Public report of ldqk/Masuit.Tools, published 12 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.3). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 12 November 2026, 02:56 UTC · Survey ID cd_823a486597a24ebaad913414652f9a30
ldqk/Masuit.Tools
Measured 12 November 2026, 02:55 UTC, at code version 88c0b42
Boundary Type-Coupling is not measured: Bounded contexts not declared.
Knowledge freshness is not measured: Freshness signal contradicted by repo activity.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
No change since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 40,956 lines of product code in 30 projects, tests not counted · Estimated rebuild effort: about 0.5 person-years · Weakest lens: Security and Compliance, 18
Findings by how serious they are
14 critical405 serious95 minor
10 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
12 November 2026, 02:55 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
65of 65 dimensions measured by tools.
496of 514 findings point to an exact file and line, so you can open each one in the code. The other 18 concern the repository as a whole, such as missing documentation.
65dimensions across 6 lenses, read from 40,956 lines of product code in 30 projects.
ldqk/Masuit.Tools falls short of our standard for production, in part because we found no access checks on the code's endpoints or handlers. It scores 32 out of 100 and is rated Weak, and three of its 14 critical findings are security problems.
Security and Compliance, at 18, is the weakest lens and counts most in the score. The best first step for the work it takes is fixing the two runtimes or frameworks that no longer get security updates, worth about 7 points. Adding access checks would lift Security and Compliance itself, worth about 8 points. Raising Security and Compliance to 70 would lift the score to about 45.
Two passwords or keys are open to anyone who can read the repository. One weakness in the code could be used by an attacker, and eight errors are caught and ignored, so failures can go unnoticed. Replacing each exposed password or key, fixing the weaknesses the scanner points to and handling or logging the ignored errors would close these risks. The two loops of parts of the code that depend on each other need breaking by moving the shared parts into a project of their own.
The product code is 40,956 lines, about €67,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Security and Compliance rose from 18 to 70, the lowest score rated Strong, the score would rise from 32 to about 45.
Code composition: what the lines of code are
Business logic 31%Supporting code 40%Tests 29%
New since the last survey: 152 findings
These 152 critical or serious findings weren't in the previous survey, on 23 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 157 findings
These 157 critical or serious findings were in the previous survey, on 23 October 2026, and are gone from this one. The first 100 are listed here.
Explicit Debt · Dead code: NullableConcurrentDictionaryTestsImpl Test/Masuit.Tools.Abstractions.Test/Systems/NullableConcurrentDictionaryTests.cs
Solution Shape · Build failed
Async correctness · Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` REDACTED
Async correctness · Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Validator/IsEmailAttribute.cs
Cancellation propagation · Async method without CancellationToken: NoLock Masuit.Tools.Core/Database/DbContextExt.cs
Cancellation propagation · Async method without CancellationToken: ExecuteStrategy Masuit.Tools.Core/Database/DbContextExt.cs
Cancellation propagation · Async method without CancellationToken: ExecuteStrategyAsync Masuit.Tools.Core/Database/DbContextExt.cs
Cancellation propagation · Async method without CancellationToken: SelectManyAsync Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Cancellation propagation · Async method without CancellationToken: SelectManyAsync Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs
Rebuild cost: about €67,000 · Estimate
Cost to rebuild
€22,000 to €110,000, for 368 to 1,188 hours of work, about 0.5 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 32. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 40,956 lines of product code, of which 29% is declarations and boilerplate, 27% straight logic and 44% logic with branches
Comment lines
The estimate prices 31,674 lines. Comment lines count towards the size of 40,956 lines but aren't priced as work.
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 2 End-of-life runtime finding(s) in Platform End-of-Life — start with Masuit.Tools.Net45.csproj, Masuit.Tools.Net.csproj.
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.
Raises the score by about 8 points · Medium effort · Access Controls
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €67,000 to build again, about 0.5 person-years of work. Its weakest lens is Security and Compliance, at 18 (Critical). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Resolve the 2 End-of-life runtime finding(s) in Platform End-of-Life. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for low effort, because it clears the 2 Platform End-of-Life findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
48 modules, with 21 dependencies between them. 2 loops run through 4 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 8 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
4 pairs of types, where a type in Masuit.Tools.AspNetCore.ResumeFileResults.Executor uses a type in Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult.
Masuit.Tools.AspNetCore.ResumeFileResults.Executor uses Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult, so a change to Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult can break Masuit.Tools.AspNetCore.ResumeFileResults.Executor, while a change to Masuit.Tools.AspNetCore.ResumeFileResults.Executor can't break Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult.
Position
Below the diagonal: Masuit.Tools.AspNetCore.ResumeFileResults.Executor uses a module listed above it, which is the healthy direction.
5 pairs of types, where a type in Masuit.Tools.AspNetCore.ResumeFileResults.Extensions uses a type in Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult.
Masuit.Tools.AspNetCore.ResumeFileResults.Extensions uses Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult, so a change to Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult can break Masuit.Tools.AspNetCore.ResumeFileResults.Extensions, while a change to Masuit.Tools.AspNetCore.ResumeFileResults.Extensions can't break Masuit.Tools.AspNetCore.ResumeFileResults.ResumeFileResult.
Position
Below the diagonal: Masuit.Tools.AspNetCore.ResumeFileResults.Extensions uses a module listed above it, which is the healthy direction.
Masuit.Tools.Dynamics.Behaviors uses Masuit.Tools.Dynamics, so a change to Masuit.Tools.Dynamics can break Masuit.Tools.Dynamics.Behaviors, while a change to Masuit.Tools.Dynamics.Behaviors can't break Masuit.Tools.Dynamics.
Position
Below the diagonal: Masuit.Tools.Dynamics.Behaviors uses a module listed above it, which is the healthy direction.
Masuit.Tools.Dynamics.Implementation uses Masuit.Tools.Dynamics, so a change to Masuit.Tools.Dynamics can break Masuit.Tools.Dynamics.Implementation, while a change to Masuit.Tools.Dynamics.Implementation can't break Masuit.Tools.Dynamics.
Position
Below the diagonal: Masuit.Tools.Dynamics.Implementation uses a module listed above it, which is the healthy direction.
220 pairs of types, where a type in Masuit.Tools.Files.FileDetector.Detectors uses a type in Masuit.Tools.Files.FileDetector. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Masuit.Tools.Files.FileDetector.Detectors uses Masuit.Tools.Files.FileDetector, so a change to Masuit.Tools.Files.FileDetector can break Masuit.Tools.Files.FileDetector.Detectors, while a change to Masuit.Tools.Files.FileDetector.Detectors can't break Masuit.Tools.Files.FileDetector.
Position
Below the diagonal: Masuit.Tools.Files.FileDetector.Detectors uses a module listed above it, which is the healthy direction.
Masuit.Tools.Hardware uses Masuit.Tools.Abstractions.Hardware, so a change to Masuit.Tools.Abstractions.Hardware can break Masuit.Tools.Hardware, while a change to Masuit.Tools.Hardware can't break Masuit.Tools.Abstractions.Hardware.
Position
Below the diagonal: Masuit.Tools.Hardware uses a module listed above it, which is the healthy direction.
Masuit.Tools.Mvc.ActionResults uses Masuit.Tools.Mvc.Internal, so a change to Masuit.Tools.Mvc.Internal can break Masuit.Tools.Mvc.ActionResults, while a change to Masuit.Tools.Mvc.ActionResults can't break Masuit.Tools.Mvc.Internal.
Position
Below the diagonal: Masuit.Tools.Mvc.ActionResults uses a module listed above it, which is the healthy direction.
31→33 Masuit.Tools.Strings uses Masuit.Tools.Systemspart of a loop✕
Connections
1 pair of types, where a type in Masuit.Tools.Strings uses a type in Masuit.Tools.Systems.
Masuit.Tools.Strings uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Strings, while a change to Masuit.Tools.Strings can't break Masuit.Tools.Systems.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Masuit.Tools.Mvc uses Masuit.Tools.Mvc.ActionResults, so a change to Masuit.Tools.Mvc.ActionResults can break Masuit.Tools.Mvc, while a change to Masuit.Tools.Mvc can't break Masuit.Tools.Mvc.ActionResults.
Position
Below the diagonal: Masuit.Tools.Mvc uses a module listed above it, which is the healthy direction.
Masuit.Tools.Systems uses (global), so a change to (global) can break Masuit.Tools.Systems, while a change to Masuit.Tools.Systems can't break (global).
Position
Below the diagonal: Masuit.Tools.Systems uses a module listed above it, which is the healthy direction.
Masuit.Tools.Systems uses Masuit.Tools.Strings, so a change to Masuit.Tools.Strings can break Masuit.Tools.Systems, while a change to Masuit.Tools.Systems can't break Masuit.Tools.Strings.
Position
Below the diagonal: Masuit.Tools.Systems uses a module listed above it, which is the healthy direction.
Masuit.Tools uses Masuit.Tools.RandomSelector, so a change to Masuit.Tools.RandomSelector can break Masuit.Tools, while a change to Masuit.Tools can't break Masuit.Tools.RandomSelector.
Position
Below the diagonal: Masuit.Tools uses a module listed above it, which is the healthy direction.
Masuit.Tools uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools, while a change to Masuit.Tools can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools uses a module listed above it, which is the healthy direction.
Masuit.Tools.Excel uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Excel, while a change to Masuit.Tools.Excel can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools.Excel uses a module listed above it, which is the healthy direction.
Masuit.Tools.Files uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Files, while a change to Masuit.Tools.Files can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools.Files uses a module listed above it, which is the healthy direction.
Masuit.Tools.Media uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Media, while a change to Masuit.Tools.Media can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools.Media uses a module listed above it, which is the healthy direction.
Masuit.Tools.Mime uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Mime, while a change to Masuit.Tools.Mime can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools.Mime uses a module listed above it, which is the healthy direction.
Masuit.Tools.Models uses Masuit.Tools.Maths, so a change to Masuit.Tools.Maths can break Masuit.Tools.Models, while a change to Masuit.Tools.Models can't break Masuit.Tools.Maths.
Position
Below the diagonal: Masuit.Tools.Models uses a module listed above it, which is the healthy direction.
Masuit.Tools.Models uses Masuit.Tools.Systems, so a change to Masuit.Tools.Systems can break Masuit.Tools.Models, while a change to Masuit.Tools.Models can't break Masuit.Tools.Systems.
Position
Below the diagonal: Masuit.Tools.Models uses a module listed above it, which is the healthy direction.
39→40 Masuit.Tools.Models uses Masuit.Tools.DateTimeExtpart of a loop✕
Connections
1 pair of types, where a type in Masuit.Tools.Models uses a type in Masuit.Tools.DateTimeExt.
Masuit.Tools.Models uses Masuit.Tools.DateTimeExt, so a change to Masuit.Tools.DateTimeExt can break Masuit.Tools.Models, while a change to Masuit.Tools.Models can't break Masuit.Tools.DateTimeExt.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Masuit.Tools.DateTimeExt uses Masuit.Tools.Models, so a change to Masuit.Tools.Models can break Masuit.Tools.DateTimeExt, while a change to Masuit.Tools.DateTimeExt can't break Masuit.Tools.Models.
Position
Below the diagonal: Masuit.Tools.DateTimeExt uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 50% · Adequate · gated by X5 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
14
High / Critical
A07:2025 — Authentication Failures
3
High / Critical
A02:2025 — Security Misconfiguration
1
Medium
Roadmap
Top priorities: Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler; Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 11 sites, not one: `Masuit.Tools.Abstractions/Files/FileExt.cs:118` (SHA1), `Masuit.Tools.Abstractions/Files/FileExt.cs:121` (MD5), `REDACTED:1026` (MD5), `REDACTED:1046` (MD5), `REDACTED:1078` (MD5), `REDACTED:1098` (MD5), `REDACTED:1137` (MD5), `Masuit.Tools.Abstractions/Security/RSACrypt.cs:169` (MD5), and 3 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place; Resolve the 2 End-of-life runtime finding(s) in Platform End-of-Life — start with Masuit.Tools.Net45.csproj, Masuit.Tools.Net.csproj.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 2 End-of-life runtime finding(s) in Platform End-of-Life — start with Masuit.Tools.Net45.csproj, Masuit.Tools.Net.csproj.
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 11 sites, not one: `Masuit.Tools.Abstractions/Files/FileExt.cs:118` (SHA1), `Masuit.Tools.Abstractions/Files/FileExt.cs:121` (MD5), `REDACTED:1026` (MD5), `REDACTED:1046` (MD5), `REDACTED:1078` (MD5), `REDACTED:1098` (MD5), `REDACTED:1137` (MD5), `Masuit.Tools.Abstractions/Security/RSACrypt.cs:169` (MD5), and 3 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Code Duplication: Members sharing a duplicated core (4 members, 50+ identical tokens)
How the grades work
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 14
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 405
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 95
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 10
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 65 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 65 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 496 of 514 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the analyzer environment could not build/run the test suite (a target framework / SDK band or targeting pack the analyzer image doesn't carry). This is OUR limitation, not a defect in the repo — coverage is excluded from the score rather than counted as a near-zero. We track the analyzer-image gap so it can be closed; in the meantime, your test projects already reference a coverage collector, but no CI step we found runs the tests with it, so there is no report to hand us — run them with `--collect:"XPlat Code Coverage"` and commit (or publish into the working tree) the coverage.cobertura.xml it writes, and real coverage will be read. You can widen what we reach: optional: your test projects already reference a coverage collector, but no CI step we found runs the tests with it, so there is no report to hand us — run them with `--collect:"XPlat Code Coverage"` and commit (or publish into the working tree) the coverage.cobertura.xml it writes, and the real number is read on the next scan.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: the analyzer environment could not build/run the test suite (a target framework / SDK band or targeting pack the analyzer image doesn't carry), so no test ever ran. This is OUR limitation, not a defect in the repo — it is excluded from the score. We track the analyzer-image gap so it can be closed.
D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: /usr/share/dotnet/sdk/10.0.400/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(184,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 11.0. Either target .NET 10.0 or lower, or use a version of the .NET SDK that supports .NET 11.0. Download the ….
D18 Solution Shape — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (40,956 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D24 compares a comment's words with the identifiers, literals and constructs of the code it annotates, using English function-word and rationale lexicons. Comments in another script or language were left unread rather than counted as clean.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `Masuit.Tools.Abstractions/Config/CoreConfig.cs`, `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/ArrayBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/InterfaceProxyBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Clay.cs`, … (+21 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D34 Knowledge Freshness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. File-level freshness contradicts repo activity: 48 commits in the last 90 days, yet 100 of 125 significant files carry no living knowledge. Those two readings cannot both be true, so the per-file recency signal is treated as unreliable here and freshness is not scored for this run.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
P8 Schema migrations — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Every other migration runner — DbUp, FluentMigrator, Evolve, Flyway, Liquibase, RoundhousE, a hand-rolled versioned-SQL runner — is invisible to the detector, so an absence here is our blind spot rather than a missing migration strategy in the repository. The card abstains instead of scoring. You can widen what we reach: if the schema is created and evolved by a tool other than EF Core migrations, naming it lets us teach the detector to read it.
PF3 Async & latency hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 79 further occurrence(s) are not listed individually; the score already reflects all 119.
Package restore incomplete — third-party types were unresolved in part of the solution — NuGet restore did not complete for Masuit.Tools/Masuit.Tools.Net.csproj, Masuit.Tools.Core/Masuit.Tools.Core.csproj, Masuit.Tools.Abstractions/Masuit.Tools.Abstractions.csproj, Test/Masuit.Tools.Core.Test/Masuit.Tools.Core.Test.csproj, Test/Masuit.Tools.Abstractions.Test/Masuit.Tools.Abstractions.Test.csproj and 8 more, so those projects were analysed with framework references only: every check keyed on a third-party type saw an error type there and reported nothing. Findings on those projects are a lower bound; run `dotnet restore` on them and rescan.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
22 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ImageDetectExt.GetImageType at 61. A further 3 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being DataTableHelper.ConvertType at 25 — they are counted neither in the figure above nor in this dimension's score. 2 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: Masuit.Tools.Abstractions/Database/DataTableHelper.cs (DataTableHelper.ConvertType at 25), Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs (ObjectExtensions.IsDefaultValue at 21). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 17 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 4 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with ImageDetectExt.GetImageType (cyclomatic 61), FromBodyOrDefaultModelBinder.BindModelAsync (cyclomatic 35), DiffAlgorithm.MyersDiffBisect (cyclomatic 33). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 4 together lifts Cyclomatic Complexity from 6.8 to about 7.5/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 38 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 60 down to 60 or less in Cognitive Complexity — start with FromBodyOrDefaultModelBinder.BindModelAsync (cognitive 125). — Refactoring it lifts Cognitive Complexity from 5.8 to about 6.5/10.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.1 / 10Stronggated by 9 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 4 TooManyMethods finding(s) in God Classes — start with MongoDbClient.cs, SystemInfo.cs, ConcurrentList.cs. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 3 FileTooLong finding(s) in God Classes — start with AbstractCompoundFileDetailDetector.cs, REDACTED, ChineseCalendar.cs. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 2 ClassTooLong finding(s) in God Classes — start with ChineseCalendar.cs, DefaultMimeItems.cs. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
79 duplicated block group(s) detected. A further 329 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×5Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:797
+ 57 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 17 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with NullableConcurrentDictionary.cs (8), IDictionaryExtensions.cs (2), ImageUtilities.cs (2). — One of this dimension's main actionable groups (17 warning-level).
Resolve the 14 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with NullableConcurrentDictionary.cs (8), IQueryableExt.cs, ExcelExtension.cs. — One of this dimension's main actionable groups (14 warning-level).
Resolve the 8 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with LogManager.cs (3), IEnumerableExtensions.cs (2), DbContextExt.cs. — One of this dimension's main actionable groups (8 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
D10 · Test Quality10.0 / 10Stronggated by 2 serious findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
0 skipped, 2 zero-assertion, 2 mock references across 1006 tests.
No assertions: InvokeMethod_ShouldInvokeMethodWithoutReturn · ×2Test/Masuit.Tools.Abstractions.Test/Refection/ReflectionUtilTests.cs:26
Mock framework: Moq · ×2
What to do
Resolve the 2 No assertions finding(s) in Test Quality — start with ReflectionUtilTests.cs, DisposableDictionaryTests.cs. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 272 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 44 direct `PackageReference`(s), and 195 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 2 Hotspot finding(s) in Churn × Complexity Hotspots — start with ImageBorderRemover.cs, ExcelExtension.cs. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor8.0 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
24 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is REDACTED. Counted over 122 of the 367 production source files in this repository: 242 are under the ~2,400-byte size floor this dimension measures over, and the remaining 3 have no attributable history left to measure.
Off-boarding risk: anonymized user #1
What to do
Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
Resolve the 8 EmptyCatchBlock finding(s) in Explicit Debt — start with CoreConfig.cs, ConfigurationDetector.cs, SystemInfo.cs. — One of this dimension's main actionable groups (8 issue-level).
Resolve the 1 WriteOnlyPrivateField finding(s) in Explicit Debt — start with PartialDownloader.cs. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 10 Dead code finding(s) in Explicit Debt — start with Arguments.cs (4), ConcurrentHashQueue.cs (2), HashQueue.cs (2). — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
30 projects, 2288 source files, 53825 hand-written lines of code (40956 production / 12869 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 23 inter-project edges (build status unknown — did not finish).
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
Resolve the 2 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with Masuit.Tools.Abstractions.csproj, Masuit.Tools.Net45.csproj. — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 1 Split Masuit.Tools.Abstractions(netstandard2.0) finding(s) in Project Cohesion — start with Masuit.Tools.Abstractions.csproj. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
2 finding(s): 0 critical, 2 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
14 finding(s): 0 critical, 1 high, 13 medium, 0 low. semgrep hit a parse error in 27 file(s) — `Masuit.Tools.Abstractions/Config/CoreConfig.cs` (lines 32–40), `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs` (line 15), `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/ArrayBehavior.cs` (lines 115–116, line 149), `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/InterfaceProxyBehavior.cs` (lines 39–40, lines 114–125, line 215), `Masuit.Tools.Abstractions/Extensions/Dynamics/Clay.cs` (line 10), … (+22 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 21 of those file(s) — `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/ArrayBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/InterfaceProxyBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Clay.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/ClayBehaviorCollection.cs`, … (+16 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 2 of those file(s) — `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs`, `Masuit.Tools.Abstractions/TextDiff/PatchExtension.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 9 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (9). — One of this dimension's main actionable groups (9 warning-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (REDACTED or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a REDACTED (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
A vulnerability-disclosure policy (REDACTED) is present but lists no reporting contact.
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Vulnerability-disclosure Policy — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d37_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
2 end-of-life runtime(s) and 0 end-of-life framework(s), read from 16 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Resolve the 2 End-of-life runtime finding(s) in Platform End-of-Life — start with Masuit.Tools.Net45.csproj, Masuit.Tools.Net.csproj. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`CacheHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (dic; e.g. `dic` at line 108). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools/Net/CacheHelper.cs:11
`ConfigHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Configuration; e.g. `Configuration` at line 160). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Config/CoreConfig.cs:47
`SystemInfo` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_diskInfos; e.g. `_diskInfos` at line 580). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:20
`LogManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_logDirectory; e.g. `_logDirectory` at line 80). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Logging/LogManager.cs:16
`DctHasher` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_valuesBuffer; e.g. `_valuesBuffer` at line 135). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Media/DctHasher.cs:7
`InstanceCreationFactory` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InstanceCreationMethods; e.g. `InstanceCreationMethods` at line 490). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Reflection/ReflectionUtil.cs:455
`Crc32` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_defaultTable; e.g. `_defaultTable` at line 104). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Security/Crc32.cs:13
`Crc64` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Table; e.g. `Table` at line 137). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Security/Crc64.cs:13
`RC2Crypt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_iv, _key; e.g. `_iv` at line 1542). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — REDACTED:1173
`RsaCrypt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (RsaKey; e.g. `RsaKey` at line 30). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Security/RSACrypt.cs:11
`EnumExt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_enumTypeDict; e.g. `_enumTypeDict` at line 55). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Systems/EnumExt.cs:15
`SnowFlake` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_snowFlake, _machineId, _numberFormater, _offset; e.g. `_snowFlake` at line 55). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Systems/SnowFlake.cs:15
`SnowFlakeNew` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_snowFlake, _workerId, _offset, _numberFormater; e.g. `_snowFlake` at line 42). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:13
`WindowsServer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_instance; e.g. `_instance` at line 229). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Masuit.Tools.Abstractions/Win32/Windows.cs:167
What to do
A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces Masuit.Tools.Strings ↔ Masuit.Tools.Systems depend on each other. The lightest dependency in the cycle is Masuit.Tools.Strings → Masuit.Tools.Systems (Masuit.Tools.Strings.ValidateCode → Masuit.Tools.Systems.PooledMemoryStream, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — Masuit.Tools.Abstractions/Strings/ValidateCode.cs:3
The namespaces Masuit.Tools.DateTimeExt ↔ Masuit.Tools.Models depend on each other. The lightest dependency in the cycle is Masuit.Tools.DateTimeExt → Masuit.Tools.Models (Masuit.Tools.DateTimeExt.DateTimeHelper → Masuit.Tools.Models.DateTimeRange, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — Masuit.Tools.Abstractions/DateTimeExt/DateTimeHelper.cs:7
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
No [Authorize]/policies and no imperative guard methods (throw-on-violation) were found — endpoints may be unprotected.
`HomeController.Test` serves requests and nothing authorizes it: no [Authorize] or RequireAuthorization on it or its controller/group, no fallback policy, no auth-gate middleware and no imperative guard in this codebase. — NetCoreTest/Controllers/HomeController.cs:12
What to do
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×6) — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:90, Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:114, Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:131, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
The first 1 statement of the `if` and of the `else` are identical, so it runs on both paths regardless of the condition. Lift it above the `if` — leaving it duplicated inside makes the branches read as though they handled this differently. — Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:352
`BindDeleteMember` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:90
`BindDeleteIndex` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:114
`BindCreateInstance` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:131
`BindUnaryOperation` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:137
`GetDynamicMemberNames` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:151
`Write` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:1042
The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently. — Masuit.Tools.Excel/ExcelExtension.cs:142
`Test` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — NetCoreTest/Controllers/HomeController.cs:10
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×8) — REDACTED:889, REDACTED:890, REDACTED:893, …
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Describe the projects a newcomer cannot place from the root README: 7 of 8 have no README of their own, in their folder or in their family's project (`Masuit.Tools`, `Masuit.Tools.Core`, `Masuit.Tools.NoSQL.MongoDBClient`, `Masuit.Tools.Abstractions`, `Masuit.Tools.Excel` and 2 more).
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Do you agree with this assessment?
P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
What to do
Add a CI workflow that builds and runs the test suite on every push/PR.
Do you agree with this assessment?
P10 · Library API & versioning9.3 / 10Exemplary✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
2 public types in `Masuit.Tools.Mvc.Internal` are marked as implementation by their own namespace, folder or name: `ByteRange` (Masuit.Tools/Mvc/Internal/ByteRange.cs:5, `Internal`), `ByteRange` (Masuit.Tools/Mvc/Internal/ByteRange.cs:5, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — Masuit.Tools/Mvc/Internal/ByteRange.cs:5
`Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5
`Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5
`Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5
`Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5
`Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8
`Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7
`Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7
What to do
Hide `Masuit.Tools.Mvc.Internal` (`ByteRange`, `ByteRange`) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Make `Masuit.Tools.Dynamics.DynamicFactory` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Dynamics.DynamicFactory` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Dynamics.DynamicFactory` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Dynamics.DynamicFactory` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Dynamics.DynamicFactory` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Do you agree with this assessment?
P2 · Observability5.0 / 10Adequate✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 2/6 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 6, 1 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
What to do
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Consider OpenTelemetry tracing/metrics and a health-check endpoint for operability.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
`BenchmarkTest/BenchmarkTest.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — BenchmarkTest/BenchmarkTest.csproj:10
What to do
Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`services.AddHttpClient<ISevenZipCompressor, SevenZipCompressor>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — Masuit.Tools.AspNetCore/AspNetCore/ServiceCollectionExtensions.cs:39
What to do
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
2 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×2) — Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:207, Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:344
Only 8/123 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
`await q.ToListAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:236
`await q.CountAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:264
`await q.CountAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:292
`await q.AnyAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:320
`await q.AnyAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:348
`await q.FirstOrDefaultAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:376
`await q.FirstOrDefaultAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:404
`await q.SingleOrDefaultAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:432
`await q.SingleOrDefaultAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:460
`await q.AllAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:488
`await func(dbContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Database/DbContextExt.cs:534
`await query.CountAsync(cancellationToken: cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. (×2) — Masuit.Tools.Core/Models/IQueryableExt.cs:18, Masuit.Tools.Core/Models/IQueryableExt.cs:43
`await query.Skip(size * (page - 1)).Take(size).ToListAsync(cancellationToken: cance...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Models/IQueryableExt.cs:29
`await query.Skip(size * (page - 1)).Take(size).ToListWithNoLockAsync(cancellationTo...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.Core/Models/IQueryableExt.cs:54
`await Database.GetCollection<T>(collection).BulkWriteAsync(list, cancellationToken:...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:190
`await Database.GetCollection<BsonDocument>(collection).BulkWriteAsync(list, cancell...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:202
`await Database.GetCollection<T>(collection).UpdateOneAsync(filter, update, new Upda...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:254
`await Database.GetCollection<BsonDocument>(collection).UpdateOneAsync(filter, updat...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:270
`await Database.GetCollection<T>(collName).UpdateManyAsync(filter, update, new Updat...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:321
`await Database.GetCollection<BsonDocument>(collName).UpdateManyAsync(filter, update...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:338
`await Database.GetCollection<T>(collection).DeleteOneAsync(document, cancellationTo...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:457
`await Database.GetCollection<T>(collection).DeleteManyAsync(document, cancellationT...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:469
`await Database.GetCollection<BsonDocument>(collection).DeleteOneAsync(document, can...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:481
`await Database.GetCollection<BsonDocument>(collection).DeleteManyAsync(document, ca...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:493
`await Database.GetCollection<T>(collName).DeleteOneAsync(json)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:553
`await Database.GetCollection<T>(collName).DeleteManyAsync(json, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:565
`await Database.GetCollection<BsonDocument>(collName).DeleteOneAsync(json, cancellat...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:577
`await Database.GetCollection<BsonDocument>(collName).DeleteManyAsync(json, cancella...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:589
`await Database.GetCollection<T>(collName).DeleteOneAsync(predicate, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:649
`await Database.GetCollection<T>(collName).DeleteManyAsync(predicate, cancellationTo...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:661
`await Database.GetCollection<BsonDocument>(collName).DeleteOneAsync(predicate, canc...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:673
`await Database.GetCollection<BsonDocument>(collName).DeleteManyAsync(predicate, can...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:685
`await Database.GetCollection<T>(collName).DeleteOneAsync(filter, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:750
`await Database.GetCollection<T>(collName).DeleteManyAsync(filter, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:763
`await Database.GetCollection<BsonDocument>(collName).DeleteOneAsync(filter, cancell...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:776
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
In library code, append .ConfigureAwait(false) to every await (or set <ConfigureAwait>false</ConfigureAwait> / use the analyzer CA2007) so the library never captures the host's context.
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. (×11) — Masuit.Tools.Abstractions/Files/FileExt.cs:118, Masuit.Tools.Abstractions/Files/FileExt.cs:121, REDACTED:1026, …
This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages. (×2) — REDACTED:65, REDACTED:182
DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes. (×8) — REDACTED:31, REDACTED:49, REDACTED:69, …
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves. — NetCoreTest/Program.cs:4
No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it. — NetCoreTest/Program.cs:4
No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.) — Masuit.Tools/Mvc/HttpHeaders.cs:60
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 11 sites, not one: `Masuit.Tools.Abstractions/Files/FileExt.cs:118` (SHA1), `Masuit.Tools.Abstractions/Files/FileExt.cs:121` (MD5), `REDACTED:1026` (MD5), `REDACTED:1046` (MD5), `REDACTED:1078` (MD5), `REDACTED:1098` (MD5), `REDACTED:1137` (MD5), `Masuit.Tools.Abstractions/Security/RSACrypt.cs:169` (MD5), and 3 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Generate a fresh random IV for every encryption with `RandomNumberGenerator.Fill` and store or transmit it next to the ciphertext, rather than fixing it in the source or deriving it from the key material — a derived IV is constant, because its inputs do not vary between messages. An IV need not be secret, only unpredictable and unique per message; under CTR/GCM a repeated nonce is catastrophic rather than merely leaky. This repository constructs an initialisation vector that does not vary per message at 2 sites, not one: `REDACTED:65` (a compile-time constant), `REDACTED:182` (a compile-time constant). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Replace DES/3DES (and bare RijndaelManaged) with AES-GCM via `Aes.Create()`. This repository constructs a broken or deprecated cipher at 8 sites, not one: `REDACTED:31` (DES), `REDACTED:49` (DES), `REDACTED:69` (DES), `REDACTED:84` (DES), `REDACTED:100` (DES), `REDACTED:115` (DES), `REDACTED:134` (DES), `REDACTED:152` (DES). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
Enforce HTTPS at the app layer (UseHttpsRedirection / UseHsts) — only skip this if a reverse proxy demonstrably terminates TLS.
Set secure cookie flags — CookieSecurePolicy.Always, HttpOnly, and SameSite (Strict/Lax) on auth/session cookies. Skip only if the app sets no cookies.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×2) — Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:196, Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:344
Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×3) — Masuit.Tools.Abstractions/Html/HtmlTools.cs:107, Masuit.Tools.Abstractions/Html/HtmlTools.cs:140, Masuit.Tools.AspNetCore/ModelBinder/ModelBindingContextExtension.cs:53
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream3.5 / 10Weak✓ Tool-verified
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
`RedirectStandardError` is set here, but `StandardError` is not being read when `StandardOutput` is read to the end — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardError pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginErrorReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume. — REDACTED:159
`RedirectStandardOutput` is set here, but `StandardOutput` is not being read when the code waits for the child to exit — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardOutput pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginOutputReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume. — Masuit.Tools.Abstractions/Win32/WindowsCommand.cs:26
What to do
Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
This method unwraps IPv4-MAPPED IPv6 (`IsIPv4MappedToIPv6`, line 16) and rejects `10.0.0.0/8` on its IPv4 path, and it handles some IPv4-in-IPv6 embeddings — but not IPv4-compatible (`::a.b.c.d`) and 6to4 (`2002::/16`) and NAT64 (`64:ff9b::/96`): either it never names it, or it names it and returns the verdict its IPv4 path gives public space. So `::10.0.0.1`, `2002:0a00:0001::`, `64:ff9b::10.0.0.0` name a host inside `10.0.0.0/8`, the range this same method declares non-public, and reach the IPv6 branch at line 30 with the opposite verdict. Unwrap every embedding to its IPv4 form before classifying, or reject any IPv6 address carrying an embedded IPv4 outright. — Masuit.Tools.Abstractions/Extensions/BaseType/IPAddressExtensions.cs:30
What to do
Each finding names the IPv4 branch that rejects the host and the IPv6 branch that accepts the same host in another notation. Confirm from the two, then unwrap every IPv4-in-IPv6 embedding before classifying, or reject non-native IPv6 outright.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`Crc32` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Security/Crc32.cs:15
`Crc64` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Security/Crc64.cs:15
`ConcurrentHashSet` declares a finalizer (line 391), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/ConcurrentHashSet.cs:391
`ConcurrentLinkedList` declares a finalizer (line 424), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/ConcurrentLinkedList.cs:424
`ConcurrentList` declares a finalizer (line 573), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/ConcurrentList.cs:573
`Disposable` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/Disposable.cs:15
`DisposableConcurrentDictionary` declares a finalizer (line 19), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/DisposableConcurrentDictionary.cs:19
`DisposableDictionary` declares a finalizer (line 19), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/DisposableDictionary.cs:19
`LargeMemoryStream` declares a finalizer (line 16), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/LargeMemoryStream.cs:16
`PooledMemoryStream` declares a finalizer (line 18), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — Masuit.Tools.Abstractions/Systems/PooledMemoryStream.cs:18
`yRoi` is a `Mat`, which implements `IDisposable`, and it is created here (line 45). Every use of it in `EmbedWatermark` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var yRoi = …;`), which releases it at the end of the scope on every path including a throw. — Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:45
`yRoi` is a `Mat`, which implements `IDisposable`, and it is created here (line 129). Every use of it in `ExtractWatermark` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var yRoi = …;`), which releases it at the end of the scope on every path including a throw. — Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:129
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 54/71 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×17) — Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:551, Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:277, Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:296, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped3.5 / 10Weak✓ Tool-verified
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
`Body` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — Masuit.Tools.Abstractions/Models/Email.cs:90
What to do
Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×8) — Masuit.Tools.Abstractions/Config/CoreConfig.cs:114, Masuit.Tools.Abstractions/Files/FileDetector/Detectors/ConfigurationDetector.cs:33, Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:258, …
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×2) — REDACTED:1550, REDACTED:1576
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:74
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. — Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:81
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `regKey`: line 18 writes `regKey?.OpenSubKey`, which says `regKey` can be null, but line 21 then dereferences it directly as `regKey.DeleteSubKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `regKey` truly cannot be null here, the `?.` is misleading. Settle it one way — test `regKey` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — Masuit.Tools/Files/ExtensionAttach.cs:21
This method contradicts itself about `regkey`: line 52 writes `regkey?.OpenSubKey`, which says `regkey` can be null, but line 55 then dereferences it directly as `regkey.DeleteSubKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `regkey` truly cannot be null here, the `?.` is misleading. Settle it one way — test `regkey` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — Masuit.Tools/Files/ExtensionAttach.cs:55
This method contradicts itself about `d`: line 751 assigns it with `as DirectoryEntry`, which hands back null rather than throwing when the value is not a `DirectoryEntry`, but line 752 then dereferences it directly as `d.StgType` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `d` once before the first use and handle the null case, or cast with `(DirectoryEntry)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:752
This method contradicts itself about `resp`: line 373 assigns it with `as HttpWebResponse`, which hands back null rather than throwing when the value is not a `HttpWebResponse`, but line 374 then dereferences it directly as `resp.ResponseUri` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `resp` once before the first use and handle the null case, or cast with `(HttpWebResponse)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:374
This method contradicts itself about `email`: line 22 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 23 then dereferences it directly as `email.MatchInetAddress` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `email` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Validator/IsIPAddressAttribute.cs:23
This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchPhoneNumber` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Validator/IsPhoneAttribute.cs:50
This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchLandline` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Validator/LandlineAttribute.cs:50
This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchUSCC` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Masuit.Tools.Abstractions/Validator/UnifiedSocialCreditCodeAttribute.cs:50
0/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 4 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X6 Hand-rolled structured-format parsing — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 32 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 5 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 44 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AX4 Dependency direction — not applicable to a transaction-script/CRUD architecture (the inward-dependency rule is for layered/clean styles)
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
D11 Test Reliability — Test reliability not measured — analyzer environment
D12 Dependency Hygiene — Dependency hygiene not measured
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — N/A — too few peer members to establish a convention across 29 exposed C# types.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D24 Comment Value — 655 of 665 comment blocks were not judged (561 in a non-Latin script, 94 in a language other than English): redundancy is judged by word overlap with the code's identifiers, which cannot be measured across languages.
D25 ADR Conformance — no ADRs to check
D27 Navigability — symbol resolution incomplete — navigability not assessed
D30 Dependency Vulnerabilities — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 26 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D34 Knowledge Freshness — knowledge concentrated in recent work — freshness signal contradicted by repo activity
D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage not measured — analyzer environment
DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (36 value object(s))
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — no CI workflow found
P8 Schema migrations — EF Core is used, but the schema-migration mechanism could not be identified — this check only recognises EF migrations, so any other migration runner reads as an absence. Our limit, not a verdict on this repository.
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock Masuit.Tools.Abstractions/Config/CoreConfig.cs:114— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Files/FileDetector/Detectors/ConfigurationDetector.cs:33— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:258— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Logging/LogManager.cs:451— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:311— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Security/RSA.cs:164— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:44— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Masuit.Tools.Abstractions/Win32/Windows.cs:59— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
Namespace dependency cycle Masuit.Tools.Abstractions/Strings/ValidateCode.cs:3— The namespaces Masuit.Tools.Strings ↔ Masuit.Tools.Systems depend on each other. The lightest dependency in the cycle is Masuit.Tools.Strings → Masuit.Tools.Systems (Masuit.Tools.Strings.ValidateCode → Masuit.Tools.Systems.PooledMemoryStream, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle Masuit.Tools.Abstractions/DateTimeExt/DateTimeHelper.cs:7— The namespaces Masuit.Tools.DateTimeExt ↔ Masuit.Tools.Models depend on each other. The lightest dependency in the cycle is Masuit.Tools.DateTimeExt → Masuit.Tools.Models (Masuit.Tools.DateTimeExt.DateTimeHelper → Masuit.Tools.Models.DateTimeRange, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
WriteOnlyPrivateField Masuit.Tools.Abstractions/Net/PartialDownloader.cs:36— private bool _wait — assigned 2 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Awaits without ConfigureAwait(false) — Only 8/123 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:236— `await q.ToListAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:264— `await q.CountAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:292— `await q.CountAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:320— `await q.AnyAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:348— `await q.AnyAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:376— `await q.FirstOrDefaultAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:404— `await q.FirstOrDefaultAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:432— `await q.SingleOrDefaultAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:460— `await q.SingleOrDefaultAsync(cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:488— `await q.AllAsync(where, cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Database/DbContextExt.cs:534— `await func(dbContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Models/IQueryableExt.cs:18— `await query.CountAsync(cancellationToken: cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Models/IQueryableExt.cs:29— `await query.Skip(size * (page - 1)).Take(size).ToListAsync(cancellationToken: cance...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Models/IQueryableExt.cs:43— `await query.CountAsync(cancellationToken: cancellationToken)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.Core/Models/IQueryableExt.cs:54— `await query.Skip(size * (page - 1)).Take(size).ToListWithNoLockAsync(cancellationTo...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:190— `await Database.GetCollection<T>(collection).BulkWriteAsync(list, cancellationToken:...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:202— `await Database.GetCollection<BsonDocument>(collection).BulkWriteAsync(list, cancell...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:254— `await Database.GetCollection<T>(collection).UpdateOneAsync(filter, update, new Upda...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:270— `await Database.GetCollection<BsonDocument>(collection).UpdateOneAsync(filter, updat...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:321— `await Database.GetCollection<T>(collName).UpdateManyAsync(filter, update, new Updat...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:338— `await Database.GetCollection<BsonDocument>(collName).UpdateManyAsync(filter, update...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:457— `await Database.GetCollection<T>(collection).DeleteOneAsync(document, cancellationTo...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:469— `await Database.GetCollection<T>(collection).DeleteManyAsync(document, cancellationT...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:481— `await Database.GetCollection<BsonDocument>(collection).DeleteOneAsync(document, can...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Duplicated block (5 lines × 2) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1052— Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1052-1056 | Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1146-1150 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1052` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:746— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:746-750 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:764-771 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:872— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:872-876 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:890-897 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/EnumExt.cs:111— Masuit.Tools.Abstractions/Systems/EnumExt.cs:111-115 | Masuit.Tools.Abstractions/Systems/EnumExt.cs:160-169 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Systems/EnumExt.cs:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:717— Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:717-721 | Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:750-754 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:717` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Models/LoanModel.cs:106— Masuit.Tools.Abstractions/Models/LoanModel.cs:106-110 | Masuit.Tools.Abstractions/Models/LoanModel.cs:167-171 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Models/LoanModel.cs:106` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) Masuit.Tools.Net45/Media/ImageUtilities.cs:182— Masuit.Tools.Net45/Media/ImageUtilities.cs:182-186 | Masuit.Tools.Net45/Media/ImageUtilities.cs:247-251 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) Masuit.Tools.Net45/Media/ImageUtilities.cs:525— Masuit.Tools.Net45/Media/ImageUtilities.cs:525-531 | Masuit.Tools.Net45/Media/ImageUtilities.cs:926-930 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Net45/Media/ImageUtilities.cs:525` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:53— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:53-57 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:69-73 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:73— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:73-77 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:89-93 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:93— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:93-97 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:109-113 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:113— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:113-117 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:129-133 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:53— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:53-57 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:69-73 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:73— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:73-77 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:89-93 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:93— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:93-97 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:109-113 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:113— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:113-117 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:129-133 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:68— Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:68-72 | Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:121-125 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `binder` to `InvokeMemberBinder` in one and `InvokeBinder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
X2 · Cancellation propagation· Async method without CancellationToken · ×17
Async method without CancellationToken: DeleteAsync Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:551— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:277— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:296— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:315— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:373— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:392— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AddOrUpdateAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:411— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetOrAddAsync Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:588— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadAllLinesAsync Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:208— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadAllLinesAsync Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:231— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadAllTextAsync Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:262— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: WriteAllTextAsync Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:289— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: WriteAllLinesAsync Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:317— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: SaveFileAsync Masuit.Tools.Abstractions/Files/FileExt.cs:65— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: SaveAsync Masuit.Tools.Abstractions/Files/IniFile/IniFile.cs:157— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AccumulateForm Masuit.Tools.AspNetCore/Extensions/MultipartRequestService.cs:52— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Test NetCoreTest/Controllers/HomeController.cs:12— No CancellationToken parameter — this work can't be stopped early once started.
AX2 · Stateful singletons· Process-global static state · ×14
Process-global static state: CacheHelper Masuit.Tools/Net/CacheHelper.cs:11— `CacheHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (dic; e.g. `dic` at line 108). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: ConfigHelper Masuit.Tools.Abstractions/Config/CoreConfig.cs:47— `ConfigHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Configuration; e.g. `Configuration` at line 160). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SystemInfo Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:20— `SystemInfo` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_diskInfos; e.g. `_diskInfos` at line 580). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: LogManager Masuit.Tools.Abstractions/Logging/LogManager.cs:16— `LogManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_logDirectory; e.g. `_logDirectory` at line 80). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: DctHasher Masuit.Tools.Abstractions/Media/DctHasher.cs:7— `DctHasher` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_valuesBuffer; e.g. `_valuesBuffer` at line 135). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: InstanceCreationFactory Masuit.Tools.Abstractions/Reflection/ReflectionUtil.cs:455— `InstanceCreationFactory` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InstanceCreationMethods; e.g. `InstanceCreationMethods` at line 490). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: Crc32 Masuit.Tools.Abstractions/Security/Crc32.cs:13— `Crc32` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_defaultTable; e.g. `_defaultTable` at line 104). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: Crc64 Masuit.Tools.Abstractions/Security/Crc64.cs:13— `Crc64` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Table; e.g. `Table` at line 137). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: RC2Crypt REDACTED:1173— `RC2Crypt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_iv, _key; e.g. `_iv` at line 1542). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: RsaCrypt Masuit.Tools.Abstractions/Security/RSACrypt.cs:11— `RsaCrypt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (RsaKey; e.g. `RsaKey` at line 30). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: EnumExt Masuit.Tools.Abstractions/Systems/EnumExt.cs:15— `EnumExt` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_enumTypeDict; e.g. `_enumTypeDict` at line 55). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SnowFlake Masuit.Tools.Abstractions/Systems/SnowFlake.cs:15— `SnowFlake` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_snowFlake, _machineId, _numberFormater, _offset; e.g. `_snowFlake` at line 55). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SnowFlakeNew Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:13— `SnowFlakeNew` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_snowFlake, _workerId, _offset, _numberFormater; e.g. `_snowFlake` at line 42). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: WindowsServer Masuit.Tools.Abstractions/Win32/Windows.cs:167— `WindowsServer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_instance; e.g. `_instance` at line 229). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Duplicated block (7 lines × 2) Masuit.Tools.Core/Models/IQueryableExt.cs:74— Masuit.Tools.Core/Models/IQueryableExt.cs:74-80 | Masuit.Tools.Core/Models/IQueryableExt.cs:124-130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (7 lines × 2) Masuit.Tools.Excel/ExcelExtension.cs:279— Masuit.Tools.Excel/ExcelExtension.cs:279-285 | Masuit.Tools.Excel/ExcelExtension.cs:346-352 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:228— Masuit.Tools.Abstractions/Models/TreeExtensions.cs:228-234 | Masuit.Tools.Abstractions/Models/TreeExtensions.cs:326-332 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) REDACTED:1358— REDACTED:1358-1364 | REDACTED:1507-1513 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1358` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (7 lines × 2) Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:38— Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:38-45 | Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:123-129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:623— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:623-629 | Masuit.Tools/Systems/IDictionaryExtensions.cs:10-16 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:44— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:44-50 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:60-66 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:64— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:64-70 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:80-86 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:84— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:84-90 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:100-106 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:104— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:104-110 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:120-126 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:44— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:44-50 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:60-66 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:64— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:64-70 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:80-86 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:84— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:84-90 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:100-106 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:104— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:104-110 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:120-126 — before extracting anything, compare `Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs` and `Masuit.Tools.Abstractions/Systems/NullableDictionary.cs` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 96 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Weak hash algorithm Masuit.Tools.Abstractions/Files/FileExt.cs:118— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Masuit.Tools.Abstractions/Files/FileExt.cs:121— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm REDACTED:1026— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm REDACTED:1046— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm REDACTED:1078— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm REDACTED:1098— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm REDACTED:1137— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Masuit.Tools.Abstractions/Security/RSACrypt.cs:169— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Masuit.Tools.Abstractions/Security/RSACrypt.cs:182— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Masuit.Tools.Abstractions/Security/RSACrypt.cs:196— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Masuit.Tools.Abstractions/Security/RSACrypt.cs:208— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Dead code: ClayActivator Masuit.Tools.Abstractions/Extensions/Dynamics/ClayActivator.cs:6— NamedType ClayActivator — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection<KeyValuePair<System.String,T>>.Count Masuit.Tools.Abstractions/Extensions/Dynamics/Implementation/Arguments.cs:118— Property ICollection<KeyValuePair<System.String,T>>.Count — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection<KeyValuePair<System.String,T>>.IsReadOnly Masuit.Tools.Abstractions/Extensions/Dynamics/Implementation/Arguments.cs:120— Property ICollection<KeyValuePair<System.String,T>>.IsReadOnly — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: IDictionary<System.String,T>.Keys Masuit.Tools.Abstractions/Extensions/Dynamics/Implementation/Arguments.cs:150— Property IDictionary<System.String,T>.Keys — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: IDictionary<System.String,T>.Values Masuit.Tools.Abstractions/Extensions/Dynamics/Implementation/Arguments.cs:152— Property IDictionary<System.String,T>.Values — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: InstantDetector Masuit.Tools.Abstractions/Files/FileDetector/InstantDetector.cs:10— NamedType InstantDetector — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection.IsSynchronized Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:440— Property ICollection.IsSynchronized — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection.SyncRoot Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:445— Property ICollection.SyncRoot — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection.IsSynchronized Masuit.Tools.Abstractions/Systems/HashQueue.cs:298— Property ICollection.IsSynchronized — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ICollection.SyncRoot Masuit.Tools.Abstractions/Systems/HashQueue.cs:300— Property ICollection.SyncRoot — Roslyn's SymbolFinder walked every project the solution loads, including Masuit.Tools.Abstractions(netstandard2.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
X18 · Disposal-pattern correctness· Finalizer on a type that owns no unmanaged resource · ×10
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Security/Crc32.cs:15— `Crc32` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Security/Crc64.cs:15— `Crc64` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/ConcurrentHashSet.cs:391— `ConcurrentHashSet` declares a finalizer (line 391), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/ConcurrentLinkedList.cs:424— `ConcurrentLinkedList` declares a finalizer (line 424), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/ConcurrentList.cs:573— `ConcurrentList` declares a finalizer (line 573), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/Disposable.cs:15— `Disposable` declares a finalizer (line 15), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/DisposableConcurrentDictionary.cs:19— `DisposableConcurrentDictionary` declares a finalizer (line 19), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/DisposableDictionary.cs:19— `DisposableDictionary` declares a finalizer (line 19), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/LargeMemoryStream.cs:16— `LargeMemoryStream` declares a finalizer (line 16), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource Masuit.Tools.Abstractions/Systems/PooledMemoryStream.cs:18— `PooledMemoryStream` declares a finalizer (line 18), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Duplicated block (12 lines × 2) Masuit.Tools.Core/Database/DbContextExt.cs:554— Masuit.Tools.Core/Database/DbContextExt.cs:554-565 | Masuit.Tools.Core/Database/DbContextExt.cs:571-582 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:809— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:809-820 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:847-858 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:809` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:909— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:909-920 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:947-958 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:909` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Logging/LogManager.cs:201— Masuit.Tools.Abstractions/Logging/LogManager.cs:201-212 | Masuit.Tools.Abstractions/Logging/LogManager.cs:307-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Logging/LogManager.cs:201` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Logging/LogManager.cs:222— Masuit.Tools.Abstractions/Logging/LogManager.cs:222-233 | Masuit.Tools.Abstractions/Logging/LogManager.cs:328-339 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Logging/LogManager.cs:222` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Logging/LogManager.cs:265— Masuit.Tools.Abstractions/Logging/LogManager.cs:265-276 | Masuit.Tools.Abstractions/Logging/LogManager.cs:371-382 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Logging/LogManager.cs:265` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) REDACTED:1309— REDACTED:1309-1320 | REDACTED:1453-1464 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1309` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:59— Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:59-70 | Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:86-97 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:59` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `gcjLat` to `out double` in one and `double` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Config/CoreConfig.cs:114— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Files/FileDetector/Detectors/ConfigurationDetector.cs:33— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:258— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Logging/LogManager.cs:451— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:311— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Security/RSA.cs:164— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:44— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Masuit.Tools.Abstractions/Win32/Windows.cs:59— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×8
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools/Files/ExtensionAttach.cs:21— This method contradicts itself about `regKey`: line 18 writes `regKey?.OpenSubKey`, which says `regKey` can be null, but line 21 then dereferences it directly as `regKey.DeleteSubKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `regKey` truly cannot be null here, the `?.` is misleading. Settle it one way — test `regKey` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools/Files/ExtensionAttach.cs:55— This method contradicts itself about `regkey`: line 52 writes `regkey?.OpenSubKey`, which says `regkey` can be null, but line 55 then dereferences it directly as `regkey.DeleteSubKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `regkey` truly cannot be null here, the `?.` is misleading. Settle it one way — test `regkey` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:752— This method contradicts itself about `d`: line 751 assigns it with `as DirectoryEntry`, which hands back null rather than throwing when the value is not a `DirectoryEntry`, but line 752 then dereferences it directly as `d.StgType` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `d` once before the first use and handle the null case, or cast with `(DirectoryEntry)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:374— This method contradicts itself about `resp`: line 373 assigns it with `as HttpWebResponse`, which hands back null rather than throwing when the value is not a `HttpWebResponse`, but line 374 then dereferences it directly as `resp.ResponseUri` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `resp` once before the first use and handle the null case, or cast with `(HttpWebResponse)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Validator/IsIPAddressAttribute.cs:23— This method contradicts itself about `email`: line 22 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 23 then dereferences it directly as `email.MatchInetAddress` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `email` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Validator/IsPhoneAttribute.cs:50— This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchPhoneNumber` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Validator/LandlineAttribute.cs:50— This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchLandline` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded Masuit.Tools.Abstractions/Validator/UnifiedSocialCreditCodeAttribute.cs:50— This method contradicts itself about `phone`: line 49 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 50 then dereferences it directly as `phone.MatchUSCC` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `phone` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Duplicated block (10 lines × 2) REDACTED:624— REDACTED:624-633 | REDACTED:736-745 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) Masuit.Tools.Core/Models/IQueryableExt.cs:18— Masuit.Tools.Core/Models/IQueryableExt.cs:18-27 | Masuit.Tools.Core/Models/IQueryableExt.cs:43-52 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) Masuit.Tools.Core/Models/IQueryableExt.cs:68— Masuit.Tools.Core/Models/IQueryableExt.cs:68-77 | Masuit.Tools.Core/Models/IQueryableExt.cs:93-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:21— Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:21-30 | Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:38-47 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) Masuit.Tools.Abstractions/Media/ImageUtilities.cs:93— Masuit.Tools.Abstractions/Media/ImageUtilities.cs:93-102 | Masuit.Tools.Abstractions/Media/ImageUtilities.cs:105-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:74— Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:74-83 | Masuit.Tools.Abstractions/Media/SkiaSharpTransformer.cs:87-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:90— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:114— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:131— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:137— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:151— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:1042— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:90— `BindDeleteMember` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:114— `BindDeleteIndex` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:131— `BindCreateInstance` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:137— `BindUnaryOperation` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:151— `GetDynamicMemberNames` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:1042— `Write` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×5
Members sharing a duplicated core (4 members, 50+ identical tokens) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:797— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:797-820 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:833-858 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:897-920 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:933-958 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) Masuit.Tools.Abstractions/Logging/LogManager.cs:107— Masuit.Tools.Abstractions/Logging/LogManager.cs:107-118 | Masuit.Tools.Abstractions/Logging/LogManager.cs:162-173 | Masuit.Tools.Abstractions/Logging/LogManager.cs:284-298 | Masuit.Tools.Abstractions/Logging/LogManager.cs:390-402 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) Masuit.Tools.Abstractions/Logging/LogManager.cs:126— Masuit.Tools.Abstractions/Logging/LogManager.cs:126-137 | Masuit.Tools.Abstractions/Logging/LogManager.cs:181-192 | Masuit.Tools.Abstractions/Logging/LogManager.cs:241-255 | Masuit.Tools.Abstractions/Logging/LogManager.cs:347-361 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) Masuit.Tools.Abstractions/Media/ImageHasher.cs:110— Masuit.Tools.Abstractions/Media/ImageHasher.cs:110-126 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:135-148 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:169-192 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:201-224 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:1235— REDACTED:1235-1288 | REDACTED:1333-1343 | REDACTED:1382-1430 | REDACTED:1479-1490 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×5
Edited copy of a member (8 corresponding lines) Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:68— Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:68-77 | Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:121-128 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) REDACTED:64— REDACTED:64-72 | REDACTED:96-103 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) REDACTED:48— REDACTED:48-55 | REDACTED:151-158 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:103— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:103-110 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:119-126 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) Masuit.Tools/Systems/IDictionaryExtensions.cs:9— Masuit.Tools/Systems/IDictionaryExtensions.cs:9-16 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:622-629 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×5
Edited copy of a member (6 corresponding lines) Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:97— Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:97-102 | Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:106-111 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:21— Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:21-28 | Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:31-36 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:113— Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:113-120 | Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:130-135 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) REDACTED:82— REDACTED:82-87 | REDACTED:113-118 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:112— Masuit.Tools.Abstractions/Systems/NullableConcurrentDictionary.cs:112-117 | Masuit.Tools.Abstractions/Systems/NullableDictionary.cs:128-133 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
TooManyMethods: MongoDbClient Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs— TooManyMethods — 280 significant lines (blank, comment-only and punctuation-only lines excluded), 89 methods. The bar is 30 methods; this is 59 over it, 2.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SystemInfo Masuit.Tools.Abstractions/Hardware/SystemInfo.cs— TooManyMethods — 418 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: ConcurrentList Masuit.Tools.Abstractions/Systems/ConcurrentList.cs— TooManyMethods — 246 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ExcelExtension Masuit.Tools.Excel/ExcelExtension.cs— TooManyMethods — 303 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×4
Edited copy of a member (18 corresponding lines) Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:59— Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:59-76 | Masuit.Tools.Abstractions/Maths/CoordinateConvert.cs:86-103 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:244— Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:244-263 | Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:271-288 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:290— Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:290-307 | Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:318-339 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:102— Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:102-119 | Masuit.Tools.Abstractions/Extensions/BaseType/StreamExtensions.cs:232-253 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×4
Edited copy of a member (14 corresponding lines) REDACTED:171— REDACTED:171-184 | REDACTED:194-207 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:231— Masuit.Tools.Abstractions/Strings/NumberFormater.cs:231-244 | Masuit.Tools.Abstractions/Strings/NumberFormater.cs:252-266 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) Masuit.Tools.Abstractions/TextDiff/TextUtil.cs:57— Masuit.Tools.Abstractions/TextDiff/TextUtil.cs:57-70 | Masuit.Tools.Abstractions/TextDiff/TextUtil.cs:73-86 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) Masuit.Tools.Core/Database/DbContextExt.cs:509— Masuit.Tools.Core/Database/DbContextExt.cs:509-522 | Masuit.Tools.Core/Database/DbContextExt.cs:525-538 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
TreeExtensions.BuildTree (cognitive 18) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:224— TreeExtensions.BuildTree has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This shape REPEATS in the file: 2 other methods here (TreeExtensions.BuildTree, TreeExtensions.BuildTree) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
TreeExtensions.BuildTree (cognitive 18) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:278— TreeExtensions.BuildTree has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This shape REPEATS in the file: 2 other methods here (TreeExtensions.BuildTree, TreeExtensions.BuildTree) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
TreeExtensions.BuildTree (cognitive 18) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:322— TreeExtensions.BuildTree has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This shape REPEATS in the file: 2 other methods here (TreeExtensions.BuildTree, TreeExtensions.BuildTree) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FileTooLong: FileDetector/AbstractCompoundFileDetailDetector.cs Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs— FileTooLong — 786 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 286 over it, 1.57× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 687 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 187 over it, 1.37× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: DateTimeExt/ChineseCalendar.cs Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs— FileTooLong — 546 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 46 over it, 1.09× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×3
Edited copy of a member (23 corresponding lines) Masuit.Tools.Abstractions/Security/RSA.cs:57— Masuit.Tools.Abstractions/Security/RSA.cs:57-79 | Masuit.Tools.Abstractions/Security/RSA.cs:107-136 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:39— Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:39-61 | Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:72-94 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:359— Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:359-381 | Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:389-411 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×3
Edited copy of a member (29 corresponding lines) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:191— Masuit.Tools.Abstractions/Strings/NumberFormater.cs:191-223 | Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:208-236 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (29 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:711— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:711-739 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:970-1001 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (29 corresponding lines) Masuit.Tools.Abstractions/Win32/AntiVirus/AmsiScanService.cs:26— Masuit.Tools.Abstractions/Win32/AntiVirus/AmsiScanService.cs:26-57 | Masuit.Tools.Abstractions/Win32/AntiVirus/AmsiScanService.cs:107-135 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×3
Edited copy of a member (10 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1327— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1327-1336 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1439-1448 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) REDACTED:1355— REDACTED:1355-1364 | REDACTED:1504-1513 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) Masuit.Tools.Abstractions/Files/FileDetector/Detectors/PPSXDetector.cs:32— Masuit.Tools.Abstractions/Files/FileDetector/Detectors/PPSXDetector.cs:32-41 | Masuit.Tools.Abstractions/Files/FileDetector/Detectors/PPTXDetector.cs:32-41 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×3
Edited copy of a member (13 corresponding lines) Masuit.Tools.Abstractions/Strings/ValidateCode.cs:15— Masuit.Tools.Abstractions/Strings/ValidateCode.cs:15-27 | Masuit.Tools.Net45/Strings/ValidateCode.cs:23-36 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) REDACTED:25— REDACTED:25-37 | REDACTED:128-140 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) Masuit.Tools.Abstractions/Media/ImageHasher.cs:58— Masuit.Tools.Abstractions/Media/ImageHasher.cs:58-70 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:77-89 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (13 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:800— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:800-812 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:900-912 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:800` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:68— Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:68-80 | Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:89-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) Masuit.Tools.Abstractions/Media/ImageHasher.cs:469— Masuit.Tools.Abstractions/Media/ImageHasher.cs:469-481 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:484-496 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Sync-over-async blocking — 2 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:207— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:344— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Html/HtmlTools.cs:107— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.Abstractions/Html/HtmlTools.cs:140— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Masuit.Tools.AspNetCore/ModelBinder/ModelBindingContextExtension.cs:53— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Swallowed exception (caught, then discarded) REDACTED:1550— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:1576— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:74— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
No authorization — No [Authorize]/policies and no imperative guard methods (throw-on-violation) were found — endpoints may be unprotected.
No authorization NetCoreTest/Controllers/HomeController.cs:12— `HomeController.Test` serves requests and nothing authorizes it: no [Authorize] or RequireAuthorization on it or its controller/group, no fallback policy, no auth-gate middleware and no imperative guard in this codebase.
No assertions: InvokeMethod_ShouldInvokeMethodWithoutReturn Test/Masuit.Tools.Abstractions.Test/Refection/ReflectionUtilTests.cs:26— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Finalizer_DisposesValues Test/Masuit.Tools.Abstractions.Test/Systems/DisposableDictionaryTests.cs:66— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
Hotspot: Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs:356— Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ImageBorderRemover.ValidateOptions at line 356. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-13..2026-11-11, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-13 12:52:24 +08:00' --until='2026-11-11 12:52:24 +08:00' --full-history --no-merges -- Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: Masuit.Tools.Excel/ExcelExtension.cs Masuit.Tools.Excel/ExcelExtension.cs:298— Masuit.Tools.Excel/ExcelExtension.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ExcelExtension.FillCollection at line 298. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-13..2026-11-11, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-13 12:52:24 +08:00' --until='2026-11-11 12:52:24 +08:00' --full-history --no-merges -- Masuit.Tools.Excel/ExcelExtension.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
BarePragmaDisable Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:966— #pragma warning disable 1591 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable Masuit.Tools.Abstractions/Mime/ContentType.cs:2— #pragma warning disable 1591 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
IEnumerableExtensions.SequenceEqual (cognitive 18) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1237— IEnumerableExtensions.SequenceEqual has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (IEnumerableExtensions.SequenceEqual) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
IEnumerableExtensions.SequenceEqual (cognitive 18) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1283— IEnumerableExtensions.SequenceEqual has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (IEnumerableExtensions.SequenceEqual) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ClassTooLong: ChineseCalendar Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs— ClassTooLong — 541 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 141 over it, 1.35× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DefaultMimeItems Masuit.Tools.Abstractions/Mime/DefaultMimeItems.cs— ClassTooLong — 479 significant lines (blank, comment-only and punctuation-only lines excluded), 0 methods. The bar is 400 significant lines; this is 79 over it, 1.20× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
D4 · Code Duplication· Edited copy of a member (27 corresponding lines) · ×2
Edited copy of a member (27 corresponding lines) REDACTED:329— REDACTED:329-356 | REDACTED:365-391 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (27 corresponding lines) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:152— Masuit.Tools.Abstractions/Strings/NumberFormater.cs:152-183 | Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:174-200 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×2
Edited copy of a member (15 corresponding lines) Masuit.Tools.Net45/Media/ImageUtilities.cs:975— Masuit.Tools.Net45/Media/ImageUtilities.cs:975-991 | Masuit.Tools.Net45/Media/ImageUtilities.cs:1004-1018 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) Masuit.Tools.Core/Database/DbContextExt.cs:553— Masuit.Tools.Core/Database/DbContextExt.cs:553-567 | Masuit.Tools.Core/Database/DbContextExt.cs:570-584 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×2
Edited copy of a member (9 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:750— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:750-758 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1012-1020 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) Masuit.Tools.Abstractions/Security/Crc32.cs:111— Masuit.Tools.Abstractions/Security/Crc32.cs:111-119 | Masuit.Tools.Abstractions/Security/Crc64.cs:66-77 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×2
Edited copy of a member (4 corresponding lines) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1072— Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1072-1075 | Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1085-1088 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) Masuit.Tools.Abstractions/Models/Circle.cs:42— Masuit.Tools.Abstractions/Models/Circle.cs:42-45 | Masuit.Tools.Abstractions/Models/Circle.cs:53-56 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (24 lines × 2) Masuit.Tools.Net45/Media/ImageUtilities.cs:595— Masuit.Tools.Net45/Media/ImageUtilities.cs:595-618 | Masuit.Tools.Net45/Media/ImageUtilities.cs:677-700 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Net45/Media/ImageUtilities.cs:595` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Masuit.Tools.Net45/Media/ImageUtilities.cs:620` calls `FileInfo` and `Masuit.Tools.Net45/Media/ImageUtilities.cs:702` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (24 lines × 2) Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:67— Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:67-90 | Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:144-167 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:836— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:836-850 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:936-950 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:836` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) REDACTED:1252— REDACTED:1252-1268 | REDACTED:1397-1411 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:1248` calls `Close` and `REDACTED:1393` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) Masuit.Tools.Net45/Media/ImageUtilities.cs:326— Masuit.Tools.Net45/Media/ImageUtilities.cs:326-339 | Masuit.Tools.Net45/Media/ImageUtilities.cs:427-440 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) Masuit.Tools.Abstractions/Systems/SnowFlake.cs:181— Masuit.Tools.Abstractions/Systems/SnowFlake.cs:181-194 | Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:168-181 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12–15 lines × 4) Masuit.Tools.Abstractions/Logging/LogManager.cs:107— Masuit.Tools.Abstractions/Logging/LogManager.cs:107-118 | Masuit.Tools.Abstractions/Logging/LogManager.cs:162-173 | Masuit.Tools.Abstractions/Logging/LogManager.cs:284-298 | Masuit.Tools.Abstractions/Logging/LogManager.cs:390-402 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (12–15 lines × 4) Masuit.Tools.Abstractions/Logging/LogManager.cs:126— Masuit.Tools.Abstractions/Logging/LogManager.cs:126-137 | Masuit.Tools.Abstractions/Logging/LogManager.cs:181-192 | Masuit.Tools.Abstractions/Logging/LogManager.cs:241-255 | Masuit.Tools.Abstractions/Logging/LogManager.cs:347-361 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (10–13 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:699— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:699-708 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:721-733 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10–13 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:825— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:825-834 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:847-859 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:168— Masuit.Tools.Abstractions/Strings/NumberFormater.cs:168-178 | Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:185-195 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Strings/NumberFormater.cs:168` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:305— Masuit.Tools.Abstractions/Strings/NumberFormater.cs:305-315 | Masuit.Tools.Abstractions/Strings/NumberFormater.cs:377-387 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Strings/NumberFormater.cs:305` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) Masuit.Tools.Abstractions/Media/ImageUtilities.cs:147— Masuit.Tools.Abstractions/Media/ImageUtilities.cs:147-152 | Masuit.Tools.Abstractions/Media/ImageUtilities.cs:196-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Media/ImageUtilities.cs:147` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) Masuit.Tools.Abstractions/Models/LoanModel.cs:72— Masuit.Tools.Abstractions/Models/LoanModel.cs:72-77 | Masuit.Tools.Abstractions/Models/LoanModel.cs:143-148 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Models/LoanModel.cs:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 4) Masuit.Tools.Abstractions/Media/ImageHasher.cs:110— Masuit.Tools.Abstractions/Media/ImageHasher.cs:110-116 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:135-141 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:169-175 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:201-207 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Media/ImageHasher.cs:110` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 4) REDACTED:1251— REDACTED:1251-1267 | REDACTED:1335-1341 | REDACTED:1396-1410 | REDACTED:1481-1487 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:1248` calls `Close` and `REDACTED:1393` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
End-of-life runtime: .NET Framework net45 Masuit.Tools.Net45/Masuit.Tools.Net45.csproj:3— Masuit.Tools.Net45/Masuit.Tools.Net45.csproj declares .NET Framework net45 as this project's target framework, and .NET Framework 4.5, support ended 2016-01-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2016-01-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET Framework net461 Masuit.Tools/Masuit.Tools.Net.csproj:3— Masuit.Tools/Masuit.Tools.Net.csproj declares .NET Framework net461 as this project's target framework, and .NET Framework 4.6.1, support ended 2022-04-26. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2022-04-26 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
IC1 · Incompleteness & stubs· Both branches open with the same statements · ×2
Both branches open with the same statements — the condition does not decide them Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:352— The first 1 statement of the `if` and of the `else` are identical, so it runs on both paths regardless of the condition. Lift it above the `if` — leaving it duplicated inside makes the branches read as though they handled this differently.
Both branches open with the same statements — the condition does not decide them Masuit.Tools.Excel/ExcelExtension.cs:142— The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently.
S1 · Web-Security Posture· The encryption IV is the same for every message · ×2
The encryption IV is the same for every message REDACTED:65— This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages.
The encryption IV is the same for every message REDACTED:182— This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages.
Sync-over-async (deadlock risk) Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:196— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:344— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
X13 · Undrained process stream· Redirected process stream is never drained (deadlock) · ×2
Redirected process stream is never drained (deadlock) REDACTED:159— `RedirectStandardError` is set here, but `StandardError` is not being read when `StandardOutput` is read to the end — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardError pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginErrorReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume.
Redirected process stream is never drained (deadlock) Masuit.Tools.Abstractions/Win32/WindowsCommand.cs:26— `RedirectStandardOutput` is set here, but `StandardOutput` is not being read when the code waits for the child to exit — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardOutput pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginOutputReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×2
Disposable created and abandoned in the method that made it Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:45— `yRoi` is a `Mat`, which implements `IDisposable`, and it is created here (line 45). Every use of it in `EmbedWatermark` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var yRoi = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Masuit.Tools.DigtalWatermarker/DigitalWatermarker.cs:129— `yRoi` is a `Mat`, which implements `IDisposable`, and it is created here (line 129). Every use of it in `ExtractWatermark` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var yRoi = …;`), which releases it at the end of the scope on every path including a throw.
ImageDetectExt.GetImageType (cyclomatic 61) REDACTED:24— ImageDetectExt.GetImageType has cyclomatic complexity 61 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
FromBodyOrDefaultModelBinder.BindModelAsync (cyclomatic 35) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:27— FromBodyOrDefaultModelBinder.BindModelAsync has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffAlgorithm.MyersDiffBisect (cyclomatic 33) Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:208— DiffAlgorithm.MyersDiffBisect has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IPAddressExtensions.IsPrivateIP (cyclomatic 32) Masuit.Tools.Abstractions/Extensions/BaseType/IPAddressExtensions.cs:13— IPAddressExtensions.IsPrivateIP has cyclomatic complexity 32 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
FromBodyOrDefaultModelBinder.GetBindingValue (cyclomatic 28) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:221— FromBodyOrDefaultModelBinder.GetBindingValue has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TextDetector.Detect (cyclomatic 24) Masuit.Tools.Abstractions/Files/FileDetector/Detectors/TextDetector.cs:39— TextDetector.Detect has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ResumeActionResultBase.ShouldProceedAfterEvaluatingPreconditions (cyclomatic 23) Masuit.Tools/Mvc/ActionResults/ResumeActionResultBase.cs:74— ResumeActionResultBase.ShouldProceedAfterEvaluatingPreconditions has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffExtension.CleanupEfficiency (cyclomatic 23) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:396— DiffExtension.CleanupEfficiency has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExcelExtension.MergeAdjacentCells (cyclomatic 20) Masuit.Tools.Excel/ExcelExtension.cs:398— ExcelExtension.MergeAdjacentCells has cyclomatic complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ChineseCalendar.IsWorkDay.get (cyclomatic 19) Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:748— ChineseCalendar.IsWorkDay.get has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PerceptualLosslessCompressor.HasCompressionMarker (cyclomatic 19) Masuit.Tools.Abstractions/Media/PerceptualLosslessCompressor.cs:104— PerceptualLosslessCompressor.HasCompressionMarker has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RsaPem.FromXML (cyclomatic 19) Masuit.Tools.Abstractions/Security/RsaPem.cs:598— RsaPem.FromXML has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
TextEncodingDetector.GetEncoding (cyclomatic 18) Masuit.Tools.Abstractions/Files/TextEncodingDetector.cs:46— TextEncodingDetector.GetEncoding has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
PartialDownloader.DownloadProcedure (cyclomatic 18) Masuit.Tools.Abstractions/Net/PartialDownloader.cs:154— PartialDownloader.DownloadProcedure has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PatchExtension.SplitMax (cyclomatic 18) Masuit.Tools.Abstractions/TextDiff/PatchExtension.cs:248— PatchExtension.SplitMax has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DbSetExtensions.AddOrUpdate (cyclomatic 18) Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:33— DbSetExtensions.AddOrUpdate has cyclomatic complexity 18 (threshold 15). Of this number, 14 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServiceCollectionExtensions.RegisterServiceByAttribute (cyclomatic 18) Masuit.Tools.AspNetCore/AspNetCore/ServiceCollectionExtensions.cs:69— ServiceCollectionExtensions.RegisterServiceByAttribute has cyclomatic complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RsaPem.FromPEM (cyclomatic 17) Masuit.Tools.Abstractions/Security/RsaPem.cs:257— RsaPem.FromPEM has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 8 of the 17 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 275, 322, 302). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DiffExtension.CleanupSemantic (cyclomatic 17) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:503— DiffExtension.CleanupSemantic has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PatchExtension.Apply (cyclomatic 17) Masuit.Tools.Abstractions/TextDiff/PatchExtension.cs:154— PatchExtension.Apply has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImageUtilities.ZoomAuto (cyclomatic 17) Masuit.Tools.Net45/Media/ImageUtilities.cs:287— ImageUtilities.ZoomAuto has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffPatch.Compute (cyclomatic 16) Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:121— DiffPatch.Compute has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FromBodyOrDefaultModelBinder.BindModelAsync (cognitive 125) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:27— FromBodyOrDefaultModelBinder.BindModelAsync has cognitive complexity 125 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DiffAlgorithm.MyersDiffBisect (cognitive 59) Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:208— DiffAlgorithm.MyersDiffBisect has cognitive complexity 59 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PatchExtension.Apply (cognitive 54) Masuit.Tools.Abstractions/TextDiff/PatchExtension.cs:154— PatchExtension.Apply has cognitive complexity 54 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PatchExtension.SplitMax (cognitive 46) Masuit.Tools.Abstractions/TextDiff/PatchExtension.cs:248— PatchExtension.SplitMax has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
VersionNumber.CompareTo (cognitive 43) Masuit.Tools.Abstractions/Models/VersionNumber.cs:134— VersionNumber.CompareTo has cognitive complexity 43 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ResumeActionResultBase.ShouldProceedAfterEvaluatingPreconditions (cognitive 42) Masuit.Tools/Mvc/ActionResults/ResumeActionResultBase.cs:74— ResumeActionResultBase.ShouldProceedAfterEvaluatingPreconditions has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DiffExtension.CleanupEfficiency (cognitive 38) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:396— DiffExtension.CleanupEfficiency has cognitive complexity 38 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
TextDetector.Detect (cognitive 37) Masuit.Tools.Abstractions/Files/FileDetector/Detectors/TextDetector.cs:39— TextDetector.Detect has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelExtension.MergeAdjacentCells (cognitive 37) Masuit.Tools.Excel/ExcelExtension.cs:398— ExcelExtension.MergeAdjacentCells has cognitive complexity 37 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ImageUtilities.ZoomAuto (cognitive 37) Masuit.Tools.Net45/Media/ImageUtilities.cs:287— ImageUtilities.ZoomAuto has cognitive complexity 37 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BitapAlgorithm.Match (cognitive 36) Masuit.Tools.Abstractions/TextDiff/BitapAlgorithm.cs:25— BitapAlgorithm.Match has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DbSetExtensions.AddOrUpdate (cognitive 36) Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:33— DbSetExtensions.AddOrUpdate has cognitive complexity 36 (threshold 15). Of this number, 32 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PartialDownloader.DownloadProcedure (cognitive 35) Masuit.Tools.Abstractions/Net/PartialDownloader.cs:154— PartialDownloader.DownloadProcedure has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffExtension.CleanupSemantic (cognitive 33) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:503— DiffExtension.CleanupSemantic has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FromBodyOrDefaultModelBinder.GetBindingValue (cognitive 33) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:221— FromBodyOrDefaultModelBinder.GetBindingValue has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StringExtensions.MatchCNPatentNumber (cognitive 32) REDACTED:761— StringExtensions.MatchCNPatentNumber has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
RsaPem.FromPEM (cognitive 29) Masuit.Tools.Abstractions/Security/RsaPem.cs:257— RsaPem.FromPEM has cognitive complexity 29 (threshold 15). Of this number, 15 points are the body's own statements and 14 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffExtension.CleanupMergePass1 (cognitive 29) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:135— DiffExtension.CleanupMergePass1 has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageDetectExt.GetImageType (cognitive 26) REDACTED:24— ImageDetectExt.GetImageType has cognitive complexity 26 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ChineseCalendar.IsWorkDay.get (cognitive 25) Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:748— ChineseCalendar.IsWorkDay.get has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DbSetExtensions.AddOrUpdate (cognitive 25) Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:122— DbSetExtensions.AddOrUpdate has cognitive complexity 25 (threshold 15). Of this number, 21 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PerceptualLosslessCompressor.HasCompressionMarker (cognitive 24) Masuit.Tools.Abstractions/Media/PerceptualLosslessCompressor.cs:104— PerceptualLosslessCompressor.HasCompressionMarker has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Encrypt.GetSubString (cognitive 24) REDACTED:502— Encrypt.GetSubString has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffExtension.CleanupSemanticLossless (cognitive 24) Masuit.Tools.Abstractions/TextDiff/DiffExtension.cs:326— DiffExtension.CleanupSemanticLossless has cognitive complexity 24 (threshold 15). Of this number, 21 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServiceCollectionExtensions.RegisterServiceByAttribute (cognitive 24) Masuit.Tools.AspNetCore/AspNetCore/ServiceCollectionExtensions.cs:69— ServiceCollectionExtensions.RegisterServiceByAttribute has cognitive complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffPatch.Compute (cognitive 23) Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:121— DiffPatch.Compute has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ChineseCalendar.ChineseCalendar.ctor (cognitive 22) Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs:335— ChineseCalendar.ChineseCalendar.ctor has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageBorderRemover.RefineWithEdgeDensity (cognitive 21) Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs:272— ImageBorderRemover.RefineWithEdgeDensity has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageUtilities.Relief (cognitive 21) Masuit.Tools.Net45/Media/ImageUtilities.cs:884— ImageUtilities.Relief has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BodyOrDefaultBinderMiddleware.Invoke (cognitive 21) Masuit.Tools.AspNetCore/ModelBinder/BodyOrDefaultBinderMiddleware.cs:12— BodyOrDefaultBinderMiddleware.Invoke has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelExtension.FillCollection (cognitive 20) Masuit.Tools.Excel/ExcelExtension.cs:298— ExcelExtension.FillCollection has cognitive complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IConvertibleExtensions.ConvertTo (cognitive 19) Masuit.Tools.Abstractions/Extensions/BaseType/IConvertibleExtensions.cs:38— IConvertibleExtensions.ConvertTo has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RBTree.Insert (cognitive 19) Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:162— RBTree.Insert has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NumberFormater.ToInt (cognitive 19) Masuit.Tools.Abstractions/Strings/NumberFormater.cs:326— NumberFormater.ToInt has cognitive complexity 19 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RsaPem.ToPEM (cognitive 18) Masuit.Tools.Abstractions/Security/RsaPem.cs:426— RsaPem.ToPEM has cognitive complexity 18 (threshold 15). Of this number, 9 points are the body's own statements and 9 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageUtilities.CutForCustom (cognitive 18) Masuit.Tools.Net45/Media/ImageUtilities.cs:159— ImageUtilities.CutForCustom has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IniFile.ParseLine (cognitive 17) Masuit.Tools.Abstractions/Files/IniFile/IniFile.cs:63— IniFile.ParseLine has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelExtension.GetPictures (cognitive 17) Masuit.Tools.Excel/ExcelExtension.cs:557— ExcelExtension.GetPictures has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModelBindingContextExtension.ConvertObject (cognitive 17) Masuit.Tools.AspNetCore/ModelBinder/ModelBindingContextExtension.cs:65— ModelBindingContextExtension.ConvertObject has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RsaPem.FindFactor (cognitive 16) Masuit.Tools.Abstractions/Security/RsaPem.cs:211— RsaPem.FindFactor has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IsEmailAttribute.IsValid (cognitive 16) Masuit.Tools.Abstractions/Validator/IsEmailAttribute.cs:49— IsEmailAttribute.IsValid has cognitive complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D4 · Code Duplication· Edited copy of a member (70 corresponding lines) · ×1
Edited copy of a member (70 corresponding lines) Masuit.Tools.Net45/Media/ImageUtilities.cs:566— Masuit.Tools.Net45/Media/ImageUtilities.cs:566-637 | Masuit.Tools.Net45/Media/ImageUtilities.cs:649-718 — These two members are one piece of code written twice and then edited apart: 70 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (47 corresponding lines) · ×1
Edited copy of a member (47 corresponding lines) Masuit.Tools.Excel/ExcelExtension.cs:242— Masuit.Tools.Excel/ExcelExtension.cs:242-288 | Masuit.Tools.Excel/ExcelExtension.cs:299-355 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (61 corresponding lines) · ×1
Edited copy of a member (61 corresponding lines) Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:34— Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:34-111 | Masuit.Tools.AspNetCore/AspNetCore/DbSetExtensions.cs:123-183 — These two members are one piece of code written twice and then edited apart: 61 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (48 corresponding lines) · ×1
Edited copy of a member (48 corresponding lines) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:225— Masuit.Tools.Abstractions/Models/TreeExtensions.cs:225-272 | Masuit.Tools.Abstractions/Models/TreeExtensions.cs:323-370 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (45 corresponding lines) · ×1
Edited copy of a member (45 corresponding lines) REDACTED:658— REDACTED:658-702 | REDACTED:757-807 — These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (33 corresponding lines) · ×1
Edited copy of a member (33 corresponding lines) REDACTED:603— REDACTED:603-635 | REDACTED:713-746 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×1
Edited copy of a member (20 corresponding lines) REDACTED:1301— REDACTED:1301-1320 | REDACTED:1445-1464 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (51 corresponding lines) · ×1
Edited copy of a member (51 corresponding lines) Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:245— Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:245-295 | Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:548-603 — These two members are one piece of code written twice and then edited apart: 51 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×1
Edited copy of a member (31 corresponding lines) Masuit.Tools.Abstractions/Media/ImageHasher.cs:317— Masuit.Tools.Abstractions/Media/ImageHasher.cs:317-347 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:356-386 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×1
Edited copy of a member (7 corresponding lines) Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:48— Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:48-54 | Masuit.Tools.Abstractions/Extensions/Dynamics/ClayMetaObject.cs:58-64 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 13+ corresponding lines) · ×1
Edited copies of one member (4 members, 13+ corresponding lines) Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1028— Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1028-1040 | Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1050-1062 | Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1121-1133 | Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs:1144-1156 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×1
Edited copy of a member (17 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:1162— Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:1162-1179 | Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs:1191-1207 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×1
Edited copy of a member (22 corresponding lines) Masuit.Tools.Abstractions/Media/ImageHasher.cs:245— Masuit.Tools.Abstractions/Media/ImageHasher.cs:245-266 | Masuit.Tools.Abstractions/Media/ImageHasher.cs:275-296 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) Masuit.Tools.Abstractions/Systems/SnowFlake.cs:69— Masuit.Tools.Abstractions/Systems/SnowFlake.cs:69-92 | Masuit.Tools.Abstractions/Systems/SnowFlakeNew.cs:55-78 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×1
Edited copy of a member (21 corresponding lines) Masuit.Tools.Abstractions/Files/IniFile/IniFile.cs:131— Masuit.Tools.Abstractions/Files/IniFile/IniFile.cs:131-151 | Masuit.Tools.Abstractions/Files/IniFile/IniFile.cs:158-178 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (26 corresponding lines) · ×1
Edited copy of a member (26 corresponding lines) Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1363— Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1363-1388 | Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs:1476-1501 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×1
Edited copy of a member (12 corresponding lines) Masuit.Tools.Abstractions/Files/FileExt.cs:47— Masuit.Tools.Abstractions/Files/FileExt.cs:47-58 | Masuit.Tools.Abstractions/Files/FileExt.cs:66-77 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×1
Edited copy of a member (16 corresponding lines) Masuit.Tools.Net45/Media/ImageUtilities.cs:521— Masuit.Tools.Net45/Media/ImageUtilities.cs:521-536 | Masuit.Tools.Net45/Media/ImageUtilities.cs:920-936 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 14+ corresponding lines) · ×1
Edited copies of one member (4 members, 14+ corresponding lines) Masuit.Tools.Net45/Media/ImageUtilities.cs:829— Masuit.Tools.Net45/Media/ImageUtilities.cs:829-844 | Masuit.Tools.Net45/Media/ImageUtilities.cs:857-872 | Masuit.Tools.Net45/Media/ImageUtilities.cs:949-962 | Masuit.Tools.Net45/Media/ImageUtilities.cs:1046-1059 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×1
Edited copies of one member (3 members, 6+ corresponding lines) Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:21— Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:21-28 | Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:31-36 | Masuit.Tools.Abstractions/TextDiff/DiffPatch.cs:64-69 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:69— Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:69-90 | Masuit.Tools.Abstractions/Files/SevenZipCompressor.cs:129-147 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (38 lines × 2) REDACTED:659— REDACTED:659-696 | REDACTED:765-802 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (32 lines × 2) Masuit.Tools.Abstractions/Models/TreeExtensions.cs:240— Masuit.Tools.Abstractions/Models/TreeExtensions.cs:240-271 | Masuit.Tools.Abstractions/Models/TreeExtensions.cs:338-369 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (30 lines × 2) Masuit.Tools.Excel/ExcelExtension.cs:412— Masuit.Tools.Excel/ExcelExtension.cs:412-441 | Masuit.Tools.Excel/ExcelExtension.cs:443-472 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 2) Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:250— Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:250-267 | Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:553-570 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:250` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:571` calls `TryAdd` and `Masuit.Tools.Abstractions/Systems/ConcurrentHashQueue.cs:268` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) Masuit.Tools.Net45/Media/ImageUtilities.cs:304— Masuit.Tools.Net45/Media/ImageUtilities.cs:304-322 | Masuit.Tools.Net45/Media/ImageUtilities.cs:403-421 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Net45/Media/ImageUtilities.cs:304` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8–20 lines × 2) REDACTED:1248— REDACTED:1248-1267 | REDACTED:1334-1341 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:360— Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:360-375 | Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:390-405 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/Extensions/BaseType/ObjectExtensions.cs:360` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–18 lines × 2) REDACTED:1393— REDACTED:1393-1410 | REDACTED:1480-1487 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15–17 lines × 2) Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:246— Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:246-262 | Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs:273-287 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17 lines × 2) Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:240— Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:240-256 | Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:283-299 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.Abstractions/TextDiff/DiffAlgorithm.cs:240` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 3) Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:123— Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:123-134 | Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:137-148 | Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:149-161 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:123` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:123` calls `foreach` and `Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:149` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 3) REDACTED:370— REDACTED:370-380 | REDACTED:604-614 | REDACTED:716-726 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (8 lines × 2) Masuit.Tools.Abstractions/Files/FileExt.cs:48— Masuit.Tools.Abstractions/Files/FileExt.cs:48-55 | Masuit.Tools.Abstractions/Files/FileExt.cs:67-74 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) Masuit.Tools.Abstractions/Systems/CompositeContractResolver.cs:34— Masuit.Tools.Abstractions/Systems/CompositeContractResolver.cs:34-42 | Masuit.Tools.Abstractions/Systems/DeserializeOnlyContractResolver.cs:18-26 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 3) REDACTED:32— REDACTED:32-36 | REDACTED:39-43 | REDACTED:56-60 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Fake-async — async method never awaits NetCoreTest/Controllers/HomeController.cs:10— `Test` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Outbound HTTP without resilience Masuit.Tools.AspNetCore/AspNetCore/ServiceCollectionExtensions.cs:39— `services.AddHttpClient<ISevenZipCompressor, SevenZipCompressor>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
SC1 · Supply-chain hygiene· NuGet dependencies are not locked · ×1
NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
X14 · Bypassable address classification· IP classification is bypassable through an IPv4-in-IPv6 embedding · ×1
IP classification is bypassable through an IPv4-in-IPv6 embedding Masuit.Tools.Abstractions/Extensions/BaseType/IPAddressExtensions.cs:30— This method unwraps IPv4-MAPPED IPv6 (`IsIPv4MappedToIPv6`, line 16) and rejects `10.0.0.0/8` on its IPv4 path, and it handles some IPv4-in-IPv6 embeddings — but not IPv4-compatible (`::a.b.c.d`) and 6to4 (`2002::/16`) and NAT64 (`64:ff9b::/96`): either it never names it, or it names it and returns the verdict its IPv4 path gives public space. So `::10.0.0.1`, `2002:0a00:0001::`, `64:ff9b::10.0.0.0` name a host inside `10.0.0.0/8`, the range this same method declares non-public, and reach the IPv6 branch at line 30 with the opposite verdict. Unwrap every embedding to its IPv4 form before classifying, or reject any IPv6 address carrying an embedded IPv4 outright.
X24 · Document value interpolated into markup unescaped· Untrusted text written into markup unescaped · ×1
Untrusted text written into markup unescaped Masuit.Tools.Abstractions/Models/Email.cs:90— `Body` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Silent fallback default in catch Masuit.Tools.Abstractions/Config/CoreConfig.cs:122— `ConvertTo` swallows every exception into `return default;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:41— `Detect` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:31— `Detect` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:147— `GetCPUTemperature` swallows every exception into `return -1;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:173— `GetCpuCount` swallows every exception into `return -1;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:348— `MemoryAvailable` swallows every exception into `return -1;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:583— `GetDiskInfo` swallows every exception into `return [];` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:192— `IsSvg` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:78— `TotalBytesReceived` swallows every exception into `return 0;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Net/MultiThreadDownloader.cs:109— `TotalSpeedInBytes` swallows every exception into `return 0;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:1550— `SetIV` swallows every exception and sets `_iv = null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:1576— `SetKey` swallows every exception and sets `_key = null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Security/RSA.cs:97— `DecryptOrNull` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Security/RSA.cs:132— `DecryptOrNull` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Security/RSA.cs:180— `Verify` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:132— `GetOsVersion` swallows every exception into `return Environment.OSVersion.VersionString;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:286— `GetDiskID` swallows every exception into `return "unknow ";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:312— `GetUserName` swallows every exception into `return "unknow ";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:334— `GetSystemType` swallows every exception into `return "unknow ";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:356— `GetTotalPhysicalMemory` swallows every exception into `return "unknow ";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Abstractions/Win32/Windows.cs:368— `GetComputerName` swallows every exception into `return "unknow ";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Net45/Config/CoreConfig.cs:25— `Get` swallows every exception into `return default;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Net45/Media/ImageUtilities.cs:503— `CutImage` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Net45/Media/ImageUtilities.cs:532— `ResizeImage` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch Masuit.Tools.Net45/Media/ImageUtilities.cs:633— `CompressImage` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
+ 2 more in this group — see findings.md.
P10 · Library API & versioning· Public type used only inside its own library · ×25
Public type used only inside its own library Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5— `Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5— `Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5— `Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5— `Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5— `Masuit.Tools.Dynamics.DynamicFactory` (Masuit.Tools.Abstractions/Extensions/Dynamics/DynamicFactory.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractCompoundFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractCompoundFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractISOBaseMediaFileDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractISOBaseMediaFileDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net6)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net8)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(net10.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8— `Masuit.Tools.Files.FileDetector.AbstractRegexSignatureDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractRegexSignatureDetector.cs:8) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Abstractions.Test`, `Masuit.Tools.Core(net11.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.0)`, `Masuit.Tools.Net`, `Masuit.Tools.Test`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7— `Masuit.Tools.Files.FileDetector.AbstractZipDetailDetector` (Masuit.Tools.Abstractions/Files/FileDetector/AbstractZipDetailDetector.cs:7) is public, and the library's own code uses it, but no other project in this repository uses it (read: `Masuit.Tools.Core(netstandard2.1)`, `Masuit.Tools.Excel`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Commented-out code REDACTED:889— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:890— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:893— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:896— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Masuit.Tools.Abstractions/Hardware/SystemInfo.cs:312— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Masuit.Tools.Abstractions/Models/DateTimeRange.cs:17— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Masuit.Tools.Abstractions/Security/RsaPem.cs:154— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Masuit.Tools.Abstractions/Security/RsaPem.cs:155— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Silent fallback default on parse failure REDACTED:484— `CheckChinaID18` returns `false` when `m.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure REDACTED:518— `CheckChinaID15` returns `false` when `m.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure REDACTED:571— `IPToID` returns `0` when `IPAddress.TryParse(addr, out var ip)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure REDACTED:781— `MatchCNPatentNumber` returns `false` when `m.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Duplicated predicate Masuit.Tools.Abstractions/Strings/NumberFormater.cs:99— `characters == null || characters.Length == 0` appears character-identically in 2 files — Masuit.Tools.Abstractions/Strings/NumberFormater.cs, Masuit.Tools.Abstractions/Strings/UnicodeFormater.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate Masuit.Tools.Abstractions/Media/ImageUtilities.cs:17— `contentType == "image/pjpeg" || contentType == "image/jpeg" || contentType == "image/gif" || contentType == "image/bmpp" || contentType == "…` appears character-identically in 2 files — Masuit.Tools.Abstractions/Media/ImageUtilities.cs, Masuit.Tools.Net45/Media/ImageUtilities.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate Masuit.Tools/Systems/IDictionaryExtensions.cs:12— `dictionary.IsReadOnly || dictionary.ContainsKey(key)` appears character-identically in 2 files — Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs, Masuit.Tools/Systems/IDictionaryExtensions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Hand-rolled JSON/XML parsing via regex Masuit.Tools.Abstractions/Security/RsaPem.cs:667— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
Hand-rolled JSON/XML parsing via regex Masuit.Tools.Abstractions/TextDiff/Extensions.cs:73— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
Hand-rolled JSON/XML parsing via regex Masuit.Tools.Abstractions/TextDiff/Extensions.cs:143— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×2
Projects may be oversized for their cohesion Masuit.Tools.Abstractions/Masuit.Tools.Abstractions.csproj:1— `Masuit.Tools.Abstractions(netstandard2.0)` overshoots its size bounds (34047 LoC, 216 public types across 32 namespaces). 2 of 16 project(s) overshoot their size bounds, lowering Project Cohesion to 7.5/10. Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
Projects may be oversized for their cohesion Masuit.Tools.Net45/Masuit.Tools.Net45.csproj:1— `Masuit.Tools.Net45` overshoots its size bounds (21882 LoC, 142 public types across 26 namespaces). 2 of 16 project(s) overshoot their size bounds, lowering Project Cohesion to 7.5/10. Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No security response headers detected NetCoreTest/Program.cs:4— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
No app-layer HTTPS enforcement detected — No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
No app-layer HTTPS enforcement detected NetCoreTest/Program.cs:4— This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 24 significant file(s) lose their only recent owner: REDACTED, Masuit.Tools.Abstractions/Extensions/BaseType/IEnumerableExtensions.cs, Masuit.Tools.Abstractions/Extensions/BaseType/IDictionaryExtensions.cs, Masuit.Tools.NoSQL.MongoDBClient/MongoDbClient.cs, Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs, Masuit.Tools.Abstractions/Hardware/SystemInfo.cs, REDACTED, Masuit.Tools.Excel/ExcelExtension.cs (+16 more). Pair on, review, or document these before any departure.
Split Masuit.Tools.Abstractions(netstandard2.0) Masuit.Tools.Abstractions/Masuit.Tools.Abstractions.csproj:1— `Masuit.Tools.Abstractions(netstandard2.0)` overshoots its size bounds (34047 LoC, 216 public types across 32 namespaces). These parts reach the rest of the project only through its shared core (`(root)`, `Abstractions`, `Maths`, `Mime`, `Systems`), so they are the cleanest seams: `Masuit.Tools.Dynamics` (29 types in 21 files): 1 of 140 of its type references cross into a sibling namespace, and the rest of the project uses it 1 times and it uses the rest 0 times; `Masuit.Tools.TextDiff` (21 types in 17 files): 0 of 312 of its type references cross into a sibling namespace, and the rest of the project uses it 0 times and it uses the rest 20 times; `Masuit.Tools.Win32` (11 types in 9 files): 6 of 99 of its type references cross into a sibling namespace, and the rest of the project uses it 0 times and it uses the rest 13 times. Draw the boundary inside the assembly first (keep each seam's cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P10 · Library API & versioning· Implementation type on the public API · ×1
Implementation type on the public API Masuit.Tools/Mvc/Internal/ByteRange.cs:5— 2 public types in `Masuit.Tools.Mvc.Internal` are marked as implementation by their own namespace, folder or name: `ByteRange` (Masuit.Tools/Mvc/Internal/ByteRange.cs:5, `Internal`), `ByteRange` (Masuit.Tools/Mvc/Internal/ByteRange.cs:5, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
Logging is not universal — Only 2/6 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 6, 1 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation BenchmarkTest/BenchmarkTest.csproj:10— `BenchmarkTest/BenchmarkTest.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
Secure cookie flags not detected Masuit.Tools/Mvc/HttpHeaders.cs:60— No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.)
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 54/71 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Interpolated log message defeats structured logging Masuit.Tools.AspNetCore/ModelBinder/FromBodyOrDefaultModelBinder.cs:81— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Nullable reference types not enabled everywhere — 0/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Silent fallback default on unknown code Masuit.Tools.Abstractions/Media/ImageBorderRemover.cs:353— `GetEncodedFormat` maps every unrecognised code to `SKEncodedImageFormat.Png`, one of the real values, with no log or throw — a malformed or new code silently reads as a known one. Throw on the unknown code, or log it. If that member is the correct answer for any other code, say so in a comment on the member and the row stops firing.
Off the main sequence: Masuit.Tools.Abstractions(netstandard2.0) Masuit.Tools.Abstractions/Masuit.Tools.Abstractions.csproj:1— Masuit.Tools.Abstractions(netstandard2.0): abstractness 0.08, instability 0.00, distance 0.92 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 26 file(s) — `Masuit.Tools.Abstractions/Config/CoreConfig.cs`, `Masuit.Tools.Abstractions/DateTimeExt/ChineseCalendar.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/ArrayBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Behaviors/InterfaceProxyBehavior.cs`, `Masuit.Tools.Abstractions/Extensions/Dynamics/Clay.cs`, … (+21 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1cdae-b341-78fe-a532-f9c896f379cd · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 14 · Warnings: 405 · Recommendations: 92 · Info: 3 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 12-11-2026 @ 02:55 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.