Public report of komikku-app/komikku, published 13 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 13 November 2026, 20:20 UTC · Survey ID cd_b857c382ce60437b8ce4827feedd5a8c

komikku-app/komikku

Measured 13 November 2026, 20:19 UTC, at code version 383ffaa

CAI score 56out of 100 Adequate
CriticalWeakAdequateStrongExemplary
Up 6 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A large codebase: 170,557 lines of product code in 17 projects, tests not counted · Estimated rebuild effort: about 1.4 person-years · Weakest lens: Security and Compliance, 50

Findings by how serious they are

27 critical 697 serious 336 minor

13 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
13 November 2026, 20:19 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

53of 53 dimensions measured by tools.
1047of 1060 findings point to an exact file and line, so you can open each one in the code. The other 13 concern the repository as a whole, such as missing documentation.
53dimensions across 7 lenses, read from 170,557 lines of product code in 17 projects.
Chapters

Executive summary

komikku-app/komikku falls short of our standard for production, in part because it has passwords or keys in the code's history. It scores 56 out of 100 and is rated Adequate, and 17 of its 27 critical findings are security problems.

Security and Compliance, at 50, is the weakest lens and counts most in the score. The best first steps are replacing the nine passwords or keys found in the code's history and replacing the five exposed passwords or keys and switching the old ones off, each worth about 5 points. Raising Security and Compliance to 70 would lift the score to about 61.

Nine passwords or keys in the code's history and five in the code are open to anyone who can read the repository. One automatic update takes new releases before a bad one can be spotted, and seven parts of the code are no longer understood by anyone working on it. Replacing each exposed password or key, setting a waiting period for automatic updates and having someone learn the forgotten files would close these risks. Passing outside input through environment variables would fix the pipeline step that puts outside input straight into a shell command, and limiting each secret to its own step would deal with the secret exposed to more of the pipeline than needed. The inner part of the code that depends on an outer part needs turning around so it points inward.

The product code is 170,557 lines, about €200,000 to rebuild. The check for the health of its packages couldn't finish, so that result is missing, not a clean pass.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Security and Compliance 50 · counts for 46%Production Readiness 53 · counts for 25%Maturity 61 · counts for 14%Performance 75 · counts for 8%Architecture 75 · counts for 4%Code Health 75 · counts for 2%Domain Modelling 100 · counts for 1%

If Security and Compliance rose from 50 to 70, the lowest score rated Strong, the score would rise from 56 to about 61.

Code composition: what the lines of code are
Product code 99%Tests 1%
New since the last survey: 334 findings

These 334 critical or serious findings weren't in the previous survey, on 24 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Cyclomatic Complexity · Builder.build (cyclomatic 16) .claude/skills/cherrypick-log/update_cherrypick_log.py
  • Code Duplication · Near-duplicate member pair (185 shared lines) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Near-duplicate member pair (83 shared lines) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Near-duplicate member pair (52 shared lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt
  • Code Duplication · Near-duplicate member pair (35 shared lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
  • Code Duplication · Edited copies of one member (3 members, 79+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt
  • Code Duplication · Edited copy of a member (67 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Edited copy of a member (64 corresponding lines) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
  • Code Duplication · Edited copies of one member (3 members, 57+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt
  • Code Duplication · Edited copy of a member (60 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/category/CategoryScreen.kt
  • Code Duplication · Edited copy of a member (64 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt
  • Code Duplication · Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt
  • Code Duplication · Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt
  • Code Duplication · Edited copy of a member (124 corresponding lines) app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt
  • Code Duplication · Edited copy of a member (48 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt
  • Code Duplication · Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt
  • Code Duplication · Edited copy of a member (50 corresponding lines) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt
  • Code Duplication · Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt
  • Code Duplication · Edited copy of a member (47 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
  • Code Duplication · Edited copies of one member (3 members, 50+ corresponding lines) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt
  • Code Duplication · Edited copy of a member (44 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
  • Code Duplication · Edited copy of a member (40 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt
  • Code Duplication · Edited copy of a member (44 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
  • Code Duplication · Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt
  • Code Duplication · Edited copy of a member (37 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt
  • Code Duplication · Edited copies of one member (4 members, 41+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt
  • Code Duplication · Edited copy of a member (37 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt
  • Code Duplication · Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt
  • Code Duplication · Edited copies of one member (3 members, 30+ corresponding lines) app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt
  • Code Duplication · Edited copy of a member (38 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt
  • Code Duplication · Edited copy of a member (37 corresponding lines) app/src/main/java/exh/util/OkHttpExtensions.kt
  • Code Duplication · Edited copies of one member (4 members, 35+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt
  • Code Duplication · Edited copy of a member (38 corresponding lines) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Edited copy of a member (41 corresponding lines) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt
  • Code Duplication · Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt
  • Code Duplication · Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
  • Code Duplication · Edited copy of a member (31 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Edited copy of a member (32 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt
  • Code Duplication · Edited copy of a member (32 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/connections/discord/DiscordRPCService.kt
  • Code Duplication · Edited copies of one member (3 members, 25+ corresponding lines) app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt
  • Code Duplication · Edited copy of a member (29 corresponding lines) domain/src/main/java/tachiyomi/domain/category/interactor/ReorderCategory.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresContent.kt
  • Code Duplication · Edited copy of a member (34 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/RelatedMangasScreen.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt
  • Code Duplication · Edited copy of a member (26 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt
  • Code Duplication · Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt
  • Code Duplication · Edited copy of a member (24 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/KitsuInterceptor.kt
  • Code Duplication · Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt
  • Code Duplication · Edited copy of a member (36 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/about/OpenSourceLibraryLicenseScreen.kt
  • Code Duplication · Edited copy of a member (12 corresponding lines) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateNotifier.kt
  • Code Duplication · Edited copy of a member (26 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt
  • Code Duplication · Edited copies of one member (4 members, 34+ corresponding lines) app/src/main/java/eu/kanade/presentation/category/BiometricTimesScreen.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/src/main/java/eu/kanade/presentation/reader/OrientationSelectDialog.kt
  • Code Duplication · Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadNotifier.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt
  • Code Duplication · Edited copies of one member (4 members, 22+ corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/util/chapter/ChapterGetNextUnread.kt
  • Code Duplication · Edited copy of a member (21 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) REDACTED
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupCreateJob.kt
  • Code Duplication · Edited copies of one member (3 members, 20+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt
  • Code Duplication · Edited copy of a member (24 corresponding lines) data/src/main/java/tachiyomi/data/source/FeedSavedSearchRepositoryImpl.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/presentation/manga/components/ChapterDownloadIndicator.kt
  • Code Duplication · Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupNotifier.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) REDACTED
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt
  • Code Duplication · Edited copies of one member (4 members, 21+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt
  • Code Duplication · Edited copy of a member (15 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt
  • Code Duplication · Edited copy of a member (13 corresponding lines) app/src/main/java/mihon/core/migration/migrations/DisabledRepoMigration.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt
  • Code Duplication · Edited copy of a member (16 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt
  • Code Duplication · Edited copies of one member (3 members, 49+ corresponding lines) REDACTED
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/reader/ChapterTransition.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt
  • Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt
  • Code Duplication · Edited copy of a member (24 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt
  • Code Duplication · Edited copies of one member (5 members, 18+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadCache.kt
  • Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) app/src/main/java/exh/md/handlers/BilibiliHandler.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) app/src/main/java/exh/md/handlers/ApiMangaParser.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) source-api/src/commonMain/kotlin/exh/metadata/metadata/EightMusesSearchMetadata.kt
  • Code Duplication · Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Edited copy of a member (16 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt
  • Code Duplication · Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/core/util/CollectionUtils.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt
  • Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/more/ComingUpdatesScreen.kt
  • Code Duplication · Edited copy of a member (11 corresponding lines) app/src/main/java/mihon/core/migration/migrations/MoveCacheToDiskSettingMigration.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) core/common/src/main/kotlin/tachiyomi/core/common/util/system/UrlUtils.kt
  • Code Duplication · Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 158 findings

These 158 critical or serious findings were in the previous survey, on 24 October 2026, and are gone from this one. The first 100 are listed here.

  • Code Duplication · Near-duplicate member pair (172 shared lines) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Near-duplicate member pair (70 shared lines) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Near-duplicate member pair (35 shared lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt
  • Code Duplication · Duplicated block (50–51 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (45–46 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (42 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt
  • Code Duplication · Duplicated block (38 lines × 3) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt
  • Code Duplication · Duplicated block (35–36 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt
  • Code Duplication · Duplicated block (32–35 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt
  • Code Duplication · Duplicated block (34 lines × 2) app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt
  • Code Duplication · Duplicated block (31 lines × 2) data/src/main/java/tachiyomi/data/manga/MangaMapper.kt
  • Code Duplication · Duplicated block (29 lines × 3) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt
  • Code Duplication · Duplicated block (27–29 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt
  • Code Duplication · Duplicated block (27–28 lines × 2) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt
  • Code Duplication · Duplicated block (26 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt
  • Code Duplication · Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt
  • Code Duplication · Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt
  • Code Duplication · Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt
  • Code Duplication · Duplicated block (22–24 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt
  • Code Duplication · Duplicated block (20–24 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Duplicated block (21–22 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt
  • Code Duplication · Duplicated block (22 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (21–22 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
  • Code Duplication · Duplicated block (20–21 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (21 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
  • Code Duplication · Duplicated block (19–20 lines × 2) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt
  • Code Duplication · Duplicated block (20 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt
  • Code Duplication · Duplicated block (20 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt
  • Code Duplication · Duplicated block (19 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt
  • Code Duplication · Duplicated block (19 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (18 lines × 4) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt
  • Code Duplication · Duplicated block (18 lines × 3) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt
  • Code Duplication · Duplicated block (18 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (17–18 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt
  • Code Duplication · Duplicated block (16–18 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt
  • Code Duplication · Duplicated block (18 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
  • Code Duplication · Duplicated block (18 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt
  • Code Duplication · Duplicated block (16 lines × 3) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (16 lines × 3) app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (15–16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaCover.kt
  • Code Duplication · Duplicated block (15–16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
  • Code Duplication · Duplicated block (16 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Duplicated block (14–15 lines × 4) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt
  • Code Duplication · Duplicated block (13–15 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
  • Code Duplication · Duplicated block (13–15 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt
  • Code Duplication · Duplicated block (13–15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt
  • Code Duplication · Duplicated block (14 lines × 3) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/CommonMangaItem.kt
  • Code Duplication · Duplicated block (13–14 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt
  • Code Duplication · Duplicated block (12–14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/src/main/java/mihon/core/migration/migrations/CategoryPreferencesCleanupMigration.kt
  • Code Duplication · Duplicated block (14 lines × 2) source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/UrlImportableSource.kt
  • Code Duplication · Duplicated block (13 lines × 3) app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt
  • Code Duplication · Duplicated block (13 lines × 3) app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt
  • Code Duplication · Duplicated block (13 lines × 3) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt
  • Code Duplication · Duplicated block (12–13 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (12–13 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt
  • Code Duplication · Duplicated block (11–12 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/components/TabbedDialog.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt
  • Code Duplication · Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt
  • Code Duplication · Duplicated block (12 lines × 2) data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt
  • Code Duplication · Duplicated block (11 lines × 4) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt
  • Code Duplication · Duplicated block (11 lines × 3) app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt
  • Code Duplication · Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/sync/service/GoogleDriveSyncService.kt
  • Code Duplication · Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt
  • Code Duplication · Duplicated block (11 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt
  • Code Duplication · Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt
Rebuild cost: about €200,000 · Estimate
Cost to rebuild€67,000 to €330,000, for 1,110 to 3,521 hours of work, about 1.4 person-years for 1 to 3 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 56. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeLarge: 170,557 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (3), REDACTED (2), REDACTED (2).
Raises the score by about 5 points · Low effort · Secrets (history)
2
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED (2), REDACTED.
Raises the score by about 5 points · Low effort · REDACTED Scanning
3
Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED.
Raises the score by about 2 points · Low effort · Supply-chain Provenance & Signing

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €200,000 to build again, about 1.4 person-years of work. Its weakest lens is Security and Compliance, at 50 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Resolve the 9 REDACTED finding(s) in Secrets (history). Of all the actions in this report, it raises the score most for the work it takes: about 5 points for low effort, because it clears the 9 Secrets (history) findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.2 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 4,508 lines over the last 90 days, which is about 18,282 lines a year. At that pace, the extra work comes to an estimated 0.9 to 6.1 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch :app :app :core-metadata :core-metadata :app->:core-metadata :core:archive :core:archive :app->:core:archive :core:common :core:common :app->:core:common :data :data :app->:data :domain :domain :app->:domain :flagkit :flagkit :app->:flagkit :i18n :i18n :app->:i18n :i18n-kmk :i18n-kmk :app->:i18n-kmk :i18n-sy :i18n-sy :app->:i18n-sy :presentation-core :presentation-core :app->:presentation-core :presentation-widget :presentation-widget :app->:presentation-widget :source-api :source-api :app->:source-api :source-local :source-local :app->:source-local :telemetry :telemetry :app->:telemetry :core-metadata->:source-api :core:archive->:core:common :core:common->:i18n :core:common->:i18n-sy :data->:core:common :data->:domain :data->:source-api :domain->:core:common :domain->:source-api :flagkit->:core:common :macrobenchmark :macrobenchmark :presentation-core->:core:common :presentation-core->:i18n :presentation-core->:i18n-sy :presentation-widget->:core:common :presentation-widget->:domain :presentation-widget->:i18n :presentation-widget->:presentation-core :source-api->:core:common :source-api->:i18n :source-api->:i18n-sy :source-local->:core-metadata :source-local->:core:archive :source-local->:core:common :source-local->:domain :source-local->:i18n :source-local->:i18n-sy :source-local->:source-api Komikku Komikku

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

811 modules, with 1876 dependencies between them. 20 loops run through 129 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 771 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 eu.kanade.presentation.util2 tachiyomi.core.common.preference3 tachiyomi.domain.category.model4 tachiyomi.domain.chapter.model5 tachiyomi.domain.track.model6 eu.kanade.tachiyomi.extension.model.Extension7 exh.metadata.metadata8 eu.kanade.tachiyomi.source.model9 eu.kanade.tachiyomi.data.database.models10 eu.kanade.tachiyomi.source.online11 tachiyomi.domain.manga.model12 tachiyomi.domain.source.model13 eu.kanade.presentation.manga.components14 eu.kanade.tachiyomi.data.track.model15 tachiyomi.domain.library.model16 tachiyomi.domain.source.service17 eu.kanade.domain.source.service18 tachiyomi.domain.library.service19 tachiyomi.domain.manga.interactor20 eu.kanade.domain.source.interactor21 eu.kanade.tachiyomi.extension22 tachiyomi.domain.category.interactor23 tachiyomi.domain.chapter.interactor24 eu.kanade.tachiyomi.data.download25 eu.kanade.tachiyomi.source26 eu.kanade.tachiyomi.ui.reader.viewer27 eu.kanade.tachiyomi.data.track28 eu.kanade.tachiyomi.ui.reader.setting29 eu.kanade.tachiyomi.data.cache30 eu.kanade.tachiyomi.ui.updates31 eu.kanade.domain.manga.interactor32 mihon.domain.source.interactor33 eu.kanade.tachiyomi.ui.browse.source.browse34 eu.kanade.tachiyomi.ui.library35 eu.kanade.tachiyomi.ui.reader36 exh.eh37 eu.kanade.tachiyomi.source.online.all38 eu.kanade.tachiyomi.ui.manga39 eu.kanade.presentation.browse40 eu.kanade.presentation.more.settings.screen
1 eu.kanade.presentation.util
2 tachiyomi.core.common.preference
3 tachiyomi.domain.category.model
4 tachiyomi.domain.chapter.model
5 tachiyomi.domain.track.model
6 eu.kanade.tachiyomi.extension.model.Extension1
7 exh.metadata.metadata8
8 eu.kanade.tachiyomi.source.model1
9 eu.kanade.tachiyomi.data.database.models11
10 eu.kanade.tachiyomi.source.online1148
11 tachiyomi.domain.manga.model22
12 tachiyomi.domain.source.model71
13 eu.kanade.presentation.manga.components62
14 eu.kanade.tachiyomi.data.track.model1
15 tachiyomi.domain.library.model1
16 tachiyomi.domain.source.service111
17 eu.kanade.domain.source.service21
18 tachiyomi.domain.library.service313
19 tachiyomi.domain.manga.interactor212421
20 eu.kanade.domain.source.interactor19115
21 eu.kanade.tachiyomi.extension311
22 tachiyomi.domain.category.interactor615
23 tachiyomi.domain.chapter.interactor8214
24 eu.kanade.tachiyomi.data.download5215411112131
25 eu.kanade.tachiyomi.source141111111
26 eu.kanade.tachiyomi.ui.reader.viewer112
27 eu.kanade.tachiyomi.data.track42151
28 eu.kanade.tachiyomi.ui.reader.setting211
29 eu.kanade.tachiyomi.data.cache11211
30 eu.kanade.tachiyomi.ui.updates121111221
31 eu.kanade.domain.manga.interactor4472111
32 mihon.domain.source.interactor1111111
33 eu.kanade.tachiyomi.ui.browse.source.browse2111323111331211111
34 eu.kanade.tachiyomi.ui.library1321111521264321312
35 eu.kanade.tachiyomi.ui.reader11111114132331
36 exh.eh5151152311
37 eu.kanade.tachiyomi.source.online.all115241231131911
38 eu.kanade.tachiyomi.ui.manga311221161111122433311611
39 eu.kanade.presentation.browse41810251
40 eu.kanade.presentation.more.settings.screen213123311
Uses a module listed above itPart of a loopThe module itself
1 eu.kanade.presentation.util2 tachiyomi.core.common.preference3 tachiyomi.domain.category.model4 tachiyomi.domain.chapter.model5 tachiyomi.domain.track.model6 eu.kanade.tachiyomi.extension.model.Extension7 exh.metadata.metadata8 eu.kanade.tachiyomi.source.model9 eu.kanade.tachiyomi.data.database.models10 eu.kanade.tachiyomi.source.online11 tachiyomi.domain.manga.model12 tachiyomi.domain.source.model13 eu.kanade.presentation.manga.components14 eu.kanade.tachiyomi.data.track.model15 tachiyomi.domain.library.model16 tachiyomi.domain.source.service17 eu.kanade.domain.source.service18 tachiyomi.domain.library.service19 tachiyomi.domain.manga.interactor20 eu.kanade.domain.source.interactor21 eu.kanade.tachiyomi.extension22 tachiyomi.domain.category.interactor23 tachiyomi.domain.chapter.interactor24 eu.kanade.tachiyomi.data.download25 eu.kanade.tachiyomi.source26 eu.kanade.tachiyomi.ui.reader.viewer27 eu.kanade.tachiyomi.data.track28 eu.kanade.tachiyomi.ui.reader.setting29 eu.kanade.tachiyomi.data.cache30 eu.kanade.tachiyomi.ui.updates31 eu.kanade.domain.manga.interactor32 mihon.domain.source.interactor33 eu.kanade.tachiyomi.ui.browse.source.browse34 eu.kanade.tachiyomi.ui.library35 eu.kanade.tachiyomi.ui.reader36 exh.eh37 eu.kanade.tachiyomi.source.online.all38 eu.kanade.tachiyomi.ui.manga39 eu.kanade.presentation.browse40 eu.kanade.presentation.more.settings.screeneu.kanade.presentation.util1tachiyomi.core.common.preference2tachiyomi.domain.category.model3tachiyomi.domain.chapter.model4tachiyomi.domain.track.model5eu.kanade.tachiyomi.extension.model.Extension6exh.metadata.metadata7eu.kanade.tachiyomi.source.model8eu.kanade.tachiyomi.data.database.models9eu.kanade.tachiyomi.source.online10tachiyomi.domain.manga.model11tachiyomi.domain.source.model12eu.kanade.presentation.manga.components13eu.kanade.tachiyomi.data.track.model14tachiyomi.domain.library.model15tachiyomi.domain.source.service16eu.kanade.domain.source.service17tachiyomi.domain.library.service18tachiyomi.domain.manga.interactor19eu.kanade.domain.source.interactor20eu.kanade.tachiyomi.extension21tachiyomi.domain.category.interactor22tachiyomi.domain.chapter.interactor23eu.kanade.tachiyomi.data.download24eu.kanade.tachiyomi.source25eu.kanade.tachiyomi.ui.reader.viewer26eu.kanade.tachiyomi.data.track27eu.kanade.tachiyomi.ui.reader.setting28eu.kanade.tachiyomi.data.cache29eu.kanade.tachiyomi.ui.updates30eu.kanade.domain.manga.interactor31mihon.domain.source.interactor32eu.kanade.tachiyomi.ui.browse.source.browse33eu.kanade.tachiyomi.ui.library34eu.kanade.tachiyomi.ui.reader35exh.eh36eu.kanade.tachiyomi.source.online.all37eu.kanade.tachiyomi.ui.manga38eu.kanade.presentation.browse39eu.kanade.presentation.more.settings.screen40181111148227162111112131321242119115311615821452154111121311411111111124215121111211121111221447211111111112111323111331211111132111152126432131211111114132331515115231111524123113191131122116111112243331161141810251213123311+771 more modules (most-connected shown)

At a glance — Code Health · 75% · Strong ·

At a glance — Architecture · 75% · Strong ·

At a glance — Maturity · 61% · Adequate · gated by M2 ·

At a glance — Readiness · 53% · Adequate · gated by D13, P3 ·

At a glance — Security · 50% · Weak · gated by D28, D29 ·

At a glance — Domain Modelling · 100% · Exemplary ·

At a glance — Performance · 75% · Strong ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A07:2025 — Authentication Failures15High / Critical
A05:2025 — Injection11High / Critical
A03:2025 — Software Supply Chain Failures5Medium

Roadmap

Top priorities: Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (3), REDACTED (2), REDACTED (2); Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED (2), REDACTED; Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (3), REDACTED (2), REDACTED (2).+4.7 ptsLowSecrets (history)
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED (2), REDACTED.+4.7 ptsLowREDACTED Scanning
Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED.+2.5 ptsLowSupply-chain Provenance & Signing
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.+2.4 ptsLowADR Quality
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.7 ptsMediumSecurity & performance tooling

File quality

Per-file score 0–10 — a quality signature. Of 272 files carrying findings, judged against the Production bar: 1% slop · 49% mixed · 50% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED0.8SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED3.0SlopREDACTED Scanning: Leaked secret: REDACTED
app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt4.9MixedCognitive Complexity: BrowseSourceScreenModel.searchGenre (cognitive 23)
REDACTED5.0MixedSecrets (history): REDACTED: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt5.1MixedCode Duplication: Edited copy of a member (64 corresponding lines)
app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt5.2MixedChange Coupling: Boundary-crossing change coupling: MainActivity.kt ↔ CrashlyticsPrinter.kt
app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt5.6MixedCyclomatic Complexity: HistoryScreenModel.toggleSelection (cyclomatic 17)
app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt5.7MixedCyclomatic Complexity: DuplicateMangaDialogKt.DuplicateMangaListItem (cyclomatic 21)
app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt5.7MixedGod Classes: MethodTooLong: MigrateSourceSearchScreen.Content
app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt5.7MixedCode Duplication: Edited copy of a member (40 corresponding lines)
app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt5.7MixedCode Duplication: Edited copy of a member (23 corresponding lines)
REDACTED5.9MixedStatic Analysis (SAST): Medium: REDACTED
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt6.0MixedExplicit Debt: TodoComment
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt6.0MixedExplicit Debt: FixmeComment
app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt6.0MixedExplicit Debt: TodoComment
presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 27

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 697

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 336

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 13

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 53 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 53 dimensions across the health lenses
D1D2D3D4D5D6D13D14D15D16D17D19D20D21D26D28D29D34D35D36D44AX10AX3AX4DM1DM10DM12DM6DM9M1M2M3M4P1P3P4P5P6PF1PF3X1X12X13X15X16X18X2X21X25X27X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1047 of 1060 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1d690-a47a-70a6-a89c-466f8c8bcebe.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository's dependency manifests WERE read and their pinning discipline assessed; what went unanswered is the currency half, because www.jitpack.io — the registry that answers it — was asked and did not reply (the build stopped because www.jitpack.io, a repository this project declares, refused it with HTTP 403 — what this scan's egress allowlist returns for a host that is not on it, so the dependency graph was not resolved). This is OUR side and it is an ENVIRONMENT fault, not a missing collector: the collector exists and ran. An HTTP 403 here is what this scan's egress allowlist returns for a host that is not on it, so the remedy is to add www.jitpack.io to the allowlist and re-run — not to build anything.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app/src/main/java/eu/kanade/domain/source/interactor/GetEnabledSources.kt`, `app/src/main/java/eu/kanade/presentation/browse/components/BaseSourceItem.kt`, `app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchToolbar.kt`, `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt`, `app/src/main/java/eu/kanade/presentation/manga/components/NamespaceTags.kt`, … (+48 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX6 Interface segregation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over the public interfaces this run's compilations declare, and none was loaded, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (telemetry/src/noop/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • DM8 Value-object opportunities — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds primitive parameters that travel together through several signatures of the domain (a missing value object). Its deterministic rule has not yet shown 95 % precision on adjudicated rows, so the clumps it finds are counted here and not published as findings, and the card carries no score. That is a limit of the analyzer, not a finding about your code.
  • DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Arm two tells a construction that PRODUCES a measurement from one that merely passes it along, and this repository's frontend does not compute that fact. A measurement built independently in two places would not appear above.
  • DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Some of this repository's production types come from a frontend that does not bind comparison operands to the members they read, which arm one needs, and those types were not walked for this dimension. The counts above speak for the languages that declare it.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Kotlin is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and no C#, JavaScript/TypeScript, Java, Dart, Ruby or Scala was found, and this repository's Kotlin is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, Scala, Ruby and Python source only, and no C# was loaded and no JavaScript/TypeScript, Java, Scala, Ruby or Python was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X3 Exception handling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 9 further occurrence(s) are not listed individually; the score already reflects all 49.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.4 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Prevented

61 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ImageUtil.chooseBackground at 71. A further 4 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being GetExtensionLanguages.getLanguageIconID at 125 — they are counted neither in the figure above nor in this dimension's score. 4 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt (GetExtensionLanguages.getLanguageIconID at 125), presentation-core/src/main/java/tachiyomi/presentation/core/icons/FlagEmoji.kt (FlagEmoji.lang2Country at 124), app/src/main/java/exh/ui/metadata/adapters/MetadataUIUtil.kt (MetadataUIUtil.getGenreAndColour at 29), app/src/main/java/exh/util/SourceTagsUtil.kt (SourceTagsUtil.getLocaleSourceUtil at 17). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

ImageUtil.chooseBackground (cyclomatic 71)core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:384
TrackStatus.parseTrackerStatus (cyclomatic 52)app/src/main/java/eu/kanade/tachiyomi/data/track/TrackStatus.kt:26
MangaScreen.MangaDetailContent (cyclomatic 40)app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:222
SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog (cyclomatic 39)app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:32
update_cherrypick_log.cmd_update (cyclomatic 38).claude/skills/cherrypick-log/update_cherrypick_log.py:902

+ 56 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 60 down to 60 or less in Cyclomatic Complexity — start with ImageUtil.chooseBackground (cyclomatic 71). — Refactoring it lifts Cyclomatic Complexity from 6.4 to about 6.5/10.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.9 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.9 / 10 · rule-coverage 100% · ceiling Prevented

74 method(s) exceeded the cognitive complexity threshold of 15; the worst was ImageUtil.chooseBackground at 108.

ImageUtil.chooseBackground (cognitive 108)core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:384
Builder.detect (cognitive 81).claude/skills/cherrypick-log/update_cherrypick_log.py:690
SyncChaptersWithSource.await (cognitive 57)app/src/main/java/eu/kanade/domain/chapter/interactor/SyncChaptersWithSource.kt:50
update_cherrypick_log.cmd_update (cognitive 54).claude/skills/cherrypick-log/update_cherrypick_log.py:902
update_cherrypick_log.flag_revert_chains (cognitive 53).claude/skills/cherrypick-log/update_cherrypick_log.py:771

+ 69 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 60 down to 60 or less in Cognitive Complexity — start with ImageUtil.chooseBackground (cognitive 108), Builder.detect (cognitive 81). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 5.9 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.6 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

63 god class(es) detected.

MethodTooLong: MangaScreen.MangaDetailContent · ×33app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:222
FileTooLong: manga/MangaScreenModel.kt · ×15app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
TooManyMethods: MangaScreenModel · ×9app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:173
ClassTooLong: MangaScreenModel · ×6app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:173

What to do

  1. Resolve the 33 MethodTooLong finding(s) in God Classes — start with BrowseSourceScreen.kt (2), MangaScreen.kt, LibraryTab.kt. — One of this dimension's main actionable groups (33 warning-level).
  2. Resolve the 15 FileTooLong finding(s) in God Classes — start with MangaScreen.kt (2), MangaScreenModel.kt, LibraryScreenModel.kt. — One of this dimension's main actionable groups (15 warning-level).
  3. Resolve the 9 TooManyMethods finding(s) in God Classes — start with MangaScreenModel.kt, ReaderViewModel.kt, EHentai.kt. — One of this dimension's main actionable groups (9 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication7.3 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Verified

191 duplicated block group(s) detected. 6.8 % of the production lines (11,587 of 170,557) are in a reported copy. A further 165 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (10 lines × 2) · ×13app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:306
Duplicated block (8 lines × 2) · ×13app/src/main/java/eu/kanade/presentation/components/Chip.kt:676
Duplicated block (11 lines × 2) · ×11app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:39
Duplicated block (14 lines × 2) · ×10app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:134
Duplicated block (13 lines × 2) · ×10app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt:153

+ 139 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 13 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with FeedScreen.kt, SourceFeedDialogs.kt, HistoryScreen.kt. — One of this dimension's main actionable groups (13 warning-level).
  2. Resolve the 13 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with Chip.kt (2), DuplicateMangaDialog.kt (2), SettingsDownloadScreen.kt. — One of this dimension's main actionable groups (13 warning-level).
  3. Resolve the 11 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with FeedScreenModel.kt (2), SortTagListItem.kt, Banners.kt. — One of this dimension's main actionable groups (11 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling8.9 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Prevented

17 production modules (Gradle), 0 dependency cycle(s), 1 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 2 module(s) off the main sequence, with abstractness counted on 12 of the 17 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Unstable project :source-local
Off the main sequence: :telemetry
Off the main sequence: :core:common

What to do

  1. Resolve the 1 Unstable project finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.3 / 10Stronggated by 16 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Verified

16 of 284 classes have LCOM4 above 3.

Low cohesion: FeedScreenModel (LCOM4 13) · ×16app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:60

What to do

  1. Resolve the 16 Low cohesion finding(s) in Cohesion (LCOM4) — start with FeedScreenModel.kt, MangaDexAuthService.kt, LibraryScreenModel.kt. — One of this dimension's main actionable groups (16 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Prevented

5 secret(s) detected.

REDACTED

What to do

  1. Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (5 issue-level).

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 44 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 23 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 17 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 11 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: .claude/skills/cherrypick-log/update_cherrypick_log.py (2×38=76) Repeated repair below the complexity floor: app/src/main/java/eu/kanade/presentation/util/Navigator.kt (4 of 5 changes were fixes); app/src/main/java/eu/kanade/tachiyomi/di/AppModule.kt (3 of 5 changes were fixes)

Repeated repair: app/src/main/java/eu/kanade/presentation/util/Navigator.kt · ×2app/src/main/java/eu/kanade/presentation/util/Navigator.kt:34
Hotspot: .claude/skills/cherrypick-log/update_cherrypick_log.py.claude/skills/cherrypick-log/update_cherrypick_log.py:902

What to do

  1. Resolve the 2 Repeated repair finding(s) in Churn × Complexity Hotspots — start with Navigator.kt, AppModule.kt. — One of this dimension's main actionable groups (2 warning-level).
  2. Resolve the 1 Hotspot finding(s) in Churn × Complexity Hotspots — start with update_cherrypick_log.py. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor9.4 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

40 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt. Counted over 612 of the 1369 production source files in this repository: 756 are under the ~2,400-byte size floor this dimension measures over, and the remaining 1 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.9 / 10Stronggated by 48 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

48 deducted task-comment markers across 170557 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×42source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt:249
FixmeComment · ×4app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:461
HackComment · ×2presentation-widget/src/main/java/tachiyomi/presentation/widget/util/GlanceUtils.kt:34

What to do

  1. Resolve the 42 TodoComment finding(s) in Explicit Debt — start with BiometricTimesScreenModel.kt (3), VerticalFastScroller.kt (2), ReaderViewModel.kt (2). — One of this dimension's main actionable groups (42 warning-level).
  2. Resolve the 4 FixmeComment finding(s) in Explicit Debt — start with LibraryScreenModel.kt (2), BulkFavoriteScreenModel.kt (2). — One of this dimension's main actionable groups (4 warning-level).
  3. Resolve the 2 HackComment finding(s) in Explicit Debt — start with GlanceUtils.kt, SearchableSettings.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 4 document(s) read across 1 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundapp/build.gradle.kts:7

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency8.7 / 10Strong✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 8.7 / 10 · rule-coverage 100% · ceiling Verified

5 naming inconsistencies among 379 declarations measured against a convention their peers follow.

`getLanguageIconID` spells `ID` where 369 names in the project spell it `Id`app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:42
`clientAPIKey` spells `API` where 22 names in the project spell it `Api`app/src/main/java/eu/kanade/domain/sync/SyncPreferences.kt:14
`uniqueDeviceID` spells `ID` where 369 names in the project spell it `Id`app/src/main/java/eu/kanade/domain/sync/SyncPreferences.kt:39
`getRandomID` spells `ID` where 369 names in the project spell it `Id`app/src/main/java/eu/kanade/tachiyomi/source/online/all/Lanraragi.kt:59
`mangaID` spells `ID` where 369 names in the project spell it `Id`app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:323

What to do

  1. Resolve the 1 `getLanguageIconID` spells `ID` where 369 names in the project spell it… finding(s) in Naming Consistency — start with GetExtensionLanguages.kt. — One of this dimension's main actionable groups (1 recommendation-level).
  2. Resolve the 1 `clientAPIKey` spells `API` where 22 names in the project spell it `Api` finding(s) in Naming Consistency — start with SyncPreferences.kt. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 `uniqueDeviceID` spells `ID` where 369 names in the project spell it… finding(s) in Naming Consistency — start with SyncPreferences.kt. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion7.1 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.1 / 10 · rule-coverage 100% · ceiling Documented

2 of 14 build units (Gradle) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)1.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 1.0 / 10 · rule-coverage 100% · ceiling Documented

9 finding(s): 0 critical, 9 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (3), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (9 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)3.9 / 10Weak✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 3.9 / 10 · rule-coverage 100% · ceiling Documented

11 finding(s): 0 critical, 3 high, 8 medium, 0 low. semgrep hit a parse error in 5 file(s) — `app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/SuwayomiApi.kt`, `app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateJob.kt` (line 36), `core/archive/src/main/kotlin/mihon/core/archive/CbzCrypto.kt` (line 142), `gradlew` (line 74, line 178), `REDACTED` (lines 93–98) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 5 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness5.4 / 10Adequate✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 5.4 / 10 · rule-coverage 100% · ceiling Documented

284 of 613 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt. Counted over 613 of the 1369 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledge · ×7app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:1
Orphaned file · ×277app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:1
Further orphaned files (smaller)

What to do

  1. Resolve the 277 Orphaned file finding(s) in Knowledge Freshness — start with Discord.kt (2), PagerViewer.kt, TrackerSearch.kt. — One of this dimension's main actionable groups (277 recommendation-level).
  2. Resolve the 7 Orphaned knowledge finding(s) in Knowledge Freshness — start with TrackInfoDialog.kt, NotificationReceiver.kt, Chip.kt. — One of this dimension's main actionable groups (7 issue-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.8 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: MigrateSourceSearchScreen.kt↔BrowseRecommendsScreen.kt 79%; MangaDexFollowsScreen.kt↔BrowseRecommendsScreen.kt 75%; UpdatesScreen.kt↔UpdatesTab.kt 71%

Boundary-crossing change coupling: MainActivity.kt ↔ CrashlyticsPrinter.ktapp/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:1
Change coupling: UpdatesScreen.kt ↔ UpdatesTab.kt · ×15app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt:1
Change-coupling hub: BrowseRecommendsScreen.kt → BrowseSourceSimpleToolbar.kt, MigrateSourceSearchScreen.kt, BrowseSourceScreen.kt, MangaDexFollowsScreen.kt · ×3app/src/main/java/exh/recs/BrowseRecommendsScreen.kt

What to do

  1. Resolve the 1 Boundary-crossing change coupling finding(s) in Change Coupling — start with MainActivity.kt. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 15 Change coupling finding(s) in Change Coupling — start with MigrateSearchScreen.kt (3), GlobalSearchScreen.kt (2), UpdatesScreen.kt. — One of this dimension's main actionable groups (15 warning-level).
  3. Resolve the 3 Change-coupling hub finding(s) in Change Coupling — start with BrowseRecommendsScreen.kt, LibraryScreenModel.kt, TabbedScreen.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 0 platform declaration(s) and 55 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition8.4 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction6.1 / 10Adequate✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

  • `:domain` is a Domain project but references `:source-api`, a Web project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.

What to do

  • Keep dependencies pointing inward: domain/application define interfaces, infrastructure/web implement them (Dependency Inversion).
DM1 · Aggregate boundaries10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.

Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.

Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.

DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

M1 · Documentation (README)6.2 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 9 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:8

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P5 · DR & Backup4.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

PF1 · Benchmark discipline9.5 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • `init` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:418
  • `getPages` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ArchivePageLoader.kt:62
  • `withTransaction` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — data/src/main/java/tachiyomi/data/TransactionContext.kt:41
  • `acquireTransactionThread` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — data/src/main/java/tachiyomi/data/TransactionContext.kt:100

What to do

  • Kotlin: call the suspend function directly instead of wrapping it in runBlocking, use delay() instead of Thread.sleep, and move unavoidable blocking I/O into withContext(Dispatchers.IO).
X1 · Async correctness8.0 / 10Strong✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • `runBlocking` parks the calling thread until its block finishes, and this is already running in a coroutine, on a dispatcher's thread. On a single-threaded dispatcher (`Dispatchers.Main`, a `limitedParallelism(1)` view) the block can need that very thread to make progress — a deadlock — and on any dispatcher it takes a thread out of the pool for the wait; the library documents that `runBlocking` "should not be used from a coroutine". The suspending call can simply be made here: call it directly, or `coroutineScope { … }` / `withContext(…) { … }` for a block. Where a non-suspending function in between forces the bridge, make that function `suspend` too. — app/src/main/java/exh/debug/DebugFunctions.kt:148

What to do

  • `runBlocking` inside a coroutine
X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader3.5 / 10Weak✓ Tool-verified

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

  • `size` is read from the bytes being parsed at line 92 (`getInt`), then used to size a `ByteArray` at line 93 — and nowhere in its scope is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining and a maximum the format allows before allocating. — app/src/main/java/exh/eh/MemAutoFlushingLookupTable.kt:93

What to do

  • Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×4) — telemetry/src/firebase/kotlin/exh/log/CrashlyticsPrinter.kt:19, core/common/src/main/kotlin/eu/kanade/tachiyomi/network/OkHttpExtensions.kt:82, app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:192, …
  • `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×19) — REDACTED:342, data/src/main/java/mihon/data/extension/service/ExtensionStoreService.kt:126, core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:69, …
  • `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×16) — domain/src/main/java/tachiyomi/domain/library/model/LibrarySortMode.kt:122, domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChapterByUrlAndMangaId.kt:13, data/src/main/java/tachiyomi/data/manga/CustomMangaRepositoryImpl.kt:26, …
  • `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — app/src/main/java/exh/util/ExceptionUtil.kt:6

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X5 · Nullable reference types9.7 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health75%StrongSolid.
Architecture75%StrongSolid.
Maturity61%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness53%Adequate — gated by D13, P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security50%Weak — gated by D28, D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling100%ExemplaryStrongest area.
Performance75%StrongSolid.
Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 36 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 5 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X9 Subsumed condition operand — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not included — 71 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — Not applicable: this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~996 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D12 Dependency Hygiene — Dependency currency not established — www.jitpack.io did not answer
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 53 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
  • DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
  • DM8 Value-object opportunities — not scored — the deterministic rule found 0 candidate clump(s); its rows are withheld until it has a measured precision of 95 % (a sample of fewer than 10 rows cannot show one)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P2 Observability — This repository's JVM source (13 module(s), 1356 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 27 finding(s)
D28 · Secrets (history) · REDACTED · ×9
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D34 · Knowledge Freshness · Orphaned knowledge · ×7
  • Orphaned knowledge app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge app/src/main/java/eu/kanade/presentation/components/Chip.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge app/src/main/java/exh/assets/ehassets/MangadexLogo.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge app/src/main/java/eu/kanade/tachiyomi/data/connections/discord/DiscordRPCService.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
D13 · REDACTED Scanning · Leaked secret · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AX4 · Dependency direction · Dependency-rule violation · ×1
  • Dependency-rule violation: :domain (Domain) → :source-api (Web) — `:domain` is a Domain project but references `:source-api`, a Web project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D35 · Change Coupling · Boundary-crossing change coupling · ×1
  • Boundary-crossing change coupling: MainActivity.kt ↔ CrashlyticsPrinter.kt app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:1 — `app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt` (context main) and `telemetry/src/firebase/kotlin/exh/log/CrashlyticsPrinter.kt` (context telemetry) sit in DIFFERENT parts of the tree yet change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `3623b4ef` Change foss variant application id suffix to '.foss' and more (mihona… (at that commit the file was still `app/src/analytics-firebase/kotlin/exh/log/CrashlyticsPrinter.kt`); `6178e1cf` Fix CrashlyticsPrinter & preview_version (at that commit the file was still `app/src/standard/java/exh/log/CrashlyticsPrinter.kt`); `ffd5b4eb` Fix crashlytics while using custom global exception handler (#338) (at that commit the file was still `app/src/main/java/exh/log/CrashlyticsPrinter.kt`) — run `git show` on any of them.
X1 · Async correctness · `runBlocking` inside a coroutine · ×1
  • `runBlocking` inside a coroutine app/src/main/java/exh/debug/DebugFunctions.kt:148 — `runBlocking` parks the calling thread until its block finishes, and this is already running in a coroutine, on a dispatcher's thread. On a single-threaded dispatcher (`Dispatchers.Main`, a `limitedParallelism(1)` view) the block can need that very thread to make progress — a deadlock — and on any dispatcher it takes a thread out of the pool for the wait; the library documents that `runBlocking` "should not be used from a coroutine". The suspending call can simply be made here: call it directly, or `coroutineScope { … }` / `withContext(…) { … }` for a block. Where a non-suspending function in between forces the bridge, make that function `suspend` too.
Serious — 697 finding(s)
D17 · Explicit Debt · TodoComment · ×42
  • TodoComment source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt:249 — // TODO: remove support for this entirely after a while — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment source-api/src/commonMain/kotlin/exh/metadata/metadata/EHentaiSearchMetadata.kt:61 — // todo — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/exh/ui/metadata/adapters/MangaDexDescriptionAdapter.kt:47 — // todo — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/exh/md/handlers/ApiMangaParser.kt:264 — // todo — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:82 — // todo — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/ConfigurableSource.kt:24 — // TODO: use getSourcePreferences once all extensions are on ext-lib 1.5 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:273 — // TODO: Ideally rewrite VerticalGridFastScroller to use similar logic as VerticalFastScroller — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:428 — // TODO: not sure why abs corrections are in the following functions; these can probably be removed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment macrobenchmark/src/main/java/tachiyomi/macrobenchmark/BaselineProfileGenerator.kt:24 — // TODO: automate storage permissions and possibly open manga details screen too? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/common/src/main/kotlin/tachiyomi/core/common/i18n/Localize.kt:28 — // TODO: janky workaround for https://github.com/icerockdev/moko-resources/issues/337
  • TodoComment app/src/main/java/exh/favorites/FavoritesSyncHelper.kt:51 — // TODO only apply database changes after sync — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/util/system/DisplayExtensions.kt:25 — // TODO: move the logic to `isTabletUi()` when main activity is rewritten in Compose — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:207 — // TODO: updateDownloadState(activeDownload.apply { status = Download.State.NOT_DOWNLOADED }) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:228 — // // TODO: Refresh chapters state for Local source — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaCoverScreenModel.kt:102 — // TODO: Handle animated cover — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:570 — // TODO: handle error — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/category/biometric/BiometricTimesScreenModel.kt:31 — // todo usecase — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/category/biometric/BiometricTimesScreenModel.kt:53 — // todo usecase — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/category/biometric/BiometricTimesScreenModel.kt:71 — // todo usecase — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:346 — // TODO: also allow deleting chapters when remove favorite (just like in [MangaScreenModel]) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/AutoCompleteItem.kt:145 — // todo remove if focus bug is fixed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:98 — // TODO Consider gallery updating when doing tabbed browsing — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/data/track/BaseTracker.kt:44 — // TODO: Store all scores as 10 point in the future maybe? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/data/track/Tracker.kt:42 — // TODO: Store all scores as 10 point in the future maybe? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/eu/kanade/tachiyomi/data/track/Tracker.kt:72 — // TODO: move this to an interactor, and update all trackers based on common data — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 17 more in this group — see findings.md.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×36
  • Swallowed exception (caught, then discarded) REDACTED:342 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) domain/src/main/java/tachiyomi/domain/library/model/LibrarySortMode.kt:122 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChapterByUrlAndMangaId.kt:13 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) data/src/main/java/tachiyomi/data/manga/CustomMangaRepositoryImpl.kt:26 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) data/src/main/java/mihon/data/extension/service/ExtensionStoreService.kt:126 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:69 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:91 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/tachiyomi/core/common/preference/AndroidPreference.kt:185 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/tachiyomi/core/common/preference/AndroidPreference.kt:206 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/eu/kanade/tachiyomi/util/system/DeviceUtil.kt:42 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/eu/kanade/tachiyomi/util/system/DeviceUtil.kt:60 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:58 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:70 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:82 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:241 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:283 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/mihon/core/migration/migrations/MergedMangaRewriteMigration.kt:156 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/mihon/core/migration/migrations/MergedMangaRewriteMigration.kt:184 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/exh/GalleryAdder.kt:53 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/exh/GalleryAdder.kt:91 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/exh/util/ExceptionUtil.kt:6 — `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/exh/md/utils/MdUtil.kt:166 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1404 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:672 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/Suwayomi.kt:92 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • + 11 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×33
  • MethodTooLong: MangaScreen.MangaDetailContent app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:222 — MethodTooLong — MangaDetailContent runs 297 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 197 over it, 2.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BrowseSourceScreen.Content app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:105 — MethodTooLong — Content runs 260 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 160 over it, 2.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LibraryTab.Content app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryTab.kt:109 — MethodTooLong — Content runs 255 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 155 over it, 2.55× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ThemeColorPickerWidgetKt.ThemeColorPickerWidget app/src/main/java/eu/kanade/presentation/more/settings/widget/ThemeColorPickerWidget.kt:58 — MethodTooLong — ThemeColorPickerWidget runs 218 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 118 over it, 2.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MainActivity.onCreate app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:195 — MethodTooLong — onCreate runs 166 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 66 over it, 1.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DownloadQueueScreen.Content app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadQueueScreen.kt:69 — MethodTooLong — Content runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SourceFeedScreen.Content app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:56 — MethodTooLong — Content runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MangaToolbarKt.MangaToolbar app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt:40 — MethodTooLong — MangaToolbar runs 153 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 53 over it, 1.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ExhUtilsKt.ExhUtils app/src/main/java/eu/kanade/presentation/reader/appbars/ExhUtils.kt:46 — MethodTooLong — ExhUtils runs 143 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 43 over it, 1.43× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MangaInfoHeaderKt.MangaContentInfo app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:666 — MethodTooLong — MangaContentInfo runs 142 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 42 over it, 1.42× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FeedTabKt.feedTab app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt:46 — MethodTooLong — feedTab runs 134 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 34 over it, 1.34× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AboutScreen.Content app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt:68 — MethodTooLong — Content runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DiscordLoginScreen.Content app/src/main/java/eu/kanade/tachiyomi/ui/setting/connections/DiscordLoginScreen.kt:76 — MethodTooLong — Content runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SettingsDiscordScreen.getPreferences app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordScreen.kt:68 — MethodTooLong — getPreferences runs 129 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 29 over it, 1.29× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MangaBottomActionMenuKt.LibraryBottomActionMenu app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:259 — MethodTooLong — LibraryBottomActionMenu runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Companion.getLanguageIconID app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:42 — MethodTooLong — getLanguageIconID runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SyncChaptersWithSource.await app/src/main/java/eu/kanade/domain/chapter/interactor/SyncChaptersWithSource.kt:50 — MethodTooLong — await runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MigrateSourceSearchScreen.Content app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:65 — MethodTooLong — Content runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MangaChapterListItemKt.MangaChapterListItem app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt:50 — MethodTooLong — MangaChapterListItem runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReaderPageActionsDialogKt.ReaderPageActionsDialog app/src/main/java/eu/kanade/presentation/reader/ReaderPageActionsDialog.kt:32 — MethodTooLong — ReaderPageActionsDialog runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MigrationConfigScreenSheetKt.MigrationConfigScreenSheet app/src/main/java/mihon/feature/migration/config/MigrationConfigScreenSheet.kt:51 — MethodTooLong — MigrationConfigScreenSheet runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AdaptiveSheetKt.AdaptiveSheet presentation-core/src/main/java/tachiyomi/presentation/core/components/AdaptiveSheet.kt:53 — MethodTooLong — AdaptiveSheet runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: EditMangaDialogKt.onViewCreated app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:234 — MethodTooLong — onViewCreated runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ExtensionDetailsScreenKt.DetailsHeader app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt:242 — MethodTooLong — DetailsHeader runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MangaCoverDialogKt.MangaCoverDialog app/src/main/java/eu/kanade/presentation/manga/components/MangaCoverDialog.kt:61 — MethodTooLong — MangaCoverDialog runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • + 8 more in this group — see findings.md.
D6 · Cohesion (LCOM4) · Low cohesion · ×16
  • Low cohesion: FeedScreenModel (LCOM4 13) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:60 — FeedScreenModel's methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MangaDexAuthService (LCOM4 13) app/src/main/java/exh/md/service/MangaDexAuthService.kt:23 — MangaDexAuthService's methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: LibraryScreenModel (LCOM4 11) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:132 — LibraryScreenModel's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MangaDexService (LCOM4 11) app/src/main/java/exh/md/service/MangaDexService.kt:28 — MangaDexService's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SourceFeedScreenModel (LCOM4 9) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:71 — SourceFeedScreenModel's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: HistoryScreenModel (LCOM4 7) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:56 — HistoryScreenModel's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: UpdatesScreenModel (LCOM4 7) app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:61 — UpdatesScreenModel's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: BrowseSourceScreenModel (LCOM4 6) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:93 — BrowseSourceScreenModel's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: NHentai (LCOM4 5) app/src/main/java/eu/kanade/tachiyomi/source/online/all/NHentai.kt:36 — NHentai's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MangaScreenModel (LCOM4 5) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:173 — MangaScreenModel's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: StatsScreenModel (LCOM4 5) app/src/main/java/eu/kanade/tachiyomi/ui/stats/StatsScreenModel.kt:32 — StatsScreenModel's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Kitsu (LCOM4 4) app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:19 — Kitsu's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ExtensionDetailsScreenModel (LCOM4 4) app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/ExtensionDetailsScreenModel.kt:35 — ExtensionDetailsScreenModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SearchScreenModel (LCOM4 4) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/SearchScreenModel.kt:38 — SearchScreenModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SortTagScreenModel (LCOM4 4) app/src/main/java/eu/kanade/tachiyomi/ui/category/genre/SortTagScreenModel.kt:23 — SortTagScreenModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SourceCategoryScreenModel (LCOM4 4) app/src/main/java/eu/kanade/tachiyomi/ui/category/sources/SourceCategoryScreenModel.kt:23 — SourceCategoryScreenModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
D3 · God Classes · FileTooLong · ×15
  • FileTooLong: manga/MangaScreenModel.kt app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt — FileTooLong — 1368 significant lines (blank, comment-only and punctuation-only lines excluded), about 83% of them inside a single declaration: MangaScreenModel (173-2098). The bar is 500 significant lines; this is 868 over it, 2.74× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: library/LibraryScreenModel.kt app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt — FileTooLong — 1196 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: LibraryScreenModel (132-1839). The bar is 500 significant lines; this is 696 over it, 2.39× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: manga/MangaScreen.kt app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt — FileTooLong — 1073 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 573 over it, 2.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: all/EHentai.kt app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt — FileTooLong — 1013 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 513 over it, 2.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: reader/ReaderActivity.kt app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt — FileTooLong — 968 significant lines (blank, comment-only and punctuation-only lines excluded), about 85% of them inside a single declaration: ReaderActivity (152-1554). The bar is 500 significant lines; this is 468 over it, 1.94× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/SettingsEhScreen.kt app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt — FileTooLong — 941 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 441 over it, 1.88× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: reader/ReaderViewModel.kt app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt — FileTooLong — 911 significant lines (blank, comment-only and punctuation-only lines excluded), about 88% of them inside a single declaration: ReaderViewModel (113-1548). The bar is 500 significant lines; this is 411 over it, 1.82× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: cherrypick-log/update_cherrypick_log.py .claude/skills/cherrypick-log/update_cherrypick_log.py — FileTooLong — 855 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 355 over it, 1.71× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: components/MangaInfoHeader.kt app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt — FileTooLong — 736 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 236 over it, 1.47× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: track/TrackInfoDialog.kt app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt — FileTooLong — 657 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 157 over it, 1.31× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/SettingsAdvancedScreen.kt app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAdvancedScreen.kt — FileTooLong — 650 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 150 over it, 1.30× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: manga/MangaScreen.kt app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt — FileTooLong — 628 significant lines (blank, comment-only and punctuation-only lines excluded), about 81% of them inside a single declaration: MangaScreen (123-937). The bar is 500 significant lines; this is 128 over it, 1.26× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/SettingsDataScreen.kt app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt — FileTooLong — 626 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 126 over it, 1.25× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: library/LibraryUpdateJob.kt app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt — FileTooLong — 552 significant lines (blank, comment-only and punctuation-only lines excluded), about 81% of them inside a single declaration: LibraryUpdateJob (106-901). The bar is 500 significant lines; this is 52 over it, 1.10× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/SettingsReaderScreen.kt app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt — FileTooLong — 503 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 3 over it, 1.01× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D35 · Change Coupling · Change coupling · ×15
  • Change coupling: UpdatesScreen.kt ↔ UpdatesTab.kt app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesTab.kt` change together 71% of the time (10 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `3e7dc5c4` Add Filters to Updates screen (mihonapp/mihon#2851); `c52de8c4` feat(updates-screen): Swipe actions for chapter updates (#915); `1f3d2cbd` Group update entries together (#610) — run `git show` on any of them.
  • Change coupling: Banners.kt ↔ MainActivity.kt app/src/main/java/eu/kanade/presentation/components/Banners.kt:1 — `app/src/main/java/eu/kanade/presentation/components/Banners.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `050c661c` progress-banner (#163); `274aefb3` feat(ui): Add restoring & syncing banner; `98e4ca48` Revert "Fix banners-related issues" (#9186) — run `git show` on any of them.
  • Change coupling: MigrateSearchScreen.kt ↔ GlobalSearchScreen.kt app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSearchScreen.kt:1 — `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSearchScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchScreen.kt` change together 68% of the time (17 of the 25 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 17 shared commits counted here, the most recent 3 are `d33efced` refactor(network-to-local): simplify networkToLocalManga (#910); `3310784f` chore(network-local-manga): Reintroduce (in-memory) fast browsing (#909); `fa7b1859` Allow `migrate` mangas when using `Bulk-favorite` (#824) — run `git show` on any of them.
  • Change coupling: MigrateSourceSearchScreen.kt ↔ MangaDexFollowsScreen.kt app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:1 — `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt` and `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` change together 68% of the time (21 of the 31 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 21 shared commits counted here, the most recent 3 are `d33efced` refactor(network-to-local): simplify networkToLocalManga (#910) (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`); `3310784f` chore(network-local-manga): Reintroduce (in-memory) fast browsing (#909) (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`); `fa7b1859` Allow `migrate` mangas when using `Bulk-favorite` (#824) (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`) — run `git show` on any of them.
  • Change coupling: ReaderBottomBar.kt ↔ ReaderActivity.kt app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderBottomBar.kt:1 — `app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderBottomBar.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt` change together 64% of the time (9 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `77ecb975` Make reader edge-to-edge (mihonapp/mihon#1908); `3e473e56` Reorder reader menu overflow items (at that commit the file was still `app/src/main/java/eu/kanade/presentation/reader/appbars/BottomReaderBar.kt`); `a8276011` Add an "open in browser" button to reader menu (mihonapp/mihon#1110) (at that commit the file was still `app/src/main/java/eu/kanade/presentation/reader/appbars/BottomReaderBar.kt`) — run `git show` on any of them.
  • Change coupling: BrowseSourceScreenModel.kt ↔ NetworkToLocalManga.kt app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:1 — `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt` and `domain/src/main/java/tachiyomi/domain/manga/interactor/NetworkToLocalManga.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `3310784f` chore(network-local-manga): Reintroduce (in-memory) fast browsing (#909); `712a1f2b` Significantly improve browsing speed (near instantaneous) (mihonapp/m…; `d23130b3` Revert "Fast browsing (#612)" — run `git show` on any of them.
  • Change coupling: HistoryScreen.kt ↔ HistoryItem.kt app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt` and `app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt` change together 59% of the time (10 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `8f57f4a5` feat(history): Allow multi/range-selection and batch reset for histor…; `f373818d` feat(history): Add Filters to History screen (#1433); `5dae177b` feat(history): Add indicator for un-finished reading & has more un-re… — run `git show` on any of them.
  • Change coupling: GlobalSearchScreen.kt ↔ GlobalSearchScreenModel.kt app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchScreenModel.kt` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `88950153` hide Pinned chip in Global/Migrate Search if no pinned sources available; `7b763712` Dedupe SearchScreenModels; `996d47e0` Replicate global search filters to migrate screen — run `git show` on any of them.
  • Change coupling: MigrateSearchScreen.kt ↔ GlobalSearchToolbar.kt app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchToolbar.kt` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `88950153` hide Pinned chip in Global/Migrate Search if no pinned sources available; `a4038555` show loading indicator while bulk-selection is running; `df229af0` migrate the rest to BulkSelectionScreenModel — run `git show` on any of them.
  • Change coupling: GlobalSearchScreen.kt ↔ GlobalSearchToolbar.kt app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchToolbar.kt` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `88950153` hide Pinned chip in Global/Migrate Search if no pinned sources available; `a4038555` show loading indicator while bulk-selection is running; `df229af0` migrate the rest to BulkSelectionScreenModel — run `git show` on any of them.
  • Change coupling: DuplicateMangaDialog.kt ↔ MangaDexFollowsScreen.kt app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:1 — `app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt` and `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` change together 53% of the time (10 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `f8ef5d4c` feat(duplicate-manga): Add target manga name in duplicate dialogs (#921); `fa7b1859` Allow `migrate` mangas when using `Bulk-favorite` (#824); `28fae365` `Bulk-favorite` fully uses new multi-Duplicate dialog — run `git show` on any of them.
  • Change coupling: SourcesFilterScreen.kt ↔ SourcesScreen.kt app/src/main/java/eu/kanade/presentation/browse/SourcesFilterScreen.kt:1 — `app/src/main/java/eu/kanade/presentation/browse/SourcesFilterScreen.kt` and `app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt` change together 50% of the time (11 of the 22 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `b648afb8` fix(sticky-header): Fix sticky-header and scrolling issues in source …; `486dc91b` Don't use animateItem's fade-in/fade-out in FastScrollLazyColumn; `1d5f906a` refactor: Use modifier instead of contentPadding for ScrollbarLazyCol… — run `git show` on any of them.
  • Change coupling: ReaderAppBars.kt ↔ ReaderBottomBar.kt app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt:1 — `app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt` and `app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderBottomBar.kt` change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `77ecb975` Make reader edge-to-edge (mihonapp/mihon#1908); `3e473e56` Reorder reader menu overflow items (at that commit the file was still `app/src/main/java/eu/kanade/presentation/reader/appbars/BottomReaderBar.kt`); `a8276011` Add an "open in browser" button to reader menu (mihonapp/mihon#1110) (at that commit the file was still `app/src/main/java/eu/kanade/presentation/reader/appbars/BottomReaderBar.kt`) — run `git show` on any of them.
  • Change coupling: MigrateSearchScreen.kt ↔ GlobalSearchScreenModel.kt app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSearchScreen.kt:1 — `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSearchScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchScreenModel.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `88950153` hide Pinned chip in Global/Migrate Search if no pinned sources available; `f6f00cf3` Trigger new search on source filter change; `7b763712` Dedupe SearchScreenModels — run `git show` on any of them.
  • Change coupling: BrowseSourceSimpleToolbar.kt ↔ MigrateSourceSearchScreen.kt app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt:1 — `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `fa7b1859` Allow `migrate` mangas when using `Bulk-favorite` (#824) (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`); `c643d8a5` Add bulk-selection & improve display mode in RecommendsScreen (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`); `a4038555` show loading indicator while bulk-selection is running (at that commit the file was still `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/SourceSearchScreen.kt`) — run `git show` on any of them.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×13
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:306 — app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:306-315 | app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:343-352 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:306` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:47 — app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:47-56 | app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:73-82 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:47` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:84 — app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:84-95 | app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt:186-195 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:84` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt:140 — app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt:140-149 | app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt:153-162 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt:250 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt:250-259 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt:264-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:262 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:262-271 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:388-397 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:262` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) REDACTED:46 — REDACTED:46-55 | REDACTED:64-73 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) REDACTED:59 — REDACTED:59-68 | app/src/main/java/eu/kanade/tachiyomi/data/track/komga/Komga.kt:56-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:59` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) REDACTED:178 — REDACTED:178-187 | REDACTED:199-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:178` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:146 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:146-155 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:176-185 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:146` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt:74 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt:74-83 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonAdapter.kt:48-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:123 — app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:123-132 | app/src/main/java/exh/ui/metadata/adapters/PururinDescriptionAdapter.kt:85-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/eu/kanade/domain/chapter/model/ChapterFilter.kt:56 — app/src/main/java/eu/kanade/domain/chapter/model/ChapterFilter.kt:56-65 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:2086-2095 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×13
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:676 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:676-683 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:311-318 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/components/Chip.kt` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/Chip.kt:676` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt:147 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt:147-154 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt:134-141 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt:147` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:152 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:152-159 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:406-413 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:152` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt:25 — data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt:25-32 | data/src/main/java/tachiyomi/data/source/SourcePagingSource.kt:89-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt:25` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:76 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:76-83 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:294-301 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:76` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:403 — app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:403-410 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:803-810 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) core-metadata/src/main/java/tachiyomi/core/metadata/comicinfo/ComicInfo.kt:12 — core-metadata/src/main/java/tachiyomi/core/metadata/comicinfo/ComicInfo.kt:12-19 | source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt:175-182 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:685 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:685-692 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:320-327 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/components/Chip.kt` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:92 — app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:92-99 | app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:45-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChaptersByMangaId.kt:12 — domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChaptersByMangaId.kt:12-19 | domain/src/main/java/tachiyomi/domain/chapter/interactor/GetMergedChaptersByMangaId.kt:53-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `domain/src/main/java/tachiyomi/domain/chapter/interactor/GetMergedChaptersByMangaId.kt:53` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) domain/src/main/java/tachiyomi/domain/manga/interactor/GetMergedManga.kt:13 — domain/src/main/java/tachiyomi/domain/manga/interactor/GetMergedManga.kt:13-20 | domain/src/main/java/tachiyomi/domain/track/interactor/GetTracks.kt:23-30 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) domain/src/main/java/tachiyomi/domain/source/interactor/InsertFeedSavedSearch.kt:13 — domain/src/main/java/tachiyomi/domain/source/interactor/InsertFeedSavedSearch.kt:13-20 | domain/src/main/java/tachiyomi/domain/source/interactor/InsertSavedSearch.kt:13-20 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:394 — app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:394-401 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:819-826 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×11
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:39 — app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:39-49 | app/src/main/java/eu/kanade/presentation/category/components/sources/SourceCategoryListItem.kt:37-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:39` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Label` names `androidx.compose.material.icons.automirrored.outlined.Label` in one and `androidx.compose.material.icons.outlined.Label` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/presentation/category/components/sources/SourceCategoryListItem.kt:36` calls `onRename` and `app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:38` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/presentation/components/Banners.kt:125 — app/src/main/java/eu/kanade/presentation/components/Banners.kt:125-135 | app/src/main/java/eu/kanade/presentation/components/Banners.kt:139-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/Banners.kt:125` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/sync/service/GoogleDriveSyncService.kt:316 — app/src/main/java/eu/kanade/tachiyomi/data/sync/service/GoogleDriveSyncService.kt:316-326 | app/src/main/java/eu/kanade/tachiyomi/data/sync/service/GoogleDriveSyncService.kt:367-377 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:466 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:466-476 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt:303-313 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 34 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:466` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:43 — app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:43-53 | app/src/main/java/exh/ui/intercept/InterceptActivity.kt:55-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:86 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:86-96 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:306-316 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:439 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:439-449 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:898-908 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:221 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:221-231 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:322-332 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:221` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:171 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:171-181 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:379-389 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:171` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `feed` to `FeedItemUI` in one and `SourceFeedUI.SourceSavedSearch` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:330 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:330-340 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:254-264 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:205 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:205-215 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:132-142 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×10
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:134 — app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:134-147 | app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:148-161 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:134` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:30 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:30-43 | app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt:44-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt:28 — app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt:28-41 | app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:33-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Label` names `androidx.compose.material.icons.automirrored.outlined.Label` in one and `androidx.compose.material.icons.outlined.Label` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/CommonMangaItem.kt:250 — app/src/main/java/eu/kanade/presentation/library/components/CommonMangaItem.kt:250-263 | app/src/main/java/eu/kanade/presentation/library/components/CommonMangaItem.kt:269-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:266 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:266-279 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:361-374 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:266` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:213 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:213-226 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:201-214 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:200 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:200-213 | app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt:111-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:200` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/SuwayomiApi.kt:49 — app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/SuwayomiApi.kt:49-62 | app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/SuwayomiApi.kt:100-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/SuwayomiApi.kt:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/UrlImportableSource.kt:23 — source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/UrlImportableSource.kt:23-36 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/UrlImportableSource.kt:39-52 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/widget/ThemeColorPickerWidget.kt:136 — app/src/main/java/eu/kanade/presentation/more/settings/widget/ThemeColorPickerWidget.kt:136-149 | app/src/main/java/eu/kanade/presentation/more/settings/widget/ThemeColorPickerWidget.kt:163-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×10
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt:153 — app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt:153-165 | app/src/main/java/mihon/feature/migration/config/MigrationConfigScreen.kt:278-290 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/SourcesScreen.kt:153` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:258 — app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:258-270 | app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:179-191 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:258` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:86 — app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:86-98 | app/src/main/java/eu/kanade/presentation/updates/UpdatesFilterDialog.kt:122-134 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:184 — app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:184-196 | app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt:213-225 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:184` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:208 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:208-220 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:307-319 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:208` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:683 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:683-695 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1115-1127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:683` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:351 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:351-363 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:456-468 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:351` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:157 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:157-169 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:77-89 — `app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 42 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:338 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:338-350 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:369-381 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:338` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:571 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:571-583 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:317-329 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:571` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:569` calls `resetFilters` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:316` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×10
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:95 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:95-106 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt:88-99 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/components/TabbedDialog.kt:92 — app/src/main/java/eu/kanade/presentation/components/TabbedDialog.kt:92-103 | app/src/main/java/eu/kanade/presentation/track/TrackInfoDialogHome.kt:329-340 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/TabbedDialog.kt:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:321 — app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:321-332 | app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:340-351 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:321` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:122 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:122-133 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:111-122 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:122` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:134` calls `logcat` and `app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:124` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:485 — app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:485-496 | app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:512-523 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:485` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:580 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:580-591 | app/src/main/java/exh/ui/login/EhLoginActivity.kt:190-201 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:580` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:579` calls `onActivityFinish` and `app/src/main/java/exh/ui/login/EhLoginActivity.kt:189` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1027 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1027-1038 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1063-1074 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1027` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1075` calls `send`, `SetOrientation`, `getMangaOrientation` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1039` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:107 — app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:107-118 | app/src/main/java/exh/ui/intercept/InterceptActivity.kt:166-177 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:81 — data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:81-92 | data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:100-111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:93` calls `selectLastInsertedRowId` and `data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:112` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:206 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:206-217 | app/src/main/java/eu/kanade/tachiyomi/data/library/MetadataUpdateJob.kt:74-85 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D3 · God Classes · TooManyMethods · ×9
  • TooManyMethods: MangaScreenModel app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:173 — TooManyMethods — 76 methods. The bar is 30 methods; this is 46 over it, 2.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ReaderViewModel app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:113 — TooManyMethods — 65 methods. The bar is 30 methods; this is 35 over it, 2.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: EHentai app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:99 — TooManyMethods — 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ReaderActivity app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:152 — TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LibraryScreenModel app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:132 — TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MangaDex app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:57 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: HttpSource REDACTED:34 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SettingsEhScreen app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:87 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DebugFunctions app/src/main/java/exh/debug/DebugFunctions.kt:40 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×9
  • Edited copy of a member (12 corresponding lines) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:430 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:430-441 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:443-455 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/core/util/CollectionUtils.kt:10 — app/src/main/java/eu/kanade/core/util/CollectionUtils.kt:10-21 | app/src/main/java/eu/kanade/core/util/CollectionUtils.kt:28-39 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:169 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:169-180 | app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:376-387 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:249 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:249-263 | app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:265-276 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) REDACTED:57 — REDACTED:57-68 | app/src/main/java/eu/kanade/tachiyomi/data/track/komga/Komga.kt:54-66 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:156 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:156-167 | app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:360-374 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonConfig.kt:155 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonConfig.kt:155-166 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerConfig.kt:239-250 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:391 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:391-402 | app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationHandler.kt:21-32 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/exh/md/service/MangaDexAuthService.kt:67 — app/src/main/java/exh/md/service/MangaDexAuthService.kt:67-78 | app/src/main/java/exh/md/service/MangaDexService.kt:181-192 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×9
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:61 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:61-76 | app/src/main/java/eu/kanade/presentation/components/Chip.kt:97-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:343 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:343-358 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:277-292 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:343` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:487 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:487-502 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:939-954 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:937` calls `onAllChapterSelected` and `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:485` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:713 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:713-728 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1176-1191 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:713` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:370 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:370-385 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:389-404 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:370` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt:112 — app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt:112-127 | app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt:189-204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/about/AboutScreen.kt:112` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1018 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1018-1033 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1037-1052 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1018` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:37 — app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:37-52 | app/src/main/java/eu/kanade/presentation/updates/UpdatesFilterDialog.kt:37-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/components/HistoryFilterDialog.kt:37` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `screenModel` to `HistorySettingsScreenModel` in one and `UpdatesSettingsScreenModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:111 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:111-126 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonTransitionHolder.kt:113-128 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×8
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:45 — app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:45-59 | app/src/main/java/eu/kanade/presentation/browse/SourceFeedOrderScreen.kt:66-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:45` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/FeedOrderListItem.kt:32 — app/src/main/java/eu/kanade/presentation/browse/components/FeedOrderListItem.kt:32-46 | app/src/main/java/eu/kanade/presentation/category/components/CategoryListItem.kt:45-59 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/FeedOrderListItem.kt` and `app/src/main/java/eu/kanade/presentation/category/components/CategoryListItem.kt` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/FeedOrderListItem.kt:32` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/presentation/category/components/CategoryListItem.kt:44` calls `clickable` and `app/src/main/java/eu/kanade/presentation/browse/components/FeedOrderListItem.kt:31` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:643 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:643-657 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:279-293 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/components/Chip.kt` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/Chip.kt:643` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/eu/kanade/presentation/components/Chip.kt:658` calls `Start` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:294` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:619 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:619-633 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1071-1085 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:619` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:270 — app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:270-284 | app/src/main/java/eu/kanade/tachiyomi/ui/setting/connections/DiscordLoginScreen.kt:211-225 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:270` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:259 — app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:259-273 | data/src/main/java/tachiyomi/data/chapter/ChapterRepositoryImpl.kt:22-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `data/src/main/java/tachiyomi/data/chapter/ChapterRepositoryImpl.kt:37` calls `selectLastInsertedRowId`, `executeAsOne` and `app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:274` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:302 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:302-316 | app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt:213-227 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15 lines × 2) REDACTED:238 — REDACTED:238-252 | REDACTED:484-498 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:238` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×8
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:675 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:675-683 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:653-661 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1192 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1192-1200 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1318-1326 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1192` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:195 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:195-203 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:183-191 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:343 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:343-351 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:267-275 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/SearchScreenModel.kt:84 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/SearchScreenModel.kt:84-92 | app/src/main/java/exh/recs/RecommendsScreenModel.kt:110-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:262 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:262-270 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt:240-248 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 34 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:50 — data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:50-58 | data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt:112-120 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/DeleteLibraryUpdateErrors.kt:12 — domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/DeleteLibraryUpdateErrors.kt:12-20 | domain/src/main/java/tachiyomi/domain/libraryUpdateErrorMessage/interactor/DeleteLibraryUpdateErrorMessages.kt:13-21 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×7
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:131 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:131-151 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonTransitionHolder.kt:133-152 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) REDACTED:174 — REDACTED:174-193 | REDACTED:195-214 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupCreateJob.kt:91 — app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupCreateJob.kt:91-115 | app/src/main/java/eu/kanade/tachiyomi/data/sync/SyncDataJob.kt:90-109 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/presentation/manga/components/ChapterDownloadIndicator.kt:88 — app/src/main/java/eu/kanade/presentation/manga/components/ChapterDownloadIndicator.kt:88-108 | app/src/main/java/eu/kanade/presentation/manga/components/ChapterDownloadIndicator.kt:230-249 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:868 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:868-887 | app/src/main/java/eu/kanade/tachiyomi/data/sync/SyncDataJob.kt:125-148 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1023 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1023-1042 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1059-1079 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1416 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1416-1435 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:360-380 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×7
  • Edited copy of a member (13 corresponding lines) app/src/main/java/mihon/core/migration/migrations/DisabledRepoMigration.kt:14 — app/src/main/java/mihon/core/migration/migrations/DisabledRepoMigration.kt:14-30 | app/src/main/java/mihon/core/migration/migrations/MoveSortingModeSettingMigration.kt:14-26 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:456 — app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:456-469 | app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:531-543 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:529 — app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:529-541 | app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:543-556 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:578 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:578-591 | app/src/main/java/exh/ui/login/EhLoginActivity.kt:189-201 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:37 — app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:37-49 | app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/Suwayomi.kt:50-62 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Banners.kt:173 — app/src/main/java/eu/kanade/presentation/components/Banners.kt:173-185 | app/src/main/java/eu/kanade/presentation/components/Banners.kt:188-200 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:227 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:227-242 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:1157-1169 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×7
  • Edited copy of a member (10 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:366 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:366-375 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:380-389 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) core/archive/src/main/kotlin/mihon/core/archive/CbzCrypto.kt:191 — core/archive/src/main/kotlin/mihon/core/archive/CbzCrypto.kt:191-200 | core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:96-111 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/exh/recs/sources/MangaUpdatesPagingSource.kt:38 — app/src/main/java/exh/recs/sources/MangaUpdatesPagingSource.kt:38-47 | app/src/main/java/exh/recs/sources/MyAnimeListPagingSource.kt:69-81 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/mihon/core/migration/migrations/MoveLibraryNonCompleteSettingMigration.kt:14 — app/src/main/java/mihon/core/migration/migrations/MoveLibraryNonCompleteSettingMigration.kt:14-24 | app/src/main/java/mihon/core/migration/migrations/MoveReadingButtonSettingMigration.kt:13-22 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/exh/md/handlers/BilibiliHandler.kt:103 — app/src/main/java/exh/md/handlers/BilibiliHandler.kt:103-113 | app/src/main/java/exh/md/handlers/BilibiliHandler.kt:146-155 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:217 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:217-227 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:128-137 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/Lanraragi.kt:169 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/Lanraragi.kt:169-178 | app/src/main/java/eu/kanade/tachiyomi/source/online/all/NHentai.kt:221-230 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×7
  • Edited copy of a member (9 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:170 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:170-180 | app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:182-190 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:215 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:215-223 | app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt:126-136 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/RelatedMangasScreen.kt:116 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/RelatedMangasScreen.kt:116-126 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:244-252 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) app/src/main/java/mihon/core/migration/migrations/RemoveShortLibraryUpdatesMigration.kt:11 — app/src/main/java/mihon/core/migration/migrations/RemoveShortLibraryUpdatesMigration.kt:11-19 | app/src/main/java/mihon/core/migration/migrations/RemoveShorterLibraryUpdatesMigration.kt:11-19 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1461 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1461-1469 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:302-310 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) REDACTED:218 — REDACTED:218-227 | REDACTED:233-241 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:96 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:96-104 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:85-93 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D3 · God Classes · ClassTooLong · ×6
  • ClassTooLong: MangaScreenModel app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:173 — ClassTooLong — 1131 significant lines (blank, comment-only and punctuation-only lines excluded), 76 methods. The bar is 400 significant lines; this is 731 over it, 2.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: LibraryScreenModel app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:132 — ClassTooLong — 1067 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 400 significant lines; this is 667 over it, 2.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ReaderActivity app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:152 — ClassTooLong — 819 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 400 significant lines; this is 419 over it, 2.05× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ReaderViewModel app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:113 — ClassTooLong — 804 significant lines (blank, comment-only and punctuation-only lines excluded), 65 methods. The bar is 400 significant lines; this is 404 over it, 2.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MangaScreen app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:123 — ClassTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 108 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: LibraryUpdateJob app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:106 — ClassTooLong — 449 significant lines (blank, comment-only and punctuation-only lines excluded), 13 methods. The bar is 400 significant lines; this is 49 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×6
  • Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt:60 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:60-77 | app/src/main/java/eu/kanade/presentation/components/Chip.kt:93-114 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:145 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:145-162 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:175-192 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/util/chapter/ChapterGetNextUnread.kt:19 — app/src/main/java/eu/kanade/tachiyomi/util/chapter/ChapterGetNextUnread.kt:19-36 | app/src/main/java/eu/kanade/tachiyomi/util/chapter/ChapterGetNextUnread.kt:41-58 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:75 — data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:75-95 | data/src/main/java/tachiyomi/data/manga/MangaMergeRepositoryImpl.kt:97-114 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/exh/util/SearchOverride.kt:24 — app/src/main/java/exh/util/SearchOverride.kt:24-41 | app/src/main/java/exh/util/SearchOverride.kt:51-70 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:69 — app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:69-87 | app/src/main/java/eu/kanade/presentation/more/NewUpdateScreen.kt:68-85 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×6
  • Edited copy of a member (22 corresponding lines) app/src/main/java/eu/kanade/presentation/reader/OrientationSelectDialog.kt:54 — app/src/main/java/eu/kanade/presentation/reader/OrientationSelectDialog.kt:54-79 | app/src/main/java/eu/kanade/presentation/reader/ReadingModeSelectDialog.kt:56-77 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:185 — app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:185-206 | presentation-core/src/main/java/tachiyomi/presentation/core/components/ListGroupHeader.kt:26-61 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) source-api/src/commonMain/kotlin/exh/metadata/metadata/EightMusesSearchMetadata.kt:20 — source-api/src/commonMain/kotlin/exh/metadata/metadata/EightMusesSearchMetadata.kt:20-41 | source-api/src/commonMain/kotlin/exh/metadata/metadata/PururinSearchMetadata.kt:31-56 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/more/ComingUpdatesScreen.kt:21 — app/src/main/java/eu/kanade/tachiyomi/ui/more/ComingUpdatesScreen.kt:21-42 | app/src/main/java/eu/kanade/tachiyomi/ui/more/NewUpdateScreen.kt:21-42 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) data/src/main/java/tachiyomi/data/history/HistoryMapper.kt:39 — data/src/main/java/tachiyomi/data/history/HistoryMapper.kt:39-62 | data/src/main/java/tachiyomi/data/updates/UpdatesRepositoryImpl.kt:83-104 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:646 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:646-667 | app/src/main/java/eu/kanade/tachiyomi/data/library/MetadataUpdateJob.kt:146-167 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×6
  • Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:404 — app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:404-422 | app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt:430-454 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:907 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:907-931 | app/src/main/java/eu/kanade/presentation/more/settings/screen/about/WhatsNewDialog.kt:18-36 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadCache.kt:248 — app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadCache.kt:248-266 | app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadCache.kt:289-309 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:109 — app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:109-127 | app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:129-147 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) core/common/src/main/kotlin/tachiyomi/core/common/util/system/UrlUtils.kt:14 — core/common/src/main/kotlin/tachiyomi/core/common/util/system/UrlUtils.kt:14-32 | core/common/src/main/kotlin/tachiyomi/core/common/util/system/UrlUtils.kt:40-63 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:175 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:175-193 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:163-181 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×5
  • Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresContent.kt:200 — app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresContent.kt:200-222 | app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt:120-145 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:116 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:116-141 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt:137-159 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:278 — app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:278-302 | data/src/main/java/tachiyomi/data/chapter/ChapterRepositoryImpl.kt:55-77 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:257 — app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:257-285 | app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:178-200 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) app/src/main/java/eu/kanade/presentation/reader/ChapterTransition.kt:148 — app/src/main/java/eu/kanade/presentation/reader/ChapterTransition.kt:148-171 | app/src/main/java/eu/kanade/presentation/reader/ChapterTransition.kt:177-199 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×5
  • Edited copy of a member (17 corresponding lines) data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt:19 — data/src/main/java/tachiyomi/data/source/EHentaiPagingSource.kt:19-35 | data/src/main/java/tachiyomi/data/source/SourcePagingSource.kt:75-100 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) REDACTED:45 — REDACTED:45-61 | REDACTED:63-86 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:156 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:156-172 | app/src/main/java/exh/eh/EHentaiUpdateNotifier.kt:89-106 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) app/src/main/java/exh/md/handlers/ApiMangaParser.kt:49 — app/src/main/java/exh/md/handlers/ApiMangaParser.kt:49-75 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/MetadataSource.kt:58-74 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/mangaupdates/MangaUpdatesApi.kt:152 — app/src/main/java/eu/kanade/tachiyomi/data/track/mangaupdates/MangaUpdatesApi.kt:152-176 | app/src/main/java/eu/kanade/tachiyomi/data/track/mangaupdates/MangaUpdatesApi.kt:178-194 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×5
  • Edited copy of a member (15 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:482 — app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:482-496 | app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:509-523 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) app/src/main/java/exh/EXHMigrations.kt:169 — app/src/main/java/exh/EXHMigrations.kt:169-183 | REDACTED:539-553 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) app/src/main/java/eu/kanade/presentation/reader/OrientationSelectDialog.kt:34 — app/src/main/java/eu/kanade/presentation/reader/OrientationSelectDialog.kt:34-48 | app/src/main/java/eu/kanade/presentation/reader/ReadingModeSelectDialog.kt:36-50 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesContent.kt:21 — app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesContent.kt:21-35 | app/src/main/java/eu/kanade/presentation/category/components/sources/SourceCategoryContent.kt:21-36 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/extension/util/ExtensionLoader.kt:414 — app/src/main/java/eu/kanade/tachiyomi/extension/util/ExtensionLoader.kt:414-428 | telemetry/src/firebase/kotlin/mihon/telemetry/PackageInfo.kt:9-24 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×5
  • Edited copy of a member (16 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:373 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:373-388 | app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:398-413 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:91 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerTransitionHolder.kt:91-106 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonTransitionHolder.kt:92-108 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:211 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:211-226 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:199-214 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) core/archive/src/main/kotlin/mihon/core/archive/ArchiveReader.kt:34 — core/archive/src/main/kotlin/mihon/core/archive/ArchiveReader.kt:34-49 | core/archive/src/main/kotlin/mihon/core/archive/ArchiveReader.kt:52-68 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) presentation-core/src/main/java/tachiyomi/presentation/core/util/LazyListState.kt:38 — presentation-core/src/main/java/tachiyomi/presentation/core/util/LazyListState.kt:38-53 | presentation-core/src/main/java/tachiyomi/presentation/core/util/LazyListState.kt:56-71 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×5
  • Edited copy of a member (14 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt:95 — app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt:95-108 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt:160-176 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadHeaderItem.kt:36 — app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadHeaderItem.kt:36-49 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/model/MangasPage.kt:60-73 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:275 — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:275-288 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:873-887 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) domain/src/main/java/tachiyomi/domain/category/interactor/HideCategory.kt:14 — domain/src/main/java/tachiyomi/domain/category/interactor/HideCategory.kt:14-27 | domain/src/main/java/tachiyomi/domain/category/interactor/RenameCategory.kt:14-27 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchResultItems.kt:82 — app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchResultItems.kt:82-95 | app/src/main/java/eu/kanade/presentation/manga/components/RelatedMangasRow.kt:89-103 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×5
  • Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:43 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:43-59 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:42-58 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt` as WHOLE FILES: 94% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:31 — app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:31-47 | app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt:81-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:31` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt:128 — app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt:128-145 | app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt:151-167 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresScreen.kt:128` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:111 — app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:111-127 | app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:131-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:111` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/src/main/java/eu/kanade/presentation/reader/appbars/ExhUtils.kt:177 — app/src/main/java/eu/kanade/presentation/reader/appbars/ExhUtils.kt:177-193 | app/src/main/java/eu/kanade/presentation/reader/appbars/ExhUtils.kt:205-221 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/reader/appbars/ExhUtils.kt:177` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×5
  • Duplicated block (6 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:311 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:311-316 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:899-904 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:311` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) app/src/main/java/eu/kanade/tachiyomi/source/online/all/Pururin.kt:68 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/Pururin.kt:68-73 | app/src/main/java/eu/kanade/tachiyomi/source/online/english/EightMuses.kt:49-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:286 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:286-291 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:862-867 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) data/src/main/java/tachiyomi/data/QueryPagingSource.kt:61 — data/src/main/java/tachiyomi/data/QueryPagingSource.kt:61-66 | data/src/main/java/tachiyomi/data/source/SourcePagingSource.kt:105-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `data/src/main/java/tachiyomi/data/source/SourcePagingSource.kt:105` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryTab.kt:76 — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryTab.kt:76-81 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesTab.kt:67-72 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D17 · Explicit Debt · FixmeComment · ×4
  • FixmeComment app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:461 — // FIXME: Calling await in filter could lead to N+1 performance issues. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:794 — // FIXME: N+1 performance issues. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:263 — // FIXME (KMK): Should have throttle here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:365 — // FIXME (KMK): Should have throttle here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Edited copy of a member (57 corresponding lines) · ×4
  • Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:96 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:96-154 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:93-149 — These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:710 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:710-766 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:888-957 — These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:135 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:135-213 | app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt:68-124 — These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (57 corresponding lines) app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt:51 — app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt:51-118 | app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt:126-182 — These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×4
  • Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1235 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1235-1267 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1349-1378 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:659 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:659-697 | app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:699-728 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:32 — app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:32-67 | app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncTriggerOptionsScreen.kt:30-59 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (30 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupNotifier.kt:109 — app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupNotifier.kt:109-143 | app/src/main/java/eu/kanade/tachiyomi/data/sync/SyncNotifier.kt:55-84 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×4
  • Edited copy of a member (11 corresponding lines) app/src/main/java/mihon/core/migration/migrations/MoveCacheToDiskSettingMigration.kt:13 — app/src/main/java/mihon/core/migration/migrations/MoveCacheToDiskSettingMigration.kt:13-23 | app/src/main/java/mihon/core/migration/migrations/MoveReaderTapSettingMigration.kt:13-24 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordAccountsScreen.kt:198 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordAccountsScreen.kt:198-208 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordAccountsScreen.kt:210-221 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/Pururin.kt:41 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/Pururin.kt:41-53 | app/src/main/java/eu/kanade/tachiyomi/source/online/all/Pururin.kt:55-65 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:105 — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:105-118 | app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt:56-66 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×4
  • Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:595 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:595-619 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:240-264 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/components/Chip.kt` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/Chip.kt:595` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:50 — app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:50-74 | app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt:100-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:50` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:42 — app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:42-66 | app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt:40-64 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (25 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:156 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:156-180 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:262-286 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×4
  • Duplicated block (19 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:87 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:87-105 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt:55-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:87` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:640 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:640-658 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1086-1104 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (19 lines × 2) app/src/main/java/exh/EXHMigrations.kt:96 — app/src/main/java/exh/EXHMigrations.kt:96-114 | app/src/main/java/exh/EXHMigrations.kt:120-138 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (19 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:917 — app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:917-935 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:967-985 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:917` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:916` calls `take` and `app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:966` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×4
  • Duplicated block (7 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:100 — app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:100-106 | app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:112-118 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt:131 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt:131-137 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt:149-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt:156` calls `HttpPageLoader`, `error`, `stringResource` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt:138` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:640 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:640-646 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:356-362 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) domain/src/main/java/tachiyomi/domain/source/interactor/InsertFeedSavedSearch.kt:22 — domain/src/main/java/tachiyomi/domain/source/interactor/InsertFeedSavedSearch.kt:22-28 | domain/src/main/java/tachiyomi/domain/source/interactor/InsertSavedSearch.kt:22-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
PF3 · Async & latency hygiene · Sync-over-async blocking · ×4
  • Sync-over-async blocking app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:418 — `init` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
  • Sync-over-async blocking app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ArchivePageLoader.kt:62 — `getPages` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
  • Sync-over-async blocking data/src/main/java/tachiyomi/data/TransactionContext.kt:41 — `withTransaction` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
  • Sync-over-async blocking data/src/main/java/tachiyomi/data/TransactionContext.kt:100 — `acquireTransactionThread` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
X3 · Exception handling · Swallowed exception (empty catch) · ×4
  • Swallowed exception (empty catch) telemetry/src/firebase/kotlin/exh/log/CrashlyticsPrinter.kt:19 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) core/common/src/main/kotlin/eu/kanade/tachiyomi/network/OkHttpExtensions.kt:82 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:192 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) app/src/main/java/eu/kanade/tachiyomi/App.kt:340 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
D35 · Change Coupling · Change-coupling hub · ×3
  • Change-coupling hub: BrowseRecommendsScreen.kt → BrowseSourceSimpleToolbar.kt, MigrateSourceSearchScreen.kt, BrowseSourceScreen.kt, MangaDexFollowsScreen.kt app/src/main/java/exh/recs/BrowseRecommendsScreen.kt — `app/src/main/java/exh/recs/BrowseRecommendsScreen.kt` changes together with 4 other files — `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt`, `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt`, `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt`, `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
  • Change-coupling hub: LibraryScreenModel.kt → LibraryComfortableGrid.kt, LibraryCompactGrid.kt, CategoryRepositoryImpl.kt app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt — `app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt` changes together with 3 other files — `app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt`, `app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt`, `data/src/main/java/tachiyomi/data/category/CategoryRepositoryImpl.kt` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
  • Change-coupling hub: TabbedScreen.kt → LibraryPager.kt, LibraryTabs.kt, BrowseTab.kt app/src/main/java/eu/kanade/presentation/components/TabbedScreen.kt — `app/src/main/java/eu/kanade/presentation/components/TabbedScreen.kt` changes together with 3 other files — `app/src/main/java/eu/kanade/presentation/library/components/LibraryPager.kt`, `app/src/main/java/eu/kanade/presentation/library/components/LibraryTabs.kt`, `app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseTab.kt` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (37 corresponding lines) · ×3
  • Edited copy of a member (37 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:241 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:241-279 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:338-374 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (37 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:335 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:335-372 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:368-404 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (37 corresponding lines) app/src/main/java/exh/util/OkHttpExtensions.kt:10 — app/src/main/java/exh/util/OkHttpExtensions.kt:10-54 | core/common/src/main/kotlin/eu/kanade/tachiyomi/network/OkHttpExtensions.kt:26-62 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×3
  • Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:452 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:452-480 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt:290-316 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1221 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1221-1247 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:523-549 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (27 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:112 — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:112-139 | app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt:101-127 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×3
  • Edited copy of a member (24 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/KitsuInterceptor.kt:20 — app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/KitsuInterceptor.kt:20-46 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/ShikimoriInterceptor.kt:20-43 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) data/src/main/java/tachiyomi/data/source/FeedSavedSearchRepositoryImpl.kt:53 — data/src/main/java/tachiyomi/data/source/FeedSavedSearchRepositoryImpl.kt:53-76 | data/src/main/java/tachiyomi/data/source/SavedSearchRepositoryImpl.kt:28-53 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:39 — app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:39-62 | app/src/main/java/eu/kanade/presentation/browse/SourcesFilterScreen.kt:39-66 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×3
  • Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateNotifier.kt:133 — app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateNotifier.kt:133-159 | app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateNotifier.kt:271-295 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadNotifier.kt:187 — app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadNotifier.kt:187-211 | app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadNotifier.kt:221-245 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt:184 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:184-210 | presentation-core/src/main/java/tachiyomi/presentation/core/components/LazyGrid.kt:34-58 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×3
  • Duplicated block (18 lines × 2) app/src/main/java/eu/kanade/presentation/components/Chip.kt:141 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:141-158 | app/src/main/java/eu/kanade/presentation/components/Chip.kt:193-210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/components/Chip.kt:141` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:228 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:228-245 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:327-344 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:228` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (18 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:220 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:220-237 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:409-426 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:220` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:219` calls `padding` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:408` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×3
  • Duplicated block (12–13 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:117 — app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:117-128 | app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:324-336 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:117` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12–13 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:526 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:526-537 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:982-994 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:526` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12–13 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:273 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:273-284 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:399-411 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:273` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D15 · Churn × Complexity Hotspots · Repeated repair · ×2
  • Repeated repair: app/src/main/java/eu/kanade/presentation/util/Navigator.kt app/src/main/java/eu/kanade/presentation/util/Navigator.kt:34 — app/src/main/java/eu/kanade/presentation/util/Navigator.kt changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is Tab.onReselect at line 34), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(screen-transition): Register navigator BackHandler before screen content (#1908)”; “fix(screen-transition): Key AnimatedContent children by screen key (#1904)”; “Revert "Add full predictive back support (# 2085)" (mihonapp/mihon#2362)”; “Revert screen-transition key debugging changes (#1902)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-04..2026-11-02, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-04 15:07:58 +07:00' --until='2026-11-02 15:07:58 +07:00' --full-history --no-merges -- app/src/main/java/eu/kanade/presentation/util/Navigator.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/eu/kanade/tachiyomi/di/AppModule.kt app/src/main/java/eu/kanade/tachiyomi/di/AppModule.kt:78 — app/src/main/java/eu/kanade/tachiyomi/di/AppModule.kt changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is AppModule.registerInjectables at line 78), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Revert "chore(NetworkHelper): Allow disabling network handling for MangaDex cover images based on delegate source preferences (#1786)"”; “fix(sqlite): Improve SQLite connection handling with busy timeout for bundled driver (#1921)”; “Potentially fix 'database is locked' crash”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-04..2026-11-02, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-04 15:07:58 +07:00' --until='2026-11-02 15:07:58 +07:00' --full-history --no-merges -- app/src/main/java/eu/kanade/tachiyomi/di/AppModule.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D17 · Explicit Debt · HackComment · ×2
  • HackComment presentation-widget/src/main/java/tachiyomi/presentation/widget/util/GlanceUtils.kt:34 — // Hack: Size provided by Glance manager is not reliable so take at least 1 row and 1 column — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment app/src/main/java/eu/kanade/presentation/more/settings/screen/SearchableSettings.kt:41 — // HACK: for the background blipping thingy. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:204 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:204-303 | app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:86-185 | app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:278-438 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:303-366 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:65 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:65-253 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:105-523 | app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt:41-210 | app/src/main/java/exh/recs/BrowseRecommendsScreen.kt:48-179 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Edited copy of a member (64 corresponding lines) · ×2
  • Edited copy of a member (64 corresponding lines) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:504 — app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:504-567 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:588-662 — These two members are one piece of code written twice and then edited apart: 64 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (64 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:44 — app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:44-107 | app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt:34-98 — These two members are one piece of code written twice and then edited apart: 64 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (44 corresponding lines) · ×2
  • Edited copy of a member (44 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:750 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:750-797 | app/src/main/java/exh/eh/EHentaiUpdateWorker.kt:285-328 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (44 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1476 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1476-1526 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1541-1584 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (38 corresponding lines) · ×2
  • Edited copy of a member (38 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:93 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:93-136 | app/src/main/java/eu/kanade/presentation/webview/components/IgneousDialog.kt:25-62 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (38 corresponding lines) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:316 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:316-358 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:255-292 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×2
  • Edited copy of a member (32 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:374 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:374-405 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:406-439 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (32 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/connections/discord/DiscordRPCService.kt:45 — app/src/main/java/eu/kanade/tachiyomi/data/connections/discord/DiscordRPCService.kt:45-86 | app/src/main/java/eu/kanade/tachiyomi/data/connections/discord/DiscordRPCService.kt:111-142 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×2
  • Edited copy of a member (26 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:216 — app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:216-241 | app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:249-274 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:29 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:29-54 | app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt:43-68 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×2
  • Edited copy of a member (21 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:97 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt:97-121 | app/src/main/java/exh/eh/EHentaiUpdateNotifier.kt:61-81 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:164 — app/src/main/java/eu/kanade/presentation/browse/FeedScreen.kt:164-184 | app/src/main/java/eu/kanade/presentation/browse/SourceFeedScreen.kt:285-306 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 10+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:119 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:119-132 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:134-143 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:164-173 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 10+ corresponding lines) domain/src/main/java/tachiyomi/domain/manga/interactor/GetFavorites.kt:21 — domain/src/main/java/tachiyomi/domain/manga/interactor/GetFavorites.kt:21-35 | domain/src/main/java/tachiyomi/domain/manga/interactor/GetLibraryManga.kt:21-33 | domain/src/main/java/tachiyomi/domain/updates/interactor/GetUpdates.kt:50-59 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 13+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:78 — app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:78-94 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:76-92 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:49-61 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 13+ corresponding lines) source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/ParsedHttpSource.kt:30 — source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/ParsedHttpSource.kt:30-42 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/ParsedHttpSource.kt:72-84 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/online/ParsedHttpSource.kt:114-126 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 11+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 11+ corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt:672 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:672-683 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:307-318 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:364-374 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 11+ corresponding lines) app/src/main/java/mihon/core/migration/migrations/MoveCatalogueCoverOnlyGridSettingMigration.kt:13 — app/src/main/java/mihon/core/migration/migrations/MoveCatalogueCoverOnlyGridSettingMigration.kt:13-23 | app/src/main/java/mihon/core/migration/migrations/MoveCoverOnlyGridSettingMigration.kt:13-23 | app/src/main/java/mihon/core/migration/migrations/ResetRotationSettingMigration.kt:13-24 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×2
  • Edited copy of a member (7 corresponding lines) app/src/main/java/exh/util/DataSaver.kt:58 — app/src/main/java/exh/util/DataSaver.kt:58-68 | app/src/main/java/exh/util/DataSaver.kt:85-91 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:127 — app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:127-133 | app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:154-160 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×2
  • Duplicated block (31 lines × 2) app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:49 — app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:49-79 | app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt:39-69 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt` and `app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (31 lines × 2) data/src/main/java/tachiyomi/data/manga/MangaMapper.kt:113 — data/src/main/java/tachiyomi/data/manga/MangaMapper.kt:113-143 | data/src/main/java/tachiyomi/data/manga/MangaMapper.kt:189-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (21–22 lines × 2) · ×2
  • Duplicated block (21–22 lines × 2) app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:105 — app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:105-125 | app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:129-150 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/components/HistoryItem.kt:105` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (21–22 lines × 2) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:755 — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:755-775 | app/src/main/java/exh/eh/EHentaiUpdateWorker.kt:290-311 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×2
  • Duplicated block (20 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:97 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:97-116 | app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:78-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:97` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:222 — app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:222-241 | app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:255-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/home/HomeScreen.kt:222` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×2
  • Duplicated block (16 lines × 3) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:225 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:225-240 | app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:103-118 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:324-339 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:225` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (16 lines × 3) app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:104 — app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:104-119 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1748-1763 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:438-453 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:104` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×2
  • Duplicated block (15–16 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaCover.kt:127 — app/src/main/java/eu/kanade/presentation/manga/components/MangaCover.kt:127-141 | app/src/main/java/eu/kanade/presentation/manga/components/MangaCover.kt:204-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/components/MangaCover.kt:127` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15–16 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:138 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:138-153 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsDialog.kt:230-244 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:138` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×2
  • Duplicated block (15 lines × 3) app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt:75 — app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt:75-89 | app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:118-132 | app/src/main/java/eu/kanade/presentation/updates/UpdatesDeleteConfirmationDialog.kt:20-34 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt:75` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 3) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:265 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:265-281 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:327-343 | data/src/main/java/tachiyomi/data/chapter/ChapterMapper.kt:27-41 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:265` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–15 lines × 2) · ×2
  • Duplicated block (13–15 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:114 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:114-128 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:219-231 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13–15 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:619 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:619-631 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:783-797 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:619` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×2
  • Duplicated block (13 lines × 3) app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:46 — app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:46-58 | app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt:36-48 | app/src/main/java/eu/kanade/presentation/browse/SourceFeedScreen.kt:119-131 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt` and `app/src/main/java/eu/kanade/presentation/browse/MigrateSearchScreen.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/GlobalSearchScreen.kt:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 3) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:189 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:189-201 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:104-116 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:73-85 — `app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 42 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:189` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×2
  • Duplicated block (12 lines × 3) app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:261 — app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:261-272 | app/src/main/java/eu/kanade/presentation/library/components/LibraryToolbar.kt:182-193 | app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt:211-222 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/history/HistoryScreen.kt:261` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) app/src/main/java/eu/kanade/presentation/more/settings/screen/data/CreateBackupScreen.kt:109 — app/src/main/java/eu/kanade/presentation/more/settings/screen/data/CreateBackupScreen.kt:109-120 | app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncSettingsSelector.kt:74-85 | app/src/main/java/eu/kanade/presentation/more/settings/screen/data/SyncTriggerOptionsScreen.kt:66-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/data/CreateBackupScreen.kt:109` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `CreateBackupScreenModel` in one and `SyncSettingsSelectorModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×2
  • Duplicated block (9 lines × 3) REDACTED:58 — REDACTED:58-66 | app/src/main/java/eu/kanade/tachiyomi/data/track/komga/Komga.kt:55-63 | app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/Suwayomi.kt:51-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
  • Duplicated block (9 lines × 3) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:66 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:66-74 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:50-58 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:110-118 — `app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 42 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×2
  • Duplicated block (7 lines × 3) app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:123 — app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:123-129 | app/src/main/java/exh/ui/metadata/adapters/MangaDexDescriptionAdapter.kt:56-62 | app/src/main/java/exh/ui/metadata/adapters/PururinDescriptionAdapter.kt:85-91 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
  • Duplicated block (7 lines × 3) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:254 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:254-260 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:189-195 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:143-149 — `app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt` and `app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 42 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×2
  • Duplicated block (5 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1351 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1351-1355 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:275-279 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:299 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:299-303 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:886-890 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×2
  • Duplicated block (8 lines × 4) app/src/main/java/eu/kanade/tachiyomi/ui/category/CategoryScreenModel.kt:101 — app/src/main/java/eu/kanade/tachiyomi/ui/category/CategoryScreenModel.kt:101-108 | app/src/main/java/eu/kanade/tachiyomi/ui/category/biometric/BiometricTimesScreenModel.kt:88-95 | app/src/main/java/eu/kanade/tachiyomi/ui/category/genre/SortTagScreenModel.kt:79-86 | app/src/main/java/eu/kanade/tachiyomi/ui/category/sources/SourceCategoryScreenModel.kt:86-93 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Note first that the copies are not typed on the same thing: the declarations holding them bind `dialog` to `CategoryDialog` in one and `BiometricTimesDialog` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 4) domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChapterByUrl.kt:12 — domain/src/main/java/tachiyomi/domain/chapter/interactor/GetChapterByUrl.kt:12-19 | domain/src/main/java/tachiyomi/domain/manga/interactor/GetMergedMangaById.kt:13-20 | domain/src/main/java/tachiyomi/domain/manga/interactor/GetMergedReferencesById.kt:13-20 | domain/src/main/java/tachiyomi/domain/track/interactor/GetTracks.kt:43-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D1 · Cyclomatic Complexity · ImageUtil.chooseBackground (cyclomatic 71) · ×1
  • ImageUtil.chooseBackground (cyclomatic 71) core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:384 — ImageUtil.chooseBackground has cyclomatic complexity 71 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TrackStatus.parseTrackerStatus (cyclomatic 52) · ×1
  • TrackStatus.parseTrackerStatus (cyclomatic 52) app/src/main/java/eu/kanade/tachiyomi/data/track/TrackStatus.kt:26 — TrackStatus.parseTrackerStatus has cyclomatic complexity 52 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MangaScreen.MangaDetailContent (cyclomatic 40) · ×1
  • MangaScreen.MangaDetailContent (cyclomatic 40) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:222 — MangaScreen.MangaDetailContent has cyclomatic complexity 40 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog (cyclomatic 39) · ×1
  • SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog (cyclomatic 39) app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:32 — SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog has cyclomatic complexity 39 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · update_cherrypick_log.cmd_update (cyclomatic 38) · ×1
  • update_cherrypick_log.cmd_update (cyclomatic 38) .claude/skills/cherrypick-log/update_cherrypick_log.py:902 — update_cherrypick_log.cmd_update has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryTab.Content (cyclomatic 36) · ×1
  • LibraryTab.Content (cyclomatic 36) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryTab.kt:109 — LibraryTab.Content has cyclomatic complexity 36 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MainActivity.onCreate (cyclomatic 35) · ×1
  • MainActivity.onCreate (cyclomatic 35) app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:195 — MainActivity.onCreate has cyclomatic complexity 35 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Builder.detect (cyclomatic 35) · ×1
  • Builder.detect (cyclomatic 35) .claude/skills/cherrypick-log/update_cherrypick_log.py:690 — Builder.detect has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SyncChaptersWithSource.await (cyclomatic 32) · ×1
  • SyncChaptersWithSource.await (cyclomatic 32) app/src/main/java/eu/kanade/domain/chapter/interactor/SyncChaptersWithSource.kt:50 — SyncChaptersWithSource.await has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BrowseSourceScreen.Content (cyclomatic 32) · ×1
  • BrowseSourceScreen.Content (cyclomatic 32) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:105 — BrowseSourceScreen.Content has cyclomatic complexity 32 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SearchEngine.parseQuery (cyclomatic 31) · ×1
  • SearchEngine.parseQuery (cyclomatic 31) app/src/main/java/exh/search/SearchEngine.kt:129 — SearchEngine.parseQuery has cyclomatic complexity 31 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · PagerViewerAdapter.setJoinedItems (cyclomatic 29) · ×1
  • PagerViewerAdapter.setJoinedItems (cyclomatic 29) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt:238 — PagerViewerAdapter.setJoinedItems has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · update_cherrypick_log.flag_revert_chains (cyclomatic 28) · ×1
  • update_cherrypick_log.flag_revert_chains (cyclomatic 28) .claude/skills/cherrypick-log/update_cherrypick_log.py:771 — update_cherrypick_log.flag_revert_chains has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryUpdateJob.addMangaToQueue (cyclomatic 27) · ×1
  • LibraryUpdateJob.addMangaToQueue (cyclomatic 27) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:224 — LibraryUpdateJob.addMangaToQueue has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · PagerViewer.handleKeyEvent (cyclomatic 27) · ×1
  • PagerViewer.handleKeyEvent (cyclomatic 27) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:434 — PagerViewer.handleKeyEvent has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryScreenModel.filterManga (cyclomatic 26) · ×1
  • LibraryScreenModel.filterManga (cyclomatic 26) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:1261 — LibraryScreenModel.filterManga has cyclomatic complexity 26 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · SourcesScreenModel.collectLatestSources (cyclomatic 24) · ×1
  • SourcesScreenModel.collectLatestSources (cyclomatic 24) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourcesScreenModel.kt:97 — SourcesScreenModel.collectLatestSources has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MangaToolbarKt.MangaToolbar (cyclomatic 22) · ×1
  • MangaToolbarKt.MangaToolbar (cyclomatic 22) app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt:40 — MangaToolbarKt.MangaToolbar has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FilterHandler.getQueryMap (cyclomatic 22) · ×1
  • FilterHandler.getQueryMap (cyclomatic 22) app/src/main/java/exh/md/handlers/FilterHandler.kt:167 — FilterHandler.getQueryMap has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem (cyclomatic 21) · ×1
  • BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem (cyclomatic 21) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:108 — BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ChipElevation.animateElevation (cyclomatic 21) · ×1
  • ChipElevation.animateElevation (cyclomatic 21) app/src/main/java/eu/kanade/presentation/components/Chip.kt:591 — ChipElevation.animateElevation has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DuplicateMangaDialogKt.DuplicateMangaListItem (cyclomatic 21) · ×1
  • DuplicateMangaDialogKt.DuplicateMangaListItem (cyclomatic 21) app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt:290 — DuplicateMangaDialogKt.DuplicateMangaListItem has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MangaScreenKt.MangaScreenSmallImpl (cyclomatic 21) · ×1
  • MangaScreenKt.MangaScreenSmallImpl (cyclomatic 21) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:348 — MangaScreenKt.MangaScreenSmallImpl has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MangaInfoHeaderKt.MangaContentInfo (cyclomatic 21) · ×1
  • MangaInfoHeaderKt.MangaContentInfo (cyclomatic 21) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:666 — MangaInfoHeaderKt.MangaContentInfo has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SourceFeedScreen.Content (cyclomatic 21) · ×1
  • SourceFeedScreen.Content (cyclomatic 21) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:56 — SourceFeedScreen.Content has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · EditMangaDialogKt.onViewCreated (cyclomatic 21) · ×1
  • EditMangaDialogKt.onViewCreated (cyclomatic 21) app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:234 — EditMangaDialogKt.onViewCreated has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Detector.onTouchEvent (cyclomatic 21) · ×1
  • Detector.onTouchEvent (cyclomatic 21) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt:289 — Detector.onTouchEvent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WebtoonViewer.handleKeyEvent (cyclomatic 21) · ×1
  • WebtoonViewer.handleKeyEvent (cyclomatic 21) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt:396 — WebtoonViewer.handleKeyEvent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VerticalFastScrollerKt.VerticalFastScroller (cyclomatic 21) · ×1
  • VerticalFastScrollerKt.VerticalFastScroller (cyclomatic 21) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:66 — VerticalFastScrollerKt.VerticalFastScroller has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BrowseSourceScreenKt.BrowseSourceContent (cyclomatic 20) · ×1
  • BrowseSourceScreenKt.BrowseSourceContent (cyclomatic 20) app/src/main/java/eu/kanade/presentation/browse/BrowseSourceScreen.kt:44 — BrowseSourceScreenKt.BrowseSourceContent has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExtensionsScreenKt.ExtensionContent (cyclomatic 20) · ×1
  • ExtensionsScreenKt.ExtensionContent (cyclomatic 20) app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt:144 — ExtensionsScreenKt.ExtensionContent has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · NotificationReceiver.onReceive (cyclomatic 20) · ×1
  • NotificationReceiver.onReceive (cyclomatic 20) app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt:52 — NotificationReceiver.onReceive has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FeedTabKt.feedTab (cyclomatic 20) · ×1
  • FeedTabKt.feedTab (cyclomatic 20) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt:46 — FeedTabKt.feedTab has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · LibraryScreenModel.applySort (cyclomatic 20) · ×1
  • LibraryScreenModel.applySort (cyclomatic 20) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:612 — LibraryScreenModel.applySort has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MainActivity.handleIntentAction (cyclomatic 20) · ×1
  • MainActivity.handleIntentAction (cyclomatic 20) app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:638 — MainActivity.handleIntentAction has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · update_cherrypick_log.cmd_uncertain (cyclomatic 20) · ×1
  • update_cherrypick_log.cmd_uncertain (cyclomatic 20) .claude/skills/cherrypick-log/update_cherrypick_log.py:1060 — update_cherrypick_log.cmd_uncertain has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExtensionsScreenKt.ExtensionItemContent (cyclomatic 19) · ×1
  • ExtensionsScreenKt.ExtensionItemContent (cyclomatic 19) app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt:365 — ExtensionsScreenKt.ExtensionItemContent has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MigrationListScreenModel.runMigrations (cyclomatic 19) · ×1
  • MigrationListScreenModel.runMigrations (cyclomatic 19) app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:137 — MigrationListScreenModel.runMigrations has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MangaInfoHeaderKt.MangaActionRow (cyclomatic 18) · ×1
  • MangaInfoHeaderKt.MangaActionRow (cyclomatic 18) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:233 — MangaInfoHeaderKt.MangaActionRow has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PreferenceItemKt.PreferenceItem (cyclomatic 18) · ×1
  • PreferenceItemKt.PreferenceItem (cyclomatic 18) app/src/main/java/eu/kanade/presentation/more/settings/PreferenceItem.kt:59 — PreferenceItemKt.PreferenceItem has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TriStateListDialogKt.TriStateListDialog (cyclomatic 18) · ×1
  • TriStateListDialogKt.TriStateListDialog (cyclomatic 18) app/src/main/java/eu/kanade/presentation/more/settings/widget/TriStateListDialog.kt:41 — TriStateListDialogKt.TriStateListDialog has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PreferenceRestorer.restorePreferences (cyclomatic 18) · ×1
  • PreferenceRestorer.restorePreferences (cyclomatic 18) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/PreferenceRestorer.kt:59 — PreferenceRestorer.restorePreferences has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryScreenModel.applyFilters (cyclomatic 18) · ×1
  • LibraryScreenModel.applyFilters (cyclomatic 18) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:426 — LibraryScreenModel.applyFilters has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ReaderActivity.setComposeOverlay (cyclomatic 18) · ×1
  • ReaderActivity.setComposeOverlay (cyclomatic 18) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:317 — ReaderActivity.setComposeOverlay has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UpdatesScreenModel.toggleSelection (cyclomatic 18) · ×1
  • UpdatesScreenModel.toggleSelection (cyclomatic 18) app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:371 — UpdatesScreenModel.toggleSelection has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MigrateMangaUseCase.invoke (cyclomatic 18) · ×1
  • MigrateMangaUseCase.invoke (cyclomatic 18) app/src/main/java/mihon/domain/migration/usecases/MigrateMangaUseCase.kt:49 — MigrateMangaUseCase.invoke has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReaderBottomBarKt.ReaderBottomBar (cyclomatic 17) · ×1
  • ReaderBottomBarKt.ReaderBottomBar (cyclomatic 17) app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderBottomBar.kt:29 — ReaderBottomBarKt.ReaderBottomBar has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · WebViewScreenContentKt.WebViewScreenContent (cyclomatic 17) · ×1
  • WebViewScreenContentKt.WebViewScreenContent (cyclomatic 17) app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:69 — WebViewScreenContentKt.WebViewScreenContent has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HistoryScreenModel.toggleSelection (cyclomatic 17) · ×1
  • HistoryScreenModel.toggleSelection (cyclomatic 17) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:296 — HistoryScreenModel.toggleSelection has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HeaderViewHolder.bind (cyclomatic 17) · ×1
  • HeaderViewHolder.bind (cyclomatic 17) app/src/main/java/eu/kanade/tachiyomi/ui/manga/merged/EditMergedSettingsHeaderAdapter.kt:51 — HeaderViewHolder.bind has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · GalleryAdder.addGallery (cyclomatic 17) · ×1
  • GalleryAdder.addGallery (cyclomatic 17) app/src/main/java/exh/GalleryAdder.kt:59 — GalleryAdder.addGallery has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · EhUConfigBuilder.build (cyclomatic 17) · ×1
  • EhUConfigBuilder.build (cyclomatic 17) app/src/main/java/exh/uconfig/EhUConfigBuilder.kt:11 — EhUConfigBuilder.build has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MangaScreenKt.MangaScreenLargeImpl (cyclomatic 16) · ×1
  • MangaScreenKt.MangaScreenLargeImpl (cyclomatic 16) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:808 — MangaScreenKt.MangaScreenLargeImpl has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · UpdatesUiItemKt.UpdatesUiItem (cyclomatic 16) · ×1
  • UpdatesUiItemKt.UpdatesUiItem (cyclomatic 16) app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:223 — UpdatesUiItemKt.UpdatesUiItem has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MangaCoverMetadata.setRatioAndColors (cyclomatic 16) · ×1
  • MangaCoverMetadata.setRatioAndColors (cyclomatic 16) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverMetadata.kt:77 — MangaCoverMetadata.setRatioAndColors has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · LibraryUpdateJob.updateChapterList (cyclomatic 16) · ×1
  • LibraryUpdateJob.updateChapterList (cyclomatic 16) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:389 — LibraryUpdateJob.updateChapterList has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExtensionLoader.loadExtension (cyclomatic 16) · ×1
  • ExtensionLoader.loadExtension (cyclomatic 16) app/src/main/java/eu/kanade/tachiyomi/extension/util/ExtensionLoader.kt:247 — ExtensionLoader.loadExtension has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · EHentai.parseIntoMetadata (cyclomatic 16) · ×1
  • EHentai.parseIntoMetadata (cyclomatic 16) app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:732 — EHentai.parseIntoMetadata has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MigrateMangaScreenModel.toggleSelection (cyclomatic 16) · ×1
  • MigrateMangaScreenModel.toggleSelection (cyclomatic 16) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:81 — MigrateMangaScreenModel.toggleSelection has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ButtonElevation.animateElevation (cyclomatic 16) · ×1
  • ButtonElevation.animateElevation (cyclomatic 16) presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:236 — ButtonElevation.animateElevation has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Builder.build (cyclomatic 16) · ×1
  • Builder.build (cyclomatic 16) .claude/skills/cherrypick-log/update_cherrypick_log.py:634 — Builder.build has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D15 · Churn × Complexity Hotspots · Hotspot · ×1
  • Hotspot: .claude/skills/cherrypick-log/update_cherrypick_log.py .claude/skills/cherrypick-log/update_cherrypick_log.py:902 — .claude/skills/cherrypick-log/update_cherrypick_log.py changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in update_cherrypick_log.cmd_update at line 902. 1 of those changes was a fix/bug commit, and the other 1 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-04..2026-11-02, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-04 15:07:58 +07:00' --until='2026-11-02 15:07:58 +07:00' --full-history --no-merges -- .claude/skills/cherrypick-log/update_cherrypick_log.py`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D2 · Cognitive Complexity · ImageUtil.chooseBackground (cognitive 108) · ×1
  • ImageUtil.chooseBackground (cognitive 108) core/common/src/main/kotlin/tachiyomi/core/common/util/system/ImageUtil.kt:384 — ImageUtil.chooseBackground has cognitive complexity 108 (threshold 15). Drivers by points: if/else 28 (61 pts), boolean chains 30, match/switch 6 (14 pts), loops 2 (3 pts) (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Builder.detect (cognitive 81) · ×1
  • Builder.detect (cognitive 81) .claude/skills/cherrypick-log/update_cherrypick_log.py:690 — Builder.detect has cognitive complexity 81 (threshold 15). Drivers by points: if/else 17 (42 pts), loops 10 (18 pts), ternaries 6 (18 pts), boolean chains 3 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SyncChaptersWithSource.await (cognitive 57) · ×1
  • SyncChaptersWithSource.await (cognitive 57) app/src/main/java/eu/kanade/domain/chapter/interactor/SyncChaptersWithSource.kt:50 — SyncChaptersWithSource.await has cognitive complexity 57 (threshold 15). Drivers by points: if/else 25 (47 pts), boolean chains 9, loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · update_cherrypick_log.cmd_update (cognitive 54) · ×1
  • update_cherrypick_log.cmd_update (cognitive 54) .claude/skills/cherrypick-log/update_cherrypick_log.py:902 — update_cherrypick_log.cmd_update has cognitive complexity 54 (threshold 15). Drivers by points: if/else 16 (24 pts), ternaries 9 (15 pts), loops 8 (10 pts), boolean chains 5 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · update_cherrypick_log.flag_revert_chains (cognitive 53) · ×1
  • update_cherrypick_log.flag_revert_chains (cognitive 53) .claude/skills/cherrypick-log/update_cherrypick_log.py:771 — update_cherrypick_log.flag_revert_chains has cognitive complexity 53 (threshold 15). Drivers by points: if/else 9 (21 pts), loops 10 (19 pts), ternaries 2 (7 pts), boolean chains 6 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PagerViewerAdapter.setJoinedItems (cognitive 50) · ×1
  • PagerViewerAdapter.setJoinedItems (cognitive 50) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt:238 — PagerViewerAdapter.setJoinedItems has cognitive complexity 50 (threshold 15). Drivers by points: if/else 17 (34 pts), boolean chains 10, match/switch 3 (4 pts), loops 1 (2 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaScreen.MangaDetailContent (cognitive 46) · ×1
  • MangaScreen.MangaDetailContent (cognitive 46) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:222 — MangaScreen.MangaDetailContent has cognitive complexity 46 (threshold 15). Drivers by points: if/else 26 (33 pts), boolean chains 6, match/switch 3 (5 pts), error handling 1 (2 pts) (nesting depth added 10). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PagerViewer.handleKeyEvent (cognitive 40) · ×1
  • PagerViewer.handleKeyEvent (cognitive 40) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:434 — PagerViewer.handleKeyEvent has cognitive complexity 40 (threshold 15). Drivers by points: if/else 20 (37 pts), boolean chains 2, match/switch 1 (nesting depth added 17). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MainActivity.onCreate (cognitive 38) · ×1
  • MainActivity.onCreate (cognitive 38) app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt:195 — MainActivity.onCreate has cognitive complexity 38 (threshold 15). Drivers by points: if/else 21 (24 pts), boolean chains 13, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BrowseSourceScreen.Content (cognitive 37) · ×1
  • BrowseSourceScreen.Content (cognitive 37) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:105 — BrowseSourceScreen.Content has cognitive complexity 37 (threshold 15). Drivers by points: if/else 20 (23 pts), boolean chains 7, match/switch 5 (7 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LibraryTab.Content (cognitive 37) · ×1
  • LibraryTab.Content (cognitive 37) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryTab.kt:109 — LibraryTab.Content has cognitive complexity 37 (threshold 15). Drivers by points: if/else 24 (28 pts), match/switch 6, boolean chains 3 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Detector.onTouchEvent (cognitive 37) · ×1
  • Detector.onTouchEvent (cognitive 37) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt:289 — Detector.onTouchEvent has cognitive complexity 37 (threshold 15). Drivers by points: if/else 14 (32 pts), boolean chains 4, match/switch 1 (nesting depth added 18). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MigrationListScreenModel.runMigrations (cognitive 36) · ×1
  • MigrationListScreenModel.runMigrations (cognitive 36) app/src/main/java/mihon/feature/migration/list/MigrationListScreenModel.kt:137 — MigrationListScreenModel.runMigrations has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (23 pts), error handling 3 (8 pts), boolean chains 4, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Builder.build (cognitive 35) · ×1
  • Builder.build (cognitive 35) .claude/skills/cherrypick-log/update_cherrypick_log.py:634 — Builder.build has cognitive complexity 35 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 6 (10 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · update_cherrypick_log.cmd_uncertain (cognitive 31) · ×1
  • update_cherrypick_log.cmd_uncertain (cognitive 31) .claude/skills/cherrypick-log/update_cherrypick_log.py:1060 — update_cherrypick_log.cmd_uncertain has cognitive complexity 31 (threshold 15). Drivers by points: if/else 10 (21 pts), boolean chains 6, ternaries 3, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LibraryScreenModel.filterManga (cognitive 30) · ×1
  • LibraryScreenModel.filterManga (cognitive 30) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:1261 — LibraryScreenModel.filterManga has cognitive complexity 30 (threshold 15). Drivers by points: boolean chains 15, if/else 8 (10 pts), match/switch 3 (5 pts) (nesting depth added 4). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · UpdatesScreenModel.toggleSelection (cognitive 30) · ×1
  • UpdatesScreenModel.toggleSelection (cognitive 30) app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:371 — UpdatesScreenModel.toggleSelection has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (27 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog (cognitive 29) · ×1
  • SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog (cognitive 29) app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:32 — SyncFavoritesProgressDialogKt.SyncFavoritesProgressDialog has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (16 pts), match/switch 5 (10 pts), boolean chains 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MigrateMangaScreenModel.toggleSelection (cognitive 29) · ×1
  • MigrateMangaScreenModel.toggleSelection (cognitive 29) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:81 — MigrateMangaScreenModel.toggleSelection has cognitive complexity 29 (threshold 15). Drivers by points: if/else 18 (28 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaScreenKt.MangaScreenSmallImpl (cognitive 28) · ×1
  • MangaScreenKt.MangaScreenSmallImpl (cognitive 28) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:348 — MangaScreenKt.MangaScreenSmallImpl has cognitive complexity 28 (threshold 15). Drivers by points: if/else 18 (21 pts), boolean chains 7 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PreferenceRestorer.restorePreferences (cognitive 28) · ×1
  • PreferenceRestorer.restorePreferences (cognitive 28) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/PreferenceRestorer.kt:59 — PreferenceRestorer.restorePreferences has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (22 pts), match/switch 2 (5 pts), error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LibraryUpdateJob.addMangaToQueue (cognitive 28) · ×1
  • LibraryUpdateJob.addMangaToQueue (cognitive 28) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:224 — LibraryUpdateJob.addMangaToQueue has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 11, match/switch 3 (5 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GalleryAdder.addGallery (cognitive 28) · ×1
  • GalleryAdder.addGallery (cognitive 28) app/src/main/java/exh/GalleryAdder.kt:59 — GalleryAdder.addGallery has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (17 pts), error handling 7 (10 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LibraryUpdateErrorScreenModel.toggleSelection (cognitive 27) · ×1
  • LibraryUpdateErrorScreenModel.toggleSelection (cognitive 27) app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:62 — LibraryUpdateErrorScreenModel.toggleSelection has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16 (26 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaScreenModel.toggleSelection (cognitive 27) · ×1
  • MangaScreenModel.toggleSelection (cognitive 27) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1704 — MangaScreenModel.toggleSelection has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16 (26 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TargetIndex.__init__ (cognitive 27) · ×1
  • TargetIndex.__init__ (cognitive 27) .claude/skills/cherrypick-log/update_cherrypick_log.py:377 — TargetIndex.__init__ has cognitive complexity 27 (threshold 15). Drivers by points: if/else 3 (10 pts), loops 4 (8 pts), ternaries 2 (7 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UpdatesUiItemKt.UpdatesUiItem (cognitive 26) · ×1
  • UpdatesUiItemKt.UpdatesUiItem (cognitive 26) app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:223 — UpdatesUiItemKt.UpdatesUiItem has cognitive complexity 26 (threshold 15). Drivers by points: if/else 19 (23 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · HistoryScreenModel.toggleSelection (cognitive 26) · ×1
  • HistoryScreenModel.toggleSelection (cognitive 26) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:296 — HistoryScreenModel.toggleSelection has cognitive complexity 26 (threshold 15). Drivers by points: if/else 17 (24 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BrowseSourceScreenKt.BrowseSourceContent (cognitive 25) · ×1
  • BrowseSourceScreenKt.BrowseSourceContent (cognitive 25) app/src/main/java/eu/kanade/presentation/browse/BrowseSourceScreen.kt:44 — BrowseSourceScreenKt.BrowseSourceContent has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (16 pts), match/switch 3 (5 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaInfoHeaderKt.MangaActionRow (cognitive 25) · ×1
  • MangaInfoHeaderKt.MangaActionRow (cognitive 25) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:233 — MangaInfoHeaderKt.MangaActionRow has cognitive complexity 25 (threshold 15). Drivers by points: if/else 21, boolean chains 3, match/switch 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ChapterNavigatorKt.ChapterNavigator (cognitive 25) · ×1
  • ChapterNavigatorKt.ChapterNavigator (cognitive 25) app/src/main/java/eu/kanade/presentation/reader/components/ChapterNavigator.kt:53 — ChapterNavigatorKt.ChapterNavigator has cognitive complexity 25 (threshold 15). Drivers by points: if/else 23 (25 pts) (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TrackStatus.parseTrackerStatus (cognitive 25) · ×1
  • TrackStatus.parseTrackerStatus (cognitive 25) app/src/main/java/eu/kanade/tachiyomi/data/track/TrackStatus.kt:26 — TrackStatus.parseTrackerStatus has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 9 (17 pts), if/else 8 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SourceFeedScreen.Content (cognitive 25) · ×1
  • SourceFeedScreen.Content (cognitive 25) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt:56 — SourceFeedScreen.Content has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 4, match/switch 3 (4 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MangaScreenModel.toggleFavorite (cognitive 25) · ×1
  • MangaScreenModel.toggleFavorite (cognitive 25) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:809 — MangaScreenModel.toggleFavorite has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (21 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MigrateMangaUseCase.invoke (cognitive 25) · ×1
  • MigrateMangaUseCase.invoke (cognitive 25) app/src/main/java/mihon/domain/migration/usecases/MigrateMangaUseCase.kt:49 — MigrateMangaUseCase.invoke has cognitive complexity 25 (threshold 15). Drivers by points: if/else 15 (20 pts), boolean chains 4, error handling 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaToolbarKt.MangaToolbar (cognitive 24) · ×1
  • MangaToolbarKt.MangaToolbar (cognitive 24) app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt:40 — MangaToolbarKt.MangaToolbar has cognitive complexity 24 (threshold 15). Drivers by points: if/else 20, boolean chains 4. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · EHentai.extendedGenericMangaParse (cognitive 24) · ×1
  • EHentai.extendedGenericMangaParse (cognitive 24) app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:147 — EHentai.extendedGenericMangaParse has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (20 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · WebtoonViewer.handleKeyEvent (cognitive 24) · ×1
  • WebtoonViewer.handleKeyEvent (cognitive 24) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt:396 — WebtoonViewer.handleKeyEvent has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (21 pts), boolean chains 2, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · VerticalFastScrollerKt.VerticalFastScroller (cognitive 24) · ×1
  • VerticalFastScrollerKt.VerticalFastScroller (cognitive 24) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:66 — VerticalFastScrollerKt.VerticalFastScroller has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 10 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ScaffoldKt.ScaffoldLayout (cognitive 24) · ×1
  • ScaffoldKt.ScaffoldLayout (cognitive 24) presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Scaffold.kt:162 — ScaffoldKt.ScaffoldLayout has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (19 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CommonMangaItemKt.MangaComfortableGridItem (cognitive 23) · ×1
  • CommonMangaItemKt.MangaComfortableGridItem (cognitive 23) app/src/main/java/eu/kanade/presentation/library/components/CommonMangaItem.kt:208 — CommonMangaItemKt.MangaComfortableGridItem has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeedTabKt.feedTab (cognitive 23) · ×1
  • FeedTabKt.feedTab (cognitive 23) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt:46 — FeedTabKt.feedTab has cognitive complexity 23 (threshold 15). Drivers by points: if/else 14 (18 pts), match/switch 3, boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BrowseSourceScreenModel.searchGenre (cognitive 23) · ×1
  • BrowseSourceScreenModel.searchGenre (cognitive 23) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:320 — BrowseSourceScreenModel.searchGenre has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (5 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · update_cherrypick_log.release_script_flag (cognitive 23) · ×1
  • update_cherrypick_log.release_script_flag (cognitive 23) .claude/skills/cherrypick-log/update_cherrypick_log.py:844 — update_cherrypick_log.release_script_flag has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 4, ternaries 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LibraryUpdateJob.updateChapterList (cognitive 22) · ×1
  • LibraryUpdateJob.updateChapterList (cognitive 22) app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:389 — LibraryUpdateJob.updateChapterList has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 2 (3 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LibraryScreenModel.applyFilters (cognitive 22) · ×1
  • LibraryScreenModel.applyFilters (cognitive 22) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:426 — LibraryScreenModel.applyFilters has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13, boolean chains 9. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · EditMangaDialogKt.onViewCreated (cognitive 22) · ×1
  • EditMangaDialogKt.onViewCreated (cognitive 22) app/src/main/java/eu/kanade/tachiyomi/ui/manga/EditMangaDialog.kt:234 — EditMangaDialogKt.onViewCreated has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (20 pts), match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MangaScreenKt.MangaScreenLargeImpl (cognitive 21) · ×1
  • MangaScreenKt.MangaScreenLargeImpl (cognitive 21) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:808 — MangaScreenKt.MangaScreenLargeImpl has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LibraryScreenModel.filterLibrary (cognitive 21) · ×1
  • LibraryScreenModel.filterLibrary (cognitive 21) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:1195 — LibraryScreenModel.filterLibrary has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (18 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EHentaiUpdateWorker.startUpdating (cognitive 21) · ×1
  • EHentaiUpdateWorker.startUpdating (cognitive 21) app/src/main/java/exh/eh/EHentaiUpdateWorker.kt:102 — EHentaiUpdateWorker.startUpdating has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 4, error handling 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SearchEngine.parseQuery (cognitive 21) · ×1
  • SearchEngine.parseQuery (cognitive 21) app/src/main/java/exh/search/SearchEngine.kt:129 — SearchEngine.parseQuery has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11, boolean chains 8, match/switch 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ReaderViewModel.init (cognitive 20) · ×1
  • ReaderViewModel.init (cognitive 20) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:418 — ReaderViewModel.init has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (19 pts), error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExtensionsScreenKt.ExtensionItemContent (cognitive 19) · ×1
  • ExtensionsScreenKt.ExtensionItemContent (cognitive 19) app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt:365 — ExtensionsScreenKt.ExtensionItemContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 3, match/switch 2 (3 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem (cognitive 19) · ×1
  • BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem (cognitive 19) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:108 — BrowseSourceEHentaiListKt.BrowseSourceEHentaiListItem has cognitive complexity 19 (threshold 15). Drivers by points: if/else 16 (17 pts), boolean chains 1, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · WebViewScreenContentKt.WebViewScreenContent (cognitive 19) · ×1
  • WebViewScreenContentKt.WebViewScreenContent (cognitive 19) app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:69 — WebViewScreenContentKt.WebViewScreenContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14 (15 pts), boolean chains 3, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MangaCoverMetadata.setRatioAndColors (cognitive 19) · ×1
  • MangaCoverMetadata.setRatioAndColors (cognitive 19) app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverMetadata.kt:77 — MangaCoverMetadata.setRatioAndColors has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 5, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · FilterHandler.getQueryMap (cognitive 19) · ×1
  • FilterHandler.getQueryMap (cognitive 19) app/src/main/java/exh/md/handlers/FilterHandler.kt:167 — FilterHandler.getQueryMap has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (14 pts), match/switch 2 (4 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RateLimitInterceptor.intercept (cognitive 19) · ×1
  • RateLimitInterceptor.intercept (cognitive 19) core/common/src/main/kotlin/eu/kanade/tachiyomi/network/interceptor/RateLimitInterceptor.kt:68 — RateLimitInterceptor.intercept has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (9 pts), error handling 2 (4 pts), loops 2 (3 pts), boolean chains 2, match/switch 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MangaChapterListItemKt.MangaChapterListItem (cognitive 18) · ×1
  • MangaChapterListItemKt.MangaChapterListItem (cognitive 18) app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt:50 — MangaChapterListItemKt.MangaChapterListItem has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ReaderBottomBarKt.ReaderBottomBar (cognitive 18) · ×1
  • ReaderBottomBarKt.ReaderBottomBar (cognitive 18) app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderBottomBar.kt:29 — ReaderBottomBarKt.ReaderBottomBar has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (13 pts), boolean chains 4, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MigrationConfigScreen.Content (cognitive 18) · ×1
  • MigrationConfigScreen.Content (cognitive 18) app/src/main/java/mihon/feature/migration/config/MigrationConfigScreen.kt:99 — MigrationConfigScreen.Content has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 3 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LibrarySettingsDialogKt.SortPage (cognitive 17) · ×1
  • LibrarySettingsDialogKt.SortPage (cognitive 17) app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt:220 — LibrarySettingsDialogKt.SortPage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 14 (16 pts), match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MangaBackupCreator.backupManga (cognitive 17) · ×1
  • MangaBackupCreator.backupManga (cognitive 17) app/src/main/java/eu/kanade/tachiyomi/data/backup/create/creators/MangaBackupCreator.kt:44 — MangaBackupCreator.backupManga has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (17 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GlobalSearchScreen.Content (cognitive 17) · ×1
  • GlobalSearchScreen.Content (cognitive 17) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchScreen.kt:30 — GlobalSearchScreen.Content has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LibraryScreenModel.applySort (cognitive 17) · ×1
  • LibraryScreenModel.applySort (cognitive 17) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:612 — LibraryScreenModel.applySort has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 3 (4 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReaderActivity.enableExhAutoScroll (cognitive 17) · ×1
  • ReaderActivity.enableExhAutoScroll (cognitive 17) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt:780 — ReaderActivity.enableExhAutoScroll has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), match/switch 1 (4 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EHentaiUpdateHelper.getChapterList (cognitive 17) · ×1
  • EHentaiUpdateHelper.getChapterList (cognitive 17) app/src/main/java/exh/eh/EHentaiUpdateHelper.kt:208 — EHentaiUpdateHelper.getChapterList has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 4, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseSmartSearchEngine.removeTextInBrackets (cognitive 17) · ×1
  • BaseSmartSearchEngine.removeTextInBrackets (cognitive 17) app/src/main/java/mihon/feature/migration/list/search/BaseSmartSearchEngine.kt:103 — BaseSmartSearchEngine.removeTextInBrackets has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (13 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ScrollbarKt.onDrawScrollbar (cognitive 17) · ×1
  • ScrollbarKt.onDrawScrollbar (cognitive 17) presentation-core/src/main/java/tachiyomi/presentation/core/util/Scrollbar.kt:143 — ScrollbarKt.onDrawScrollbar has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (17 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SmartSearchMerge.smartSearchMerge (cognitive 16) · ×1
  • SmartSearchMerge.smartSearchMerge (cognitive 16) app/src/main/java/eu/kanade/domain/manga/interactor/SmartSearchMerge.kt:37 — SmartSearchMerge.smartSearchMerge has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppLanguageScreen.getLangs (cognitive 16) · ×1
  • AppLanguageScreen.getLangs (cognitive 16) app/src/main/java/eu/kanade/presentation/more/settings/screen/appearance/AppLanguageScreen.kt:116 — AppLanguageScreen.getLangs has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExtensionLoader.loadExtension (cognitive 16) · ×1
  • ExtensionLoader.loadExtension (cognitive 16) app/src/main/java/eu/kanade/tachiyomi/extension/util/ExtensionLoader.kt:247 — ExtensionLoader.loadExtension has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9, boolean chains 3, error handling 2, match/switch 2. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SourcesScreenModel.collectLatestSources (cognitive 16) · ×1
  • SourcesScreenModel.collectLatestSources (cognitive 16) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourcesScreenModel.kt:97 — SourcesScreenModel.collectLatestSources has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 10, if/else 4, match/switch 2. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · LocalSource.getSearchManga (cognitive 16) · ×1
  • LocalSource.getSearchManga (cognitive 16) source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt:86 — LocalSource.getSearchManga has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 3, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member pair (185 shared lines) · ×1
  • Near-duplicate member pair (185 shared lines) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:422 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:422-805 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:882-1242 — These two members are variants of one another: 185 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (83 shared lines) · ×1
  • Near-duplicate member pair (83 shared lines) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:75 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:75-237 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:287-426 — These two members are variants of one another: 83 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (52 shared lines) · ×1
  • Near-duplicate member pair (52 shared lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:113 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:113-213 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:218-315 — These two members are variants of one another: 52 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (35 shared lines) · ×1
  • Near-duplicate member pair (35 shared lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:242 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:242-370 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt:373-495 — These two members are variants of one another: 35 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copies of one member (3 members, 79+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 79+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:42 — app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:42-124 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt:41-122 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasList.kt:36-114 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 79 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (67 corresponding lines) · ×1
  • Edited copy of a member (67 corresponding lines) app/src/main/java/eu/kanade/presentation/components/Chip.kt:594 — app/src/main/java/eu/kanade/presentation/components/Chip.kt:594-670 | presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:239-305 — These two members are one piece of code written twice and then edited apart: 67 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 57+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 57+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:86 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt:86-142 | app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:66-122 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1708-1766 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 57 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (60 corresponding lines) · ×1
  • Edited copy of a member (60 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/category/CategoryScreen.kt:25 — app/src/main/java/eu/kanade/tachiyomi/ui/category/CategoryScreen.kt:25-84 | app/src/main/java/eu/kanade/tachiyomi/ui/category/sources/SourceCategoryScreen.kt:25-88 — These two members are one piece of code written twice and then edited apart: 60 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (124 corresponding lines) · ×1
  • Edited copy of a member (124 corresponding lines) app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:180 — app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:180-322 | app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:114-237 — These two members are one piece of code written twice and then edited apart: 124 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (48 corresponding lines) · ×1
  • Edited copy of a member (48 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:32 — app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:32-79 | app/src/main/java/eu/kanade/presentation/browse/SourceFeedOrderScreen.kt:38-102 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (50 corresponding lines) · ×1
  • Edited copy of a member (50 corresponding lines) app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:23 — app/src/main/java/eu/kanade/presentation/library/DeleteLibraryMangaDialog.kt:23-74 | app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt:75-124 — These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (47 corresponding lines) · ×1
  • Edited copy of a member (47 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:907 — app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:907-956 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:958-1004 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 50+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 50+ corresponding lines) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:26 — app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:26-78 | app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt:24-73 | app/src/main/java/eu/kanade/presentation/library/components/LibraryList.kt:26-80 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 50 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (40 corresponding lines) · ×1
  • Edited copy of a member (40 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:271 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedScreenModel.kt:271-326 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreenModel.kt:211-250 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 41+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 41+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:314 — app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:314-354 | app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:359-402 | app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:407-459 | app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt:473-524 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 41 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 30+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 30+ corresponding lines) app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:35 — app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:35-65 | app/src/main/java/eu/kanade/presentation/more/NewUpdateScreen.kt:34-64 | app/src/main/java/eu/kanade/presentation/more/WhatsNewScreen.kt:35-64 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 35+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 35+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:42 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:42-82 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:41-80 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:71-105 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt:37-73 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 35 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (41 corresponding lines) · ×1
  • Edited copy of a member (41 corresponding lines) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:221 — app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:221-261 | app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:276-318 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×1
  • Edited copy of a member (31 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:146 — app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:146-178 | app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt:309-339 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 25+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 25+ corresponding lines) app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt:27 — app/src/main/java/eu/kanade/presentation/category/components/biometric/BiometricTimesListItem.kt:27-51 | app/src/main/java/eu/kanade/presentation/category/components/genre/SortTagListItem.kt:32-68 | app/src/main/java/eu/kanade/presentation/category/components/sources/SourceCategoryListItem.kt:29-57 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) domain/src/main/java/tachiyomi/domain/category/interactor/ReorderCategory.kt:17 — domain/src/main/java/tachiyomi/domain/category/interactor/ReorderCategory.kt:17-45 | domain/src/main/java/tachiyomi/domain/source/interactor/ReorderFeed.kt:18-50 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (34 corresponding lines) · ×1
  • Edited copy of a member (34 corresponding lines) app/src/main/java/eu/kanade/presentation/browse/RelatedMangasScreen.kt:133 — app/src/main/java/eu/kanade/presentation/browse/RelatedMangasScreen.kt:133-166 | app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchResultItems.kt:43-79 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×1
  • Edited copy of a member (36 corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/about/OpenSourceLibraryLicenseScreen.kt:33 — app/src/main/java/eu/kanade/presentation/more/settings/screen/about/OpenSourceLibraryLicenseScreen.kt:33-68 | app/src/main/java/eu/kanade/presentation/more/settings/screen/debug/BackupSchemaScreen.kt:35-72 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 34+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 34+ corresponding lines) app/src/main/java/eu/kanade/presentation/category/BiometricTimesScreen.kt:28 — app/src/main/java/eu/kanade/presentation/category/BiometricTimesScreen.kt:28-61 | app/src/main/java/eu/kanade/presentation/category/CategoryScreen.kt:44-81 | app/src/main/java/eu/kanade/presentation/category/SortTagScreen.kt:29-64 | app/src/main/java/eu/kanade/presentation/category/SourceCategoryScreen.kt:29-63 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 34 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 22+ corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:384 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:384-408 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:414-438 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:637-658 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsEhScreen.kt:803-824 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 20+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 20+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:423 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:423-442 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:476-496 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt:535-555 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 21+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 21+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:61 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceDialogs.kt:61-86 | app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:40-60 | app/src/main/java/eu/kanade/presentation/browse/components/SourceFeedDialogs.kt:66-86 | app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesConfirmDialog.kt:16-37 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 49+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 49+ corresponding lines) REDACTED:197 — REDACTED:197-259 | REDACTED:261-342 | REDACTED:458-506 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 49 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 21+ corresponding lines) app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt:66 — app/src/main/java/eu/kanade/presentation/history/components/HistoryDialogs.kt:66-89 | app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:109-132 | app/src/main/java/eu/kanade/presentation/updates/UpdatesDeleteConfirmationDialog.kt:14-34 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 18+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:183 — app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt:183-201 | app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt:51-70 | app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt:100-117 | app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt:98-116 | app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt:67-85 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 17+ corresponding lines) app/src/main/java/exh/md/handlers/BilibiliHandler.kt:79 — app/src/main/java/exh/md/handlers/BilibiliHandler.kt:79-96 | app/src/main/java/exh/md/handlers/BilibiliHandler.kt:126-144 | app/src/main/java/exh/md/handlers/BilibiliHandler.kt:166-182 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 17+ corresponding lines) app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt:576 — app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt:576-596 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:703-719 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsMangadexScreen.kt:85-102 | app/src/main/java/mihon/feature/migration/list/components/MigrationExitDialog.kt:14-31 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×1
  • Edited copy of a member (6 corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:298 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:298-303 | app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt:885-890 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 18+ corresponding lines) app/src/main/java/exh/md/service/MangaDexAuthService.kt:180 — app/src/main/java/exh/md/service/MangaDexAuthService.kt:180-197 | app/src/main/java/exh/md/service/MangaDexService.kt:35-54 | app/src/main/java/exh/md/service/MangaDexService.kt:80-97 | app/src/main/java/exh/md/service/MangaDexService.kt:102-119 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 11+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 11+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:124 — app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:124-134 | app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:136-146 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:458-470 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:472-484 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 5+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 5+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:357 — app/src/main/java/eu/kanade/tachiyomi/source/online/all/EHentai.kt:357-362 | source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/CatalogueSource.kt:40-44 | source-api/src/commonMain/kotlin/exh/source/DelegatedHttpSource.kt:154-163 | source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt:204-208 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) app/src/main/java/exh/md/handlers/AzukiHandler.kt:28 — app/src/main/java/exh/md/handlers/AzukiHandler.kt:28-35 | app/src/main/java/exh/md/handlers/ComikeyHandler.kt:51-58 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 9+ corresponding lines) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:112 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:112-120 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordScreen.kt:57-65 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:81-89 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 11+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 11+ corresponding lines) app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupCreateJob.kt:69 — app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupCreateJob.kt:69-79 | app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/BackupRestoreJob.kt:75-85 | app/src/main/java/eu/kanade/tachiyomi/data/sync/SyncDataJob.kt:69-79 | app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateDownloadJob.kt:112-122 | app/src/main/java/exh/eh/EHentaiUpdateWorker.kt:90-100 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (70 lines × 2) · ×1
  • Duplicated block (70 lines × 2) app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:196 — app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:196-265 | app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:132-201 — before extracting anything, compare `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt` and `app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 162 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:196` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (59 lines × 3) · ×1
  • Duplicated block (59 lines × 3) app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:237 — app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:237-295 | app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:173-231 | presentation-core/src/main/java/tachiyomi/presentation/core/icons/FlagEmoji.kt:230-288 — before extracting anything, compare `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt` and `app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 162 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:237` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (50–51 lines × 2) · ×1
  • Duplicated block (50–51 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:539 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:539-588 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:996-1046 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:539` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:589` calls `calculateTopPadding` and `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1047` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (47 lines × 2) · ×1
  • Duplicated block (47 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:43 — app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:43-89 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt:42-88 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 95 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×1
  • Duplicated block (42 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt:62 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt:62-103 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceToolbar.kt:114-155 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceSimpleToolbar.kt:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (38 lines × 3) · ×1
  • Duplicated block (38 lines × 3) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:117 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:117-154 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt:112-149 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt:103-140 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt` as WHOLE FILES: 94% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32–35 lines × 2) · ×1
  • Duplicated block (32–35 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:459 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:459-490 | app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt:165-199 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt` and `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:459` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (33 lines × 3) · ×1
  • Duplicated block (33 lines × 3) app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:203 — app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:203-235 | app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt:139-171 | presentation-core/src/main/java/tachiyomi/presentation/core/icons/FlagEmoji.kt:196-228 — before extracting anything, compare `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt` and `app/src/main/java/eu/kanade/presentation/browse/ExtensionFilterScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 162 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:203` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32–33 lines × 2) · ×1
  • Duplicated block (32–33 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:771 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:771-803 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:1206-1237 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:771` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (29 lines × 3) · ×1
  • Duplicated block (29 lines × 3) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:78 — app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:78-106 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt:77-105 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasList.kt:69-97 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 95 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:78` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (27–29 lines × 2) · ×1
  • Duplicated block (27–29 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:372 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:372-400 | app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt:127-153 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt` and `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:372` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (46–50 lines × 2) · ×1
  • Duplicated block (46–50 lines × 2) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:173 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:173-218 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:359-408 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:173` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:219` calls `padding` and `presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:409` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (27–28 lines × 2) · ×1
  • Duplicated block (27–28 lines × 2) app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:234 — app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:234-261 | app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:289-315 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/mihon/feature/upcoming/UpcomingScreenContent.kt:234` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:173 — app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:173-198 | app/src/main/java/exh/recs/batch/RecommendationSearchProgressDialog.kt:85-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:173` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (45–46 lines × 2) · ×1
  • Duplicated block (45–46 lines × 2) app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:237 — app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:237-281 | app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:299-344 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt:237` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAppearanceScreen.kt:112 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAppearanceScreen.kt:112-135 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAppearanceScreen.kt:175-198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (22–24 lines × 2) · ×1
  • Duplicated block (22–24 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:375 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:375-396 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt:407-430 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:375` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 3) · ×1
  • Duplicated block (22 lines × 3) app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:44 — app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:44-65 | app/src/main/java/eu/kanade/presentation/more/NewUpdateScreen.kt:43-64 | app/src/main/java/eu/kanade/presentation/more/WhatsNewScreen.kt:43-64 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/NewUpdateScreen.kt` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/ComingUpdatesScreen.kt:44` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:317 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:317-338 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:256-277 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:317` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×1
  • Duplicated block (21 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1722 — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1722-1742 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:412-432 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1722` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19–20 lines × 2) · ×1
  • Duplicated block (19–20 lines × 2) app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:61 — app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:61-79 | app/src/main/java/eu/kanade/presentation/browse/SourceFeedOrderScreen.kt:82-101 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/FeedOrderScreen.kt:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×1
  • Duplicated block (19 lines × 3) app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:54 — app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt:54-72 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt:53-71 | app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasList.kt:45-63 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/browse/components/RelatedMangasCompactGrid.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 95 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (18–19 lines × 2) · ×1
  • Duplicated block (18–19 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt:92 — app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt:92-109 | app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt:269-287 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt:92` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (18 lines × 4) · ×1
  • Duplicated block (18 lines × 4) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:96 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:96-113 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:193-210 | app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt:70-87 | app/src/main/java/exh/recs/BrowseRecommendsScreen.kt:95-112 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt` and `app/src/main/java/exh/md/follows/MangaDexFollowsScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:54 — app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:54-71 | app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt:52-69 | app/src/main/java/eu/kanade/presentation/library/components/LibraryList.kt:59-76 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt` and `app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:54` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (17–18 lines × 2) · ×1
  • Duplicated block (17–18 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:77 — app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:77-94 | app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:175-191 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionStoresDialogs.kt:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–18 lines × 2) · ×1
  • Duplicated block (16–18 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:194 — app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:194-209 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:393-410 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:194` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateSourceSearchScreen.kt:192` calls `push`, `MangaScreen` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt:393` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (15–17 lines × 2) · ×1
  • Duplicated block (15–17 lines × 2) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:405 — app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:405-421 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:693-707 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:405` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (14–15 lines × 4) · ×1
  • Duplicated block (14–15 lines × 4) app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:515 — app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:515-528 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:533-547 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:604-617 | app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:626-640 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt:515` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×1
  • Duplicated block (14–15 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:46 — app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:46-59 | app/src/main/java/exh/ui/login/EhLoginActivity.kt:38-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/webview/WebViewActivity.kt:46` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:318 — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:318-331 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:1728-1741 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:418-431 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:318` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:131 — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:131-143 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt:233-246 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt` and `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsTrackingScreen.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:131` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (12–14 lines × 2) · ×1
  • Duplicated block (12–14 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:119 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:119-132 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt:139-150 — before extracting anything, compare `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonPageHolder.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 34 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:119` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:74 — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:74-84 | app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt:40-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt:74` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×1
  • Duplicated block (12 lines × 4) app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:222 — app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:222-233 | app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:100-111 | app/src/main/java/eu/kanade/presentation/manga/components/MangaBottomActionMenu.kt:292-303 | app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt:321-332 — before extracting anything, compare `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt` and `app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreen.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 97 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt:222` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:37 — app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:37-47 | app/src/main/java/exh/ui/metadata/adapters/MangaDexDescriptionAdapter.kt:29-39 | app/src/main/java/exh/ui/metadata/adapters/PururinDescriptionAdapter.kt:31-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/exh/ui/metadata/adapters/EHentaiDescriptionAdapter.kt:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1236 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1236-1246 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1350-1359 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) app/src/main/java/exh/md/handlers/BilibiliHandler.kt:83 — app/src/main/java/exh/md/handlers/BilibiliHandler.kt:83-91 | app/src/main/java/exh/md/handlers/BilibiliHandler.kt:130-139 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/exh/md/handlers/BilibiliHandler.kt:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×1
  • Duplicated block (8–9 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:241 — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:241-249 | app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:839-846 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:241` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:238` calls `addFavorite` and `app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt:836` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1191 — app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1191-1198 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1317-1324 | app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:1386-1393 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:69 — app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:69-75 | app/src/main/java/eu/kanade/tachiyomi/ui/updates/UpdatesScreenModel.kt:383-390 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (4–7 lines × 3) · ×1
  • Duplicated block (4–7 lines × 3) app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt:491 — app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt:491-497 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt:158-161 | app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsLibraryScreen.kt:148-154 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt:491` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (4–5 lines × 3) · ×1
  • Duplicated block (4–5 lines × 3) presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:332 — presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:332-335 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:431-435 | presentation-core/src/main/java/tachiyomi/presentation/core/components/VerticalFastScroller.kt:444-448 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) REDACTED:40 — REDACTED:40-45 | app/src/main/java/eu/kanade/tachiyomi/data/track/komga/Komga.kt:37-42 | app/src/main/java/eu/kanade/tachiyomi/data/track/suwayomi/Suwayomi.kt:33-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/DeleteLibraryUpdateErrors.kt:22 — domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/DeleteLibraryUpdateErrors.kt:22-30 | domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/DeleteLibraryUpdateErrors.kt:32-40 | domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/InsertLibraryUpdateErrors.kt:13-21 | domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/InsertLibraryUpdateErrors.kt:23-31 | domain/src/main/java/tachiyomi/domain/libraryUpdateError/interactor/InsertLibraryUpdateErrors.kt:33-41 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
D5 · Coupling · Unstable project · ×1
  • Unstable project :source-local — :source-local has instability 0.88 with 1 dependents.
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: :telemetry — :telemetry: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
X15 · Unvalidated length from an untrusted reader · Length read from the parsed input is spent without ever being bounded · ×1
  • Length read from the parsed input is spent without ever being bounded app/src/main/java/exh/eh/MemAutoFlushingLookupTable.kt:93 — `size` is read from the bytes being parsed at line 92 (`getInt`), then used to size a `ByteArray` at line 93 — and nowhere in its scope is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining and a maximum the format allows before allocating.
Minor — 335 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×277
  • Orphaned file app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/track/TrackerSearch.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/components/AppBar.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadQueueScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/track/TrackInfoDialogHome.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/tachiyomi/ui/setting/connections/DiscordLoginScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/reader/components/ChapterNavigator.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDiscordScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/settings/screen/advanced/ClearDatabaseScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSearchScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/reader/ChapterTransition.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/exh/md/handlers/ApiMangaParser.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/exh/uconfig/EhUConfigBuilder.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/exh/md/handlers/FilterHandler.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/category/components/CategoryDialogs.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsMangadexScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/manga/components/MarkdownRender.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsConnectionScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 252 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×36
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:440 — `!config.volumeKeysEnabled || activity.viewModel.state.value.menuVisible` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/SearchScreenModel.kt:273 — `!onlyShowHasResults || (this is Success && !this.isEmpty)` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/SearchScreenModel.kt, app/src/main/java/exh/recs/RecommendsScreenModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt:218 — `!response.isSuccessful && response.code != HTTP_NOT_MODIFIED` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt, app/src/main/java/eu/kanade/tachiyomi/data/coil/PagePreviewFetcher.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt:555 — `Build.VERSION.SDK_INT < Build.VERSION_CODES.Q && context.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.P…` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt:285 — `DeviceUtil.isMiui && DeviceUtil.isMiuiOptimizationDisabled()` appears character-identically in 3 files — app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt, app/src/main/java/eu/kanade/presentation/more/settings/screen/data/CreateBackupScreen.kt, app/src/main/java/eu/kanade/presentation/more/settings/screen/data/RestoreBackupScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:329 — `MANGA_HAS_UNREAD in restrictions && it.unreadCount != 0L` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt, domain/src/main/java/mihon/domain/upcoming/interactor/GetUpcomingManga.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:324 — `MANGA_NON_COMPLETED in restrictions && it.manga.status.toInt() == SManga.COMPLETED` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt, domain/src/main/java/mihon/domain/upcoming/interactor/GetUpcomingManga.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:334 — `MANGA_NON_READ in restrictions && it.totalChapters > 0L && !it.hasStarted` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt, domain/src/main/java/mihon/domain/upcoming/interactor/GetUpcomingManga.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:138 — `activity.viewModel.state.value.menuVisible || config.longTapEnabled` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:445 — `beforeDate != afterDate && afterDate != null` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt, app/src/main/java/mihon/feature/upcoming/UpcomingScreenModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt:118 — `bulkFavoriteState.selectionMode || showingFeedOrderScreen.value` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt, app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/feed/SourceFeedScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:165 — `config.navigationOverlayOnStart || config.forceNavigationOverlay` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:167 — `defaultCategoryId == 0 || categories.isEmpty()` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt, app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt:254 — `defaultCategoryId == 0L || categories.isEmpty()` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/history/HistoryScreenModel.kt, app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:185 — `dialog.negativeButton != null && dialog.negativeButtonText != null` appears character-identically in 2 files — app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt, app/src/main/java/exh/recs/batch/RecommendationSearchProgressDialog.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt:178 — `dialog.positiveButton != null && dialog.positiveButtonText != null` appears character-identically in 2 files — app/src/main/java/eu/kanade/presentation/library/components/SyncFavoritesProgressDialog.kt, app/src/main/java/exh/recs/batch/RecommendationSearchProgressDialog.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt:213 — `file == "journal" || file.startsWith("journal.")` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt, app/src/main/java/eu/kanade/tachiyomi/data/cache/PagePreviewCache.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/connections/ConnectionsService.kt:54 — `getUsername().isNotEmpty() && getPassword().isNotEmpty()` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/connections/ConnectionsService.kt, app/src/main/java/eu/kanade/tachiyomi/data/track/BaseTracker.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt:263 — `inPreloadRange && allowPreload && page.chapter == adapter.currentChapter` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonViewer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt:264 — `includedCategories.isEmpty() || it.categories.intersect(includedCategories).isNotEmpty()` appears character-identically in 3 files — app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt, app/src/main/java/eu/kanade/tachiyomi/ui/stats/StatsScreenModel.kt, domain/src/main/java/mihon/domain/upcoming/interactor/GetUpcomingManga.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupOptions.kt:44 — `libraryEntries || categories || appSettings || extensionStores || sourceSettings || savedSearchesFeeds` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/data/backup/create/BackupOptions.kt, app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/RestoreOptions.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt:76 — `mangaList.loadState.refresh is LoadState.Loading || mangaList.loadState.append is LoadState.Loading` appears character-identically in 4 files — app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceComfortableGrid.kt, app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceCompactGrid.kt, app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceEHentaiList.kt, app/src/main/java/eu/kanade/presentation/browse/components/BrowseSourceList.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt:357 — `new.favorite && (fetchMetadataOnAdd || fetchChaptersOnAdd)` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/browse/BulkFavoriteScreenModel.kt, app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt:112 — `nextHasMissingChapters || forceTransition || chapters.nextChapter?.state !is ReaderChapter.State.Loaded` appears character-identically in 2 files — app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewerAdapter.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonAdapter.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt:67 — `onClickContinueReading != null && libraryItem.unreadCount > 0` appears character-identically in 3 files — app/src/main/java/eu/kanade/presentation/library/components/LibraryComfortableGrid.kt, app/src/main/java/eu/kanade/presentation/library/components/LibraryCompactGrid.kt, app/src/main/java/eu/kanade/presentation/library/components/LibraryList.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • + 11 more in this group — see findings.md.
X7 · Silent fallback defaults · Silent fallback default in catch · ×5
  • Silent fallback default in catch app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/dto/ALFuzzyDate.kt:18 — `toEpochMilli` swallows every exception into `0L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch app/src/main/java/exh/md/utils/MdExtensions.kt:25 — `asMdMap` swallows every exception into `emptyMap()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:58 — `getTotalStorageSpace` swallows every exception into `-1L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:70 — `getAvailableStorageSpace` swallows every exception into `-1L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt:82 — `getAvailableStorageSpace` swallows every exception into `-1L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
D16 · Bus Factor · Off-boarding risk · ×2
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 26 significant file(s) lose their only recent owner: app/src/main/java/eu/kanade/presentation/updates/UpdatesUiItem.kt, app/src/main/java/eu/kanade/presentation/libraryUpdateError/LibraryUpdateErrorScreen.kt, app/src/main/java/eu/kanade/presentation/browse/SourceFeedScreen.kt, app/src/main/java/eu/kanade/tachiyomi/ui/browse/feed/FeedTab.kt, app/src/main/java/exh/debug/SettingsDebugScreen.kt, app/src/main/java/exh/md/service/MangaDexService.kt, app/src/main/java/eu/kanade/tachiyomi/ui/libraryUpdateError/LibraryUpdateErrorScreenModel.kt, app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/manga/MigrateMangaScreenModel.kt (+18 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 10 significant file(s) lose their only recent owner: app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesTextArea.kt, app/src/main/java/eu/kanade/presentation/more/settings/screen/debug/DebugInfoScreen.kt, app/src/main/java/mihon/domain/source/interactor/UpdateMangaFromRemote.kt, app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonAdapter.kt, data/src/main/java/mihon/data/extension/model/NetworkExtensionStore.kt, source-api/src/commonMain/kotlin/eu/kanade/tachiyomi/source/model/SManga.kt, app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt (+2 more). Pair on, review, or document these before any departure.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 3 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (40 single-owned of 612 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 612 of the 1369 production source files in this repository met that bar). They are anonymized user #2 (2 file(s)), anonymized user #3 (1 file(s)), anonymized user #4 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: data/src/main/java/mihon/data/extension/service/ExtensionStoreService.kt, data/src/main/java/mihon/data/extension/repository/ExtensionStoreRepositoryImpl.kt, app/src/main/java/exh/ui/login/EhLoginActivity.kt, app/src/main/java/exh/util/MangaType.kt.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found app/build.gradle.kts:7 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `app/build.gradle.kts` makes this repository a deployable product (line 7).
D21 · Naming Consistency · `getLanguageIconID` spells `ID` where 369 names in the project spell it `Id` · ×1
  • `getLanguageIconID` spells `ID` where 369 names in the project spell it `Id` app/src/main/java/eu/kanade/domain/extension/interactor/GetExtensionLanguages.kt:42 — 369 of 373 names in project app spell the token `Id` (369 of 373; unit: names in project app containing `Id`). Peers: BasePreferences.installationId (app/src/main/java/eu/kanade/domain/base/BasePreferences.kt:39); GetAvailableScanlators.await(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:15); GetAvailableScanlators.subscribe(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:20); GetAvailableScanlators.awaitMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:26); GetAvailableScanlators.subscribeMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:31). Rename to `getLanguageIconId`. [rule N6]
D21 · Naming Consistency · `clientAPIKey` spells `API` where 22 names in the project spell it `Api` · ×1
  • `clientAPIKey` spells `API` where 22 names in the project spell it `Api` app/src/main/java/eu/kanade/domain/sync/SyncPreferences.kt:14 — 22 of 23 names in project app spell the token `Api` (22 of 23; unit: names in project app containing `Api`). Peers: eu.kanade.tachiyomi.data.track.anilist.AnilistApi (REDACTED:40); AnilistUtilsKt.toApiStatus (app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/AnilistUtils.kt:8); AnilistUtilsKt.toApiScore (app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/AnilistUtils.kt:20); eu.kanade.tachiyomi.data.track.bangumi.BangumiApi (REDACTED:35); BangumiUtilsKt.toApiStatus (app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/BangumiUtils.kt:5). Rename to `clientApiKey`. [rule N6]
D21 · Naming Consistency · `uniqueDeviceID` spells `ID` where 369 names in the project spell it `Id` · ×1
  • `uniqueDeviceID` spells `ID` where 369 names in the project spell it `Id` app/src/main/java/eu/kanade/domain/sync/SyncPreferences.kt:39 — 369 of 373 names in project app spell the token `Id` (369 of 373; unit: names in project app containing `Id`). Peers: BasePreferences.installationId (app/src/main/java/eu/kanade/domain/base/BasePreferences.kt:39); GetAvailableScanlators.await(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:15); GetAvailableScanlators.subscribe(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:20); GetAvailableScanlators.awaitMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:26); GetAvailableScanlators.subscribeMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:31). Rename to `uniqueDeviceId`. [rule N6]
D21 · Naming Consistency · `getRandomID` spells `ID` where 369 names in the project spell it `Id` · ×1
  • `getRandomID` spells `ID` where 369 names in the project spell it `Id` app/src/main/java/eu/kanade/tachiyomi/source/online/all/Lanraragi.kt:59 — 369 of 373 names in project app spell the token `Id` (369 of 373; unit: names in project app containing `Id`). Peers: BasePreferences.installationId (app/src/main/java/eu/kanade/domain/base/BasePreferences.kt:39); GetAvailableScanlators.await(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:15); GetAvailableScanlators.subscribe(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:20); GetAvailableScanlators.awaitMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:26); GetAvailableScanlators.subscribeMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:31). Rename to `getRandomId`. [rule N6]
D21 · Naming Consistency · `mangaID` spells `ID` where 369 names in the project spell it `Id` · ×1
  • `mangaID` spells `ID` where 369 names in the project spell it `Id` app/src/main/java/eu/kanade/tachiyomi/source/online/all/MangaDex.kt:323 — 369 of 373 names in project app spell the token `Id` (369 of 373; unit: names in project app containing `Id`). Peers: BasePreferences.installationId (app/src/main/java/eu/kanade/domain/base/BasePreferences.kt:39); GetAvailableScanlators.await(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:15); GetAvailableScanlators.subscribe(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:20); GetAvailableScanlators.awaitMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:26); GetAvailableScanlators.subscribeMerge(mangaId) (app/src/main/java/eu/kanade/domain/chapter/interactor/GetAvailableScanlators.kt:31). Rename to `mangaId`. [rule N6]
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 2 of 14 project(s) overshoot their size bounds, lowering Project Cohesion to 7.1/10. The most over is `app` (147585 LoC, 2205 module-visible types across 225 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 277 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerViewer.kt, app/src/main/java/eu/kanade/presentation/track/TrackerSearch.kt, app/src/main/java/eu/kanade/presentation/components/AppBar.kt, app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/PagerPageHolder.kt, presentation-core/src/main/java/tachiyomi/presentation/core/components/material/Button.kt, app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadQueueScreen.kt, app/src/main/java/eu/kanade/presentation/track/TrackInfoDialogHome.kt, app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt (and 269 more) (284 orphaned of 613 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 613 of the 1369 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST REDACTED:8 — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 9 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
X9 · Subsumed condition operand · Subsumed condition operand · ×1
  • Subsumed condition operand app/src/main/java/eu/kanade/presentation/webview/WebViewScreenContent.kt:139 — `url.startsWith("https")` can never decide this `||` — every value satisfying `url.startsWith("https")` also satisfies `url.startsWith("http")`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Minor — 1 finding(s)
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: :core:common — :core:common: abstractness 0.09, instability 0.18, distance 0.73 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-039c567e6a4b4295924cfb4effa0f52e/history.json --exit-code 0 --source .15artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-039c567e6a4b4295924cfb4effa0f52e/tree.json --exit-code 0 --source .3artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .11artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 53 file(s) — `app/src/main/java/eu/kanade/domain/source/interactor/GetEnabledSources.kt`, `app/src/main/java/eu/kanade/presentation/browse/components/BaseSourceItem.kt`, `app/src/main/java/eu/kanade/presentation/browse/components/GlobalSearchToolbar.kt`, `app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt`, `app/src/main/java/eu/kanade/presentation/manga/components/NamespaceTags.kt`, … (+48 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—

Run 01a1d690-a47a-70a6-a89c-466f8c8bcebe · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md