Public report of joggle-cn/joggle, published 16 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 16 November 2026, 20:38 UTC · Survey ID cd_7cb3e87d564f40fd92608aba629dad28
joggle-cn/joggle
Measured 16 November 2026, 20:37 UTC, at code version d24d918
First survey, so nothing to compare with yet
CAI scoreAt risk
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 39,353 lines of product code in 4 projects, tests not counted · Estimated rebuild effort: about 0.3 person-years · Weakest lens: Accessibility, 33.0
Findings by how serious they are
69 critical252 serious93 minor
16 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
16 November 2026, 20:37 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
68of 68 dimensions measured by tools.
398of 414 findings point to an exact file and line, so you can open each one in the code. The other 16 concern the repository as a whole, such as missing documentation.
68dimensions across 7 lenses, read from 39,353 lines of product code in 4 projects.
joggle-cn/joggle is rated At risk because critical security findings are open, most of them in the packages it uses. Its score is held back in part because it has pages that don't say their language. It scores 43.1 out of 100, which the At risk rating leaves unchanged.
Accessibility, at 33.0, is the weakest lens and counts most in the score. The best first step for the work it takes is fixing the three passwords or keys in the code's history, worth about 4.0 points. Making the controls keyboard-usable would lift Accessibility itself, worth about 7.2 points. Raising Accessibility to 70 would lift the score to about 51.5.
Thirty-three known security holes in the packages the code depends on can be used by attackers. Ten passwords or keys in the code's history and one in the code are open to anyone who can read the repository, and ten settings leave the servers or containers unsafe. Updating the vulnerable packages, replacing each exposed password or key and correcting the unsafe settings would close these risks. Reading outside data into plain values would fix the two places where outside data is turned straight into objects, and fixing the weaknesses the scanner points to would deal with the two security weaknesses in the code. The nine pages that don't say their language need their language set.
The product code is 39,353 lines, about €40,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Accessibility rose from 33.0 to 70, the lowest score rated Strong, the score would rise from 43.1 to about 51.5.
Code composition: what the lines of code are
Product code 99%Tests 1%
Rebuild cost: about €40,000 · Estimate
Cost to rebuild
€13,000 to €66,000, for 219 to 694 hours of work, about 0.3 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 43. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 39,353 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 3 REDACTED finding(s) in REDACTED Scanning — start with REDACTED (3).
Raises the score by about 4.0 points · Low effort · REDACTED Scanning
2
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Raises the score by about 7.2 points · Medium effort · Keyboard semantics
3
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Raises the score by about 5.5 points · Medium effort · Page structure
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €40,000 to build again, about 0.3 person-years of work. Its weakest lens is Accessibility, at 33.0 (Weak). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Resolve the 3 REDACTED finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 4.0 points for low effort, because it clears the 3 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
172 modules, with 428 dependencies between them. 2 loops run through 7 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 132 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
domain2.domain.vo uses domain2.entity, so a change to domain2.entity can break domain2.domain.vo, while a change to domain2.domain.vo can't break domain2.entity.
Position
Below the diagonal: domain2.domain.vo uses a module listed above it, which is the healthy direction.
device.domain.vo uses device.domain, so a change to device.domain can break device.domain.vo, while a change to device.domain.vo can't break device.domain.
Position
Below the diagonal: device.domain.vo uses a module listed above it, which is the healthy direction.
domain2.mapper uses domain2.entity, so a change to domain2.entity can break domain2.mapper, while a change to domain2.mapper can't break domain2.entity.
Position
Below the diagonal: domain2.mapper uses a module listed above it, which is the healthy direction.
domain2.mapper uses domain2.domain.vo, so a change to domain2.domain.vo can break domain2.mapper, while a change to domain2.mapper can't break domain2.domain.vo.
Position
Below the diagonal: domain2.mapper uses a module listed above it, which is the healthy direction.
domain2.service uses domain2.domain.vo, so a change to domain2.domain.vo can break domain2.service, while a change to domain2.service can't break domain2.domain.vo.
Position
Below the diagonal: domain2.service uses a module listed above it, which is the healthy direction.
system.service uses system.domain.dto, so a change to system.domain.dto can break system.service, while a change to system.service can't break system.domain.dto.
Position
Below the diagonal: system.service uses a module listed above it, which is the healthy direction.
device.service uses device.domain.dto, so a change to device.domain.dto can break device.service, while a change to device.service can't break device.domain.dto.
Position
Below the diagonal: device.service uses a module listed above it, which is the healthy direction.
device.service uses device.domain.vo, so a change to device.domain.vo can break device.service, while a change to device.service can't break device.domain.vo.
Position
Below the diagonal: device.service uses a module listed above it, which is the healthy direction.
business.impl uses device.domain.dto, so a change to device.domain.dto can break business.impl, while a change to business.impl can't break device.domain.dto.
Position
Below the diagonal: business.impl uses a module listed above it, which is the healthy direction.
business.impl uses domain2.service, so a change to domain2.service can break business.impl, while a change to business.impl can't break domain2.service.
Position
Below the diagonal: business.impl uses a module listed above it, which is the healthy direction.
controller uses domain.domain.session, so a change to domain.domain.session can break controller, while a change to controller can't break domain.domain.session.
Position
Below the diagonal: controller uses a module listed above it, which is the healthy direction.
device.service.impl uses device.domain.dto, so a change to device.domain.dto can break device.service.impl, while a change to device.service.impl can't break device.domain.dto.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses device.entity, so a change to device.entity can break device.service.impl, while a change to device.service.impl can't break device.entity.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses flow.service, so a change to flow.service can break device.service.impl, while a change to device.service.impl can't break flow.service.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses device.domain, so a change to device.domain can break device.service.impl, while a change to device.service.impl can't break device.domain.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses entity.api, so a change to entity.api can break device.service.impl, while a change to device.service.impl can't break entity.api.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses device.domain.vo, so a change to device.domain.vo can break device.service.impl, while a change to device.service.impl can't break device.domain.vo.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses domain2.mapper, so a change to domain2.mapper can break device.service.impl, while a change to device.service.impl can't break domain2.mapper.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses domain2.service, so a change to domain2.service can break device.service.impl, while a change to device.service.impl can't break domain2.service.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
device.service.impl uses device.service, so a change to device.service can break device.service.impl, while a change to device.service.impl can't break device.service.
Position
Below the diagonal: device.service.impl uses a module listed above it, which is the healthy direction.
domain2.controller uses common.domain, so a change to common.domain can break domain2.controller, while a change to domain2.controller can't break common.domain.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses domain.domain.session, so a change to domain.domain.session can break domain2.controller, while a change to domain2.controller can't break domain.domain.session.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses domain2.entity, so a change to domain2.entity can break domain2.controller, while a change to domain2.controller can't break domain2.entity.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses domain2.domain.vo, so a change to domain2.domain.vo can break domain2.controller, while a change to domain2.controller can't break domain2.domain.vo.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses entity.api, so a change to entity.api can break domain2.controller, while a change to domain2.controller can't break entity.api.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses domain2.service, so a change to domain2.service can break domain2.controller, while a change to domain2.controller can't break domain2.service.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
domain2.controller uses device.service, so a change to device.service can break domain2.controller, while a change to domain2.controller can't break device.service.
Position
Below the diagonal: domain2.controller uses a module listed above it, which is the healthy direction.
feedback.controller uses common.domain, so a change to common.domain can break feedback.controller, while a change to feedback.controller can't break common.domain.
Position
Below the diagonal: feedback.controller uses a module listed above it, which is the healthy direction.
feedback.controller uses domain.domain.session, so a change to domain.domain.session can break feedback.controller, while a change to feedback.controller can't break domain.domain.session.
Position
Below the diagonal: feedback.controller uses a module listed above it, which is the healthy direction.
feedback.controller uses entity.api, so a change to entity.api can break feedback.controller, while a change to feedback.controller can't break entity.api.
Position
Below the diagonal: feedback.controller uses a module listed above it, which is the healthy direction.
metrics.controller uses common.domain, so a change to common.domain can break metrics.controller, while a change to metrics.controller can't break common.domain.
Position
Below the diagonal: metrics.controller uses a module listed above it, which is the healthy direction.
metrics.controller uses flow.service, so a change to flow.service can break metrics.controller, while a change to metrics.controller can't break flow.service.
Position
Below the diagonal: metrics.controller uses a module listed above it, which is the healthy direction.
metrics.controller uses entity.api, so a change to entity.api can break metrics.controller, while a change to metrics.controller can't break entity.api.
Position
Below the diagonal: metrics.controller uses a module listed above it, which is the healthy direction.
metrics.controller uses metrics.service, so a change to metrics.service can break metrics.controller, while a change to metrics.controller can't break metrics.service.
Position
Below the diagonal: metrics.controller uses a module listed above it, which is the healthy direction.
metrics.service.impl uses REDACTED, so a change to REDACTED can break metrics.service.impl, while a change to metrics.service.impl can't break REDACTED.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses flow.service, so a change to flow.service can break metrics.service.impl, while a change to metrics.service.impl can't break flow.service.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses res.service, so a change to res.service can break metrics.service.impl, while a change to metrics.service.impl can't break res.service.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses entity.api, so a change to entity.api can break metrics.service.impl, while a change to metrics.service.impl can't break entity.api.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses business, so a change to business can break metrics.service.impl, while a change to metrics.service.impl can't break business.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses metrics.service, so a change to metrics.service can break metrics.service.impl, while a change to metrics.service.impl can't break metrics.service.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
metrics.service.impl uses device.service, so a change to device.service can break metrics.service.impl, while a change to metrics.service.impl can't break device.service.
Position
Below the diagonal: metrics.service.impl uses a module listed above it, which is the healthy direction.
orders.controller uses common.domain, so a change to common.domain can break orders.controller, while a change to orders.controller can't break common.domain.
Position
Below the diagonal: orders.controller uses a module listed above it, which is the healthy direction.
orders.controller uses domain.domain.session, so a change to domain.domain.session can break orders.controller, while a change to orders.controller can't break domain.domain.session.
Position
Below the diagonal: orders.controller uses a module listed above it, which is the healthy direction.
orders.controller uses orders.entity, so a change to orders.entity can break orders.controller, while a change to orders.controller can't break orders.entity.
Position
Below the diagonal: orders.controller uses a module listed above it, which is the healthy direction.
service.impl uses device.domain.dto, so a change to device.domain.dto can break service.impl, while a change to service.impl can't break device.domain.dto.
Position
Below the diagonal: service.impl uses a module listed above it, which is the healthy direction.
service.impl uses system.domain.dto, so a change to system.domain.dto can break service.impl, while a change to service.impl can't break system.domain.dto.
Position
Below the diagonal: service.impl uses a module listed above it, which is the healthy direction.
service.impl uses domain2.domain.vo, so a change to domain2.domain.vo can break service.impl, while a change to service.impl can't break domain2.domain.vo.
Position
Below the diagonal: service.impl uses a module listed above it, which is the healthy direction.
service.impl uses device.domain.vo, so a change to device.domain.vo can break service.impl, while a change to service.impl can't break device.domain.vo.
Position
Below the diagonal: service.impl uses a module listed above it, which is the healthy direction.
system.controller uses common.domain, so a change to common.domain can break system.controller, while a change to system.controller can't break common.domain.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
system.controller uses domain.domain.session, so a change to domain.domain.session can break system.controller, while a change to system.controller can't break domain.domain.session.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
system.controller uses flow.service, so a change to flow.service can break system.controller, while a change to system.controller can't break flow.service.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
system.controller uses res.service, so a change to res.service can break system.controller, while a change to system.controller can't break res.service.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
system.controller uses system.domain.dto, so a change to system.domain.dto can break system.controller, while a change to system.controller can't break system.domain.dto.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
system.controller uses system.service, so a change to system.service can break system.controller, while a change to system.controller can't break system.service.
Position
Below the diagonal: system.controller uses a module listed above it, which is the healthy direction.
device.controller uses common.domain, so a change to common.domain can break device.controller, while a change to device.controller can't break common.domain.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses device.domain.dto, so a change to device.domain.dto can break device.controller, while a change to device.controller can't break device.domain.dto.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses device.entity, so a change to device.entity can break device.controller, while a change to device.controller can't break device.entity.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses domain.domain.session, so a change to domain.domain.session can break device.controller, while a change to device.controller can't break domain.domain.session.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses flow.service, so a change to flow.service can break device.controller, while a change to device.controller can't break flow.service.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses res.service, so a change to res.service can break device.controller, while a change to device.controller can't break res.service.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses device.domain, so a change to device.domain can break device.controller, while a change to device.controller can't break device.domain.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses device.domain.vo, so a change to device.domain.vo can break device.controller, while a change to device.controller can't break device.domain.vo.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses domain2.mapper, so a change to domain2.mapper can break device.controller, while a change to device.controller can't break domain2.mapper.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses domain2.service, so a change to domain2.service can break device.controller, while a change to device.controller can't break domain2.service.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses device.service, so a change to device.service can break device.controller, while a change to device.controller can't break device.service.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
device.controller uses domain2.controller, so a change to domain2.controller can break device.controller, while a change to device.controller can't break domain2.controller.
Position
Below the diagonal: device.controller uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 61.9 · Adequate · gated by X5 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2025 — Software Supply Chain Failures
58
High / Critical
A02:2025 — Security Misconfiguration
22
High / Critical
A07:2025 — Authentication Failures
17
High / Critical
A05:2025 — Injection
17
High / Critical
Roadmap
Top priorities: Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href; Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh; Resolve the 3 REDACTED finding(s) in REDACTED Scanning — start with REDACTED (3).
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 3 REDACTED finding(s) in REDACTED Scanning — start with REDACTED (3).
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Code Duplication: Edited copy of a member (20 corresponding lines)
How the grades work
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 69
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 252
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 93
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 16
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 68 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 68 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 398 of 414 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java) and this repository declares a JVM test suite (repository root, Maven), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — a Maven build resolved 128 artifact(s) (115 behind a shipped release, reported), but the build resolved only part of the graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `joggle-server/src/main/java/com/wuweibi/bullet/alias/StateCode.java` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 18 — an image could not be pulled) — mysql Pulling nginx Pulling redis Pulling joggle-prod Pulling nginx Error manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown mysql Error context canceled joggle-prod Error context canceled redis Error context canceled Error response from daemon: manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown; the earlier `compose pull` step reported: nginx Pulling redis Pulling mysql Pulling joggle-prod Pulling nginx Error manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown redis Error context canceled joggle-prod Error context canceled mysql Error context canceled Error response from daemon: manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped.
C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
DM8 Value-object opportunities — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds primitive parameters that travel together through several signatures of the domain (a missing value object). Its deterministic rule has not yet shown 95 % precision on adjudicated rows, so the clumps it finds are counted here and not published as findings, and the card carries no score. That is a limit of the analyzer, not a finding about your code.
DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Arm one resolves each comparison operand to the domain member it judges, and that binding exists only in a Roslyn compilation, which this run did not load. Arm two ran over the neutral model because this repository's frontend declares whether each construction is produced or passed. A rule decided in two places would not appear above.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
X1 Async correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin and Rust source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin or Rust was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
X17 Uncapped recursion over a caller-supplied document — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin and Rust source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin or Rust was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
DM4 Rich vs anemic model: Behaviour is detected as state mutation inside a method body — a method that enforces an invariant by validating-and-throwing without mutating reads as a query, and mutation delegated through an interface the scan can't resolve isn't credited; entities with zero public properties still drop out of the population. It detects that state changes, not whether the rule is correct.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
Bring the 5 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with OrderPayBizImpl.calculate (cyclomatic 31), DeviceMappingManagerServiceImpl.saveOrUpdateMapping (cyclomatic 22), IpAddrUtils.textToNumericFormatV4 (cyclomatic 21). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 5 together lifts Cyclomatic Complexity from 8.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 3 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 30 down to 30 or less in Cognitive Complexity — start with OrderPayBizImpl.calculate (cognitive 54). — Refactoring it lifts Cognitive Complexity from 8.0 to about 8.6/10.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.8 / 10Stronggated by 2 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 1 TooManyMethods finding(s) in God Classes — start with StringUtil.java. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 MethodTooLong finding(s) in God Classes — start with OrderPayBizImpl.java. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
95 duplicated block group(s) detected. 7.2 % of the production lines (2,833 of 39,353) are in a reported copy. A further 47 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
Edited copy of a member (10 corresponding lines) · ×7joggle-server/src/main/java/com/wuweibi/bullet/service/impl/SysMenuServiceImpl.java:141
+ 59 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 16 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with REDACTED (4), DevicePeersServiceImpl.java (2), REDACTED (2). — One of this dimension's main actionable groups (16 warning-level).
Resolve the 10 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with UserAdminController.java (2), REDACTED (2), DLockAspectHandler.java. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 8 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with REDACTED (2), DeviceDomainMappingController.java, ServerTunnelController.java. — One of this dimension's main actionable groups (8 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
4 production modules (Maven), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 3 module(s) off the main sequence.
Off the main sequence: joggle-common-alipay · ×3
✓ On the Gold path — maintain.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 6 Low cohesion finding(s) in Cohesion (LCOM4) — start with REDACTED, DeviceOnlineServiceImpl.java, UserServiceImpl.java. — One of this dimension's main actionable groups (6 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
1 secret(s) detected. 8 detection(s) were excluded as holding no minted credential in material that runs: a name, reference or comparison rather than a value, a readable phrase or pattern, a value that declares itself fake, or development, test, example, mock or demo material. 3 password hash(es) are listed to check and are not counted as leaked credentials.
REDACTED
REDACTED
What to do
Resolve the 3 REDACTED finding(s) in REDACTED Scanning — start with REDACTED (3). — One of this dimension's main actionable groups (3 recommendation-level).
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 21 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 5 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 40 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 3 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
19 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java. Counted over 142 of the 632 production source files in this repository: 480 are under the ~2,400-byte size floor this dimension measures over, and the remaining 10 have no attributable history left to measure.
Off-boarding risk: anonymized user #1
What to do
Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
15 deducted task-comment markers across 39353 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 15 TodoComment finding(s) in Explicit Debt — start with CountServiceImpl.java (2), DeviceMappingServiceImpl.java, DomainServiceImpl.java. — One of this dimension's main actionable groups (15 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 7 document(s) read across 1 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
3 naming inconsistencies among 159 declarations measured against a convention their peers follow.
`openAPI` spells `API` where 12 names in the project spell it `Api`joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/SwaggerConfig.java:51
`DeviceMappingDto` spells `Dto` where 86 names in the project spell it `DTO`joggle-server/src/main/java/com/wuweibi/bullet/domain/dto/DeviceMappingDto.java:11
`toVo` spells `Vo` where 64 names in the project spell it `VO`joggle-server/src/main/java/com/wuweibi/bullet/system/api_key/controller/ApiKeyController.java:74
What to do
Resolve the 1 `openAPI` spells `API` where 12 names in the project spell it `Api` finding(s) in Naming Consistency — start with SwaggerConfig.java. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `DeviceMappingDto` spells `Dto` where 86 names in the project spell it… finding(s) in Naming Consistency — start with DeviceMappingDto.java. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `toVo` spells `Vo` where 64 names in the project spell it `VO` finding(s) in Naming Consistency — start with ApiKeyController.java. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
1 of 4 build units (Maven) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesionjoggle-server/REDACTED:1
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
30 % of calls cross a namespace and 7 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
12 finding(s): 0 critical, 10 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 6 REDACTED finding(s) in Secrets (history) — start with REDACTED (3), REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
Resolve the 4 High secret finding(s) in Secrets (history) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED (2). — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
17 finding(s): 0 critical, 4 high, 6 medium, 7 low. semgrep hit a parse error in 5 file(s) — `REDACTED` (line 13, line 14, line 15), `REDACTED` (lines 4–5), `joggle-server/src/main/java/com/wuweibi/bullet/alias/StateCode.java` (lines 15–16), `joggle-server/src/main/resources/templates/common/_page.html` (lines 1–58), `joggle-server/src/main/resources/templates/common/child.html` (lines 1–4, line 7, line 11, …) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
Resolve the 29 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (29). — One of this dimension's main actionable groups (29 issue-level).
Resolve the 17 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (17). — One of this dimension's main actionable groups (17 warning-level).
Resolve the 4 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 8 High IaC finding(s) in IaC & Container Security — start with REDACTED (7), REDACTED. — One of this dimension's main actionable groups (8 issue-level).
Resolve the 2 Critical IaC finding(s) in IaC & Container Security — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 6 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (3), REDACTED (3). — One of this dimension's main actionable groups (6 warning-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
34 of 152 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java. Counted over 152 of the 632 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 33 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED (2), Tools.java, MailServiceImpl.java. — One of this dimension's main actionable groups (33 recommendation-level).
Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with StringUtil.java. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 11 Change coupling finding(s) in Change Coupling — start with UserMapper.java (2), CountMapper.java, DomainMapper.java. — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 3 platform declaration(s) and 32 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC2 · Forms & labels6.7 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label. — joggle-server/src/main/resources/mail/template/register_mail.ftl:19
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Do you agree with this assessment?
AC3 · Page structure2.9 / 10Weak✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×9) — joggle-server/src/main/resources/mail/template/certification_result.ftl:2, joggle-server/src/main/resources/mail/template/device_down_notice.htm:2, joggle-server/src/main/resources/mail/template/domain_release.htm:2, …
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×9) — joggle-server/src/main/resources/mail/template/certification_result.ftl:2, joggle-server/src/main/resources/mail/template/device_down_notice.htm:2, joggle-server/src/main/resources/mail/template/domain_release.htm:2, …
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. (×2) — joggle-server/src/main/resources/templates/common/child.html:13, joggle-server/src/main/resources/templates/common/child.html:14
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them. (×8) — joggle-server/src/main/resources/mail/template/certification_result.ftl:23, joggle-server/src/main/resources/mail/template/device_down_notice.htm:18, joggle-server/src/main/resources/mail/template/domain_release.htm:18, …
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`ResourceManagerImpl` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (resourceConfigAttributes; e.g. `resourceConfigAttributes` in `loadResource` at line 68). — joggle-server/src/main/java/com/wuweibi/bullet/oauth2/manager/impl/ResourceManagerImpl.java:33
`Bullet3Annotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, tunnelId; e.g. `session` in `open` at line 84). — joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:52
`LogAnnotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, deviceId; e.g. `session` in `start` at line 53). — joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:40
`VideoAnnotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, nickname; e.g. `session` in `start` at line 52). — joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:39
What to do
Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`DeviceMappingMapper` declares 19 abstract methods: `exists`, `existsDomain`, `existsDomainId`, `getDeviceMappingIdByUserId`, `getMappingIdByUserId`, `insertPeerMapping`, `recoveryId`, `removeByDomainId`, `selectAllByUserId`, `selectByDeviceId`, `selectByHostAndPort`, `selectByUserAndDomainId`, `selectDeviceNo`, `selectDeviceNoById`, `selectListByDeviceNo`, `selectMapping4ProtocolByDeviceNo`, `selectMapping4ProtocolByMappingId`, `selectServiceListPage`, `updateStatusById`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — joggle-server/src/main/java/com/wuweibi/bullet/mapper/DeviceMappingMapper.java:27
`DeviceMappingService` declares 20 abstract methods: `checkUserDomain`, `countByDeviceId`, `deleteByDeviceId`, `exists`, `existsDomain`, `existsDomainId`, `existsDomainId`, `getAll`, `getAllByUserId`, `getByDeviceId`, `getByDomainId`, `getDeviceAll`, `getDeviceNo`, `getDeviceNoByMappingId`, `getMapping`, `getMapping4ProtocolByDeviceNo`, `getMapping4ProtocolByMappingId`, `hasOkMapping`, `putScanResult`, `updateDownByUserId`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 20 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — joggle-server/src/main/java/com/wuweibi/bullet/service/DeviceMappingService.java:21
`DeviceService` declares 19 abstract methods: `bindDevice`, `exists`, `existsDeviceId`, `existsNoBindDevice`, `existsUserDeviceId`, `getAdminList`, `getByDeviceNo`, `getCountByUserId`, `getDetail`, `getDetailByDeviceNo`, `getDeviceInfoById`, `getDiscoveryDevice`, `getOptionListByUserId`, `getRecentWebListByUserId`, `getWebListByUserId`, `removeUserId`, `removeUserIdByDeviceNo`, `updateName`, `wakeUp`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — joggle-server/src/main/java/com/wuweibi/bullet/service/DeviceService.java:25
`DomainService` declares 19 abstract methods: `checkDomain`, `checkServerTunnelUse`, `checkStatus`, `exists`, `exists`, `getAdminList`, `getAvailableDomainByUserId`, `getBuyList`, `getByMappingId`, `getDetail`, `getListByUserId`, `getListNotBindByUserId`, `release`, `releaseById`, `resourceDueTimeRelease`, `updateDueTime`, `updateDueTimeById`, `updateUserDueTime`, `updateUserId`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — joggle-server/src/main/java/com/wuweibi/bullet/service/DomainService.java:28
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.
Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.
Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.
Other · Domain Modelling — Whether an aggregate can be constructed in a state its own rules forbid — a public constructor that takes a raw primitive, stores it, and validates nothing, with no factory beside it. A constructor taking only value objects is not counted: each parameter has already validated itself.
Method: Neutral surface (DDD-gated): each non-abstract entity/aggregate checked for a PUBLIC constructor taking at least one RAW PRIMITIVE parameter whose body contains no guard token (throw / Guard. / Ensure. / ArgumentException / CheckRule / an XException.ThrowIf* helper). C#: a static factory beside a public constructor does not exempt it, and a public parameterless constructor followed by public raw-primitive setters that refuse nothing is charged when the type also declares a validating way in (a guarded constructor or a guarding static method returning the type); TypeScript: a static Create/Of/From/New factory exempts the type. A constructor taking only value objects is never charged -- measured: 64 of 87 unguarded public constructors on the C# corpus take value objects only, so ignoring parameter types would be 73% false positives. One finding per entity. Deterministic.
Do you agree with this assessment?
DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged
Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.
Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.
Do you agree with this assessment?
DM4 · Rich vs anemic model3.0 / 10Weak✓ Tool-verified
Other · Domain Modelling — Whether aggregates/entities carry the behaviour that protects their invariants, rather than being data bags driven by external services.
Method: Roslyn (DDD-gated): entity method BODIES classified mutator-vs-query — only methods that mutate the entity's own declared state count as invariant-protecting behaviour, so a getter/passthrough doesn't rescue an anemic class. Deterministic, exhaustive over domain-layer entities.
Coverage: Population: entities by name/base convention; rich-vs-anemic judged by classifying each method body mutator-vs-query — logic-bearing domain types outside the convention are invisible.
`BasePo` is an aggregate/entity with 5 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — joggle-server/src/main/java/com/wuweibi/bullet/common/domain/BasePo.java:19
What to do
Move business rules onto the aggregates/entities they govern so invariants are enforced at the source, not in anemic services.
Other · Domain Modelling — Whether entities protect their state — private/init-only setters, and collections handed out as read-only views rather than the mutable backing collection — instead of exposing writable state that bypasses invariants. Softened when a rehydration framework (Marten/EF) is present.
Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.
Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.
Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.
com.wuweibi.bullet.protocol.MsgHead's [command, length, sequence1, sequence2] are built independently in com.wuweibi.bullet.message.MessageHandlerContext, com.wuweibi.bullet.protocol.Message — the same reading, produced twice. Two producers can disagree without either looking wrong on its own: whichever population, filter or rounding one of them applies, the other need not, and nothing compares them. Give the measurement ONE producer and let the other call it.
What to do
Give each measurement ONE producer — the others call it. Centralising the judgement is not enough on its own: two producers of the same numbers can disagree while every rule reading them is correct.
Other · Code Health — Unreviewed-generation residue in this repository's Java: methods whose whole body only throws a "not implemented" or bare unsupported-operation exception, or returns a default value (or nothing) under a TODO/FIXME marker, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
`updateMapping` is a shipped method whose whole body returns a default value under a TODO/FIXME — a placeholder standing in for the implementation. Implement it or remove it. — joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DeviceBizImpl.java:69
`intercept` is a shipped method whose whole body returns a default value under a TODO/FIXME — a placeholder standing in for the implementation. Implement it or remove it. — joggle-server/src/main/java/com/wuweibi/bullet/controller/interceptor/MyAroundInterceptor.java:24
What to do
Finish or delete the methods that still throw "not implemented" or return a placeholder under a TODO, and replace placeholder text before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`incoming` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:94
`rateLimiter` has an empty body — confirm it's an intentional no-op and not an unfinished method. — joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/handler/RateLimterHandler.java:54
`@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead. — joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:667
What to do
Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
Clear the softer debt: re-enable or delete @Disabled/@Ignore tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace @SuppressWarnings("all") with targeted, justified suppressions.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
`REDACTED` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — REDACTED:33
What to do
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse. — joggle-server/Jenkinsfile:90
Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it. — joggle-server/Jenkinsfile:90
What to do
Add a `healthcheck:` to the served compose service — probing the endpoint it already answers on where it has one — with `depends_on: condition: service_healthy` on whatever waits for it, and keep the deployed image tag immutable and recorded so rolling back is re-pointing at the previous tag rather than rebuilding.
Add an approval/environment gate (required reviewers / protection rules) before production promotion.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×2) — joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:38, joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:92
What to do
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Other · Security — Only what this repository's own non-C# files could be read for was assessed — markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself, since a page handed to a consumer runs in that consumer’s origin. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`http://qzonestyle.gtimg.cn/qzone/openapi/qc_loader.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository. — REDACTED:11
What to do
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:540, joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:553, joggle-server/src/main/java/com/wuweibi/bullet/jwt/utils/JWTUtil.java:50
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — REDACTED:30
What to do
Swallowed exception (caught, then discarded)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
`error` at line 56 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — joggle-server/src/main/java/com/wuweibi/bullet/orders/payment/impl/PaymentServiceImpl.java:56
`error` at line 122 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — joggle-server/src/main/java/com/wuweibi/bullet/orders/controller/OrdersOpenController.java:122
`error` at line 90 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — joggle-server/src/main/java/com/wuweibi/bullet/domain/message/FormFieldMessage.java:90
`error` at line 165 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageResult.java:165
Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
0/175 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
What to do
Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 12 of 55 WCAG 2.2 Level A/AA success criteria (22%; ≈24% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 43 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 1 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 4 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 54 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No image/media element found in the parsed markup — AC1 not applicable here.
AC5 ARIA correctness — No ARIA usage found in the parsed markup — AC5 not applicable here.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — compose up failed (exit 18 — an image could not be pulled) — mysql Pulling nginx Pulling redis Pulling joggle-prod Pulling nginx Error manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown mysql Error context canceled joggle-prod Error context canceled redis Error context canceled Error response from daemon: manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown; the earlier `compose pull` step reported: nginx Pulling redis Pulling mysql Pulling joggle-prod Pulling nginx Error manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown redis Error context canceled joggle-prod Error context canceled mysql Error context canceled Error response from daemon: manifest for bitnami/nginx:1.12 not found: manifest unknown: manifest unknown; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .java suite was found but not re-run
D12 Dependency Hygiene — Not scored — a Maven build resolved 128 artifact(s) (115 behind a shipped release, reported), but the build resolved only part of the graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Aggregate roots were found in only one source directory (wuweibi), which is a layered codebase, not two contexts. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D32 Data Compliance (PII/GDPR) — 1 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM10 One transaction, one aggregate — no repository writes detected — no operation to judge against the one-aggregate rule
DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
DM8 Value-object opportunities — not scored — the deterministic rule found 0 candidate clump(s); its rows are withheld until it has a measured precision of 95 % (a sample of fewer than 10 rows cannot show one)
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a REDACTED, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X12 Unreachable branch — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X2 Cancellation propagation — no C# was loaded; this repository's Java was read, and no request in it can be cancelled by a caller — a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter
X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
<html> without a lang joggle-server/src/main/resources/mail/template/certification_result.ftl:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/device_down_notice.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/domain_release.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/feedback_reply.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/package_expiration_notice.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/package_release.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/package_rest_flow_notice.htm:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang joggle-server/src/main/resources/mail/template/register_mail.ftl:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang REDACTED:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
AC2 · Forms & labels· Link with no accessible name · ×1
Link with no accessible name joggle-server/src/main/resources/mail/template/register_mail.ftl:19— A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label.
Orphaned knowledge joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Serious — 252 finding(s)
D30 · Dependency Vulnerabilities· Medium CVE · ×17
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:153— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:153-158 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:171-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:214— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:214-219 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:227-232 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java:214` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:215— joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:215-220 | joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:250-255 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:215` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:104— joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:104-109 | joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:117-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:104` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:232— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:232-237 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:174-179 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:232` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:231` calls `setRemotePort`, `getRemotePort` and `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:173` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) REDACTED:177— REDACTED:177-182 | REDACTED:207-212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:64— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:64-71 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceLatency.java:42-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:49— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:49-54 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgPeer.java:49-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgMapping.java:58— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgMapping.java:58-63 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgUnMapping.java:55-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) REDACTED:178— REDACTED:178-183 | REDACTED:177-182 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) REDACTED:191— REDACTED:191-196 | REDACTED:190-195 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) REDACTED:220— REDACTED:220-225 | REDACTED:219-224 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) REDACTED:294— REDACTED:294-299 | REDACTED:293-298 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:49— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:49-55 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java:70-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:74— joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:74-79 | joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserController.java:60-65 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgMapping.java:34— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgMapping.java:34-39 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgUnMapping.java:31-36 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:124— // TODO 支持按设备筛选实时数据 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:219— // TODO 使用游标查询 改 流式查询 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:59— // TODO host处理 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:96— // 查询过期的域名 TODO 优化为游标形式 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:101— // 权益使用记录 TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgGetDeviceStatusRespHandler.java:32— // TODO this.tunnelId待确认 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgHeartHandler.java:38— // TODO 待确认 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/domain2/service/impl/UserDomainServiceImpl.java:170— // TODO 通知所有节点删除证书 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceProxyController.java:89— // TODO 校验设备是否自己的 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceWhiteIpsController.java:71— // TODO 校验ip的的地址正确性 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/controller/interceptor/MyAroundInterceptor.java:26— // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DeviceBizImpl.java:71— // TODO 更新映射信息 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:90— // TODO 修正架构 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:261— // TODO 加锁,事务控制 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment joggle-server/src/main/java/com/wuweibi/bullet/business/impl/UserDomainCertBizImpl.java:63— // todo 预校验域名是否指向joggled — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Change coupling: CountMapper.java ↔ CountService.java joggle-server/src/main/java/com/wuweibi/bullet/mapper/CountMapper.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/mapper/CountMapper.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/CountService.java` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `c8c1092f` [1.4.0] 统计优化,支持设备24小时流量统计; `fbbee82f` [1.3.10] 新增统计; `0afcebd3` [1.3.8] 新增全网小时级流量 — run `git show` on any of them.
Change coupling: DomainMapper.java ↔ DomainService.java joggle-server/src/main/java/com/wuweibi/bullet/domain2/mapper/DomainMapper.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/domain2/mapper/DomainMapper.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/DomainService.java` change together 75% of the time (15 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 15 shared commits counted here, the most recent 3 are `fbbee82f` [1.3.10] 新增统计; `8743f208` 最大并发通过域名本身控制而不是设备 (at that commit the file was still `joggle-server/src/main/java/com/wuweibi/bullet/mapper/DomainMapper.java`); `8b1134e8` V1.3.x 优化 (at that commit the file was still `joggle-server/src/main/java/com/wuweibi/bullet/mapper/DomainMapper.java`) — run `git show` on any of them.
Change coupling: UserMapper.java ↔ UserService.java joggle-server/src/main/java/com/wuweibi/bullet/mapper/UserMapper.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/mapper/UserMapper.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/UserService.java` change together 73% of the time (8 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `124cc1b9` [1.3.9] 映射支持软删除,套餐到期支持短信通知; `c7e6b68c` 新增系统通知开关接口; `6bb6420f` V1.3.x 套餐前台列表展示 — run `git show` on any of them.
Change coupling: DevicePeersController.java ↔ DevicePeersServiceImpl.java joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java` change together 67% of the time (10 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `6e9e8202` [1.4.0] 优化 p2p映射 归一到deviceMapping; `2c3812c1` [1.4.0] p2p支持传输策略配置,套餐支持中继模式开关; `c4e4908b` [1.4.0] 支持p2p relay — run `git show` on any of them.
Change coupling: OrderPayBizImpl.java ↔ OrdersAppController.java joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java` and `joggle-server/src/main/java/com/wuweibi/bullet/orders/controller/OrdersAppController.java` change together 65% of the time (13 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `83db4a43` [1.3.9] 新增微信支付; `4e97c04c` V1.3.x 支持VIP购买优化; `a0c09a74` V1.3.x 支持VIP购买 — run `git show` on any of them.
Change coupling: DeviceMappingMapper.java ↔ DeviceMappingService.java joggle-server/src/main/java/com/wuweibi/bullet/mapper/DeviceMappingMapper.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/mapper/DeviceMappingMapper.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/DeviceMappingService.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `0cf66566` [1.3.10] 支持设备服务清单扫描; `8b1134e8` V1.3.x 优化; `6235edf8` V1.3.x 宽带峰值控制 — run `git show` on any of them.
Change coupling: DeviceController.java ↔ DeviceServiceImpl.java joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java` change together 62% of the time (13 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `6fbc4045` [1.4.0] 优化绑定设备逻辑 & 其他; `fbbee82f` [1.3.10] 新增统计; `0cf66566` [1.3.10] 支持设备服务清单扫描 — run `git show` on any of them.
Change coupling: DomainController.java ↔ DomainServiceImpl.java joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainController.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java` change together 61% of the time (11 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `124cc1b9` [1.3.9] 映射支持软删除,套餐到期支持短信通知; `0a7bfa41` V1.3.1 多通道支持优化; `079e6462` 1、设备解绑逻辑优化 2、设备任意门优化,支持domain自动绑定 — run `git show` on any of them.
Change coupling: UserMapper.java ↔ UserController.java joggle-server/src/main/java/com/wuweibi/bullet/mapper/UserMapper.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/mapper/UserMapper.java` and `joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserController.java` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `c7e6b68c` 新增系统通知开关接口; `6bb6420f` V1.3.x 套餐前台列表展示; `3aa18dfa` V1.3.x admin用户管理列表接口 (at that commit the file was still `joggle-server/src/main/java/com/wuweibi/bullet/controller/UserController.java`) — run `git show` on any of them.
Change coupling: DeviceMappingController.java ↔ DeviceMappingMapper.java joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:1— `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/mapper/DeviceMappingMapper.java` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `6e9e8202` [1.4.0] 优化 p2p映射 归一到deviceMapping; `124cc1b9` [1.3.9] 映射支持软删除,套餐到期支持短信通知; `8b1134e8` V1.3.x 优化 — run `git show` on any of them.
Change coupling: REDACTED ↔ ClientVersionServiceImpl.java REDACTED:1— `REDACTED` and `joggle-server/src/main/java/com/wuweibi/bullet/system/client/service/impl/ClientVersionServiceImpl.java` change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `89cf87c4` [1.4.0] 优化检查更新; `dae7460c` [1.3.8] 新增通道检查更新接口; `08d1b5bf` V1.3.x 客户端版本管理 — run `git show` on any of them.
Duplicated block (10 lines × 2) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:105— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:105-114 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:188-197 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) REDACTED:55— REDACTED:55-64 | REDACTED:55-64 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:149— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:149-158 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:196-205 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:161— joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:161-170 | joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserController.java:159-168 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:179— joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:179-188 | joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserController.java:190-199 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:58— joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:58-67 | joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:100-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) REDACTED:119— REDACTED:119-128 | REDACTED:180-189 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:119` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) REDACTED:150— REDACTED:150-159 | REDACTED:210-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:150` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:94— joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:94-103 | joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:109-118 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java:76— joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java:76-85 | joggle-server/src/main/java/com/wuweibi/bullet/utils/SpringUtils.java:76-85 — before extracting anything, compare `joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java` and `joggle-server/src/main/java/com/wuweibi/bullet/utils/SpringUtils.java` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
AC3 · Page structure· Page without a main landmark · ×9
Page without a main landmark joggle-server/src/main/resources/mail/template/certification_result.ftl:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/device_down_notice.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/domain_release.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/feedback_reply.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/package_expiration_notice.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/package_release.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/package_rest_flow_notice.htm:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark joggle-server/src/main/resources/mail/template/register_mail.ftl:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark REDACTED:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/certification_result.ftl:23— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/device_down_notice.htm:18— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/domain_release.htm:18— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/feedback_reply.htm:19— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/package_expiration_notice.htm:18— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/package_release.htm:18— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/package_rest_flow_notice.htm:18— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Low contrast colour pair (2.6:1) joggle-server/src/main/resources/mail/template/register_mail.ftl:22— The inline foreground/background colours fall below the 4.5:1 WCAG AA minimum for normal text. Darken/lighten one of them.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceDomainMappingController.java:57— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceDomainMappingController.java:57-63 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePortMappingController.java:51-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:61— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:61-67 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:79-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:79` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:115— joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:115-121 | joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:136-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:165— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:165-171 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:181-187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:165` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:84— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:84-90 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:104-110 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:40— joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:40-46 | joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:52-58 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) REDACTED:161— REDACTED:161-167 | REDACTED:160-166 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) REDACTED:206— REDACTED:206-212 | REDACTED:205-211 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:71— joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:71-75 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:178-182 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/UserDomainCertBizImpl.java:158— joggle-server/src/main/java/com/wuweibi/bullet/business/impl/UserDomainCertBizImpl.java:158-162 | joggle-server/src/main/java/com/wuweibi/bullet/domain2/service/impl/UserDomainServiceImpl.java:159-164 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:88— joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:88-92 | joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:104-108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceScan.java:41— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceScan.java:41-46 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgUnBind.java:35-39 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:84— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:84-88 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java:90-94 — before extracting anything, compare `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:29— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:29-33 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceNo.java:29-33 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/domain2/service/impl/UserDomainServiceImpl.java:178— joggle-server/src/main/java/com/wuweibi/bullet/domain2/service/impl/UserDomainServiceImpl.java:178-183 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DomainServiceImpl.java:193-197 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:43— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:43-47 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:132-136 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×7
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/SysMenuServiceImpl.java:141— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/SysMenuServiceImpl.java:141-154 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/SysMenuServiceImpl.java:177-186 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:37— joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:37-46 | joggle-server/src/main/java/com/wuweibi/bullet/orders/service/impl/OrdersServiceImpl.java:49-58 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceDomainMappingController.java:56— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceDomainMappingController.java:56-65 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePortMappingController.java:50-59 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) REDACTED:50— REDACTED:50-59 | REDACTED:235-244 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/system/client/service/impl/ClientVersionServiceImpl.java:46— joggle-server/src/main/java/com/wuweibi/bullet/system/client/service/impl/ClientVersionServiceImpl.java:46-55 | joggle-server/src/main/java/com/wuweibi/bullet/system/client/service/impl/ClientVersionServiceImpl.java:107-116 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java:109— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java:109-118 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java:202-211 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelAdminController.java:95— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelAdminController.java:95-104 | joggle-server/src/main/java/com/wuweibi/bullet/res/controller/ResourcePackageAdminController.java:99-108 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:72— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:72-80 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:93-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:72` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `dto` to `DeviceMappingDomainDTO` in one and `DeviceMappingPortDTO` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageFactory.java:89— joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageFactory.java:89-97 | joggle-server/src/main/java/com/wuweibi/bullet/entity/api/R.java:193-201 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:179— joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:179-187 | joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:210-218 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `dto` to `DomainAddDTO` in one and `ReleaseResourceDTO` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/metrics/service/impl/DataMetricsServiceImpl.java:237— joggle-server/src/main/java/com/wuweibi/bullet/metrics/service/impl/DataMetricsServiceImpl.java:237-245 | joggle-server/src/main/java/com/wuweibi/bullet/metrics/service/impl/DataMetricsServiceImpl.java:248-256 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:105— joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:105-113 | joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainController.java:116-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:105` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:56— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:56-64 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceNo.java:56-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Low cohesion: OpenController (LCOM4 9) REDACTED:71— OpenController's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: DeviceOnlineServiceImpl (LCOM4 8) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceOnlineServiceImpl.java:40— DeviceOnlineServiceImpl's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: UserServiceImpl (LCOM4 5) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/UserServiceImpl.java:50— UserServiceImpl's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ScheduleConfig (LCOM4 4) joggle-server/src/main/java/com/wuweibi/bullet/config/ScheduleConfig.java:29— ScheduleConfig's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: DomainMappingTool (LCOM4 4) joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DomainMappingTool.java:24— DomainMappingTool's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: UserController (LCOM4 4) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserController.java:50— UserController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Stateful singleton: ResourceManagerImpl joggle-server/src/main/java/com/wuweibi/bullet/oauth2/manager/impl/ResourceManagerImpl.java:33— `ResourceManagerImpl` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (resourceConfigAttributes; e.g. `resourceConfigAttributes` in `loadResource` at line 68).
Stateful singleton: Bullet3Annotation joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:52— `Bullet3Annotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, tunnelId; e.g. `session` in `open` at line 84).
Stateful singleton: LogAnnotation joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:40— `LogAnnotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, deviceId; e.g. `session` in `start` at line 53).
Stateful singleton: VideoAnnotation joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:39— `VideoAnnotation` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (session, nickname; e.g. `session` in `start` at line 52).
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×4
Edited copy of a member (20 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:94— joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainAdminController.java:94-113 | joggle-server/src/main/java/com/wuweibi/bullet/domain2/controller/DomainController.java:100-124 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelOpenController.java:45— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelOpenController.java:45-64 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/ServerTunnelServiceImpl.java:78-99 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:56— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:56-75 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:86-105 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:44— joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:44-63 | joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:66-85 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (13 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:224— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:224-236 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:305-317 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:224` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `dto` to `DevicePeersDTO` in one and `DevicePeersStatusDTO` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/SysMenuController.java:197— joggle-server/src/main/java/com/wuweibi/bullet/system/controller/SysMenuController.java:197-209 | joggle-server/src/main/java/com/wuweibi/bullet/system/controller/SysMenuController.java:214-226 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:108— joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:108-120 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:109-121 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:108` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) REDACTED:87— REDACTED:87-99 | REDACTED:86-98 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:48— joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:48-58 | joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:70-80 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:136— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:136-146 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:202-212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:149` calls `checkLimit`, `fail` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:215` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:154— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:154-164 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:215-225 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:288— joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:288-298 | joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:310-320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:46— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:46-53 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceNo.java:46-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:57— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:57-64 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgPeer.java:57-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java:114— joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java:114-121 | joggle-server/src/main/java/com/wuweibi/bullet/utils/SpringUtils.java:114-121 — before extracting anything, compare `joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/util/RateSpringUtils.java` and `joggle-server/src/main/java/com/wuweibi/bullet/utils/SpringUtils.java` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) REDACTED:104— REDACTED:104-111 | joggle-server/src/main/java/com/wuweibi/bullet/system/client/controller/VersionAdminController.java:37-44 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×3
Edited copy of a member (14 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:502— joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:502-515 | joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:517-530 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/flow/service/impl/UserFlowServiceImpl.java:22— joggle-server/src/main/java/com/wuweibi/bullet/flow/service/impl/UserFlowServiceImpl.java:22-35 | joggle-server/src/main/java/com/wuweibi/bullet/flow/service/impl/UserFlowServiceImpl.java:47-60 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:41— joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:41-54 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/UserServiceImpl.java:135-148 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×3
Edited copy of a member (7 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:148— joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:148-157 | REDACTED:351-357 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/domain/Page.java:53— joggle-server/src/main/java/com/wuweibi/bullet/domain/Page.java:53-59 | joggle-server/src/main/java/com/wuweibi/bullet/domain/Page.java:69-76 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/res/controller/ResourcePackageAdminController.java:84— joggle-server/src/main/java/com/wuweibi/bullet/res/controller/ResourcePackageAdminController.java:84-90 | joggle-server/src/main/java/com/wuweibi/bullet/res/service/impl/UserPackageRightsServiceImpl.java:45-51 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (14 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelOpenController.java:49— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelOpenController.java:49-62 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/ServerTunnelServiceImpl.java:84-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelOpenController.java:49` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:130— joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:130-143 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:132-145 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:130` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:112— joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:112-125 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:136-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:112` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Swallowed exception (caught, then discarded) joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:540— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:553— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) joggle-server/src/main/java/com/wuweibi/bullet/jwt/utils/JWTUtil.java:50— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
AC4 · Keyboard semantics· Link used as a button (placeholder href) · ×2
Link used as a button (placeholder href) joggle-server/src/main/resources/templates/common/child.html:13— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) joggle-server/src/main/resources/templates/common/child.html:14— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×2
Edited copy of a member (19 corresponding lines) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/DLockAutoConfiguration.java:45— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/DLockAutoConfiguration.java:45-63 | joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/autoconfigure/RateLimiterAutoConfiguration.java:40-58 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (19 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:205— joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:205-224 | joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserOpenController.java:61-79 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×2
Edited copy of a member (21 corresponding lines) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:102— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:102-127 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/core/DLockAspectHandler.java:186-206 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/domain/message/FormFieldMessage.java:72— joggle-server/src/main/java/com/wuweibi/bullet/domain/message/FormFieldMessage.java:72-94 | joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageResult.java:149-169 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×2
Edited copy of a member (17 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:270— joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:270-287 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:310-326 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/oauth2/handler/JwtUserHandlerMethodArgumentResolver.java:49— joggle-server/src/main/java/com/wuweibi/bullet/oauth2/handler/JwtUserHandlerMethodArgumentResolver.java:49-68 | joggle-server/src/main/java/com/wuweibi/bullet/oauth2/utils/SecurityUtils.java:27-43 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×2
Edited copy of a member (11 corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/utils/EnumUtil.java:27— joggle-common/src/main/java/com/wuweibi/bullet/utils/EnumUtil.java:27-37 | joggle-common/src/main/java/com/wuweibi/bullet/utils/EnumUtil.java:68-78 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:103— joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:103-113 | joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:116-126 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×2
Edited copy of a member (8 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:60— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:60-67 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/ServerTunnelController.java:75-85 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:64— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:64-71 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuthResp.java:64-71 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (28 lines × 2) REDACTED:125— REDACTED:125-152 | REDACTED:124-151 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (28 lines × 2) REDACTED:311— REDACTED:311-338 | REDACTED:310-337 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23 lines × 2) REDACTED:391— REDACTED:391-413 | REDACTED:390-412 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23 lines × 2) REDACTED:151— REDACTED:151-173 | joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:73-95 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) REDACTED:242— REDACTED:242-258 | REDACTED:241-257 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgAuthRespHandler.java:71— joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgAuthRespHandler.java:71-87 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:164-180 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgAuthRespHandler.java:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:43— joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:43-54 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/UserServiceImpl.java:137-148 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:43` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/FairLock.java:39— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/FairLock.java:39-51 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/ReentrantLock.java:37-48 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6–7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:73— joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:73-78 | joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:89-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DomainBizImpl.java:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6–7 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:77— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:77-82 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:125-131 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingViewServiceImpl.java:125` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 3) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:55— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:55-61 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceLatency.java:34-39 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceScanResp.java:66-72 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:55` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) REDACTED:78— REDACTED:78-83 | REDACTED:116-121 | REDACTED:147-152 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Unfinished stub — returns a placeholder under a TODO marker joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DeviceBizImpl.java:69— `updateMapping` is a shipped method whose whole body returns a default value under a TODO/FIXME — a placeholder standing in for the implementation. Implement it or remove it.
Unfinished stub — returns a placeholder under a TODO marker joggle-server/src/main/java/com/wuweibi/bullet/controller/interceptor/MyAroundInterceptor.java:24— `intercept` is a shipped method whose whole body returns a default value under a TODO/FIXME — a placeholder standing in for the implementation. Implement it or remove it.
Outbound HTTP without resilience joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:38— `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:92— `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
OrderPayBizImpl.calculate (cyclomatic 31) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:86— OrderPayBizImpl.calculate has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeviceMappingManagerServiceImpl.saveOrUpdateMapping (cyclomatic 22) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:129— DeviceMappingManagerServiceImpl.saveOrUpdateMapping has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IpAddrUtils.textToNumericFormatV4 (cyclomatic 21) joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:61— IpAddrUtils.textToNumericFormatV4 has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UserPackageApiController.getUserPackInfo (cyclomatic 18) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserPackageApiController.java:51— UserPackageApiController.getUserPackInfo has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UserPackageManagerImpl.checkLimit (cyclomatic 17) joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:45— UserPackageManagerImpl.checkLimit has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
OrderPayBizImpl.calculate (cognitive 54) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:86— OrderPayBizImpl.calculate has cognitive complexity 54 (threshold 15). Drivers by points: if/else 19 (39 pts), ternaries 3 (10 pts), boolean chains 4, match/switch 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DeviceMappingManagerServiceImpl.saveOrUpdateMapping (cognitive 30) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:129— DeviceMappingManagerServiceImpl.saveOrUpdateMapping has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (23 pts), boolean chains 5, ternaries 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IpAddrUtils.textToNumericFormatV4 (cognitive 27) joggle-server/src/main/java/com/wuweibi/bullet/utils/IpAddrUtils.java:61— IpAddrUtils.textToNumericFormatV4 has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 6, loops 2 (4 pts), error handling 1, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserPackageApiController.getUserPackInfo (cognitive 21) joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserPackageApiController.java:51— UserPackageApiController.getUserPackInfo has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 5, ternaries 1 (2 pts) (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
UserPackageManagerImpl.checkLimit (cognitive 20) joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:45— UserPackageManagerImpl.checkLimit has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 8 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HttpUtils.buildUrl (cognitive 20) REDACTED:246— HttpUtils.buildUrl has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CommonExtClient.closeTradeNo (cognitive 17) joggle-common-alipay/src/main/java/com/alipay/easysdk/payment/common/CommonExtClient.java:17— CommonExtClient.closeTradeNo has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), error handling 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FormFieldMessage.getMsg (cognitive 17) joggle-server/src/main/java/com/wuweibi/bullet/domain/message/FormFieldMessage.java:72— FormFieldMessage.getMsg has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 1 (4 pts), error handling 1 (2 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
TooManyMethods: StringUtil joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:20— TooManyMethods — 68 methods. The bar is 30 methods; this is 38 over it, 2.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
MethodTooLong: OrderPayBizImpl.calculate joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:86— MethodTooLong — calculate runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) REDACTED:77— REDACTED:77-97 | REDACTED:115-128 | REDACTED:146-159 | REDACTED:176-189 | REDACTED:206-219 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (4 members, 50+ identical tokens) joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:105— joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:105-124 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:127-148 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:105-126 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:130-149 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (58 corresponding lines) · ×1
Edited copy of a member (58 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:213— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:213-274 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:278-335 — These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (39 corresponding lines) · ×1
Edited copy of a member (39 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgAuthRespHandler.java:54— joggle-server/src/main/java/com/wuweibi/bullet/message/handler/MsgAuthRespHandler.java:54-92 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:146-185 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 29+ corresponding lines) · ×1
Edited copies of one member (3 members, 29+ corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:178— joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:178-208 | joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:211-242 | joggle-server/src/main/java/com/wuweibi/bullet/res/manager/impl/UserPackageManagerImpl.java:245-273 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 29 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (38 corresponding lines) · ×1
Edited copy of a member (38 corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:110— joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:110-147 | joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:154-192 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (44 corresponding lines) · ×1
Edited copy of a member (44 corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:31— joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:31-74 | joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:85-133 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (30 corresponding lines) · ×1
Edited copy of a member (30 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:187— joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:187-216 | joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:218-247 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×1
Edited copy of a member (18 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:70— joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:70-88 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:91-108 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×1
Edited copy of a member (12 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageFactory.java:88— joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageFactory.java:88-99 | joggle-server/src/main/java/com/wuweibi/bullet/entity/api/R.java:192-203 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×1
Edited copy of a member (15 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:53— joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:53-72 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:76-90 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 6+ corresponding lines) · ×1
Edited copies of one member (4 members, 6+ corresponding lines) REDACTED:53— REDACTED:53-60 | REDACTED:62-69 | REDACTED:71-76 | REDACTED:171-176 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×1
Edited copy of a member (9 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:159— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:159-167 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceMappingServiceImpl.java:180-188 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (8 members, 9+ corresponding lines) · ×1
Edited copies of one member (8 members, 9+ corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:50— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:50-61 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuthResp.java:50-61 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:50-61 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDown.java:45-53 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceLatency.java:31-39 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceNo.java:45-53 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceScanResp.java:61-72 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgWOL.java:51-61 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×1
Edited copy of a member (13 corresponding lines) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/ReadLock.java:37— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/ReadLock.java:37-49 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/WriteLock.java:37-49 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 8+ corresponding lines) · ×1
Edited copies of one member (4 members, 8+ corresponding lines) joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/FairLock.java:29— joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/FairLock.java:29-36 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/ReadLock.java:27-34 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/ReentrantLock.java:27-34 | joggle-common-lock/src/main/java/com/wuweibi/bullet/common/lock/lock/WriteLock.java:27-34 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×1
Edited copy of a member (6 corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DomainMappingTool.java:111— joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DomainMappingTool.java:111-117 | joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/ServerTunnelTool.java:27-32 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 5+ corresponding lines) · ×1
Edited copies of one member (3 members, 5+ corresponding lines) joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DeviceTool.java:21— joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DeviceTool.java:21-25 | joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/DomainMappingTool.java:90-94 | joggle-server/src/main/java/com/wuweibi/bullet/mcp/tools/ServerTunnelTool.java:21-25 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (5 corresponding lines) · ×1
Edited copy of a member (5 corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:34— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceDoor.java:34-39 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgPeer.java:41-45 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 5+ corresponding lines) · ×1
Edited copies of one member (5 members, 5+ corresponding lines) joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:34— joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuth.java:34-38 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgAuthResp.java:34-38 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDataMetrics.java:34-38 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceLatency.java:16-20 | joggle-common/src/main/java/com/wuweibi/bullet/protocol/MsgDeviceScanResp.java:45-49 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
Duplicated block (38–42 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:254— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:254-295 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java:314-351 — before extracting anything, compare `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (32 lines × 2) REDACTED:349— REDACTED:349-380 | REDACTED:348-379 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23–25 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:225— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:225-249 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:289-311 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:225` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20–21 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:127— joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:127-147 | joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:173-192 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:127` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:198— joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:198-216 | joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:229-247 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:198` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:196` calls `write`, `IntToBytes4`, `length` and `joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:228` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18–19 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:251— joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:251-269 | joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:313-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java:251` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (18 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:77— joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:77-94 | joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:136-153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/system/service/impl/ThirdMessageServiceImpl.java:77` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (16–17 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/oauth2/handler/JwtUserHandlerMethodArgumentResolver.java:52— joggle-server/src/main/java/com/wuweibi/bullet/oauth2/handler/JwtUserHandlerMethodArgumentResolver.java:52-68 | joggle-server/src/main/java/com/wuweibi/bullet/oauth2/utils/SecurityUtils.java:28-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:53— joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:53-68 | joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:108-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:53` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) REDACTED:269— REDACTED:269-283 | REDACTED:268-282 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 204 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13–14 lines × 2) joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:111— joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:111-124 | joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:155-167 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–14 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:360— joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:360-371 | joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:402-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:402` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:371` calls `success`, `fail` and `joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:415` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12–13 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:57— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:57-68 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:87-99 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceMappingController.java:69` calls `getServerTunnelId` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:100` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11–12 lines × 3) joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:277— joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:277-287 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:296-306 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:315-326 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:277` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:275` calls `write`, `IntToBytes4`, `length` and `joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:314` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10–11 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:112— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:112-122 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java:131-140 — before extracting anything, compare `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9–10 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:142— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java:142-151 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java:164-172 — before extracting anything, compare `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceAdminController.java` and `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 3) joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:193— joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:193-201 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:272-280 | joggle-server/src/main/java/com/wuweibi/bullet/websocket/Bullet3Annotation.java:291-299 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `joggle-server/src/main/java/com/wuweibi/bullet/conn/WebsocketPool.java:193` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–9 lines × 2) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:222— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:222-230 | joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:166-173 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:231` calls `setRemotePort`, `getRemotePort` and `joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DeviceMappingManagerServiceImpl.java:174` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 3) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:147— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:147-154 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:194-201 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java:259-266 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceOnlineLogController.java:51— joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceOnlineLogController.java:51-55 | joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java:69-74 | joggle-server/src/main/java/com/wuweibi/bullet/metrics/controller/DataMetricsController.java:57-61 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `params` to `DeviceOnlineLogParam` in one and `DevicePeersParam` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Anemic entity: BasePo joggle-server/src/main/java/com/wuweibi/bullet/common/domain/BasePo.java:19— `BasePo` is an aggregate/entity with 5 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body — does nothing with its inputs joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:94— `incoming` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Third-party script without Subresource Integrity REDACTED:11— `http://qzonestyle.gtimg.cn/qzone/openapi/qc_loader.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository.
Swallowed exception (empty catch) REDACTED:30— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/service/impl/MailServiceImpl.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/entity/api/R.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/AuthenticationServiceImpl.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/system/controller/SysMenuController.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-common/src/main/java/com/wuweibi/bullet/utils/SnowflakeIdWorker.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/web/filter/RequestParamsFilter.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/service/impl/SysMenuServiceImpl.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/websocket/LogAnnotation.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/websocket/VideoAnnotation.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-common/src/main/java/com/wuweibi/bullet/utils/HTTPRequest.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/exception/DefaultGlobalExceptionHandlerAdvice.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/utils/ConfigUtils.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/utils/HttpUtils.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/domain/Page.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-common/src/main/java/com/wuweibi/bullet/protocol/Message.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/oauth2/security/UserDetail.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/config/cache/RedisTemplateConfig.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/oauth2/manager/impl/ResourceManagerImpl.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/web/RequestBodyWrapper.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/service/impl/WeixinAccountServiceImpl.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageResult.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Fat interface: DeviceMappingMapper (19 abstract methods) joggle-server/src/main/java/com/wuweibi/bullet/mapper/DeviceMappingMapper.java:27— `DeviceMappingMapper` declares 19 abstract methods: `exists`, `existsDomain`, `existsDomainId`, `getDeviceMappingIdByUserId`, `getMappingIdByUserId`, `insertPeerMapping`, `recoveryId`, `removeByDomainId`, `selectAllByUserId`, `selectByDeviceId`, `selectByHostAndPort`, `selectByUserAndDomainId`, `selectDeviceNo`, `selectDeviceNoById`, `selectListByDeviceNo`, `selectMapping4ProtocolByDeviceNo`, `selectMapping4ProtocolByMappingId`, `selectServiceListPage`, `updateStatusById`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: DeviceMappingService (20 abstract methods) joggle-server/src/main/java/com/wuweibi/bullet/service/DeviceMappingService.java:21— `DeviceMappingService` declares 20 abstract methods: `checkUserDomain`, `countByDeviceId`, `deleteByDeviceId`, `exists`, `existsDomain`, `existsDomainId`, `existsDomainId`, `getAll`, `getAllByUserId`, `getByDeviceId`, `getByDomainId`, `getDeviceAll`, `getDeviceNo`, `getDeviceNoByMappingId`, `getMapping`, `getMapping4ProtocolByDeviceNo`, `getMapping4ProtocolByMappingId`, `hasOkMapping`, `putScanResult`, `updateDownByUserId`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 20 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: DeviceService (19 abstract methods) joggle-server/src/main/java/com/wuweibi/bullet/service/DeviceService.java:25— `DeviceService` declares 19 abstract methods: `bindDevice`, `exists`, `existsDeviceId`, `existsNoBindDevice`, `existsUserDeviceId`, `getAdminList`, `getByDeviceNo`, `getCountByUserId`, `getDetail`, `getDetailByDeviceNo`, `getDeviceInfoById`, `getDiscoveryDevice`, `getOptionListByUserId`, `getRecentWebListByUserId`, `getWebListByUserId`, `removeUserId`, `removeUserIdByDeviceNo`, `updateName`, `wakeUp`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: DomainService (19 abstract methods) joggle-server/src/main/java/com/wuweibi/bullet/service/DomainService.java:28— `DomainService` declares 19 abstract methods: `checkDomain`, `checkServerTunnelUse`, `checkStatus`, `exists`, `exists`, `getAdminList`, `getAvailableDomainByUserId`, `getBuyList`, `getByMappingId`, `getDetail`, `getListByUserId`, `getListNotBindByUserId`, `release`, `releaseById`, `resourceDueTimeRelease`, `updateDueTime`, `updateDueTimeById`, `updateUserDueTime`, `updateUserId`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Duplicated predicate REDACTED:125— `!dirFile.exists() || !dirFile.isDirectory()` appears character-identically in 2 files — REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java:208— `email.indexOf("@") == -1 && !SpringUtils.emailFormat(email)` appears character-identically in 2 files — joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserAdminController.java, joggle-server/src/main/java/com/wuweibi/bullet/system/controller/UserOpenController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:162— `path.lastIndexOf(".") != -1 && path.lastIndexOf(".") != 0` appears character-identically in 2 files — REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java:45— `userPass != null && userPass.equals(pass)` appears character-identically in 2 files — joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/OauthUserServiceImpl.java, joggle-server/src/main/java/com/wuweibi/bullet/service/impl/UserServiceImpl.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Interpolated log message defeats structured logging joggle-server/src/main/java/com/wuweibi/bullet/orders/payment/impl/PaymentServiceImpl.java:56— `error` at line 56 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging joggle-server/src/main/java/com/wuweibi/bullet/orders/controller/OrdersOpenController.java:122— `error` at line 122 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging joggle-server/src/main/java/com/wuweibi/bullet/domain/message/FormFieldMessage.java:90— `error` at line 90 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging joggle-server/src/main/java/com/wuweibi/bullet/domain/message/MessageResult.java:165— `error` at line 165 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 19 significant file(s) lose their only recent owner: joggle-server/src/main/java/com/wuweibi/bullet/service/impl/CountServiceImpl.java, REDACTED, joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceServiceController.java, joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DevicePeersController.java, joggle-server/src/main/java/com/wuweibi/bullet/device/controller/DeviceController.java, joggle-server/src/main/java/com/wuweibi/bullet/device/service/impl/DevicePeersServiceImpl.java, joggle-server/src/main/java/com/wuweibi/bullet/business/impl/UserDomainCertBizImpl.java, joggle-server/src/main/java/com/wuweibi/bullet/service/impl/DeviceServiceImpl.java (+11 more). Pair on, review, or document these before any departure.
No ADRs found joggle-server/REDACTED:41— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `joggle-server/REDACTED` makes this repository a deployable product (line 41).
D21 · Naming Consistency· `openAPI` spells `API` where 12 names in the project spell it `Api` · ×1
`openAPI` spells `API` where 12 names in the project spell it `Api` joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/SwaggerConfig.java:51— 12 of 13 names in project joggle-server spell the token `Api` (12 of 13; unit: names in project joggle-server containing `Api`). Peers: SwaggerConfig.createRest2Api (joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/SwaggerConfig.java:26); SwaggerConfig.createRestApi (joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/SwaggerConfig.java:34); SwaggerConfig.createRest3Api (joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/SwaggerConfig.java:43); com.wuweibi.bullet.config.swagger.annotation.AdminApi (joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/annotation/AdminApi.java:15); com.wuweibi.bullet.config.swagger.annotation.WebApi (joggle-server/src/main/java/com/wuweibi/bullet/config/swagger/annotation/WebApi.java:15). Rename to `openApi`. [rule N6]
D21 · Naming Consistency· `DeviceMappingDto` spells `Dto` where 86 names in the project spell it `DTO` · ×1
`DeviceMappingDto` spells `Dto` where 86 names in the project spell it `DTO` joggle-server/src/main/java/com/wuweibi/bullet/domain/dto/DeviceMappingDto.java:11— 86 of 87 names in project joggle-server spell the token `DTO` (86 of 87; unit: names in project joggle-server containing `DTO`). Peers: DeviceBiz.updateMapping(deviceMappingDTO) (joggle-server/src/main/java/com/wuweibi/bullet/business/DeviceBiz.java:21); OrderPayBiz.calculate(ordersDTO) (joggle-server/src/main/java/com/wuweibi/bullet/business/OrderPayBiz.java:33); DeviceBizImpl.updateMapping(deviceMappingDTO) (joggle-server/src/main/java/com/wuweibi/bullet/business/impl/DeviceBizImpl.java:69); OrderPayBizImpl.calculate(ordersDTO) (joggle-server/src/main/java/com/wuweibi/bullet/business/impl/OrderPayBizImpl.java:86); com.wuweibi.bullet.common.domain.IdDTO (joggle-server/src/main/java/com/wuweibi/bullet/common/domain/IdDTO.java:14). Rename to `DeviceMappingDTO`. [rule N6]
D21 · Naming Consistency· `toVo` spells `Vo` where 64 names in the project spell it `VO` · ×1
`toVo` spells `Vo` where 64 names in the project spell it `VO` joggle-server/src/main/java/com/wuweibi/bullet/system/api_key/controller/ApiKeyController.java:74— 64 of 65 names in project joggle-server spell the token `VO` (64 of 65; unit: names in project joggle-server containing `VO`). Peers: com.wuweibi.bullet.dashboard.domain.DeviceCountInfoVO (joggle-server/src/main/java/com/wuweibi/bullet/dashboard/domain/DeviceCountInfoVO.java:9); com.wuweibi.bullet.dashboard.domain.DeviceDateItemHourVO (joggle-server/src/main/java/com/wuweibi/bullet/dashboard/domain/DeviceDateItemHourVO.java:12); DeviceDateItemHourVO.sorted(deviceDateItemVO) (joggle-server/src/main/java/com/wuweibi/bullet/dashboard/domain/DeviceDateItemHourVO.java:29); com.wuweibi.bullet.dashboard.domain.DeviceDateItemVO (joggle-server/src/main/java/com/wuweibi/bullet/dashboard/domain/DeviceDateItemVO.java:9); com.wuweibi.bullet.dashboard.domain.UserCountVO (joggle-server/src/main/java/com/wuweibi/bullet/dashboard/domain/UserCountVO.java:9). Rename to `toVO`. [rule N6]
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion joggle-server/REDACTED:1— `joggle-server` (34352 LoC, 551 module-visible types across 150 directories) overshoots its size bounds. 1 of 4 build unit(s) (Maven) overshoot their size bounds, lowering Project Cohesion to 5.0/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
D34 · Knowledge Freshness· Further orphaned files (smaller) · ×1
Further orphaned files (smaller) — 33 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: REDACTED, REDACTED, joggle-common/src/main/java/com/wuweibi/bullet/utils/Tools.java, joggle-server/src/main/java/com/wuweibi/bullet/service/impl/MailServiceImpl.java, joggle-server/src/main/java/com/wuweibi/bullet/oauth2/service/impl/AuthenticationServiceImpl.java, REDACTED, joggle-server/src/main/java/com/wuweibi/bullet/system/controller/SysMenuController.java, joggle-common/src/main/java/com/wuweibi/bullet/utils/SnowflakeIdWorker.java (and 25 more) (34 orphaned of 152 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 152 of the 632 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
DM9 · Scattered domain decisions· Measurement [command, length, sequence1, sequence2] produced in 2 places · ×1
Measurement [command, length, sequence1, sequence2] produced in 2 places — com.wuweibi.bullet.protocol.MsgHead's [command, length, sequence1, sequence2] are built independently in com.wuweibi.bullet.message.MessageHandlerContext, com.wuweibi.bullet.protocol.Message — the same reading, produced twice. Two producers can disagree without either looking wrong on its own: whichever population, filter or rounding one of them applies, the other need not, and nothing compares them. Give the measurement ONE producer and let the other call it.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body joggle-common/src/main/java/com/wuweibi/bullet/ratelimiter/handler/RateLimterHandler.java:54— `rateLimiter` has an empty body — confirm it's an intentional no-op and not an unfinished method.
Blanket warning suppression joggle-server/src/main/java/com/wuweibi/bullet/utils/StringUtil.java:667— `@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation REDACTED:33— `REDACTED` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
P4 · Deployment & Rollback· No rollback/health safety · ×1
No rollback/health safety joggle-server/Jenkinsfile:90— Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse.
No release approval gate joggle-server/Jenkinsfile:90— Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X5 · Nullable reference types· Java packages are not null-marked everywhere · ×1
Java packages are not null-marked everywhere — 0/175 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
Off the main sequence: joggle-common-alipay — joggle-common-alipay: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: joggle-common — joggle-common: abstractness 0.07, instability 0.00, distance 0.93 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: joggle-common-lock — joggle-common-lock: abstractness 0.20, instability 0.00, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 1 file(s) — `joggle-server/src/main/java/com/wuweibi/bullet/alias/StateCode.java` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1e614-91aa-76be-87ca-807792ff920d · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 69 · Warnings: 252 · Recommendations: 90 · Info: 3 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 16-11-2026 @ 20:37 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.