Public report of jishenghua/jshERP, published 16 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 16 November 2026, 18:04 UTC · Survey ID cd_df555268e2b941c584147d946f89777f
jishenghua/jshERP
Measured 16 November 2026, 18:03 UTC, at code version 38ad91e
First survey, so nothing to compare with yet
CAI scoreAt risk
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 29,217 lines of product code in 2 projects, tests not counted · Estimated rebuild effort: about 0.2 person-years · Weakest lens: Production Readiness, 23.9
Findings by how serious they are
84 critical452 serious164 minor
15 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
16 November 2026, 18:03 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
54of 54 dimensions measured by tools.
574of 700 findings point to an exact file and line, so you can open each one in the code. The other 126 concern the repository as a whole, such as missing documentation.
54dimensions across 6 lenses, read from 29,217 lines of product code in 2 projects.
jishenghua/jshERP is rated At risk because critical security findings are open, most of them in the packages it uses. Its score is held back because the project has no automated tests and we found no working pipeline that builds or tests changes to the code. It scores 34.2 out of 100, which the At risk rating leaves unchanged.
Production Readiness, at 23.9, is the weakest lens and counts most in the score. The best first step for the work it takes is fixing the password or key in the code, worth about 7.0 points. Adding automated tests would lift Production Readiness itself, worth about 10.2 points. Raising Production Readiness to 70 would lift the score to about 43.3.
Thirty-one known security holes in the packages the code depends on can be used by attackers. Three passwords or keys in the code's history and one in the code are open to anyone who can read the repository, and sixteen images have no description for people who can't see them. Replacing each exposed password or key, updating the vulnerable packages and describing the images would close these risks. Fixing the weaknesses the scanner points to would fix the security weakness in the code. The ten buttons or links with no name need a name, even when they only show an icon.
The product code is 29,217 lines, about €25,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Production Readiness rose from 23.9 to 70, the lowest score rated Strong, the score would rise from 34.2 to about 43.3.
Code composition: what the lines of code are
Product code 100%
Rebuild cost: about €25,000 · Estimate
Cost to rebuild
€8,300 to €41,000, for 138 to 437 hours of work, about 0.2 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 34. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 29,217 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED.
Raises the score by about 7.0 points · Low effort · Secret Scanning
2
Resolve the 1 Banned license finding(s) in License Compliance.
Resolve the 1 No automated tests finding(s) in Code Coverage.
Raises the score by about 10.2 points · High effort · Code Coverage
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €25,000 to build again, about 0.2 person-years of work. Its weakest lens is Production Readiness, at 23.9 (Critical). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in Secret Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 7.0 points for low effort, because it clears the 1 Secret Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 5.1 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 7% to 16% on every change. The history of the code shows how much it changes: about 359 lines over the last 90 days, which is about 1,456 lines a year. At that pace, the extra work comes to an estimated 0.3 to 1.6 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
26 modules, with 13 dependencies between them. Every module uses only modules listed above it, so there are no loops.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
com.jsh.erp.datasource.vo uses com.jsh.erp.datasource.entities, so a change to com.jsh.erp.datasource.entities can break com.jsh.erp.datasource.vo, while a change to com.jsh.erp.datasource.vo can't break com.jsh.erp.datasource.entities.
Position
Below the diagonal: com.jsh.erp.datasource.vo uses a module listed above it, which is the healthy direction.
com.jsh.erp.utils uses com.jsh.erp.datasource.entities, so a change to com.jsh.erp.datasource.entities can break com.jsh.erp.utils, while a change to com.jsh.erp.utils can't break com.jsh.erp.datasource.entities.
Position
Below the diagonal: com.jsh.erp.utils uses a module listed above it, which is the healthy direction.
104 pairs of types, where a type in com.jsh.erp.datasource.mappers uses a type in com.jsh.erp.datasource.entities. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.jsh.erp.datasource.mappers uses com.jsh.erp.datasource.entities, so a change to com.jsh.erp.datasource.entities can break com.jsh.erp.datasource.mappers, while a change to com.jsh.erp.datasource.mappers can't break com.jsh.erp.datasource.entities.
Position
Below the diagonal: com.jsh.erp.datasource.mappers uses a module listed above it, which is the healthy direction.
com.jsh.erp.datasource.mappers uses com.jsh.erp.datasource.vo, so a change to com.jsh.erp.datasource.vo can break com.jsh.erp.datasource.mappers, while a change to com.jsh.erp.datasource.mappers can't break com.jsh.erp.datasource.vo.
Position
Below the diagonal: com.jsh.erp.datasource.mappers uses a module listed above it, which is the healthy direction.
60 pairs of types, where a type in com.jsh.erp.service uses a type in com.jsh.erp.datasource.entities. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.jsh.erp.service uses com.jsh.erp.datasource.entities, so a change to com.jsh.erp.datasource.entities can break com.jsh.erp.service, while a change to com.jsh.erp.service can't break com.jsh.erp.datasource.entities.
Position
Below the diagonal: com.jsh.erp.service uses a module listed above it, which is the healthy direction.
com.jsh.erp.service uses com.jsh.erp.datasource.vo, so a change to com.jsh.erp.datasource.vo can break com.jsh.erp.service, while a change to com.jsh.erp.service can't break com.jsh.erp.datasource.vo.
Position
Below the diagonal: com.jsh.erp.service uses a module listed above it, which is the healthy direction.
com.jsh.erp.service uses com.jsh.erp.utils, so a change to com.jsh.erp.utils can break com.jsh.erp.service, while a change to com.jsh.erp.service can't break com.jsh.erp.utils.
Position
Below the diagonal: com.jsh.erp.service uses a module listed above it, which is the healthy direction.
95 pairs of types, where a type in com.jsh.erp.service uses a type in com.jsh.erp.datasource.mappers. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.jsh.erp.service uses com.jsh.erp.datasource.mappers, so a change to com.jsh.erp.datasource.mappers can break com.jsh.erp.service, while a change to com.jsh.erp.service can't break com.jsh.erp.datasource.mappers.
Position
Below the diagonal: com.jsh.erp.service uses a module listed above it, which is the healthy direction.
46 pairs of types, where a type in com.jsh.erp.controller uses a type in com.jsh.erp.base. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.jsh.erp.controller uses com.jsh.erp.base, so a change to com.jsh.erp.base can break com.jsh.erp.controller, while a change to com.jsh.erp.controller can't break com.jsh.erp.base.
Position
Below the diagonal: com.jsh.erp.controller uses a module listed above it, which is the healthy direction.
com.jsh.erp.controller uses com.jsh.erp.datasource.entities, so a change to com.jsh.erp.datasource.entities can break com.jsh.erp.controller, while a change to com.jsh.erp.controller can't break com.jsh.erp.datasource.entities.
Position
Below the diagonal: com.jsh.erp.controller uses a module listed above it, which is the healthy direction.
com.jsh.erp.controller uses com.jsh.erp.utils, so a change to com.jsh.erp.utils can break com.jsh.erp.controller, while a change to com.jsh.erp.controller can't break com.jsh.erp.utils.
Position
Below the diagonal: com.jsh.erp.controller uses a module listed above it, which is the healthy direction.
70 pairs of types, where a type in com.jsh.erp.controller uses a type in com.jsh.erp.service. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.jsh.erp.controller uses com.jsh.erp.service, so a change to com.jsh.erp.service can break com.jsh.erp.controller, while a change to com.jsh.erp.controller can't break com.jsh.erp.service.
Position
Below the diagonal: com.jsh.erp.controller uses a module listed above it, which is the healthy direction.
com.jsh.erp.filter uses com.jsh.erp.service, so a change to com.jsh.erp.service can break com.jsh.erp.filter, while a change to com.jsh.erp.filter can't break com.jsh.erp.service.
Position
Below the diagonal: com.jsh.erp.filter uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 50.0 · Adequate · gated by D2, D4, X5 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2025 — Software Supply Chain Failures
39
High / Critical
A05:2025 — Injection
8
High / Critical
A07:2025 — Authentication Failures
5
High / Critical
Roadmap
Top priorities: Resolve the 1 No automated tests finding(s) in Code Coverage; Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED; Add a CI workflow that builds and runs the test suite on every push/PR.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED.
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 84
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 452
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 164
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 15
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 54 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 54 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 574 of 700 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D12 Dependency Hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Currency was graded against Maven Central, but whether an artifact is DEPRECATED is not: Maven Central publishes no deprecation marker, exactly as rubygems.org does not. Whether one is UNMAINTAINED is not graded either — no registry publishes a maintenance status, and release age does not stand in for one. Two of this dimension's four signals are therefore unread on a Maven tree, and its score reflects currency alone.
D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares package.json, but the licence verdict published here was taken over its JVM dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (23 contributor(s) across 3830 commit(s) sampled, automation and bot accounts excluded). One of them holds 89% of the history; the other 22 hold 0.5% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's naming rules read C# through Roslyn and every other language through its sidecar model; these languages are left out (PHP's reading is its own change, a Roslyn-loaded VB or F# project has no population builder yet). Their declarations carry no naming verdict this run — this says nothing about whether their names are consistent.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
AC4 Keyboard semantics — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 250 further occurrence(s) are not listed individually; the score already reflects all 290.
AXB2 Runtime readiness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. (rule: no-root-manifest). The renderer reported: the dev server (`npm run serve`) exited before it served a page. Likely cause (our sandbox): `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. Last output: "npm error code ENOENT / npm error syscall open / npm error path <repo>/package.json / npm error errno -2 / npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '<repo>/package.json' / npm error enoent This is related to npm not being able to find a file. / npm error enoent / npm error A complete log of this run can be found in: <path>" No runtime evidence was gathered.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DevServer (serve). the dev server (`npm run serve`) exited before it served a page. Likely cause (our sandbox): `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. Last output: "npm error code ENOENT / npm error syscall open / npm error path <repo>/package.json / npm error errno -2 / npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '<repo>/package.json' / npm error enoent This is related to npm not being able to find a file. / npm error enoent / npm error A complete log of this run can be found in: <path>" No runtime evidence was gathered.
C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
X1 Async correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin and Rust source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin or Rust was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
X17 Uncapped recursion over a caller-supplied document — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin and Rust source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Kotlin or Rust was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Repo exclusion declarations: 3 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
+ 15 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 60 down to 60 or less in Cyclomatic Complexity — start with DepotItemService.saveDetials (cyclomatic 103). — Refactoring it lifts Cyclomatic Complexity from 6.4 to about 6.9/10.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 57 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 120 down to 120 or less in Cognitive Complexity — start with DepotItemService.saveDetials (cognitive 316). — Refactoring it lifts Cognitive Complexity from 3.4 to about 4.8/10.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes7.6 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 10 TooManyMethods finding(s) in God Classes — start with DepotHeadService.java, MaterialService.java, DepotItemService.java. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 9 ClassTooLong finding(s) in God Classes — start with DepotHeadService.java, MaterialService.java, DepotItemService.java. — One of this dimension's main actionable groups (9 warning-level).
Resolve the 8 FileTooLong finding(s) in God Classes — start with DepotHeadService.java, MaterialService.java, DepotItemService.java. — One of this dimension's main actionable groups (8 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
130 duplicated block group(s) detected. 22.9 % of the production lines (6,690 of 29,217) are in a reported copy. A further 114 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
Edited copy of a member (14 corresponding lines) · ×9jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:155
+ 99 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 13 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with InOutItemService.java (2), AccountItemService.java (2), DepotItemController.java. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 13 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with DepotHeadService.java (3), AccountService.java (2), SupplierService.java (2). — One of this dimension's main actionable groups (13 warning-level).
Resolve the 10 Edited copy of a member (11 corresponding lines) finding(s) in Code Duplication — start with AccountHeadService.java, REDACTED, OrgaUserRelService.java. — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
2 production modules (Maven+npm), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 0 module(s) off the main sequence, with abstractness counted on 1 of the 2 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with RoleService.java, UnitService.java. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D8 · Code Coverage0.0 / 10Critical✓ Tool-verified
What it measures: How much of the code is actually exercised by tests.
Method: Coverage from the analyzer's own run of the suite, computed per-file with structured exclusions for generated, trivial, and glue code. A coverage report found in the repository is never read. When the suite can't be built/run in-image, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
117 outdated artifact(s) of 124 resolved by the build, graded against Maven Central. The poms themselves state a version for only 19 of 21 declaration(s) — the rest are parent- or BOM-managed, which is why this is read from the resolved graph rather than from the manifests. Whether any of these is DEPRECATED is not graded — Maven Central publishes no deprecation marker, exactly as rubygems.org does not. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Known CVEs in this graph are D30's question, read from the manifest there.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
1 of 19 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 1 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 2 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. 3 of them resolve to no licence at all on Central, even through their parent POMs; that is missing data, not a violation, and none of them is charged. 1 name a copyleft licence without stating its version (e.g. "GNU Lesser General Public Licence"), which this policy bans only at specific versions; they are reported here and not charged, because guessing the version would either accuse an LGPL-2.1 artifact or clear an LGPL-3.0 one. ★ COVERAGE OF THIS VERDICT: it grades this repository's JVM dependencies and nothing else. The repository also declares package.json, and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.
Banned license: com.itextpdf:itextpdf
What to do
Resolve the 1 Banned license finding(s) in License Compliance. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d14_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 1 Hotspot finding(s) in Churn × Complexity Hotspots — start with DepotItemService.java. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
3 deducted task-comment markers across 29217 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 3 TodoComment finding(s) in Explicit Debt — start with OrderUtils.java (2), DepotHeadService.java. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
0 of 1 documentation facets pass in full; short on: F2 example. 2 document(s) read across 2 unit(s).
Documentation: no build, run or usage exampleREADME.md:1
What to do
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
1 of 2 build units (Maven, npm) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesionREDACTED:1
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
98 % of calls cross a namespace and 0 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
3 finding(s): 0 critical, 3 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 3 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (4 warning-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
Resolve the 19 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (19). — One of this dimension's main actionable groups (19 issue-level).
Resolve the 12 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (12). — One of this dimension's main actionable groups (12 issue-level).
Resolve the 7 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (7). — One of this dimension's main actionable groups (7 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 86 of the 132 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 2 end-of-life framework(s), read from 1 platform declaration(s) and 20 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
End-of-life framework: Spring Boot 1 · ×2REDACTED:1
What to do
Resolve the 2 End-of-life framework finding(s) in Platform End-of-Life — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives2.0 / 10Critical✓ Tool-verified
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content. — jshERP-web/src/components/jeecg/JGraphicCode.vue:3
An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. (×16) — jshERP-web/src/components/jeecg/JImageUpload.vue:16, jshERP-web/src/components/layouts/PageView.vue:4, jshERP-web/src/components/layouts/UserLayout.vue:83, …
What to do
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Do you agree with this assessment?
AC2 · Forms & labels6.5 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×3) — jshERP-web/public/static/translate.js:2060, jshERP-web/public/static/translate.js:551, jshERP-web/src/components/jeecg/JCodeEditor.vue:6
A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one. (×2) — jshERP-web/src/components/jeecg/JFormContainer.vue:3, jshERP-web/src/components/jeecg/JFormContainer.vue:7
This <div> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label. (×2) — jshERP-web/src/components/jeecg/JGraphicCode.vue:2, jshERP-web/src/components/setting/SettingDrawer.vue:185
This <a> has no href, so it exposes no link role — but it carries a click handler, which makes it a control. It has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label. (×2) — jshERP-web/src/components/jeecg/JUpload.vue:7, jshERP-web/src/components/jeecg/JUpload.vue:8
This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. — jshERP-web/src/components/jeecg/minipop/JInputPop.vue:14
This <span> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label. — jshERP-web/src/components/tools/UserMenu.vue:11
A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label. — jshERP-web/src/components/tools/UserMenu.vue:38
This <img> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label. (×4) — jshERP-web/src/views/user/Login.vue:40, jshERP-web/src/views/user/Login.vue:41, jshERP-web/src/views/user/Register.vue:51, …
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
An empty <title> gives no page name in the tab, history or screen-reader page list. Put descriptive text in the <title>. — jshERP-web/public/index.html:2
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. — jshERP-web/public/index.html:2
An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label. (×2) — jshERP-web/src/components/layouts/IframeFReportView.vue:3, jshERP-web/src/components/layouts/IframePageView.vue:2
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler. (×10) — jshERP-web/src/components/jeecg/JGraphicCode.vue:2, jshERP-web/src/components/layouts/UserLayout.vue:104, jshERP-web/src/components/layouts/UserLayout.vue:109, …
An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action. (×29) — jshERP-web/src/components/jeecg/JSuperQuery.vue:53, jshERP-web/src/components/jeecg/JUpload.vue:7, jshERP-web/src/components/jeecg/JUpload.vue:8, …
An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. — jshERP-web/src/components/tools/UserMenu.vue:61
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This role is not a valid WAI-ARIA role, so assistive tech ignores it. Use a valid role (or the native element). — jshERP-web/src/components/menu/Contextmenu.vue:4
These two <img> controls (line 40 and line 41) are the two halves of one toggle: each is rendered on a different value of "requestCodeSuccess" and each one's own click handler writes "requestCodeSuccess". Nothing exposes the state programmatically — no aria-pressed on a toggle button, no aria-expanded/aria-controls if it is a disclosure — and neither branch has an accessible name, so assistive tech is told nothing at all when the state changes; a screen-reader user sees only that one nameless control was replaced by another (WCAG 4.1.2). Render ONE control that stays in the DOM and carries aria-pressed="true|false" bound to "requestCodeSuccess", or keep the two branches and give them DISTINCT accessible names (the WAI-ARIA APG name-change pattern), which announces the state through the name instead. — jshERP-web/src/views/user/Login.vue:40
These two <img> controls (line 51 and line 52) are the two halves of one toggle: each is rendered on a different value of "requestCodeSuccess" and each one's own click handler writes "requestCodeSuccess". Nothing exposes the state programmatically — no aria-pressed on a toggle button, no aria-expanded/aria-controls if it is a disclosure — and neither branch has an accessible name, so assistive tech is told nothing at all when the state changes; a screen-reader user sees only that one nameless control was replaced by another (WCAG 4.1.2). Render ONE control that stays in the DOM and carries aria-pressed="true|false" bound to "requestCodeSuccess", or keep the two branches and give them DISTINCT accessible names (the WAI-ARIA APG name-change pattern), which announces the state through the name instead. — jshERP-web/src/views/user/Register.vue:51
What to do
Use valid, non-abstract roles, supply the ARIA state each role requires, and never put aria-hidden on a focusable element.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`#loader` moves (`animation: spin 2s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/public/index.html:53
`#loader:before` moves (`animation: spin 3s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/public/index.html:76
`#loader:after` moves (`animation: spin 1.5s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/public/index.html:98
`.chromeframe` sets color: #999 on background-color: #ccc — 1.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — jshERP-web/public/index.html:19
`.input-table .tbody .td .td-span` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/components/jeecg/JEditableTable.vue:3114
`.card-container .ant-tabs .ant-tabs-bar` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/components/jeecg/modal/JCronModal.vue:844
`.language` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/components/jeecg/modal/JCronModal.vue:899
`.area-select` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/assets/less/JAreaLinkage.less:30
`.area-selectable-list-wrap` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/assets/less/JAreaLinkage.less:123
`.cascader-menu-list-wrap` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — jshERP-web/src/assets/less/JAreaLinkage.less:171
`.layout .topmenu .ant-header-fixedHeader` moves (`transition: width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/src/components/page/GlobalLayout.vue:261
`.layout .sidemenu .ant-header-fixedHeader` moves (`transition: width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/src/components/page/GlobalLayout.vue:292
`.layout .top-nav-header-index` moves (`transition: background .3s, width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/src/components/page/GlobalLayout.vue:431
`.area-selectable-list-wrap` moves (`transition: opacity 0.15s, transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/src/assets/less/JAreaLinkage.less:126
`.cascader-menu-list-wrap` moves (`transition: opacity 0.15s, transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — jshERP-web/src/assets/less/JAreaLinkage.less:174
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`DepotHeadMapperEx` declares 31 abstract methods: `batchDeleteDepotHeadByIds`, `debtList`, `debtListCount`, `findAllocationDetail`, `findAllocationDetailCount`, `findAllocationStatistic`, `findInOutDetail`, `findInOutDetailCount`, `findInOutDetailStatistic`, `findInOutMaterialCount`, `findInOutMaterialCountStatistic`, `findInOutMaterialCountTotal`, `findMaterialsListMapByHeaderIdList`, `getAllDepositByLinkNumber`, `getBillAllPriceByOrganId`, `getBuyAndSaleStatisticsList`, `getDepotHeadListByAccountIds`, `getDepotHeadListByCreator`, `getDepotHeadListByOrganIds`, `getDetailByNumber`, `getFinishDepositByNumberExceptCurrent`, `getFinishDepositByNumberList`, `getMaterialCountListByHeaderIdList`, `getSerialNumberBySell`, `getStatementAccount`, `getStatementAccountCount`, `getStatementAccountTotalPay`, `selectByConditionDepotHead`, `setAccountIdToNull`, `waitBillCount`, `waitBillList`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/DepotHeadMapperEx.java:17
`DepotItemMapperEx` declares 37 abstract methods: `batchDeleteDepotItemByDepotHeadIds`, `batchDeleteDepotItemByIds`, `batchInsert`, `buyOrSaleNumber`, `buyOrSalePrice`, `buyOrSalePriceTotal`, `countsByDepotItem`, `findDepotItemListBydepotheadId`, `findDetailByDepotIdsAndMaterialIdCount`, `findDetailByDepotIdsAndMaterialIdList`, `findStockWarningCount`, `findStockWarningCountTotal`, `getBatchBillDetailMaterialSum`, `getBatchNumberList`, `getBillDetailListByIds`, `getBillItemByParam`, `getCountByMaterialAndBatchNumber`, `getCountByMaterialAndDepot`, `getCurrentStockByParam`, `getDepotItemByBatchNumber`, `getDepotItemListListByDepotIds`, `getDepotItemListListByMaterialIds`, `getDetailList`, `getFinishNumber`, `getInOutStock`, `getInOutStockCount`, `getLastUnitPriceByParam`, `getLinkBillDetailMaterialSum`, `getListWithBuyOrSale`, `getListWithBuyOrSaleCount`, `getRealFinishNumber`, `getSkuStockByParamWithDepotList`, `getSkuStockCheckSumByDepotList`, `getStockByParamWithDepotList`, `getStockCheckSumByDepotList`, `inOrOutPriceList`, `selectByConditionDepotItem`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/DepotItemMapperEx.java:17
`MaterialMapperEx` declares 30 abstract methods: `batchDeleteMaterialByIds`, `checkIsExist`, `exportExcel`, `findById`, `findByIdWithBarCode`, `findByMaterialName`, `findBySelectWithBarCode`, `findBySelectWithBarCodeCount`, `findUnitList`, `getBarCodeList`, `getInitialStockWithMaterial`, `getListWithStock`, `getListWithStockCount`, `getMaterialByBarCode`, `getMaterialByBarCodeAndWithOutMId`, `getMaterialByMeId`, `getMaterialByParam`, `getMaterialDepotStock`, `getMaterialEnableSerialNumberCount`, `getMaterialEnableSerialNumberList`, `getMaterialExtendBySerialNumber`, `getMaterialListByCategoryIds`, `getMaterialListByUnitIds`, `getMaterialNameList`, `getOtherMaterialList`, `getTotalStockAndPrice`, `insertSelectiveEx`, `selectByConditionMaterial`, `setExpiryNumToNull`, `setUnitIdToNull`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/MaterialMapperEx.java:19
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Other · Code Health — Unreviewed-generation residue in this repository's Java: methods whose whole body only throws a "not implemented" or bare unsupported-operation exception, or returns a default value (or nothing) under a TODO/FIXME marker, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`SequenceService` has 7 unfinished members out of 11 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:28
`getSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:40
`select` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. (×2) — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:44, jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:76
`countSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:48
`insertSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:53
`updateSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:58
`deleteSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:63
`batchDeleteSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:68
`insertSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:81
`updateSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:86
`deleteSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:91
`batchDeleteSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:96
What to do
Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Do you agree with this assessment?
P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
What to do
Add a CI workflow that builds and runs the test suite on every push/PR.
Do you agree with this assessment?
P2 · Observability7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Add a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) so orchestrators and load balancers can probe liveness/readiness.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
`jshERP-web/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — jshERP-web/package.json:9
What to do
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
Do you agree with this assessment?
X13 · Undrained process stream3.5 / 10Weak✓ Tool-verified
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and the parent reads the other stream to its end while nothing reads stderr; that read returns only at end of stream, which the child never reaches. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file). — jshERP-boot/src/main/java/com/jsh/erp/utils/ComputerInfo.java:50
What to do
Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×6) — jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:119, jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:170, jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:217, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — jshERP-boot/src/main/java/com/jsh/erp/utils/HttpClient.java:85
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
`info` at line 78 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jshERP-boot/src/main/java/com/jsh/erp/utils/HttpClient.java:78
`error` at line 48 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jshERP-boot/src/main/java/com/jsh/erp/utils/PinYinUtil.java:48
`error` at line 255 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:255
`error` at line 320 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:320
`error` at line 321 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:321
`error` at line 322 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:322
`error` at line 323 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:323
`error` at line 375 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:375
`error` at line 377 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:377
`error` at line 379 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:379
`info` at line 433 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:433
`info` at line 436 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:436
`error` at line 163 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:163
`error` at line 345 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:345
`error` at line 264 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:264
`info` at line 166 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:166
`error` at line 272 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:272
Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
0/10 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
What to do
Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X10 Duplicated predicate — 16 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 5 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 56 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — the dev server (`npm run serve`) exited before it served a page. Likely cause (our sandbox): `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. Last output: "npm error code ENOENT / npm error syscall open / npm error path <repo>/package.json / npm error errno -2 / npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '<repo>/package.json' / npm error enoent This is related to npm not being able to find a file. / npm error enoent / npm error A complete log of this run can be found in: <path>" No runtime evidence was gathered. This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D10 Test Quality — No tests were found in the analyzed repository to assess for quality.
D11 Test Reliability — No test suite was found to re-run, so reliability couldn't be assessed. Two searches produced that zero and both came back empty: the classifier that reads the loaded workspace recognised no suite it could run, and a walk of the source on disk — which covers the JS/TS `*.test.*` and `*.spec.*` conventions and probes for a Pester suite — found no test source in any other ecosystem either. Neither search reaches a suite that is missing from the loaded workspace and carries no name either walk recognises, so this is 'no suite found by those two searches', not a verdict that the repository has none.
D16 Bus Factor — single-maintainer repository — bus factor is not applicable
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D21 Naming Consistency — Naming consistency does not read html yet; not measured.
D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
DM1 Domain Modelling — not scored — this repository shows none of the 3 signals this lens looks for
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — no CI workflow found
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a REDACTED, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X12 Unreachable branch — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X2 Cancellation propagation — no C# was loaded; this repository's Java was read, and no request in it can be cancelled by a caller — a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter
X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X30 Support guard that admits what it rejects — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
AC1 · Text alternatives· <img> without a text alternative · ×16
<img> without a text alternative jshERP-web/src/components/jeecg/JImageUpload.vue:16— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/PageView.vue:4— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:83— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:105— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:110— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:115— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:130— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:136— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/layouts/UserLayout.vue:142— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/components/page/PageHeader.vue:16— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/dashboard/IndexChart.vue:132— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/exception/ExceptionPage.vue:4— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/user/Login.vue:40— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/user/Login.vue:41— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/user/Register.vue:51— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative jshERP-web/src/views/user/Register.vue:52— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
AC4 · Keyboard semantics· Click handler on a non-interactive <div> · ×7
Click handler on a non-interactive <div> jshERP-web/src/components/jeecg/JGraphicCode.vue:2— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/layouts/UserLayout.vue:104— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/layouts/UserLayout.vue:109— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/layouts/UserLayout.vue:114— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/setting/SettingDrawer.vue:21— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/setting/SettingDrawer.vue:33— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> jshERP-web/src/components/setting/SettingDrawer.vue:185— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC2 · Forms & labels· Custom control with no accessible name on <img> · ×4
Custom control with no accessible name on <img> jshERP-web/src/views/user/Login.vue:40— This <img> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
Custom control with no accessible name on <img> jshERP-web/src/views/user/Login.vue:41— This <img> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
Custom control with no accessible name on <img> jshERP-web/src/views/user/Register.vue:51— This <img> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
Custom control with no accessible name on <img> jshERP-web/src/views/user/Register.vue:52— This <img> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
AC2 · Forms & labels· <textarea> without a programmatic label · ×3
<textarea> without a programmatic label jshERP-web/public/static/translate.js:2060— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<textarea> without a programmatic label jshERP-web/src/components/jeecg/JCodeEditor.vue:6— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<textarea> without a programmatic label jshERP-web/src/components/jeecg/minipop/JInputPop.vue:14— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC4 · Keyboard semantics· Click handler on a non-interactive <span> · ×3
Click handler on a non-interactive <span> jshERP-web/src/components/page/SHeaderNotice.vue:12— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <span> jshERP-web/src/components/tools/HeaderNotice.vue:29— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <span> jshERP-web/src/components/tools/UserMenu.vue:11— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC2 · Forms & labels· Custom control with no accessible name on <div> · ×2
Custom control with no accessible name on <div> jshERP-web/src/components/jeecg/JGraphicCode.vue:2— This <div> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
Custom control with no accessible name on <div> jshERP-web/src/components/setting/SettingDrawer.vue:185— This <div> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
AC2 · Forms & labels· Clickable <a> with no accessible name · ×2
Clickable <a> with no accessible name jshERP-web/src/components/jeecg/JUpload.vue:7— This <a> has no href, so it exposes no link role — but it carries a click handler, which makes it a control. It has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
Clickable <a> with no accessible name jshERP-web/src/components/jeecg/JUpload.vue:8— This <a> has no href, so it exposes no link role — but it carries a click handler, which makes it a control. It has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
AC3 · Page structure· <iframe> without a title · ×2
<iframe> without a title jshERP-web/src/components/layouts/IframeFReportView.vue:3— An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label.
<iframe> without a title jshERP-web/src/components/layouts/IframePageView.vue:2— An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label.
AC5 · ARIA correctness· Toggle state conveyed only by which <img> renders · ×2
Toggle state conveyed only by which <img> renders jshERP-web/src/views/user/Login.vue:40— These two <img> controls (line 40 and line 41) are the two halves of one toggle: each is rendered on a different value of "requestCodeSuccess" and each one's own click handler writes "requestCodeSuccess". Nothing exposes the state programmatically — no aria-pressed on a toggle button, no aria-expanded/aria-controls if it is a disclosure — and neither branch has an accessible name, so assistive tech is told nothing at all when the state changes; a screen-reader user sees only that one nameless control was replaced by another (WCAG 4.1.2). Render ONE control that stays in the DOM and carries aria-pressed="true|false" bound to "requestCodeSuccess", or keep the two branches and give them DISTINCT accessible names (the WAI-ARIA APG name-change pattern), which announces the state through the name instead.
Toggle state conveyed only by which <img> renders jshERP-web/src/views/user/Register.vue:51— These two <img> controls (line 51 and line 52) are the two halves of one toggle: each is rendered on a different value of "requestCodeSuccess" and each one's own click handler writes "requestCodeSuccess". Nothing exposes the state programmatically — no aria-pressed on a toggle button, no aria-expanded/aria-controls if it is a disclosure — and neither branch has an accessible name, so assistive tech is told nothing at all when the state changes; a screen-reader user sees only that one nameless control was replaced by another (WCAG 4.1.2). Render ONE control that stays in the DOM and carries aria-pressed="true|false" bound to "requestCodeSuccess", or keep the two branches and give them DISTINCT accessible names (the WAI-ARIA APG name-change pattern), which announces the state through the name instead.
AC2 · Forms & labels· <select> without a programmatic label · ×1
<select> without a programmatic label jshERP-web/public/static/translate.js:551— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC2 · Forms & labels· Custom control with no accessible name on <span> · ×1
Custom control with no accessible name on <span> jshERP-web/src/components/tools/UserMenu.vue:11— This <span> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
AC2 · Forms & labels· Link with no accessible name · ×1
Link with no accessible name jshERP-web/src/components/tools/UserMenu.vue:38— A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label.
AC3 · Page structure· Document <title> is empty · ×1
Document <title> is empty jshERP-web/public/index.html:2— An empty <title> gives no page name in the tab, history or screen-reader page list. Put descriptive text in the <title>.
AC5 · ARIA correctness· Invalid ARIA role "menuitemicon" · ×1
Invalid ARIA role "menuitemicon" jshERP-web/src/components/menu/Contextmenu.vue:4— This role is not a valid WAI-ARIA role, so assistive tech ignores it. Use a valid role (or the native element).
Banned license: com.itextpdf:itextpdf — `com.itextpdf:itextpdf` 5.5.13.1 is published on Maven Central under `AGPL-3.0`, which this policy bans, and this repository declares it in a Maven or Gradle manifest. The licence was read from the artifact's POM `<licenses>` block — following `<parent>` where the POM inherits them — and normalised to SPDX before it was judged, because Maven publishes the name as free text (`GNU Affero General Public License v3` is AGPL-3.0). Where a POM lists several licences they are read as a CHOICE, per Maven's own documentation, so this is charged only because EVERY listed licence is banned. Replace the dependency, or record an accepted exception.
No automated tests — No automated tests — no test code was found in this repository. Untested code is the largest single risk to changing it safely. Start with the code you change most often: add a suite in a framework a runner can collect (JUnit (with Kotest or MockK on Kotlin)), and run it in CI so the gap cannot reopen.
Serious — 452 finding(s)
AC4 · Keyboard semantics· Anchor without href · ×29
Anchor without href jshERP-web/src/components/jeecg/JSuperQuery.vue:53— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecg/JUpload.vue:7— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecg/JUpload.vue:8— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecgbiz/JSelectBizComponent/JSelectBizComponentModal.vue:54— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecgbiz/modal/JSelectMaterialModal.vue:46— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecgbiz/modal/JSelectSnAddModal.vue:63— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecgbiz/modal/JSelectSnModal.vue:53— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/jeecgbiz/modal/JSelectSnModal.vue:69— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/table/StandardTable.vue:6— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/table/StandardTable.vue:13— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/table/index.js:167— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/table/index.js:183— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/table/index.js:192— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/components/tools/TwoStepCaptcha.vue:33— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AllocationOutList.vue:36— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AllocationOutList.vue:133— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AllocationOutList.vue:135— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AllocationOutList.vue:137— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AllocationOutList.vue:140— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AssembleList.vue:36— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AssembleList.vue:133— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AssembleList.vue:135— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AssembleList.vue:137— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/AssembleList.vue:140— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href jshERP-web/src/views/bill/DisassembleList.vue:36— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:619— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:619-627 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:759-767 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:619` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) REDACTED:183— REDACTED:183-191 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:153-161 — before extracting anything, compare `REDACTED` and `jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 34 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:183` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:81— jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:81-89 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:220-229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:81` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:94— jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:94-102 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:115-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:94` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:182— jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:182-190 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:195-203 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:182` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:65— jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:65-73 | jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:179-187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) REDACTED:178— REDACTED:178-186 | REDACTED:244-252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:959— jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:959-967 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:975-983 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:959` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:167— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:167-175 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1108-1116 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:57— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:57-65 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:94-102 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:101— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:101-109 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:51-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:91— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:91-99 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:125-133 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:61— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:61-69 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:90-98 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:181— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:181-188 | jshERP-boot/src/main/java/com/jsh/erp/controller/RoleController.java:132-139 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:181` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:335— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:335-342 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:382-389 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:139— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:139-146 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:313-320 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:410— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:410-417 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:247-254 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:410` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:623— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:623-630 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:658-665 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:623` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1228— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1228-1235 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1337-1344 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1228` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:162— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:162-169 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:174-181 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:162` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/LogService.java:142— jshERP-boot/src/main/java/com/jsh/erp/service/LogService.java:142-149 | jshERP-boot/src/main/java/com/jsh/erp/service/LogService.java:161-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:579— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:579-586 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:443-450 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:252— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:252-259 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:265-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:252` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:613— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:613-620 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:653-660 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:613` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1236— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1236-1243 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1354-1361 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1351` calls `getDepotHead`, `getId`, `getOrganId` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1235` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:419— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:419-426 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:195-202 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:40— `getSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:44— `select` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:48— `countSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:53— `insertSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:58— `updateSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:63— `deleteSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:68— `batchDeleteSequence` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:76— `select` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:81— `insertSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:86— `updateSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:91— `deleteSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Hollow method — returns a constant without doing the work jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:96— `batchDeleteSerialNumber` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
TooManyMethods: DepotHeadService jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:41— TooManyMethods — 65 methods. The bar is 30 methods; this is 35 over it, 2.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MaterialService jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:35— TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DepotItemService jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:30— TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DepotHeadVo4List jshERP-boot/src/main/java/com/jsh/erp/datasource/vo/DepotHeadVo4List.java:8— TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Tools REDACTED:24— TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DepotHeadVo4InDetail jshERP-boot/src/main/java/com/jsh/erp/datasource/vo/DepotHeadVo4InDetail.java:7— TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DepotItemStockWarningCount jshERP-boot/src/main/java/com/jsh/erp/datasource/vo/DepotItemStockWarningCount.java:6— TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: StringUtil jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:21— TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UserService jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:31— TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SupplierService jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:32— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×10
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:138— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:138-152 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:312-322 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) REDACTED:233— REDACTED:233-243 | REDACTED:543-553 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/OrgaUserRelService.java:49— jshERP-boot/src/main/java/com/jsh/erp/service/OrgaUserRelService.java:49-59 | jshERP-boot/src/main/java/com/jsh/erp/service/OrgaUserRelService.java:61-72 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:875— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:875-885 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:891-901 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:45— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:45-55 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:67-77 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:96— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:96-106 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:602-612 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:47— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:47-58 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:124-134 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) REDACTED:80— REDACTED:80-90 | REDACTED:158-168 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:64— jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:64-74 | jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:156-166 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:206— jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:206-216 | jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:218-228 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:166— jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:166-172 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:247-253 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:166` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:165` calls `JSONArray` and `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:246` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:200— jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:200-206 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:281-287 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:200` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:288` calls `put`, `getAdvanceIn` and `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:207` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:131— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:131-137 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1075-1081 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:131` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:139` calls `getFinishDepositMapByNumberList`, `getFinancialBillPriceMapByBillIdList` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1083` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:63— jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:63-69 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:80-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:52— jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:52-59 | jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:121-127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:490— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:490-496 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:130-136 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:127— jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:127-133 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:697-703 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:127` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1302— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1302-1308 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1983-1989 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1302` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:649— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:649-655 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1582-1588 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:649` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:106— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:106-112 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:445-451 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
ClassTooLong: DepotHeadService jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:41— ClassTooLong — 1369 significant lines (blank, comment-only and punctuation-only lines excluded), 65 methods. The bar is 400 significant lines; this is 969 over it, 3.42× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MaterialService jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:35— ClassTooLong — 1032 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 400 significant lines; this is 632 over it, 2.58× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DepotItemService jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:30— ClassTooLong — 1027 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 400 significant lines; this is 627 over it, 2.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DepotItemController jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:47— ClassTooLong — 888 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 488 over it, 2.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UserService jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:31— ClassTooLong — 664 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 264 over it, 1.66× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MaterialController jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:37— ClassTooLong — 569 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 169 over it, 1.42× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DepotHeadController jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:45— ClassTooLong — 552 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 152 over it, 1.38× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: SupplierService jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:32— ClassTooLong — 516 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 116 over it, 1.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AccountService jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:31— ClassTooLong — 409 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 9 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×9
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:155— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:155-168 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:152-168 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:886— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:886-899 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:991-1004 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:324— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:324-337 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:339-352 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:317— jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:317-330 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:340-353 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:62— jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:62-75 | jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:176-189 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:126— jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:126-140 | jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:143-156 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:277— jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:277-290 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:298-313 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:265— jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:265-278 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:303-318 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/RedisLockUtil.java:84— jshERP-boot/src/main/java/com/jsh/erp/utils/RedisLockUtil.java:84-101 | jshERP-boot/src/main/java/com/jsh/erp/utils/RedisLockUtil.java:106-119 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×8
Animation without a prefers-reduced-motion guard jshERP-web/public/index.html:53— `#loader` moves (`animation: spin 2s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/public/index.html:76— `#loader:before` moves (`animation: spin 3s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/public/index.html:98— `#loader:after` moves (`animation: spin 1.5s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/src/components/page/GlobalLayout.vue:261— `.layout .topmenu .ant-header-fixedHeader` moves (`transition: width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/src/components/page/GlobalLayout.vue:292— `.layout .sidemenu .ant-header-fixedHeader` moves (`transition: width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/src/components/page/GlobalLayout.vue:431— `.layout .top-nav-header-index` moves (`transition: background .3s, width .2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/src/assets/less/JAreaLinkage.less:126— `.area-selectable-list-wrap` moves (`transition: opacity 0.15s, transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard jshERP-web/src/assets/less/JAreaLinkage.less:174— `.cascader-menu-list-wrap` moves (`transition: opacity 0.15s, transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
FileTooLong: service/DepotHeadService.java jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java— FileTooLong — 1405 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: DepotHeadService (41-2026). The bar is 500 significant lines; this is 905 over it, 2.81× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: service/MaterialService.java jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java— FileTooLong — 1063 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: MaterialService (35-1539). The bar is 500 significant lines; this is 563 over it, 2.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: service/DepotItemService.java jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java— FileTooLong — 1053 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: DepotItemService (30-1630). The bar is 500 significant lines; this is 553 over it, 2.11× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: controller/DepotItemController.java jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java— FileTooLong — 927 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: DepotItemController (47-1223). The bar is 500 significant lines; this is 427 over it, 1.85× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: service/UserService.java jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java— FileTooLong — 691 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: UserService (31-989). The bar is 500 significant lines; this is 191 over it, 1.38× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: controller/MaterialController.java jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java— FileTooLong — 598 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: MaterialController (37-904). The bar is 500 significant lines; this is 98 over it, 1.20× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: controller/DepotHeadController.java jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java— FileTooLong — 589 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: DepotHeadController (45-854). The bar is 500 significant lines; this is 89 over it, 1.18× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: service/SupplierService.java jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java— FileTooLong — 543 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: SupplierService (32-727). The bar is 500 significant lines; this is 43 over it, 1.09× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:716— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:716-725 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:786-795 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:716` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:406— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:406-415 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:501-510 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:406` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:890— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:890-899 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:995-1004 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:890` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:603— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:603-612 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:632-641 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:603` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:558— jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:558-567 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:708-717 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:80— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:80-89 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:69-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:109— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:109-118 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:85-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) REDACTED:91— REDACTED:91-100 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:80-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1290— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1290-1294 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1404-1408 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1290` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1409` calls `equals`, `getOrganId`, `updateAdvanceIn` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1295` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1663— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1663-1667 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1708-1712 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:109— jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:109-113 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:199-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:176— jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:176-180 | jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:195-199 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:176` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:208— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:208-212 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:368-372 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:208` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:213` calls `getUnit`, `getUnitId` and `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:373` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:443— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:443-447 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:598-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1242— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1242-1246 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1316-1320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1242` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:71— jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:71-75 | jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:138-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
AC6 · Visual & motion safety· Focus outline removed in CSS without a · ×6
Focus outline removed in CSS without a :focus replacement jshERP-web/src/components/jeecg/JEditableTable.vue:3114— `.input-table .tbody .td .td-span` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement jshERP-web/src/components/jeecg/modal/JCronModal.vue:844— `.card-container .ant-tabs .ant-tabs-bar` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement jshERP-web/src/components/jeecg/modal/JCronModal.vue:899— `.language` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement jshERP-web/src/assets/less/JAreaLinkage.less:30— `.area-select` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement jshERP-web/src/assets/less/JAreaLinkage.less:123— `.area-selectable-list-wrap` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement jshERP-web/src/assets/less/JAreaLinkage.less:171— `.cascader-menu-list-wrap` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×6
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:175— jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:175-187 | jshERP-boot/src/main/java/com/jsh/erp/service/RedisService.java:194-205 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1277— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1277-1288 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1295-1306 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:111— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:111-122 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:125-136 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:72— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:72-87 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:90-101 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:150— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:150-161 | jshERP-boot/src/main/java/com/jsh/erp/service/LogService.java:118-129 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:79— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:79-90 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:68-79 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (12 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:162— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:162-173 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:569-580 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:162` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:184— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:184-195 | REDACTED:493-504 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java` and `REDACTED` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:184` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) REDACTED:161— REDACTED:161-172 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:130-141 — before extracting anything, compare `REDACTED` and `jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 34 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:161` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:695— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:695-706 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:720-731 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:695` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:796— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:796-807 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:818-829 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:796` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:102— jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:102-113 | jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:145-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:267— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:267-277 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:426-436 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:267` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1117— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1117-1127 | REDACTED:75-85 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) REDACTED:267— REDACTED:267-277 | REDACTED:326-336 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:267` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:160— jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:160-170 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:188-198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:160` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:255— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:255-265 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:308-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:255` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:110— jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:110-120 | jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:128-138 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:119— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:170— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:217— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:268— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:411— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:463— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
MethodTooLong: DepotItemService.saveDetials jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:389— MethodTooLong — saveDetials runs 240 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 140 over it, 2.40× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MaterialService.importExcel jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:574— MethodTooLong — importExcel runs 226 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 126 over it, 2.26× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DepotItemController.getDetailList jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:240— MethodTooLong — getDetailList runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DepotHeadService.debtExport jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1631— MethodTooLong — debtExport runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MaterialExtendService.saveDetials jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:75— MethodTooLong — saveDetials runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×5
Edited copy of a member (13 corresponding lines) REDACTED:103— REDACTED:103-115 | REDACTED:118-130 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:62— jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:62-75 | jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:77-89 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:159— jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:159-174 | jshERP-boot/src/main/java/com/jsh/erp/service/OrgaUserRelService.java:86-98 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:185— jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:185-197 | jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:206-218 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:223— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:223-235 | jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:162-174 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 11+ corresponding lines) · ×5
Edited copies of one member (3 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1240— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1240-1250 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1258-1270 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1314-1324 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:73— jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:73-83 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:172-183 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:68-78 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:67— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:67-77 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:171-181 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:183-195 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:128— jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:128-138 | jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:150-160 | jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:176-186 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:82— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:82-92 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:163-173 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:231-241 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×5
Edited copy of a member (9 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:84— jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:84-97 | jshERP-boot/src/main/java/com/jsh/erp/controller/SerialNumberController.java:51-59 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:384— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:384-392 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:300-308 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:240— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:240-248 | jshERP-boot/src/main/java/com/jsh/erp/service/OrganizationService.java:140-148 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:80— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:80-88 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:210-218 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:139— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:139-147 | jshERP-boot/src/main/java/com/jsh/erp/service/LogService.java:107-115 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (15 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:54— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:54-68 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:76-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:54` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:330— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:330-344 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:358-372 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:330` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:170— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:170-184 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:220-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:170` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:328— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:328-342 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:355-369 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:328` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/exception/BusinessParamCheckingException.java:17— jshERP-boot/src/main/java/com/jsh/erp/exception/BusinessParamCheckingException.java:17-31 | jshERP-boot/src/main/java/com/jsh/erp/exception/BusinessRunTimeException.java:17-31 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/exception/BusinessParamCheckingException.java` and `jshERP-boot/src/main/java/com/jsh/erp/exception/BusinessRunTimeException.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×4
Edited copy of a member (16 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:904— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:904-919 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:942-961 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:144— jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:144-159 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:446-461 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:177— jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:177-192 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:195-210 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:396— jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:396-411 | jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:418-433 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×4
Edited copy of a member (15 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:958— jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:958-972 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:974-988 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:62— jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:62-76 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:79-93 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1595— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1595-1612 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1615-1629 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:176— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:176-190 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:193-207 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×4
Edited copy of a member (17 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialAttributeController.java:116— jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialAttributeController.java:116-132 | REDACTED:287-303 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:157— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:157-173 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:564-580 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:14— jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:14-31 | jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:52-68 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:283— jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:283-300 | jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:303-319 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (13 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:98— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:98-110 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:164-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:98` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:664— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:664-676 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:757-769 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:664` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1026— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1026-1038 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1071-1083 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:242— jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:242-254 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:306-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:306` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:166— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:166-174 | jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:246-254 | REDACTED:476-484 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java` and `REDACTED` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:166` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:661— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:661-669 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:754-762 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:848-856 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:661` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1018— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1018-1026 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1039-1047 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1060-1068 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1018` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:479— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:479-487 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:515-523 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:544-552 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:479` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:246— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:246-252 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:321-327 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:410-416 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:244` calls `equals`, `getOrganArray` and `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:409` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:184— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:184-190 | REDACTED:144-150 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:107-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:184` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:906— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:906-912 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:925-931 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:944-950 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:906` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:462— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:462-468 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:484-490 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:676-682 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:462` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:488— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:488-493 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:505-510 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1855— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1855-1860 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1902-1907 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1855` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1861` calls `getAccountMap` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1908` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:641— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:641-646 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1574-1579 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:641` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:120— jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:120-125 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:689-694 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:120` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
TodoComment jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:20— // TODO: 2015/12/24 这么处理不好,得相伴办法调整 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:23— // TODO: 2015/12/24 这么处理不好,得相伴办法调整 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:188— //TODO 暂时还是先通过计算获取,半年后改成从数据库直接去读last_dept time:20260601 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
Members sharing a duplicated core (4 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:187— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:187-224 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountItemController.java:44-92 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:200-228 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:87-123 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:224— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:224-277 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:306-348 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:380-436 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:946-994 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:154— jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:154-183 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:193-215 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:225-264 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:274-297 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×3
Edited copy of a member (21 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:705— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:705-725 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:774-795 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:322— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:322-345 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:351-371 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:47— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:47-68 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:70-90 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×3
Edited copy of a member (22 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1019— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1019-1040 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1063-1085 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:685— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:685-706 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:709-731 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:123— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:123-144 | jshERP-boot/src/main/java/com/jsh/erp/controller/InOutItemController.java:118-139 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (11 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:202— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:202-212 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1131-1141 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1879-1889 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (11 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:296— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:296-306 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:309-319 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:322-332 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:155— jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:155-165 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:247-257 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:300-310 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:255— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:255-259 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:165-169 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:197-201 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:175-179 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:255` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:60— jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:60-64 | jshERP-boot/src/main/java/com/jsh/erp/controller/PlatformConfigController.java:56-60 | REDACTED:79-83 | jshERP-boot/src/main/java/com/jsh/erp/controller/UnitController.java:56-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:60` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (5 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:155— jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:155-159 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:194-198 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:226-230 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:275-279 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
AC2 · Forms & labels· <fieldset> without a <legend> · ×2
<fieldset> without a <legend> jshERP-web/src/components/jeecg/JFormContainer.vue:3— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> jshERP-web/src/components/jeecg/JFormContainer.vue:7— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×2
Edited copy of a member (23 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:93— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:93-131 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:376-411 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:395— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:395-417 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:232-254 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (33 corresponding lines) · ×2
Edited copy of a member (33 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:615— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:615-647 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:650-682 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (33 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:101— jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:101-133 | jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:144-176 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×2
Edited copy of a member (19 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:438— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:438-456 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:460-480 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (19 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:533— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:533-553 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:162-180 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 11+ corresponding lines) · ×2
Edited copies of one member (4 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:102— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:102-112 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:181-191 | jshERP-boot/src/main/java/com/jsh/erp/controller/PlatformConfigController.java:203-213 | REDACTED:182-193 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
Edited copies of one member (4 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:83— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:83-93 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:249-259 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:357-369 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:390-402 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 15+ corresponding lines) · ×2
Edited copies of one member (3 members, 15+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:143— jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:143-157 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:152-170 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:181-198 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 15+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:793— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:793-807 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:815-829 | jshERP-boot/src/main/java/com/jsh/erp/service/MsgService.java:251-265 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 13+ corresponding lines) · ×2
Edited copies of one member (5 members, 13+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:93— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:93-108 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:121-134 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:97-109 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:122-134 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:92-105 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
Edited copies of one member (5 members, 13+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:135— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:135-147 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:205-217 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:679-691 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:131-143 | jshERP-boot/src/main/java/com/jsh/erp/controller/UnitController.java:116-128 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (6 members, 12+ corresponding lines) · ×2
Edited copies of one member (6 members, 12+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:184— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:184-195 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:145-156 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:111-124 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:137-149 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:112-123 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:137-148 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
Edited copies of one member (6 members, 12+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:78— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:78-89 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:281-292 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:78-89 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:217-229 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:213-225 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:67-78 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×2
Edited copy of a member (10 corresponding lines) REDACTED:103— REDACTED:103-112 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:135-144 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:154— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:154-163 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:389-399 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (18 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:463— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:463-480 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1042-1059 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:107-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (18 lines × 3) REDACTED:123— REDACTED:123-140 | REDACTED:157-174 | REDACTED:192-209 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:123` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (14 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:195— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:195-208 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1124-1137 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:634— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:634-647 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:669-682 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:634` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:215— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:215-224 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountItemController.java:83-92 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:219-228 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:114-123 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:215` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:115— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:115-124 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:127-136 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:315-324 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:326-335 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:671— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:671-687 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:764-780 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:858-874 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:671` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:455— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:455-471 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:491-507 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:527-543 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:455` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6–7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:160— jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:160-166 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:182-187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:157` calls `contains` and `jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:181` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6–7 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:286— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:286-291 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:820-826 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:820` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) REDACTED:116— REDACTED:116-121 | REDACTED:150-155 | REDACTED:185-190 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1167— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1167-1172 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1174-1179 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1182-1187 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1167` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1180` calls `getContent` and `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1173` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
End-of-life framework: Spring Boot 1 REDACTED:1— REDACTED depends on `org.springframework.boot` at a version that pins Spring Boot 1, and Spring Boot 1.x, open-source support ended 2019-08-01. The constraint cannot admit a different major, so this repository stays on it until the declaration is edited. An end-of-life framework receives no further releases, including security releases.
End-of-life framework: Spring Boot 2 REDACTED:1— REDACTED depends on `org.springframework.boot` at a version that pins Spring Boot 2, and Spring Boot 2.x, open-source support ended 2023-11-24. The constraint cannot admit a different major, so this repository stays on it until the declaration is edited. An end-of-life framework receives no further releases, including security releases.
Low cohesion: RoleService (LCOM4 4) jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:29— RoleService's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: UnitService (LCOM4 4) jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:30— UnitService's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
AC1 · Text alternatives· <canvas> without a text alternative · ×1
<canvas> without a text alternative jshERP-web/src/components/jeecg/JGraphicCode.vue:3— A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
AC3 · Page structure· Page without a main landmark · ×1
Page without a main landmark jshERP-web/public/index.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC4 · Keyboard semantics· Link used as a button (placeholder href) · ×1
Link used as a button (placeholder href) jshERP-web/src/components/tools/UserMenu.vue:61— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Low contrast colour pair in CSS (1.8:1) jshERP-web/public/index.html:19— `.chromeframe` sets color: #999 on background-color: #ccc — 1.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
DepotItemService.saveDetials (cyclomatic 103) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:389— DepotItemService.saveDetials has cyclomatic complexity 103 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MaterialService.importExcel (cyclomatic 60) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:574— MaterialService.importExcel has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MaterialExtendService.saveDetials (cyclomatic 43) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:75— MaterialExtendService.saveDetials has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.batchDeleteBillByIds (cyclomatic 41) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:417— DepotHeadService.batchDeleteBillByIds has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MaterialController.getMaterialByBarCode (cyclomatic 35) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:583— MaterialController.getMaterialByBarCode has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.select (cyclomatic 33) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:108— DepotHeadService.select has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.batchSetStatus (cyclomatic 28) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:748— DepotHeadService.batchSetStatus has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotItemController.getDetailList (cyclomatic 27) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:240— DepotItemController.getDetailList has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.addDepotHeadAndDetail (cyclomatic 25) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1218— DepotHeadService.addDepotHeadAndDetail has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.debtExport (cyclomatic 25) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1631— DepotHeadService.debtExport has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.updateDepotHeadAndDetail (cyclomatic 25) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1328— DepotHeadService.updateDepotHeadAndDetail has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotItemController.buyOrSalePrice (cyclomatic 24) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1005— DepotItemController.buyOrSalePrice has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MaterialService.exportExcel (cyclomatic 24) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:482— MaterialService.exportExcel has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.getDetailByNumber (cyclomatic 23) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1067— DepotHeadService.getDetailByNumber has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotItemService.parseMapByExcelData (cyclomatic 23) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1427— DepotItemService.parseMapByExcelData has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AccountItemService.saveDetials (cyclomatic 22) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:112— AccountItemService.saveDetials has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotItemService.calculateCurrentUnitPrice (cyclomatic 20) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1194— DepotItemService.calculateCurrentUnitPrice has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MaterialController.findBySelect (cyclomatic 18) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:296— MaterialController.findBySelect has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SystemConfigService.deleteFileByPathList (cyclomatic 18) REDACTED:350— SystemConfigService.deleteFileByPathList has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DepotHeadService.parseDebtBillList (cyclomatic 16) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1757— DepotHeadService.parseDebtBillList has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Hotspot: jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1194— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in DepotItemService.calculateCurrentUnitPrice at line 1194. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-13..2026-11-11, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-13 09:24:22 +08:00' --until='2026-11-11 09:24:22 +08:00' --full-history --no-merges -- jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
DepotItemService.saveDetials (cognitive 316) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:389— DepotItemService.saveDetials has cognitive complexity 316 (threshold 15). Drivers by points: if/else 83 (272 pts), boolean chains 24, ternaries 4 (16 pts), loops 2 (4 pts) (nesting depth added 203). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialExtendService.saveDetials (cognitive 118) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:75— MaterialExtendService.saveDetials has cognitive complexity 118 (threshold 15). Drivers by points: if/else 37 (92 pts), loops 9 (25 pts), boolean chains 1 (nesting depth added 71). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialService.importExcel (cognitive 114) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:574— MaterialService.importExcel has cognitive complexity 114 (threshold 15). Drivers by points: if/else 41 (84 pts), boolean chains 14, ternaries 5 (10 pts), loops 3 (4 pts), error handling 2 (nesting depth added 49). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialController.getMaterialByBarCode (cognitive 87) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:583— MaterialController.getMaterialByBarCode has cognitive complexity 87 (threshold 15). Drivers by points: if/else 25 (65 pts), boolean chains 9, loops 2 (6 pts), ternaries 2 (6 pts), error handling 1 (nesting depth added 48). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotHeadService.batchDeleteBillByIds (cognitive 86) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:417— DepotHeadService.batchDeleteBillByIds has cognitive complexity 86 (threshold 15). Drivers by points: if/else 22 (58 pts), boolean chains 14, loops 5 (9 pts), ternaries 1 (5 pts) (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.select (cognitive 83) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:108— DepotHeadService.select has cognitive complexity 83 (threshold 15). Drivers by points: if/else 17 (45 pts), ternaries 11 (30 pts), loops 2 (4 pts), boolean chains 3, error handling 1 (nesting depth added 49). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotItemService.parseMapByExcelData (cognitive 72) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1427— DepotItemService.parseMapByExcelData has cognitive complexity 72 (threshold 15). Drivers by points: if/else 22 (68 pts), loops 3, boolean chains 1 (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
SystemConfigService.deleteFileByPathList (cognitive 72) REDACTED:350— SystemConfigService.deleteFileByPathList has cognitive complexity 72 (threshold 15). Drivers by points: if/else 8 (30 pts), error handling 4 (24 pts), loops 4 (12 pts), ternaries 1 (6 pts) (nesting depth added 55). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotItemController.buyOrSalePrice (cognitive 65) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1005— DepotItemController.buyOrSalePrice has cognitive complexity 65 (threshold 15). Drivers by points: if/else 10 (43 pts), loops 6 (15 pts), boolean chains 6, error handling 1 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.batchSetStatus (cognitive 53) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:748— DepotHeadService.batchSetStatus has cognitive complexity 53 (threshold 15). Drivers by points: if/else 16 (33 pts), boolean chains 9, loops 3 (8 pts), ternaries 1 (3 pts) (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialService.exportExcel (cognitive 51) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:482— MaterialService.exportExcel has cognitive complexity 51 (threshold 15). Drivers by points: ternaries 11 (34 pts), loops 5 (10 pts), if/else 6, boolean chains 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotItemController.getDetailList (cognitive 50) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:240— DepotItemController.getDetailList has cognitive complexity 50 (threshold 15). Drivers by points: if/else 12 (23 pts), ternaries 11 (22 pts), boolean chains 3, error handling 1, loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountItemService.saveDetials (cognitive 50) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:112— AccountItemService.saveDetials has cognitive complexity 50 (threshold 15). Drivers by points: if/else 13 (37 pts), boolean chains 7, loops 3 (6 pts) (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialController.findBySelect (cognitive 49) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:296— MaterialController.findBySelect has cognitive complexity 49 (threshold 15). Drivers by points: if/else 14 (42 pts), boolean chains 4, loops 1 (2 pts), error handling 1 (nesting depth added 29). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotItemService.calculateCurrentUnitPrice (cognitive 49) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1194— DepotItemService.calculateCurrentUnitPrice has cognitive complexity 49 (threshold 15). Drivers by points: if/else 14 (38 pts), boolean chains 6, ternaries 2 (4 pts), loops 1 (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotHeadService.getDetailByNumber (cognitive 42) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1067— DepotHeadService.getDetailByNumber has cognitive complexity 42 (threshold 15). Drivers by points: if/else 15 (27 pts), ternaries 5 (10 pts), boolean chains 2, loops 1 (2 pts), error handling 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.debtExport (cognitive 40) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1631— DepotHeadService.debtExport has cognitive complexity 40 (threshold 15). Drivers by points: ternaries 9 (22 pts), if/else 8 (10 pts), boolean chains 4, loops 2 (3 pts), error handling 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.updateDepotHeadAndDetail (cognitive 37) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1328— DepotHeadService.updateDepotHeadAndDetail has cognitive complexity 37 (threshold 15). Drivers by points: if/else 19 (31 pts), boolean chains 5, ternaries 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QueryUtils.filter (cognitive 37) jshERP-boot/src/main/java/com/jsh/erp/utils/QueryUtils.java:93— QueryUtils.filter has cognitive complexity 37 (threshold 15). Drivers by points: if/else 9 (28 pts), loops 2 (9 pts) (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotHeadService.addDepotHeadAndDetail (cognitive 34) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1218— DepotHeadService.addDepotHeadAndDetail has cognitive complexity 34 (threshold 15). Drivers by points: if/else 18 (27 pts), boolean chains 4, ternaries 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotService.findDepotByCurrentUser (cognitive 33) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:315— DepotService.findDepotByCurrentUser has cognitive complexity 33 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 3 (14 pts), boolean chains 1 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
AccountService.getManyAccountSum (cognitive 29) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:322— AccountService.getManyAccountSum has cognitive complexity 29 (threshold 15). Drivers by points: if/else 5 (21 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotItemController.importItemExcel (cognitive 27) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1137— DepotItemController.importItemExcel has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 3, error handling 2, loops 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerialNumberController.getEnableSerialNumberList (cognitive 27) jshERP-boot/src/main/java/com/jsh/erp/controller/SerialNumberController.java:70— SerialNumberController.getEnableSerialNumberList has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 3 (8 pts), boolean chains 1, error handling 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.parseDebtBillList (cognitive 27) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1757— DepotHeadService.parseDebtBillList has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (12 pts), ternaries 6 (12 pts), loops 2, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotItemService.deleteOrCancelSerialNumber (cognitive 27) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:870— DepotItemService.deleteOrCancelSerialNumber has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (16 pts), ternaries 1 (6 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
AccountHeadService.getDetailByNumber (cognitive 25) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:376— AccountHeadService.getDetailByNumber has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 1 (2 pts), error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountHeadService.select (cognitive 25) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:91— AccountHeadService.select has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 1 (2 pts), error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FunctionController.findByIds (cognitive 23) jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:314— FunctionController.findByIds has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (6 pts), boolean chains 3, error handling 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountHeadService.addAccountHeadAndDetail (cognitive 23) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:299— AccountHeadService.addAccountHeadAndDetail has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1 (3 pts), boolean chains 2, ternaries 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialService.insertMaterial (cognitive 23) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:161— MaterialService.insertMaterial has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (16 pts), boolean chains 3, error handling 2, loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialService.updateMaterial (cognitive 23) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:206— MaterialService.updateMaterial has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (18 pts), boolean chains 2, loops 1 (2 pts), error handling 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SupplierService.exportExcelVendorOrCustomer (cognitive 23) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:623— SupplierService.exportExcelVendorOrCustomer has cognitive complexity 23 (threshold 15). Drivers by points: ternaries 4 (14 pts), if/else 5 (7 pts), loops 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountService.getManyAccountSumParse (cognitive 22) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:351— AccountService.getManyAccountSumParse has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (15 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotHeadService.getOrganArray (cognitive 22) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:278— DepotHeadService.getOrganArray has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 1 (4 pts), boolean chains 3 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
AccountHeadService.batchSetStatus (cognitive 21) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:252— AccountHeadService.batchSetStatus has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (15 pts), ternaries 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.waitBillList (cognitive 21) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1852— DepotHeadService.waitBillList has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (4 pts), ternaries 2, boolean chains 1, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserService.updateUserAndOrgUserRel (cognitive 21) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:675— UserService.updateUserAndOrgUserRel has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelUtils.exportObjectsOneSheet (cognitive 21) jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:115— ExcelUtils.exportObjectsOneSheet has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 3 (4 pts), ternaries 1 (4 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotItemController.getInOutStock (cognitive 20) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:397— DepotItemController.getInOutStock has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), ternaries 1 (3 pts), error handling 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotHeadService.batchAddDepotHeadAndDetail (cognitive 20) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1919— DepotHeadService.batchAddDepotHeadAndDetail has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (12 pts), ternaries 2 (4 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DepotItemService.getBillStatusByParam (cognitive 19) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:755— DepotItemService.getBillStatusByParam has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 2 (4 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotItemService.updateMaterialExtendPrice (cognitive 19) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:964— DepotItemService.updateMaterialExtendPrice has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (19 pts) (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialService.batchCheckExistBarCodeByParam (cognitive 19) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:972— MaterialService.batchCheckExistBarCodeByParam has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialService.getMaterialOtherByParam (cognitive 19) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1431— MaterialService.getMaterialOtherByParam has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 3 (9 pts), if/else 3 (6 pts), boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserService.validateUser (cognitive 19) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:403— UserService.validateUser has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 4, error handling 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountItemController.getDetailList (cognitive 18) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountItemController.java:43— AccountItemController.getDetailList has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (11 pts), ternaries 1 (4 pts), loops 1 (2 pts), error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerialNumberService.addSerialNumberByBill (cognitive 18) jshERP-boot/src/main/java/com/jsh/erp/service/SerialNumberService.java:246— SerialNumberService.addSerialNumberByBill has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 2 (8 pts), if/else 3 (5 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserService.getBtnStrArrById (cognitive 18) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:875— UserService.getBtnStrArrById has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DepotItemController.findStockWarningCount (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:941— DepotItemController.findStockWarningCount has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 2 (4 pts), boolean chains 2, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialController.getListWithStock (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:741— MaterialController.getListWithStock has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (8 pts), ternaries 4 (6 pts), loops 1 (2 pts), error handling 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
AccountHeadService.getFinancialBillPriceByBillId (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:419— AccountHeadService.getFinancialBillPriceByBillId has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
UserService.checkLoginName (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:776— UserService.checkLoginName has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 3 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
DictUtils.getDictLabel (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:100— DictUtils.getDictLabel has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 3 (7 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (DictUtils.getDictValue) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
DictUtils.getDictValue (cognitive 17) jshERP-boot/src/main/java/com/jsh/erp/utils/DictUtils.java:143— DictUtils.getDictValue has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 3 (7 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (DictUtils.getDictLabel) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
DepotItemController.getInOutStockCountMoney (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:496— DepotItemController.getInOutStockCountMoney has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), error handling 2, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FunctionController.getMenuByFunction (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:195— FunctionController.getMenuByFunction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (13 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MaterialService.getStockMapCache (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:920— MaterialService.getStockMapCache has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (14 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MaterialService.select (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:120— MaterialService.select has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (6 pts), ternaries 2 (6 pts), loops 1 (2 pts), boolean chains 1, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserBusinessService.updateOneValueByKeyIdAndType (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:183— UserBusinessService.updateOneValueByKeyIdAndType has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OrderUtils.getOrderString (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/utils/OrderUtils.java:52— OrderUtils.getOrderString has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
StringUtil.stripEnd (cognitive 16) jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:503— StringUtil.stripEnd has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Near-duplicate member family (3 members, 65 shared lines) · ×1
Near-duplicate member family (3 members, 65 shared lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:660— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:660-728 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:753-821 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:847-915 — These 3 members are variants of one another: a block of 65 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication· Near-duplicate member family (3 members, 2 shared lines) · ×1
Near-duplicate member family (3 members, 2 shared lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1354— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1354-1374 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:227-240 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:271-284 — These 3 members are variants of one another: a block of 2 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
Near-duplicate member pair (56 shared lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1219— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1219-1318 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1328-1429 — These two members are variants of one another: 56 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (50 shared lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:109— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:109-225 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1067-1152 — These two members are variants of one another: 50 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (28 shared lines) jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:50— jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:50-102 | jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:116-179 — These two members are variants of one another: 28 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (25 shared lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:159— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:159-195 | REDACTED:468-504 — These two members are variants of one another: 25 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Members sharing a duplicated core (24 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (24 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:48— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:48-57 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:45-54 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:59-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:66-75 | jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:54-63 | jshERP-boot/src/main/java/com/jsh/erp/controller/InOutItemController.java:42-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/LogController.java:43-52 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialAttributeController.java:42-51 | REDACTED:45-54 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:70-79 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:41-50 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:46-55 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:43-52 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:47-56 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:44-53 | jshERP-boot/src/main/java/com/jsh/erp/controller/PlatformConfigController.java:42-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/RoleController.java:47-56 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:60-69 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:528-537 | REDACTED:65-74 | jshERP-boot/src/main/java/com/jsh/erp/controller/TenantController.java:39-48 | jshERP-boot/src/main/java/com/jsh/erp/controller/UnitController.java:42-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:39-48 | REDACTED:68-77 — These 24 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 24 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 24 times.
D4 · Code Duplication· Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (7 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:208— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:208-267 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:144-176 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:162-205 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:267-310 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:136-181 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:201-247 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:154-187 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (6 members, 50+ identical tokens) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:405— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:405-484 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:500-554 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:404-420 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:432-448 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:460-476 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:574-869 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication· Edited copies of one member (3 members, 52+ corresponding lines) · ×1
Edited copies of one member (3 members, 52+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:101— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:101-157 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:440-496 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:498-549 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 52 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (34 corresponding lines) · ×1
Edited copy of a member (34 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:454— jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:454-487 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:490-523 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (53 corresponding lines) · ×1
Edited copy of a member (53 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:529— jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:529-581 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:675-740 — These two members are one piece of code written twice and then edited apart: 53 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (43 corresponding lines) · ×1
Edited copy of a member (43 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:161— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:161-203 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:206-254 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (44 corresponding lines) · ×1
Edited copy of a member (44 corresponding lines) REDACTED:230— REDACTED:230-286 | REDACTED:295-338 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (26 corresponding lines) · ×1
Edited copy of a member (26 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:240— jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:240-265 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:293-318 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) REDACTED:145— REDACTED:145-172 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:112-141 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 26+ corresponding lines) · ×1
Edited copies of one member (3 members, 26+ corresponding lines) REDACTED:115— REDACTED:115-140 | REDACTED:149-174 | REDACTED:184-209 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×1
Edited copy of a member (18 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:93— jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:93-111 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:114-131 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (27 corresponding lines) · ×1
Edited copy of a member (27 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/ExtJsonUtils.java:22— jshERP-boot/src/main/java/com/jsh/erp/utils/ExtJsonUtils.java:22-48 | jshERP-boot/src/main/java/com/jsh/erp/utils/ExtJsonUtils.java:52-79 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 14+ corresponding lines) · ×1
Edited copies of one member (3 members, 14+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:183— jshERP-boot/src/main/java/com/jsh/erp/service/AccountItemService.java:183-196 | REDACTED:143-156 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:106-119 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 17+ corresponding lines) · ×1
Edited copies of one member (3 members, 17+ corresponding lines) REDACTED:197— REDACTED:197-213 | REDACTED:438-456 | REDACTED:513-532 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (8 members, 16+ corresponding lines) · ×1
Edited copies of one member (8 members, 16+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:566— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:566-582 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:376-392 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:228-244 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:228-244 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:217-233 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:372-388 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:287-303 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:162-177 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 15+ corresponding lines) · ×1
Edited copies of one member (4 members, 15+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:169— jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:169-183 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:195-209 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:170-184 | REDACTED:391-405 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 10+ corresponding lines) · ×1
Edited copies of one member (4 members, 10+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:122— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:122-131 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:135-144 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:148-157 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:161-170 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 15+ corresponding lines) · ×1
Edited copies of one member (5 members, 15+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:153— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:153-167 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:119-133 | jshERP-boot/src/main/java/com/jsh/erp/controller/SequenceController.java:37-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:108-122 | REDACTED:414-429 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 14+ corresponding lines) · ×1
Edited copies of one member (4 members, 14+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1579— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1579-1592 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:250-263 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:154-171 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:179-192 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (8 members, 11+ corresponding lines) · ×1
Edited copies of one member (8 members, 11+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:269— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:269-279 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:205-215 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:159-169 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:192-203 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:312-322 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:183-193 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:160-170 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:189-199 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×1
Edited copy of a member (8 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/SysDictTypeController.java:71— jshERP-boot/src/main/java/com/jsh/erp/controller/SysDictTypeController.java:71-78 | jshERP-boot/src/main/java/com/jsh/erp/controller/SysDictTypeController.java:85-92 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 12+ corresponding lines) · ×1
Edited copies of one member (3 members, 12+ corresponding lines) REDACTED:180— REDACTED:180-191 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:150-161 | REDACTED:376-387 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 10+ corresponding lines) · ×1
Edited copies of one member (3 members, 10+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:290— jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:290-299 | jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:308-317 | jshERP-boot/src/main/java/com/jsh/erp/utils/StringUtil.java:326-338 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 9+ corresponding lines) · ×1
Edited copies of one member (5 members, 9+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:236— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:236-245 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:229-238 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:838-847 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:859-867 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:513-522 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (6 members, 23+ corresponding lines) · ×1
Edited copies of one member (6 members, 23+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:97— jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:97-123 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:148-174 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:199-221 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:246-272 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:388-415 | jshERP-boot/src/main/java/com/jsh/erp/utils/Convert.java:440-467 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (6 members, 10+ corresponding lines) · ×1
Edited copies of one member (6 members, 10+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:260— jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:260-269 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:294-303 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:356-366 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:369-379 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:208-218 | jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:516-526 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 12+ corresponding lines) · ×1
Edited copies of one member (5 members, 12+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:54— jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:54-66 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:82-93 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:96-107 | jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:123-136 | jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:141-154 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 7+ corresponding lines) · ×1
Edited copies of one member (3 members, 7+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:62— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:62-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/InOutItemController.java:56-62 | jshERP-boot/src/main/java/com/jsh/erp/controller/TenantController.java:53-60 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×1
Edited copy of a member (6 corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:73— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:73-79 | REDACTED:59-64 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 9+ corresponding lines) · ×1
Edited copies of one member (4 members, 9+ corresponding lines) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:104— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:104-112 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:91-100 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:81-90 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:1169-1177 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
Duplicated block (4–28 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:130— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:130-157 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:469-496 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:534-537 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:130` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (35 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1252— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1252-1286 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1362-1396 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (25 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:136— jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:136-160 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:171-195 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:136` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23–24 lines × 2) REDACTED:232— REDACTED:232-255 | REDACTED:297-319 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:232` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) REDACTED:194— REDACTED:194-215 | REDACTED:260-281 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1025— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1025-1044 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1046-1065 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1025` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (3–16 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:147— jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:147-162 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1090-1105 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1876-1878 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:147` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:147` calls `setAccountName` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:1876` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:225— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:225-238 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:307-320 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:947-960 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:225` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (30 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:690— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:690-719 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:783-812 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:877-906 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:690` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:212— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:212-223 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountItemController.java:80-91 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:111-122 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:212` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10–11 lines × 7) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:242— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:242-252 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:152-162 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:170-179 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:274-284 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:157-167 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:222-232 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:162-172 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 7 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:242` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 18) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:158— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:158-167 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:544-553 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:719-728 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:812-821 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:906-915 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:985-994 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:792-801 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:174-183 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:200-209 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:124-133 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:150-159 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:175-184 | jshERP-boot/src/main/java/com/jsh/erp/controller/SequenceController.java:42-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:113-122 | REDACTED:204-213 | REDACTED:396-405 | REDACTED:420-429 | REDACTED:523-532 — there are 18 copies across 9 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 18 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:158` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 6) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:475— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:475-484 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:545-554 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:411-420 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:439-448 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:467-476 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:860-869 — there are 6 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:475` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 5) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:229— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:229-238 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:311-320 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:386-395 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:396-405 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:951-960 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (9 lines × 11) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:215— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:215-223 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:228-236 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:241-249 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:151-159 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:169-177 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:273-281 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:143-151 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:156-164 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:208-216 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:221-229 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:161-169 — there are 11 copies across 7 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 11 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:215` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:102— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:102-124 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:384-406 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:407` calls `add` and `jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:125` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8–9 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1217— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1217-1225 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1231-1238 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1217` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 24) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:50— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:50-57 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:47-54 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:61-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:68-75 | jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:56-63 | jshERP-boot/src/main/java/com/jsh/erp/controller/InOutItemController.java:44-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/LogController.java:45-52 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialAttributeController.java:44-51 | REDACTED:47-54 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:72-79 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:43-50 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:48-55 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:45-52 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:49-56 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:46-53 | jshERP-boot/src/main/java/com/jsh/erp/controller/PlatformConfigController.java:44-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/RoleController.java:49-56 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:62-69 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:530-537 | REDACTED:67-74 | jshERP-boot/src/main/java/com/jsh/erp/controller/TenantController.java:41-48 | jshERP-boot/src/main/java/com/jsh/erp/controller/UnitController.java:44-51 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:41-48 | REDACTED:70-77 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:50` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:79— jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:79-94 | jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:146-161 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/utils/ExcelUtils.java:79` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (4–7 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:430— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:430-433 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:693-699 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:786-792 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:880-886 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (5 lines × 6) jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:123— jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:123-127 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:128-132 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:462-466 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:467-471 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:518-522 | jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:523-527 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:135` calls `DecimalFormat` and `jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:530` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1034— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1034-1038 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1055-1059 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1076-1080 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java:1034` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (4–5 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:176— jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:176-180 | jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:285-289 | REDACTED:486-489 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java` and `REDACTED` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (2–5 lines × 3) jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1370— jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1370-1371 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:236-240 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:280-284 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1370` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:236` calls `divide`, `getRatioThree` and `jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:1370` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 23) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:72— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:72-76 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:80-84 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:88-92 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java:96-100 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotController.java:83-87 | jshERP-boot/src/main/java/com/jsh/erp/controller/FunctionController.java:77-81 | jshERP-boot/src/main/java/com/jsh/erp/controller/InOutItemController.java:66-70 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialAttributeController.java:65-69 | REDACTED:68-72 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialController.java:110-114 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java:54-58 | jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialPropertyController.java:68-72 | jshERP-boot/src/main/java/com/jsh/erp/controller/MsgController.java:65-69 | jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java:60-64 | jshERP-boot/src/main/java/com/jsh/erp/controller/PersonController.java:67-71 | jshERP-boot/src/main/java/com/jsh/erp/controller/PlatformConfigController.java:64-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/RoleController.java:70-74 | jshERP-boot/src/main/java/com/jsh/erp/controller/SupplierController.java:86-90 | REDACTED:87-91 | jshERP-boot/src/main/java/com/jsh/erp/controller/TenantController.java:64-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/UnitController.java:64-68 | jshERP-boot/src/main/java/com/jsh/erp/controller/UserBusinessController.java:52-56 | REDACTED:91-95 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/MaterialExtendController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 4) jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:123— jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:123-129 | jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java:140-146 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:615-621 | jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:632-638 — before extracting anything, compare `jshERP-boot/src/main/java/com/jsh/erp/controller/AccountHeadController.java` and `jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `body` to `AccountHeadVo4Body` in one and `DepotHeadVo4Body` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 18) jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:57— jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:57-65 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java:86-94 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotItemService.java:72-80 | jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:49-57 | jshERP-boot/src/main/java/com/jsh/erp/service/FunctionService.java:44-52 | jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java:46-54 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialAttributeService.java:37-45 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:46-54 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialExtendService.java:42-50 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialPropertyService.java:37-45 | jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java:85-93 | jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java:50-58 | jshERP-boot/src/main/java/com/jsh/erp/service/RoleService.java:44-52 | jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java:60-68 | REDACTED:70-78 | jshERP-boot/src/main/java/com/jsh/erp/service/TenantService.java:54-62 | jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java:45-53 | jshERP-boot/src/main/java/com/jsh/erp/service/UserBusinessService.java:39-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 18 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Skeleton type — most members are unfinished jshERP-boot/src/main/java/com/jsh/erp/service/SequenceService.java:28— `SequenceService` has 7 unfinished members out of 11 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented.
No CI pipeline — No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
SC1 · Supply-chain hygiene· JavaScript dependencies are not locked · ×1
JavaScript dependencies are not locked jshERP-web/package.json:9— jshERP-web/package.json declares dependencies that no committed lockfile resolves — there is no package-lock.json / yarn.lock / pnpm-lock.yaml / bun.lock beside it, and no locked workspace above it names it — so its installs aren't reproducible (SSDF PW.4.4). Commit its package manager's lockfile (or add it to the locked workspace) and install from it (`npm ci`, `yarn --immutable`, `pnpm i --frozen-lockfile` or `bun i --frozen-lockfile`). Advisory — never scored.
X13 · Undrained process stream· Redirected process stream is never drained (deadlock) · ×1
Redirected process stream is never drained (deadlock) jshERP-boot/src/main/java/com/jsh/erp/utils/ComputerInfo.java:50— The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and the parent reads the other stream to its end while nothing reads stderr; that read returns only at end of stream, which the child never reaches. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
Swallowed exception (empty catch) jshERP-boot/src/main/java/com/jsh/erp/utils/HttpClient.java:85— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Interpolated log message defeats structured logging jshERP-boot/src/main/java/com/jsh/erp/utils/HttpClient.java:78— `info` at line 78 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging jshERP-boot/src/main/java/com/jsh/erp/utils/PinYinUtil.java:48— `error` at line 48 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging jshERP-boot/src/main/java/com/jsh/erp/service/PlatformConfigService.java:255— `error` at line 255 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:320— `error` at line 320 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:321— `error` at line 321 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:322— `error` at line 322 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:323— `error` at line 323 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:375— `error` at line 375 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:377— `error` at line 377 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:379— `error` at line 379 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:433— `info` at line 433 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:436— `info` at line 436 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:163— `error` at line 163 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java:345— `error` at line 345 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:264— `error` at line 264 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:166— `info` at line 166 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging REDACTED:272— `error` at line 272 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java:286— `!noList.isEmpty() && ("0".equals(status) || "1".equals(status))` appears character-identically in 2 files — jshERP-boot/src/main/java/com/jsh/erp/service/AccountHeadService.java, jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:218— `accountHeadList!=null&&accountHeadList.size()>0` appears character-identically in 3 files — jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java, jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java, jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:231— `accountItemList!=null&&accountItemList.size()>0` appears character-identically in 2 files — jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java, jshERP-boot/src/main/java/com/jsh/erp/service/InOutItemService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java:241— `creatorArray == null && organizationId != null` appears character-identically in 3 files — jshERP-boot/src/main/java/com/jsh/erp/controller/DepotHeadController.java, jshERP-boot/src/main/java/com/jsh/erp/controller/DepotItemController.java, jshERP-boot/src/main/java/com/jsh/erp/service/DepotHeadService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:156— `dataParentList!=null&&dataParentList.size()>0` appears character-identically in 2 files — REDACTED, jshERP-boot/src/main/java/com/jsh/erp/controller/OrganizationController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java:244— `depotHeadList!=null&&depotHeadList.size()>0` appears character-identically in 3 files — jshERP-boot/src/main/java/com/jsh/erp/service/AccountService.java, jshERP-boot/src/main/java/com/jsh/erp/service/PersonService.java, jshERP-boot/src/main/java/com/jsh/erp/service/SupplierService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java:174— `depotItemList!=null&&depotItemList.size()>0` appears character-identically in 2 files — jshERP-boot/src/main/java/com/jsh/erp/service/DepotService.java, jshERP-boot/src/main/java/com/jsh/erp/service/MaterialService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java:172— `materialList!=null&&materialList.size()>0` appears character-identically in 2 files — jshERP-boot/src/main/java/com/jsh/erp/service/MaterialCategoryService.java, jshERP-boot/src/main/java/com/jsh/erp/service/UnitService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:571— `tenant.getExpireTime()!=null && tenant.getExpireTime().getTime()<System.currentTimeMillis()` appears character-identically in 2 files — REDACTED, jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/mixins/JeecgListMixin.js:326— `!fileName || typeof fileName != "string"` appears character-identically in 2 files — jshERP-web/src/mixins/JeecgListMixin.js, jshERP-web/src/utils/util.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/utils/authFilter.js:78— `allPermissionList != null && allPermissionList != "" && allPermissionList != undefined && allPermissionList.length > 0` appears character-identically in 2 files — jshERP-web/src/utils/authFilter.js, jshERP-web/src/utils/hasPermission.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/mixins/JeecgListMixin.js:296— `columnsStr && columnsStr.indexOf(',')>-1` appears character-identically in 2 files — jshERP-web/src/mixins/JeecgListMixin.js, jshERP-web/src/views/bill/mixins/BillListMixin.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/utils/authFilter.js:94— `permissionList === null || permissionList === "" || permissionList === undefined||permissionList.length<=0` appears character-identically in 2 files — jshERP-web/src/utils/authFilter.js, jshERP-web/src/utils/hasPermission.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/utils/authFilter.js:69— `sessionStorage.getItem(SYS_BUTTON_AUTH) || "[]"` appears character-identically in 2 files — jshERP-web/src/utils/authFilter.js, jshERP-web/src/utils/hasPermission.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/utils/authFilter.js:62— `sessionStorage.getItem(USER_AUTH) || "[]"` appears character-identically in 2 files — jshERP-web/src/utils/authFilter.js, jshERP-web/src/utils/hasPermission.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate jshERP-web/src/views/bill/mixins/BillModalMixin.js:86— `this.action !== "add" && this.action !== "edit"` appears character-identically in 2 files — jshERP-web/src/views/bill/mixins/BillModalMixin.js, jshERP-web/src/views/financial/mixins/FinancialModalMixin.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Fat interface: DepotHeadMapperEx (31 abstract methods) jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/DepotHeadMapperEx.java:17— `DepotHeadMapperEx` declares 31 abstract methods: `batchDeleteDepotHeadByIds`, `debtList`, `debtListCount`, `findAllocationDetail`, `findAllocationDetailCount`, `findAllocationStatistic`, `findInOutDetail`, `findInOutDetailCount`, `findInOutDetailStatistic`, `findInOutMaterialCount`, `findInOutMaterialCountStatistic`, `findInOutMaterialCountTotal`, `findMaterialsListMapByHeaderIdList`, `getAllDepositByLinkNumber`, `getBillAllPriceByOrganId`, `getBuyAndSaleStatisticsList`, `getDepotHeadListByAccountIds`, `getDepotHeadListByCreator`, `getDepotHeadListByOrganIds`, `getDetailByNumber`, `getFinishDepositByNumberExceptCurrent`, `getFinishDepositByNumberList`, `getMaterialCountListByHeaderIdList`, `getSerialNumberBySell`, `getStatementAccount`, `getStatementAccountCount`, `getStatementAccountTotalPay`, `selectByConditionDepotHead`, `setAccountIdToNull`, `waitBillCount`, `waitBillList`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: DepotItemMapperEx (37 abstract methods) jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/DepotItemMapperEx.java:17— `DepotItemMapperEx` declares 37 abstract methods: `batchDeleteDepotItemByDepotHeadIds`, `batchDeleteDepotItemByIds`, `batchInsert`, `buyOrSaleNumber`, `buyOrSalePrice`, `buyOrSalePriceTotal`, `countsByDepotItem`, `findDepotItemListBydepotheadId`, `findDetailByDepotIdsAndMaterialIdCount`, `findDetailByDepotIdsAndMaterialIdList`, `findStockWarningCount`, `findStockWarningCountTotal`, `getBatchBillDetailMaterialSum`, `getBatchNumberList`, `getBillDetailListByIds`, `getBillItemByParam`, `getCountByMaterialAndBatchNumber`, `getCountByMaterialAndDepot`, `getCurrentStockByParam`, `getDepotItemByBatchNumber`, `getDepotItemListListByDepotIds`, `getDepotItemListListByMaterialIds`, `getDetailList`, `getFinishNumber`, `getInOutStock`, `getInOutStockCount`, `getLastUnitPriceByParam`, `getLinkBillDetailMaterialSum`, `getListWithBuyOrSale`, `getListWithBuyOrSaleCount`, `getRealFinishNumber`, `getSkuStockByParamWithDepotList`, `getSkuStockCheckSumByDepotList`, `getStockByParamWithDepotList`, `getStockCheckSumByDepotList`, `inOrOutPriceList`, `selectByConditionDepotItem`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: MaterialMapperEx (30 abstract methods) jshERP-boot/src/main/java/com/jsh/erp/datasource/mappers/MaterialMapperEx.java:19— `MaterialMapperEx` declares 30 abstract methods: `batchDeleteMaterialByIds`, `checkIsExist`, `exportExcel`, `findById`, `findByIdWithBarCode`, `findByMaterialName`, `findBySelectWithBarCode`, `findBySelectWithBarCodeCount`, `findUnitList`, `getBarCodeList`, `getInitialStockWithMaterial`, `getListWithStock`, `getListWithStockCount`, `getMaterialByBarCode`, `getMaterialByBarCodeAndWithOutMId`, `getMaterialByMeId`, `getMaterialByParam`, `getMaterialDepotStock`, `getMaterialEnableSerialNumberCount`, `getMaterialEnableSerialNumberList`, `getMaterialExtendBySerialNumber`, `getMaterialListByCategoryIds`, `getMaterialListByUnitIds`, `getMaterialNameList`, `getOtherMaterialList`, `getTotalStockAndPrice`, `insertSelectiveEx`, `selectByConditionMaterial`, `setExpiryNumToNull`, `setUnitIdToNull`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Documentation: no build, run or usage example README.md:1— the repository holds project manifests and neither `README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
No ADRs found REDACTED:143— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `REDACTED` makes this repository a deployable product (line 143).
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion REDACTED:1— `jshERP-boot` (29217 LoC, 337 module-visible types across 12 directories) overshoots its size bounds. 1 of 2 build unit(s) (Maven, npm) overshoot their size bounds, lowering Project Cohesion to 0.0/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation jshERP-web/package.json:9— `jshERP-web/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X5 · Nullable reference types· Java packages are not null-marked everywhere · ×1
Java packages are not null-marked everywhere — 0/10 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1e587-90ef-7974-ba74-60de2696f8d6 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 84 · Warnings: 452 · Recommendations: 47 · Info: 117 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 16-11-2026 @ 18:03 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.