Public report of fengzhizi715/Monica, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 20:12 UTC · Survey ID cd_e968f8e7c9ed4855a35fe2267215727a

fengzhizi715/Monica

Measured 17 November 2026, 20:12 UTC, at code version f110bba

First survey, so nothing to compare with yet
CAI score 54.2out of 100 Adequate
CriticalWeakAdequateStrongExemplary

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 39,362 lines of product code in 7 projects, tests not counted · Estimated rebuild effort: about 0.3 person-years · Weakest lens: Production Readiness, 41.6

Findings by how serious they are

0 critical 235 serious 231 minor

12 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 20:12 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

48of 48 dimensions measured by tools.
459of 466 findings point to an exact file and line, so you can open each one in the code. The other 7 concern the repository as a whole, such as missing documentation.
48dimensions across 6 lenses, read from 39,362 lines of product code in 7 projects.
Chapters

Executive summary

fengzhizi715/Monica falls short of our standard for production because we found no working pipeline that builds or tests changes to the code and no automated security scanning of the code, its secrets or its dependencies. It scores 54.2 out of 100 and is rated Adequate, and it has no critical findings.

Production Readiness, at 41.6, is the weakest lens and counts most in the score. The best first step for the work it takes is recording design decisions, worth about 6.4 points. Adding an automated build and test pipeline would lift Production Readiness itself, worth about 6.7 points. Raising Production Readiness to 70 would lift the score to about 62.0.

Most of the 235 serious findings are in Code Health.

The product code is 39,362 lines, about €39,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 41.6 · counts for 46%Maturity 48.1 · counts for 25%Code Health 63.2 · counts for 14%Architecture 94.1 · counts for 8%Security and Compliance 100.0 · counts for 4%Performance 100.0 · counts for 2%

If Production Readiness rose from 41.6 to 70, the lowest score rated Strong, the score would rise from 54.2 to about 62.0.

Code composition: what the lines of code are
Product code 100%Tests 0%
Rebuild cost: about €39,000 · Estimate
Cost to rebuild€13,000 to €65,000, for 216 to 685 hours of work, about 0.3 person-years for one engineer
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 54. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 39,362 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.
Raises the score by about 6.4 points · Low effort · ADR Quality
2
Resolve the 1 `setupGammaLut` spells `Lut` where 14 names in the project spell it… finding(s) in Naming Consistency — start with GammaFilter.kt.
Raises the score by about 4.8 points · Low effort · Naming Consistency
3
Add a CI workflow that builds and runs the test suite on every push/PR.
Raises the score by about 6.7 points · Medium effort · CI/CD gates

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €39,000 to build again, about 0.3 person-years of work. Its weakest lens is Production Readiness, at 41.6 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 6.4 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 6.9 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 3% to 6% on every change. The history of the code shows how much it changes: about 2,059 lines over the last 90 days, which is about 8,350 lines a year. At that pace, the extra work comes to an estimated 0.6 to 3.5 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch :config :config :domain :domain :config->:domain :i18n :i18n :i18n->:config :imageprocess :imageprocess :opencv :opencv :opencv->:config :opencv->:domain Monica Monica Monica->:config Monica->:domain Monica->:i18n Monica->:imageprocess Monica->:opencv monica-web-screenshot monica-web-screenshot

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

131 modules, with 155 dependencies between them. 5 loops run through 11 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 91 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 config.storage2 domain3 exception4 history5 i18n6 imageprocess7 ui.controlpanel.cropimage.model8 ui.controlpanel.shapedrawing.geometry9 config.category.ConfigCategoryManager10 history.modules.colorcorrection11 imageprocess.domain12 imageprocess.filter.base13 llm14 ui.controlpanel.cropimage.setting15 ui.controlpanel.shapedrawing.model16 ui.i18n17 utils18 config.category19 history.modules.colorcorrection.ColorCorrectionParams20 imageprocess.filter.blur21 state22 ui.controlpanel.cropimage.state23 ui.controlpanel.shapedrawing.model.Shape24 ui.controlpanel.shapedrawing.state25 imageprocess.filter26 imageprocess.filter.sharpen27 ui.controlpanel.ai.experiment28 ui.controlpanel.ai.experiment.viewmodel29 ui.controlpanel.colorcorrection30 ui.controlpanel.compression31 ui.controlpanel.cropimage.utils32 ui.controlpanel.filter.viewmodel33 ui.controlpanel.shapedrawing.handler34 ui.controlpanel.shapedrawing.layer35 ui.main36 ui.preview37 ui.controlpanel.cropimage38 ui.controlpanel.filter.widget39 ui.controlpanel.shapedrawing40 ui.controlpanel.shapedrawing.widget
1 config.storage
2 domain
3 exception
4 history
5 i18n
6 imageprocess
7 ui.controlpanel.cropimage.model
8 ui.controlpanel.shapedrawing.geometry
9 config.category.ConfigCategoryManager12
10 history.modules.colorcorrection2
11 imageprocess.domain1
12 imageprocess.filter.base1
13 llm5
14 ui.controlpanel.cropimage.setting8
15 ui.controlpanel.shapedrawing.model1
16 ui.i18n1
17 utils4
18 config.category11
19 history.modules.colorcorrection.ColorCorrectionParams11
20 imageprocess.filter.blur19
21 state21
22 ui.controlpanel.cropimage.state331
23 ui.controlpanel.shapedrawing.model.Shape12
24 ui.controlpanel.shapedrawing.state3
25 imageprocess.filter1371
26 imageprocess.filter.sharpen21
27 ui.controlpanel.ai.experiment4119
28 ui.controlpanel.ai.experiment.viewmodel497
29 ui.controlpanel.colorcorrection311112
30 ui.controlpanel.compression715
31 ui.controlpanel.cropimage.utils11
32 ui.controlpanel.filter.viewmodel1
33 ui.controlpanel.shapedrawing.handler11
34 ui.controlpanel.shapedrawing.layer161
35 ui.main16
36 ui.preview12
37 ui.controlpanel.cropimage28121
38 ui.controlpanel.filter.widget431
39 ui.controlpanel.shapedrawing2321217
40 ui.controlpanel.shapedrawing.widget1115112
Uses a module listed above itPart of a loopThe module itself
1 config.storage2 domain3 exception4 history5 i18n6 imageprocess7 ui.controlpanel.cropimage.model8 ui.controlpanel.shapedrawing.geometry9 config.category.ConfigCategoryManager10 history.modules.colorcorrection11 imageprocess.domain12 imageprocess.filter.base13 llm14 ui.controlpanel.cropimage.setting15 ui.controlpanel.shapedrawing.model16 ui.i18n17 utils18 config.category19 history.modules.colorcorrection.ColorCorrectionParams20 imageprocess.filter.blur21 state22 ui.controlpanel.cropimage.state23 ui.controlpanel.shapedrawing.model.Shape24 ui.controlpanel.shapedrawing.state25 imageprocess.filter26 imageprocess.filter.sharpen27 ui.controlpanel.ai.experiment28 ui.controlpanel.ai.experiment.viewmodel29 ui.controlpanel.colorcorrection30 ui.controlpanel.compression31 ui.controlpanel.cropimage.utils32 ui.controlpanel.filter.viewmodel33 ui.controlpanel.shapedrawing.handler34 ui.controlpanel.shapedrawing.layer35 ui.main36 ui.preview37 ui.controlpanel.cropimage38 ui.controlpanel.filter.widget39 ui.controlpanel.shapedrawing40 ui.controlpanel.shapedrawing.widgetconfig.storage1domain2exception3history4i18n5imageprocess6ui.controlpanel.cropimage.model7ui.controlpanel.shapedrawing.geometry8config.category.ConfigCategoryManager9history.modules.colorcorrection10imageprocess.domain11imageprocess.filter.base12llm13ui.controlpanel.cropimage.setting14ui.controlpanel.shapedrawing.model15ui.i18n16utils17config.category18history.modules.colorcorrection.ColorCorrectionParams19imageprocess.filter.blur20state21ui.controlpanel.cropimage.state22ui.controlpanel.shapedrawing.model.Shape23ui.controlpanel.shapedrawing.state24imageprocess.filter25imageprocess.filter.sharpen26ui.controlpanel.ai.experiment27ui.controlpanel.ai.experiment.viewmodel28ui.controlpanel.colorcorrection29ui.controlpanel.compression30ui.controlpanel.cropimage.utils31ui.controlpanel.filter.viewmodel32ui.controlpanel.shapedrawing.handler33ui.controlpanel.shapedrawing.layer34ui.main35ui.preview36ui.controlpanel.cropimage37ui.controlpanel.filter.widget38ui.controlpanel.shapedrawing39ui.controlpanel.shapedrawing.widget4012211581141111192133112313712141194973111127151111116116122812143123212171115112+91 more modules (most-connected shown)

At a glance — Code Health · 63.2 · Adequate · gated by D2, X4 ·

At a glance — Architecture · 94.1 · Exemplary ·

At a glance — Maturity · 48.1 · Weak · gated by D34, M2 ·

At a glance — Readiness · 41.6 · Weak · gated by P1, P3 ·

At a glance — Security · 100.0 · Exemplary ·

At a glance — Performance · 100.0 · Exemplary ·

Roadmap

Top priorities: Resolve the 177 Orphaned file finding(s) in Knowledge Freshness — start with ImageUtils.kt (2), SpecialLayerHelper.kt (2), FilterAdjustmentPanel.kt; Add a CI workflow that builds and runs the test suite on every push/PR; Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.+6.4 ptsLowADR Quality
Resolve the 1 `setupGammaLut` spells `Lut` where 14 names in the project spell it… finding(s) in Naming Consistency — start with GammaFilter.kt.+4.8 ptsLowNaming Consistency
Add a CI workflow that builds and runs the test suite on every push/PR.+6.7 ptsMediumCI/CD gates
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+5.4 ptsMediumArchitecture documentation
Resolve the 177 Orphaned file finding(s) in Knowledge Freshness — start with ImageUtils.kt (2), SpecialLayerHelper.kt (2), FilterAdjustmentPanel.kt.+8.4 ptsHighKnowledge Freshness
Interpolated log message defeats structured logging+2.0 ptsMediumStructured logging
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.+1.7 ptsMediumDocumentation (README)
Swallowed exception (caught, then discarded)+1.1 ptsMediumException handling

File quality

Per-file score 0–10 — a quality signature. Of 97 files carrying findings, judged against the Production bar: 0% slop · 45% mixed · 55% near-clean.

FileScoreBandWorst signal
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt5.9MixedCognitive Complexity: PreviewViewModel.mosaic (cognitive 21)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt5.9MixedCognitive Complexity: DoodleViewKt.drawImage (cognitive 19)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt6.0MixedExplicit Debt: TodoComment
imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt6.0MixedExplicit Debt: FixmeComment
imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Gradient.kt6.0MixedExplicit Debt: FixmeComment
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/CropStateImpl.kt6.7MixedExplicit Debt: TodoComment
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt6.7MixedExplicit Debt: TodoComment
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt7.0MixedCyclomatic Complexity: GeneralSettingsDialogKt.generalSettings (cyclomatic 25)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt7.0MixedCyclomatic Complexity: BinaryImageViewKt.binaryImage (cyclomatic 22)
imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt7.0MixedCognitive Complexity: ConvolveFilter.convolveHV (cognitive 43)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt7.0MixedGod Classes: MethodTooLong: CropImageSettingViewKt.cropFrameScrollableRow
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt7.0MixedCode Duplication: Duplicated block (12 lines × 2)
imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt7.1MixedCyclomatic Complexity: CellularFilter.checkCube (cyclomatic 27)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt7.1MixedCyclomatic Complexity: ContourAnalysisViewKt.contourAnalysis (cyclomatic 26)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt7.1MixedCode Duplication: Duplicated block (12 lines × 2)
imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt7.1MixedCyclomatic Complexity: SmearFilter.filterPixels (cyclomatic 41)
src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt7.1MixedCognitive Complexity: ImageUtilsKt.getBufferedImage (cognitive 17)
src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt7.1MixedCode Duplication: Edited copy of a member (34 corresponding lines)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt7.2MixedCyclomatic Complexity: LayerPanelKt.LayerPanel (cyclomatic 35)
src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt7.2MixedCyclomatic Complexity: FilterAdjustmentPanelKt.FilterParamSlider (cyclomatic 34)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 0

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 235

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 231

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 12

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 48 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 48 dimensions across the health lenses
D1D2D3D4D5D6D13D14D15D17D19D20D21D26D28D29D30D34D35D43D44AX10AX3AX4AX6M1M2M3M4P1P10P2P3P6PF3X1X12X13X16X18X21X23X25X27X29X3X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 459 of 466 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1eb23-5b91-7864-8f24-638f9b12333c.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — a Gradle build resolved 73 artifact(s) across its subprojects (64 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares package.json, but the licence verdict published here was taken over its JVM dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (2 contributor(s) across 1938 commit(s) sampled, automation and bot accounts excluded). One of them holds 100% of the history; the other 1 hold 0% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: it declares a published package (resources/package.json), but no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict. For npm the surface is what a published package.json's entry points (exports, main, module, types) export, followed through the source; an entry that names build output the tree does not commit (dist/, build/) is not followed back to source, because only a tsconfig outDir/rootDir pair states that mapping and a bundler's input lives in executable configuration this engine does not evaluate.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D24 compares a comment's words with the identifiers, literals and constructs of the code it annotates, using English function-word and rationale lexicons. Comments in another script or language were left unread rather than counted as clean.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `build.gradle.kts`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CarveFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorHalftoneFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/EqualizeFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GaussianNoiseFilter.kt`, … (+7 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX1 Captive dependencies — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Koin, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 81 further occurrence(s) are not listed individually; the score already reflects all 121.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity7.2 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.2 / 10 · rule-coverage 100% · ceiling Prevented

17 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ShapeDrawingViewKt.shapeDrawing at 60. A further 1 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ImageUtilsKt.doFilter at 52 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt (ImageUtilsKt.doFilter at 52). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

ShapeDrawingViewKt.shapeDrawing (cyclomatic 60)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:60
SmearFilter.filterPixels (cyclomatic 41)imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:37
LensBlurFilter.doFilter (cyclomatic 37)imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:23
LayerPanelKt.LayerPanel (cyclomatic 35)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:60
FilterAdjustmentPanelKt.FilterParamSlider (cyclomatic 34)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:368

+ 11 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 16 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with ShapeDrawingViewKt.shapeDrawing (cyclomatic 60), SmearFilter.filterPixels (cyclomatic 41), LensBlurFilter.doFilter (cyclomatic 37). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 16 together lifts Cyclomatic Complexity from 7.2 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity3.8 / 10Weak✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 3.8 / 10 · rule-coverage 100% · ceiling Prevented

45 method(s) exceeded the cognitive complexity threshold of 15; the worst was SmearFilter.filterPixels at 135.

SmearFilter.filterPixels (cognitive 135)imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:37
LensBlurFilter.doFilter (cognitive 112)imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:23
LayerPanelKt.LayerPanel (cognitive 58)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:60
ShapeDrawingViewKt.shapeDrawing (cognitive 55)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:60
GeneralSettingsDialogKt.generalSettings (cognitive 50)src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:70

+ 39 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 60 down to 60 or less in Cognitive Complexity — start with SmearFilter.filterPixels (cognitive 135), LensBlurFilter.doFilter (cognitive 112). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 3.8 to about 5.4/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.3 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.3 / 10 · rule-coverage 100% · ceiling Prevented

17 god class(es) detected.

MethodTooLong: GeneralSettingsDialogKt.generalSettings · ×13src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:70
TooManyMethods: ImageProcess · ×2opencv/src/main/kotlin/cn/netdiscovery/monica/opencv/ImageProcess.kt:16
FileTooLong: widget/FilterAdjustmentPanel.kt · ×2src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt

What to do

  1. Resolve the 13 MethodTooLong finding(s) in God Classes — start with CropImageSettingView.kt (2), GeneralSettingsDialog.kt, LayerPanel.kt. — One of this dimension's main actionable groups (13 warning-level).
  2. Resolve the 2 TooManyMethods finding(s) in God Classes — start with ImageProcess.kt, EditorController.kt. — One of this dimension's main actionable groups (2 warning-level).
  3. Resolve the 2 FileTooLong finding(s) in God Classes — start with FilterAdjustmentPanel.kt, GeneralSettingsDialog.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication6.9 / 10Adequate✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.9 / 10 · rule-coverage 100% · ceiling Verified

100 duplicated block group(s) detected. 7.9 % of the production lines (3,093 of 39,362) are in a reported copy. A further 31 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (12 lines × 2) · ×11imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:54
Duplicated block (8 lines × 2) · ×10imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:164
Duplicated block (9 lines × 2) · ×6imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:194
Duplicated block (10 lines × 2) · ×5imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ConBriFilter.kt:25
Duplicated block (14 lines × 2) · ×4src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:84

+ 73 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 11 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with MatchTemplateView.kt (2), MaximumFilter.kt, AIViewModel.kt. — One of this dimension's main actionable groups (11 warning-level).
  2. Resolve the 10 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with ImageUtils.kt, BinaryImageView.kt, ContourAnalysisView.kt. — One of this dimension's main actionable groups (10 warning-level).
  3. Resolve the 6 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with CellularFilter.kt, ImageCompressionUtils.kt, ImageDenoisingView.kt. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling7.7 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 7.7 / 10 · rule-coverage 100% · ceiling Prevented

7 production modules (Gradle+npm), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 2 module(s) off the main sequence, with abstractness counted on 6 of the 7 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: :domain · ×2

What to do

  1. Resolve the 2 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.6 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

2 of 67 classes have LCOM4 above 3.

Low cohesion: PreviewViewModel (LCOM4 8) · ×2src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:42

What to do

  1. Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with PreviewViewModel.kt, ApplicationState.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 7 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 6 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 28 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 2 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict. ★ COVERAGE OF THIS VERDICT: it grades this repository's JVM dependencies and nothing else. The repository also declares package.json, and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt10.0 / 10Stronggated by 10 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

10 deducted task-comment markers across 39362 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×8src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:205
FixmeComment · ×2imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:51

What to do

  1. Resolve the 8 TodoComment finding(s) in Explicit Debt — start with ShapeDrawingView.kt (2), ImageLayerControlRenderer.kt, FilterView.kt. — One of this dimension's main actionable groups (8 warning-level).
  2. Resolve the 2 FixmeComment finding(s) in Explicit Debt — start with LensBlurFilter.kt, Gradient.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2 of 2 documentation facets pass in full. 7 document(s) read across 7 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundbuild.gradle.kts:561

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency3.3 / 10Weak✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 3.3 / 10 · rule-coverage 100% · ceiling Verified

1 naming inconsistencies among 15 declarations measured against a convention their peers follow.

`setupGammaLut` spells `Lut` where 14 names in the project spell it `LUT`imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GammaFilter.kt:23

What to do

  1. Resolve the 1 `setupGammaLut` spells `Lut` where 14 names in the project spell it… finding(s) in Naming Consistency — start with GammaFilter.kt. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion7.1 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.1 / 10 · rule-coverage 100% · ceiling Documented

1 of 7 build units (Gradle, npm) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesionbuild.gradle.kts:1

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with build.gradle.kts. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)10.0 / 10Exemplary○ Nothing flagged

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

semgrep found no security issues. semgrep hit a parse error in 2 file(s) — `build.gradle.kts` (line 53, line 54), `gradlew` (line 72, line 173) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

✓ On the Gold path — maintain.

Detailed fixes: d29_recommendation.md.

D30 · Dependency Vulnerabilities10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No known-vulnerable dependencies in any ecosystem this repository declares.

✓ On the Gold path — maintain.

Detailed fixes: d30_recommendation.md.

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

180 of 180 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/model/ColorNameMap.kt. Counted over 180 of the 321 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×177src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:1
Most significant orphaned file · ×3src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/model/ColorNameMap.kt:1
Dormant codebase

What to do

  1. Resolve the 177 Orphaned file finding(s) in Knowledge Freshness — start with ImageUtils.kt (2), SpecialLayerHelper.kt (2), FilterAdjustmentPanel.kt. — One of this dimension's main actionable groups (177 recommendation-level).
  2. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with ColorNameMap.kt, GeneralSettingsDialog.kt, ShapeDrawingView.kt. — One of this dimension's main actionable groups (3 recommendation-level).
  3. Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.8 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: DoodleView.kt↔ColorSelectionDialog.kt 58%; ShapeDrawingView.kt↔ShapeDrawingViewModel.kt 54%; CropImageView.kt↔ImageCropper.kt 50%

Change coupling: DoodleView.kt ↔ ColorSelectionDialog.kt · ×3src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:1

What to do

  1. Resolve the 3 Change coupling finding(s) in Change Coupling — start with DoodleView.kt, ShapeDrawingView.kt, CropImageView.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 6 platform declaration(s) and 12 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.7 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

M1 · Documentation (README)6.3 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.

What to do

  • Add a CI workflow that builds and runs the test suite on every push/PR.
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
  • `resources/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — resources/package.json:9

What to do

  • Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×8) — src/jvmMain/kotlin/Main.kt:413, src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:57, src/jvmMain/kotlin/cn/netdiscovery/monica/utils/extensions/String+Extensions.kt:23, …
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:67

What to do

  • Swallowed exception (caught, then discarded)
X4 · Structured logging3.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `info` at line 221 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/Main.kt:221
  • `info` at line 302 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/Main.kt:302
  • `info` at line 388 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/Main.kt:388
  • `info` at line 402 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/Main.kt:402
  • `info` at line 39 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/FileChoose.kt:39
  • `error` at line 380 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:380
  • `error` at line 411 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:411
  • `info` at line 40 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:40
  • `info` at line 100 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:100
  • `error` at line 47 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ScreenshotUtils.kt:47
  • `debug` at line 92 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:92
  • `info` at line 306 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:306
  • `info` at line 323 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:323
  • `info` at line 342 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:342
  • `debug` at line 345 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:345
  • `info` at line 393 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:393
  • `info` at line 404 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:404
  • `debug` at line 459 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:459
  • `warn` at line 514 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:514
  • `info` at line 541 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:541
  • `info` at line 562 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:562
  • `debug` at line 583 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:583
  • `error` at line 610 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:610
  • `info` at line 641 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:641
  • `info` at line 38 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/extensions/Any+Extensions.kt:38
  • `info` at line 94 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/Buttons.kt:94
  • `warn` at line 46 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:46
  • `debug` at line 71 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:71
  • `info` at line 32 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:32
  • `warn` at line 107 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:107
  • `info` at line 175 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/screenshot/SwingScreenshotAreaSelector.kt:175
  • `info` at line 186 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/screenshot/SwingScreenshotAreaSelector.kt:186
  • `info` at line 245 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/screenshot/SwingScreenshotAreaSelector.kt:245
  • `info` at line 58 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:58
  • `info` at line 196 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/SidebarView.kt:196
  • `info` at line 29 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/webscreenshot/WebScreenshotViewModel.kt:29
  • `info` at line 98 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/CoordinateSystem.kt:98
  • `info` at line 500 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:500
  • `warn` at line 505 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:505
  • `info` at line 583 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:583

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types9.5 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health63.2Adequate — gated by D2, X4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture94.1ExemplarySolid.
Maturity48.1Weak — gated by D34, M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness41.6Weak — gated by P1, P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security100.0ExemplaryStrongest area.
Performance100.0ExemplarySolid.
Unscored — 1 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 67 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~161 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D12 Dependency Hygiene — Not scored — a Gradle build resolved 73 artifact(s) across its subprojects (64 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — 9 of 9 comment blocks were not judged (9 in a non-Latin script): redundancy is judged by word overlap with the code's identifiers, which cannot be measured across languages.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 12 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 35 value object(s); a Domain/Aggregates/ValueObjects layer
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — no CI workflow found
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, JavaScript/TypeScript source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X2 Cancellation propagation — no C# was loaded; this repository's Kotlin was read, and no request in it can be cancelled by a caller (Ktor, OkHttp's newCall or a URL stream, from a suspend function) — a Kotlin request outside a suspend function has no caller's cancellation to honour
  • X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X30 Support guard that admits what it rejects — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Serious — 235 finding(s)
D3 · God Classes · MethodTooLong · ×13
  • MethodTooLong: GeneralSettingsDialogKt.generalSettings src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:70 — MethodTooLong — generalSettings runs 496 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 396 over it, 4.96× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LayerPanelKt.LayerPanel src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:60 — MethodTooLong — LayerPanel runs 298 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 198 over it, 2.98× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ImageUtilsKt.doFilter src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:139 — MethodTooLong — doFilter runs 191 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 91 over it, 1.91× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FilterAdjustmentPanelKt.FilterParamSlider src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:368 — MethodTooLong — FilterParamSlider runs 176 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 76 over it, 1.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CropImageSettingViewKt.cropFrameScrollableRow src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:275 — MethodTooLong — cropFrameScrollableRow runs 171 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 71 over it, 1.71× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WebScreenshotViewKt.webScreenshot src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/webscreenshot/WebScreenshotView.kt:29 — MethodTooLong — webScreenshot runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LensBlurFilter.doFilter imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:23 — MethodTooLong — doFilter runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: NaturalLanguageDialogKt.NaturalLanguageDialog src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/NaturalLanguageDialog.kt:35 — MethodTooLong — NaturalLanguageDialog runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CompressionInputSectionKt.CompressionInputSection src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionInputSection.kt:18 — MethodTooLong — CompressionInputSection runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CropImageSettingViewKt.aspectRatioScrollableRow src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:111 — MethodTooLong — aspectRatioScrollableRow runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SmearFilter.filterPixels imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:37 — MethodTooLong — filterPixels runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FilterPreviewAreaKt.FilterPreviewArea src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterPreviewArea.kt:29 — MethodTooLong — FilterPreviewArea runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ShapeAnimationManager.drawAnimationHighlight src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:144 — MethodTooLong — drawAnimationHighlight runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×11
  • Duplicated block (12 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:54 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:54-65 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MinimumFilter.kt:53-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:54` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:39 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:39-50 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:64-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:39` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:73 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:73-84 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:105-116 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:73` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:94 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:94-105 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:85-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:94` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ShapeLayer.kt:96 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ShapeLayer.kt:96-112 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/state/ShapeDrawingState.kt:247-258 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:52 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:52-63 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:102-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageSizeCalculator.kt:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:133 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:133-144 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:199-210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:133` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/helper/SpecialLayerHelper.kt:45 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/helper/SpecialLayerHelper.kt:45-57 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/SpecialLayerHelper.kt:42-53 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:418 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:418-429 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:433-445 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:418` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:372 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:372-383 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:492-503 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:372` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:199 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:199-210 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:128-139 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:199` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×10
  • Duplicated block (8 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:164 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:164-171 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:181-188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:164` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:68 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:68-75 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:64-71 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:68` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:44 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:44-51 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:48-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:44` calls `mutableStateOf` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:42` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:148 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:148-158 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:172-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:148` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:62 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:62-69 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:70-77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/IntIntegralImage.kt:57 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/IntIntegralImage.kt:57-64 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/IntIntegralImage.kt:84-91 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/IntIntegralImage.kt:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/AIServiceErrorHandler.kt:15 — src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/AIServiceErrorHandler.kt:15-22 | src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/NetworkErrorHandler.kt:15-22 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/FileIOErrorHandler.kt:15 — src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/FileIOErrorHandler.kt:15-22 | src/jvmMain/kotlin/cn/netdiscovery/monica/exception/handlers/ImageProcessingErrorHandler.kt:15-22 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:36 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:36-43 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:69-76 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:36` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:232 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:232-239 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:251-258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:232` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D17 · Explicit Debt · TodoComment · ×8
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:205 — // TODO: 添加右键检测逻辑 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:371 — // TODO: 实现裁剪控制点的拖动逻辑 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/ImageLayerControlRenderer.kt:227 — // TODO: 完善裁剪控制点的计算,考虑所有变换 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/FilterView.kt:92 — // TODO: 实现导出功能 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/CropStateImpl.kt:285 — // TODO Add resetting back to bounds for rotated state as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt:271 — // TODO Change pan when zoom is bigger than 1f and touchRegion is inside overlay rect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/jvmMain/kotlin/cn/netdiscovery/monica/http/HttpClient.kt:57 — // TODO: 发布到生产环境需要改成false — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorHalftoneFilter.kt:63 — // TODO: Efficiency warning: Because the dots overlap, we need to check neighbouring grid squares. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×8
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/Main.kt:413 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:57 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/extensions/String+Extensions.kt:23 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:407 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/EditorController.kt:153 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/model/ColorData.kt:26 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/model/ColorData.kt:37 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) config/src/main/kotlin/cn/netdiscovery/monica/config/category/ConfigValidator.kt:107 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×6
  • Duplicated block (9 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:194 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:194-202 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:203-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:194` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:123 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:123-131 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:185-195 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:103 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:103-111 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:108-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:103` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:161 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:161-169 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:179-187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:161` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:208 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:208-216 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:232-240 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:208` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:194 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:194-202 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:208-216 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:194` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×5
  • Duplicated block (10 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ConBriFilter.kt:25 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ConBriFilter.kt:25-34 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ConBriFilter.kt:46-55 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ConBriFilter.kt:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:173 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:173-182 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:218-227 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:173` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:85 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:85-94 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:121-130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:85` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:133` calls `create`, `drawImage` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:97` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:61 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:61-70 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:113-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:61` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:225 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:225-234 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:280-289 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:225` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×4
  • Duplicated block (14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:84 — src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:84-97 | src/jvmMain/kotlin/cn/netdiscovery/monica/llm/GeminiClient.kt:88-101 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:94 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:94-107 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:145-158 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:94` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/viewmodel/FilterViewModel.kt:138 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/viewmodel/FilterViewModel.kt:138-151 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/viewmodel/FilterViewModel.kt:213-226 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:221 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:221-234 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:271-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:221` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×4
  • Duplicated block (7 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:56 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:56-62 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:48-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:242 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:242-248 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:191-198 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:242` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:252` calls `size` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:202` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:73 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:73-79 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:57-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:73` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/TransformFilter.kt:152 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/TransformFilter.kt:152-158 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/TransformFilter.kt:191-197 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×4
  • Duplicated block (6 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:259 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:259-264 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:265-270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:259` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:219 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:219-224 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:225-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:219` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:89 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:89-94 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:69-74 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:334 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:334-339 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:365-370 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:334` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D35 · Change Coupling · Change coupling · ×3
  • Change coupling: DoodleView.kt ↔ ColorSelectionDialog.kt src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:1 — `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/color/ColorSelectionDialog.kt` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `ef5303a2` update; `ec6698c7` update (at that commit the file was still `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/widget/ColorSelectionDialog.kt`); `9f9b28b6` update (at that commit the file was still `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/ColorSelectionDialog.kt`) — run `git show` on any of them.
  • Change coupling: ShapeDrawingView.kt ↔ ShapeDrawingViewModel.kt src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:1 — `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingViewModel.kt` change together 54% of the time (14 of the 26 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 14 shared commits counted here, the most recent 3 are `d7df32ac` update; `db341586` update; `2176a744` update — run `git show` on any of them.
  • Change coupling: CropImageView.kt ↔ ImageCropper.kt src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageView.kt:1 — `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/ImageCropper.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `4434489a` update (at that commit the files were still `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/CropImageView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/ImageCropper.kt`); `21912af2` update (at that commit the files were still `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/CropImageView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/ImageCropper.kt`); `ec8b9dab` update (at that commit the files were still `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/CropImageView.kt` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/crop/cropimage/ImageCropper.kt`) — run `git show` on any of them.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (4 members, 50+ identical tokens) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:23 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:23-110 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GammaFilter.kt:29-56 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SepiaToneFilter.kt:18-44 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SpotlightFilter.kt:17-49 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:140 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:140-182 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:202-239 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:259-294 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/GaussianFilter.kt:88-142 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44-351 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:40-296 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:41-267 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:40-215 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:58 — src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:58-68 | src/jvmMain/kotlin/cn/netdiscovery/monica/llm/GeminiClient.kt:63-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:58` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:78 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:78-88 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:93-103 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:78` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:106` calls `Column`, `padding`, `subTitleWithDivider` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:90` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:107 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:107-118 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:182-192 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:107` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D17 · Explicit Debt · FixmeComment · ×2
  • FixmeComment imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:51 — // FIXME - tileWidth, w, 和 cols 始终相同 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Gradient.kt:350 — //FIXME-alpha — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D3 · God Classes · TooManyMethods · ×2
  • TooManyMethods: ImageProcess opencv/src/main/kotlin/cn/netdiscovery/monica/opencv/ImageProcess.kt:16 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: EditorController src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/EditorController.kt:34 — TooManyMethods — 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · FileTooLong · ×2
  • FileTooLong: widget/FilterAdjustmentPanel.kt src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt — FileTooLong — 587 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 87 over it, 1.17× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: main/GeneralSettingsDialog.kt src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt — FileTooLong — 554 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 54 over it, 1.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×2
  • Edited copy of a member (33 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:16 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:16-48 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/sharpen/USMFilter.kt:18-57 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (33 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/CropStateImpl.kt:356 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/CropStateImpl.kt:356-388 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt:314-346 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×2
  • Edited copy of a member (17 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:346 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:346-362 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:369-389 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorFilter.kt:21 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorFilter.kt:21-37 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/NatureFilter.kt:50-66 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×2
  • Edited copy of a member (11 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:70 — src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:70-80 | src/jvmMain/kotlin/cn/netdiscovery/monica/llm/GeminiClient.kt:75-85 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/PosterizeFilter.kt:23 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/PosterizeFilter.kt:23-33 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/TransferFilter.kt:35-49 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×2
  • Edited copy of a member (10 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/BaseFilter.kt:44 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/BaseFilter.kt:44-53 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/BaseFilter.kt:59-68 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:261 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:261-270 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:41-50 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×2
  • Duplicated block (21 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/ColorPickView.kt:56 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/ColorPickView.kt:56-76 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:92-112 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/ColorPickView.kt:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:155 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:155-175 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:303-323 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:153` calls `Box`, `fillMaxSize`, `padding` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:302` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×2
  • Duplicated block (20 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:154 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:154-173 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:87-106 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:154` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:212 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:212-231 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:71-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:212` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×2
  • Duplicated block (13–14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:269 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:269-282 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:514-526 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:269` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13–14 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:53 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:53-65 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:68-81 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ThemeManager.kt:53` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×2
  • Duplicated block (13 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:45 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:45-57 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:73-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:169 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:169-181 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:78-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:169` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×2
  • Duplicated block (11–12 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:27 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:27-37 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/sharpen/USMFilter.kt:30-41 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:27` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11–12 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionViewModel.kt:124 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionViewModel.kt:124-135 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionViewModel.kt:139-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionViewModel.kt:124` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:175 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:175-182 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:232-239 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:287-294 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:175` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:119 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:119-126 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:151-158 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:183-190 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:119` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×2
  • Duplicated block (6 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:233 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:233-239 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:240-245 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:252-258 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:233` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 3) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:18 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/HighPassFilter.kt:18-23 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/GaussianFilter.kt:57-62 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/sharpen/USMFilter.kt:19-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×2
  • Duplicated block (5 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:320 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:320-324 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:328-333 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:167-171 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:320` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:88 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:88-92 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:152-156 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:184-188 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:88` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D5 · Coupling · Off the main sequence · ×2
  • Off the main sequence: :domain — :domain: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
  • Off the main sequence: :imageprocess — :imageprocess: abstractness 0.11, instability 0.00, distance 0.89 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
D6 · Cohesion (LCOM4) · Low cohesion · ×2
  • Low cohesion: PreviewViewModel (LCOM4 8) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:42 — PreviewViewModel's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ApplicationState (LCOM4 4) src/jvmMain/kotlin/cn/netdiscovery/monica/state/ApplicationState.kt:65 — ApplicationState's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
D1 · Cyclomatic Complexity · ShapeDrawingViewKt.shapeDrawing (cyclomatic 60) · ×1
  • ShapeDrawingViewKt.shapeDrawing (cyclomatic 60) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:60 — ShapeDrawingViewKt.shapeDrawing has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SmearFilter.filterPixels (cyclomatic 41) · ×1
  • SmearFilter.filterPixels (cyclomatic 41) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:37 — SmearFilter.filterPixels has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LensBlurFilter.doFilter (cyclomatic 37) · ×1
  • LensBlurFilter.doFilter (cyclomatic 37) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:23 — LensBlurFilter.doFilter has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LayerPanelKt.LayerPanel (cyclomatic 35) · ×1
  • LayerPanelKt.LayerPanel (cyclomatic 35) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:60 — LayerPanelKt.LayerPanel has cyclomatic complexity 35 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FilterAdjustmentPanelKt.FilterParamSlider (cyclomatic 34) · ×1
  • FilterAdjustmentPanelKt.FilterParamSlider (cyclomatic 34) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:368 — FilterAdjustmentPanelKt.FilterParamSlider has cyclomatic complexity 34 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MainKt.main (cyclomatic 30) · ×1
  • MainKt.main (cyclomatic 30) src/jvmMain/kotlin/Main.kt:77 — MainKt.main has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ImageFormatDetector.detectFormat (cyclomatic 28) · ×1
  • ImageFormatDetector.detectFormat (cyclomatic 28) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageFormatDetector.kt:30 — ImageFormatDetector.detectFormat has cyclomatic complexity 28 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · CellularFilter.checkCube (cyclomatic 27) · ×1
  • CellularFilter.checkCube (cyclomatic 27) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:96 — CellularFilter.checkCube has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ContourAnalysisViewKt.contourAnalysis (cyclomatic 26) · ×1
  • ContourAnalysisViewKt.contourAnalysis (cyclomatic 26) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:40 — ContourAnalysisViewKt.contourAnalysis has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GeneralSettingsDialogKt.generalSettings (cyclomatic 25) · ×1
  • GeneralSettingsDialogKt.generalSettings (cyclomatic 25) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:70 — GeneralSettingsDialogKt.generalSettings has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BinaryImageViewKt.binaryImage (cyclomatic 22) · ×1
  • BinaryImageViewKt.binaryImage (cyclomatic 22) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44 — BinaryImageViewKt.binaryImage has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EdgeDetectionViewKt.edgeDetection (cyclomatic 20) · ×1
  • EdgeDetectionViewKt.edgeDetection (cyclomatic 20) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:41 — EdgeDetectionViewKt.edgeDetection has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NaturalLanguageDialogKt.NaturalLanguageDialog (cyclomatic 19) · ×1
  • NaturalLanguageDialogKt.NaturalLanguageDialog (cyclomatic 19) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/NaturalLanguageDialog.kt:35 — NaturalLanguageDialogKt.NaturalLanguageDialog has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · RxCacheConfigStorage.load (cyclomatic 19) · ×1
  • RxCacheConfigStorage.load (cyclomatic 19) config/src/main/kotlin/cn/netdiscovery/monica/config/storage/RxCacheConfigStorage.kt:40 — RxCacheConfigStorage.load has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · web-screenshot.captureScreenshot (cyclomatic 19) · ×1
  • web-screenshot.captureScreenshot (cyclomatic 19) resources/web-screenshot.js:155 — web-screenshot.captureScreenshot has cyclomatic complexity 19 (threshold 15). Of this number, 13 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · Gradient.rebuildGradient (cyclomatic 17) · ×1
  • Gradient.rebuildGradient (cyclomatic 17) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Gradient.kt:305 — Gradient.rebuildGradient has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · SmearFilter.filterPixels (cognitive 135) · ×1
  • SmearFilter.filterPixels (cognitive 135) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:37 — SmearFilter.filterPixels has cognitive complexity 135 (threshold 15). Drivers by points: if/else 32 (98 pts), loops 11 (30 pts), boolean chains 6, match/switch 1 (nesting depth added 85). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LensBlurFilter.doFilter (cognitive 112) · ×1
  • LensBlurFilter.doFilter (cognitive 112) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/LensBlurFilter.kt:23 — LensBlurFilter.doFilter has cognitive complexity 112 (threshold 15). Drivers by points: if/else 25 (71 pts), loops 14 (32 pts), match/switch 2 (9 pts) (nesting depth added 71). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LayerPanelKt.LayerPanel (cognitive 58) · ×1
  • LayerPanelKt.LayerPanel (cognitive 58) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:60 — LayerPanelKt.LayerPanel has cognitive complexity 58 (threshold 15). Drivers by points: if/else 41 (49 pts), boolean chains 6, match/switch 2, error handling 1 (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ShapeDrawingViewKt.shapeDrawing (cognitive 55) · ×1
  • ShapeDrawingViewKt.shapeDrawing (cognitive 55) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:60 — ShapeDrawingViewKt.shapeDrawing has cognitive complexity 55 (threshold 15). Drivers by points: if/else 30 (40 pts), boolean chains 11, match/switch 3 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GeneralSettingsDialogKt.generalSettings (cognitive 50) · ×1
  • GeneralSettingsDialogKt.generalSettings (cognitive 50) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:70 — GeneralSettingsDialogKt.generalSettings has cognitive complexity 50 (threshold 15). Drivers by points: if/else 33 (47 pts), error handling 1 (2 pts), match/switch 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CellularFilter.checkCube (cognitive 46) · ×1
  • CellularFilter.checkCube (cognitive 46) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:96 — CellularFilter.checkCube has cognitive complexity 46 (threshold 15). Drivers by points: if/else 19 (39 pts), match/switch 3 (6 pts), loops 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConvolveFilter.convolveHV (cognitive 43) · ×1
  • ConvolveFilter.convolveHV (cognitive 43) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:132 — ConvolveFilter.convolveHV has cognitive complexity 43 (threshold 15). Drivers by points: if/else 11 (31 pts), loops 4 (10 pts), boolean chains 2 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GaussianFilter.convolveAndTranspose (cognitive 43) · ×1
  • GaussianFilter.convolveAndTranspose (cognitive 43) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/GaussianFilter.kt:78 — GaussianFilter.convolveAndTranspose has cognitive complexity 43 (threshold 15). Drivers by points: if/else 11 (36 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilterAdjustmentPanelKt.FilterParamSlider (cognitive 40) · ×1
  • FilterAdjustmentPanelKt.FilterParamSlider (cognitive 40) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:368 — FilterAdjustmentPanelKt.FilterParamSlider has cognitive complexity 40 (threshold 15). Drivers by points: if/else 20 (26 pts), match/switch 6 (9 pts), boolean chains 4, loops 1 (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ContourAnalysisViewKt.contourAnalysis (cognitive 38) · ×1
  • ContourAnalysisViewKt.contourAnalysis (cognitive 38) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:40 — ContourAnalysisViewKt.contourAnalysis has cognitive complexity 38 (threshold 15). Drivers by points: if/else 22 (34 pts), boolean chains 4 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransformGesturesKt.detectTransformGestures (cognitive 35) · ×1
  • TransformGesturesKt.detectTransformGestures (cognitive 35) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/TransformGestures.kt:21 — TransformGesturesKt.detectTransformGestures has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (30 pts), boolean chains 4, loops 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Gradient.rebuildGradient (cognitive 35) · ×1
  • Gradient.rebuildGradient (cognitive 35) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Gradient.kt:305 — Gradient.rebuildGradient has cognitive complexity 35 (threshold 15). Drivers by points: if/else 6 (23 pts), match/switch 2 (8 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BinaryImageViewKt.binaryImage (cognitive 34) · ×1
  • BinaryImageViewKt.binaryImage (cognitive 34) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44 — BinaryImageViewKt.binaryImage has cognitive complexity 34 (threshold 15). Drivers by points: if/else 19 (28 pts), boolean chains 6 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GradientFilter.doFilter (cognitive 34) · ×1
  • GradientFilter.doFilter (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GradientFilter.kt:30 — GradientFilter.doFilter has cognitive complexity 34 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 4 (10 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConvolveFilter.convolveH (cognitive 34) · ×1
  • ConvolveFilter.convolveH (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:194 — ConvolveFilter.convolveH has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (28 pts), loops 3 (6 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConvolveFilter.convolveV (cognitive 34) · ×1
  • ConvolveFilter.convolveV (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:251 — ConvolveFilter.convolveV has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (28 pts), loops 3 (6 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MaximumFilter.doColorProcessor (cognitive 34) · ×1
  • MaximumFilter.doColorProcessor (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:18 — MaximumFilter.doColorProcessor has cognitive complexity 34 (threshold 15). Drivers by points: if/else 8 (24 pts), loops 4 (10 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MinimumFilter.doColorProcessor (cognitive 34) · ×1
  • MinimumFilter.doColorProcessor (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MinimumFilter.kt:17 — MinimumFilter.doColorProcessor has cognitive complexity 34 (threshold 15). Drivers by points: if/else 8 (24 pts), loops 4 (10 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VariableBlurFilter.blur (cognitive 34) · ×1
  • VariableBlurFilter.blur (cognitive 34) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/VariableBlurFilter.kt:39 — VariableBlurFilter.blur has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (29 pts), loops 3 (5 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OilPaintFilter.doFilter (cognitive 33) · ×1
  • OilPaintFilter.doFilter (cognitive 33) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/OilPaintFilter.kt:17 — OilPaintFilter.doFilter has cognitive complexity 33 (threshold 15). Drivers by points: loops 7 (17 pts), if/else 3 (14 pts), boolean chains 2 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · StrokeAreaFilter.doFilter (cognitive 31) · ×1
  • StrokeAreaFilter.doFilter (cognitive 31) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/StrokeAreaFilter.kt:19 — StrokeAreaFilter.doFilter has cognitive complexity 31 (threshold 15). Drivers by points: if/else 4 (20 pts), loops 5 (11 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CompressionInputSectionKt.CompressionInputSection (cognitive 30) · ×1
  • CompressionInputSectionKt.CompressionInputSection (cognitive 30) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionInputSection.kt:18 — CompressionInputSectionKt.CompressionInputSection has cognitive complexity 30 (threshold 15). Drivers by points: if/else 14 (27 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NaturalLanguageDialogKt.NaturalLanguageDialog (cognitive 25) · ×1
  • NaturalLanguageDialogKt.NaturalLanguageDialog (cognitive 25) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/NaturalLanguageDialog.kt:35 — NaturalLanguageDialogKt.NaturalLanguageDialog has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 4 (9 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FastBlur2D.processSingleChannel (cognitive 25) · ×1
  • FastBlur2D.processSingleChannel (cognitive 25) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/FastBlur2D.kt:64 — FastBlur2D.processSingleChannel has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (22 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BilateralFilter.doFilter (cognitive 24) · ×1
  • BilateralFilter.doFilter (cognitive 24) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:23 — BilateralFilter.doFilter has cognitive complexity 24 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 4 (10 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MotionFilter.doFilter (cognitive 24) · ×1
  • MotionFilter.doFilter (cognitive 24) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MotionFilter.kt:21 — MotionFilter.doFilter has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EdgeDetectionViewKt.edgeDetection (cognitive 23) · ×1
  • EdgeDetectionViewKt.edgeDetection (cognitive 23) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:41 — EdgeDetectionViewKt.edgeDetection has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 3, match/switch 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MainKt.main (cognitive 22) · ×1
  • MainKt.main (cognitive 22) src/jvmMain/kotlin/Main.kt:77 — MainKt.main has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (15 pts), match/switch 2 (4 pts), error handling 2, boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ColorTheme.getThemeDisplayName (cognitive 22) · ×1
  • ColorTheme.getThemeDisplayName (cognitive 22) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/theme/ColorTheme.kt:143 — ColorTheme.getThemeDisplayName has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (21 pts), match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PreviewViewModel.mosaic (cognitive 21) · ×1
  • PreviewViewModel.mosaic (cognitive 21) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:119 — PreviewViewModel.mosaic has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VignetteFilter.doFilter (cognitive 21) · ×1
  • VignetteFilter.doFilter (cognitive 21) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/VignetteFilter.kt:23 — VignetteFilter.doFilter has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · web-screenshot.captureScreenshot (cognitive 21) · ×1
  • web-screenshot.captureScreenshot (cognitive 21) resources/web-screenshot.js:155 — web-screenshot.captureScreenshot has cognitive complexity 21 (threshold 15). Drivers by points: boolean chains 10, if/else 6 (7 pts), error handling 2 (3 pts), ternaries 1 (nesting depth added 2). Of this number, 15 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ImageLayer.render (cognitive 20) · ×1
  • ImageLayer.render (cognitive 20) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ImageLayer.kt:57 — ImageLayer.render has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageCompressionUtils.compressPNG (cognitive 20) · ×1
  • ImageCompressionUtils.compressPNG (cognitive 20) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:160 — ImageCompressionUtils.compressPNG has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Histogram.<init> (cognitive 20) · ×1
  • Histogram.<init> (cognitive 20) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Histogram.kt:30 — Histogram.<init> has cognitive complexity 20 (threshold 15). Drivers by points: loops 7 (11 pts), if/else 3 (8 pts), boolean chains 1 (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · DoodleViewKt.drawImage (cognitive 19) · ×1
  • DoodleViewKt.drawImage (cognitive 19) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:46 — DoodleViewKt.drawImage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 3 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · PreviewViewModel.saveImage (cognitive 18) · ×1
  • PreviewViewModel.saveImage (cognitive 18) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:251 — PreviewViewModel.saveImage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 1, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CellularFilter.evaluate (cognitive 18) · ×1
  • CellularFilter.evaluate (cognitive 18) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:222 — CellularFilter.evaluate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (16 pts), loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageUtilsKt.getBufferedImage (cognitive 17) · ×1
  • ImageUtilsKt.getBufferedImage (cognitive 17) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:35 — ImageUtilsKt.getBufferedImage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (10 pts), error handling 2 (5 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WebScreenshotUtilsKt.captureWebPage (cognitive 17) · ×1
  • WebScreenshotUtilsKt.captureWebPage (cognitive 17) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:473 — WebScreenshotUtilsKt.captureWebPage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (12 pts), boolean chains 3, error handling 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · BlockFilter.doFilter (cognitive 17) · ×1
  • BlockFilter.doFilter (cognitive 17) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BlockFilter.kt:22 — BlockFilter.doFilter has cognitive complexity 17 (threshold 15). Drivers by points: loops 6 (17 pts) (nesting depth added 11). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ColorCorrectionViewModel.save (cognitive 16) · ×1
  • ColorCorrectionViewModel.save (cognitive 16) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionViewModel.kt:103 — ColorCorrectionViewModel.save has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CompressionViewModel.compressSingleImageToPreview (cognitive 16) · ×1
  • CompressionViewModel.compressSingleImageToPreview (cognitive 16) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionViewModel.kt:110 — CompressionViewModel.compressSingleImageToPreview has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 4, error handling 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShapeDrawingEventHandler.determineRectangleCoordinates (cognitive 16) · ×1
  • ShapeDrawingEventHandler.determineRectangleCoordinates (cognitive 16) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/handler/ShapeDrawingEventHandler.kt:251 — ShapeDrawingEventHandler.determineRectangleCoordinates has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 4 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:44-351 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:41-267 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:40-196 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:40-215 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:60-163 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (48 corresponding lines) · ×1
  • Edited copy of a member (48 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:18 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:18-65 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MinimumFilter.kt:17-64 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×1
  • Edited copy of a member (25 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CrystallizeFilter.kt:23 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CrystallizeFilter.kt:23-47 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/PointillizeFilter.kt:24-49 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (43 corresponding lines) · ×1
  • Edited copy of a member (43 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:35 — src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:35-93 | src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:95-137 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (41 corresponding lines) · ×1
  • Edited copy of a member (41 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:156 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:156-197 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/BasicView.kt:201-241 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (34 corresponding lines) · ×1
  • Edited copy of a member (34 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:35 — src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:35-68 | src/jvmMain/kotlin/cn/netdiscovery/monica/llm/GeminiClient.kt:35-73 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (54 corresponding lines) · ×1
  • Edited copy of a member (54 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:28 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:28-81 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:134-189 — These two members are one piece of code written twice and then edited apart: 54 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×1
  • Edited copy of a member (16 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:163 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:163-178 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/utils/ImageUtils.kt:180-200 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:27 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:27-50 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:52-75 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×1
  • Edited copy of a member (21 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/handler/ShapeDrawingEventHandler.kt:96 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/handler/ShapeDrawingEventHandler.kt:96-116 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/handler/ShapeDrawingEventHandler.kt:229-249 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×1
  • Edited copy of a member (18 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/LayerManager.kt:96 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/LayerManager.kt:96-113 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/LayerManager.kt:228-246 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapViewModel.kt:49 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapViewModel.kt:49-70 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonViewModel.kt:26-48 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×1
  • Edited copy of a member (15 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:82 — src/jvmMain/kotlin/cn/netdiscovery/monica/llm/DeepseekClient.kt:82-97 | src/jvmMain/kotlin/cn/netdiscovery/monica/llm/GeminiClient.kt:87-101 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×1
  • Edited copy of a member (9 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/DiffuseFilter.kt:27 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/DiffuseFilter.kt:27-35 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/MarbleFilter.kt:29-37 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×1
  • Edited copy of a member (5 corresponding lines) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ColorProcessorFilter.kt:50 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ColorProcessorFilter.kt:50-54 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ColorProcessorFilter.kt:56-62 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×1
  • Edited copy of a member (19 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ShapeLayer.kt:95 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ShapeLayer.kt:95-113 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/state/ShapeDrawingState.kt:245-266 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) domain/src/main/kotlin/cn/netdiscovery/monica/domain/DecodedPreviewImage.kt:17 — domain/src/main/kotlin/cn/netdiscovery/monica/domain/DecodedPreviewImage.kt:17-29 | domain/src/main/kotlin/cn/netdiscovery/monica/domain/NativeImage.kt:16-27 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/BufferedImages.kt:15-24 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×1
  • Edited copy of a member (20 corresponding lines) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt:211 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt:211-233 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/StaticCropState.kt:82-101 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 8+ corresponding lines) config/src/main/kotlin/cn/netdiscovery/monica/config/storage/FileConfigStorage.kt:121 — config/src/main/kotlin/cn/netdiscovery/monica/config/storage/FileConfigStorage.kt:121-129 | config/src/main/kotlin/cn/netdiscovery/monica/config/storage/PreferencesConfigStorage.kt:83-91 | config/src/main/kotlin/cn/netdiscovery/monica/config/storage/RxCacheConfigStorage.kt:92-99 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) config/src/main/kotlin/cn/netdiscovery/monica/config/storage/PreferencesConfigStorage.kt:74 — config/src/main/kotlin/cn/netdiscovery/monica/config/storage/PreferencesConfigStorage.kt:74-81 | config/src/main/kotlin/cn/netdiscovery/monica/config/storage/RxCacheConfigStorage.kt:83-90 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (30–36 lines × 2) · ×1
  • Duplicated block (30–36 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:127 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:127-156 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:196-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:233` calls `sCurve` and `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:158` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (35–36 lines × 2) · ×1
  • Duplicated block (35–36 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:35 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:35-69 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:142-177 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/gesture/AwaitPointerMontionEvent.kt:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (28–30 lines × 2) · ×1
  • Duplicated block (28–30 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ImageLayer.kt:83 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/layer/ImageLayer.kt:83-112 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/ImageLayerControlRenderer.kt:55-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×1
  • Duplicated block (30 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:19 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:19-48 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MinimumFilter.kt:18-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/MaximumFilter.kt:19` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/exception/ErrorExtensions.kt:65 — src/jvmMain/kotlin/cn/netdiscovery/monica/exception/ErrorExtensions.kt:65-83 | src/jvmMain/kotlin/cn/netdiscovery/monica/exception/ErrorExtensions.kt:96-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:243 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:243-277 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:228-262 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:243` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:228 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:228-245 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:333-350 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:360-377 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:228` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1
  • Duplicated block (18 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:208 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:208-225 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/blur/GaussianFilter.kt:94-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:208` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:68 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:68-84 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:99-115 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionView.kt:165-181 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:68` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×1
  • Duplicated block (16–17 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:440 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:440-455 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:576-592 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:440` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16 lines × 5) · ×1
  • Duplicated block (16 lines × 5) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:230 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:230-245 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:335-350 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:362-377 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:471-486 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:607-622 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:230` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 4) · ×1
  • Duplicated block (16 lines × 4) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:227 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:227-242 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:254-269 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:332-347 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:359-374 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:227` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:243` calls `spacedBy` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:270` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (15–16 lines × 3) · ×1
  • Duplicated block (15–16 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:214 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:214-229 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:73-88 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:76-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ExperimentView.kt:214` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×1
  • Duplicated block (15 lines × 4) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:120 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:120-134 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:136-150 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:152-166 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:168-182 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:120` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (4–13 lines × 3) · ×1
  • Duplicated block (4–13 lines × 3) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:113 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:113-116 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:118-130 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:135-147 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SmearFilter.kt:118` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (11 lines × 8) · ×1
  • Duplicated block (11 lines × 8) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:208 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:208-218 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:235-245 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:340-350 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:367-377 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:476-486 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:546-556 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:612-622 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:678-688 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:208` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×1
  • Duplicated block (11 lines × 4) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:41 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:41-51 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GammaFilter.kt:34-44 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SepiaToneFilter.kt:23-33 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SpotlightFilter.kt:25-35 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/BilateralFilter.kt:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/SpotlightFilter.kt:24` calls `sqrt`, `toDouble` and `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GammaFilter.kt:33` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:146 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:146-156 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:263-272 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/base/ConvolveFilter.kt:146` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:28 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:28-37 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:53-62 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonViewModel.kt:27-36 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/AIViewModel.kt:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (8–10 lines × 2) · ×1
  • Duplicated block (8–10 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:115 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:115-124 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:72-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (2–6 lines × 3) · ×1
  • Duplicated block (2–6 lines × 3) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:133 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:133-134 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:148-153 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:172-177 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CellularFilter.kt:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (3–5 lines × 4) · ×1
  • Duplicated block (3–5 lines × 4) imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:238 — imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:238-240 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:241-245 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:249-253 | imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:255-259 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:247` calls `lerp` and `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/math/Noise.kt:254` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×1
  • Duplicated block (5 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/history/EditHistoryCenter.kt:24 — src/jvmMain/kotlin/cn/netdiscovery/monica/history/EditHistoryCenter.kt:24-28 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:51-55 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:90 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:90-105 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:165-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:90` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 9) · ×1
  • Duplicated block (15 lines × 9) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292-306 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:312-326 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:332-346 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:352-366 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:392-406 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:412-426 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:432-446 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:452-466 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:472-486 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (15 lines × 8) · ×1
  • Duplicated block (15 lines × 8) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:123 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:123-137 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:140-154 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:157-171 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:174-188 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:191-205 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:208-222 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:225-239 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:242-256 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:123` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (15 lines × 10) · ×1
  • Duplicated block (15 lines × 10) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292-306 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:312-326 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:332-346 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:352-366 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:372-386 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:392-406 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:412-426 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:432-446 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:452-466 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:472-486 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:292` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×1
  • Duplicated block (13 lines × 4) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:69 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:69-81 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:133-145 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:152-164 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:188-200 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11 lines × 5) · ×1
  • Duplicated block (11 lines × 5) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:109 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:109-119 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:125-135 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:141-151 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:157-167 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:173-183 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cartoon/CartoonView.kt:109` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:249 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:249-259 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:305-315 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:234-244 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:249` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1
  • Duplicated block (9 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:207 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:207-215 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:231-239 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:255-263 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/animation/ShapeAnimationManager.kt:207` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (8 lines × 8) · ×1
  • Duplicated block (8 lines × 8) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:155 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:155-162 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:179-186 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:205-212 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:231-238 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:257-264 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:283-290 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:309-316 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:334-341 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:155` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×1
  • Duplicated block (7 lines × 4) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:108 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:108-114 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:140-146 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:172-178 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:204-210 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:108` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (4–6 lines × 3) · ×1
  • Duplicated block (4–6 lines × 3) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:57 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:57-60 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:74-79 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:71-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:74` calls `title`, `align` and `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:57` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 8) · ×1
  • Duplicated block (5 lines × 8) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221-226 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:268-272 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:337-341 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:175-179 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:253-257 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:93-97 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:171-175 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:203-207 — there are 8 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 8 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 11) · ×1
  • Duplicated block (5 lines × 11) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221-226 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:268-272 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:320-324 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:328-333 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:337-341 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:175-179 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:253-257 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:93-97 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:167-171 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageEnhanceView.kt:203-207 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MorphologicalOperationsView.kt:145-149 — there are 11 copies across 4 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 11 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:221` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:264 — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:264-268 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:171-175 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:249-253 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:84-88 | src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ImageDenoisingView.kt:148-152 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:264` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
P1 · CI/CD gates · No CI pipeline · ×1
  • No CI pipeline — No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
X3 · Exception handling · Swallowed exception (empty catch) · ×1
  • Swallowed exception (empty catch) src/jvmMain/kotlin/cn/netdiscovery/monica/ui/preview/PreviewViewModel.kt:67 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Minor — 231 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×177
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/filter/widget/FilterAdjustmentPanel.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/LayerPanel.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file build.gradle.kts:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorcorrection/ColorCorrectionView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/DynamicCropState.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/CropImageSettingView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/Main.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionViewModel.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/BinaryImageView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/handler/ShapeDrawingEventHandler.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/EditorController.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/widget/image/ImageWithThumbnail.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/state/CropStateImpl.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/ImageLayerControlRenderer.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/ContourAnalysisView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/domain/Gradient.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/MatchTemplateView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/faceswap/FaceSwapView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/cropimage/ImageCropper.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/ai/experiment/EdgeDetectionView.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionPreview.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 152 more in this group — see findings.md.
X4 · Structured logging · Interpolated log message defeats structured logging · ×40
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/Main.kt:221 — `info` at line 221 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/Main.kt:302 — `info` at line 302 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/Main.kt:388 — `info` at line 388 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/Main.kt:402 — `info` at line 402 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/FileChoose.kt:39 — `info` at line 39 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:380 — `error` at line 380 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt:411 — `error` at line 411 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:40 — `info` at line 40 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageUtils.kt:100 — `info` at line 100 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ScreenshotUtils.kt:47 — `error` at line 47 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:92 — `debug` at line 92 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:306 — `info` at line 306 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:323 — `info` at line 323 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:342 — `info` at line 342 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:345 — `debug` at line 345 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:393 — `info` at line 393 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:404 — `info` at line 404 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:459 — `debug` at line 459 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:514 — `warn` at line 514 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:541 — `info` at line 541 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:562 — `info` at line 562 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:583 — `debug` at line 583 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:610 — `error` at line 610 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/WebScreenshotUtils.kt:641 — `info` at line 641 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging src/jvmMain/kotlin/cn/netdiscovery/monica/utils/extensions/Any+Extensions.kt:38 — `info` at line 38 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
  • + 15 more in this group — see findings.md.
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/colorpick/model/ColorNameMap.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/main/GeneralSettingsDialog.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
X10 · Duplicated predicate · Duplicated predicate · ×3
  • Duplicated predicate src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt:198 — `activeImageLayer != null && !activeImageLayer.locked && !editorController.isBackgroundLayer(activeImageLayer)` appears character-identically in 2 files — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt, src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/widget/CanvasView.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionViewModel.kt:236 — `file.isFile && file.extension.lowercase() in imageExtensions` appears character-identically in 2 files — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/compression/CompressionViewModel.kt, src/jvmMain/kotlin/cn/netdiscovery/monica/utils/ImageCompressionUtils.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt:119 — `originalSize != null && displaySize != null` appears character-identically in 2 files — src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/doodle/DoodleView.kt, src/jvmMain/kotlin/cn/netdiscovery/monica/ui/controlpanel/shapedrawing/ShapeDrawingView.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found build.gradle.kts:561 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `build.gradle.kts` makes this repository a deployable product (line 561).
D21 · Naming Consistency · `setupGammaLut` spells `Lut` where 14 names in the project spell it `LUT` · ×1
  • `setupGammaLut` spells `Lut` where 14 names in the project spell it `LUT` imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GammaFilter.kt:23 — 14 of 15 names in project imageprocess spell the token `LUT` (14 of 15; unit: names in project imageprocess containing `LUT`). Peers: ColorFilter.getStyleLUT (imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorFilter.kt:19); cn.netdiscovery.monica.imageprocess.lut.AutumnLUT (imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/lut/AutumnLUT.kt:12); cn.netdiscovery.monica.imageprocess.lut.BoneLUT (imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/lut/BoneLUT.kt:12); cn.netdiscovery.monica.imageprocess.lut.CoolLUT (imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/lut/CoolLUT.kt:12); cn.netdiscovery.monica.imageprocess.lut.HotLUT (imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/lut/HotLUT.kt:12). Rename to `setupGammaLUT`. [rule N6]
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion build.gradle.kts:1 — `(repository root)` (28798 LoC, 459 module-visible types across 62 directories) overshoots its size bounds. 1 of 7 build unit(s) (Gradle, npm) overshoot their size bounds, lowering Project Cohesion to 7.1/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness · Dormant codebase · ×1
  • Dormant codebase — 180 of 180 significant files have no living knowledge — the codebase as a whole is dormant, not 180 separate risks. Counted over 180 of the 321 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation resources/package.json:9 — `resources/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-54853d8cdf724a1e956cddeae7082be7/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-54853d8cdf724a1e956cddeae7082be7/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=938" --report-format json --report-path /tmp/watchdog-gitleaks-54853d8cdf724a1e956cddeae7082be7/history-2.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-54853d8cdf724a1e956cddeae7082be7/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .0artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 12 file(s) — `build.gradle.kts`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/CarveFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/ColorHalftoneFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/EqualizeFilter.kt`, `imageprocess/src/main/kotlin/cn/netdiscovery/monica/imageprocess/filter/GaussianNoiseFilter.kt`, … (+7 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D36 · Supply-chain Provenance & Signingprovenance—provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json

Run 01a1eb23-5b91-7864-8f24-638f9b12333c · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md