# Changelog

## Score

- CAI 38 → 36 (-1.5)
- Rubric changed (rubric-2026.10.5 → rubric-2026.11.2) — scores are not directly comparable.

## Lenses

- Code Health 84 → 84 (+0.0)
- Architecture 86 → 86 (+0.0)
- Maturity 58 → 62 (+4.4)
- Readiness 9 → 11 (+2.2)
- Security 49 → 46 (-2.4)
- Domain Modelling 56 (new)
- Event-Driven 100 → 100 (+0.0)
- Performance 100 → 100 (+0.0)

## Resolved (20)

- Documentation: no usage examples (README.md)
- Duplicate Intent: The CustomerAccount nested type in NewCustomerAccountRequest contains the same fields (AccountTypesId, Frequency) as the standalone CreateAccountRequest. This suggests that account creation logic is duplicated across different request flows (admin new customer vs. direct account creation).
- End-of-life runtime: .NET net7.0 (BankApplication.Infrastructure/BankApplication.Infrastructure.csproj)
- Inconsistent Naming for Account Identifiers: In AccountTransactionsResponse, the account is identified by 'AccountId' (int in constructor, string in property). In TransferResponse, accounts are identified by 'SenderAccount' (string) and 'RetrieverAccount' (int). The type mismatch (int vs string) for the same conceptual entity (Account ID) across response types is confusing.
- Properties 'Emailaddress', 'Telephonenumber', and 'Telephonecountrycode' are concatenated single words, while other properties like 'CountryCode', 'Givenname' (in parameter), 'Surname', 'City' follow standard casing. 'Givenname' is also concatenated. This indicates an inconsistent approach to naming multi-word properties.
- Redundant Request Types: Similar to above, two request types exist for fetching transactions. One is AccountId-only, the other is UserId+AccountId. This creates confusion about which type to use for which endpoint or context.
- Redundant Request Types: Two distinct request types exist for creating an account. One lacks UserId (likely for admin context), the other includes it. This forces consumers to choose between two nearly identical DTOs based on implicit context rather than explicit API design.
- Redundant Request Types: Two request types exist for transfers. One lacks UserId, the other includes it. This inconsistency mirrors the pattern seen in CreateAccount and GetTransactions, suggesting a systemic lack of unified request modeling.
- The namespace and assembly prefix for persistence-related infrastructure is spelled 'Presistence' instead of 'Persistence'. This spelling error is repeated across multiple repository types and the namespace itself.
- The property/parameter name 'Telephonenumber' (and 'Telephonecountrycode') uses a concatenated camelCase style for a multi-word concept, whereas other similar properties in the same models use separate words or standard casing (e.g., 'Emailaddress' is also concatenated, but 'CountryCode' is not). More critically, 'Telephonenumber' is inconsistent with standard naming conventions for multi-word identifiers which typically use PascalCase for properties (TelephoneNumber) or camelCase with separators if not a single compound word. However, the primary inconsistency is between 'Telephonenumber' and 'Telephonecountrycode' vs 'CountryCode'. 'CountryCode' is two words, 'Telephonenumber' is one. This suggests a lack of consistent tokenization for multi-word identifiers.
- The word 'Administrator' is consistently misspelled as 'Adminstrator' across namespaces, types, controllers, and repositories. While consistent internally, this is a spelling error in the codebase vocabulary.
- Vulnerable: Azure.Identity
- Vulnerable: System.Data.SqlClient
- Vulnerable: System.IdentityModel.Tokens.Jwt
- XML-doc coverage: BankApplication.Application (BankApplication.Application/BankApplication.Application.csproj)
- XML-doc coverage: BankApplication.Contracts (BankApplication.Presentation/BankApplication.Contracts/BankApplication.Contracts.csproj)
- XML-doc coverage: BankApplication.Domain (BankApplication.Domain/BankApplication.Domain.csproj)
- XML-doc coverage: BankApplication.Infrastructure (BankApplication.Infrastructure/BankApplication.Infrastructure.csproj)
- XML-doc coverage: BankApplication.WebApi (BankApplication.Presentation/BankApplication.WebApi/BankApplication.WebApi.csproj)
- misleading comment (BankApplication.Application/Authentication/Commands/Register/RegisterCommandHandler.cs)

## New (5)

- End-of-life runtime: .NET net7.0 (BankApplication.Application/BankApplication.Application.csproj)
- End-of-life runtime: .NET net7.0 (BankApplication.Domain/BankApplication.Domain.csproj)
- End-of-life runtime: .NET net7.0 (BankApplication.Infrastructure/BankApplication.Infrastructure.csproj)
- End-of-life runtime: .NET net7.0 (BankApplication.Presentation/BankApplication.Contracts/BankApplication.Contracts.csproj)
- End-of-life runtime: .NET net7.0 (BankApplication.Presentation/BankApplication.WebApi/BankApplication.WebApi.csproj)

## API surface

- Unchanged — 8 HTTP endpoints

## Architecture

- Unchanged — 2 containers · 0 contexts · 0 edges
