Public report of ebi-pf-team/interproscan, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 02:45 UTC · Survey ID cd_f328a2f7dec74e7ea05ebf40637cc950

ebi-pf-team/interproscan

Measured 17 November 2026, 02:43 UTC, at code version 26256cb

First survey, so nothing to compare with yet
CAI score 49.7out of 100 At risk

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 80,249 lines of product code in 15 projects, tests not counted · Estimated rebuild effort: about 0.5 person-years · Weakest lens: Production Readiness, 42.9

Findings by how serious they are

86 critical 1244 serious 608 minor

13 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 02:43 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

66of 66 dimensions measured by tools.
1923of 1938 findings point to an exact file and line, so you can open each one in the code. The other 15 concern the repository as a whole, such as missing documentation.
66dimensions across 7 lenses, read from 80,249 lines of product code in 15 projects.
Chapters

Executive summary

ebi-pf-team/interproscan is rated At risk because critical security findings are open. Its score is held back in part because we found no automated security scanning of the code, its secrets or its dependencies. It scores 49.7 out of 100, which the At risk rating leaves unchanged.

Production Readiness, at 42.9, is the weakest lens and counts most in the score. The best first step is adding tests for untested code, worth about 5.7 points. Adding automated security scanning comes next, worth about 4.5 points. Raising Production Readiness to 70 would lift the score to about 55.3.

Thirty-five known security holes in the packages the code depends on can be used by attackers. Twenty-three passwords or keys are open to anyone who can read the repository, and nineteen weaknesses in the code could be used by an attacker. Updating the vulnerable packages, replacing each exposed password or key and fixing the weaknesses the scanner points to would close these risks. Pinning each tool to an exact version would fix the two pipeline tools referenced by a changeable name, and the unsafe setting in infrastructure or container files needs changing to safe values. The six pages that don't say their language need their language set.

The product code is 80,249 lines, about €74,000 to rebuild. The check for the health of its packages couldn't finish, so that result is missing, not a clean pass.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 42.9 · counts for 46%Security and Compliance 49.3 · counts for 25%Code Health 50.2 · counts for 14%Maturity 65.6 · counts for 8%Accessibility 70.6 · counts for 4%Architecture 78.5 · counts for 2%Performance 80.0 · counts for 1%

If Production Readiness rose from 42.9 to 70, the lowest score rated Strong, the score would rise from 49.7 to about 55.3.

Code composition: what the lines of code are
Product code 90%Tests 10%
Rebuild cost: about €74,000 · Estimate
Cost to rebuild€25,000 to €120,000, for 412 to 1,306 hours of work, about 0.5 person-years for one engineer
Difficulty of the problemLow, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 50. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 80,249 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 98 Low coverage finding(s) in Code Coverage — start with BlastProDomMatch.java, ChunkerSingleton.java, CoilsMatch.java.
Raises the score by about 5.7 points · Medium effort · Code Coverage
2
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 4.5 points · Medium effort · Security & performance tooling
3
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Raises the score by about 3.4 points · Medium effort · Outbound HTTP resilience

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €74,000 to build again, about 0.5 person-years of work. Its weakest lens is Production Readiness, at 42.9 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 98 Low coverage finding(s) in Code Coverage. Of all the actions in this report, it raises the score most for the work it takes: about 5.7 points for medium effort, because it clears the 98 Code Coverage findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 6.2 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 5% to 10% on every change.
How this is estimated: It rests on an assumption of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4)
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch berkeley berkeley generic-jpa-dao generic-jpa-dao interproscan-util interproscan-util generic-jpa-dao->interproscan-util interproscan-business interproscan-business interproscan-persistence interproscan-persistence interproscan-business->interproscan-persistence precalc-match-client precalc-match-client interproscan-business->precalc-match-client interproscan-io interproscan-io interproscan-model interproscan-model interproscan-io->interproscan-model interproscan-io->interproscan-util interproscan-management interproscan-management interproscan-management->interproscan-util interproscan-web interproscan-web interproscan-management->interproscan-web interproscan-persistence->generic-jpa-dao interproscan-persistence->interproscan-io interproscan-persistence->interproscan-model interproscan-web->interproscan-business interproscan-web->interproscan-model jms-implementation jms-implementation jms-implementation->interproscan-management precalc-match-client->berkeley server server server->berkeley

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

171 modules, with 362 dependencies between them. 3 loops run through 10 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 131 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 model2 precalc.berkeley.model3 io4 management.model5 model.raw6 web.model7 io.gene3d8 io.getorf9 management.dao10 persistence.raw11 web.io12 business.filter13 io.match14 jms.master15 management.model.implementations.writer16 io.match.hmmer.hmmer217 io.match.hmmer.hmmer318 io.match.prosite19 io.tmhmm20 jms.main21 jms.worker22 jms.activemq23 persistence24 management.model.implementations.pirsf.hmmer325 management.model.implementations.stepInstanceCreation.memberDatabaseLoad26 precalc.berkeley.conversion.toi527 business.sequence28 business.sequence.fasta29 management.model.implementations30 management.model.implementations.stepInstanceCreation.proteinLoad31 management.model.implementations.funfam32 management.model.implementations.gene3d33 management.model.implementations.hamap34 management.model.implementations.hmmer335 management.model.implementations.hmmer3.PfamA36 management.model.implementations.panther37 management.model.implementations.prints38 management.model.implementations.prosite39 management.model.implementations.smart40 management.model.implementations.tigrfam
1 model
2 precalc.berkeley.model
3 io6
4 management.model21
5 model.raw27
6 web.model22
7 io.gene3d244
8 io.getorf12
9 management.dao9
10 persistence.raw20
11 web.io415
12 business.filter41
13 io.match231
14 jms.master1823
15 management.model.implementations.writer31104
16 io.match.hmmer.hmmer2161
17 io.match.hmmer.hmmer36115125
18 io.match.prosite8122
19 io.tmhmm6121
20 jms.main152
21 jms.worker1233
22 jms.activemq212122
23 persistence344112
24 management.model.implementations.pirsf.hmmer312111
25 management.model.implementations.stepInstanceCreation.memberDatabaseLoad111
26 precalc.berkeley.conversion.toi5541
27 business.sequence95182
28 business.sequence.fasta7158
29 management.model.implementations1323811331131
30 management.model.implementations.stepInstanceCreation.proteinLoad21642113
31 management.model.implementations.funfam1311111
32 management.model.implementations.gene3d29233123
33 management.model.implementations.hamap2722211
34 management.model.implementations.hmmer322111113
35 management.model.implementations.hmmer3.PfamA122111
36 management.model.implementations.panther171116
37 management.model.implementations.prints151211
38 management.model.implementations.prosite292227
39 management.model.implementations.smart131111
40 management.model.implementations.tigrfam121111
Uses a module listed above itPart of a loopThe module itself
1 model2 precalc.berkeley.model3 io4 management.model5 model.raw6 web.model7 io.gene3d8 io.getorf9 management.dao10 persistence.raw11 web.io12 business.filter13 io.match14 jms.master15 management.model.implementations.writer16 io.match.hmmer.hmmer217 io.match.hmmer.hmmer318 io.match.prosite19 io.tmhmm20 jms.main21 jms.worker22 jms.activemq23 persistence24 management.model.implementations.pirsf.hmmer325 management.model.implementations.stepInstanceCreation.memberDatabaseLoad26 precalc.berkeley.conversion.toi527 business.sequence28 business.sequence.fasta29 management.model.implementations30 management.model.implementations.stepInstanceCreation.proteinLoad31 management.model.implementations.funfam32 management.model.implementations.gene3d33 management.model.implementations.hamap34 management.model.implementations.hmmer335 management.model.implementations.hmmer3.PfamA36 management.model.implementations.panther37 management.model.implementations.prints38 management.model.implementations.prosite39 management.model.implementations.smart40 management.model.implementations.tigrfammodel1precalc.berkeley.model2io3management.model4model.raw5web.model6io.gene3d7io.getorf8management.dao9persistence.raw10web.io11business.filter12io.match13jms.master14management.model.implementations.writer15io.match.hmmer.hmmer216io.match.hmmer.hmmer317io.match.prosite18io.tmhmm19jms.main20jms.worker21jms.activemq22persistence23management.model.implementations.pirsf.hmmer324management.model.implementations.stepInstanceCreation.memberDatabaseLoad25precalc.berkeley.conversion.toi526business.sequence27business.sequence.fasta28management.model.implementations29management.model.implementations.stepInstanceCreation.proteinLoad30management.model.implementations.funfam31management.model.implementations.gene3d32management.model.implementations.hamap33management.model.implementations.hmmer334management.model.implementations.hmmer3.PfamA35management.model.implementations.panther36management.model.implementations.prints37management.model.implementations.prosite38management.model.implementations.smart39management.model.implementations.tigrfam4062127222441292041541231182331104161611512581226121152123321212234411212111111541951827158132381133113121642113131111129233123272221122111113122111171116151211292227131111121111+131 more modules (most-connected shown)

At a glance — Code Health · 50.2 · Adequate · gated by D2, X4, X5 ·

At a glance — Architecture · 78.5 · Strong ·

At a glance — Maturity · 65.6 · Adequate · gated by D34 ·

At a glance — Readiness · 42.9 · Weak · gated by D8, P3, P7 ·

At a glance — Security · 49.3 · Checked 5 of 11 · gated by D28, D29, D36 ·

At a glance — Accessibility · 70.6 · Strong ·

At a glance — Performance · 80.0 · Strong ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2025 — Software Supply Chain Failures89High / Critical
A05:2025 — Injection45High / Critical
A07:2025 — Authentication Failures24High / Critical
A02:2025 — Security Misconfiguration2High / Critical

Roadmap

Top priorities: Resolve the 98 Low coverage finding(s) in Code Coverage — start with BlastProDomMatch.java, ChunkerSingleton.java, CoilsMatch.java; Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing; Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 98 Low coverage finding(s) in Code Coverage — start with BlastProDomMatch.java, ChunkerSingleton.java, CoilsMatch.java.+5.7 ptsMediumCode Coverage
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+4.5 ptsMediumSecurity & performance tooling
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).+3.4 ptsMediumOutbound HTTP resilience
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.+2.2 ptsMediumDeployment & Rollback
Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).+2.2 ptsMediumNullable reference types
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.+1.0 ptsLowDocumentation Quality
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with REDACTED.+1.0 ptsLowADR Quality
Interpolated log message defeats structured logging+1.9 ptsMediumStructured logging

File quality

Per-file score 0–10 — a quality signature. Of 437 files carrying findings, judged against the Production bar: 3% slop · 55% mixed · 42% near-clean.

FileScoreBandWorst signal
REDACTED0.2SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED0.7SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED0.7SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED0.7SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED0.7SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED0.8SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED1.4SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED1.4SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED1.5SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED1.5SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.0SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.0SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.0SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.0SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.1SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 86

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 1244

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 608

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 13

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 66 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 66 dimensions across the health lenses
D1D2D3D4D5D6D8D10D11D13D14D15D16D17D19D20D21D23D26D27D28D29D30D31D34D35D36D43D44AC1AC2AC3AC6AX1AX10AX2AX3AX5AX6GD1IC1M1M2M3P1P10P2P3P4P6P7PF1X13X16X18X19X20X23X25X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1923 of 1938 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic

Every finding is locatable in findings.md. Run 01a1e763-6dba-7ff0-8c42-59770d5dd51d.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository's dependency manifests WERE read and their pinning discipline assessed; what went unanswered is the currency half, because maven.java.net — the registry that answers it — was asked and did not reply (the build stopped because maven.java.net, a repository this project declares, refused it with HTTP 403 — what this scan's egress allowlist returns for a host that is not on it; 32 dependencies were resolved and graded first, but the graph is partial so the result is reported and not scored). This is OUR side and it is an ENVIRONMENT fault, not a missing collector: the collector exists and ran. An HTTP 403 here is what this scan's egress allowlist returns for a host that is not on it, so the remedy is to add maven.java.net to the allowlist and re-run — not to build anything.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (REDACTED), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
  • D23 Boundary Type-Coupling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind measured 0/40 valid on a seeded held-out sample of its rows on 98 C# repositories (docs/plans/deterministic-engine/adjudication/P5c-D23-units.md, "Version 1 ON MAIN"): the noise rows were dependencies on layer folders, shared cores and grouping folders read as contexts. By the pre-registered fallback (PREREGISTRATION v37) it publishes no row until version 4 passes its gate. The candidates are counted here, not reported as findings, and the score does not include them.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D28 Secrets (history) — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The newest 3272 of 8070 commits were scanned for secrets, back to commit c696e277f507; older commits were not. `gitleaks` TIMED OUT after 78.6s against a 78.6s budget, so we killed its process tree. The budget is ours; the work may simply be larger than it allows. The working tree WAS scanned in full, and every row of the scanned ranges is reported. Nothing about the unscanned commits is asserted by the absence of a result; the budget is ours to raise.
  • AXB2 Runtime readiness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. A build step could not reach the network from our sandbox (a registry or download request was refused). This is a limit of our sandbox, not of your repository. (rule: network). The renderer reported: docker build failed (exit 1) — scan-core-${VERSION}.tar.gz && wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz.md5 && md5sum -c interproscan-core-${VERSION}.tar.gz.md5 && tar -zxf interproscan-core-${VERSION}.tar.gz && rm interproscan-core-${VERSION}.tar.gz* && mv /opt/interproscan-${VERSION} /opt/interproscan" did not complete successfully: exit code: 4; likely cause (our sandbox): a build step could not reach the network from our sandbox (a registry or download request was refused). This is a limit of our sandbox, not of your repository; runtime evidence skipped.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via REDACTED (REDACTED). docker build failed (exit 1) — scan-core-${VERSION}.tar.gz && wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz.md5 && md5sum -c interproscan-core-${VERSION}.tar.gz.md5 && tar -zxf interproscan-core-${VERSION}.tar.gz && rm interproscan-core-${VERSION}.tar.gz* && mv /opt/interproscan-${VERSION} /opt/interproscan" did not complete successfully: exit code: 4; likely cause (our sandbox): a build step could not reach the network from our sandbox (a registry or download request was refused). This is a limit of our sandbox, not of your repository; runtime evidence skipped.
  • C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • P10 Library API & versioning — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 6 further occurrence(s) are not listed individually; the score already reflects all 46.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X10 Duplicated predicate — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 11 further occurrence(s) are not listed individually; the score already reflects all 51.
  • X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 675 further occurrence(s) are not listed individually; the score already reflects all 715.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D11 Test Reliability: Flakiness is inferred from history/markers — we run the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D23 Boundary Type-Coupling: Boundary leakage is detected from type references across detected contexts — leaks that flow through primitives, serialization or shared infrastructure may not surface as a typed reference.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.4 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Prevented

103 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was 2.run at 70.

2.run (cyclomatic 70)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:949
DistributedBlackBoxMaster.run (cyclomatic 58)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:99
Run.main (cyclomatic 56)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:107
StepCreationSequenceLoadListener.sequencesLoaded (cyclomatic 52)core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:95
StandaloneBlackBoxMaster.run (cyclomatic 43)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:49

+ 98 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 60 down to 60 or less in Cyclomatic Complexity — start with 2.run (cyclomatic 70). — Refactoring it lifts Cyclomatic Complexity from 6.4 to about 6.5/10.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity3.9 / 10Weak✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 3.9 / 10 · rule-coverage 100% · ceiling Prevented

254 method(s) exceeded the cognitive complexity threshold of 15; the worst was 2.run at 152.

2.run (cognitive 152)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:949
Hmmer3SearchMatchParser.parse (cognitive 141)core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:161
LookupStoreToI5ModelDAOImpl.populateProteinMatches (cognitive 138)core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:74
StepCreationSequenceLoadListener.sequencesLoaded (cognitive 136)core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:95
DistributedBlackBoxMaster.run (cognitive 132)core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:99

+ 249 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 6 bodies over 120 down to 120 or less in Cognitive Complexity — start with 2.run (cognitive 152), Hmmer3SearchMatchParser.parse (cognitive 141), LookupStoreToI5ModelDAOImpl.populateProteinMatches (cognitive 138). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cognitive Complexity from 3.9 to about 4.3/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.3 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.3 / 10 · rule-coverage 100% · ceiling Prevented

35 god class(es) detected.

TooManyMethods: WorkerImpl · ×16core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56
MethodTooLong: StandaloneBlackBoxMaster.run · ×12core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:49
FileTooLong: main/Run.java · ×6core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java
ClassTooLong: WorkerImplcore/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56

What to do

  1. Resolve the 16 TooManyMethods finding(s) in God Classes — start with WorkerImpl.java, StatsUtil.java, Signature.java. — One of this dimension's main actionable groups (16 warning-level).
  2. Resolve the 12 MethodTooLong finding(s) in God Classes — start with StandaloneBlackBoxMaster.java, LookupStoreToI5ModelDAOImpl.java, WorkerImpl.java. — One of this dimension's main actionable groups (12 warning-level).
  3. Resolve the 6 FileTooLong finding(s) in God Classes — start with Run.java, WorkerImpl.java, DistributedBlackBoxMaster.java. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication4.8 / 10Weak✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 4.8 / 10 · rule-coverage 100% · ceiling Verified

255 duplicated block group(s) detected. 13.1 % of the production lines (10,481 of 80,249) are in a reported copy. A further 151 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (7 lines × 2) · ×19core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:211
Duplicated block (9 lines × 2) · ×15core/io/src/main/java/uk/ac/ebi/interpro/scan/io/AbstractResourceReader.java:23
Duplicated block (8 lines × 2) · ×13core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:193
Duplicated block (6 lines × 2) · ×12core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:196
Duplicated block (11 lines × 2) · ×11core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:295

+ 162 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 19 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with WriteOutputStep.java (5), Gene3dRawMatchFilter.java, Hmmer3ScanMatchParser.java. — One of this dimension's main actionable groups (19 warning-level).
  2. Resolve the 15 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with DistributedBlackBoxMaster.java (4), CommandLineConversationMonitor.java (2), AbstractResourceReader.java. — One of this dimension's main actionable groups (15 warning-level).
  3. Resolve the 13 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with AbstractMaster.java, DistributedBlackBoxMasterOLD.java, WriteOutputStep.java. — One of this dimension's main actionable groups (13 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling8.0 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Prevented

12 production modules (Maven), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 3 module(s) off the main sequence.

Off the main sequence: interproscan-util · ×3

What to do

  1. Resolve the 3 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.6 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

6 of 174 classes have LCOM4 above 3.

Low cohesion: KVDBImpl (LCOM4 16) · ×6core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/kvstore/KVDBImpl.java:28

What to do

  1. Resolve the 6 Low cohesion finding(s) in Cohesion (LCOM4) — start with KVDBImpl.java, ProteinDAOImpl.java, PIRSRHmmer3MatchParser.java. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D8 · Code Coverage1.0 / 10Critical✓ Tool-verified

What it measures: How much of the code is actually exercised by tests.

Method: Coverage from the analyzer's own run of the suite, computed per-file with structured exclusions for generated, trivial, and glue code. A coverage report found in the repository is never read. When the suite can't be built/run in-image, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.

Maturity: Documented → Verified → Prevented · effective 1.0 / 10 · rule-coverage 100% · ceiling Verified

Line coverage 0.9% — 98 file(s) below 50%. Measured from the Java/Kotlin suite (core, Maven: the JaCoCo agent on the 3 run(s) test reliability made). Taken over 3 runs of the suite: a line counts as covered only when every run executed it.

Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java · ×98core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:1

What to do

  1. Resolve the 98 Low coverage finding(s) in Code Coverage — start with BlastProDomMatch.java, ChunkerSingleton.java, CoilsMatch.java. — One of this dimension's main actionable groups (98 warning-level).

Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.

D10 · Test Quality9.1 / 10Stronggated by 11 serious findings✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Prevented

19 skipped (19 with a documented reason), 11 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 179 tests.

No assertions: testWriter · ×11core/business/src/test/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/FastaFileWriterTest.java:53
Skipped (documented): testParseAndFilter · ×19core/business/src/test/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessingTest.java:62

What to do

  1. Resolve the 11 No assertions finding(s) in Test Quality — start with HibernateAnnotationTest.java (2), FastaFileWriterTest.java, LoadFastaFileTest.java. — One of this dimension's main actionable groups (11 warning-level).

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests pass reliably, with no flakiness.

Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 flaky across 1 measured tier(s). Java/Kotlin (core, Maven): measured (0 flaky).

✓ On the Gold path — maintain.

Detailed fixes: d11_recommendation.md.

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 43 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 14 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 37 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. 3 of them resolve to no licence at all on Central, even through their parent POMs; that is missing data, not a violation, and none of them is charged. A further 10 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D16 · Bus Factor9.2 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Documented

8 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java. Counted over 108 of the 713 production source files in this repository: 295 are under the ~2,400-byte size floor this dimension measures over, and the remaining 310 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.4 / 10Stronggated by 238 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Prevented

238 deducted task-comment markers across 80249 LoC (0.3/KLoC) → score 9.4. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×235core/web/src/test/java/uk/ac/ebi/interpro/scan/web/ProteinViewControllerTest.java:90
FixmeComment · ×2core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:127
HackCommentcore/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1160

What to do

  1. Resolve the 235 TodoComment finding(s) in Explicit Debt — start with Signature.java (14), Entry.java (11), Run.java (10). — One of this dimension's main actionable groups (235 warning-level).
  2. Resolve the 2 FixmeComment finding(s) in Explicit Debt — start with EntryRowCallbackHandler.java, PrepareForOutputStep.java. — One of this dimension's main actionable groups (2 warning-level).
  3. Resolve the 1 HackComment finding(s) in Explicit Debt — start with Run.java. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 1 documentation facets pass in full; short on: F2 example. 1 document(s) read across 1 unit(s).

Documentation: no build, run or usage exampleREADME.md:1

What to do

  1. Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundREDACTED:16

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency7.6 / 10Strong✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 7.6 / 10 · rule-coverage 100% · ceiling Verified

10 naming inconsistencies among 408 declarations measured against a convention their peers follow.

`hierarchyModelIDLimitation` spells `ID` where 18 names in the project spell it `Id`core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prints/PrintsPostProcessing.java:188
`setXrefDao` spells `Dao` where 28 names in the project spell it `DAO`core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:50
`proteinXrefDao` spells `Dao` where 28 names in the project spell it `DAO`core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:50
`configureTCPTransport` spells `TCP` where 15 names in the project spell it `Tcp`core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1539
`setXrefDao` spells `Dao` where 135 names in the project spell it `DAO`core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:124

+ 5 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 `hierarchyModelIDLimitation` spells `ID` where 18 names in the project… finding(s) in Naming Consistency — start with PrintsPostProcessing.java. — One of this dimension's main actionable groups (1 recommendation-level).
  2. Resolve the 1 `setXrefDao` spells `Dao` where 28 names in the project spell it `DAO` finding(s) in Naming Consistency — start with LoadUniParcFromDBImpl.java. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 `proteinXrefDao` spells `Dao` where 28 names in the project spell it… finding(s) in Naming Consistency — start with LoadUniParcFromDBImpl.java. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D23 · Boundary Type-Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether domain types (IDs, enums, value objects) leak across bounded-context boundaries.

Method: Cross-context domain-type leakage via Roslyn structural classification (strongly-typed IDs / value objects) over every public surface. Exhaustive, deterministic, type-level aggregate-boundary check.

Coverage: Bounded contexts derived from NAMESPACE prefix (or graph-inferred where available); cross-boundary domain-type leakage then checked exhaustively over every public member of every type.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

59 domain type(s) cross context boundaries across 3 contexts; they are measured and withheld (not published, not scored). Contexts: management, model, web.

✓ On the Gold path — maintain.

Detailed fixes: d23_recommendation.md.

D26 · Project Cohesion4.7 / 10Weak✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 4.7 / 10 · rule-coverage 100% · ceiling Documented

4 of 15 build units (Maven, Python, checkout) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion · ×4REDACTED:1

What to do

  1. Resolve the 4 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with REDACTED (4). — One of this dimension's main actionable groups (4 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.7 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

75 % of calls cross a namespace and 6 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

23 finding(s): 0 critical, 23 high, 0 medium, 0 low. History coverage: The newest 3272 of 8070 commits were scanned for secrets, back to commit c696e277f507; older commits were not. `gitleaks` TIMED OUT after 78.6s against a 78.6s budget, so we killed its process tree. The budget is ours; the work may simply be larger than it allows. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 23 REDACTED finding(s) in Secrets (history) — start with REDACTED (16), REDACTED (7). — One of this dimension's main actionable groups (23 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.1 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.1 / 10 · rule-coverage 100% · ceiling Documented

45 finding(s): 0 critical, 21 high, 24 medium, 0 low. 2 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 4 file(s) — `core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/_aligners.c`, `core/jms-implementation/support-mini-x86-32/src/prints/fingerprintscan/3597/configure`, `core/jms-implementation/support-mini-x86-32/src/prints/fingerprintscan/3597/missing` (line 31, line 99, line 100, …), `core/jms-implementation/support-mini-x86-32/work/kvs/idb/goterms.ipr.json` — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 3 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED (3), REDACTED (2). — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 9 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (9). — One of this dimension's main actionable groups (9 issue-level).
  3. No action in Static Analysis (SAST) — all 2 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (2 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities3.2 / 10Weak✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 3.2 / 10 · rule-coverage 100% · ceiling Documented

84 finding(s): 2 critical, 33 high, 35 medium, 14 low.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 35 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (35). — One of this dimension's main actionable groups (35 warning-level).
  2. Resolve the 33 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (33). — One of this dimension's main actionable groups (33 issue-level).
  3. Resolve the 2 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security9.6 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Documented

2 finding(s): 0 critical, 1 high, 1 medium, 0 low.

REDACTED
REDACTED

What to do

  1. Resolve the 1 High IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 Medium IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness0.5 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.5 / 10 · rule-coverage 100% · ceiling Documented

398 of 418 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java. Counted over 418 of the 713 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×395core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:1
Most significant orphaned file · ×3core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1
Concentrated knowledge decay

What to do

  1. Resolve the 395 Orphaned file finding(s) in Knowledge Freshness — start with EntryType.java (2), ParseException.java (2), WriteOutputStep.java. — One of this dimension's main actionable groups (395 recommendation-level).
  2. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with Run.java, DistributedBlackBoxMaster.java, WorkerImpl.java. — One of this dimension's main actionable groups (3 recommendation-level).
  3. Resolve the 1 Concentrated knowledge decay finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 76 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC3 · Page structure4.5 / 10Weak✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×6) — core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structure.ftl:2, core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structures.ftl:2, core/web/src/main/webapp/WEB-INF/freemarker/views/protein.ftl:7, …
  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×6) — core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structure.ftl:2, core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structures.ftl:2, core/web/src/main/webapp/WEB-INF/freemarker/views/protein.ftl:7, …

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC6 · Visual & motion safety6.6 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.ui-tooltip-titlebar .ui-state-default` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — core/web/src/main/webapp/resources/javascript/qtip2/jquery.qtip.css:71

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

AX10 · Code composition8.6 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons4.8 / 10Weak✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `JMSErrorHandler` is a singleton (@Service: the container shares one instance across every request thread) but mutates instance state outside any lock (errorCount; e.g. `errorCount` in `handleError` at line 23). — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/JMSErrorHandler.java:17
  • `JMSTransportListener` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (previousIOExceptionTime, brokenConnection, exceptionsCount, lastInterrupt, interruptedConnection; e.g. `previousIOExceptionTime` in `onException` at line 52). — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/JMSTransportListener.java:16
  • `CreateSimpleProteinFromMatchDataImpl` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (resourceLoader; e.g. `resourceLoader` in `retrieveMatches` at line 70). — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:25
  • `EntryHierarchy` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (entryColourMap, entryHierarchyDataMap, entryToGoTerms; e.g. `entryColourMap` in `init` at line 41). — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:25
  • `MatchesServiceImpl` is a singleton (@Repository: the container shares one instance across every request thread) but mutates instance state outside any lock (serviceName; e.g. `serviceName` in `setName` at line 319). — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:32

What to do

  • Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `KVDB` declares 26 abstract methods: `addSignatureLibraryName`, `asEntry`, `asMatch`, `asMatchSet`, `asNucleotideSequence`, `asProtein`, `asString`, `close`, `get`, `getAllElements`, `getDbName`, `getDbPath`, `getKVDBStore`, `getKVDBType`, `getLevelDBStore`, `getNucleotideSequence`, `getProtein`, `getSignatureLibraryNames`, `put`, `put`, `serialize`, `serialize`, `serialize`, `serialize`, `serialize`, `setKVDBStore`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 26 declarations carry 21 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 21 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/kvstore/KVDB.java:18
  • `ProteinDAO` declares 24 abstract methods: `checkKVDBStores`, `closeKVDBStores`, `getKeyToProteinMap`, `getLevelDBStore`, `getProtein`, `getProteinAndCrossReferencesByProteinId`, `getProteinById`, `getProteinNotInLookup`, `getProteins`, `getProteins`, `getProteinsAndMatchesAndCrossReferencesBetweenIds`, `getProteinsBetweenIds`, `getProteinsByIds`, `getProteinsNotInLookup`, `getProteinsNotInLookupCount`, `getProteinsWithoutLookupHit`, `getProteinsWithoutLookupHitBetweenIds`, `insert`, `insertNewProteins`, `insertProteinNotInLookup`, `persist`, `persist`, `persistProteinNotInLookup`, `setProteinIdsWithoutLookupHit`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 24 declarations carry 22 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 22 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAO.java:37

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
GD1 · Unfinished & placeholder code10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Unreviewed-generation residue in this repository's Java: methods whose whole body only throws a "not implemented" or bare unsupported-operation exception, or returns a default value (or nothing) under a TODO/FIXME marker, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

IC1 · Incompleteness & stubs9.0 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `header` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java:49
  • A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. (×24) — core/business/src/test/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessingTest.java:61, core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/CathDomainListRecordTest.java:38, core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/Model2SfReaderTest.java:34, …

What to do

  • Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
  • Clear the softer debt: re-enable or delete @Disabled/@Ignore tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace @SuppressWarnings("all") with targeted, justified suppressions.
M1 · Documentation (README)6.7 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`mvn test` for the toolchain this pipeline already uses) and gate merges on it.
P10 · Library API & versioning8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • 1 public type in `uk.ac.ebi.interpro.scan.business.binary` is marked as implementation by its own namespace, folder or name: `RawMatchBinaryRunnerImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/binary/RawMatchBinaryRunnerImpl.java:32, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/binary/RawMatchBinaryRunnerImpl.java:32
  • 2 public types in `uk.ac.ebi.interpro.scan.business.sequence.fasta` are marked as implementation by their own namespace, folder or name: `LoadFastaFileImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:34, name ends in `Impl`), `LoadFastaFileIntoDBImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:42, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:34
  • 1 public type in `uk.ac.ebi.interpro.scan.business.sequence.uniparcdb` is marked as implementation by its own namespace, folder or name: `LoadUniParcFromDBImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:19, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:19
  • 1 public type in `uk.ac.ebi.interpro.scan.genericjpadao` is marked as implementation by its own namespace, folder or name: `GenericDAOImpl` (core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:48, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:48
  • 3 public types in `uk.ac.ebi.interpro.scan.io` are marked as implementation by their own namespace, folder or name: `InstallerTemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/InstallerTemporaryDirectoryManagerImpl.java:13, name ends in `Impl`), `NoopTemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/NoopTemporaryDirectoryManagerImpl.java:10, name ends in `Impl`), `TemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/TemporaryDirectoryManagerImpl.java:23, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/InstallerTemporaryDirectoryManagerImpl.java:13
  • 1 public type in `uk.ac.ebi.interpro.scan.io.cli` is marked as implementation by its own namespace, folder or name: `CommandLineConversationImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:27, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:27
  • 2 public types in `uk.ac.ebi.interpro.scan.jms.activemq` are marked as implementation by their own namespace, folder or name: `MasterMessageSenderImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:27, name ends in `Impl`), `StepExecutionTransactionImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/StepExecutionTransactionImpl.java:29, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:27
  • 1 public type in `uk.ac.ebi.interpro.scan.jms.master` is marked as implementation by its own namespace, folder or name: `ResponseMonitorImpl` (REDACTED:24, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — REDACTED:24
  • 1 public type in `uk.ac.ebi.interpro.scan.jms.monitoring` is marked as implementation by its own namespace, folder or name: `MonitorQueueMessageListenerImpl` (REDACTED:23, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — REDACTED:23
  • 1 public type in `uk.ac.ebi.interpro.scan.jms.stats` is marked as implementation by its own namespace, folder or name: `ProducerCallbackImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/ProducerCallbackImpl.java:13, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/ProducerCallbackImpl.java:13
  • 2 public types in `uk.ac.ebi.interpro.scan.jms.worker` are marked as implementation by their own namespace, folder or name: `WorkerImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56, name ends in `Impl`), `WorkerMessageSenderImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:23, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56
  • 2 public types in `uk.ac.ebi.interpro.scan.management.dao` are marked as implementation by their own namespace, folder or name: `StepExecutionDAOImpl` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAOImpl.java:17, name ends in `Impl`), `StepInstanceDAOImpl` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepInstanceDAOImpl.java:20, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAOImpl.java:17
  • 15 public types in `uk.ac.ebi.interpro.scan.management.model.implementations` are marked as implementation by their own namespace, folder or name: `AbstractParseHmmpfamOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/AbstractParseHmmpfamOutputStep.java:27, `implementations`), `CompositeParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:32, `implementations`), `DeleteFileStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DeleteFileStep.java:19, `implementations`), `Domain` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/Domain.java:7, `implementations`), `DomainResolver` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DomainResolver.java:5, `implementations`), `FileContentChecker` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FileContentChecker.java:17, `implementations`), `FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:23, `implementations`), `MatchAndSitePostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:31, `implementations`), and 7 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/AbstractParseHmmpfamOutputStep.java:27
  • 4 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.cdd` are marked as implementation by their own namespace, folder or name: `CDDPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/CDDPostProcessingStep.java:13, `implementations`), `ParseCDDOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/ParseCDDOutputStep.java:16, `implementations`), `RunCDDPostBlastUtilityStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:26, `implementations`), `RunCDDRPSBlastStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDRPSBlastStep.java:23, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/CDDPostProcessingStep.java:13
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.coils` are marked as implementation by their own namespace, folder or name: `CoilsParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/CoilsParseStep.java:7, `implementations`), `RunCoilsBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/RunCoilsBinaryStep.java:24, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/CoilsParseStep.java:7
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.funfam` are marked as implementation by their own namespace, folder or name: `ParseAndPersisteStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:18, `implementations`), `RunFunFamBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/RunFunFamBinaryStep.java:13, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:18
  • 6 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.gene3d` are marked as implementation by their own namespace, folder or name: `Gene3DParseAndPersistOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:41, `implementations`), `Gene3DPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DPostProcessingStep.java:25, `implementations`), `RunAssignCathFamilyBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunAssignCathFamilyBinaryStep.java:16, `implementations`), `RunCathResolveHitsBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunCathResolveHitsBinaryStep.java:17, `implementations`), `RunDomainFinder3BinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunDomainFinder3BinaryStep.java:18, `implementations`), `WriteGene3dSsfFileStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:22, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:41
  • 4 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hamap` are marked as implementation by their own namespace, folder or name: `HamapCreateMiniDatabaseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:36, `implementations`), `HamapHmmPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:27, `implementations`), `HamapPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:26, `implementations`), `RunPFSearchStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:22, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:36
  • 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer` is marked as implementation by its own namespace, folder or name: `RunHmmerBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer/RunHmmerBinaryStep.java:22, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer/RunHmmerBinaryStep.java:22
  • 14 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3` are marked as implementation by their own namespace, folder or name: `AntiFamHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3FilterStep.java:14, `implementations`), `AntiFamHmmer3ParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3ParseStep.java:12, `implementations`), `Gene3dHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStep.java:27, `implementations`), `Gene3dHmmer3ParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3ParseStep.java:12, `implementations`), `NCBIfamFilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/NCBIfamFilterStep.java:10, `implementations`), `NCBIfamParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/NCBIfamParseStep.java:9, `implementations`), `PIRSRBinaryParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PIRSRBinaryParseStep.java:14, `implementations`), `PIRSRHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PIRSRHmmer3FilterStep.java:15, `implementations`), and 6 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3FilterStep.java:14
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3.PfamA` are marked as implementation by their own namespace, folder or name: `ParsePfam_A_HMMER3OutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/ParsePfam_A_HMMER3OutputStep.java:13, `implementations`), `Pfam_A_PostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:30, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/ParsePfam_A_HMMER3OutputStep.java:13
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.mobidb` are marked as implementation by their own namespace, folder or name: `ParseMobiDBOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/ParseMobiDBOutputStep.java:13, `implementations`), `RunMobiDBBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/RunMobiDBBinaryStep.java:19, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/ParseMobiDBOutputStep.java:13
  • 7 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.panther` are marked as implementation by their own namespace, folder or name: `PantherBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:22, `implementations`), `PantherNewBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:21, `implementations`), `PantherParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherParseStep.java:31, `implementations`), `PantherPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherPostProcessingStep.java:26, `implementations`), `PantherScoreStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherScoreStep.java:21, `implementations`), `RunPantherScoreStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherScoreStep.java:21, `implementations`), `RunPantherTreeGrafterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherTreeGrafterStep.java:20, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:22
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.phobius` are marked as implementation by their own namespace, folder or name: `ParsePhobiusOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/ParsePhobiusOutputStep.java:15, `implementations`), `RunPhobiusBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:23, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/ParsePhobiusOutputStep.java:15
  • 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.pirsf.hmmer3` is marked as implementation by its own namespace, folder or name: `PIRSFPostProcessAndPersistStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsf/hmmer3/PIRSFPostProcessAndPersistStep.java:25, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsf/hmmer3/PIRSFPostProcessAndPersistStep.java:25
  • 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.pirsr` is marked as implementation by its own namespace, folder or name: `RunPIRSRBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsr/RunPIRSRBinaryStep.java:24, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsr/RunPIRSRBinaryStep.java:24
  • 3 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.prints` are marked as implementation by their own namespace, folder or name: `ParsePrintsOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:28, `implementations`), `PrintsPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/PrintsPostProcessingStep.java:26, `implementations`), `RunFingerPrintScanStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/RunFingerPrintScanStep.java:21, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:28
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.prodom` are marked as implementation by their own namespace, folder or name: `ParseAndPersistProDomOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:31, `implementations`), `RunProDomBlast3iStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/RunProDomBlast3iStep.java:21, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:31
  • 9 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.prosite` are marked as implementation by their own namespace, folder or name: `ParseHamapPfsearchOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/ParseHamapPfsearchOutputStep.java:12, `implementations`), `ParsePrositeGffOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/ParsePrositeGffOutputStep.java:12, `implementations`), `PrositePatternsPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositePatternsPostProcessingStep.java:26, `implementations`), `PrositeProfilesPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositeProfilesPostProcessingStep.java:27, `implementations`), `RunHmmPfsearchStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunHmmPfsearchStep.java:22, `implementations`), `RunPFScanStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPFScanStep.java:20, `implementations`), `RunPatternScanStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPatternScanStep.java:20, `implementations`), `RunPrositeProfilesBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPrositeProfilesBinaryStep.java:20, `implementations`), and 1 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/ParseHamapPfsearchOutputStep.java:12
  • 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.sfld` is marked as implementation by its own namespace, folder or name: `RunSFLDBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/sfld/RunSFLDBinaryStep.java:24, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/sfld/RunSFLDBinaryStep.java:24
  • 3 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.signalp` are marked as implementation by their own namespace, folder or name: `ParseAndPersistBinaryOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:28, `implementations`), `RunSignalPBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/RunSignalPBinaryStep.java:23, `implementations`), `RunSignalPTempOptionCheckStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/RunSignalPTempOptionCheckStep.java:20, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:28
  • 3 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.smart` are marked as implementation by their own namespace, folder or name: `ParseSmartHmmpfamOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/ParseSmartHmmpfamOutputStep.java:30, `implementations`), `RunSmartBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/RunSmartBinaryStep.java:21, `implementations`), `SmartPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:26, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/ParseSmartHmmpfamOutputStep.java:30
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation` are marked as implementation by their own namespace, folder or name: `AbstractStepInstanceCreator` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/AbstractStepInstanceCreator.java:25, `implementations`), `StepInstanceCreatingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/StepInstanceCreatingStep.java:11, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/AbstractStepInstanceCreator.java:25
  • 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.memberDatabaseLoad` is marked as implementation by its own namespace, folder or name: `StepCreationSignatureDatabaseLoadListener` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/memberDatabaseLoad/StepCreationSignatureDatabaseLoadListener.java:30, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/memberDatabaseLoad/StepCreationSignatureDatabaseLoadListener.java:30
  • 3 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.nucleotide` are marked as implementation by their own namespace, folder or name: `RunGetOrfParserStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfParserStep.java:18, `implementations`), `RunGetOrfStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:20, `implementations`), `RunTranslateToProteinsStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java:20, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfParserStep.java:18
  • 6 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.proteinLoad` are marked as implementation by their own namespace, folder or name: `FastaFileLoadIntoDBStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:35, `implementations`), `FastaFileLoadStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:34, `implementations`), `FinaliseInitialSetupStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:30, `implementations`), `MatchLookupStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:36, `implementations`), `StepCreationSequenceLoadListener` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:29, `implementations`), `UniparcProteinLoadStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/UniparcProteinLoadStep.java:17, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:35
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.superfamily` are marked as implementation by their own namespace, folder or name: `ParseAndPersistSuperFamilyOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:29, `implementations`), `RunSuperFamilyAss3Step` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/RunSuperFamilyAss3Step.java:21, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:29
  • 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.tigrfam` are marked as implementation by their own namespace, folder or name: `ParseTigrFamHmmpfamOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tigrfam/ParseTigrFamHmmpfamOutputStep.java:15, `implementations`), `TigrFamPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tigrfam/TigrFamPostProcessingStep.java:23, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tigrfam/ParseTigrFamHmmpfamOutputStep.java:15
  • 3 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.tmhmm` are marked as implementation by their own namespace, folder or name: `TMHMMBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMBinaryStep.java:22, `implementations`), `TMHMMParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStep.java:7, `implementations`), `TMHMMParseStepOldV11` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStepOldV11.java:28, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMBinaryStep.java:22
  • 11 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.writer` are marked as implementation by their own namespace, folder or name: `CondensedViewHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:25, `implementations`), `GraphicalOutputResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/GraphicalOutputResultWriter.java:26, `implementations`), `MatchPopupHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/MatchPopupHTMLResultWriter.java:20, `implementations`), `PopupHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/PopupHTMLResultWriter.java:21, `implementations`), `ProteinMatchesHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:37, `implementations`), `ProteinMatchesSVGResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesSVGResultWriter.java:33, `implementations`), `ResiduePopupHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ResiduePopupHTMLResultWriter.java:20, `implementations`), `StructMatchPopupHTMLResultWriter` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/StructMatchPopupHTMLResultWriter.java:22, `implementations`), and 3 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:25

What to do

  • Hide `uk.ac.ebi.interpro.scan.business.binary` (`RawMatchBinaryRunnerImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.business.sequence.fasta` (`LoadFastaFileImpl`, `LoadFastaFileIntoDBImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.business.sequence.uniparcdb` (`LoadUniParcFromDBImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.genericjpadao` (`GenericDAOImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.io` (`InstallerTemporaryDirectoryManagerImpl`, `NoopTemporaryDirectoryManagerImpl`, `TemporaryDirectoryManagerImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.io.cli` (`CommandLineConversationImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.jms.activemq` (`MasterMessageSenderImpl`, `StepExecutionTransactionImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.jms.master` (`ResponseMonitorImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.jms.monitoring` (`MonitorQueueMessageListenerImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.jms.stats` (`ProducerCallbackImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.jms.worker` (`WorkerImpl`, `WorkerMessageSenderImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.dao` (`StepExecutionDAOImpl`, `StepInstanceDAOImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations` (`AbstractParseHmmpfamOutputStep`, `CompositeParseStep`, `DeleteFileStep`, `Domain`, `DomainResolver`, `FileContentChecker`, `FilterStep`, `MatchAndSitePostProcessingStep`, and 7 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.cdd` (`CDDPostProcessingStep`, `ParseCDDOutputStep`, `RunCDDPostBlastUtilityStep`, `RunCDDRPSBlastStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.coils` (`CoilsParseStep`, `RunCoilsBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.funfam` (`ParseAndPersisteStep`, `RunFunFamBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.gene3d` (`Gene3DParseAndPersistOutputStep`, `Gene3DPostProcessingStep`, `RunAssignCathFamilyBinaryStep`, `RunCathResolveHitsBinaryStep`, `RunDomainFinder3BinaryStep`, `WriteGene3dSsfFileStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.hamap` (`HamapCreateMiniDatabaseStep`, `HamapHmmPostProcessingStep`, `HamapPostProcessingStep`, `RunPFSearchStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer` (`RunHmmerBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3` (`AntiFamHmmer3FilterStep`, `AntiFamHmmer3ParseStep`, `Gene3dHmmer3FilterStep`, `Gene3dHmmer3ParseStep`, `NCBIfamFilterStep`, `NCBIfamParseStep`, `PIRSRBinaryParseStep`, `PIRSRHmmer3FilterStep`, and 6 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3.PfamA` (`ParsePfam_A_HMMER3OutputStep`, `Pfam_A_PostProcessingStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.mobidb` (`ParseMobiDBOutputStep`, `RunMobiDBBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.panther` (`PantherBinaryStep`, `PantherNewBinaryStep`, `PantherParseStep`, `PantherPostProcessingStep`, `PantherScoreStep`, `RunPantherScoreStep`, `RunPantherTreeGrafterStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.phobius` (`ParsePhobiusOutputStep`, `RunPhobiusBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.pirsf.hmmer3` (`PIRSFPostProcessAndPersistStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.pirsr` (`RunPIRSRBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.prints` (`ParsePrintsOutputStep`, `PrintsPostProcessingStep`, `RunFingerPrintScanStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.prodom` (`ParseAndPersistProDomOutputStep`, `RunProDomBlast3iStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.prosite` (`ParseHamapPfsearchOutputStep`, `ParsePrositeGffOutputStep`, `PrositePatternsPostProcessingStep`, `PrositeProfilesPostProcessingStep`, `RunHmmPfsearchStep`, `RunPFScanStep`, `RunPatternScanStep`, `RunPrositeProfilesBinaryStep`, and 1 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.sfld` (`RunSFLDBinaryStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.signalp` (`ParseAndPersistBinaryOutputStep`, `RunSignalPBinaryStep`, `RunSignalPTempOptionCheckStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.smart` (`ParseSmartHmmpfamOutputStep`, `RunSmartBinaryStep`, `SmartPostProcessingStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation` (`AbstractStepInstanceCreator`, `StepInstanceCreatingStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.memberDatabaseLoad` (`StepCreationSignatureDatabaseLoadListener`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.nucleotide` (`RunGetOrfParserStep`, `RunGetOrfStep`, `RunTranslateToProteinsStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.stepInstanceCreation.proteinLoad` (`FastaFileLoadIntoDBStep`, `FastaFileLoadStep`, `FinaliseInitialSetupStep`, `MatchLookupStep`, `StepCreationSequenceLoadListener`, `UniparcProteinLoadStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.superfamily` (`ParseAndPersistSuperFamilyOutputStep`, `RunSuperFamilyAss3Step`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.tigrfam` (`ParseTigrFamHmmpfamOutputStep`, `TigrFamPostProcessingStep`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.tmhmm` (`TMHMMBinaryStep`, `TMHMMParseStep`, `TMHMMParseStepOldV11`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.management.model.implementations.writer` (`CondensedViewHTMLResultWriter`, `GraphicalOutputResultWriter`, `MatchPopupHTMLResultWriter`, `PopupHTMLResultWriter`, `ProteinMatchesHTMLResultWriter`, `ProteinMatchesSVGResultWriter`, `ResiduePopupHTMLResultWriter`, `StructMatchPopupHTMLResultWriter`, and 3 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.persistence` (`AntiFamHmmer3FilteredMatchDAOImpl`, `CDDFilteredMatchDAOImpl`, `CoilsFilteredMatchDAOImpl`, `EntryDAOImpl`, `EntryKVDAOImpl`, `FilteredMatchAndSiteDAOImpl`, `FilteredMatchDAOImpl`, `FunFamHmmer3FilteredMatchDAOImpl`, and 28 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.persistence.installer` (`Entry2GoDAOImpl`, `Entry2PathwayDAOImpl`, `Entry2SignaturesDAOImpl`, `JdbcEntryDaoImpl`, `NoOpEntryDaoImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.persistence.raw` (`Gene3dHmmer3RawMatchDAOImpl`, `HamapRawMatchDAOImpl`, `PIRSFHmmer3RawMatchDAOImpl`, `PantherRawMatchDAOImpl`, `PfamHmmer3RawMatchDAOImpl`, `PrintsRawMatchDAOImpl`, `RawMatchDAOImpl`, `RawSiteDAOImpl`, and 1 more) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.precalc.berkeley.conversion.toi5` (`LookupStoreToI5ModelDAOImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.precalc.server.service.impl` (`AbstractDBService`, `BerkeleyMD5DBService`, `BerkeleyMatchDBService`, `BerkeleySiteDBService`, `MatchesServiceImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
  • Hide `uk.ac.ebi.interpro.scan.web.io` (`CreateSimpleProteinFromMatchDataImpl`) (Java: package-private (no modifier), or leave its package out of `module-info` exports): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
P2 · Observability8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
  • `REDACTED` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — REDACTED:35

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P6 · Release Hygiene8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • The changelog this check read carries 0 versioned entries, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.

What to do

  • Keep the changelog current — add a versioned entry (Keep-a-Changelog ## [x.y.z]) for each release so the history isn't a stub.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×2) — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:753, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:523
  • `HttpClients.createDefault(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×3) — REDACTED:127, REDACTED:231, REDACTED:495
  • `HttpClients.custom(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×2) — REDACTED:501, REDACTED:518

What to do

  • Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
PF1 · Benchmark discipline8.0 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

  • A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured. — core/benchmarking/src/main/java/uk/ac/ebi/interpro/scan/benchmarking/RunBenchmark.java

What to do

  • Run JMH with the GC profiler (`-prof gc`, or addProfiler(GCProfiler.class)) so allocation rate regressions are visible, not just time.
X13 · Undrained process stream2.7 / 10Weak✓ Tool-verified

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

  • The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file). (×6) — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:277, core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:307, core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:525, …

What to do

  • Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation8.0 / 10Strong✓ Tool-verified

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

  • `debug` at line 213 is called with an argument built by `Arrays.toString(siteInfo)` (line 213), whose cost grows with the collection it walks. Java evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isDebugEnabled`/`isTraceEnabled` test, no debug flag, no lambda or `Supplier` the logger calls only when the level is on. — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/cdd/CDDMatchParser.java:213

What to do

  • In Java, put the construction behind the logger's own check (`if (log.isDebugEnabled())` for SLF4J and Log4j, `if (logger.isLoggable(Level.FINE))` for java.util.logging), or hand the logger a lambda it calls only when the level is on (Log4j 2's `Supplier` overloads, SLF4J 2's `log.atDebug().addArgument(() -> …)`). A `{}` placeholder alone is not the fix: it defers the formatting, not the stream, join or serialisation in the argument.
X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated7.7 / 10Strong✓ Tool-verified

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

  • `this.entries` is enumerated directly, and line 138 calls `this.entries.add(…)` inside the loop body — a structural change to a `ArrayList`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:136
  • `domains.values()` is a live view over `domains` and shares its modification count, and line 330 calls `domains.remove(…)` inside the loop body — a structural change to a `HashMap`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen. — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:322

What to do

  • Each finding names the two spans that cannot both stand — the enhanced `for` source, and the call inside the body that structurally changes that same collection. Confirm from those two, then pick one: remove through the iterator itself (`Iterator<T> it = c.iterator(); … it.remove();`) or replace the loop with `c.removeIf(…)`; iterate a copy (`for (T x : new ArrayList<>(c))`); collect what needs changing and apply it after the loop; or — where the loop was only ever meant to act on the first match — `break` immediately after the mutation, which is the one shape that is already safe. In Python: Each finding names the two lines that cannot both stand — the `for` over the collection (or its `keys()`/`values()`/`items()` view), and the call inside the body that changes its size. Confirm from those two, then pick one: walk a snapshot (`for k in list(d):`, `for x in s.copy():`); build the result instead of editing in place (`d = {k: v for k, v in d.items() if keep(v)}`); collect what needs removing and remove it after the loop; or — where only the first match was ever meant — `break` straight after the change, which is the one shape that is already safe.
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging2.8 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `debug` at line 46 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:46
  • `debug` at line 117 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. (×2) — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:117, REDACTED:117
  • `info` at line 72 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:72
  • `error` at line 78 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:78
  • `error` at line 74 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:74
  • `info` at line 83 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:83
  • `warn` at line 141 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:141
  • `debug` at line 149 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:149
  • `info` at line 81 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:81
  • `warn` at line 52 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:52
  • `warn` at line 59 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:59
  • `warn` at line 77 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:77
  • `warn` at line 101 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:101
  • `warn` at line 120 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:120
  • `warn` at line 124 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:124
  • `error` at line 48 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryToGoDataResourceReader.java:48
  • `debug` at line 41 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:41
  • `debug` at line 85 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:85
  • `debug` at line 98 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:98
  • `debug` at line 37 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataResourceReader.java:37
  • `debug` at line 430 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:430
  • `debug` at line 464 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:464
  • `debug` at line 475 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:475
  • `debug` at line 476 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:476
  • `error` at line 102 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:102
  • `error` at line 112 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:112
  • `error` at line 107 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:107
  • `error` at line 117 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:117
  • `error` at line 109 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:109
  • `error` at line 119 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:119
  • `debug` at line 131 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:131
  • `debug` at line 221 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:221
  • `debug` at line 275 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:275
  • `debug` at line 382 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:382
  • `debug` at line 455 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:455
  • `debug` at line 473 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:473
  • `debug` at line 482 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:482
  • `debug` at line 88 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:88
  • `debug` at line 123 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:123

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 0/126 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.

What to do

  • Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).

WCAG coverage — what static analysis assessed

Statically assessed 13 of 55 WCAG 2.2 Level A/AA success criteria (24%; ≈26% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 42 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 42 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.1, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health50.2Adequate — gated by D2, X4, X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture78.5StrongSolid.
Maturity65.6Adequate — gated by D34Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness42.9Weak — gated by D8, P3, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security49.3Checked 5 of 11Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility70.6StrongSolid.
Performance80.0StrongStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 40 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 45 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
  • AC5 ARIA correctness — No ARIA usage found in the parsed markup — AC5 not applicable here.
  • AX4 Dependency direction — not applicable to a transaction-script/CRUD architecture (the inward-dependency rule is for layered/clean styles)
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — docker build failed (exit 1) — scan-core-${VERSION}.tar.gz && wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz.md5 && md5sum -c interproscan-core-${VERSION}.tar.gz.md5 && tar -zxf interproscan-core-${VERSION}.tar.gz && rm interproscan-core-${VERSION}.tar.gz* && mv /opt/interproscan-${VERSION} /opt/interproscan" did not complete successfully: exit code: 4; likely cause (our sandbox): a build step could not reach the network from our sandbox (a registry or download request was refused). This is a limit of our sandbox, not of your repository; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — Dependency currency not established — maven.java.net did not answer
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only; comments in this repository's .java, .py source were not judged.
  • D25 ADR Conformance — no ADRs to check
  • D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 9 aggregate root(s) (types guarding their own state behind command methods — this language has no AggregateRoot base to inherit); 5 value object(s)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage data present for 99 file(s), but no domain-layer files were identified: no covered file's path contains any of the markers this check keys on (/domain/, /aggregates/, /valueobjects/, /domainmodel/, .domain/, /entities/), which are matched case-insensitively anywhere in the path. With no domain partition there is nothing to compare the web/controller layer against — if this repository keeps its business rules under a folder named none of those, that naming is what the check cannot see, not the domain logic.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X12 Unreachable branch — X12 reached only 1% of this repository's production lines — java (79,746 lines), cpp (4,270 lines), c (3,352 lines), objectivec (430 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X2 Cancellation propagation — no C# was loaded; this repository's Java and Python were read, and no request in it can be cancelled by a caller — a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter; a Python request takes no token: asyncio cancels the task and trio or anyio the scope that made it, from outside the call, and requests, httpx, aiohttp and gRPC take a timeout, not a cancellation
  • X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 86 finding(s)
D30 · Dependency Vulnerabilities · High CVE · ×33
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 8 more in this group — see findings.md.
D28 · Secrets (history) · REDACTED · ×23
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC3 · Page structure · <html> without a lang · ×6
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structure.ftl:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structures.ftl:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/protein.ftl:7 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/proteins.ftl:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/reinit.ftl:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang core/web/src/main/webapp/WEB-INF/freemarker/views/render-warning.ftl:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×2
  • REDACTED
  • REDACTED
D31 · IaC & Container Security · High IaC · ×1
  • REDACTED
Serious — 1244 finding(s)
D17 · Explicit Debt · TodoComment · ×235
  • TodoComment core/web/src/test/java/uk/ac/ebi/interpro/scan/web/ProteinViewControllerTest.java:90 — // TODO: This is a really bad example -- we should replace this with a an XML file containing real protein data injected as a Spring resource — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/test/java/uk/ac/ebi/interpro/scan/web/model/SimpleEntryTest.java:34 — // TODO Change to @BeforeClass — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:97 — // TODO: Check if id is MD5 using regex (using Protein class code?) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:171 — // TODO: Check if id is MD5 using regex (using Protein class code?) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:101 — // TODO: Do not allow exception to go beyond here, otherwise user will see in browser — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:175 — // TODO: Do not allow exception to go beyond here, otherwise user will see in browser — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/MatchDataSource.java:277 — // TODO Inconsistent? SignatureLibrary (InterProScan) uses "TIGRFAM" and MatchDataSource (InterPro) uses "TIGRFAMS" — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleEntry.java:50 — // this.hierarchyLevel = 1; // TODO - Is this desirable? Current algorithm probably allows for this being null. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:139 — // TODO 23/07/14 Does this methods code work properly? newBuckets always empty here?! — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:44 — //TODO This does not parse feature matches - but this code is no longer used since the original REST service was retired — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:134 — // TODO Remove this eventually as fragments will never be empty once all matches have been recalculated — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:116 — //md5 = "N/A"; // TODO May need to get this from UAREAD in the future — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:38 — // TODO: Configure in Spring context — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:72 — // TODO: Shouldn't need this -- why isn't Spring giving us the resourceLoader?? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:93 — // TODO Note that we do not have the taxonomy information, but the protein structure web pages do not display that information anyway — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:152 — // TODO: Use MD5 as filter if not proteinAc — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:113 — // TODO signatureModels NULL for now as it's not in the TSV output (but can this class and associated tests all be deleted - obsolete?) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:118 — //TODo Fragments empty - remove all this code? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:61 — //TODO, this is usefull to check the performance of site lookup — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/precalcmatches/precalc-match-client/src/test/java/uk/ac/ebi/interpro/scan/precalc/client/MatchHttpClientTest.java:134 — // @Ignore // TODO This test doesn't work on all systems, beware: Connection to http://localhost:80 refused" type="org.apache.http.conn.HttpHostConnectException">org.apache.http.conn.HttpHostConnectException: Connection to http://localhost:80 refused
  • TodoComment REDACTED:407 — //TODO this is for TEM and testing only as the server with the correct versionis not yet ready; — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/BerkeleyToI5ModelDAO.java:12 — // * TODO: Description — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PantherBerkeleyMatchConverter.java:24 — //TODO: Add the e-value to the match location — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/SuperfamilyMatchConverter.java:29 — //TODO: Add the e-value to the match location — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/PantherLookupMatchConverter.java:14 — //TODO: Add the e-value to the match location — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 210 more in this group — see findings.md.
D8 · Code Coverage · Low coverage · ×98
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:1 — 0.0% line coverage (0/52).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ChunkerSingleton.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ChunkerSingleton.java:1 — 0.0% line coverage (0/28).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/CoilsMatch.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/CoilsMatch.java:1 — 0.0% line coverage (0/49).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DCStatus.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DCStatus.java:1 — 0.0% line coverage (0/29).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DateAdapter.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DateAdapter.java:1 — 0.0% line coverage (0/9).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Entry.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Entry.java:1 — 0.0% line coverage (0/212).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/EntryType.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/EntryType.java:1 — 0.0% line coverage (0/27).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java:1 — 0.0% line coverage (0/79).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FunFamHmmer3Match.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FunFamHmmer3Match.java:1 — 0.0% line coverage (0/37).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoCategory.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoCategory.java:1 — 0.0% line coverage (0/23).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java:1 — 0.0% line coverage (0/44).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmBounds.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmBounds.java:1 — 0.0% line coverage (0/30).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:1 — 0.0% line coverage (0/53).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:1 — 0.0% line coverage (0/85).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:1 — 0.0% line coverage (0/112).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:1 — 0.0% line coverage (0/60).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:1 — 0.0% line coverage (0/71).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java:1 — 0.0% line coverage (0/28).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java:1 — 0.0% line coverage (0/28).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Location.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Location.java:1 — 0.0% line coverage (0/186).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/LocationFragment.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/LocationFragment.java:1 — 0.0% line coverage (0/170).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/LocationWithSites.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/LocationWithSites.java:1 — 0.0% line coverage (0/31).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Match.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Match.java:1 — 0.0% line coverage (0/175).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/MobiDBMatch.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/MobiDBMatch.java:1 — 0.0% line coverage (0/54).
  • Low coverage: core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Model.java core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Model.java:1 — 0.0% line coverage (0/104).
  • + 73 more in this group — see findings.md.
D30 · Dependency Vulnerabilities · Medium CVE · ×35
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 10 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×19
  • Duplicated block (7 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:211 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:211-217 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:64-70 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:291 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:291-297 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:191-197 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:291` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:623 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:623-629 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:982-988 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:54 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:54-60 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:60-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86-92 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:75-81 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:439 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:439-445 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:535-541 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:439` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:447 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:447-454 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:603-609 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:447` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:445` calls `header` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:602` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:594 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:594-600 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:624-630 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:594` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:711 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:711-717 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:755-762 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:711` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:63 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:63-69 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDRPSBlastStep.java:49-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:75 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:75-81 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/SFLDHmmer3RawMatch.java:45-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:67 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:67-73 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:95-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:584 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:584-590 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:871-877 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmScanSearchRecord.java:73 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmScanSearchRecord.java:73-79 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmSearchRecord.java:77-83 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesWithNucleotidesXMLJAXBFragmentsResultWriter.java:99 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesWithNucleotidesXMLJAXBFragmentsResultWriter.java:99-106 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesXMLJAXBFragmentsResultWriter.java:124-130 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/exception/InvalidInputException.java:18 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/exception/InvalidInputException.java:18-24 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:238-244 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java:92 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java:92-98 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java:92-98 — before extracting anything, compare `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java` and `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DCStatus.java:72 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/DCStatus.java:72-78 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmBounds.java:73-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) REDACTED:120 — REDACTED:120-126 | REDACTED:466-472 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D3 · God Classes · TooManyMethods · ×16
  • TooManyMethods: WorkerImpl core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56 — TooManyMethods — 107 methods. The bar is 30 methods; this is 77 over it, 3.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: StatsUtil core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:30 — TooManyMethods — 88 methods. The bar is 30 methods; this is 58 over it, 2.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Signature core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Signature.java:51 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: WorkerState core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerState.java:32 — TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AbstractBlackBoxMaster core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractBlackBoxMaster.java:22 — TooManyMethods — 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Utilities core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:23 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SimpleProtein core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:14 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DistributedBlackBoxMaster core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:45 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BerkeleyLocation core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:23 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Step core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/Step.java:41 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SubmissionWorkerRunner core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/queuejumper/platforms/SubmissionWorkerRunner.java:25 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Protein REDACTED:50 — TooManyMethods — 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: WriteOutputStep core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:46 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Converter core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:41 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Run core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:54 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ProteinDAOImpl core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:52 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×15
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/AbstractResourceReader.java:23 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/AbstractResourceReader.java:23-31 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prints/FingerPRINTSHierarchyDBParser.java:40-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:200 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:200-208 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:519-527 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:200` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:235 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:235-243 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:271-279 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:235` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/CathResolverRecord.java:206 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/CathResolverRecord.java:206-214 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:279-287 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/CathResolverRecord.java:206` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:128 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:128-136 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:240-248 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:128` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:127` calls `verboseLog`, `toString` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:239` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:51 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:51-60 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:48-56 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:611 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:611-619 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:240-248 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:611` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) REDACTED:40 — REDACTED:40-48 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/monitoring/WorkerMonitorQueueListener.java:38-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116-124 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:105-113 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:114` calls `verboseLog`, `size` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:102` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:544 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:544-552 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:635-643 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:544` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:93 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:93-101 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawSiteDAOImpl.java:93-101 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:93` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:575 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:575-583 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:40-48 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (9 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:585 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:585-593 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:251-259 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:626 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:626-634 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:265-273 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:279 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:279-287 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocationFragment.java:107-115 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `that` to `BerkeleyLocation` in one and `BerkeleyLocationFragment` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×13
  • Duplicated block (8 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:193 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:193-200 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/AbstractStepInstanceCreator.java:122-129 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:193` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:45 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:45-52 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:165-172 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:699 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:699-707 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:743-750 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:699` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:751` calls `toLowerCase`, `contains` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:708` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:77 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:77-84 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java:85-92 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:371 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:371-378 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:162-169 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:371` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:182 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:182-189 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:288-296 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:596 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:596-603 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:51-58 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:477 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:477-484 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:585-592 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PatternScanMatch.java:101 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PatternScanMatch.java:101-108 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProfileScanMatch.java:106-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/BerkeleyMatchConverter.java:18 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/BerkeleyMatchConverter.java:18-25 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupMatchConverter.java:144-151 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:40 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:40-47 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:41-48 — before extracting anything, compare `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java` and `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) REDACTED:448 — REDACTED:448-455 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Signature.java:615-622 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProfileFilteredMatchDAO.java:65 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProfileFilteredMatchDAO.java:65-72 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrositePatternFilteredMatchDAO.java:64-71 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `rawMatch` to `T` in one and `ProSitePatternRawMatch` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · MethodTooLong · ×12
  • MethodTooLong: StandaloneBlackBoxMaster.run core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:49 — MethodTooLong — run runs 206 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 106 over it, 2.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LookupStoreToI5ModelDAOImpl.populateProteinMatches core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:74 — MethodTooLong — populateProteinMatches runs 191 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 91 over it, 1.91× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WorkerImpl.run core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:726 — MethodTooLong — run runs 147 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 47 over it, 1.47× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FastaFileLoadIntoDBStep.execute core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:80 — MethodTooLong — execute runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FastaFileLoadStep.execute core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:79 — MethodTooLong — execute runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Gene3DParseAndPersistOutputStep.execute core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:120 — MethodTooLong — execute runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PIRSRHmmer3MatchParser.parseFileInput core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:304 — MethodTooLong — parseFileInput runs 121 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 21 over it, 1.21× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AnalyseMatchDataResult.createSimpleProtein core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:93 — MethodTooLong — createSimpleProtein runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CreateMatchesDBFromOracle.buildDatabase core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:33 — MethodTooLong — buildDatabase runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BlastProDomMatchParser.createMatch core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/match/BlastProDomMatchParser.java:59 — MethodTooLong — createMatch runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ProteinMatchesTSVProResultWriter.write core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:41 — MethodTooLong — write runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SingleSeqOptimisedBlackBoxMaster.run core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:46 — MethodTooLong — run runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×12
  • Duplicated block (6 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:196 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:196-201 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:303-308 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:196` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:138 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:138-143 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/parsemodel/PhobiusFeature.java:38-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:128 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:128-133 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:135-140 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:152 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:152-157 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:164-169 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:152` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:206 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:206-211 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:220-225 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:206` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMPredictionTableParser.java:162 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMPredictionTableParser.java:162-167 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:201-206 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (6 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPFScanStep.java:111 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPFScanStep.java:111-116 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPsScanStep.java:111-128 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPFScanStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPsScanStep.java` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:110 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:110-115 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:161-166 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:110` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:128 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:128-133 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:98-103 — before extracting anything, compare `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:126` calls `add`, `kvValueOf` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:97` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) REDACTED:232 — REDACTED:232-237 | REDACTED:341-346 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:1074 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:1074-1079 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:122-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:307 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:307-312 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:191-196 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D10 · Test Quality · No assertions · ×11
  • No assertions: testWriter core/business/src/test/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/FastaFileWriterTest.java:53 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testLoader core/business/src/test/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileTest.java:56 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testParserEfficiency core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/coils/CoilsMatchParserTest.java:31 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testInstaller core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/activemq/InstallerTest.java:39 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: selectPerformanceTest core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/persistence/test/HibernateAnnotationTest.java:204 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: updatePerformanceTest core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/persistence/test/HibernateAnnotationTest.java:218 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSetNameMethod core/management/src/test/java/uk/ac/ebi/interpro/scan/management/BeanNameAwareTest.java:33 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testMarshal core/model/src/test/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchTest.java:74 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testIUPACNucleotideCharacters core/model/src/test/java/uk/ac/ebi/interpro/scan/model/NucleotideSequenceTest.java:72 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testProtein core/web/src/test/java/uk/ac/ebi/interpro/scan/web/ProteinStructureViewControllerTest.java:37 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testProtein core/web/src/test/java/uk/ac/ebi/interpro/scan/web/ProteinViewControllerTest.java:36 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×11
  • Duplicated block (11 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:295 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:295-305 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:151-161 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:295` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:357 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:357-367 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:177-187 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:369` calls `verboseLog`, `size` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:190` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) REDACTED:84 — REDACTED:84-94 | REDACTED:159-171 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:112 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:112-122 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:146-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:112` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:382 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:382-392 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:409-419 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:382` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:164 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:164-174 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:148-158 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:164` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:54 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:54-64 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:76-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:54` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:87` calls `isDebugEnabled`, `debug`, `toString` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:65` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) REDACTED:130 — REDACTED:130-140 | REDACTED:274-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:130` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:142` calls `warn` and `REDACTED:286` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:119 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:119-129 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:169-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:119` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:179 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:179-189 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:94-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:177 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:177-187 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:161-171 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×10
  • Duplicated block (10 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:219 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:219-228 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:72-81 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:219` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:180 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:180-189 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:470-479 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/JobStatusChecker.java:22 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/JobStatusChecker.java:22-31 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/JobStatusChecker.java:38-47 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/JobStatusChecker.java:22` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:80 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:80-89 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:84-93 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:826 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:826-835 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:850-859 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:826` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:81 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:81-90 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:80-89 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:263 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:263-272 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:159-168 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `m` to `Hmmer3RawMatch` in one and `T` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (10 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignalPFilteredMatchDAOImpl.java:97 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignalPFilteredMatchDAOImpl.java:97-106 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SuperFamilyHmmer3FilteredMatchDAOImpl.java:148-157 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignalPFilteredMatchDAOImpl.java:97` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:117 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:117-126 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:107-116 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:117` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:167 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:167-176 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:483-493 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×8
  • Edited copy of a member (9 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMPredictionTableParser.java:160 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMPredictionTableParser.java:160-169 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:199-207 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:169 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:169-177 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:180-188 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:32 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:32-40 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawSiteDAOImpl.java:34-43 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SignalPMatch.java:155 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SignalPMatch.java:155-165 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/MobiDBMatch.java:144-152 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AbstractHierarchyElementBuilder.java:38 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AbstractHierarchyElementBuilder.java:38-49 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java:92-100 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java:133 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java:133-141 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PathwayXref.java:87-95 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1802 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1802-1810 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:250-262 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:93 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:93-101 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:77-85 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×8
  • Duplicated block (14 lines × 2) core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:153 — core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:153-166 | core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:170-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `id` to `PK` in one and `String` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (14 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:118 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:118-131 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:112-125 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:118` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:27 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:27-40 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:49-62 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:27` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (14 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:287 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:287-300 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:276-289 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:287` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:285` calls `verboseLog` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:275` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:67 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:67-80 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:99-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:67` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:66` calls `setParameter` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:98` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) REDACTED:114 — REDACTED:114-127 | REDACTED:218-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:64 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:64-77 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataResourceReader.java:52-65 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (14 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:729 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:729-742 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:499-512 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×7
  • Edited copy of a member (13 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:73 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:73-86 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/SFLDHmmer3RawMatch.java:43-55 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:110 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:110-123 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:108-120 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:114 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:114-126 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:143-155 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:62 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:62-74 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDRPSBlastStep.java:48-60 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:464 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:464-480 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:531-543 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:621 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:621-633 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:635-647 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:152 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:152-164 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:496-508 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×7
  • Edited copy of a member (12 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:608 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:608-619 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:237-248 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:279 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:279-290 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:305-321 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractBlackBoxMaster.java:106 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractBlackBoxMaster.java:106-117 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractBlackBoxMaster.java:126-139 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:590 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:590-602 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:671-682 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:36 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:36-47 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:61-72 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) REDACTED:303 — REDACTED:303-314 | REDACTED:534-546 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:157 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:157-171 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:128-139 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×7
  • Duplicated block (5 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:131 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:131-135 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:181-185 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:131` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:307 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:307-312 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:326-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:307` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DPostProcessingStep.java:122 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DPostProcessingStep.java:122-126 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsf/hmmer3/PIRSFPostProcessAndPersistStep.java:74-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:106 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:106-110 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:67-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:32 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:32-36 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer3BerkeleyMatchConverter.java:31-35 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `match` to `SimpleLookupMatch` in one and `BerkeleyMatch` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer3BerkeleyMatchConverter.java:52 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer3BerkeleyMatchConverter.java:52-56 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/SuperfamilyMatchConverter.java:40-44 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer3BerkeleyMatchConverter.java:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/MatchLocationSvgElementBuilder.java:52 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/MatchLocationSvgElementBuilder.java:52-56 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/CondensedView.java:201-205 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×7
  • Outbound HTTP without resilience core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:753 — `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:523 — `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:127 — `HttpClients.createDefault(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:231 — `HttpClients.createDefault(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:495 — `HttpClients.createDefault(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:501 — `HttpClients.custom(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:518 — `HttpClients.custom(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
AC3 · Page structure · Page without a main landmark · ×6
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structure.ftl:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/protein-structures.ftl:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/protein.ftl:7 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/proteins.ftl:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/reinit.ftl:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark core/web/src/main/webapp/WEB-INF/freemarker/views/render-warning.ftl:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · FileTooLong · ×6
  • FileTooLong: main/Run.java core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java — FileTooLong — 1024 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 524 over it, 2.05× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: worker/WorkerImpl.java core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java — FileTooLong — 927 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: WorkerImpl (56-1640). The bar is 500 significant lines; this is 427 over it, 1.85× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: master/DistributedBlackBoxMaster.java core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java — FileTooLong — 901 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 401 over it, 1.80× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: implementations/PrepareForOutputStep.java core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java — FileTooLong — 753 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 253 over it, 1.51× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: implementations/WriteOutputStep.java core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java — FileTooLong — 563 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 63 over it, 1.13× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: stats/StatsUtil.java core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java — FileTooLong — 555 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 55 over it, 1.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×6
  • Edited copy of a member (15 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:68 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:68-82 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/SequenceDomainMatch.java:83-101 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawMatch.java:195 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawMatch.java:195-211 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawSite.java:141-155 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:240 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:240-254 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:277-291 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/coils/CoilsDummyParser.java:28 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/coils/CoilsDummyParser.java:28-42 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/mobidb/MobiDBDummyModelParser.java:31-46 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:60 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:60-74 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:69-88 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:575 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:575-589 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:358-372 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×6
  • Edited copy of a member (10 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:69 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:69-78 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:97-106 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:192 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:192-202 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:144-153 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:323 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:323-332 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:339-348 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) REDACTED:259 — REDACTED:259-268 | REDACTED:490-499 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:651 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:651-661 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:422-431 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawMatch.java:214 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawMatch.java:214-225 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RPSBlastRawSite.java:158-167 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×6
  • Edited copy of a member (8 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryDAOImpl.java:44 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryDAOImpl.java:44-51 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ReleaseDAOImpl.java:30-40 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/FunFamHmmer3RawMatch.java:41 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/FunFamHmmer3RawMatch.java:41-48 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Gene3dHmmer3RawMatch.java:65-73 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/EntryType.java:137 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/EntryType.java:137-144 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoCategory.java:84-91 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAO.java:74 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAO.java:74-81 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAO.java:171-178 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAO.java:83 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAO.java:83-90 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAO.java:180-187 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:93 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:93-101 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:83-90 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×6
  • Duplicated block (15 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:386 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:386-400 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:428-442 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:386` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:180 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:180-194 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:294-308 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 102 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java:61 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java:61-75 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/TigrfamHmmer2ParserSupport.java:61-75 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/TigrfamHmmer2ParserSupport.java` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:181 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:181-195 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/SequenceDomainMatch.java:182-196 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:181` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:170 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:170-184 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:129-143 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:170` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:315 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:315-329 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:89-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:315` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:86` calls `getGoXRefs`, `put`, `GoXrefSources` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:313` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×6
  • Duplicated block (13 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/ParseException.java:68 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/ParseException.java:68-80 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/ParseException.java:68-80 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/ParseException.java` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/ParseException.java` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:27 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:27-39 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/NonZeroExitOnUnrecoverableError.java:26-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:27` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:388 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:388-400 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:426-438 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:388` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:53 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:53-65 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMBinaryStep.java:96-108 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:53` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer2FilteredMatchDAO.java:55 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer2FilteredMatchDAO.java:55-67 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProfileFilteredMatchDAO.java:51-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer2FilteredMatchDAO.java:55` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:144 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:144-156 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:189-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:144` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×6
  • Duplicated block (12 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:26 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:26-37 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:52-63 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:26` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:247 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:247-258 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:346-357 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:247` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1178 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1178-1189 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1258-1269 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:185 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:185-196 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:247-258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:117 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:117-128 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStepOldV11.java:93-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:117` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:192 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:192-203 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:158-169 — before extracting anything, compare `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D6 · Cohesion (LCOM4) · Low cohesion · ×6
  • Low cohesion: KVDBImpl (LCOM4 16) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/kvstore/KVDBImpl.java:28 — KVDBImpl's methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ProteinDAOImpl (LCOM4 10) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:52 — ProteinDAOImpl's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PIRSRHmmer3MatchParser (LCOM4 5) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:32 — PIRSRHmmer3MatchParser's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Protein (LCOM4 5) REDACTED:50 — Protein's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Entry (LCOM4 4) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Entry.java:36 — Entry's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SimpleProtein (LCOM4 4) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:14 — SimpleProtein's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
X13 · Undrained process stream · Redirected process stream is never drained (deadlock) · ×6
  • Redirected process stream is never drained (deadlock) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:277 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
  • Redirected process stream is never drained (deadlock) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:307 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
  • Redirected process stream is never drained (deadlock) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:525 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
  • Redirected process stream is never drained (deadlock) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:95 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
  • Redirected process stream is never drained (deadlock) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:206 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
  • Redirected process stream is never drained (deadlock) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:241 — The JDK pipes both `stdout` and `stderr` of this child — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and `pr.waitFor()` is written before stdout and stderr is read, so nothing drains it while the parent waits. The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the wait never returns. Nothing fails loudly. Read every piped stream before (or while) waiting — a thread or `CompletableFuture` per stream — merge them with `redirectErrorStream(true)` and read the one stream before `waitFor`, or discard what you do not want with `redirectOutput`/`redirectError(ProcessBuilder.Redirect.DISCARD)` (or a file).
AX2 · Stateful singletons · Stateful singleton · ×5
  • Stateful singleton: JMSErrorHandler core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/JMSErrorHandler.java:17 — `JMSErrorHandler` is a singleton (@Service: the container shares one instance across every request thread) but mutates instance state outside any lock (errorCount; e.g. `errorCount` in `handleError` at line 23).
  • Stateful singleton: JMSTransportListener core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/JMSTransportListener.java:16 — `JMSTransportListener` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (previousIOExceptionTime, brokenConnection, exceptionsCount, lastInterrupt, interruptedConnection; e.g. `previousIOExceptionTime` in `onException` at line 52).
  • Stateful singleton: CreateSimpleProteinFromMatchDataImpl core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:25 — `CreateSimpleProteinFromMatchDataImpl` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (resourceLoader; e.g. `resourceLoader` in `retrieveMatches` at line 70).
  • Stateful singleton: EntryHierarchy core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:25 — `EntryHierarchy` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (entryColourMap, entryHierarchyDataMap, entryToGoTerms; e.g. `entryColourMap` in `init` at line 41).
  • Stateful singleton: MatchesServiceImpl core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:32 — `MatchesServiceImpl` is a singleton (@Repository: the container shares one instance across every request thread) but mutates instance state outside any lock (serviceName; e.g. `serviceName` in `setName` at line 319).
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×5
  • Edited copy of a member (11 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/CDDRawMatch.java:78 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/CDDRawMatch.java:78-88 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/SmartRawMatch.java:37-47 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java:76 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java:76-87 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SuperFamilyHmmer3Match.java:55-65 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:594 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:594-607 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:486-496 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/NucleicAcidMatchesHolder.java:64 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/NucleicAcidMatchesHolder.java:64-74 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProteinMatchesHolder.java:76-86 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) REDACTED:273 — REDACTED:273-283 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SuperMatch.java:89-99 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×5
  • Edited copy of a member (18 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/phobius/PhobiusDummyParser.java:29 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/phobius/PhobiusDummyParser.java:29-47 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMSignatureBuilder.java:25-42 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:110 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:110-128 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:136-153 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:410 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:410-427 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:842-859 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/FinaliseInitialSetupTasks.java:119 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/FinaliseInitialSetupTasks.java:119-138 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:507-524 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:178 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomainMatch.java:178-195 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/SequenceDomainMatch.java:176-196 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×5
  • Duplicated block (21 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:788 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:788-808 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:558-578 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (21 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:126 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:126-146 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:119-139 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:126` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:790 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:790-810 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:400-420 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:790` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (21 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:87 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:87-107 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:77-97 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (21 lines × 2) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:72 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:72-92 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:73-93 — before extracting anything, compare `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java` and `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×5
  • Duplicated block (18 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:91 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:91-108 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:89-106 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:91` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (18 lines × 2) REDACTED:63 — REDACTED:63-80 | REDACTED:65-82 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:63` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) REDACTED:77 — REDACTED:77-94 | REDACTED:147-164 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:77` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:145` calls `put` and `REDACTED:75` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (18 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleLocation.java:66 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleLocation.java:66-83 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleLocationFragment.java:45-62 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `that` to `SimpleLocation` in one and `SimpleLocationFragment` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:40 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:40-57 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3WithSitesLookupMatchConverter.java:40-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:58` calls `verboseLog`, `toString` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3WithSitesLookupMatchConverter.java:58` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×5
  • Duplicated block (13 lines × 3) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:297 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:297-309 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:149-161 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:119-131 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (13 lines × 3) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:335 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:335-347 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:117-129 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:163-175 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:335` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:332 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:332-344 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:768-780 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:378-390 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:332` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:345` calls `get`, `buildTarArchiveName`, `toString` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:782` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:235 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:235-247 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:230-242 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:172-184 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:235` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:233` calls `verboseLog`, `asList` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:227` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 3) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:84 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:84-96 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:148-160 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:104-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:84` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×5
  • Duplicated block (5 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:91 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:91-95 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/PrintsPostProcessingStep.java:71-75 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:74-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 3) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:52 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:52-56 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3WithSitesLookupMatchConverter.java:52-56 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/SuperfamilyLookupMatchConverter.java:36-40 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3LookupMatchConverter.java:58` calls `verboseLog`, `toString` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3WithSitesLookupMatchConverter.java:58` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:302 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:302-306 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:291-295 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:118-122 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:31 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/CondensedViewHTMLResultWriter.java:31-35 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/PopupHTMLResultWriter.java:26-30 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:42-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
  • Duplicated block (5 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:114 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:114-118 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:128-132 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:155-159 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×4
  • Edited copy of a member (25 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:184 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:184-212 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:214-238 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:86 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:86-110 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataRecord.java:130-160 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:23 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:23-47 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java:36-62 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/RunProDomBlast3iStep.java:78 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/RunProDomBlast3iStep.java:78-102 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/RunSuperFamilyAss3Step.java:92-120 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×4
  • Edited copy of a member (14 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java:109 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/GoXref.java:109-122 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PathwayXref.java:71-84 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PrositePatternsBerkeleyMatchConverter.java:20 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PrositePatternsBerkeleyMatchConverter.java:20-33 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PrositeProfilesBerkeleyMatchConverter.java:20-33 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/MobiDBBerkeleyMatchConverter.java:28 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/MobiDBBerkeleyMatchConverter.java:28-41 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/RPSBlastBerkeleyMatchConverter.java:26-41 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignatureDAOImpl.java:65 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignatureDAOImpl.java:65-78 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignatureDAOImpl.java:81-96 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×4
  • Edited copy of a member (7 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/ModelMatchTMP.java:50 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/ModelMatchTMP.java:50-56 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/SequenceMatch.java:45-51 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmScanSearchRecord.java:65 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmScanSearchRecord.java:65-71 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/HmmSearchRecord.java:69-75 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:205 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:205-212 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:156-162 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:119 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:119-125 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProfileScanMatch.java:145-151 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×4
  • Duplicated block (25 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:703 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:703-727 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:473-497 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (25 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1235 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1235-1259 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1494-1518 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (25 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:65 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:65-89 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:90-114 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:65` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:87` calls `isDebugEnabled`, `debug`, `toString` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:64` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (25 lines × 2) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:177 — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:177-201 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:204-228 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×4
  • Duplicated block (17 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:745 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:745-761 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:515-531 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:745` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:534` calls `getMessage` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:762` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (17 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:494 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:494-510 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:468-484 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (17 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:92 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:92-108 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java:105-121 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (17 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:71 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:71-87 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:69-85 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:71` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×4
  • Duplicated block (10–11 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:275 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:275-285 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:177-186 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:275` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10–11 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:81 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:81-90 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:78-88 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:81` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10–11 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:72 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:72-81 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:233-243 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:244` calls `getStepId` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:84` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10–11 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:260 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:260-270 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:256-265 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:258` calls `toString` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:251` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×4
  • Duplicated block (8–9 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:312 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:312-320 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:122-129 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:312` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:322` calls `toString`, `getEvalue` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:130` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8–9 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:212 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:212-219 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:337-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:346` calls `isInfoEnabled`, `info` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:221` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8–9 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:416 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:416-424 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:406-413 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:416` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8–9 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:448 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:448-456 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:972-979 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:448` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×3
  • Edited copy of a member (17 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:59 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:59-82 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:90-116 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/getorf/GetOrfDescriptionLineParser.java:24 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/getorf/GetOrfDescriptionLineParser.java:24-40 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/ntranslate/ORFDescriptionLineParser.java:29-49 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) REDACTED:175 — REDACTED:175-191 | REDACTED:333-354 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (10 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (10 members, 50+ identical tokens) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/AntiFamHmmer3ParserSupport.java:50 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/AntiFamHmmer3ParserSupport.java:50-72 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/FunFamHmmer3ParserSupport.java:37-61 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Gene3DHmmer3ParserSupport.java:53-83 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Gene3DHmmer3ParserSupport.java:90-120 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/NCBIfamParserSupport.java:50-72 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSFHmmer3ParserSupport.java:30-53 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3ParserSupport.java:54-79 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Pfam_A_Hmmer3Hmmer3ParserSupport.java:90-131 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3ParserSupport.java:54-76 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/TigrFamHmmer3ParserSupport.java:50-72 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
  • Members sharing a duplicated core (10 members, 50+ identical tokens) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:78 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:78-191 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:70-144 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:82-215 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:138-207 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:120-312 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:103-207 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:72-154 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:64-136 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:61-132 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:62-139 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
  • Members sharing a duplicated core (10 members, 50+ identical tokens) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:69 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:69-87 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:89-179 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:73-144 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:72-126 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStep.java:95-121 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:89-158 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositePatternsPostProcessingStep.java:72-93 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositeProfilesPostProcessingStep.java:73-94 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:71-127 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tigrfam/TigrFamPostProcessingStep.java:62-77 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (4 members, 50+ identical tokens) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:109 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:109-128 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:128-160 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:137-169 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherScoreStep.java:148-180 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:423 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:423-518 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:572-660 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:869-903 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:905-929 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:76 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:76-112 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:140-182 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FunFamHmmer3FilteredMatchDAOImpl.java:12-108 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:95-141 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×3
  • Edited copy of a member (26 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:203 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:203-228 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:55-81 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:49 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:49-74 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:59-99 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:61 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:61-86 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2SignaturesDAOImpl.java:88-114 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×3
  • Edited copy of a member (22 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/cdd/CDDPostProcessing.java:45 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/cdd/CDDPostProcessing.java:45-68 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prosite/PatternPostProcessing.java:43-64 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:45 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:45-67 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:44-65 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:135 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:135-156 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/MatchesServiceImpl.java:180-201 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×3
  • Edited copy of a member (24 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:962 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:962-986 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:1029-1052 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:42 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:42-65 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMBinaryStep.java:74-108 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:457 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:457-483 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1008-1031 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×3
  • Edited copy of a member (20 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:25 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:25-44 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFMonitor.java:51-70 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:24 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:24-43 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/NonZeroExitOnUnrecoverableError.java:24-44 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:21 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:21-40 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/QueueBrowser.java:42-62 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×3
  • Edited copy of a member (19 corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:113 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:113-131 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataRecord.java:163-187 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/smart/SmartOverlappingFileParser.java:30 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/smart/SmartOverlappingFileParser.java:30-49 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/smart/SmartThresholdFileParser.java:46-64 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:69 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:69-87 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:67-85 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×3
  • Edited copy of a member (16 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:147 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:147-165 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/SsfFileWriter.java:21-36 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/NucleotideSequenceLoader.java:56 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/NucleotideSequenceLoader.java:56-73 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:114-129 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:214 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:214-229 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:397-416 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 11+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 11+ corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryKVDAOImpl.java:43 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryKVDAOImpl.java:43-53 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/MatchDAOImpl.java:62-74 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/MatchDAOImpl.java:77-88 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 11+ corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAOImpl.java:62 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAOImpl.java:62-73 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAOImpl.java:127-138 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAOImpl.java:164-174 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 11+ corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMProtein.java:47 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMProtein.java:47-57 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RawProtein.java:69-79 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/RawProteinSite.java:63-73 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 9+ corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/RunFingerPrintScanStep.java:68 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/RunFingerPrintScanStep.java:68-76 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPFScanStep.java:109-119 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunPsScanStep.java:109-131 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 9+ corresponding lines) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:385 — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:385-395 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:413-421 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:424-433 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 9+ corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/Jobs.java:60 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/Jobs.java:60-68 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/Jobs.java:70-78 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/Jobs.java:214-225 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×3
  • Edited copy of a member (6 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:65 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawMatch.java:65-71 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSFHmmer3RawMatch.java:43-48 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:545 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:545-550 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:861-867 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:53 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2GoDAOImpl.java:53-59 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/Entry2PathwayDAOImpl.java:52-57 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×3
  • Duplicated block (27 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/MatchPopupHTMLResultWriter.java:31 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/MatchPopupHTMLResultWriter.java:31-57 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ResiduePopupHTMLResultWriter.java:31-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (27 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:118 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:118-144 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesSVGResultWriter.java:54-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:118` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (27 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:103 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:103-129 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunHmmPfsearchStep.java:143-169 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunHmmPfsearchStep.java` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:103` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunHmmPfsearchStep.java:141` calls `buildFullyQualifiedFilePath`, `getFastaFileNameFilteredTemplate` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:100` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14 lines × 4) · ×3
  • Duplicated block (14 lines × 4) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1230 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1230-1243 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1327-1340 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1424-1437 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1489-1502 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1230` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1341` calls `setDeprecated` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1244` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:120 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:120-133 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:291-304 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:111-124 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:108-121 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:120` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:210 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:210-223 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:206-219 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:96-109 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:147-160 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:210` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:161` calls `verboseLog`, `getLibrary`, `getName` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:224` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×3
  • Duplicated block (12–13 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:397 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:397-409 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:215-226 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (12–13 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/PrositePfsearchMatchParser.java:68 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/PrositePfsearchMatchParser.java:68-79 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/PrositePfsearchMatchParser.java:86-98 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/PrositePfsearchMatchParser.java:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12–13 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:43 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:43-54 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:41-53 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:56` calls `getSignatureModels` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:55` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×3
  • Duplicated block (6 lines × 3) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:93 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:93-98 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataRecord.java:137-142 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataRecord.java:63-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FeatureMatchDataRecord.java:100` calls `getMethodName` and `core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataRecord.java:144` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:149 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:149-154 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:129-134 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:169-174 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 3) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:88 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:88-94 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:94-99 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:95-101 — before extracting anything, compare `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java` and `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D5 · Coupling · Off the main sequence · ×3
  • Off the main sequence: interproscan-util — interproscan-util: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
  • Off the main sequence: berkeley — berkeley: abstractness 0.06, instability 0.00, distance 0.94 — an application entry point, so it is concrete by design — the distance is expected; what is worth checking is that other projects depend on it at all, since a host should be a leaf of the graph.
  • Off the main sequence: interproscan-model — interproscan-model: abstractness 0.18, instability 0.00, distance 0.82 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
D17 · Explicit Debt · FixmeComment · ×2
  • FixmeComment core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:127 — //FIXME disable this and load them during the PrepareOutPut Step — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:989 — //FIXME calling this in multiple threads might cause a problem — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×2
  • Edited copy of a member (36 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:487 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:487-522 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:268-303 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (36 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:525 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:525-560 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:306-341 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (5 members, 50+ identical tokens) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:52 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:52-119 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:61-147 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:51-146 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:68-127 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:64-143 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:142 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:142-167 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:132-157 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:259-284 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:164-190 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:124-149 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×2
  • Edited copy of a member (32 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:600 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:600-643 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:383-414 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (32 corresponding lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:116 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:116-147 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:150-189 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×2
  • Edited copy of a member (31 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java:45 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/SmartHmmer2ParserSupport.java:45-75 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/TigrfamHmmer2ParserSupport.java:45-75 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (31 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:99 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:99-129 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/RunHmmPfsearchStep.java:139-169 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×2
  • Edited copy of a member (33 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/serialization/ObjectSerializerDeserializer.java:69 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/serialization/ObjectSerializerDeserializer.java:69-101 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/serialization/ObjectSerializerDeserializer.java:109-143 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (33 corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesWithNucleotidesXMLJAXBFragmentsResultWriter.java:54 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesWithNucleotidesXMLJAXBFragmentsResultWriter.java:54-86 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesXMLJAXBFragmentsResultWriter.java:61-105 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×2
  • Edited copy of a member (28 corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer2LookupMatchConverter.java:14 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer2LookupMatchConverter.java:14-42 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/PantherLookupMatchConverter.java:16-43 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (28 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:169 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:169-198 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:24-51 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 16+ corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:50 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:50-65 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:64-83 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:32-49 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 16+ corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:249 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:249-264 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:267-282 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/EntryRowCallbackHandler.java:284-299 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 7+ corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:309 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:309-315 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:208-214 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/RPSBlastMatch.java:205-211 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryKVDAOImpl.java:34 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/EntryKVDAOImpl.java:34-40 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/MatchDAOImpl.java:37-43 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:151-157 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (40 lines × 2) · ×2
  • Duplicated block (40 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:120 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:120-159 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:116-155 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:120` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (40 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:163 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:163-202 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:159-198 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:163` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (34 lines × 2) · ×2
  • Duplicated block (34 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:666 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:666-699 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:436-469 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (34 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:77 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:77-110 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:76-109 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×2
  • Duplicated block (31 lines × 2) REDACTED:166 — REDACTED:166-196 | REDACTED:242-272 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (31 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/HamapMatchParser.java:18 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/HamapMatchParser.java:18-48 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/HamapPfsearchMatchParser.java:16-46 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/HamapMatchParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prosite/HamapPfsearchMatchParser.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×2
  • Duplicated block (24 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:24 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:24-47 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java:39-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java:39` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (24 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GoXrefComparator.java:1 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GoXrefComparator.java:1-24 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/PathwayXrefComparator.java:1-24 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GoXrefComparator.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×2
  • Duplicated block (23 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:763 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:763-785 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:533-555 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:763` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (23 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PIRSFHmmer3RawMatchDAOImpl.java:43 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PIRSFHmmer3RawMatchDAOImpl.java:43-65 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PfamHmmer3RawMatchDAOImpl.java:45-67 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PIRSFHmmer3RawMatchDAOImpl.java:43` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×2
  • Duplicated block (20 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:371 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:371-390 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:190-209 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:369` calls `verboseLog`, `size` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:187` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (20 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:187 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:187-206 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:196-215 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:194` calls `buildFullyQualifiedFilePath`, `getInputFileNameDomTbloutTemplate` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:184` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:210 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:210-228 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:219-237 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:210` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (19 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:156 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:156-174 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:235-253 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:156` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×2
  • Duplicated block (22 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1200 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1200-1221 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1301-1322 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1200` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PrintsRawMatchDAOImpl.java:50 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/PrintsRawMatchDAOImpl.java:50-71 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/SmartHmmer2RawMatchDAOImpl.java:47-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:412 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:412-427 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:844-859 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:412` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1316 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1316-1331 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1413-1428 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1316` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×2
  • Duplicated block (15 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1210 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1210-1224 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1311-1325 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1408-1422 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1210` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 3) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/AntiFamHmmer3RawMatch.java:27 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/AntiFamHmmer3RawMatch.java:27-41 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/NCBIfamRawMatch.java:24-38 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/TigrFamHmmer3RawMatch.java:27-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×2
  • Duplicated block (12 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:117 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:117-128 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:149-160 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:158-169 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherScoreStep.java:169-180 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (12 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:198 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:198-209 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:194-205 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:83-94 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:135-146 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:198` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:132` calls `getParameters`, `get` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:195` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×2
  • Duplicated block (10 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:190 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:190-199 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:209-218 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:229-238 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:190` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:201` calls `isDeprecated` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:240` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 3) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/CDDRawSite.java:75 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/CDDRawSite.java:75-84 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/PIRSRHmmer3RawSite.java:154-163 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/SFLDHmmer3RawSite.java:53-62 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `that` to `CDDRawSite` in one and `PIRSRHmmer3RawSite` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×2
  • Duplicated block (9–10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:114 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:114-122 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:133-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:114` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9–10 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:107 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:107-115 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:92-101 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:107` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×2
  • Duplicated block (9 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:597 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:597-605 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:881-889 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:910-918 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:597` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:61 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:61-69 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawMatchDAOImpl.java:146-154 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/raw/RawSiteDAOImpl.java:64-72 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:236 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:236-243 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:272-279 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:300-309 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:236` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForProtSeqs.java:46 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForProtSeqs.java:46-53 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:43-50 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:41-48 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForProtSeqs.java:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×2
  • Duplicated block (7 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:42 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:42-48 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:41-47 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:40-46 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:468 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:468-474 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:380-386 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:490-496 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×2
  • Duplicated block (6 lines × 4) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:72 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:72-77 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:60-65 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:77-82 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:74-79 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:70` calls `StringBuffer` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:75` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 4) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:266 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:266-271 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:461-466 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:373-378 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:111-116 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java` and `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×2
  • Duplicated block (5 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86-90 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:145-150 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:107-112 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:75-80 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:104` calls `currentTimeMillis` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:72` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:118 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:118-122 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:121-125 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:140-144 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:119-123 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart.
X27 · Collection changed while being enumerated · Collection is structurally changed while it is being enumerated · ×2
  • Collection is structurally changed while it is being enumerated core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:136 — `this.entries` is enumerated directly, and line 138 calls `this.entries.add(…)` inside the loop body — a structural change to a `ArrayList`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen.
  • Collection is structurally changed while it is being enumerated core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:322 — `domains.values()` is a live view over `domains` and shares its modification count, and line 330 calls `domains.remove(…)` inside the loop body — a structural change to a `HashMap`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen.
AC6 · Visual & motion safety · Focus outline removed in CSS without a · ×1
  • Focus outline removed in CSS without a :focus replacement core/web/src/main/webapp/resources/javascript/qtip2/jquery.qtip.css:71 — `.ui-tooltip-titlebar .ui-state-default` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D1 · Cyclomatic Complexity · 2.run (cyclomatic 70) · ×1
  • 2.run (cyclomatic 70) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:949 — 2.run has cyclomatic complexity 70 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DistributedBlackBoxMaster.run (cyclomatic 58) · ×1
  • DistributedBlackBoxMaster.run (cyclomatic 58) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:99 — DistributedBlackBoxMaster.run has cyclomatic complexity 58 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Run.main (cyclomatic 56) · ×1
  • Run.main (cyclomatic 56) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:107 — Run.main has cyclomatic complexity 56 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StepCreationSequenceLoadListener.sequencesLoaded (cyclomatic 52) · ×1
  • StepCreationSequenceLoadListener.sequencesLoaded (cyclomatic 52) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:95 — StepCreationSequenceLoadListener.sequencesLoaded has cyclomatic complexity 52 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StandaloneBlackBoxMaster.run (cyclomatic 43) · ×1
  • StandaloneBlackBoxMaster.run (cyclomatic 43) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:49 — StandaloneBlackBoxMaster.run has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LookupStoreToI5ModelDAOImpl.populateProteinMatches (cyclomatic 40) · ×1
  • LookupStoreToI5ModelDAOImpl.populateProteinMatches (cyclomatic 40) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:74 — LookupStoreToI5ModelDAOImpl.populateProteinMatches has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus.write_nexus_data (cyclomatic 40) · ×1
  • Nexus.write_nexus_data (cyclomatic 40) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1535 — Nexus.write_nexus_data has cyclomatic complexity 40 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · WorkerImpl.run (cyclomatic 39) · ×1
  • WorkerImpl.run (cyclomatic 39) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:726 — WorkerImpl.run has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Hmmer3SearchMatchParser.parse (cyclomatic 38) · ×1
  • Hmmer3SearchMatchParser.parse (cyclomatic 38) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:161 — Hmmer3SearchMatchParser.parse has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FastaFileLoadIntoDBStep.execute (cyclomatic 38) · ×1
  • FastaFileLoadIntoDBStep.execute (cyclomatic 38) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:80 — FastaFileLoadIntoDBStep.execute has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Array.__new__ (cyclomatic 38) · ×1
  • Array.__new__ (cyclomatic 38) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/substitution_matrices/__init__.py:27 — Array.__new__ has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FastaFileLoadStep.execute (cyclomatic 37) · ×1
  • FastaFileLoadStep.execute (cyclomatic 37) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:79 — FastaFileLoadStep.execute has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PIRSFPostProcessor.processProtein (cyclomatic 36) · ×1
  • PIRSFPostProcessor.processProtein (cyclomatic 36) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pirsf/PIRSFPostProcessor.java:57 — PIRSFPostProcessor.processProtein has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BlastProDomMatchParser.createMatch (cyclomatic 36) · ×1
  • BlastProDomMatchParser.createMatch (cyclomatic 36) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/match/BlastProDomMatchParser.java:59 — BlastProDomMatchParser.createMatch has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BerkeleyLocation.equals (cyclomatic 36) · ×1
  • BerkeleyLocation.equals (cyclomatic 36) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:200 — BerkeleyLocation.equals has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Hmmer3ScanMatchParser.parse (cyclomatic 35) · ×1
  • Hmmer3ScanMatchParser.parse (cyclomatic 35) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:257 — Hmmer3ScanMatchParser.parse has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PrepareForOutputStep.simulateMarshalling (cyclomatic 35) · ×1
  • PrepareForOutputStep.simulateMarshalling (cyclomatic 35) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:322 — PrepareForOutputStep.simulateMarshalling has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BerkeleyLocation.compareTo (cyclomatic 35) · ×1
  • BerkeleyLocation.compareTo (cyclomatic 35) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:278 — BerkeleyLocation.compareTo has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProteinMatchesTSVResultWriter.write (cyclomatic 33) · ×1
  • ProteinMatchesTSVResultWriter.write (cyclomatic 33) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:40 — ProteinMatchesTSVResultWriter.write has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus._format (cyclomatic 32) · ×1
  • Nexus._format (cyclomatic 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:789 — Nexus._format has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus.append_sets (cyclomatic 32) · ×1
  • Nexus.append_sets (cyclomatic 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1709 — Nexus.append_sets has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CreateMatchesDBFromOracle.buildDatabase (cyclomatic 31) · ×1
  • CreateMatchesDBFromOracle.buildDatabase (cyclomatic 31) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:33 — CreateMatchesDBFromOracle.buildDatabase has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus._matrix (cyclomatic 31) · ×1
  • Nexus._matrix (cyclomatic 31) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1015 — Nexus._matrix has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · parsehmmer.parsehmmsearch (cyclomatic 31) · ×1
  • parsehmmer.parsehmmsearch (cyclomatic 31) core/jms-implementation/support-mini-x86-32/bin/pirsr/0.1/parsehmmer.py:26 — parsehmmer.parsehmmsearch has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Run.checkIfBlackBoxMasterAndConfigure (cyclomatic 30) · ×1
  • Run.checkIfBlackBoxMasterAndConfigure (cyclomatic 30) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:577 — Run.checkIfBlackBoxMasterAndConfigure has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Run.checkIfDistributedWorkerAndConfigure (cyclomatic 30) · ×1
  • Run.checkIfDistributedWorkerAndConfigure (cyclomatic 30) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:891 — Run.checkIfDistributedWorkerAndConfigure has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StatsUtil.displayMasterProgress (cyclomatic 29) · ×1
  • StatsUtil.displayMasterProgress (cyclomatic 29) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:761 — StatsUtil.displayMasterProgress has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Gene3DParseAndPersistOutputStep.execute (cyclomatic 29) · ×1
  • Gene3DParseAndPersistOutputStep.execute (cyclomatic 29) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:120 — Gene3DParseAndPersistOutputStep.execute has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Converter.run (cyclomatic 27) · ×1
  • Converter.run (cyclomatic 27) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:179 — Converter.run has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · treegrafter.parsehmmsearch (cyclomatic 27) · ×1
  • treegrafter.parsehmmsearch (cyclomatic 27) core/jms-implementation/support-mini-x86-32/bin/panther/treegrafter.py:246 — treegrafter.parsehmmsearch has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ParseStep.execute (cyclomatic 26) · ×1
  • ParseStep.execute (cyclomatic 26) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:82 — ParseStep.execute has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WriteOutputStep.execute (cyclomatic 26) · ×1
  • WriteOutputStep.execute (cyclomatic 26) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:186 — WriteOutputStep.execute has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AnalyseMatchDataResult.createSimpleProtein (cyclomatic 26) · ×1
  • AnalyseMatchDataResult.createSimpleProtein (cyclomatic 26) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:93 — AnalyseMatchDataResult.createSimpleProtein has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PrintsMatchParser.parse (cyclomatic 25) · ×1
  • PrintsMatchParser.parse (cyclomatic 25) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prints/PrintsMatchParser.java:43 — PrintsMatchParser.parse has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HmmerModelParser.parse (cyclomatic 25) · ×1
  • HmmerModelParser.parse (cyclomatic 25) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:61 — HmmerModelParser.parse has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DistributedBlackBoxMasterOLD.run (cyclomatic 25) · ×1
  • DistributedBlackBoxMasterOLD.run (cyclomatic 25) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:31 — DistributedBlackBoxMasterOLD.run has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CreateSitesDBFromOracle.buildDatabase (cyclomatic 25) · ×1
  • CreateSitesDBFromOracle.buildDatabase (cyclomatic 25) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:32 — CreateSitesDBFromOracle.buildDatabase has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · idrpred.get_region_features (cyclomatic 25) · ×1
  • idrpred.get_region_features (cyclomatic 25) core/jms-implementation/support-mini-x86-32/bin/mobidb/idrpred/__init__.py:235 — idrpred.get_region_features has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus._kill_comments_and_break_lines (cyclomatic 25) · ×1
  • Nexus._kill_comments_and_break_lines (cyclomatic 25) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:478 — Nexus._kill_comments_and_break_lines has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Run.getApplications (cyclomatic 24) · ×1
  • Run.getApplications (cyclomatic 24) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1155 — Run.getApplications has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Run.setupSimpleBlackBoxMaster (cyclomatic 24) · ×1
  • Run.setupSimpleBlackBoxMaster (cyclomatic 24) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:747 — Run.setupSimpleBlackBoxMaster has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SubmissionWorkerRunner.startupNewWorker (cyclomatic 24) · ×1
  • SubmissionWorkerRunner.startupNewWorker (cyclomatic 24) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/queuejumper/platforms/SubmissionWorkerRunner.java:244 — SubmissionWorkerRunner.startupNewWorker has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Writer.process_clade (cyclomatic 24) · ×1
  • Writer.process_clade (cyclomatic 24) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/CDAOIO.py:332 — Writer.process_clade has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · Run.getDeprecatedApplications (cyclomatic 23) · ×1
  • Run.getDeprecatedApplications (cyclomatic 23) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1268 — Run.getDeprecatedApplications has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SingleSeqOptimisedBlackBoxMaster.run (cyclomatic 23) · ×1
  • SingleSeqOptimisedBlackBoxMaster.run (cyclomatic 23) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:46 — SingleSeqOptimisedBlackBoxMaster.run has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EntryHierarchyDataResourceReader.read (cyclomatic 23) · ×1
  • EntryHierarchyDataResourceReader.read (cyclomatic 23) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:28 — EntryHierarchyDataResourceReader.read has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parse (cyclomatic 23) · ×1
  • Parser.parse (cyclomatic 23) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/NeXMLIO.py:142 — Parser.parse has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LoadFastaFileIntoDBImpl.loadSequences (cyclomatic 22) · ×1
  • LoadFastaFileIntoDBImpl.loadSequences (cyclomatic 22) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:104 — LoadFastaFileIntoDBImpl.loadSequences has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HmmPfamParser.parse (cyclomatic 22) · ×1
  • HmmPfamParser.parse (cyclomatic 22) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/HmmPfamParser.java:145 — HmmPfamParser.parse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SuperFamilyHmmer3MatchParser.parseLine (cyclomatic 22) · ×1
  • SuperFamilyHmmer3MatchParser.parseLine (cyclomatic 22) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/match/SuperFamilyHmmer3MatchParser.java:102 — SuperFamilyHmmer3MatchParser.parseLine has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · Run.getExcludedApplications (cyclomatic 22) · ×1
  • Run.getExcludedApplications (cyclomatic 22) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1370 — Run.getExcludedApplications has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BerkeleyPrecalculatedProteinLookup.getPrecalculated (cyclomatic 21) · ×1
  • BerkeleyPrecalculatedProteinLookup.getPrecalculated (cyclomatic 21) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:308 — BerkeleyPrecalculatedProteinLookup.getPrecalculated has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SFLDHmmer3MatchParser.parseMatchesAndSites (cyclomatic 21) · ×1
  • SFLDHmmer3MatchParser.parseMatchesAndSites (cyclomatic 21) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3MatchParser.java:88 — SFLDHmmer3MatchParser.parseMatchesAndSites has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 1.run (cyclomatic 21) · ×1
  • 1.run (cyclomatic 21) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:225 — 1.run has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LocalJobQueueListener.onMessage (cyclomatic 21) · ×1
  • LocalJobQueueListener.onMessage (cyclomatic 21) REDACTED:117 — LocalJobQueueListener.onMessage has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CompositeParseStep.execute (cyclomatic 21) · ×1
  • CompositeParseStep.execute (cyclomatic 21) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:78 — CompositeParseStep.execute has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PantherFilteredMatchDAOImpl.persist (cyclomatic 21) · ×1
  • PantherFilteredMatchDAOImpl.persist (cyclomatic 21) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:60 — PantherFilteredMatchDAOImpl.persist has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Tree._parse (cyclomatic 21) · ×1
  • Tree._parse (cyclomatic 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:87 — Tree._parse has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · _utils.draw (cyclomatic 21) · ×1
  • _utils.draw (cyclomatic 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/_utils.py:320 — _utils.draw has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Seq._translate_str (cyclomatic 21) · ×1
  • Seq._translate_str (cyclomatic 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Seq.py:2741 — Seq._translate_str has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PfamHMMER3PostProcessing.processProtein (cyclomatic 20) · ×1
  • PfamHMMER3PostProcessing.processProtein (cyclomatic 20) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pfam_A/PfamHMMER3PostProcessing.java:76 — PfamHMMER3PostProcessing.processProtein has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CommandLineConversationImpl.runCommand (cyclomatic 20) · ×1
  • CommandLineConversationImpl.runCommand (cyclomatic 20) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:100 — CommandLineConversationImpl.runCommand has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SignalPMatchParser.parse (cyclomatic 20) · ×1
  • SignalPMatchParser.parse (cyclomatic 20) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/signalp/match/SignalPMatchParser.java:56 — SignalPMatchParser.parse has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SuperFamilyModelParser.parse (cyclomatic 20) · ×1
  • SuperFamilyModelParser.parse (cyclomatic 20) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:64 — SuperFamilyModelParser.parse has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WriteOutputStep.outputToXML (cyclomatic 20) · ×1
  • WriteOutputStep.outputToXML (cyclomatic 20) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:423 — WriteOutputStep.outputToXML has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleProtein.valueOf (cyclomatic 20) · ×1
  • SimpleProtein.valueOf (cyclomatic 20) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:450 — SimpleProtein.valueOf has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Consensus._part (cyclomatic 20) · ×1
  • Consensus._part (cyclomatic 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/Consensus.py:391 — Consensus._part has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · _Matrix.__setitem__ (cyclomatic 20) · ×1
  • _Matrix.__setitem__ (cyclomatic 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:185 — _Matrix.__setitem__ has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProteinMatchesTSVProResultWriter.write (cyclomatic 19) · ×1
  • ProteinMatchesTSVProResultWriter.write (cyclomatic 19) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:41 — ProteinMatchesTSVProResultWriter.write has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · idrpred.predict (cyclomatic 19) · ×1
  • idrpred.predict (cyclomatic 19) core/jms-implementation/support-mini-x86-32/bin/mobidb/idrpred/__init__.py:47 — idrpred.predict has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser._parse_clade (cyclomatic 19) · ×1
  • Parser._parse_clade (cyclomatic 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/PhyloXMLIO.py:400 — Parser._parse_clade has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · jquery.cookie.$.cookie (cyclomatic 19) · ×1
  • jquery.cookie.$.cookie (cyclomatic 19) core/web/src/main/webapp/resources/javascript/jquery/jquery.cookie.js:11 — jquery.cookie.$.cookie has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SFLDHmmer3MatchParser.parseFileInput (cyclomatic 18) · ×1
  • SFLDHmmer3MatchParser.parseFileInput (cyclomatic 18) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3MatchParser.java:223 — SFLDHmmer3MatchParser.parseFileInput has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PhobiusMatchParser.parseFileInput (cyclomatic 18) · ×1
  • PhobiusMatchParser.parseFileInput (cyclomatic 18) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:88 — PhobiusMatchParser.parseFileInput has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Gff3FastaSeqIdComparator.compare (cyclomatic 18) · ×1
  • Gff3FastaSeqIdComparator.compare (cyclomatic 18) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:110 — Gff3FastaSeqIdComparator.compare has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProteinMatchesRAWResultWriter.write (cyclomatic 18) · ×1
  • ProteinMatchesRAWResultWriter.write (cyclomatic 18) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:85 — ProteinMatchesRAWResultWriter.write has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WriteOutputStep.outputToJSON (cyclomatic 18) · ×1
  • WriteOutputStep.outputToJSON (cyclomatic 18) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:572 — WriteOutputStep.outputToJSON has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SuperFamilyHmmer3FilteredMatchDAOImpl.persist (cyclomatic 18) · ×1
  • SuperFamilyHmmer3FilteredMatchDAOImpl.persist (cyclomatic 18) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SuperFamilyHmmer3FilteredMatchDAOImpl.java:51 — SuperFamilyHmmer3FilteredMatchDAOImpl.persist has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BerkeleyMatch.equals (cyclomatic 18) · ×1
  • BerkeleyMatch.equals (cyclomatic 18) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyMatch.java:154 — BerkeleyMatch.equals has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · _SQLiteManySeqFilesDict._load_index (cyclomatic 18) · ×1
  • _SQLiteManySeqFilesDict._load_index (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/File.py:572 — _SQLiteManySeqFilesDict._load_index has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus._resolve (cyclomatic 18) · ×1
  • Nexus._resolve (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1395 — Nexus._resolve has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus.constant (cyclomatic 18) · ×1
  • Nexus.constant (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1853 — Nexus.constant has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Nexus.combine (cyclomatic 18) · ×1
  • Nexus.combine (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:390 — Nexus.combine has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Tree.is_compatible (cyclomatic 18) · ×1
  • Tree.is_compatible (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:407 — Tree.is_compatible has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Consensus.majority_consensus (cyclomatic 18) · ×1
  • Consensus.majority_consensus (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/Consensus.py:275 — Consensus.majority_consensus has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · parsehmmer.parsehmmscan (cyclomatic 18) · ×1
  • parsehmmer.parsehmmscan (cyclomatic 18) core/jms-implementation/support-mini-x86-32/bin/pirsr/0.1/parsehmmer.py:246 — parsehmmer.parsehmmscan has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PrositeDatFileParser.parse (cyclomatic 17) · ×1
  • PrositeDatFileParser.parse (cyclomatic 17) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:68 — PrositeDatFileParser.parse has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MatchLookupStep.execute (cyclomatic 17) · ×1
  • MatchLookupStep.execute (cyclomatic 17) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:117 — MatchLookupStep.execute has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProteinDAOImpl.insertNewProteins (cyclomatic 17) · ×1
  • ProteinDAOImpl.insertNewProteins (cyclomatic 17) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:444 — ProteinDAOImpl.insertNewProteins has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BerkeleyLocation.hashCode (cyclomatic 17) · ×1
  • BerkeleyLocation.hashCode (cyclomatic 17) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:230 — BerkeleyLocation.hashCode has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SummaryInfo._get_letter_freqs (cyclomatic 17) · ×1
  • SummaryInfo._get_letter_freqs (cyclomatic 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:550 — SummaryInfo._get_letter_freqs has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Seq.translate (cyclomatic 17) · ×1
  • Seq.translate (cyclomatic 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Seq.py:1128 — Seq.translate has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SeqRecord.reverse_complement (cyclomatic 17) · ×1
  • SeqRecord.reverse_complement (cyclomatic 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/SeqRecord.py:1072 — SeqRecord.reverse_complement has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BerkeleyPrecalculatedProteinLookup.run (cyclomatic 16) · ×1
  • BerkeleyPrecalculatedProteinLookup.run (cyclomatic 16) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:129 — BerkeleyPrecalculatedProteinLookup.run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PIRSRHmmer3MatchParser.parseMatchesAndSites (cyclomatic 16) · ×1
  • PIRSRHmmer3MatchParser.parseMatchesAndSites (cyclomatic 16) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:97 — PIRSRHmmer3MatchParser.parseMatchesAndSites has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProDomModelParser.parse (cyclomatic 16) · ×1
  • ProDomModelParser.parse (cyclomatic 16) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:51 — ProDomModelParser.parse has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FinaliseInitialSetupStep.execute (cyclomatic 16) · ×1
  • FinaliseInitialSetupStep.execute (cyclomatic 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:61 — FinaliseInitialSetupStep.execute has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PrepareForOutputStep.outputToXML (cyclomatic 16) · ×1
  • PrepareForOutputStep.outputToXML (cyclomatic 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:601 — PrepareForOutputStep.outputToXML has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PrepareForOutputStep.processNucleotideSequences (cyclomatic 16) · ×1
  • PrepareForOutputStep.processNucleotideSequences (cyclomatic 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:192 — PrepareForOutputStep.processNucleotideSequences has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · PrepareForOutputStep.selectRepresentative (cyclomatic 16) · ×1
  • PrepareForOutputStep.selectRepresentative (cyclomatic 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:1140 — PrepareForOutputStep.selectRepresentative has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · Parser._parse_tree (cyclomatic 16) · ×1
  • Parser._parse_tree (cyclomatic 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/NewickIO.py:137 — Parser._parse_tree has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Sequence.from_seqrecord (cyclomatic 16) · ×1
  • Sequence.from_seqrecord (cyclomatic 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/PhyloXML.py:1270 — Sequence.from_seqrecord has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · sfld_preprocess.parse_msa (cyclomatic 16) · ×1
  • sfld_preprocess.parse_msa (cyclomatic 16) core/jms-implementation/support-mini-x86-32/src/sfld/1.1/sfld_preprocess.py:35 — sfld_preprocess.parse_msa has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D17 · Explicit Debt · HackComment · ×1
  • HackComment core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1160 — //Hack to allow old names — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D2 · Cognitive Complexity · 2.run (cognitive 152) · ×1
  • 2.run (cognitive 152) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:949 — 2.run has cognitive complexity 152 (threshold 15). Drivers by points: if/else 51 (122 pts), boolean chains 16, error handling 4 (10 pts), loops 2, ternaries 1 (2 pts) (nesting depth added 78). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Hmmer3SearchMatchParser.parse (cognitive 141) · ×1
  • Hmmer3SearchMatchParser.parse (cognitive 141) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:161 — Hmmer3SearchMatchParser.parse has cognitive complexity 141 (threshold 15). Drivers by points: if/else 34 (123 pts), loops 2 (7 pts), ternaries 1 (5 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 100). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · LookupStoreToI5ModelDAOImpl.populateProteinMatches (cognitive 138) · ×1
  • LookupStoreToI5ModelDAOImpl.populateProteinMatches (cognitive 138) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:74 — LookupStoreToI5ModelDAOImpl.populateProteinMatches has cognitive complexity 138 (threshold 15). Drivers by points: if/else 34 (105 pts), loops 10 (30 pts), boolean chains 3 (nesting depth added 91). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · StepCreationSequenceLoadListener.sequencesLoaded (cognitive 136) · ×1
  • StepCreationSequenceLoadListener.sequencesLoaded (cognitive 136) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:95 — StepCreationSequenceLoadListener.sequencesLoaded has cognitive complexity 136 (threshold 15). Drivers by points: if/else 37 (84 pts), loops 14 (45 pts), boolean chains 6, error handling 1 (nesting depth added 78). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DistributedBlackBoxMaster.run (cognitive 132) · ×1
  • DistributedBlackBoxMaster.run (cognitive 132) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:99 — DistributedBlackBoxMaster.run has cognitive complexity 132 (threshold 15). Drivers by points: if/else 47 (113 pts), boolean chains 11, loops 3 (6 pts), error handling 2 (nesting depth added 69). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinMatchesTSVResultWriter.write (cognitive 123) · ×1
  • ProteinMatchesTSVResultWriter.write (cognitive 123) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVResultWriter.java:40 — ProteinMatchesTSVResultWriter.write has cognitive complexity 123 (threshold 15). Drivers by points: if/else 25 (81 pts), loops 8 (34 pts), ternaries 1 (5 pts), boolean chains 3 (nesting depth added 86). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PrepareForOutputStep.simulateMarshalling (cognitive 118) · ×1
  • PrepareForOutputStep.simulateMarshalling (cognitive 118) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:322 — PrepareForOutputStep.simulateMarshalling has cognitive complexity 118 (threshold 15). Drivers by points: if/else 21 (70 pts), loops 10 (30 pts), error handling 4 (17 pts), boolean chains 1 (nesting depth added 82). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Run.main (cognitive 115) · ×1
  • Run.main (cognitive 115) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:107 — Run.main has cognitive complexity 115 (threshold 15). Drivers by points: if/else 39 (78 pts), loops 7 (22 pts), error handling 6 (9 pts), boolean chains 6 (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hmmer3ScanMatchParser.parse (cognitive 110) · ×1
  • Hmmer3ScanMatchParser.parse (cognitive 110) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:257 — Hmmer3ScanMatchParser.parse has cognitive complexity 110 (threshold 15). Drivers by points: if/else 27 (97 pts), ternaries 1 (5 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 77). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · StandaloneBlackBoxMaster.run (cognitive 100) · ×1
  • StandaloneBlackBoxMaster.run (cognitive 100) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:49 — StandaloneBlackBoxMaster.run has cognitive complexity 100 (threshold 15). Drivers by points: if/else 38 (90 pts), boolean chains 5, loops 2 (3 pts), error handling 2 (nesting depth added 53). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · parsehmmer.parsehmmsearch (cognitive 97) · ×1
  • parsehmmer.parsehmmsearch (cognitive 97) core/jms-implementation/support-mini-x86-32/bin/pirsr/0.1/parsehmmer.py:26 — parsehmmer.parsehmmsearch has cognitive complexity 97 (threshold 15). Drivers by points: if/else 23 (82 pts), loops 5 (14 pts), boolean chains 1 (nesting depth added 68). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · FastaFileLoadIntoDBStep.execute (cognitive 90) · ×1
  • FastaFileLoadIntoDBStep.execute (cognitive 90) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:80 — FastaFileLoadIntoDBStep.execute has cognitive complexity 90 (threshold 15). Drivers by points: if/else 30 (67 pts), loops 4 (10 pts), error handling 3 (9 pts), boolean chains 4 (nesting depth added 49). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Gene3DParseAndPersistOutputStep.execute (cognitive 89) · ×1
  • Gene3DParseAndPersistOutputStep.execute (cognitive 89) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:120 — Gene3DParseAndPersistOutputStep.execute has cognitive complexity 89 (threshold 15). Drivers by points: if/else 22 (63 pts), loops 6 (19 pts), error handling 4 (6 pts), boolean chains 1 (nesting depth added 56). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · FastaFileLoadStep.execute (cognitive 88) · ×1
  • FastaFileLoadStep.execute (cognitive 88) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:79 — FastaFileLoadStep.execute has cognitive complexity 88 (threshold 15). Drivers by points: if/else 30 (66 pts), loops 4 (10 pts), error handling 3 (9 pts), boolean chains 3 (nesting depth added 48). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Array.__new__ (cognitive 84) · ×1
  • Array.__new__ (cognitive 84) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/substitution_matrices/__init__.py:27 — Array.__new__ has cognitive complexity 84 (threshold 15). Drivers by points: if/else 27 (66 pts), loops 5 (17 pts), boolean chains 1 (nesting depth added 51). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Nexus._matrix (cognitive 79) · ×1
  • Nexus._matrix (cognitive 79) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1015 — Nexus._matrix has cognitive complexity 79 (threshold 15). Drivers by points: if/else 24 (55 pts), loops 7 (19 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlastProDomMatchParser.createMatch (cognitive 74) · ×1
  • BlastProDomMatchParser.createMatch (cognitive 74) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/match/BlastProDomMatchParser.java:59 — BlastProDomMatchParser.createMatch has cognitive complexity 74 (threshold 15). Drivers by points: if/else 25 (65 pts), boolean chains 4, error handling 1 (2 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrintsMatchParser.parse (cognitive 73) · ×1
  • PrintsMatchParser.parse (cognitive 73) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/prints/PrintsMatchParser.java:43 — PrintsMatchParser.parse has cognitive complexity 73 (threshold 15). Drivers by points: if/else 20 (64 pts), loops 2 (7 pts), boolean chains 2 (nesting depth added 49). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · EntryHierarchyDataResourceReader.read (cognitive 72) · ×1
  • EntryHierarchyDataResourceReader.read (cognitive 72) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:28 — EntryHierarchyDataResourceReader.read has cognitive complexity 72 (threshold 15). Drivers by points: if/else 21 (57 pts), loops 4 (14 pts), boolean chains 1 (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Parser.parse (cognitive 70) · ×1
  • Parser.parse (cognitive 70) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/NeXMLIO.py:142 — Parser.parse has cognitive complexity 70 (threshold 15). Drivers by points: if/else 13 (48 pts), loops 6 (18 pts), boolean chains 4 (nesting depth added 47). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CreateMatchesDBFromOracle.buildDatabase (cognitive 69) · ×1
  • CreateMatchesDBFromOracle.buildDatabase (cognitive 69) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:33 — CreateMatchesDBFromOracle.buildDatabase has cognitive complexity 69 (threshold 15). Drivers by points: if/else 20 (57 pts), boolean chains 6, loops 3 (5 pts), error handling 1 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Run.checkIfBlackBoxMasterAndConfigure (cognitive 68) · ×1
  • Run.checkIfBlackBoxMasterAndConfigure (cognitive 68) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:577 — Run.checkIfBlackBoxMasterAndConfigure has cognitive complexity 68 (threshold 15). Drivers by points: if/else 25 (58 pts), boolean chains 5, error handling 1 (5 pts) (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Run.checkIfDistributedWorkerAndConfigure (cognitive 68) · ×1
  • Run.checkIfDistributedWorkerAndConfigure (cognitive 68) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:891 — Run.checkIfDistributedWorkerAndConfigure has cognitive complexity 68 (threshold 15). Drivers by points: if/else 25 (61 pts), error handling 1 (4 pts), boolean chains 3 (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · WorkerImpl.run (cognitive 66) · ×1
  • WorkerImpl.run (cognitive 66) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:726 — WorkerImpl.run has cognitive complexity 66 (threshold 15). Drivers by points: if/else 32 (56 pts), error handling 3 (4 pts), boolean chains 3, loops 3 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus.write_nexus_data (cognitive 66) · ×1
  • Nexus.write_nexus_data (cognitive 66) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1535 — Nexus.write_nexus_data has cognitive complexity 66 (threshold 15). Drivers by points: if/else 33 (43 pts), loops 7 (19 pts), boolean chains 4 (nesting depth added 22). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · HmmerModelParser.parse (cognitive 65) · ×1
  • HmmerModelParser.parse (cognitive 65) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:61 — HmmerModelParser.parse has cognitive complexity 65 (threshold 15). Drivers by points: if/else 14 (55 pts), match/switch 1 (4 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · treegrafter.parsehmmsearch (cognitive 65) · ×1
  • treegrafter.parsehmmsearch (cognitive 65) core/jms-implementation/support-mini-x86-32/bin/panther/treegrafter.py:246 — treegrafter.parsehmmsearch has cognitive complexity 65 (threshold 15). Drivers by points: if/else 15 (53 pts), loops 4 (9 pts), boolean chains 3 (nesting depth added 43). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Nexus.append_sets (cognitive 64) · ×1
  • Nexus.append_sets (cognitive 64) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1709 — Nexus.append_sets has cognitive complexity 64 (threshold 15). Drivers by points: if/else 23 (49 pts), loops 7 (11 pts), boolean chains 4 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LoadFastaFileIntoDBImpl.loadSequences (cognitive 63) · ×1
  • LoadFastaFileIntoDBImpl.loadSequences (cognitive 63) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:104 — LoadFastaFileIntoDBImpl.loadSequences has cognitive complexity 63 (threshold 15). Drivers by points: if/else 17 (54 pts), loops 4 (7 pts), boolean chains 1, error handling 1 (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ProteinMatchesRAWResultWriter.write (cognitive 63) · ×1
  • ProteinMatchesRAWResultWriter.write (cognitive 63) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:85 — ProteinMatchesRAWResultWriter.write has cognitive complexity 63 (threshold 15). Drivers by points: if/else 13 (44 pts), loops 4 (14 pts), ternaries 1 (5 pts) (nesting depth added 45). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Run.getApplications (cognitive 63) · ×1
  • Run.getApplications (cognitive 63) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1155 — Run.getApplications has cognitive complexity 63 (threshold 15). Drivers by points: if/else 18 (48 pts), loops 3 (7 pts), boolean chains 4, ternaries 1 (4 pts) (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ParseStep.execute (cognitive 63) · ×1
  • ParseStep.execute (cognitive 63) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:82 — ParseStep.execute has cognitive complexity 63 (threshold 15). Drivers by points: if/else 16 (41 pts), loops 5 (17 pts), boolean chains 3, error handling 2 (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ProteinDAOImpl.insertNewProteins (cognitive 63) · ×1
  • ProteinDAOImpl.insertNewProteins (cognitive 63) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:444 — ProteinDAOImpl.insertNewProteins has cognitive complexity 63 (threshold 15). Drivers by points: if/else 13 (52 pts), loops 4 (11 pts) (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ProteinMatchesTSVProResultWriter.write (cognitive 61) · ×1
  • ProteinMatchesTSVProResultWriter.write (cognitive 61) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:41 — ProteinMatchesTSVProResultWriter.write has cognitive complexity 61 (threshold 15). Drivers by points: if/else 14 (49 pts), loops 4 (12 pts) (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AnalyseMatchDataResult.createSimpleProtein (cognitive 61) · ×1
  • AnalyseMatchDataResult.createSimpleProtein (cognitive 61) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:93 — AnalyseMatchDataResult.createSimpleProtein has cognitive complexity 61 (threshold 15). Drivers by points: if/else 20 (45 pts), loops 5 (12 pts), boolean chains 4 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Run.getDeprecatedApplications (cognitive 60) · ×1
  • Run.getDeprecatedApplications (cognitive 60) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1268 — Run.getDeprecatedApplications has cognitive complexity 60 (threshold 15). Drivers by points: if/else 17 (45 pts), loops 3 (7 pts), boolean chains 4, ternaries 1 (4 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DistributedBlackBoxMasterOLD.run (cognitive 59) · ×1
  • DistributedBlackBoxMasterOLD.run (cognitive 59) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:31 — DistributedBlackBoxMasterOLD.run has cognitive complexity 59 (threshold 15). Drivers by points: if/else 13 (40 pts), ternaries 2 (8 pts), boolean chains 6, loops 2 (3 pts), error handling 2 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PIRSFPostProcessor.processProtein (cognitive 57) · ×1
  • PIRSFPostProcessor.processProtein (cognitive 57) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pirsf/PIRSFPostProcessor.java:57 — PIRSFPostProcessor.processProtein has cognitive complexity 57 (threshold 15). Drivers by points: if/else 18 (36 pts), loops 9 (12 pts), boolean chains 9 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProDomModelParser.parse (cognitive 56) · ×1
  • ProDomModelParser.parse (cognitive 56) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:51 — ProDomModelParser.parse has cognitive complexity 56 (threshold 15). Drivers by points: if/else 12 (42 pts), loops 3 (7 pts), match/switch 1 (5 pts), boolean chains 2 (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SubmissionWorkerRunner.startupNewWorker (cognitive 56) · ×1
  • SubmissionWorkerRunner.startupNewWorker (cognitive 56) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/queuejumper/platforms/SubmissionWorkerRunner.java:244 — SubmissionWorkerRunner.startupNewWorker has cognitive complexity 56 (threshold 15). Drivers by points: if/else 21 (44 pts), error handling 2 (4 pts), ternaries 1 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 29). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · HmmPfamParser.parse (cognitive 55) · ×1
  • HmmPfamParser.parse (cognitive 55) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer2/HmmPfamParser.java:145 — HmmPfamParser.parse has cognitive complexity 55 (threshold 15). Drivers by points: if/else 15 (44 pts), ternaries 1 (5 pts), match/switch 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PIRSRHmmer3MatchParser.parseFileInput (cognitive 55) · ×1
  • PIRSRHmmer3MatchParser.parseFileInput (cognitive 55) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:304 — PIRSRHmmer3MatchParser.parseFileInput has cognitive complexity 55 (threshold 15). Drivers by points: if/else 9 (39 pts), loops 5 (14 pts), boolean chains 1, error handling 1 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinSiteMatchesTSVResultWriter.write (cognitive 55) · ×1
  • ProteinSiteMatchesTSVResultWriter.write (cognitive 55) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:39 — ProteinSiteMatchesTSVResultWriter.write has cognitive complexity 55 (threshold 15). Drivers by points: loops 5 (23 pts), if/else 4 (22 pts), ternaries 1 (9 pts), boolean chains 1 (nesting depth added 44). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Run.getExcludedApplications (cognitive 55) · ×1
  • Run.getExcludedApplications (cognitive 55) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1370 — Run.getExcludedApplications has cognitive complexity 55 (threshold 15). Drivers by points: if/else 15 (40 pts), loops 3 (7 pts), boolean chains 4, ternaries 1 (4 pts) (nesting depth added 32). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Consensus._part (cognitive 54) · ×1
  • Consensus._part (cognitive 54) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/Consensus.py:391 — Consensus._part has cognitive complexity 54 (threshold 15). Drivers by points: if/else 7 (27 pts), loops 7 (26 pts), boolean chains 1 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StatsUtil.displayMasterProgress (cognitive 53) · ×1
  • StatsUtil.displayMasterProgress (cognitive 53) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:761 — StatsUtil.displayMasterProgress has cognitive complexity 53 (threshold 15). Drivers by points: if/else 18 (43 pts), boolean chains 10 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SimpleProtein.valueOf (cognitive 53) · ×1
  • SimpleProtein.valueOf (cognitive 53) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:450 — SimpleProtein.valueOf has cognitive complexity 53 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 5 (18 pts), ternaries 5 (8 pts), boolean chains 1 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CreateSitesDBFromOracle.buildDatabase (cognitive 53) · ×1
  • CreateSitesDBFromOracle.buildDatabase (cognitive 53) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:32 — CreateSitesDBFromOracle.buildDatabase has cognitive complexity 53 (threshold 15). Drivers by points: if/else 15 (42 pts), boolean chains 5, loops 3 (5 pts), error handling 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PantherFilteredMatchDAOImpl.persist (cognitive 51) · ×1
  • PantherFilteredMatchDAOImpl.persist (cognitive 51) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:60 — PantherFilteredMatchDAOImpl.persist has cognitive complexity 51 (threshold 15). Drivers by points: if/else 13 (39 pts), loops 5 (8 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyLocation.equals (cognitive 51) · ×1
  • BerkeleyLocation.equals (cognitive 51) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:200 — BerkeleyLocation.equals has cognitive complexity 51 (threshold 15). Drivers by points: ternaries 16 (32 pts), if/else 18, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SignalPMatchParser.parse (cognitive 50) · ×1
  • SignalPMatchParser.parse (cognitive 50) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/signalp/match/SignalPMatchParser.java:56 — SignalPMatchParser.parse has cognitive complexity 50 (threshold 15). Drivers by points: if/else 19 (46 pts), boolean chains 3, loops 1 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SuperFamilyModelParser.parse (cognitive 50) · ×1
  • SuperFamilyModelParser.parse (cognitive 50) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:64 — SuperFamilyModelParser.parse has cognitive complexity 50 (threshold 15). Drivers by points: if/else 9 (39 pts), loops 3 (5 pts), match/switch 1 (4 pts), boolean chains 2 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuperFamilyHmmer3FilteredMatchDAOImpl.persist (cognitive 50) · ×1
  • SuperFamilyHmmer3FilteredMatchDAOImpl.persist (cognitive 50) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SuperFamilyHmmer3FilteredMatchDAOImpl.java:51 — SuperFamilyHmmer3FilteredMatchDAOImpl.persist has cognitive complexity 50 (threshold 15). Drivers by points: if/else 11 (29 pts), loops 5 (12 pts), ternaries 2 (8 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyLocation.compareTo (cognitive 50) · ×1
  • BerkeleyLocation.compareTo (cognitive 50) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:278 — BerkeleyLocation.compareTo has cognitive complexity 50 (threshold 15). Drivers by points: if/else 25 (41 pts), boolean chains 9 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LoadFastaFileImpl.loadSequences (cognitive 49) · ×1
  • LoadFastaFileImpl.loadSequences (cognitive 49) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:63 — LoadFastaFileImpl.loadSequences has cognitive complexity 49 (threshold 15). Drivers by points: if/else 13 (47 pts), error handling 1, loops 1 (nesting depth added 34). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SFLDHmmer3MatchParser.parseMatchesAndSites (cognitive 49) · ×1
  • SFLDHmmer3MatchParser.parseMatchesAndSites (cognitive 49) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3MatchParser.java:88 — SFLDHmmer3MatchParser.parseMatchesAndSites has cognitive complexity 49 (threshold 15). Drivers by points: if/else 11 (29 pts), loops 8 (17 pts), boolean chains 3 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PfamHMMER3PostProcessing.processProtein (cognitive 48) · ×1
  • PfamHMMER3PostProcessing.processProtein (cognitive 48) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pfam_A/PfamHMMER3PostProcessing.java:76 — PfamHMMER3PostProcessing.processProtein has cognitive complexity 48 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 6 (13 pts), ternaries 1 (5 pts), boolean chains 4 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CompositeParseStep.execute (cognitive 48) · ×1
  • CompositeParseStep.execute (cognitive 48) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:78 — CompositeParseStep.execute has cognitive complexity 48 (threshold 15). Drivers by points: if/else 16 (38 pts), loops 3 (8 pts), error handling 2 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · WriteOutputStep.outputToXML (cognitive 48) · ×1
  • WriteOutputStep.outputToXML (cognitive 48) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:423 — WriteOutputStep.outputToXML has cognitive complexity 48 (threshold 15). Drivers by points: if/else 12 (35 pts), loops 3 (8 pts), error handling 3, boolean chains 2 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NucleotideSequenceDAOImpl.insertNewNucleotideSequences (cognitive 48) · ×1
  • NucleotideSequenceDAOImpl.insertNewNucleotideSequences (cognitive 48) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAOImpl.java:208 — NucleotideSequenceDAOImpl.insertNewNucleotideSequences has cognitive complexity 48 (threshold 15). Drivers by points: if/else 11 (37 pts), loops 4 (11 pts) (nesting depth added 33). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PIRSRHmmer3MatchParser.parseMatchesAndSites (cognitive 47) · ×1
  • PIRSRHmmer3MatchParser.parseMatchesAndSites (cognitive 47) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:97 — PIRSRHmmer3MatchParser.parseMatchesAndSites has cognitive complexity 47 (threshold 15). Drivers by points: if/else 11 (27 pts), loops 8 (20 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SingleSeqOptimisedBlackBoxMaster.run (cognitive 47) · ×1
  • SingleSeqOptimisedBlackBoxMaster.run (cognitive 47) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:46 — SingleSeqOptimisedBlackBoxMaster.run has cognitive complexity 47 (threshold 15). Drivers by points: if/else 16 (34 pts), loops 3 (8 pts), boolean chains 3, error handling 2 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TMHMMRawResultParser.parseFileInput (cognitive 45) · ×1
  • TMHMMRawResultParser.parseFileInput (cognitive 45) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:104 — TMHMMRawResultParser.parseFileInput has cognitive complexity 45 (threshold 15). Drivers by points: if/else 10 (36 pts), loops 2 (6 pts), boolean chains 2, error handling 1 (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · WriteOutputStep.outputToJSON (cognitive 45) · ×1
  • WriteOutputStep.outputToJSON (cognitive 45) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:572 — WriteOutputStep.outputToJSON has cognitive complexity 45 (threshold 15). Drivers by points: if/else 11 (32 pts), loops 3 (10 pts), boolean chains 3 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _Matrix.__setitem__ (cognitive 45) · ×1
  • _Matrix.__setitem__ (cognitive 45) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:185 — _Matrix.__setitem__ has cognitive complexity 45 (threshold 15). Drivers by points: if/else 20 (34 pts), loops 2 (8 pts), boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Gff3FastaSeqIdComparator.compare (cognitive 44) · ×1
  • Gff3FastaSeqIdComparator.compare (cognitive 44) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:110 — Gff3FastaSeqIdComparator.compare has cognitive complexity 44 (threshold 15). Drivers by points: ternaries 7 (21 pts), if/else 8 (19 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PrositeDatFileParser.parse (cognitive 43) · ×1
  • PrositeDatFileParser.parse (cognitive 43) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:68 — PrositeDatFileParser.parse has cognitive complexity 43 (threshold 15). Drivers by points: if/else 8 (34 pts), match/switch 1 (4 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Converter.run (cognitive 43) · ×1
  • Converter.run (cognitive 43) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:179 — Converter.run has cognitive complexity 43 (threshold 15). Drivers by points: if/else 20 (28 pts), loops 3 (6 pts), error handling 4 (5 pts), ternaries 2 (4 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.run (cognitive 43) · ×1
  • 1.run (cognitive 43) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:225 — 1.run has cognitive complexity 43 (threshold 15). Drivers by points: if/else 12 (32 pts), boolean chains 6, error handling 1 (2 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParsimonyScorer.get_score (cognitive 43) · ×1
  • ParsimonyScorer.get_score (cognitive 43) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:1040 — ParsimonyScorer.get_score has cognitive complexity 43 (threshold 15). Drivers by points: if/else 9 (24 pts), loops 6 (19 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrepareForOutputStep.getPathName (cognitive 41) · ×1
  • PrepareForOutputStep.getPathName (cognitive 41) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:742 — PrepareForOutputStep.getPathName has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (30 pts), error handling 2 (7 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WriteOutputStep.getPathName (cognitive 41) · ×1
  • WriteOutputStep.getPathName (cognitive 41) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:353 — WriteOutputStep.getPathName has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (30 pts), error handling 2 (7 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._format (cognitive 41) · ×1
  • Nexus._format (cognitive 41) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:789 — Nexus._format has cognitive complexity 41 (threshold 15). Drivers by points: if/else 23 (34 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CDDMatchParser.parseFileInput (cognitive 39) · ×1
  • CDDMatchParser.parseFileInput (cognitive 39) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/cdd/CDDMatchParser.java:129 — CDDMatchParser.parseFileInput has cognitive complexity 39 (threshold 15). Drivers by points: if/else 11 (32 pts), loops 3 (7 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WriteOutputStep.removeSites (cognitive 39) · ×1
  • WriteOutputStep.removeSites (cognitive 39) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:937 — WriteOutputStep.removeSites has cognitive complexity 39 (threshold 15). Drivers by points: if/else 5 (27 pts), loops 3 (9 pts), boolean chains 3 (nesting depth added 28). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AbstractMaster.addDependenciesAndStore (cognitive 38) · ×1
  • AbstractMaster.addDependenciesAndStore (cognitive 38) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/AbstractMaster.java:191 — AbstractMaster.addDependenciesAndStore has cognitive complexity 38 (threshold 15). Drivers by points: if/else 5 (19 pts), loops 5 (16 pts), boolean chains 2, error handling 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrepareForOutputStep.selectRepresentative (cognitive 38) · ×1
  • PrepareForOutputStep.selectRepresentative (cognitive 38) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:1140 — PrepareForOutputStep.selectRepresentative has cognitive complexity 38 (threshold 15). Drivers by points: loops 8 (19 pts), if/else 5 (17 pts), boolean chains 2 (nesting depth added 23). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookup.run (cognitive 37) · ×1
  • BerkeleyPrecalculatedProteinLookup.run (cognitive 37) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:129 — BerkeleyPrecalculatedProteinLookup.run has cognitive complexity 37 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 4 (13 pts), boolean chains 4 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GaValuesRetriever.parseModelFile (cognitive 37) · ×1
  • GaValuesRetriever.parseModelFile (cognitive 37) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/GaValuesRetriever.java:152 — GaValuesRetriever.parseModelFile has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (34 pts), boolean chains 2, loops 1 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · idrpred.get_region_features (cognitive 37) · ×1
  • idrpred.get_region_features (cognitive 37) core/jms-implementation/support-mini-x86-32/bin/mobidb/idrpred/__init__.py:235 — idrpred.get_region_features has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (26 pts), loops 6 (11 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._kill_comments_and_break_lines (cognitive 37) · ×1
  • Nexus._kill_comments_and_break_lines (cognitive 37) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:478 — Nexus._kill_comments_and_break_lines has cognitive complexity 37 (threshold 15). Drivers by points: if/else 13 (25 pts), boolean chains 9, error handling 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Writer.process_clade (cognitive 37) · ×1
  • Writer.process_clade (cognitive 37) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/CDAOIO.py:332 — Writer.process_clade has cognitive complexity 37 (threshold 15). Drivers by points: loops 7 (13 pts), if/else 9 (12 pts), error handling 4 (7 pts), ternaries 2 (3 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SFLDHmmer3MatchParser.parseFileInput (cognitive 36) · ×1
  • SFLDHmmer3MatchParser.parseFileInput (cognitive 36) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3MatchParser.java:223 — SFLDHmmer3MatchParser.parseFileInput has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (31 pts), loops 2, match/switch 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrintsFilteredMatchDAOImpl.persist (cognitive 36) · ×1
  • PrintsFilteredMatchDAOImpl.persist (cognitive 36) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrintsFilteredMatchDAOImpl.java:50 — PrintsFilteredMatchDAOImpl.persist has cognitive complexity 36 (threshold 15). Drivers by points: if/else 9 (28 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CodonTable.__str__ (cognitive 36) · ×1
  • CodonTable.__str__ (cognitive 36) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Data/CodonTable.py:75 — CodonTable.__str__ has cognitive complexity 36 (threshold 15). Drivers by points: if/else 10 (18 pts), error handling 2 (10 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Consensus.majority_consensus (cognitive 36) · ×1
  • Consensus.majority_consensus (cognitive 36) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/Consensus.py:275 — Consensus.majority_consensus has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (27 pts), loops 3 (6 pts), boolean chains 3 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RPSBlastFilteredMatchDAO.persist (cognitive 35) · ×1
  • RPSBlastFilteredMatchDAO.persist (cognitive 35) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/RPSBlastFilteredMatchDAO.java:53 — RPSBlastFilteredMatchDAO.persist has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (27 pts), loops 4 (8 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · idrpred.predict (cognitive 35) · ×1
  • idrpred.predict (cognitive 35) core/jms-implementation/support-mini-x86-32/bin/mobidb/idrpred/__init__.py:47 — idrpred.predict has cognitive complexity 35 (threshold 15). Drivers by points: if/else 12 (22 pts), loops 5 (10 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PhobiusMatchParser.parseFileInput (cognitive 34) · ×1
  • PhobiusMatchParser.parseFileInput (cognitive 34) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:88 — PhobiusMatchParser.parseFileInput has cognitive complexity 34 (threshold 15). Drivers by points: if/else 10 (24 pts), boolean chains 5, ternaries 1 (4 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TemporaryDirectoryManagerImpl.replacePath (cognitive 34) · ×1
  • TemporaryDirectoryManagerImpl.replacePath (cognitive 34) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/TemporaryDirectoryManagerImpl.java:47 — TemporaryDirectoryManagerImpl.replacePath has cognitive complexity 34 (threshold 15). Drivers by points: if/else 11 (32 pts), loops 1 (2 pts) (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Run.setupSimpleBlackBoxMaster (cognitive 34) · ×1
  • Run.setupSimpleBlackBoxMaster (cognitive 34) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:747 — Run.setupSimpleBlackBoxMaster has cognitive complexity 34 (threshold 15). Drivers by points: if/else 21 (30 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProDomFilteredMatchDAOImpl.persist (cognitive 34) · ×1
  • ProDomFilteredMatchDAOImpl.persist (cognitive 34) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProDomFilteredMatchDAOImpl.java:52 — ProDomFilteredMatchDAOImpl.persist has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (27 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PairwiseAlignment._format_generalized (cognitive 34) · ×1
  • PairwiseAlignment._format_generalized (cognitive 34) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/__init__.py:1046 — PairwiseAlignment._format_generalized has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 6 (16 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._resolve (cognitive 34) · ×1
  • Nexus._resolve (cognitive 34) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1395 — Nexus._resolve has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (22 pts), boolean chains 4, error handling 2 (4 pts), loops 1 (4 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GFFResultWriterForNucSeqs.writeSequenceRegionPart (cognitive 33) · ×1
  • GFFResultWriterForNucSeqs.writeSequenceRegionPart (cognitive 33) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForNucSeqs.java:110 — GFFResultWriterForNucSeqs.writeSequenceRegionPart has cognitive complexity 33 (threshold 15). Drivers by points: if/else 5 (21 pts), loops 4 (12 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SmartPostProcessing.filterByFamilyOverlap (cognitive 32) · ×1
  • SmartPostProcessing.filterByFamilyOverlap (cognitive 32) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:215 — SmartPostProcessing.filterByFamilyOverlap has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (23 pts), loops 3 (4 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CDDModelParser.parse (cognitive 32) · ×1
  • CDDModelParser.parse (cognitive 32) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:52 — CDDModelParser.parse has cognitive complexity 32 (threshold 15). Drivers by points: if/else 8 (24 pts), loops 2 (3 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuperFamilyHmmer3MatchParser.parseLine (cognitive 32) · ×1
  • SuperFamilyHmmer3MatchParser.parseLine (cognitive 32) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/match/SuperFamilyHmmer3MatchParser.java:102 — SuperFamilyHmmer3MatchParser.parseLine has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (16 pts), error handling 2 (7 pts), loops 2 (4 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalJobQueueListener.onMessage (cognitive 32) · ×1
  • LocalJobQueueListener.onMessage (cognitive 32) REDACTED:117 — LocalJobQueueListener.onMessage has cognitive complexity 32 (threshold 15). Drivers by points: if/else 16 (25 pts), error handling 5 (7 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummaryInfo._get_letter_freqs (cognitive 32) · ×1
  • SummaryInfo._get_letter_freqs (cognitive 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:550 — SummaryInfo._get_letter_freqs has cognitive complexity 32 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 4 (7 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.get_node_info (cognitive 32) · ×1
  • Parser.get_node_info (cognitive 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/CDAOIO.py:167 — Parser.get_node_info has cognitive complexity 32 (threshold 15). Drivers by points: if/else 11 (28 pts), error handling 1 (2 pts), loops 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser._parse_clade (cognitive 32) · ×1
  • Parser._parse_clade (cognitive 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/PhyloXMLIO.py:400 — Parser._parse_clade has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (31 pts), loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Seq._translate_str (cognitive 32) · ×1
  • Seq._translate_str (cognitive 32) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Seq.py:2741 — Seq._translate_str has cognitive complexity 32 (threshold 15). Drivers by points: if/else 15 (28 pts), error handling 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProductionMaster.run (cognitive 31) · ×1
  • ProductionMaster.run (cognitive 31) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:63 — ProductionMaster.run has cognitive complexity 31 (threshold 15). Drivers by points: if/else 6 (19 pts), ternaries 1 (4 pts), boolean chains 3, loops 2 (3 pts), error handling 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RemoteJobQueueListener.checkQueueState (cognitive 30) · ×1
  • RemoteJobQueueListener.checkQueueState (cognitive 30) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/RemoteJobQueueListener.java:144 — RemoteJobQueueListener.checkQueueState has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (21 pts), error handling 2 (7 pts), match/switch 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractStepInstanceCreator.addDependenciesAndStore (cognitive 30) · ×1
  • AbstractStepInstanceCreator.addDependenciesAndStore (cognitive 30) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/AbstractStepInstanceCreator.java:119 — AbstractStepInstanceCreator.addDependenciesAndStore has cognitive complexity 30 (threshold 15). Drivers by points: if/else 4 (17 pts), loops 4 (13 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrepareForOutputStep.outputToXML (cognitive 30) · ×1
  • PrepareForOutputStep.outputToXML (cognitive 30) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:601 — PrepareForOutputStep.outputToXML has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (10 pts), error handling 2, boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FunFamHmmer3FilteredMatchDAOImpl.persist (cognitive 30) · ×1
  • FunFamHmmer3FilteredMatchDAOImpl.persist (cognitive 30) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FunFamHmmer3FilteredMatchDAOImpl.java:12 — FunFamHmmer3FilteredMatchDAOImpl.persist has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 3 (8 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._parse_list (cognitive 30) · ×1
  • Nexus._parse_list (cognitive 30) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1339 — Nexus._parse_list has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (23 pts), error handling 2 (4 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Nexus.combine (cognitive 30) · ×1
  • Nexus.combine (cognitive 30) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:390 — Nexus.combine has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 8 (12 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WorkerImpl.manageRemoteQueueListenerContainer (cognitive 29) · ×1
  • WorkerImpl.manageRemoteQueueListenerContainer (cognitive 29) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1176 — WorkerImpl.manageRemoteQueueListenerContainer has cognitive complexity 29 (threshold 15). Drivers by points: if/else 12 (26 pts), match/switch 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CondensedView.build (cognitive 29) · ×1
  • CondensedView.build (cognitive 29) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/CondensedView.java:166 — CondensedView.build has cognitive complexity 29 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (6 pts), ternaries 1 (5 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookup.getMatchesFromLookup (cognitive 28) · ×1
  • BerkeleyPrecalculatedProteinLookup.getMatchesFromLookup (cognitive 28) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:487 — BerkeleyPrecalculatedProteinLookup.getMatchesFromLookup has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), error handling 5 (13 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (BerkeleyPrecalculatedProteinLookup.getSitesFromLookup) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookup.getSitesFromLookup (cognitive 28) · ×1
  • BerkeleyPrecalculatedProteinLookup.getSitesFromLookup (cognitive 28) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:525 — BerkeleyPrecalculatedProteinLookup.getSitesFromLookup has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), error handling 5 (13 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (BerkeleyPrecalculatedProteinLookup.getMatchesFromLookup) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getMatchesFromLookup (cognitive 28) · ×1
  • BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getMatchesFromLookup (cognitive 28) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:268 — BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getMatchesFromLookup has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), error handling 5 (13 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getSitesFromLookup) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getSitesFromLookup (cognitive 28) · ×1
  • BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getSitesFromLookup (cognitive 28) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:306 — BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getSitesFromLookup has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), error handling 5 (13 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.getMatchesFromLookup) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · WriteOutputStep.execute (cognitive 28) · ×1
  • WriteOutputStep.execute (cognitive 28) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:186 — WriteOutputStep.execute has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (19 pts), error handling 2 (4 pts), match/switch 1 (2 pts), boolean chains 1, loops 1, ternaries 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummaryInfo.dumb_consensus (cognitive 28) · ×1
  • SummaryInfo.dumb_consensus (cognitive 28) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:47 — SummaryInfo.dumb_consensus has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 3 (5 pts), boolean chains 3 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _SQLiteManySeqFilesDict._load_index (cognitive 28) · ×1
  • _SQLiteManySeqFilesDict._load_index (cognitive 28) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/File.py:572 — _SQLiteManySeqFilesDict._load_index has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 2 (4 pts), boolean chains 3, error handling 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Tree.collapse_genera (cognitive 28) · ×1
  • Tree.collapse_genera (cognitive 28) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:336 — Tree.collapse_genera has cognitive complexity 28 (threshold 15). Drivers by points: if/else 4 (14 pts), loops 4 (10 pts), error handling 1 (4 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · pirsr.process_row (cognitive 28) · ×1
  • pirsr.process_row (cognitive 28) core/jms-implementation/support-mini-x86-32/bin/pirsr/0.1/pirsr.py:32 — pirsr.process_row has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (24 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinLoader.createAndPersistNewORFs (cognitive 27) · ×1
  • ProteinLoader.createAndPersistNewORFs (cognitive 27) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:374 — ProteinLoader.createAndPersistNewORFs has cognitive complexity 27 (threshold 15). Drivers by points: loops 4 (14 pts), if/else 6 (13 pts) (nesting depth added 17). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · LSFMaximumSubmittedJobsWorkerStartupStrategy.startUpWorker (cognitive 27) · ×1
  • LSFMaximumSubmittedJobsWorkerStartupStrategy.startUpWorker (cognitive 27) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/queuejumper/platforms/LSFMaximumSubmittedJobsWorkerStartupStrategy.java:64 — LSFMaximumSubmittedJobsWorkerStartupStrategy.startUpWorker has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (21 pts), error handling 2 (6 pts) (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ParsePrintsOutputStep.execute (cognitive 27) · ×1
  • ParsePrintsOutputStep.execute (cognitive 27) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:72 — ParsePrintsOutputStep.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 2 (4 pts), error handling 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FinaliseInitialSetupStep.execute (cognitive 27) · ×1
  • FinaliseInitialSetupStep.execute (cognitive 27) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:61 — FinaliseInitialSetupStep.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 15 (23 pts), loops 3 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilteredMatchDAOImpl.persist (cognitive 27) · ×1
  • FilteredMatchDAOImpl.persist (cognitive 27) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:75 — FilteredMatchDAOImpl.persist has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Array.__array_ufunc__ (cognitive 27) · ×1
  • Array.__array_ufunc__ (cognitive 27) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/substitution_matrices/__init__.py:193 — Array.__array_ufunc__ has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (22 pts), loops 3 (4 pts), ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Sequence.from_seqrecord (cognitive 27) · ×1
  • Sequence.from_seqrecord (cognitive 27) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/PhyloXML.py:1270 — Sequence.from_seqrecord has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 3 (6 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · sfld_preprocess.parse_msa (cognitive 27) · ×1
  • sfld_preprocess.parse_msa (cognitive 27) core/jms-implementation/support-mini-x86-32/src/sfld/1.1/sfld_preprocess.py:35 — sfld_preprocess.parse_msa has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (20 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookup.getPrecalculated (cognitive 26) · ×1
  • BerkeleyPrecalculatedProteinLookup.getPrecalculated (cognitive 26) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:308 — BerkeleyPrecalculatedProteinLookup.getPrecalculated has cognitive complexity 26 (threshold 15). Drivers by points: if/else 16 (18 pts), error handling 3 (4 pts), boolean chains 2, loops 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ProteinMatchesGFFResultWriter.buildMatchFeature (cognitive 26) · ×1
  • ProteinMatchesGFFResultWriter.buildMatchFeature (cognitive 26) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:215 — ProteinMatchesGFFResultWriter.buildMatchFeature has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PantherModelDirectoryParser.parse (cognitive 26) · ×1
  • PantherModelDirectoryParser.parse (cognitive 26) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/panther/PantherModelDirectoryParser.java:46 — PantherModelDirectoryParser.parse has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 4 (11 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InterProXMLUnmarshaller.processEntryElement (cognitive 26) · ×1
  • InterProXMLUnmarshaller.processEntryElement (cognitive 26) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshaller.java:131 — InterProXMLUnmarshaller.processEntryElement has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Run.checkAnalysesToRun (cognitive 26) · ×1
  • Run.checkAnalysesToRun (cognitive 26) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1476 — Run.checkAnalysesToRun has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (20 pts), loops 2 (3 pts), ternaries 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuperMatchBucket.addIfSameHierarchyMergeIfOverlap (cognitive 26) · ×1
  • SuperMatchBucket.addIfSameHierarchyMergeIfOverlap (cognitive 26) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:69 — SuperMatchBucket.addIfSameHierarchyMergeIfOverlap has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LookupMatchConverter.convertMatches (cognitive 26) · ×1
  • LookupMatchConverter.convertMatches (cognitive 26) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupMatchConverter.java:26 — LookupMatchConverter.convertMatches has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (11 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _utils.draw (cognitive 26) · ×1
  • _utils.draw (cognitive 26) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/_utils.py:320 — _utils.draw has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (17 pts), error handling 3 (5 pts), loops 3, boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SeqRecord.__getitem__ (cognitive 26) · ×1
  • SeqRecord.__getitem__ (cognitive 26) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/SeqRecord.py:341 — SeqRecord.__getitem__ has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 2 (5 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XrefParser.getProteinXref (cognitive 25) · ×1
  • XrefParser.getProteinXref (cognitive 25) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:115 — XrefParser.getProteinXref has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (24 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrepareForOutputStep.processNucleotideSequences (cognitive 25) · ×1
  • PrepareForOutputStep.processNucleotideSequences (cognitive 25) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:192 — PrepareForOutputStep.processNucleotideSequences has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 6 (8 pts), error handling 3 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JobStatusChecker.getJobStatus (cognitive 25) · ×1
  • JobStatusChecker.getJobStatus (cognitive 25) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/JobStatusChecker.java:14 — JobStatusChecker.getJobStatus has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RPSBlastFilteredMatchDAO.getSites (cognitive 25) · ×1
  • RPSBlastFilteredMatchDAO.getSites (cognitive 25) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/RPSBlastFilteredMatchDAO.java:160 — RPSBlastFilteredMatchDAO.getSites has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (18 pts), loops 2 (7 pts) (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Tree.is_compatible (cognitive 25) · ×1
  • Tree.is_compatible (cognitive 25) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:407 — Tree.is_compatible has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 8, loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _Matrix.__getitem__ (cognitive 25) · ×1
  • _Matrix.__getitem__ (cognitive 25) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:131 — _Matrix.__getitem__ has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (23 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistanceTreeConstructor.nj (cognitive 25) · ×1
  • DistanceTreeConstructor.nj (cognitive 25) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:732 — DistanceTreeConstructor.nj has cognitive complexity 25 (threshold 15). Drivers by points: loops 6 (13 pts), if/else 6 (11 pts), boolean chains 1 (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · PrintsPostProcessing.processProtein (cognitive 24) · ×1
  • PrintsPostProcessing.processProtein (cognitive 24) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prints/PrintsPostProcessing.java:128 — PrintsPostProcessing.processProtein has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (21 pts), boolean chains 2, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinMatchesGFFResultWriter.processMatches (cognitive 24) · ×1
  • ProteinMatchesGFFResultWriter.processMatches (cognitive 24) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesGFFResultWriter.java:290 — ProteinMatchesGFFResultWriter.processMatches has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 2 (4 pts), ternaries 1 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PvalParser.parse (cognitive 24) · ×1
  • PvalParser.parse (cognitive 24) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prints/PvalParser.java:47 — PvalParser.parse has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 3 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TMHMMPredictionTableParser.parse (cognitive 24) · ×1
  • TMHMMPredictionTableParser.parse (cognitive 24) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMPredictionTableParser.java:70 — TMHMMPredictionTableParser.parse has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (18 pts), ternaries 1 (4 pts), error handling 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TMHMMRawResultParser.parseTransmembraneRegions (cognitive 24) · ×1
  • TMHMMRawResultParser.parseTransmembraneRegions (cognitive 24) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:168 — TMHMMRawResultParser.parseTransmembraneRegions has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (20 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Installer.loadModels (cognitive 24) · ×1
  • Installer.loadModels (cognitive 24) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/installer/Installer.java:146 — Installer.loadModels has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 3, error handling 1 (3 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MatchLookupStep.execute (cognitive 24) · ×1
  • MatchLookupStep.execute (cognitive 24) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:117 — MatchLookupStep.execute has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (17 pts), loops 3 (4 pts), error handling 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilteredMatchAndSiteDAOImpl.persist (cognitive 24) · ×1
  • FilteredMatchAndSiteDAOImpl.persist (cognitive 24) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:53 — FilteredMatchAndSiteDAOImpl.persist has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyMatch.equals (cognitive 24) · ×1
  • BerkeleyMatch.equals (cognitive 24) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyMatch.java:154 — BerkeleyMatch.equals has cognitive complexity 24 (threshold 15). Drivers by points: ternaries 7 (14 pts), if/else 9, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · treegrafter.prepare (cognitive 24) · ×1
  • treegrafter.prepare (cognitive 24) core/jms-implementation/support-mini-x86-32/bin/panther/treegrafter.py:464 — treegrafter.prepare has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 5 (8 pts), error handling 1 (2 pts), ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · parsehmmer.parsehmmscan (cognitive 24) · ×1
  • parsehmmer.parsehmmscan (cognitive 24) core/jms-implementation/support-mini-x86-32/bin/pirsr/0.1/parsehmmer.py:246 — parsehmmer.parsehmmscan has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (20 pts), boolean chains 3, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CommandLineConversationImpl.runCommand (cognitive 23) · ×1
  • CommandLineConversationImpl.runCommand (cognitive 23) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:100 — CommandLineConversationImpl.runCommand has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (17 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Run.configureTCPTransport (cognitive 23) · ×1
  • Run.configureTCPTransport (cognitive 23) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1539 — Run.configureTCPTransport has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (11 pts), error handling 2 (6 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PairwiseAlignment._format_psl (cognitive 23) · ×1
  • PairwiseAlignment._format_psl (cognitive 23) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/__init__.py:1119 — PairwiseAlignment._format_psl has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 2 (4 pts), error handling 2, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._charstatelabels (cognitive 23) · ×1
  • Nexus._charstatelabels (cognitive 23) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:949 — Nexus._charstatelabels has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (4 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Trees.consensus (cognitive 23) · ×1
  • Trees.consensus (cognitive 23) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:906 — Trees.consensus has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 6 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistanceTreeConstructor.upgma (cognitive 23) · ×1
  • DistanceTreeConstructor.upgma (cognitive 23) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:666 — DistanceTreeConstructor.upgma has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 4 (8 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinLoader.lookupProteins (cognitive 22) · ×1
  • ProteinLoader.lookupProteins (cognitive 22) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:134 — ProteinLoader.lookupProteins has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (9 pts), ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TMHMMMatchParser.parse (cognitive 22) · ×1
  • TMHMMMatchParser.parse (cognitive 22) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/tmhmm/TMHMMMatchParser.java:31 — TMHMMMatchParser.parse has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (20 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GFFResultWriterForNucSeqs.writeSequenceRegionPart (cognitive 22) · ×1
  • GFFResultWriterForNucSeqs.writeSequenceRegionPart (cognitive 22) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForNucSeqs.java:190 — GFFResultWriterForNucSeqs.writeSequenceRegionPart has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 4 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ManagerTopicMessageListener.onMessage (cognitive 22) · ×1
  • ManagerTopicMessageListener.onMessage (cognitive 22) REDACTED:68 — ManagerTopicMessageListener.onMessage has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (20 pts), error handling 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HamapCreateMiniDatabaseStep.execute (cognitive 22) · ×1
  • HamapCreateMiniDatabaseStep.execute (cognitive 22) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:103 — HamapCreateMiniDatabaseStep.execute has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (13 pts), error handling 4 (7 pts), loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RunBinaryStep.execute (cognitive 22) · ×1
  • RunBinaryStep.execute (cognitive 22) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java:138 — RunBinaryStep.execute has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (11 pts), error handling 3 (6 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Hmmer3FilteredMatchAndSiteDAO.getSites (cognitive 22) · ×1
  • Hmmer3FilteredMatchAndSiteDAO.getSites (cognitive 22) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:173 — Hmmer3FilteredMatchAndSiteDAO.getSites has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (8 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SignalPFilteredMatchDAOImpl.persist (cognitive 22) · ×1
  • SignalPFilteredMatchDAOImpl.persist (cognitive 22) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/SignalPFilteredMatchDAOImpl.java:52 — SignalPFilteredMatchDAOImpl.persist has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FamilyHierachySvgElementBuilder.<init> (cognitive 22) · ×1
  • FamilyHierachySvgElementBuilder.<init> (cognitive 22) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java:36 — FamilyHierachySvgElementBuilder.<init> has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (14 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · FamilyHierachyElementBuilder.<init> (cognitive 22) · ×1
  • FamilyHierachyElementBuilder.<init> (cognitive 22) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:23 — FamilyHierachyElementBuilder.<init> has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (14 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PrintsLookupMatchConverter.convertMatches (cognitive 22) · ×1
  • PrintsLookupMatchConverter.convertMatches (cognitive 22) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/PrintsLookupMatchConverter.java:47 — PrintsLookupMatchConverter.convertMatches has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (5 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LookupMatchConverter.getSiteLocationsMap (cognitive 22) · ×1
  • LookupMatchConverter.getSiteLocationsMap (cognitive 22) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupMatchConverter.java:71 — LookupMatchConverter.getSiteLocationsMap has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), boolean chains 1, error handling 1, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummaryInfo.gap_consensus (cognitive 22) · ×1
  • SummaryInfo.gap_consensus (cognitive 22) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:121 — SummaryInfo.gap_consensus has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CodonTable.list_ambiguous_codons (cognitive 22) · ×1
  • CodonTable.list_ambiguous_codons (cognitive 22) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Data/CodonTable.py:261 — CodonTable.list_ambiguous_codons has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 5 (9 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · setup.main (cognitive 22) · ×1
  • setup.main (cognitive 22) core/jms-implementation/support-mini-x86-32/setup.py:67 — setup.main has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (11 pts), error handling 1 (5 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Gene3dRawMatchFilter.addRecord (cognitive 21) · ×1
  • Gene3dRawMatchFilter.addRecord (cognitive 21) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:230 — Gene3dRawMatchFilter.addRecord has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Gene3DPostProcessing.addRecord (cognitive 21) · ×1
  • Gene3DPostProcessing.addRecord (cognitive 21) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:83 — Gene3DPostProcessing.addRecord has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JMSExceptionListener.onException (cognitive 21) · ×1
  • JMSExceptionListener.onException (cognitive 21) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/JMSExceptionListener.java:35 — JMSExceptionListener.onException has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DeleteFileStep.execute (cognitive 21) · ×1
  • DeleteFileStep.execute (cognitive 21) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DeleteFileStep.java:48 — DeleteFileStep.execute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuperMatchBucket.ensureNoOverlaps (cognitive 21) · ×1
  • SuperMatchBucket.ensureNoOverlaps (cognitive 21) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:123 — SuperMatchBucket.ensureNoOverlaps has cognitive complexity 21 (threshold 15). Drivers by points: loops 4 (11 pts), if/else 2 (10 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · substitution_matrices.read (cognitive 21) · ×1
  • substitution_matrices.read (cognitive 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/substitution_matrices/__init__.py:422 — substitution_matrices.read has cognitive complexity 21 (threshold 15). Drivers by points: loops 6 (11 pts), if/else 5 (10 pts) (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · Nexus.constant (cognitive 21) · ×1
  • Nexus.constant (cognitive 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1853 — Nexus.constant has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Writer.add_stmt_to_handle (cognitive 21) · ×1
  • Writer.add_stmt_to_handle (cognitive 21) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/CDAOIO.py:305 — Writer.add_stmt_to_handle has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · treegrafter.filter_best_domain (cognitive 21) · ×1
  • treegrafter.filter_best_domain (cognitive 21) core/jms-implementation/support-mini-x86-32/bin/panther/treegrafter.py:424 — treegrafter.filter_best_domain has cognitive complexity 21 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 2 (5 pts) (nesting depth added 14). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · FastaFileWriter.writeFastaFile (cognitive 20) · ×1
  • FastaFileWriter.writeFastaFile (cognitive 20) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/FastaFileWriter.java:69 — FastaFileWriter.writeFastaFile has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 2 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CommandLineConversationMonitor.simpleBinaryRunDelay (cognitive 20) · ×1
  • CommandLineConversationMonitor.simpleBinaryRunDelay (cognitive 20) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:85 — CommandLineConversationMonitor.simpleBinaryRunDelay has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (12 pts), error handling 2 (6 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.run (cognitive 20) · ×1
  • 1.run (cognitive 20) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:880 — 1.run has cognitive complexity 20 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 3 (8 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WriteGene3dSsfFileStep.execute (cognitive 20) · ×1
  • WriteGene3dSsfFileStep.execute (cognitive 20) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:106 — WriteGene3dSsfFileStep.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParseAndPersistProDomOutputStep.execute (cognitive 20) · ×1
  • ParseAndPersistProDomOutputStep.execute (cognitive 20) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:64 — ParseAndPersistProDomOutputStep.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 2, boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParseAndPersistStep.execute (cognitive 20) · ×1
  • ParseAndPersistStep.execute (cognitive 20) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:70 — ParseAndPersistStep.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 2, boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilteredMatchDAOImpl.getModelAccessionToSignatureMap (cognitive 20) · ×1
  • FilteredMatchDAOImpl.getModelAccessionToSignatureMap (cognitive 20) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:143 — FilteredMatchDAOImpl.getModelAccessionToSignatureMap has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 5 (7 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hmmer3BerkeleyMatchConverter.convertMatch (cognitive 20) · ×1
  • Hmmer3BerkeleyMatchConverter.convertMatch (cognitive 20) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer3BerkeleyMatchConverter.java:29 — Hmmer3BerkeleyMatchConverter.convertMatch has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 4 (10 pts), if/else 3 (6 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummaryInfo._guess_consensus_alphabet (cognitive 20) · ×1
  • SummaryInfo._guess_consensus_alphabet (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:182 — SummaryInfo._guess_consensus_alphabet has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (18 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummaryInfo.pos_specific_score_matrix (cognitive 20) · ×1
  • SummaryInfo.pos_specific_score_matrix (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:377 — SummaryInfo.pos_specific_score_matrix has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (8 pts), error handling 2 (7 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Alphabet._consensus_alphabet (cognitive 20) · ×1
  • Alphabet._consensus_alphabet (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Alphabet/__init__.py:347 — Alphabet._consensus_alphabet has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus.cstatus (cognitive 20) · ×1
  • Nexus.cstatus (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1913 — Nexus.cstatus has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 3, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Tree._parse (cognitive 20) · ×1
  • Tree._parse (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:87 — Tree._parse has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 7, loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Tree.root_with_outgroup (cognitive 20) · ×1
  • Tree.root_with_outgroup (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/BaseTree.py:842 — Tree.root_with_outgroup has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 3, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Seq.translate (cognitive 20) · ×1
  • Seq.translate (cognitive 20) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Seq.py:1128 — Seq.translate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 2, error handling 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MonitorQueueMessageListenerImpl.onMessage (cognitive 19) · ×1
  • MonitorQueueMessageListenerImpl.onMessage (cognitive 19) REDACTED:39 — MonitorQueueMessageListenerImpl.onMessage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 2 (5 pts), error handling 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParseAndPersistSuperFamilyOutputStep.execute (cognitive 19) · ×1
  • ParseAndPersistSuperFamilyOutputStep.execute (cognitive 19) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:62 — ParseAndPersistSuperFamilyOutputStep.execute has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 2, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hmmer3FilteredMatchDAO.persist (cognitive 19) · ×1
  • Hmmer3FilteredMatchDAO.persist (cognitive 19) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchDAO.java:48 — Hmmer3FilteredMatchDAO.persist has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hmmer3WithSitesLookupMatchConverter.convertMatch (cognitive 19) · ×1
  • Hmmer3WithSitesLookupMatchConverter.convertMatch (cognitive 19) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer3WithSitesLookupMatchConverter.java:27 — Hmmer3WithSitesLookupMatchConverter.convertMatch has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 4 (6 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · search.main (cognitive 19) · ×1
  • search.main (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/funfam/4.3.0/search.py:11 — search.main has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 3 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _SQLiteManySeqFilesDict._build_index (cognitive 19) · ×1
  • _SQLiteManySeqFilesDict._build_index (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/File.py:660 — _SQLiteManySeqFilesDict._build_index has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 2 (3 pts), boolean chains 2, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus._adjust_charlabels (cognitive 19) · ×1
  • Nexus._adjust_charlabels (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:2080 — Nexus._adjust_charlabels has cognitive complexity 19 (threshold 15). Drivers by points: loops 4 (11 pts), if/else 5 (7 pts), boolean chains 1 (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · Consensus._sub_clade (cognitive 19) · ×1
  • Consensus._sub_clade (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/Consensus.py:450 — Consensus._sub_clade has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser._parse_tree (cognitive 19) · ×1
  • Parser._parse_tree (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/NewickIO.py:137 — Parser._parse_tree has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (17 pts), error handling 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NNITreeSearcher._get_neighbors (cognitive 19) · ×1
  • NNITreeSearcher._get_neighbors (cognitive 19) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:916 — NNITreeSearcher._get_neighbors has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 2, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GaValuesRetriever.lazyInitialise (cognitive 18) · ×1
  • GaValuesRetriever.lazyInitialise (cognitive 18) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/GaValuesRetriever.java:88 — GaValuesRetriever.lazyInitialise has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Converter.initOutputFile (cognitive 18) · ×1
  • Converter.initOutputFile (cognitive 18) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:304 — Converter.initOutputFile has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), error handling 1 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Run.getRealAnalysesNames (cognitive 18) · ×1
  • Run.getRealAnalysesNames (cognitive 18) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1136 — Run.getRealAnalysesNames has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (10 pts), loops 2 (5 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistributedBlackBoxMaster.handleLongRunningJobs (cognitive 18) · ×1
  • DistributedBlackBoxMaster.handleLongRunningJobs (cognitive 18) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:678 — DistributedBlackBoxMaster.handleLongRunningJobs has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (3 pts), match/switch 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParseAndPersisteStep.execute (cognitive 18) · ×1
  • ParseAndPersisteStep.execute (cognitive 18) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:75 — ParseAndPersisteStep.execute has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 3 (7 pts), error handling 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinMatchesHTMLResultWriter.write (cognitive 18) · ×1
  • ProteinMatchesHTMLResultWriter.write (cognitive 18) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:110 — ProteinMatchesHTMLResultWriter.write has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (12 pts), error handling 1 (4 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProteinMatchesSVGResultWriter.write (cognitive 18) · ×1
  • ProteinMatchesSVGResultWriter.write (cognitive 18) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesSVGResultWriter.java:45 — ProteinMatchesSVGResultWriter.write has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (12 pts), error handling 1 (4 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PrepareForOutputStep.execute (cognitive 18) · ×1
  • PrepareForOutputStep.execute (cognitive 18) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:89 — PrepareForOutputStep.execute has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (14 pts), error handling 2, boolean chains 1, loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SummaryInfo._get_column_info_content (cognitive 18) · ×1
  • SummaryInfo._get_column_info_content (cognitive 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/AlignInfo.py:633 — SummaryInfo._get_column_info_content has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus.crop_matrix (cognitive 18) · ×1
  • Nexus.crop_matrix (cognitive 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:1951 — Nexus.crop_matrix has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Tree.display (cognitive 18) · ×1
  • Tree.display (cognitive 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:597 — Tree.display has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistanceCalculator._pairwise (cognitive 18) · ×1
  • DistanceCalculator._pairwise (cognitive 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:496 — DistanceCalculator._pairwise has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnknownSeq.join (cognitive 18) · ×1
  • UnknownSeq.join (cognitive 18) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Seq.py:1959 — UnknownSeq.join has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PfamHMMER3PostProcessing.getNestedModels (cognitive 17) · ×1
  • PfamHMMER3PostProcessing.getNestedModels (cognitive 17) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pfam_A/PfamHMMER3PostProcessing.java:219 — PfamHMMER3PostProcessing.getNestedModels has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 3 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DomainFinderRecord.getSegmentAndBoundaries (cognitive 17) · ×1
  • DomainFinderRecord.getSegmentAndBoundaries (cognitive 17) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:304 — DomainFinderRecord.getSegmentAndBoundaries has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PantherMatchParser.createMatch (cognitive 17) · ×1
  • PantherMatchParser.createMatch (cognitive 17) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/panther/PantherMatchParser.java:38 — PantherMatchParser.createMatch has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 5 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FingerPRINTSHierarchyDBParser.parse (cognitive 17) · ×1
  • FingerPRINTSHierarchyDBParser.parse (cognitive 17) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prints/FingerPRINTSHierarchyDBParser.java:39 — FingerPRINTSHierarchyDBParser.parse has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InterProXMLUnmarshaller.processGoTerms (cognitive 17) · ×1
  • InterProXMLUnmarshaller.processGoTerms (cognitive 17) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshaller.java:202 — InterProXMLUnmarshaller.processGoTerms has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 1, ternaries 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Converter.writeProteinMatches (cognitive 17) · ×1
  • Converter.writeProteinMatches (cognitive 17) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:483 — Converter.writeProteinMatches has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LSFJobInfoParser.parse (cognitive 17) · ×1
  • LSFJobInfoParser.parse (cognitive 17) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/lsf/LSFJobInfoParser.java:46 — LSFJobInfoParser.parse has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), error handling 3, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ParseAndPersistBinaryOutputStep.execute (cognitive 17) · ×1
  • ParseAndPersistBinaryOutputStep.execute (cognitive 17) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:61 — ParseAndPersistBinaryOutputStep.execute has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (13 pts), error handling 2, boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WriteOutputStep.writeProteinMatches (cognitive 17) · ×1
  • WriteOutputStep.writeProteinMatches (cognitive 17) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:869 — WriteOutputStep.writeProteinMatches has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.compare (cognitive 17) · ×1
  • 1.compare (cognitive 17) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrintsFilteredMatchDAOImpl.java:152 — 1.compare has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (17 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · SimpleEntry.compareTo (cognitive 17) · ×1
  • SimpleEntry.compareTo (cognitive 17) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleEntry.java:122 — SimpleEntry.compareTo has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Alphabet._check_type_compatible (cognitive 17) · ×1
  • Alphabet._check_type_compatible (cognitive 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Alphabet/__init__.py:427 — Alphabet._check_type_compatible has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (14 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StepMatrix.smprint (cognitive 17) · ×1
  • StepMatrix.smprint (cognitive 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:246 — StepMatrix.smprint has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TreeMixin.prune (cognitive 17) · ×1
  • TreeMixin.prune (cognitive 17) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/BaseTree.py:690 — TreeMixin.prune has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookup.isAnalysisVersionConsistent (cognitive 16) · ×1
  • BerkeleyPrecalculatedProteinLookup.isAnalysisVersionConsistent (cognitive 16) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:600 — BerkeleyPrecalculatedProteinLookup.isAnalysisVersionConsistent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.isAnalysisVersionConsistent (cognitive 16) · ×1
  • BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.isAnalysisVersionConsistent (cognitive 16) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:383 — BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.isAnalysisVersionConsistent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PirsfDatFileParser.loadRecords (cognitive 16) · ×1
  • PirsfDatFileParser.loadRecords (cognitive 16) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/pirsf/PirsfDatFileParser.java:56 — PirsfDatFileParser.loadRecords has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InterProXMLUnmarshaller.processMemberDatabaseXrefs (cognitive 16) · ×1
  • InterProXMLUnmarshaller.processMemberDatabaseXrefs (cognitive 16) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshaller.java:286 — InterProXMLUnmarshaller.processMemberDatabaseXrefs has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ExternalDriverDataSource.loadDriver (cognitive 16) · ×1
  • ExternalDriverDataSource.loadDriver (cognitive 16) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/ExternalDriverDataSource.java:128 — ExternalDriverDataSource.loadDriver has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MatchAndSitePostProcessingStep.execute (cognitive 16) · ×1
  • MatchAndSitePostProcessingStep.execute (cognitive 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:89 — MatchAndSitePostProcessingStep.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 4 (6 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · WriteFastaFileStep.execute (cognitive 16) · ×1
  • WriteFastaFileStep.execute (cognitive 16) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteFastaFileStep.java:65 — WriteFastaFileStep.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), error handling 3, loops 1 (2 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hmmer3FilteredMatchAndSiteDAO.persist (cognitive 16) · ×1
  • Hmmer3FilteredMatchAndSiteDAO.persist (cognitive 16) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:37 — Hmmer3FilteredMatchAndSiteDAO.persist has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleSuperMatch.inSameHierarchy (cognitive 16) · ×1
  • SimpleSuperMatch.inSameHierarchy (cognitive 16) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleSuperMatch.java:128 — SimpleSuperMatch.inSameHierarchy has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 2 (3 pts), boolean chains 1, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BerkeleyLocation.hashCode (cognitive 16) · ×1
  • BerkeleyLocation.hashCode (cognitive 16) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/model/BerkeleyLocation.java:230 — BerkeleyLocation.hashCode has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 16. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · seg.run (cognitive 16) · ×1
  • seg.run (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/mobidb/idrpred/seg.py:10 — seg.run has cognitive complexity 16 (threshold 15). Drivers by points: loops 2 (6 pts), ternaries 1 (5 pts), if/else 2 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PairwiseAlignment.format (cognitive 16) · ×1
  • PairwiseAlignment.format (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Align/__init__.py:982 — PairwiseAlignment.format has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 2 (4 pts), error handling 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Nexus.read (cognitive 16) · ×1
  • Nexus.read (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Nexus.py:696 — Nexus.read has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (9 pts), error handling 3 (5 pts), loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Tree._add_nodedata (cognitive 16) · ×1
  • Tree._add_nodedata (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Nexus/Trees.py:152 — Tree._add_nodedata has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 1 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Parser._parse_phylogeny (cognitive 16) · ×1
  • Parser._parse_phylogeny (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/PhyloXMLIO.py:341 — Parser._parse_phylogeny has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _Matrix.__init__ (cognitive 16) · ×1
  • _Matrix.__init__ (cognitive 16) core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/TreeConstruction.py:89 — _Matrix.__init__ has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D3 · God Classes · ClassTooLong · ×1
  • ClassTooLong: WorkerImpl core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56 — ClassTooLong — 889 significant lines (blank, comment-only and punctuation-only lines excluded), 107 methods. The bar is 400 significant lines; this is 489 over it, 2.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D31 · IaC & Container Security · Medium IaC · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (4 members, 45 shared lines) · ×1
  • Near-duplicate member family (4 members, 45 shared lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:80 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:80-300 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:79-289 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:61-192 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:117-279 — These 4 members are variants of one another: a block of 45 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Near-duplicate member family (4 members, 14 shared lines) · ×1
  • Near-duplicate member family (4 members, 14 shared lines) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1155 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1155-1266 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1268-1367 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1370-1464 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1476-1521 — These 4 members are variants of one another: a block of 14 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Near-duplicate member pair (79 shared lines) · ×1
  • Near-duplicate member pair (79 shared lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:257 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:257-454 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:161-366 — These two members are variants of one another: 79 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (56 shared lines) · ×1
  • Near-duplicate member pair (56 shared lines) REDACTED:113 — REDACTED:113-207 | REDACTED:217-306 — These two members are variants of one another: 56 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (43 shared lines) · ×1
  • Near-duplicate member pair (43 shared lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:308 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:308-485 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:164-266 — These two members are variants of one another: 43 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (35 corresponding lines) · ×1
  • Edited copy of a member (35 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:110 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesHTMLResultWriter.java:110-144 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/writer/ProteinMatchesSVGResultWriter.java:45-80 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (7 members, 50+ identical tokens) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:116 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:116-131 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:106-121 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/MobiDBFilteredMatchDAO.java:127-142 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:155-170 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:138-153 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAO.java:162-177 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:101-115 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication · Edited copy of a member (120 corresponding lines) · ×1
  • Edited copy of a member (120 corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:33 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:33-185 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:32-151 — These two members are one piece of code written twice and then edited apart: 120 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (90 corresponding lines) · ×1
  • Edited copy of a member (90 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:233 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:233-323 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:86-175 — These two members are one piece of code written twice and then edited apart: 90 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (74 corresponding lines) · ×1
  • Edited copy of a member (74 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrintsFilteredMatchDAOImpl.java:50 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrintsFilteredMatchDAOImpl.java:50-128 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProDomFilteredMatchDAOImpl.java:52-125 — These two members are one piece of code written twice and then edited apart: 74 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (67 corresponding lines) · ×1
  • Edited copy of a member (67 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:238 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:238-305 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:95-161 — These two members are one piece of code written twice and then edited apart: 67 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (66 corresponding lines) · ×1
  • Edited copy of a member (66 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:744 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:744-810 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:355-420 — These two members are one piece of code written twice and then edited apart: 66 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (51 corresponding lines) · ×1
  • Edited copy of a member (51 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:53 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:53-103 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:75-131 — These two members are one piece of code written twice and then edited apart: 51 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (48 corresponding lines) · ×1
  • Edited copy of a member (48 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:181 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:181-228 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:190-237 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (42 corresponding lines) · ×1
  • Edited copy of a member (42 corresponding lines) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:744 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:744-785 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:514-555 — These two members are one piece of code written twice and then edited apart: 42 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (37 corresponding lines) · ×1
  • Edited copy of a member (37 corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:76 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:76-112 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java:84-126 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×1
  • Edited copy of a member (21 corresponding lines) REDACTED:74 — REDACTED:74-94 | REDACTED:143-164 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProfileFilteredMatchDAO.java:35 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProfileFilteredMatchDAO.java:35-63 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PrositePatternFilteredMatchDAO.java:34-62 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×1
  • Edited copy of a member (23 corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer2BerkeleyMatchConverter.java:24 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer2BerkeleyMatchConverter.java:24-56 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PantherBerkeleyMatchConverter.java:26-48 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 23+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 23+ corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:812 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:812-835 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:837-859 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:861-883 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:885-907 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 33+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 33+ corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherScoreStep.java:75 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherScoreStep.java:75-110 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsr/RunPIRSRBinaryStep.java:109-154 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/sfld/RunSFLDBinaryStep.java:82-114 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 33 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 22+ corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:199 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:199-228 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationMonitor.java:233-260 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:518-539 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 20+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 20+ corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/coils/CoilsMatchParser.java:72 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/coils/CoilsMatchParser.java:72-91 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/mobidb/MobiDBMatchParser.java:64-83 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:66-85 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/tmhmm/TMHMMRawResultParser.java:83-102 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 26+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 26+ corresponding lines) REDACTED:55 — REDACTED:55-80 | REDACTED:42-67 | REDACTED:55-82 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 18+ corresponding lines) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunCathResolveHitsBinaryStep.java:75 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunCathResolveHitsBinaryStep.java:75-103 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunDomainFinder3BinaryStep.java:66-83 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/RunSmartBinaryStep.java:34-56 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 13+ corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/CoilsBerkeleyMatchConverter.java:20 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/CoilsBerkeleyMatchConverter.java:20-32 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PhobiusBerkeleyMatchConverter.java:17-30 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/ProdomMatchConverter.java:23-39 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/TMHMMBerkeleyMatchConverter.java:17-30 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 16+ corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:158 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:158-174 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java:142-158 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:295-310 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/HmmerRawMatch.java:106-121 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 15+ corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:316 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:316-331 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:330-344 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:469-484 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 13+ corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:191 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:191-203 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:205-217 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/sequence/XrefParser.java:219-231 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 7+ corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FunFamHmmer3Match.java:33 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FunFamHmmer3Match.java:33-40 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:66-73 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:74-80 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:87-93 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 9+ corresponding lines) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/CoilsLookupMatchConverter.java:14 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/CoilsLookupMatchConverter.java:14-23 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/MobiDBLookupMatchConverter.java:26-34 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/PhobiusLookupMatchConverter.java:14-24 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/TMHMMLookupMatchConverter.java:14-24 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleSignature.java:51 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleSignature.java:51-60 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleSiteLocation.java:24-34 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleSuperMatch.java:145-157 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 11+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 11+ corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:105 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:105-116 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java:78-89 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java:78-89 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProfileScanMatch.java:131-142 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SignalPMatch.java:89-99 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×1
  • Edited copy of a member (4 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:120 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:120-123 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:325-328 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 4+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 4+ corresponding lines) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:121 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:121-124 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:156-161 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:148-152 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:136-139 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×1
  • Edited copy of a member (5 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:127 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:127-132 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:119-123 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (3 corresponding lines) · ×1
  • Edited copy of a member (3 corresponding lines) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:127 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:127-129 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProfileScanMatch.java:153-155 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (62 lines × 2) · ×1
  • Duplicated block (62 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:363 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:363-424 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:256-317 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:363` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (51–52 lines × 2) · ×1
  • Duplicated block (51–52 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:241 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:241-291 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:97-148 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:241` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:240` calls `verboseLog`, `getId` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:95` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (51 lines × 2) · ×1
  • Duplicated block (51 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:135 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:135-185 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:101-151 — before extracting anything, compare `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:135` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (47–48 lines × 2) · ×1
  • Duplicated block (47–48 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:104 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:104-151 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:150-196 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 102 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:104` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×1
  • Duplicated block (42 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:282 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:282-323 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:134-175 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:282` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (38 lines × 2) · ×1
  • Duplicated block (38 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:242 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:242-279 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:95-132 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:242` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (37 lines × 2) · ×1
  • Duplicated block (37 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesJSONResultWriter.java:58 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesJSONResultWriter.java:58-94 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesXMLResultWriter.java:64-100 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesJSONResultWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesXMLResultWriter.java` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesXMLResultWriter.java:104` calls `warn` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesJSONResultWriter.java:98` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (36 lines × 2) · ×1
  • Duplicated block (36 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:111 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:111-146 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:94-129 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (31–32 lines × 3) · ×1
  • Duplicated block (31–32 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1172 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1172-1202 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1273-1303 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1375-1406 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1172` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (30 lines × 4) · ×1
  • Duplicated block (30 lines × 4) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:493 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:493-522 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:531-560 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:274-303 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:312-341 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:493` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (22–30 lines × 2) · ×1
  • Duplicated block (22–30 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:603 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:603-632 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:385-406 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 301 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:603` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×1
  • Duplicated block (30 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:749 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:749-778 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:359-388 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:749` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:391` calls `get`, `buildTarArchiveName`, `toString` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:782` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (27 lines × 3) · ×1
  • Duplicated block (27 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:129 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:129-155 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:138-164 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherScoreStep.java:149-175 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:129` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23–26 lines × 2) · ×1
  • Duplicated block (23–26 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:173 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:173-198 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java:29-51 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 136 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:173` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:77 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:77-102 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:123-148 — before extracting anything, compare `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java` and `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 102 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23–24 lines × 2) · ×1
  • Duplicated block (23–24 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:34 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:34-56 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java:33-56 — before extracting anything, compare `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java` and `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 93 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java:34` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22–24 lines × 2) · ×1
  • Duplicated block (22–24 lines × 2) core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:32 — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:32-55 | core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataResourceReader.java:30-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataResourceReader.java:30` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (21 lines × 3) · ×1
  • Duplicated block (21 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:196 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:196-216 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:192-212 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:133-153 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:196` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:132` calls `getParameters`, `get` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:195` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (17–19 lines × 3) · ×1
  • Duplicated block (17–19 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1250 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1250-1266 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1349-1367 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1446-1464 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1250` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1347` calls `setDeprecated` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1248` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×1
  • Duplicated block (19 lines × 3) core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:97 — core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:97-115 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java:102-120 | core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java:104-122 — before extracting anything, compare `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMatchDBService.java` and `core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleySiteDBService.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (18–19 lines × 2) · ×1
  • Duplicated block (18–19 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:98 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:98-115 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:94-112 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17–18 lines × 4) · ×1
  • Duplicated block (17–18 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:97 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:97-114 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:89-106 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:85-102 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:93-109 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 113 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:97` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17–18 lines × 2) · ×1
  • Duplicated block (17–18 lines × 2) core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:313 — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:313-330 | core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadProteinFastaFile.java:18-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (15–17 lines × 2) · ×1
  • Duplicated block (15–17 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:85 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:85-101 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PantherFilteredMatchDAOImpl.java:132-146 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (12–16 lines × 3) · ×1
  • Duplicated block (12–16 lines × 3) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:63 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:63-74 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:88-99 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAO.java:69-84 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:63` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×1
  • Duplicated block (14–15 lines × 2) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:100 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:100-113 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:91-105 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–14 lines × 5) · ×1
  • Duplicated block (11–14 lines × 5) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:104 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:104-114 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:200-213 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:96-106 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:92-102 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:99-109 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 113 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:104` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:148 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:148-161 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:138-151 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:265-278 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:148` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–14 lines × 2) · ×1
  • Duplicated block (12–14 lines × 2) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:48 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:48-61 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/RPSBlastFilteredMatchDAO.java:65-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:48` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–13 lines × 3) · ×1
  • Duplicated block (12–13 lines × 3) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:317 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:317-328 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:331-342 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:470-482 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:317` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:329` calls `getSignature`, `getCrossReferences` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:343` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 10) · ×1
  • Duplicated block (12 lines × 10) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/AntiFamHmmer3ParserSupport.java:56 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/AntiFamHmmer3ParserSupport.java:56-67 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/FunFamHmmer3ParserSupport.java:42-53 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Gene3DHmmer3ParserSupport.java:65-76 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Gene3DHmmer3ParserSupport.java:102-113 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/NCBIfamParserSupport.java:56-67 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSFHmmer3ParserSupport.java:36-47 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3ParserSupport.java:60-71 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Pfam_A_Hmmer3Hmmer3ParserSupport.java:109-120 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/SFLDHmmer3ParserSupport.java:60-71 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/TigrFamHmmer3ParserSupport.java:56-67 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/NCBIfamParserSupport.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/TigrFamHmmer3ParserSupport.java` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Gene3DHmmer3ParserSupport.java:62` calls `getCathFamilyId`, `getMatchModelName` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/FunFamHmmer3ParserSupport.java:40` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 5) · ×1
  • Duplicated block (12 lines × 5) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:156 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:156-167 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:146-157 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java:273-284 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:179-190 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:138-149 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:156` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (11–12 lines × 4) · ×1
  • Duplicated block (11–12 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:131 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:131-141 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:122-133 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:119-129 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:126-136 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 113 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:131` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:137` calls `verboseLog` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:144` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:329 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:329-340 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:164-174 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:329` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 4) · ×1
  • Duplicated block (19 lines × 4) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:238 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:238-256 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:233-251 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FinaliseInitialSetupStep.java:120-138 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:175-193 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 214 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:258` calls `toString` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java:256` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7–11 lines × 3) · ×1
  • Duplicated block (7–11 lines × 3) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:92 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:92-98 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:46-55 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:44-54 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesRAWResultWriter.java:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinMatchesTSVProResultWriter.java:56` calls `getSignatureModels` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/ProteinSiteMatchesTSVResultWriter.java:55` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:110 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:110-120 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:92-102 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:91-101 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:52 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:52-60 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:78-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:51` calls `haveFinished` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ProductionMaster.java:77` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–10 lines × 5) · ×1
  • Duplicated block (9–10 lines × 5) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:104 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:104-113 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:92-101 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:93-102 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:84-93 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:88-96 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:104` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:114` calls `verboseLog`, `size` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:104` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–10 lines × 3) · ×1
  • Duplicated block (9–10 lines × 3) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:814 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:814-823 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:839-847 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:887-896 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:814` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (3–10 lines × 7) · ×1
  • Duplicated block (3–10 lines × 7) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:122 — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:122-131 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:112-121 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/MobiDBFilteredMatchDAO.java:133-135 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAO.java:161-163 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/PhobiusFilteredMatchDAOImpl.java:144-146 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAO.java:168-170 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/TMHMMFilteredMatchDAOImplOld.java:107-109 — before extracting anything, compare `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java` and `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:122` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8–10 lines × 2) · ×1
  • Duplicated block (8–10 lines × 2) core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:273 — core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:273-280 | core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:301-310 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:273` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–9 lines × 6) · ×1
  • Duplicated block (8–9 lines × 6) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102-110 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:90-97 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:91-98 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:82-89 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:86-93 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStepOldV11.java:75-82 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 8) · ×1
  • Duplicated block (8 lines × 8) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:142 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:142-149 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:129-136 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:300-307 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:135-142 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:120-127 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:117-124 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:124-131 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStepOldV11.java:100-107 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:142` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:138` calls `isDebugEnabled`, `debug` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:309` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7–8 lines × 5) · ×1
  • Duplicated block (7–8 lines × 5) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:72 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:72-79 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:89-95 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:122-129 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:66-73 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:63-70 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (7–8 lines × 4) · ×1
  • Duplicated block (7–8 lines × 4) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:84 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:84-91 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java:148-155 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FunFamHmmer3FilteredMatchDAOImpl.java:31-37 | core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:104-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FunFamHmmer3FilteredMatchDAOImpl.java:31` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer2BerkeleyMatchConverter.java:28 — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer2BerkeleyMatchConverter.java:28-35 | core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PantherBerkeleyMatchConverter.java:32-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/Hmmer2BerkeleyMatchConverter.java:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 7) · ×1
  • Duplicated block (7 lines × 7) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102-108 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:90-96 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:280-286 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:91-97 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:82-88 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:86-92 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tmhmm/TMHMMParseStepOldV11.java:75-81 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 6) · ×1
  • Duplicated block (7 lines × 6) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116-122 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:120-126 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:291-297 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:105-111 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:111-117 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/signalp/ParseAndPersistBinaryOutputStep.java:108-114 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:114` calls `verboseLog`, `size` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:102` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–7 lines × 5) · ×1
  • Duplicated block (6–7 lines × 5) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:108 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:108-114 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:91-96 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:90-95 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:106-111 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartPostProcessingStep.java:90-96 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:105` calls `size` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:87` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–7 lines × 2) · ×1
  • Duplicated block (6–7 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomTblDomainMatch.java:59 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomTblDomainMatch.java:59-64 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomTblDomainMatch.java:66-72 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/parsemodel/DomTblDomainMatch.java:66` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (4–7 lines × 3) · ×1
  • Duplicated block (4–7 lines × 3) core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:201 — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:201-208 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:377-380 | core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:383-389 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:201` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/SingleSeqOptimisedBlackBoxMaster.java:201` calls `toMinutes` and `core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:377` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 7) · ×1
  • Duplicated block (6 lines × 7) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:102-107 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java:90-95 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseStep.java:105-110 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:280-285 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prints/ParsePrintsOutputStep.java:91-96 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prodom/ParseAndPersistProDomOutputStep.java:82-87 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/superfamily/ParseAndPersistSuperFamilyOutputStep.java:86-91 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/ParseAndPersistStep.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (5 lines × 8) · ×1
  • Duplicated block (5 lines × 8) core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:71 — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:71-75 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:91-95 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:76-80 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:75-79 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStep.java:97-101 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositePatternsPostProcessingStep.java:74-78 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/prosite/PrositeProfilesPostProcessingStep.java:75-79 | core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/tigrfam/TigrFamPostProcessingStep.java:64-68 — before extracting anything, compare `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java` and `core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 5) · ×1
  • Duplicated block (7 lines × 5) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:58 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:58-64 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java:73-79 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prodom/model/ProDomModelParser.java:61-67 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/prosite/PrositeDatFileParser.java:78-84 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java:75-81 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/model/HmmerModelParser.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/superfamily/model/SuperFamilyModelParser.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cdd/CDDModelParser.java:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (41 lines × 2) · ×1
  • Duplicated block (41 lines × 2) core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java:1 — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java:1-67 | core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlWriter.java:1-41 — before extracting anything, compare `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java` and `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlWriter.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 11) · ×1
  • Duplicated block (9 lines × 11) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:147 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/BlastProDomMatch.java:147-155 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java:209-217 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:141-149 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3Match.java:245-253 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java:194-202 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/MobiDBMatch.java:118-126 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PantherMatch.java:346-354 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/PatternScanMatch.java:231-239 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/ProfileScanMatch.java:173-181 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SignalPMatch.java:129-137 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SuperFamilyHmmer3Match.java:162-170 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 11 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:48 — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:48-57 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer2Match.java:102-111 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/MobiDBMatch.java:80-89 | core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawSite.java:39-48 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
IC1 · Incompleteness & stubs · Empty method body · ×1
  • Empty method body — does nothing with its inputs core/io/src/main/java/uk/ac/ebi/interpro/scan/io/XmlFragmentWriter.java:49 — `header` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Minor — 589 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×395
  • Orphaned file core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/StatsUtil.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/PIRSRHmmer3MatchParser.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/StepCreationSequenceLoadListener.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/LookupStoreToI5ModelDAOImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/converter/Converter.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/StandaloneBlackBoxMaster.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/ProteinLoader.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Signature.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAOImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SimpleProtein.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/queuejumper/platforms/SubmissionWorkerRunner.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshaller.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFFResultWriterForNucSeqs.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/DomainFinderRecord.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 370 more in this group — see findings.md.
P10 · Library API & versioning · Implementation type on the public API · ×40
  • Implementation type on the public API core/business/src/main/java/uk/ac/ebi/interpro/scan/business/binary/RawMatchBinaryRunnerImpl.java:32 — 1 public type in `uk.ac.ebi.interpro.scan.business.binary` is marked as implementation by its own namespace, folder or name: `RawMatchBinaryRunnerImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/binary/RawMatchBinaryRunnerImpl.java:32, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:34 — 2 public types in `uk.ac.ebi.interpro.scan.business.sequence.fasta` are marked as implementation by their own namespace, folder or name: `LoadFastaFileImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:34, name ends in `Impl`), `LoadFastaFileIntoDBImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java:42, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:19 — 1 public type in `uk.ac.ebi.interpro.scan.business.sequence.uniparcdb` is marked as implementation by its own namespace, folder or name: `LoadUniParcFromDBImpl` (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:19, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:48 — 1 public type in `uk.ac.ebi.interpro.scan.genericjpadao` is marked as implementation by its own namespace, folder or name: `GenericDAOImpl` (core/generic-jpa-dao/src/main/java/uk/ac/ebi/interpro/scan/genericjpadao/GenericDAOImpl.java:48, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/io/src/main/java/uk/ac/ebi/interpro/scan/io/InstallerTemporaryDirectoryManagerImpl.java:13 — 3 public types in `uk.ac.ebi.interpro.scan.io` are marked as implementation by their own namespace, folder or name: `InstallerTemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/InstallerTemporaryDirectoryManagerImpl.java:13, name ends in `Impl`), `NoopTemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/NoopTemporaryDirectoryManagerImpl.java:10, name ends in `Impl`), `TemporaryDirectoryManagerImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/TemporaryDirectoryManagerImpl.java:23, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:27 — 1 public type in `uk.ac.ebi.interpro.scan.io.cli` is marked as implementation by its own namespace, folder or name: `CommandLineConversationImpl` (core/io/src/main/java/uk/ac/ebi/interpro/scan/io/cli/CommandLineConversationImpl.java:27, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:27 — 2 public types in `uk.ac.ebi.interpro.scan.jms.activemq` are marked as implementation by their own namespace, folder or name: `MasterMessageSenderImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/MasterMessageSenderImpl.java:27, name ends in `Impl`), `StepExecutionTransactionImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/StepExecutionTransactionImpl.java:29, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API REDACTED:24 — 1 public type in `uk.ac.ebi.interpro.scan.jms.master` is marked as implementation by its own namespace, folder or name: `ResponseMonitorImpl` (REDACTED:24, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API REDACTED:23 — 1 public type in `uk.ac.ebi.interpro.scan.jms.monitoring` is marked as implementation by its own namespace, folder or name: `MonitorQueueMessageListenerImpl` (REDACTED:23, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/ProducerCallbackImpl.java:13 — 1 public type in `uk.ac.ebi.interpro.scan.jms.stats` is marked as implementation by its own namespace, folder or name: `ProducerCallbackImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/stats/ProducerCallbackImpl.java:13, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56 — 2 public types in `uk.ac.ebi.interpro.scan.jms.worker` are marked as implementation by their own namespace, folder or name: `WorkerImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:56, name ends in `Impl`), `WorkerMessageSenderImpl` (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerMessageSenderImpl.java:23, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAOImpl.java:17 — 2 public types in `uk.ac.ebi.interpro.scan.management.dao` are marked as implementation by their own namespace, folder or name: `StepExecutionDAOImpl` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAOImpl.java:17, name ends in `Impl`), `StepInstanceDAOImpl` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepInstanceDAOImpl.java:20, name ends in `Impl`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/AbstractParseHmmpfamOutputStep.java:27 — 15 public types in `uk.ac.ebi.interpro.scan.management.model.implementations` are marked as implementation by their own namespace, folder or name: `AbstractParseHmmpfamOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/AbstractParseHmmpfamOutputStep.java:27, `implementations`), `CompositeParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/CompositeParseStep.java:32, `implementations`), `DeleteFileStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DeleteFileStep.java:19, `implementations`), `Domain` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/Domain.java:7, `implementations`), `DomainResolver` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DomainResolver.java:5, `implementations`), `FileContentChecker` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FileContentChecker.java:17, `implementations`), `FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/FilterStep.java:23, `implementations`), `MatchAndSitePostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/MatchAndSitePostProcessingStep.java:31, `implementations`), and 7 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/CDDPostProcessingStep.java:13 — 4 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.cdd` are marked as implementation by their own namespace, folder or name: `CDDPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/CDDPostProcessingStep.java:13, `implementations`), `ParseCDDOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/ParseCDDOutputStep.java:16, `implementations`), `RunCDDPostBlastUtilityStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:26, `implementations`), `RunCDDRPSBlastStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDRPSBlastStep.java:23, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/CoilsParseStep.java:7 — 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.coils` are marked as implementation by their own namespace, folder or name: `CoilsParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/CoilsParseStep.java:7, `implementations`), `RunCoilsBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/coils/RunCoilsBinaryStep.java:24, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:18 — 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.funfam` are marked as implementation by their own namespace, folder or name: `ParseAndPersisteStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/ParseAndPersisteStep.java:18, `implementations`), `RunFunFamBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/funfam/RunFunFamBinaryStep.java:13, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:41 — 6 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.gene3d` are marked as implementation by their own namespace, folder or name: `Gene3DParseAndPersistOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:41, `implementations`), `Gene3DPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DPostProcessingStep.java:25, `implementations`), `RunAssignCathFamilyBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunAssignCathFamilyBinaryStep.java:16, `implementations`), `RunCathResolveHitsBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunCathResolveHitsBinaryStep.java:17, `implementations`), `RunDomainFinder3BinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunDomainFinder3BinaryStep.java:18, `implementations`), `WriteGene3dSsfFileStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/WriteGene3dSsfFileStep.java:22, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:36 — 4 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hamap` are marked as implementation by their own namespace, folder or name: `HamapCreateMiniDatabaseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapCreateMiniDatabaseStep.java:36, `implementations`), `HamapHmmPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapHmmPostProcessingStep.java:27, `implementations`), `HamapPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/HamapPostProcessingStep.java:26, `implementations`), `RunPFSearchStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hamap/RunPFSearchStep.java:22, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer/RunHmmerBinaryStep.java:22 — 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer` is marked as implementation by its own namespace, folder or name: `RunHmmerBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer/RunHmmerBinaryStep.java:22, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3FilterStep.java:14 — 14 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3` are marked as implementation by their own namespace, folder or name: `AntiFamHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3FilterStep.java:14, `implementations`), `AntiFamHmmer3ParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/AntiFamHmmer3ParseStep.java:12, `implementations`), `Gene3dHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStep.java:27, `implementations`), `Gene3dHmmer3ParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3ParseStep.java:12, `implementations`), `NCBIfamFilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/NCBIfamFilterStep.java:10, `implementations`), `NCBIfamParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/NCBIfamParseStep.java:9, `implementations`), `PIRSRBinaryParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PIRSRBinaryParseStep.java:14, `implementations`), `PIRSRHmmer3FilterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PIRSRHmmer3FilterStep.java:15, `implementations`), and 6 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/ParsePfam_A_HMMER3OutputStep.java:13 — 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.hmmer3.PfamA` are marked as implementation by their own namespace, folder or name: `ParsePfam_A_HMMER3OutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/ParsePfam_A_HMMER3OutputStep.java:13, `implementations`), `Pfam_A_PostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/PfamA/Pfam_A_PostProcessingStep.java:30, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/ParseMobiDBOutputStep.java:13 — 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.mobidb` are marked as implementation by their own namespace, folder or name: `ParseMobiDBOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/ParseMobiDBOutputStep.java:13, `implementations`), `RunMobiDBBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/mobidb/RunMobiDBBinaryStep.java:19, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:22 — 7 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.panther` are marked as implementation by their own namespace, folder or name: `PantherBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherBinaryStep.java:22, `implementations`), `PantherNewBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherNewBinaryStep.java:21, `implementations`), `PantherParseStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherParseStep.java:31, `implementations`), `PantherPostProcessingStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherPostProcessingStep.java:26, `implementations`), `PantherScoreStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/PantherScoreStep.java:21, `implementations`), `RunPantherScoreStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherScoreStep.java:21, `implementations`), `RunPantherTreeGrafterStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherTreeGrafterStep.java:20, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/ParsePhobiusOutputStep.java:15 — 2 public types in `uk.ac.ebi.interpro.scan.management.model.implementations.phobius` are marked as implementation by their own namespace, folder or name: `ParsePhobiusOutputStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/ParsePhobiusOutputStep.java:15, `implementations`), `RunPhobiusBinaryStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/phobius/RunPhobiusBinaryStep.java:23, `implementations`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
  • Implementation type on the public API core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsf/hmmer3/PIRSFPostProcessAndPersistStep.java:25 — 1 public type in `uk.ac.ebi.interpro.scan.management.model.implementations.pirsf.hmmer3` is marked as implementation by its own namespace, folder or name: `PIRSFPostProcessAndPersistStep` (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/pirsf/hmmer3/PIRSFPostProcessAndPersistStep.java:25, `implementations`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
  • + 15 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×40
  • Duplicated predicate core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java:87 — `!signatureLibrary.equals(m.getSignatureLibrary()) || !signatureLibraryRelease.equals(m.getSignatureLibraryRelease())` appears character-identically in 4 files — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer2RawMatch.java, core/model/src/main/java/uk/ac/ebi/interpro/scan/model/raw/Hmmer3RawMatch.java, core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FunFamHmmer3FilteredMatchDAOImpl.java, core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java:168 — `(!stdinOn) && fastaFileInputStream == null` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadIntoDBStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/FastaFileLoadStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java:397 — `(currentDomain != null) && (currentSequenceIdentifier != null)` appears character-identically in 2 files — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3ScanMatchParser.java, core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParser.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:371 — `analysedMd5s == null || analysedMd5s.size() == 0` appears character-identically in 2 files — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookupPreMultiThreadedLookup.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/CoilsBerkeleyMatchConverter.java:21 — `berkeleyMatch == null || signature == null` appears character-identically in 6 files — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/CoilsBerkeleyMatchConverter.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PantherBerkeleyMatchConverter.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/PhobiusBerkeleyMatchConverter.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromonion/ProdomMatchConverter.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java:311 — `bottomProteinId == null || bottomProteinId > newProtein.getId()` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/proteinLoad/MatchLookupStep.java, core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAO.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java:185 — `currentId == null || currentId.isEmpty()` appears character-identically in 2 files — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileImpl.java, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/fasta/LoadFastaFileIntoDBImpl.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java:39 — `execution != null && execution.getException() != null` appears character-identically in 2 files — core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/EmailErrorAndContinueErrorStrategy.java, core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/activemq/NonZeroExitOnUnrecoverableError.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java:26 — `familyEntries != null && familyEntries.size() > 0` appears character-identically in 2 files — core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/FamilyHierachyElementBuilder.java, core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/svg/FamilyHierachySvgElementBuilder.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java:67 — `filteredMatches == null && filteredMatches.isEmpty()` appears character-identically in 2 files — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchAndSiteDAO.java, core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/Hmmer3FilteredMatchDAO.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/cdd/CDDPostProcessing.java:63 — `filteredProtein.getMatches() != null && filteredProtein.getMatches().size() > 0` appears character-identically in 3 files — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/cdd/CDDPostProcessing.java, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prosite/PatternPostProcessing.java, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prosite/ProfilePostProcessing.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:54 — `filteredProteins == null || filteredProteins.size() == 0` appears character-identically in 2 files — core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java, core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchDAOImpl.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java:168 — `forceHmmsearch || Utilities.getSequenceCount() > 10` appears character-identically in 4 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/Gene3DParseAndPersistOutputStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/gene3d/RunCathResolveHitsBinaryStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer/RunHmmerBinaryStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/panther/RunPantherScoreStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java:141 — `group4 != null && group4.trim().length() > 0` appears character-identically in 2 files — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/PhobiusMatchParser.java, core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/phobius/parsemodel/PhobiusFeature.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DeleteFileStep.java:53 — `job.getLibraryRelease() != null && checkIfDoSkipRun(stepInstance.getBottomProtein(), stepInstance.getTopProtein())` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/DeleteFileStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/RunBinaryStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/io/src/main/java/uk/ac/ebi/interpro/scan/io/funfam/CathResolveHit.java:87 — `line.trim().isEmpty() || line.startsWith("#")` appears character-identically in 2 files — core/io/src/main/java/uk/ac/ebi/interpro/scan/io/funfam/CathResolveHit.java, core/io/src/main/java/uk/ac/ebi/interpro/scan/io/gene3d/CathResolveHitsOutputParser.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java:262 — `mModelId.equals(r.getModelId()) && m.getLocationStart() <= lowestBoundary && m.getLocationEnd() >= highestBoundary && m.getDomainIeValue() =…` appears character-identically in 2 files — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/filter/Gene3dRawMatchFilter.java, core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/gene3d/Gene3DPostProcessing.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer2LookupMatchConverter.java:17 — `match.getHmmBounds() == null || match.getHmmBounds().isEmpty()` appears character-identically in 2 files — core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/Hmmer2LookupMatchConverter.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/conversion/toi5/fromkvs/PantherLookupMatchConverter.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java:80 — `minSizeCommandLine != null && minSizeCommandLine.length() > 0` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunGetOrfStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/stepInstanceCreation/nucleotide/RunTranslateToProteinsStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java:164 — `new EqualsBuilder() .appendSuper(super.equals(o)) .append(hmmStart, h.hmmStart) .append(hmmEnd, h.hmmEnd) .append(hmmLength, h.hmmLength) .a…` appears character-identically in 2 files — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocation.java, core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerLocationWithSites.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java:84 — `new EqualsBuilder() .appendSuper(super.equals(o)) .append(score, m.score) .isEquals() && PersistenceConversion.equivalent(evalue, m.evalue)` appears character-identically in 2 files — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatch.java, core/model/src/main/java/uk/ac/ebi/interpro/scan/model/HmmerMatchWithSites.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java:82 — `new EqualsBuilder() .appendSuper(super.equals(o)) .isEquals() && PersistenceConversion.equivalent(evalue, m.evalue)` appears character-identically in 2 files — core/model/src/main/java/uk/ac/ebi/interpro/scan/model/FingerPrintsMatch.java, core/model/src/main/java/uk/ac/ebi/interpro/scan/model/SuperFamilyHmmer3Match.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/NucleotideSequenceLoader.java:107 — `nonUniqueIdentifiers != null && nonUniqueIdentifiers.size() > 0` appears character-identically in 2 files — core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/NucleotideSequenceLoader.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:780 — `outputFormat.equals(FileOutputFormat.HTML) || outputFormat.equals(FileOutputFormat.SVG)` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java:789 — `outputFormat.equals(FileOutputFormat.SVG) && !archiveSVGOutput` appears character-identically in 2 files — core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/PrepareForOutputStep.java, core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • + 15 more in this group — see findings.md.
X4 · Structured logging · Interpolated log message defeats structured logging · ×40
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:46 — `debug` at line 46 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/model/SuperMatchBucket.java:117 — `debug` at line 117 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:72 — `info` at line 72 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseMatchDataResult.java:78 — `error` at line 78 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:74 — `error` at line 74 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:83 — `info` at line 83 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:141 — `warn` at line 141 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/AnalyseStructuralMatchDataResult.java:149 — `debug` at line 149 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/CreateSimpleProteinFromMatchDataImpl.java:81 — `info` at line 81 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:52 — `warn` at line 52 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:59 — `warn` at line 59 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:77 — `warn` at line 77 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchy.java:101 — `warn` at line 101 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:120 — `warn` at line 120 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryHierarchyDataResourceReader.java:124 — `warn` at line 124 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/EntryToGoDataResourceReader.java:48 — `error` at line 48 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:41 — `debug` at line 41 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:85 — `debug` at line 85 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/MatchDataResourceReader.java:98 — `debug` at line 98 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/web/src/main/java/uk/ac/ebi/interpro/scan/web/io/StructuralMatchDataResourceReader.java:37 — `debug` at line 37 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:430 — `debug` at line 430 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:464 — `debug` at line 464 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:475 — `debug` at line 475 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/util/src/main/java/uk/ac/ebi/interpro/scan/util/Utilities.java:476 — `debug` at line 476 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging core/precalcmatches/server/src/main/java/uk/ac/ebi/interpro/scan/precalc/server/service/impl/BerkeleyMD5DBService.java:102 — `error` at line 102 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • + 15 more in this group — see findings.md.
IC1 · Incompleteness & stubs · Disabled test · ×24
  • Disabled test core/business/src/test/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessingTest.java:61 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/CathDomainListRecordTest.java:38 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/Model2SfReaderTest.java:34 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:60 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:101 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:123 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/prints/PrintsMatchParserTest.java:50 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/model/GaValuesRetrieverTest.java:19 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/io/src/test/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshallerTest.java:67 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/activemq/ActiveMQTest.java:26 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/activemq/ActiveMQTest.java:36 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/activemq/InstallerTest.java:27 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/persistence/test/HibernateAnnotationTest.java:36 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/management/src/test/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStepTest.java:59 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/management/src/test/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartParseFilterTest.java:38 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/management/src/test/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartParseFilterTest.java:86 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/model/src/test/java/uk/ac/ebi/interpro/scan/model/NucleicAcidMatchesHolderTest.java:69 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinMatchesHolderTest.java:49 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinMatchesHolderTest.java:71 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinTest.java:110 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinTest.java:212 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/web/src/test/java/uk/ac/ebi/interpro/scan/web/freeMarker/svg/SVGFreeMarkerTest.java:52 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/web/src/test/java/uk/ac/ebi/interpro/scan/web/model/CondensedViewComponentTest.java:126 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test core/web/src/test/java/uk/ac/ebi/interpro/scan/web/model/CondensedViewTest.java:38 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
D30 · Dependency Vulnerabilities · Low CVE · ×14
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×4
  • Projects may be oversized for their cohesion REDACTED:1 — `core/io` (16134 LoC, 161 module-visible types across 44 directories) overshoots its size bounds. 4 of 15 build unit(s) (Maven, Python, checkout) overshoot their size bounds, lowering Project Cohesion to 4.7/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
  • Projects may be oversized for their cohesion REDACTED:1 — `core/management` (14003 LoC, 128 module-visible types across 30 directories) overshoots its size bounds. 4 of 15 build unit(s) (Maven, Python, checkout) overshoot their size bounds, lowering Project Cohesion to 4.7/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
  • Projects may be oversized for their cohesion REDACTED:1 — `core/model` (14012 LoC, 146 module-visible types across 5 directories) overshoots its size bounds. 4 of 15 build unit(s) (Maven, Python, checkout) overshoot their size bounds, lowering Project Cohesion to 4.7/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
  • Projects may be oversized for their cohesion REDACTED:1 — `core/jms-implementation` (12426 LoC, 75 module-visible types across 11 directories) overshoots its size bounds. 4 of 15 build unit(s) (Maven, Python, checkout) overshoot their size bounds, lowering Project Cohesion to 4.7/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/worker/WorkerImpl.java:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
AX6 · Interface segregation · Fat interface · ×2
  • Fat interface: KVDB (26 abstract methods) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/kvstore/KVDB.java:18 — `KVDB` declares 26 abstract methods: `addSignatureLibraryName`, `asEntry`, `asMatch`, `asMatchSet`, `asNucleotideSequence`, `asProtein`, `asString`, `close`, `get`, `getAllElements`, `getDbName`, `getDbPath`, `getKVDBStore`, `getKVDBType`, `getLevelDBStore`, `getNucleotideSequence`, `getProtein`, `getSignatureLibraryNames`, `put`, `put`, `serialize`, `serialize`, `serialize`, `serialize`, `serialize`, `setKVDBStore`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 26 declarations carry 21 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 21 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ProteinDAO (24 abstract methods) core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/ProteinDAO.java:37 — `ProteinDAO` declares 24 abstract methods: `checkKVDBStores`, `closeKVDBStores`, `getKeyToProteinMap`, `getLevelDBStore`, `getProtein`, `getProteinAndCrossReferencesByProteinId`, `getProteinById`, `getProteinNotInLookup`, `getProteins`, `getProteins`, `getProteinsAndMatchesAndCrossReferencesBetweenIds`, `getProteinsBetweenIds`, `getProteinsByIds`, `getProteinsNotInLookup`, `getProteinsNotInLookupCount`, `getProteinsWithoutLookupHit`, `getProteinsWithoutLookupHitBetweenIds`, `insert`, `insertNewProteins`, `insertProteinNotInLookup`, `persist`, `persist`, `persistProteinNotInLookup`, `setProteinIdsWithoutLookupHit`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 24 declarations carry 22 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 22 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D16 · Bus Factor · Off-boarding risk · ×2
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 4 significant file(s) lose their only recent owner: core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java, scripts/convert_output.py, core/model/src/main/java/uk/ac/ebi/interpro/scan/model/Hmmer3MatchWithSites.java, core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/writer/GFF3Feature.java. Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 4 significant file(s) lose their only recent owner: core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMatchesDBFromOracle.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateSitesDBFromOracle.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/IprscanMain.java, core/precalcmatches/berkeley/src/main/java/uk/ac/ebi/interpro/scan/precalc/berkeley/iprscan/CreateMD5DBFromOracle.java. Pair on, review, or document these before any departure.
D19 · Documentation Quality · Documentation · ×1
  • Documentation: no build, run or usage example README.md:1 — the repository holds project manifests and neither `README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found REDACTED:16 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `REDACTED` makes this repository a deployable product (line 16).
D21 · Naming Consistency · `hierarchyModelIDLimitation` spells `ID` where 18 names in the project spell it `Id` · ×1
  • `hierarchyModelIDLimitation` spells `ID` where 18 names in the project spell it `Id` core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prints/PrintsPostProcessing.java:188 — 18 of 19 names in project interproscan-business spell the token `Id` (18 of 19; unit: names in project interproscan-business containing `Id`). Peers: PostProcessor.process(proteinIdToRawMatchMap) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/PostProcessor.java:22); CDDPostProcessing.process(proteinIdToRawMatchMap) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/cdd/CDDPostProcessing.java:45); PfamHMMER3PostProcessing.process(proteinIdToRawMatchMap) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/pfam_A/PfamHMMER3PostProcessing.java:52); PrintsPostProcessing.process(proteinIdToRawMatchMap) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prints/PrintsPostProcessing.java:68); PatternPostProcessing.process(proteinIdToRawMatchMap) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/prosite/PatternPostProcessing.java:43). Rename to `hierarchyModelIdLimitation`. [rule N6]
D21 · Naming Consistency · `setXrefDao` spells `Dao` where 28 names in the project spell it `DAO` · ×1
  • `setXrefDao` spells `Dao` where 28 names in the project spell it `DAO` core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:50 — 28 of 30 names in project interproscan-business spell the token `DAO` (28 of 30; unit: names in project interproscan-business containing `DAO`). Peers: SmartPostProcessing.setProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:80); SmartPostProcessing.setProteinDAO(proteinDAO) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:80); BerkeleyPrecalculatedProteinLookup.getProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:96); BerkeleyPrecalculatedProteinLookup.setProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:101); BerkeleyPrecalculatedProteinLookup.setProteinDAO(proteinDAO) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:101). Rename to `setXrefDAO`. [rule N6]
D21 · Naming Consistency · `proteinXrefDao` spells `Dao` where 28 names in the project spell it `DAO` · ×1
  • `proteinXrefDao` spells `Dao` where 28 names in the project spell it `DAO` core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/uniparcdb/LoadUniParcFromDBImpl.java:50 — 28 of 30 names in project interproscan-business spell the token `DAO` (28 of 30; unit: names in project interproscan-business containing `DAO`). Peers: SmartPostProcessing.setProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:80); SmartPostProcessing.setProteinDAO(proteinDAO) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessing.java:80); BerkeleyPrecalculatedProteinLookup.getProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:96); BerkeleyPrecalculatedProteinLookup.setProteinDAO (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:101); BerkeleyPrecalculatedProteinLookup.setProteinDAO(proteinDAO) (core/business/src/main/java/uk/ac/ebi/interpro/scan/business/sequence/BerkeleyPrecalculatedProteinLookup.java:101). Rename to `proteinXrefDAO`. [rule N6]
D21 · Naming Consistency · `configureTCPTransport` spells `TCP` where 15 names in the project spell it `Tcp` · ×1
  • `configureTCPTransport` spells `TCP` where 15 names in the project spell it `Tcp` core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/main/Run.java:1539 — 15 of 16 names in project jms-implementation spell the token `Tcp` (15 of 16; unit: names in project jms-implementation containing `Tcp`). Peers: ClusterUser.setTcpUri (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ClusterUser.java:12); ClusterUser.getTcpUri (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/ClusterUser.java:14); DistributedBlackBoxMaster.setTcpUri (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:502); DistributedBlackBoxMaster.getTcpUri (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMaster.java:506); DistributedBlackBoxMasterOLD.setTcpUri (core/jms-implementation/src/main/java/uk/ac/ebi/interpro/scan/jms/master/DistributedBlackBoxMasterOLD.java:131). Rename to `configureTcpTransport`. [rule N6]
D21 · Naming Consistency · `setXrefDao` spells `Dao` where 135 names in the project spell it `DAO` · ×1
  • `setXrefDao` spells `Dao` where 135 names in the project spell it `DAO` core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:124 — 135 of 136 names in project interproscan-management spell the token `DAO` (135 of 136; unit: names in project interproscan-management containing `DAO`). Peers: uk.ac.ebi.interpro.scan.management.dao.StepExecutionDAO (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAO.java:13); uk.ac.ebi.interpro.scan.management.dao.StepExecutionDAOImpl (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepExecutionDAOImpl.java:17); uk.ac.ebi.interpro.scan.management.dao.StepInstanceDAO (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepInstanceDAO.java:19); uk.ac.ebi.interpro.scan.management.dao.StepInstanceDAOImpl (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/dao/StepInstanceDAOImpl.java:20); StepExecution.submit(stepExecutionDAO) (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/StepExecution.java:172). Rename to `setXrefDAO`. [rule N6]
D21 · Naming Consistency · `writeFASTASequences` spells `FASTA` where 57 names in the project spell it `Fasta` · ×1
  • `writeFASTASequences` spells `FASTA` where 57 names in the project spell it `Fasta` core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteOutputStep.java:861 — 57 of 58 names in project interproscan-management spell the token `Fasta` (57 of 58; unit: names in project interproscan-management containing `Fasta`). Peers: uk.ac.ebi.interpro.scan.management.model.implementations.WriteFastaFileStep (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteFastaFileStep.java:26); WriteFastaFileStep.setFastaFileNameTemplate (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteFastaFileStep.java:38); WriteFastaFileStep.setFastaFileWriter (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/WriteFastaFileStep.java:54); RunCDDPostBlastUtilityStep.setFastaFileNameTemplate (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDPostBlastUtilityStep.java:45); RunCDDRPSBlastStep.setFastaFileNameTemplate (core/management/src/main/java/uk/ac/ebi/interpro/scan/management/model/implementations/cdd/RunCDDRPSBlastStep.java:38). Rename to `writeFastaSequences`. [rule N6]
D21 · Naming Consistency · `nucleotideSequenceID` spells `ID` where 97 names in the project spell it `Id` · ×1
  • `nucleotideSequenceID` spells `ID` where 97 names in the project spell it `Id` core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/NucleotideSequenceDAO.java:33 — 97 of 99 names in project interproscan-persistence spell the token `Id` (97 of 99; unit: names in project interproscan-persistence containing `Id`). Peers: CoilsFilteredMatchDAO.getProteinIdToProteinMap (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:142); CoilsFilteredMatchDAOImpl.getProteinIdToProteinMap (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:132); FilteredMatchAndSiteDAO.persist(modelIdToSignatureMap) (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAO.java:37); FilteredMatchAndSiteDAO.persist(proteinIdToProteinMap) (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAO.java:37); FilteredMatchAndSiteDAOImpl.persist(modelIdToSignatureMap) (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/FilteredMatchAndSiteDAOImpl.java:106). Rename to `nucleotideSequenceId`. [rule N6]
D21 · Naming Consistency · `JdbcEntryDao` spells `Dao` where 118 names in the project spell it `DAO` · ×1
  • `JdbcEntryDao` spells `Dao` where 118 names in the project spell it `DAO` core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/JdbcEntryDao.java:10 — 118 of 121 names in project interproscan-persistence spell the token `DAO` (118 of 121; unit: names in project interproscan-persistence containing `DAO`). Peers: uk.ac.ebi.interpro.scan.persistence.AntiFamHmmer3FilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/AntiFamHmmer3FilteredMatchDAOImpl.java:10); uk.ac.ebi.interpro.scan.persistence.CDDFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CDDFilteredMatchDAOImpl.java:14); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:17); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:18); DAOManager.getProteinDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/DAOManager.java:31). Rename to `JdbcEntryDAO`. [rule N6]
D21 · Naming Consistency · `JdbcEntryDaoImpl` spells `Dao` where 118 names in the project spell it `DAO` · ×1
  • `JdbcEntryDaoImpl` spells `Dao` where 118 names in the project spell it `DAO` core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/JdbcEntryDaoImpl.java:16 — 118 of 121 names in project interproscan-persistence spell the token `DAO` (118 of 121; unit: names in project interproscan-persistence containing `DAO`). Peers: uk.ac.ebi.interpro.scan.persistence.AntiFamHmmer3FilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/AntiFamHmmer3FilteredMatchDAOImpl.java:10); uk.ac.ebi.interpro.scan.persistence.CDDFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CDDFilteredMatchDAOImpl.java:14); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:17); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:18); DAOManager.getProteinDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/DAOManager.java:31). Rename to `JdbcEntryDAOImpl`. [rule N6]
D21 · Naming Consistency · `NoOpEntryDaoImpl` spells `Dao` where 118 names in the project spell it `DAO` · ×1
  • `NoOpEntryDaoImpl` spells `Dao` where 118 names in the project spell it `DAO` core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/installer/NoOpEntryDaoImpl.java:10 — 118 of 121 names in project interproscan-persistence spell the token `DAO` (118 of 121; unit: names in project interproscan-persistence containing `DAO`). Peers: uk.ac.ebi.interpro.scan.persistence.AntiFamHmmer3FilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/AntiFamHmmer3FilteredMatchDAOImpl.java:10); uk.ac.ebi.interpro.scan.persistence.CDDFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CDDFilteredMatchDAOImpl.java:14); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAO.java:17); uk.ac.ebi.interpro.scan.persistence.CoilsFilteredMatchDAOImpl (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/CoilsFilteredMatchDAOImpl.java:18); DAOManager.getProteinDAO (core/persistence/src/main/java/uk/ac/ebi/interpro/scan/persistence/DAOManager.java:31). Rename to `NoOpEntryDAOImpl`. [rule N6]
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D34 · Knowledge Freshness · Concentrated knowledge decay · ×1
  • Concentrated knowledge decay — 398 of 418 significant files have no living knowledge, while the repository is still being changed at a low rate (3 commit(s) in the last 90 days) — so this is one repo-wide knowledge-decay state, not 398 separate risks. Counted over 418 of the 713 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. The code moved on without the people who understood these files: document them or schedule a read-through before the next change lands in them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation REDACTED:35 — `REDACTED` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
P6 · Release Hygiene · Changelog looks stale/thin · ×1
  • Changelog looks stale/thin — The changelog this check read carries 0 versioned entries, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.
PF1 · Benchmark discipline · Benchmarks don't track allocations · ×1
  • Benchmarks don't track allocations core/benchmarking/src/main/java/uk/ac/ebi/interpro/scan/benchmarking/RunBenchmark.java — A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured.
X23 · Unguarded diagnostic materialisation · Diagnostic log message is built whether or not it is wanted · ×1
  • Diagnostic log message is built whether or not it is wanted core/io/src/main/java/uk/ac/ebi/interpro/scan/io/match/cdd/CDDMatchParser.java:213 — `debug` at line 213 is called with an argument built by `Arrays.toString(siteInfo)` (line 213), whose cost grows with the collection it walks. Java evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isDebugEnabled`/`isTraceEnabled` test, no debug flag, no lambda or `Supplier` the logger calls only when the level is on.
X5 · Nullable reference types · Java packages are not null-marked everywhere · ×1
  • Java packages are not null-marked everywhere — 0/126 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×1
  • Silent fallback default on parse failure core/jms-implementation/support-mini-x86-32/bin/panther/Bio/Phylo/BaseTree.py:177 — `match` (in `_function_matcher`) returns `False` when `(LookupError, AttributeError, ValueError, TypeError)` is raised, with no log or raise — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing.
Minor — 19 finding(s)
D10 · Test Quality · Skipped (documented) · ×19
  • Skipped (documented): testParseAndFilter core/business/src/test/java/uk/ac/ebi/interpro/scan/business/postprocessing/smart/SmartPostProcessingTest.java:62 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testCreateSignatures core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/CathDomainListRecordTest.java:39 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testRead core/io/src/test/java/uk/ac/ebi/interpro/scan/io/gene3d/Model2SfReaderTest.java:35 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testEmptyAlignmentLine core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:102 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testGene3DParser core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:61 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testPfamParser core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/hmmer/hmmer3/Hmmer3SearchMatchParserTest.java:124 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testParserEfficiency core/io/src/test/java/uk/ac/ebi/interpro/scan/io/match/prints/PrintsMatchParserTest.java:51 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): DummyTest core/io/src/test/java/uk/ac/ebi/interpro/scan/io/model/GaValuesRetrieverTest.java:20 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testUnmarshallerAndSerialization core/io/src/test/java/uk/ac/ebi/interpro/scan/io/unmarshal/xml/interpro/InterProXMLUnmarshallerTest.java:68 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testEmbeddedSystem core/jms-implementation/src/test/java/uk/ac/ebi/interpro/scan/jms/activemq/ActiveMQTest.java:37 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testFilter core/management/src/test/java/uk/ac/ebi/interpro/scan/management/model/implementations/hmmer3/Gene3dHmmer3FilterStepTest.java:60 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testFilter core/management/src/test/java/uk/ac/ebi/interpro/scan/management/model/implementations/smart/SmartParseFilterTest.java:87 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testXml core/model/src/test/java/uk/ac/ebi/interpro/scan/model/NucleicAcidMatchesHolderTest.java:70 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testXml core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinMatchesHolderTest.java:72 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testEquals core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinTest.java:111 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testJpa core/model/src/test/java/uk/ac/ebi/interpro/scan/model/ProteinTest.java:213 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testSVGFileCreation core/web/src/test/java/uk/ac/ebi/interpro/scan/web/freeMarker/svg/SVGFreeMarkerTest.java:53 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testSuperMatchBucket core/web/src/test/java/uk/ac/ebi/interpro/scan/web/model/CondensedViewComponentTest.java:127 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
  • Skipped (documented): testCondensedView core/web/src/test/java/uk/ac/ebi/interpro/scan/web/model/CondensedViewTest.java:39 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=140" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-1.json --exit-code 0 --source .6artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=340 --max-count=92" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-2.json --exit-code 0 --source .6artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=432 --max-count=104" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-3.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-3.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=536 --max-count=104" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-4.json --exit-code 0 --source .7artifacts/raw/gitleaks-history-4.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=640 --max-count=119" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-5.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-5.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=759 --max-count=133" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-6.json --exit-code 0 --source .7artifacts/raw/gitleaks-history-6.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=892 --max-count=151" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-7.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-7.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1043 --max-count=141" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-8.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-8.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1184 --max-count=159" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-9.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-9.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1343 --max-count=180" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-10.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-10.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1523 --max-count=165" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-11.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-11.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1688 --max-count=180" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-12.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-12.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1868 --max-count=144" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-13.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-13.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2012 --max-count=153" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-14.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-14.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2165 --max-count=145" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-15.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-15.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2310 --max-count=152" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-16.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-16.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2462 --max-count=151" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-17.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-17.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2613 --max-count=159" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-18.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-18.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2772 --max-count=163" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-19.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-19.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=2935 --max-count=169" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-20.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-20.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=3104 --max-count=168" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-21.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-21.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=3272 --max-count=175" --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/history-22.json --exit-code 0 --source .0—
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-2c2603377e7a43c490536aeadfc02f23/tree.json --exit-code 0 --source .6artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .45artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .84artifacts/raw/osv-scanner.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .2artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .0artifacts/raw/osv-scanner.json

Run 01a1e763-6dba-7ff0-8c42-59770d5dd51d · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md