Public report of croc-code/jxfw, published 8 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.2). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 8 November 2026, 00:31 UTC · Survey ID cd_481f1f850a5748f0a065a9b44b4aa929

croc-code/jxfw

Measured 8 November 2026, 00:31 UTC, at code version 7af05aa

CAI score 52out of 100 At risk No change since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 95,362 lines of product code in 28 projects, tests not counted · Estimated rebuild effort: about 0.9 person-years · Weakest lens: Production Readiness, 49

Findings by how serious they are

27 critical 519 serious 95 minor

21 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
8 November 2026, 00:31 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

62of 62 dimensions measured by tools.
628of 641 findings point to an exact file and line, so you can open each one in the code. The other 13 concern the repository as a whole, such as missing documentation.
62dimensions across 6 lenses, read from 95,362 lines of product code in 28 projects.
Chapters

Executive summary

croc-code/jxfw is rated At risk because critical security findings are open, most of them in the packages it uses. Its score is held back because we found no automated security scanning of the code, its secrets or its dependencies. It scores 52 out of 100, which the At risk rating leaves unchanged.

Production Readiness, at 49, is the weakest lens, level with Maturity, and counts most in the score. The best first step is recording design decisions, worth about 4 points. Adding automated security scanning would lift Production Readiness itself, worth about 2 points.

Seventeen known security holes in the packages the code depends on can be used by attackers. Seven weaknesses in the code could be used by an attacker, and two pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Updating the vulnerable packages, fixing the weaknesses the scanner points to and pinning each tool to an exact version would close these risks. Giving the shared object a factory instead of the short-lived one would take care of the shared object holding on to a short-lived one.

The product code is 95,362 lines, about €130,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 49 · counts for 46%Maturity 49 · counts for 25%Code Health 53 · counts for 14%Security and Compliance 55 · counts for 8%Architecture 82 · counts for 4%Domain Modelling 100 · counts for 2%

The weakest lenses score close to each other, so improving any of them moves the score.

Code composition: what the lines of code are
Product code 94%Tests 6%
New since the last survey: 21 findings

These 21 critical or serious findings weren't in the previous survey, on 21 October 2026.

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 17 findings

These 17 critical or serious findings were in the previous survey, on 21 October 2026, and are gone from this one.

  • Test Quality · No assertions: caseIgnoreAndCaseSensitiveOperators jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testContainsAndMultipleNotContainsOnOneField jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testMassiveInequalities jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testMultiMapOrderedStringOperatorsWithIgnoreCase jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testMultiMapOrderedStringOperatorsWithoutIgnoreCase jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testMultipleContainsAndMultipleNotContainsOnOneField jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testMultipleContainsAndNotContainsOnOneField jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testOperatorAnyOfListWithNullOperator jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testOperatorValueIsNull jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testOperatorsOfComparing jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: testOperatorsOfFlags jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java
  • Test Quality · No assertions: storeContextCreation jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/store/StoreContextTest.java
  • Dependency Vulnerabilities · Critical CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Critical CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] jxfw-eclipse-bundles/bundles/jxfw-dependencies-bundle/pom.xml
  • Dependency Vulnerabilities · Medium CVE: REDACTED REDACTED
Rebuild cost: about €130,000 · Estimate
Cost to rebuild€44,000 to €220,000, for 734 to 2,328 hours of work, about 0.9 person-years for 1 to 2 engineers
Difficulty of the problemHigh, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 52. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 95,362 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Raises the score by about 4 points · Low effort · ADR Quality
2
Record your significant design decisions.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Raises the score by about 3 points · Medium effort · Architecture documentation
3
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 2 points · Medium effort · Security & performance tooling

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €130,000 to build again, about 0.9 person-years of work. Its weakest lens is Production Readiness, at 49 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 4 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.3 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 202 lines over the last 90 days, which is about 819 lines a year. At that pace, the extra work comes to an estimated 0 to 0.3 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch jxfw-cass-compile jxfw-cass-compile jxfw-cass-runtime jxfw-cass-runtime jxfw-cass-compile->jxfw-cass-runtime jxfw-core-compile jxfw-core-compile jxfw-cass-compile->jxfw-core-compile jxfw-core-runtime jxfw-core-runtime jxfw-cass-runtime->jxfw-core-runtime jxfw-core-compile->jxfw-core-runtime jxfw-metamodel jxfw-metamodel jxfw-core-runtime->jxfw-metamodel jxfw-export-poi jxfw-export-poi jxfw-export-poi->jxfw-core-runtime jxfw-fulltext-service jxfw-fulltext-service jxfw-fulltext-service->jxfw-core-compile jxfw-solr-runtime jxfw-solr-runtime jxfw-fulltext-service->jxfw-solr-runtime jxfw-jpa-compile jxfw-jpa-compile jxfw-jpa-compile->jxfw-core-compile jxfw-jpa-runtime jxfw-jpa-runtime jxfw-jpa-compile->jxfw-jpa-runtime jxfw-jpa-runtime->jxfw-core-runtime jxfw-reporting-birt jxfw-reporting-birt jxfw-reporting-birt->jxfw-core-runtime jxfw-reporting-xsl-fo jxfw-reporting-xsl-fo jxfw-reporting-xsl-fo->jxfw-core-compile jxfw-security jxfw-security jxfw-security->jxfw-core-runtime jxfw-wc-loader jxfw-wc-loader jxfw-security->jxfw-wc-loader jxfw-security-ldap jxfw-security-ldap jxfw-security-ldap->jxfw-security jxfw-solr-runtime->jxfw-core-runtime jxfw-transfer jxfw-transfer jxfw-transfer->jxfw-core-runtime jxfw-transfer-facade-gen-maven-plugin jxfw-transfer-facade-gen-maven-plugin jxfw-transfer-facade-gen-maven-plugin->jxfw-core-compile jxfw-transfer-facade-gen-maven-plugin->jxfw-transfer jxfw-wc-loader->jxfw-core-runtime modelgen-maven-plugin modelgen-maven-plugin modelgen-maven-plugin->jxfw-core-runtime scriptgen-maven-plugin scriptgen-maven-plugin scriptgen-maven-plugin->jxfw-core-compile wcgen-maven-plugin wcgen-maven-plugin wcgen-maven-plugin->jxfw-core-compile __more__ +8 more projects

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

225 modules, with 460 dependencies between them. 9 loops run through 39 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 185 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 core.reporting2 metamodel3 metamodel.runtime4 core.facade.webclient.file5 core.generator.impl6 core.load7 core.localization8 reporting.xslfo.layouts.formatters9 reporting.xslfo.renderer.excel.core.element.area10 reporting.xslfo.renderer.word.processing.tree.element.root11 core.exception.exceptions12 core.export13 core.generator14 reporting.xslfo.layouts15 reporting.xslfo.renderer.core.common16 core.store17 reporting.xslfo.renderer.excel.core.element.root18 reporting.xslfo.renderer.word.rendering19 core.facade.webclient.impl20 reporting.xslfo.renderer.excel21 reporting.xslfo.renderer.excel.core.rendering.excel22 core.facade.webclient23 reporting.xslfo.impl24 core.domain25 core.exception26 transfer.impl.imp.context.data27 core.datasource28 core.load.events29 core.store.impl30 jpa.exception31 transfer.component.imp.context.handler32 transfer.impl.exp33 core.load.impl34 transfer.component.imp.context35 core.export.impl36 transfer.impl.imp37 transfer.impl38 transfer.component.imp39 transfer.impl.imp.context40 transfer.config
1 core.reporting
2 metamodel
3 metamodel.runtime
4 core.facade.webclient.file1
5 core.generator.impl28
6 core.load12
7 core.localization1
8 reporting.xslfo.layouts.formatters11
9 reporting.xslfo.renderer.excel.core.element.area4
10 reporting.xslfo.renderer.word.processing.tree.element.root2
11 core.exception.exceptions814
12 core.export112
13 core.generator83
14 reporting.xslfo.layouts22
15 reporting.xslfo.renderer.core.common11
16 core.store2166
17 reporting.xslfo.renderer.excel.core.element.root95
18 reporting.xslfo.renderer.word.rendering111
19 core.facade.webclient.impl22212195
20 reporting.xslfo.renderer.excel222
21 reporting.xslfo.renderer.excel.core.rendering.excel212
22 core.facade.webclient2352123
23 reporting.xslfo.impl6111
24 core.domain21
25 core.exception2112
26 transfer.impl.imp.context.data3
27 core.datasource1112
28 core.load.events151
29 core.store.impl1145
30 jpa.exception4752
31 transfer.component.imp.context.handler1
32 transfer.impl.exp215
33 core.load.impl10232
34 transfer.component.imp.context111
35 core.export.impl121012221
36 transfer.impl.imp135117521
37 transfer.impl43211
38 transfer.component.imp213131
39 transfer.impl.imp.context55362143
40 transfer.config224362
Uses a module listed above itPart of a loopThe module itself
1 core.reporting2 metamodel3 metamodel.runtime4 core.facade.webclient.file5 core.generator.impl6 core.load7 core.localization8 reporting.xslfo.layouts.formatters9 reporting.xslfo.renderer.excel.core.element.area10 reporting.xslfo.renderer.word.processing.tree.element.root11 core.exception.exceptions12 core.export13 core.generator14 reporting.xslfo.layouts15 reporting.xslfo.renderer.core.common16 core.store17 reporting.xslfo.renderer.excel.core.element.root18 reporting.xslfo.renderer.word.rendering19 core.facade.webclient.impl20 reporting.xslfo.renderer.excel21 reporting.xslfo.renderer.excel.core.rendering.excel22 core.facade.webclient23 reporting.xslfo.impl24 core.domain25 core.exception26 transfer.impl.imp.context.data27 core.datasource28 core.load.events29 core.store.impl30 jpa.exception31 transfer.component.imp.context.handler32 transfer.impl.exp33 core.load.impl34 transfer.component.imp.context35 core.export.impl36 transfer.impl.imp37 transfer.impl38 transfer.component.imp39 transfer.impl.imp.context40 transfer.configcore.reporting1metamodel2metamodel.runtime3core.facade.webclient.file4core.generator.impl5core.load6core.localization7reporting.xslfo.layouts.formatters8reporting.xslfo.renderer.excel.core.element.area9reporting.xslfo.renderer.word.processing.tree.element.root10core.exception.exceptions11core.export12core.generator13reporting.xslfo.layouts14reporting.xslfo.renderer.core.common15core.store16reporting.xslfo.renderer.excel.core.element.root17reporting.xslfo.renderer.word.rendering18core.facade.webclient.impl19reporting.xslfo.renderer.excel20reporting.xslfo.renderer.excel.core.rendering.excel21core.facade.webclient22reporting.xslfo.impl23core.domain24core.exception25transfer.impl.imp.context.data26core.datasource27core.load.events28core.store.impl29jpa.exception30transfer.component.imp.context.handler31transfer.impl.exp32core.load.impl33transfer.component.imp.context34core.export.impl35transfer.impl.imp36transfer.impl37transfer.component.imp38transfer.impl.imp.context39transfer.config401281211142814112832211216695111222121952222122352123611121211231112151114547521215102321111210122211351175214321121313155362143224362+185 more modules (most-connected shown)

At a glance — Code Health · 53% · Adequate · gated by X5 ·

At a glance — Architecture · 82% · Strong ·

At a glance — Maturity · 49% · Weak · gated by M2 ·

At a glance — Readiness · 49% · Weak · gated by P3 ·

At a glance — Security · 55% · Checked 4 of 10 · gated by D29, D36 ·

At a glance — Domain Modelling · 100% · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2025 — Software Supply Chain Failures31High / Critical
A05:2025 — Injection19High / Critical

Roadmap

Top priorities: Resolve the 1 No ADRs found finding(s) in ADR Quality; Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them; Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality.+4.2 ptsLowADR Quality
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+3.3 ptsMediumArchitecture documentation
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.5 ptsMediumSecurity & performance tooling
Expand the README with getting-started, architecture overview and a project map.+2.0 ptsMediumDocumentation (README)
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.+1.4 ptsMediumDeployment & Rollback
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.+1.4 ptsMediumRelease Hygiene
Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).+1.4 ptsMediumNullable reference types
Resolve the 15 No assertions finding(s) in Test Quality — start with TestCmfEnumUtil.java (2), XslfoReportProfileTest.java (2), XmlTextReaderTest.java (2).+1.4 ptsMediumTest Quality

File quality

Per-file score 0–10 — a quality signature. Of 158 files carrying findings, judged against the Production bar: 1% slop · 49% mixed · 50% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED5.0MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED5.4MixedStatic Analysis (SAST): Medium: REDACTED
jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java6.0MixedExplicit Debt: TodoComment
wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java6.0MixedExplicit Debt: TodoComment
jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/AbstractEcoreGenerator.java6.0MixedExplicit Debt: TodoComment
wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java6.0MixedExplicit Debt: FixmeComment
jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposer.java6.0MixedExplicit Debt: TodoComment
jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java6.0MixedExplicit Debt: TodoComment
jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java6.0MixedExplicit Debt: TodoComment
jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceEcoreGenerator.java6.0MixedExplicit Debt: TodoComment
jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java6.0MixedExplicit Debt: TodoComment
jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java6.0MixedExplicit Debt: FixmeComment
jxfw-export-poi/src/main/java/ru/croc/ctp/jxfw/export/poi/impl/views/ExcelView.java6.0MixedExplicit Debt: FixmeComment
jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java6.0MixedExplicit Debt: TodoComment
wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java6.0MixedExplicit Debt: TodoComment
wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java6.0MixedExplicit Debt: FixmeComment
jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java6.0MixedExplicit Debt: FixmeComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 27

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 519

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 95

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 21

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 62 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 62 dimensions across the health lenses
D1D2D3D4D5D6D9D10D13D14D15D17D20D26D27D28D29D30D35D36D43D44AX1AX10AX2AX3AX4AX5AX6DM10DM12DM6DM9IC1M1M2M3P1P10P2P3P4P6X14X15X16X18X19X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 628 of 641 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1b891-7d2e-7e01-a5fe-8043dadb9382.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability not included — the Java/Kotlin suite (repository root, Maven) did not finish re-running within its budget: the JVM suite did not finish re-running within its tier budget.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 42 Maven/Gradle manifest(s) were read, stating a version for 16 dependency(ies) and leaving 198 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D15 Churn × Complexity Hotspots — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Git history depth insufficient — this repository has 18 commit(s), too few for a reliable trend signal. The clone is complete, so there is no deeper history to fetch: the signal returns as the project accumulates history.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-contributor repository — bus factor is not applicable (1 contributor(s) across 18 commit(s) sampled, automation and bot accounts excluded). Concentration needs a team to concentrate: with one contributor there is nobody to spread the knowledge to, so there is nothing here for the owner to act on.
  • D19 Documentation Quality — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: it declares a published package (jxfw-eclipse-bundles/bundles/jxfw-dependencies-bundle/pom.xml), but no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D34 Knowledge Freshness — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Too few commits to judge knowledge freshness (18 commit(s) sampled).
  • D35 Change Coupling — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Git history depth insufficient — this repository has 18 commit(s), too few for a reliable change-coupling signal. The clone is complete, so there is no deeper history to fetch: the signal returns as the project accumulates history.
  • AX1 Captive dependencies — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository also uses Guice, whose singleton and shorter-lived bindings can capture one another the same way, but this check does not read them yet. That is a gap in this analyzer's language reach — not a finding that those bindings are free of it.
  • C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • DM8 Value-object opportunities — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds primitive parameters that travel together through several signatures of the domain (a missing value object). Its deterministic rule has not yet shown 95 % precision on adjudicated rows, so the clumps it finds are counted here and not published as findings, and the card carries no score. That is a limit of the analyzer, not a finding about your code.
  • DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Arm one resolves each comparison operand to the domain member it judges, and that binding exists only in a Roslyn compilation, which this run did not load. Arm two ran over the neutral model because this repository's frontend declares whether each construction is produced or passed. A rule decided in two places would not appear above.
  • ED5 Idempotency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check decides whether a handler's mutation is safe to re-run by recognising its persistence writes (a database save, a repository write, an event publish) and its guards. Those markers are .NET member names, so in this repository's language a write such as `repository.save(order)` is not recognised and a same-named call on an unrelated library type could be. The handlers were found; their idempotency was neither confirmed nor ruled out.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Java is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • P8 Schema migrations — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The schema may be created by a runner, a deploy script or a config file outside what this check reads, so an absence here is our blind spot rather than a missing migration strategy. The card abstains instead of scoring. You can widen what we reach: if the schema is created and evolved by a tool this check does not name, naming it lets us teach the detector to read it.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X1 Async correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala, Rust or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X13 Undrained process stream — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X17 Uncapped recursion over a caller-supplied document — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Python, Dart, Ruby, Scala and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Python, Dart, Ruby, Scala or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 11 further occurrence(s) are not listed individually; the score already reflects all 51.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity5.9 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.9 / 10 · rule-coverage 100% · ceiling Prevented

47 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was AttributeParser.processProperties at 109. A further 9 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being XFWConstants.getUri at 30 — they are counted neither in the figure above nor in this dimension's score. 4 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/XFWConstants.java (XFWConstants.getUri at 30), jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/HelpFuncs.java (HelpFuncs.getSizeInPointsEx at 16), jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java (FoFont.setFontWeight at 16), jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java (CriteriaComposer.addCriteria at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

AttributeParser.processProperties (cyclomatic 109)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:334
TableLayout.writeTotalRow (cyclomatic 77)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2225
AttributeParser.processProperty (cyclomatic 77)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:308
XslFoTreeBuilder.parseChildrenElement (cyclomatic 67)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilder.java:116
XslfoTable.setHeaderBodyFooterBordersProperties (cyclomatic 65)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:460

+ 42 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 5 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with AttributeParser.processProperties (cyclomatic 109), TableLayout.writeTotalRow (cyclomatic 77), AttributeParser.processProperty (cyclomatic 77). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 5 together lifts Cyclomatic Complexity from 5.9 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity4.8 / 10Weak✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 4.8 / 10 · rule-coverage 100% · ceiling Prevented

115 method(s) exceeded the cognitive complexity threshold of 15; the worst was TableLayout.writeTotalRow at 313.

AttributeParser.processBorderAttribute (cognitive 24) · ×2jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:166
TableLayout.writeTotalRow (cognitive 313)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2225
TableLayout.writeGroupBound (cognitive 194)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1713
XslfoTable.setHeaderBodyFooterBordersProperties (cognitive 125)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:460
BlockProperties.addBlock (cognitive 91)jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:59

+ 109 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 3 bodies over 120 down to 120 or less in Cognitive Complexity — start with TableLayout.writeTotalRow (cognitive 313), TableLayout.writeGroupBound (cognitive 194), XslfoTable.setHeaderBodyFooterBordersProperties (cognitive 125). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 4.8 to about 5.8/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.9 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Prevented

45 god class(es) detected.

TooManyMethods: ToServiceGenerator · ×12wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:93
ClassTooLong: ToServiceGenerator · ×11wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:93
FileTooLong: layouts/TableLayout.java · ×11jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java
MethodTooLong: AttributeParser.processProperties · ×11jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:334

What to do

  1. Resolve the 12 TooManyMethods finding(s) in God Classes — start with ToServiceGenerator.java, TransferToServiceGenerator.java, LoggerOverReflection.java. — One of this dimension's main actionable groups (12 warning-level).
  2. Resolve the 11 ClassTooLong finding(s) in God Classes — start with ToServiceGenerator.java, WordRenderer.java, TransferToServiceGenerator.java. — One of this dimension's main actionable groups (11 warning-level).
  3. Resolve the 11 FileTooLong finding(s) in God Classes — start with TableLayout.java, ToServiceGenerator.java, WordRenderer.java. — One of this dimension's main actionable groups (11 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.2 / 10Stronggated by 161 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Verified

155 duplicated block group(s) detected. A further 6 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (8 lines × 2) · ×15jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:153
Duplicated block (6 lines × 2) · ×11jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:177
Duplicated block (7 lines × 2) · ×10jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2144
Duplicated block (16 lines × 2) · ×8jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:40
Duplicated block (15 lines × 2) · ×8jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1023

+ 55 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 15 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with TransferToServiceGenerator.java (4), WordRenderer.java (2), AbstractFacadeGenerator.java (2). — One of this dimension's main actionable groups (15 warning-level).
  2. Resolve the 11 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with TransferToServiceGenerator.java (3), BaseExportDataProvider.java, AttributeParser.java. — One of this dimension's main actionable groups (11 warning-level).
  3. Resolve the 10 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with TransferToServiceGenerator.java (4), TableLayout.java, WordRenderer.java. — One of this dimension's main actionable groups (10 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

28 production modules (Maven), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 0 module(s) off the main sequence, with abstractness counted on 23 of the 28 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)9.4 / 10Stronggated by 10 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Verified

10 of 207 classes have LCOM4 above 3.

Low cohesion: JsModelGenerator (LCOM4 8) · ×10wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:56

What to do

  1. Resolve the 10 Low cohesion finding(s) in Cohesion (LCOM4) — start with JsModelGenerator.java, ColumnBuilder.java, DomainViolation.java. — One of this dimension's main actionable groups (10 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

190 test methods: 190 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality8.8 / 10Strong✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

3 skipped (3 with a documented reason), 15 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 190 tests.

No assertions: testOp2 · ×15jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java:52
Skipped (documented): toStringOfReadSessionEventTest · ×3jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/load/events/EventsTest.java:27

What to do

  1. Resolve the 15 No assertions finding(s) in Test Quality — start with TestCmfEnumUtil.java (2), XslfoReportProfileTest.java (2), XmlTextReaderTest.java (2). — One of this dimension's main actionable groups (15 warning-level).
  2. Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 13 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 42 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 198 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt9.8 / 10Stronggated by 84 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

84 deducted task-comment markers across 95362 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×69wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:60
FixmeComment · ×15wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:501

What to do

  1. Resolve the 69 TodoComment finding(s) in Explicit Debt — start with TestDomainObject.java (10), TestObject.java (9), XslFoProfileWriter.java (7). — One of this dimension's main actionable groups (69 warning-level).
  2. Resolve the 15 FixmeComment finding(s) in Explicit Debt — start with EcoreGenerator.java (3), ToServiceGenerator.java, ToServiceGeneratorSolr.java. — One of this dimension's main actionable groups (15 warning-level).
  3. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion7.5 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.5 / 10 · rule-coverage 100% · ceiling Documented

3 of 24 build units (Maven) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.5 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Documented

29 % of calls cross a namespace and 10 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)1.9 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 1.9 / 10 · rule-coverage 100% · ceiling Documented

19 finding(s): 0 critical, 9 high, 8 medium, 2 low. 2 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 2 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (2 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.0 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

26 finding(s): 6 critical, 11 high, 7 medium, 2 low.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 11 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (11). — One of this dimension's main actionable groups (11 issue-level).
  2. Resolve the 7 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (7). — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 6 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (6). — One of this dimension's main actionable groups (6 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 2 platform declaration(s) and 56 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies7.6 / 10Strong✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

  • `DomainApiController` is a Spring singleton (the default scope) and is injected `WebclientQueryParamsBuilder<? extends DomainObject, String> webclientQueryParamsBuilder`, whose bean `WebclientQueryParamsBuilder` is scoped prototype without a scoped proxy (jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/WebclientQueryParamsBuilder.java:39). The singleton is given ONE instance, once, and keeps it for the life of the application context — the fresh instance per use that the prototype scope promises never happens, and any state it carries is shared by every caller on every thread. Inject `ObjectProvider<WebclientQueryParamsBuilder>` and call getObject() per use, or declare the scope with proxyMode = ScopedProxyMode.TARGET_CLASS. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/DomainApiController.java:80

What to do

  • Spring: don't inject prototype, request or session beans into a singleton directly — inject ObjectProvider<T> (or a Provider<T>, or an @Lookup method) and resolve per use, or declare the shorter scope with proxyMode = ScopedProxyMode.TARGET_CLASS so the singleton holds a proxy.
AX10 · Code composition9.5 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons6.2 / 10Adequate✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `ExportJsonItemFileWriterFactory` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `create` at line 52). — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/json/ExportJsonItemFileWriterFactory.java:28
  • `JsonFileItemWriter` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `write` at line 82). — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/json/JsonFileItemWriter.java:29
  • `ExportXmlItemFileWriterFactory` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `create` at line 54). — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/xml/ExportXmlItemFileWriterFactory.java:29
  • `ImportSequenceGroupContextSplitterAndAggregator` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (packageSize; e.g. `packageSize` in `setMaxGroupPackageSize` at line 296). — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:27
  • `InMemoryDataHolder` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (currentPosition, items; e.g. `currentPosition` in `read` at line 35). — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/InMemoryDataHolder.java:24
  • `XslFo2ExcelRenderer` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (listeners, rootArea, excel, excelColors, reader, textEncoding; e.g. `listeners` in `addListener` at line 70). — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/XslFo2ExcelRenderer.java:45
  • `XslFoTreeBuilder` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (rootArea; e.g. `rootArea` in `buildTree` at line 92). — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilder.java:60
  • `CmdDispatcher` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (xtendProjects, tasks; e.g. `xtendProjects` in `start` at line 48). — jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/dispatcher/CmdDispatcher.java:29
  • `CliProperties` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (location, pom, settings, trackedPoms; e.g. `location` in `setLocation` at line 139). — jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/CliProperties.java:27

What to do

  • Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `IArea` declares 23 abstract methods: `getAreaType`, `getBorderRange`, `getBorderRectangle`, `getChildrenList`, `getInheritedProperty`, `getInheritedPropertyValue`, `getParentArea`, `getProgressionDirection`, `getProperties`, `getProperty`, `getPropertyValue`, `isColumnLayoutSpan`, `isHasChildren`, `isNeedRendering`, `isSplitted`, `postProcessProperties`, `setBorderRectangle`, `setChildrenList`, `setColumnLayoutSpan`, `setParentArea`, `setProgressionDirection`, `setPropertyValue`, `setSplitted`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/IArea.java:16
  • `XfwClass` declares 21 abstract methods: `findAttribute`, `getChainingEStructuralFeature`, `getEAllAttributes`, `getEAllReferences`, `getEAllStructuralFeatures`, `getEAllSuperTypes`, `getEAttributes`, `getEReferences`, `getEStructuralFeature`, `getEStructuralFeatures`, `getESuperTypes`, `getFeatureCount`, `getFeaturesFlatMap`, `getKeyTypeName`, `getPersistenceModule`, `getPersistenceType`, `isAbstract`, `isComplexType`, `isPersistentType`, `isSuperTypeOf`, `isTransientType`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/XfwClass.java:9
  • `XFWMMPackage` declares 40 abstract methods: `getBlob`, `getDomainObject`, `getDuration`, `getDuration_Java7`, `getList`, `getLocalDate`, `getLocalDateTime`, `getLocalDateTime_Java7`, `getLocalDate_Java7`, `getLocalTime`, `getLocalTime_Java7`, `getMap`, `getModelFileExtension`, `getModelFileName`, `getModelFilePath`, `getModelFileUri`, `getModelFolderPath`, `getObjectFilter`, `getPeriod`, `getPeriod_Java7`, `getSet`, `getTimestamp`, `getTuple`, `getUUID`, `getXFWAttribute`, `getXFWAttribute_MaxLength`, `getXFWClass`, `getXFWClass_ComplexType`, `getXFWClass_KeyTypeName`, `getXFWClass_PersistenceModule`, `getXFWClass_PersistenceType`, `getXFWDataSource`, `getXFWDataSource_General`, `getXFWDataSource_RequestMapping`, `getXFWMMFactory`, `getXFWOperation`, `getXFWPackage`, `getXFWReference`, `getZonedDateTime`, `getZonedDateTime_Java7`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/XFWMMPackage.java:30
  • `DomainService<T, TK, Q>` declares 16 abstract methods under just 8 distinct name(s): `createNew`, `delete`, `deleteAll`, `getMaxObjects`, `getObjectById`, `getObjectById`, `getObjectById`, `getObjectById`, `getObjects`, `getObjects`, `getObjects`, `getObjects`, `save`, `save`, `validate`, `validate`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 8 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/domain/DomainService.java:22
  • `PersistenceModule` declares 18 abstract methods: `createComplexKey`, `createRepository`, `createRepositoryImpl`, `createService`, `doGenerateCode`, `doValidate`, `ecoreAddColumnProps`, `ecoreGetOpposite`, `extendClazz`, `extendMappedSuperclass`, `getEcoreModelEmitter`, `getFieldsList`, `getIdType`, `getKeyType`, `getKeyType`, `produceRequiredFields`, `registerClasses`, `validateBeforeTransform`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 18 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/PersistenceModule.java:28

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
  • Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

IC1 · Incompleteness & stubs7.3 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. (×5) — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:113, jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:123, jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:134, …
  • `not` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:68
  • `accept` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:74
  • `getType` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:79
  • `getDataAsMap` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/data/impl/DataProvider.java:217
  • `getStream` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:145
  • A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. (×3) — jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/load/events/EventsTest.java:26, jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/reporting/impl/XfwResourceLoaderTest.java:14, jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilderTest.java:18
  • `@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead. — jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/mvc/controllers/PageControllerBase.java:174

What to do

  • Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
  • Clear the softer debt: re-enable or delete @Disabled/@Ignore tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace @SuppressWarnings("all") with targeted, justified suppressions.
M1 · Documentation (README)4.7 / 10Weak✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

  • The root README is 38 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers. — README.md:1

What to do

  • Expand the README with getting-started, architecture overview and a project map.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 32 of 32 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`mvn test` for the toolchain this pipeline already uses) and gate merges on it.
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Consider OpenTelemetry tracing/metrics (opentelemetry-java or Micrometer) and a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) for operability.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1036 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X20 · Mistyped argument guard2.2 / 10Critical✓ Tool-verified

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

  • The guard on line 206 rejects `stringFrom` and line 207 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:207
  • The guard on line 236 rejects `stringFrom` and line 237 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:237
  • The guard on line 272 rejects `stringFrom` and line 273 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:273

What to do

  • Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: on the JVM `IllegalArgumentException` for a value that arrived empty (`Objects.requireNonNull(x)` for the null half, Kotlin's `require(x.isNotEmpty())` for the empty one), in Dart `ArgumentError.value(x, 'x', 'must not be empty')`, in F# `invalidArg (nameof x) "must not be empty"` (keeping `nullArg` for the null half). Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation7.8 / 10Strong✓ Tool-verified

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

  • `debug` at line 237 is called with an argument built by `classes.stream()` (line 238), whose cost grows with the collection it walks. Java evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isDebugEnabled`/`isTraceEnabled` test, no debug flag, no lambda or `Supplier` the logger calls only when the level is on. — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/EcoreProcessor.java:237

What to do

  • In Java, put the construction behind the logger's own check (`if (log.isDebugEnabled())` for SLF4J and Log4j, `if (logger.isLoggable(Level.FINE))` for java.util.logging), or hand the logger a lambda it calls only when the level is on (Log4j 2's `Supplier` overloads, SLF4J 2's `log.atDebug().addArgument(() -> …)`). A `{}` placeholder alone is not the fix: it defers the formatting, not the stream, join or serialisation in the argument.
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.6 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×4) — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1641, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:224, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:260, …

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging4.9 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `warn` at line 441 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:441
  • `debug` at line 742 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:742
  • `debug` at line 648 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:648
  • `debug` at line 683 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:683
  • `debug` at line 160 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/wc/TransferController.java:160
  • `debug` at line 87 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:87
  • `debug` at line 90 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:90
  • `debug` at line 196 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:196
  • `error` at line 177 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:177
  • `debug` at line 104 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultFileScanner.java:104
  • `debug` at line 119 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultFileScanner.java:119
  • `debug` at line 256 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultImportContextManager.java:256
  • `debug` at line 392 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:392
  • `debug` at line 43 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-security/src/main/java/ru/croc/ctp/jxfw/security/facade/Http401UnauthorizedEntryPoint.java:43
  • `debug` at line 76 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/style/StyleInliner.java:76
  • `debug` at line 81 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/style/StyleInliner.java:81
  • `debug` at line 511 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:511
  • `error` at line 1306 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1306
  • `debug` at line 100 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. (×2) — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:100, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/file/LocalResourceStore.java:100
  • `debug` at line 118 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:118
  • `error` at line 653 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:653
  • `error` at line 679 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:679
  • `error` at line 77 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:77
  • `error` at line 95 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:95
  • `debug` at line 186 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/HelpFuncs.java:186
  • `error` at line 220 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/HelpFuncs.java:220
  • `error` at line 114 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/Svg2Image.java:114
  • `error` at line 123 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/Svg2Image.java:123
  • `error` at line 211 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/Svg2Image.java:211
  • `debug` at line 331 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:331
  • `debug` at line 336 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:336
  • `debug` at line 138 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/impl/XFWModelImpl.java:138
  • `error` at line 67 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/ObjectValidator.java:67
  • `debug` at line 199 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — REDACTED:199
  • `debug` at line 243 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/DomainToServiceImpl.java:243
  • `debug` at line 95 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/file/FileApiController.java:95
  • `debug` at line 117 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/file/FileApiController.java:117
  • `debug` at line 67 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/XFWModelGenerator.java:67
  • `debug` at line 68 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text. — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/XFWModelGenerator.java:68

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 0/230 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.

What to do

  • Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health53%Adequate — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture82%StrongSolid.
Maturity49%Weak — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness49%Weak — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security55%Checked 4 of 10Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling100%ExemplaryStrongest area.
Unscored — 1 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 64 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included
  • D12 Dependency Hygiene — Not scored — 42 Maven/Gradle manifest(s) were read, stating a version for 16 dependency(ies) and leaving 198 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — single-contributor repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D19 Documentation Quality — D19 reads .NET projects and npm packages as units; 33 folder(s) declared by REDACTED were not judged for an overview, an example or the map.
  • D21 Naming Consistency — Naming consistency is measured on C# and TypeScript only; Java not measured.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only; comments in this repository's .java source were not judged.
  • D25 ADR Conformance — no ADRs to check
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
  • D34 Knowledge Freshness — too few commits to judge knowledge freshness
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
  • DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
  • DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
  • DM8 Value-object opportunities — not scored — the deterministic rule found 0 candidate clump(s); its rows are withheld until it has a measured precision of 95 % (a sample of fewer than 10 rows cannot show one)
  • ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (3 event handler(s))
  • ED5 Idempotency — Not assessed, and this one is on us: 3 command handler(s) or message consumer(s) were found here, but this check does not yet recognise persistence writes in this repository's language. Idempotency was neither confirmed nor ruled out — this is a limit of the analyzer, not a finding about your code.
  • ES1 Event Sourcing — not scored — this repository shows only 1 of the 3 signals this lens looks for (an Axon event-sourcing framework (@Aggregate/@CommandHandler/@EventSourcingHandler annotations))
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P7 Outbound HTTP resilience — no outbound HTTP usage detected — no HTTP client call or construction in the JVM source (service entry point: jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/mvc/controllers/BootloaderController.java:40 (@RestController))
  • P8 Schema migrations — Hibernate, Liquibase, jOOQ is declared, but the schema-migration mechanism could not be identified. Our limit, not a verdict on this repository.
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a REDACTED, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X12 Unreachable branch — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X13 Undrained process stream — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X17 Uncapped recursion over a caller-supplied document — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X2 Cancellation propagation — no C# was loaded; this repository's Java was read, and no request in it can be cancelled by a caller — a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 27 finding(s)
D30 · Dependency Vulnerabilities · High CVE · ×11
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
AX1 · Captive dependencies · Captive dependency · ×1
  • Captive dependency: singleton DomainApiController captures prototype WebclientQueryParamsBuilder jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/DomainApiController.java:80 — `DomainApiController` is a Spring singleton (the default scope) and is injected `WebclientQueryParamsBuilder<? extends DomainObject, String> webclientQueryParamsBuilder`, whose bean `WebclientQueryParamsBuilder` is scoped prototype without a scoped proxy (jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/WebclientQueryParamsBuilder.java:39). The singleton is given ONE instance, once, and keeps it for the life of the application context — the fresh instance per use that the prototype scope promises never happens, and any state it carries is shared by every caller on every thread. Inject `ObjectProvider<WebclientQueryParamsBuilder>` and call getObject() per use, or declare the scope with proxyMode = ScopedProxyMode.TARGET_CLASS.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 519 finding(s)
D17 · Explicit Debt · TodoComment · ×69
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:60 — //TODO Убрать копипаст из EcoreGenerator — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:142 — //TODO разобраться с названием — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:448 — //TODO JXFW-1177
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:688 — //TODO JXFW-1177
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:697 — //TODO JXFW-1177
  • TodoComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:657 — //TODO разобраться в назначении — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/solr/SchemaMetadata.java:19 — //TODO типы — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/solr/SchemaMetadata.java:20 — //TODO маппинги — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/config/ConfigSettings.java:78 — // TODO Получать версию билда — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/config/XFilesModuleConfig.java:67 — //TODO вычисление дефолтного значения в рантайм — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:223 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:27 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:48 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:53 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:59 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:65 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:71 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:77 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:83 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/services/TestObject.java:90 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/domain/TestDomainObject.java:17 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/domain/TestDomainObject.java:23 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/domain/TestDomainObject.java:29 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/domain/TestDomainObject.java:35 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/domain/TestDomainObject.java:40 — // TODO Auto-generated method stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 44 more in this group — see findings.md.
D10 · Test Quality · No assertions · ×15
  • No assertions: testOp2 jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposerTest.java:52 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testGetEnumValueFail jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/util/TestCmfEnumUtil.java:75 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testValueOfInvalidValue jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/util/TestCmfEnumUtil.java:63 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: beforeStoreFailTest jxfw-jpa-runtime/src/test/java/ru/croc/ctp/jxfw/jpa/store/impl/UnitOfWorkJpaStoreServiceImplTest.java:31 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: validateReportProfile jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/XslfoReportProfileTest.java:28 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: validateReportProfileAlien jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/XslfoReportProfileTest.java:11 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: throwExceptionIfAggregateFunctionIsUnknown jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutTableTest.java:11 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: addSomeInfoToXmlTextReader jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/XmlTextReaderTest.java:27 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: createXmlTextReader jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/XmlTextReaderTest.java:19 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: rowHeightStrategyDefaultIsUsed jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/XslFo2ExcelRendererTest.java:37 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testFewNotResolveDependencies jxfw-transfer/src/test/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportDependencyManagerTest.java:54 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testFewNotResolveDependenciesWithNotLoadedDto jxfw-transfer/src/test/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportDependencyManagerTest.java:72 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: checkEcorePriorityEclipseCaseExpectException modelgen-maven-plugin/src/test/java/ru/croc/ctp/jxfw/mojo/modelgen/AggregateTest.java:219 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: checkEcorePriorityExpectException modelgen-maven-plugin/src/test/java/ru/croc/ctp/jxfw/mojo/modelgen/AggregateTest.java:174 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testCheckFileAutogenerated wcgen-maven-plugin/src/test/java/ru/croc/ctp/jxfw/mojo/EcoreProcessorTest.java:16 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
D17 · Explicit Debt · FixmeComment · ×15
  • FixmeComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:501 — // FIXME: захардкожено — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:127 — //FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/XFWConstants.java:158 — //FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:82 — //FIXME: идентификатор не должен определяться по наименованию поля — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:77 — //FIXME: идентификатор не должен определяться по наименованию поля — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:472 — //FIXME: predicateByID — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:205 — //FIXME: predicateByID — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-export-poi/src/main/java/ru/croc/ctp/jxfw/export/poi/impl/views/ExcelView.java:133 — // FIXME как лучше определить ширину страницы? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/load/events/EventsTest.java:26 — // FIXME JXFW-1223
  • FixmeComment jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/store/StoreResult.java:88 — // FIXME JXFW-1223 сюда должен пойти контекст сохранения => контексты должны иметь общую иерархию
  • FixmeComment jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/WebclientQueryParamsBuilder.java:157 — // FIXME JXFW-1215 что тут будет с комплексными ключами в CASS и SOLR?
  • FixmeComment jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:149 — // FIXME JXFW-1206
  • FixmeComment jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:314 — //FIXME XfwValueType.UNDEFINED добавлен в JXFW-953, где затрагиваются только комплексные типы
  • FixmeComment jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:780 — // fixme — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:837 — // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×15
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:153 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:153-163 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:239-246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:153` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:426 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:426-433 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java:371-378 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:426` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/logging/AreaLogHelper.java:99 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/logging/AreaLogHelper.java:99-106 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/logging/AreaLogHelper.java:130-137 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java:171 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java:171-178 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java:198-205 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java:171` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:374 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:374-381 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:627-634 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:374` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `CharacterArea` in one and `InlineArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:909 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:909-916 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:979-986 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:909` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1065 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1065-1072 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1153-1160 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1065` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/GenerateCqlScriptsMojo.java:118 — scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/GenerateCqlScriptsMojo.java:118-125 | scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/GenerateSolrSchemaMojo.java:113-120 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:818 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:818-825 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:886-893 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:895 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:895-902 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:975-982 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1081 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1081-1088 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1169-1176 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:164 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:164-171 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:176-183 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java:97 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java:97-104 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/FacadeGenerator.java:182-189 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java:111 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java:111-118 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/FacadeGenerator.java:173-180 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:960 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:960-968 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/TransientXfwObjectToGenerator.java:79-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `Builder` in one and `MethodSpec.Builder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D3 · God Classes · TooManyMethods · ×12
  • TooManyMethods: ToServiceGenerator wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:93 — TooManyMethods — 83 methods. The bar is 30 methods; this is 53 over it, 2.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TransferToServiceGenerator jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:85 — TooManyMethods — 72 methods. The bar is 30 methods; this is 42 over it, 2.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LoggerOverReflection jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/xtend/logging/impl/LoggerOverReflection.java:11 — TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: XslFoProfileWriter jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:36 — TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: XslfoTable jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:24 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: XMMEditor jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:168 — TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LayoutColumn jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:55 — TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GenericArea jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:27 — TooManyMethods — 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: JsModelGenerator wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:56 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: WordRenderer jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:115 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ObservableList jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/domain/impl/ObservableList.java:22 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: XfwClassImpl jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwClassImpl.java:27 — TooManyMethods — 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · ClassTooLong · ×11
  • ClassTooLong: ToServiceGenerator wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:93 — ClassTooLong — 1198 significant lines (blank, comment-only and punctuation-only lines excluded), 83 methods. The bar is 400 significant lines; this is 798 over it, 3.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: WordRenderer jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:115 — ClassTooLong — 1014 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 614 over it, 2.54× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: TransferToServiceGenerator jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:85 — ClassTooLong — 897 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. The bar is 400 significant lines; this is 497 over it, 2.24× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: XMMEditor jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:168 — ClassTooLong — 699 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 400 significant lines; this is 299 over it, 1.75× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: AreaTreeBuilder jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:101 — ClassTooLong — 660 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 260 over it, 1.65× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: EcoreGenerator jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:74 — ClassTooLong — 535 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. The bar is 400 significant lines; this is 135 over it, 1.34× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: GenericLayoutManager jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:34 — ClassTooLong — 501 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 101 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: XslFoProfileWriter jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:36 — ClassTooLong — 492 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 400 significant lines; this is 92 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: WebClientControllerCreator wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:87 — ClassTooLong — 469 significant lines (blank, comment-only and punctuation-only lines excluded), 18 methods. The bar is 400 significant lines; this is 69 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: AttributeParser jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:89 — ClassTooLong — 428 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 28 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ToServiceGeneratorSolr wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:67 — ClassTooLong — 412 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 12 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · FileTooLong · ×11
  • FileTooLong: layouts/TableLayout.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java — FileTooLong — 1280 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 780 over it, 2.56× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: facade/ToServiceGenerator.java wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java — FileTooLong — 1278 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: ToServiceGenerator (93-2116). The bar is 500 significant lines; this is 778 over it, 2.56× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: rendering/WordRenderer.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java — FileTooLong — 1120 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: WordRenderer (115-2026). The bar is 500 significant lines; this is 620 over it, 2.24× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: transfer/TransferToServiceGenerator.java jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java — FileTooLong — 970 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: TransferToServiceGenerator (85-1716). The bar is 500 significant lines; this is 470 over it, 1.94× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: presentation/XMMEditor.java jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java — FileTooLong — 814 significant lines (blank, comment-only and punctuation-only lines excluded), about 86% of them inside a single declaration: XMMEditor (168-1818). The bar is 500 significant lines; this is 314 over it, 1.63× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: tree/AreaTreeBuilder.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java — FileTooLong — 752 significant lines (blank, comment-only and punctuation-only lines excluded), about 88% of them inside a single declaration: AreaTreeBuilder (101-1390). The bar is 500 significant lines; this is 252 over it, 1.50× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: generator/EcoreGenerator.java jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java — FileTooLong — 598 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: EcoreGenerator (74-961). The bar is 500 significant lines; this is 98 over it, 1.20× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: facade/WebClientControllerCreator.java wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java — FileTooLong — 545 significant lines (blank, comment-only and punctuation-only lines excluded), about 86% of them inside a single declaration: WebClientControllerCreator (87-682). The bar is 500 significant lines; this is 45 over it, 1.09× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: layoutmanager/GenericLayoutManager.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java — FileTooLong — 526 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: GenericLayoutManager (34-1095). The bar is 500 significant lines; this is 26 over it, 1.05× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: fowriter/XslFoProfileWriter.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java — FileTooLong — 518 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: XslFoProfileWriter (36-1271). The bar is 500 significant lines; this is 18 over it, 1.04× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: attribute/AttributeParser.java jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java — FileTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), about 84% of them inside a single declaration: AttributeParser (89-798). The bar is 500 significant lines; this is 8 over it, 1.02× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D3 · God Classes · MethodTooLong · ×11
  • MethodTooLong: AttributeParser.processProperties jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:334 — MethodTooLong — processProperties runs 241 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 141 over it, 2.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WebClientControllerCreator.create wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:135 — MethodTooLong — create runs 181 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 81 over it, 1.81× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BlockProperties.addBlock jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:59 — MethodTooLong — addBlock runs 177 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 77 over it, 1.77× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AttributeParser.processProperty jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:308 — MethodTooLong — processProperty runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: XMMEditor.createPages jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1012 — MethodTooLong — createPages runs 153 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 53 over it, 1.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AreaTreeBuilder.parseChildrenElement jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:189 — MethodTooLong — parseChildrenElement runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WebClientDataSourceCreator.create wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:96 — MethodTooLong — create runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TransferToServiceGenerator.createToToFieldBlockCode jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:651 — MethodTooLong — createToToFieldBlockCode runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ToServiceGenerator.populateNavigables wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1314 — MethodTooLong — populateNavigables runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ToServiceGenerator.createToToFieldBlockCode wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:710 — MethodTooLong — createToToFieldBlockCode runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WordRenderer.completeListItem jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:859 — MethodTooLong — completeListItem runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×11
  • Duplicated block (6 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:177 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:177-182 | jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwModelImpl.java:190-195 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwModelImpl.java:186` calls `resolveMetadata` and `jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:174` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:168 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:168-173 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:211-216 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:168` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `StringUtils` names `org.apache.commons.lang.StringUtils` in one and `org.apache.commons.lang3.StringUtils` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:748 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:748-753 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:758-763 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:242 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:242-247 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:252-257 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:630 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:630-635 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:689-694 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1309 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1309-1314 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1596-1601 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:413 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:413-418 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:276-281 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:420` calls `autowireServiceBySetter`, `autowireFieldsBySetters` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:282` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/store/impl/UnitOfWorkMultiStoreServiceImpl.java:65 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/store/impl/UnitOfWorkMultiStoreServiceImpl.java:65-70 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/store/impl/UnitOfWorkSingleStoreServiceImpl.java:37-43 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1573 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1573-1578 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1859-1864 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:309 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:309-315 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java:251-256 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:143 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:143-148 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:154-159 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:143` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×10
  • Duplicated block (7 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2144 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2144-2150 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2384-2390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2144` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:951 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:951-957 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:960-966 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:951` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:923 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:923-929 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1019-1025 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:923` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1317 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1317-1323 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1604-1610 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:469 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:469-475 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:485-491 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:241 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:241-247 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:244-250 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:237` calls `builder`, `addMember`, `build` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1350 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1350-1356 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1637-1643 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:155 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:155-161 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:167-173 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:40 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:40-46 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java:42-48 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:43 — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:43-49 | jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/predicate/SolrQueryContext.java:44-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:43` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D6 · Cohesion (LCOM4) · Low cohesion · ×10
  • Low cohesion: JsModelGenerator (LCOM4 8) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:56 — JsModelGenerator's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ColumnBuilder (LCOM4 8) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/ColumnBuilder.java:13 — ColumnBuilder's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Builder (LCOM4 8) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/exceptions/DomainViolation.java:109 — Builder's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: StoreContextBuilder (LCOM4 7) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/store/StoreContext.java:277 — StoreContextBuilder's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PackageModel (LCOM4 6) modelgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/modelgen/ModelGenerator.java:126 — PackageModel's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: WebClientLoaderConfig (LCOM4 5) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/WebClientLoaderConfig.java:32 — WebClientLoaderConfig's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: RowCellBuilder (LCOM4 5) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/RowCellBuilder.java:8 — RowCellBuilder's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ToServiceGenerator (LCOM4 4) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:93 — ToServiceGenerator's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DomainToServiceImpl (LCOM4 4) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/DomainToServiceImpl.java:38 — DomainToServiceImpl's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Builder (LCOM4 4) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/load/GeneralLoadContext.java:88 — Builder's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
IC1 · Incompleteness & stubs · Unfinished stub · ×10
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:113 — `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:123 — `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:134 — `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:145 — `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:157 — `toStatement` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:68 — `not` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:74 — `accept` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/predicate/CassandraQueryContext.java:79 — `getType` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/data/impl/DataProvider.java:217 — `getDataAsMap` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
  • Unfinished stub — throws a "not implemented" exception jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:145 — `getStream` throws an exception whose message says it isn't finished — a not-implemented stub wearing an ordinary exception. Implement it or remove it.
AX2 · Stateful singletons · Stateful singleton · ×9
  • Stateful singleton: ExportJsonItemFileWriterFactory jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/json/ExportJsonItemFileWriterFactory.java:28 — `ExportJsonItemFileWriterFactory` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `create` at line 52).
  • Stateful singleton: JsonFileItemWriter jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/json/JsonFileItemWriter.java:29 — `JsonFileItemWriter` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `write` at line 82).
  • Stateful singleton: ExportXmlItemFileWriterFactory jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/exp/xml/ExportXmlItemFileWriterFactory.java:29 — `ExportXmlItemFileWriterFactory` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (count; e.g. `count` in `create` at line 54).
  • Stateful singleton: ImportSequenceGroupContextSplitterAndAggregator jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:27 — `ImportSequenceGroupContextSplitterAndAggregator` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (packageSize; e.g. `packageSize` in `setMaxGroupPackageSize` at line 296).
  • Stateful singleton: InMemoryDataHolder jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/InMemoryDataHolder.java:24 — `InMemoryDataHolder` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (currentPosition, items; e.g. `currentPosition` in `read` at line 35).
  • Stateful singleton: XslFo2ExcelRenderer jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/XslFo2ExcelRenderer.java:45 — `XslFo2ExcelRenderer` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (listeners, rootArea, excel, excelColors, reader, textEncoding; e.g. `listeners` in `addListener` at line 70).
  • Stateful singleton: XslFoTreeBuilder jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilder.java:60 — `XslFoTreeBuilder` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (rootArea; e.g. `rootArea` in `buildTree` at line 92).
  • Stateful singleton: CmdDispatcher jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/dispatcher/CmdDispatcher.java:29 — `CmdDispatcher` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (xtendProjects, tasks; e.g. `xtendProjects` in `start` at line 48).
  • Stateful singleton: CliProperties jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/CliProperties.java:27 — `CliProperties` is a singleton (@Component: the container shares one instance across every request thread) but mutates instance state outside any lock (location, pom, settings, trackedPoms; e.g. `location` in `setLocation` at line 139).
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×8
  • Duplicated block (16 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:40 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:40-55 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/XExceptionToSerializer.java:38-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `to` to `ExceptionTo` in one and `XExceptionTo` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:38` calls `writeObjectField`, `getParentClasses` and `jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/XExceptionToSerializer.java:36` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (16 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:150 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:150-165 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java:119-135 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:150` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:435 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:435-450 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java:380-395 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:435` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1208 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1208-1223 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1263-1278 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1208` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:348 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:348-363 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:350-365 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:369 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:369-384 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:371-386 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:390 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:390-405 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:392-407 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:33 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:33-48 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:47-62 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 80 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:33` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×8
  • Duplicated block (15 lines × 2) jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1023 — jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1023-1037 | jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1057-1071 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/formatters/HrefEvaluator.java:73 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/formatters/HrefEvaluator.java:73-87 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/formatters/ImageEvaluator.java:64-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/formatters/HrefEvaluator.java:88` calls `escapeHtml4`, `getCurrentValue`, `toString` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/formatters/ImageEvaluator.java:79` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1050 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1050-1064 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1115-1129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1050` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1175 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1175-1189 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1203-1217 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `PageNumberArea` in one and `PageNumberCitationArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (15 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:278 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:278-292 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:281-295 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:278` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:297` calls `addMethod`, `createEqualsObjectMethod`, `build` and `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:294` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:595 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:595-609 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:653-667 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:595` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:592` calls `addStatement` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:652` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:613 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:613-627 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:671-685 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:613` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemBodyArea.java:41 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemBodyArea.java:41-55 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemLabelArea.java:41-55 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemBodyArea.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemLabelArea.java` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×8
  • Duplicated block (5 lines × 2) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/ExceptionBuilderImpl.java:89 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/ExceptionBuilderImpl.java:89-94 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/ExceptionBuilderImpl.java:118-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/ExceptionBuilderImpl.java:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:908 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:908-912 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:917-921 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:978 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:978-982 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:987-991 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:67 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:67-71 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java:98-102 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:179 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:179-183 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:628-639 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:179` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1562 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1562-1566 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1848-1852 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/AreaType.java:214 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/AreaType.java:214-218 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/FoPropertyType.java:569-573 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:83 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:83-87 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:108-112 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 80 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D30 · Dependency Vulnerabilities · Medium CVE · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×6
  • Duplicated block (11 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportController.java:60 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportController.java:60-70 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportControllerNew.java:61-71 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportController.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportControllerNew.java` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/facade/webclient/ReportController.java:60` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/CommonTable.java:118 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/CommonTable.java:118-128 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:129-139 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (11 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:490 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:490-500 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:497-507 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:490` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:496` calls `addAnnotation` and `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:489` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:868 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:868-878 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:935-945 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:868` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (11 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1597 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1597-1607 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1883-1893 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) REDACTED:160 — REDACTED:160-170 | REDACTED:220-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `ExecuteImportRequest` in one and `ExecuteExportRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×6
  • Duplicated block (10 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:102 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:102-111 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:169-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:102` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:306 — jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:306-315 | jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:334-343 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:306` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1398 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1398-1407 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1684-1693 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1398` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:54 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:54-63 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:79-88 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 80 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:54` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:175 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:175-184 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:574-583 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:573` calls `equals` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:173` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:477 — jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:477-486 | jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/impl/SolrLoadServiceImpl.java:65-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×5
  • Duplicated block (20 lines × 2) jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1104 — jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1104-1123 | jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1174-1193 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:1104` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (20 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:412 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:412-431 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:420-439 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:410` calls `setFields` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:418` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (20 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:561 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:561-580 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:641-660 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:561` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/H2BitwiseAndSqlFunction.java:21 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/H2BitwiseAndSqlFunction.java:21-40 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/OracleBitwiseAndSqlFunction.java:21-40 — before extracting anything, compare `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/H2BitwiseAndSqlFunction.java` and `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/OracleBitwiseAndSqlFunction.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (20 lines × 2) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/MySqlBitwiseAndSqlFunction.java:21 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/MySqlBitwiseAndSqlFunction.java:21-40 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/PostgreSqlBitwiseAndSqlFunction.java:21-40 — before extracting anything, compare `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/MySqlBitwiseAndSqlFunction.java` and `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/impl/sql/PostgreSqlBitwiseAndSqlFunction.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×5
  • Duplicated block (14 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1191 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1191-1204 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1246-1259 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1191` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:134 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:134-147 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:159-172 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 80 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/load/events/CassBeforeLoadEvent.java:29 — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/load/events/CassBeforeLoadEvent.java:29-42 | jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/load/events/CassPreCheckSecurityEvent.java:29-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/events/SolrBeforeLoadEvent.java:29 — jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/events/SolrBeforeLoadEvent.java:29-42 | jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/events/SolrPreCheckSecurityEvent.java:28-41 — before extracting anything, compare `jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/events/SolrBeforeLoadEvent.java` and `jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/load/events/SolrPreCheckSecurityEvent.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:349 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:349-362 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:929-942 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `layoutProfile` to `MasterDetailLayoutClass` in one and `TableLayoutClass` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×5
  • Duplicated block (13 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2333 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2333-2345 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2374-2386 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (13 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:577 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:577-589 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1529-1541 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:577` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `FlowArea` in one and `StaticContentArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1065 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1065-1077 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1141-1153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1065` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `ListItemBodyArea` in one and `ListItemLabelArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1648 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1648-1660 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1930-1942 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:536 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:536-548 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:638-650 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:536` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:535` calls `addParameter`, `createExpandParameter` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:637` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×4
  • Members sharing a duplicated core (4 members, 50+ identical tokens) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:469 — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:469-485 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:487-503 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:505-521 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:523-539 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:139 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:139-156 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:166-188 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:197-216 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:226-247 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwH2Dialect.java:58 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwH2Dialect.java:58-73 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwMySqlDialect.java:55-70 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwOracle10gDialect.java:55-70 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwPostgreSql9Dialect.java:55-70 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:364 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:364-385 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:619-638 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1173-1189 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1201-1217 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×4
  • Duplicated block (18 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxExclusiveValidator.java:29 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxExclusiveValidator.java:29-46 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MaxExclusiveValidator.java:29-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `LocalDate` names `java.time.LocalDate` in one and `org.threeten.bp.LocalDate` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinExclusiveValidator.java:29 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinExclusiveValidator.java:29-46 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MinExclusiveValidator.java:29-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `LocalDate` names `java.time.LocalDate` in one and `org.threeten.bp.LocalDate` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java:29 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java:29-46 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MinInclusiveValidator.java:29-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `LocalDate` names `java.time.LocalDate` in one and `org.threeten.bp.LocalDate` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1444 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1444-1461 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1730-1747 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×4
  • Duplicated block (17 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java:29 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java:29-45 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MaxInclusiveValidator.java:29-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `LocalDate` names `java.time.LocalDate` in one and `org.threeten.bp.LocalDate` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:138 — jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:138-154 | jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:199-215 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:138` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1037 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1037-1053 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1119-1135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1037` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `ListItemBodyArea` in one and `ListItemLabelArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) REDACTED:184 — REDACTED:184-200 | REDACTED:233-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:184` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×4
  • Duplicated block (9 lines × 2) jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwEnumerationImpl.java:129 — jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwEnumerationImpl.java:129-137 | jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwEnumerationImpl.java:195-203 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/impl/XfwEnumerationImpl.java:129` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:825 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:825-833 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1681-1689 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:825` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `tableNode` to `Table` in one and `XslfoTable` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (9 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1581 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1581-1589 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1867-1875 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:57 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/ExceptionToSerializer.java:57-65 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/exception/dto/XExceptionToSerializer.java:55-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×4
  • Swallowed exception (caught, then discarded) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1641 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:224 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:260 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:295 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×3
  • Duplicated block (30 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2456 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2456-2485 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2538-2567 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2456` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (30 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:746 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:746-775 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:799-828 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:746` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (30 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1253 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1253-1282 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1539-1568 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1253` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×3
  • Duplicated block (12 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:847 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:847-858 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:916-927 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:938 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:938-949 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1034-1045 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:938` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/load/events/JpaBeforeLoadEvent.java:29 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/load/events/JpaBeforeLoadEvent.java:29-40 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/load/events/JpaPreCheckSecurityEvent.java:29-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×3
  • Duplicated block (7 lines × 3) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceClassEcoreGenerator.java:54 — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceClassEcoreGenerator.java:54-60 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceEcoreGenerator.java:64-70 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/EnumEcoreGenerator.java:38-44 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceClassEcoreGenerator.java:54` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/DomainFacadeIgnoreServiceImpl.java:128 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/impl/DomainFacadeIgnoreServiceImpl.java:128-134 | jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1063-1069 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1151-1157 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `facadeIgnoreAnnotation` to `XfwAnnotation` in one and `EAnnotation` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 3) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1078 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1078-1084 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1154-1160 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1435-1441 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1078` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `ListItemBodyArea` in one and `ListItemLabelArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×3
  • Duplicated block (6 lines × 4) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:474 — jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:474-479 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:492-497 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:510-515 | jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:528-533 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:474` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 4) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:141 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:141-146 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:168-174 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:199-204 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:228-234 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:175` calls `group` and `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:148` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 4) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:366 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:366-371 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:380-385 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:636-641 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:652-657 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:366` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:643` calls `getRowFormat`, `getBorders`, `setLineStyle` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:373` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X20 · Mistyped argument guard · Argument guard throws the exception its own condition disproves · ×3
  • Argument guard throws the exception its own condition disproves jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:207 — The guard on line 206 rejects `stringFrom` and line 207 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:237 — The guard on line 236 rejects `stringFrom` and line 237 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/util/Converter.java:273 — The guard on line 272 rejects `stringFrom` and line 273 reports that rejection as `NullPointerException` — but the condition's own test `stringFrom.length() == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `stringFrom`, and on that path `stringFrom` was already proven non-null by the very expression that decided it. So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `NullPointerException` to handle a real null handles the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. Throw `IllegalArgumentException` for the empty case, or split the guard and throw each on its own condition.
D2 · Cognitive Complexity · AttributeParser.processBorderAttribute (cognitive 24) · ×2
  • AttributeParser.processBorderAttribute (cognitive 24) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:166 — AttributeParser.processBorderAttribute has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (17 pts), ternaries 4 (5 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • AttributeParser.processBorderAttribute (cognitive 24) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:210 — AttributeParser.processBorderAttribute has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (17 pts), ternaries 4 (5 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×2
  • Duplicated block (27 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:209 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:209-235 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:215-241 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:237` calls `builder`, `addMember`, `build` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:242` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (27 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:74 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:74-100 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java:105-131 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/SimpleImportContextSplitterAndAggregator.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:74` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:918 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:918-936 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:988-1006 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:918` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:552 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:552-570 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:561-579 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:552` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (11–16 lines × 2) · ×2
  • Duplicated block (11–16 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:608 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:608-618 | jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:928-943 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:608` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11–16 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:666 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:666-676 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1024-1039 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:666` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×2
  • Duplicated block (9–10 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:91 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:91-99 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:157-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9–10 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:530 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:530-539 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:552-560 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:530` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:145 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:145-152 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:174-181 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:233-240 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (8 lines × 3) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:140 — jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:140-147 | jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:201-208 | jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:261-268 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:140` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D1 · Cyclomatic Complexity · AttributeParser.processProperties (cyclomatic 109) · ×1
  • AttributeParser.processProperties (cyclomatic 109) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:334 — AttributeParser.processProperties has cyclomatic complexity 109 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · TableLayout.writeTotalRow (cyclomatic 77) · ×1
  • TableLayout.writeTotalRow (cyclomatic 77) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2225 — TableLayout.writeTotalRow has cyclomatic complexity 77 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AttributeParser.processProperty (cyclomatic 77) · ×1
  • AttributeParser.processProperty (cyclomatic 77) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:308 — AttributeParser.processProperty has cyclomatic complexity 77 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · XslFoTreeBuilder.parseChildrenElement (cyclomatic 67) · ×1
  • XslFoTreeBuilder.parseChildrenElement (cyclomatic 67) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilder.java:116 — XslFoTreeBuilder.parseChildrenElement has cyclomatic complexity 67 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · XslfoTable.setHeaderBodyFooterBordersProperties (cyclomatic 65) · ×1
  • XslfoTable.setHeaderBodyFooterBordersProperties (cyclomatic 65) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:460 — XslfoTable.setHeaderBodyFooterBordersProperties has cyclomatic complexity 65 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · TableLayout.writeGroupBound (cyclomatic 57) · ×1
  • TableLayout.writeGroupBound (cyclomatic 57) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1713 — TableLayout.writeGroupBound has cyclomatic complexity 57 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BlockProperties.addBlock (cyclomatic 54) · ×1
  • BlockProperties.addBlock (cyclomatic 54) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:59 — BlockProperties.addBlock has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JsModelGenerator.getTypeName (cyclomatic 38) · ×1
  • JsModelGenerator.getTypeName (cyclomatic 38) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:238 — JsModelGenerator.getTypeName has cyclomatic complexity 38 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AbstractEcoreGenerator.getEType (cyclomatic 37) · ×1
  • AbstractEcoreGenerator.getEType (cyclomatic 37) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/AbstractEcoreGenerator.java:143 — AbstractEcoreGenerator.getEType has cyclomatic complexity 37 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · GenericArea.preProcessProperties (cyclomatic 33) · ×1
  • GenericArea.preProcessProperties (cyclomatic 33) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:441 — GenericArea.preProcessProperties has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReportParameterConverter.parse (cyclomatic 33) · ×1
  • ReportParameterConverter.parse (cyclomatic 33) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/ReportParameterConverter.java:177 — ReportParameterConverter.parse has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AreaTreeBuilder.parseChildrenElement (cyclomatic 32) · ×1
  • AreaTreeBuilder.parseChildrenElement (cyclomatic 32) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:189 — AreaTreeBuilder.parseChildrenElement has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · WordRenderer.completeListItem (cyclomatic 32) · ×1
  • WordRenderer.completeListItem (cyclomatic 32) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:859 — WordRenderer.completeListItem has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WordRenderer.treeRenderer (cyclomatic 30) · ×1
  • WordRenderer.treeRenderer (cyclomatic 30) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:183 — WordRenderer.treeRenderer has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · GenericLayoutManager.calculateAreaSize (cyclomatic 29) · ×1
  • GenericLayoutManager.calculateAreaSize (cyclomatic 29) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:123 — GenericLayoutManager.calculateAreaSize has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ToServiceGenerator.createPropertyValueByType (cyclomatic 27) · ×1
  • ToServiceGenerator.createPropertyValueByType (cyclomatic 27) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1473 — ToServiceGenerator.createPropertyValueByType has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · TransferToServiceGenerator.createPropertyValueByType (cyclomatic 27) · ×1
  • TransferToServiceGenerator.createPropertyValueByType (cyclomatic 27) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1187 — TransferToServiceGenerator.createPropertyValueByType has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ListItemArea.postProcessProperties (cyclomatic 27) · ×1
  • ListItemArea.postProcessProperties (cyclomatic 27) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:43 — ListItemArea.postProcessProperties has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PredicateComposer.getOperator (cyclomatic 26) · ×1
  • PredicateComposer.getOperator (cyclomatic 26) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposer.java:307 — PredicateComposer.getOperator has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ExcelRenderer.renderAreaToCells (cyclomatic 25) · ×1
  • ExcelRenderer.renderAreaToCells (cyclomatic 25) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:233 — ExcelRenderer.renderAreaToCells has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PredicateComposer.createPredicate (cyclomatic 24) · ×1
  • PredicateComposer.createPredicate (cyclomatic 24) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposer.java:103 — PredicateComposer.createPredicate has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EcoreGenerator.addRelationAnnotation (cyclomatic 24) · ×1
  • EcoreGenerator.addRelationAnnotation (cyclomatic 24) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:822 — EcoreGenerator.addRelationAnnotation has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TableLayout.writeSubTitleRow (cyclomatic 23) · ×1
  • TableLayout.writeSubTitleRow (cyclomatic 23) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2076 — TableLayout.writeSubTitleRow has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WordRenderer.addTableCell (cyclomatic 23) · ×1
  • WordRenderer.addTableCell (cyclomatic 23) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1776 — WordRenderer.addTableCell has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · XfwMetadataHolder.init (cyclomatic 22) · ×1
  • XfwMetadataHolder.init (cyclomatic 22) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/metadata/XfwMetadataHolder.java:89 — XfwMetadataHolder.init has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FoFont.setFontSize (cyclomatic 21) · ×1
  • FoFont.setFontSize (cyclomatic 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:184 — FoFont.setFontSize has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AreaTreeBuilder.processStaticContentArea (cyclomatic 21) · ×1
  • AreaTreeBuilder.processStaticContentArea (cyclomatic 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:518 — AreaTreeBuilder.processStaticContentArea has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BlockProperties.completeBlock (cyclomatic 21) · ×1
  • BlockProperties.completeBlock (cyclomatic 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:323 — BlockProperties.completeBlock has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LayoutTable.getAggregatedValue (cyclomatic 20) · ×1
  • LayoutTable.getAggregatedValue (cyclomatic 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutTable.java:119 — LayoutTable.getAggregatedValue has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TableLayout.writeRows (cyclomatic 20) · ×1
  • TableLayout.writeRows (cyclomatic 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1302 — TableLayout.writeRows has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ListItemArea.calculateMargins (cyclomatic 20) · ×1
  • ListItemArea.calculateMargins (cyclomatic 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/pagesequence/listblock/ListItemArea.java:110 — ListItemArea.calculateMargins has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TableProperties.setSpannedForCell (cyclomatic 20) · ×1
  • TableProperties.setSpannedForCell (cyclomatic 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/TableProperties.java:144 — TableProperties.setSpannedForCell has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WordRenderer.addCatchWord (cyclomatic 20) · ×1
  • WordRenderer.addCatchWord (cyclomatic 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1323 — WordRenderer.addCatchWord has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AttributeParser.processShorthandProperties (cyclomatic 19) · ×1
  • AttributeParser.processShorthandProperties (cyclomatic 19) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:272 — AttributeParser.processShorthandProperties has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · TransferPropertyResolverImpl.addTypedValue (cyclomatic 18) · ×1
  • TransferPropertyResolverImpl.addTypedValue (cyclomatic 18) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferPropertyResolverImpl.java:24 — TransferPropertyResolverImpl.addTypedValue has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · XslFoProfileWriter.writeLayoutMaster (cyclomatic 18) · ×1
  • XslFoProfileWriter.writeLayoutMaster (cyclomatic 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:380 — XslFoProfileWriter.writeLayoutMaster has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GenericArea.moveChildMarginsToParentPaddings (cyclomatic 18) · ×1
  • GenericArea.moveChildMarginsToParentPaddings (cyclomatic 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:752 — GenericArea.moveChildMarginsToParentPaddings has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: GenericArea.getDefaultPropertyValue (cyclomatic 27) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · DataSourceEcoreGenerator.setupParametersOfDataSource (cyclomatic 18) · ×1
  • DataSourceEcoreGenerator.setupParametersOfDataSource (cyclomatic 18) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceEcoreGenerator.java:124 — DataSourceEcoreGenerator.setupParametersOfDataSource has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · XslFoProfileWriter.setRegionAttributes (cyclomatic 17) · ×1
  • XslFoProfileWriter.setRegionAttributes (cyclomatic 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:1168 — XslFoProfileWriter.setRegionAttributes has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReportParam.setValue (cyclomatic 17) · ×1
  • ReportParam.setValue (cyclomatic 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/ReportParams.java:150 — ReportParam.setValue has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GenericLayoutManager.calculateTableWidthFromCells (cyclomatic 17) · ×1
  • GenericLayoutManager.calculateTableWidthFromCells (cyclomatic 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:700 — GenericLayoutManager.calculateTableWidthFromCells has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WebClientDataSourceCreator.generateControllerMethod (cyclomatic 16) · ×1
  • WebClientDataSourceCreator.generateControllerMethod (cyclomatic 16) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:259 — WebClientDataSourceCreator.generateControllerMethod has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · JsModelGenerator.getTypeParams (cyclomatic 16) · ×1
  • JsModelGenerator.getTypeParams (cyclomatic 16) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:144 — JsModelGenerator.getTypeParams has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PageBootloader.parseLoaderConfig (cyclomatic 16) · ×1
  • PageBootloader.parseLoaderConfig (cyclomatic 16) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:46 — PageBootloader.parseLoaderConfig has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TableLayout.insertColumn (cyclomatic 16) · ×1
  • TableLayout.insertColumn (cyclomatic 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1182 — TableLayout.insertColumn has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · InlineAreasExcelRenderer.handleValueTypeAndSetText (cyclomatic 16) · ×1
  • InlineAreasExcelRenderer.handleValueTypeAndSetText (cyclomatic 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/InlineAreasExcelRenderer.java:210 — InlineAreasExcelRenderer.handleValueTypeAndSetText has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BaseExportDataProvider.formatPrimitive (cyclomatic 16) · ×1
  • BaseExportDataProvider.formatPrimitive (cyclomatic 16) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:113 — BaseExportDataProvider.formatPrimitive has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · TableLayout.writeTotalRow (cognitive 313) · ×1
  • TableLayout.writeTotalRow (cognitive 313) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2225 — TableLayout.writeTotalRow has cognitive complexity 313 (threshold 15). Drivers by points: if/else 68 (264 pts), loops 9 (37 pts), ternaries 2 (5 pts), boolean chains 4, error handling 1 (3 pts) (nesting depth added 229). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · TableLayout.writeGroupBound (cognitive 194) · ×1
  • TableLayout.writeGroupBound (cognitive 194) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1713 — TableLayout.writeGroupBound has cognitive complexity 194 (threshold 15). Drivers by points: if/else 39 (155 pts), loops 11 (28 pts), match/switch 2 (6 pts), boolean chains 5 (nesting depth added 137). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · XslfoTable.setHeaderBodyFooterBordersProperties (cognitive 125) · ×1
  • XslfoTable.setHeaderBodyFooterBordersProperties (cognitive 125) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:460 — XslfoTable.setHeaderBodyFooterBordersProperties has cognitive complexity 125 (threshold 15). Drivers by points: if/else 25 (53 pts), loops 15 (48 pts), boolean chains 24 (nesting depth added 61). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlockProperties.addBlock (cognitive 91) · ×1
  • BlockProperties.addBlock (cognitive 91) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:59 — BlockProperties.addBlock has cognitive complexity 91 (threshold 15). Drivers by points: if/else 30 (70 pts), loops 3 (8 pts), boolean chains 6, ternaries 3 (4 pts), match/switch 1 (3 pts) (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.writeRows (cognitive 81) · ×1
  • TableLayout.writeRows (cognitive 81) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1302 — TableLayout.writeRows has cognitive complexity 81 (threshold 15). Drivers by points: if/else 14 (50 pts), ternaries 4 (16 pts), loops 4 (14 pts), boolean chains 1 (nesting depth added 58). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · XslFoTreeBuilder.parseChildrenElement (cognitive 80) · ×1
  • XslFoTreeBuilder.parseChildrenElement (cognitive 80) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilder.java:116 — XslFoTreeBuilder.parseChildrenElement has cognitive complexity 80 (threshold 15). Drivers by points: if/else 24 (65 pts), boolean chains 12, match/switch 1 (2 pts), loops 1 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReportParameterConverter.parse (cognitive 80) · ×1
  • ReportParameterConverter.parse (cognitive 80) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/ReportParameterConverter.java:177 — ReportParameterConverter.parse has cognitive complexity 80 (threshold 15). Drivers by points: if/else 13 (42 pts), error handling 10 (35 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 55). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PredicateComposer.createPredicate (cognitive 66) · ×1
  • PredicateComposer.createPredicate (cognitive 66) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposer.java:103 — PredicateComposer.createPredicate has cognitive complexity 66 (threshold 15). Drivers by points: if/else 18 (40 pts), ternaries 4 (18 pts), boolean chains 4, loops 2 (4 pts) (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XslFoProfileWriter.writeLayoutMaster (cognitive 62) · ×1
  • XslFoProfileWriter.writeLayoutMaster (cognitive 62) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:380 — XslFoProfileWriter.writeLayoutMaster has cognitive complexity 62 (threshold 15). Drivers by points: if/else 12 (38 pts), ternaries 4 (20 pts), error handling 1 (2 pts), loops 1 (2 pts) (nesting depth added 44). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · WordRenderer.completeListItem (cognitive 62) · ×1
  • WordRenderer.completeListItem (cognitive 62) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:859 — WordRenderer.completeListItem has cognitive complexity 62 (threshold 15). Drivers by points: if/else 17 (41 pts), loops 5 (14 pts), boolean chains 4, match/switch 1 (3 pts) (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableProperties.setSpannedForCell (cognitive 52) · ×1
  • TableProperties.setSpannedForCell (cognitive 52) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/TableProperties.java:144 — TableProperties.setSpannedForCell has cognitive complexity 52 (threshold 15). Drivers by points: if/else 15 (42 pts), loops 3 (7 pts), boolean chains 3 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.writeSubTitleRow (cognitive 50) · ×1
  • TableLayout.writeSubTitleRow (cognitive 50) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2076 — TableLayout.writeSubTitleRow has cognitive complexity 50 (threshold 15). Drivers by points: if/else 16 (37 pts), loops 3 (6 pts), error handling 1 (3 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · TableLayout.hideColumns (cognitive 46) · ×1
  • TableLayout.hideColumns (cognitive 46) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1034 — TableLayout.hideColumns has cognitive complexity 46 (threshold 15). Drivers by points: if/else 10 (40 pts), loops 3 (6 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · GenericLayoutManager.calculateAreaSize (cognitive 45) · ×1
  • GenericLayoutManager.calculateAreaSize (cognitive 45) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:123 — GenericLayoutManager.calculateAreaSize has cognitive complexity 45 (threshold 15). Drivers by points: if/else 20 (34 pts), ternaries 3 (5 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EcoreGenerator.addRelationAnnotation (cognitive 45) · ×1
  • EcoreGenerator.addRelationAnnotation (cognitive 45) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:822 — EcoreGenerator.addRelationAnnotation has cognitive complexity 45 (threshold 15). Drivers by points: if/else 18 (35 pts), boolean chains 6, loops 2 (4 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DataSourceEcoreGenerator.setupParametersOfDataSource (cognitive 44) · ×1
  • DataSourceEcoreGenerator.setupParametersOfDataSource (cognitive 44) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/impl/DataSourceEcoreGenerator.java:124 — DataSourceEcoreGenerator.setupParametersOfDataSource has cognitive complexity 44 (threshold 15). Drivers by points: if/else 18 (35 pts), loops 3 (7 pts), boolean chains 1, ternaries 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AreaTreeBuilder.processStaticContentArea (cognitive 42) · ×1
  • AreaTreeBuilder.processStaticContentArea (cognitive 42) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:518 — AreaTreeBuilder.processStaticContentArea has cognitive complexity 42 (threshold 15). Drivers by points: if/else 6 (20 pts), loops 4 (10 pts), ternaries 2 (5 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenericArea.preProcessProperties (cognitive 40) · ×1
  • GenericArea.preProcessProperties (cognitive 40) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:441 — GenericArea.preProcessProperties has cognitive complexity 40 (threshold 15). Drivers by points: ternaries 8 (24 pts), if/else 5 (10 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ListItemArea.postProcessProperties (cognitive 39) · ×1
  • ListItemArea.postProcessProperties (cognitive 39) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:43 — ListItemArea.postProcessProperties has cognitive complexity 39 (threshold 15). Drivers by points: if/else 18 (25 pts), ternaries 5 (10 pts), boolean chains 4 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenericArea.moveChildMarginsToParentPaddings (cognitive 38) · ×1
  • GenericArea.moveChildMarginsToParentPaddings (cognitive 38) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:752 — GenericArea.moveChildMarginsToParentPaddings has cognitive complexity 38 (threshold 15). Drivers by points: if/else 6 (19 pts), loops 4 (14 pts), boolean chains 4, match/switch 1 (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ExcelRenderer.renderAreaToCells (cognitive 38) · ×1
  • ExcelRenderer.renderAreaToCells (cognitive 38) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:233 — ExcelRenderer.renderAreaToCells has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (25 pts), loops 2 (6 pts), boolean chains 5, ternaries 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImportSequenceGroupContextSplitterAndAggregator.topologicalSort (cognitive 37) · ×1
  • ImportSequenceGroupContextSplitterAndAggregator.topologicalSort (cognitive 37) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/ImportSequenceGroupContextSplitterAndAggregator.java:109 — ImportSequenceGroupContextSplitterAndAggregator.topologicalSort has cognitive complexity 37 (threshold 15). Drivers by points: if/else 7 (24 pts), loops 4 (10 pts), ternaries 1 (3 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DomainToXmlParser.parseDomainTo (cognitive 37) · ×1
  • DomainToXmlParser.parseDomainTo (cognitive 37) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/xml/DomainToXmlParser.java:27 — DomainToXmlParser.parseDomainTo has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (30 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · WordRenderer.addCatchWord (cognitive 37) · ×1
  • WordRenderer.addCatchWord (cognitive 37) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1323 — WordRenderer.addCatchWord has cognitive complexity 37 (threshold 15). Drivers by points: if/else 14 (26 pts), ternaries 2 (6 pts), match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XfwXslfoReport.writeReport (cognitive 36) · ×1
  • XfwXslfoReport.writeReport (cognitive 36) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/impl/XfwXslfoReport.java:570 — XfwXslfoReport.writeReport has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (34 pts), loops 1 (2 pts) (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · LayoutTable.getAggregatedValue (cognitive 35) · ×1
  • LayoutTable.getAggregatedValue (cognitive 35) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutTable.java:119 — LayoutTable.getAggregatedValue has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (26 pts), boolean chains 3, match/switch 1 (3 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.writeGroupBoundSeparatorEx (cognitive 35) · ×1
  • TableLayout.writeGroupBoundSeparatorEx (cognitive 35) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2741 — TableLayout.writeGroupBoundSeparatorEx has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (24 pts), loops 5 (11 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · AttributeParser.processProperties (cognitive 35) · ×1
  • AttributeParser.processProperties (cognitive 35) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:334 — AttributeParser.processProperties has cognitive complexity 35 (threshold 15). Drivers by points: if/else 16 (34 pts), match/switch 1 (nesting depth added 18). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · WordRenderer.addPage (cognitive 35) · ×1
  • WordRenderer.addPage (cognitive 35) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1227 — WordRenderer.addPage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (24 pts), ternaries 2 (8 pts), error handling 1 (3 pts) (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PageBootloader.parseLoaderConfig (cognitive 33) · ×1
  • PageBootloader.parseLoaderConfig (cognitive 33) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:46 — PageBootloader.parseLoaderConfig has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (28 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ToServiceGenerator.createPropertyValueByType (cognitive 32) · ×1
  • ToServiceGenerator.createPropertyValueByType (cognitive 32) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1473 — ToServiceGenerator.createPropertyValueByType has cognitive complexity 32 (threshold 15). Drivers by points: if/else 21 (23 pts), boolean chains 7, ternaries 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TransferToServiceGenerator.createPropertyValueByType (cognitive 32) · ×1
  • TransferToServiceGenerator.createPropertyValueByType (cognitive 32) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1187 — TransferToServiceGenerator.createPropertyValueByType has cognitive complexity 32 (threshold 15). Drivers by points: if/else 21 (23 pts), boolean chains 7, ternaries 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · XfwMetadataHolder.init (cognitive 32) · ×1
  • XfwMetadataHolder.init (cognitive 32) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/metadata/XfwMetadataHolder.java:89 — XfwMetadataHolder.init has cognitive complexity 32 (threshold 15). Drivers by points: if/else 14 (22 pts), loops 3 (4 pts), boolean chains 3, error handling 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MasterDetailLayout.writeLayout (cognitive 31) · ×1
  • MasterDetailLayout.writeLayout (cognitive 31) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:82 — MasterDetailLayout.writeLayout has cognitive complexity 31 (threshold 15). Drivers by points: if/else 5 (18 pts), loops 4 (13 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenericLayoutManager.calculateTableWidthFromCells (cognitive 31) · ×1
  • GenericLayoutManager.calculateTableWidthFromCells (cognitive 31) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:700 — GenericLayoutManager.calculateTableWidthFromCells has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 6 (11 pts), boolean chains 3 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlockProperties.completeBlock (cognitive 31) · ×1
  • BlockProperties.completeBlock (cognitive 31) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/foproperties/BlockProperties.java:323 — BlockProperties.completeBlock has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (22 pts), boolean chains 4, match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addListBlock (cognitive 30) · ×1
  • WordRenderer.addListBlock (cognitive 30) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:679 — WordRenderer.addListBlock has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 3 (8 pts), match/switch 1 (3 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReportParameterConverter.format (cognitive 30) · ×1
  • ReportParameterConverter.format (cognitive 30) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/ReportParameterConverter.java:72 — ReportParameterConverter.format has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18 (29 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EcoreGenerator.generate (cognitive 30) · ×1
  • EcoreGenerator.generate (cognitive 30) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/EcoreGenerator.java:140 — EcoreGenerator.generate has cognitive complexity 30 (threshold 15). Drivers by points: if/else 6 (17 pts), ternaries 4 (11 pts), boolean chains 1, loops 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · GenericLayoutManager.calculateTableHeightFromCells (cognitive 29) · ×1
  • GenericLayoutManager.calculateTableHeightFromCells (cognitive 29) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:786 — GenericLayoutManager.calculateTableHeightFromCells has cognitive complexity 29 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 4 (10 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ListItemArea.calculateMargins (cognitive 29) · ×1
  • ListItemArea.calculateMargins (cognitive 29) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/pagesequence/listblock/ListItemArea.java:110 — ListItemArea.calculateMargins has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (19 pts), ternaries 2 (6 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.calcShapeSize (cognitive 29) · ×1
  • WordRenderer.calcShapeSize (cognitive 29) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:431 — WordRenderer.calcShapeSize has cognitive complexity 29 (threshold 15). Drivers by points: ternaries 4 (18 pts), if/else 5, loops 2 (3 pts), match/switch 1 (3 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addTableCell (cognitive 28) · ×1
  • WordRenderer.addTableCell (cognitive 28) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1776 — WordRenderer.addTableCell has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 3 (8 pts), loops 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RuntimeComparator.compare (cognitive 28) · ×1
  • RuntimeComparator.compare (cognitive 28) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/store/impl/comparator/RuntimeComparator.java:20 — RuntimeComparator.compare has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (20 pts), error handling 1 (5 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ExcelView.setupStyles (cognitive 28) · ×1
  • ExcelView.setupStyles (cognitive 28) jxfw-export-poi/src/main/java/ru/croc/ctp/jxfw/export/poi/impl/views/ExcelView.java:147 — ExcelView.setupStyles has cognitive complexity 28 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 4 (8 pts), boolean chains 2, error handling 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JsModelGenerator.getTypeParams (cognitive 26) · ×1
  • JsModelGenerator.getTypeParams (cognitive 26) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:144 — JsModelGenerator.getTypeParams has cognitive complexity 26 (threshold 15). Drivers by points: if/else 14 (24 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AreaTreeBuilder.processInstreamForeignObject (cognitive 26) · ×1
  • AreaTreeBuilder.processInstreamForeignObject (cognitive 26) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:890 — AreaTreeBuilder.processInstreamForeignObject has cognitive complexity 26 (threshold 15). Drivers by points: ternaries 8 (20 pts), if/else 3, boolean chains 2, error handling 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ExcelRenderer.renderImage (cognitive 26) · ×1
  • ExcelRenderer.renderImage (cognitive 26) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:411 — ExcelRenderer.renderImage has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (21 pts), boolean chains 5 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · TransferPropertyResolverImpl.addTypedValue (cognitive 25) · ×1
  • TransferPropertyResolverImpl.addTypedValue (cognitive 25) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferPropertyResolverImpl.java:24 — TransferPropertyResolverImpl.addTypedValue has cognitive complexity 25 (threshold 15). Drivers by points: if/else 15 (22 pts), ternaries 1 (2 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DebugComparators.verifyTransitivity (cognitive 25) · ×1
  • DebugComparators.verifyTransitivity (cognitive 25) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/store/impl/comparator/DebugComparators.java:31 — DebugComparators.verifyTransitivity has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 5 (9 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XMMEditor.updateProblemIndication (cognitive 25) · ×1
  • XMMEditor.updateProblemIndication (cognitive 25) jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:616 — XMMEditor.updateProblemIndication has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (15 pts), error handling 2 (7 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ToServiceGenerator.populateNavigables (cognitive 24) · ×1
  • ToServiceGenerator.populateNavigables (cognitive 24) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1314 — ToServiceGenerator.populateNavigables has cognitive complexity 24 (threshold 15). Drivers by points: if/else 16 (23 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PageBootloader.parseRuntimeMatchSpec (cognitive 24) · ×1
  • PageBootloader.parseRuntimeMatchSpec (cognitive 24) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:277 — PageBootloader.parseRuntimeMatchSpec has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (17 pts), error handling 1 (5 pts), loops 1 (2 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · FoColor.getColorFromString (cognitive 24) · ×1
  • FoColor.getColorFromString (cognitive 24) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/FoColor.java:99 — FoColor.getColorFromString has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (12 pts), ternaries 3 (9 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XslfoTable.setTableBordersProperties (cognitive 24) · ×1
  • XslfoTable.setTableBordersProperties (cognitive 24) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/table/XslfoTable.java:415 — XslfoTable.setTableBordersProperties has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 5 (11 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XfwMetadataHolder.buildColumnsToFieldsMap (cognitive 24) · ×1
  • XfwMetadataHolder.buildColumnsToFieldsMap (cognitive 24) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/metadata/XfwMetadataHolder.java:244 — XfwMetadataHolder.buildColumnsToFieldsMap has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (18 pts), error handling 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WebClientDataSourceCreator.generateControllerMethod (cognitive 23) · ×1
  • WebClientDataSourceCreator.generateControllerMethod (cognitive 23) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:259 — WebClientDataSourceCreator.generateControllerMethod has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 4 (8 pts), boolean chains 2, match/switch 2, ternaries 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · WebClientCookieLocaleResolver.parseLocaleCookieIfNecessary (cognitive 23) · ×1
  • WebClientCookieLocaleResolver.parseLocaleCookieIfNecessary (cognitive 23) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/config/locale/WebClientCookieLocaleResolver.java:59 — WebClientCookieLocaleResolver.parseLocaleCookieIfNecessary has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (12 pts), ternaries 4 (11 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PageBootloader.parseFilesMatchConfig (cognitive 23) · ×1
  • PageBootloader.parseFilesMatchConfig (cognitive 23) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:133 — PageBootloader.parseFilesMatchConfig has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XslFoProfileWriter.setRegionAttributes (cognitive 23) · ×1
  • XslFoProfileWriter.setRegionAttributes (cognitive 23) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/XslFoProfileWriter.java:1168 — XslFoProfileWriter.setRegionAttributes has cognitive complexity 23 (threshold 15). Drivers by points: if/else 16 (23 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FoBorder.changeStyle (cognitive 23) · ×1
  • FoBorder.changeStyle (cognitive 23) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/border/FoBorder.java:203 — FoBorder.changeStyle has cognitive complexity 23 (threshold 15). Drivers by points: ternaries 3 (11 pts), if/else 5 (7 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AreaTreeBuilder.processFlowWithStaticContentAreas (cognitive 23) · ×1
  • AreaTreeBuilder.processFlowWithStaticContentAreas (cognitive 23) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:424 — AreaTreeBuilder.processFlowWithStaticContentAreas has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 3 (5 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ToServiceGenerator.createToToFieldBlockCode (cognitive 22) · ×1
  • ToServiceGenerator.createToToFieldBlockCode (cognitive 22) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:710 — ToServiceGenerator.createToToFieldBlockCode has cognitive complexity 22 (threshold 15). Drivers by points: if/else 17 (21 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TransferToServiceGenerator.createToToFieldBlockCode (cognitive 22) · ×1
  • TransferToServiceGenerator.createToToFieldBlockCode (cognitive 22) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:651 — TransferToServiceGenerator.createToToFieldBlockCode has cognitive complexity 22 (threshold 15). Drivers by points: if/else 17 (21 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CommonTable.pasteColumnsGroup (cognitive 22) · ×1
  • CommonTable.pasteColumnsGroup (cognitive 22) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/CommonTable.java:235 — CommonTable.pasteColumnsGroup has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (19 pts), loops 2, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XfwHelp.documentSynopsys (cognitive 22) · ×1
  • XfwHelp.documentSynopsys (cognitive 22) jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/command/XfwHelp.java:138 — XfwHelp.documentSynopsys has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (19 pts), boolean chains 2, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.calculateTotalCell (cognitive 21) · ×1
  • TableLayout.calculateTotalCell (cognitive 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1596 — TableLayout.calculateTotalCell has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 3, ternaries 1 (2 pts), error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · GenericLayoutManager.doCalculateAreaCoordinates (cognitive 21) · ×1
  • GenericLayoutManager.doCalculateAreaCoordinates (cognitive 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:868 — GenericLayoutManager.doCalculateAreaCoordinates has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (5 pts), match/switch 1 (2 pts), boolean chains 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addTableRow (cognitive 21) · ×1
  • WordRenderer.addTableRow (cognitive 21) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1958 — WordRenderer.addTableRow has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (15 pts), match/switch 2 (4 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XMMEditor.handleChangedResources (cognitive 21) · ×1
  • XMMEditor.handleChangedResources (cognitive 21) jxfw-eclipse-bundles/bundles/jxfw-metamodel.editor/src/ru/croc/ctp/jxfw/XtendMetaModel/presentation/XMMEditor.java:579 — XMMEditor.handleChangedResources has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (13 pts), error handling 1 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractEcoreGenerator.getEType (cognitive 21) · ×1
  • AbstractEcoreGenerator.getEType (cognitive 21) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/AbstractEcoreGenerator.java:143 — AbstractEcoreGenerator.getEType has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 1 (2 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ToServiceGenerator.populateOpposite (cognitive 20) · ×1
  • ToServiceGenerator.populateOpposite (cognitive 20) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1203 — ToServiceGenerator.populateOpposite has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (19 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MasterDetailLayout.writeMasterData (cognitive 20) · ×1
  • MasterDetailLayout.writeMasterData (cognitive 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/MasterDetailLayout.java:143 — MasterDetailLayout.writeMasterData has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (7 pts), boolean chains 1, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.setVarValues (cognitive 20) · ×1
  • TableLayout.setVarValues (cognitive 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2884 — TableLayout.setVarValues has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 2 (6 pts), match/switch 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · ReportParamDefintionProcessor.processAnd (cognitive 20) · ×1
  • ReportParamDefintionProcessor.processAnd (cognitive 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/paramprocessors/ReportParamDefintionProcessor.java:50 — ReportParamDefintionProcessor.processAnd has cognitive complexity 20 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 2 (6 pts), ternaries 1 (5 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ReportParamDefintionProcessor.processAndNot) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ReportParamDefintionProcessor.processAndNot (cognitive 20) · ×1
  • ReportParamDefintionProcessor.processAndNot (cognitive 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/paramprocessors/ReportParamDefintionProcessor.java:68 — ReportParamDefintionProcessor.processAndNot has cognitive complexity 20 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 2 (6 pts), ternaries 1 (5 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ReportParamDefintionProcessor.processAnd) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · InlineAreasExcelRenderer.handleValueTypeAndSetText (cognitive 20) · ×1
  • InlineAreasExcelRenderer.handleValueTypeAndSetText (cognitive 20) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/InlineAreasExcelRenderer.java:210 — InlineAreasExcelRenderer.handleValueTypeAndSetText has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (13 pts), error handling 2 (4 pts), boolean chains 2, ternaries 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ExcelView.fillHeaderAndRows (cognitive 20) · ×1
  • ExcelView.fillHeaderAndRows (cognitive 20) jxfw-export-poi/src/main/java/ru/croc/ctp/jxfw/export/poi/impl/views/ExcelView.java:240 — ExcelView.fillHeaderAndRows has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 4 (7 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BootloaderController.index (cognitive 19) · ×1
  • BootloaderController.index (cognitive 19) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/mvc/controllers/BootloaderController.java:65 — BootloaderController.index has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Catchword.doExecute (cognitive 19) · ×1
  • Catchword.doExecute (cognitive 19) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/catchword/Catchword.java:54 — Catchword.doExecute has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, loops 1 (2 pts), ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenericLayoutManager.processTableColumnsProperties (cognitive 19) · ×1
  • GenericLayoutManager.processTableColumnsProperties (cognitive 19) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:494 — GenericLayoutManager.processTableColumnsProperties has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (15 pts), loops 2, ternaries 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AttributeParser.processProperty (cognitive 19) · ×1
  • AttributeParser.processProperty (cognitive 19) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:308 — AttributeParser.processProperty has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (16 pts), error handling 1 (2 pts), match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · WordRenderer.addFlow (cognitive 19) · ×1
  • WordRenderer.addFlow (cognitive 19) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:559 — WordRenderer.addFlow has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EcoreModelEmitterSolr.addKeyFieldDetails (cognitive 19) · ×1
  • EcoreModelEmitterSolr.addKeyFieldDetails (cognitive 19) jxfw-fulltext-service/src/main/java/ru/croc/ctp/jxfw/fulltext/generator/solr/EcoreModelEmitterSolr.java:67 — EcoreModelEmitterSolr.addKeyFieldDetails has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JsModelGenerator.appendDefaultValue (cognitive 18) · ×1
  • JsModelGenerator.appendDefaultValue (cognitive 18) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:202 — JsModelGenerator.appendDefaultValue has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EnumGenerator.generate (cognitive 18) · ×1
  • EnumGenerator.generate (cognitive 18) modelgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/modelgen/EnumGenerator.java:71 — EnumGenerator.generate has cognitive complexity 18 (threshold 15). Drivers by points: loops 4 (12 pts), if/else 1 (3 pts), ternaries 1 (3 pts) (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · TaskExecutorWithInterrupt.<init> (cognitive 18) · ×1
  • TaskExecutorWithInterrupt.<init> (cognitive 18) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:59 — TaskExecutorWithInterrupt.<init> has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (6 pts), error handling 2 (5 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransponedTable.addCell (cognitive 18) · ×1
  • TransponedTable.addCell (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:123 — TransponedTable.addCell has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenericLayoutManager.makeEqualChildrenSizes (cognitive 18) · ×1
  • GenericLayoutManager.makeEqualChildrenSizes (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:255 — GenericLayoutManager.makeEqualChildrenSizes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (9 pts), match/switch 2 (5 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AreaTreeBuilder.parseChildrenElement (cognitive 18) · ×1
  • AreaTreeBuilder.parseChildrenElement (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:189 — AreaTreeBuilder.parseChildrenElement has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), match/switch 1 (2 pts), boolean chains 1, error handling 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExcelRenderer.setPageBreak (cognitive 18) · ×1
  • ExcelRenderer.setPageBreak (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:512 — ExcelRenderer.setPageBreak has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ListItemArea.adjustPaddings (cognitive 18) · ×1
  • ListItemArea.adjustPaddings (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/pagesequence/listblock/ListItemArea.java:44 — ListItemArea.adjustPaddings has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addRegionBody (cognitive 18) · ×1
  • WordRenderer.addRegionBody (cognitive 18) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1467 — WordRenderer.addRegionBody has cognitive complexity 18 (threshold 15). Drivers by points: error handling 1 (5 pts), loops 2 (5 pts), if/else 3 (4 pts), match/switch 1 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExceptionDescriptorImpl.updateTableMetadataFromStoreContext (cognitive 18) · ×1
  • ExceptionDescriptorImpl.updateTableMetadataFromStoreContext (cognitive 18) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/ExceptionDescriptorImpl.java:122 — ExceptionDescriptorImpl.updateTableMetadataFromStoreContext has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (18 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PackageModel.getImports (cognitive 17) · ×1
  • PackageModel.getImports (cognitive 17) modelgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/modelgen/ModelGenerator.java:214 — PackageModel.getImports has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransferToTransformerImplWithXmlns.toXml (cognitive 17) · ×1
  • TransferToTransformerImplWithXmlns.toXml (cognitive 17) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:42 — TransferToTransformerImplWithXmlns.toXml has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 1 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransponedTable.pasteColumnsGroup (cognitive 17) · ×1
  • TransponedTable.pasteColumnsGroup (cognitive 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java:255 — TransponedTable.pasteColumnsGroup has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), ternaries 1 (3 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LayoutFinder.findLayout (cognitive 17) · ×1
  • LayoutFinder.findLayout (cognitive 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutFinder.java:43 — LayoutFinder.findLayout has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableLayout.insertColumn (cognitive 17) · ×1
  • TableLayout.insertColumn (cognitive 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1182 — TableLayout.insertColumn has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 7 (8 pts), boolean chains 5, if/else 2, loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · InstreamForeignObjectArea.createSvg2Image (cognitive 17) · ×1
  • InstreamForeignObjectArea.createSvg2Image (cognitive 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/pagesequence/block/InstreamForeignObjectArea.java:66 — InstreamForeignObjectArea.createSvg2Image has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), error handling 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addTable (cognitive 17) · ×1
  • WordRenderer.addTable (cognitive 17) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1561 — WordRenderer.addTable has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseExportDataProvider.formatPrimitive (cognitive 17) · ×1
  • BaseExportDataProvider.formatPrimitive (cognitive 17) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/export/impl/BaseExportDataProvider.java:113 — BaseExportDataProvider.formatPrimitive has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 4, ternaries 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · AbstractDomainObjectFactory.create (cognitive 17) · ×1
  • AbstractDomainObjectFactory.create (cognitive 17) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/AbstractDomainObjectFactory.java:52 — AbstractDomainObjectFactory.create has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XfwHelp.documentOptions (cognitive 17) · ×1
  • XfwHelp.documentOptions (cognitive 17) jxfw-cli/src/main/java/ru/croc/ctp/jxfw/cli/command/XfwHelp.java:177 — XfwHelp.documentOptions has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 2 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PageBootloader.parseConfigMatchSpec (cognitive 16) · ×1
  • PageBootloader.parseConfigMatchSpec (cognitive 16) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/PageBootloader.java:174 — PageBootloader.parseConfigMatchSpec has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (7 pts), boolean chains 4, error handling 1 (3 pts), match/switch 1 (2 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScriptMatcher.isMatch (cognitive 16) · ×1
  • ScriptMatcher.isMatch (cognitive 16) jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/bootloader/ScriptMatcher.java:17 — ScriptMatcher.isMatch has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LayoutColumn.resetTotals (cognitive 16) · ×1
  • LayoutColumn.resetTotals (cognitive 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:597 — LayoutColumn.resetTotals has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java holds 10 of the 115 methods over the threshold — including the worst — and 643 of the 2078 points over it (31%), 4.4× the next-largest file (jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java at 147). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · GenericLayoutManager.distributeHeightGap (cognitive 16) · ×1
  • GenericLayoutManager.distributeHeightGap (cognitive 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:378 — GenericLayoutManager.distributeHeightGap has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), ternaries 1 (3 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (GenericLayoutManager.distributeWidthGap) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · GenericLayoutManager.distributeWidthGap (cognitive 16) · ×1
  • GenericLayoutManager.distributeWidthGap (cognitive 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java:323 — GenericLayoutManager.distributeWidthGap has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), ternaries 1 (3 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (GenericLayoutManager.distributeHeightGap) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · InlineAreasExcelRenderer.doRenderInlineAreas (cognitive 16) · ×1
  • InlineAreasExcelRenderer.doRenderInlineAreas (cognitive 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/InlineAreasExcelRenderer.java:168 — InlineAreasExcelRenderer.doRenderInlineAreas has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), boolean chains 3, loops 1 (2 pts), ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WordRenderer.addRegion (cognitive 16) · ×1
  • WordRenderer.addRegion (cognitive 16) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1522 — WordRenderer.addRegion has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (16 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PredicateComposer.createMultiplyExpressions (cognitive 16) · ×1
  • PredicateComposer.createMultiplyExpressions (cognitive 16) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/PredicateComposer.java:236 — PredicateComposer.createMultiplyExpressions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QTupleDataSourceResultSerializer.serialize (cognitive 16) · ×1
  • QTupleDataSourceResultSerializer.serialize (cognitive 16) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/facade/webclient/QTupleDataSourceResultSerializer.java:34 — QTupleDataSourceResultSerializer.serialize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member pair (36 shared lines) · ×1
  • Near-duplicate member pair (36 shared lines) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:412 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:412-464 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:275-360 — These two members are variants of one another: 36 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (96 corresponding lines) · ×1
  • Edited copy of a member (96 corresponding lines) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1187 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1187-1282 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1473-1568 — These two members are one piece of code written twice and then edited apart: 96 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (84–86 lines × 2) · ×1
  • Duplicated block (84–86 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:652 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:652-737 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:711-794 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:652` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (68 lines × 2) · ×1
  • Duplicated block (68 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:967 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:967-1034 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1055-1122 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (54 lines × 2) · ×1
  • Duplicated block (54 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1189 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1189-1242 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1475-1528 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (41 lines × 2) · ×1
  • Duplicated block (41 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:301 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:301-341 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java:218-258 — before extracting anything, compare `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoFont.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/font/FoFont.java:301` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25–35 lines × 3) · ×1
  • Duplicated block (25–35 lines × 3) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:98 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:98-122 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java:123-147 | scriptgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/solr/MapFieldToSolr.java:21-55 — before extracting anything, compare `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java` and `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImplWithXmlns.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 80 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/service/TransferToTransformerImpl.java:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:63 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:63-95 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:68-100 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×1
  • Duplicated block (31 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1516 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1516-1546 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1802-1832 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×1
  • Duplicated block (28 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:106 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java:106-133 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java:117-144 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/jpa/TransferToServiceGeneratorJpa.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/jpa/ToServiceGeneratorJpa.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (24–25 lines × 2) · ×1
  • Duplicated block (24–25 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:294 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:294-318 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:298-321 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:294` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:297` calls `addMethod`, `createEqualsObjectMethod`, `build` and `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:292` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24 lines × 3) · ×1
  • Duplicated block (24 lines × 3) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2419 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2419-2442 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2500-2523 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2638-2661 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2524` calls `getLayoutTable`, `getCurrentRow`, `getCurrentCell` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2444` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20–22 lines × 2) · ×1
  • Duplicated block (20–22 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2081 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2081-2102 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2230-2249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2081` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1376 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1376-1397 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1399-1420 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (20–21 lines × 2) · ×1
  • Duplicated block (20–21 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1235 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1235-1255 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1260-1279 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:1235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (17–18 lines × 2) · ×1
  • Duplicated block (17–18 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:185 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:185-202 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java:228-244 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:185` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (17 lines × 4) · ×1
  • Duplicated block (17 lines × 4) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2422 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2422-2438 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2503-2519 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2641-2657 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2760-2776 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2524` calls `getLayoutTable`, `getCurrentRow`, `getCurrentCell` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2444` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×1
  • Duplicated block (16–17 lines × 2) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:534 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:534-550 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:544-559 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:534` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:543` calls `addStatement` and `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:534` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (15–16 lines × 4) · ×1
  • Duplicated block (15–16 lines × 4) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2350 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2350-2365 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2394-2408 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2574-2589 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2697-2712 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2350` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:441 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:441-456 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:449-464 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:345-360 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:441` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×1
  • Duplicated block (15 lines × 4) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwH2Dialect.java:59 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwH2Dialect.java:59-73 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwMySqlDialect.java:56-70 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwOracle10gDialect.java:56-70 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwPostgreSql9Dialect.java:56-70 — before extracting anything, compare `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwH2Dialect.java` and `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/hibernate/dialect/XfwMySqlDialect.java` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (12–15 lines × 2) · ×1
  • Duplicated block (12–15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2152 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2152-2166 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2172-2183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2152` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×1
  • Duplicated block (14–15 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:600 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:600-614 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:661-674 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/ExcelRenderer.java:600` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:422 — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:422-435 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:430-443 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/solr/ToServiceGeneratorSolr.java:326-339 — before extracting anything, compare `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java` and `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java` as WHOLE FILES: this scan already matched 41 separate duplicated blocks between them, totalling at least 727 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:422` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–13 lines × 5) · ×1
  • Duplicated block (9–13 lines × 5) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2419 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2419-2430 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2500-2511 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2614-2626 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2638-2649 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2760-2768 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:2419` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10–11 lines × 3) · ×1
  • Duplicated block (10–11 lines × 3) jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:141 — jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:141-150 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:199-208 | jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:228-238 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:151` calls `setConstraint` and `jxfw-jpa-runtime/src/main/java/ru/croc/ctp/jxfw/jpa/exception/impl/H2DbExceptionParser.java:209` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ControllerGenerationUtils.java:171 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ControllerGenerationUtils.java:171-181 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:568-579 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:648-659 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ControllerGenerationUtils.java:171` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:60 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:60-68 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:79-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/list/ListItemArea.java:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:109 — jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:109-118 | jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:177-187 | jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:239-248 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:174` calls `addFileDownLoadCookieAndHeader`, `getExtension` and `jxfw-reporting-birt/src/main/java/ru/croc/ctp/jxfw/reporting/birt/impl/BirtReportServiceImpl.java:235` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:182 — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:182-188 | wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:270-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientControllerCreator.java:182` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6–7 lines × 2) · ×1
  • Duplicated block (6–7 lines × 2) jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:318 — jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:318-323 | jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:344-350 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-cass-runtime/src/main/java/ru/croc/ctp/jxfw/cass/facade/webclient/SelectComposer.java:318` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:630 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:630-635 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1180-1185 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1208-1213 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `area` to `InlineArea` in one and `PageNumberArea` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1187` calls `insertField` and `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:637` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (3–5 lines × 3) · ×1
  • Duplicated block (3–5 lines × 3) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1345 — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1345-1347 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1354-1358 | jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1368-1373 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java:1345` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 3) · ×1
  • Duplicated block (23 lines × 3) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/datasource/DomainObjectDataSourceResult.java:33 — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/datasource/DomainObjectDataSourceResult.java:33-66 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/datasource/GeneralDataSourceResult.java:32-54 | jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/datasource/PojoDataSourceResult.java:32-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `data` to `Iterable<DomainObject<? extends Serializable>>` in one and `Iterable<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (52 lines × 2) · ×1
  • Duplicated block (52 lines × 2) REDACTED:1 — REDACTED:1-52 | REDACTED:1-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (93 lines × 2) · ×1
  • Duplicated block (93 lines × 2) jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/config/JsonXfwTransferConfig.java:1 — jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/config/JsonXfwTransferConfig.java:1-95 | jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/config/XmlXfwTransferConfig.java:1-93 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/config/JsonXfwTransferConfig.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Minor — 92 finding(s)
X4 · Structured logging · Interpolated log message defeats structured logging · ×40
  • Interpolated log message defeats structured logging wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java:441 — `warn` at line 441 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:742 — `debug` at line 742 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/WebClientDataSourceCreator.java:648 — `debug` at line 648 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:683 — `debug` at line 683 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/wc/TransferController.java:160 — `debug` at line 160 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:87 — `debug` at line 87 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:90 — `debug` at line 90 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/TaskExecutorWithInterrupt.java:196 — `debug` at line 196 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging REDACTED:177 — `error` at line 177 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultFileScanner.java:104 — `debug` at line 104 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultFileScanner.java:119 — `debug` at line 119 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-transfer/src/main/java/ru/croc/ctp/jxfw/transfer/impl/imp/context/DefaultImportContextManager.java:256 — `debug` at line 256 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-solr-runtime/src/main/java/ru/croc/ctp/jxfw/solr/facade/webclient/CriteriaComposer.java:392 — `debug` at line 392 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-security/src/main/java/ru/croc/ctp/jxfw/security/facade/Http401UnauthorizedEntryPoint.java:43 — `debug` at line 43 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/style/StyleInliner.java:76 — `debug` at line 76 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/style/StyleInliner.java:81 — `debug` at line 81 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:511 — `debug` at line 511 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/rendering/WordRenderer.java:1306 — `error` at line 1306 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:100 — `debug` at line 100 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:118 — `debug` at line 118 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:653 — `error` at line 653 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/attribute/AttributeParser.java:679 — `error` at line 679 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:77 — `error` at line 77 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/common/foimage/FoImage.java:95 — `error` at line 95 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • Interpolated log message defeats structured logging jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/core/common/HelpFuncs.java:186 — `debug` at line 186 is handed a message assembled at the call — a string concatenated with a value, or `String.format` — through SLF4J or log4j 2, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. An exception goes last, as the throwable argument, not into the text.
  • + 15 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×25
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/ColumnLayoutManager.java:124 — `!area.isHasChildren() || area.getProgressionDirection() == AreaProgressionDirection.INLINE` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/ColumnLayoutManager.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/layout/layoutmanager/GenericLayoutManager.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java:1332 — `!textIndent.isPercentage() && textIndent.hasValue()` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/processing/tree/AreaTreeBuilder.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/rendering/excel/InlineAreasExcelRenderer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1256 — `"EBooleanObject".equals(fieldTypeName) || "EBoolean".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1232 — `"EByteObject".equals(fieldTypeName) || "EByte".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1252 — `"EDoubleObject".equals(fieldTypeName) || "EDouble".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1248 — `"EFloatObject".equals(fieldTypeName) || "EFloat".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1240 — `"EIntegerObject".equals(fieldTypeName) || "EInt".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1244 — `"ELongObject".equals(fieldTypeName) || "ELong".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1236 — `"EShortObject".equals(fieldTypeName) || "EShort".equals(fieldTypeName)` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java:34 — `((LocalDate) date).isAfter(minDate) || ((LocalDate) date).isEqual(minDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MinInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java:34 — `((LocalDate) date).isBefore(maxDate) || ((LocalDate) date).isEqual(maxDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MaxInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java:38 — `((LocalDateTime) date).isAfter(minDate) || ((LocalDateTime) date).isEqual(minDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MinInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java:38 — `((LocalDateTime) date).isBefore(maxDate) || ((LocalDateTime) date).isEqual(maxDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MaxInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java:42 — `((LocalTime) date).isAfter(minDate) || date.equals(minDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MinInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MinInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java:42 — `((LocalTime) date).isBefore(maxDate) || date.equals(maxDate)` appears character-identically in 2 files — jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/jdk7/validator/MaxInclusiveValidator.java, jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/validation/validator/MaxInclusiveValidator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:109 — `(f instanceof XFWAttribute) && ((XFWAttribute) f).isSystemField()` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:112 — `(f instanceof XFWAttribute) && ((XFWAttribute) f).isVersionField()` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutTable.java:146 — `aggregationFunction != "distinctcount" && aggregationFunction != "count"` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/LayoutTable.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/layouts/TableLayout.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java:868 — `annotation != null && annotation.getDetails() != null` appears character-identically in 2 files — wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/JsModelGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:238 — `attributeList == null || attributeList.size() == 0` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/AttributeParser.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java:123 — `childrenList != null && childrenList.size() > 0` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/GenericArea.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/element/root/GenericArea.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java:98 — `classifierFiltrator.anyMatch( (Set<ClassifierFilter>) options.get(INCLUDE_FILTERS), classifier) && !classifierFiltrator.anyMatch( (Set<Class…` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/AbstractFacadeGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/generator/FacadeGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/border/FoBorder.java:60 — `color != FoColor.DEFAULT_COLOR || !(isStyleDefined() || isWidthDefined())` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/foproperty/border/FoBorder.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/tree/attribute/FoBorder.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/CommonTable.java:135 — `dataType != null && dataType.length() != 0` appears character-identically in 2 files — jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/CommonTable.java, jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/fowriter/TransponedTable.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java:1476 — `f.getEAnnotation(XFWConstants.SERVER_ONLY_ANNOTATION.getUri()) == null && f.getEType().getEAnnotation(XFWConstants.SERVER_ONLY_ANNOTATION.ge…` appears character-identically in 2 files — jxfw-transfer-facade-gen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/transfer/TransferToServiceGenerator.java, wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/facade/ToServiceGenerator.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
AX6 · Interface segregation · Fat interface · ×5
  • Fat interface: IArea (23 abstract methods) jxfw-reporting-xsl-fo/src/main/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/excel/core/element/area/IArea.java:16 — `IArea` declares 23 abstract methods: `getAreaType`, `getBorderRange`, `getBorderRectangle`, `getChildrenList`, `getInheritedProperty`, `getInheritedPropertyValue`, `getParentArea`, `getProgressionDirection`, `getProperties`, `getProperty`, `getPropertyValue`, `isColumnLayoutSpan`, `isHasChildren`, `isNeedRendering`, `isSplitted`, `postProcessProperties`, `setBorderRectangle`, `setChildrenList`, `setColumnLayoutSpan`, `setParentArea`, `setProgressionDirection`, `setPropertyValue`, `setSplitted`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: XfwClass (21 abstract methods) jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/runtime/XfwClass.java:9 — `XfwClass` declares 21 abstract methods: `findAttribute`, `getChainingEStructuralFeature`, `getEAllAttributes`, `getEAllReferences`, `getEAllStructuralFeatures`, `getEAllSuperTypes`, `getEAttributes`, `getEReferences`, `getEStructuralFeature`, `getEStructuralFeatures`, `getESuperTypes`, `getFeatureCount`, `getFeaturesFlatMap`, `getKeyTypeName`, `getPersistenceModule`, `getPersistenceType`, `isAbstract`, `isComplexType`, `isPersistentType`, `isSuperTypeOf`, `isTransientType`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: XFWMMPackage (40 abstract methods) jxfw-eclipse-bundles/bundles/jxfw-metamodel/src/main/java/ru/croc/ctp/jxfw/metamodel/XFWMMPackage.java:30 — `XFWMMPackage` declares 40 abstract methods: `getBlob`, `getDomainObject`, `getDuration`, `getDuration_Java7`, `getList`, `getLocalDate`, `getLocalDateTime`, `getLocalDateTime_Java7`, `getLocalDate_Java7`, `getLocalTime`, `getLocalTime_Java7`, `getMap`, `getModelFileExtension`, `getModelFileName`, `getModelFilePath`, `getModelFileUri`, `getModelFolderPath`, `getObjectFilter`, `getPeriod`, `getPeriod_Java7`, `getSet`, `getTimestamp`, `getTuple`, `getUUID`, `getXFWAttribute`, `getXFWAttribute_MaxLength`, `getXFWClass`, `getXFWClass_ComplexType`, `getXFWClass_KeyTypeName`, `getXFWClass_PersistenceModule`, `getXFWClass_PersistenceType`, `getXFWDataSource`, `getXFWDataSource_General`, `getXFWDataSource_RequestMapping`, `getXFWMMFactory`, `getXFWOperation`, `getXFWPackage`, `getXFWReference`, `getZonedDateTime`, `getZonedDateTime_Java7`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: DomainService<T, TK, Q> (16 abstract methods) jxfw-core-runtime/src/main/java/ru/croc/ctp/jxfw/core/domain/DomainService.java:22 — `DomainService<T, TK, Q>` declares 16 abstract methods under just 8 distinct name(s): `createNew`, `delete`, `deleteAll`, `getMaxObjects`, `getObjectById`, `getObjectById`, `getObjectById`, `getObjectById`, `getObjects`, `getObjects`, `getObjects`, `getObjects`, `save`, `save`, `validate`, `validate`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 8 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: PersistenceModule (18 abstract methods) jxfw-core-compile/src/main/java/ru/croc/ctp/jxfw/core/generator/PersistenceModule.java:28 — `PersistenceModule` declares 18 abstract methods: `createComplexKey`, `createRepository`, `createRepositoryImpl`, `createService`, `doGenerateCode`, `doValidate`, `ecoreAddColumnProps`, `ecoreGetOpposite`, `extendClazz`, `extendMappedSuperclass`, `getEcoreModelEmitter`, `getFieldsList`, `getIdType`, `getKeyType`, `getKeyType`, `produceRequiredFields`, `registerClasses`, `validateBeforeTransform`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 18 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
IC1 · Incompleteness & stubs · Disabled test · ×3
  • Disabled test jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/load/events/EventsTest.java:26 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/reporting/impl/XfwResourceLoaderTest.java:14 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilderTest.java:18 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
D30 · Dependency Vulnerabilities · Low CVE · ×2
  • REDACTED
  • REDACTED
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 3 of 24 project(s) overshoot their size bounds, lowering Project Cohesion to 7.5/10. The most over is `jxfw-reporting-xsl-fo` (32013 LoC, 211 module-visible types across 60 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
IC1 · Incompleteness & stubs · Blanket warning suppression · ×1
  • Blanket warning suppression jxfw-wc-loader/src/main/java/ru/croc/ctp/jxfw/wc/web/mvc/controllers/PageControllerBase.java:174 — `@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead.
M1 · Documentation (README) · Thin README · ×1
  • Thin README README.md:1 — The root README is 38 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1036 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P4 · Deployment & Rollback · No release approval gate · ×1
  • No release approval gate — The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X23 · Unguarded diagnostic materialisation · Diagnostic log message is built whether or not it is wanted · ×1
  • Diagnostic log message is built whether or not it is wanted wcgen-maven-plugin/src/main/java/ru/croc/ctp/jxfw/mojo/EcoreProcessor.java:237 — `debug` at line 237 is called with an argument built by `classes.stream()` (line 238), whose cost grows with the collection it walks. Java evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isDebugEnabled`/`isTraceEnabled` test, no debug flag, no lambda or `Supplier` the logger calls only when the level is on.
X5 · Nullable reference types · Java packages are not null-marked everywhere · ×1
  • Java packages are not null-marked everywhere — 0/230 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
Minor — 3 finding(s)
D10 · Test Quality · Skipped (documented) · ×3
  • Skipped (documented): toStringOfReadSessionEventTest jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/load/events/EventsTest.java:27 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore
  • Skipped (documented): httpResource jxfw-core-runtime/src/test/java/ru/croc/ctp/jxfw/core/reporting/impl/XfwResourceLoaderTest.java:15 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore
  • Skipped (documented): endElementThroughReaderApi jxfw-reporting-xsl-fo/src/test/java/ru/croc/ctp/jxfw/reporting/xslfo/renderer/word/processing/XslFoTreeBuilderTest.java:19 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-4c82ee88f956445db8d57043a60d205e/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-4c82ee88f956445db8d57043a60d205e/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .19artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .26artifacts/raw/osv-scanner.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .0artifacts/raw/osv-scanner.json

Run 01a1b891-7d2e-7e01-a5fe-8043dadb9382 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md