{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D8","name":"Code Coverage","shortDescription":{"text":"Code Coverage"},"helpUri":"https://codehealth.canine.dev/dimensions/D8"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D18","name":"Solution Shape","shortDescription":{"text":"Solution Shape"},"helpUri":"https://codehealth.canine.dev/dimensions/D18"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D24","name":"Comment Value","shortDescription":{"text":"Comment Value"},"helpUri":"https://codehealth.canine.dev/dimensions/D24"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX5","name":"Architecture \u0026 structure","shortDescription":{"text":"Architecture \u0026 structure"},"helpUri":"https://codehealth.canine.dev/dimensions/AX5"},{"id":"AXB1","name":"Runtime evidence locked \u2014 no reproducible boot","shortDescription":{"text":"Runtime evidence locked \u2014 no reproducible boot"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB1"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"GD1","name":"Unfinished \u0026 placeholder code","shortDescription":{"text":"Unfinished \u0026 placeholder code"},"helpUri":"https://codehealth.canine.dev/dimensions/GD1"},{"id":"IC1","name":"Incompleteness \u0026 stubs","shortDescription":{"text":"Incompleteness \u0026 stubs"},"helpUri":"https://codehealth.canine.dev/dimensions/IC1"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"X1","name":"Async correctness","shortDescription":{"text":"Async correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X1"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X12","name":"Unreachable branch","shortDescription":{"text":"Unreachable branch"},"helpUri":"https://codehealth.canine.dev/dimensions/X12"},{"id":"X13","name":"Undrained process stream","shortDescription":{"text":"Undrained process stream"},"helpUri":"https://codehealth.canine.dev/dimensions/X13"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X15","name":"Unvalidated length from an untrusted reader","shortDescription":{"text":"Unvalidated length from an untrusted reader"},"helpUri":"https://codehealth.canine.dev/dimensions/X15"},{"id":"X16","name":"Unfloored truncation loop","shortDescription":{"text":"Unfloored truncation loop"},"helpUri":"https://codehealth.canine.dev/dimensions/X16"},{"id":"X17","name":"Uncapped recursion over a caller-supplied document","shortDescription":{"text":"Uncapped recursion over a caller-supplied document"},"helpUri":"https://codehealth.canine.dev/dimensions/X17"},{"id":"X18","name":"Disposal-pattern correctness","shortDescription":{"text":"Disposal-pattern correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X18"},{"id":"X19","name":"Unrestored process-global state","shortDescription":{"text":"Unrestored process-global state"},"helpUri":"https://codehealth.canine.dev/dimensions/X19"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X22","name":"Contradicted release guard","shortDescription":{"text":"Contradicted release guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X22"},{"id":"X23","name":"Unguarded diagnostic materialisation","shortDescription":{"text":"Unguarded diagnostic materialisation"},"helpUri":"https://codehealth.canine.dev/dimensions/X23"},{"id":"X24","name":"Document value interpolated into markup unescaped","shortDescription":{"text":"Document value interpolated into markup unescaped"},"helpUri":"https://codehealth.canine.dev/dimensions/X24"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X27","name":"Collection changed while being enumerated","shortDescription":{"text":"Collection changed while being enumerated"},"helpUri":"https://codehealth.canine.dev/dimensions/X27"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X29","name":"Per-element action decided by a fixed element","shortDescription":{"text":"Per-element action decided by a fixed element"},"helpUri":"https://codehealth.canine.dev/dimensions/X29"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X30","name":"Support guard that admits what it rejects","shortDescription":{"text":"Support guard that admits what it rejects"},"helpUri":"https://codehealth.canine.dev/dimensions/X30"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X4","name":"Structured logging","shortDescription":{"text":"Structured logging"},"helpUri":"https://codehealth.canine.dev/dimensions/X4"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"MbSlaveDataServer.DataServices (cyclomatic 21): MbSlaveDataServer.DataServices has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/SlaveDataServer/MbSlaveDataServer.cs"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"36a9452c2fe19b8ccf5866a8aa8471c07600e19c583e66579dac43b776fdd161"}},{"ruleId":"D2","level":"warning","message":{"text":"MbSlaveDataServer.DataServices (cognitive 23): MbSlaveDataServer.DataServices has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/SlaveDataServer/MbSlaveDataServer.cs"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"7880abb0034a81a3f257513e223553dc7196ae134e508747c29e03e142525975"}},{"ruleId":"D2","level":"warning","message":{"text":"MbSlaveStateMachine.SerialInterface_DataReceivedEvent (cognitive 22): MbSlaveStateMachine.SerialInterface_DataReceivedEvent has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbSlaveStateMachine.cs"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c077b587fdb2b6141ebfb25333ceddfcb8389916f233253634c9bb7bd4f16fb"}},{"ruleId":"D2","level":"warning","message":{"text":"MbGridView.InitGridView (cognitive 18): MbGridView.InitGridView has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/MbGridView.cs"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b54fcfadad44a5a9ec59f7fa7b2f42815b71570448a72f4f6dd921f3fca5afd"}},{"ruleId":"D8","level":"error","message":{"text":"No automated tests: No automated tests \u2014 no test code was found in this repository. Untested code is the largest single risk to changing it safely. Start with the code you change most often: add a suite in a framework a runner can collect (xUnit, NUnit or MSTest), and run it in CI so the gap cannot reopen."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3132564c6310e5d01a231f252a02d5d2f5a542c0a8fa29a14c89693f1e3df871"}},{"ruleId":"D9","level":"note","message":{"text":"No tests found: No test suite could be collected \u2014 no discoverable tests to count. If this repository does test, wiring the suite to a framework a runner can collect (xUnit, NUnit or MSTest) is what makes it countable here; a pipeline step that invokes a runner is not evidence on its own, because a runner over an empty suite passes. Tests written as plain executables or shell/PowerShell harnesses are not collectible this way and are not scored here."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"c9bf64cbb5a4ae13d6bcd01fa3bc8d2879d860c73bc67f176ee3c2cecb8adce3"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: DemoApps/Samples/SlaveSimple/Program.cs: DemoApps/Samples/SlaveSimple/Program.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 5 (its worst body is Program.Main at line 13), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201CBug fix in MasterSimple/Program.cs Update of DemoApps/VB.NET example programs\u201D; \u201CMbSlaveStdServer.cs bug fix regarding 32-bit data type\u201D; \u201CBug fixed in MbSlaveStdServer.cs conversion short[] -\u003E ushort[]\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2024-09-21..2024-12-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272024-09-21 15:51:50 \u002B01:00\u0027 --until=\u00272024-12-20 15:51:50 \u002B01:00\u0027 --full-history --no-merges -- DemoApps/Samples/SlaveSimple/Program.cs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/Samples/SlaveSimple/Program.cs"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce9e1ffaaf4ca871308d34fb8bcf46ae76cb2fce28c28d79149ef62223a5621c"}},{"ruleId":"D16","level":"warning","message":{"text":"bus factor 1 \u2014 one contributor carries this repository: 2 contributor(s) have commits in this repository (automation and bot accounts excluded), but the commits of a single one of them cover most of its history \u2014 92% of the 51 commit(s) sampled \u2014 so the number of people who actually carry it is 1. This is not the ambient state of a solo project: there ARE other contributors, and if the one who carries the repository becomes unavailable, the knowledge behind most of its history goes with them. Spread the next changes deliberately \u2014 have a second contributor review or pair on them \u2014 and write down the parts only one person can currently change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"a99f114ab4dfee37ae0bf0665b44c7468d85b809d361949e2b6258101fa1e5a2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO CRC into Utils verschieben \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbRTU.cs"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"07e6e7f96ee3ad264e1040787c07a1d053ed6b799d1e16af6450b298af3d4cf6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO better READ with timeout \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbSerial.cs"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"9768f758c3d3b96605943c804c925c0bdd3b99cd23a82f33f0e6fc3f581e5c88"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO MASK_WRITE_REGISTER \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbBase.cs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fe4534878d8c3232f568e5c2ed6bca448fc7ed7c1401efa9d25b2e2c2bf5fdc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO wenn Size \u003E als Array Fehler erzeugen \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":358}}}],"partialFingerprints":{"codehealthFindingId/v1":"31e3f183ee32f8124fbd21fbf58c2ad83acd63114147f155970bed44e5094f0b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO overflow \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":521}}}],"partialFingerprints":{"codehealthFindingId/v1":"5aa37cabb6be179c85d6d32fb193e06b8a40167ca8aca2bd1dc240c40337b5eb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO overflow \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":538}}}],"partialFingerprints":{"codehealthFindingId/v1":"b96c01aeaa1071d699121951d56d451bfe73e2be77daed7a4310b2bdc4374716"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO check if connected \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMaster.cs"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"54532168b3ec8f68dda0df4075e41d53961e4fcc224dbb3d530c728e1e284925"}},{"ruleId":"D17","level":"warning","message":{"text":"CommentedOutCode: 3 consecutive commented-code lines"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMaster.cs"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"463a862e3d321a352a737c4ae1bf6d91468be126fd7e45cb6a61a4c0ca062708"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO consider using template macro"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMasterEx.cs"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"16cd0f3fb8c202f2bbb0f340b4f4f5630c824e35e5bd412840308665befb5ede"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO raise disconnect event \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbSlave.cs"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebf797b00fafd1552cf66330a3b96c7a01a20ea4d17be71813a2d7e464a47145"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO Async Call ? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/MasterGridView.cs"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5a5e077b145614308655d0936806d5a38214fa8d484947468319e771d606e21"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO Async Call ? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/MasterGridView.cs"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"290298a5e443f57a2ac960d5e3578d7723b4a4fa6580a00f89397960dd50e20b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO use new Modbusb32Data\u003CDataT\u003E for 32bit Datatypes \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/SlaveGridView.cs"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c9f1f04a22ae0dd1e420e185988310a9800e8b6571801d8921cd8df3ae87486"}},{"ruleId":"D17","level":"warning","message":{"text":"DeadPreprocessorBranch: #if RTU_INTERFACE \u2014 no definition of that symbol was found anywhere this analysis looks: not in a \u003CDefineConstants\u003E in any project file, props or targets under any condition, not on a build script\u0027s command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles \u2014 including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/Samples/MasterSimple/Program.cs"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac31aa04246c853da8da63bf1cd84d3c4c098324d5c0b20bce34f2cd99b697ef"}},{"ruleId":"D17","level":"warning","message":{"text":"DeadPreprocessorBranch: #if RTU_INTERFACE \u2014 no definition of that symbol was found anywhere this analysis looks: not in a \u003CDefineConstants\u003E in any project file, props or targets under any condition, not on a build script\u0027s command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles \u2014 including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/Samples/SlaveSimple/Program.cs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bdc824b652ddc08172fd03540e2755478703cd2f8d87377884ec111daa657cd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: \u0027 TODO Master should closed at the end of one polling cycle \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060\u0027 REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/frmModsMaster.vb"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d50e633af5c64def9830176b89bd0ded12d1ce2b23519858eb7f0420da59687"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: \u0027 TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060\u0027 REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/frmModsMaster.vb"},"region":{"startLine":148}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c411de5cf0e0e4f129cbd9db74e5e1afe741a5f63e7310ab132816ad6e932d1"}},{"ruleId":"D18","level":"warning","message":{"text":"Solution references a project that does not exist: \u0060DemoApps/VB.NET/csModBus.sln\u0060 declares 1 project file(s) that are missing from the tree (\u0060DemoApps/GridViewTest/GridViewTest.csproj\u0060). A solution-level restore or build fails on a dangling reference, so anyone building the solution rather than an individual project is blocked. Delete the stale entry from the solution, or restore the missing project file."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModBus.sln"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"74b43757b1cb01b1653cc0a5cc7f0717e1fb5a7ba2234a979a08e86fa45bf6f7"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022General Information about an assembly is controlled through the following set of attributes. Change these attribute values to modify the information associated  \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/Properties/AssemblyInfo.cs"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"98a15c5bdd5ad0129acbcf4bceebb16ea998eeea1dda27845d08b0b3e4a907e2"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/Properties/AssemblyInfo.cs"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3cb5e67db76c1ebb29907929b1179ad0ccc88b9eaac6e555c7c8d41c82ecaea"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022The following GUID is for the ID of the typelib if this project is exposed to COM\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/Properties/AssemblyInfo.cs"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d282d2c6adc4b81e8bc8994969f9825f8039b93ca56308393e91013bc6d3347"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Version information for an assembly consists of the following four values: Major Version Minor Version Build Number Revision You can specify all the values or y \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/Properties/AssemblyInfo.cs"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b1222d5787e428b2ca723cd1329c73be50b53648081c0dcb1cf0f0b00add30a"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Copy the write data\u0022 repeats the code it sits on: 3 of its 3 words (copy, write, data) are already in \u0060WriteData.CopyFrom(RawData.Data, REQST_WRADDR_IDX, WrDataLen \u002B 5);\u0060. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":305}}}],"partialFingerprints":{"codehealthFindingId/v1":"039c2e92a574ce2b39fc7aa62c608428be4f4668222b093e572f2debb09445b9"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022General Information about an assembly is controlled through the following set of attributes. Change these attribute values to modify the information associated  \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/Properties/AssemblyInfo.cs"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"da493fc6cefa6d56f62728e009609630490219311e140ca9e598b67a333d681b"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/Properties/AssemblyInfo.cs"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9e89de30c4433a12cd798be1bae26f260b8572739ba878259918ddc991f8b92"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022The following GUID is for the ID of the typelib if this project is exposed to COM\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/Properties/AssemblyInfo.cs"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"23d2e2589525de2e49fc85afdf9568e30a7f41c63e54b4d871bb58e668d74183"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Version information for an assembly consists of the following four values: Major Version Minor Version Build Number Revision You can specify all the values or y \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/Properties/AssemblyInfo.cs"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5a27b544419863704f53431219e514c7f8f6e715bf6652e865deb4d78bab7a8"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Get the Descriptor\u0027s Properties\u0022 repeats the code it sits on: 3 of its 3 words (get, descriptor, properties) are already in \u0060PropertyDescriptor theDescriptor = TypeDescriptor.GetProperties(this.GetType())[strPropertyName];\u0060. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/ModbusView.cs"},"region":{"startLine":369}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa9315a4e66a44aa5cd9466472ef860e3c8de14cc44b0a052b65430b85773fdf"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Set the Descriptor\u0027s \u0022Browsable\u0022 Attribute\u0022 repeats the code it sits on: 4 of its 4 words (set, descriptor, browsable, attribute) are already in \u0060isBrowsable.SetValue(theDescriptorBrowsableAttribute, bIsBrowsable);\u0060. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/ModbusView.cs"},"region":{"startLine":376}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c481f588619559be08aef90c93cf09b023e7b501042d0e71462154940be9d38"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022This call is required by the designer.\u0022 is Visual Studio form constructor template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/common/dOptions.vb"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"86dd87e51facbc7e057ff3e90af65f0ac104ae101c5c84a55cb0df142c793aaf"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022General Information about an assembly is controlled through the following set of attributes. Change these attribute values to modify the information associated  \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/My Project/AssemblyInfo.vb"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb6cc9b6ea08de92b229df4baa7b49e0951b95d8783c8faadc6d3517128dc03a"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Review the values of the assembly attributes\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/My Project/AssemblyInfo.vb"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d22949f3774fb5509638b7a3311efe2e7e9496bad3dc34628baa0ca5e42a43e"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022The following GUID is for the ID of the typelib if this project is exposed to COM\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/My Project/AssemblyInfo.vb"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fd78348be5ddfd0119aa46d23b0d457eb8610d4954d83e6d5661f9c595d52d2"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Version information for an assembly consists of the following four values: Major Version Minor Version Build Number Revision You can specify all the values or y \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModMaster/My Project/AssemblyInfo.vb"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd843ac0e576162b7b1215036985390ff05d6db727603d65f59a740778fe2bdb"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022General Information about an assembly is controlled through the following set of attributes. Change these attribute values to modify the information associated  \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModSlave/My Project/AssemblyInfo.vb"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"20ad6b38ddae61acbd218724da0a2399d914b9088c988b7bcfd0da93746ffc3c"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Review the values of the assembly attributes\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModSlave/My Project/AssemblyInfo.vb"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"85d528917ce8a92ea5aa581c753245638648b2b4132281eabccc3624fb2c77cc"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022The following GUID is for the ID of the typelib if this project is exposed to COM\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModSlave/My Project/AssemblyInfo.vb"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e99f2ccf5032e8e55381d34e4a2df4d564c94689efde35ddb22f42bd47d1e3a"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022Version information for an assembly consists of the following four values: Major Version Minor Version Build Number Revision You can specify all the values or y \u2026\u0022 is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"DemoApps/VB.NET/csModSlave/My Project/AssemblyInfo.vb"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"715fce71b259a80da5d59aa00def88dbdcec80fa656cd10388fe7b852d9b780e"}},{"ruleId":"D34","level":"note","message":{"text":"Dormant codebase: 20 of 20 significant files have no living knowledge \u2014 the codebase as a whole is dormant, not 20 separate risks. Counted over 20 of the 25 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"4c69f1e54b7dd6fe9029dd02df6ba8f8145b789f2f18dbdaa086c40ded49dba6"}},{"ruleId":"D34","level":"note","message":{"text":"Most significant orphaned file: One of the orphaned files carrying the most lost knowledge \u2014 ranked by size weighted by the file\u0027s role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c291bdbd1872d8d8d82e207209d3bd2e142d2dd68e9494229cffeccffb63708"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/ModbusView.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef4886c2545c67ef88c162b46e26bfc9bf62151837d9b5b5a9b6641e74560d87"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMaster.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"722d495a1f1d0f020f1a9e3ff8d49b709d001ee53e447210ca81d2d7071002a7"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/MbGridView.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"51281bec12015b8021499b1c4c18727cf1fef75d07708a649d5d4c6ff9513093"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"eee3eb73c31baee6222c36c39b4debf57abe3e73b7d5856a20a6798ea82146f1"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/SlaveGridView.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d0634df8da23d832d5d5130a454cb7b7506a08e765f312eccaf7fc091876dd8"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/ModbusGridViewCell.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdae5f61b7e2d479300e86512d1eccf7ed54941e1c6d543b3535a7be35018e29"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusView/lib/MasterGridView.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a74e54f954faf3f4a47a718bbc8aa872bdc5470eb79b7bb7c25c83ac4a87b7e"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/SlaveDataServer/MbSlaveData.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f0abd7bc60a8d4a8fd58465faeee3c067d4c1e71c547f058d58c01f3846fed9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbSlaveStateMachine.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"30813e2cad7bd4954c8dfc8ed5f939277ce55ffe669bc143c799a5f7dfea26ad"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/SlaveDataServer/MbSlaveStdServer.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ea7f981d4344ed764abf18769a1347d336f153972cfddd65ff31227a3509887"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbSerial.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dc4481b2cd5b4254e630aade68e806c7c8cf26e83503bacc500e84cd9194124"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMasterEx.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"882fba57a549a097d39aa8f72f7d09031126e42e5540b403879b8c103f8c336e"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/B32Converter.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dd5ec43c8c8c05fb604438de346e9742fbef906031247ff8b7aad2f38f429fc"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbBase.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e080674e15d2d7a352825b17f80cf79361f413be7079dccc15227c7eea8b9c09"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbSlave.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"25a679458c1f8b5def6ee4e96c1d1abd9c2cd1eb60560041c5255a5c6701baf9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthMaster.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e715fb4374cbfe7c5ba130e698001c9ca1b1fdea2098ebf5337835f636a90e45"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbASCII.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"18782b07fde8cbd9da887a97341ba849bf7e58bb5ab82c1789cddd7857f0a9f6"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/SlaveDataServer/MbSlaveDataServer.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d4be95c51e532d5711e0f77e90620c428d702e9b7641ee3d2462a1ac32cd1bc"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbRTU.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d7888cd9f3e0ecf8c5f9ab343136a0c8e5e94a2186540c511b33feaaa87c324"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbSerial.cs"},"region":{"startLine":167}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e222dab8b96b01181da2ed6330d6fee0f6b4585eafa072db172afe9a4fb00b3"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":271}}}],"partialFingerprints":{"codehealthFindingId/v1":"362887a6cc534fd583222a480c32959c724e33d3bf82e439b4ab1459ebff6cec"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbFrame.cs"},"region":{"startLine":344}}}],"partialFingerprints":{"codehealthFindingId/v1":"37bc0452b5dc2ab3f892f9fc91e431c37a8591501d427b05a8ac6c063a180ee9"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMaster.cs"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"741148ddee25c1a37c4ef917e247ba650a98290e783521c11611df581b7da77b"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbMaster.cs"},"region":{"startLine":217}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ff3d0e9689e65ac1abb9e94747cd6c819f114c9ecf184a2744a679f59d51eeb"}},{"ruleId":"IC1","level":"note","message":{"text":"Commented-out code: A line of code has been commented out rather than removed \u2014 dead weight that rots and confuses. Delete it (version control remembers)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Modbus/MbSlaveStateMachine.cs"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ee9e020926fccfc633a2fa0dc66e3b30aef8a31dc293d11566fe521b14c78b2"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"No architecture diagram/doc: No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named \u0060architecture\u0060 or \u0060design\u0060 in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape \u2014 no \u0060## Architecture\u0060 heading, no \u0022architecture overview\u0022/\u0022high-level design\u0022 phrasing, no \u0022the architecture is \u2026\u0022 introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document \u2014 not evidence that nobody wrote the shape down."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0c190e7c159d1850ee706c3ac4486e151e8a4fe169de4bf61436b9f399654f06"}},{"ruleId":"M3","level":"note","message":{"text":"No src/ separation: Production code isn\u0027t grouped under a src/ folder \u2014 it\u0027s spread across several top-level directories, so there\u0027s no one place that says \u0027this is the product\u0027."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"fdf7f5b24e313364d10170a5c2542959902fe0d26ed70edef3eaa10ec5bcdb1d"}},{"ruleId":"M3","level":"note","message":{"text":"Inconsistent root namespaces: Only 1/7 projects share a common root namespace \u2014 the code\u0027s module identity is inconsistent."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"c8031c9fb77ad97c2e4a8ddb29978f4bf30140d481913bd7fde8b5adbbb83ede"}},{"ruleId":"P1","level":"warning","message":{"text":"No CI pipeline: No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, \u2026) \u2014 changes aren\u0027t gated by an automated build/test."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"44f01af96e50474fba2df84d95ddf4f7e1d34c29c307830b9efc9057daa6b670"}},{"ruleId":"P3","level":"note","message":{"text":"No SAST: No static application security testing detected. For this repository\u0027s stack, add CodeQL\u0027s csharp pack, or a .NET security analyzer package (or \u0060semgrep --config=auto\u0060, which runs on any language) \u2014 this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge\u0027s web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen \u2014 if that is your case the row is wrong, and saying so is more useful than adding a second scanner."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6e54424179c892f03ef2fd003130ac4bd43f39bbf3b1ca0a0143e25acb80ec87"}},{"ruleId":"P6","level":"note","message":{"text":"No changelog: No CHANGELOG/HISTORY/RELEASES file \u2014 what shipped when isn\u0027t easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"dda5aa5aed8cbb292c3ef2b733bc138f614293ae6426c85e98bf31ef330d9415"}},{"ruleId":"PF3","level":"warning","message":{"text":"Sync-over-async blocking: 2 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) \u2014 these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one)."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"2dedb76432d7d4f359386b5c37564c0f3de368182a77e31aa8af9ba73f9a4def"}},{"ruleId":"PF3","level":"warning","message":{"text":"Sync-over-async blocking: \u0060smRxDataAvail.Wait()\u0060 blocks this thread until the async work completes \u2014 it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"398e932dde1838f87b5f680685afad06111e76e6b81f4b67de8ea28701d9e98e"}},{"ruleId":"PF3","level":"warning","message":{"text":"Sync-over-async blocking: \u0060smRxProcess.Wait()\u0060 blocks this thread until the async work completes \u2014 it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c83dc78405be721edec6a61932437b9b4a7d51eef4faa93a54b2998e7cfa44e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (System.Exception)\u0060 does nothing with the exception it caught \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthMaster.cs"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"94e9c252251c09fd2d86d57d2bb4cfbce6a551c60432b58920473d70e22e1dd0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (System.Exception)\u0060 does nothing with the exception it caught \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthMaster.cs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ed761c3d31239c6abbbd365e60ed1985e899de72e726908d1ab61bf2cbd9cde"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (System.Exception)\u0060 does nothing with the exception it caught \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"7393fa802a5d891e4b677264881fbde992c8199c768bc5a7984bf6f4794ea9c2"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060Connect\u0060 swallows every exception and sets \u0060IsConnected = false;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthMaster.cs"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a1061398c5d390d68fd124bdae7939c8ec903ca02618d0afb301db7e9c21092"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060Connect\u0060 swallows every exception and sets \u0060IsConnected = false;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthMaster.cs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"183487b16fefb210552908e77b4b18ace817eef19d7f40facf9b96f0711c7014"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060Connect\u0060 swallows every exception and sets \u0060IsConnected = false;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa5ebb66a8e5fb2d8f14e0b0961f8fb3e0ca41d8347fef262cfc3618640dd928"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060Connect\u0060 swallows every exception and sets \u0060IsConnected = false;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"af8e7c71fbe626b24312163f286bb3b95f4505e23203fa57f558b45b9027cf52"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060EndReceive\u0060 swallows every exception and sets \u0060readed = 0;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbEthSlave.cs"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"5676668b6391ece1e2470cf15cff60d5f88e83954a79484166210758a5faec77"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060Connect\u0060 swallows every exception and sets \u0060IsConnected = false;\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let validation throw."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ClassLib/csModbusLib/lib/Interface/MbSerial.cs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd301c716852836ef0e0e2703a1733be70b92c6e11055943543dcaa2d640815e"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":0,"secretScannerRunsExcluded":0}}}]}