Public report of commons-app/apps-android-commons, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 14:12 UTC · Survey ID cd_7f5e5518ff554cb593bed277752fdb44

commons-app/apps-android-commons

Measured 17 November 2026, 14:11 UTC, at code version 53f6f00

First survey, so nothing to compare with yet
CAI score 56.9out of 100 Adequate
CriticalWeakAdequateStrongExemplary

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 71,250 lines of product code in 2 projects, tests not counted · Estimated rebuild effort: about 0.8 person-years · Weakest lens: Production Readiness, 48.5

Findings by how serious they are

23 critical 239 serious 90 minor

14 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 14:11 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

52of 52 dimensions measured by tools.
340of 352 findings point to an exact file and line, so you can open each one in the code. The other 12 concern the repository as a whole, such as missing documentation.
52dimensions across 6 lenses, read from 71,250 lines of product code in 2 projects.
Chapters

Executive summary

commons-app/apps-android-commons falls short of our standard for production, in part because we found no automated security scanning of the code, its secrets or its dependencies. It scores 56.9 out of 100 and is rated Adequate, and 22 of its 23 critical findings are security problems in the build pipeline.

Production Readiness, at 48.5, is the weakest lens and counts most in the score. The best first step is recording design decisions, worth about 6.3 points. Adding automated security scanning would lift Production Readiness itself, also worth about 6.3. Raising Production Readiness to 70 would lift the score to about 63.0.

Nineteen pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Three secrets can leak from the build pipeline, and one part of the code is no longer understood by anyone working on it. Pinning each tool to an exact version, limiting each secret to its own step and having someone learn the forgotten files would close these risks.

The product code is 71,250 lines, about €110,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 48.5 · counts for 46%Maturity 51.1 · counts for 25%Code Health 70.4 · counts for 14%Security and Compliance 75.7 · counts for 8%Architecture 82.3 · counts for 4%Performance 100.0 · counts for 2%

If Production Readiness rose from 48.5 to 70, the lowest score rated Strong, the score would rise from 56.9 to about 63.0.

Code composition: what the lines of code are
Product code 66%Tests 34%
Rebuild cost: about €110,000 · Estimate
Cost to rebuild€37,000 to €180,000, for 612 to 1,943 hours of work, about 0.8 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 57. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 71,250 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.
Raises the score by about 6.3 points · Low effort · ADR Quality
2
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 6.3 points · Medium effort · Security & performance tooling
3
Record your significant design decisions.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Raises the score by about 6.2 points · Medium effort · Architecture documentation

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €110,000 to build again, about 0.8 person-years of work. Its weakest lens is Production Readiness, at 48.5 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 6.3 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

331 modules, with 738 dependencies between them. 5 loops run through 109 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 291 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 customselector.model2 filepicker3 kvstore4 location5 explore.paging.PagingContract6 profile.leaderboard7 wikidata.model8 explore.paging9 wikidata.mwapi10 auth.csrf11 explore.media12 actions13 wikidata14 upload.structure.depictions15 repository16 upload.categories17 upload.mediaDetails18 notification19 upload.depicts20 upload21 utils22 theme23 description24 explore.depictions25 review26 mwapi27 nearby28 nearby.fragments29 bookmarks.locations30 explore.map31 explore32 contributions33 customselector.ui.selector34 media35 category36 bookmarks37 db38 di39 auth40 fr.free.nrw.commons
1 customselector.model
2 filepicker
3 kvstore
4 location
5 explore.paging.PagingContract11
6 profile.leaderboard515
7 wikidata.model1
8 explore.paging51
9 wikidata.mwapi6
10 auth.csrf21
11 explore.media1151216
12 actions122
13 wikidata143131
14 upload.structure.depictions111111
15 repository13715244
16 upload.categories31714
17 upload.mediaDetails264319
18 notification11111
19 upload.depicts12311611121113
20 upload581021222132231721342
21 utils11921213
22 theme111
23 description113112
24 explore.depictions116111213
25 review2212124
26 mwapi122111
27 nearby1511121222
28 nearby.fragments24111222311
29 bookmarks.locations21
30 explore.map314112217
31 explore12114226
32 contributions257311231141181258
33 customselector.ui.selector761232
34 media221410213121132242413
35 category2111111216
36 bookmarks112121
37 db111111211
38 di2111313311248112531121444832163
39 auth3121
40 fr.free.nrw.commons122211
Uses a module listed above itPart of a loopThe module itself
1 customselector.model2 filepicker3 kvstore4 location5 explore.paging.PagingContract6 profile.leaderboard7 wikidata.model8 explore.paging9 wikidata.mwapi10 auth.csrf11 explore.media12 actions13 wikidata14 upload.structure.depictions15 repository16 upload.categories17 upload.mediaDetails18 notification19 upload.depicts20 upload21 utils22 theme23 description24 explore.depictions25 review26 mwapi27 nearby28 nearby.fragments29 bookmarks.locations30 explore.map31 explore32 contributions33 customselector.ui.selector34 media35 category36 bookmarks37 db38 di39 auth40 fr.free.nrw.commonscustomselector.model1filepicker2kvstore3location4explore.paging.PagingContract5profile.leaderboard6wikidata.model7explore.paging8wikidata.mwapi9auth.csrf10explore.media11actions12wikidata13upload.structure.depictions14repository15upload.categories16upload.mediaDetails17notification18upload.depicts19upload20utils21theme22description23explore.depictions24review25mwapi26nearby27nearby.fragments28bookmarks.locations29explore.map30explore31contributions32customselector.ui.selector33media34category35bookmarks36db37di38auth39fr.free.nrw.commons40115151516211151216122143131111111137152443171426431911111123116111211135810212221322317213421192121311111311211611121322121241221111511121222241112223112131411221712114226257311231141181258761232221410213121132242413211111121611212111111121121113133112481125311214448321633121122211+291 more modules (most-connected shown)

At a glance — Code Health · 70.4 · Strong ·

At a glance — Architecture · 82.3 · Strong ·

At a glance — Maturity · 51.1 · Adequate · gated by M2 ·

At a glance — Readiness · 48.5 · Weak · gated by P3, P7 ·

At a glance — Security · 75.7 · Adequate · gated by D36 ·

At a glance — Performance · 100.0 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection24High / Critical
A03:2025 — Software Supply Chain Failures6Medium

Roadmap

Top priorities: Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing; Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts; Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.+6.3 ptsLowADR Quality
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+6.3 ptsMediumSecurity & performance tooling
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+6.2 ptsMediumArchitecture documentation
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).+4.2 ptsMediumOutbound HTTP resilience
Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with SettingsFragment.kt.+1.7 ptsLowKnowledge Freshness
Resolve the 2 `defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` finding(s) in Naming Consistency — start with ContributionsLocalDataSource.kt, MediaLicensePresenter.kt.+1.4 ptsLowNaming Consistency
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.+2.7 ptsMediumDocumentation (README)
Resolve the 1 `getAPILevel` spells `API` where 19 names in the project spell it `Api` finding(s) in Naming Consistency — start with DeviceInfoUtil.kt.+0.7 ptsLowNaming Consistency

File quality

Per-file score 0–10 — a quality signature. Of 117 files carrying findings, judged against the Production bar: 2% slop · 43% mixed · 55% near-clean.

FileScoreBandWorst signal
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt5.6MixedCognitive Complexity: UploadMediaDetailAdapter.updateAddButtonVisibility (cognitive 30)
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt6.4MixedExplicit Debt: TodoComment
app/src/main/java/fr/free/nrw/commons/auth/login/LoginClient.kt6.7MixedExplicit Debt: TodoComment
app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryResult.kt6.7MixedExplicit Debt: TodoComment
app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt6.7MixedExplicit Debt: TodoComment
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt7.0MixedCyclomatic Complexity: NearbyParentFragment.filterMarkersByLabels (cyclomatic 21)
app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt7.0MixedCognitive Complexity: OkHttpJsonApiClient.getNearbyPlaces (cognitive 23)
app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt7.1MixedCyclomatic Complexity: ImageLoader.queryAndSetView (cyclomatic 31)
app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt7.1MixedCyclomatic Complexity: BlurOverlayView.onTouchEvent (cyclomatic 26)
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt7.1MixedCognitive Complexity: MediaDetailFragmentKt.FileUsagesContainer (cognitive 18)
app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt7.1MixedGod Classes: ClassTooLong: ZoomableActivity
app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt7.1MixedCode Duplication: Edited copy of a member (18 corresponding lines)
app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt7.2MixedCyclomatic Complexity: MediaDetailPagerFragment.onOptionsItemSelected (cyclomatic 17)
app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java7.2MixedCognitive Complexity: NearbyController.loadAttractionsFromLocation (cognitive 29)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 23

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 239

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 90

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 14

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 52 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 52 dimensions across the health lenses
D1D2D3D4D5D6D13D14D15D16D17D19D20D21D28D29D34D35D36D37D44AX10AX2AX3AX4AX6M1M2M3P1P2P3P6P7PF3X1X12X16X18X19X2X20X21X23X25X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 340 of 352 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1e9d9-73a0-7bf0-be8e-f5e1675655c9.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 3 Maven/Gradle manifest(s) were read, stating a version for 96 dependency(ies) and leaving 11 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D26 Project Cohesion — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app` (71250 LoC, 1368 module-visible types across 100 directories) is over its size bounds, and whether one unit is a coherent whole or a grab-bag is read from its type references: the parts of it that reach the rest only through its shared core. Those are read over the C#/VB code model, which this unit's source did not supply. Its size alone is no verdict on its cohesion, so none is published.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt`, `app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsViewModel.kt`, `app/src/main/java/fr/free/nrw/commons/contributions/WikipediaInstructionsDialogFragment.kt`, `app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt`, `app/src/main/java/fr/free/nrw/commons/kvstore/BasicKvStore.kt`, … (+12 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (app). the Android app did not build — `./gradlew :app:assembleDebug` exited 1: FAILURE: Build failed with an exception. * Where: Build file 'app/build.gradle.kts' line: 551 * What went wrong: /tmp/codehealth-iso-44e865ad41f1…; runtime evidence skipped (launch chosen because app/build.gradle.kts applies the Android application plugin and gradlew builds it).
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity8.8 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

6 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ImageLoader.queryAndSetView at 31.

ImageLoader.queryAndSetView (cyclomatic 31)app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:73
BlurOverlayView.onTouchEvent (cyclomatic 26)app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311
NearbyParentFragment.filterMarkersByLabels (cyclomatic 21)app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:2353
MediaDetailPagerFragment.onOptionsItemSelected (cyclomatic 17)app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:180
NearbyParentFragment.onViewCreated (cyclomatic 17)app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 6 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with ImageLoader.queryAndSetView (cyclomatic 31), BlurOverlayView.onTouchEvent (cyclomatic 26), NearbyParentFragment.filterMarkersByLabels (cyclomatic 21). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cyclomatic Complexity from 8.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.8 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.8 / 10 · rule-coverage 100% · ceiling Prevented

29 method(s) exceeded the cognitive complexity threshold of 15; the worst was ImageLoader.queryAndSetView at 46.

NearbyController.loadAttractionsFromLocation (cognitive 29) · ×2app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:50
ImageLoader.queryAndSetView (cognitive 46)app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:73
BlurOverlayView.onTouchEvent (cognitive 44)app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311
UploadProgressActivity.updateMenuItems (cognitive 38)app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:109
MediaDetailPagerFragment.onCreateOptionsMenu (cognitive 37)app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:327

+ 23 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 29 bodies over 15 down to 15 or less in Cognitive Complexity — start with ImageLoader.queryAndSetView (cognitive 46), BlurOverlayView.onTouchEvent (cognitive 44), UploadProgressActivity.updateMenuItems (cognitive 38). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 29 together lifts Cognitive Complexity from 6.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.9 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Prevented

23 god class(es) detected.

MethodTooLong: NearbyParentFragment.onViewCreated · ×10app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462
TooManyMethods: NearbyParentFragment · ×8app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:155
ClassTooLong: NearbyParentFragment · ×3app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:155
FileTooLong: fragments/NearbyParentFragment.kt · ×2app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt

What to do

  1. Resolve the 10 MethodTooLong finding(s) in God Classes — start with NearbyParentFragment.kt (2), MediaDetailFragment.kt (2), BlurOverlayView.kt. — One of this dimension's main actionable groups (10 warning-level).
  2. Resolve the 8 TooManyMethods finding(s) in God Classes — start with NearbyParentFragment.kt, DefaultZoomableController.kt, FragmentBuilderModule.kt. — One of this dimension's main actionable groups (8 warning-level).
  3. Resolve the 3 ClassTooLong finding(s) in God Classes — start with NearbyParentFragment.kt, ZoomableActivity.kt, UploadMediaDetailAdapter.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication7.9 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.9 / 10 · rule-coverage 100% · ceiling Verified

48 duplicated block group(s) detected. 5.3 % of the production lines (3,744 of 71,250) are in a reported copy. A further 66 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Edited copy of a member (14 corresponding lines) · ×5app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:122
Duplicated block (5 lines × 2) · ×5app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictsClient.kt:115
Edited copy of a member (11 corresponding lines) · ×4app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32
Edited copy of a member (22 corresponding lines) · ×4app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:438
Edited copy of a member (18 corresponding lines) · ×3app/src/main/java/fr/free/nrw/commons/media/MediaDetailCategories.kt:133

+ 65 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 5 Edited copy of a member (14 corresponding lines) finding(s) in Code Duplication — start with RandomAccessFileExifWriter.kt, MediaResponseMapper.kt, MwQueryResult.kt. — One of this dimension's main actionable groups (5 warning-level).
  2. Resolve the 5 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with DepictsClient.kt, MediaResponseMapper.kt, FailedUploadsAdapter.kt. — One of this dimension's main actionable groups (5 warning-level).
  3. Resolve the 4 Edited copy of a member (11 corresponding lines) finding(s) in Code Duplication — start with GestureTransform.kt, MediaDetailImage.kt, Place.java. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

2 production modules (Gradle), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 0 module(s) off the main sequence, with abstractness counted on 1 of the 2 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)9.9 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

2 of 238 classes have LCOM4 above 3.

Low cohesion: MediaDetailMenuHandler (LCOM4 4) · ×2app/src/main/java/fr/free/nrw/commons/media/MediaDetailMenuHandler.kt:29

What to do

  1. Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with MediaDetailMenuHandler.kt, UploadMediaDetailAdapter.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 56 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 3 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 11 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 40 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Stronggated by 20 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt (22×17=374); app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt (7×17=119); app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt (3×26=78) Repeated repair below the complexity floor: app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt (10 of 17 changes were fixes); app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt (7 of 9 changes were fixes); app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt (6 of 8 changes were fixes)

Repeated repair: app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt · ×17app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:595
Hotspot: app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt · ×3app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462

What to do

  1. Resolve the 17 Repeated repair finding(s) in Churn × Complexity Hotspots — start with MediaDetailFragment.kt, LoginActivity.kt, FilePicker.kt. — One of this dimension's main actionable groups (17 warning-level).
  2. Resolve the 3 Hotspot finding(s) in Churn × Complexity Hotspots — start with NearbyParentFragment.kt, MediaDetailPagerFragment.kt, BlurOverlayView.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor9.7 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

10 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is app/src/main/java/fr/free/nrw/commons/repository/UploadRepository.kt. Counted over 339 of the 691 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Off-boarding risk: anonymized user #1
Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.9 / 10Stronggated by 23 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

23 deducted task-comment markers across 71250 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×20app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt:137
FixmeComment · ×3app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.kt:153

What to do

  1. Resolve the 20 TodoComment finding(s) in Explicit Debt — start with PageTitle.kt (3), CommonsApplication.kt (2), ContributionsFragment.kt (2). — One of this dimension's main actionable groups (20 warning-level).
  2. Resolve the 3 FixmeComment finding(s) in Explicit Debt — start with SearchActivity.kt (2), RecentSearchesDao.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 2 document(s) read across 2 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundapp/build.gradle.kts:5

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency5.8 / 10Adequate✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 5.8 / 10 · rule-coverage 100% · ceiling Verified

5 naming inconsistencies among 119 declarations measured against a convention their peers follow.

`defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` · ×2app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt:16
`getMediaFromImageURL` spells `URL` where 54 names in the project spell it `Url`app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapMarkerOverlayHelper.kt:321
`getAPILevel` spells `API` where 19 names in the project spell it `Api`app/src/main/java/fr/free/nrw/commons/utils/DeviceInfoUtil.kt:62
`decodeURL` spells `URL` where 54 names in the project spell it `Url`app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt:138

What to do

  1. Resolve the 2 `defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` finding(s) in Naming Consistency — start with ContributionsLocalDataSource.kt, MediaLicensePresenter.kt. — One of this dimension's main actionable groups (2 recommendation-level).
  2. Resolve the 1 `getMediaFromImageURL` spells `URL` where 54 names in the project spell… finding(s) in Naming Consistency — start with ExploreMapMarkerOverlayHelper.kt. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 `getAPILevel` spells `API` where 19 names in the project spell it `Api` finding(s) in Naming Consistency — start with DeviceInfoUtil.kt. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)5.4 / 10Adequate✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 5.4 / 10 · rule-coverage 100% · ceiling Documented

24 finding(s): 0 critical, 22 high, 2 medium, 0 low. 19 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 1 file(s) — `gradlew` (lines 144–145, line 146, line 147, …) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 2 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 19 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (19 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness8.3 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 8.3 / 10 · rule-coverage 100% · ceiling Documented

56 of 339 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt. Counted over 339 of the 691 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledgeapp/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:1
Orphaned file · ×55app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:1
Further orphaned files (smaller)

What to do

  1. Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with SettingsFragment.kt. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 55 Orphaned file finding(s) in Knowledge Freshness — start with ImageLoader.kt, NearbyController.java, DepictsPresenter.kt. — One of this dimension's main actionable groups (55 recommendation-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 96 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons4.8 / 10Weak✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `SessionManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (password, _currentAccount; e.g. `password` in `updateAccount` at line 52). — app/src/main/java/fr/free/nrw/commons/auth/SessionManager.kt:21
  • `BookmarkPicturesController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (currentBookmarks; e.g. `currentBookmarks` in `loadBookmarkedPictures` at line 24). — app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesController.kt:12
  • `CampaignsPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, disposable, campaign; e.g. `view` in `onAttachView` at line 36). — app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.kt:25
  • `ContributionController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (locationPermissionCallback, locationPermissionsHelper, locationBeforeImageCapture, isInAppCameraUpload, isInternalUploadInProgress; e.g. `locationPermissionCallback` in `createDialogsAndHandleLocationPermissions` at line 120). — app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.kt:44
  • `DeleteHelper` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (d; e.g. `d` in `askReasonAndExecute` at line 213). — app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt:41
  • `QuizChecker` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (totalUploadCount, isUploadCountFetched, revertCount, isRevertCountFetched; e.g. `totalUploadCount` in `setTotalUploadCount` at line 80). — app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt:27
  • `ReviewController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (media; e.g. `media` in `onImageRefreshed` at line 64). — app/src/main/java/fr/free/nrw/commons/review/ReviewController.kt:29
  • `UploadModel` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (items, selectedCategories, selectedDepictions, selectedExistingDepictions; e.g. `items` in `cleanUp` at line 65). — app/src/main/java/fr/free/nrw/commons/upload/UploadModel.kt:24
  • `UploadPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (basicKvStoreFactory, view; e.g. `basicKvStoreFactory` in `setupBasicKvStoreFactory` at line 149). — app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.kt:26
  • `CategoriesPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, media; e.g. `view` in `onAttachView` at line 58). — app/src/main/java/fr/free/nrw/commons/upload/categories/CategoriesPresenter.kt:29
  • `DepictsPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, media; e.g. `view` in `onAttachView` at line 62). — app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:33
  • `NearbyPlaces` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (radius; e.g. `radius` in `radiusExpander` at line 59). — app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java:26

What to do

  • Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `View` declares 45 abstract methods: `addCurrentLocationMarker`, `animateFABs`, `askForLocationPermission`, `centerMapToPlace`, `clearAllMarkers`, `disableFABRecenter`, `displayLoginSkippedWarning`, `enableFABRecenter`, `filterMarkersByLabels`, `filterOutAllMarkers`, `getCameraTarget`, `getContext`, `getLastLocation`, `getLastMapFocus`, `getMapCenter`, `getMapFocus`, `getScreenBottomLeft`, `getScreenTopRight`, `hideBottomDetailsSheet`, `hideBottomSheet`, `hideNearbyFilterList`, `isAdvancedQueryFragmentVisible`, `isDetailsBottomSheetVisible`, `isListBottomSheetExpanded`, `isNearbyFilterListVisible`, `isNetworkConnectionEstablished`, `listOptionMenuItemClicked`, `openLocationSettings`, `populatePlaces`, `populatePlaces`, `recenterMap`, `replaceMarkerOverlays`, `setBottomSheetDetailsSmaller`, `setCheckBoxAction`, `setCheckBoxState`, `setFABPlusAction`, `setFABRecenterAction`, `setFilterState`, `setProgressBarVisibility`, `setRecyclerViewAdapterAllSelected`, and 5 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 45 declarations carry 44 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 44 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app/src/main/java/fr/free/nrw/commons/nearby/contract/NearbyParentFragmentContract.java:17
  • `ActivityBuilderModule` declares 22 abstract methods: `bindLoginActivity`, `bindWelcomeActivity`, `bindContributionsActivity`, `bindCustomSelectorActivity`, `bindSettingsActivity`, `bindAboutActivity`, `bindLocationPickerActivity`, `bindSignupActivity`, `bindNotificationActivity`, `bindUploadActivity`, `bindDepictsPickerActivity`, `bindSearchActivity`, `bindCategoryDetailsActivity`, `bindDepictionDetailsActivity`, `bindAchievementsActivity`, `bindReviewActivity`, `bindDescriptionEditActivity`, `bindZoomableActivity`, `bindUploadProgressActivity`, `bindWikiFeedback`, `bindEditActivity`, `bindDeletedFileActivity`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.kt:37
  • `FragmentBuilderModule` declares 39 abstract methods: `bindContributionsListFragment`, `bindMediaDetailFragment`, `bindFolderFragment`, `bindImageFragment`, `bindMediaDetailPagerFragment`, `bindSettingsFragment`, `bindDepictedImagesFragment`, `bindBrowseImagesListFragment`, `bindSearchCategoryListFragment`, `bindSearchDepictionListFragment`, `bindRecentSearchesFragment`, `bindContributionsFragment`, `bindNearbyParentFragment`, `bindBookmarkPictureListFragment`, `bindBookmarkLocationListFragment`, `bindBookmarkItemListFragment`, `bindBookmarkCategoriesListFragment`, `bindReviewOutOfContextFragment`, `bindUploadMediaDetailFragment`, `bindUploadCategoriesFragment`, `bindDepictsFragment`, `bindMediaLicenseFragment`, `bindParentDepictionsFragment`, `bindChildDepictionsFragment`, `bindCategoriesMediaFragment`, `bindSubCategoriesFragment`, `bindParentCategoriesFragment`, `bindExploreFragmentFragment`, `bindExploreFeaturedRootFragment`, `bindExploreNearbyUploadsFragment`, `bindExploreNearbyUploadsRootFragment`, `bindBookmarkListRootFragment`, `bindBookmarkFragmentFragment`, `bindMoreBottomSheetFragment`, `bindMoreBottomSheetLoggedOutFragment`, `bindAchievementsFragment`, `bindLeaderboardFragment`, `bindPendingUploadsFragment`, `bindFailedUploadsFragment`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt:54
  • `ZoomableController` declares 16 abstract methods: `setEnabled`, `isEnabled`, `setListener`, `getScaleFactor`, `isIdentity`, `wasTransformCorrected`, `computeHorizontalScrollRange`, `computeHorizontalScrollOffset`, `computeHorizontalScrollExtent`, `computeVerticalScrollRange`, `computeVerticalScrollOffset`, `computeVerticalScrollExtent`, `getTransform`, `setImageBounds`, `setViewBounds`, `onTouchEvent`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableController.kt:11

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 9 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:3
  • `app/build.gradle.kts` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — app/build.gradle.kts:359

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:373

What to do

  • Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/2 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
  • `getFileUsagesOnCommons` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:87
  • `getGlobalFileUsages` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:123

What to do

  • Thread the coroutine's cancellation through suspend functions that make requests, so the work stops when its caller gives up.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.8 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch (ignored: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFileLoader.kt:167

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

X5 · Nullable reference types7.0 / 10Strong✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • ~18.5 `!!` not-null assertions per 1k Kotlin product lines — 1435 across the 77547 line(s) of the 672 Kotlin file(s) read (generated, test and sample code not counted). Densest: app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt (298), app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.kt (45), app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.kt (43). Each one tells the compiler to trust the author about null and becomes a `NullPointerException` the first time the author is wrong. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.

What to do

  • Replace `!!` rather than adding to it: each is a run-time null check the compiler could not prove. Narrow the value with a null check, an early return or `?: return`, use `?.` / `?:` where absence is legitimate, `requireNotNull(x) { "why" }` / `checkNotNull` where a missing value is a contract breach worth a message, make the property non-nullable and set it in the constructor (or `by lazy`) instead of `lateinit` plus `!!`, or change the API so the null cannot arrive.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health70.4StrongSolid.
Architecture82.3StrongSolid.
Maturity51.1Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness48.5Weak — gated by P3, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security75.7Adequate — gated by D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100.0ExemplaryStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • X10 Duplicated predicate — 13 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 60 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — Not applicable: Dagger rejects, at compile time, a component that holds a binding with a narrower scope than its own.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Android app did not build — `./gradlew :app:assembleDebug` exited 1: FAILURE: Build failed with an exception. * Where: Build file 'app/build.gradle.kts' line: 551 * What went wrong: /tmp/codehealth-iso-44e865ad41f1…; runtime evidence skipped (launch chosen because app/build.gradle.kts applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~36561 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D12 Dependency Hygiene — Not scored — 3 Maven/Gradle manifest(s) were read, stating a version for 96 dependency(ies) and leaving 11 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D26 Project Cohesion — D26 could not read how the parts of this repository's one build unit reference each other, so its cohesion was not measured. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 17 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 96 value object(s); 3 repository port(s) loading or saving an aggregate/entity
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • M4 Documentation accuracy — Not applicable: the 2 current-state document(s) make no claim of a kind M4 checks. 5 claim(s) of kinds M4 does not check were not checked (path 3, environment variable 2); M4 checks only links and versions and artefact counts.
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — X24 reached only 3% of this repository's production lines — kotlin (69,034 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 23 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D34 · Knowledge Freshness · Orphaned knowledge · ×1
  • Orphaned knowledge app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Serious — 239 finding(s)
D17 · Explicit Debt · TodoComment · ×20
  • TodoComment app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt:137 — // TODO: Remove when we're able to initialize Fresco in test builds. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt:257 — // TODO: fix preference manager — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/Media.kt:216 — // TODO added categories should be removed. It is added for a short fix. On category update, — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryPage.kt:54 — // TODO: Handle null values in lists during deserialization, perhaps with a new — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryResult.kt:66 — // TODO: Looks like result pages and redirects can also be matched on the "index" — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/model/WikiSite.kt:51 — // TODO: remove @SerializedName. this is now in the TypeAdapter and a "uri" case may be added — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt:59 — // TODO: remove after the restbase endpoint supports ZH variants. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt:194 — // TODO: find a better way to check if the namespace is a ISO Alpha2 Code (two digits country code) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt:304 — // TODO: this class needs some refactoring to allow passing in a fragment — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/utils/ConfigUtils.kt:8 — // TODO - this can be constructed in a Dagger provider method, in a module and injected. No need — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/utils/NetworkUtils.kt:50 — // TODO for Android 12+ request permission from user is mandatory — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/review/ReviewController.kt:51 — // TODO: maybe we can expand this class to include fileName — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt:135 — // TODO Create a Method to Hide all the Statistics — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsStatsBinder.kt:137 — // binding.achievementBadgeImage.visibility = View.INVISIBLE // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/feedback/FeedbackDialog.kt:46 — // TODO("DEPRECATION") Issue : #6002
  • TodoComment app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/FolderFragment.kt:76 — // todo change column count depending on the orientation of the device. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt:160 — // todo change span count depending on the device orientation and other factos. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.kt:293 — // TODO: Improve UX. Additional details: https://github.com/commons-app/apps-android-commons/pull/5257#discussion_r1304662562
  • TodoComment app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.kt:306 — // TODO: Show the exact reason for failure — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/src/main/java/fr/free/nrw/commons/auth/login/LoginClient.kt:322 — // TODO: Find a better way to boil up the warning about 2FA — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D15 · Churn × Complexity Hotspots · Repeated repair · ×17
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:595 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt changed 17 times in last 90 days and 10 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 15 (its worst body is MediaDetailFragmentKt.FileUsagesContainer at line 595), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: hide loading spinner on intermediate image set (#7250) (#7330)”; “Fix self upload media by using uploader instead of author (#6870)”; “fix : leaks at Media Detail Fragment (#6705)”; “fix: Show media details and a loading spinner while the image loads (#7011)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt:119 — app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt changed 9 times in last 90 days and 7 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is LoginActivity.renderLoginState at line 119), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: narrow TooGenericExceptionCaught for multiple components (#7307)”; “fix: prevent login crash after rotation during failed login (#7233)”; “fix: preserve login focus on locale change (#6974)”; “Fix/7167 login unknown error (#7190)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt:69 — app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt changed 8 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is FilePicker.onPictureReturnedFromDocuments at line 69), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Split FilePicker and PickedFiles to fix Detekt TooManyFunctions (#7262)”; “Fix Detekt miscellaneous code smells (#7210)”; “Fix Detekt UnusedPrivateProperty findings and remove from baseline (#7200)”; “Fixes Nested Depth block static analysis errors from ImageFileLoader, ImageFragment, FilePicker (#7206)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt:188 — app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt changed 7 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is DescriptionEditActivity.editDescription at line 188), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix: multi-language captions not saved on upload (#6938) (#6946)”; “Fix Detekt Empty findings (#7178)”; “fix: open the description editor for Nearby uploads (#7025)”; “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt:259 — app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is ImageFragment.onViewCreated at line 259), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: narrow TooGenericExceptionCaught catches (#7321)”; “Fix Detekt miscellaneous code smells (#7210)”; “Fixes Nested Depth block static analysis errors from ImageFileLoader, ImageFragment, FilePicker (#7206)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt:174 — app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is PendingUploadsPresenter.restartUploads at line 174), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix #7126: Remove unused functions from ContributionsRepository and ContributionsLocalDataSource (#7236)”; “Fix Detekt Empty findings (#7178)”; “fix: retry every failed upload, not only the ones loaded in the list (#7196)”; “Fix Detekt miscellaneous code smells (#7210)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt:213 — app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is DeleteHelper.askReasonAndExecute at line 213), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix Detekt Empty findings (#7178)”; “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”; “Fix Detekt UnusedPrivateProperty findings and remove from baseline (#7200)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/utils/CustomSelectorUtils.kt app/src/main/java/fr/free/nrw/commons/utils/CustomSelectorUtils.kt:81 — app/src/main/java/fr/free/nrw/commons/utils/CustomSelectorUtils.kt changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is CustomSelectorUtils.checkWhetherFileExistsOnCommonsUsingSHA1 at line 81), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: narrow TooGenericExceptionCaught for multiple components (#7307)”; “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”; “Fix Detekt miscellaneous code smells (#7210)”; “detekt: fix function parameter naming violations (#7174)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/utils/CustomSelectorUtils.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableDraweeView.kt app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableDraweeView.kt:231 — app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableDraweeView.kt changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is ZoomableDraweeView.onTouchEvent at line 231), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: narrow TooGenericExceptionCaught catches (#7321)”; “Fix Detekt Empty findings (#7178)”; “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableDraweeView.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt:50 — app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is MoreBottomSheetFragment.onCreateView at line 50), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: narrow TooGenericExceptionCaught for multiple components (#7307)”; “Fix Detekt UnusedPrivateMember, UnusedParameter and UnusedPrivateClass findings (#7049) (#7103)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt:92 — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is ContributionsLocalDataSource.saveContributions at line 92), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix #7126: Remove unused functions from ContributionsRepository and ContributionsLocalDataSource (#7236)”; “fix: retry every failed upload, not only the ones loaded in the list (#7196)”; “fix: explain a deleted contribution instead of opening a blank page (#7097)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/contributions/ContributionsRepository.kt app/src/main/java/fr/free/nrw/commons/contributions/ContributionsRepository.kt:22 — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsRepository.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is ContributionsRepository.deleteContributionFromDB at line 22), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix #7126: Remove unused functions from ContributionsRepository and ContributionsLocalDataSource (#7236)”; “fix: retry every failed upload, not only the ones loaded in the list (#7196)”; “fix: explain a deleted contribution instead of opening a blank page (#7097)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/contributions/ContributionsRepository.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListPresenter.kt app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListPresenter.kt:37 — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListPresenter.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is ContributionsListPresenter.setup at line 37), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix Detekt Empty findings (#7178)”; “Fix Detekt UnusedPrivateProperty findings and remove from baseline (#7200)”; “fix: explain a deleted contribution instead of opening a blank page (#7097)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListPresenter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/utils/DownloadReceiver.kt app/src/main/java/fr/free/nrw/commons/utils/DownloadReceiver.kt:31 — app/src/main/java/fr/free/nrw/commons/utils/DownloadReceiver.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is DownloadReceiver.getFailedDownload at line 31), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix Detekt Empty findings (#7178)”; “Fixes Nested Depth block static analysis errors from ImageFileLoader, ImageFragment, FilePicker (#7206)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/utils/DownloadReceiver.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/notification/NotificationClient.kt app/src/main/java/fr/free/nrw/commons/notification/NotificationClient.kt:52 — app/src/main/java/fr/free/nrw/commons/notification/NotificationClient.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is NotificationClient.markNotificationAsRead at line 52), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: use Echo's unread count for the notification badge (#7187)”; “fix: pass source wiki to echomarkread so cross-wiki notifications clear (#6896)”; “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/notification/NotificationClient.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:241 — app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is RandomAccessFileExifWriter.scanAndUpdateIfd at line 241), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “ fix: compile error from reserved _ loop variables (since #7200) (#7212)”; “Fix Detekt UnusedPrivateProperty findings and remove from baseline (#7200)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:106 — app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is MoreBottomSheetLoggedOutFragment.sendFeedback at line 106), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix Detekt exception-handling smells and remove 38 baseline entries (#7216)”; “Fix Detekt UnusedPrivateMember, UnusedParameter and UnusedPrivateClass findings (#7049) (#7103)”; “Fix Detekt NewLineAtEndOfFile findings (#7067)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
AX2 · Stateful singletons · Stateful singleton · ×12
  • Stateful singleton: SessionManager app/src/main/java/fr/free/nrw/commons/auth/SessionManager.kt:21 — `SessionManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (password, _currentAccount; e.g. `password` in `updateAccount` at line 52).
  • Stateful singleton: BookmarkPicturesController app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesController.kt:12 — `BookmarkPicturesController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (currentBookmarks; e.g. `currentBookmarks` in `loadBookmarkedPictures` at line 24).
  • Stateful singleton: CampaignsPresenter app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.kt:25 — `CampaignsPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, disposable, campaign; e.g. `view` in `onAttachView` at line 36).
  • Stateful singleton: ContributionController app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.kt:44 — `ContributionController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (locationPermissionCallback, locationPermissionsHelper, locationBeforeImageCapture, isInAppCameraUpload, isInternalUploadInProgress; e.g. `locationPermissionCallback` in `createDialogsAndHandleLocationPermissions` at line 120).
  • Stateful singleton: DeleteHelper app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt:41 — `DeleteHelper` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (d; e.g. `d` in `askReasonAndExecute` at line 213).
  • Stateful singleton: QuizChecker app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt:27 — `QuizChecker` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (totalUploadCount, isUploadCountFetched, revertCount, isRevertCountFetched; e.g. `totalUploadCount` in `setTotalUploadCount` at line 80).
  • Stateful singleton: ReviewController app/src/main/java/fr/free/nrw/commons/review/ReviewController.kt:29 — `ReviewController` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (media; e.g. `media` in `onImageRefreshed` at line 64).
  • Stateful singleton: UploadModel app/src/main/java/fr/free/nrw/commons/upload/UploadModel.kt:24 — `UploadModel` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (items, selectedCategories, selectedDepictions, selectedExistingDepictions; e.g. `items` in `cleanUp` at line 65).
  • Stateful singleton: UploadPresenter app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.kt:26 — `UploadPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (basicKvStoreFactory, view; e.g. `basicKvStoreFactory` in `setupBasicKvStoreFactory` at line 149).
  • Stateful singleton: CategoriesPresenter app/src/main/java/fr/free/nrw/commons/upload/categories/CategoriesPresenter.kt:29 — `CategoriesPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, media; e.g. `view` in `onAttachView` at line 58).
  • Stateful singleton: DepictsPresenter app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:33 — `DepictsPresenter` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (view, media; e.g. `view` in `onAttachView` at line 62).
  • Stateful singleton: NearbyPlaces app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java:26 — `NearbyPlaces` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (radius; e.g. `radius` in `radiusExpander` at line 59).
D3 · God Classes · MethodTooLong · ×10
  • MethodTooLong: NearbyParentFragment.onViewCreated app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462 — MethodTooLong — onViewCreated runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: NearbyParentFragment.passInfoToSheet app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:2716 — MethodTooLong — passInfoToSheet runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BlurOverlayView.onTouchEvent app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311 — MethodTooLong — onTouchEvent runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MediaDetailFragment.onCreateView app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:231 — MethodTooLong — onCreateView runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ViewHolder.initLanguage app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:315 — MethodTooLong — initLanguage runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UploadWorker.uploadContribution app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt:263 — MethodTooLong — uploadContribution runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MediaDetailFragmentKt.FileUsagesContainer app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:595 — MethodTooLong — FileUsagesContainer runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MediaDetailPagerFragment.onCreateOptionsMenu app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:327 — MethodTooLong — onCreateOptionsMenu runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SettingsFragment.onCreatePreferences app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:110 — MethodTooLong — onCreatePreferences runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ImageLoader.queryAndSetView app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:73 — MethodTooLong — queryAndSetView runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D3 · God Classes · TooManyMethods · ×8
  • TooManyMethods: NearbyParentFragment app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:155 — TooManyMethods — 133 methods. The bar is 30 methods; this is 103 over it, 4.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DefaultZoomableController app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/DefaultZoomableController.kt:12 — TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: FragmentBuilderModule app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt:54 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ZoomableDraweeView app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableDraweeView.kt:36 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NetworkingModule app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.kt:57 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LoginActivity app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt:57 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CommonsApplicationModule app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt:56 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DepictsFragment app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt:50 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×5
  • Edited copy of a member (14 corresponding lines) app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:122 — app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:122-137 | app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:158-171 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaResponseMapper.kt:30 — app/src/main/java/fr/free/nrw/commons/media/MediaResponseMapper.kt:30-44 | app/src/main/java/fr/free/nrw/commons/media/WikidataMediaClient.kt:67-80 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryResult.kt:59 — app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryResult.kt:59-76 | app/src/main/java/fr/free/nrw/commons/wikidata/mwapi/MwQueryResult.kt:78-91 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:253 — app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:253-270 | app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:277-290 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/categories/CategoryEditView.kt:72 — app/src/main/java/fr/free/nrw/commons/upload/categories/CategoryEditView.kt:72-85 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt:401-414 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×5
  • Duplicated block (5 lines × 2) app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictsClient.kt:115 — app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictsClient.kt:115-119 | app/src/main/java/fr/free/nrw/commons/upload/structure/depictions/DepictedItem.kt:105-109 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) app/src/main/java/fr/free/nrw/commons/media/MediaResponseMapper.kt:23 — app/src/main/java/fr/free/nrw/commons/media/MediaResponseMapper.kt:23-27 | app/src/main/java/fr/free/nrw/commons/media/WikidataMediaClient.kt:88-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt:44 — app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt:44-48 | app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt:40-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt:44` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (5 lines × 2) app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:123 — app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:123-127 | app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:214-218 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:220` calls `w` and `app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:128` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:152 — app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:152-156 | app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:179-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:152` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×4
  • Edited copy of a member (11 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32 — app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32-42 | app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:46-56 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailImage.kt:149 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailImage.kt:149-159 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailImage.kt:171-181 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/Place.java:62 — app/src/main/java/fr/free/nrw/commons/nearby/Place.java:62-73 | app/src/main/java/fr/free/nrw/commons/nearby/Place.java:76-86 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1480 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1480-1490 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1497-1507 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×4
  • Edited copy of a member (22 corresponding lines) app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:438 — app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:438-459 | app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:522-548 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:62 — app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:62-83 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:291-314 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.kt:157 — app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.kt:157-178 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt:277-299 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaReportHelper.kt:70 — app/src/main/java/fr/free/nrw/commons/media/MediaReportHelper.kt:70-91 | app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:106-127 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D15 · Churn × Complexity Hotspots · Hotspot · ×3
  • Hotspot: app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt changed 22 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in NearbyParentFragment.onViewCreated at line 462. 13 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:180 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in MediaDetailPagerFragment.onOptionsItemSelected at line 180. 3 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311 — app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in BlurOverlayView.onTouchEvent at line 311. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 11:35:08 +09:00' --until='2026-11-17 11:35:08 +09:00' --full-history --no-merges -- app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D17 · Explicit Debt · FixmeComment · ×3
  • FixmeComment app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.kt:153 — // FIXME: Temporary fix for screen rotation inside media details. If we don't call onBackPressed then — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.kt:155 — // FIXME: Similar issue like this https://github.com/commons-app/apps-android-commons/issues/894
  • FixmeComment app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:159 — // fixme add a limit on the original query instead of falling out of the loop? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D3 · God Classes · ClassTooLong · ×3
  • ClassTooLong: NearbyParentFragment app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:155 — ClassTooLong — 2179 significant lines (blank, comment-only and punctuation-only lines excluded), 133 methods. The bar is 400 significant lines; this is 1779 over it, 5.45× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ZoomableActivity app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:61 — ClassTooLong — 441 significant lines (blank, comment-only and punctuation-only lines excluded), 17 methods. The bar is 400 significant lines; this is 41 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: UploadMediaDetailAdapter app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:41 — ClassTooLong — 404 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 4 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×3
  • Edited copy of a member (18 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailCategories.kt:133 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailCategories.kt:133-150 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailDepictions.kt:86-105 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/fr/free/nrw/commons/location/LocationPermissionsHelper.kt:106 — app/src/main/java/fr/free/nrw/commons/location/LocationPermissionsHelper.kt:106-124 | app/src/main/java/fr/free/nrw/commons/location/LocationPermissionsHelper.kt:153-170 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:59 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:59-76 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt:59-76 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×3
  • Edited copy of a member (12 corresponding lines) app/src/main/java/fr/free/nrw/commons/language/AppLanguageLookUpTable.kt:59 — app/src/main/java/fr/free/nrw/commons/language/AppLanguageLookUpTable.kt:59-70 | app/src/main/java/fr/free/nrw/commons/language/AppLanguageLookUpTable.kt:72-83 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailCategories.kt:88 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailCategories.kt:88-100 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailDepictions.kt:19-30 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt:63 — app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt:63-74 | app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt:96-109 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×3
  • Edited copy of a member (7 corresponding lines) app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:129 — app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:129-135 | app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetNavigation.kt:30-36 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:137 — app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragment.kt:137-143 | app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetNavigation.kt:44-50 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaCollectionClient.kt:84 — app/src/main/java/fr/free/nrw/commons/media/MediaCollectionClient.kt:84-90 | app/src/main/java/fr/free/nrw/commons/media/WikidataMediaClient.kt:39-45 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×3
  • Duplicated block (14 lines × 2) app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:65 — app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:65-78 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:126-140 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:65` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1713 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1713-1726 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1761-1774 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1713` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/fr/free/nrw/commons/di/CommonsDaggerIntentService.kt:9 — app/src/main/java/fr/free/nrw/commons/di/CommonsDaggerIntentService.kt:9-22 | app/src/main/java/fr/free/nrw/commons/di/CommonsDaggerService.kt:7-20 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:94 — app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:94-106 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:98-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1686 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1686-1698 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1734-1746 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1686` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:64 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:64-76 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt:64-76 — before extracting anything, compare `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt` and `app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:64` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: `TABLE_NAME` names `fr.free.nrw.commons.bookmarks.items.BookmarkItemsTable.TABLE_NAME` in one and `fr.free.nrw.commons.bookmarks.pictures.BookmarksTable.TABLE_NAME` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×3
  • Duplicated block (12 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt:184 — app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt:184-195 | app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt:254-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsPresenter.kt:184` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:126 — app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:126-137 | app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:167-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:126` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:34 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:34-45 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt:34-45 — before extracting anything, compare `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt` and `app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:34` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: `TABLE_NAME` names `fr.free.nrw.commons.bookmarks.items.BookmarkItemsTable.TABLE_NAME` in one and `fr.free.nrw.commons.bookmarks.pictures.BookmarksTable.TABLE_NAME` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) app/src/main/java/fr/free/nrw/commons/edit/CropOverlayView.kt:314 — app/src/main/java/fr/free/nrw/commons/edit/CropOverlayView.kt:314-324 | app/src/main/java/fr/free/nrw/commons/edit/CropOverlayView.kt:330-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/edit/CropOverlayView.kt:314` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:243 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:243-253 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:284-294 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:284` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt:39 — app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt:39-49 | app/src/main/java/fr/free/nrw/commons/upload/LanguagesAdapter.kt:64-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×3
  • Duplicated block (9 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:570 — app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:570-578 | app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:598-606 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:570` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:566` calls `updateAddButtonVisibility` and `app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:595` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:582 — app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:582-590 | app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:610-618 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:582` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/Place.java:63 — app/src/main/java/fr/free/nrw/commons/nearby/Place.java:63-71 | app/src/main/java/fr/free/nrw/commons/nearby/Place.java:77-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×3
  • Duplicated block (6 lines × 2) app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:29 — app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:29-34 | app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:39-44 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:29` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:40 — app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:40-45 | app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:72-77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:40` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:84 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:84-89 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt:84-89 — before extracting anything, compare `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt` and `app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:84` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: `TABLE_NAME` names `fr.free.nrw.commons.bookmarks.items.BookmarkItemsTable.TABLE_NAME` in one and `fr.free.nrw.commons.bookmarks.pictures.BookmarksTable.TABLE_NAME` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D2 · Cognitive Complexity · NearbyController.loadAttractionsFromLocation (cognitive 29) · ×2
  • NearbyController.loadAttractionsFromLocation (cognitive 29) app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:50 — NearbyController.loadAttractionsFromLocation has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (25 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (NearbyController.loadAttractionsFromLocation) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • NearbyController.loadAttractionsFromLocation (cognitive 29) app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:186 — NearbyController.loadAttractionsFromLocation has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (25 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (NearbyController.loadAttractionsFromLocation) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D3 · God Classes · FileTooLong · ×2
  • FileTooLong: fragments/NearbyParentFragment.kt app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt — FileTooLong — 2331 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: NearbyParentFragment (155-3553). The bar is 500 significant lines; this is 1831 over it, 4.66× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: media/MediaDetailFragment.kt app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt — FileTooLong — 530 significant lines (blank, comment-only and punctuation-only lines excluded), about 64% of them inside a single declaration: MediaDetailFragment (84-592). The bar is 500 significant lines; this is 30 over it, 1.06× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Edited copy of a member (49 corresponding lines) · ×2
  • Edited copy of a member (49 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1925 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1925-1973 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1981-2037 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (49 corresponding lines) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:327 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:327-378 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:381-429 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×2
  • Edited copy of a member (33 corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarkListNavigator.kt:29 — app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarkListNavigator.kt:29-62 | app/src/main/java/fr/free/nrw/commons/explore/ExploreMediaRootFragment.kt:48-80 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (33 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:455 — app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:455-487 | app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:492-524 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×2
  • Edited copy of a member (21 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:142 — app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:142-164 | app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt:169-189 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt:113 — app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt:113-133 | app/src/main/java/fr/free/nrw/commons/explore/media/PagedMediaAdapter.kt:47-68 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×2
  • Edited copy of a member (28 corresponding lines) app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt:38 — app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt:38-65 | app/src/main/java/fr/free/nrw/commons/upload/LanguagesAdapter.kt:63-90 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (28 corresponding lines) app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:33 — app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:33-67 | app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:90-117 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×2
  • Edited copy of a member (19 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt:119 — app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt:119-137 | app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt:157-180 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyPlaceDetailsLoader.kt:316 — app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyPlaceDetailsLoader.kt:316-335 | app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyPlaceDetailsLoader.kt:351-369 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×2
  • Edited copy of a member (24 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:930 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:930-953 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1340-1372 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailDeletion.kt:162 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailDeletion.kt:162-187 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailDeletion.kt:233-256 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×2
  • Edited copy of a member (15 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/categories/CategorySearchView.kt:28 — app/src/main/java/fr/free/nrw/commons/upload/categories/CategorySearchView.kt:28-45 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt:443-457 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:26 — app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:26-48 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:36-50 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×2
  • Edited copy of a member (16 corresponding lines) app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.kt:98 — app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.kt:98-114 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesContentProvider.kt:120-135 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt:255 — app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt:255-270 | app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.kt:262-277 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×2
  • Edited copy of a member (8 corresponding lines) app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:27 — app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:27-34 | app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.kt:37-44 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt:143 — app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt:143-150 | app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailView.kt:120-130 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×2
  • Edited copy of a member (13 corresponding lines) app/src/main/java/fr/free/nrw/commons/AboutLinkHandler.kt:20 — app/src/main/java/fr/free/nrw/commons/AboutLinkHandler.kt:20-32 | app/src/main/java/fr/free/nrw/commons/AboutLinkHandler.kt:38-50 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/src/main/java/fr/free/nrw/commons/contributions/SetWallpaperWorker.kt:86 — app/src/main/java/fr/free/nrw/commons/contributions/SetWallpaperWorker.kt:86-99 | app/src/main/java/fr/free/nrw/commons/contributions/SetWallpaperWorker.kt:105-117 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×2
  • Edited copy of a member (10 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/license/LicenseAdapter.kt:84 — app/src/main/java/fr/free/nrw/commons/upload/license/LicenseAdapter.kt:84-93 | app/src/main/java/fr/free/nrw/commons/upload/license/LicenseAdapter.kt:98-109 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:101 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:101-110 | app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesDao.kt:85-98 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×2
  • Duplicated block (10 lines × 2) app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:405 — app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:405-414 | app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:472-481 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt:405` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:86 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:86-95 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:77-86 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `BASE_URI` names `fr.free.nrw.commons.bookmarks.items.BookmarkItemsContentProvider.Companion.BASE_URI` in one and `fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesContentProvider.Companion.BASE_URI` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D6 · Cohesion (LCOM4) · Low cohesion · ×2
  • Low cohesion: MediaDetailMenuHandler (LCOM4 4) app/src/main/java/fr/free/nrw/commons/media/MediaDetailMenuHandler.kt:29 — MediaDetailMenuHandler's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: UploadMediaDetailAdapter (LCOM4 4) app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:41 — UploadMediaDetailAdapter's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
X2 · Cancellation propagation · Suspend function with a blocking request · ×2
  • Suspend function with a blocking request: getFileUsagesOnCommons app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:87 — `getFileUsagesOnCommons` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
  • Suspend function with a blocking request: getGlobalFileUsages app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:123 — `getGlobalFileUsages` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
D1 · Cyclomatic Complexity · ImageLoader.queryAndSetView (cyclomatic 31) · ×1
  • ImageLoader.queryAndSetView (cyclomatic 31) app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:73 — ImageLoader.queryAndSetView has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BlurOverlayView.onTouchEvent (cyclomatic 26) · ×1
  • BlurOverlayView.onTouchEvent (cyclomatic 26) app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311 — BlurOverlayView.onTouchEvent has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NearbyParentFragment.filterMarkersByLabels (cyclomatic 21) · ×1
  • NearbyParentFragment.filterMarkersByLabels (cyclomatic 21) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:2353 — NearbyParentFragment.filterMarkersByLabels has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MediaDetailPagerFragment.onOptionsItemSelected (cyclomatic 17) · ×1
  • MediaDetailPagerFragment.onOptionsItemSelected (cyclomatic 17) app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:180 — MediaDetailPagerFragment.onOptionsItemSelected has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · NearbyParentFragment.onViewCreated (cyclomatic 17) · ×1
  • NearbyParentFragment.onViewCreated (cyclomatic 17) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462 — NearbyParentFragment.onViewCreated has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BlurOverlayView.onDraw (cyclomatic 16) · ×1
  • BlurOverlayView.onDraw (cyclomatic 16) app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:191 — BlurOverlayView.onDraw has cyclomatic complexity 16 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ImageLoader.queryAndSetView (cognitive 46) · ×1
  • ImageLoader.queryAndSetView (cognitive 46) app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:73 — ImageLoader.queryAndSetView has cognitive complexity 46 (threshold 15). Drivers by points: if/else 20 (27 pts), match/switch 5 (13 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlurOverlayView.onTouchEvent (cognitive 44) · ×1
  • BlurOverlayView.onTouchEvent (cognitive 44) app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:311 — BlurOverlayView.onTouchEvent has cognitive complexity 44 (threshold 15). Drivers by points: if/else 19 (39 pts), boolean chains 2, loops 1 (2 pts), match/switch 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UploadProgressActivity.updateMenuItems (cognitive 38) · ×1
  • UploadProgressActivity.updateMenuItems (cognitive 38) app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt:109 — UploadProgressActivity.updateMenuItems has cognitive complexity 38 (threshold 15). Drivers by points: if/else 12 (38 pts) (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MediaDetailPagerFragment.onCreateOptionsMenu (cognitive 37) · ×1
  • MediaDetailPagerFragment.onCreateOptionsMenu (cognitive 37) app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:327 — MediaDetailPagerFragment.onCreateOptionsMenu has cognitive complexity 37 (threshold 15). Drivers by points: if/else 10 (26 pts), error handling 1 (5 pts), match/switch 1 (5 pts), boolean chains 1 (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · NearbyParentFragment.filterMarkersByLabels (cognitive 31) · ×1
  • NearbyParentFragment.filterMarkersByLabels (cognitive 31) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:2353 — NearbyParentFragment.filterMarkersByLabels has cognitive complexity 31 (threshold 15). Drivers by points: if/else 12 (22 pts), boolean chains 8, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UploadMediaDetailAdapter.updateAddButtonVisibility (cognitive 30) · ×1
  • UploadMediaDetailAdapter.updateAddButtonVisibility (cognitive 30) app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:566 — UploadMediaDetailAdapter.updateAddButtonVisibility has cognitive complexity 30 (threshold 15). Drivers by points: if/else 12 (29 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NearbyParentFragment.onViewCreated (cognitive 24) · ×1
  • NearbyParentFragment.onViewCreated (cognitive 24) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:462 — NearbyParentFragment.onViewCreated has cognitive complexity 24 (threshold 15). Drivers by points: if/else 19 (21 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NearbyPlaces.getFromWikidataQuery (cognitive 24) · ×1
  • NearbyPlaces.getFromWikidataQuery (cognitive 24) app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java:127 — NearbyPlaces.getFromWikidataQuery has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (14 pts), ternaries 3 (6 pts), boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OkHttpJsonApiClient.getNearbyPlaces (cognitive 23) · ×1
  • OkHttpJsonApiClient.getNearbyPlaces (cognitive 23) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:233 — OkHttpJsonApiClient.getNearbyPlaces has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 2 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UploadWorker.uploadContribution (cognitive 23) · ×1
  • UploadWorker.uploadContribution (cognitive 23) app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt:263 — UploadWorker.uploadContribution has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (15 pts), error handling 3 (5 pts), boolean chains 2, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RandomAccessFileExifWriter.scanAndUpdateIfd (cognitive 21) · ×1
  • RandomAccessFileExifWriter.scanAndUpdateIfd (cognitive 21) app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:241 — RandomAccessFileExifWriter.scanAndUpdateIfd has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ViewHolder.initLanguage (cognitive 20) · ×1
  • ViewHolder.initLanguage (cognitive 20) app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.kt:315 — ViewHolder.initLanguage has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (20 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UploadModel.onDepictItemClicked (cognitive 20) · ×1
  • UploadModel.onDepictItemClicked (cognitive 20) app/src/main/java/fr/free/nrw/commons/upload/UploadModel.kt:195 — UploadModel.onDepictItemClicked has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (20 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UploadActivity.onRequestPermissionsResult (cognitive 19) · ×1
  • UploadActivity.onRequestPermissionsResult (cognitive 19) app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt:249 — UploadActivity.onRequestPermissionsResult has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 1 (3 pts) (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ImageLoader.nextActionableImage (cognitive 18) · ×1
  • ImageLoader.nextActionableImage (cognitive 18) app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:243 — ImageLoader.nextActionableImage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MediaDetailFragmentKt.FileUsagesContainer (cognitive 18) · ×1
  • MediaDetailFragmentKt.FileUsagesContainer (cognitive 18) app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:595 — MediaDetailFragmentKt.FileUsagesContainer has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (14 pts), match/switch 2 (4 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LoginClient.login (cognitive 17) · ×1
  • LoginClient.login (cognitive 17) app/src/main/java/fr/free/nrw/commons/auth/login/LoginClient.kt:85 — LoginClient.login has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (12 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · GestureListener.onFling (cognitive 17) · ×1
  • GestureListener.onFling (cognitive 17) app/src/main/java/fr/free/nrw/commons/customselector/helper/OnSwipeTouchListener.kt:55 — GestureListener.onFling has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageAdapter.onBindViewHolder (cognitive 17) · ×1
  • ImageAdapter.onBindViewHolder (cognitive 17) app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/ImageAdapter.kt:141 — ImageAdapter.onBindViewHolder has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (17 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlurOverlayView.onDraw (cognitive 17) · ×1
  • BlurOverlayView.onDraw (cognitive 17) app/src/main/java/fr/free/nrw/commons/edit/BlurOverlayView.kt:191 — BlurOverlayView.onDraw has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 10, if/else 2 (4 pts), loops 3 (nesting depth added 2). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · NearbyParentFragment.getIconFor (cognitive 17) · ×1
  • NearbyParentFragment.getIconFor (cognitive 17) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:2442 — NearbyParentFragment.getIconFor has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RandomAccessFileExifWriter.writeTagsInternal (cognitive 17) · ×1
  • RandomAccessFileExifWriter.writeTagsInternal (cognitive 17) app/src/main/java/fr/free/nrw/commons/utils/RandomAccessFileExifWriter.kt:192 — RandomAccessFileExifWriter.writeTagsInternal has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 1, error handling 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExploreMapViewportHelper.recenterMap (cognitive 16) · ×1
  • ExploreMapViewportHelper.recenterMap (cognitive 16) app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapViewportHelper.kt:149 — ExploreMapViewportHelper.recenterMap has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NearbyPlaceDetailsLoader.fetchPlacesThreadMethod (cognitive 16) · ×1
  • NearbyPlaceDetailsLoader.fetchPlacesThreadMethod (cognitive 16) app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyPlaceDetailsLoader.kt:191 — NearbyPlaceDetailsLoader.fetchPlacesThreadMethod has cognitive complexity 16 (threshold 15). Drivers by points: error handling 4 (12 pts), loops 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DownloadReceiver.getFailedDownload (cognitive 16) · ×1
  • DownloadReceiver.getFailedDownload (cognitive 16) app/src/main/java/fr/free/nrw/commons/utils/DownloadReceiver.kt:31 — DownloadReceiver.getFailedDownload has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageUtils.checkIfImageIsDark (cognitive 16) · ×1
  • ImageUtils.checkIfImageIsDark (cognitive 16) app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.kt:185 — ImageUtils.checkIfImageIsDark has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageUtils.getErrorMessageForResult (cognitive 16) · ×1
  • ImageUtils.getErrorMessageForResult (cognitive 16) app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.kt:377 — ImageUtils.getErrorMessageForResult has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (16 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:192 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:192-230 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:236-324 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:447-470 | app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt:72-108 | app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt:117-174 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (68 corresponding lines) · ×1
  • Edited copy of a member (68 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:53 — app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:53-120 | app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:191-258 — These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (53 corresponding lines) · ×1
  • Edited copy of a member (53 corresponding lines) app/src/main/java/fr/free/nrw/commons/utils/EdgeToEdgeUtils.kt:29 — app/src/main/java/fr/free/nrw/commons/utils/EdgeToEdgeUtils.kt:29-83 | app/src/main/java/fr/free/nrw/commons/utils/EdgeToEdgeUtils.kt:99-151 — These two members are one piece of code written twice and then edited apart: 53 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (66 corresponding lines) · ×1
  • Edited copy of a member (66 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:312 — app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:312-377 | app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:382-450 — These two members are one piece of code written twice and then edited apart: 66 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (47 corresponding lines) · ×1
  • Edited copy of a member (47 corresponding lines) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1680 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1680-1726 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1728-1774 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (35 corresponding lines) · ×1
  • Edited copy of a member (35 corresponding lines) app/src/main/java/fr/free/nrw/commons/category/CategoryEditHelper.kt:100 — app/src/main/java/fr/free/nrw/commons/category/CategoryEditHelper.kt:100-139 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictEditHelper.kt:93-127 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (34 corresponding lines) · ×1
  • Edited copy of a member (34 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailCaptionEditor.kt:93 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailCaptionEditor.kt:93-126 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailCaptionEditor.kt:133-166 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 28+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 28+ corresponding lines) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:90 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:90-118 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:126-156 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:158-185 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 28 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×1
  • Edited copy of a member (23 corresponding lines) app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:31 — app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:31-53 | app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:63-85 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×1
  • Edited copy of a member (36 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailActions.kt:102 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailActions.kt:102-145 | app/src/main/java/fr/free/nrw/commons/review/ReviewController.kt:173-208 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) app/src/main/java/fr/free/nrw/commons/media/MediaDetailViewModel.kt:33 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailViewModel.kt:33-63 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailViewModel.kt:65-94 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×1
  • Edited copy of a member (27 corresponding lines) app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.kt:122 — app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.kt:122-148 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesContentProvider.kt:145-179 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 13+ corresponding lines) app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt:73 — app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt:73-86 | app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt:97-109 | app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt:116-129 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 25+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 25+ corresponding lines) app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt:177 — app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt:177-203 | app/src/main/java/fr/free/nrw/commons/description/DescriptionEditHelper.kt:93-117 | app/src/main/java/fr/free/nrw/commons/description/DescriptionEditHelper.kt:130-156 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×1
  • Edited copy of a member (17 corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaMetadataController.kt:53 — app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaMetadataController.kt:53-75 | app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaMetadataController.kt:80-96 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 22+ corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:31 — app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:31-54 | app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:56-78 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:56-77 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:117-140 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt:146-170 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 18+ corresponding lines) app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:138 — app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:138-157 | app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:199-222 | app/src/main/java/fr/free/nrw/commons/upload/worker/UploadNotificationHelper.kt:229-246 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 21+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 21+ corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:117 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.kt:117-140 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt:114-138 | app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesDao.kt:31-51 | app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesDao.kt:105-129 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 10+ corresponding lines) app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:32 — app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:32-43 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:59-78 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:92-101 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:115-124 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:140-149 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×1
  • Edited copy of a member (9 corresponding lines) app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:199 — app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:199-207 | app/src/main/java/fr/free/nrw/commons/media/MediaClient.kt:113-122 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:98 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsContentProvider.kt:98-107 | app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesContentProvider.kt:95-104 | app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesContentProvider.kt:125-134 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (1 corresponding lines) · ×1
  • Edited copy of a member (1 corresponding lines) app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictsClient.kt:107 — app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictsClient.kt:107-109 | app/src/main/java/fr/free/nrw/commons/upload/structure/depictions/DepictedItem.kt:117-117 — These two members are one piece of code written twice and then edited apart: 1 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (69 lines × 2) · ×1
  • Duplicated block (69 lines × 2) app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:613 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:613-681 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:690-758 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:613` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (39 lines × 2) · ×1
  • Duplicated block (39 lines × 2) app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:535 — app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:535-573 | app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:584-622 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:535` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×1
  • Duplicated block (31 lines × 2) app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:132 — app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:132-162 | app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:167-197 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:132` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (29–31 lines × 2) · ×1
  • Duplicated block (29–31 lines × 2) app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:326 — app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:326-354 | app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:404-434 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt:326` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (24–26 lines × 2) · ×1
  • Duplicated block (24–26 lines × 2) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:332 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:332-357 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:392-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:332` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1926 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1926-1951 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1982-2007 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1926` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:398 — app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:398-422 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:428-452 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:428` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19–22 lines × 2) · ×1
  • Duplicated block (19–22 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarksTable.kt:38 — app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarksTable.kt:38-59 | app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesTable.kt:58-76 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1
  • Duplicated block (20 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:64 — app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:64-83 | app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:295-314 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:64` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/category/BookmarkCategoriesFragment.kt:55 — app/src/main/java/fr/free/nrw/commons/bookmarks/category/BookmarkCategoriesFragment.kt:55-71 | app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt:333-349 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/bookmarks/category/BookmarkCategoriesFragment.kt:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–15 lines × 4) · ×1
  • Duplicated block (9–15 lines × 4) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:207 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:207-217 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:297-307 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:455-463 | app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt:146-160 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:207` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:204` calls `replace` and `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:453` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×1
  • Duplicated block (14–15 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:931 — app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:931-944 | app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:1341-1355 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt:931` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/SimilarImageDialogFragment.kt:43 — app/src/main/java/fr/free/nrw/commons/upload/SimilarImageDialogFragment.kt:43-57 | app/src/main/java/fr/free/nrw/commons/upload/SimilarImageDialogFragment.kt:60-74 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt:116 — app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt:116-126 | app/src/main/java/fr/free/nrw/commons/explore/media/PagedMediaAdapter.kt:51-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:204 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:204-214 | app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt:82-91 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:204` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7–8 lines × 3) · ×1
  • Duplicated block (7–8 lines × 3) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:100 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:100-107 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:137-144 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:166-172 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:218 — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:218-223 | app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:308-313 | app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt:95-100 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:218` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×1
  • Duplicated block (7 lines × 2) app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32 — app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32-38 | app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:46-52 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/media/zoomControllers/gestures/GestureTransform.kt:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (40 lines × 2) · ×1
  • Duplicated block (40 lines × 2) app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsTable.kt:55 — app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsTable.kt:55-96 | app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesTable.kt:33-72 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:37 — app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:37-52 | app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:94-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/mwapi/UserStatsClient.kt:37` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:35 — app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:35-43 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:95-101 | app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:143-149 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt:35` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×1
  • Duplicated block (8 lines × 2) app/src/main/java/fr/free/nrw/commons/upload/UploadClient.kt:250 — app/src/main/java/fr/free/nrw/commons/upload/UploadClient.kt:250-257 | app/src/main/java/fr/free/nrw/commons/upload/UploadClient.kt:283-290 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/upload/UploadClient.kt:250` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (57–58 lines × 2) · ×1
  • Duplicated block (57–58 lines × 2) app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:63 — app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:63-120 | app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:202-258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:63` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
P12 · CI test-gate honesty · Coverage collected but not gated · ×1
  • Coverage collected but not gated — CI collects a coverage report but no step enforces a minimum — coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool's minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository's CI files AND its coverage configuration — the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited — matched against the threshold settings this check knows by name. A floor set in your coverage service's web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×1
  • Outbound HTTP without resilience app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:373 — `.openConnection(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×1
  • Swallowed exception (caught, then discarded) app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFileLoader.kt:167 — `catch (ignored: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Minor — 90 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×55
  • Orphaned file app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/activity/SingleWebViewActivity.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/auth/csrf/CsrfTokenClient.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/upload/LanguagesAdapter.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/PageEditHelper.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/widget/PicOfDayAppWidget.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file jacoco.gradle:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/PlaceAdapterDelegate.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/category/CategoryClient.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/nearby/fragments/CommonPlaceClickActions.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageProperties.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsFragment.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/review/ReviewHelper.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/description/DescriptionEditHelper.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/explore/media/MediaConverter.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/src/main/java/fr/free/nrw/commons/contributions/ContributionBoundaryCallback.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 30 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×13
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt:79 — `!fragment.isAdded && otherFragment != null` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt, app/src/main/java/fr/free/nrw/commons/explore/ExploreMediaRootFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt:258 — `!userName.isNullOrBlank() && userName != sessionManager.userName` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt, app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt:371 — `caught is LoginFailedException && !message.isNullOrBlank()` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt, app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt:98 — `cursor != null && cursor.moveToNext() && cursor.position < limit` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/category/CategoryDao.kt, app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt:68 — `fragment.isAdded && otherFragment != null` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt, app/src/main/java/fr/free/nrw/commons/explore/ExploreMediaRootFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt:74 — `fragment.isAdded && otherFragment == null` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragmentRenderer.kt, app/src/main/java/fr/free/nrw/commons/explore/ExploreMediaRootFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/contributions/ContributionsNavigator.kt:133 — `fragment.mediaDetailPagerFragment != null && !fragment.contributionsListFragment!!.isVisible` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/contributions/ContributionsNavigator.kt, app/src/main/java/fr/free/nrw/commons/contributions/ContributionsNearbyController.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt:29 — `it.isNotEmpty() && !selectedLanguages.containsValue(it) && it != selectedLangCode` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesAdapter.kt, app/src/main/java/fr/free/nrw/commons/upload/LanguagesAdapter.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapFragment.kt:128 — `locationManager.isGPSProviderEnabled() || locationManager.isNetworkProviderEnabled()` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapFragment.kt, app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.kt:83 — `null != mediaDetails && mediaDetails!!.isVisible` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.kt, app/src/main/java/fr/free/nrw/commons/explore/ExploreMapRootFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapViewportHelper.kt:81 — `prevZoom != 0.0 || prevLatitude != 0.0 || prevLongitude != 0.0` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapViewportHelper.kt, app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt:44 — `response != null && response.status == 200` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/profile/leaderboard/DataSourceClass.kt, app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt:67 — `response.body != null && response.isSuccessful` appears character-identically in 2 files — app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt, app/src/main/java/fr/free/nrw/commons/mwapi/WikidataQueryClient.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
AX6 · Interface segregation · Fat interface · ×4
  • Fat interface: View (45 abstract methods) app/src/main/java/fr/free/nrw/commons/nearby/contract/NearbyParentFragmentContract.java:17 — `View` declares 45 abstract methods: `addCurrentLocationMarker`, `animateFABs`, `askForLocationPermission`, `centerMapToPlace`, `clearAllMarkers`, `disableFABRecenter`, `displayLoginSkippedWarning`, `enableFABRecenter`, `filterMarkersByLabels`, `filterOutAllMarkers`, `getCameraTarget`, `getContext`, `getLastLocation`, `getLastMapFocus`, `getMapCenter`, `getMapFocus`, `getScreenBottomLeft`, `getScreenTopRight`, `hideBottomDetailsSheet`, `hideBottomSheet`, `hideNearbyFilterList`, `isAdvancedQueryFragmentVisible`, `isDetailsBottomSheetVisible`, `isListBottomSheetExpanded`, `isNearbyFilterListVisible`, `isNetworkConnectionEstablished`, `listOptionMenuItemClicked`, `openLocationSettings`, `populatePlaces`, `populatePlaces`, `recenterMap`, `replaceMarkerOverlays`, `setBottomSheetDetailsSmaller`, `setCheckBoxAction`, `setCheckBoxState`, `setFABPlusAction`, `setFABRecenterAction`, `setFilterState`, `setProgressBarVisibility`, `setRecyclerViewAdapterAllSelected`, and 5 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 45 declarations carry 44 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 44 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ActivityBuilderModule (22 abstract methods) app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.kt:37 — `ActivityBuilderModule` declares 22 abstract methods: `bindLoginActivity`, `bindWelcomeActivity`, `bindContributionsActivity`, `bindCustomSelectorActivity`, `bindSettingsActivity`, `bindAboutActivity`, `bindLocationPickerActivity`, `bindSignupActivity`, `bindNotificationActivity`, `bindUploadActivity`, `bindDepictsPickerActivity`, `bindSearchActivity`, `bindCategoryDetailsActivity`, `bindDepictionDetailsActivity`, `bindAchievementsActivity`, `bindReviewActivity`, `bindDescriptionEditActivity`, `bindZoomableActivity`, `bindUploadProgressActivity`, `bindWikiFeedback`, `bindEditActivity`, `bindDeletedFileActivity`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: FragmentBuilderModule (39 abstract methods) app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt:54 — `FragmentBuilderModule` declares 39 abstract methods: `bindContributionsListFragment`, `bindMediaDetailFragment`, `bindFolderFragment`, `bindImageFragment`, `bindMediaDetailPagerFragment`, `bindSettingsFragment`, `bindDepictedImagesFragment`, `bindBrowseImagesListFragment`, `bindSearchCategoryListFragment`, `bindSearchDepictionListFragment`, `bindRecentSearchesFragment`, `bindContributionsFragment`, `bindNearbyParentFragment`, `bindBookmarkPictureListFragment`, `bindBookmarkLocationListFragment`, `bindBookmarkItemListFragment`, `bindBookmarkCategoriesListFragment`, `bindReviewOutOfContextFragment`, `bindUploadMediaDetailFragment`, `bindUploadCategoriesFragment`, `bindDepictsFragment`, `bindMediaLicenseFragment`, `bindParentDepictionsFragment`, `bindChildDepictionsFragment`, `bindCategoriesMediaFragment`, `bindSubCategoriesFragment`, `bindParentCategoriesFragment`, `bindExploreFragmentFragment`, `bindExploreFeaturedRootFragment`, `bindExploreNearbyUploadsFragment`, `bindExploreNearbyUploadsRootFragment`, `bindBookmarkListRootFragment`, `bindBookmarkFragmentFragment`, `bindMoreBottomSheetFragment`, `bindMoreBottomSheetLoggedOutFragment`, `bindAchievementsFragment`, `bindLeaderboardFragment`, `bindPendingUploadsFragment`, `bindFailedUploadsFragment`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ZoomableController (16 abstract methods) app/src/main/java/fr/free/nrw/commons/media/zoomControllers/zoomable/ZoomableController.kt:11 — `ZoomableController` declares 16 abstract methods: `setEnabled`, `isEnabled`, `setListener`, `getScaleFactor`, `isIdentity`, `wasTransformCorrected`, `computeHorizontalScrollRange`, `computeHorizontalScrollOffset`, `computeHorizontalScrollExtent`, `computeVerticalScrollRange`, `computeVerticalScrollOffset`, `computeVerticalScrollExtent`, `getTransform`, `setImageBounds`, `setViewBounds`, `onTouchEvent`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D21 · Naming Consistency · `defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` · ×2
  • `defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` app/src/main/java/fr/free/nrw/commons/contributions/ContributionsLocalDataSource.kt:16 — 48 of 50 names in project app spell the token `Kv` (48 of 50; unit: names in project app containing `Kv`). Peers: LoginActivity.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt:63); LoginViewModel.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt:58); LoginViewModelFactory.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt:190); SessionManager.defaultKvStore (app/src/main/java/fr/free/nrw/commons/auth/SessionManager.kt:25); BookmarkFragment.applicationKvStore (app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarkFragment.kt:32). Rename to `defaultKvStore`. [rule N6]
  • `defaultKVStore` spells `KV` where 48 names in the project spell it `Kv` app/src/main/java/fr/free/nrw/commons/upload/license/MediaLicensePresenter.kt:18 — 48 of 50 names in project app spell the token `Kv` (48 of 50; unit: names in project app containing `Kv`). Peers: LoginActivity.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt:63); LoginViewModel.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt:58); LoginViewModelFactory.applicationKvStore (app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt:190); SessionManager.defaultKvStore (app/src/main/java/fr/free/nrw/commons/auth/SessionManager.kt:25); BookmarkFragment.applicationKvStore (app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarkFragment.kt:32). Rename to `defaultKvStore`. [rule N6]
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 2 significant file(s) lose their only recent owner: app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt, app/src/main/java/fr/free/nrw/commons/upload/ThumbnailsAdapter.kt. Pair on, review, or document these before any departure.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 7 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (10 single-owned of 339 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 339 of the 691 production source files in this repository met that bar). They are anonymized user #2 (2 file(s)), anonymized user #3 (1 file(s)), anonymized user #4 (1 file(s)), anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)) (+1 more) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: app/src/main/java/fr/free/nrw/commons/auth/WikiAccountAuthenticator.kt, app/src/main/java/fr/free/nrw/commons/auth/SessionManager.kt, app/src/main/java/fr/free/nrw/commons/review/ReviewController.kt, app/src/main/java/fr/free/nrw/commons/language/AppLanguageLookUpTable.kt, app/src/main/java/fr/free/nrw/commons/wikidata/cookies/CommonsCookieJar.kt, app/src/main/java/fr/free/nrw/commons/WelcomePagerAdapter.kt, app/src/main/java/fr/free/nrw/commons/fileusages/FileUsagesUiModel.kt, app/src/main/java/fr/free/nrw/commons/repository/UploadRepository.kt.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found app/build.gradle.kts:5 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `app/build.gradle.kts` makes this repository a deployable product (line 5).
D21 · Naming Consistency · `getMediaFromImageURL` spells `URL` where 54 names in the project spell it `Url` · ×1
  • `getMediaFromImageURL` spells `URL` where 54 names in the project spell it `Url` app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapMarkerOverlayHelper.kt:321 — 54 of 56 names in project app spell the token `Url` (54 of 56; unit: names in project app containing `Url`). Peers: Media.thumbUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:31); Media.imageUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:36); Media.licenseUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:59); UnsuccessfulResponseInterceptor.isExcludedUrl (app/src/main/java/fr/free/nrw/commons/OkHttpConnectionFactory.kt:138); SingleWebViewActivity.WebViewComponent(successUrl) (app/src/main/java/fr/free/nrw/commons/activity/SingleWebViewActivity.kt:116). Rename to `getMediaFromImageUrl`. [rule N6]
D21 · Naming Consistency · `getAPILevel` spells `API` where 19 names in the project spell it `Api` · ×1
  • `getAPILevel` spells `API` where 19 names in the project spell it `Api` app/src/main/java/fr/free/nrw/commons/utils/DeviceInfoUtil.kt:62 — 19 of 20 names in project app spell the token `Api` (19 of 20; unit: names in project app containing `Api`). Peers: CampaignsPresenter.okHttpJsonApiClient (app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.kt:28); ReasonBuilder.okHttpJsonApiClient (app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt:28); NetworkingModule.provideOkHttpJsonApiClient (app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.kt:106); MediaDetailMenuHandler.okHttpJsonApiClient (app/src/main/java/fr/free/nrw/commons/media/MediaDetailMenuHandler.kt:34); MediaDetailPagerFragment.okHttpJsonApiClient (app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt:51). Rename to `getApiLevel`. [rule N6]
D21 · Naming Consistency · `decodeURL` spells `URL` where 54 names in the project spell it `Url` · ×1
  • `decodeURL` spells `URL` where 54 names in the project spell it `Url` app/src/main/java/fr/free/nrw/commons/wikidata/model/page/PageTitle.kt:138 — 54 of 56 names in project app spell the token `Url` (54 of 56; unit: names in project app containing `Url`). Peers: Media.thumbUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:31); Media.imageUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:36); Media.licenseUrl (app/src/main/java/fr/free/nrw/commons/Media.kt:59); UnsuccessfulResponseInterceptor.isExcludedUrl (app/src/main/java/fr/free/nrw/commons/OkHttpConnectionFactory.kt:138); SingleWebViewActivity.WebViewComponent(successUrl) (app/src/main/java/fr/free/nrw/commons/activity/SingleWebViewActivity.kt:116). Rename to `decodeUrl`. [rule N6]
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 55 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageLoader.kt, app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java, app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt, app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt, app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.kt, app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java, app/src/main/java/fr/free/nrw/commons/activity/SingleWebViewActivity.kt, app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java (and 47 more) (56 orphaned of 339 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 339 of the 691 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST REDACTED:3 — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 9 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation app/build.gradle.kts:359 — `app/build.gradle.kts` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
X2 · Cancellation propagation · Not all suspend functions that make a request accept the coroutine's cancellation · ×1
  • Not all suspend functions that make a request accept the coroutine's cancellation — Only 0/2 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
X5 · Nullable reference types · Not-null assertions (`!!`) override null safety · ×1
  • Not-null assertions (`!!`) override null safety — ~18.5 `!!` not-null assertions per 1k Kotlin product lines — 1435 across the 77547 line(s) of the 672 Kotlin file(s) read (generated, test and sample code not counted). Densest: app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt (298), app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.kt (45), app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.kt (43). Each one tells the compiler to trust the author about null and becomes a `NullPointerException` the first time the author is wrong. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-ad0ca7c9056748a38a9bca4daf561172/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-ad0ca7c9056748a38a9bca4daf561172/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=3200" --report-format json --report-path /tmp/watchdog-gitleaks-ad0ca7c9056748a38a9bca4daf561172/history-2.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=4200 --max-count=3023" --report-format json --report-path /tmp/watchdog-gitleaks-ad0ca7c9056748a38a9bca4daf561172/history-3.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-3.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-ad0ca7c9056748a38a9bca4daf561172/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .24artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 17 file(s) — `app/src/main/java/fr/free/nrw/commons/auth/LoginViewModel.kt`, `app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsViewModel.kt`, `app/src/main/java/fr/free/nrw/commons/contributions/WikipediaInstructionsDialogFragment.kt`, `app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.kt`, `app/src/main/java/fr/free/nrw/commons/kvstore/BasicKvStore.kt`, … (+12 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—

Run 01a1e9d9-73a0-7bf0-be8e-f5e1675655c9 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md