Public report of christianrowlands/android-network-survey, published 16 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 16 November 2026, 19:38 UTC · Survey ID cd_d1ff26489d2349b38798eec04b0b5a1e
christianrowlands/android-network-survey
Measured 16 November 2026, 19:37 UTC, at code version 4b92316
First survey, so nothing to compare with yet
CAI scoreAdequate
CriticalWeakAdequateStrongExemplary
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 109,926 lines of product code in 2 projects, tests not counted · Estimated rebuild effort: about 1.2 person-years · Weakest lens: Production Readiness, 54.9
Findings by how serious they are
27 critical295 serious30 minor
13 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
16 November 2026, 19:37 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
47of 47 dimensions measured by tools.
344of 352 findings point to an exact file and line, so you can open each one in the code. The other 8 concern the repository as a whole, such as missing documentation.
47dimensions across 6 lenses, read from 109,926 lines of product code in 2 projects.
christianrowlands/android-network-survey falls short of our standard for production because we found no automated security scanning of the code, its secrets or its dependencies. It scores 63.5 out of 100 and is rated Adequate, and all 27 of its critical findings are security problems.
Production Readiness, at 54.9, is the weakest lens and counts most in the score. The best first step for the work it takes is recording design decisions, worth about 5.1 points. Adding automated security scanning would lift Production Readiness itself, worth about 6.9 points. Raising Production Readiness to 70 would lift the score to about 68.5.
Twenty-one pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Three pipeline steps put outside input straight into a shell command, so an attacker can run commands in the build pipeline, and two secrets can leak from the build pipeline. Pinning each tool to an exact version, passing outside input through environment variables and limiting each secret to its own step would close these risks. The password or key in the code's history needs replacing, with the old one switched off.
The product code is 109,926 lines, about €170,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Production Readiness rose from 54.9 to 70, the lowest score rated Strong, the score would rise from 63.5 to about 68.5.
Code composition: what the lines of code are
Product code 74%Tests 26%
Rebuild cost: about €170,000 · Estimate
Cost to rebuild
€56,000 to €280,000, for 938 to 2,975 hours of work, about 1.2 person-years for 1 to 3 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.9 at a score of 64. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 109,926 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.
Raises the score by about 5.1 points · Low effort · ADR Quality
2
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €170,000 to build again, about 1.2 person-years of work. Its weakest lens is Production Readiness, at 54.9 (Adequate). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 5.1 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
455 modules, with 711 dependencies between them. 17 loops run through 77 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 415 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
logging.db.uploader uses listeners, so a change to listeners can break logging.db.uploader, while a change to logging.db.uploader can't break listeners.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
ui.cellular.towermap uses data.api, so a change to data.api can break ui.cellular.towermap, while a change to ui.cellular.towermap can't break data.api.
Position
Below the diagonal: ui.cellular.towermap uses a module listed above it, which is the healthy direction.
ui.cellular.towermap uses ui.cellular.model, so a change to ui.cellular.model can break ui.cellular.towermap, while a change to ui.cellular.towermap can't break ui.cellular.model.
Position
Below the diagonal: ui.cellular.towermap uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in services uses a type in listeners. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
ui.scout.firmware uses scout.firmware, so a change to scout.firmware can break ui.scout.firmware, while a change to ui.scout.firmware can't break scout.firmware.
Position
Below the diagonal: ui.scout.firmware uses a module listed above it, which is the healthy direction.
ui.scout.firmware uses scout.model, so a change to scout.model can break ui.scout.firmware, while a change to ui.scout.firmware can't break scout.model.
Position
Below the diagonal: ui.scout.firmware uses a module listed above it, which is the healthy direction.
services.controller uses scout.model, so a change to scout.model can break services.controller, while a change to services.controller can't break scout.model.
Position
Below the diagonal: services.controller uses a module listed above it, which is the healthy direction.
services.controller uses survey.model, so a change to survey.model can break services.controller, while a change to services.controller can't break survey.model.
Position
Below the diagonal: services.controller uses a module listed above it, which is the healthy direction.
services.controller uses scout.wifi, so a change to scout.wifi can break services.controller, while a change to services.controller can't break scout.wifi.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
26→30 services.controller uses scout.clientspart of a loop✕
Connections
3 pairs of types, where a type in services.controller uses a type in scout.clients.
services.controller uses scout.clients, so a change to scout.clients can break services.controller, while a change to services.controller can't break scout.clients.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
26→31 services.controller uses listenerspart of a loop✕
Connections
3 pairs of types, where a type in services.controller uses a type in listeners.
services.controller uses listeners, so a change to listeners can break services.controller, while a change to services.controller can't break listeners.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
29 pairs of types, where a type in ui.survey.model uses a type in survey.model. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
ui.survey.model uses survey.engine, so a change to survey.engine can break ui.survey.model, while a change to ui.survey.model can't break survey.engine.
Position
Below the diagonal: ui.survey.model uses a module listed above it, which is the healthy direction.
ui.survey.model uses survey.status, so a change to survey.status can break ui.survey.model, while a change to ui.survey.model can't break survey.status.
Position
Below the diagonal: ui.survey.model uses a module listed above it, which is the healthy direction.
scout.wifi uses services.controller, so a change to services.controller can break scout.wifi, while a change to scout.wifi can't break services.controller.
Position
Below the diagonal: scout.wifi uses a module listed above it, which is the healthy direction.
listeners uses services.controller, so a change to services.controller can break listeners, while a change to listeners can't break services.controller.
Position
Below the diagonal: listeners uses a module listed above it, which is the healthy direction.
ui.wifi.model uses services.controller, so a change to services.controller can break ui.wifi.model, while a change to ui.wifi.model can't break services.controller.
Position
Below the diagonal: ui.wifi.model uses a module listed above it, which is the healthy direction.
ui.survey uses services.controller, so a change to services.controller can break ui.survey, while a change to ui.survey can't break services.controller.
Position
Below the diagonal: ui.survey uses a module listed above it, which is the healthy direction.
ui.survey.components uses scout.model, so a change to scout.model can break ui.survey.components, while a change to ui.survey.components can't break scout.model.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses survey.model, so a change to survey.model can break ui.survey.components, while a change to ui.survey.components can't break survey.model.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses survey.engine, so a change to survey.engine can break ui.survey.components, while a change to ui.survey.components can't break survey.engine.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses survey.status, so a change to survey.status can break ui.survey.components, while a change to ui.survey.components can't break survey.status.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses ui.scout, so a change to ui.scout can break ui.survey.components, while a change to ui.survey.components can't break ui.scout.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses ui.survey.model, so a change to ui.survey.model can break ui.survey.components, while a change to ui.survey.components can't break ui.survey.model.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.survey.components uses ui.survey, so a change to ui.survey can break ui.survey.components, while a change to ui.survey.components can't break ui.survey.
Position
Below the diagonal: ui.survey.components uses a module listed above it, which is the healthy direction.
ui.signals uses ui.cellular.details.model, so a change to ui.cellular.details.model can break ui.signals, while a change to ui.signals can't break ui.cellular.details.model.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
ui.cellular.details.model uses data.band, so a change to data.band can break ui.cellular.details.model, while a change to ui.cellular.details.model can't break data.band.
Position
Below the diagonal: ui.cellular.details.model uses a module listed above it, which is the healthy direction.
ui.cellular.details.model uses ui.signals, so a change to ui.signals can break ui.cellular.details.model, while a change to ui.cellular.details.model can't break ui.signals.
Position
Below the diagonal: ui.cellular.details.model uses a module listed above it, which is the healthy direction.
ui.wifi.details uses scout.clients, so a change to scout.clients can break ui.wifi.details, while a change to ui.wifi.details can't break scout.clients.
Position
Below the diagonal: ui.wifi.details uses a module listed above it, which is the healthy direction.
ui.wifi.details uses ui.wifi.model, so a change to ui.wifi.model can break ui.wifi.details, while a change to ui.wifi.details can't break ui.wifi.model.
Position
Below the diagonal: ui.wifi.details uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
27
High / Critical
A03:2025 — Software Supply Chain Failures
7
Medium
A07:2025 — Authentication Failures
2
High / Critical
Roadmap
Top priorities: Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing; Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle; Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
Resolve the 1 `generateClientID` spells `ID` where 61 names in the project spell it… finding(s) in Naming Consistency — start with PreferenceUtils.java.
Code Duplication: Near-duplicate member pair (45 shared lines)
How the grades work
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 27
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 295
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 30
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 13
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 47 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 47 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 344 of 352 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt, .java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt, .java) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — a Gradle build resolved 465 artifact(s) across its subprojects (149 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (18 contributor(s) across 1472 commit(s) sampled, automation and bot accounts excluded). One of them holds 93% of the history; the other 17 hold 0.4% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D26 Project Cohesion — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `networksurvey` (107948 LoC, 2431 module-visible types across 102 directories) is over its size bounds, and whether one unit is a coherent whole or a grab-bag is read from its type references: the parts of it that reach the rest only through its shared core. Those are read over the C#/VB code model, which this unit's source did not supply. Its size alone is no verdict on its cohesion, so none is published.
D27 Navigability — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Tracing effort is measured over resolved call sites, and all 359 sampled here came from .kt files. This repository's .java source is a material share of its production lines and contributed none, so the score above is a verdict about the part that was read. Not a finding that the unread half navigates well — it is unmeasured.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `networksurvey/src/main/java/com/craxiom/networksurvey/SimChanges.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/mqtt/profile/MqttBrokerProfileMigration.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/mqtt/profile/MqttBrokerProfileStore.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/scout/firmware/FirmwareFetcher.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiSource.kt`, … (+11 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (networksurvey). the Android app did not build — `./gradlew :networksurvey:assembleDebug` exited 1: m.github.yuriy-budiyev:code-scanner:2.3.2.
> Could not get resource 'https://jitpack.io/com/github/yuriy-budiyev/code-scanner/2.3.2/code-scanner-2.3.2.pom'.
> Could not GET 'https…; runtime evidence skipped (launch chosen because networksurvey/build.gradle applies the Android application plugin and gradlew builds it).
C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X12 Unreachable branch — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X2 Cancellation propagation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch, got, undici, node:http; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
31 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SurveyRecordProcessor.generateBluetoothSurveyRecord at 48. A further 27 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being BandNames.getNrBandName at 80 — they are counted neither in the figure above nor in this dimension's score. 16 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: networksurvey/src/main/java/com/craxiom/networksurvey/util/band/BandNames.java (BandNames.getNrBandName at 80), networksurvey/src/main/java/com/craxiom/networksurvey/util/band/LteBandTable.java (LteBandTable.downlinkLowMhz at 71), networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java (WifiUtils.get6GhzCenterChannelFor40Mhz at 59), networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/CellFieldGrid.kt (CellFieldGridKt.fieldLabel at 29), networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsNetworkTag.kt (NsNetworkTagKt.NsNetworkTag at 28), and 11 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 26 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 4 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with SurveyRecordProcessor.generateBluetoothSurveyRecord (cyclomatic 48), ParserUtils.convertNetworkInfo (cyclomatic 47), NsAnalyticsUploadWorker.doWork (cyclomatic 34). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 4 together lifts Cyclomatic Complexity from 6.8 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 53 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 60 down to 60 or less in Cognitive Complexity — start with ParserUtils.convertNetworkInfo (cognitive 109), SurveyRecordProcessor.generateBluetoothSurveyRecord (cognitive 94), NsAnalyticsUploadWorker.doWork (cognitive 65). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 5.9 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.1 / 10Stronggated by 31 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 13 TooManyMethods finding(s) in God Classes — start with NetworkSurveyService.java, SurveyRecordProcessor.java, GrpcConnectionService.java. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 7 ClassTooLong finding(s) in God Classes — start with NetworkSurveyService.java, SurveyRecordProcessor.java, TowerMapLibreViewModel.kt. — One of this dimension's main actionable groups (7 warning-level).
Resolve the 6 MethodTooLong finding(s) in God Classes — start with CombinedFiltersBottomSheet.kt, AcknowledgmentsRepository.kt, AppNavigation.kt. — One of this dimension's main actionable groups (6 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
69 duplicated block group(s) detected. 3.3 % of the production lines (3,631 of 109,926) are in a reported copy. A further 56 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
Edited copy of a member (15 corresponding lines) · ×4networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:227
Edited copy of a member (12 corresponding lines) · ×4networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:110
+ 75 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 6 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with ProviderColorAddSheet.kt, WifiClientRow.kt, NsAnalyticsDeepLinkHandler.kt. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 5 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with TowerMapLibreViewModel.kt (2), BandFilterBar.kt, TowerBottomSheet.kt. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 5 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with BluetoothDetailsRoute.kt, AppNavigation.kt, ScoutClientRecords.kt. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
2 production modules (Gradle), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 0 module(s) off the main sequence, with abstractness counted on 1 of the 2 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 1 Low cohesion finding(s) in Cohesion (LCOM4) — start with CalculatorViewModel.kt. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 32 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 3 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 15 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 25 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 6 Hotspot finding(s) in Churn × Complexity Hotspots — start with SurveyRecordProcessor.java, NetworkSurveyService.java, SurveyOrchestrator.kt. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 1 Repeated repair finding(s) in Churn × Complexity Hotspots — start with StillToDoPanel.kt. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
6 deducted task-comment markers across 109926 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 3 TodoComment finding(s) in Explicit Debt — start with SharedGnssMeasurementManager.kt (2), WifiUtils.java. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 3 FixmeComment finding(s) in Explicit Debt — start with NsAnalyticsSecureStorage.kt (2), MapUpdater.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 3 document(s) read across 1 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
3 naming inconsistencies among 144 declarations measured against a convention their peers follow.
`LibUIUtils` spells `UI` where 55 names in the project spell it `Ui`networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/util/LibUIUtils.kt:8
`uploadToBeaconDB` spells `DB` where 29 names in the project spell it `Db`networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:35
`generateClientID` spells `ID` where 61 names in the project spell it `Id`networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:600
What to do
Resolve the 1 `LibUIUtils` spells `UI` where 55 names in the project spell it `Ui` finding(s) in Naming Consistency — start with LibUIUtils.kt. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `uploadToBeaconDB` spells `DB` where 29 names in the project spell it… finding(s) in Naming Consistency — start with BeaconDbUploadClient.java. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `generateClientID` spells `ID` where 61 names in the project spell it… finding(s) in Naming Consistency — start with PreferenceUtils.java. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
33 % of calls cross a namespace and 7 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated. Measured over the .kt source only — this repository's .java was not sampled for call sites, so this score covers part of the tree, not all of it.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
27 finding(s): 0 critical, 26 high, 1 medium, 0 low. 21 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 6 file(s) — `gradlew` (line 74, line 178), `networksurvey/src/main/assets/member_uuids.yaml`, `networksurvey/src/main/java/com/craxiom/networksurvey/survey/mdm/RestrictionsSnapshot.kt` (line 90), `networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyScreen.kt` (line 260, line 273), `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiEnvironment.kt` (line 26, line 82), … (+1 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
No action in Static Analysis (SAST) — all 21 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (21 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 587 of the 869 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 3 Change coupling finding(s) in Change Coupling — start with TowerMapScreen.kt (2), MapLibreMap.kt. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 Change-coupling hub finding(s) in Change Coupling — start with TowerSymbols.kt. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 57 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`SurveyRecordDao` declares 35 abstract methods: `deleteAllCdmaRecords`, `deleteAllGsmRecords`, `deleteAllLteRecords`, `deleteAllNrRecords`, `deleteAllUmtsRecords`, `deleteAllWifiRecords`, `deleteUploadedCdmaRecords`, `deleteUploadedGsmRecords`, `deleteUploadedLteRecords`, `deleteUploadedNrRecords`, `deleteUploadedUmtsRecords`, `deleteUploadedWifiRecords`, `getCdmaRecordCountForUpload`, `getCdmaRecordsForUpload`, `getGsmRecordCountForUpload`, `getGsmRecordsForUpload`, `getLteRecordCountForUpload`, `getLteRecordsForUpload`, `getNrRecordCountForUpload`, `getNrRecordsForUpload`, `getUmtsRecordCountForUpload`, `getUmtsRecordsForUpload`, `getWifiRecordCountForUpload`, `getWifiRecordsForUpload`, `markCdmaRecordsAsUploadedToBeaconDb`, `markCdmaRecordsAsUploadedToOcid`, `markGsmRecordsAsUploadedToBeaconDb`, `markGsmRecordsAsUploadedToOcid`, `markLteRecordsAsUploadedToBeaconDb`, `markLteRecordsAsUploadedToOcid`, `markNrRecordsAsUploadedToBeaconDb`, `markNrRecordsAsUploadedToOcid`, `markUmtsRecordsAsUploadedToBeaconDb`, `markUmtsRecordsAsUploadedToOcid`, `markWifiRecordsAsUploadedToBeaconDb`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:17
`SurveyedPointDao` declares 19 abstract methods: `insert`, `inBounds`, `inBoundsWhere`, `inBoundsRecent`, `byIds`, `coarse`, `coarseDominant`, `markUploaded`, `count`, `observeCount`, `observeCountByKind`, `observeSources`, `kindsSince`, `observeLatestNsAnalyticsMissionId`, `missionStartTime`, `observeMaxId`, `trimUploadedOldest`, `trimOldest`, `clear`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyedPointDao.kt:31
`SurveyOutputs` declares 21 abstract methods: `activeTypes`, `isRunning`, `probeDestination`, `probeRecordType`, `communityTargets`, `autoIncludePhoneState`, `mqttSendsWithoutRecordTypes`, `setFileLoggingEnabled`, `startMqtt`, `updateMqttTypes`, `stopMqtt`, `startNsAnalytics`, `updateNsAnalyticsTypes`, `stopNsAnalytics`, `startGrpc`, `updateGrpcTypes`, `stopGrpc`, `startCommunity`, `updateCommunityTypes`, `stopCommunity`, `endMissionSession`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOutputs.kt:14
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 3 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:4
`build.gradle` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — build.gradle:13
What to do
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
What to do
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×17) — networksurvey/src/regular/java/com/craxiom/networksurvey/util/NsCrashReporter.kt:26, networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:104, networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:108, …
`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — networksurvey/src/main/java/com/craxiom/networksurvey/util/CellularUtils.java:295
`catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×5) — networksurvey/src/main/java/com/craxiom/networksurvey/ui/oui/OuiLookupViewModel.kt:114, networksurvey/src/main/java/com/craxiom/networksurvey/ui/manufacturer/ManufacturerUiState.kt:62, networksurvey/src/main/java/com/craxiom/networksurvey/data/ManufacturerResolver.kt:69, …
`catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×4) — networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsRegistration.kt:214, networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/DistanceSymbol.kt:116, networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:155, …
Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 1 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 14 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 67 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — Not applicable: Dagger rejects, at compile time, a component that holds a binding with a narrower scope than its own.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — the Android app did not build — `./gradlew :networksurvey:assembleDebug` exited 1: m.github.yuriy-budiyev:code-scanner:2.3.2.
> Could not get resource 'https://jitpack.io/com/github/yuriy-budiyev/code-scanner/2.3.2/code-scanner-2.3.2.pom'.
> Could not GET 'https…; runtime evidence skipped (launch chosen because networksurvey/build.gradle applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D10 Test Quality — ~38287 lines of test source are present (.kt, .java) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
D12 Dependency Hygiene — Not scored — a Gradle build resolved 465 artifact(s) across its subprojects (149 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
D16 Bus Factor — single-maintainer repository — bus factor is not applicable
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D26 Project Cohesion — D26 could not read how the parts of this repository's one build unit reference each other, so its cohesion was not measured. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 16 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 192 value object(s); 12 domain event(s); its domain events are published by services or handlers — no domain entity raises one
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P2 Observability — This repository's JVM source (1 module(s), 881 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X30 Support guard that admits what it rejects — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Swallowed exception (empty catch) networksurvey/src/regular/java/com/craxiom/networksurvey/util/NsCrashReporter.kt:26— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:104— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:108— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:112— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:119— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:123— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/Circle.kt:127— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:82— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:86— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:93— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:97— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SearchResultSymbols.kt:67— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SearchResultSymbols.kt:71— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SurveyedPoints.kt:93— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SurveyedPoints.kt:97— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerSymbols.kt:197— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerSymbols.kt:202— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
TooManyMethods: NetworkSurveyService networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:185— TooManyMethods — 199 methods. The bar is 30 methods; this is 169 over it, 6.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SurveyRecordProcessor networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:173— TooManyMethods — 117 methods. The bar is 30 methods; this is 87 over it, 3.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GrpcConnectionService networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:86— TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TowerMapLibreViewModel networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:76— TooManyMethods — 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PreferenceUtils networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:57— TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CellularController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:65— TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ScreenActions networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyScreen.kt:94— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. Most of these members implement survey.SurveyActions (32 of 38 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: SurveyViewModel networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyViewModel.kt:59— TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BatteryPauseState networksurvey/src/main/java/com/craxiom/networksurvey/model/BatteryPauseState.java:16— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BluetoothController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:60— TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NsAnalyticsSecureStorage networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsSecureStorage.kt:15— TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: WifiClientsController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiClientsController.kt:43— TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: WifiController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiController.java:43— TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/util/CellularUtils.java:295— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/oui/OuiLookupViewModel.kt:114— `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsRegistration.kt:214— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/manufacturer/ManufacturerUiState.kt:62— `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/DistanceSymbol.kt:116— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:155— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/SurveyedPointsController.kt:229— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/data/ManufacturerResolver.kt:69— `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/data/ManufacturerResolver.kt:81— `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) networksurvey/src/main/java/com/craxiom/networksurvey/data/oui/OuiRepository.kt:152— `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
ClassTooLong: NetworkSurveyService networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:185— ClassTooLong — 1782 significant lines (blank, comment-only and punctuation-only lines excluded), 199 methods. The bar is 400 significant lines; this is 1382 over it, 4.46× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: SurveyRecordProcessor networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:173— ClassTooLong — 1369 significant lines (blank, comment-only and punctuation-only lines excluded), 117 methods. The bar is 400 significant lines; this is 969 over it, 3.42× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TowerMapLibreViewModel networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:76— ClassTooLong — 762 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 362 over it, 1.91× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: GrpcConnectionService networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:86— ClassTooLong — 638 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 238 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CellularController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:65— ClassTooLong — 620 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 400 significant lines; this is 220 over it, 1.55× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: NsAnalyticsUploadWorker networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt:40— ClassTooLong — 464 significant lines (blank, comment-only and punctuation-only lines excluded), 6 methods. The bar is 400 significant lines; this is 64 over it, 1.16× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: BluetoothController networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:60— ClassTooLong — 457 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods. The bar is 400 significant lines; this is 57 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2317— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 48 in SurveyRecordProcessor.generateBluetoothSurveyRecord at line 2317. 2 of those changes were fix/bug commits, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3063— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in NetworkSurveyService.updateLocationListener at line 3063. 5 of those changes were fix/bug commits, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt:189— networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in SurveyOrchestrator.reconcile at line 189. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt:45— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 34 in NsAnalyticsUploadWorker.doWork at line 45. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt:23— networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in SurveyEventMessages.message at line 23. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt:93— networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in WifiListContentKt.WifiListContent at line 93. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
MethodTooLong: CombinedFiltersBottomSheetKt.CombinedFiltersBottomSheet networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:77— MethodTooLong — CombinedFiltersBottomSheet runs 210 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 110 over it, 2.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AcknowledgmentsRepository.getLibraryAcknowledgments networksurvey/src/main/java/com/craxiom/networksurvey/data/AcknowledgmentsRepository.kt:16— MethodTooLong — getLibraryAcknowledgments runs 173 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 73 over it, 1.73× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AppNavigationKt.mainGraph networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:61— MethodTooLong — mainGraph runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ParserUtils.convertNetworkInfo networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:125— MethodTooLong — convertNetworkInfo runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: WatchlistScreenKt.WatchlistScreen networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistScreen.kt:54— MethodTooLong — WatchlistScreen runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UploadSettingsScreenKt.UploadSettingsScreen networksurvey/src/main/java/com/craxiom/networksurvey/ui/settings/UploadSettingsScreen.kt:48— MethodTooLong — UploadSettingsScreen runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorAddSheet.kt:94— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorAddSheet.kt:94-100 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorAddSheet.kt:108-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorAddSheet.kt:94` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/clients/WifiClientRow.kt:56— networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/clients/WifiClientRow.kt:56-62 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/clients/WifiClientsContent.kt:169-175 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/clients/WifiClientRow.kt:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsDeepLinkHandler.kt:48— networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsDeepLinkHandler.kt:48-56 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WatchlistDeepLinkHandler.kt:106-112 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:235— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:235-241 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:306-312 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:119— networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:119-125 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:116-122 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:119` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:57— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:57-63 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDUploadClient.java:61-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
FileTooLong: services/NetworkSurveyService.java networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java— FileTooLong — 1947 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: NetworkSurveyService (185-4586). The bar is 500 significant lines; this is 1447 over it, 3.89× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: services/SurveyRecordProcessor.java networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java— FileTooLong — 1528 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: SurveyRecordProcessor (173-3619). The bar is 500 significant lines; this is 1028 over it, 3.06× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: model/TowerMapLibreViewModel.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt— FileTooLong — 819 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: TowerMapLibreViewModel (76-1434). The bar is 500 significant lines; this is 319 over it, 1.64× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: services/GrpcConnectionService.java networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java— FileTooLong — 713 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: GrpcConnectionService (86-1416). The bar is 500 significant lines; this is 213 over it, 1.43× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: controller/CellularController.java networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java— FileTooLong — 671 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: CellularController (65-1460). The bar is 500 significant lines; this is 171 over it, 1.34× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Duplicated block (12 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:144— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:144-155 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:170-181 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:144` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerBottomSheet.kt:360— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerBottomSheet.kt:360-371 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerBottomSheet.kt:521-532 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerBottomSheet.kt:360` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistRows.kt:137— networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistRows.kt:137-150 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistScreen.kt:99-110 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistRows.kt:137` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:848— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:848-859 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:865-876 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:848` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:882— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:882-893 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:899-910 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:882` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/details/BluetoothDetailsRoute.kt:39— networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/details/BluetoothDetailsRoute.kt:39-49 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/details/WifiDetailsRoute.kt:49-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:373— networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:373-383 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:409-419 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:373` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:41— networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:41-51 | networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:79-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:86— networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:86-96 | networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:107-117 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3148— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3148-3158 | networksurvey/src/main/java/com/craxiom/networksurvey/util/LocationUtils.java:35-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3148` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×4
Edited copy of a member (15 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:227— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:227-241 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:293-312 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/BluetoothListContent.kt:226— networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/BluetoothListContent.kt:226-240 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt:314-328 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/DeepLinkDispatcher.kt:37— networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/DeepLinkDispatcher.kt:37-52 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/DeepLinkDispatcher.kt:54-68 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1361— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1361-1375 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1381-1399 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×4
Edited copy of a member (12 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:110— networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:110-121 | networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:124-135 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1177— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1177-1188 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1194-1205 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsRegistrationFlow.kt:64— networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsRegistrationFlow.kt:64-75 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsRegistrationFlow.kt:121-133 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutCaptureSource.kt:199— networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutCaptureSource.kt:199-211 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiRawController.kt:221-232 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×4
Edited copy of a member (11 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideRows.kt:45— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideRows.kt:45-55 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionRows.kt:34-44 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/LiveDestinationRows.kt:59— networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/LiveDestinationRows.kt:59-69 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt:45-55 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:38— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:38-50 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDUploadClient.java:44-54 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/PlmnLookupScreen.kt:279— networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/PlmnLookupScreen.kt:279-289 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistHistoryScreen.kt:291-301 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (10 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145-154 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:162-171 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:179— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:179-188 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:196-205 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:179` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1363— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1363-1372 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1386-1395 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1363` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:274— networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:274-283 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:317-326 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/RawFramesConfirmation.kt:78— networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/RawFramesConfirmation.kt:78-86 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/sheets/SurveyDialogs.kt:24-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:113— networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:113-121 | networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:127-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/data/plmn/PlmnRepository.kt:113` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/fragments/CodeScannerFragment.java:38— networksurvey/src/main/java/com/craxiom/networksurvey/fragments/CodeScannerFragment.java:38-46 | networksurvey/src/main/java/com/craxiom/networksurvey/fragments/NsAnalyticsQrScannerFragment.java:39-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/fragments/CodeScannerFragment.java:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:216— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:216-224 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:282-290 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:216` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
TodoComment networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:174— // TODO It is unclear how to map the 320 MHz channels — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedGnssMeasurementManager.kt:126— // TODO - surface this state message in UI somewhere, like when user returned from Settings like before? For now just disable logging option in Settings, will surface in Dashboard later — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedGnssMeasurementManager.kt:185— // TODO - surface this state message in UI somewhere, like when user returned from Settings like before? For now just disable logging option in Settings, will surface in Dashboard later — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsSecureStorage.kt:508— // FIXME we don't ever use the registered at time, delete it or use it — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsSecureStorage.kt:509— // FIXME do we store the full QR data and then the part? We only need to store it once — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapUpdater.kt:58— // FIXME I don't think I need this camera update — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Change coupling: TowerMapScreen.kt ↔ MapUpdater.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt:1— `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapUpdater.kt` change together 70% of the time (14 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 14 shared commits counted here, the most recent 3 are `82e9a07b` Load towers onto the map through a session tile cache; `d2f458a9` Use string MCC/MNC across the app to preserve leading zeros; `9a3f4d6b` #95 Add multi-tower display on the map with comments field support — run `git show` on any of them.
Change coupling: MapLibreMap.kt ↔ MapUpdater.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapLibreMap.kt:1— `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapLibreMap.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapUpdater.kt` change together 65% of the time (11 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `82e9a07b` Load towers onto the map through a session tile cache; `9a3f4d6b` #95 Add multi-tower display on the map with comments field support; `21522455` Backup approaches to cleanup maplibre location listener when exiting … — run `git show` on any of them.
Change coupling: TowerMapScreen.kt ↔ MapLibreMap.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt:1— `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapLibreMap.kt` change together 59% of the time (10 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `82e9a07b` Load towers onto the map through a session tile cache; `d345a731` Use different colors in the tower list and for the tower icons on the…; `ebfe7be6` Switch to OpenFreeMap if MapTiler has hit the limit or is unavailable — run `git show` on any of them.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×3
Edited copy of a member (17 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiFields.kt:78— networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiFields.kt:78-96 | networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiFields.kt:100-116 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:777— networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:777-800 | networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:808-824 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:138— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:138-154 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:171-187 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (14 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:139— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:139-152 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt:118-131 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:139` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/community/CommunityDatabasesScreen.kt:189— networksurvey/src/main/java/com/craxiom/networksurvey/ui/community/CommunityDatabasesScreen.kt:189-202 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/logfiles/LogFilesContent.kt:182-195 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/community/CommunityDatabasesScreen.kt:189` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:164— networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:164-177 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:231-244 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:164` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/components/PlmnRow.kt:93— networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/components/PlmnRow.kt:93-97 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/components/PlmnRow.kt:266-270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/plmn/components/PlmnRow.kt:93` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:297— networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:297-301 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:340-344 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:249— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:249-253 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:323-327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:249` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (4 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:274— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:274-291 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:294-311 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:314-331 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:334-351 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:65— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:65-82 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:85-102 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:105-124 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:127-145 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×2
Edited copy of a member (20 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsFilterPill.kt:39— networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsFilterPill.kt:39-58 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/components/WifiModeTabs.kt:136-161 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/oui/OuiLookupScreen.kt:237— networksurvey/src/main/java/com/craxiom/networksurvey/ui/oui/OuiLookupScreen.kt:237-261 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/oui/OuiLookupScreen.kt:264-283 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×2
Edited copy of a member (21 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/HomeNavigation.kt:132— networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/HomeNavigation.kt:132-155 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/HomeNavigation.kt:158-178 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SurveyedPoints.kt:116— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SurveyedPoints.kt:116-136 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerSymbols.kt:225-250 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×2
Edited copy of a member (22 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/CalculatorViewModel.kt:199— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/CalculatorViewModel.kt:199-221 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/CalculatorViewModel.kt:228-249 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:54— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:54-75 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:43-67 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×2
Edited copy of a member (13 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/model/BluetoothDisplayFilter.kt:28— networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/model/BluetoothDisplayFilter.kt:28-40 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiDisplayFilter.kt:36-48 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1506— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1506-1518 | networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1528-1540 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×2
Edited copy of a member (16 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/MissionSessionTracker.kt:124— networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/MissionSessionTracker.kt:124-145 | networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/MissionSessionTracker.kt:152-167 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:519— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:519-534 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1324-1341 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (21 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistDetailRows.kt:104— networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistDetailRows.kt:104-124 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistHistoryRows.kt:147-167 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistDetailRows.kt:104` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (21 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1653— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1653-1673 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1787-1807 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1653` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1785` calls `setConnectionStatus`, `toConnectionStatus`, `setCellBandwidthsIfActive` and `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1652` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:70— networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:70-88 | networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt:70-88 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:959— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:959-977 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1126-1144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:959` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1146` calls `postDelayed`, `getEffectiveScanRateMs` and `networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:978` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (15 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:155— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:155-169 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:195-209 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:155` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:235— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:235-249 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:271-285 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:235` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:217— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:217-224 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CellSearchBottomSheet.kt:270-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsManagedLockSheet.kt:53— networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsManagedLockSheet.kt:53-60 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/sheets/WhatGoesWhereSheet.kt:79-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsManagedLockSheet.kt:53` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:426— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:426-437 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:457-468 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:489-500 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:525-536 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `record` to `GsmRecordData` in one and `UmtsRecordData` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:156— networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:156-167 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:223-234 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:266-277 | networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:309-320 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
SurveyRecordProcessor.generateBluetoothSurveyRecord (cyclomatic 48) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2317— SurveyRecordProcessor.generateBluetoothSurveyRecord has cyclomatic complexity 48 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
ParserUtils.convertNetworkInfo (cyclomatic 47) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:125— ParserUtils.convertNetworkInfo has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NsAnalyticsUploadWorker.doWork (cyclomatic 34) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt:45— NsAnalyticsUploadWorker.doWork has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SurveyRecordProcessor.generateNrSurveyRecord (cyclomatic 31) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1910— SurveyRecordProcessor.generateNrSurveyRecord has cyclomatic complexity 31 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
SurveyOrchestrator.reconcile (cyclomatic 28) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt:189— SurveyOrchestrator.reconcile has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DbUploadStore.onCellularBatch (cyclomatic 27) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:88— DbUploadStore.onCellularBatch has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NetworkSurveyService.updateLocationListener (cyclomatic 27) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3063— NetworkSurveyService.updateLocationListener has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SurveyRecordProcessor.generateLteSurveyRecord (cyclomatic 27) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1720— SurveyRecordProcessor.generateLteSurveyRecord has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
SurveyRecordProcessor.generateGsmSurveyRecord (cyclomatic 25) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1383— SurveyRecordProcessor.generateGsmSurveyRecord has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
ScoutWifiFields.cipherSuite (cyclomatic 24) networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiFields.kt:78— ScoutWifiFields.cipherSuite has cyclomatic complexity 24 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
NetworkSurveyService.applyListenerTypes (cyclomatic 24) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1029— NetworkSurveyService.applyListenerTypes has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file's highest cyclomatic complexity: NetworkSurveyService.onSharedPreferenceChanged (cyclomatic 27) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
NetworkSurveyService.toggleUploadRecordSavingLocked (cyclomatic 23) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:2190— NetworkSurveyService.toggleUploadRecordSavingLocked has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: NetworkSurveyService.onSharedPreferenceChanged (cyclomatic 27) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
SurveyRecordProcessor.generateUmtsSurveyRecord (cyclomatic 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1595— SurveyRecordProcessor.generateUmtsSurveyRecord has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
WifiListContentKt.WifiListContent (cyclomatic 21) networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt:93— WifiListContentKt.WifiListContent has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ScoutWifiFields.akmSuite (cyclomatic 20) networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiFields.kt:100— ScoutWifiFields.akmSuite has cyclomatic complexity 20 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
SurveyEventMessages.message (cyclomatic 20) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt:23— SurveyEventMessages.message has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
NsAnalyticsUploadTracker.handleUploadWorkChanges (cyclomatic 18) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsUploadTracker.kt:96— NsAnalyticsUploadTracker.handleUploadWorkChanges has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeviceStatusCsvLogger.convertToObjectArray (cyclomatic 18) networksurvey/src/main/java/com/craxiom/networksurvey/logging/DeviceStatusCsvLogger.java:82— DeviceStatusCsvLogger.convertToObjectArray has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LteCsvLogger.convertToObjectArray (cyclomatic 18) networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:87— LteCsvLogger.convertToObjectArray has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NrCsvLogger.convertToObjectArray (cyclomatic 18) networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:86— NrCsvLogger.convertToObjectArray has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
OuiRepository.lookup (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/data/oui/OuiRepository.kt:57— OuiRepository.lookup has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
SatelliteTableKt.HeaderCell (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/status/SatelliteTable.kt:124— SatelliteTableKt.HeaderCell has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SurveyOrchestrator.startOrUpdate (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt:326— SurveyOrchestrator.startOrUpdate has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
SurveySetupMigration.migrateUpgradingUser (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/survey/setup/SurveySetupMigration.kt:146— SurveySetupMigration.migrateUpgradingUser has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SurveyEventMessages.scoutItemRes (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt:130— SurveyEventMessages.scoutItemRes has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SurveyRecordProcessor.processCellInfo (cyclomatic 17) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1066— SurveyRecordProcessor.processCellInfo has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java holds 6 of the 31 methods over the threshold — including the worst — and 80 of the 237 points over it (34%), 2.5× the next-largest file (networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java at 32). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
LegacyMdmMapper.map (cyclomatic 16) networksurvey/src/main/java/com/craxiom/networksurvey/survey/mdm/LegacyMdmMapper.kt:76— LegacyMdmMapper.map has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ServingCellSummary.from (cyclomatic 16) networksurvey/src/main/java/com/craxiom/networksurvey/ui/map/ServingCellSummary.kt:81— ServingCellSummary.from has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NsAnalyticsDialogsKt.NsAnalyticsDialogs (cyclomatic 16) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsDialogs.kt:35— NsAnalyticsDialogsKt.NsAnalyticsDialogs has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CdrSmsObserver.onChange (cyclomatic 16) networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:53— CdrSmsObserver.onChange has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DbUploadStore.mapNrRecordToEntity (cyclomatic 16) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:519— DbUploadStore.mapNrRecordToEntity has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Repeated repair: networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt:39— networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is StillToDoPanelKt.StillToDoPanel at line 39), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix data, copy and layout bugs found while preparing the 2.0 docs”; “Fix the follow-ups from testing v2 on a phone”; “Fix what the pre-merge review of v2 found”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-09..2026-11-07, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-09 10:09:03 -05:00' --until='2026-11-07 10:09:03 -05:00' --full-history --no-merges -- networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
ParserUtils.convertNetworkInfo (cognitive 109) networksurvey/src/main/java/com/craxiom/networksurvey/util/ParserUtils.java:125— ParserUtils.convertNetworkInfo has cognitive complexity 109 (threshold 15). Drivers by points: if/else 41 (104 pts), boolean chains 5 (nesting depth added 63). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.generateBluetoothSurveyRecord (cognitive 94) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2317— SurveyRecordProcessor.generateBluetoothSurveyRecord has cognitive complexity 94 (threshold 15). Drivers by points: if/else 32 (61 pts), loops 4 (19 pts), boolean chains 10, ternaries 3 (4 pts) (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NsAnalyticsUploadWorker.doWork (cognitive 65) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/NsAnalyticsUploadWorker.kt:45— NsAnalyticsUploadWorker.doWork has cognitive complexity 65 (threshold 15). Drivers by points: if/else 25 (51 pts), match/switch 2 (7 pts), boolean chains 5, error handling 1, loops 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyOrchestrator.reconcile (cognitive 42) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt:189— SurveyOrchestrator.reconcile has cognitive complexity 42 (threshold 15). Drivers by points: if/else 20 (31 pts), loops 5, boolean chains 4, match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NetworkSurveyService.updateLocationListener (cognitive 40) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3063— NetworkSurveyService.updateLocationListener has cognitive complexity 40 (threshold 15). Drivers by points: if/else 20 (31 pts), boolean chains 7, error handling 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.generateNrSurveyRecord (cognitive 38) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1910— SurveyRecordProcessor.generateNrSurveyRecord has cognitive complexity 38 (threshold 15). Drivers by points: if/else 27 (34 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DbUploadStore.onCellularBatch (cognitive 37) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:88— DbUploadStore.onCellularBatch has cognitive complexity 37 (threshold 15). Drivers by points: if/else 18 (33 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CdrSmsObserver.onChange (cognitive 36) networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrSmsObserver.java:53— CdrSmsObserver.onChange has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (27 pts), error handling 2 (8 pts), boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.generateLteSurveyRecord (cognitive 34) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1720— SurveyRecordProcessor.generateLteSurveyRecord has cognitive complexity 34 (threshold 15). Drivers by points: if/else 22 (30 pts), boolean chains 4 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NsAnalyticsUploadTracker.handleUploadWorkChanges (cognitive 33) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsUploadTracker.kt:96— NsAnalyticsUploadTracker.handleUploadWorkChanges has cognitive complexity 33 (threshold 15). Drivers by points: if/else 13 (29 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 17). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
NetworkSurveyService.toggleUploadRecordSavingLocked (cognitive 33) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:2190— NetworkSurveyService.toggleUploadRecordSavingLocked has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (24 pts), boolean chains 7, error handling 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServingCellSummary.from (cognitive 32) networksurvey/src/main/java/com/craxiom/networksurvey/ui/map/ServingCellSummary.kt:81— ServingCellSummary.from has cognitive complexity 32 (threshold 15). Drivers by points: if/else 21 (31 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SurveyRecordProcessor.generateGsmSurveyRecord (cognitive 31) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1383— SurveyRecordProcessor.generateGsmSurveyRecord has cognitive complexity 31 (threshold 15). Drivers by points: if/else 16 (23 pts), boolean chains 8 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.processCellInfo (cognitive 31) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1066— SurveyRecordProcessor.processCellInfo has cognitive complexity 31 (threshold 15). Drivers by points: if/else 14 (29 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ScoutLinkController.runLink (cognitive 29) networksurvey/src/main/java/com/craxiom/networksurvey/scout/ScoutLinkController.kt:168— ScoutLinkController.runLink has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (21 pts), error handling 3 (6 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WifiListContentKt.WifiListContent (cognitive 29) networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt:93— WifiListContentKt.WifiListContent has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19 (21 pts), boolean chains 6, match/switch 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SurveyRecordProcessor.generateUmtsSurveyRecord (cognitive 29) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1595— SurveyRecordProcessor.generateUmtsSurveyRecord has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19 (27 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TowerKey.from (cognitive 27) networksurvey/src/main/java/com/craxiom/networksurvey/model/TowerKey.kt:35— TowerKey.from has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (25 pts), boolean chains 1, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
TowerMapLibreViewModel.searchForTower (cognitive 27) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:1254— TowerMapLibreViewModel.searchForTower has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (25 pts), boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
SurveyedPointSheetKt.PointDetails (cognitive 26) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SurveyedPointSheet.kt:180— SurveyedPointSheetKt.PointDetails has cognitive complexity 26 (threshold 15). Drivers by points: if/else 19 (25 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SurveyEventMessages.scoutItemRes (cognitive 25) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/SurveyEventMessages.kt:130— SurveyEventMessages.scoutItemRes has cognitive complexity 25 (threshold 15). Drivers by points: if/else 16 (24 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
CellularController.initializeCellularScanningResources (cognitive 25) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:599— CellularController.initializeCellularScanningResources has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 2 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NetworkSurveyService.generateDeviceStatus (cognitive 25) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3353— NetworkSurveyService.generateDeviceStatus has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (25 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
SurveyRecordProcessor.generateGnssSurveyRecord (cognitive 25) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2555— SurveyRecordProcessor.generateGnssSurveyRecord has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (25 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UploadSettingsScreenKt.UploadSettingsScreen (cognitive 23) networksurvey/src/main/java/com/craxiom/networksurvey/ui/settings/UploadSettingsScreen.kt:48— UploadSettingsScreenKt.UploadSettingsScreen has cognitive complexity 23 (threshold 15). Drivers by points: if/else 17 (21 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
NetworkSurveyService.toggleNsAnalyticsScanningLocked (cognitive 23) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:2352— NetworkSurveyService.toggleNsAnalyticsScanningLocked has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 3 (4 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WatchlistDetectionManager.findMatch (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/watchlist/WatchlistDetectionManager.kt:148— WatchlistDetectionManager.findMatch has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LegacyMdmMapper.map (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/survey/mdm/LegacyMdmMapper.kt:76— LegacyMdmMapper.map has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 7 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CombinedFiltersBottomSheetKt.CombinedFiltersBottomSheet (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/CombinedFiltersBottomSheet.kt:77— CombinedFiltersBottomSheetKt.CombinedFiltersBottomSheet has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 4, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CellularController.runSingleScan (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:904— CellularController.runSingleScan has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (15 pts), error handling 3, loops 2 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GnssController.startGnssRecordScanning (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/GnssController.java:331— GnssController.startGnssRecordScanning has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (22 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BatteryMonitor.checkThresholdCrossing (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/BatteryMonitor.java:225— BatteryMonitor.checkThresholdCrossing has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 3 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrpcConnectionService.onStartCommand (cognitive 22) networksurvey/src/main/java/com/craxiom/networksurvey/services/GrpcConnectionService.java:351— GrpcConnectionService.onStartCommand has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 3 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OtaChunkSender.run (cognitive 21) networksurvey/src/main/java/com/craxiom/networksurvey/scout/firmware/OtaChunkSender.kt:47— OtaChunkSender.run has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Radiotap.header (cognitive 21) networksurvey/src/main/java/com/craxiom/networksurvey/scout/raw/Radiotap.kt:40— Radiotap.header has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (15 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LogFilesContentKt.LogFilesContent (cognitive 21) networksurvey/src/main/java/com/craxiom/networksurvey/ui/logfiles/LogFilesContent.kt:52— LogFilesContentKt.LogFilesContent has cognitive complexity 21 (threshold 15). Drivers by points: if/else 17 (20 pts), match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
3.run (cognitive 21) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1069— 3.run has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (14 pts), error handling 3, loops 2 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.generateWiFiBeaconSurveyRecord (cognitive 21) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2185— SurveyRecordProcessor.generateWiFiBeaconSurveyRecord has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (19 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServingCellMapper.lte (cognitive 20) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/model/ServingCellMapper.kt:106— ServingCellMapper.lte has cognitive complexity 20 (threshold 15). Drivers by points: if/else 20. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MapLibreMapKt.lifecycleObserver (cognitive 20) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapLibreMap.kt:233— MapLibreMapKt.lifecycleObserver has cognitive complexity 20 (threshold 15). Drivers by points: error handling 4 (9 pts), if/else 5 (9 pts), boolean chains 1, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ScoutPlateKt.ScoutPlate (cognitive 20) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/ScoutPlate.kt:23— ScoutPlateKt.ScoutPlate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 3, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyOrchestrator.applyFileLogging (cognitive 19) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOrchestrator.kt:361— SurveyOrchestrator.applyFileLogging has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 4, loops 3, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyRecordProcessor.generateCdmaSurveyRecord (cognitive 19) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1502— SurveyRecordProcessor.generateCdmaSurveyRecord has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TowerMapScreenKt.MapMessages (cognitive 18) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt:507— TowerMapScreenKt.MapMessages has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 6 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServingCellMapper.nr (cognitive 18) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/model/ServingCellMapper.kt:143— ServingCellMapper.nr has cognitive complexity 18 (threshold 15). Drivers by points: if/else 18. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NsAnalyticsDialogsKt.NsAnalyticsDialogs (cognitive 18) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsDialogs.kt:35— NsAnalyticsDialogsKt.NsAnalyticsDialogs has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 3, match/switch 1 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SurveyUiStateMapper.destinationRows (cognitive 18) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/model/SurveyUiStateMapper.kt:119— SurveyUiStateMapper.destinationRows has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 4, match/switch 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
NetworkSurveyService.applyListenerTypes (cognitive 18) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1029— NetworkSurveyService.applyListenerTypes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (8 pts), match/switch 2 (6 pts), boolean chains 2, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CommunityDatabasesScreenKt.CommunityDatabasesContent (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/ui/community/CommunityDatabasesScreen.kt:106— CommunityDatabasesScreenKt.CommunityDatabasesContent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 14 (15 pts), boolean chains 1, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NsAnalyticsConnectionViewModel.toggleAutoUpload (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/ui/nsanalytics/NsAnalyticsConnectionViewModel.kt:344— NsAnalyticsConnectionViewModel.toggleAutoUpload has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 1, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SurveyUiStateMapper.map (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/model/SurveyUiStateMapper.kt:22— SurveyUiStateMapper.map has cognitive complexity 17 (threshold 15). Drivers by points: if/else 14, boolean chains 3. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DeviceStatusCsvLogger.convertToObjectArray (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/logging/DeviceStatusCsvLogger.java:82— DeviceStatusCsvLogger.convertToObjectArray has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 13, boolean chains 4. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LteCsvLogger.convertToObjectArray (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:87— LteCsvLogger.convertToObjectArray has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 17. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NrCsvLogger.convertToObjectArray (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:86— NrCsvLogger.convertToObjectArray has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 17. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
CellularController.buildNetworkTechnologyInfo (cognitive 17) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:761— CellularController.buildNetworkTechnologyInfo has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MqttBrokerEditorContentKt.MqttBrokerEditorContent (cognitive 16) networksurvey/src/main/java/com/craxiom/networksurvey/ui/mqtt/MqttBrokerEditorContent.kt:54— MqttBrokerEditorContentKt.MqttBrokerEditorContent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12, boolean chains 2, match/switch 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
CredentialSecureStorage.migrateFromPlainTextIfNeeded (cognitive 16) networksurvey/src/main/java/com/craxiom/networksurvey/util/CredentialSecureStorage.kt:152— CredentialSecureStorage.migrateFromPlainTextIfNeeded has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11, boolean chains 4, error handling 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SurveyRecordProcessor.generateEmptyGnssSurveyRecord (cognitive 16) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2652— SurveyRecordProcessor.generateEmptyGnssSurveyRecord has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (16 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
Change-coupling hub: TowerSymbols.kt → TowerMapScreen.kt, TowerMapLibreViewModel.kt, MapLibreMap.kt, MapUpdater.kt, TowerBottomSheet.kt networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerSymbols.kt— `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerSymbols.kt` changes together with 5 other files — `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapScreen.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapLibreMap.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/MapUpdater.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/TowerBottomSheet.kt` — none of which declares a dependency on it: one file is the hub of 5 separate couplings, not 5 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 5.
Near-duplicate member pair (45 shared lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:132— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:132-238 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt:111-214 — These two members are variants of one another: 45 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Members sharing a duplicated core (11 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (11 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3354— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3354-3444 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:983-1039 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1384-1494 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1503-1587 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1596-1712 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1721-1871 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1911-2087 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2186-2273 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2318-2545 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2556-2644 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2653-2707 — These 11 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 11 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 11 times.
D4 · Code Duplication· Members sharing a duplicated core (10 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (10 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:110— networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:110-139 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:79-106 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/DeviceStatusCsvLogger.java:83-126 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GnssCsvLogger.java:84-114 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:80-108 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:88-125 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:87-122 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/PhoneStateCsvLogger.java:81-121 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/UmtsCsvLogger.java:81-110 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiCsvLogger.java:87-127 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (6 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:238— networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:238-258 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:277-318 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:354-382 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:399-419 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:850-901 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:933-979 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:421— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:421-449 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:452-481 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:484-517 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:520-553 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:556-594 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication· Edited copy of a member (38 corresponding lines) · ×1
Edited copy of a member (38 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/model/CellularRecordWrapper.java:98— networksurvey/src/main/java/com/craxiom/networksurvey/model/CellularRecordWrapper.java:98-135 | networksurvey/src/main/java/com/craxiom/networksurvey/util/CellularUtils.java:335-380 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (82 corresponding lines) · ×1
Edited copy of a member (82 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:905— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:905-986 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1063-1156 — These two members are one piece of code written twice and then edited apart: 82 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (30 corresponding lines) · ×1
Edited copy of a member (30 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:35— networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:35-64 | networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientRecords.kt:73-106 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (49 corresponding lines) · ×1
Edited copy of a member (49 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistDetailRows.kt:90— networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistDetailRows.kt:90-138 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistHistoryRows.kt:132-182 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (41 corresponding lines) · ×1
Edited copy of a member (41 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/theme/Color.kt:18— networksurvey/src/main/java/com/craxiom/networksurvey/ui/theme/Color.kt:18-58 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/theme/Color.kt:61-101 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (32 corresponding lines) · ×1
Edited copy of a member (32 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:193— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:193-224 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:256-290 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×1
Edited copy of a member (14 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiClientCsvLogger.java:62— networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiClientCsvLogger.java:62-75 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiProbeCsvLogger.java:65-81 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 29+ corresponding lines) · ×1
Edited copies of one member (4 members, 29+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/details/BluetoothDetailsScreen.kt:233— networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/details/BluetoothDetailsScreen.kt:233-263 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/BluetoothListContent.kt:171-210 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt:261-289 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/components/WifiBlockedNotice.kt:29-60 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 29 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:129— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:129-155 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/bands/BandFilterBar.kt:158-181 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 39+ corresponding lines) · ×1
Edited copies of one member (4 members, 39+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:286— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:286-328 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:410-449 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/GnssController.java:242-280 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiController.java:291-333 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 39 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×1
Edited copy of a member (29 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:366— networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:366-399 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/AppNavigation.kt:402-430 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×1
Edited copy of a member (8 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/model/CellularNeighbors.kt:88— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/model/CellularNeighbors.kt:88-95 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/model/CellularNeighbors.kt:97-105 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/BatteryMonitor.java:293— networksurvey/src/main/java/com/craxiom/networksurvey/services/BatteryMonitor.java:293-320 | networksurvey/src/main/java/com/craxiom/networksurvey/services/BatteryMonitor.java:326-353 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 10+ corresponding lines) · ×1
Edited copies of one member (4 members, 10+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDCsvFormatter.java:103— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDCsvFormatter.java:103-112 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDCsvFormatter.java:115-124 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDCsvFormatter.java:127-137 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDCsvFormatter.java:140-150 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×1
Edited copy of a member (10 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/fragments/model/MqttConnectionSettings.java:169— networksurvey/src/main/java/com/craxiom/networksurvey/fragments/model/MqttConnectionSettings.java:169-178 | networksurvey/src/main/java/com/craxiom/networksurvey/fragments/model/MqttConnectionSettings.java:182-199 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 15+ corresponding lines) · ×1
Edited copies of one member (3 members, 15+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2864— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2864-2884 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2914-2928 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2936-2956 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:85— networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:85-103 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/CsvRecordLogger.java:204-225 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 18+ corresponding lines) · ×1
Edited copies of one member (3 members, 18+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1388— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1388-1405 | networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1440-1460 | networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:1672-1689 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (8 members, 15+ corresponding lines) · ×1
Edited copies of one member (8 members, 15+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3022— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3022-3037 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3045-3060 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3068-3083 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3092-3107 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3116-3130 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3341-3356 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3416-3431 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:3604-3618 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×1
Edited copies of one member (3 members, 6+ corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:50— networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:50-55 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:58-63 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:57-62 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (5 corresponding lines) · ×1
Edited copy of a member (5 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiCsvLogger.java:61— networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiCsvLogger.java:61-68 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiProbeCsvLogger.java:46-50 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×1
Edited copy of a member (6 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/model/CellularRecordWrapper.java:41— networksurvey/src/main/java/com/craxiom/networksurvey/model/CellularRecordWrapper.java:41-49 | networksurvey/src/main/java/com/craxiom/networksurvey/model/ConstellationFreqKey.java:56-61 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×1
Edited copy of a member (4 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/survey/model/Destination.kt:31— networksurvey/src/main/java/com/craxiom/networksurvey/survey/model/Destination.kt:31-34 | networksurvey/src/main/java/com/craxiom/networksurvey/survey/model/RecordType.kt:39-42 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×1
Edited copy of a member (9 corresponding lines) networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsManagedLockSheet.kt:33— networksurvey/src/main/java/com/craxiom/networksurvey/ui/common/NsManagedLockSheet.kt:33-41 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/sheets/WhatGoesWhereSheet.kt:66-74 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (24 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:157— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:157-180 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt:136-159 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:157` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:95— networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:95-117 | networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt:95-117 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:47— networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt:47-63 | networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt:47-63 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/util/CryptoManager.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/util/NsAnalyticsCryptoManager.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15–16 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/grpc/GrpcServerContent.kt:113— networksurvey/src/main/java/com/craxiom/networksurvey/ui/grpc/GrpcServerContent.kt:113-128 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/mqtt/MqttBrokersContent.kt:118-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/grpc/GrpcServerContent.kt:113` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/logfiles/LogFilesContent.kt:180— networksurvey/src/main/java/com/craxiom/networksurvey/ui/logfiles/LogFilesContent.kt:180-194 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/mqtt/MqttBrokersContent.kt:122-134 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/logfiles/LogFilesContent.kt:180` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–12 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/DestinationRows.kt:102— networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/DestinationRows.kt:102-113 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/LiveDestinationRows.kt:80-89 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/StillToDoPanel.kt:60-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/components/DestinationRows.kt:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145-153 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:162-170 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:179-187 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:196-204 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/SurveyedPointDetails.kt:145` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:192— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:192-201 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/watchlist/WatchlistScreen.kt:139-145 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt:171-177 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt` and `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/SsidExclusionListScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/ProviderColorOverrideScreen.kt:192` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5–6 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/spectrum/SpectrumInterpolator.kt:39— networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/spectrum/SpectrumInterpolator.kt:39-43 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/spectrum/SpectrumInterpolator.kt:47-52 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/spectrum/SpectrumInterpolator.kt:47` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:79— networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:79-88 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/LineString.kt:90-99 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/towermap/SearchResultSymbols.kt:64-73 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (9 lines × 5) networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum24ViewModel.kt:18— networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum24ViewModel.kt:18-26 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum5Group1ViewModel.kt:18-26 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum5Group2ViewModel.kt:18-26 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum5Group3ViewModel.kt:18-26 | networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiSpectrum6ViewModel.kt:18-26 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (42 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2559— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2559-2600 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2658-2699 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2655` calls `now`, `elapsedRealtime` and `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2557` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (30–32 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:922— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:922-953 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:1091-1120 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/CellularController.java:922` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 8) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:988— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:988-1009 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1411-1432 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1530-1551 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1624-1645 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1756-1777 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1983-2004 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2194-2215 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2330-2351 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (18 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:104— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:104-121 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/ocid/OpenCelliDUploadClient.java:141-158 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16–17 lines × 10) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:998— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:998-1014 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1421-1436 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1540-1555 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1634-1649 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1766-1781 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1993-2008 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2204-2219 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2340-2355 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2582-2597 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2681-2696 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:998` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:275— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:275-287 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:295-307 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:315-327 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:335-347 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `data` to `GsmRecordData` in one and `UmtsRecordData` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 9) networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113— networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113-121 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:82-90 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GnssCsvLogger.java:87-95 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:83-91 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:93-101 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:90-98 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/PhoneStateCsvLogger.java:104-112 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/UmtsCsvLogger.java:84-92 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiCsvLogger.java:95-103 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:91` calls `getLteBandwidth` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:111` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 6) networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:239— networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:239-246 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:278-285 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:355-362 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:400-407 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:851-858 | networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:934-941 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:239` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 5) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:423— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:423-430 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:454-461 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:486-493 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:522-529 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:558-565 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `record` to `GsmRecordData` in one and `UmtsRecordData` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:431` calls `getGroupNumber` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:566` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 10) networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113— networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113-119 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:82-88 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/DeviceStatusCsvLogger.java:95-101 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GnssCsvLogger.java:87-93 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:83-89 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:93-99 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:90-96 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/PhoneStateCsvLogger.java:104-110 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/UmtsCsvLogger.java:84-90 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/WifiCsvLogger.java:95-101 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:91` calls `getLteBandwidth` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/BluetoothCsvLogger.java:111` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:66— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:66-72 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:86-92 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:106-112 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/GeosubmitJsonFormatter.java:128-134 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `record` to `GsmRecordEntity` in one and `UmtsRecordEntity` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 11) networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3367— networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3367-3372 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:991-996 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1414-1419 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1533-1538 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1627-1632 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1759-1764 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1986-1991 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2197-2202 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2333-2338 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2562-2567 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:2661-2666 — there are 11 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 11 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3367` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:444— networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:444-449 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:476-481 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:548-553 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/DbUploadStore.java:444` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `record` to `GsmRecordData` in one and `UmtsRecordData` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:228— networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:228-233 | networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:294-299 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/util/WifiUtils.java:228` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (4–5 lines × 4) networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:100— networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:100-103 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:104-108 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:113-116 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/UmtsCsvLogger.java:106-110 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:104` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:103` calls `getDeviceSerialNumber`, `getLocationAge`, `valueOf` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:108` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (3–5 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1437— networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1437-1439 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1558-1562 | networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1652-1656 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1558` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1557` calls `setGroupNumber`, `get`, `setServingCell` and `networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java:1437` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 8) networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:64— networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java:64-72 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/DeviceStatusCsvLogger.java:68-76 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GnssCsvLogger.java:69-77 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java:65-73 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/LteCsvLogger.java:73-81 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/NrCsvLogger.java:72-80 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/PhoneStateCsvLogger.java:66-74 | networksurvey/src/main/java/com/craxiom/networksurvey/logging/UmtsCsvLogger.java:66-74 — before extracting anything, compare `networksurvey/src/main/java/com/craxiom/networksurvey/logging/CdmaCsvLogger.java` and `networksurvey/src/main/java/com/craxiom/networksurvey/logging/GsmCsvLogger.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `record` to `CdmaRecord` in one and `DeviceStatus` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 3) networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:535— networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/BluetoothController.java:535-546 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/GnssController.java:469-480 | networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiController.java:401-412 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Low cohesion: CalculatorViewModel (LCOM4 6) networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/CalculatorViewModel.kt:30— CalculatorViewModel's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java:3146— `Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && locationManager.isProviderEnabled(LocationManager.FUSED_PROVIDER)` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java, networksurvey/src/main/java/com/craxiom/networksurvey/util/LocationUtils.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/AutoUploadManager.java:148— `batteryMonitor != null && batteryMonitor.isPausedDueToBattery()` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/AutoUploadManager.java, networksurvey/src/main/java/com/craxiom/networksurvey/services/NetworkSurveyService.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:172— `bluetoothRecords == null || bluetoothRecords.isEmpty()` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java, networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java:139— `wifiBeaconRecords == null || wifiBeaconRecords.isEmpty()` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/NsAnalyticsDataStore.java, networksurvey/src/main/java/com/craxiom/networksurvey/services/SurveyRecordProcessor.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedGnssMeasurementManager.kt:67— `!context.hasPermission(Manifest.permission.ACCESS_FINE_LOCATION) || !context.hasPermission(Manifest.permission.ACCESS_COARSE_LOCATION)` appears character-identically in 5 files — networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedGnssMeasurementManager.kt, networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedGnssStatusManager.kt, networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedLocationManager.kt, networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/gnss/data/SharedNmeaManager.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/BluetoothListContent.kt:146— `!listState.isScrollInProgress && listState.firstVisibleItemIndex == 0 && listState.firstVisibleItemScrollOffset == 0` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/BluetoothListContent.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/WifiListContent.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientPipeline.kt:215— `!settings.liveViews || (last != null && nowMs - last < settings.snapshotIntervalMs)` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/scout/clients/ScoutClientPipeline.kt, networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiPipeline.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/model/RecordingUiMapper.kt:48— `form.allTypesManaged && form.allDestinationsManaged` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/model/RecordingUiMapper.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/survey/model/SurveyUiStateMapper.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt:710— `it?.cellularRecord != null && CellularUtils.isServingCell(it.cellularRecord)` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/model/TowerMapLibreViewModel.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/map/MapTabViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/GnssEnvironment.kt:47— `locationManager != null && !LocationManagerCompat.isLocationEnabled(locationManager)` appears character-identically in 4 files — networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/GnssEnvironment.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/model/BluetoothEnvironment.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/details/CellularEnvironment.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/wifi/model/WifiEnvironment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/sky/SkyPage.kt:128— `maxWidth >= GNSS_TWO_PANE_MIN_WIDTH && maxWidth > maxHeight` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/sky/SkyPage.kt, networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/ui/status/StatusPage.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/notification/SurveyNotificationState.kt:84— `pausedForBattery || pausedForBackpressure` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/notification/SurveyNotificationState.kt, networksurvey/src/main/java/com/craxiom/networksurvey/ui/main/SurveyStatusViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/scout/firmware/FirmwareInstaller.kt:239— `response.result == ResultCode.RESULT_CODE_OK || response.result == ResultCode.RESULT_CODE_INCOMPATIBLE` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/scout/firmware/FirmwareInstaller.kt, networksurvey/src/main/java/com/craxiom/networksurvey/scout/link/ScoutSession.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiClientsController.kt:191— `scoutManager.pairedScout.value != null && scoutManager.wifiSource.value == WifiSource.SCOUT` appears character-identically in 2 files — networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiClientsController.kt, networksurvey/src/main/java/com/craxiom/networksurvey/services/controller/WifiRawController.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Fat interface: SurveyRecordDao (35 abstract methods) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:17— `SurveyRecordDao` declares 35 abstract methods: `deleteAllCdmaRecords`, `deleteAllGsmRecords`, `deleteAllLteRecords`, `deleteAllNrRecords`, `deleteAllUmtsRecords`, `deleteAllWifiRecords`, `deleteUploadedCdmaRecords`, `deleteUploadedGsmRecords`, `deleteUploadedLteRecords`, `deleteUploadedNrRecords`, `deleteUploadedUmtsRecords`, `deleteUploadedWifiRecords`, `getCdmaRecordCountForUpload`, `getCdmaRecordsForUpload`, `getGsmRecordCountForUpload`, `getGsmRecordsForUpload`, `getLteRecordCountForUpload`, `getLteRecordsForUpload`, `getNrRecordCountForUpload`, `getNrRecordsForUpload`, `getUmtsRecordCountForUpload`, `getUmtsRecordsForUpload`, `getWifiRecordCountForUpload`, `getWifiRecordsForUpload`, `markCdmaRecordsAsUploadedToBeaconDb`, `markCdmaRecordsAsUploadedToOcid`, `markGsmRecordsAsUploadedToBeaconDb`, `markGsmRecordsAsUploadedToOcid`, `markLteRecordsAsUploadedToBeaconDb`, `markLteRecordsAsUploadedToOcid`, `markNrRecordsAsUploadedToBeaconDb`, `markNrRecordsAsUploadedToOcid`, `markUmtsRecordsAsUploadedToBeaconDb`, `markUmtsRecordsAsUploadedToOcid`, `markWifiRecordsAsUploadedToBeaconDb`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: SurveyedPointDao (19 abstract methods) networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyedPointDao.kt:31— `SurveyedPointDao` declares 19 abstract methods: `insert`, `inBounds`, `inBoundsWhere`, `inBoundsRecent`, `byIds`, `coarse`, `coarseDominant`, `markUploaded`, `count`, `observeCount`, `observeCountByKind`, `observeSources`, `kindsSince`, `observeLatestNsAnalyticsMissionId`, `missionStartTime`, `observeMaxId`, `trimUploadedOldest`, `trimOldest`, `clear`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: SurveyOutputs (21 abstract methods) networksurvey/src/main/java/com/craxiom/networksurvey/survey/engine/SurveyOutputs.kt:14— `SurveyOutputs` declares 21 abstract methods: `activeTypes`, `isRunning`, `probeDestination`, `probeRecordType`, `communityTargets`, `autoIncludePhoneState`, `mqttSendsWithoutRecordTypes`, `setFileLoggingEnabled`, `startMqtt`, `updateMqttTypes`, `stopMqtt`, `startNsAnalytics`, `updateNsAnalyticsTypes`, `stopNsAnalytics`, `startGrpc`, `updateGrpcTypes`, `stopGrpc`, `startCommunity`, `updateCommunityTypes`, `stopCommunity`, `endMissionSession`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
No ADRs found networksurvey/build.gradle:2— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `networksurvey/build.gradle` makes this repository a deployable product (line 2).
D21 · Naming Consistency· `LibUIUtils` spells `UI` where 55 names in the project spell it `Ui` · ×1
`LibUIUtils` spells `UI` where 55 names in the project spell it `Ui` networksurvey/src/main/java/com/craxiom/networksurvey/gpstest/util/LibUIUtils.kt:8— 55 of 56 names in project networksurvey spell the token `Ui` (55 of 56; unit: names in project networksurvey containing `Ui`). Peers: com.craxiom.networksurvey.ui.acknowledgments.AcknowledgmentsUiState (networksurvey/src/main/java/com/craxiom/networksurvey/ui/acknowledgments/AcknowledgmentsViewModel.kt:43); com.craxiom.networksurvey.ui.bluetooth.list.model.BluetoothListUiState (networksurvey/src/main/java/com/craxiom/networksurvey/ui/bluetooth/list/model/BluetoothListUiState.kt:32); com.craxiom.networksurvey.ui.cellular.TowerMapUiStateKt (networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapUiState.kt:1); com.craxiom.networksurvey.ui.cellular.TowerMapUiState (networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapUiState.kt:21); TowerMapUiStateKt.rememberTowerMapUiState (networksurvey/src/main/java/com/craxiom/networksurvey/ui/cellular/TowerMapUiState.kt:39). Rename to `LibUiUtils`. [rule N6]
D21 · Naming Consistency· `uploadToBeaconDB` spells `DB` where 29 names in the project spell it `Db` · ×1
`uploadToBeaconDB` spells `DB` where 29 names in the project spell it `Db` networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/uploader/beacondb/BeaconDbUploadClient.java:35— 29 of 30 names in project networksurvey spell the token `Db` (29 of 30; unit: names in project networksurvey containing `Db`). Peers: SurveyRecordDao.getGsmRecordCountForUpload(beaconDb) (networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:31); SurveyRecordDao.getGsmRecordsForUpload(beaconDb) (networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:34); SurveyRecordDao.markGsmRecordsAsUploadedToBeaconDb (networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:40); SurveyRecordDao.getCdmaRecordCountForUpload(beaconDb) (networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:44); SurveyRecordDao.getCdmaRecordsForUpload(beaconDb) (networksurvey/src/main/java/com/craxiom/networksurvey/logging/db/dao/SurveyRecordDao.java:47). Rename to `uploadToBeaconDb`. [rule N6]
D21 · Naming Consistency· `generateClientID` spells `ID` where 61 names in the project spell it `Id` · ×1
`generateClientID` spells `ID` where 61 names in the project spell it `Id` networksurvey/src/main/java/com/craxiom/networksurvey/util/PreferenceUtils.java:600— 61 of 62 names in project networksurvey spell the token `Id` (61 of 62; unit: names in project networksurvey containing `Id`). Peers: NrSecondaryCellSighting.isUsableFor(currentServingCellId) (networksurvey/src/main/java/com/craxiom/networksurvey/fragments/model/NrSecondaryCellSighting.java:33); CdrMmsObserver.queryAddresses(mmsId) (networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrMmsObserver.java:113); CdrMmsObserver.submitEvent(subscriptionId) (networksurvey/src/main/java/com/craxiom/networksurvey/listeners/CdrMmsObserver.java:146); ICellularSurveyRecordListener.onCellularBatch(subscriptionId) (networksurvey/src/main/java/com/craxiom/networksurvey/listeners/ICellularSurveyRecordListener.java:82); ICellularSurveyRecordListener.onNetworkType(subscriptionId) (networksurvey/src/main/java/com/craxiom/networksurvey/listeners/ICellularSurveyRecordListener.java:93). Rename to `generateClientId`. [rule N6]
D28 · Secrets (history)· Rotate the exposed credentials · ×1
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No SAST REDACTED:4— No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 3 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation build.gradle:13— `build.gradle` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
No release approval gate — The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
none (dependency manifest found, not scanned for vulnerabilities here)
—
none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 16 file(s) — `networksurvey/src/main/java/com/craxiom/networksurvey/SimChanges.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/mqtt/profile/MqttBrokerProfileMigration.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/mqtt/profile/MqttBrokerProfileStore.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/scout/firmware/FirmwareFetcher.kt`, `networksurvey/src/main/java/com/craxiom/networksurvey/scout/wifi/ScoutWifiSource.kt`, … (+11 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (dependency manifest found, not scanned for vulnerabilities here)
—
none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
0
—
Run 01a1e5dd-2f65-78ca-935a-433c3dc455b5 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 27 · Warnings: 295 · Recommendations: 30 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 16-11-2026 @ 19:37 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.