Public report of chef/chef-server, published 13 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.3). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 13 November 2026, 09:52 UTC · Survey ID cd_1a20369a1646485dad5a0f9ba2653d68

chef/chef-server

Measured 13 November 2026, 09:51 UTC, at code version d2ff756

CAI score 58out of 100 At risk Up 1 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 56,501 lines of product code in 21 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Code Health, 49

Findings by how serious they are

47 critical 634 serious 263 minor

25 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
13 November 2026, 09:51 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

60of 60 dimensions measured by tools.
907of 944 findings point to an exact file and line, so you can open each one in the code. The other 37 concern the repository as a whole, such as missing documentation.
60dimensions across 7 lenses, read from 56,501 lines of product code in 21 projects.
Chapters

Executive summary

chef/chef-server is rated At risk because critical security findings are open. It scores 58 out of 100, which the At risk rating leaves unchanged.

Code Health, at 49, is the weakest lens and counts most in the score. The best first step is adding type checking, worth about 7 points. Adopting a type checker comes next, worth about 6 points. Raising Code Health to 70 would lift the score to about 65.

Ten passwords or keys in the code's history and five in the code are open to anyone who can read the repository. Eight known security holes in the packages the code depends on can be used by attackers, and six pipeline steps run downloads nobody checks. Replacing each exposed password or key, updating the vulnerable packages and checking each download against a checksum would close these risks. Pinning each tool to an exact version would fix the six pipeline tools referenced by a changeable name, and the three places where the code runs text as code or as a command need a direct call instead. The three labels or groups of fields with no name need connecting to their fields or naming.

The product code is 56,501 lines, about €100,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Code Health 49 · counts for 46%Accessibility 62 · counts for 25%Production Readiness 63 · counts for 14%Security and Compliance 68 · counts for 8%Maturity 73 · counts for 4%Architecture 97 · counts for 2%Event Sourcing 100 · counts for 1%

If Code Health rose from 49 to 70, the lowest score rated Strong, the score would rise from 58 to about 65.

Code composition: what the lines of code are
Product code 57%Tests 43%
New since the last survey: 138 findings

These 138 critical or serious findings weren't in the previous survey, on 23 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED
  • Code Duplication · Edited copy of a member (78 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb
  • Code Duplication · Edited copy of a member (75 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb
  • Code Duplication · Edited copy of a member (44 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb
  • Code Duplication · Edited copy of a member (44 corresponding lines) REDACTED
  • Code Duplication · Edited copy of a member (23 corresponding lines) src/bookshelf/src/bksw_io.erl
  • Code Duplication · Edited copy of a member (29 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl
  • Code Duplication · Edited copy of a member (24 corresponding lines) oc-chef-pedant/lib/pedant/rspec/validations.rb
  • Code Duplication · Edited copy of a member (22 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_wm_base.erl
  • Code Duplication · Edited copies of one member (4 members, 14+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl
  • Code Duplication · Edited copy of a member (14 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl
  • Code Duplication · Edited copy of a member (25 corresponding lines) REDACTED
  • Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) src/bookshelf/src/bksw_app.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl
  • Code Duplication · Edited copy of a member (17 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl
  • Code Duplication · Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl
  • Code Duplication · Edited copy of a member (13 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl
  • Code Duplication · Edited copies of one member (3 members, 11+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl
  • Code Duplication · Edited copy of a member (19 corresponding lines) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl
  • Code Duplication · Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl
  • Code Duplication · Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl
  • Code Duplication · Edited copy of a member (14 corresponding lines) oc-chef-pedant/lib/pedant/rspec/search_util.rb
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl
  • Code Duplication · Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl
  • Code Duplication · Edited copies of one member (4 members, 6+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_data.erl
  • Code Duplication · Edited copy of a member (14 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl
  • Code Duplication · Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_environment.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_db.erl
  • Code Duplication · Edited copy of a member (13 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl
  • Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl
  • Code Duplication · Edited copy of a member (18 corresponding lines) oc-chef-pedant/lib/pedant/config.rb
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl
  • Code Duplication · Edited copy of a member (16 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb
  • Code Duplication · Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl
  • Code Duplication · Edited copy of a member (15 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_db.erl
  • Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl
  • Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object_base.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl
  • Code Duplication · Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl
  • Code Duplication · Edited copy of a member (3 corresponding lines) src/bookshelf/src/bksw_io_names.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_db.erl
  • Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_environment.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) oc-chef-pedant/lib/pedant/rspec/validations.rb
  • Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_client.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl
  • Code Duplication · Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_cookbook_artifact_version.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_db.erl
  • Code Duplication · Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_named_revision.erl
  • Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_wm_acl_action_resource.erl
  • Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_cookbooks.erl
  • Code Duplication · Edited copy of a member (7 corresponding lines) oc-chef-pedant/lib/pedant/chef_utility.rb
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/bookshelf/src/bksw_cleanup_task.erl
  • Code Duplication · Edited copies of one member (5 members, 9+ corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl
  • Code Duplication · Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl
  • Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) src/bookshelf/src/bksw_sql.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_index/src/chef_wait_group.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_sup.erl
  • Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl
  • Code Duplication · Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_environment.erl
  • Code Duplication · Edited copies of one member (3 members, 5+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_clients.erl
  • Code Duplication · Edited copy of a member (6 corresponding lines) src/bookshelf/src/bksw_wm_bucket.erl
  • Code Duplication · Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object.erl
  • Code Duplication · Edited copy of a member (3 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object_base.erl
  • Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environments.erl
  • Code Duplication · Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search_index.erl
  • Code Duplication · Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_sup.erl
  • Code Duplication · Edited copy of a member (7 corresponding lines) src/bookshelf/src/bksw_wm_object.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/oc-id/app/mailers/email_verify_mailer.rb
  • Code Duplication · Edited copies of one member (3 members, 3+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl
  • Code Duplication · Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_universe.erl
  • Code Duplication · Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl
  • Code Duplication · Edited copy of a member (5 corresponding lines) src/bookshelf/src/bksw_sql.erl
  • Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_key.erl
  • Code Duplication · Edited copy of a member (7 corresponding lines) src/bookshelf/src/bksw_wm_object.erl
  • Code Duplication · Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl
  • Code Duplication · Edited copies of one member (5 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl
  • Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_containers.erl
  • Code Duplication · Edited copy of a member (9 corresponding lines) oc-chef-pedant/lib/pedant/utility.rb
  • Code Duplication · Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 31 findings

These 31 critical or serious findings were in the previous survey, on 23 October 2026, and are gone from this one.

  • Code Duplication · Near-duplicate member pair (20 shared lines) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED
  • Code Duplication · Duplicated block (24 lines × 2) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (19 lines × 2) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (11 lines × 2) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (9 lines × 2) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (8 lines × 8) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (8 lines × 3) src/oc_erchef/knife/chefreq.erl
  • Code Duplication · Duplicated block (7 lines × 6) src/oc_erchef/knife/chefreq.erl
  • Code Duplication · Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (5 lines × 5) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (5 lines × 4) src/bookshelf/src/bksw_xml.erl
  • Code Duplication · Duplicated block (29 lines × 2) src/chef-server-ctl/plugins/notice.rb
  • Code Duplication · Duplicated block (8 lines × 2) src/chef-server-ctl/plugins/notice.rb
  • Code Duplication · Duplicated block (88 lines × 2) src/oc_erchef/apps-chef_db-itest/create_schema.rb
  • REDACTED Scanning · Leaked secret: REDACTED dev/Vagrantfile
  • REDACTED Scanning · Leaked secret: signing-key src/oc-id/habitat/default.toml
  • REDACTED Scanning · Leaked secret: REDACTED src/oc-id/config/routes.rb
  • REDACTED Scanning · Leaked secret: aws-access-key REDACTED
  • REDACTED Scanning · Leaked secret: REDACTED oc-chef-pedant/lib/pedant/rspec/search_util.rb
  • REDACTED Scanning · Leaked secret: REDACTED dev/cookbooks/provisioning/attributes/default.rb
  • Secrets (history) · REDACTED: generic-api-key data/sample_node.json
  • Secrets (history) · REDACTED: aws-access-token REDACTED
  • Secrets (history) · REDACTED: aws-access-token REDACTED
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • A11y enforcement · Accessibility enforcement below the top rung
Rebuild cost: about €100,000 · Estimate
Cost to rebuild€34,000 to €170,000, for 573 to 1,818 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 58. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 56,501 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
Raises the score by about 7 points · Medium effort · Type Safety
2
Adopt a checker and raise it file by file: with Sorbet, `srb init` (or `bundle exec tapioca init`) commits `sorbet/config`, then move each file's sigil from `# typed: false` to `# typed: true` and on to `strict` as its methods get `sig`s — `spoom bump` does the moving; with Steep, write RBS signatures and `check` the product directories in the `Steepfile` under `D::Ruby.default` or `strict`, not `lenient`.
Then pay down the assertions rather than adding to them: each `T.must` is a nil the checker could not rule out — narrow it (`return unless x`, `x&.`, `if (y = x)`), make the attribute non-nilable and set it in `initialize`, or change the method so the nil cannot arrive.
Raises the score by about 6 points · Medium effort · Nullable reference types
3
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.
Raises the score by about 2 points · Low effort · REDACTED Scanning

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €100,000 to build again, about 0.7 person-years of work. Its weakest lens is Code Health, at 49 (Weak). Code Health is about how easy the code is to read and change safely, and code that is hard to read is slow and risky to change, so every future change costs more than it should. Because the weakest lens counts most in the score, work on Code Health also moves the score most.
Based on: the rebuild estimate · the Code Health grade · how much each lens counts
What to do: Start with the Code Health actions in Top priorities.
If you do one thing first · First action
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch bifrost bifrost bookshelf bookshelf bookshelf_bench bookshelf_bench chef-server-ctl chef-server-ctl chef_db chef_db chef_index chef_index chef_license chef_license chef_objects chef_objects chef_telemetry chef_telemetry data_collector data_collector depsolver depsolver github.com/chef/chef-server/docs-chef-io docs-chef-io oc-bifrost-pedant oc-bifrost-pedant oc-chef-pedant oc-chef-pedant oc_chef_authz oc_chef_authz oc_chef_authz->chef_db oc_chef_authz->chef_objects oc_chef_wm oc_chef_wm oc_chef_wm->chef_index oc_chef_wm->chef_license oc_chef_wm->chef_objects oc_chef_wm->data_collector oc_chef_wm->oc_chef_authz oc_erchef oc_erchef oc_erchef->chef_db oc_erchef->chef_index oc_erchef->chef_license oc_erchef->chef_objects oc_erchef->chef_telemetry oc_erchef->data_collector oc_erchef->depsolver oc_erchef->oc_chef_authz oc_erchef->oc_chef_wm src/oc-id oc-id

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

62 modules, with 4 dependencies between them. Every module uses only modules listed above it, so there are no loops.

The table shows the 40 modules with the most connections; 22 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 Chef2 Chef.Web3 Chef.Web.Core4 ChefServerCtl5 ChefServerCtl.Helpers6 DVM7 Net8 OcId9 Pedant10 Pedant.CoreExt11 Pedant.RSpec.ClientUtil12 Pedant.RSpec.CookbookUtil13 Pedant.RSpec.EnvironmentUtil14 Pedant.RSpec.KnifeUtil15 Pedant.RSpec.NodeUtil16 Pedant.RSpec.RoleUtil17 Pedant.RSpec.SearchUtil18 Pedant.RSpec.UserUtil19 Pedant.RSpec.Validations20 Pedant.RSpec.Validations.Create21 Pedant.RSpec.Validations.Update22 RSpec23 RSpec.Matchers24 RSpecShared25 Rack26 SchemaHelper27 Statfs28 bksw_cleanup_task29 bookshelf_bench30 chef_cbv_cache31 chef_db32 chef_depsolver_worker33 chef_index_batch34 chef_index_expand35 chef_license_worker36 chef_telemetry_worker37 chef_wait_group38 (global)39 Pedant.RSpec40 V1
1 Chef
2 Chef.Web
3 Chef.Web.Core
4 ChefServerCtl
5 ChefServerCtl.Helpers
6 DVM
7 Net
8 OcId
9 Pedant
10 Pedant.CoreExt
11 Pedant.RSpec.ClientUtil
12 Pedant.RSpec.CookbookUtil
13 Pedant.RSpec.EnvironmentUtil
14 Pedant.RSpec.KnifeUtil
15 Pedant.RSpec.NodeUtil
16 Pedant.RSpec.RoleUtil
17 Pedant.RSpec.SearchUtil
18 Pedant.RSpec.UserUtil
19 Pedant.RSpec.Validations
20 Pedant.RSpec.Validations.Create
21 Pedant.RSpec.Validations.Update
22 RSpec
23 RSpec.Matchers
24 RSpecShared
25 Rack
26 SchemaHelper
27 Statfs
28 bksw_cleanup_task
29 bookshelf_bench
30 chef_cbv_cache
31 chef_db
32 chef_depsolver_worker
33 chef_index_batch
34 chef_index_expand
35 chef_license_worker
36 chef_telemetry_worker
37 chef_wait_group
38 (global)2
39 Pedant.RSpec21
40 V13
Uses a module listed above itPart of a loopThe module itself
1 Chef2 Chef.Web3 Chef.Web.Core4 ChefServerCtl5 ChefServerCtl.Helpers6 DVM7 Net8 OcId9 Pedant10 Pedant.CoreExt11 Pedant.RSpec.ClientUtil12 Pedant.RSpec.CookbookUtil13 Pedant.RSpec.EnvironmentUtil14 Pedant.RSpec.KnifeUtil15 Pedant.RSpec.NodeUtil16 Pedant.RSpec.RoleUtil17 Pedant.RSpec.SearchUtil18 Pedant.RSpec.UserUtil19 Pedant.RSpec.Validations20 Pedant.RSpec.Validations.Create21 Pedant.RSpec.Validations.Update22 RSpec23 RSpec.Matchers24 RSpecShared25 Rack26 SchemaHelper27 Statfs28 bksw_cleanup_task29 bookshelf_bench30 chef_cbv_cache31 chef_db32 chef_depsolver_worker33 chef_index_batch34 chef_index_expand35 chef_license_worker36 chef_telemetry_worker37 chef_wait_group38 (global)39 Pedant.RSpec40 V1Chef1Chef.Web2Chef.Web.Core3ChefServerCtl4ChefServerCtl.Helpers5DVM6Net7OcId8Pedant9Pedant.CoreExt10Pedant.RSpec.ClientUtil11Pedant.RSpec.CookbookUtil12Pedant.RSpec.EnvironmentUtil13Pedant.RSpec.KnifeUtil14Pedant.RSpec.NodeUtil15Pedant.RSpec.RoleUtil16Pedant.RSpec.SearchUtil17Pedant.RSpec.UserUtil18Pedant.RSpec.Validations19Pedant.RSpec.Validations.Create20Pedant.RSpec.Validations.Update21RSpec22RSpec.Matchers23RSpecShared24Rack25SchemaHelper26Statfs27bksw_cleanup_task28bookshelf_bench29chef_cbv_cache30chef_db31chef_depsolver_worker32chef_index_batch33chef_index_expand34chef_license_worker35chef_telemetry_worker36chef_wait_group37(global)38Pedant.RSpec39V1402213+22 more modules (most-connected shown)

At a glance — Code Health · 49% · Weak · gated by R1, X5 ·

At a glance — Architecture · 97% · Exemplary ·

At a glance — Maturity · 73% · Adequate · gated by D34 ·

At a glance — Readiness · 63% · Adequate · gated by D13, P7 ·

At a glance — Security · 68% · Adequate · gated by D28, D29 ·

At a glance — Event Sourcing · 100% · Exemplary ·

At a glance — Accessibility · 62% · Adequate · gated by AC2 ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection32High / Critical
A03:2025 — Software Supply Chain Failures22High / Critical
A07:2025 — Authentication Failures19High / Critical

Roadmap

Top priorities: Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up; Adopt a checker and raise it file by file: with Sorbet, `srb init` (or `bundle exec tapioca init`) commits `sorbet/config`, then move each file's sigil from `# typed: false` to `# typed: true` and on to `strict` as its methods get `sig`s — `spoom bump` does the moving; with Steep, write RBS signatures and `check` the product directories in the `Steepfile` under `D::Ruby.default` or `strict`, not `lenient`. Then pay down the assertions rather than adding to them: each `T.must` is a nil the checker could not rule out — narrow it (`return unless x`, `x&.`, `if (y = x)`), make the attribute non-nilable and set it in `initialize`, or change the method so the nil cannot arrive; Resolve the 298 TodoComment finding(s) in Explicit Debt — start with update_spec.rb (19), oc_chef_authz.erl (7), complete_endpoint_spec.rb (7).

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.+6.8 ptsMediumType Safety
Adopt a checker and raise it file by file: with Sorbet, `srb init` (or `bundle exec tapioca init`) commits `sorbet/config`, then move each file's sigil from `# typed: false` to `# typed: true` and on to `strict` as its methods get `sig`s — `spoom bump` does the moving; with Steep, write RBS signatures and `check` the product directories in the `Steepfile` under `D::Ruby.default` or `strict`, not `lenient`. Then pay down the assertions rather than adding to them: each `T.must` is a nil the checker could not rule out — narrow it (`return unless x`, `x&.`, `if (y = x)`), make the attribute non-nilable and set it in `initialize`, or change the method so the nil cannot arrive.+6.1 ptsMediumNullable reference types
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.+2.2 ptsLowREDACTED Scanning
Resolve the 298 TodoComment finding(s) in Explicit Debt — start with update_spec.rb (19), oc_chef_authz.erl (7), complete_endpoint_spec.rb (7).+4.7 ptsHighExplicit Debt
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with rebar.config.+1.1 ptsLowADR Quality
Swallowed exception (caught, then discarded)+2.1 ptsMediumException handling
Resolve the 1 REDACTED finding(s) in REDACTED Scanning — start with REDACTED.+1.0 ptsLowREDACTED Scanning
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.+1.7 ptsMediumForms & labels

File quality

Per-file score 0–10 — a quality signature. Of 252 files carrying findings, judged against the Production bar: 2% slop · 59% mixed · 39% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED0.2SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED1.6SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED3.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.5MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedDependency Vulnerabilities: High CVE: REDACTED
REDACTED5.1MixedDependency Vulnerabilities: High CVE: REDACTED
REDACTED5.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.7MixedStatic Analysis (SAST): Medium: REDACTED
src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl6.0MixedExplicit Debt: TodoComment
src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl6.0MixedExplicit Debt: FixmeComment
src/oc_erchef/apps/chef_db/src/chef_sql.erl6.0MixedExplicit Debt: TodoComment
src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl6.0MixedExplicit Debt: TodoComment
src/oc_erchef/apps/chef_objects/src/chef_user.erl6.0MixedExplicit Debt: FixmeComment
src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl6.0MixedExplicit Debt: TodoComment
src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl6.0MixedExplicit Debt: TodoComment
src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl6.0MixedExplicit Debt: FixmeComment
src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 47

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 634

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 263

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 25

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 60 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 60 dimensions across the health lenses
D1D2D3D4D5D6D12D13D14D15D16D17D19D20D26D27D28D29D30D31D34D35D36D37D43D44AC2AC3AC5AC6AX10AX2AX3AX4AX8AX9ES1M1M2M3M4P1P10P2P3P4P5P6P7P8R1R10R2R3R7R9S1X27X3X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 907 of 944 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic

Every finding is locatable in findings.md. Run 01a1d451-edc1-7368-91d7-3f007af00fe6.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.rb, .erl) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability not scored — the Ruby suite (RSpec: 4 bundle roots) ran but surfaced no test cases to the runner, so flakiness couldn't be exercised.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Go module (REDACTED/go.sum), but the licence verdict published here was taken over its gem dependencies. Nothing was read about its Go dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D27 Navigability — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Tracing effort is measured over resolved call sites, and all 531 sampled here came from .erl files. This repository's .rb source is a material share of its production lines and contributed none, so the score above is a verdict about the part that was read. Not a finding that the unread half navigates well — it is unmeasured.
  • D28 Secrets (history) — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `src/bookshelf/habitat/config/veil-secrets.json`, `src/chef-server-ctl/habitat/config/hab-secrets-config.json`, `src/oc-id/habitat/config/veil-secrets.json`, `src/oc_bifrost/habitat/config/veil-secrets.json`, `src/oc_erchef/habitat/config/veil-secrets.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `docs-chef-io/tools/vale/chef/name_lookarounds.rb`, `src/chef-server-ctl/habitat/config/pedant_config.rb`, `src/chef-server-ctl/habitat/config/pivotal.rb`, `src/oc-id/habitat/config/secret_token.rb`, `src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX6 Interface segregation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: 23 markup document(s) — HTML, Razor, JSX, Vue, Svelte or server templates. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a REDACTED (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's , Erlang, Go, lua, r is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's , Erlang, Go, lua, r is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X14 Bypassable address classification — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X16 Unfloored truncation loop — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X18 Disposal-pattern correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X19 Unrestored process-global state — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X2 Cancellation propagation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch, got, undici, node:http; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X21 Side-effecting pattern guard — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X23 Unguarded diagnostic materialisation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X30 Support guard that admits what it rejects — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X7 Silent fallback defaults — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. X7 measured the part of this repository it reads (C#, Python, TypeScript/JavaScript, Rust, Go, Java, Kotlin, Scala, PHP, Ruby, Swift and Dart), and its Erlang source is outside the check's reach, so the card covers only part of the product. That is a gap in this analyzer's language reach — not a finding that the unread source is free of silent defaults.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (REDACTED, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity8.8 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

4 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was oc_chef_authz_acl.fetch_id at 34. A further 11 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being chef_wm_malformed.malformed_request_message at 42 — they are counted neither in the figure above nor in this dimension's score. 8 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold functions was excluded, so the exclusion is disclosed nowhere in the file itself: src/oc_erchef/apps/oc_chef_wm/src/chef_wm_malformed.erl (chef_wm_malformed.malformed_request_message at 42), src/oc_erchef/apps/chef_objects/src/chef_regex.erl (chef_regex.regex_for at 24), src/oc_erchef/apps/chef_objects/src/chef_sandbox.erl (chef_sandbox.is_hex at 24), src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_routes.erl (oc_chef_wm_routes.org_route at 23), src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl (chef_wm_util.not_found_message at 19), and 3 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

oc_chef_authz_acl.fetch_id (cyclomatic 34)src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:110
chef_cbv_cache.handle_call (cyclomatic 17)src/oc_erchef/apps/chef_objects/src/chef_cbv_cache.erl:158
bksw_wm_base.malformed_request (cyclomatic 16)src/bookshelf/src/bksw_wm_base.erl:52
HTTP.connect (cyclomatic 16)REDACTED:22

What to do

  1. Bring the 4 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with oc_chef_authz_acl.fetch_id (cyclomatic 34), chef_cbv_cache.handle_call (cyclomatic 17), bksw_wm_base.malformed_request (cyclomatic 16). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 4 together lifts Cyclomatic Complexity from 8.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity8.6 / 10Strong✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

6 method(s) exceeded the cognitive complexity threshold of 15; the worst was bksw_wm_base.malformed_request at 35.

bksw_wm_base.malformed_request (cognitive 35)src/bookshelf/src/bksw_wm_base.erl:52
HTTP.connect (cognitive 28)REDACTED:22
chef_license_worker.process_license (cognitive 23)src/oc_erchef/apps/chef_license/src/chef_license_worker.erl:246
chef_telemetry_worker.get_company_name (cognitive 17)src/oc_erchef/apps/chef_telemetry/src/chef_telemetry_worker.erl:231
chef_sql_cookbook_versions.fetch_cookbook_versions (cognitive 16)src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:127

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 6 bodies over 15 down to 15 or less in Cognitive Complexity — start with bksw_wm_base.malformed_request (cognitive 35), HTTP.connect (cognitive 28), chef_license_worker.process_license (cognitive 23). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cognitive Complexity from 8.6 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.5 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

19 god class(es) detected.

TooManyFunctions: chef_user · ×10src/oc_erchef/apps/chef_objects/src/chef_user.erl:21
FileTooLong: src/bksw_xml.erl · ×7src/bookshelf/src/bksw_xml.erl
TooManyMethods: Platform · ×2REDACTED:23

What to do

  1. Resolve the 10 TooManyFunctions finding(s) in God Classes — start with chef_user.erl, oc_chef_group.erl, oc_chef_authz_scoped_name.erl. — One of this dimension's main actionable groups (10 warning-level).
  2. Resolve the 7 FileTooLong finding(s) in God Classes — start with bksw_xml.erl, chef_sql.erl, oc_chef_wm_base.erl. — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 2 TooManyMethods finding(s) in God Classes — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.2 / 10Stronggated by 211 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Verified

92 duplicated block group(s) detected. A further 119 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 2 of the 211 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Edited copy of a member (4 corresponding lines) · ×11src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:125
Edited copy of a member (8 corresponding lines) · ×10src/oc_erchef/apps/chef_objects/src/chef_node.erl:110
Duplicated block (5 lines × 2) · ×9src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:58
Edited copy of a member (9 corresponding lines) · ×8src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:10
Edited copy of a member (6 corresponding lines) · ×8src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:57

+ 89 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 11 Edited copy of a member (4 corresponding lines) finding(s) in Code Duplication — start with chef_sql_data_bag.erl (2), chef_wm_named_data.erl (2), oc_chef_org_user_association.erl. — One of this dimension's main actionable groups (11 warning-level).
  2. Resolve the 10 Edited copy of a member (8 corresponding lines) finding(s) in Code Duplication — start with chef_node.erl, oc_chef_wm_keys.erl, chef_sql_cookbook_versions.erl. — One of this dimension's main actionable groups (10 warning-level).
  3. Resolve the 9 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with client_util.rb (2), pg_test_util.erl (2), chef_elasticsearch.erl. — One of this dimension's main actionable groups (9 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling6.9 / 10Adequate✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 6.9 / 10 · rule-coverage 100% · ceiling Prevented

18 production modules (Go+RubyGems+OTP), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 7 module(s) off the main sequence, with abstractness counted on 14 of the 18 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: chef_db · ×7

What to do

  1. Resolve the 7 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (7 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 8 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D12 · Dependency Hygiene8.9 8.4 / 10Strong✓ Tool-verified

What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.

Maturity: Documented → Verified → Prevented · effective 8.4 / 10 · rule-coverage 94% · ceiling Verified

21 outdated direct gem(s), 0 pinning defect(s). 94 declaration(s) graded against rubygems.org, 70 of them against a version resolved in a committed REDACTED. 24 declaration(s) carry a requirement that EXCLUDES the current release; that is a deliberate constraint (a supported-version ceiling or a held-back CI pin) and is counted, not charged. 94 of 100 gradable declaration(s) were graded against rubygems.org (0 not published there, 6 carrying a version or requirement this pass cannot order). Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.

Outdated: addressable · ×21

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Prevented

5 secret(s) detected. 1 AWS access key ID(s) with no secret access key beside them are listed to check and are not counted as leaked: the key ID alone signs nothing. 4 detection(s) were excluded as holding no minted credential in material that runs: a name, reference or comparison rather than a value, a readable phrase or pattern, a value that declares itself fake, or development, test, example, mock or demo material.

REDACTED
REDACTED

What to do

  1. Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (5 issue-level).
  2. Resolve the 1 REDACTED finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 245 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 245 gem(s) a consumer installs — this repository's runtime declarations closed transitively over its committed REDACTED. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. 7 of them publish no licence on rubygems.org; that is missing data, not a violation, and none of them is charged. This repository publishes itself under Apache-2.0, which is its own choice and is not judged here. ★ COVERAGE OF THIS VERDICT: it grades this repository's gem dependencies and nothing else. The repository also declares a Go module (REDACTED/go.sum), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D16 · Bus Factor10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No source file's living knowledge is concentrated in a single author. Counted over 106 of the 404 production source files in this repository: 171 are under the ~2,400-byte size floor this dimension measures over, and the remaining 127 have no attributable history left to measure.

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md.

D17 · Explicit Debt8.8 / 10Strong✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

337 deducted task-comment markers across 56501 LoC (0.6/KLoC) → score 8.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×298src/oc_erchef/include/oc_chef_wm.hrl:113
FixmeComment · ×32src/oc_erchef/include/chef_regex.hrl:43
XxxComment · ×6src/oc_bifrost/apps/bifrost/src/bifrost_wm_error.erl:21
HackCommentsrc/oc_erchef/apps/chef_objects/src/chef_user.erl:342

What to do

  1. Resolve the 298 TodoComment finding(s) in Explicit Debt — start with update_spec.rb (19), oc_chef_authz.erl (7), complete_endpoint_spec.rb (7). — One of this dimension's main actionable groups (298 warning-level).
  2. Resolve the 32 FixmeComment finding(s) in Explicit Debt — start with chef_wm_search.erl (3), chef_wm_sandboxes.erl (2), chef_cookbook_version.erl (2). — One of this dimension's main actionable groups (32 warning-level).
  3. Resolve the 6 XxxComment finding(s) in Explicit Debt — start with search_util.rb (4), bifrost_wm_error.erl (2). — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 53 document(s) read across 1 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundsrc/oc_erchef/rebar.config:127

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with rebar.config. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 21 build units (Bundler, Go, Make, OTP, rebar3) flagged as possibly oversized/incoherent.

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md.

D27 · Navigability10.0 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 % of calls cross a namespace and 0 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated. Measured over the .erl source only — this repository's .rb was not sampled for call sites, so this score covers part of the tree, not all of it.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

12 finding(s): 0 critical, 10 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 6 High secret finding(s) in Secrets (history) — start with REDACTED (2), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 4 REDACTED finding(s) in Secrets (history) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
  3. Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.7 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.7 / 10 · rule-coverage 100% · ceiling Documented

32 finding(s): 0 critical, 17 high, 14 medium, 1 low. 6 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 18 file(s) — `docs-chef-io/.markdownlint.yaml`, `docs-chef-io/tools/vale/chef/name_lookarounds.rb` (lines 2–4, line 5), `src/bookshelf/habitat/config/database-migrations.sh`, `src/bookshelf/habitat/config/veil-secrets.json`, `src/chef-server-ctl/habitat/config/hab-secrets-config.json`, … (+13 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 8 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 5 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (5). — One of this dimension's main actionable groups (5 issue-level).
  2. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).
  3. No action in Static Analysis (SAST) — all 5 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (5 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities2.5 / 10Weak✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no REDACTED is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

20 finding(s): 1 critical, 7 high, 9 medium, 3 low.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 8 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (7), REDACTED. — One of this dimension's main actionable groups (8 warning-level).
  2. Resolve the 7 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (7). — One of this dimension's main actionable groups (7 issue-level).
  3. Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (Dockerfile/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

trivy and checkov found no infrastructure-as-code or container misconfigurations.

✓ On the Gold path — maintain.

Detailed fixes: d31_recommendation.md.

D34 · Knowledge Freshness0.5 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.5 / 10 · rule-coverage 100% · ceiling Documented

222 of 233 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/oc_erchef/apps/chef_db/src/chef_sql.erl. Counted over 233 of the 404 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×219oc-chef-pedant/lib/pedant/rspec/search_util.rb:1
Most significant orphaned file · ×3src/oc_erchef/apps/chef_db/src/chef_sql.erl:1
Concentrated knowledge decay

What to do

  1. Resolve the 219 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED (3), common.rb (2), matchers.rb (2). — One of this dimension's main actionable groups (219 recommendation-level).
  2. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with chef_sql.erl, oc_chef_wm_base.erl, bksw_xml.erl. — One of this dimension's main actionable groups (3 recommendation-level).
  3. Resolve the 1 Concentrated knowledge decay finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 100 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC2 · Forms & labels3.5 / 10Weak✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label. — src/oc-id/app/views/layouts/application.html.erb:22
  • This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id. (×3) — src/oc-id/app/views/profiles/_change_password.html.erb:11, src/oc-id/app/views/profiles/_change_password.html.erb:18, src/oc-id/app/views/profiles/_change_password.html.erb:25

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure4.8 / 10Weak✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. (×2) — src/oc-id/app/views/doorkeeper/applications/show.html.erb:7, src/oc-id/app/views/doorkeeper/authorizations/new.html.erb:6
  • A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). — src/oc-id/app/views/doorkeeper/applications/show.html.erb:12
  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×4) — src/oc-id/app/views/layouts/application.html.erb:2, src/oc-id/public/404.html:2, src/oc-id/public/422.html:2, …
  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×3) — src/oc-id/public/404.html:2, src/oc-id/public/422.html:2, src/oc-id/public/500.html:2

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AX10 · Code composition9.5 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

AX9 · CQS / query purity10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.

Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.

Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.

ES1 · Fold determinism10.0 / 10Exemplary✓ Tool-verified

Other · Event Sourcing — Whether the event-sourcing replay fold reconstructs state purely from the event (no wall clock, UUID or randomness) so replay is reproducible.

Method: Roslyn syntax scan (event-sourcing gated): Apply/When folds checked for forbidden tokens (DateTime.Now, Guid.NewGuid, Random, IO), stripped of comments/strings. Deterministic, hard fact per fold.

M1 · Documentation (README)8.7 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

P2 · Observability9.5 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 10/12 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `docs-chef-io`.

What to do

  • Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
P3 · Security & performance tooling10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • `.github/workflows/archived/dependabot.yml` schedules updates, but no `package-ecosystem` entry covers `github-actions`, `gomod`, `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entries to the `updates:` list. — .github/workflows/archived/dependabot.yml:2

What to do

  • Dependabot is configured but does not watch `github-actions`, `gomod`, `gitsubmodule` — add those `package-ecosystem` entries to .github/dependabot.yml so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
P4 · Deployment & Rollback8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it.

What to do

  • Add an approval/environment gate (required reviewers / protection rules) before production promotion.
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `Net::HTTP.new` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — REDACTED:322
  • `RestClient.` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×4) — oc-chef-pedant/lib/pedant/rspec/search_util.rb:731, oc-chef-pedant/lib/pedant/rspec/search_util.rb:757, src/oc_bifrost/oc-bifrost-pedant/lib/pedant/rspec/common.rb:409, …
  • `RestClient::` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×4) — src/chef-server-ctl/plugins/server_admins.rb:50, src/chef-server-ctl/plugins/server_admins.rb:86, src/chef-server-ctl/plugins/server_admins.rb:105, …
  • `RestClient.get` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:350

What to do

  • Set `open_timeout` and `read_timeout` explicitly on every client (Net::HTTP, Faraday `request: { timeout: }`, HTTParty `timeout:`), add Faraday's `:retry` middleware (faraday-retry) or `retriable`, and a breaker (`circuitbox`, `stoplight`) around dependencies that fail.
P8 · Schema migrations10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether database schema changes go through versioned migrations rather than being auto-created from the model at startup.

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

R1 · Type Safety0.0 / 10Critical✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

  • 0 typed · 9 plain JS — the untyped files are src/oc-id/app/assets/config/manifest.js, src/oc-id/app/assets/javascripts/application.js, src/oc-id/app/assets/javascripts/chef-web-core.js, src/oc-id/lib/assets/javascripts/chef.js, src/oc-id/lib/assets/javascripts/chef/chef.js, src/oc-id/lib/assets/javascripts/chef/components/icon.js (+3 more).

What to do

  • Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
R10 · Code Duplication10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.

R2 · Cyclomatic Complexity10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

R3 · Large Files10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

R9 · Circular Imports10.0 / 10Exemplary✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

S1 · Web-Security Posture8.0 / 10Strong✓ Tool-verified

Other · Security — Only what this repository's own non-C# files could be read for was assessed — and because this repository commits the configuration that serves its own HTTP surface, that configuration could be read in full for the security response headers it sets. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `nginx.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.) — src/nginx/habitat/config/nginx.conf:55

What to do

  • Set security response headers on the surface this repository serves: an `add_header` directive per header in the nginx/Caddy/Apache config, a `_headers` / `vercel.json` / `netlify.toml` entry for a static host, or `helmet()` in the HTTP server. `Content-Security-Policy` is the one that pays for itself first — it is what contains an injected script once one reaches the page — followed by `X-Content-Type-Options: nosniff` and a frame policy (`X-Frame-Options: DENY`, or CSP `frame-ancestors`). Where the app is served from a build container, the header configuration belongs in the image beside the built assets, so it ships with them rather than depending on where it lands.
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a walk over an ETS table leaves the key it stands on alone — Erlang's own lists and maps are values no body can change, but an ETS key traversal asks the table for the key after the current one, so on a `set`, `bag` or `duplicate_bag` that is not fixed with `ets:safe_fixtable/2`, deleting the current key and then calling `ets:next/2` (or `ets:prev/2`) from it raises `badarg` and the rest of the table is never visited. Whether a walk over a `Hash` or `Set` (`each`, `each_pair`, `map`, `for … in` and the other block walks) leaves it alone — Ruby refuses `rehash`, `replace`, `compare_by_identity` and `transform_keys!` on a Hash, and `reset`, `replace`, `compare_by_identity` and `map!` on a Set, while it is being iterated: the call raises `RuntimeError` at once and the remaining entries are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X3 · Exception handling6.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:288, dev/dvm/lib/dvm/project/erlang.rb:70
  • `catch _Module:_Reason` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authn_ldap.erl:73
  • `catch _:_` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:143, src/oc_erchef/apps/chef_telemetry/src/chef_telemetry_worker.erl:100
  • `rescue => e` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — src/oc-id/app/models/user.rb:103, src/chef-server-ctl/plugins/wrap-knife.rb:243
  • `… rescue []` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — oc-chef-pedant/lib/pedant/rspec/search_util.rb:634

What to do

  • Swallowed exception (caught, then discarded)
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Ruby's type checker checks nil and is not undermined by assertions — a file Sorbet reads at `# typed: true` or above, or a Steep target `check`s under its default or strict diagnostics, is one where a method call on a `T.nilable(String)` / `String?` is an error, and each `T.must`, `#: as !nil` or `# steep:ignore NoMethod` is the author telling the checker a value cannot be nil.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • This repository commits no Sorbet configuration (`sorbet/config`) and no `Steepfile`, so nothing type-checks its 163 Ruby product file(s): a nilable value reaches a method call silently and raises `NoMethodError: undefined method … for nil` the first time it is nil. A `# typed:` sigil does nothing without a `sorbet/config` beside the code; a Steep run configured only on a command line is not something this check can read.

What to do

  • Adopt a checker and raise it file by file: with Sorbet, `srb init` (or `bundle exec tapioca init`) commits `sorbet/config`, then move each file's sigil from `# typed: false` to `# typed: true` and on to `strict` as its methods get `sig`s — `spoom bump` does the moving; with Steep, write RBS signatures and `check` the product directories in the `Steepfile` under `D::Ruby.default` or `strict`, not `lenient`. Then pay down the assertions rather than adding to them: each `T.must` is a nil the checker could not rule out — narrow it (`return unless x`, `x&.`, `if (y = x)`), make the attribute non-nilable and set it in `initialize`, or change the method so the nil cannot arrive.

WCAG coverage — what static analysis assessed

Statically assessed 10 of 55 WCAG 2.2 Level A/AA success criteria (18%; ≈20% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 45 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 45 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.1, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health49%Weak — gated by R1, X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture97%ExemplarySolid.
Maturity73%Adequate — gated by D34Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness63%Adequate — gated by D13, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security68%Adequate — gated by D28, D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Event Sourcing100%ExemplaryStrongest area.
Accessibility62%Adequate — gated by AC2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X31 Test-only surface in a production module — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
Not included — 65 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No image/media element found in the parsed markup — AC1 not applicable here.
  • AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
  • AX1 Captive dependencies — Not applicable: the BEAM has no dependency-injection container — state lives in processes, and no process is handed an instance whose lifetime another one scopes; this repository's Go imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Ruby imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — AX6 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~42202 lines of test source are present (.rb, .erl) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — No tests discovered
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D21 Naming Consistency — Naming consistency is measured on C# and TypeScript only; Erlang, Go, JavaScript, Ruby not measured.
  • D22 Internal API Consistency — API consistency is measured on C# only; the exposed Ruby surface was not measured.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only; comments in this repository's .erl, .go, .rb source were not judged.
  • D25 ADR Conformance — no ADRs to check
  • D32 Data Compliance (PII/GDPR) — 5 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (1 of 2 signals for this style — below the bar we score at): 168 value object(s)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES2 Immutable events — not applicable — the code was read and holds no persisted event, so there is nothing for this check to judge
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `x.report(…)` entries in a `Benchmark.ips`/`bm`/`bmbm`/`benchmark`/`memory` block, `benchmark:` entries in a benchmark-driver YAML under a bench* directory, rspec-benchmark `perform_*` expectations where the gem is installed, or benchmark-ips, benchmark-memory, rspec-benchmark or benchmark-driver in a Gemfile or gemspec, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • PF3 Async & latency hygiene — Not applicable: Erlang and Go and Ruby has no async/await function colour, so there is no asynchronous code for a blocking call to stall.
  • R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
  • R4 Test Coverage — the JS/TS workspace (9 production file(s)) has no JavaScript/TypeScript test, but it is 0.25% of this repository's production source and the other 99.75% carries 42,202 line(s) of test code this pass cannot read — an incidental frontend's reachability is not the repository's test posture, so it is not scored as one
  • R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
  • R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
  • R8 Dependency Hygiene — Not measured — no package.json declares any dependency, so there is nothing to check imports against (imports may resolve through a host runtime rather than node).
  • X1 Async correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X12 Unreachable branch — X12 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — X14 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X16 Unfloored truncation loop — X16 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X18 Disposal-pattern correctness — X18 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X19 Unrestored process-global state — X19 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X21 Side-effecting pattern guard — X21 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X23 Unguarded diagnostic materialisation — X23 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X24 Document value interpolated into markup unescaped — X24 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines), go (4 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X30 Support guard that admits what it rejects — X30 reached only 34% of this repository's production lines — erlang (37,063 lines), lua (693 lines), r (129 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Ruby was read, and it logs through none: the standard library's Logger, which Rails.logger is, takes one finished message and no template arguments or fields (as log4net does in C#), so an interpolated message there loses nothing the API could have kept. The console gem (`Console.info`), SemanticLogger, Ougai and dry-logger would be judged.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 47 finding(s)
D30 · Dependency Vulnerabilities · High CVE · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · High secret · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D13 · REDACTED Scanning · Leaked secret · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · REDACTED · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · <label> that labels no control · ×3
  • <label> that labels no control src/oc-id/app/views/profiles/_change_password.html.erb:11 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/oc-id/app/views/profiles/_change_password.html.erb:18 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/oc-id/app/views/profiles/_change_password.html.erb:25 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
AC3 · Page structure · <html> without a lang · ×3
  • <html> without a lang src/oc-id/public/404.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang src/oc-id/public/422.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang src/oc-id/public/500.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · Link with no accessible name · ×1
  • Link with no accessible name src/oc-id/app/views/layouts/application.html.erb:22 — A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×1
  • REDACTED
Serious — 634 finding(s)
D17 · Explicit Debt · TodoComment · ×298
  • TodoComment src/oc_erchef/include/oc_chef_wm.hrl:113 — %% TODO this is also set as part of x-ops-api-info, which could be confusing. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:106 — # TODO: Need to cleanly guard that we only do this in one instance of chef-server-ctl — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:187 — # TODO Guard against multiple instances racing — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:250 — # TODO is this right? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_reindex.erl:179 — % TODO - we will likely want to accept version asa parameter to make_context — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:181 — %% TODO - look at the nested loops and complexity of this operation - — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:254 — %% TODO - helper function to deal with the call and match on a chef_cookbook version — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:364 — %% TODO: refactor common parts into sub-function — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_enforce.erl:54 — %% match against. TODO: webmachine. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_recipes.erl:63 — %% TODO: This is the same as in named_environment_resource and — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_malformed.erl:151 — % TODO msg is provided here - we should use it if it is. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_sandbox.erl:175 — %% TODO: use the timestamp from the record created_at. Avoiding that for now because we — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_pooler_collector.erl:34 — % TODO(jaym) 08-23-17: This sucks, we should expose this in a sane way from pooler. Leaving for now — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_pooler_collector.erl:75 — % TODO(jaym) 08-23-17: Move this out to configuration — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_prometheus_json_format.erl:87 — %% TODO(jaym) 08/27/17: Summary types — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:331 — %% TODO: when data bags are no longer in couchdb, clean this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_routes.erl:300 — %% TODO: when data bags are no longer in couchdb, clean this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:352 — % TODO - sort this out — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_stats.erl:49 — % TODO: Understand https://github.com/basho/webmachine/blob/develop/src/webmachine_util.erl#L140-L158
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl:45 — %% TODO: These types are just placeholders until we get all the types cleaned up — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl:111 — %% TODO: Why are these messages phrased differently? This is what the Ruby endpoints were — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl:222 — %% TODO: Currently we only use this for nodes and roles; when we clean up our custom types, — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authn_ldap.erl:109 — % TODO: Remove once a fix is accepted upstream and we can upgrade our — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:238 — %% TODO: Extract this logging message, as it is used elsewhere, too — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:325 — % TODO another possibility is to pre-load the creating client in client_data? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 273 more in this group — see findings.md.
D17 · Explicit Debt · FixmeComment · ×32
  • FixmeComment src/oc_erchef/include/chef_regex.hrl:43 — %% FIXME: This type is not yet correct — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:78 — %% FIXME: This is a temporary fix until pedant uses the validator which has — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:178 — %% FIXME: error handling for {error, _}. Can also return {not_found, org}, but I think — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:74 — %% FIXME: should we also fetch the data_bag here to make sure that it exists and ensure — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_sandboxes.erl:128 — %% FIXME: need to do a lookup either one at a time or in bulk to find out which — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_sandboxes.erl:130 — %% FIXME: will this be a problem for OSC w/ bookshelf? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:247 — %% FIXME: these are the chef_types that are indexable for search and — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:273 — %% FIXME: it would be great if we didn't have to wrap the data_bag_item — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:420 — %% FIXME Refactor into a more readable/understandable design — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:465 — %% FIXME: the supported version is determined by the chef_authn application — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_sup.erl:76 — %% FIXME: location of the ibrowse.config should be itself configurable. Also need to — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_test/src/chef_test_db_helper.erl:120 — %% FIXME: we should fail explicitely here if any of the commands above — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/test/chef_environment_tests.erl:41 — %% FIXME: fill out more compelte environment json object — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/test/chef_s3_tests.erl:295 — %% FIXME - copy pasta — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:112 — %% FIXME: more to come soon — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:279 — %% FIXME: what's this? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/src/chef_node.erl:170 — %% FIXME: nodes may have environment in the db, but not in JSON — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/src/chef_user.erl:191 — %% FIXME as an always-required field this belongs in the schema — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_objects/src/chef_user.erl:194 — %% FIXME these should be retained by the components that need them — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_index/test/chef_lucene_tests.erl:154 — % FIXME: should we change the parsing to only accept prohibited — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_index/test/chef_lucene_tests.erl:183 — % FIXME: should we bother to support this or explicitly — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_index/src/chef_index_batch.erl:156 — %% FIXME: this process will stay around even after someone calls — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_db/src/chef_db.erl:613 — %% FIXME: we should implement a specialized environment exists function — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_db/src/chef_db.erl:707 — %% FIXME: seems like delete_object should take either object ID or orgid+object_name only. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment src/oc_erchef/apps/chef_db/src/chef_sql.erl:959 — %% FIXME - what cleanup do I need to do here given I'm not in a transaction — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 7 more in this group — see findings.md.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×11
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:125 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:125-128 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_invite.erl:150-153 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_environment.erl:148 — src/oc_erchef/apps/chef_objects/src/chef_environment.erl:148-151 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:143-146 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_sup.erl:56 — src/oc_bifrost/apps/bifrost/src/bifrost_sup.erl:56-59 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_sup.erl:132-135 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:28 — src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:28-31 | src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:28-31 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:186 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:186-189 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:176-179 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:148 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:148-151 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_system_recovery.erl:110-113 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group_revision_association.erl:210 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group_revision_association.erl:210-213 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_revision.erl:217-221 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:144 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:144-154 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:132-135 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:39 — src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:39-42 | src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:40-45 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_wm_util.erl:48 — src/oc_bifrost/apps/bifrost/src/bifrost_wm_util.erl:48-51 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl:330-333 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/oc_erchef/apps/chef_index/src/chef_index_http.erl:110 — src/oc_erchef/apps/chef_index/src/chef_index_http.erl:110-113 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_http.erl:196-199 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D3 · God Classes · TooManyFunctions · ×10
  • TooManyFunctions: chef_user src/oc_erchef/apps/chef_objects/src/chef_user.erl:21 — TooManyFunctions — 53 functions. The bar is 30 functions; this is 23 over it, 1.77× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: oc_chef_group src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:6 — TooManyFunctions — 49 functions. The bar is 30 functions; this is 19 over it, 1.63× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: oc_chef_authz_scoped_name src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_scoped_name.erl:21 — TooManyFunctions — 42 functions. The bar is 30 functions; this is 12 over it, 1.40× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: oc_chef_authz src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:26 — TooManyFunctions — 41 functions. The bar is 30 functions; this is 11 over it, 1.37× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: chef_wm_search src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:27 — TooManyFunctions — 36 functions. The bar is 30 functions; this is 6 over it, 1.20× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: chef_client src/oc_erchef/apps/chef_objects/src/chef_client.erl:21 — TooManyFunctions — 34 functions. The bar is 30 functions; this is 4 over it, 1.13× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: bksw_io src/bookshelf/src/bksw_io.erl:18 — TooManyFunctions — 32 functions. The bar is 30 functions; this is 2 over it, 1.07× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: chef_wm_depsolver src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:24 — TooManyFunctions — 32 functions. The bar is 30 functions; this is 2 over it, 1.07× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: chef_key src/oc_erchef/apps/chef_objects/src/chef_key.erl:22 — TooManyFunctions — 31 functions. The bar is 30 functions; this is 1 over it, 1.03× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
  • TooManyFunctions: chef_node src/oc_erchef/apps/chef_objects/src/chef_node.erl:22 — TooManyFunctions — 31 functions. The bar is 30 functions; this is 1 over it, 1.03× the bar. The counted members are a module's functions — a module holds no instance state, so there is no shared data to group them by and no type to move them onto. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no single module carries every responsibility.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×10
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl:110 — src/oc_erchef/apps/chef_objects/src/chef_node.erl:110-125 | src/oc_erchef/apps/chef_objects/src/chef_node.erl:197-204 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:106 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:106-116 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_invites.erl:121-128 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:87 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:87-94 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:114-125 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_db.erl:683 — src/oc_erchef/apps/chef_db/src/chef_db.erl:683-690 | src/oc_erchef/apps/chef_db/src/chef_db.erl:698-705 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:126 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:126-133 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:237-244 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl:92 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl:92-104 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl:107-114 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:372 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:372-379 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:513-521 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_cookbooks.erl:153 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_cookbooks.erl:153-164 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_recipes.erl:94-101 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl:81 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl:81-88 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:108-115 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:106 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:106-113 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_invite.erl:116-123 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×10
  • Outbound HTTP without resilience REDACTED:322 — `Net::HTTP.new` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience oc-chef-pedant/lib/pedant/rspec/search_util.rb:731 — `RestClient.` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience oc-chef-pedant/lib/pedant/rspec/search_util.rb:757 — `RestClient.` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/chef-server-ctl/plugins/server_admins.rb:50 — `RestClient::` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/chef-server-ctl/plugins/server_admins.rb:86 — `RestClient::` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/chef-server-ctl/plugins/server_admins.rb:105 — `RestClient::` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/chef-server-ctl/plugins/server_admins.rb:132 — `RestClient::` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/oc_bifrost/oc-bifrost-pedant/lib/pedant/rspec/common.rb:409 — `RestClient.` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/oc_bifrost/oc-bifrost-pedant/lib/pedant/rspec/common.rb:411 — `RestClient.` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:350 — `RestClient.get` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×9
  • Duplicated block (5 lines × 2) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:58 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:58-62 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:53-57 — before extracting anything, compare `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl` and `src/oc_erchef/apps/chef_index/src/chef_opensearch.erl` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:157 — src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:157-161 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:258-262 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_associations.erl:103 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_associations.erl:103-107 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_invites.erl:99-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_associations.erl:103` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) oc-chef-pedant/lib/pedant/rspec/client_util.rb:369 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:369-373 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:276-280 — before extracting anything, compare `oc-chef-pedant/lib/pedant/rspec/client_util.rb` and `oc-chef-pedant/lib/pedant/rspec/user_util.rb` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) REDACTED:284 — REDACTED:284-288 | REDACTED:571-575 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) oc-chef-pedant/lib/pedant/rspec/client_util.rb:282 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:282-286 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:195-199 — before extracting anything, compare `oc-chef-pedant/lib/pedant/rspec/client_util.rb` and `oc-chef-pedant/lib/pedant/rspec/user_util.rb` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) src/chef-server-ctl/plugins/notice.rb:846 — src/chef-server-ctl/plugins/notice.rb:846-850 | src/chef-server-ctl/plugins/notice.rb:1257-1261 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) src/oc_erchef/apps/chef_db/itest/pg_test_util.erl:40 — src/oc_erchef/apps/chef_db/itest/pg_test_util.erl:40-44 | src/oc_erchef/apps/chef_test/src/chef_test_suite_helper.erl:73-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) src/oc_erchef/apps/chef_db/itest/pg_test_util.erl:46 — src/oc_erchef/apps/chef_db/itest/pg_test_util.erl:46-50 | src/oc_erchef/apps/chef_test/src/chef_test_suite_helper.erl:93-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D30 · Dependency Vulnerabilities · Medium CVE · ×8
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×8
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:10 — src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag.erl:10-20 | src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:10-18 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:222 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:222-230 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:126-134 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_db.erl:670 — src/oc_erchef/apps/chef_db/src/chef_db.erl:670-678 | src/oc_erchef/apps/chef_db/src/chef_db.erl:747-756 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:11 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:11-19 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:21-31 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:135 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:135-143 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:246-254 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/bookshelf/src/bksw_cleanup_task.erl:79 — src/bookshelf/src/bksw_cleanup_task.erl:79-87 | src/bookshelf/src/bksw_cleanup_task.erl:89-97 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:283 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:283-291 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:293-302 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) oc-chef-pedant/lib/pedant/utility.rb:65 — oc-chef-pedant/lib/pedant/utility.rb:65-73 | src/oc_bifrost/oc-bifrost-pedant/lib/pedant/utility.rb:65-75 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×8
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:57 — src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:57-65 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_sandbox.erl:192-197 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:174 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:174-184 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:1339-1344 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_index/src/chef_wait_group.erl:175 — src/oc_erchef/apps/chef_index/src/chef_wait_group.erl:175-180 | src/oc_erchef/apps/chef_index/src/chef_wait_group.erl:183-188 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_sup.erl:139 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_sup.erl:139-144 | src/oc_bifrost/apps/bifrost/src/bifrost_sup.erl:61-66 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl:130 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_group.erl:130-135 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policy_groups.erl:108-113 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:33 — src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:33-38 | src/oc_erchef/apps/chef_db/itest/chef_sql_data_bag_item.erl:47-53 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/bookshelf/src/bksw_wm_bucket.erl:79 — src/bookshelf/src/bksw_wm_bucket.erl:79-84 | src/bookshelf/src/bksw_wm_sql_bucket.erl:79-84 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_environment.erl:191 — src/oc_erchef/apps/chef_objects/src/chef_environment.erl:191-196 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_organization.erl:107-112 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×8
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_named_revision.erl:65 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_named_revision.erl:65-69 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_revisions.erl:69-75 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:108 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:108-112 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:114-118 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search_index.erl:96 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search_index.erl:96-103 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_universe.erl:66-70 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:89 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:89-93 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policy_groups.erl:102-106 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/bookshelf/src/bksw_sql.erl:51 — src/bookshelf/src/bksw_sql.erl:51-55 | src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:23-27 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl:108 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl:108-112 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:145-149 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_data_bag.erl:169 — src/oc_erchef/apps/chef_objects/src/chef_data_bag.erl:169-175 | src/oc_erchef/apps/chef_objects/src/chef_depsolver.erl:99-103 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_organization.erl:133 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_organization.erl:133-137 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:506-510 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×8
  • Duplicated block (9 lines × 2) src/bookshelf/src/bksw_xml.erl:696 — src/bookshelf/src/bksw_xml.erl:696-704 | src/bookshelf/src/bksw_xml.erl:761-769 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:696` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/oc_erchef/apps/chef_test/src/chef_test_sup.erl:39 — src/oc_erchef/apps/chef_test/src/chef_test_sup.erl:39-47 | src/oc_erchef/src/oc_erchef_sup.erl:18-26 — before extracting anything, compare `src/oc_erchef/apps/chef_test/src/chef_test_sup.erl` and `src/oc_erchef/src/oc_erchef_sup.erl` as WHOLE FILES: 94% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) src/bookshelf/src/bksw_wm_bucket.erl:47 — src/bookshelf/src/bksw_wm_bucket.erl:47-55 | src/bookshelf/src/bksw_wm_sql_bucket.erl:47-55 — before extracting anything, compare `src/bookshelf/src/bksw_wm_bucket.erl` and `src/bookshelf/src/bksw_wm_sql_bucket.erl` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) src/bookshelf/src/bksw_wm_bucket.erl:57 — src/bookshelf/src/bksw_wm_bucket.erl:57-65 | src/bookshelf/src/bksw_wm_sql_bucket.erl:57-65 — before extracting anything, compare `src/bookshelf/src/bksw_wm_bucket.erl` and `src/bookshelf/src/bksw_wm_sql_bucket.erl` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) src/bookshelf/src/bksw_wm_object.erl:79 — src/bookshelf/src/bksw_wm_object.erl:79-87 | src/bookshelf/src/bksw_wm_sql_object.erl:79-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/bookshelf/src/bksw_wm_object.erl:90` calls `get_object_and_bucket` and `src/bookshelf/src/bksw_wm_sql_object.erl:90` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_recipes.erl:36 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_recipes.erl:36-44 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_recipes.erl:47-56 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_recipes.erl:36` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:141 — src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:141-149 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:151-159 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:141` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) oc-chef-pedant/lib/pedant/rspec/client_util.rb:201 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:201-209 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:113-121 — before extracting anything, compare `oc-chef-pedant/lib/pedant/rspec/client_util.rb` and `oc-chef-pedant/lib/pedant/rspec/user_util.rb` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×8
  • Swallowed exception (caught, then discarded) src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb:288 — `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authn_ldap.erl:73 — `catch _Module:_Reason` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:143 — `catch _:_` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/oc_erchef/apps/chef_telemetry/src/chef_telemetry_worker.erl:100 — `catch _:_` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/oc-id/app/models/user.rb:103 — `rescue => e` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) src/chef-server-ctl/plugins/wrap-knife.rb:243 — `rescue => e` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) oc-chef-pedant/lib/pedant/rspec/search_util.rb:634 — `… rescue []` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) dev/dvm/lib/dvm/project/erlang.rb:70 — `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D29 · Static Analysis (SAST) · REDACTED · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · FileTooLong · ×7
  • FileTooLong: src/bksw_xml.erl src/bookshelf/src/bksw_xml.erl — FileTooLong — 1287 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 787 over it, 2.57× the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them.
  • FileTooLong: src/chef_sql.erl src/oc_erchef/apps/chef_db/src/chef_sql.erl — FileTooLong — 1050 significant lines (blank, comment-only and punctuation-only lines excluded), declaring 85 functions. The bar is 500 significant lines; this is 550 over it, 2.10× the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them.
  • FileTooLong: src/oc_chef_wm_base.erl src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl — FileTooLong — 1010 significant lines (blank, comment-only and punctuation-only lines excluded), declaring 79 functions. The bar is 500 significant lines; this is 510 over it, 2.02× the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 640 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 140 over it, 1.28× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: src/chef_cookbook_version.erl src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl — FileTooLong — 593 significant lines (blank, comment-only and punctuation-only lines excluded), declaring 67 functions. The bar is 500 significant lines; this is 93 over it, 1.19× the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them.
  • FileTooLong: src/chef_db.erl src/oc_erchef/apps/chef_db/src/chef_db.erl — FileTooLong — 536 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 36 over it, 1.07× the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them.
  • FileTooLong: rspec/search_util.rb oc-chef-pedant/lib/pedant/rspec/search_util.rb — FileTooLong — 522 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 22 over it, 1.04× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Edited copy of a member (2 corresponding lines) · ×7
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_universe.erl:60 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_universe.erl:60-61 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_validate.erl:68-69 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:119 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:119-120 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:123-124 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:49 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:49-51 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policy_groups.erl:65-66 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:240 — src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:240-241 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_revision.erl:193-194 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_key.erl:213 — src/oc_erchef/apps/chef_objects/src/chef_key.erl:213-214 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_association.erl:157-158 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/bookshelf/src/bksw_io_names.erl:97 — src/bookshelf/src/bksw_io_names.erl:97-98 | src/oc_erchef/apps/chef_objects/src/chef_password.erl:115-116 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:181 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:181-182 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:147-148 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D5 · Coupling · Off the main sequence · ×7
  • Off the main sequence: chef_db — chef_db: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: chef_index — chef_index: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: chef_license — chef_license: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: chef_telemetry — chef_telemetry: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
  • Off the main sequence: data_collector — data_collector: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: depsolver — depsolver: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
  • Off the main sequence: chef_objects — chef_objects: abstractness 0.03, instability 0.00, distance 0.97 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
D17 · Explicit Debt · XxxComment · ×6
  • XxxComment src/oc_bifrost/apps/bifrost/src/bifrost_wm_error.erl:21 — %% request (which could contain true or {halt, XXX} if some other return code is — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment src/oc_bifrost/apps/bifrost/src/bifrost_wm_error.erl:62 — %% request (which should contain {halt, XXX} with whatever return code is — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `% REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment oc-chef-pedant/lib/pedant/rspec/search_util.rb:265 — # The 'with temporary testing XXX' context exposes a let — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment oc-chef-pedant/lib/pedant/rspec/search_util.rb:305 — # XXX' context. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment oc-chef-pedant/lib/pedant/rspec/search_util.rb:408 — # All 'with temporary testing XXX' contexts allow you to — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment oc-chef-pedant/lib/pedant/rspec/search_util.rb:415 — # generated by the 'with temporary testing XXX' context (all — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×6
  • Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:82 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:82-94 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_system_recovery.erl:81-91 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:78 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:78-88 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:67-78 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) oc-chef-pedant/lib/pedant/rspec/validations.rb:185 — oc-chef-pedant/lib/pedant/rspec/validations.rb:185-195 | oc-chef-pedant/lib/pedant/rspec/validations.rb:267-277 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:103 — src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:103-113 | src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:180-190 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:219 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:219-229 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:239-250 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/oc-id/app/mailers/email_verify_mailer.rb:17 — src/oc-id/app/mailers/email_verify_mailer.rb:17-29 | src/oc-id/app/mailers/password_reset_mailer.rb:5-15 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×6
  • Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:118 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:118-124 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_users.erl:97-106 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) oc-chef-pedant/lib/pedant/chef_utility.rb:26 — oc-chef-pedant/lib/pedant/chef_utility.rb:26-32 | oc-chef-pedant/lib/pedant/requestor.rb:79-87 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object.erl:238 — src/oc_erchef/apps/chef_objects/src/chef_object.erl:238-245 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:1346-1352 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/bookshelf/src/bksw_wm_object.erl:116 — src/bookshelf/src/bksw_wm_object.erl:116-122 | src/bookshelf/src/bksw_wm_sql_object.erl:127-135 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/bookshelf/src/bksw_wm_object.erl:108 — src/bookshelf/src/bksw_wm_object.erl:108-114 | src/bookshelf/src/bksw_wm_sql_object.erl:117-125 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:195 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:195-201 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:159-165 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×5
  • Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:146 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:146-156 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:170-179 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_environment.erl:78 — src/oc_erchef/apps/chef_objects/src/chef_environment.erl:78-87 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:122-131 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl:846 — src/oc_erchef/apps/chef_db/src/chef_sql.erl:846-855 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1183-1193 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_cookbook_artifact_version.erl:139 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_cookbook_artifact_version.erl:139-148 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_group.erl:138-148 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl:295 — src/oc_erchef/apps/chef_objects/src/chef_node.erl:295-305 | src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:264-273 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×5
  • Duplicated block (8 lines × 2) src/bookshelf/src/bksw_xml.erl:456 — src/bookshelf/src/bksw_xml.erl:456-463 | src/bookshelf/src/bksw_xml.erl:499-506 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:456` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_revisions.erl:77 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_revisions.erl:77-84 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policy_group_policy_rev.erl:90-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:121 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:121-128 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:131-138 — before extracting anything, compare `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl` and `src/oc_erchef/apps/chef_index/src/chef_opensearch.erl` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:121` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_client.erl:330 — src/oc_erchef/apps/chef_objects/src/chef_client.erl:330-337 | src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:237-244 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:136 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:136-143 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:102-109 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×5
  • Duplicated block (6 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_node.erl:281 — src/oc_erchef/apps/chef_objects/src/chef_node.erl:281-286 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:197-204 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_objects/src/chef_node.erl:281` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_roles.erl:71 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_roles.erl:71-76 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl:90-95 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environment_roles.erl:71` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/bookshelf/src/bksw_io_names.erl:43 — src/bookshelf/src/bksw_io_names.erl:43-48 | src/oc_erchef/apps/chef_index/src/chef_index_query.erl:152-157 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_container.erl:74 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_container.erl:74-79 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_organization.erl:90-95 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_container.erl:74` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) src/chef-server-ctl/plugins/notice.rb:856 — src/chef-server-ctl/plugins/notice.rb:856-861 | src/chef-server-ctl/plugins/notice.rb:1115-1123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
AC3 · Page structure · Page without a main landmark · ×4
  • Page without a main landmark src/oc-id/app/views/layouts/application.html.erb:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark src/oc-id/public/404.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark src/oc-id/public/422.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark src/oc-id/public/500.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D29 · Static Analysis (SAST) · REDACTED · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×4
  • Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:104 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:104-125 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_sandbox.erl:69-84 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl:337 — src/oc_erchef/apps/chef_db/src/chef_sql.erl:337-352 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1474-1490 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl:112 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl:112-127 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl:167-182 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb:263 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:263-278 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:176-191 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) · ×4
  • Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:190 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:190-195 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:197-202 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:204-209 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_client.erl:119 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_client.erl:119-127 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_key.erl:147-152 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_user.erl:316-323 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:12 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:12-17 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_recipes.erl:10-16 | src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:11-17 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 6+ corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_key.erl:216 — src/oc_erchef/apps/chef_objects/src/chef_key.erl:216-221 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:327-334 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_org_user_invite.erl:139-145 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×4
  • Duplicated block (13 lines × 2) src/bookshelf/src/bksw_xml.erl:708 — src/bookshelf/src/bksw_xml.erl:708-720 | src/bookshelf/src/bksw_xml.erl:769-781 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:708` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:31 — src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:31-43 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:90-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:31` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:68 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:68-80 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_system_recovery.erl:67-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/chef-server-ctl/plugins/key_control.rb:57 — src/chef-server-ctl/plugins/key_control.rb:57-69 | src/chef-server-ctl/plugins/key_control.rb:193-205 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×4
  • Duplicated block (11 lines × 2) src/bookshelf/src/bksw_xml.erl:412 — src/bookshelf/src/bksw_xml.erl:412-422 | src/bookshelf/src/bksw_xml.erl:465-475 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:412` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/bookshelf/src/bksw_xml.erl:471 — src/bookshelf/src/bksw_xml.erl:471-481 | src/bookshelf/src/bksw_xml.erl:616-626 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:471` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:89 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:89-99 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:84-94 — before extracting anything, compare `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl` and `src/oc_erchef/apps/chef_index/src/chef_opensearch.erl` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) oc-chef-pedant/lib/pedant/rspec/validations.rb:132 — oc-chef-pedant/lib/pedant/rspec/validations.rb:132-142 | oc-chef-pedant/lib/pedant/rspec/validations.rb:215-225 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×4
  • Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl:259 — src/bookshelf/src/bksw_xml.erl:259-265 | src/bookshelf/src/bksw_xml.erl:352-358 | src/bookshelf/src/bksw_xml.erl:889-895 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:259` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl:293 — src/bookshelf/src/bksw_xml.erl:293-299 | src/bookshelf/src/bksw_xml.erl:700-706 | src/bookshelf/src/bksw_xml.erl:765-771 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:293` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl:418 — src/bookshelf/src/bksw_xml.erl:418-424 | src/bookshelf/src/bksw_xml.erl:471-477 | src/bookshelf/src/bksw_xml.erl:616-622 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:418` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/bookshelf/src/bksw_xml.erl:525 — src/bookshelf/src/bksw_xml.erl:525-531 | src/bookshelf/src/bksw_xml.erl:548-554 | src/bookshelf/src/bksw_xml.erl:575-581 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:525` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×4
  • Duplicated block (7 lines × 2) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:183 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:183-189 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl:113-120 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:183` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:203 — src/oc_erchef/apps/chef_objects/src/chef_data_bag_item.erl:203-209 | src/oc_erchef/apps/chef_objects/src/chef_sandbox.erl:57-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_node.erl:267 — src/oc_erchef/apps/chef_objects/src/chef_node.erl:267-273 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:183-189 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) src/chef-server-ctl/plugins/notice.rb:818 — src/chef-server-ctl/plugins/notice.rb:818-824 | src/chef-server-ctl/plugins/notice.rb:876-882 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×3
  • Edited copy of a member (14 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl:86 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl:86-99 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_container.erl:55-69 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) oc-chef-pedant/lib/pedant/rspec/search_util.rb:108 — oc-chef-pedant/lib/pedant/rspec/search_util.rb:108-124 | oc-chef-pedant/lib/pedant/rspec/search_util.rb:498-511 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:69 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policies.erl:69-82 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_policy_groups.erl:81-95 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
AC3 · Page structure · Heading level jumps from h1 to h4 · ×2
  • Heading level jumps from h1 to h4 src/oc-id/app/views/doorkeeper/applications/show.html.erb:7 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h1 to h4 src/oc-id/app/views/doorkeeper/authorizations/new.html.erb:6 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
D3 · God Classes · TooManyMethods · ×2
  • TooManyMethods: Platform REDACTED:23 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CookbookUtil REDACTED:22 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (44 corresponding lines) · ×2
  • Edited copy of a member (44 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb:201 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:201-244 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:113-157 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (44 corresponding lines) REDACTED:768 — REDACTED:768-811 | REDACTED:904-950 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×2
  • Edited copy of a member (13 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy.erl:71 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy.erl:71-83 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_policy_named_revision.erl:72-85 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_node.erl:276 — src/oc_erchef/apps/chef_objects/src/chef_node.erl:276-288 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:192-206 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (3 corresponding lines) · ×2
  • Edited copy of a member (3 corresponding lines) src/bookshelf/src/bksw_io_names.erl:31 — src/bookshelf/src/bksw_io_names.erl:31-33 | src/oc_erchef/apps/chef_index/src/chef_index_query.erl:139-141 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:207 — src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:207-209 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:172-174 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 9+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_environment.erl:114 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_environment.erl:114-122 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_node.erl:103-111 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl:123-132 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 9+ corresponding lines) src/bookshelf/src/bksw_sql.erl:202 — src/bookshelf/src/bksw_sql.erl:202-210 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:902-911 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:918-927 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environments.erl:98 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environments.erl:98-101 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_nodes.erl:119-122 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_keys.erl:215-218 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_containers.erl:62 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_containers.erl:62-65 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_organizations.erl:81-84 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_users.erl:76-79 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 3+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 3+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:105 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:105-107 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_roles.erl:90-92 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_organizations.erl:89-91 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 3+ corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_data_bag.erl:116 — src/oc_erchef/apps/chef_objects/src/chef_data_bag.erl:116-119 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:164-166 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:130-132 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×2
  • Duplicated block (17 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:255 — src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:255-271 | src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:295-311 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:255` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) REDACTED:195 — REDACTED:195-211 | REDACTED:231-247 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:195` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) src/bookshelf/src/bksw_xml.erl:515 — src/bookshelf/src/bksw_xml.erl:515-529 | src/bookshelf/src/bksw_xml.erl:538-552 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:515` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) REDACTED:469 — REDACTED:469-483 | REDACTED:505-519 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×2
  • Duplicated block (11 lines × 3) src/bookshelf/src/bksw_app.erl:33 — src/bookshelf/src/bksw_app.erl:33-43 | src/oc_bifrost/apps/bifrost/src/bifrost_app.erl:13-23 | src/oc_erchef/src/oc_erchef_app.erl:27-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_app.erl:33` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/bookshelf/src/bksw_app.erl:45` calls `maybe_start_sqerl`, `storage_type` and `src/oc_erchef/src/oc_erchef_app.erl:39` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 3) src/bookshelf/src/bksw_xml.erl:438 — src/bookshelf/src/bksw_xml.erl:438-448 | src/bookshelf/src/bksw_xml.erl:483-493 | src/bookshelf/src/bksw_xml.erl:624-634 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:438` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×2
  • Duplicated block (9–10 lines × 2) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:111 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:111-119 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:119-128 — before extracting anything, compare `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl` and `src/oc_erchef/apps/chef_index/src/chef_opensearch.erl` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:111` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9–10 lines × 2) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:179 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:179-187 | src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:199-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:179` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×2
  • Duplicated block (10 lines × 2) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:222 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:222-231 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:267-276 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:222` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/bookshelf/src/bksw_wm_object.erl:67 — src/bookshelf/src/bksw_wm_object.erl:67-77 | src/bookshelf/src/bksw_wm_sql_object.erl:68-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) src/oc_erchef/knife/chefreq.erl:7 — src/oc_erchef/knife/chefreq.erl:7-14 | src/oc_erchef/knife/chefreq.erl:19-26 | src/oc_erchef/knife/chefreq.erl:33-40 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/oc_erchef/knife/chefreq.erl:27` calls `keyreplace` and `src/oc_erchef/knife/chefreq.erl:15` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 3) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:186 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:186-193 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:150-157 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_revision.erl:196-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (7 lines × 6) · ×2
  • Duplicated block (7 lines × 6) src/bookshelf/src/bksw_xml.erl:297 — src/bookshelf/src/bksw_xml.erl:297-303 | src/bookshelf/src/bksw_xml.erl:712-718 | src/bookshelf/src/bksw_xml.erl:773-779 | src/bookshelf/src/bksw_xml.erl:949-955 | src/bookshelf/src/bksw_xml.erl:983-989 | src/bookshelf/src/bksw_xml.erl:1298-1304 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:297` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 6) src/oc_erchef/knife/chefreq.erl:7 — src/oc_erchef/knife/chefreq.erl:7-13 | src/oc_erchef/knife/chefreq.erl:19-25 | src/oc_erchef/knife/chefreq.erl:33-39 | src/oc_erchef/knife/chefreq.erl:47-53 | src/oc_erchef/knife/chefreq.erl:59-65 | src/oc_erchef/knife/chefreq.erl:72-78 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/oc_erchef/knife/chefreq.erl:27` calls `keyreplace` and `src/oc_erchef/knife/chefreq.erl:15` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×2
  • Duplicated block (5 lines × 3) src/bookshelf/src/bksw_xml.erl:529 — src/bookshelf/src/bksw_xml.erl:529-533 | src/bookshelf/src/bksw_xml.erl:560-564 | src/bookshelf/src/bksw_xml.erl:587-591 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:529` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:134 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:134-138 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:142-146 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:147-153 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:134` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
AC3 · Page structure · Data table has no header cells · ×1
  • Data table has no header cells src/oc-id/app/views/doorkeeper/applications/show.html.erb:12 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
D1 · Cyclomatic Complexity · oc_chef_authz_acl.fetch_id (cyclomatic 34) · ×1
  • oc_chef_authz_acl.fetch_id (cyclomatic 34) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_acl.erl:110 — oc_chef_authz_acl.fetch_id has cyclomatic complexity 34 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · chef_cbv_cache.handle_call (cyclomatic 17) · ×1
  • chef_cbv_cache.handle_call (cyclomatic 17) src/oc_erchef/apps/chef_objects/src/chef_cbv_cache.erl:158 — chef_cbv_cache.handle_call has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · bksw_wm_base.malformed_request (cyclomatic 16) · ×1
  • bksw_wm_base.malformed_request (cyclomatic 16) src/bookshelf/src/bksw_wm_base.erl:52 — bksw_wm_base.malformed_request has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · HTTP.connect (cyclomatic 16) · ×1
  • HTTP.connect (cyclomatic 16) REDACTED:22 — HTTP.connect has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D17 · Explicit Debt · HackComment · ×1
  • HackComment src/oc_erchef/apps/chef_objects/src/chef_user.erl:342 — %% Hack to get null public_key accepted as undefined — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D2 · Cognitive Complexity · bksw_wm_base.malformed_request (cognitive 35) · ×1
  • bksw_wm_base.malformed_request (cognitive 35) src/bookshelf/src/bksw_wm_base.erl:52 — bksw_wm_base.malformed_request has cognitive complexity 35 (threshold 15). Drivers by points: match/switch 16 (30 pts), loops 1 (3 pts), boolean chains 1, error handling 1 (nesting depth added 16). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · HTTP.connect (cognitive 28) · ×1
  • HTTP.connect (cognitive 28) REDACTED:22 — HTTP.connect has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (24 pts), boolean chains 2, error handling 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · chef_license_worker.process_license (cognitive 23) · ×1
  • chef_license_worker.process_license (cognitive 23) src/oc_erchef/apps/chef_license/src/chef_license_worker.erl:246 — chef_license_worker.process_license has cognitive complexity 23 (threshold 15). Drivers by points: match/switch 12 (23 pts) (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · chef_telemetry_worker.get_company_name (cognitive 17) · ×1
  • chef_telemetry_worker.get_company_name (cognitive 17) src/oc_erchef/apps/chef_telemetry/src/chef_telemetry_worker.erl:231 — chef_telemetry_worker.get_company_name has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 8 (13 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · chef_sql_cookbook_versions.fetch_cookbook_versions (cognitive 16) · ×1
  • chef_sql_cookbook_versions.fetch_cookbook_versions (cognitive 16) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:127 — chef_sql_cookbook_versions.fetch_cookbook_versions has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 8 (12 pts), boolean chains 3, loops 1 (nesting depth added 4). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · chef_telemetry_worker.mask (cognitive 16) · ×1
  • chef_telemetry_worker.mask (cognitive 16) src/oc_erchef/apps/chef_telemetry/src/chef_telemetry_worker.erl:380 — chef_telemetry_worker.mask has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 10 (16 pts) (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Medium vulnerability · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×1
  • Edited copy of a member (20 corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:24 — src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:24-48 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:83-115 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (7 members, 50+ identical tokens) src/oc_erchef/knife/chefreq.erl:6 — src/oc_erchef/knife/chefreq.erl:6-16 | src/oc_erchef/knife/chefreq.erl:18-30 | src/oc_erchef/knife/chefreq.erl:32-44 | src/oc_erchef/knife/chefreq.erl:46-56 | src/oc_erchef/knife/chefreq.erl:58-68 | src/oc_erchef/knife/chefreq.erl:71-81 | src/oc_erchef/knife/chefreq.erl:83-93 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:180 — REDACTED:180-211 | REDACTED:215-247 | REDACTED:367-396 | REDACTED:400-441 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Edited copy of a member (78 corresponding lines) · ×1
  • Edited copy of a member (78 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb:282 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:282-365 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:195-272 — These two members are one piece of code written twice and then edited apart: 78 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (75 corresponding lines) · ×1
  • Edited copy of a member (75 corresponding lines) oc-chef-pedant/lib/pedant/rspec/client_util.rb:369 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:369-456 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:276-350 — These two members are one piece of code written twice and then edited apart: 75 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×1
  • Edited copy of a member (23 corresponding lines) src/bookshelf/src/bksw_io.erl:125 — src/bookshelf/src/bksw_io.erl:125-148 | src/bookshelf/src/bksw_io.erl:151-173 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:450 — src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:450-486 | src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:492-520 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) oc-chef-pedant/lib/pedant/rspec/validations.rb:132 — oc-chef-pedant/lib/pedant/rspec/validations.rb:132-155 | oc-chef-pedant/lib/pedant/rspec/validations.rb:215-238 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_wm_base.erl:154 — src/oc_bifrost/apps/bifrost/src/bifrost_wm_base.erl:154-183 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:537-558 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 14+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 14+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:111 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data.erl:111-125 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:83-99 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_environment.erl:83-98 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_node.erl:75-88 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×1
  • Edited copy of a member (25 corresponding lines) REDACTED:459 — REDACTED:459-483 | REDACTED:487-519 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 19+ corresponding lines) src/bookshelf/src/bksw_app.erl:28 — src/bookshelf/src/bksw_app.erl:28-46 | src/oc_bifrost/apps/bifrost/src/bifrost_app.erl:6-24 | src/oc_erchef/src/oc_erchef_app.erl:14-39 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×1
  • Edited copy of a member (17 corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:52 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:52-68 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_org_invites.erl:141-160 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 11+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 11+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl:55 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl:55-68 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_group.erl:65-75 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_organization.erl:52-64 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×1
  • Edited copy of a member (19 corresponding lines) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:166 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:166-187 | src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:190-208 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 6+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 6+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_data.erl:72 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_data.erl:72-81 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_roles.erl:69-77 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_containers.erl:52-57 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_organizations.erl:67-72 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 8+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:69 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_data_item.erl:69-81 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_node.erl:62-70 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_role.erl:74-81 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×1
  • Edited copy of a member (18 corresponding lines) oc-chef-pedant/lib/pedant/config.rb:28 — oc-chef-pedant/lib/pedant/config.rb:28-54 | src/oc_bifrost/oc-bifrost-pedant/lib/pedant/config.rb:27-44 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×1
  • Edited copy of a member (15 corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:141 — src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:141-156 | src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:160-174 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 16+ corresponding lines) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:68 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:68-87 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:63-82 | src/oc_erchef/apps/chef_index/src/chef_solr.erl:73-88 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) src/oc_bifrost/apps/bifrost/src/bifrost_wm_acl_action_resource.erl:24 — src/oc_bifrost/apps/bifrost/src/bifrost_wm_acl_action_resource.erl:24-34 | src/oc_bifrost/apps/bifrost/src/bifrost_wm_acl_action_resource.erl:56-66 | src/oc_bifrost/apps/bifrost/src/bifrost_wm_acl_resource.erl:19-28 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 7+ corresponding lines) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:341 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:341-347 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:441-449 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:451-459 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 9+ corresponding lines) src/oc_erchef/apps/chef_db/src/chef_sql.erl:386 — src/oc_erchef/apps/chef_db/src/chef_sql.erl:386-395 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1565-1573 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1581-1590 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1592-1601 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:1603-1612 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 5+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 5+ corresponding lines) src/oc_erchef/apps/chef_db/itest/chef_sql_clients.erl:34 — src/oc_erchef/apps/chef_db/itest/chef_sql_clients.erl:34-38 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:38-43 | src/oc_erchef/apps/chef_db/itest/chef_sql_users.erl:79-83 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 4+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 4+ corresponding lines) src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:100 — src/oc_erchef/apps/oc_chef_wm/src/chef_wm_clients.erl:100-103 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_data.erl:86-89 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_environments.erl:90-93 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_nodes.erl:91-94 | src/oc_erchef/apps/oc_chef_wm/src/chef_wm_roles.erl:82-85 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 4+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 4+ corresponding lines) src/bookshelf/src/bksw_sql.erl:59 — src/bookshelf/src/bksw_sql.erl:59-62 | src/oc_bifrost/apps/bifrost/src/bifrost_db.erl:248-251 | src/oc_erchef/apps/chef_db/src/chef_sql.erl:763-766 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_db.erl:58-61 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 2+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 2+ corresponding lines) src/oc_erchef/apps/chef_objects/src/chef_client.erl:345 — src/oc_erchef/apps/chef_objects/src/chef_client.erl:345-346 | src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:823-824 | src/oc_erchef/apps/chef_objects/src/chef_data_bag.erl:177-178 | src/oc_erchef/apps/chef_objects/src/chef_environment.erl:205-206 | src/oc_erchef/apps/chef_objects/src/chef_role.erl:271-272 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_container.erl:121-122 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_group.erl:159-160 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 2 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) src/bookshelf/src/bksw_xml.erl:548 — src/bookshelf/src/bksw_xml.erl:548-571 | src/bookshelf/src/bksw_xml.erl:575-598 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:548` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) src/bookshelf/src/bksw_xml.erl:811 — src/bookshelf/src/bksw_xml.erl:811-829 | src/bookshelf/src/bksw_xml.erl:907-925 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:811` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 4) · ×1
  • Duplicated block (17 lines × 4) src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:53 — src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:53-69 | src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:80-96 | src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:108-124 | src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:139-155 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (14–16 lines × 2) · ×1
  • Duplicated block (14–16 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:47 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:47-62 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_system_recovery.erl:48-61 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_authenticate_user.erl:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–14 lines × 3) · ×1
  • Duplicated block (13–14 lines × 3) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:84 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:84-96 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:99-111 | src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:114-127 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:114` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:473 — src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:473-486 | src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:508-520 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:126 — src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:126-135 | src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:157-167 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_latest_cookbooks.erl:126` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 16) · ×1
  • Duplicated block (10 lines × 16) src/bookshelf/src/bksw_xml.erl:324 — src/bookshelf/src/bksw_xml.erl:324-333 | src/bookshelf/src/bksw_xml.erl:398-407 | src/bookshelf/src/bksw_xml.erl:635-644 | src/bookshelf/src/bksw_xml.erl:669-678 | src/bookshelf/src/bksw_xml.erl:723-732 | src/bookshelf/src/bksw_xml.erl:784-793 | src/bookshelf/src/bksw_xml.erl:858-867 | src/bookshelf/src/bksw_xml.erl:926-935 | src/bookshelf/src/bksw_xml.erl:956-965 | src/bookshelf/src/bksw_xml.erl:990-999 | src/bookshelf/src/bksw_xml.erl:1090-1099 | src/bookshelf/src/bksw_xml.erl:1124-1133 | src/bookshelf/src/bksw_xml.erl:1150-1159 | src/bookshelf/src/bksw_xml.erl:1184-1193 | src/bookshelf/src/bksw_xml.erl:1236-1245 | src/bookshelf/src/bksw_xml.erl:1305-1314 — all 16 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:324` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 3) · ×1
  • Duplicated block (9–10 lines × 3) src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:51 — src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:51-60 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:26-34 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:85-93 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_deps.erl:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–10 lines × 2) · ×1
  • Duplicated block (7–10 lines × 2) src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl:59 — src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl:59-68 | src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_group.erl:69-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_groups.erl:59` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 8) · ×1
  • Duplicated block (8 lines × 8) src/bookshelf/src/bksw_xml.erl:347 — src/bookshelf/src/bksw_xml.erl:347-354 | src/bookshelf/src/bksw_xml.erl:661-668 | src/bookshelf/src/bksw_xml.erl:695-702 | src/bookshelf/src/bksw_xml.erl:760-767 | src/bookshelf/src/bksw_xml.erl:810-817 | src/bookshelf/src/bksw_xml.erl:906-913 | src/bookshelf/src/bksw_xml.erl:978-985 | src/bookshelf/src/bksw_xml.erl:1116-1123 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:347` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (4–8 lines × 4) · ×1
  • Duplicated block (4–8 lines × 4) src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:253 — src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:253-256 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:274-277 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:297-303 | src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:318-325 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:253` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×1
  • Duplicated block (6 lines × 4) src/bookshelf/src/bksw_xml.erl:258 — src/bookshelf/src/bksw_xml.erl:258-263 | src/bookshelf/src/bksw_xml.erl:551-556 | src/bookshelf/src/bksw_xml.erl:578-583 | src/bookshelf/src/bksw_xml.erl:888-893 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:258` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5–6 lines × 3) · ×1
  • Duplicated block (5–6 lines × 3) src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:127 — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:127-132 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:137-141 | src/oc_erchef/apps/chef_index/src/chef_opensearch.erl:155-160 — before extracting anything, compare `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl` and `src/oc_erchef/apps/chef_index/src/chef_opensearch.erl` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:127` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) src/bookshelf/src/bksw_xml.erl:259 — src/bookshelf/src/bksw_xml.erl:259-263 | src/bookshelf/src/bksw_xml.erl:352-356 | src/bookshelf/src/bksw_xml.erl:552-556 | src/bookshelf/src/bksw_xml.erl:579-583 | src/bookshelf/src/bksw_xml.erl:889-893 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:259` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×1
  • Duplicated block (5 lines × 4) src/bookshelf/src/bksw_xml.erl:525 — src/bookshelf/src/bksw_xml.erl:525-529 | src/bookshelf/src/bksw_xml.erl:548-552 | src/bookshelf/src/bksw_xml.erl:575-579 | src/bookshelf/src/bksw_xml.erl:743-747 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/bookshelf/src/bksw_xml.erl:525` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:145 — src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy.erl:145-150 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:111-116 | src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_revision.erl:168-173 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/oc_erchef/apps/oc_chef_authz/src/oc_chef_policy_group.erl:111` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 7) · ×1
  • Duplicated block (7 lines × 7) src/oc_erchef/knife/chefreq.erl:7 — src/oc_erchef/knife/chefreq.erl:7-13 | src/oc_erchef/knife/chefreq.erl:19-25 | src/oc_erchef/knife/chefreq.erl:33-39 | src/oc_erchef/knife/chefreq.erl:47-53 | src/oc_erchef/knife/chefreq.erl:59-65 | src/oc_erchef/knife/chefreq.erl:72-78 | src/oc_erchef/knife/chefreq.erl:84-90 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/oc_erchef/knife/chefreq.erl:27` calls `keyreplace` and `src/oc_erchef/knife/chefreq.erl:15` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (36–37 lines × 2) · ×1
  • Duplicated block (36–37 lines × 2) src/chef-server-ctl/plugins/key_control.rb:30 — src/chef-server-ctl/plugins/key_control.rb:30-66 | src/chef-server-ctl/plugins/key_control.rb:108-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (35–36 lines × 2) · ×1
  • Duplicated block (35–36 lines × 2) REDACTED:777 — REDACTED:777-811 | REDACTED:915-950 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (31–32 lines × 2) · ×1
  • Duplicated block (31–32 lines × 2) src/chef-server-ctl/plugins/key_control.rb:172 — src/chef-server-ctl/plugins/key_control.rb:172-202 | src/chef-server-ctl/plugins/key_control.rb:221-252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (58 lines × 2) · ×1
  • Duplicated block (58 lines × 2) src/chef-server-ctl/plugins/notice.rb:1309 — src/chef-server-ctl/plugins/notice.rb:1309-1366 | src/chef-server-ctl/plugins/notice.rb:1396-1453 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/chef-server-ctl/plugins/notice.rb:1309` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) src/chef-server-ctl/plugins/rotate_credentials.rb:37 — src/chef-server-ctl/plugins/rotate_credentials.rb:37-61 | src/chef-server-ctl/plugins/rotate_credentials.rb:77-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (18–23 lines × 3) · ×1
  • Duplicated block (18–23 lines × 3) src/chef-server-ctl/plugins/rotate_credentials.rb:47 — src/chef-server-ctl/plugins/rotate_credentials.rb:47-69 | src/chef-server-ctl/plugins/rotate_credentials.rb:87-108 | src/chef-server-ctl/plugins/rotate_credentials.rb:127-144 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (18–19 lines × 5) · ×1
  • Duplicated block (18–19 lines × 5) src/chef-server-ctl/plugins/key_control.rb:94 — src/chef-server-ctl/plugins/key_control.rb:94-111 | src/chef-server-ctl/plugins/key_control.rb:168-185 | src/chef-server-ctl/plugins/key_control.rb:217-235 | src/chef-server-ctl/plugins/key_control.rb:265-282 | src/chef-server-ctl/plugins/key_control.rb:295-312 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/chef-server-ctl/plugins/key_control.rb:94` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×1
  • Duplicated block (16–17 lines × 2) oc-chef-pedant/lib/pedant/rspec/user_util.rb:300 — oc-chef-pedant/lib/pedant/rspec/user_util.rb:300-316 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:320-335 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (14 lines × 6) · ×1
  • Duplicated block (14 lines × 6) src/chef-server-ctl/plugins/key_control.rb:93 — src/chef-server-ctl/plugins/key_control.rb:93-106 | src/chef-server-ctl/plugins/key_control.rb:167-180 | src/chef-server-ctl/plugins/key_control.rb:216-229 | src/chef-server-ctl/plugins/key_control.rb:264-277 | src/chef-server-ctl/plugins/key_control.rb:294-307 | src/chef-server-ctl/plugins/key_control.rb:326-339 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/chef-server-ctl/plugins/key_control.rb:91` calls `exit_failure` and `src/chef-server-ctl/plugins/key_control.rb:214` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×1
  • Duplicated block (13 lines × 4) REDACTED:197 — REDACTED:197-209 | REDACTED:233-245 | REDACTED:377-389 | REDACTED:429-441 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:197` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×1
  • Duplicated block (12–13 lines × 2) src/chef-server-ctl/plugins/server_admins.rb:77 — src/chef-server-ctl/plugins/server_admins.rb:77-88 | src/chef-server-ctl/plugins/server_admins.rb:123-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/chef-server-ctl/plugins/server_admins.rb:74` calls `get_user_authz_id` and `src/chef-server-ctl/plugins/server_admins.rb:120` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) oc-chef-pedant/lib/pedant/rspec/client_util.rb:288 — oc-chef-pedant/lib/pedant/rspec/client_util.rb:288-298 | oc-chef-pedant/lib/pedant/rspec/user_util.rb:201-212 — before extracting anything, compare `oc-chef-pedant/lib/pedant/rspec/client_util.rb` and `oc-chef-pedant/lib/pedant/rspec/user_util.rb` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `oc-chef-pedant/lib/pedant/rspec/user_util.rb:213` calls `authenticate_user`, `be` and `oc-chef-pedant/lib/pedant/rspec/client_util.rb:301` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–8 lines × 2) · ×1
  • Duplicated block (6–8 lines × 2) src/chef-server-ctl/plugins/notice.rb:1057 — src/chef-server-ctl/plugins/notice.rb:1057-1062 | src/chef-server-ctl/plugins/notice.rb:1066-1073 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (6 lines × 5) · ×1
  • Duplicated block (6 lines × 5) src/chef-server-ctl/plugins/notice.rb:814 — src/chef-server-ctl/plugins/notice.rb:814-819 | src/chef-server-ctl/plugins/notice.rb:870-877 | src/chef-server-ctl/plugins/notice.rb:943-948 | src/chef-server-ctl/plugins/notice.rb:1270-1275 | src/chef-server-ctl/plugins/notice.rb:1283-1288 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (3–5 lines × 10) · ×1
  • Duplicated block (3–5 lines × 10) src/chef-server-ctl/plugins/notice.rb:829 — src/chef-server-ctl/plugins/notice.rb:829-834 | src/chef-server-ctl/plugins/notice.rb:856-861 | src/chef-server-ctl/plugins/notice.rb:1091-1093 | src/chef-server-ctl/plugins/notice.rb:1115-1123 | src/chef-server-ctl/plugins/notice.rb:1143-1152 | src/chef-server-ctl/plugins/notice.rb:1175-1179 | src/chef-server-ctl/plugins/notice.rb:1187-1191 | src/chef-server-ctl/plugins/notice.rb:1202-1206 | src/chef-server-ctl/plugins/notice.rb:1214-1220 | src/chef-server-ctl/plugins/notice.rb:1296-1300 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
R1 · Type Safety · Type Safety · ×1
  • Type Safety — 0 typed · 9 plain JS — the untyped files are src/oc-id/app/assets/config/manifest.js, src/oc-id/app/assets/javascripts/application.js, src/oc-id/app/assets/javascripts/chef-web-core.js, src/oc-id/lib/assets/javascripts/chef.js, src/oc-id/lib/assets/javascripts/chef/chef.js, src/oc-id/lib/assets/javascripts/chef/components/icon.js (+3 more).
Minor — 242 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×219
  • Orphaned file oc-chef-pedant/lib/pedant/rspec/search_util.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_db/src/chef_db.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_objects/src/chef_cookbook_version.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_db/itest/chef_sql_cookbook_versions.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file oc-chef-pedant/lib/pedant/rspec/common.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_objects/src/chef_user.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file oc-chef-pedant/lib/pedant/rspec/client_util.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/chef_wm_search.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/chef_wm_depsolver.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file oc-chef-pedant/lib/pedant/rspec/user_util.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_scoped_name.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file oc-chef-pedant/lib/pedant/rspec/auth_headers_util.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/oc_chef_associations.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_db/itest/chef_sql_environment_cookbooks.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_bifrost/oc-bifrost-pedant/lib/pedant/rspec/common.rb:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/chef_reindex.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_authz/src/oc_chef_authz_org_creator.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/bookshelf/src/bksw_io.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_named_user.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/oc_chef_wm/src/chef_wm_util.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_db/itest/itest_cookbook_util.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/oc_erchef/apps/chef_objects/src/chef_object_base.erl:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 194 more in this group — see findings.md.
D30 · Dependency Vulnerabilities · Low CVE · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file src/oc_erchef/apps/chef_db/src/chef_sql.erl:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file src/oc_erchef/apps/oc_chef_wm/src/oc_chef_wm_base.erl:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file src/bookshelf/src/bksw_xml.erl:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
D28 · Secrets (history) · REDACTED
  • REDACTED
  • REDACTED
X10 · Duplicated predicate · Duplicated predicate · ×2
  • Duplicated predicate src/oc_erchef/apps/chef_objects/src/chef_node.erl:282 — `Name =:= UrlName orelse Name =:= undefined` appears character-identically in 2 files — src/oc_erchef/apps/chef_objects/src/chef_node.erl, src/oc_erchef/apps/chef_objects/src/chef_role.erl. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl:167 — `Type == client orelse Type == data_bag_item orelse Type == environment orelse Type == node orelse Type == role` appears character-identically in 3 files — src/oc_erchef/apps/chef_index/src/chef_elasticsearch.erl, src/oc_erchef/apps/chef_index/src/chef_opensearch.erl, src/oc_erchef/apps/chef_index/src/chef_solr.erl. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D13 · REDACTED Scanning · REDACTED · ×1
  • REDACTED
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found src/oc_erchef/rebar.config:127 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `src/oc_erchef/rebar.config` makes this repository a deployable product (line 127).
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D34 · Knowledge Freshness · Concentrated knowledge decay · ×1
  • Concentrated knowledge decay — 222 of 233 significant files have no living knowledge, while the repository is still being changed at a low rate (29 commit(s) in the last 90 days) — so this is one repo-wide knowledge-decay state, not 222 separate risks. Counted over 233 of the 404 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. The code moved on without the people who understood these files: document them or schedule a read-through before the next change lands in them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 10/12 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `docs-chef-io`.
P3 · Security & performance tooling · Dependabot does not watch github-actions/gomod/gitsubmodule · ×1
  • Dependabot does not watch github-actions/gomod/gitsubmodule .github/workflows/archived/dependabot.yml:2 — `.github/workflows/archived/dependabot.yml` schedules updates, but no `package-ecosystem` entry covers `github-actions`, `gomod`, `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entries to the `updates:` list.
P4 · Deployment & Rollback · No release approval gate · ×1
  • No release approval gate — Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it.
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected src/nginx/habitat/config/nginx.conf:55 — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `nginx.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.)
X31 · Test-only surface in a production module · Test-only surface in a production module · ×1
  • Test-only surface in a production module src/oc_erchef/apps/chef_license/src/chef_license_worker.erl:7 — `chef_license_worker:test_license/0` is exported unconditionally and its name carries a test marker at a name-segment boundary, so the shipped module publishes a function named for the test tree. No other module in this repository calls it at any arity. Erlang has no visibility below `-export`, so this is part of the module's public contract: it cannot be changed without a compatibility argument. Nothing tells the next maintainer that its only caller is a test. Wrapping the attribute in `-ifdef(TEST). … -endif.` keeps the test's access and removes it from the shipped module.
X5 · Nullable reference types · Ruby's type checker does not check nil everywhere · ×1
  • Ruby's type checker does not check nil everywhere — This repository commits no Sorbet configuration (`sorbet/config`) and no `Steepfile`, so nothing type-checks its 163 Ruby product file(s): a nilable value reaches a method call silently and raises `NoMethodError: undefined method … for nil` the first time it is nil. A `# typed:` sigil does nothing without a `sorbet/config` beside the code; a Steep run configured only on a command line is not something this check can read.
Minor — 21 finding(s)
D12 · Dependency Hygiene · Outdated · ×21
  • Outdated: addressable — `addressable` is resolved to 2.9.0 in the committed REDACTED but 2.9.2 is the current release on rubygems.org, and oc-chef-pedant/oc-chef-pedant.gemspec declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update addressable` and commit the updated REDACTED.
  • Outdated: chef-utils — `chef-utils` is resolved to 19.2.110 in the committed REDACTED but 19.4.46 is the current release on rubygems.org, and it already satisfies the `">= 16.17.51"` requirement declared in oc-chef-pedant/oc-chef-pedant.gemspec — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update chef-utils` and commit the updated REDACTED.
  • Outdated: doorkeeper — `doorkeeper` is resolved to 5.9.0 in the committed REDACTED but 5.9.9 is the current release on rubygems.org, and it already satisfies the `"~> 5.0"` requirement declared in src/oc-id/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update doorkeeper` and commit the updated REDACTED.
  • Outdated: faraday — `faraday` is resolved to 2.14.3 in the committed REDACTED but 2.15.1 is the current release on rubygems.org, and it already satisfies the `">= 2.14.3"` requirement declared in src/chef-server-ctl/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update faraday` and commit the updated REDACTED.
  • Outdated: ffi-yajl — `ffi-yajl` is resolved to 2.7.11 in the committed REDACTED but 3.0.1 is the current release on rubygems.org, and it already satisfies the `">= 1.2.0"` requirement declared in src/chef-server-ctl/chef-server-ctl.gemspec — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. This crosses a major version, so read the changelog before taking it. Run `bundle update ffi-yajl` and commit the updated REDACTED.
  • Outdated: jbuilder — `jbuilder` is resolved to 2.14.1 in the committed REDACTED but 2.15.1 is the current release on rubygems.org, and it already satisfies the `"~> 2.11"` requirement declared in src/oc-id/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update jbuilder` and commit the updated REDACTED.
  • Outdated: jwt — `jwt` is resolved to 3.2.0 in the committed REDACTED but 3.3.0 is the current release on rubygems.org, and it already satisfies the `">= 3.2.0"` requirement declared in src/oc-id/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update jwt` and commit the updated REDACTED.
  • Outdated: knife-ec-backup — `knife-ec-backup` is resolved to 3.0.9 in the committed REDACTED but 3.0.11 is the current release on rubygems.org, and it already satisfies the `"~> 3.0.8"` requirement declared in src/chef-server-ctl/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update knife-ec-backup` and commit the updated REDACTED.
  • Outdated: mailcatcher — `mailcatcher` is resolved to 0.2.4 in the committed REDACTED but 0.11.0 is the current release on rubygems.org, and src/oc-id/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update mailcatcher` and commit the updated REDACTED.
  • Outdated: mixlib-install — `mixlib-install` is resolved to 3.17.0 in the committed REDACTED but 3.19.2 is the current release on rubygems.org, and src/chef-server-ctl/chef-server-ctl.gemspec declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update mixlib-install` and commit the updated REDACTED.
  • Outdated: mixlib-log — `mixlib-log` is resolved to 3.1.2.1 in the committed REDACTED but 3.2.3 is the current release on rubygems.org, and src/chef-server-ctl/chef-server-ctl.gemspec declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update mixlib-log` and commit the updated REDACTED.
  • Outdated: pry — `pry` is resolved to 0.16.0 in the committed REDACTED but 0.16.1 is the current release on rubygems.org, and oc-chef-pedant/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update pry` and commit the updated REDACTED.
  • Outdated: pry-byebug — `pry-byebug` is resolved to 3.8.0 in the committed REDACTED but 3.12.0 is the current release on rubygems.org, and oc-chef-pedant/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update pry-byebug` and commit the updated REDACTED.
  • Outdated: redis — `redis` is resolved to 5.4.1 in the committed REDACTED but 6.0.0 is the current release on rubygems.org, and src/chef-server-ctl/chef-server-ctl.gemspec declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. This crosses a major version, so read the changelog before taking it. Run `bundle update redis` and commit the updated REDACTED.
  • Outdated: responders — `responders` is resolved to 3.2.0 in the committed REDACTED but 3.2.1 is the current release on rubygems.org, and it already satisfies the `"~> 3.0, >= 3.0.1"` requirement declared in src/oc-id/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update responders` and commit the updated REDACTED.
  • Outdated: rspec — `rspec` is resolved to 3.12.0 in the committed REDACTED but 3.13.2 is the current release on rubygems.org, and src/chef-server-ctl/chef-server-ctl.gemspec declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update rspec` and commit the updated REDACTED.
  • Outdated: rspec_junit_formatter — `rspec_junit_formatter` is resolved to 0.6.0 in the committed REDACTED but 0.8.0 is the current release on rubygems.org, and it already satisfies the `"~> 0.2"` requirement declared in oc-chef-pedant/oc-chef-pedant.gemspec — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update rspec_junit_formatter` and commit the updated REDACTED.
  • Outdated: spring — `spring` is resolved to 4.5.0 in the committed REDACTED but 4.7.0 is the current release on rubygems.org, and src/oc-id/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update spring` and commit the updated REDACTED.
  • Outdated: thor — `thor` is resolved to 1.4.0 in the committed REDACTED but 1.5.0 is the current release on rubygems.org, and it already satisfies the `"~> 1.4"` requirement declared in src/oc-id/Gemfile — so the lockfile is behind this repository's own declared range. This build is therefore missing every fix published since, including any security fix. Run `bundle update thor` and commit the updated REDACTED.
  • Outdated: tzinfo-data — `tzinfo-data` is resolved to 1.2026.2 in the committed REDACTED but 1.2026.6 is the current release on rubygems.org, and src/oc-id/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update tzinfo-data` and commit the updated REDACTED.
  • Outdated: uuidtools — `uuidtools` is resolved to 2.2.0 in the committed REDACTED but 3.0.0 is the current release on rubygems.org, and src/oc_erchef/apps/chef_objects/priv/depselector_rb/Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. This crosses a major version, so read the changelog before taking it. Run `bundle update uuidtools` and commit the updated REDACTED.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-ffc8d2313ad94426ad43a5283612658e/history.json --exit-code 0 --source .12artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-ffc8d2313ad94426ad43a5283612658e/tree.json --exit-code 0 --source .3artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .32artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-38b4b659ca4f49229581fccfc76ad9f620artifacts/raw/osv-scanner.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .0artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 5 file(s) — `docs-chef-io/tools/vale/chef/name_lookarounds.rb`, `src/chef-server-ctl/habitat/config/pedant_config.rb`, `src/chef-server-ctl/habitat/config/pivotal.rb`, `src/oc-id/habitat/config/secret_token.rb`, `src/oc_erchef/habitat/config/chef_server_data_bootstrap.rb` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-38b4b659ca4f49229581fccfc76ad9f60artifacts/raw/osv-scanner.json

Run 01a1d451-edc1-7368-91d7-3f007af00fe6 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md