# Changelog

## Score

- CAI 44 → 43 (-0.1)
- Rubric changed (rubric-2026.10.5 → rubric-2026.11.2) — scores are not directly comparable.

## Lenses

- Code Health 100 → 100 (+0.0)
- Architecture 69 → 69 (+0.0)
- Maturity 51 → 48 (-2.6)
- Readiness 19 → 19 (+0.0)
- Security 100 → 100 (+0.0)
- Performance 70 → 77 (+7.4)

## Resolved (4)

- Inconsistent use of 'Succeed' vs 'Success' and 'Failed' vs 'Failure' across types and methods. The type `ITransactionParticipantPreCommitSucceed` uses the verb form 'Succeed', while the method `AddPreCommitSuccessParticipant` uses the noun 'Success'. Similarly, the type `ITransactionParticipantPreCommitFailed` uses the adjective 'Failed', while the method `AddPreCommitFailedParticipant` also uses 'Failed'. This creates a mismatch between the event type names and the command/actor method names. The convention should be consistent: either all use the verb form (Succeed/Failed is not a verb, so Succeeded/Failed) or all use the noun form (Success/Failure).
- The concept of a participant successfully completing the pre-commit phase is named inconsistently. One method uses 'PreCommitFailed' (which semantically contradicts 'Success' in the other name, or implies a different state) while the other uses 'PreCommitSuccess'. Given the context of 'Failed' vs 'Success', it is highly likely that 'PreCommitFailed' is a typo for 'PreCommitSucceeded' or vice versa, or that the naming convention for the success state is split between 'Success' and 'Succeeded'. However, looking at the events, we see `ITransactionParticipantPreCommitSucceed` and `ITransactionParticipantPreCommitFailed`. The method `AddPreCommitFailedParticipant` likely corresponds to the failure event, but the existence of `AddPreCommitSuccessParticipant` alongside `AddPreCommitFailedParticipant` suggests a symmetry issue where one uses the adjective 'Failed' and the other the noun/verb form 'Success'. More critically, comparing `AddPreCommitFailedParticipant` with `AddPreCommitSuccessParticipant` reveals a lack of parallel structure: 'Failed' is an adjective describing the state, 'Success' is a noun. The event interface uses `PreCommitSucceed` (verb/noun) and `PreCommitFailed` (adjective). The method names should align with the event names or each other. If the event is `PreCommitSucceed`, the method should likely be `AddPreCommitSucceededParticipant` or `AddPreCommitSuccessParticipant` is acceptable if the event was `PreCommitSuccess`. But `PreCommitFailed` vs `PreCommitSucceed` is the root inconsistency in the domain model naming.
- The property naming for the collection of participants is inconsistent. In the `AnyParticipantPreCommitFailed` event, the property is named `PreCommitSucceedTransactionParticipants`, which is semantically confusing (why does a 'Failed' event have 'Succeed' participants?) and structurally different from `TransactionParticipants` in the `AllParticipantPreCommitSucceed` event. It is likely that `PreCommitSucceedTransactionParticipants` is a typo for `PreCommitFailedTransactionParticipants` or that the naming convention for the collection is not consistent (`PreCommitSucceed...` vs `Transaction...`).
- XML-doc coverage: Eventual2PC (src/Eventual2PC/Eventual2PC.csproj)
