Public report of aaa1115910/bv, published 14 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 14 November 2026, 13:07 UTC · Survey ID cd_73a1ead38e4e4d3fae6ed4ea30c6fb98

aaa1115910/bv

Measured 14 November 2026, 13:07 UTC, at code version 0e454c0

CAI score 48out of 100 Adequate
CriticalWeakAdequateStrongExemplary
Up 1 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 69,335 lines of product code in 15 projects, tests not counted · Estimated rebuild effort: about 0.5 person-years · Weakest lens: Maturity, 37

Findings by how serious they are

47 critical 394 serious 306 minor

14 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
14 November 2026, 13:07 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

45of 45 dimensions measured by tools.
732of 747 findings point to an exact file and line, so you can open each one in the code. The other 15 concern the repository as a whole, such as missing documentation.
45dimensions across 6 lenses, read from 69,335 lines of product code in 15 projects.
Chapters

Executive summary

aaa1115910/bv falls short of our standard for a preview release because 280 files are no longer known to anyone active in the project and the project keeps no record of its design decisions. It scores 48 out of 100 and is rated Adequate, and 42 of its 47 critical findings are security problems in the build pipeline.

Maturity, at 37, is the weakest lens and counts most in the score. The best first step is recording design decisions, worth about 10 points. Having someone learn and document the 280 files no active contributor knows is another step, also worth about 10. Raising Maturity to 62 would lift the score to about 54.

Thirty-four pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Eight secrets can leak from the build pipeline, and five sets of files in separate parts keep changing together, which points to hidden dependencies. Pinning each tool to an exact version, limiting each secret to its own step and making the hidden dependencies explicit would close these risks.

The product code is 69,335 lines, about €66,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Maturity 37 · counts for 46%Production Readiness 38 · counts for 25%Security and Compliance 60 · counts for 14%Architecture 85 · counts for 8%Code Health 88 · counts for 4%Performance 100 · counts for 2%

If Maturity rose from 37 to 62, the lowest score rated Strong, the score would rise from 48 to about 54.

Code composition: what the lines of code are
Product code 96%Tests 4%
New since the last survey: 198 findings

These 198 critical or serious findings weren't in the previous survey, on 26 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Code Duplication · Near-duplicate member family (4 members, 41 shared lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt
  • Code Duplication · Near-duplicate member pair (118 shared lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Near-duplicate member pair (78 shared lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt
  • Code Duplication · Near-duplicate member pair (54 shared lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt
  • Code Duplication · Edited copy of a member (24 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt
  • Code Duplication · Edited copy of a member (149 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt
  • Code Duplication · Edited copy of a member (129 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Edited copies of one member (3 members, 106+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Edited copy of a member (92 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt
  • Code Duplication · Edited copy of a member (98 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Edited copy of a member (45 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt
  • Code Duplication · Edited copies of one member (4 members, 82+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt
  • Code Duplication · Edited copies of one member (3 members, 61+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt
  • Code Duplication · Edited copy of a member (52 corresponding lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt
  • Code Duplication · Edited copy of a member (59 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt
  • Code Duplication · Edited copy of a member (60 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt
  • Code Duplication · Edited copy of a member (35 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/LoginRepository.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (41 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt
  • Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (35 corresponding lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt
  • Code Duplication · Edited copy of a member (40 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt
  • Code Duplication · Edited copy of a member (33 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt
  • Code Duplication · Edited copies of one member (5 members, 36+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/ApiSetting.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt
  • Code Duplication · Edited copy of a member (31 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt
  • Code Duplication · Edited copy of a member (26 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt
  • Code Duplication · Edited copies of one member (3 members, 33+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt
  • Code Duplication · Edited copy of a member (29 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/RadioPreference.kt
  • Code Duplication · Edited copy of a member (31 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt
  • Code Duplication · Edited copy of a member (30 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt
  • Code Duplication · Edited copy of a member (27 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt
  • Code Duplication · Edited copy of a member (27 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt
  • Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt
  • Code Duplication · Edited copy of a member (21 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt
  • Code Duplication · Edited copies of one member (3 members, 25+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt
  • Code Duplication · Edited copy of a member (16 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt
  • Code Duplication · Edited copy of a member (21 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt
  • Code Duplication · Edited copy of a member (11 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (16 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt
  • Code Duplication · Edited copy of a member (12 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/Episode.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt
  • Code Duplication · Edited copy of a member (13 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt
  • Code Duplication · Edited copy of a member (17 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/SeasonViewModel.kt
  • Code Duplication · Edited copy of a member (23 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/QrTokenResultScreen.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/search/SearchInputViewModel.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt
  • Code Duplication · Edited copy of a member (13 corresponding lines) player/core/src/main/kotlin/dev/aaa1115910/bv/player/impl/exo/ExoMediaPlayer.kt
  • Code Duplication · Edited copies of one member (3 members, 22+ corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt
  • Code Duplication · Edited copies of one member (5 members, 19+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt
  • Code Duplication · Edited copy of a member (19 corresponding lines) app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/ImageTransform.kt
  • Code Duplication · Edited copy of a member (26 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SmallVideoCard.kt
  • Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt
  • Code Duplication · Edited copy of a member (20 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt
  • Code Duplication · Edited copy of a member (21 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Edited copy of a member (14 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/ListItemPreference.kt
  • Code Duplication · Edited copy of a member (11 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt
  • Code Duplication · Edited copy of a member (22 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt
  • Code Duplication · Edited copy of a member (13 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt
  • Code Duplication · Edited copy of a member (14 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/grpc/utils/Channel.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/network/VlcLibsApi.kt
  • Code Duplication · Edited copy of a member (18 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt
  • Code Duplication · Edited copy of a member (15 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt
  • Code Duplication · Edited copy of a member (9 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt
  • Code Duplication · Edited copy of a member (11 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt
  • Code Duplication · Duplicated block (71 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt
  • Code Duplication · Duplicated block (56 lines × 3) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt
  • Code Duplication · Duplicated block (51 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt
  • Code Duplication · Duplicated block (45 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt
  • Code Duplication · Duplicated block (39 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (38 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Duplicated block (36 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt
  • Code Duplication · Duplicated block (33 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt
  • Code Duplication · Duplicated block (33 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt
  • Code Duplication · Duplicated block (31–32 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (32 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Duplicated block (30 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt
  • Code Duplication · Duplicated block (29 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Duplicated block (29 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt
  • Code Duplication · Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt
  • Code Duplication · Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (27 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt
  • Code Duplication · Duplicated block (27 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt
  • Code Duplication · Duplicated block (26 lines × 4) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt
  • Code Duplication · Duplicated block (26 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Duplicated block (24–26 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (25 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/HomeScreen.kt
  • Code Duplication · Duplicated block (41–48 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (23–24 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 112 findings

These 112 critical or serious findings were in the previous survey, on 26 October 2026, and are gone from this one. The first 100 are listed here.

  • Code Duplication · Near-duplicate member pair (112 shared lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Near-duplicate member pair (62 shared lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt
  • Code Duplication · Near-duplicate member pair (55 shared lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt
  • Code Duplication · Duplicated block (71 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt
  • Code Duplication · Duplicated block (60 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (55 lines × 3) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt
  • Code Duplication · Duplicated block (41–48 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (45 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt
  • Code Duplication · Duplicated block (38 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Duplicated block (36 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt
  • Code Duplication · Duplicated block (33–34 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/video/VideoDetailViewModel.kt
  • Code Duplication · Duplicated block (33 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt
  • Code Duplication · Duplicated block (31 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Duplicated block (29 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Duplicated block (29 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt
  • Code Duplication · Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt
  • Code Duplication · Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (27 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt
  • Code Duplication · Duplicated block (26 lines × 4) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt
  • Code Duplication · Duplicated block (24–26 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (23–24 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (24 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt
  • Code Duplication · Duplicated block (23 lines × 3) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Duplicated block (23 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/settings/UpdateDialog.kt
  • Code Duplication · Duplicated block (22 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt
  • Code Duplication · Duplicated block (22 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt
  • Code Duplication · Duplicated block (22 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt
  • Code Duplication · Duplicated block (21 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt
  • Code Duplication · Duplicated block (16–21 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt
  • Code Duplication · Duplicated block (21 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt
  • Code Duplication · Duplicated block (21 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (19–20 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt
  • Code Duplication · Duplicated block (19 lines × 3) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt
  • Code Duplication · Duplicated block (18–19 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt
  • Code Duplication · Duplicated block (17–18 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (18 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt
  • Code Duplication · Duplicated block (18 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (18 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt
  • Code Duplication · Duplicated block (18 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt
  • Code Duplication · Duplicated block (16–17 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt
  • Code Duplication · Duplicated block (17 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt
  • Code Duplication · Duplicated block (17 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (16 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt
  • Code Duplication · Duplicated block (16 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt
  • Code Duplication · Duplicated block (15–16 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/UserSpaceScreen.kt
  • Code Duplication · Duplicated block (15 lines × 5) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt
  • Code Duplication · Duplicated block (15 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt
  • Code Duplication · Duplicated block (15 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt
  • Code Duplication · Duplicated block (14–15 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (14 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt
  • Code Duplication · Duplicated block (14 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt
  • Code Duplication · Duplicated block (14 lines × 3) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt
  • Code Duplication · Duplicated block (13–14 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt
  • Code Duplication · Duplicated block (14 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt
  • Code Duplication · Duplicated block (13–14 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt
  • Code Duplication · Duplicated block (13 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt
  • Code Duplication · Duplicated block (12 lines × 12) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt
  • Code Duplication · Duplicated block (12 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt
  • Code Duplication · Duplicated block (12 lines × 3) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Duplicated block (11–12 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt
  • Code Duplication · Duplicated block (11 lines × 6) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt
  • Code Duplication · Duplicated block (11 lines × 4) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt
  • Code Duplication · Duplicated block (10–11 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (11 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt
  • Code Duplication · Duplicated block (11 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (11 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/NetworkSetting.kt
  • Code Duplication · Duplicated block (11 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt
  • Code Duplication · Duplicated block (10 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchInput.kt
  • Code Duplication · Duplicated block (9–10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt
  • Code Duplication · Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt
  • Code Duplication · Duplicated block (10 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Duplicated block (10 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt
  • Code Duplication · Duplicated block (8–9 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt
  • Code Duplication · Duplicated block (8–9 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt
  • Code Duplication · Duplicated block (9 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt
  • Code Duplication · Duplicated block (9 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt
  • Code Duplication · Duplicated block (8 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt
  • Code Duplication · Duplicated block (7 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt
  • Code Duplication · Duplicated block (7 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt
  • Code Duplication · Duplicated block (7 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Duplicated block (6 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
  • Code Duplication · Duplicated block (5 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt
Rebuild cost: about €66,000 · Estimate
Cost to rebuild€22,000 to €110,000, for 363 to 1,151 hours of work, about 0.5 person-years for one engineer
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 48. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 69,335 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.
Raises the score by about 10 points · Low effort · ADR Quality
2
Record your significant design decisions.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Raises the score by about 7 points · Medium effort · Architecture documentation
3
Resolve the 280 Orphaned file finding(s) in Knowledge Freshness — start with SeekBar.kt (3), BvPlayer.kt (2), Comment.kt (2).
Raises the score by about 10 points · High effort · Knowledge Freshness

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €66,000 to build again, about 0.5 person-years of work. Its weakest lens is Maturity, at 37 (Weak). Maturity is about how well the project explains and looks after itself, which decides whether a new developer, or a new supplier, can take over. Because the weakest lens counts most in the score, work on Maturity also moves the score most.
Based on: the rebuild estimate · the Maturity grade · how much each lens counts
What to do: Start with the Maturity actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 10 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.1 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 4,353 lines over the last 90 days, which is about 17,654 lines a year. At that pace, the extra work comes to an estimated 1 to 6.2 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch :app :app :app:mobile :app:mobile :app->:app:mobile :app:tv :app:tv :app->:app:tv :app:shared :app:shared :app:mobile->:app:shared :app:tv->:app:shared :bili-api :bili-api :bili-api:grpc :bili-api:grpc :bili-api->:bili-api:grpc :bili-subtitle :bili-subtitle :player :player :player:core :player:core :player->:player:core :player:mobile :player:mobile :player->:player:mobile :player:shared :player:shared :player->:player:shared :player:tv :player:tv :player->:player:tv :player:core->:player:shared :player:mobile->:player:core :player:mobile->:player:shared :player:shared->:bili-api :player:shared->:bili-subtitle :symbols :symbols :player:shared->:symbols :utils :utils :player:shared->:utils :player:tv->:player:core :player:tv->:player:shared BV BV

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

492 modules, with 705 dependencies between them. 15 loops run through 51 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 452 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 com.origeek.imageViewer.previewer2 dev.aaa1115910.biliapi.entity3 dev.aaa1115910.biliapi.entity.season4 dev.aaa1115910.biliapi.entity.ugc5 dev.aaa1115910.biliapi.http.entity.region6 dev.aaa1115910.biliapi.http.entity.reply7 dev.aaa1115910.biliapi.http.entity.season.AppSeasonData8 dev.aaa1115910.biliapi.http.entity.user9 dev.aaa1115910.biliapi.http.entity.user.favorite10 dev.aaa1115910.bv.entity11 dev.aaa1115910.bv.entity.carddata12 dev.aaa1115910.bv.entity.db13 dev.aaa1115910.bv.entity.proxy14 dev.aaa1115910.bv.player15 dev.aaa1115910.biliapi.entity.reply16 dev.aaa1115910.biliapi.entity.user.DynamicItem17 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic.Major18 dev.aaa1115910.biliapi.http.entity.search19 dev.aaa1115910.biliapi.http.entity.season.WebSeasonData20 dev.aaa1115910.biliapi.http.entity.video21 dev.aaa1115910.biliapi.entity.user22 dev.aaa1115910.biliapi.entity.video.VideoDetail23 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic24 dev.aaa1115910.biliapi.http.entity.season25 dev.aaa1115910.biliapi.repositories.SearchTypeResult26 dev.aaa1115910.biliapi.entity.video.season27 dev.aaa1115910.biliapi.http28 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules29 dev.aaa1115910.biliapi.entity.pgc30 dev.aaa1115910.biliapi.entity.video31 dev.aaa1115910.biliapi.entity.pgc.index32 dev.aaa1115910.bv.player.entity33 dev.aaa1115910.biliapi.repositories34 dev.aaa1115910.bv.util35 dev.aaa1115910.bv.repository36 dev.aaa1115910.bv.viewmodel37 dev.aaa1115910.bv.viewmodel.home38 dev.aaa1115910.bv.mobile.screen39 dev.aaa1115910.bv.mobile.screen.home40 dev.aaa1115910.bv.tv.screens
1 com.origeek.imageViewer.previewer
2 dev.aaa1115910.biliapi.entity
3 dev.aaa1115910.biliapi.entity.season
4 dev.aaa1115910.biliapi.entity.ugc
5 dev.aaa1115910.biliapi.http.entity.region
6 dev.aaa1115910.biliapi.http.entity.reply
7 dev.aaa1115910.biliapi.http.entity.season.AppSeasonData
8 dev.aaa1115910.biliapi.http.entity.user
9 dev.aaa1115910.biliapi.http.entity.user.favorite
10 dev.aaa1115910.bv.entity
11 dev.aaa1115910.bv.entity.carddata
12 dev.aaa1115910.bv.entity.db
13 dev.aaa1115910.bv.entity.proxy
14 dev.aaa1115910.bv.player
15 dev.aaa1115910.biliapi.entity.reply1
16 dev.aaa1115910.biliapi.entity.user.DynamicItem11
17 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic.Major1
18 dev.aaa1115910.biliapi.http.entity.search1
19 dev.aaa1115910.biliapi.http.entity.season.WebSeasonData1
20 dev.aaa1115910.biliapi.http.entity.video5
21 dev.aaa1115910.biliapi.entity.user9
22 dev.aaa1115910.biliapi.entity.video.VideoDetail11
23 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic8
24 dev.aaa1115910.biliapi.http.entity.season2082
25 dev.aaa1115910.biliapi.repositories.SearchTypeResult11
26 dev.aaa1115910.biliapi.entity.video.season12
27 dev.aaa1115910.biliapi.http52104611451
28 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules24
29 dev.aaa1115910.biliapi.entity.pgc1
30 dev.aaa1115910.biliapi.entity.video231
31 dev.aaa1115910.biliapi.entity.pgc.index1
32 dev.aaa1115910.bv.player.entity12
33 dev.aaa1115910.biliapi.repositories17521109312414
34 dev.aaa1115910.bv.util125
35 dev.aaa1115910.bv.repository1111
36 dev.aaa1115910.bv.viewmodel2111131453
37 dev.aaa1115910.bv.viewmodel.home31
38 dev.aaa1115910.bv.mobile.screen33112621112
39 dev.aaa1115910.bv.mobile.screen.home1131313
40 dev.aaa1115910.bv.tv.screens1332243
Uses a module listed above itPart of a loopThe module itself
1 com.origeek.imageViewer.previewer2 dev.aaa1115910.biliapi.entity3 dev.aaa1115910.biliapi.entity.season4 dev.aaa1115910.biliapi.entity.ugc5 dev.aaa1115910.biliapi.http.entity.region6 dev.aaa1115910.biliapi.http.entity.reply7 dev.aaa1115910.biliapi.http.entity.season.AppSeasonData8 dev.aaa1115910.biliapi.http.entity.user9 dev.aaa1115910.biliapi.http.entity.user.favorite10 dev.aaa1115910.bv.entity11 dev.aaa1115910.bv.entity.carddata12 dev.aaa1115910.bv.entity.db13 dev.aaa1115910.bv.entity.proxy14 dev.aaa1115910.bv.player15 dev.aaa1115910.biliapi.entity.reply16 dev.aaa1115910.biliapi.entity.user.DynamicItem17 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic.Major18 dev.aaa1115910.biliapi.http.entity.search19 dev.aaa1115910.biliapi.http.entity.season.WebSeasonData20 dev.aaa1115910.biliapi.http.entity.video21 dev.aaa1115910.biliapi.entity.user22 dev.aaa1115910.biliapi.entity.video.VideoDetail23 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic24 dev.aaa1115910.biliapi.http.entity.season25 dev.aaa1115910.biliapi.repositories.SearchTypeResult26 dev.aaa1115910.biliapi.entity.video.season27 dev.aaa1115910.biliapi.http28 dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules29 dev.aaa1115910.biliapi.entity.pgc30 dev.aaa1115910.biliapi.entity.video31 dev.aaa1115910.biliapi.entity.pgc.index32 dev.aaa1115910.bv.player.entity33 dev.aaa1115910.biliapi.repositories34 dev.aaa1115910.bv.util35 dev.aaa1115910.bv.repository36 dev.aaa1115910.bv.viewmodel37 dev.aaa1115910.bv.viewmodel.home38 dev.aaa1115910.bv.mobile.screen39 dev.aaa1115910.bv.mobile.screen.home40 dev.aaa1115910.bv.tv.screenscom.origeek.imageViewer.previewer1dev.aaa1115910.biliapi.entity2dev.aaa1115910.biliapi.entity.season3dev.aaa1115910.biliapi.entity.ugc4dev.aaa1115910.biliapi.http.entity.region5dev.aaa1115910.biliapi.http.entity.reply6dev.aaa1115910.biliapi.http.entity.season.AppSeasonData7dev.aaa1115910.biliapi.http.entity.user8dev.aaa1115910.biliapi.http.entity.user.favorite9dev.aaa1115910.bv.entity10dev.aaa1115910.bv.entity.carddata11dev.aaa1115910.bv.entity.db12dev.aaa1115910.bv.entity.proxy13dev.aaa1115910.bv.player14dev.aaa1115910.biliapi.entity.reply15dev.aaa1115910.biliapi.entity.user.DynamicItem16dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic.Major17dev.aaa1115910.biliapi.http.entity.search18dev.aaa1115910.biliapi.http.entity.season.WebSeasonData19dev.aaa1115910.biliapi.http.entity.video20dev.aaa1115910.biliapi.entity.user21dev.aaa1115910.biliapi.entity.video.VideoDetail22dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules.Dynamic23dev.aaa1115910.biliapi.http.entity.season24dev.aaa1115910.biliapi.repositories.SearchTypeResult25dev.aaa1115910.biliapi.entity.video.season26dev.aaa1115910.biliapi.http27dev.aaa1115910.biliapi.http.entity.dynamic.DynamicItem.Modules28dev.aaa1115910.biliapi.entity.pgc29dev.aaa1115910.biliapi.entity.video30dev.aaa1115910.biliapi.entity.pgc.index31dev.aaa1115910.bv.player.entity32dev.aaa1115910.biliapi.repositories33dev.aaa1115910.bv.util34dev.aaa1115910.bv.repository35dev.aaa1115910.bv.viewmodel36dev.aaa1115910.bv.viewmodel.home37dev.aaa1115910.bv.mobile.screen38dev.aaa1115910.bv.mobile.screen.home39dev.aaa1115910.bv.tv.screens401111115911820821112521046114512412311121752110931241412511112111131453313311262111211313131332243+452 more modules (most-connected shown)

At a glance — Code Health · 88% · Exemplary ·

At a glance — Architecture · 85% · Adequate · gated by D26 ·

At a glance — Maturity · 37% · Weak · gated by D34, M2 ·

At a glance — Readiness · 38% · Weak · gated by P3, P7 ·

At a glance — Security · 60% · Adequate · gated by D29, D36 ·

At a glance — Performance · 100% · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection53High / Critical
A03:2025 — Software Supply Chain Failures10Medium

Roadmap

Top priorities: Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts; Resolve the 280 Orphaned file finding(s) in Knowledge Freshness — start with SeekBar.kt (3), BvPlayer.kt (2), Comment.kt (2); Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts.+9.8 ptsLowADR Quality
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+6.8 ptsMediumArchitecture documentation
Resolve the 280 Orphaned file finding(s) in Knowledge Freshness — start with SeekBar.kt (3), BvPlayer.kt (2), Comment.kt (2).+9.7 ptsHighKnowledge Freshness
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+4.5 ptsMediumSecurity & performance tooling
Expand the README with getting-started, architecture overview and a project map.+3.6 ptsMediumDocumentation (README)
Resolve the 3 `dedeUserID` spells `ID` where 233 names in the project spell it `Id` finding(s) in Naming Consistency — start with BiliHttpApi.kt (2), BiliHttpProxyApi.kt.+1.7 ptsLowNaming Consistency
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).+2.3 ptsMediumOutbound HTTP resilience
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED (2).+0.9 ptsLowStatic Analysis (SAST)

File quality

Per-file score 0–10 — a quality signature. Of 135 files carrying findings, judged against the Preview bar: 4% slop · 15% mixed · 81% near-clean.

FileScoreBandWorst signal
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt4.0MixedChange Coupling: Boundary-crossing change coupling: VideoPlayerActivity.kt ↔ BvPlayer.kt
app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt4.0MixedChange Coupling: Boundary-crossing change coupling: VideoPlayerScreen.kt ↔ BvPlayer.kt
player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt4.8MixedCode Duplication: Near-duplicate member pair (118 shared lines)
app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt5.4MixedChange Coupling: Boundary-crossing change coupling: HistoryViewModel.kt ↔ UserInfoScreen.kt
app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt5.7MixedCode Duplication: Members sharing a duplicated core (4 members, 50+ identical tokens)
REDACTED5.9MixedStatic Analysis (SAST): Medium: REDACTED
player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt6.0MixedExplicit Debt: TodoComment
player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt6.0MixedExplicit Debt: TodoComment
bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt6.0MixedExplicit Debt: TodoComment
bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt6.0MixedExplicit Debt: TodoComment
app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt6.0MixedExplicit Debt: TodoComment
app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt6.0MixedExplicit Debt: TodoComment
bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt6.0MixedExplicit Debt: TodoComment
app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt6.0MixedExplicit Debt: TodoComment
bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt6.3MixedGod Classes: TooManyMethods: BiliHttpApi

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 47

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 394

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 306

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 14

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 45 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 45 dimensions across the health lenses
D1D2D3D4D5D6D13D14D15D17D20D21D26D28D29D34D35D36D44AX10AX3AX4M1M2M3P1P2P3P4P6P7PF3X1X12X13X16X2X21X23X25X27X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 732 of 747 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1da2b-5624-7045-a073-6abcc559d0c5.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — a Gradle build resolved 521 artifact(s) across its subprojects (213 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (9 contributor(s) across 894 commit(s) sampled, automation and bot accounts excluded). One of them holds 98% of the history; the other 8 hold 0.2% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D19 Documentation Quality — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: it declares a published package (utils/build.gradle.kts), but no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/PreviewerTransformState.kt`, `app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt`, `bili-api/src/main/kotlin/com/tfowl/ktor/client/plugins/JsoupPlugin.kt`, `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/danmaku/DanmakuMask.kt` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX1 Captive dependencies — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Koin, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AX6 Interface segregation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over the public interfaces this run's compilations declare, and none was loaded, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (app). the Android app did not build — `./gradlew :app:assembleDebug` exited 1: tlin.platform.type' with value 'androidJvm' but: - No variants exist. * Try: > Creating consumable variants is explained in more detail at https://docs.gradle.org/8.14.3/userguide/declaring…; runtime evidence skipped (launch chosen because app/build.gradle.kts applies the Android application plugin and gradlew builds it).
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Kotlin is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and no C#, JavaScript/TypeScript, Java, Dart, Ruby or Scala was found, and this repository's Kotlin is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, Scala, Ruby and Python source only, and no C# was loaded and no JavaScript/TypeScript, Java, Scala, Ruby or Python was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.7 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.7 / 10 · rule-coverage 100% · ceiling Prevented

27 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was VideoPlayerControllerKt.VideoPlayerController at 54. A further 6 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being UgcTypeV2ExtendsKt.getDisplayName at 237 — they are counted neither in the figure above nor in this dimension's score. 6 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: app/shared/src/main/kotlin/dev/aaa1115910/bv/util/UgcTypeV2Extends.kt (UgcTypeV2ExtendsKt.getDisplayName at 237), app/shared/src/main/kotlin/dev/aaa1115910/bv/util/UgcTypeExtends.kt (UgcTypeExtendsKt.getDisplayName at 126), app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/UgcContent.kt (UgcContentKt.UgcContent at 95), app/shared/src/main/kotlin/dev/aaa1115910/bv/component/settings/UpdateDialog.kt (UpdateDialogKt.UpdateDialogContent at 34), bili-api/src/main/kotlin/dev/aaa1115910/biliapi/websocket/LiveDataWebSocket.kt (LiveDataWebSocket.handleLiveCMDEventString at 31), and 1 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

VideoPlayerControllerKt.VideoPlayerController (cyclomatic 54)player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:55
ImageViewerKt.ImageViewer (cyclomatic 40)app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:324
ImageComposeCanvasKt.ImageComposeCanvas (cyclomatic 37)app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:276
VideoInfoScreenKt.VideoInfoScreen (cyclomatic 33)app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158
BvPlayerKt.BvPlayer (cyclomatic 33)player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:80

+ 22 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 27 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with VideoPlayerControllerKt.VideoPlayerController (cyclomatic 54), ImageViewerKt.ImageViewer (cyclomatic 40), ImageComposeCanvasKt.ImageComposeCanvas (cyclomatic 37). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 27 together lifts Cyclomatic Complexity from 6.7 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.2 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Prevented

34 method(s) exceeded the cognitive complexity threshold of 15; the worst was VideoPlayerControllerKt.VideoPlayerController at 80.

VideoPlayerControllerKt.VideoPlayerController (cognitive 80)player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:55
VideoInfoScreenKt.VideoInfoScreen (cognitive 69)app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158
ImageComposeCanvasKt.ImageComposeCanvas (cognitive 58)app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:276
ImageViewerKt.ImageViewer (cognitive 51)app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:324
SeasonInfoScreenKt.SeasonInfoScreen (cognitive 42)app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:123

+ 29 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 60 down to 60 or less in Cognitive Complexity — start with VideoPlayerControllerKt.VideoPlayerController (cognitive 80), VideoInfoScreenKt.VideoInfoScreen (cognitive 69). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 6.2 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes7.5 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.5 / 10 · rule-coverage 100% · ceiling Prevented

46 god class(es) detected.

MethodTooLong: VideoInfoScreenKt.VideoInfoScreen · ×30app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158
FileTooLong: http/BiliHttpApi.kt · ×13bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt
ClassTooLong: VideoPlayerV3ViewModel · ×2app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt:61
TooManyMethods: BiliHttpApibili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:105

What to do

  1. Resolve the 30 MethodTooLong finding(s) in God Classes — start with VideoInfoScreen.kt (2), SeasonInfoScreen.kt (2), VideoPlayerScreen.kt. — One of this dimension's main actionable groups (30 warning-level).
  2. Resolve the 13 FileTooLong finding(s) in God Classes — start with BiliHttpApi.kt, VideoInfoScreen.kt, SeasonInfoScreen.kt. — One of this dimension's main actionable groups (13 warning-level).
  3. Resolve the 2 ClassTooLong finding(s) in God Classes — start with VideoPlayerV3ViewModel.kt, Dynamic.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication5.3 / 10Adequate✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.3 / 10 · rule-coverage 100% · ceiling Verified

136 duplicated block group(s) detected. 11.7 % of the production lines (8,084 of 69,335) are in a reported copy. A further 81 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (10 lines × 2) · ×9app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchInput.kt:68
Edited copy of a member (22 corresponding lines) · ×7bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:583
Duplicated block (17 lines × 2) · ×7app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:306
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×6app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:350
Duplicated block (15 lines × 2) · ×6app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:436

+ 118 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 9 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with UnlockSwitchUserContent.kt (2), SearchInput.kt, UgcViewModel.kt. — One of this dimension's main actionable groups (9 warning-level).
  2. Resolve the 7 Edited copy of a member (22 corresponding lines) finding(s) in Code Duplication — start with BiliHttpApi.kt, UgcViewModel.kt, Tips.kt. — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 7 Duplicated block (17 lines × 2) finding(s) in Code Duplication — start with ImageComposeCanvas.kt, UserDialog.kt, HistoryViewModel.kt. — One of this dimension's main actionable groups (7 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling8.9 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Prevented

15 production modules (Gradle), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 3 module(s) off the main sequence, with abstractness counted on 11 of the 15 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: :bili-subtitle · ×2
Off the main sequence: :app:shared

What to do

  1. Resolve the 2 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 46 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 42 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 19 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 3 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph. A further 43 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt9.9 / 10Stronggated by 37 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

37 deducted task-comment markers across 69335 LoC (0.1/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×37player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:317

What to do

  1. Resolve the 37 TodoComment finding(s) in Explicit Debt — start with BvPlayerPreview.kt (9), DynamicItem.kt (5), VideoPlayerPages.kt (4). — One of this dimension's main actionable groups (37 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundapp/build.gradle.kts:9

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.kts. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency8.5 / 10Strong✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Verified

4 naming inconsistencies among 268 declarations measured against a convention their peers follow.

`dedeUserID` spells `ID` where 233 names in the project spell it `Id` · ×3bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:193
`NewEP` spells `EP` where 31 names in the project spell it `Ep`bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/season/WebSeasonData.kt:441

What to do

  1. Resolve the 3 `dedeUserID` spells `ID` where 233 names in the project spell it `Id` finding(s) in Naming Consistency — start with BiliHttpApi.kt (2), BiliHttpProxyApi.kt. — One of this dimension's main actionable groups (3 recommendation-level).
  2. Resolve the 1 `NewEP` spells `EP` where 31 names in the project spell it `Ep` finding(s) in Naming Consistency — start with WebSeasonData.kt. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion3.3 / 10Weak✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 3.3 / 10 · rule-coverage 100% · ceiling Documented

4 of 12 build units (Gradle) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)1.4 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 1.4 / 10 · rule-coverage 100% · ceiling Documented

53 finding(s): 0 critical, 42 high, 11 medium, 0 low. 34 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 1 file(s) — `gradlew` (line 177) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 4 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. No action in Static Analysis (SAST) — all 34 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (34 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

283 of 283 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt. Counted over 283 of the 596 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×280bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1
Most significant orphaned file · ×3app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1
Dormant codebase

What to do

  1. Resolve the 280 Orphaned file finding(s) in Knowledge Freshness — start with SeekBar.kt (3), BvPlayer.kt (2), Comment.kt (2). — One of this dimension's main actionable groups (280 recommendation-level).
  2. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with VideoInfoScreen.kt, SeasonInfoScreen.kt, VideoPlayerScreen.kt. — One of this dimension's main actionable groups (3 recommendation-level).
  3. Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.6 / 10Adequategated by 5 critical findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: ClosedCaptionMenu.kt↔PictureMenu.kt 90%; BvPlayer.kt↔BvPlayerController.kt 80%; ClosedCaptionMenu.kt↔DanmakuMenu.kt 80%

Boundary-crossing change coupling: VideoPlayerScreen.kt ↔ BvPlayer.kt · ×5app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:1
Change coupling: BvPlayer.kt ↔ BvPlayerController.kt · ×5player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:1
Change coupling clique: MenuController.kt, ClosedCaptionMenu.kt, DanmakuMenu.kt, PictureMenu.ktplayer/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt

What to do

  1. Resolve the 5 Boundary-crossing change coupling finding(s) in Change Coupling — start with VideoPlayerScreen.kt (2), HistoryViewModel.kt, VideoPlayerActivity.kt. — One of this dimension's main actionable groups (5 issue-level).
  2. Resolve the 5 Change coupling finding(s) in Change Coupling — start with BvPlayer.kt (2), BvPlayerController.kt, VideosRow.kt. — One of this dimension's main actionable groups (5 warning-level).
  3. Resolve the 1 Change coupling clique finding(s) in Change Coupling — start with MenuController.kt. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 11 platform declaration(s) and 86 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition8.0 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

M1 · Documentation (README)4.0 / 10Weak✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

  • The root README is 83 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers. — README.md:1

What to do

  • Expand the README with getting-started, architecture overview and a project map.
  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

P1 · CI/CD gates8.5 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`./gradlew test` for the toolchain this pipeline already uses) and gate merges on it.
P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Add a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) so orchestrators and load balancers can probe liveness/readiness.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 6 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×7) — app/shared/src/main/kotlin/dev/aaa1115910/bv/network/GithubApi.kt:48, app/shared/src/main/kotlin/dev/aaa1115910/bv/network/VlcLibsApi.kt:34, app/shared/src/main/kotlin/dev/aaa1115910/bv/util/BlacklistUtil.kt:22, …

What to do

  • Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated5.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

  • `ticketMap` is walked by the loop on line 34, and line 36 calls `ticketMap.remove` on `ticketMap` inside the loop body — a structural change to a `LinkedHashMap`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen. — app/mobile/src/main/kotlin/com/origeek/imageViewer/util/Ticket.kt:34

What to do

  • Each finding names the two lines that cannot both stand — the loop over the collection, and the call inside its body that changes it. Confirm from those two, then pick one: change the collection in one call instead of in the loop (`list.removeAll { … }`, `list.retainAll { … }`, `map.entries.removeIf { … }`); walk a snapshot (`for (x in list.toList())`, `list.toList().forEach { … }`); build a new collection (`val kept = list.filter { … }`) instead of editing the one being walked; or — where only the first match was ever meant — leave the walk straight after the change (`break`, `return`), which is the one shape that is already safe.
X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

X5 · Nullable reference types9.4 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health88%ExemplarySolid.
Architecture85%Adequate — gated by D26Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity37%Weak — gated by D34, M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness38%Weak — gated by P3, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security60%Adequate — gated by D29, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100%ExemplaryStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 4 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 68 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Android app did not build — `./gradlew :app:assembleDebug` exited 1: tlin.platform.type' with value 'androidJvm' but: - No variants exist. * Try: > Creating consumable variants is explained in more detail at https://docs.gradle.org/8.14.3/userguide/declaring…; runtime evidence skipped (launch chosen because app/build.gradle.kts applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~2675 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D12 Dependency Hygiene — Not scored — a Gradle build resolved 521 artifact(s) across its subprojects (213 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D19 Documentation Quality — D19 reads .NET projects and npm packages as units; 16 folder(s) declared by build.gradle.kts were not judged for an overview, an example or the map.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 4 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 587 value object(s); 1 repository port(s) loading or saving an aggregate/entity
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X18 Disposal-pattern correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 47 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 9 more in this group — see findings.md.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D35 · Change Coupling · Boundary-crossing change coupling · ×5
  • Boundary-crossing change coupling: VideoPlayerScreen.kt ↔ BvPlayer.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:1 — `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt` (context mobile) and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` (context player) sit in DIFFERENT parts of the tree yet change together 73% of the time (11 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `8db5ca51` 新增播放模式选项; `ff04d2b7` 完善播放器; `8eae9a09` 完善播放器 — run `git show` on any of them.
  • Boundary-crossing change coupling: HistoryViewModel.kt ↔ UserInfoScreen.kt app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:1 — `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` (context shared) and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt` (context tv) sit in DIFFERENT parts of the tree yet change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `f732427b` 优化视频时长显示,时长>=1小时时,显示小时 (#227); `b1f35b98` 改造历史记录接口 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/user/UserInfoScreen.kt`); `f0a51843` 新增搜索结果页 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/user/UserInfoScreen.kt`) — run `git show` on any of them.
  • Boundary-crossing change coupling: VideoPlayerScreen.kt ↔ FullscreenControllers.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:1 — `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt` (context mobile) and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt` (context player) sit in DIFFERENT parts of the tree yet change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `ff04d2b7` 完善播放器; `8eae9a09` 完善播放器; `fc660d26` 支持视频分p/合集 (at that commit the file was still `app/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt`) — run `git show` on any of them.
  • Boundary-crossing change coupling: VideoPlayerActivity.kt ↔ BvPlayer.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:1 — `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt` (context mobile) and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` (context player) sit in DIFFERENT parts of the tree yet change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `bca5ec87` 复用 VideoPlayerV3ViewModel (at that commit the file was still `app/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt`); `1f99772a` 复用 tv 版的播放器代码 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt` and `bv-player-mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/component/BvPlayer.kt`); `e884ca0b` 支持显示弹幕 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt` and `bv-player-mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/component/BvPlayer.kt`) — run `git show` on any of them.
  • Boundary-crossing change coupling: VideoPlayerV3Screen.kt ↔ VideoPlayerController.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoPlayerV3Screen.kt:1 — `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoPlayerV3Screen.kt` (context tv) and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt` (context player) sit in DIFFERENT parts of the tree yet change together 52% of the time (13 of the 25 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `8db5ca51` 新增播放模式选项; `ff04d2b7` 完善播放器; `fc660d26` 支持视频分p/合集 (at that commit the file was still `app/src/main/kotlin/dev/aaa1115910/bv/screen/VideoPlayerV3Screen.kt`) — run `git show` on any of them.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
Serious — 394 finding(s)
D17 · Explicit Debt · TodoComment · ×37
  • TodoComment player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:317 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:29 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:34 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:39 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:44 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:49 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:54 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:59 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:63 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/component/BvPlayerPreview.kt:67 — //TODO("Not yet implemented") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt:184 — // TODO 使用颜文字显示影片价格 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/SkipTip.kt:23 — // TODO 跳转历史记录 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/SkipTip.kt:37 — // TODO 跳过片头 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/SkipTip.kt:50 — // TODO 跳过片尾 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:105 — //TODO 临时解决方案,应该根据手机垂直方向来屏幕宽度 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/SearchRepository.kt:99 — //TODO 返回的关键词提示中可能包含通过avid/bvid/专栏id等的直达跳转结果项,需要过滤掉或进行单独处理 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:109 — //TODO 改成返回 关注数,粉丝数,黑名单数 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/video/PlayUrlResponse.kt:282 — //TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/video/VideoDetail.kt:17 — //TODO 评论 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/search/SearchResult.kt:107 — // TODO live search result — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/live/LiveFrame.kt:98 — //TODO do some verity — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/Subtitle.kt:3 — //TODO 将 lanDoc 内括号的内容分离出来,将其作为 Badge 显示 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:5 — //TODO 暂时仅解析 UGC 和 PGC — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:5 — //TODO 暂时仅解析 UGC 和 PGC — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/UserSpaceViewModel.kt:61 — //TODO 这里在改造 app 端接口时,没找到在空间内显示为合集样式封面的UP,没法进一步测试接口 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 12 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×30
  • MethodTooLong: VideoInfoScreenKt.VideoInfoScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158 — MethodTooLong — VideoInfoScreen runs 418 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 318 over it, 4.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VideoPlayerScreenKt.VideoPlayerScreen app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:129 — MethodTooLong — VideoPlayerScreen runs 416 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 316 over it, 4.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VideoPlayerControllerKt.VideoPlayerController player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:55 — MethodTooLong — VideoPlayerController runs 231 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 131 over it, 2.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SeasonInfoScreenKt.SeasonInfoScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:123 — MethodTooLong — SeasonInfoScreen runs 225 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 125 over it, 2.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UgcContentKt.UgcContent app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/UgcContent.kt:97 — MethodTooLong — UgcContent runs 198 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 98 over it, 1.98× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UserInfoScreenKt.UserInfoScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:103 — MethodTooLong — UserInfoScreen runs 195 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 95 over it, 1.95× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BvPlayerControllerKt.BvPlayerControllerVideoContent player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:280 — MethodTooLong — BvPlayerControllerVideoContent runs 181 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 81 over it, 1.81× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UserDialogKt.UserDialogContent app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:126 — MethodTooLong — UserDialogContent runs 154 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 54 over it, 1.54× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchResultScreenKt.SearchResultScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultScreen.kt:70 — MethodTooLong — SearchResultScreen runs 152 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 52 over it, 1.52× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: RemoteControlPanelDemoKt.RemoteControlPanelInfo app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:40 — MethodTooLong — RemoteControlPanelInfo runs 147 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 47 over it, 1.47× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MobileMainScreenKt.MobileMainScreen app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/MobileMainScreen.kt:110 — MethodTooLong — MobileMainScreen runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PgcIndexScreenKt.PgcIndexScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:52 — MethodTooLong — PgcIndexScreen runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VideoPlayerV3ScreenKt.VideoPlayerV3Screen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoPlayerV3Screen.kt:39 — MethodTooLong — VideoPlayerV3Screen runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReplySheetScaffoldKt.ReplySheetScaffold app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/ReplySheetScaffold.kt:53 — MethodTooLong — ReplySheetScaffold runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchResultFilterKt.SearchResultVideoFilter app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:41 — MethodTooLong — SearchResultVideoFilter runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DynamicDetailScreenKt.DynamicDetailMobileContent app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:155 — MethodTooLong — DynamicDetailMobileContent runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DanmakuMenuKt.DanmakuMenuList player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:42 — MethodTooLong — DanmakuMenuList runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FollowingSeasonScreenKt.FollowingSeasonScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt:50 — MethodTooLong — FollowingSeasonScreen runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SmsLoginContentKt.SmsLoginContent app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt:47 — MethodTooLong — SmsLoginContent runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UnlockUserScreenKt.UnlockUserContent app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:80 — MethodTooLong — UnlockUserContent runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MainScreenKt.MainScreen app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/MainScreen.kt:60 — MethodTooLong — MainScreen runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: IndexFilterKt.IndexFilter app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/pgc/IndexFilter.kt:67 — MethodTooLong — IndexFilter runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SeasonInfoScreenKt.SeasonSelectorContent app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:943 — MethodTooLong — SeasonSelectorContent runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VideoPlayerPagesKt.VideoPlayerPartSheetContent app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:404 — MethodTooLong — VideoPlayerPartSheetContent runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VideoInfoScreenKt.VideoInfoData app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:776 — MethodTooLong — VideoInfoData runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • + 5 more in this group — see findings.md.
D3 · God Classes · FileTooLong · ×13
  • FileTooLong: http/BiliHttpApi.kt bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt — FileTooLong — 1311 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 811 over it, 2.62× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screens/VideoInfoScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt — FileTooLong — 1220 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 720 over it, 2.44× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screens/SeasonInfoScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt — FileTooLong — 912 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 412 over it, 1.82× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: dynamic/DynamicItem.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt — FileTooLong — 732 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 232 over it, 1.46× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/VideoPlayerScreen.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt — FileTooLong — 707 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 207 over it, 1.41× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: user/Dynamic.kt bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt — FileTooLong — 679 significant lines (blank, comment-only and punctuation-only lines excluded), about 65% of them inside a single declaration: DynamicItem (93-697). The bar is 500 significant lines; this is 179 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: user/UserInfoScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt — FileTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 165 over it, 1.33× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: player/VideoPlayerPages.kt app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt — FileTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 82 over it, 1.16× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: user/UserSwitchScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt — FileTooLong — 567 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 67 over it, 1.13× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: controller/BvPlayerController.kt player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt — FileTooLong — 552 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 52 over it, 1.10× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: viewer/ImageViewer.kt app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt — FileTooLong — 544 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 44 over it, 1.09× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: viewmodel/VideoPlayerV3ViewModel.kt app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt — FileTooLong — 519 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: VideoPlayerV3ViewModel (61-697). The bar is 500 significant lines; this is 19 over it, 1.04× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: m3qrcode/MaterialShapeQrState.kt app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt — FileTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), about 74% of them inside a single declaration: MaterialShapeQrState (38-570). The bar is 500 significant lines; this is 8 over it, 1.02× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×9
  • Duplicated block (10 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchInput.kt:68 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchInput.kt:68-77 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt:178-187 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchInput.kt:68` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:90 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:90-99 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:238-247 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:90` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:42 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:42-51 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:43-52 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:42` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:139 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:139-148 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt:156-165 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:139` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:86 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:86-95 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:137-146 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:134` calls `when` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:85` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:130 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:130-139 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:188-197 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:130` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:187` calls `focusRequester` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:129` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:584 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:584-593 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:623-632 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:584` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:318 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:318-327 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:343-352 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:318` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:298 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:298-307 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:326-335 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:298` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×7
  • Edited copy of a member (22 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:583 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:583-605 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:622-643 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:54 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:54-75 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:202-223 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:48 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:48-74 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:95-116 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:319 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:319-340 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:345-366 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt:191 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt:191-212 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt:216-237 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/ListItemPreference.kt:98 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/ListItemPreference.kt:98-119 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/TextPreference.kt:92-115 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt:30 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt:30-51 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliPassportHttpApi.kt:38-61 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×7
  • Duplicated block (17 lines × 2) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:306 — app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:306-322 | app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeOrigin.kt:82-98 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (17 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:369 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:369-385 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:393-409 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:369` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:411` calls `OptIn` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:387` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (17 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:84 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:84-100 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:84-100 — before extracting anything, compare `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:84` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:96 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:96-112 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:749-765 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:96` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:36 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:36-52 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:59-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:36` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:181 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:181-197 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:251-267 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:181` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:262 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:262-278 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:312-328 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:262` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×7
  • Outbound HTTP without resilience app/shared/src/main/kotlin/dev/aaa1115910/bv/network/GithubApi.kt:48 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience app/shared/src/main/kotlin/dev/aaa1115910/bv/network/VlcLibsApi.kt:34 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience app/shared/src/main/kotlin/dev/aaa1115910/bv/util/BlacklistUtil.kt:22 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt:551 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt:31 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliPassportHttpApi.kt:39 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience bili-api/src/main/kotlin/dev/aaa1115910/biliapi/websocket/LiveDataWebSocket.kt:57 — `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×6
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:350 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:350-385 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:389-409 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:414-450 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:455-493 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:56 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:56-166 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:52-168 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/ReplySheetScaffold.kt:63-228 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:827-910 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/UserViewModel.kt:36 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/UserViewModel.kt:36-72 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/home/DynamicViewModel.kt:64-106 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:50-100 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:50-100 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:80 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:80-102 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:104-122 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:124-139 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:141-169 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:46 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:46-113 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:810-904 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:986-1029 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:702-765 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:107 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:107-113 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:850-859 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/SearchRepository.kt:401-407 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/util/Extends.kt:3-9 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×6
  • Duplicated block (15 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:436 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:436-450 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:479-493 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:436` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:111 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:111-125 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:419-433 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:55 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:55-69 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:203-217 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (15 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:681 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:681-695 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:778-792 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:681` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:164 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:164-178 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UserLockSettingsScreen.kt:188-202 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:164` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UserLockSettingsScreen.kt:205` calls `stringResource` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:181` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:411 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:411-425 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:449-463 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:411` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D35 · Change Coupling · Change coupling · ×5
  • Change coupling: BvPlayer.kt ↔ BvPlayerController.kt player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:1 — `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt` change together 80% of the time (12 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `8db5ca51` 新增播放模式选项; `fe28272f` 更新播放器样式; `ff04d2b7` 完善播放器 — run `git show` on any of them.
  • Change coupling: BvPlayer.kt ↔ FullscreenControllers.kt player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:1 — `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt` change together 77% of the time (10 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `fe28272f` 更新播放器样式; `ff04d2b7` 完善播放器; `8eae9a09` 完善播放器 — run `git show` on any of them.
  • Change coupling: BvPlayerController.kt ↔ FullscreenControllers.kt player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:1 — `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt` and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt` change together 77% of the time (10 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `fe28272f` 更新播放器样式; `ff04d2b7` 完善播放器; `8eae9a09` 完善播放器 — run `git show` on any of them.
  • Change coupling: VideosRow.kt ↔ VideoInfoScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:1 — `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `3051835c` 将 createCustomInitialFocusRestorerModifiers 替换为 Modifier.focusRequester (at that commit the file was still `app/shared/src/main/kotlin/dev/aaa1115910/bv/component/videocard/VideosRow.kt`); `c149716d` 支持通过代理服务器获取播放地址 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/component/videocard/VideosRow.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/VideoInfoScreen.kt`); `ff8d847a` 更改加载推荐视频的来源 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/component/videocard/VideosRow.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/VideoInfoScreen.kt`) — run `git show` on any of them.
  • Change coupling: SearchInputScreen.kt ↔ SearchResultScreen.kt app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:1 — `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultScreen.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f29cde40` 支持使用代理进行搜索 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchInputScreen.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchResultScreen.kt`); `e39ba714` 改造搜索接口 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchInputScreen.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchResultScreen.kt`); `c6a6c000` 优化搜索 (at that commit the files were still `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchInputScreen.kt` and `app/src/main/kotlin/dev/aaa1115910/bv/screen/search/SearchResultScreen.kt`) — run `git show` on any of them.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×5
  • Edited copy of a member (18 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:75 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:75-94 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/VideoPlayerV3Activity.kt:93-110 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:108 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:108-127 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/FavoriteRepository.kt:134-151 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/search/SearchInputViewModel.kt:43 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/search/SearchInputViewModel.kt:43-60 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/search/SearchInputViewModel.kt:62-80 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/network/VlcLibsApi.kt:33 — app/shared/src/main/kotlin/dev/aaa1115910/bv/network/VlcLibsApi.kt:33-54 | app/shared/src/main/kotlin/dev/aaa1115910/bv/network/GithubApi.kt:47-64 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:143 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:143-160 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:159-176 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×5
  • Duplicated block (22 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:56 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:56-77 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:56-77 — before extracting anything, compare `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:56` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (22 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:41 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:41-62 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:41-62 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:140 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:140-161 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UserLockSettingsScreen.kt:220-241 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:140` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:30 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:30-51 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:92-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:30` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (22 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt:30 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt:30-51 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/RadioMenuList.kt:30-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×5
  • Duplicated block (14 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:122 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:122-135 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt:114-127 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:122` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (14 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt:226 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt:226-239 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt:250-263 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/search/SearchResult.kt:226` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332-345 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:391-404 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:97 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:97-110 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:110-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:97` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:85 — app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:85-98 | utils/src/main/kotlin/dev/aaa1115910/bv/util/LongExtends.kt:6-19 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×5
  • Duplicated block (13 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:108 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:108-120 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt:100-112 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:108` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:454 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:454-466 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1064-1076 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1064` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:78 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:78-90 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:117-129 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:78` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt:215 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt:215-227 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockSwitchUserContent.kt:111-123 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt:215` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt:123 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt:123-135 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt:169-181 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×4
  • Duplicated block (18 lines × 2) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:140 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:140-157 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:183-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: `Canvas` names `android.graphics.Canvas` in one and `androidx.compose.foundation.Canvas` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:779 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:779-796 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:878-895 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:779` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:57 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:57-74 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:58-75 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:57` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (18 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:184 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:184-201 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:416-433 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:184` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:183` calls `fillMaxSize` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:415` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×4
  • Duplicated block (16 lines × 2) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:341 — app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:341-357 | app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeOrigin.kt:115-130 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:341` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `bSize` to `key1 =` in one and `key2 =` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (16 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:367 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:367-382 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:567-582 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (16 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:320 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:320-335 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:346-361 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:320` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:100 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:100-115 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:130-145 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:100` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×4
  • Duplicated block (11 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:440 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:440-450 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt:199-209 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:440` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `MaterialTheme` names `androidx.compose.material3.MaterialTheme` in one and `androidx.tv.material3.MaterialTheme` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:103 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:103-113 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:214-224 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:103` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/NetworkSetting.kt:68 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/NetworkSetting.kt:68-79 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/OtherSetting.kt:49-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/NetworkSetting.kt:68` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (11 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:65 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:65-75 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:67-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `item` to `bilibili.app.interfaces.v1.CursorItem) = HistoryItem( oid = item.oid` in one and `bilibili.app.interfaces.v1.CursorItem) = ToViewItem( oid = item.oid` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×3
  • Edited copy of a member (21 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:675 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:675-695 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:772-792 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:150 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:150-170 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:176-196 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:126 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:126-149 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliPlusHttpApi.kt:37-57 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×3
  • Edited copy of a member (11 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:696 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:696-706 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:748-758 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:427 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:427-437 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:444-455 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:77 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:77-87 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:225-235 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×3
  • Edited copy of a member (13 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt:143 — app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt:143-155 | app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt:158-170 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) player/core/src/main/kotlin/dev/aaa1115910/bv/player/impl/exo/ExoMediaPlayer.kt:71 — player/core/src/main/kotlin/dev/aaa1115910/bv/player/impl/exo/ExoMediaPlayer.kt:71-83 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/Media3VideoPlayer.kt:42-54 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt:38 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt:38-55 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/TextPreference.kt:30-42 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×3
  • Duplicated block (21 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:465 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:465-485 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:232-252 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:465` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1157 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1157-1177 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1178-1198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (21 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:221 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:221-241 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:290-310 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:221` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:311` calls `sendHeartbeat` and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:244` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×3
  • Duplicated block (20 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:576 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:576-595 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:340-359 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:576` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:703 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:703-722 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:781-800 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1413 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1413-1432 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1528-1547 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1413` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×3
  • Duplicated block (14 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:157 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:157-170 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:195-208 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:248-261 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:531 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:531-544 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:563-576 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:593-606 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:531` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 3) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:128 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:128-141 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:163-176 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:190-203 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:146` calls `updateEnabledDanmakuTypeFilter` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:177` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×3
  • Duplicated block (8 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:62 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:62-69 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:167-174 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1186 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1186-1193 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1258-1265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/UserSpaceActivity.kt:13 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/UserSpaceActivity.kt:13-20 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/UpInfoActivity.kt:13-20 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D3 · God Classes · ClassTooLong · ×2
  • ClassTooLong: VideoPlayerV3ViewModel app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt:61 — ClassTooLong — 461 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 61 over it, 1.15× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DynamicItem bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:93 — ClassTooLong — 441 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 41 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (5 members, 50+ identical tokens) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:50 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:50-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/GuoChuangContent.kt:50-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/MovieContent.kt:50-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/TvContent.kt:50-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/VarietyContent.kt:50-77 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:43 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:43-96 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DashMenu.kt:52-89 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/MoreMenu.kt:38-74 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/SpeedMenu.kt:37-82 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt:50-105 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (35 corresponding lines) · ×2
  • Edited copy of a member (35 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/LoginRepository.kt:33 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/LoginRepository.kt:33-67 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/LoginRepository.kt:89-126 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (35 corresponding lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt:29 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/CheckBoxMenuList.kt:29-65 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/RadioMenuList.kt:29-63 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×2
  • Edited copy of a member (20 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt:49 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt:49-68 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt:70-90 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:210 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:210-229 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DashMenu.kt:205-224 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×2
  • Edited copy of a member (31 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:209 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:209-239 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:246-276 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (31 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:144 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:144-174 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/SettingsScreen.kt:126-161 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×2
  • Edited copy of a member (26 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:139 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:139-173 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQr.kt:182-207 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SmallVideoCard.kt:185 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SmallVideoCard.kt:185-210 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SmallVideoCard.kt:371-398 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×2
  • Edited copy of a member (27 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:242 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:242-268 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:276-302 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (27 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:354 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:354-382 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:388-414 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×2
  • Edited copy of a member (19 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:35 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:35-53 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/VideoPlayerV3Activity.kt:41-62 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/ImageTransform.kt:101 — app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/ImageTransform.kt:101-119 | app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/ImageTransform.kt:128-148 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×2
  • Edited copy of a member (16 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:672 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:672-687 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:723-739 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:89 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/ugc/UgcViewModel.kt:89-104 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:237-252 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×2
  • Edited copy of a member (23 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:79 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:79-107 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:113-135 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/QrTokenResultScreen.kt:247 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/QrTokenResultScreen.kt:247-269 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/QrTokenResultScreen.kt:274-296 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×2
  • Edited copy of a member (17 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:47 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:47-63 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:81-97 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/SeasonViewModel.kt:86 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/SeasonViewModel.kt:86-102 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/SeasonViewModel.kt:104-120 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×2
  • Edited copy of a member (14 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:140 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:140-153 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/UserRepository.kt:158-171 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/grpc/utils/Channel.kt:67 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/grpc/utils/Channel.kt:67-80 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/grpc/utils/Channel.kt:82-95 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (45 lines × 2) · ×2
  • Duplicated block (45 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:137 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:137-181 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt:99-143 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:137` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (45 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:66 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:66-110 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:66-110 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:66` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:113` calls `update` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:115` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×2
  • Duplicated block (33 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:46 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:46-78 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/RcmdPage.kt:46-78 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/RcmdPage.kt` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (33 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:156 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:156-188 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt:178-210 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:156` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (29 lines × 2) · ×2
  • Duplicated block (29 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:510 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:510-538 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:546-574 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:510` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (29 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:171 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:171-199 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:287-315 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:171` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×2
  • Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:276 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:276-303 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:311-338 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:276` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (28 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:513 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:513-540 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:655-682 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:513` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×2
  • Duplicated block (27 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:86 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:86-112 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/ReplySheetScaffold.kt:168-194 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (27 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:77 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:77-103 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:79-105 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `item` to `bilibili.app.interfaces.v1.CursorItem) = HistoryItem( oid = item.oid` in one and `bilibili.app.interfaces.v1.CursorItem) = ToViewItem( oid = item.oid` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (18–19 lines × 2) · ×2
  • Duplicated block (18–19 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:470 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:470-487 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/FavoriteScreen.kt:144-162 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:470` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18–19 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:387 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:387-404 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:422-440 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:387` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:57 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:57-75 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:53-71 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 72 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt:31 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliLiveHttpApi.kt:31-50 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliPassportHttpApi.kt:39-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliPassportHttpApi.kt:39` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×2
  • Duplicated block (16–17 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:38 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:38-53 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/VideoPlayerV3Activity.kt:46-62 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:38` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/VideoPlayerV3Activity.kt:65` calls `viewModel` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/RemoteControllerPanelDemoActivity.kt:56` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (16–17 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:93 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:93-108 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:120-136 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:115` calls `FocusRequester`, `mutableStateOf` and `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:91` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×2
  • Duplicated block (13–14 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:249 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:249-261 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:371-384 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:249` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13–14 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:49 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:49-61 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:96-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×2
  • Duplicated block (12 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt:181 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt:181-192 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/PgcContent.kt:142-153 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/UgcContent.kt:273-284 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt:181` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 3) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:244 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:244-255 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:279-290 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpProxyApi.kt:85-96 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:242` calls `require` and `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:278` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:100 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:100-111 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:123-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:100` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:274 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:274-285 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:304-315 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:274` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×2
  • Duplicated block (11 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:65 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:65-75 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:65-75 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:144-154 — before extracting anything, compare `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:65` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:126 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:126-136 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:148-158 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:170-180 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/RemoteControlPanelDemo.kt:126` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×2
  • Duplicated block (9 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/UserViewModel.kt:54 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/UserViewModel.kt:54-64 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:86-94 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:86-94 — before extracting anything, compare `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/UserViewModel.kt:54` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/home/DynamicViewModel.kt:86 — app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/home/DynamicViewModel.kt:86-94 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt:84-92 | app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt:84-92 — before extracting anything, compare `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/HistoryViewModel.kt` and `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/user/ToViewViewModel.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/home/DynamicViewModel.kt:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×2
  • Duplicated block (7 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:49 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:49-55 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:811-817 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1263 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1263-1269 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpProxyApi.kt:114-120 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D5 · Coupling · Off the main sequence · ×2
  • Off the main sequence: :bili-subtitle — :bili-subtitle: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
  • Off the main sequence: :utils — :utils: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
D1 · Cyclomatic Complexity · VideoPlayerControllerKt.VideoPlayerController (cyclomatic 54) · ×1
  • VideoPlayerControllerKt.VideoPlayerController (cyclomatic 54) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:55 — VideoPlayerControllerKt.VideoPlayerController has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ImageViewerKt.ImageViewer (cyclomatic 40) · ×1
  • ImageViewerKt.ImageViewer (cyclomatic 40) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:324 — ImageViewerKt.ImageViewer has cyclomatic complexity 40 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ImageComposeCanvasKt.ImageComposeCanvas (cyclomatic 37) · ×1
  • ImageComposeCanvasKt.ImageComposeCanvas (cyclomatic 37) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:276 — ImageComposeCanvasKt.ImageComposeCanvas has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VideoInfoScreenKt.VideoInfoScreen (cyclomatic 33) · ×1
  • VideoInfoScreenKt.VideoInfoScreen (cyclomatic 33) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158 — VideoInfoScreenKt.VideoInfoScreen has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BvPlayerKt.BvPlayer (cyclomatic 33) · ×1
  • BvPlayerKt.BvPlayer (cyclomatic 33) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:80 — BvPlayerKt.BvPlayer has cyclomatic complexity 33 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MediaCodecScreenKt.MediaCodecDetails (cyclomatic 26) · ×1
  • MediaCodecScreenKt.MediaCodecDetails (cyclomatic 26) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:224 — MediaCodecScreenKt.MediaCodecDetails has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SearchResultScreenKt.SearchResultScreen (cyclomatic 25) · ×1
  • SearchResultScreenKt.SearchResultScreen (cyclomatic 25) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultScreen.kt:70 — SearchResultScreenKt.SearchResultScreen has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · BvPlayerControllerKt.detectPlayerGestures (cyclomatic 24) · ×1
  • BvPlayerControllerKt.detectPlayerGestures (cyclomatic 24) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:546 — BvPlayerControllerKt.detectPlayerGestures has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HomeContentKt.HomeContent (cyclomatic 23) · ×1
  • HomeContentKt.HomeContent (cyclomatic 23) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt:45 — HomeContentKt.HomeContent has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DynamicItem.fromDynamicItem (cyclomatic 21) · ×1
  • DynamicItem.fromDynamicItem (cyclomatic 21) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:151 — DynamicItem.fromDynamicItem has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · VideoPlayerScreenKt.VideoPlayerScreen (cyclomatic 20) · ×1
  • VideoPlayerScreenKt.VideoPlayerScreen (cyclomatic 20) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:129 — VideoPlayerScreenKt.VideoPlayerScreen has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SeasonInfoScreenKt.SeasonInfoScreen (cyclomatic 20) · ×1
  • SeasonInfoScreenKt.SeasonInfoScreen (cyclomatic 20) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:123 — SeasonInfoScreenKt.SeasonInfoScreen has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ImageViewerKt.detectTransformGestures (cyclomatic 19) · ×1
  • ImageViewerKt.detectTransformGestures (cyclomatic 19) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:662 — ImageViewerKt.detectTransformGestures has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UserLockSettingsScreenKt.UserLockSettingsContent (cyclomatic 19) · ×1
  • UserLockSettingsScreenKt.UserLockSettingsContent (cyclomatic 19) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UserLockSettingsScreen.kt:93 — UserLockSettingsScreenKt.UserLockSettingsContent has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DanmakuMenuKt.DanmakuMenuList (cyclomatic 19) · ×1
  • DanmakuMenuKt.DanmakuMenuList (cyclomatic 19) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:42 — DanmakuMenuKt.DanmakuMenuList has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ImageComposeOriginKt.ImageComposeOrigin (cyclomatic 18) · ×1
  • ImageComposeOriginKt.ImageComposeOrigin (cyclomatic 18) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeOrigin.kt:51 — ImageComposeOriginKt.ImageComposeOrigin has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ThemeKt.BVTheme (cyclomatic 18) · ×1
  • ThemeKt.BVTheme (cyclomatic 18) app/shared/src/main/kotlin/dev/aaa1115910/bv/ui/theme/Theme.kt:33 — ThemeKt.BVTheme has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · UnlockUserScreenKt.UnlockUserContent (cyclomatic 18) · ×1
  • UnlockUserScreenKt.UnlockUserContent (cyclomatic 18) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:80 — UnlockUserScreenKt.UnlockUserContent has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PreviewerVerticalDragState.verticalDrag (cyclomatic 17) · ×1
  • PreviewerVerticalDragState.verticalDrag (cyclomatic 17) app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/PreviewerVerticalDragState.kt:118 — PreviewerVerticalDragState.verticalDrag has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VideoPlayerV3ViewModel.loadPlayUrl (cyclomatic 17) · ×1
  • VideoPlayerV3ViewModel.loadPlayUrl (cyclomatic 17) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt:183 — VideoPlayerV3ViewModel.loadPlayUrl has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SeasonInfoScreenKt.SeasonEpisodesDialog (cyclomatic 17) · ×1
  • SeasonInfoScreenKt.SeasonEpisodesDialog (cyclomatic 17) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:664 — SeasonInfoScreenKt.SeasonEpisodesDialog has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SearchResultFilterKt.SearchResultVideoFilter (cyclomatic 17) · ×1
  • SearchResultFilterKt.SearchResultVideoFilter (cyclomatic 17) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:41 — SearchResultFilterKt.SearchResultVideoFilter has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BvPlayerControllerKt.BvPlayerControllerVideoContent (cyclomatic 17) · ×1
  • BvPlayerControllerKt.BvPlayerControllerVideoContent (cyclomatic 17) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:280 — BvPlayerControllerKt.BvPlayerControllerVideoContent has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HistoryItem.fromHistoryItem (cyclomatic 16) · ×1
  • HistoryItem.fromHistoryItem (cyclomatic 16) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:64 — HistoryItem.fromHistoryItem has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ToViewItem.fromToViewItem (cyclomatic 16) · ×1
  • ToViewItem.fromToViewItem (cyclomatic 16) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:66 — ToViewItem.fromToViewItem has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ReplySheetScaffoldKt.ReplySheetScaffold (cyclomatic 16) · ×1
  • ReplySheetScaffoldKt.ReplySheetScaffold (cyclomatic 16) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/ReplySheetScaffold.kt:53 — ReplySheetScaffoldKt.ReplySheetScaffold has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · CodecMode.fromMediaCodecInfo (cyclomatic 16) · ×1
  • CodecMode.fromMediaCodecInfo (cyclomatic 16) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt:86 — CodecMode.fromMediaCodecInfo has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · VideoPlayerControllerKt.VideoPlayerController (cognitive 80) · ×1
  • VideoPlayerControllerKt.VideoPlayerController (cognitive 80) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:55 — VideoPlayerControllerKt.VideoPlayerController has cognitive complexity 80 (threshold 15). Drivers by points: if/else 43 (77 pts), boolean chains 2, match/switch 1 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VideoInfoScreenKt.VideoInfoScreen (cognitive 69) · ×1
  • VideoInfoScreenKt.VideoInfoScreen (cognitive 69) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:158 — VideoInfoScreenKt.VideoInfoScreen has cognitive complexity 69 (threshold 15). Drivers by points: if/else 40 (64 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageComposeCanvasKt.ImageComposeCanvas (cognitive 58) · ×1
  • ImageComposeCanvasKt.ImageComposeCanvas (cognitive 58) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:276 — ImageComposeCanvasKt.ImageComposeCanvas has cognitive complexity 58 (threshold 15). Drivers by points: if/else 31 (47 pts), boolean chains 6, loops 2 (3 pts), match/switch 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageViewerKt.ImageViewer (cognitive 51) · ×1
  • ImageViewerKt.ImageViewer (cognitive 51) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:324 — ImageViewerKt.ImageViewer has cognitive complexity 51 (threshold 15). Drivers by points: if/else 28 (37 pts), boolean chains 9, match/switch 2 (3 pts), error handling 1 (2 pts) (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SeasonInfoScreenKt.SeasonInfoScreen (cognitive 42) · ×1
  • SeasonInfoScreenKt.SeasonInfoScreen (cognitive 42) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:123 — SeasonInfoScreenKt.SeasonInfoScreen has cognitive complexity 42 (threshold 15). Drivers by points: if/else 25 (41 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageViewerKt.detectTransformGestures (cognitive 41) · ×1
  • ImageViewerKt.detectTransformGestures (cognitive 41) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:662 — ImageViewerKt.detectTransformGestures has cognitive complexity 41 (threshold 15). Drivers by points: if/else 14 (36 pts), boolean chains 4, loops 1 (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SearchResultFilterKt.SearchResultVideoFilter (cognitive 38) · ×1
  • SearchResultFilterKt.SearchResultVideoFilter (cognitive 38) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultFilter.kt:41 — SearchResultFilterKt.SearchResultVideoFilter has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (38 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PreviewerVerticalDragState.verticalDrag (cognitive 37) · ×1
  • PreviewerVerticalDragState.verticalDrag (cognitive 37) app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/PreviewerVerticalDragState.kt:118 — PreviewerVerticalDragState.verticalDrag has cognitive complexity 37 (threshold 15). Drivers by points: if/else 19 (35 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SeasonInfoScreenKt.SeasonEpisodesDialog (cognitive 37) · ×1
  • SeasonInfoScreenKt.SeasonEpisodesDialog (cognitive 37) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:664 — SeasonInfoScreenKt.SeasonEpisodesDialog has cognitive complexity 37 (threshold 15). Drivers by points: if/else 20 (32 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BvPlayerKt.BvPlayer (cognitive 35) · ×1
  • BvPlayerKt.BvPlayer (cognitive 35) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:80 — BvPlayerKt.BvPlayer has cognitive complexity 35 (threshold 15). Drivers by points: if/else 24 (28 pts), match/switch 4 (6 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MaterialShapeQrState.searchAndCreateLargeSquareShapes (cognitive 32) · ×1
  • MaterialShapeQrState.searchAndCreateLargeSquareShapes (cognitive 32) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:497 — MaterialShapeQrState.searchAndCreateLargeSquareShapes has cognitive complexity 32 (threshold 15). Drivers by points: if/else 4 (18 pts), loops 4 (12 pts), boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BvPlayerControllerKt.detectPlayerGestures (cognitive 30) · ×1
  • BvPlayerControllerKt.detectPlayerGestures (cognitive 30) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:546 — BvPlayerControllerKt.detectPlayerGestures has cognitive complexity 30 (threshold 15). Drivers by points: if/else 21 (26 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ThemeKt.BVTheme (cognitive 29) · ×1
  • ThemeKt.BVTheme (cognitive 29) app/shared/src/main/kotlin/dev/aaa1115910/bv/ui/theme/Theme.kt:33 — ThemeKt.BVTheme has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21 (25 pts), match/switch 2 (4 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · VideoPlayerScreenKt.VideoPlayerScreen (cognitive 27) · ×1
  • VideoPlayerScreenKt.VideoPlayerScreen (cognitive 27) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:129 — VideoPlayerScreenKt.VideoPlayerScreen has cognitive complexity 27 (threshold 15). Drivers by points: if/else 18 (20 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MediaCodecScreenKt.MediaCodecDetails (cognitive 27) · ×1
  • MediaCodecScreenKt.MediaCodecDetails (cognitive 27) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:224 — MediaCodecScreenKt.MediaCodecDetails has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 3 (8 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BvPlayerControllerKt.BvPlayerControllerVideoContent (cognitive 25) · ×1
  • BvPlayerControllerKt.BvPlayerControllerVideoContent (cognitive 25) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:280 — BvPlayerControllerKt.BvPlayerControllerVideoContent has cognitive complexity 25 (threshold 15). Drivers by points: if/else 20 (24 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · UserInfoScreenKt.UserInfoScreen (cognitive 24) · ×1
  • UserInfoScreenKt.UserInfoScreen (cognitive 24) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:103 — UserInfoScreenKt.UserInfoScreen has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (21 pts), match/switch 3 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MobileMainScreenKt.MobileMainScreen (cognitive 22) · ×1
  • MobileMainScreenKt.MobileMainScreen (cognitive 22) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/MobileMainScreen.kt:110 — MobileMainScreenKt.MobileMainScreen has cognitive complexity 22 (threshold 15). Drivers by points: if/else 16 (20 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MaterialShapeQrState.searchAndCreateHorizontalBars (cognitive 22) · ×1
  • MaterialShapeQrState.searchAndCreateHorizontalBars (cognitive 22) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:549 — MaterialShapeQrState.searchAndCreateHorizontalBars has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UserLockSettingsScreenKt.UserLockSettingsContent (cognitive 22) · ×1
  • UserLockSettingsScreenKt.UserLockSettingsContent (cognitive 22) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UserLockSettingsScreen.kt:93 — UserLockSettingsScreenKt.UserLockSettingsContent has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RecommendViewModel.loadMore (cognitive 21) · ×1
  • RecommendViewModel.loadMore (cognitive 21) app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/home/RecommendViewModel.kt:33 — RecommendViewModel.loadMore has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UISettingKt.UIDensityDialog (cognitive 21) · ×1
  • UISettingKt.UIDensityDialog (cognitive 21) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/UISetting.kt:117 — UISettingKt.UIDensityDialog has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (20 pts), boolean chains 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VideoInfoScreenKt.VideoPartListDialog (cognitive 20) · ×1
  • VideoInfoScreenKt.VideoPartListDialog (cognitive 20) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1333 — VideoInfoScreenKt.VideoPartListDialog has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (VideoInfoScreenKt.VideoUgcListDialog) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · VideoInfoScreenKt.VideoUgcListDialog (cognitive 20) · ×1
  • VideoInfoScreenKt.VideoUgcListDialog (cognitive 20) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1448 — VideoInfoScreenKt.VideoUgcListDialog has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (VideoInfoScreenKt.VideoPartListDialog) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · SearchResultScreenKt.SearchResultScreen (cognitive 20) · ×1
  • SearchResultScreenKt.SearchResultScreen (cognitive 20) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultScreen.kt:70 — SearchResultScreenKt.SearchResultScreen has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (15 pts), match/switch 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · VideoListControllerKt.VideoListController (cognitive 20) · ×1
  • VideoListControllerKt.VideoListController (cognitive 20) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoListController.kt:43 — VideoListControllerKt.VideoListController has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (17 pts), match/switch 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DanmakuMenuKt.DanmakuMenuList (cognitive 19) · ×1
  • DanmakuMenuKt.DanmakuMenuList (cognitive 19) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:42 — DanmakuMenuKt.DanmakuMenuList has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 4, match/switch 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ImageComposeOriginKt.ImageComposeOrigin (cognitive 18) · ×1
  • ImageComposeOriginKt.ImageComposeOrigin (cognitive 18) app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeOrigin.kt:51 — ImageComposeOriginKt.ImageComposeOrigin has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (14 pts), match/switch 3, boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VideoPlayerPagesKt.VideoPlayerPartSheetContent (cognitive 18) · ×1
  • VideoPlayerPagesKt.VideoPlayerPartSheetContent (cognitive 18) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:404 — VideoPlayerPagesKt.VideoPlayerPartSheetContent has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CodecMode.fromMediaCodecInfo (cognitive 18) · ×1
  • CodecMode.fromMediaCodecInfo (cognitive 18) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/CodecUtil.kt:86 — CodecMode.fromMediaCodecInfo has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (12 pts), boolean chains 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · UnlockUserScreenKt.UnlockUserContent (cognitive 18) · ×1
  • UnlockUserScreenKt.UnlockUserContent (cognitive 18) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/lock/UnlockUserScreen.kt:80 — UnlockUserScreenKt.UnlockUserContent has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), match/switch 4 (5 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HistoryItem.fromHistoryItem (cognitive 16) · ×1
  • HistoryItem.fromHistoryItem (cognitive 16) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:64 — HistoryItem.fromHistoryItem has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, match/switch 8. The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ToViewItem.fromToViewItem (cognitive 16) · ×1
  • ToViewItem.fromToViewItem (cognitive 16) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:66 — ToViewItem.fromToViewItem has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, match/switch 8. The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MaterialShapeQrState.searchAndCreateBars (cognitive 16) · ×1
  • MaterialShapeQrState.searchAndCreateBars (cognitive 16) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:531 — MaterialShapeQrState.searchAndCreateBars has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D3 · God Classes · TooManyMethods · ×1
  • TooManyMethods: BiliHttpApi bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:105 — TooManyMethods — 82 methods. The bar is 30 methods; this is 52 over it, 2.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D35 · Change Coupling · Change coupling clique · ×1
  • Change coupling clique: MenuController.kt, ClosedCaptionMenu.kt, DanmakuMenu.kt, PictureMenu.kt player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt — 4 files — `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt`, `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt`, `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt`, `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/PictureMenu.kt` — all change together with no explicit dependency: a fully-connected co-change clique, not 6 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (4 members, 41 shared lines) · ×1
  • Near-duplicate member family (4 members, 41 shared lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:51 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:51-151 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:50-198 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/OthersMenu.kt:43-111 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/PictureMenu.kt:52-173 — These 4 members are variants of one another: a block of 41 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Near-duplicate member pair (118 shared lines) · ×1
  • Near-duplicate member pair (118 shared lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:81 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:81-393 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:104-675 — These two members are variants of one another: 118 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (78 shared lines) · ×1
  • Near-duplicate member pair (78 shared lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:40 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:40-147 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt:41-139 — These two members are variants of one another: 78 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (54 shared lines) · ×1
  • Near-duplicate member pair (54 shared lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:55 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:55-221 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt:53-220 — These two members are variants of one another: 54 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:19 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:19-77 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:79-127 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (149 corresponding lines) · ×1
  • Edited copy of a member (149 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:83 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:83-231 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt:50-220 — These two members are one piece of code written twice and then edited apart: 149 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (129 corresponding lines) · ×1
  • Edited copy of a member (129 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:464 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:464-595 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:231-359 — These two members are one piece of code written twice and then edited apart: 129 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 106+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 106+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:673 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:673-800 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1340-1445 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1455-1561 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 106 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (92 corresponding lines) · ×1
  • Edited copy of a member (92 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:48 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:48-139 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:54-154 — These two members are one piece of code written twice and then edited apart: 92 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (98 corresponding lines) · ×1
  • Edited copy of a member (98 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:186 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:186-283 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SmallVideoCard.kt:45-160 — These two members are one piece of code written twice and then edited apart: 98 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (45 corresponding lines) · ×1
  • Edited copy of a member (45 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:64 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/History.kt:64-108 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/ToView.kt:66-110 — These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 82+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 82+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:41 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:41-127 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:40-121 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:40-121 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:42-134 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 82 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 61+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 61+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:41 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:41-123 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:38-98 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt:38-99 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 61 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (52 corresponding lines) · ×1
  • Edited copy of a member (52 corresponding lines) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:31 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:31-82 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:93-144 — These two members are one piece of code written twice and then edited apart: 52 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (59 corresponding lines) · ×1
  • Edited copy of a member (59 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:133 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:133-191 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:208-266 — These two members are one piece of code written twice and then edited apart: 59 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (60 corresponding lines) · ×1
  • Edited copy of a member (60 corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:62 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:62-135 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/SettingsScreen.kt:59-118 — These two members are one piece of code written twice and then edited apart: 60 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (41 corresponding lines) · ×1
  • Edited copy of a member (41 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:38 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:38-78 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/RcmdPage.kt:38-78 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 17+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:241 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:241-259 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:278-294 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpProxyApi.kt:82-100 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (40 corresponding lines) · ×1
  • Edited copy of a member (40 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:239 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:239-278 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:288-328 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×1
  • Edited copy of a member (33 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:392 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:392-425 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:431-463 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 36+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 36+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/ApiSetting.kt:31 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/ApiSetting.kt:31-66 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/AudioSetting.kt:31-66 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/PlayerTypeSetting.kt:32-75 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/ResolutionSetting.kt:31-66 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/content/VideoCodecSetting.kt:31-66 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 36 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 33+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 33+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt:80 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt:80-112 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/VideoDetailRepository.kt:175-215 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/VideoDetailRepository.kt:223-258 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 33 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/RadioPreference.kt:200 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/RadioPreference.kt:200-228 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt:116-144 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt:344 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt:344-373 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt:377-406 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 21+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:530 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:530-555 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:562-586 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:592-612 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 25+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 25+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1149 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1149-1173 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:386-413 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcCommon.kt:421-452 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×1
  • Edited copy of a member (12 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/Episode.kt:35 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/Episode.kt:35-46 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/Episode.kt:49-60 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 22+ corresponding lines) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:171 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:171-192 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:199-220 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:227-252 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 19+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 19+ corresponding lines) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:26 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:26-44 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/GuoChuangContent.kt:26-44 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/MovieContent.kt:26-44 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/TvContent.kt:26-44 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/VarietyContent.kt:26-44 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 8+ corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1242 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1242-1249 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1262-1270 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpProxyApi.kt:113-121 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×1
  • Edited copy of a member (15 corresponding lines) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt:90 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/SwitchPreference.kt:90-105 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/preferences/items/TextPreference.kt:52-66 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×1
  • Edited copy of a member (9 corresponding lines) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt:22 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/Comment.kt:22-30 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/reply/CommentRepliesData.kt:22-31 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (71 lines × 2) · ×1
  • Duplicated block (71 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:58 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:58-128 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt:73-143 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/SeasonCard.kt` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SeasonCard.kt:58` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `MaterialTheme` names `androidx.compose.material3.MaterialTheme` in one and `androidx.tv.material3.MaterialTheme` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (56 lines × 3) · ×1
  • Duplicated block (56 lines × 3) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:130 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:130-185 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:188-243 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/PlayData.kt:246-301 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (51 lines × 2) · ×1
  • Duplicated block (51 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:41 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:41-91 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt:44-94 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/UpSpaceVideoItem.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/RelatedVideoItem.kt:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (39 lines × 2) · ×1
  • Duplicated block (39 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:247 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:247-285 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoPlayerV3Screen.kt:68-106 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:247` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `BvPlayer` names `dev.aaa1115910.bv.player.mobile.BvPlayer` in one and `dev.aaa1115910.bv.player.tv.BvPlayer` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (38 lines × 2) · ×1
  • Duplicated block (38 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:90 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:90-127 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:856-893 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:90` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:89` calls `background` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:855` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (36 lines × 2) · ×1
  • Duplicated block (36 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:139 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:139-174 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:214-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/Tips.kt:139` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (31–32 lines × 3) · ×1
  • Duplicated block (31–32 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:680 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:680-711 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1347-1377 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1462-1492 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:680` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32 lines × 2) · ×1
  • Duplicated block (32 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:135 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:135-166 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:137-168 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 72 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:135` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×1
  • Duplicated block (30 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:69 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:69-98 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt:70-99 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:69` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (27 lines × 5) · ×1
  • Duplicated block (27 lines × 5) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:51 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/DocumentaryContent.kt:51-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/GuoChuangContent.kt:51-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/MovieContent.kt:51-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/TvContent.kt:51-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/VarietyContent.kt:51-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (26 lines × 4) · ×1
  • Duplicated block (26 lines × 4) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:110 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:110-135 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:157-182 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/OthersMenu.kt:70-95 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/PictureMenu.kt:132-157 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:110` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:194 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:194-219 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:665-690 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:194` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:191` calls `isNotBlank`, `Text` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:664` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24–26 lines × 2) · ×1
  • Duplicated block (24–26 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:464 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:464-489 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:572-595 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:464` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:570` calls `padding`, `clip` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:463` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/HomeScreen.kt:149 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/HomeScreen.kt:149-173 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/HomeScreen.kt:180-204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/HomeScreen.kt:149` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (41–48 lines × 2) · ×1
  • Duplicated block (41–48 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:273 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:273-313 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:457-504 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:273` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23–24 lines × 3) · ×1
  • Duplicated block (23–24 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:715 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:715-737 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1377-1400 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1492-1515 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:715` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:715` calls `TabRow` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1377` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:32 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:32-55 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:94-117 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/component/StepLessMenuItem.kt:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 3) · ×1
  • Duplicated block (23 lines × 3) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:208 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:208-230 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:679-701 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/videocard/SmallVideoCard.kt:65-87 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:208` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/settings/UpdateDialog.kt:16 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/settings/UpdateDialog.kt:16-38 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/settings/UpdateDialog.kt:16-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `Button` names `androidx.compose.material3.Button` in one and `androidx.tv.material3.Button` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (21 lines × 4) · ×1
  • Duplicated block (21 lines × 4) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:100 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:100-120 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt:100-120 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/ReplySheetScaffold.kt:182-202 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:866-886 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Replies.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 72 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/Comments.kt:100` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–21 lines × 2) · ×1
  • Duplicated block (16–21 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:439 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:439-459 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:547-562 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:439` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (20–21 lines × 2) · ×1
  • Duplicated block (20–21 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:246 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:246-265 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:267-287 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:267` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19–20 lines × 2) · ×1
  • Duplicated block (19–20 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:46 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:46-64 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt:46-65 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×1
  • Duplicated block (19 lines × 3) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:351 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:351-369 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:415-433 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:457-475 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:351` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:690 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:690-707 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt:104-121 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/VideoPlayerController.kt:350-367 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:690` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15–18 lines × 2) · ×1
  • Duplicated block (15–18 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt:98 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt:98-112 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/VideoDetailRepository.kt:241-258 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/CommentRepository.kt:98` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:127 — app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:127-142 | app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:149-164 | app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Extends.kt:171-186 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×1
  • Duplicated block (15–16 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/UserSpaceScreen.kt:41 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/UserSpaceScreen.kt:41-55 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:49-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/UserSpaceScreen.kt:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (15 lines × 5) · ×1
  • Duplicated block (15 lines × 5) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:51 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:51-65 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DashMenu.kt:58-72 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/MoreMenu.kt:46-60 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/SpeedMenu.kt:46-60 | player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/VideoListMenu.kt:76-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/menu/DanmakuMenu.kt:51` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×1
  • Duplicated block (15 lines × 4) player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:137 — player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:137-151 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/DanmakuMenu.kt:184-198 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/OthersMenu.kt:97-111 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/PictureMenu.kt:159-173 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/playermenu/ClosedCaptionMenu.kt:137` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 12) · ×1
  • Duplicated block (12 lines × 12) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:63 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:63-74 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:116-127 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:123-134 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchResultScreen.kt:177-188 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/LogsScreen.kt:158-169 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:85-101 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/SettingsScreen.kt:69-85 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FavoriteScreen.kt:94-105 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowScreen.kt:78-94 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:53-64 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:53-64 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt:64-75 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UpInfoScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/TagScreen.kt:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659-669 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:704-715 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 6) · ×1
  • Duplicated block (11 lines × 6) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:116 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:116-126 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/LogsScreen.kt:158-168 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/SettingsScreen.kt:69-84 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt:95-110 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/HistoryScreen.kt:53-63 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/ToViewScreen.kt:53-63 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/FollowingSeasonScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 59 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/pgc/PgcIndexScreen.kt:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×1
  • Duplicated block (11 lines × 4) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:75 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:75-85 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt:66-76 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt:67-77 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/ugc/UgcCommon.kt:114-124 — before extracting anything, compare `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/PopularScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/RecommendScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:75` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 3) · ×1
  • Duplicated block (10–11 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332-342 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:363-372 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:391-401 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:332` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:812 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:812-822 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:987-996 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:812` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:62 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:62-71 | app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/RcmdPage.kt:62-71 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/home/DynamicsScreen.kt:81-90 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt` and `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/RcmdPage.kt` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/home/PopularPage.kt:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `SmallVideoCard` names `dev.aaa1115910.bv.mobile.component.videocard.SmallVideoCard` in one and `dev.aaa1115910.bv.tv.component.videocard.SmallVideoCard` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:50 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:50-58 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:705-714 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:50` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/component/videocard/VideosRow.kt:49` calls `FocusRequester` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:704` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–9 lines × 3) · ×1
  • Duplicated block (8–9 lines × 3) app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659 — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659-667 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:687-694 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:704-712 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:659` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×1
  • Duplicated block (8–9 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:78 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:78-86 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/activities/video/VideoPlayerV3Activity.kt:95-102 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/activities/VideoPlayerActivity.kt:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×1
  • Duplicated block (9 lines × 2) app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:94 — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:94-102 | app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt:61-69 — before extracting anything, compare `app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt` and `app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/login/SmsLoginContent.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (7–9 lines × 2) · ×1
  • Duplicated block (7–9 lines × 2) player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:113 — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:113-121 | player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:149-155 — before extracting anything, compare `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 126 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:109` calls `mutableLongStateOf` and `player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:145` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:94 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:94-102 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:115-122 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:132-139 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:94` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×1
  • Duplicated block (6 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:595 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:595-600 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:634-639 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (2–5 lines × 4) · ×1
  • Duplicated block (2–5 lines × 4) app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:89 — app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:89-93 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:110-114 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:127-131 | app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:150-151 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeRenderer.kt:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×1
  • Duplicated block (5 lines × 2) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:697 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:697-701 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:749-753 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:697` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×1
  • Duplicated block (5 lines × 4) bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:109 — bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:109-113 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:855-859 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/repositories/SearchRepository.kt:403-407 | bili-api/src/main/kotlin/dev/aaa1115910/biliapi/util/Extends.kt:5-9 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:109` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:852` calls `startsWith`, `isBlank` and `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:107` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X27 · Collection changed while being enumerated · Collection is structurally changed while it is being enumerated · ×1
  • Collection is structurally changed while it is being enumerated app/mobile/src/main/kotlin/com/origeek/imageViewer/util/Ticket.kt:34 — `ticketMap` is walked by the loop on line 34, and line 36 calls `ticketMap.remove` on `ticketMap` inside the loop body — a structural change to a `LinkedHashMap`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen.
Minor — 305 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×280
  • Orphaned file bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/user/Dynamic.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/dynamic/DynamicItem.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserInfoScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/shared/src/main/kotlin/dev/aaa1115910/bv/viewmodel/VideoPlayerV3ViewModel.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/shared/src/main/kotlin/dev/aaa1115910/m3qrcode/MaterialShapeQrState.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/player/VideoPlayerPages.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageComposeCanvas.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/user/UserSwitchScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/DynamicDetailScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/reply/CommentItem.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/MobileMainScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/component/home/UserDialog.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/shared/src/main/kotlin/dev/aaa1115910/bv/util/Prefs.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/UgcContent.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/ImageTransform.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/MenuController.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/LoginScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/home/SearchScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/settings/MediaCodecScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/search/SearchInputScreen.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/FullscreenControllers.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 255 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×4
  • Duplicated predicate app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt:73 — `firstVisibleItemIndex == 0 && firstVisibleItemScrollOffset == 0` appears character-identically in 2 files — app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/HomeContent.kt, app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/main/PgcContent.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt:184 — `lastPlayed > 0 && hideBackToHistoryTimer == null` appears character-identically in 2 files — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/BvPlayer.kt, player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/BvPlayer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/MobileMainScreen.kt:212 — `previewerState.canClose || previewerState.animating` appears character-identically in 2 files — app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/MobileMainScreen.kt, app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt:424 — `videoPlayerStateData.isBuffering && !videoPlayerStateData.isError` appears character-identically in 2 files — player/mobile/src/main/kotlin/dev/aaa1115910/bv/player/mobile/controller/BvPlayerController.kt, player/tv/src/main/kotlin/dev/aaa1115910/bv/player/tv/controller/PlayStateTips.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D21 · Naming Consistency · `dedeUserID` spells `ID` where 233 names in the project spell it `Id` · ×3
  • `dedeUserID` spells `ID` where 233 names in the project spell it `Id` bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:193 — 233 of 236 names in project bili-api spell the token `Id` (233 of 236; unit: names in project bili-api containing `Id`). Peers: CarouselItem.seasonId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:103); CarouselItem.episodeId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:104); CodeType.codecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:6); Companion.fromCodecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:14); dev.aaa1115910.biliapi.entity.FavoriteFolderItemId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/Favorite.kt:6). Rename to `dedeUserId`. [rule N6]
  • `dedeUserID` spells `ID` where 233 names in the project spell it `Id` bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpApi.kt:226 — 233 of 236 names in project bili-api spell the token `Id` (233 of 236; unit: names in project bili-api containing `Id`). Peers: CarouselItem.seasonId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:103); CarouselItem.episodeId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:104); CodeType.codecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:6); Companion.fromCodecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:14); dev.aaa1115910.biliapi.entity.FavoriteFolderItemId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/Favorite.kt:6). Rename to `dedeUserId`. [rule N6]
  • `dedeUserID` spells `ID` where 233 names in the project spell it `Id` bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/BiliHttpProxyApi.kt:67 — 233 of 236 names in project bili-api spell the token `Id` (233 of 236; unit: names in project bili-api containing `Id`). Peers: CarouselItem.seasonId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:103); CarouselItem.episodeId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CarouselData.kt:104); CodeType.codecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:6); Companion.fromCodecId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/CodeType.kt:14); dev.aaa1115910.biliapi.entity.FavoriteFolderItemId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/Favorite.kt:6). Rename to `dedeUserId`. [rule N6]
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/VideoInfoScreen.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file app/tv/src/main/kotlin/dev/aaa1115910/bv/tv/screens/SeasonInfoScreen.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file app/mobile/src/main/kotlin/dev/aaa1115910/bv/mobile/screen/VideoPlayerScreen.kt:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found app/build.gradle.kts:9 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `app/build.gradle.kts` makes this repository a deployable product (line 9).
D21 · Naming Consistency · `NewEP` spells `EP` where 31 names in the project spell it `Ep` · ×1
  • `NewEP` spells `EP` where 31 names in the project spell it `Ep` bili-api/src/main/kotlin/dev/aaa1115910/biliapi/http/entity/season/WebSeasonData.kt:441 — 31 of 32 names in project bili-api spell the token `Ep` (31 of 32; unit: names in project bili-api containing `Ep`). Peers: dev.aaa1115910.biliapi.entity.season.TimelineEp (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/season/Timeline.kt:38); VideoDetail.redirectToEp (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/VideoDetail.kt:24); SeasonDetail.newEpDesc (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/SeasonDetail.kt:34); Progress.lastEpId (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/SeasonDetail.kt:140); Progress.lastEpIndex (bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/video/season/SeasonDetail.kt:141). Rename to `NewEp`. [rule N6]
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 4 of 12 project(s) overshoot their size bounds, lowering Project Cohesion to 3.3/10. The most over is `bili-api` (18855 LoC, 1483 module-visible types across 47 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness · Dormant codebase · ×1
  • Dormant codebase — 283 of 283 significant files have no living knowledge — the codebase as a whole is dormant, not 283 separate risks. Counted over 283 of the 596 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M1 · Documentation (README) · Thin README · ×1
  • Thin README README.md:1 — The root README is 83 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 6 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P4 · Deployment & Rollback · No release approval gate · ×1
  • No release approval gate — The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X7 · Silent fallback defaults · Silent fallback default in catch · ×1
  • Silent fallback default in catch bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/ugc/UgcItem.kt:32 — `fromRcmdItem` swallows every exception into `-1` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Minor — 1 finding(s)
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: :app:shared — :app:shared: abstractness 0.03, instability 0.00, distance 0.97 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-0f57e34fa56b48c5824aebaf989d7a9e/history.json --exit-code 0 --source .4artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-0f57e34fa56b48c5824aebaf989d7a9e/tree.json --exit-code 0 --source .4artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .53artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 4 file(s) — `app/mobile/src/main/kotlin/com/origeek/imageViewer/previewer/PreviewerTransformState.kt`, `app/mobile/src/main/kotlin/com/origeek/imageViewer/viewer/ImageViewer.kt`, `bili-api/src/main/kotlin/com/tfowl/ktor/client/plugins/JsoupPlugin.kt`, `bili-api/src/main/kotlin/dev/aaa1115910/biliapi/entity/danmaku/DanmakuMask.kt` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) and a Gradle version catalogue — not scanned yet).0—

Run 01a1da2b-5624-7045-a073-6abcc559d0c5 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md