Public report of WorkingRobot/XIViewer, published 17 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 17 November 2026, 03:33 UTC · Survey ID cd_faa84760961146c0b9ac6b8596b6b0cb
WorkingRobot/XIViewer
Measured 17 November 2026, 03:32 UTC, at code version c378fa1
First survey, so nothing to compare with yet
CAI scoreAt risk
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 109,021 lines of product code in 9 projects, tests not counted · Estimated rebuild effort: about 0.8 person-years · Weakest lens: Accessibility, 19.1
Findings by how serious they are
17 critical925 serious56 minor
8 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 03:32 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
65of 65 dimensions measured by tools.
955of 998 findings point to an exact file and line, so you can open each one in the code. The other 43 concern the repository as a whole, such as missing documentation.
65dimensions across 7 lenses, read from 109,021 lines of product code in 9 projects.
WorkingRobot/XIViewer is rated At risk because critical security findings are open, most of them in the build pipeline. It scores 38.1 out of 100, which the At risk rating leaves unchanged.
Accessibility, at 19.1, is the weakest lens and counts most in the score. The best first steps are adding text alternatives and fixing focus, motion and contrast, each worth about 11.4 points. Raising Accessibility to 70 would lift the score to about 53.9.
Thirteen pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. One known security hole in a package the code depends on can be used by attackers, and one secret can leak from the build pipeline. Pinning each tool to an exact version, updating the vulnerable packages and limiting the secret to its own step would close these risks. The unsafe setting in infrastructure or container files needs changing to safe values. The page that blocks zooming needs the zoom block removed.
The product code is 109,021 lines, about €110,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Accessibility rose from 19.1 to 70, the lowest score rated Strong, the score would rise from 38.1 to about 53.9.
Code composition: what the lines of code are
Product code 85%Tests 15%
Rebuild cost: about €110,000 · Estimate
Cost to rebuild
€36,000 to €180,000, for 606 to 1,921 hours of work, about 0.8 person-years for 1 to 2 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 38. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 109,021 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Raises the score by about 11.4 points · Medium effort · Text alternatives
2
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Raises the score by about 5.8 points · Medium effort · Page structure
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €110,000 to build again, about 0.8 person-years of work. Its weakest lens is Accessibility, at 19.1 (Critical). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video. Of all the actions in this report, it raises the score most for the work it takes: about 11.4 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 6.6 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 4% to 8% on every change. The history of the code shows how much it changes: about 86,346 lines over the last 90 days, which is about 350,181 lines a year. At that pace, the extra work comes to an estimated 31.4 to 188.1 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
247 modules, with 623 dependencies between them. One loop runs through 73 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 207 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
assets.viewers.cmp uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.cmp, while a change to assets.viewers.cmp can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.cmp uses a module listed above it, which is the healthy direction.
6→29 assets.viewers.cmp uses backendpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.cmp uses a type in backend.
assets.viewers.cmp uses assets.deps, so a change to assets.deps can break assets.viewers.cmp, while a change to assets.viewers.cmp can't break assets.deps.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.layer uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.layer, while a change to assets.viewers.layer can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.layer uses a module listed above it, which is the healthy direction.
7→27 assets.viewers.layer uses assets.viewers.avfx.programpart of a loop✕
Connections
5 pairs of types, where a type in assets.viewers.layer uses a type in assets.viewers.avfx.program.
assets.viewers.layer uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.layer, while a change to assets.viewers.layer can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
7→29 assets.viewers.layer uses backendpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.layer uses a type in backend.
assets.viewers.layer uses assets.deps, so a change to assets.deps can break assets.viewers.layer, while a change to assets.viewers.layer can't break assets.deps.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
sheet.table_context uses excel.provider, so a change to excel.provider can break sheet.table_context, while a change to sheet.table_context can't break excel.provider.
Position
Below the diagonal: sheet.table_context uses a module listed above it, which is the healthy direction.
sheet.table_context uses excel.base, so a change to excel.base can break sheet.table_context, while a change to sheet.table_context can't break excel.base.
Position
Below the diagonal: sheet.table_context uses a module listed above it, which is the healthy direction.
8→10 sheet.table_context uses sheet.cellpart of a loop✕
Connections
1 pair of types, where a type in sheet.table_context uses a type in sheet.cell.
sheet.table_context uses sheet.cell, so a change to sheet.cell can break sheet.table_context, while a change to sheet.table_context can't break sheet.cell.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.avfx.sim uses assets.viewers.cmp, so a change to assets.viewers.cmp can break assets.viewers.avfx.sim, while a change to assets.viewers.avfx.sim can't break assets.viewers.cmp.
Position
Below the diagonal: assets.viewers.avfx.sim uses a module listed above it, which is the healthy direction.
9→27 assets.viewers.avfx.sim uses assets.viewers.avfx.programpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.avfx.sim uses a type in assets.viewers.avfx.program.
assets.viewers.avfx.sim uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.avfx.sim, while a change to assets.viewers.avfx.sim can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
sheet.cell uses sheet.table_context, so a change to sheet.table_context can break sheet.cell, while a change to sheet.cell can't break sheet.table_context.
Position
Below the diagonal: sheet.cell uses a module listed above it, which is the healthy direction.
assets.viewers.avfx.gpu uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.avfx.gpu, while a change to assets.viewers.avfx.gpu can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.avfx.gpu uses a module listed above it, which is the healthy direction.
11→26 assets.viewers.avfx.gpu uses assets.viewers.avfxpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.avfx.gpu uses a type in assets.viewers.avfx.
assets.viewers.avfx.gpu uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.avfx.gpu, while a change to assets.viewers.avfx.gpu can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
11→27 assets.viewers.avfx.gpu uses assets.viewers.avfx.programpart of a loop✕
Connections
7 pairs of types, where a type in assets.viewers.avfx.gpu uses a type in assets.viewers.avfx.program.
assets.viewers.avfx.gpu uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.avfx.gpu, while a change to assets.viewers.avfx.gpu can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl.program uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.mdl.program uses a module listed above it, which is the healthy direction.
12→13 assets.viewers.mdl.program uses assets.viewers.mdl.deferredpart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.mdl.program uses a type in assets.viewers.mdl.deferred.
assets.viewers.mdl.program uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.viewers.mdl.deferred.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→16 assets.viewers.mdl.program uses assets.viewers.layer.scene.ambientpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl.program uses a type in assets.viewers.layer.scene.ambient.
assets.viewers.mdl.program uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.viewers.layer.scene.ambient.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→26 assets.viewers.mdl.program uses assets.viewers.avfxpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.mdl.program uses a type in assets.viewers.avfx.
assets.viewers.mdl.program uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→27 assets.viewers.mdl.program uses assets.viewers.avfx.programpart of a loop✕
Connections
8 pairs of types, where a type in assets.viewers.mdl.program uses a type in assets.viewers.avfx.program.
assets.viewers.mdl.program uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→33 assets.viewers.mdl.program uses assetspart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.mdl.program uses a type in assets.
assets.viewers.mdl.program uses assets, so a change to assets can break assets.viewers.mdl.program, while a change to assets.viewers.mdl.program can't break assets.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl.deferred uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.mdl.deferred uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.deferred uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.mdl.deferred uses a module listed above it, which is the healthy direction.
13→16 assets.viewers.mdl.deferred uses assets.viewers.layer.scene.ambientpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl.deferred uses a type in assets.viewers.layer.scene.ambient.
assets.viewers.mdl.deferred uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.viewers.layer.scene.ambient.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
13→26 assets.viewers.mdl.deferred uses assets.viewers.avfxpart of a loop✕
Connections
12 pairs of types, where a type in assets.viewers.mdl.deferred uses a type in assets.viewers.avfx.
assets.viewers.mdl.deferred uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
13→27 assets.viewers.mdl.deferred uses assets.viewers.avfx.programpart of a loop✕
Connections
11 pairs of types, where a type in assets.viewers.mdl.deferred uses a type in assets.viewers.avfx.program.
assets.viewers.mdl.deferred uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
13→33 assets.viewers.mdl.deferred uses assetspart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.mdl.deferred uses a type in assets.
assets.viewers.mdl.deferred uses assets, so a change to assets can break assets.viewers.mdl.deferred, while a change to assets.viewers.mdl.deferred can't break assets.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl.export uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.mdl.export, while a change to assets.viewers.mdl.export can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.mdl.export uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.export uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.mdl.export, while a change to assets.viewers.mdl.export can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.mdl.export uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.export uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.mdl.export, while a change to assets.viewers.mdl.export can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.mdl.export uses a module listed above it, which is the healthy direction.
14→27 assets.viewers.mdl.export uses assets.viewers.avfx.programpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.mdl.export uses a type in assets.viewers.avfx.program.
assets.viewers.mdl.export uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.mdl.export, while a change to assets.viewers.mdl.export can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.uld uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.uld, while a change to assets.viewers.uld can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.uld uses a module listed above it, which is the healthy direction.
assets.viewers.uld uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.uld, while a change to assets.viewers.uld can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.uld uses a module listed above it, which is the healthy direction.
15→23 assets.viewers.uld uses assets.viewers.mdlpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.uld uses a type in assets.viewers.mdl.
assets.viewers.uld uses assets.viewers.mdl, so a change to assets.viewers.mdl can break assets.viewers.uld, while a change to assets.viewers.uld can't break assets.viewers.mdl.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→26 assets.viewers.uld uses assets.viewers.avfxpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.uld uses a type in assets.viewers.avfx.
assets.viewers.uld uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.uld, while a change to assets.viewers.uld can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→29 assets.viewers.uld uses backendpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.uld uses a type in backend.
assets.viewers.uld uses assets.deps, so a change to assets.deps can break assets.viewers.uld, while a change to assets.viewers.uld can't break assets.deps.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→33 assets.viewers.uld uses assetspart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.uld uses a type in assets.
assets.viewers.layer.scene.ambient uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.layer.scene.ambient uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.ambient uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.layer.scene.ambient uses a module listed above it, which is the healthy direction.
16→27 assets.viewers.layer.scene.ambient uses assets.viewers.avfx.programpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.layer.scene.ambient uses a type in assets.viewers.avfx.program.
assets.viewers.layer.scene.ambient uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→29 assets.viewers.layer.scene.ambient uses backendpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.layer.scene.ambient uses a type in backend.
assets.viewers.layer.scene.ambient uses backend, so a change to backend can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break backend.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→30 assets.viewers.layer.scene.ambient uses assets.depspart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.layer.scene.ambient uses a type in assets.deps.
assets.viewers.layer.scene.ambient uses assets.deps, so a change to assets.deps can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break assets.deps.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→33 assets.viewers.layer.scene.ambient uses assetspart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.layer.scene.ambient uses a type in assets.
assets.viewers.layer.scene.ambient uses assets, so a change to assets can break assets.viewers.layer.scene.ambient, while a change to assets.viewers.layer.scene.ambient can't break assets.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.shader uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.shader, while a change to assets.viewers.shader can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.shader uses a module listed above it, which is the healthy direction.
17→27 assets.viewers.shader uses assets.viewers.avfx.programpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.shader uses a type in assets.viewers.avfx.program.
assets.viewers.shader uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.shader, while a change to assets.viewers.shader can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl.gpu uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.mdl.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.gpu uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.mdl.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.gpu uses assets.viewers.mdl.export, so a change to assets.viewers.mdl.export can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.mdl.export.
Position
Below the diagonal: assets.viewers.mdl.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.gpu uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.layer.scene.ambient.
Position
Below the diagonal: assets.viewers.mdl.gpu uses a module listed above it, which is the healthy direction.
18→24 assets.viewers.mdl.gpu uses assets.viewers.layer.scene.gpupart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.mdl.gpu uses a type in assets.viewers.layer.scene.gpu.
assets.viewers.mdl.gpu uses assets.viewers.layer.scene.gpu, so a change to assets.viewers.layer.scene.gpu can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.layer.scene.gpu.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→26 assets.viewers.mdl.gpu uses assets.viewers.avfxpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.mdl.gpu uses a type in assets.viewers.avfx.
assets.viewers.mdl.gpu uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→27 assets.viewers.mdl.gpu uses assets.viewers.avfx.programpart of a loop✕
Connections
9 pairs of types, where a type in assets.viewers.mdl.gpu uses a type in assets.viewers.avfx.program.
assets.viewers.mdl.gpu uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.mdl.gpu, while a change to assets.viewers.mdl.gpu can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
utils.tracked_promise uses assets.viewers.mdl.gpu, so a change to assets.viewers.mdl.gpu can break utils.tracked_promise, while a change to utils.tracked_promise can't break assets.viewers.mdl.gpu.
Position
Below the diagonal: utils.tracked_promise uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.layer, so a change to assets.viewers.layer can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.layer.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.layer.scene.ambient.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene uses utils.tracked_promise, so a change to utils.tracked_promise can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break utils.tracked_promise.
Position
Below the diagonal: assets.viewers.layer.scene uses a module listed above it, which is the healthy direction.
20→24 assets.viewers.layer.scene uses assets.viewers.layer.scene.gpupart of a loop✕
Connections
8 pairs of types, where a type in assets.viewers.layer.scene uses a type in assets.viewers.layer.scene.gpu.
assets.viewers.layer.scene uses assets.viewers.layer.scene.gpu, so a change to assets.viewers.layer.scene.gpu can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.layer.scene.gpu.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
20→26 assets.viewers.layer.scene uses assets.viewers.avfxpart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.layer.scene uses a type in assets.viewers.avfx.
assets.viewers.layer.scene uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
20→27 assets.viewers.layer.scene uses assets.viewers.avfx.programpart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.layer.scene uses a type in assets.viewers.avfx.program.
assets.viewers.layer.scene uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
20→29 assets.viewers.layer.scene uses backendpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.layer.scene uses a type in backend.
assets.viewers.layer.scene uses backend, so a change to backend can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break backend.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
20→30 assets.viewers.layer.scene uses assets.depspart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.layer.scene uses a type in assets.deps.
assets.viewers.layer.scene uses assets.deps, so a change to assets.deps can break assets.viewers.layer.scene, while a change to assets.viewers.layer.scene can't break assets.deps.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl.skin uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.skin uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.skin uses sheet.cell, so a change to sheet.cell can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break sheet.cell.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.skin uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.skin uses assets.viewers.shader, so a change to assets.viewers.shader can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.shader.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
assets.viewers.mdl.skin uses assets.viewers.layer.scene, so a change to assets.viewers.layer.scene can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.layer.scene.
Position
Below the diagonal: assets.viewers.mdl.skin uses a module listed above it, which is the healthy direction.
21→28 assets.viewers.mdl.skin uses assets.viewers.cutb.playpart of a loop✕
Connections
3 pairs of types, where a type in assets.viewers.mdl.skin uses a type in assets.viewers.cutb.play.
assets.viewers.mdl.skin uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break assets.viewers.cutb.play.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
21→29 assets.viewers.mdl.skin uses backendpart of a loop✕
Connections
4 pairs of types, where a type in assets.viewers.mdl.skin uses a type in backend.
assets.viewers.mdl.skin uses backend, so a change to backend can break assets.viewers.mdl.skin, while a change to assets.viewers.mdl.skin can't break backend.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
character uses assets.viewers.atch, so a change to assets.viewers.atch can break character, while a change to character can't break assets.viewers.atch.
Position
Below the diagonal: character uses a module listed above it, which is the healthy direction.
character uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break character, while a change to character can't break assets.viewers.avfx.sim.
Position
Below the diagonal: character uses a module listed above it, which is the healthy direction.
character uses utils.tracked_promise, so a change to utils.tracked_promise can break character, while a change to character can't break utils.tracked_promise.
Position
Below the diagonal: character uses a module listed above it, which is the healthy direction.
character uses assets.viewers.mdl.skin, so a change to assets.viewers.mdl.skin can break character, while a change to character can't break assets.viewers.mdl.skin.
Position
Below the diagonal: character uses a module listed above it, which is the healthy direction.
22→23 character uses assets.viewers.mdlpart of a loop✕
Connections
2 pairs of types, where a type in character uses a type in assets.viewers.mdl.
character uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break character, while a change to character can't break assets.viewers.cutb.play.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.mdl uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.layer, so a change to assets.viewers.layer can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.layer.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.layer.scene.ambient.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.mdl.gpu, so a change to assets.viewers.mdl.gpu can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.mdl.gpu.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses utils.tracked_promise, so a change to utils.tracked_promise can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break utils.tracked_promise.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.layer.scene, so a change to assets.viewers.layer.scene can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.layer.scene.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.mdl.skin, so a change to assets.viewers.mdl.skin can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.mdl.skin.
Position
Below the diagonal: assets.viewers.mdl uses a module listed above it, which is the healthy direction.
assets.viewers.mdl uses assets.viewers.layer.scene.gpu, so a change to assets.viewers.layer.scene.gpu can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.layer.scene.gpu.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
23→26 assets.viewers.mdl uses assets.viewers.avfxpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl uses a type in assets.viewers.avfx.
assets.viewers.mdl uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.avfx.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
23→27 assets.viewers.mdl uses assets.viewers.avfx.programpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl uses a type in assets.viewers.avfx.program.
assets.viewers.mdl uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
23→28 assets.viewers.mdl uses assets.viewers.cutb.playpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl uses a type in assets.viewers.cutb.play.
assets.viewers.mdl uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break assets.viewers.mdl, while a change to assets.viewers.mdl can't break assets.viewers.cutb.play.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
23→29 assets.viewers.mdl uses backendpart of a loop✕
Connections
2 pairs of types, where a type in assets.viewers.mdl uses a type in backend.
assets.viewers.layer.scene.gpu uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.mdl.program, so a change to assets.viewers.mdl.program can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.mdl.program.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.mdl.export, so a change to assets.viewers.mdl.export can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.mdl.export.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.layer.scene.ambient, so a change to assets.viewers.layer.scene.ambient can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.layer.scene.ambient.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
assets.viewers.layer.scene.gpu uses assets.viewers.mdl, so a change to assets.viewers.mdl can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.mdl.
Position
Below the diagonal: assets.viewers.layer.scene.gpu uses a module listed above it, which is the healthy direction.
24→27 assets.viewers.layer.scene.gpu uses assets.viewers.avfx.programpart of a loop✕
Connections
11 pairs of types, where a type in assets.viewers.layer.scene.gpu uses a type in assets.viewers.avfx.program.
assets.viewers.layer.scene.gpu uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.layer.scene.gpu, while a change to assets.viewers.layer.scene.gpu can't break assets.viewers.avfx.program.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
character.stand uses assets.viewers.atch, so a change to assets.viewers.atch can break character.stand, while a change to character.stand can't break assets.viewers.atch.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
character.stand uses assets.viewers.layer, so a change to assets.viewers.layer can break character.stand, while a change to character.stand can't break assets.viewers.layer.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
character.stand uses assets.viewers.shader, so a change to assets.viewers.shader can break character.stand, while a change to character.stand can't break assets.viewers.shader.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
character.stand uses utils.tracked_promise, so a change to utils.tracked_promise can break character.stand, while a change to character.stand can't break utils.tracked_promise.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
character.stand uses assets.viewers.layer.scene, so a change to assets.viewers.layer.scene can break character.stand, while a change to character.stand can't break assets.viewers.layer.scene.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
character.stand uses assets.viewers.mdl, so a change to assets.viewers.mdl can break character.stand, while a change to character.stand can't break assets.viewers.mdl.
Position
Below the diagonal: character.stand uses a module listed above it, which is the healthy direction.
assets.viewers.avfx uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.avfx, while a change to assets.viewers.avfx can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.avfx uses a module listed above it, which is the healthy direction.
assets.viewers.avfx uses assets.viewers.cmp, so a change to assets.viewers.cmp can break assets.viewers.avfx, while a change to assets.viewers.avfx can't break assets.viewers.cmp.
Position
Below the diagonal: assets.viewers.avfx uses a module listed above it, which is the healthy direction.
assets.viewers.avfx uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.avfx, while a change to assets.viewers.avfx can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.avfx uses a module listed above it, which is the healthy direction.
assets.viewers.avfx uses assets.viewers.avfx.gpu, so a change to assets.viewers.avfx.gpu can break assets.viewers.avfx, while a change to assets.viewers.avfx can't break assets.viewers.avfx.gpu.
Position
Below the diagonal: assets.viewers.avfx uses a module listed above it, which is the healthy direction.
assets.viewers.avfx uses assets.viewers.layer.scene.gpu, so a change to assets.viewers.layer.scene.gpu can break assets.viewers.avfx, while a change to assets.viewers.avfx can't break assets.viewers.layer.scene.gpu.
Position
Below the diagonal: assets.viewers.avfx uses a module listed above it, which is the healthy direction.
26→29 assets.viewers.avfx uses backendpart of a loop✕
Connections
4 pairs of types, where a type in assets.viewers.avfx uses a type in backend.
assets.viewers.avfx.program uses assets.viewers.mdl.deferred, so a change to assets.viewers.mdl.deferred can break assets.viewers.avfx.program, while a change to assets.viewers.avfx.program can't break assets.viewers.mdl.deferred.
Position
Below the diagonal: assets.viewers.avfx.program uses a module listed above it, which is the healthy direction.
assets.viewers.avfx.program uses assets.viewers.avfx, so a change to assets.viewers.avfx can break assets.viewers.avfx.program, while a change to assets.viewers.avfx.program can't break assets.viewers.avfx.
Position
Below the diagonal: assets.viewers.avfx.program uses a module listed above it, which is the healthy direction.
27→33 assets.viewers.avfx.program uses assetspart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.avfx.program uses a type in assets.
assets.viewers.avfx.program uses assets, so a change to assets can break assets.viewers.avfx.program, while a change to assets.viewers.avfx.program can't break assets.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
assets.viewers.cutb.play uses assets.viewers.avfx.sim, so a change to assets.viewers.avfx.sim can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break assets.viewers.avfx.sim.
Position
Below the diagonal: assets.viewers.cutb.play uses a module listed above it, which is the healthy direction.
assets.viewers.cutb.play uses assets.viewers.layer.scene, so a change to assets.viewers.layer.scene can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break assets.viewers.layer.scene.
Position
Below the diagonal: assets.viewers.cutb.play uses a module listed above it, which is the healthy direction.
assets.viewers.cutb.play uses assets.viewers.mdl, so a change to assets.viewers.mdl can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break assets.viewers.mdl.
Position
Below the diagonal: assets.viewers.cutb.play uses a module listed above it, which is the healthy direction.
assets.viewers.cutb.play uses character.stand, so a change to character.stand can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break character.stand.
Position
Below the diagonal: assets.viewers.cutb.play uses a module listed above it, which is the healthy direction.
assets.viewers.cutb.play uses assets.viewers.avfx.program, so a change to assets.viewers.avfx.program can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break assets.viewers.avfx.program.
Position
Below the diagonal: assets.viewers.cutb.play uses a module listed above it, which is the healthy direction.
28→29 assets.viewers.cutb.play uses backendpart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.cutb.play uses a type in backend.
assets.viewers.cutb.play uses backend, so a change to backend can break assets.viewers.cutb.play, while a change to assets.viewers.cutb.play can't break backend.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
28→40 assets.viewers.cutb.play uses apppart of a loop✕
Connections
1 pair of types, where a type in assets.viewers.cutb.play uses a type in app.
backend uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break backend, while a change to backend can't break assets.viewers.cutb.play.
Position
Below the diagonal: backend uses a module listed above it, which is the healthy direction.
assets.viewers.pap uses assets.viewers.atch, so a change to assets.viewers.atch can break assets.viewers.pap, while a change to assets.viewers.pap can't break assets.viewers.atch.
Position
Below the diagonal: assets.viewers.pap uses a module listed above it, which is the healthy direction.
assets.viewers.pap uses assets.viewers.layer, so a change to assets.viewers.layer can break assets.viewers.pap, while a change to assets.viewers.pap can't break assets.viewers.layer.
Position
Below the diagonal: assets.viewers.pap uses a module listed above it, which is the healthy direction.
assets.viewers.pap uses assets.viewers.shader, so a change to assets.viewers.shader can break assets.viewers.pap, while a change to assets.viewers.pap can't break assets.viewers.shader.
Position
Below the diagonal: assets.viewers.pap uses a module listed above it, which is the healthy direction.
assets.viewers.pap uses assets.viewers.mdl.skin, so a change to assets.viewers.mdl.skin can break assets.viewers.pap, while a change to assets.viewers.pap can't break assets.viewers.mdl.skin.
Position
Below the diagonal: assets.viewers.pap uses a module listed above it, which is the healthy direction.
music uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break music, while a change to music can't break assets.viewers.cutb.play.
Position
Below the diagonal: music uses a module listed above it, which is the healthy direction.
quests.index uses sheet.table_context, so a change to sheet.table_context can break quests.index, while a change to quests.index can't break sheet.table_context.
Position
Below the diagonal: quests.index uses a module listed above it, which is the healthy direction.
quests.detail uses assets.viewers.layer, so a change to assets.viewers.layer can break quests.detail, while a change to quests.detail can't break assets.viewers.layer.
Position
Below the diagonal: quests.detail uses a module listed above it, which is the healthy direction.
quests uses assets.viewers.cutb.play, so a change to assets.viewers.cutb.play can break quests, while a change to quests can't break assets.viewers.cutb.play.
Position
Below the diagonal: quests uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2025 — Software Supply Chain Failures
47
High / Critical
A05:2025 — Injection
15
High / Critical
A02:2025 — Security Misconfiguration
3
High / Critical
Roadmap
Top priorities: Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video; Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1; Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
TypeScript/JavaScript: use the promise APIs (fs/promises, a promisified child_process.execFile, the async zlib/crypto functions) and await them instead of the *Sync variants.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 17
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 925
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 56
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 8
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 65 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 65 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 955 of 998 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the Rust half could not be measured — the Cargo suite in repository root did not build, so it was never run. Coverage is excluded from the score rather than counted as a near-zero. This is OUR limitation, not a defect in the repo.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.rs) and this repository declares a Cargo test suite (repository root, 76 test files), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (4 contributor(s) across 1573 commit(s) sampled, automation and bot accounts excluded). One of them holds 100% of the history; the other 3 hold 0% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated per language (docs/plans/deterministic-engine.md, P5; C# and each NeutralApiArms arm pass): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
D27 Navigability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D44 Platform End-of-Life — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a REDACTED) is simply not read here yet.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via ToolchainServer (web). the service did not build — `cargo build --locked --bin 'web'` exited 101: error: failed to load source for dependency `dxbc`
Caused by:
unable to update deps/d3dasm/crates/dxbc
Caused by:
failed to read `/tmp/codehe…; runtime evidence skipped (launch chosen because 'actix-web' dependency in web/Cargo.toml, binary 'web').
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
PF3 Async & latency hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 18 further occurrence(s) are not listed individually; the score already reflects all 58.
X17 Uncapped recursion over a caller-supplied document — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 21 further occurrence(s) are not listed individually; the score already reflects all 61.
X3 Exception handling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
X5 Nullable reference types — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 132 further occurrence(s) are not listed individually; the score already reflects all 172.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
105 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was Buffer::fill at 93. A further 13 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being viewer::assets::viewers::tmb::described at 86 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold functions was excluded, so the exclusion is disclosed nowhere in the file itself: viewer/src/assets/viewers/tmb.rs (viewer::assets::viewers::tmb::described at 86), viewer/src/utils/tex_loader.rs (viewer::utils::tex_loader::decode_stack at 25), viewer/src/utils/tex_export.rs (viewer::utils::tex_export::dxgi_format at 24), luadec/src/asm.rs (luadec::asm::operands at 17), viewer/src/sheet/filter/complex_filter_parse.rs (viewer::sheet::filter::complex_filter_parse::parse_comparator at 17). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 45 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 6 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with Buffer::fill (cyclomatic 93), CharacterBuilder::poll (cyclomatic 81), Rendered::poll (cyclomatic 71). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cyclomatic Complexity from 5.6 to about 6.2/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 61 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 120 down to 120 or less in Cognitive Complexity — start with SetupWindow::draw (cognitive 174), Renderer::render (cognitive 123), Rendered::poll (cognitive 123). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 2.8 to about 3.6/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes7.9 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 44 MethodTooLong finding(s) in God Classes — start with mod.rs (19), app.rs (3), deferred.rs (3). — One of this dimension's main actionable groups (44 warning-level).
Resolve the 30 FileTooLong finding(s) in God Classes — start with mod.rs (9), gpu.rs (2), deferred.rs. — One of this dimension's main actionable groups (30 warning-level).
Resolve the 21 FunctionTooLong finding(s) in God Classes — start with mod.rs (4), merge.rs (2), main.rs (2). — One of this dimension's main actionable groups (21 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
165 duplicated block group(s) detected. 5.2 % of the production lines (5,706 of 109,021) are in a reported copy. A further 81 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
+ 106 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 15 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with mod.rs (5), program.rs (3), sound.rs (2). — One of this dimension's main actionable groups (15 warning-level).
Resolve the 14 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with mod.rs (3), program.rs (2), pcb.rs (2). — One of this dimension's main actionable groups (14 warning-level).
Resolve the 11 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with deferred.rs (3), mod.rs (2), gpu.rs (2). — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling8.0 / 10Strong✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
8 production modules (Cargo), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 2 module(s) off the main sequence, with abstractness counted on 6 of the 8 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Off the main sequence: luadec · ×2
What to do
Resolve the 2 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
30 outdated, 0 yanked direct Cargo dependencies. 93 of 98 direct crates were graded against crates.io (0 not published there, 5 not resolved by a committed REDACTED). Only DIRECT edges are graded: a transitive crate cannot be moved past what its parent's requirement admits, so reporting one would be advice its owner cannot take. A newer release is reported only where this repository's OWN requirement already admits it, so the remedy is `cargo update` and never a manifest edit — which means a release outside the declared range is deliberately NOT charged, because a written-down constraint is a decision rather than a defect. Note that a bare requirement is a CARET, and for a 0.x crate its ceiling is the minor. Whether any crate is UNMAINTAINED is not graded — crates.io publishes no maintenance status, and release age does not stand in for one. Known CVEs in this dependency graph are D30's question, read from REDACTED there.
Outdated: actix-cors · ×30
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 830 shipped crate(s) use a banned license. Licences were resolved from crates.io over the crates a consumer compiles — this repository's REDACTED closed over its manifests' `[dependencies]` and `[build-dependencies]`. Crates it asks for ONLY under `[dev-dependencies]` are excluded: they are not compiled by anything that depends on this repository. A further 1 crate(s) in the closure resolve from git, a path or a private registry and publish no licence this pass can read; they are outside this verdict.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 30 Hotspot finding(s) in Churn × Complexity Hotspots — start with mod.rs (7), gpu.rs (2), program.rs. — One of this dimension's main actionable groups (30 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
3 deducted task-comment markers across 109021 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 3 TodoComment finding(s) in Explicit Debt — start with tex_loader.rs (3). — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 2 document(s) read across 1 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
1 of 9 build units (Cargo) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesionviewer/Cargo.toml:1
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with Cargo.toml. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
15 finding(s): 0 critical, 14 high, 1 medium, 0 low. 13 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 2 file(s) — `smoke/native.sh` (line 49), `viewer/src/assets/viewers/mdl/mod.rs` (line 782) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
No action in Static Analysis (SAST) — all 13 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (13 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
Resolve the 16 Medium advisory (unsound) finding(s) in Dependency Vulnerabilities — start with REDACTED (16). — One of this dimension's main actionable groups (16 warning-level).
Resolve the 11 Medium vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED (11). — One of this dimension's main actionable groups (11 warning-level).
Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 1 High IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 221 of the 265 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 1 Change-coupling hub finding(s) in Change Coupling — start with sqpack.rs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Change coupling finding(s) in Change Coupling — start with web.rs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
No dependency in any ecosystem this repository declares is published as malicious.
✓ On the Gold path — maintain.
Detailed fixes: d43_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives1.0 / 10Critical✓ Tool-verified
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content. — viewer/index.html:284
What to do
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Do you agree with this assessment?
AC3 · Page structure4.8 / 10Weak✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta. — viewer/index.html:40
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`.spinner` moves (`animation: rotator 1.4s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — viewer/index.html:221
`.path` moves (`animation: dash 1.4s ease-in-out infinite, colors 5.6s ease-in-out infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — viewer/index.html:238
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.
Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.
Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.
Other · Code Health — Unreviewed-generation residue in this repository's Rust: functions whose whole body is still `todo!()`/`unimplemented!()` or only panics with a "not implemented" message, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Rust: functions whose body is `todo!()`/`unimplemented!()` or only panics with a "not implemented" message, match arms and branches left as `todo!()`, functions that take inputs and return a constant (`Ok(())`, `None`, `Default::default()`, an empty `Vec`) or do nothing, and impls most of whose methods are holes.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`on_auth_callback` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — viewer/src/app.rs:1510
`set_metadata` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — viewer/src/audio/native.rs:107
`set_icons` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — viewer/src/backend.rs:137
`forget` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — viewer/src/utils/icon_loader.rs:95
What to do
Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Do you agree with this assessment?
P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
What to do
Run the test suite in CI via an explicit runner step for your stack, and gate merges on it.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
Do you agree with this assessment?
P2 · Observability7.2 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 2/5 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `framediff`, `luadec`.
What to do
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
Add a health-check endpoint (a /health route on your axum/actix router) so orchestrators and load balancers can probe liveness/readiness.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
`framediff/Cargo.toml` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — framediff/Cargo.toml:9
What to do
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release. — REDACTED:52
What to do
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`ureq::Agent::config_builder(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — viewer/src/utils/webreq.rs:163
`reqwest::Client::builder(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — web/src/data.rs:55
`reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×5) — web/src/paths/mod.rs:154, web/src/paths/report.rs:106, web/src/routes/api.rs:683, …
What to do
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
`existsSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×5) — smoke/burst.ts:67, smoke/drive.ts:66, smoke/frame.ts:99, …
`readFileSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×5) — smoke/burst.ts:69, smoke/drive.ts:68, smoke/frame.ts:101, …
`existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×2) — smoke/burst.ts:88, smoke/frame.ts:145
`mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×4) — smoke/burst.ts:89, smoke/drive.ts:146, smoke/frame.ts:137, …
`mkdtempSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×5) — smoke/burst.ts:92, smoke/drive.ts:117, smoke/frame.ts:163, …
`readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×3) — smoke/burst.ts:128, smoke/drive.ts:153, smoke/frame.ts:159
`writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×5) — smoke/burst.ts:152, smoke/burst.ts:153, smoke/frame.ts:206, …
`rmSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×5) — smoke/burst.ts:164, smoke/drive.ts:182, smoke/frame.ts:213, …
`writeFileSync` in `shot` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×2) — smoke/drive.ts:110, smoke/probe.ts:120
`statSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — smoke/frame.ts:148
`Bun.spawnSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — smoke/frame.ts:219
`existsSync` in `waitFor("chromium's debugging port")` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — smoke/probe.ts:95
`mkdirSync` in `shot` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — smoke/probe.ts:119
What to do
TypeScript/JavaScript: use the promise APIs (fs/promises, a promisified child_process.execFile, the async zlib/crypto functions) and await them instead of the *Sync variants.
Do you agree with this assessment?
R1 · Type Safety9.2 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
React / JS · Code Health — The share of the scored frontend lines inside a near-exact copy-pasted block of substantial extent (the D4 clone algorithm over JS/TS tokens, D-386; each line once, 10 at none and 0 at a quarter of the lines, as D4): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Scored on the share of the scored frontend lines inside a reported copy, on the same curve as D4. Deterministic.
smoke/look.ts:7 · smoke/net.ts:7 — these 2 files are line-for-line copies of one another — 114 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — smoke/look.ts:7
smoke/glow.ts:34 · smoke/quests.ts:36 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — smoke/glow.ts:34
smoke/drive.ts:25 · smoke/glow.ts:26 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — smoke/drive.ts:25
smoke/perf.ts:12 · smoke/probe.ts:14 — the two spans are one implementation copied and then locally edited — 380 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — smoke/perf.ts:12
smoke/probe.ts:48 · smoke/smoke.ts:205 — the two spans are one implementation copied and then locally edited — 362 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — smoke/probe.ts:48
smoke/burst.ts:37 · smoke/drive.ts:36 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — smoke/burst.ts:37
smoke/net.ts:102 · smoke/perf.ts:187 — the two spans are one implementation copied and then locally edited — 418 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — smoke/net.ts:102
smoke/drive.ts:111 · smoke/quests.ts:77 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — smoke/drive.ts:111
smoke/frame.ts:85 · smoke/perf.ts:76 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — smoke/frame.ts:85
smoke/burst.ts:130 · smoke/net.ts:153 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — smoke/burst.ts:130
smoke/quests.ts:33 · smoke/smoke.ts:221 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — smoke/quests.ts:33
smoke/burst.ts:90 · smoke/drive.ts:115 · smoke/glow.ts:79 · smoke/quests.ts:81 — the 4 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — smoke/burst.ts:90
smoke/burst.ts:105 · smoke/frame.ts:177 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — smoke/burst.ts:105
smoke/burst.ts:14 · smoke/drive.ts:13 · smoke/frame.ts:21 · smoke/glow.ts:14 · +5 more site(s) not listed — the 9 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 9 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — smoke/burst.ts:14
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
main has cyclomatic complexity 23 and cognitive complexity 49; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/perf.ts:95
decodePng has cyclomatic complexity 23 and cognitive complexity 36; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/smoke.ts:301
main has cyclomatic complexity 22 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/smoke.ts:566
main has cyclomatic complexity 15 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/drive.ts:114
main has cyclomatic complexity 15 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/frame.ts:134
main has cyclomatic complexity 14 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/probe.ts:130
main has cyclomatic complexity 14 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/burst.ts:87
main has cyclomatic complexity 12 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/look.ts:60
record has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — smoke/smoke.ts:177
Do you agree with this assessment?
R3 · Large Files6.7 / 10Adequate✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
smoke/smoke.ts has 981 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — smoke/smoke.ts:1
What to do
Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
Do you agree with this assessment?
R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
This top-level declaration is not exported and its name occurs nowhere else in its module — not called, read, typed against, re-exported or named by a string. Nothing outside the module can reach a non-exported binding, so this is the whole search: remove it, or use it. — smoke/frame.ts:104
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Read from this repository's Rust source: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository serves HTTP itself (`HttpServer::new(` (web/src/main.rs:100)), so its Rust source was also read for the server controls: TLS served or HSTS set, security response headers, cookie flags and inbound validation — each credited where its Rust spelling appears in production source, not proven on every route. A Rocket 0.5 application is credited the headers Rocket's default `Shield` sends unless it attaches its own, and its cookie jar's SameSite=Strict default; a session middleware its default cookie flags.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
This repository starts an HTTP server and nothing in its Rust source or committed `Rocket.toml` secures the transport: no TLS served (actix-web `bind_rustls`/`bind_openssl`, axum-server `bind_rustls` with a `RustlsConfig`, tonic `ServerTlsConfig`, a `TlsAcceptor`, Rocket's `[default.tls]`), no `Strict-Transport-Security` header, no `X-Forwarded-Proto` read from a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: `HttpServer::new(` (web/src/main.rs:100).
Set: Content-Security-Policy, Referrer-Policy, X-Content-Type-Options, X-Frame-Options. Missing: Strict-Transport-Security — the four headers that carry the points of this card's security-headers term (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options), 0.5 each.(−0.5 on this card.) The server: `HttpServer::new(` (web/src/main.rs:100).
What to do
Secure the server's transport: serve TLS itself (`HttpServer::bind_rustls_0_23(addr, config)` in actix-web, `axum_server::bind_rustls(addr, RustlsConfig::from_pem_file(…))`, tonic's `Server::builder().tls_config(ServerTlsConfig::new().identity(…))`, Rocket's `[default.tls]`), or run it behind a TLS-terminating proxy and check `X-Forwarded-Proto`; send `Strict-Transport-Security` once it is HTTPS-only.
Add Strict-Transport-Security beside the headers the Rust server already sets.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document1.2 / 10Critical✓ Tool-verified
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
`coerce_integer` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 101 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `coerce_integer` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:101
`coerce_string` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 134 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `coerce_string` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:134
`is_empty` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 144 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `is_empty` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:144
`read` is public and takes a `Cell` as its receiver from its caller, and it recurses at line 381 through `read_internal_link` and back with a piece of the document (and at line 323, line 401) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `read` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:381
`show` is public and takes a `Cell` as its receiver from its caller, and it recurses at line 284 through `draw` and back with a piece of the document (and at line 168, line 514) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `show` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:284
`size` is public, takes a document from its caller (line 266) and hands it to `size_internal`, which recurses at line 238 through `size_internal_link` and back with a piece of the document (and at line 205, line 262) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `size_internal` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/cell.rs:238
`has_fuzzy` is public and takes a `ComplexFilter` as its receiver from its caller, and it calls itself at line 26 with a piece of the document (and at line 27) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `has_fuzzy` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/sheet/filter/complex_filter.rs:26
`replace` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 62 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `replace` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/router/mod.rs:62
`back` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 66 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `back` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/router/mod.rs:66
`forward` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 70 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `forward` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/router/mod.rs:70
`base_url` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 74 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `base_url` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/router/mod.rs:74
`lines` is public, takes a document from its caller (line 28) and hands it to `count`, which calls itself at line 44 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `count` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/quests/script.rs:44
`poll` is public and takes a `Cast` as its receiver from its caller, and it calls itself at line 379 with a piece of the document (and at line 515) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `poll` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/character/stand.rs:379
`set_volume` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 102 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `set_volume` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/native.rs:102
`pause` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 83 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `pause` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/native.rs:83
`retain` is public and takes a `Mixer` as its receiver from its caller, and it calls itself at line 188 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `retain` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/native.rs:188
`pause` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 282 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `pause` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/web.rs:282
`stop` is public and takes a `Player` as its receiver from its caller, and it recurses at line 304 through `discard_source` and back with a piece of the document (and at line 197) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `stop` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/web.rs:304
`play` is public and takes a `Player` as its receiver from its caller, and it recurses at line 170 through `resume` and back with a piece of the document (and at line 173, line 294, line 296) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `play` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/web.rs:170
`retain` is public and takes a `Mixer` as its receiver from its caller, and it calls itself at line 684 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `retain` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/audio/web.rs:684
`replace` is public and takes a `View` as its receiver from its caller, and it calls itself at line 99 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `replace` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/placed/mod.rs:99
`active_props` is public and takes a `Cue` as its receiver from its caller, and it calls itself at line 580 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `active_props` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/emote.rs:580
`joints` is public and takes a `Cue` as its receiver from its caller, and it calls itself at line 593 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `joints` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/emote.rs:593
`attachments` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 321 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `attachments` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/gpu.rs:321
`attachments_learned` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 326 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `attachments_learned` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/gpu.rs:326
`seed_attachments` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 332 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `seed_attachments` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/gpu.rs:332
`fill` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 431 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `fill` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/gpu.rs:431
`draw` is public and takes a `Model` as its receiver from its caller, and it recurses at line 483 through `ground` and back with a piece of the document (and at line 487, line 609, line 618, line 645) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `draw` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/gpu.rs:483
`anisotropic` is public and takes a `Material` as its receiver from its caller, and it calls itself at line 223 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `anisotropic` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/material.rs:223
`poll` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 1680 with a piece of the document (and at line 1683, line 1686, line 1696) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `poll` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:1680
`hinged` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3476 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `hinged` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3476
`seated` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3481 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `seated` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3481
`play` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3509 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `play` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3509
`play_over` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3515 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `play_over` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3515
`blending` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3520 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `blending` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3520
`stand` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3535 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `stand` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3535
`act` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3541 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `act` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3541
`plays_at` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3548 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `plays_at` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3548
`standing` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3553 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `standing` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3553
`acting` is public and takes a `Rendered` as its receiver from its caller, and it calls itself at line 3558 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `acting` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — viewer/src/assets/viewers/mdl/mod.rs:3558
What to do
Each finding names the externally-callable member that accepts the document and the self-call that descends, and states that no depth parameter or counter exists anywhere in the walk. Confirm from the two, then thread a depth argument through the walk and reject documents past a fixed maximum, or rewrite it with an explicit stack.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 0/2 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
`page` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — smoke/smoke.ts:268
`proxyFetches` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — smoke/smoke.ts:526
What to do
Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
`UiColor.expansion` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:78
`UiColor.highlight_color` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:81
`Mount.last_location_mount` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:87
`Mount.mount_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:88
`Mount.buddy_model_top` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:89
`Mount.buddy_model_body` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:90
`Mount.buddy_model_legs` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:91
`Mount.buddy_stain` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:92
`Location.location_type` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:117
`Location.title_screen_logo` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:118
`Location.territory_type_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:120
`Location.layout_territory_type_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:121
`Location.layout_layer_filter_key` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:122
`Location.bgm_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:132
`Location.bgm_path` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:133
`Location.movement_mode` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:134
`Location.vfx_trigger_indexes` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:138
`Location.save_layout` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:140
`Location.use_vfx` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:141
`Location.save_housing` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:142
`Location.save_festivals` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:143
`Location.title_screen_override` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:144
`Location.ui_color` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:145
`Location.title_screen_movie` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:146
`Location.use_live_time` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:147
`Location.furniture` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:148
`Location.plots` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:149
`Location.estate` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/assets/viewers/layer/scene/preset.rs:150
`Schema.relations` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/schema/format.rs:20
`Field.relations` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/schema/format.rs:38
`GithubCommit.sha` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/schema/web.rs:21
`GithubBranch.protected` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing. — viewer/src/schema/web.rs:29
What to do
Each finding names the spans that disagree — the knob the caller supplies and the site that ignores it, whether by re-spelling its default, by falling back under the wrong key, by parsing with no format provider at all, or by printing under whatever culture the host supplies. Confirm from those spans, then decide which of the two the type meant: read the knob at the named site, or drop the knob so the signature stops advertising something the type cannot feel. Leaving both is the one option that cannot be right.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `for` loop leaves the `RefCell` it is walking alone — safe Rust rejects a body that changes the collection its loop borrows at compile time, except through interior mutability: a `RefCell` borrowed in the loop's header stays borrowed until the loop ends, so a `borrow_mut()` of it inside the body panics with `already borrowed: BorrowMutError` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether Rust's absent values are handled rather than forced — `Option` and `Result` make absence a value the caller must handle in every crate, and each `.unwrap()` or `.expect()` that no guard on its path proves present is a panic the first time the value is `None` or `Err`.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
`ShadowBuilder::builder().build()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). (×2) — web/build.rs:10, viewer/build.rs:10
`std::env::var("PROFILE")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:32
`command.spawn()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:40
`child.wait_with_output()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:41
`std::env::var("TARGET")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:54
`std::env::var("OUT_DIR")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:55
`std::env::var("PROFILE")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:56
`target_dir.to_str()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/build.rs:78
`Config::builder().add_source(File::new("config",FileFormat::Yaml).required(false)).add_source(Environment::default()).build().and_then(Config::try_deserialize)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/main.rs:62
`e.downcast::<prometheus::Error>()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). (×2) — web/src/main.rs:90, web/src/main.rs:144
`Helmet::new().add(XContentTypeOptions::nosniff()).into_middleware()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/main.rs:106
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `repositories` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:212
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `exists` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:234
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_list_id` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:253
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_global_paths` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:270
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_presence` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:292
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_file` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:314
`` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_file_by_hash` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/queue.rs:340
`self.inner.seek_relative(relative_pos).map(|_|current_pos.checked_add_signed(relative_pos))?` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `seek` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — web/src/smart_bufreader.rs:67
`std::env::var("CARGO_CFG_TARGET_OS")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/build.rs:4
`res.compile()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/build.rs:7
`create_router(ctx.clone())` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:413
`self.router.get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:415
`self.router.clone().get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_router` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:446
`self.router.get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `navigate` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:474
`self.router.get().unwrap().navigate(path)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `navigate` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:474
`self.router.get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `navigate_replace` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:478
`self.router.get().unwrap().replace(path)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `navigate_replace` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:478
`NonZero::new(e.get()as u16)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_menubar` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:693
`NonZero::new(e.get()as u8)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_menubar` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:698
`self.changed_schemas.as_mut()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `poll_changed_schemas` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:906
`self.backend.clone()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_sheet_list` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1049
`self.backend.as_ref()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_sheet_data` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1129
`SELECTED_SHEET.get(ctx)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_sheet_data` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1130
`self.router.get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_sheet_data` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1469
`self.setup_window.as_mut()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw_setup` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1484
`self.backend.as_ref()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `command_save_all_schemas` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1848
`NonZero::new(32)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `new` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`). — viewer/src/app.rs:1919
What to do
Each row is a forced `Option`/`Result` no guard on its path proves present. Handle the absent case where it arises rather than forcing it: `?` to hand it to the caller, `if let` / `match` / `let … else` to branch on it, `unwrap_or` / `unwrap_or_default` / `unwrap_or_else` where a default is right. Where the value genuinely cannot be absent, say so in a way a reader can check from the line: test it first (`if x.is_none() { return … }`), look the key up with `contains_key` or the index against `len()`, or construct the value so it cannot be absent.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 11 of 55 WCAG 2.2 Level A/AA success criteria (20%; ≈22% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 44 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 6 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 6 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 60 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC2 Forms & labels — No form control/button found in the parsed markup — AC2 not applicable here.
AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
AC5 ARIA correctness — No ARIA usage found in the parsed markup — AC5 not applicable here.
AX1 Captive dependencies — Not applicable: this repository's JavaScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Python imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; Rust with no dependency-injection crate has no container to hand one lifetime's instance to another — every value is owned by the code that builds it, and the borrow checker rejects a longer-lived value keeping a borrow of a shorter-lived one; this repository's TypeScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. Rust's compiler refuses unsynchronised shared mutation — a value shared across threads must be Sync — so the race this check looks for cannot be written. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — no exported interface declares behaviour
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — the service did not build — `cargo build --locked --bin 'web'` exited 101: error: failed to load source for dependency `dxbc`
Caused by:
unable to update deps/d3dasm/crates/dxbc
Caused by:
failed to read `/tmp/codehe…; runtime evidence skipped (launch chosen because 'actix-web' dependency in web/Cargo.toml, binary 'web') This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no data at rest for these controls to protect.
C2 Access Controls — No access-control surface detected in the analyzed source — this repository starts no server another machine can reach (no actix-web HttpServer, axum::serve, Rocket launch, warp::serve, poem or salvo Server, tonic Server::builder, hyper or tiny_http server outside examples and tests, none bound beyond loopback). Access control is therefore N/A here — a crate is authorized by the application that serves it, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D10 Test Quality — ~19493 lines of test source are present (.rs) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .rs suite was found but not re-run
D16 Bus Factor — single-maintainer repository — bus factor is not applicable
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D21 Naming Consistency — N/A — too few peers to establish a naming convention (13002 declarations, no unit with a dominant convention).
D22 Internal API Consistency — API consistency is measured on C#, TypeScript, Go only; the exposed Rust surface was not measured.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.rs), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not measured — Rust suite
DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (46 value object(s))
ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and a call made through an inferred or generic receiver has no resolvable owner in the source. Reported as guidance rather than measured
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `#[bench]`, criterion's `bench_function`/`bench_with_input`, `#[divan::bench]` or `#[library_benchmark]` in any `.rs` file, or criterion, divan, iai or a `[[bench]]` target in a Cargo.toml, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R4 Test Coverage — the JS/TS workspace (12 production file(s)) has no JavaScript/TypeScript test, but it is 2.63% of this repository's production source and the other 97.37% carries 19,493 line(s) of test code this pass cannot read — an incidental frontend's reachability is not the repository's test posture, so it is not scored as one
R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
R8 Dependency Hygiene — Not measured — no package.json declares any dependency, so there is nothing to check imports against (imports may resolve through a host runtime rather than node).
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X3 Exception handling — X3 reached only 3% of this repository's production lines — rust (105,953 lines), c (39 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Rust was read, and it logs through none: the `log` crate's macros take one finished message (as log4net does in C#; its `kv` values are an opt-in its backends mostly drop), `println!`/`eprintln!` are not loggers, or it makes no log call outside its tests and examples at all. Calls through `tracing` (`tracing::info!`, or `info!` imported from it) would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Viewport restricts zoom viewer/index.html:40— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
viewer::assets::viewers::mdl::export::gather (cognitive 96) viewer/src/assets/viewers/mdl/export.rs:89— viewer::assets::viewers::mdl::export::gather has cognitive complexity 96 (threshold 15). Drivers by points: if/else 19 (61 pts), loops 9 (26 pts), match/switch 3 (7 pts), boolean chains 2 (nesting depth added 63). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::shpk::keys::read (cognitive 60) viewer/src/assets/viewers/shpk/keys.rs:72— viewer::assets::viewers::shpk::keys::read has cognitive complexity 60 (threshold 15). Drivers by points: loops 18 (29 pts), if/else 7 (24 pts), match/switch 2 (6 pts), boolean chains 1 (nesting depth added 32). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
viewer::assets::viewers::mdl::read_level (cognitive 54) viewer/src/assets/viewers/mdl/mod.rs:822— viewer::assets::viewers::mdl::read_level has cognitive complexity 54 (threshold 15). Drivers by points: if/else 10 (23 pts), match/switch 5 (15 pts), loops 5 (13 pts), boolean chains 3 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::character::appearance (cognitive 54) viewer/src/character/mod.rs:2970— viewer::character::appearance has cognitive complexity 54 (threshold 15). Drivers by points: if/else 15 (34 pts), match/switch 3 (11 pts), boolean chains 5, loops 2 (4 pts) (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::uld::canvas (cognitive 53) viewer/src/assets/viewers/uld.rs:867— viewer::assets::viewers::uld::canvas has cognitive complexity 53 (threshold 15). Drivers by points: if/else 13 (29 pts), loops 6 (12 pts), match/switch 5 (8 pts), boolean chains 4 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::layer::ui (cognitive 50) viewer/src/assets/viewers/layer/mod.rs:844— viewer::assets::viewers::layer::ui has cognitive complexity 50 (threshold 15). Drivers by points: if/else 17 (26 pts), match/switch 5 (11 pts), loops 5 (8 pts), boolean chains 5 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::shpk::list::ui (cognitive 42) viewer/src/assets/viewers/shpk/list.rs:56— viewer::assets::viewers::shpk::list::ui has cognitive complexity 42 (threshold 15). Drivers by points: if/else 14 (23 pts), loops 6 (11 pts), match/switch 4 (5 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::quests::rewards::ui (cognitive 39) viewer/src/quests/rewards.rs:264— viewer::quests::rewards::ui has cognitive complexity 39 (threshold 15). Drivers by points: if/else 17 (27 pts), loops 5 (9 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::mdl::ui (cognitive 38) viewer/src/assets/viewers/mdl/mod.rs:1328— viewer::assets::viewers::mdl::ui has cognitive complexity 38 (threshold 15). Drivers by points: if/else 19 (27 pts), match/switch 2 (5 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::uld::tree (cognitive 38) viewer/src/assets/viewers/uld.rs:1227— viewer::assets::viewers::uld::tree has cognitive complexity 38 (threshold 15). Drivers by points: match/switch 9 (21 pts), if/else 5 (10 pts), boolean chains 4, loops 2 (3 pts) (nesting depth added 18). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
viewer::assets::viewers::zone::envs::ui (cognitive 38) viewer/src/assets/viewers/zone/envs.rs:197— viewer::assets::viewers::zone::envs::ui has cognitive complexity 38 (threshold 15). Drivers by points: if/else 11 (23 pts), match/switch 4 (9 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::character::menus::pieces (cognitive 36) viewer/src/character/menus.rs:297— viewer::character::menus::pieces has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 7 (9 pts), match/switch 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::quests::dag::ui (cognitive 36) viewer/src/quests/dag.rs:11— viewer::quests::dag::ui has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (17 pts), match/switch 2 (7 pts), boolean chains 6, loops 4 (6 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::hex_dump (cognitive 31) viewer/src/assets/mod.rs:2763— viewer::assets::hex_dump has cognitive complexity 31 (threshold 15). Drivers by points: if/else 12 (21 pts), boolean chains 4, loops 2 (3 pts), match/switch 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::cutb::play::ui (cognitive 31) viewer/src/assets/viewers/cutb/play.rs:1269— viewer::assets::viewers::cutb::play::ui has cognitive complexity 31 (threshold 15). Drivers by points: if/else 16 (21 pts), match/switch 4 (7 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
viewer::assets::viewers::layer::payload (cognitive 29) viewer/src/assets/viewers/layer/mod.rs:382— viewer::assets::viewers::layer::payload has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (22 pts), match/switch 4 (7 pts) (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
viewer::assets::viewers::cutb::play::perform (cognitive 28) viewer/src/assets/viewers/cutb/play.rs:1496— viewer::assets::viewers::cutb::play::perform has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (21 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::quests::cutscenes::load (cognitive 27) viewer/src/quests/cutscenes.rs:60— viewer::quests::cutscenes::load has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 5 (8 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::avfx::tree_ui (cognitive 26) viewer/src/assets/viewers/avfx/mod.rs:809— viewer::assets::viewers::avfx::tree_ui has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (14 pts), match/switch 3 (7 pts), boolean chains 3, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::avfx::sim::shading (cognitive 25) viewer/src/assets/viewers/avfx/sim.rs:704— viewer::assets::viewers::avfx::sim::shading has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (12 pts), match/switch 5 (7 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::icons::refs::walk_sheet (cognitive 24) viewer/src/icons/refs.rs:166— viewer::icons::refs::walk_sheet has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::icons::refs::walk (cognitive 24) viewer/src/icons/refs.rs:230— viewer::icons::refs::walk has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (5 pts), match/switch 2 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::material::ui (cognitive 23) viewer/src/assets/viewers/material.rs:202— viewer::assets::viewers::material::ui has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 4 (9 pts), match/switch 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::mdl::export::shade_texel (cognitive 23) viewer/src/assets/viewers/mdl/export.rs:789— viewer::assets::viewers::mdl::export::shade_texel has cognitive complexity 23 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 4, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
viewer::assets::viewers::skp::ui (cognitive 23) viewer/src/assets/viewers/skp.rs:185— viewer::assets::viewers::skp::ui has cognitive complexity 23 (threshold 15). Drivers by points: loops 7 (18 pts), if/else 5 (nesting depth added 11). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
MethodTooLong: Buffer.fill viewer/src/assets/viewers/mdl/program.rs:2931— MethodTooLong — fill runs 668 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 568 over it, 6.68× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SetupWindow.draw viewer/src/setup.rs:93— MethodTooLong — draw runs 454 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 354 over it, 4.54× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Scene.details_ui viewer/src/assets/viewers/layer/scene/mod.rs:4866— MethodTooLong — details_ui runs 381 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 281 over it, 3.81× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Rendered.poll viewer/src/assets/viewers/mdl/mod.rs:1673— MethodTooLong — poll runs 364 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 264 over it, 3.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Scene.translate viewer/src/assets/viewers/layer/scene/mod.rs:3590— MethodTooLong — translate runs 275 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 175 over it, 2.75× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: CharacterBuilder.poll viewer/src/character/mod.rs:692— MethodTooLong — poll runs 253 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 153 over it, 2.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: App.draw_sheet_data viewer/src/app.rs:1115— MethodTooLong — draw_sheet_data runs 248 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 148 over it, 2.48× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Buffers.attach viewer/src/assets/viewers/mdl/deferred.rs:1362— MethodTooLong — attach runs 228 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 128 over it, 2.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Rendered.viewport viewer/src/assets/viewers/mdl/mod.rs:2373— MethodTooLong — viewport runs 211 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 111 over it, 2.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Scene.viewport viewer/src/assets/viewers/layer/scene/mod.rs:4244— MethodTooLong — viewport runs 205 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 105 over it, 2.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Preview.info_ui viewer/src/assets/viewers/mod.rs:665— MethodTooLong — info_ui runs 192 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 92 over it, 1.92× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: App.draw_menubar viewer/src/app.rs:543— MethodTooLong — draw_menubar runs 186 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 86 over it, 1.86× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PrWindow.draw viewer/src/pr_window.rs:100— MethodTooLong — draw runs 186 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 86 over it, 1.86× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: EditableSchema.draw_internal viewer/src/editable_schema.rs:108— MethodTooLong — draw_internal runs 184 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 84 over it, 1.84× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Builder.step shadermerge/src/canon.rs:424— MethodTooLong — step runs 179 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 79 over it, 1.79× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Renderer.render viewer/src/assets/viewers/layer/scene/gpu.rs:1366— MethodTooLong — render runs 177 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 77 over it, 1.77× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: CharacterBuilder.side_panel viewer/src/character/mod.rs:2637— MethodTooLong — side_panel runs 176 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 76 over it, 1.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Ambient.ui viewer/src/assets/viewers/layer/scene/ambient.rs:751— MethodTooLong — ui runs 169 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 69 over it, 1.69× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Scene.walk viewer/src/assets/viewers/layer/scene/mod.rs:1647— MethodTooLong — walk runs 159 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 59 over it, 1.59× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Reader.walk luadec/src/read.rs:1641— MethodTooLong — walk runs 157 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Buffers.pass viewer/src/assets/viewers/mdl/deferred.rs:4022— MethodTooLong — pass runs 156 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SqpackWorker.received viewer/src/worker/sqpack_worker.rs:128— MethodTooLong — received runs 156 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: CharacterBuilder.appearance viewer/src/character/mod.rs:1955— MethodTooLong — appearance runs 154 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 54 over it, 1.54× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AssetBrowser.detail_panel viewer/src/assets/mod.rs:1629— MethodTooLong — detail_panel runs 151 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MusicPlayer.draw_player viewer/src/music.rs:701— MethodTooLong — draw_player runs 150 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 50 over it, 1.50× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Sync-over-async blocking smoke/burst.ts:67— `existsSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:69— `readFileSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:88— `existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:89— `mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:92— `mkdtempSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:128— `readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:152— `writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:153— `writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/burst.ts:164— `rmSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:66— `existsSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:68— `readFileSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:110— `writeFileSync` in `shot` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:117— `mkdtempSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:146— `mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:153— `readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/drive.ts:182— `rmSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:99— `existsSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:101— `readFileSync` in `launch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:137— `mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:145— `existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:148— `statSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:159— `readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:163— `mkdtempSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:206— `writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
Sync-over-async blocking smoke/frame.ts:208— `writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
+ 15 more in this group — see findings.md.
X17 · Uncapped recursion over a caller-supplied document· Recursive walk over a caller-supplied document has no depth cap · ×40
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:101— `coerce_integer` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 101 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `coerce_integer` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:134— `coerce_string` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 134 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `coerce_string` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:144— `is_empty` is public and takes a `CellValue` as its receiver from its caller, and it calls itself at line 144 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `is_empty` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:381— `read` is public and takes a `Cell` as its receiver from its caller, and it recurses at line 381 through `read_internal_link` and back with a piece of the document (and at line 323, line 401) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `read` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:284— `show` is public and takes a `Cell` as its receiver from its caller, and it recurses at line 284 through `draw` and back with a piece of the document (and at line 168, line 514) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `show` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/cell.rs:238— `size` is public, takes a document from its caller (line 266) and hands it to `size_internal`, which recurses at line 238 through `size_internal_link` and back with a piece of the document (and at line 205, line 262) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `size_internal` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/sheet/filter/complex_filter.rs:26— `has_fuzzy` is public and takes a `ComplexFilter` as its receiver from its caller, and it calls itself at line 26 with a piece of the document (and at line 27) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `has_fuzzy` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/router/mod.rs:62— `replace` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 62 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `replace` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/router/mod.rs:66— `back` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 66 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `back` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/router/mod.rs:70— `forward` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 70 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `forward` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/router/mod.rs:74— `base_url` is public and takes a `Router` as its receiver from its caller, and it calls itself at line 74 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `base_url` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/quests/script.rs:44— `lines` is public, takes a document from its caller (line 28) and hands it to `count`, which calls itself at line 44 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `count` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/character/stand.rs:379— `poll` is public and takes a `Cast` as its receiver from its caller, and it calls itself at line 379 with a piece of the document (and at line 515) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `poll` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/native.rs:102— `set_volume` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 102 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `set_volume` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/native.rs:83— `pause` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 83 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `pause` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/native.rs:188— `retain` is public and takes a `Mixer` as its receiver from its caller, and it calls itself at line 188 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `retain` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/web.rs:282— `pause` is public and takes a `Player` as its receiver from its caller, and it calls itself at line 282 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `pause` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/web.rs:304— `stop` is public and takes a `Player` as its receiver from its caller, and it recurses at line 304 through `discard_source` and back with a piece of the document (and at line 197) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `stop` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/web.rs:170— `play` is public and takes a `Player` as its receiver from its caller, and it recurses at line 170 through `resume` and back with a piece of the document (and at line 173, line 294, line 296) — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `play` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/audio/web.rs:684— `retain` is public and takes a `Mixer` as its receiver from its caller, and it calls itself at line 684 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `retain` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/assets/viewers/placed/mod.rs:99— `replace` is public and takes a `View` as its receiver from its caller, and it calls itself at line 99 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `replace` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/assets/viewers/mdl/emote.rs:580— `active_props` is public and takes a `Cue` as its receiver from its caller, and it calls itself at line 580 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `active_props` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/assets/viewers/mdl/emote.rs:593— `joints` is public and takes a `Cue` as its receiver from its caller, and it calls itself at line 593 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `joints` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/assets/viewers/mdl/gpu.rs:321— `attachments` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 321 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `attachments` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap viewer/src/assets/viewers/mdl/gpu.rs:326— `attachments_learned` is public and takes a `Model` as its receiver from its caller, and it calls itself at line 326 with a piece of the document — and nowhere in the walk is a depth or nesting counter compared with a bound. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. When a Rust thread runs out of stack it is not unwound: the runtime reports the overflow and aborts the process, so `catch_unwind` does not stop it and every other request the process serves dies with it (spawned threads, a Tokio worker included, get 2 MiB by default). serde_json and serde_yaml stop parsing at 128 levels only on their default path; a value from `disable_recursion_limit`, from another format or parser, or built in code carries whatever nesting it was given. Thread a depth argument through `attachments_learned` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
+ 15 more in this group — see findings.md.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×40
Symbol treated as nullable, then dereferenced unguarded web/build.rs:10— `ShadowBuilder::builder().build()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:32— `std::env::var("PROFILE")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:40— `command.spawn()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:41— `child.wait_with_output()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `build_frontend` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:54— `std::env::var("TARGET")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:55— `std::env::var("OUT_DIR")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:56— `std::env::var("PROFILE")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/build.rs:78— `target_dir.to_str()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_output_directory` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/main.rs:62— `Config::builder().add_source(File::new("config",FileFormat::Yaml).required(false)).add_source(Environment::default()).build().and_then(Config::try_deserialize)` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/main.rs:90— `e.downcast::<prometheus::Error>()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/main.rs:106— `Helmet::new().add(XContentTypeOptions::nosniff()).into_middleware()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/main.rs:144— `e.downcast::<prometheus::Error>()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:212— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `repositories` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:234— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `exists` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:253— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_list_id` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:270— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_global_paths` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:292— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_presence` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:314— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_file` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/queue.rs:340— `` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `get_file_by_hash` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded web/src/smart_bufreader.rs:67— `self.inner.seek_relative(relative_pos).map(|_|current_pos.checked_add_signed(relative_pos))?` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.expect()` in `seek` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded viewer/build.rs:4— `std::env::var("CARGO_CFG_TARGET_OS")` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded viewer/build.rs:7— `res.compile()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded viewer/build.rs:10— `ShadowBuilder::builder().build()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `main` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded viewer/src/app.rs:413— `create_router(ctx.clone())` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Symbol treated as nullable, then dereferenced unguarded viewer/src/app.rs:415— `self.router.get()` can be absent — it is an `Option` or `Result`, which is why it is forced — and `.unwrap()` in `draw` forces it with nothing on this path excluding `None`/`Err`: no `if let` or `match` arm that matched it present, no `let … else`, no `is_some()`/`is_ok()` test (or `is_none()`/`is_err()` test that leaves), no `assert!` of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with `?`, branch on it with `if let` / `match` / `let … else`, or give it a default (`unwrap_or`, `unwrap_or_default`, `unwrap_or_else`).
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:78— `UiColor.expansion` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:81— `UiColor.highlight_color` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:87— `Mount.last_location_mount` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:88— `Mount.mount_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:89— `Mount.buddy_model_top` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:90— `Mount.buddy_model_body` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:91— `Mount.buddy_model_legs` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:92— `Mount.buddy_stain` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:117— `Location.location_type` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:118— `Location.title_screen_logo` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:120— `Location.territory_type_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:121— `Location.layout_territory_type_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:122— `Location.layout_layer_filter_key` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:132— `Location.bgm_id` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:133— `Location.bgm_path` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:134— `Location.movement_mode` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:138— `Location.vfx_trigger_indexes` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:140— `Location.save_layout` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:141— `Location.use_vfx` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:142— `Location.save_housing` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:143— `Location.save_festivals` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:144— `Location.title_screen_override` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:145— `Location.ui_color` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:146— `Location.title_screen_movie` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Configuration option is read nowhere viewer/src/assets/viewers/layer/scene/preset.rs:147— `Location.use_live_time` is offered as a configuration-file option, so whoever configures the program can set it — but no production code reads it. Every value supplied for it is silently ignored. Consult it where it was meant to take effect — or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing.
Hotspot: viewer/src/assets/viewers/mdl/program.rs viewer/src/assets/viewers/mdl/program.rs:2931— viewer/src/assets/viewers/mdl/program.rs changed 100 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 93 in Buffer::fill at line 2931. 2 of those changes were fix/bug commits, and the other 98 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/program.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/layer/scene/mod.rs viewer/src/assets/viewers/layer/scene/mod.rs:4866— viewer/src/assets/viewers/layer/scene/mod.rs changed 148 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 61 in Scene::details_ui at line 4866. 2 of those changes were fix/bug commits, and the other 146 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/layer/scene/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/character/mod.rs viewer/src/character/mod.rs:692— viewer/src/character/mod.rs changed 79 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 81 in CharacterBuilder::poll at line 692. 1 of those changes was a fix/bug commit, and the other 78 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/character/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/mod.rs viewer/src/assets/viewers/mdl/mod.rs:1673— viewer/src/assets/viewers/mdl/mod.rs changed 88 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 71 in Rendered::poll at line 1673. 2 of those changes were fix/bug commits, and the other 86 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/deferred.rs viewer/src/assets/viewers/mdl/deferred.rs:4022— viewer/src/assets/viewers/mdl/deferred.rs changed 61 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 61 in Buffers::pass at line 4022. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/deferred.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/layer/scene/gpu.rs viewer/src/assets/viewers/layer/scene/gpu.rs:1366— viewer/src/assets/viewers/layer/scene/gpu.rs changed 46 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 40 in Renderer::render at line 1366. 1 of those changes was a fix/bug commit, and the other 45 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/layer/scene/gpu.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/skin.rs viewer/src/assets/viewers/mdl/skin.rs:1731— viewer/src/assets/viewers/mdl/skin.rs changed 50 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in Animation::walked at line 1731. 1 of those changes was a fix/bug commit, and the other 49 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/skin.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/cutb/play.rs viewer/src/assets/viewers/cutb/play.rs:1269— viewer/src/assets/viewers/cutb/play.rs changed 33 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in viewer::assets::viewers::cutb::play::ui at line 1269. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/cutb/play.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/avfx/sim.rs viewer/src/assets/viewers/avfx/sim.rs:704— viewer/src/assets/viewers/avfx/sim.rs changed 35 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in viewer::assets::viewers::avfx::sim::shading at line 704. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/avfx/sim.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mod.rs viewer/src/assets/viewers/mod.rs:665— viewer/src/assets/viewers/mod.rs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 53 in Preview::info_ui at line 665. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/layer/mod.rs viewer/src/assets/viewers/layer/mod.rs:382— viewer/src/assets/viewers/layer/mod.rs changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 45 in viewer::assets::viewers::layer::payload at line 382. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/layer/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/layer/scene/ambient.rs viewer/src/assets/viewers/layer/scene/ambient.rs:751— viewer/src/assets/viewers/layer/scene/ambient.rs changed 29 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in Ambient::ui at line 751. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/layer/scene/ambient.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/export.rs viewer/src/assets/viewers/mdl/export.rs:89— viewer/src/assets/viewers/mdl/export.rs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in viewer::assets::viewers::mdl::export::gather at line 89. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/export.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: smoke/smoke.ts smoke/smoke.ts:566— smoke/smoke.ts changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 34 in smoke.main at line 566. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- smoke/smoke.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/mod.rs viewer/src/assets/mod.rs:1629— viewer/src/assets/mod.rs changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in AssetBrowser::detail_panel at line 1629. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/app.rs viewer/src/app.rs:543— viewer/src/app.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 41 in App::draw_menubar at line 543. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/app.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/gpu.rs viewer/src/assets/viewers/mdl/gpu.rs:457— viewer/src/assets/viewers/mdl/gpu.rs changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in Model::draw at line 457. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/gpu.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: luadec/src/read.rs luadec/src/read.rs:1641— luadec/src/read.rs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 49 in Reader::walk at line 1641. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- luadec/src/read.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/character/stand.rs viewer/src/character/stand.rs:283— viewer/src/character/stand.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in Cast::poll at line 283. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/character/stand.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/icons/mod.rs viewer/src/icons/mod.rs:798— viewer/src/icons/mod.rs changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in IconBrowser::draw_detail at line 798. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/icons/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/assets/viewers/mdl/emote.rs viewer/src/assets/viewers/mdl/emote.rs:411— viewer/src/assets/viewers/mdl/emote.rs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in Cue::poll at line 411. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/assets/viewers/mdl/emote.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/music.rs viewer/src/music.rs:701— viewer/src/music.rs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in MusicPlayer::draw_player at line 701. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/music.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/smoke.rs viewer/src/smoke.rs:365— viewer/src/smoke.rs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in SmokeApp::ui at line 365. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/smoke.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: viewer/src/character/gating.rs viewer/src/character/gating.rs:128— viewer/src/character/gating.rs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in Worn::covers at line 128. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- viewer/src/character/gating.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: framediff/src/main.rs framediff/src/main.rs:84— framediff/src/main.rs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in framediff::run at line 84. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 08:21:56 -08:00' --until='2026-11-14 08:21:56 -08:00' --full-history --no-merges -- framediff/src/main.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
FileTooLong: scene/mod.rs viewer/src/assets/viewers/layer/scene/mod.rs— FileTooLong — 3594 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 83% of them inside a single declaration: Scene (2 blocks, 858-5401). The bar is 500 significant lines; this is 3094 over it, 7.19× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: mdl/deferred.rs viewer/src/assets/viewers/mdl/deferred.rs— FileTooLong — 3422 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 71% of them inside a single declaration: Buffers (3 blocks, 1000-4520), declaring 37 free functions. The bar is 500 significant lines; this is 2922 over it, 6.84× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: mdl/program.rs viewer/src/assets/viewers/mdl/program.rs— FileTooLong — 2492 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 46 free functions. The bar is 500 significant lines; this is 1992 over it, 4.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: mdl/mod.rs viewer/src/assets/viewers/mdl/mod.rs— FileTooLong — 2474 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 62% of them inside a single declaration: Rendered (2 blocks, 469-3879). The bar is 500 significant lines; this is 1974 over it, 4.95× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: character/mod.rs viewer/src/character/mod.rs— FileTooLong — 2290 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 77% of them inside a single declaration: CharacterBuilder (3 blocks, 284-2882). The bar is 500 significant lines; this is 1790 over it, 4.58× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: assets/mod.rs viewer/src/assets/mod.rs— FileTooLong — 1577 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 1077 over it, 3.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/app.rs viewer/src/app.rs— FileTooLong — 1446 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 82% of them inside a single declaration: App (4 blocks, 248-2067). The bar is 500 significant lines; this is 946 over it, 2.89× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/read.rs luadec/src/read.rs— FileTooLong — 1380 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 65% of them inside a single declaration: Reader (2 blocks, 47-2028). The bar is 500 significant lines; this is 880 over it, 2.76× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: mdl/skin.rs viewer/src/assets/viewers/mdl/skin.rs— FileTooLong — 1289 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 789 over it, 2.58× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: scene/gpu.rs viewer/src/assets/viewers/layer/scene/gpu.rs— FileTooLong — 1212 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 80% of them inside a single declaration: Renderer (3 blocks, 263-1690). The bar is 500 significant lines; this is 712 over it, 2.42× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: cutb/play.rs viewer/src/assets/viewers/cutb/play.rs— FileTooLong — 1193 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 51 free functions. The bar is 500 significant lines; this is 693 over it, 2.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: avfx/sim.rs viewer/src/assets/viewers/avfx/sim.rs— FileTooLong — 1004 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 504 over it, 2.01× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: mdl/gpu.rs viewer/src/assets/viewers/mdl/gpu.rs— FileTooLong — 993 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 493 over it, 1.99× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: viewers/uld.rs viewer/src/assets/viewers/uld.rs— FileTooLong — 933 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 433 over it, 1.87× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: mdl/export.rs viewer/src/assets/viewers/mdl/export.rs— FileTooLong — 922 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 422 over it, 1.84× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: layer/mod.rs viewer/src/assets/viewers/layer/mod.rs— FileTooLong — 905 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 405 over it, 1.81× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: avfx/mod.rs viewer/src/assets/viewers/avfx/mod.rs— FileTooLong — 896 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 396 over it, 1.79× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: viewers/mod.rs viewer/src/assets/viewers/mod.rs— FileTooLong — 887 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 387 over it, 1.77× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/music.rs viewer/src/music.rs— FileTooLong — 830 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 70% of them inside a single declaration: MusicPlayer (3 blocks, 120-931). The bar is 500 significant lines; this is 330 over it, 1.66× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: icons/mod.rs viewer/src/icons/mod.rs— FileTooLong — 742 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 84% of them inside a single declaration: IconBrowser (3 blocks, 62-939). The bar is 500 significant lines; this is 242 over it, 1.48× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/merge.rs shadermerge/src/merge.rs— FileTooLong — 710 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 210 over it, 1.42× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: routes/api.rs web/src/routes/api.rs— FileTooLong — 693 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 43 free functions. The bar is 500 significant lines; this is 193 over it, 1.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: smoke/smoke.ts smoke/smoke.ts— FileTooLong — 692 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 192 over it, 1.38× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/synth.rs shadermerge/src/synth.rs— FileTooLong — 679 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 91% of them inside a single declaration: Synth (2 blocks, 115-969). The bar is 500 significant lines; this is 179 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: scene/ambient.rs viewer/src/assets/viewers/layer/scene/ambient.rs— FileTooLong — 678 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 75% of them inside a single declaration: Ambient (2 blocks, 199-993). The bar is 500 significant lines; this is 178 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
viewer::assets::viewers::layer::payload (cyclomatic 45) viewer/src/assets/viewers/layer/mod.rs:382— viewer::assets::viewers::layer::payload has cyclomatic complexity 45 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
viewer::assets::viewers::mdl::export::gather (cyclomatic 35) viewer/src/assets/viewers/mdl/export.rs:89— viewer::assets::viewers::mdl::export::gather has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::layer::ui (cyclomatic 34) viewer/src/assets/viewers/layer/mod.rs:844— viewer::assets::viewers::layer::ui has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::shpk::list::ui (cyclomatic 32) viewer/src/assets/viewers/shpk/list.rs:56— viewer::assets::viewers::shpk::list::ui has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::uld::canvas (cyclomatic 30) viewer/src/assets/viewers/uld.rs:867— viewer::assets::viewers::uld::canvas has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::shpk::keys::read (cyclomatic 29) viewer/src/assets/viewers/shpk/keys.rs:72— viewer::assets::viewers::shpk::keys::read has cyclomatic complexity 29 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
viewer::character::appearance (cyclomatic 29) viewer/src/character/mod.rs:2970— viewer::character::appearance has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::mdl::ui (cyclomatic 27) viewer/src/assets/viewers/mdl/mod.rs:1328— viewer::assets::viewers::mdl::ui has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::uld::properties (cyclomatic 26) viewer/src/assets/viewers/uld.rs:365— viewer::assets::viewers::uld::properties has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
viewer::quests::rewards::ui (cyclomatic 26) viewer/src/quests/rewards.rs:264— viewer::quests::rewards::ui has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::cutb::play::ui (cyclomatic 25) viewer/src/assets/viewers/cutb/play.rs:1269— viewer::assets::viewers::cutb::play::ui has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
viewer::assets::viewers::mdl::read_level (cyclomatic 24) viewer/src/assets/viewers/mdl/mod.rs:822— viewer::assets::viewers::mdl::read_level has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::hex_dump (cyclomatic 23) viewer/src/assets/mod.rs:2763— viewer::assets::hex_dump has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::character::menus::pieces (cyclomatic 22) viewer/src/character/menus.rs:297— viewer::character::menus::pieces has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::uld::tree (cyclomatic 21) viewer/src/assets/viewers/uld.rs:1227— viewer::assets::viewers::uld::tree has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
viewer::assets::viewers::zone::envs::ui (cyclomatic 21) viewer/src/assets/viewers/zone/envs.rs:197— viewer::assets::viewers::zone::envs::ui has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::quests::dag::ui (cyclomatic 21) viewer/src/quests/dag.rs:11— viewer::quests::dag::ui has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::avfx::sim::shading (cyclomatic 20) viewer/src/assets/viewers/avfx/sim.rs:704— viewer::assets::viewers::avfx::sim::shading has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
viewer::assets::viewers::avfx::tree_ui (cyclomatic 18) viewer/src/assets/viewers/avfx/mod.rs:809— viewer::assets::viewers::avfx::tree_ui has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::cutb::play::perform (cyclomatic 16) viewer/src/assets/viewers/cutb/play.rs:1496— viewer::assets::viewers::cutb::play::perform has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::assets::viewers::cutb::play::transport (cyclomatic 16) viewer/src/assets/viewers/cutb/play.rs:1767— viewer::assets::viewers::cutb::play::transport has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
viewer::assets::viewers::mdl::export::shade_texel (cyclomatic 16) viewer/src/assets/viewers/mdl/export.rs:789— viewer::assets::viewers::mdl::export::shade_texel has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
viewer::character::emotes::read (cyclomatic 16) viewer/src/character/emotes.rs:178— viewer::character::emotes::read has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FunctionTooLong: viewer::assets::viewers::layer::payload viewer/src/assets/viewers/layer/mod.rs:382— FunctionTooLong — viewer::assets::viewers::layer::payload runs 296 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 196 over it, 2.96× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: smoke.main smoke/smoke.ts:566— FunctionTooLong — main runs 275 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 175 over it, 2.75× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: shadermerge::merge::merge shadermerge/src/merge.rs:98— FunctionTooLong — shadermerge::merge::merge runs 263 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 163 over it, 2.63× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: framediff::run framediff/src/main.rs:84— FunctionTooLong — framediff::run runs 220 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 120 over it, 2.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: perf.main smoke/perf.ts:95— FunctionTooLong — main runs 197 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 97 over it, 1.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::mdl::read_level viewer/src/assets/viewers/mdl/mod.rs:822— FunctionTooLong — viewer::assets::viewers::mdl::read_level runs 171 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 71 over it, 1.71× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::shpk::list::ui viewer/src/assets/viewers/shpk/list.rs:56— FunctionTooLong — viewer::assets::viewers::shpk::list::ui runs 168 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 68 over it, 1.68× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::shpk::keys::read viewer/src/assets/viewers/shpk/keys.rs:72— FunctionTooLong — viewer::assets::viewers::shpk::keys::read runs 166 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 66 over it, 1.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::mdl::export::gather viewer/src/assets/viewers/mdl/export.rs:89— FunctionTooLong — viewer::assets::viewers::mdl::export::gather runs 160 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::layer::ui viewer/src/assets/viewers/layer/mod.rs:844— FunctionTooLong — viewer::assets::viewers::layer::ui runs 156 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: shadermerge::factor::factor shadermerge/src/factor.rs:165— FunctionTooLong — shadermerge::factor::factor runs 135 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 35 over it, 1.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::phyb::simulator_ui viewer/src/assets/viewers/phyb.rs:221— FunctionTooLong — viewer::assets::viewers::phyb::simulator_ui runs 121 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 21 over it, 1.21× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::hex_dump viewer/src/assets/mod.rs:2763— FunctionTooLong — viewer::assets::hex_dump runs 118 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: luadec::read::sticky luadec/src/read.rs:504— FunctionTooLong — luadec::read::sticky runs 115 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::uld::canvas viewer/src/assets/viewers/uld.rs:867— FunctionTooLong — viewer::assets::viewers::uld::canvas runs 115 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::uld::properties viewer/src/assets/viewers/uld.rs:365— FunctionTooLong — viewer::assets::viewers::uld::properties runs 111 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: shadermerge::merge::preprocess shadermerge/src/merge.rs:902— FunctionTooLong — shadermerge::merge::preprocess runs 110 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: framediff::bin::rdframe::run framediff/src/bin/rdframe.rs:27— FunctionTooLong — framediff::bin::rdframe::run runs 109 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: viewer::assets::viewers::avfx::sim::shading viewer/src/assets/viewers/avfx/sim.rs:704— FunctionTooLong — viewer::assets::viewers::avfx::sim::shading runs 104 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: net.main smoke/net.ts:60— FunctionTooLong — main runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: web::main web/src/main.rs:48— FunctionTooLong — web::main runs 102 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
ClassTooLong: Scene viewer/src/assets/viewers/layer/scene/mod.rs:858— ClassTooLong — 2994 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 63 methods, 2 blocks, lines 858-5401. The bar is 400 significant lines; this is 2594 over it, 7.49× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Buffers viewer/src/assets/viewers/mdl/deferred.rs:1000— ClassTooLong — 2423 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 88 methods, 3 blocks, lines 1000-4520. The bar is 400 significant lines; this is 2023 over it, 6.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CharacterBuilder viewer/src/character/mod.rs:284— ClassTooLong — 1772 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 53 methods, 3 blocks, lines 284-2882. The bar is 400 significant lines; this is 1372 over it, 4.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Rendered viewer/src/assets/viewers/mdl/mod.rs:469— ClassTooLong — 1524 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 48 methods, 2 blocks, lines 469-3879. The bar is 400 significant lines; this is 1124 over it, 3.81× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: App viewer/src/app.rs:248— ClassTooLong — 1192 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 54 methods, 4 blocks, lines 248-2067. The bar is 400 significant lines; this is 792 over it, 2.98× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Renderer viewer/src/assets/viewers/layer/scene/gpu.rs:263— ClassTooLong — 968 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 29 methods, 3 blocks, lines 263-1690. The bar is 400 significant lines; this is 568 over it, 2.42× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Reader luadec/src/read.rs:47— ClassTooLong — 898 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 45 methods, 2 blocks, lines 47-2028. The bar is 400 significant lines; this is 498 over it, 2.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AssetBrowser viewer/src/assets/mod.rs:820— ClassTooLong — 786 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 19 methods, 3 blocks, lines 820-1990. The bar is 400 significant lines; this is 386 over it, 1.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Buffer viewer/src/assets/viewers/mdl/program.rs:1039— ClassTooLong — 722 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 4 methods, 2 blocks, lines 1039-4074. The bar is 400 significant lines; this is 322 over it, 1.81× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Animation viewer/src/assets/viewers/mdl/skin.rs:939— ClassTooLong — 657 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 44 methods, 2 blocks, lines 939-2014. The bar is 400 significant lines; this is 257 over it, 1.64× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: IconBrowser viewer/src/icons/mod.rs:62— ClassTooLong — 625 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 19 methods, 3 blocks, lines 62-939. The bar is 400 significant lines; this is 225 over it, 1.56× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Synth shadermerge/src/synth.rs:115— ClassTooLong — 615 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 13 methods, 2 blocks, lines 115-969. The bar is 400 significant lines; this is 215 over it, 1.54× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MusicPlayer viewer/src/music.rs:120— ClassTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 21 methods, 3 blocks, lines 120-931. The bar is 400 significant lines; this is 182 over it, 1.46× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: SetupWindow viewer/src/setup.rs:22— ClassTooLong — 530 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 4 methods, 2 blocks, lines 22-798. The bar is 400 significant lines; this is 130 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: SheetTable viewer/src/sheet/sheet_table.rs:50— ClassTooLong — 525 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 24 methods, 3 blocks, lines 50-811. The bar is 400 significant lines; this is 125 over it, 1.31× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Ambient viewer/src/assets/viewers/layer/scene/ambient.rs:199— ClassTooLong — 506 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 28 methods, 2 blocks, lines 199-993. The bar is 400 significant lines; this is 106 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: QuestBrowser viewer/src/quests/mod.rs:86— ClassTooLong — 504 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 18 methods, 3 blocks, lines 86-771. The bar is 400 significant lines; this is 104 over it, 1.26× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Game viewer/src/assets/viewers/mdl/gpu.rs:251— ClassTooLong — 482 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 10 methods, 3 blocks, lines 251-1366. The bar is 400 significant lines; this is 82 over it, 1.21× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Preview viewer/src/assets/viewers/mod.rs:306— ClassTooLong — 461 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 5 methods, 2 blocks, lines 306-920. The bar is 400 significant lines; this is 61 over it, 1.15× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Program viewer/src/assets/viewers/mdl/program.rs:2002— ClassTooLong — 440 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 12 methods, 2 blocks, lines 2002-2904. The bar is 400 significant lines; this is 40 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D30 · Dependency Vulnerabilities· Medium advisory (unsound) · ×16
Scene::details_ui (cognitive 84) viewer/src/assets/viewers/layer/scene/mod.rs:4866— Scene::details_ui has cognitive complexity 84 (threshold 15). Drivers by points: if/else 26 (39 pts), match/switch 19 (34 pts), loops 7 (10 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::translate (cognitive 78) viewer/src/assets/viewers/layer/scene/mod.rs:3590— Scene::translate has cognitive complexity 78 (threshold 15). Drivers by points: if/else 33 (50 pts), boolean chains 10, match/switch 5 (10 pts), loops 5 (8 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::motion (cognitive 70) viewer/src/assets/viewers/layer/scene/mod.rs:1506— Scene::motion has cognitive complexity 70 (threshold 15). Drivers by points: if/else 12 (38 pts), match/switch 6 (18 pts), loops 6 (13 pts), boolean chains 1 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::load_asides (cognitive 55) viewer/src/assets/viewers/layer/scene/mod.rs:2483— Scene::load_asides has cognitive complexity 55 (threshold 15). Drivers by points: match/switch 11 (21 pts), loops 9 (20 pts), if/else 8 (11 pts), boolean chains 3 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::viewport (cognitive 43) viewer/src/assets/viewers/layer/scene/mod.rs:4244— Scene::viewport has cognitive complexity 43 (threshold 15). Drivers by points: if/else 15 (19 pts), boolean chains 11, match/switch 6 (9 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::want_blobs (cognitive 42) viewer/src/assets/viewers/layer/scene/mod.rs:3282— Scene::want_blobs has cognitive complexity 42 (threshold 15). Drivers by points: if/else 7 (22 pts), loops 6 (16 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::walk (cognitive 38) viewer/src/assets/viewers/layer/scene/mod.rs:1647— Scene::walk has cognitive complexity 38 (threshold 15). Drivers by points: match/switch 8 (28 pts), loops 3 (6 pts), boolean chains 4 (nesting depth added 23). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Scene::load_packages (cognitive 33) viewer/src/assets/viewers/layer/scene/mod.rs:3136— Scene::load_packages has cognitive complexity 33 (threshold 15). Drivers by points: if/else 13 (20 pts), loops 5, match/switch 3 (5 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::load_textures (cognitive 30) viewer/src/assets/viewers/layer/scene/mod.rs:4038— Scene::load_textures has cognitive complexity 30 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 6 (11 pts), loops 4, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::rebuild (cognitive 26) viewer/src/assets/viewers/layer/scene/mod.rs:2263— Scene::rebuild has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 7, match/switch 2 (3 pts), loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::expand (cognitive 23) viewer/src/assets/viewers/layer/scene/mod.rs:2848— Scene::expand has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (12 pts), match/switch 4 (7 pts), loops 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::load_blobs (cognitive 22) viewer/src/assets/viewers/layer/scene/mod.rs:3337— Scene::load_blobs has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 2 (5 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::load_effects (cognitive 21) viewer/src/assets/viewers/layer/scene/mod.rs:2661— Scene::load_effects has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 5, match/switch 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::load_models (cognitive 20) viewer/src/assets/viewers/layer/scene/mod.rs:2957— Scene::load_models has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (9 pts), match/switch 3 (6 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Scene::place_grass (cognitive 18) viewer/src/assets/viewers/layer/scene/mod.rs:2039— Scene::place_grass has cognitive complexity 18 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 3 (7 pts), match/switch 1 (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/avfx/program.rs:615— viewer/src/assets/viewers/avfx/program.rs:615-621 | viewer/src/assets/viewers/mdl/program.rs:4078-4084 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:4015— viewer/src/assets/viewers/layer/scene/mod.rs:4015-4021 | viewer/src/assets/viewers/mdl/mod.rs:1644-1650 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:4015` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/mdl/mod.rs:1643` calls `chain`, `iter`, `flat_map` and `viewer/src/assets/viewers/layer/scene/mod.rs:4014` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:4520— viewer/src/assets/viewers/layer/scene/mod.rs:4520-4526 | viewer/src/assets/viewers/mdl/mod.rs:2681-2687 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:4520` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/layer/sound.rs:174— viewer/src/assets/viewers/layer/sound.rs:174-180 | viewer/src/assets/viewers/scd.rs:184-190 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/sound.rs:174` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/mdl/mod.rs:2896— viewer/src/assets/viewers/mdl/mod.rs:2896-2902 | viewer/src/assets/viewers/mdl/mod.rs:2936-2942 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/mod.rs:2896` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/mdl/mod.rs:2908— viewer/src/assets/viewers/mdl/mod.rs:2908-2914 | viewer/src/assets/viewers/mdl/mod.rs:2942-2948 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/mod.rs:2908` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/mdl/program.rs:2464— viewer/src/assets/viewers/mdl/program.rs:2464-2470 | viewer/src/assets/viewers/mdl/program.rs:2835-2841 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/program.rs:2464` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/pcb/gpu.rs:104— viewer/src/assets/viewers/pcb/gpu.rs:104-110 | viewer/src/assets/viewers/placed/gpu.rs:119-125 — `viewer/src/assets/viewers/pcb/gpu.rs` and `viewer/src/assets/viewers/placed/gpu.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 68 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/placed/gpu.rs:117` calls `disable` and `viewer/src/assets/viewers/pcb/gpu.rs:103` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/pcb/gpu.rs:205— viewer/src/assets/viewers/pcb/gpu.rs:205-211 | viewer/src/assets/viewers/placed/gpu.rs:250-256 — `viewer/src/assets/viewers/pcb/gpu.rs` and `viewer/src/assets/viewers/placed/gpu.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 68 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb/gpu.rs:205` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `vertices` to `&[Vertex]` in one and `&[f32]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) viewer/src/character/mod.rs:2019— viewer/src/character/mod.rs:2019-2025 | viewer/src/character/mod.rs:3056-3062 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) viewer/src/goto.rs:56— viewer/src/goto.rs:56-62 | viewer/src/goto.rs:268-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) viewer/src/quests/tree.rs:46— viewer/src/quests/tree.rs:46-52 | viewer/src/quests/tree.rs:54-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) viewer/src/utils/export.rs:20— viewer/src/utils/export.rs:20-26 | viewer/src/utils/tex_export.rs:263-269 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/layer/sound.rs:250— viewer/src/assets/viewers/layer/sound.rs:250-256 | viewer/src/assets/viewers/scd.rs:253-259 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) viewer/src/assets/viewers/mdl/program.rs:4137— viewer/src/assets/viewers/mdl/program.rs:4137-4143 | viewer/src/assets/viewers/mdl/program.rs:4178-4184 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/program.rs:4178` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) viewer/src/assets/mod.rs:1185— viewer/src/assets/mod.rs:1185-1193 | viewer/src/icons/mod.rs:533-541 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/avfx/program.rs:489— viewer/src/assets/viewers/avfx/program.rs:489-497 | viewer/src/assets/viewers/mdl/program.rs:2940-2948 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:3686— viewer/src/assets/viewers/layer/scene/mod.rs:3686-3694 | viewer/src/assets/viewers/layer/scene/mod.rs:3968-3976 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:3686` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:4836— viewer/src/assets/viewers/mdl/deferred.rs:4836-4844 | viewer/src/assets/viewers/mdl/grid.rs:95-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:4836` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/mdl/program.rs:2566— viewer/src/assets/viewers/mdl/program.rs:2566-2574 | viewer/src/assets/viewers/mdl/program.rs:2653-2661 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/pcb.rs:88— viewer/src/assets/viewers/pcb.rs:88-96 | viewer/src/assets/viewers/placed/mod.rs:33-41 — before extracting anything, compare `viewer/src/assets/viewers/pcb.rs` and `viewer/src/assets/viewers/placed/mod.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) viewer/src/music.rs:589— viewer/src/music.rs:589-597 | viewer/src/zones/mod.rs:409-417 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) viewer/src/setup.rs:165— viewer/src/setup.rs:165-173 | viewer/src/setup.rs:441-449 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/setup.rs:165` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/mdl/gpu.rs:1047— viewer/src/assets/viewers/mdl/gpu.rs:1047-1055 | viewer/src/assets/viewers/mdl/gpu.rs:1195-1203 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/gpu.rs:1047` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) viewer/src/assets/viewers/pcb.rs:226— viewer/src/assets/viewers/pcb.rs:226-243 | viewer/src/assets/viewers/pcb.rs:275-283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb.rs:226` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) viewer/src/data/web.rs:91— viewer/src/data/web.rs:91-99 | viewer/src/data/web.rs:126-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) viewer/src/data/web.rs:144— viewer/src/data/web.rs:144-152 | viewer/src/data/web.rs:158-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) viewer/src/music.rs:532— viewer/src/music.rs:532-540 | viewer/src/zones/mod.rs:349-357 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/music.rs:532` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) viewer/src/assets/mod.rs:1100— viewer/src/assets/mod.rs:1100-1108 | viewer/src/icons/mod.rs:332-340 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/mod.rs:1100` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Scene::details_ui (cyclomatic 61) viewer/src/assets/viewers/layer/scene/mod.rs:4866— Scene::details_ui has cyclomatic complexity 61 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Scene::translate (cyclomatic 54) viewer/src/assets/viewers/layer/scene/mod.rs:3590— Scene::translate has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Scene::viewport (cyclomatic 36) viewer/src/assets/viewers/layer/scene/mod.rs:4244— Scene::viewport has cyclomatic complexity 36 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Scene::load_asides (cyclomatic 34) viewer/src/assets/viewers/layer/scene/mod.rs:2483— Scene::load_asides has cyclomatic complexity 34 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Scene::motion (cyclomatic 28) viewer/src/assets/viewers/layer/scene/mod.rs:1506— Scene::motion has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Scene::load_packages (cyclomatic 26) viewer/src/assets/viewers/layer/scene/mod.rs:3136— Scene::load_packages has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Scene::walk (cyclomatic 24) viewer/src/assets/viewers/layer/scene/mod.rs:1647— Scene::walk has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Scene::load_textures (cyclomatic 20) viewer/src/assets/viewers/layer/scene/mod.rs:4038— Scene::load_textures has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Scene::rebuild (cyclomatic 18) viewer/src/assets/viewers/layer/scene/mod.rs:2263— Scene::rebuild has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Scene::want_blobs (cyclomatic 17) viewer/src/assets/viewers/layer/scene/mod.rs:3282— Scene::want_blobs has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Scene::expand (cyclomatic 16) viewer/src/assets/viewers/layer/scene/mod.rs:2848— Scene::expand has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D30 · Dependency Vulnerabilities· Medium vulnerability · ×11
Duplicated block (12 lines × 2) shadermerge/src/pick.rs:39— shadermerge/src/pick.rs:39-50 | viewer/src/assets/viewers/shpk/keys.rs:169-180 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) viewer/src/assets/mod.rs:1231— viewer/src/assets/mod.rs:1231-1242 | viewer/src/assets/mod.rs:1430-1441 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/mod.rs:1231` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/avfx/program.rs:334— viewer/src/assets/viewers/avfx/program.rs:334-345 | viewer/src/assets/viewers/mdl/program.rs:2205-2216 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:1654— viewer/src/assets/viewers/layer/scene/gpu.rs:1654-1665 | viewer/src/assets/viewers/mdl/gpu.rs:719-730 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:2510— viewer/src/assets/viewers/mdl/deferred.rs:2510-2521 | viewer/src/assets/viewers/mdl/deferred.rs:2533-2544 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:2510` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:2711— viewer/src/assets/viewers/mdl/deferred.rs:2711-2722 | viewer/src/assets/viewers/mdl/deferred.rs:2725-2736 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/mdl/gpu.rs:838— viewer/src/assets/viewers/mdl/gpu.rs:838-849 | viewer/src/assets/viewers/mdl/gpu.rs:1176-1187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/gpu.rs:838` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) viewer/src/sheet/filter/input.rs:125— viewer/src/sheet/filter/input.rs:125-136 | viewer/src/sheet/filter/input.rs:202-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:1374— viewer/src/assets/viewers/mdl/deferred.rs:1374-1385 | viewer/src/assets/viewers/mdl/deferred.rs:4434-4445 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/mdl/deferred.rs:4446` calls `extend`, `take` and `viewer/src/assets/viewers/mdl/deferred.rs:1386` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/scd.rs:262— viewer/src/assets/viewers/scd.rs:262-273 | viewer/src/music.rs:1005-1016 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) viewer/src/assets/viewers/layer/mod.rs:630— viewer/src/assets/viewers/layer/mod.rs:630-651 | viewer/src/assets/viewers/layer/mod.rs:712-723 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/mod.rs:630` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) luadec/src/read.rs:1263— luadec/src/read.rs:1263-1273 | luadec/src/read.rs:1462-1472 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `luadec/src/read.rs:1263` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/avfx/gpu.rs:569— viewer/src/assets/viewers/avfx/gpu.rs:569-579 | viewer/src/assets/viewers/mdl/deferred.rs:5193-5203 — before extracting anything, compare `viewer/src/assets/viewers/avfx/gpu.rs` and `viewer/src/assets/viewers/mdl/deferred.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/gpu.rs:569` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/avfx/mod.rs:172— viewer/src/assets/viewers/avfx/mod.rs:172-182 | viewer/src/assets/viewers/mdl/mod.rs:2142-2152 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:172` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/avfx/program.rs:459— viewer/src/assets/viewers/avfx/program.rs:459-469 | viewer/src/assets/viewers/mdl/program.rs:2464-2474 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/program.rs:459` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:4868— viewer/src/assets/viewers/mdl/deferred.rs:4868-4878 | viewer/src/assets/viewers/mdl/deferred.rs:4900-4910 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:4868` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/pcb.rs:637— viewer/src/assets/viewers/pcb.rs:637-647 | viewer/src/assets/viewers/placed/mod.rs:112-122 — before extracting anything, compare `viewer/src/assets/viewers/pcb.rs` and `viewer/src/assets/viewers/placed/mod.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb.rs:637` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/assets/viewers/shader/code.rs:74— viewer/src/assets/viewers/shader/code.rs:74-84 | viewer/src/assets/viewers/shpk/merged.rs:94-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/shader/code.rs:74` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/music.rs:1127— viewer/src/music.rs:1127-1137 | viewer/src/zones/mod.rs:648-658 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) viewer/src/setup.rs:215— viewer/src/setup.rs:215-225 | viewer/src/setup.rs:503-513 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/setup.rs:215` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) viewer/src/quests/mod.rs:516— viewer/src/quests/mod.rs:516-526 | viewer/src/quests/play.rs:112-122 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/quests/mod.rs:516` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) luadec/src/read.rs:555— luadec/src/read.rs:555-560 | luadec/src/read.rs:575-580 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `luadec/src/read.rs:555` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/assets/viewers/avfx/mod.rs:810— viewer/src/assets/viewers/avfx/mod.rs:810-815 | viewer/src/assets/viewers/zone/envs.rs:203-208 — before extracting anything, compare `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/zone/envs.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 72 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:810` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:2433— viewer/src/assets/viewers/layer/scene/mod.rs:2433-2439 | viewer/src/assets/viewers/layer/scene/mod.rs:2456-2461 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:2433` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:2698— viewer/src/assets/viewers/layer/scene/mod.rs:2698-2703 | viewer/src/assets/viewers/mdl/effects.rs:181-186 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:2698` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/quests/requirements.rs:94— viewer/src/quests/requirements.rs:94-99 | viewer/src/quests/requirements.rs:129-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/quests/requirements.rs:94` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/quests/requirements.rs:91` calls `read` and `viewer/src/quests/requirements.rs:127` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) viewer/src/sheet/cell.rs:120— viewer/src/sheet/cell.rs:120-125 | viewer/src/sheet/cell.rs:494-499 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/sheet/cell.rs:120` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/assets/viewers/layer/mod.rs:1213— viewer/src/assets/viewers/layer/mod.rs:1213-1218 | viewer/src/assets/viewers/zone/envs.rs:449-454 — before extracting anything, compare `viewer/src/assets/viewers/layer/mod.rs` and `viewer/src/assets/viewers/zone/envs.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/mod.rs:1213` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/character/mod.rs:2193— viewer/src/character/mod.rs:2193-2198 | viewer/src/character/mod.rs:2234-2239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/mod.rs:2193` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) viewer/src/quests/requirements.rs:69— viewer/src/quests/requirements.rs:69-74 | viewer/src/quests/requirements.rs:98-103 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/quests/requirements.rs:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (6 lines × 2) viewer/src/assets/viewers/layer/sound.rs:283— viewer/src/assets/viewers/layer/sound.rs:283-288 | viewer/src/assets/viewers/scd.rs:106-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/sound.rs:283` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Rendered::poll (cognitive 123) viewer/src/assets/viewers/mdl/mod.rs:1673— Rendered::poll has cognitive complexity 123 (threshold 15). Drivers by points: if/else 26 (53 pts), match/switch 22 (51 pts), loops 10 (12 pts), boolean chains 7 (nesting depth added 58). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::details_ui (cognitive 74) viewer/src/assets/viewers/mdl/mod.rs:3697— Rendered::details_ui has cognitive complexity 74 (threshold 15). Drivers by points: if/else 20 (43 pts), loops 11 (22 pts), match/switch 3 (7 pts), boolean chains 2 (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::translate (cognitive 42) viewer/src/assets/viewers/mdl/mod.rs:3129— Rendered::translate has cognitive complexity 42 (threshold 15). Drivers by points: if/else 14 (31 pts), match/switch 3 (7 pts), boolean chains 3, loops 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
Rendered::viewport (cognitive 38) viewer/src/assets/viewers/mdl/mod.rs:2373— Rendered::viewport has cognitive complexity 38 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 12 (14 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::details_ui (cognitive 28) viewer/src/assets/viewers/layer/mod.rs:1200— Rendered::details_ui has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 3 (11 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::posed (cognitive 24) viewer/src/assets/viewers/mdl/mod.rs:2212— Rendered::posed has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (5 pts), match/switch 1 (4 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::scene (cognitive 24) viewer/src/assets/viewers/pap.rs:339— Rendered::scene has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 3 (9 pts), boolean chains 2, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::details_ui (cognitive 18) viewer/src/assets/viewers/zone/envs.rs:448— Rendered::details_ui has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (8 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rendered::details_ui (cognitive 17) viewer/src/assets/viewers/avfx/mod.rs:1106— Rendered::details_ui has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D30 · Dependency Vulnerabilities· Medium advisory (unmaintained) · ×9
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×9
Edited copy of a member (9 corresponding lines) viewer/src/assets/viewers/pcb/gpu.rs:160— viewer/src/assets/viewers/pcb/gpu.rs:160-168 | viewer/src/assets/viewers/placed/gpu.rs:187-196 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/assets/viewers/mdl/program.rs:1381— viewer/src/assets/viewers/mdl/program.rs:1381-1389 | viewer/src/assets/viewers/mdl/program.rs:1393-1407 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/app.rs:380— viewer/src/app.rs:380-388 | viewer/src/app.rs:400-408 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/data/worker.rs:45— viewer/src/data/worker.rs:45-53 | viewer/src/schema/worker.rs:43-51 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/assets/viewers/layer/scene/mod.rs:3424— viewer/src/assets/viewers/layer/scene/mod.rs:3424-3432 | viewer/src/assets/viewers/layer/scene/mod.rs:3460-3468 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) shadermerge/src/pick.rs:13— shadermerge/src/pick.rs:13-21 | viewer/src/assets/viewers/shpk/keys.rs:62-70 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/sheet/filter/complex_filter_parse.rs:30— viewer/src/sheet/filter/complex_filter_parse.rs:30-38 | viewer/src/sheet/filter/complex_filter_parse.rs:288-296 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/assets/viewers/mdl/program.rs:2133— viewer/src/assets/viewers/mdl/program.rs:2133-2141 | viewer/src/assets/viewers/shader/mod.rs:204-212 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) viewer/src/data/sqpack.rs:43— viewer/src/data/sqpack.rs:43-51 | viewer/src/data/sqpack.rs:59-70 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (8 lines × 2) luadec/src/read.rs:830— luadec/src/read.rs:830-837 | luadec/src/read.rs:907-914 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `luadec/src/read.rs:830` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) shadermerge/src/factor.rs:341— shadermerge/src/factor.rs:341-348 | shadermerge/src/factor.rs:377-384 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shadermerge/src/factor.rs:341` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) shadermerge/src/pick.rs:14— shadermerge/src/pick.rs:14-21 | viewer/src/assets/viewers/shpk/keys.rs:63-70 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/avfx/mod.rs:160— viewer/src/assets/viewers/avfx/mod.rs:160-167 | viewer/src/assets/viewers/mdl/mod.rs:2129-2136 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:1425— viewer/src/assets/viewers/mdl/deferred.rs:1425-1432 | viewer/src/assets/viewers/mdl/deferred.rs:4484-4491 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:1425` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/shader/code.rs:36— viewer/src/assets/viewers/shader/code.rs:36-43 | viewer/src/assets/viewers/shpk/merged.rs:82-89 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/shader/code.rs:36` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/avfx/program.rs:444— viewer/src/assets/viewers/avfx/program.rs:444-451 | viewer/src/assets/viewers/mdl/program.rs:2809-2816 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/program.rs:444` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/eid.rs:86— viewer/src/assets/viewers/eid.rs:86-93 | viewer/src/assets/viewers/skp.rs:186-193 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) viewer/src/assets/viewers/avfx/program.rs:167— viewer/src/assets/viewers/avfx/program.rs:167-174 | viewer/src/assets/viewers/mdl/program.rs:2022-2029 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Renderer::render (cognitive 123) viewer/src/assets/viewers/layer/scene/gpu.rs:1366— Renderer::render has cognitive complexity 123 (threshold 15). Drivers by points: if/else 21 (66 pts), match/switch 8 (30 pts), loops 7 (24 pts), boolean chains 3 (nesting depth added 84). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::leg (cognitive 67) viewer/src/assets/viewers/layer/scene/gpu.rs:1064— Renderer::leg has cognitive complexity 67 (threshold 15). Drivers by points: if/else 10 (34 pts), match/switch 8 (22 pts), loops 4 (10 pts), boolean chains 1 (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::shadow (cognitive 38) viewer/src/assets/viewers/layer/scene/gpu.rs:638— Renderer::shadow has cognitive complexity 38 (threshold 15). Drivers by points: if/else 6 (21 pts), loops 4 (10 pts), match/switch 2 (7 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::draw (cognitive 31) viewer/src/assets/viewers/layer/scene/gpu.rs:393— Renderer::draw has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 7, match/switch 2 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::mirror_water (cognitive 31) viewer/src/assets/viewers/layer/scene/gpu.rs:842— Renderer::mirror_water has cognitive complexity 31 (threshold 15). Drivers by points: loops 5 (12 pts), if/else 4 (10 pts), match/switch 3 (8 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::grass (cognitive 18) viewer/src/assets/viewers/layer/scene/gpu.rs:1241— Renderer::grass has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (6 pts), loops 3 (6 pts), match/switch 2 (6 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Renderer::textures (cognitive 16) viewer/src/assets/viewers/layer/scene/gpu.rs:565— Renderer::textures has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 6 (14 pts), loops 2 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
TooManyMethods: Buffers viewer/src/assets/viewers/mdl/deferred.rs:1000— TooManyMethods — 88 methods. The bar is 30 methods; this is 58 over it, 2.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Scene viewer/src/assets/viewers/layer/scene/mod.rs:858— TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: App viewer/src/app.rs:248— TooManyMethods — 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. Most of these members implement app.App (54 of 54 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: CharacterBuilder viewer/src/character/mod.rs:284— TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Rendered viewer/src/assets/viewers/mdl/mod.rs:469— TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Reader luadec/src/read.rs:47— TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Animation viewer/src/assets/viewers/mdl/skin.rs:939— TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×7
Edited copy of a member (8 corresponding lines) viewer/src/assets/viewers/mdl/deform.rs:142— viewer/src/assets/viewers/mdl/deform.rs:142-149 | viewer/src/assets/viewers/mdl/program.rs:368-376 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/assets/viewers/eqp.rs:130— viewer/src/assets/viewers/eqp.rs:130-137 | viewer/src/assets/viewers/gmp.rs:85-101 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/assets/viewers/eqdp.rs:104— viewer/src/assets/viewers/eqdp.rs:104-112 | viewer/src/assets/viewers/evp.rs:73-80 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/utils/export.rs:19— viewer/src/utils/export.rs:19-26 | viewer/src/utils/tex_export.rs:262-269 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/assets/viewers/avfx/program.rs:614— viewer/src/assets/viewers/avfx/program.rs:614-621 | viewer/src/assets/viewers/mdl/program.rs:4077-4084 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/assets/viewers/avfx/mod.rs:593— viewer/src/assets/viewers/avfx/mod.rs:593-600 | viewer/src/assets/viewers/avfx/mod.rs:602-613 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) viewer/src/settings.rs:297— viewer/src/settings.rs:297-304 | web/src/data.rs:374-381 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (10 lines × 2) shadermerge/src/check.rs:131— shadermerge/src/check.rs:131-140 | shadermerge/src/merge.rs:80-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `shadermerge/src/check.rs:131` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) shadermerge/src/merge.rs:807— shadermerge/src/merge.rs:807-816 | shadermerge/src/merge.rs:1010-1019 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shadermerge/src/merge.rs:805` calls `get`, `ok_or` and `shadermerge/src/merge.rs:1007` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) viewer/src/assets/viewers/cutb/play.rs:1154— viewer/src/assets/viewers/cutb/play.rs:1154-1163 | viewer/src/quests/detail.rs:501-510 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/cutb/play.rs:1154` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:806— viewer/src/assets/viewers/layer/scene/gpu.rs:806-815 | viewer/src/assets/viewers/layer/scene/gpu.rs:1041-1050 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/layer/scene/gpu.rs:803` calls `keep` and `viewer/src/assets/viewers/layer/scene/gpu.rs:1040` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) viewer/src/data/web.rs:74— viewer/src/data/web.rs:74-83 | viewer/src/data/web.rs:105-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) web/src/data.rs:540— web/src/data.rs:540-549 | web/src/data.rs:646-655 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `web/src/data.rs:540` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:3474— viewer/src/assets/viewers/layer/scene/mod.rs:3474-3483 | viewer/src/assets/viewers/mdl/mod.rs:2940-2949 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:3474` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Outbound HTTP without resilience viewer/src/utils/webreq.rs:163— `ureq::Agent::config_builder(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/data.rs:55— `reqwest::Client::builder(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/paths/mod.rs:154— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/paths/report.rs:106— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/routes/api.rs:683— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/routes/api.rs:738— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience web/src/routes/api.rs:875— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
shadermerge::factor::factor (cognitive 105) shadermerge/src/factor.rs:165— shadermerge::factor::factor has cognitive complexity 105 (threshold 15). Drivers by points: if/else 17 (61 pts), loops 12 (37 pts), boolean chains 5, match/switch 1 (2 pts) (nesting depth added 70). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
shadermerge::merge::merge (cognitive 88) shadermerge/src/merge.rs:98— shadermerge::merge::merge has cognitive complexity 88 (threshold 15). Drivers by points: loops 34 (53 pts), if/else 10 (21 pts), match/switch 6 (12 pts), boolean chains 2 (nesting depth added 36). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
shadermerge::merge::preprocess (cognitive 53) shadermerge/src/merge.rs:902— shadermerge::merge::preprocess has cognitive complexity 53 (threshold 15). Drivers by points: if/else 11 (29 pts), loops 7 (15 pts), boolean chains 6, match/switch 2 (3 pts) (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
shadermerge::merge::guards (cognitive 32) shadermerge/src/merge.rs:776— shadermerge::merge::guards has cognitive complexity 32 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 4 (8 pts), match/switch 3 (6 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
shadermerge::factor::prove (cognitive 21) shadermerge/src/factor.rs:372— shadermerge::factor::prove has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 5 (9 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
shadermerge::pick::cover (cognitive 19) shadermerge/src/pick.rs:199— shadermerge::pick::cover has cognitive complexity 19 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 4 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::draw_menubar (cognitive 54) viewer/src/app.rs:543— App::draw_menubar has cognitive complexity 54 (threshold 15). Drivers by points: if/else 28 (42 pts), loops 6 (8 pts), boolean chains 3, match/switch 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::draw_sheet_list (cognitive 36) viewer/src/app.rs:920— App::draw_sheet_list has cognitive complexity 36 (threshold 15). Drivers by points: if/else 19 (31 pts), match/switch 2 (3 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::draw_sheet_data (cognitive 30) viewer/src/app.rs:1115— App::draw_sheet_data has cognitive complexity 30 (threshold 15). Drivers by points: if/else 19 (22 pts), match/switch 4 (5 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
App::draw_goto (cognitive 18) viewer/src/app.rs:481— App::draw_goto has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (9 pts), match/switch 3 (8 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::on_named_sheet (cognitive 18) viewer/src/app.rs:1543— App::on_named_sheet has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (18 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::command_save_all_schemas (cognitive 18) viewer/src/app.rs:1847— App::command_save_all_schemas has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Duplicated block (5 lines × 2) viewer/src/character/menus.rs:227— viewer/src/character/menus.rs:227-231 | viewer/src/character/menus.rs:485-489 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/menus.rs:227` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) viewer/src/assets/viewers/avfx/mod.rs:81— viewer/src/assets/viewers/avfx/mod.rs:81-85 | viewer/src/assets/viewers/mdl/mod.rs:200-204 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (5 lines × 2) viewer/src/music.rs:253— viewer/src/music.rs:253-257 | viewer/src/zones/mod.rs:179-183 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) viewer/src/sheet/cell.rs:545— viewer/src/sheet/cell.rs:545-549 | viewer/src/sheet/sheet_table.rs:169-173 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/sheet/cell.rs:545` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) luadec/src/read.rs:864— luadec/src/read.rs:864-868 | luadec/src/read.rs:878-882 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) viewer/src/assets/viewers/mdl/mod.rs:1922— viewer/src/assets/viewers/mdl/mod.rs:1922-1926 | viewer/src/assets/viewers/mdl/mod.rs:1976-1980 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/mod.rs:1922` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
TooManyFields: CharacterBuilder viewer/src/character/mod.rs:284— TooManyFields — 90 stored fields beside 53 methods. The bar is 30 stored fields; this is 60 over it, 3.00× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: Scene viewer/src/assets/viewers/layer/scene/mod.rs:858— TooManyFields — 89 stored fields beside 63 methods. The bar is 30 stored fields; this is 59 over it, 2.97× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: Buffers viewer/src/assets/viewers/mdl/deferred.rs:1000— TooManyFields — 62 stored fields beside 88 methods. The bar is 30 stored fields; this is 32 over it, 2.07× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: Rendered viewer/src/assets/viewers/mdl/mod.rs:469— TooManyFields — 52 stored fields beside 48 methods. The bar is 30 stored fields; this is 22 over it, 1.73× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: Location viewer/src/assets/viewers/layer/scene/preset.rs:115— TooManyFields — 35 stored fields. The bar is 30 stored fields; this is 5 over it, 1.17× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×5
Members sharing a duplicated core (4 members, 50+ identical tokens) shadermerge/src/pick.rs:153— shadermerge/src/pick.rs:153-192 | viewer/src/assets/viewers/avfx/program.rs:280-331 | viewer/src/assets/viewers/mdl/program.rs:2145-2168 | viewer/src/assets/viewers/shader/code.rs:184-249 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) viewer/src/assets/viewers/avfx/gpu.rs:549— viewer/src/assets/viewers/avfx/gpu.rs:549-584 | viewer/src/assets/viewers/mdl/deferred.rs:5145-5211 | viewer/src/assets/viewers/pcb/gpu.rs:175-202 | viewer/src/assets/viewers/placed/gpu.rs:219-246 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) viewer/src/assets/viewers/avfx/mod.rs:809— viewer/src/assets/viewers/avfx/mod.rs:809-898 | viewer/src/assets/viewers/layer/mod.rs:849-1067 | viewer/src/assets/viewers/uld.rs:1235-1341 | viewer/src/assets/viewers/zone/envs.rs:202-303 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) viewer/src/assets/viewers/layer/scene/gpu.rs:644— viewer/src/assets/viewers/layer/scene/gpu.rs:644-761 | viewer/src/assets/viewers/layer/scene/gpu.rs:847-951 | viewer/src/assets/viewers/layer/scene/gpu.rs:1073-1236 | viewer/src/assets/viewers/layer/scene/gpu.rs:1372-1639 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) viewer/src/assets/viewers/layer/scene/gpu.rs:777— viewer/src/assets/viewers/layer/scene/gpu.rs:777-831 | viewer/src/assets/viewers/layer/scene/gpu.rs:1023-1058 | viewer/src/assets/viewers/mdl/gpu.rs:1016-1124 | viewer/src/assets/viewers/mdl/gpu.rs:1146-1249 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (5 lines × 3) viewer/src/assets/viewers/avfx/mod.rs:840— viewer/src/assets/viewers/avfx/mod.rs:840-844 | viewer/src/assets/viewers/layer/mod.rs:1011-1015 | viewer/src/assets/viewers/zone/envs.rs:232-236 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/layer/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 66 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:840` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 3) viewer/src/assets/viewers/mdl/deferred.rs:1704— viewer/src/assets/viewers/mdl/deferred.rs:1704-1710 | viewer/src/assets/viewers/mdl/deferred.rs:4309-4313 | viewer/src/assets/viewers/mdl/deferred.rs:4392-4396 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:1704` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 3) viewer/src/assets/viewers/uld.rs:1397— viewer/src/assets/viewers/uld.rs:1397-1401 | viewer/src/assets/viewers/uld.rs:1412-1416 | viewer/src/assets/viewers/zone/envs.rs:461-465 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/uld.rs:1397` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/uld.rs:1418` calls `is_empty` and `viewer/src/assets/viewers/uld.rs:1402` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 3) viewer/src/assets/viewers/mdl/program.rs:2380— viewer/src/assets/viewers/mdl/program.rs:2380-2384 | viewer/src/assets/viewers/mdl/program.rs:2550-2555 | viewer/src/assets/viewers/mdl/program.rs:2648-2652 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (5 lines × 3) viewer/src/assets/viewers/mdl/export.rs:1182— viewer/src/assets/viewers/mdl/export.rs:1182-1186 | viewer/src/assets/viewers/mdl/export.rs:1208-1212 | viewer/src/assets/viewers/mdl/export.rs:1221-1225 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/export.rs:1182` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
CharacterBuilder::poll (cyclomatic 81) viewer/src/character/mod.rs:692— CharacterBuilder::poll has cyclomatic complexity 81 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
CharacterBuilder::side_panel (cyclomatic 50) viewer/src/character/mod.rs:2637— CharacterBuilder::side_panel has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CharacterBuilder::appearance (cyclomatic 41) viewer/src/character/mod.rs:1955— CharacterBuilder::appearance has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CharacterBuilder::slot_ui (cyclomatic 22) viewer/src/character/mod.rs:1721— CharacterBuilder::slot_ui has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Rendered::poll (cyclomatic 71) viewer/src/assets/viewers/mdl/mod.rs:1673— Rendered::poll has cyclomatic complexity 71 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Rendered::details_ui (cyclomatic 38) viewer/src/assets/viewers/mdl/mod.rs:3697— Rendered::details_ui has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Rendered::viewport (cyclomatic 30) viewer/src/assets/viewers/mdl/mod.rs:2373— Rendered::viewport has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Rendered::translate (cyclomatic 21) viewer/src/assets/viewers/mdl/mod.rs:3129— Rendered::translate has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
shadermerge::merge::merge (cyclomatic 56) shadermerge/src/merge.rs:98— shadermerge::merge::merge has cyclomatic complexity 56 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
shadermerge::factor::factor (cyclomatic 36) shadermerge/src/factor.rs:165— shadermerge::factor::factor has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
shadermerge::merge::preprocess (cyclomatic 28) shadermerge/src/merge.rs:902— shadermerge::merge::preprocess has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
shadermerge::merge::guards (cyclomatic 17) shadermerge/src/merge.rs:776— shadermerge::merge::guards has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CharacterBuilder::appearance (cognitive 95) viewer/src/character/mod.rs:1955— CharacterBuilder::appearance has cognitive complexity 95 (threshold 15). Drivers by points: if/else 19 (72 pts), match/switch 4 (10 pts), loops 3 (8 pts), boolean chains 5 (nesting depth added 64). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
CharacterBuilder::poll (cognitive 88) viewer/src/character/mod.rs:692— CharacterBuilder::poll has cognitive complexity 88 (threshold 15). Drivers by points: if/else 30 (38 pts), match/switch 23 (35 pts), loops 4 (9 pts), boolean chains 6 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CharacterBuilder::side_panel (cognitive 66) viewer/src/character/mod.rs:2637— CharacterBuilder::side_panel has cognitive complexity 66 (threshold 15). Drivers by points: if/else 17 (41 pts), loops 7 (17 pts), match/switch 3 (6 pts), boolean chains 2 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CharacterBuilder::slot_ui (cognitive 26) viewer/src/character/mod.rs:1721— CharacterBuilder::slot_ui has cognitive complexity 26 (threshold 15). Drivers by points: match/switch 7 (12 pts), if/else 8 (10 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
AssetBrowser::draw_search (cognitive 45) viewer/src/assets/mod.rs:1311— AssetBrowser::draw_search has cognitive complexity 45 (threshold 15). Drivers by points: if/else 22 (38 pts), match/switch 2 (4 pts), loops 2 (3 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AssetBrowser::detail_panel (cognitive 41) viewer/src/assets/mod.rs:1629— AssetBrowser::detail_panel has cognitive complexity 41 (threshold 15). Drivers by points: if/else 18 (30 pts), match/switch 5 (7 pts), boolean chains 4 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AssetBrowser::draw_tree (cognitive 23) viewer/src/assets/mod.rs:1222— AssetBrowser::draw_tree has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (20 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AssetBrowser::advance_scan (cognitive 23) viewer/src/assets/mod.rs:1499— AssetBrowser::advance_scan has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 3 (8 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App::draw_menubar (cyclomatic 41) viewer/src/app.rs:543— App::draw_menubar has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
App::draw_sheet_data (cyclomatic 32) viewer/src/app.rs:1115— App::draw_sheet_data has cyclomatic complexity 32 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
App::draw_sheet_list (cyclomatic 24) viewer/src/app.rs:920— App::draw_sheet_list has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Renderer::render (cyclomatic 40) viewer/src/assets/viewers/layer/scene/gpu.rs:1366— Renderer::render has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Renderer::leg (cyclomatic 28) viewer/src/assets/viewers/layer/scene/gpu.rs:1064— Renderer::leg has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Renderer::draw (cyclomatic 20) viewer/src/assets/viewers/layer/scene/gpu.rs:393— Renderer::draw has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AssetBrowser::detail_panel (cyclomatic 33) viewer/src/assets/mod.rs:1629— AssetBrowser::detail_panel has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AssetBrowser::draw_search (cyclomatic 24) viewer/src/assets/mod.rs:1311— AssetBrowser::draw_search has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AssetBrowser::advance_scan (cyclomatic 18) viewer/src/assets/mod.rs:1499— AssetBrowser::advance_scan has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Synth::survey (cyclomatic 24) shadermerge/src/synth.rs:166— Synth::survey has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Synth::build (cyclomatic 24) shadermerge/src/synth.rs:569— Synth::build has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Synth::value (cyclomatic 23) shadermerge/src/synth.rs:426— Synth::value has cyclomatic complexity 23 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
TodoComment viewer/src/utils/tex_loader.rs:368— // TODO: seems really wasteful to copy the entire image in memory just to reassign the channels. think of a better way to do this. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment viewer/src/utils/tex_loader.rs:369— // TODO: use array_chunks once it hits stable — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment viewer/src/utils/tex_loader.rs:441— // TODO: are there any non-failure cases here? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Synth::build (cognitive 54) shadermerge/src/synth.rs:569— Synth::build has cognitive complexity 54 (threshold 15). Drivers by points: if/else 11 (34 pts), loops 5 (10 pts), match/switch 3 (8 pts), boolean chains 2 (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Synth::value (cognitive 36) shadermerge/src/synth.rs:426— Synth::value has cognitive complexity 36 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 4 (10 pts), match/switch 4 (9 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Synth::survey (cognitive 32) shadermerge/src/synth.rs:166— Synth::survey has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (20 pts), loops 5 (6 pts), match/switch 2 (4 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Game::fill (cognitive 36) viewer/src/assets/viewers/mdl/gpu.rs:781— Game::fill has cognitive complexity 36 (threshold 15). Drivers by points: if/else 4 (16 pts), match/switch 4 (13 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Game::resolve (cognitive 28) viewer/src/assets/viewers/mdl/gpu.rs:1008— Game::resolve has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (13 pts), match/switch 5 (11 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Game::bind (cognitive 19) viewer/src/assets/viewers/mdl/gpu.rs:1255— Game::bind has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 6 (14 pts), loops 5 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SheetTable::cell_ui (cognitive 32) viewer/src/sheet/sheet_table.rs:687— SheetTable::cell_ui has cognitive complexity 32 (threshold 15). Drivers by points: if/else 18 (24 pts), match/switch 4 (8 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SheetTable::spawn_filter (cognitive 19) viewer/src/sheet/sheet_table.rs:325— SheetTable::spawn_filter has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 2 (3 pts) (nesting depth added 7). Of this number, 10 points are the body's own statements and 9 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SheetTable::header_cell_ui (cognitive 18) viewer/src/sheet/sheet_table.rs:610— SheetTable::header_cell_ui has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program::stars (cognitive 28) viewer/src/assets/viewers/mdl/program.rs:2377— Program::stars has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 9 (13 pts), match/switch 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program::assemble (cognitive 26) viewer/src/assets/viewers/mdl/program.rs:2713— Program::assemble has cognitive complexity 26 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 6 (9 pts), match/switch 3 (5 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program::build (cognitive 18) viewer/src/assets/viewers/avfx/program.rs:377— Program::build has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 5 (7 pts), boolean chains 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IconBrowser::draw_detail (cognitive 21) viewer/src/icons/mod.rs:798— IconBrowser::draw_detail has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 4, boolean chains 2, loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IconBrowser::draw_categories (cognitive 17) viewer/src/icons/mod.rs:369— IconBrowser::draw_categories has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 3, loops 1 (2 pts), match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IconBrowser::draw_grid (cognitive 16) viewer/src/icons/mod.rs:548— IconBrowser::draw_grid has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×3
Edited copy of a member (12 corresponding lines) viewer/src/utils/tex_loader.rs:206— viewer/src/utils/tex_loader.rs:206-217 | viewer/src/utils/tex_loader.rs:312-327 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) viewer/src/assets/viewers/cutb/mod.rs:49— viewer/src/assets/viewers/cutb/mod.rs:49-60 | viewer/src/assets/viewers/tmb.rs:194-205 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) viewer/src/editable_schema.rs:32— viewer/src/editable_schema.rs:32-43 | viewer/src/editable_schema.rs:45-56 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×3
Edited copy of a member (14 corresponding lines) viewer/src/assets/viewers/mdl/program.rs:2334— viewer/src/assets/viewers/mdl/program.rs:2334-2352 | viewer/src/assets/viewers/mdl/program.rs:2357-2370 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) viewer/src/assets/viewers/layer/lvb.rs:11— viewer/src/assets/viewers/layer/lvb.rs:11-24 | viewer/src/assets/viewers/layer/sgb.rs:11-25 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) viewer/src/data/worker.rs:58— viewer/src/data/worker.rs:58-71 | viewer/src/data/worker.rs:98-113 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×3
Edited copy of a member (4 corresponding lines) viewer/src/assets/viewers/zone/envs.rs:182— viewer/src/assets/viewers/zone/envs.rs:182-185 | viewer/src/assets/viewers/zone/instanced.rs:271-274 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) viewer/src/assets/viewers/zone/envs.rs:187— viewer/src/assets/viewers/zone/envs.rs:187-190 | viewer/src/assets/viewers/zone/instanced.rs:276-279 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) viewer/src/assets/viewers/zone/envs.rs:192— viewer/src/assets/viewers/zone/envs.rs:192-195 | viewer/src/assets/viewers/zone/instanced.rs:281-289 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (19 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:1190— viewer/src/assets/viewers/layer/scene/gpu.rs:1190-1208 | viewer/src/assets/viewers/layer/scene/gpu.rs:1477-1495 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/layer/scene/gpu.rs:1210` calls `color_mask` and `viewer/src/assets/viewers/layer/scene/gpu.rs:1496` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:1779— viewer/src/assets/viewers/layer/scene/gpu.rs:1779-1797 | viewer/src/assets/viewers/layer/scene/gpu.rs:1827-1845 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `indices` to `&[u32]` in one and `&[u16]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) viewer/src/music.rs:323— viewer/src/music.rs:323-341 | viewer/src/zones/mod.rs:256-274 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (16 lines × 2) viewer/src/assets/viewers/avfx/program.rs:219— viewer/src/assets/viewers/avfx/program.rs:219-234 | viewer/src/assets/viewers/mdl/program.rs:2083-2098 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/program.rs:219` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) viewer/src/assets/viewers/layer/mod.rs:1002— viewer/src/assets/viewers/layer/mod.rs:1002-1017 | viewer/src/assets/viewers/zone/envs.rs:223-238 — before extracting anything, compare `viewer/src/assets/viewers/layer/mod.rs` and `viewer/src/assets/viewers/zone/envs.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/mod.rs:1002` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) viewer/src/music.rs:284— viewer/src/music.rs:284-299 | viewer/src/zones/mod.rs:214-229 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) viewer/src/assets/viewers/mdl/dye.rs:145— viewer/src/assets/viewers/mdl/dye.rs:145-158 | viewer/src/assets/viewers/mdl/export.rs:357-370 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/dye.rs:145` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:1386— viewer/src/assets/viewers/mdl/deferred.rs:1386-1399 | viewer/src/assets/viewers/mdl/deferred.rs:4447-4460 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:1386` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/mdl/deferred.rs:4445` calls `extend`, `take` and `viewer/src/assets/viewers/mdl/deferred.rs:1384` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:3542— viewer/src/assets/viewers/mdl/deferred.rs:3542-3555 | viewer/src/assets/viewers/mdl/deferred.rs:4346-4359 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:3542` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/mdl/deferred.rs:4345` calls `clone` and `viewer/src/assets/viewers/mdl/deferred.rs:3541` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 3) viewer/src/character/mod.rs:3241— viewer/src/character/mod.rs:3241-3248 | viewer/src/quests/rewards.rs:146-153 | viewer/src/sheet/cell.rs:547-554 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/mod.rs:3241` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 3) web/src/queue.rs:98— web/src/queue.rs:98-105 | web/src/queue.rs:114-121 | web/src/queue.rs:130-137 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `web/src/queue.rs:98` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 3) viewer/src/assets/mod.rs:1186— viewer/src/assets/mod.rs:1186-1193 | viewer/src/assets/mod.rs:1836-1843 | viewer/src/icons/mod.rs:534-541 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/mod.rs:1186` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (7 lines × 3) viewer/src/assets/viewers/avfx/gpu.rs:518— viewer/src/assets/viewers/avfx/gpu.rs:518-525 | viewer/src/assets/viewers/mdl/deferred.rs:4915-4921 | viewer/src/assets/viewers/mdl/grid.rs:87-93 — before extracting anything, compare `viewer/src/assets/viewers/avfx/gpu.rs` and `viewer/src/assets/viewers/mdl/deferred.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/gpu.rs:518` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) viewer/src/assets/viewers/layer/scene/mod.rs:4519— viewer/src/assets/viewers/layer/scene/mod.rs:4519-4525 | viewer/src/assets/viewers/pcb.rs:707-713 | viewer/src/assets/viewers/placed/mod.rs:182-188 — before extracting anything, compare `viewer/src/assets/viewers/pcb.rs` and `viewer/src/assets/viewers/placed/mod.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/mod.rs:4519` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 3) viewer/src/assets/viewers/evp.rs:21— viewer/src/assets/viewers/evp.rs:21-27 | viewer/src/assets/viewers/phyb.rs:27-39 | viewer/src/assets/viewers/skp.rs:67-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/evp.rs:21` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
IC1 · Incompleteness & stubs· Empty method body · ×3
Empty method body — does nothing with its inputs viewer/src/audio/native.rs:107— `set_metadata` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Empty method body — does nothing with its inputs viewer/src/backend.rs:137— `set_icons` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Empty method body — does nothing with its inputs viewer/src/utils/icon_loader.rs:95— `forget` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×2
Animation without a prefers-reduced-motion guard viewer/index.html:221— `.spinner` moves (`animation: rotator 1.4s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard viewer/index.html:238— `.path` moves (`animation: dash 1.4s ease-in-out infinite, colors 5.6s ease-in-out infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Buffers::pass (cyclomatic 61) viewer/src/assets/viewers/mdl/deferred.rs:4022— Buffers::pass has cyclomatic complexity 61 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Buffers::attach (cyclomatic 19) viewer/src/assets/viewers/mdl/deferred.rs:1362— Buffers::attach has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This is NOT this file's highest cyclomatic complexity: Buffers::engine (cyclomatic 22) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded function is counted neither in this dimension's figures nor in its score.
luadec::read::sticky (cyclomatic 53) luadec/src/read.rs:504— luadec::read::sticky has cyclomatic complexity 53 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
luadec::expr::write_stat (cyclomatic 20) luadec/src/expr.rs:426— luadec::expr::write_stat has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Reader::walk (cyclomatic 49) luadec/src/read.rs:1641— Reader::walk has cyclomatic complexity 49 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Reader::shortcut (cyclomatic 16) luadec/src/read.rs:1482— Reader::shortcut has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: luadec::read::touches (cyclomatic 18) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded function is counted neither in this dimension's figures nor in its score.
MusicPlayer::draw_player (cyclomatic 25) viewer/src/music.rs:701— MusicPlayer::draw_player has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MusicPlayer::poll (cyclomatic 20) viewer/src/music.rs:283— MusicPlayer::poll has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Worn::shows (cyclomatic 23) viewer/src/character/gating.rs:69— Worn::shows has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Worn::covers (cyclomatic 21) viewer/src/character/gating.rs:128— Worn::covers has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program::stars (cyclomatic 17) viewer/src/assets/viewers/mdl/program.rs:2377— Program::stars has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: viewer::assets::viewers::mdl::program::parameter (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded function is counted neither in this dimension's figures nor in its score.
Program::assemble (cyclomatic 17) viewer/src/assets/viewers/mdl/program.rs:2713— Program::assemble has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions. This is NOT this file's highest cyclomatic complexity: viewer::assets::viewers::mdl::program::parameter (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded function is counted neither in this dimension's figures nor in its score.
luadec::read::sticky (cognitive 105) luadec/src/read.rs:504— luadec::read::sticky has cognitive complexity 105 (threshold 15). Drivers by points: if/else 21 (61 pts), loops 7 (16 pts), boolean chains 14, match/switch 6 (14 pts) (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
luadec::expr::write_stat (cognitive 20) luadec/src/expr.rs:426— luadec::expr::write_stat has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 2 (4 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Buffers::pass (cognitive 54) viewer/src/assets/viewers/mdl/deferred.rs:4022— Buffers::pass has cognitive complexity 54 (threshold 15). Drivers by points: match/switch 16 (43 pts), if/else 6 (8 pts), loops 2, boolean chains 1 (nesting depth added 29). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Buffers::attach (cognitive 24) viewer/src/assets/viewers/mdl/deferred.rs:1362— Buffers::attach has cognitive complexity 24 (threshold 15). Drivers by points: loops 9 (13 pts), if/else 8 (10 pts), boolean chains 1 (nesting depth added 6). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Reader::walk (cognitive 41) luadec/src/read.rs:1641— Reader::walk has cognitive complexity 41 (threshold 15). Drivers by points: if/else 9 (18 pts), match/switch 8 (14 pts), loops 4 (8 pts), boolean chains 1 (nesting depth added 19). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Reader::shortcut (cognitive 17) luadec/src/read.rs:1482— Reader::shortcut has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 3, boolean chains 2, match/switch 2 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MusicPlayer::poll (cognitive 28) viewer/src/music.rs:283— MusicPlayer::poll has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13 (19 pts), match/switch 3 (6 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MusicPlayer::draw_player (cognitive 27) viewer/src/music.rs:701— MusicPlayer::draw_player has cognitive complexity 27 (threshold 15). Drivers by points: if/else 19 (24 pts), boolean chains 2, match/switch 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CompiledFilterInput::match_part (cognitive 26) viewer/src/sheet/filter/input.rs:146— CompiledFilterInput::match_part has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (17 pts), loops 3 (6 pts), boolean chains 2, match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
CompiledFilterInput::score_part (cognitive 23) viewer/src/sheet/filter/input.rs:223— CompiledFilterInput::score_part has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 3 (6 pts), match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SchemaColumn::get_columns_inner (cognitive 25) viewer/src/sheet/schema_column.rs:35— SchemaColumn::get_columns_inner has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 2 (6 pts), loops 2 (4 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SchemaColumn::resolve_placeholders (cognitive 22) viewer/src/sheet/schema_column.rs:107— SchemaColumn::resolve_placeholders has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (21 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Player::transport (cognitive 17) viewer/src/quests/play.rs:227— Player::transport has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 2, loops 1 (2 pts), match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Player::step_ui (cognitive 17) viewer/src/quests/play.rs:336— Player::step_ui has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (9 pts), match/switch 3 (6 pts), loops 1 (2 pts) (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D4 · Code Duplication· Edited copy of a member (35 corresponding lines) · ×2
Edited copy of a member (35 corresponding lines) viewer/src/assets/viewers/mdl/mod.rs:2891— viewer/src/assets/viewers/mdl/mod.rs:2891-2926 | viewer/src/assets/viewers/mdl/mod.rs:2931-2965 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (35 corresponding lines) viewer/src/assets/viewers/layer/sound.rs:155— viewer/src/assets/viewers/layer/sound.rs:155-198 | viewer/src/assets/viewers/scd.rs:166-200 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×2
Edited copy of a member (24 corresponding lines) viewer/src/assets/viewers/layer/scene/mod.rs:3472— viewer/src/assets/viewers/layer/scene/mod.rs:3472-3495 | viewer/src/assets/viewers/layer/scene/mod.rs:3500-3526 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (24 corresponding lines) viewer/src/assets/viewers/layer/scene/gpu.rs:1647— viewer/src/assets/viewers/layer/scene/gpu.rs:1647-1670 | viewer/src/assets/viewers/mdl/deferred.rs:2428-2451 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×2
Edited copy of a member (21 corresponding lines) viewer/src/assets/viewers/layer/scene/mod.rs:4001— viewer/src/assets/viewers/layer/scene/mod.rs:4001-4021 | viewer/src/assets/viewers/mdl/mod.rs:1625-1650 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) viewer/src/sheet/filter/input.rs:124— viewer/src/sheet/filter/input.rs:124-144 | viewer/src/sheet/filter/input.rs:201-221 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×2
Edited copy of a member (17 corresponding lines) viewer/src/utils/tex_loader.rs:329— viewer/src/utils/tex_loader.rs:329-345 | viewer/src/utils/tex_loader.rs:347-365 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) viewer/src/data/web.rs:104— viewer/src/data/web.rs:104-123 | viewer/src/data/web.rs:125-141 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×2
Edited copy of a member (16 corresponding lines) viewer/src/sheet/filter/complex_filter_parse.rs:40— viewer/src/sheet/filter/complex_filter_parse.rs:40-55 | viewer/src/sheet/filter/complex_filter_parse.rs:57-72 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) viewer/src/assets/viewers/mdl/deferred.rs:1985— viewer/src/assets/viewers/mdl/deferred.rs:1985-2006 | viewer/src/assets/viewers/mdl/deferred.rs:3268-3283 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×2
Edited copy of a member (10 corresponding lines) viewer/src/assets/viewers/mdl/mod.rs:1155— viewer/src/assets/viewers/mdl/mod.rs:1155-1164 | viewer/src/assets/viewers/mdl/mod.rs:1184-1195 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) viewer/src/app.rs:1627— viewer/src/app.rs:1627-1636 | viewer/src/app.rs:1736-1745 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×2
Edited copy of a member (13 corresponding lines) viewer/src/assets/viewers/font.rs:331— viewer/src/assets/viewers/font.rs:331-344 | viewer/src/assets/viewers/icons.rs:146-158 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) viewer/src/assets/viewers/avfx/program.rs:347— viewer/src/assets/viewers/avfx/program.rs:347-359 | viewer/src/assets/viewers/mdl/program.rs:2220-2234 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×2
Edited copy of a member (11 corresponding lines) viewer/src/utils/tex_loader.rs:271— viewer/src/utils/tex_loader.rs:271-281 | viewer/src/utils/tex_loader.rs:283-298 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) viewer/src/sheet/table_context.rs:293— viewer/src/sheet/table_context.rs:293-304 | viewer/src/sheet/table_context.rs:312-322 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 9+ corresponding lines) · ×2
Edited copies of one member (3 members, 9+ corresponding lines) viewer/src/utils/tex_loader.rs:194— viewer/src/utils/tex_loader.rs:194-202 | viewer/src/utils/tex_loader.rs:220-228 | viewer/src/utils/tex_loader.rs:367-380 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 9+ corresponding lines) viewer/src/app.rs:1661— viewer/src/app.rs:1661-1672 | viewer/src/app.rs:1699-1707 | viewer/src/app.rs:1769-1780 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (27 lines × 2) viewer/src/assets/viewers/avfx/program.rs:283— viewer/src/assets/viewers/avfx/program.rs:283-309 | viewer/src/assets/viewers/mdl/program.rs:2172-2198 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (27 lines × 2) viewer/src/music.rs:547— viewer/src/music.rs:547-573 | viewer/src/zones/mod.rs:364-390 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/music.rs:547` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (19–20 lines × 2) viewer/src/assets/viewers/mdl/program.rs:2380— viewer/src/assets/viewers/mdl/program.rs:2380-2398 | viewer/src/assets/viewers/mdl/program.rs:2550-2569 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/program.rs:2380` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (19–20 lines × 2) viewer/src/setup.rs:194— viewer/src/setup.rs:194-212 | viewer/src/setup.rs:481-500 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) viewer/src/assets/viewers/cutb/sound.rs:153— viewer/src/assets/viewers/cutb/sound.rs:153-170 | viewer/src/assets/viewers/layer/scene/sound.rs:115-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) viewer/src/assets/viewers/pcb/gpu.rs:213— viewer/src/assets/viewers/pcb/gpu.rs:213-230 | viewer/src/assets/viewers/placed/gpu.rs:258-275 — `viewer/src/assets/viewers/pcb/gpu.rs` and `viewer/src/assets/viewers/placed/gpu.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 68 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb/gpu.rs:213` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `indices` to `&[u32]` in one and `&[u16]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (17 lines × 2) viewer/src/assets/viewers/layer/mod.rs:983— viewer/src/assets/viewers/layer/mod.rs:983-999 | viewer/src/assets/viewers/zone/envs.rs:204-220 — before extracting anything, compare `viewer/src/assets/viewers/layer/mod.rs` and `viewer/src/assets/viewers/zone/envs.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (17 lines × 2) viewer/src/report.rs:76— viewer/src/report.rs:76-92 | web/src/paths/report.rs:73-89 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (15 lines × 3) viewer/src/assets/viewers/avfx/mod.rs:884— viewer/src/assets/viewers/avfx/mod.rs:884-898 | viewer/src/assets/viewers/layer/mod.rs:1053-1067 | viewer/src/assets/viewers/zone/envs.rs:289-303 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/layer/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 66 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:884` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 3) viewer/src/assets/viewers/avfx/program.rs:315— viewer/src/assets/viewers/avfx/program.rs:315-329 | viewer/src/assets/viewers/mdl/program.rs:2153-2167 | viewer/src/assets/viewers/shader/code.rs:233-247 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/program.rs:315` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) viewer/src/assets/viewers/avfx/gpu.rs:552— viewer/src/assets/viewers/avfx/gpu.rs:552-566 | viewer/src/assets/viewers/mdl/deferred.rs:5168-5182 — before extracting anything, compare `viewer/src/assets/viewers/avfx/gpu.rs` and `viewer/src/assets/viewers/mdl/deferred.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/gpu.rs:552` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:609— viewer/src/assets/viewers/layer/scene/gpu.rs:609-623 | viewer/src/assets/viewers/mdl/gpu.rs:1303-1319 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:609` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 3) viewer/src/assets/viewers/mdl/deferred.rs:1457— viewer/src/assets/viewers/mdl/deferred.rs:1457-1470 | viewer/src/assets/viewers/mdl/deferred.rs:1522-1535 | viewer/src/assets/viewers/mdl/deferred.rs:3393-3406 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (14 lines × 3) viewer/src/assets/viewers/mdl/program.rs:2426— viewer/src/assets/viewers/mdl/program.rs:2426-2439 | viewer/src/assets/viewers/mdl/program.rs:2667-2680 | viewer/src/assets/viewers/mdl/program.rs:2783-2796 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/program.rs:2426` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) viewer/src/assets/viewers/avfx/program.rs:431— viewer/src/assets/viewers/avfx/program.rs:431-443 | viewer/src/assets/viewers/mdl/program.rs:2795-2807 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/program.rs:431` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/mdl/program.rs:2808` calls `declarations` and `viewer/src/assets/viewers/avfx/program.rs:444` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 2) viewer/src/assets/viewers/phyb.rs:27— viewer/src/assets/viewers/phyb.rs:27-39 | viewer/src/assets/viewers/skp.rs:67-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/phyb.rs:27` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 2) luadec/src/read.rs:1526— luadec/src/read.rs:1526-1537 | luadec/src/read.rs:1610-1620 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11–12 lines × 2) viewer/src/assets/viewers/mdl/gpu.rs:1108— viewer/src/assets/viewers/mdl/gpu.rs:1108-1118 | viewer/src/assets/viewers/mdl/gpu.rs:1230-1241 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/gpu.rs:1230` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–12 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:932— viewer/src/assets/viewers/layer/scene/gpu.rs:932-939 | viewer/src/assets/viewers/layer/scene/gpu.rs:1500-1511 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:932` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8–12 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:3534— viewer/src/assets/viewers/mdl/deferred.rs:3534-3541 | viewer/src/assets/viewers/mdl/deferred.rs:4333-4344 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:3534` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/mdl/deferred.rs:4345` calls `clone` and `viewer/src/assets/viewers/mdl/deferred.rs:3542` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) shadermerge/src/check.rs:119— shadermerge/src/check.rs:119-128 | shadermerge/src/factor.rs:134-143 | shadermerge/src/merge.rs:51-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `shadermerge/src/check.rs:119` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `shadermerge/src/factor.rs:144` calls `sort_unstable` and `shadermerge/src/check.rs:129` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) viewer/src/icons/mod.rs:345— viewer/src/icons/mod.rs:345-354 | viewer/src/music.rs:545-554 | viewer/src/zones/mod.rs:362-371 — before extracting anything, compare `viewer/src/music.rs` and `viewer/src/zones/mod.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/icons/mod.rs:345` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7–8 lines × 2) viewer/src/assets/viewers/shpk/list.rs:26— viewer/src/assets/viewers/shpk/list.rs:26-32 | viewer/src/assets/viewers/shpk/list.rs:206-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7–8 lines × 2) viewer/src/excel/base.rs:63— viewer/src/excel/base.rs:63-70 | viewer/src/schema/cache.rs:36-42 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/excel/base.rs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 5) viewer/src/assets/viewers/avfx/mod.rs:1080— viewer/src/assets/viewers/avfx/mod.rs:1080-1085 | viewer/src/assets/viewers/layer/scene/mod.rs:4520-4525 | viewer/src/assets/viewers/mdl/mod.rs:2681-2686 | viewer/src/assets/viewers/pcb.rs:708-713 | viewer/src/assets/viewers/placed/mod.rs:183-188 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:1080` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 5) viewer/src/character/mod.rs:1824— viewer/src/character/mod.rs:1824-1829 | viewer/src/character/mod.rs:3240-3245 | viewer/src/quests/rewards.rs:145-150 | viewer/src/sheet/cell.rs:546-551 | viewer/src/sheet/event_icon_type.rs:141-146 — there are 5 copies across 4 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/mod.rs:1824` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (6 lines × 4) shadermerge/src/pick.rs:161— shadermerge/src/pick.rs:161-166 | viewer/src/assets/viewers/avfx/program.rs:314-319 | viewer/src/assets/viewers/mdl/program.rs:2152-2157 | viewer/src/assets/viewers/shader/code.rs:232-237 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `shadermerge/src/pick.rs:161` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 4) viewer/src/assets/viewers/layer/scene/gpu.rs:808— viewer/src/assets/viewers/layer/scene/gpu.rs:808-813 | viewer/src/assets/viewers/layer/scene/gpu.rs:1043-1048 | viewer/src/assets/viewers/mdl/gpu.rs:1050-1055 | viewer/src/assets/viewers/mdl/gpu.rs:1198-1203 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:808` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Off the main sequence: luadec — luadec: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: pathlist — pathlist: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
R10 · Code Duplication· Duplicated block with local edits (45 matched lines × 2 locations) · ×2
Duplicated block with local edits (45 matched lines × 2 locations) smoke/perf.ts:12— smoke/perf.ts:12 · smoke/probe.ts:14 — the two spans are one implementation copied and then locally edited — 380 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block with local edits (45 matched lines × 2 locations) smoke/probe.ts:48— smoke/probe.ts:48 · smoke/smoke.ts:205 — the two spans are one implementation copied and then locally edited — 362 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (16 lines × 2 locations) smoke/burst.ts:130— smoke/burst.ts:130 · smoke/net.ts:153 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
Duplicated block (16 lines × 2 locations) smoke/quests.ts:33— smoke/quests.ts:33 · smoke/smoke.ts:221 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
X2 · Cancellation propagation· Async function without AbortSignal · ×2
Async function without AbortSignal: page smoke/smoke.ts:268— `page` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Async function without AbortSignal: proxyFetches smoke/smoke.ts:526— `proxyFetches` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
AC1 · Text alternatives· <canvas> without a text alternative · ×1
<canvas> without a text alternative viewer/index.html:284— A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
Buffer::fill (cyclomatic 93) viewer/src/assets/viewers/mdl/program.rs:2931— Buffer::fill has cyclomatic complexity 93 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SetupWindow::draw (cyclomatic 70) viewer/src/setup.rs:93— SetupWindow::draw has cyclomatic complexity 70 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Preview::info_ui (cyclomatic 53) viewer/src/assets/viewers/mod.rs:665— Preview::info_ui has cyclomatic complexity 53 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Builder::step (cyclomatic 40) shadermerge/src/canon.rs:424— Builder::step has cyclomatic complexity 40 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
EditableSchema::draw_internal (cyclomatic 35) viewer/src/editable_schema.rs:108— EditableSchema::draw_internal has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
smoke.main (cyclomatic 34) smoke/smoke.ts:566— smoke.main has cyclomatic complexity 34 (threshold 15). Of this number, 22 points are the body's own statements and 12 belong to 6 function items inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
GoToWindow::draw (cyclomatic 31) viewer/src/goto.rs:256— GoToWindow::draw has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PrWindow::draw (cyclomatic 28) viewer/src/pr_window.rs:100— PrWindow::draw has cyclomatic complexity 28 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
perf.main (cyclomatic 28) smoke/perf.ts:95— perf.main has cyclomatic complexity 28 (threshold 15). Of this number, 18 points are the body's own statements and 10 belong to 8 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SqpackWorker::received (cyclomatic 27) viewer/src/worker/sqpack_worker.rs:128— SqpackWorker::received has cyclomatic complexity 27 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Cast::poll (cyclomatic 26) viewer/src/character/stand.rs:283— Cast::poll has cyclomatic complexity 26 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Graph::build (cyclomatic 26) viewer/src/quests/graph.rs:28— Graph::build has cyclomatic complexity 26 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Cue::poll (cyclomatic 25) viewer/src/assets/viewers/mdl/emote.rs:411— Cue::poll has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Animation::walked (cyclomatic 24) viewer/src/assets/viewers/mdl/skin.rs:1731— Animation::walked has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
SmokeApp::ui (cyclomatic 24) viewer/src/smoke.rs:365— SmokeApp::ui has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
smoke.decodePng (cyclomatic 23) smoke/smoke.ts:301— smoke.decodePng has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
index.pipeline_state (cyclomatic 21) REDACTED:63— index.pipeline_state has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
framediff::run (cyclomatic 20) framediff/src/main.rs:84— framediff::run has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Expr::write_bare (cyclomatic 19) luadec/src/expr.rs:185— Expr::write_bare has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Ambient::ui (cyclomatic 19) viewer/src/assets/viewers/layer/scene/ambient.rs:751— Ambient::ui has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
MessageQueue::new (cyclomatic 19) web/src/queue.rs:59— MessageQueue::new has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Simple::at (cyclomatic 18) viewer/src/assets/viewers/avfx/sim.rs:322— Simple::at has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Effects::poll (cyclomatic 18) viewer/src/assets/viewers/mdl/effects.rs:135— Effects::poll has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IconBrowser::draw_detail (cyclomatic 18) viewer/src/icons/mod.rs:798— IconBrowser::draw_detail has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Motion::at (cyclomatic 17) viewer/src/assets/viewers/layer/scene/mod.rs:324— Motion::at has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
IconIndex::build (cyclomatic 17) viewer/src/data/mod.rs:282— IconIndex::build has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CellValue::show (cyclomatic 17) viewer/src/sheet/cell.rs:470— CellValue::show has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SheetTable::cell_ui (cyclomatic 17) viewer/src/sheet/sheet_table.rs:687— SheetTable::cell_ui has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ZoneBrowser::poll (cyclomatic 17) viewer/src/zones/mod.rs:213— ZoneBrowser::poll has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PathIndex::master (cyclomatic 17) web/src/paths/mod.rs:195— PathIndex::master has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
probe.main (cyclomatic 17) smoke/probe.ts:130— probe.main has cyclomatic complexity 17 (threshold 15). Of this number, 12 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Capture::read_xml (cyclomatic 16) framediff/src/capture.rs:106— Capture::read_xml has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Effect::step (cyclomatic 16) viewer/src/assets/viewers/avfx/sim.rs:1316— Effect::step has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Model::draw (cyclomatic 16) viewer/src/assets/viewers/mdl/gpu.rs:457— Model::draw has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Build::poll (cyclomatic 16) viewer/src/character/stand.rs:444— Build::poll has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SetupWindow::draw (cognitive 174) viewer/src/setup.rs:93— SetupWindow::draw has cognitive complexity 174 (threshold 15). Drivers by points: if/else 49 (100 pts), loops 9 (46 pts), match/switch 9 (22 pts), boolean chains 6 (nesting depth added 101). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Buffer::fill (cognitive 110) viewer/src/assets/viewers/mdl/program.rs:2931— Buffer::fill has cognitive complexity 110 (threshold 15). Drivers by points: if/else 52 (56 pts), loops 18 (26 pts), match/switch 11 (17 pts), boolean chains 11 (nesting depth added 18). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Preview::info_ui (cognitive 58) viewer/src/assets/viewers/mod.rs:665— Preview::info_ui has cognitive complexity 58 (threshold 15). Drivers by points: if/else 48 (51 pts), loops 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Builder::step (cognitive 54) shadermerge/src/canon.rs:424— Builder::step has cognitive complexity 54 (threshold 15). Drivers by points: match/switch 10 (21 pts), if/else 11 (17 pts), loops 7 (12 pts), boolean chains 4 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
perf.main (cognitive 49) smoke/perf.ts:95— perf.main has cognitive complexity 49 (threshold 15). Drivers by points: ternaries 10 (21 pts), if/else 12 (18 pts), loops 5 (10 pts) (nesting depth added 22). Of this number, 37 points are the body's own statements and 12 belong to 8 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EditableSchema::draw_internal (cognitive 48) viewer/src/editable_schema.rs:108— EditableSchema::draw_internal has cognitive complexity 48 (threshold 15). Drivers by points: if/else 22 (32 pts), loops 3 (7 pts), match/switch 3 (5 pts), boolean chains 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GoToWindow::draw (cognitive 44) viewer/src/goto.rs:256— GoToWindow::draw has cognitive complexity 44 (threshold 15). Drivers by points: if/else 22 (35 pts), boolean chains 3, loops 1 (3 pts), match/switch 2 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
smoke.main (cognitive 41) smoke/smoke.ts:566— smoke.main has cognitive complexity 41 (threshold 15). Drivers by points: if/else 19 (23 pts), loops 8 (11 pts), boolean chains 5, error handling 1, ternaries 1 (nesting depth added 7). Of this number, 27 points are the body's own statements and 14 belong to 6 function items inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Graph::build (cognitive 40) viewer/src/quests/graph.rs:28— Graph::build has cognitive complexity 40 (threshold 15). Drivers by points: loops 18 (25 pts), match/switch 4 (10 pts), if/else 2 (5 pts) (nesting depth added 16). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Cast::poll (cognitive 38) viewer/src/character/stand.rs:283— Cast::poll has cognitive complexity 38 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 5 (11 pts), match/switch 4 (8 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Cue::poll (cognitive 34) viewer/src/assets/viewers/mdl/emote.rs:411— Cue::poll has cognitive complexity 34 (threshold 15). Drivers by points: if/else 11 (16 pts), match/switch 7 (15 pts), loops 2, boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PrWindow::draw (cognitive 34) viewer/src/pr_window.rs:100— PrWindow::draw has cognitive complexity 34 (threshold 15). Drivers by points: if/else 22 (28 pts), match/switch 2 (3 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Effect::step (cognitive 33) viewer/src/assets/viewers/avfx/sim.rs:1316— Effect::step has cognitive complexity 33 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 5 (10 pts), boolean chains 1, match/switch 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IconIndex::build (cognitive 33) viewer/src/data/mod.rs:282— IconIndex::build has cognitive complexity 33 (threshold 15). Drivers by points: if/else 7 (18 pts), match/switch 4 (11 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PathIndex::master (cognitive 33) web/src/paths/mod.rs:195— PathIndex::master has cognitive complexity 33 (threshold 15). Drivers by points: if/else 7 (23 pts), match/switch 2 (5 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Animation::walked (cognitive 32) viewer/src/assets/viewers/mdl/skin.rs:1731— Animation::walked has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 5 (8 pts), loops 5 (7 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Capture::read_xml (cognitive 30) framediff/src/capture.rs:106— Capture::read_xml has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (25 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
framediff::run (cognitive 29) framediff/src/main.rs:84— framediff::run has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 4 (8 pts), boolean chains 3, match/switch 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageQueue::new (cognitive 29) web/src/queue.rs:59— MessageQueue::new has cognitive complexity 29 (threshold 15). Drivers by points: match/switch 11 (25 pts), if/else 1 (3 pts), loops 1 (nesting depth added 16). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
probe.main (cognitive 29) smoke/probe.ts:130— probe.main has cognitive complexity 29 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 4 (8 pts), ternaries 3 (7 pts), boolean chains 2 (nesting depth added 13). Of this number, 24 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Ambient::ui (cognitive 28) viewer/src/assets/viewers/layer/scene/ambient.rs:751— Ambient::ui has cognitive complexity 28 (threshold 15). Drivers by points: match/switch 6 (12 pts), if/else 8 (10 pts), loops 4 (6 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
smoke.decodePng (cognitive 28) smoke/smoke.ts:301— smoke.decodePng has cognitive complexity 28 (threshold 15). Drivers by points: ternaries 5 (12 pts), if/else 4 (5 pts), boolean chains 4, loops 3 (4 pts), match/switch 1 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SqpackWorker::received (cognitive 27) viewer/src/worker/sqpack_worker.rs:128— SqpackWorker::received has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 4 (7 pts), loops 1 (3 pts) (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
index.pipeline_state (cognitive 27) REDACTED:63— index.pipeline_state has cognitive complexity 27 (threshold 15). Drivers by points: ternaries 6 (11 pts), if/else 7 (8 pts), boolean chains 6, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmokeApp::ui (cognitive 26) viewer/src/smoke.rs:365— SmokeApp::ui has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (18 pts), match/switch 3 (5 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
drive.main (cognitive 26) smoke/drive.ts:114— drive.main has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (12 pts), ternaries 3 (9 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 13). Of this number, 23 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Worn::covers (cognitive 25) viewer/src/character/gating.rs:128— Worn::covers has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (19 pts), boolean chains 6 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Poses::advance (cognitive 24) viewer/src/assets/viewers/mdl/skin.rs:864— Poses::advance has cognitive complexity 24 (threshold 15). Drivers by points: match/switch 5 (15 pts), loops 2 (5 pts), if/else 2 (4 pts) (nesting depth added 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Build::poll (cognitive 24) viewer/src/character/stand.rs:444— Build::poll has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 3 (7 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Effects::poll (cognitive 23) viewer/src/assets/viewers/mdl/effects.rs:135— Effects::poll has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 5, match/switch 3 (5 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
look.main (cognitive 23) smoke/look.ts:60— look.main has cognitive complexity 23 (threshold 15). Drivers by points: loops 6 (16 pts), if/else 3 (4 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 12). Of this number, 20 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
net.main (cognitive 23) smoke/net.ts:60— net.main has cognitive complexity 23 (threshold 15). Drivers by points: loops 7 (18 pts), if/else 2 (3 pts), boolean chains 1, ternaries 1 (nesting depth added 12). Of this number, 20 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Model::draw (cognitive 22) viewer/src/assets/viewers/mdl/gpu.rs:457— Model::draw has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 5 (7 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZoneBrowser::poll (cognitive 22) viewer/src/zones/mod.rs:213— ZoneBrowser::poll has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (13 pts), match/switch 3 (6 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Channels::apply (cognitive 21) viewer/src/assets/mod.rs:2646— Channels::apply has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 2 (3 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SoundStage::poll (cognitive 20) viewer/src/assets/viewers/layer/scene/sound.rs:150— SoundStage::poll has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (10 pts), match/switch 3 (7 pts), loops 2, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Loader::poll (cognitive 20) viewer/src/assets/viewers/pcb.rs:515— Loader::poll has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 3 (6 pts), match/switch 2 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Router::ui (cognitive 20) viewer/src/router/mod.rs:85— Router::ui has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (17 pts), boolean chains 2, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Particles::batch (cognitive 18) viewer/src/assets/viewers/avfx/gpu.rs:195— Particles::batch has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (4 pts), match/switch 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
burst.main (cognitive 18) smoke/burst.ts:87— burst.main has cognitive complexity 18 (threshold 15). Drivers by points: loops 5 (10 pts), if/else 5 (7 pts), ternaries 1 (nesting depth added 7). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
pathlist::write::encode_carved (cognitive 17) pathlist/src/write.rs:37— pathlist::write::encode_carved has cognitive complexity 17 (threshold 15). Drivers by points: loops 5 (8 pts), if/else 4 (6 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Sounds::poll (cognitive 17) viewer/src/assets/viewers/layer/sound.rs:96— Sounds::poll has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (8 pts), match/switch 3 (6 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuestBrowser::draw_cutscenes (cognitive 17) viewer/src/quests/mod.rs:502— QuestBrowser::draw_cutscenes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 3, loops 2 (3 pts), match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Events::read (cognitive 16) viewer/src/assets/viewers/mdl/emote.rs:181— Events::read has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (11 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
web::routes::api::build_songs (cognitive 16) web/src/routes/api.rs:737— web::routes::api::build_songs has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
frame.main (cognitive 16) smoke/frame.ts:134— frame.main has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 2, loops 1, ternaries 1 (nesting depth added 2). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Change-coupling hub: sqpack.rs → web.rs, worker.rs, base.rs viewer/src/data/sqpack.rs— `viewer/src/data/sqpack.rs` changes together with 3 other files — `viewer/src/data/web.rs`, `viewer/src/data/worker.rs`, `viewer/src/excel/base.rs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change coupling: web.rs ↔ worker.rs viewer/src/data/web.rs:1— `viewer/src/data/web.rs` and `viewer/src/data/worker.rs` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `1428b5a0` Resolve icons under the locale they ship in; `170b8102` Fix pathlist caching; `78e1260f` Display stream kind header — run `git show` on any of them.
Near-duplicate member pair (37 shared lines) viewer/src/assets/viewers/mdl/program.rs:2377— viewer/src/assets/viewers/mdl/program.rs:2377-2499 | viewer/src/assets/viewers/mdl/program.rs:2721-2884 — These two members are variants of one another: 37 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (7 members, 50+ identical tokens) viewer/src/assets/viewers/layer/scene/gpu.rs:1776— viewer/src/assets/viewers/layer/scene/gpu.rs:1776-1806 | viewer/src/assets/viewers/layer/scene/gpu.rs:1824-1854 | viewer/src/assets/viewers/mdl/deferred.rs:4827-4844 | viewer/src/assets/viewers/mdl/deferred.rs:4852-4878 | viewer/src/assets/viewers/mdl/deferred.rs:4884-4910 | viewer/src/assets/viewers/mdl/gpu.rs:1459-1508 | viewer/src/assets/viewers/mdl/grid.rs:86-103 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) viewer/src/assets/viewers/avfx/mod.rs:1000— viewer/src/assets/viewers/avfx/mod.rs:1000-1089 | viewer/src/assets/viewers/layer/scene/mod.rs:4244-4542 | viewer/src/assets/viewers/mdl/mod.rs:2373-2697 | viewer/src/assets/viewers/pcb.rs:651-720 | viewer/src/assets/viewers/placed/mod.rs:126-192 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication· Edited copy of a member (71 corresponding lines) · ×1
Edited copy of a member (71 corresponding lines) viewer/src/music.rs:283— viewer/src/music.rs:283-361 | viewer/src/zones/mod.rs:213-283 — These two members are one piece of code written twice and then edited apart: 71 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (58 corresponding lines) · ×1
Edited copy of a member (58 corresponding lines) viewer/src/music.rs:528— viewer/src/music.rs:528-585 | viewer/src/zones/mod.rs:345-405 — These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (37 corresponding lines) · ×1
Edited copy of a member (37 corresponding lines) viewer/src/music.rs:599— viewer/src/music.rs:599-636 | viewer/src/zones/mod.rs:419-455 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (40 corresponding lines) · ×1
Edited copy of a member (40 corresponding lines) viewer/src/assets/viewers/avfx/program.rs:195— viewer/src/assets/viewers/avfx/program.rs:195-234 | viewer/src/assets/viewers/mdl/program.rs:2058-2098 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×1
Edited copy of a member (36 corresponding lines) shadermerge/src/check.rs:107— shadermerge/src/check.rs:107-142 | shadermerge/src/factor.rs:123-158 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×1
Edited copy of a member (31 corresponding lines) viewer/src/character/mod.rs:2179— viewer/src/character/mod.rs:2179-2209 | viewer/src/character/mod.rs:2214-2250 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) viewer/src/assets/viewers/mdl/mod.rs:3065— viewer/src/assets/viewers/mdl/mod.rs:3065-3093 | viewer/src/assets/viewers/mdl/mod.rs:3098-3125 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (38 corresponding lines) · ×1
Edited copy of a member (38 corresponding lines) viewer/src/assets/viewers/avfx/mod.rs:228— viewer/src/assets/viewers/avfx/mod.rs:228-265 | viewer/src/assets/viewers/layer/scene/mod.rs:2757-2800 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (46 corresponding lines) · ×1
Edited copy of a member (46 corresponding lines) viewer/src/assets/viewers/avfx/mod.rs:448— viewer/src/assets/viewers/avfx/mod.rs:448-493 | viewer/src/assets/viewers/avfx/mod.rs:507-557 — These two members are one piece of code written twice and then edited apart: 46 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (27 corresponding lines) · ×1
Edited copy of a member (27 corresponding lines) viewer/src/assets/viewers/pcb/gpu.rs:204— viewer/src/assets/viewers/pcb/gpu.rs:204-230 | viewer/src/assets/viewers/placed/gpu.rs:249-275 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×1
Edited copy of a member (29 corresponding lines) viewer/src/assets/viewers/layer/scene/mod.rs:1953— viewer/src/assets/viewers/layer/scene/mod.rs:1953-1981 | viewer/src/assets/viewers/layer/scene/mod.rs:2132-2161 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (26 corresponding lines) · ×1
Edited copy of a member (26 corresponding lines) viewer/src/assets/viewers/mdl/mod.rs:2838— viewer/src/assets/viewers/mdl/mod.rs:2838-2863 | viewer/src/assets/viewers/mdl/mod.rs:2969-2998 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×1
Edited copy of a member (23 corresponding lines) viewer/src/assets/viewers/pcb.rs:624— viewer/src/assets/viewers/pcb.rs:624-649 | viewer/src/assets/viewers/placed/mod.rs:102-124 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×1
Edited copy of a member (22 corresponding lines) viewer/src/report.rs:72— viewer/src/report.rs:72-97 | web/src/paths/report.rs:70-91 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (25 corresponding lines) · ×1
Edited copy of a member (25 corresponding lines) viewer/src/assets/viewers/avfx/gpu.rs:517— viewer/src/assets/viewers/avfx/gpu.rs:517-547 | viewer/src/assets/viewers/mdl/deferred.rs:4914-4938 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) viewer/src/assets/viewers/est.rs:72— viewer/src/assets/viewers/est.rs:72-96 | viewer/src/assets/viewers/exl.rs:36-54 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (8 members, 15+ corresponding lines) · ×1
Edited copies of one member (8 members, 15+ corresponding lines) viewer/src/assets/viewers/dic.rs:104— viewer/src/assets/viewers/dic.rs:104-118 | viewer/src/character/mod.rs:2253-2269 | viewer/src/character/mod.rs:2272-2288 | viewer/src/character/mod.rs:2436-2452 | viewer/src/character/mod.rs:2455-2471 | viewer/src/character/mod.rs:2549-2565 | viewer/src/character/mod.rs:2568-2584 | viewer/src/character/mod.rs:2618-2635 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 18+ corresponding lines) · ×1
Edited copies of one member (3 members, 18+ corresponding lines) viewer/src/assets/viewers/fpeb.rs:185— viewer/src/assets/viewers/fpeb.rs:185-211 | viewer/src/assets/viewers/waoe.rs:64-81 | viewer/src/assets/viewers/wtd.rs:64-88 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 17+ corresponding lines) · ×1
Edited copies of one member (3 members, 17+ corresponding lines) viewer/src/music.rs:265— viewer/src/music.rs:265-281 | viewer/src/quests/mod.rs:342-365 | viewer/src/zones/mod.rs:195-211 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 14+ corresponding lines) · ×1
Edited copies of one member (3 members, 14+ corresponding lines) viewer/src/sheet/filter/complex_filter_parse.rs:157— viewer/src/sheet/filter/complex_filter_parse.rs:157-170 | viewer/src/sheet/filter/complex_filter_parse.rs:246-261 | viewer/src/sheet/filter/complex_filter_parse.rs:263-276 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×1
Edited copy of a member (15 corresponding lines) web/src/data.rs:537— web/src/data.rs:537-551 | web/src/data.rs:554-569 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 11+ corresponding lines) · ×1
Edited copies of one member (3 members, 11+ corresponding lines) viewer/src/sheet/filter/complex_filter_parse.rs:101— viewer/src/sheet/filter/complex_filter_parse.rs:101-112 | viewer/src/sheet/filter/complex_filter_parse.rs:221-231 | viewer/src/sheet/filter/complex_filter_parse.rs:233-244 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 12+ corresponding lines) · ×1
Edited copies of one member (3 members, 12+ corresponding lines) viewer/src/assets/viewers/evp.rs:20— viewer/src/assets/viewers/evp.rs:20-31 | viewer/src/assets/viewers/phyb.rs:25-43 | viewer/src/assets/viewers/skp.rs:66-83 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 10+ corresponding lines) · ×1
Edited copies of one member (5 members, 10+ corresponding lines) viewer/src/app.rs:1638— viewer/src/app.rs:1638-1650 | viewer/src/app.rs:1674-1683 | viewer/src/app.rs:1709-1720 | viewer/src/app.rs:1747-1758 | viewer/src/app.rs:1782-1791 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (6 members, 16+ corresponding lines) · ×1
Edited copies of one member (6 members, 16+ corresponding lines) web/src/queue.rs:203— web/src/queue.rs:203-218 | web/src/queue.rs:225-242 | web/src/queue.rs:244-259 | web/src/queue.rs:261-276 | web/src/queue.rs:283-298 | web/src/queue.rs:305-322 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×1
Edited copy of a member (7 corresponding lines) viewer/src/assets/viewers/mdl/skin.rs:2093— viewer/src/assets/viewers/mdl/skin.rs:2093-2099 | viewer/src/assets/viewers/mdl/skin.rs:2109-2115 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 13+ corresponding lines) · ×1
Edited copies of one member (3 members, 13+ corresponding lines) viewer/src/data/web.rs:90— viewer/src/data/web.rs:90-102 | viewer/src/data/web.rs:143-155 | viewer/src/data/web.rs:157-169 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×1
Edited copy of a member (6 corresponding lines) viewer/src/schema/web.rs:73— viewer/src/schema/web.rs:73-78 | web/src/routes/github.rs:65-72 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (3 corresponding lines) · ×1
Edited copy of a member (3 corresponding lines) viewer/src/assets/viewers/pcb/gpu.rs:171— viewer/src/assets/viewers/pcb/gpu.rs:171-173 | viewer/src/assets/viewers/placed/gpu.rs:214-217 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 3+ corresponding lines) · ×1
Edited copies of one member (3 members, 3+ corresponding lines) viewer/src/assets/viewers/layer/mod.rs:248— viewer/src/assets/viewers/layer/mod.rs:248-257 | viewer/src/assets/viewers/zone/envs.rs:83-92 | viewer/src/character/palette.rs:118-120 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (29 lines × 2) viewer/src/setup.rs:239— viewer/src/setup.rs:239-267 | viewer/src/setup.rs:525-553 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/setup.rs:239` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (26–28 lines × 4) viewer/src/assets/viewers/avfx/mod.rs:1016— viewer/src/assets/viewers/avfx/mod.rs:1016-1043 | viewer/src/assets/viewers/mdl/mod.rs:2397-2424 | viewer/src/assets/viewers/pcb.rs:668-693 | viewer/src/assets/viewers/placed/mod.rs:142-169 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:1016` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 3) viewer/src/assets/viewers/avfx/mod.rs:848— viewer/src/assets/viewers/avfx/mod.rs:848-872 | viewer/src/assets/viewers/layer/mod.rs:1020-1044 | viewer/src/assets/viewers/zone/envs.rs:247-271 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/layer/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 66 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (25 lines × 2) viewer/src/assets/viewers/pcb/gpu.rs:178— viewer/src/assets/viewers/pcb/gpu.rs:178-202 | viewer/src/assets/viewers/placed/gpu.rs:222-246 — `viewer/src/assets/viewers/pcb/gpu.rs` and `viewer/src/assets/viewers/placed/gpu.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 68 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb/gpu.rs:178` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:2118— viewer/src/assets/viewers/mdl/deferred.rs:2118-2141 | viewer/src/assets/viewers/mdl/deferred.rs:2314-2337 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:2118` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 3) viewer/src/assets/viewers/grass.rs:179— viewer/src/assets/viewers/grass.rs:179-200 | viewer/src/assets/viewers/material.rs:232-253 | viewer/src/assets/viewers/uld.rs:1135-1156 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/grass.rs:179` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18–20 lines × 2) viewer/src/assets/viewers/mdl/program.rs:2425— viewer/src/assets/viewers/mdl/program.rs:2425-2442 | viewer/src/assets/viewers/mdl/program.rs:2782-2801 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17–19 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:580— viewer/src/assets/viewers/layer/scene/gpu.rs:580-598 | viewer/src/assets/viewers/mdl/gpu.rs:1276-1292 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:580` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (17–18 lines × 3) viewer/src/assets/viewers/mdl/deferred.rs:1877— viewer/src/assets/viewers/mdl/deferred.rs:1877-1894 | viewer/src/assets/viewers/mdl/deferred.rs:2375-2392 | viewer/src/assets/viewers/mdl/deferred.rs:3315-3331 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:1877` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `viewer/src/assets/viewers/mdl/deferred.rs:2373` calls `ok_or`, `table` and `viewer/src/assets/viewers/mdl/deferred.rs:3314` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17–18 lines × 2) viewer/src/audio/web.rs:139— viewer/src/audio/web.rs:139-156 | viewer/src/audio/web.rs:626-642 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `audio` to `Decoded` in one and `Arc<Decoded>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16–17 lines × 2) viewer/src/assets/viewers/layer/scene/mod.rs:4170— viewer/src/assets/viewers/layer/scene/mod.rs:4170-4186 | viewer/src/assets/viewers/mdl/mod.rs:2180-2195 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (14–16 lines × 2) viewer/src/character/mod.rs:1831— viewer/src/character/mod.rs:1831-1846 | viewer/src/character/mod.rs:3247-3260 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/mod.rs:1831` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–15 lines × 2) viewer/src/assets/viewers/layer/scene/gpu.rs:1168— viewer/src/assets/viewers/layer/scene/gpu.rs:1168-1182 | viewer/src/assets/viewers/layer/scene/gpu.rs:1464-1475 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:1168` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 2) viewer/src/assets/viewers/avfx/program.rs:205— viewer/src/assets/viewers/avfx/program.rs:205-217 | viewer/src/assets/viewers/mdl/program.rs:2068-2081 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (8–13 lines × 3) viewer/src/assets/viewers/cutb/mod.rs:173— viewer/src/assets/viewers/cutb/mod.rs:173-185 | viewer/src/assets/viewers/pap.rs:198-205 | viewer/src/assets/viewers/sklb.rs:129-140 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (11–13 lines × 2) viewer/src/assets/mod.rs:1259— viewer/src/assets/mod.rs:1259-1271 | viewer/src/assets/mod.rs:1453-1463 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/mod.rs:1259` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–13 lines × 2) viewer/src/assets/viewers/mdl/deferred.rs:3519— viewer/src/assets/viewers/mdl/deferred.rs:3519-3531 | viewer/src/assets/viewers/mdl/deferred.rs:4321-4328 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/deferred.rs:3519` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–13 lines × 2) viewer/src/setup.rs:374— viewer/src/setup.rs:374-385 | viewer/src/setup.rs:618-630 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/setup.rs:374` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–13 lines × 3) viewer/src/assets/viewers/avfx/program.rs:391— viewer/src/assets/viewers/avfx/program.rs:391-403 | viewer/src/assets/viewers/mdl/program.rs:2412-2423 | viewer/src/assets/viewers/mdl/program.rs:2734-2746 — `viewer/src/assets/viewers/avfx/program.rs` and `viewer/src/assets/viewers/mdl/program.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 13 separate duplicated blocks between them, totalling at least 159 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (9–12 lines × 2) viewer/src/data/worker.rs:63— viewer/src/data/worker.rs:63-71 | viewer/src/data/worker.rs:102-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/data/worker.rs:63` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–11 lines × 6) viewer/src/assets/viewers/layer/scene/gpu.rs:1777— viewer/src/assets/viewers/layer/scene/gpu.rs:1777-1787 | viewer/src/assets/viewers/layer/scene/gpu.rs:1825-1835 | viewer/src/assets/viewers/mdl/deferred.rs:4828-4837 | viewer/src/assets/viewers/mdl/deferred.rs:4853-4862 | viewer/src/assets/viewers/mdl/deferred.rs:4885-4894 | viewer/src/assets/viewers/mdl/gpu.rs:1460-1470 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/layer/scene/gpu.rs:1777` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `vertices` to `&[Vertex]` in one and `&[f32]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 4) viewer/src/assets/viewers/avfx/gpu.rs:550— viewer/src/assets/viewers/avfx/gpu.rs:550-560 | viewer/src/assets/viewers/mdl/deferred.rs:5166-5176 | viewer/src/assets/viewers/pcb/gpu.rs:176-186 | viewer/src/assets/viewers/placed/gpu.rs:220-230 — before extracting anything, compare `viewer/src/assets/viewers/avfx/gpu.rs` and `viewer/src/assets/viewers/mdl/deferred.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/gpu.rs:550` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) viewer/src/assets/viewers/mdl/gpu.rs:1110— viewer/src/assets/viewers/mdl/gpu.rs:1110-1120 | viewer/src/assets/viewers/mdl/gpu.rs:1179-1189 | viewer/src/assets/viewers/mdl/gpu.rs:1233-1243 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/mdl/gpu.rs:1110` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–11 lines × 2) viewer/src/assets/viewers/pcb.rs:704— viewer/src/assets/viewers/pcb.rs:704-711 | viewer/src/assets/viewers/placed/mod.rs:178-188 — before extracting anything, compare `viewer/src/assets/viewers/pcb.rs` and `viewer/src/assets/viewers/placed/mod.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/pcb.rs:704` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9–10 lines × 5) viewer/src/assets/viewers/layer/scene/gpu.rs:1789— viewer/src/assets/viewers/layer/scene/gpu.rs:1789-1798 | viewer/src/assets/viewers/layer/scene/gpu.rs:1837-1846 | viewer/src/assets/viewers/mdl/deferred.rs:4867-4875 | viewer/src/assets/viewers/mdl/deferred.rs:4899-4907 | viewer/src/assets/viewers/mdl/gpu.rs:1484-1493 — before extracting anything, compare `viewer/src/assets/viewers/layer/scene/gpu.rs` and `viewer/src/assets/viewers/mdl/gpu.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `indices` to `&[u32]` in one and `&[u16]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 4) viewer/src/assets/viewers/layer/scene/gpu.rs:685— viewer/src/assets/viewers/layer/scene/gpu.rs:685-693 | viewer/src/assets/viewers/layer/scene/gpu.rs:916-924 | viewer/src/assets/viewers/layer/scene/gpu.rs:1076-1084 | viewer/src/assets/viewers/layer/scene/gpu.rs:1396-1404 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 3) viewer/src/assets/viewers/layer/scene/gpu.rs:715— viewer/src/assets/viewers/layer/scene/gpu.rs:715-723 | viewer/src/assets/viewers/layer/scene/gpu.rs:1166-1174 | viewer/src/assets/viewers/layer/scene/gpu.rs:1462-1470 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/layer/scene/gpu.rs:725` calls `bind_vertex_array`, `Some` and `viewer/src/assets/viewers/layer/scene/gpu.rs:1175` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 4) viewer/src/assets/viewers/avfx/mod.rs:851— viewer/src/assets/viewers/avfx/mod.rs:851-858 | viewer/src/assets/viewers/layer/mod.rs:1023-1030 | viewer/src/assets/viewers/uld.rs:1308-1315 | viewer/src/assets/viewers/zone/envs.rs:250-257 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/layer/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 66 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:851` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 4) viewer/src/character/mod.rs:3241— viewer/src/character/mod.rs:3241-3247 | viewer/src/quests/rewards.rs:146-152 | viewer/src/sheet/cell.rs:547-553 | viewer/src/sheet/event_icon_type.rs:142-148 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/mod.rs:3241` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (4–7 lines × 4) viewer/src/assets/viewers/avfx/mod.rs:1002— viewer/src/assets/viewers/avfx/mod.rs:1002-1008 | viewer/src/assets/viewers/mdl/mod.rs:2387-2390 | viewer/src/assets/viewers/pcb.rs:654-660 | viewer/src/assets/viewers/placed/mod.rs:128-134 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/mdl/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 6 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:1002` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `viewer/src/assets/viewers/avfx/mod.rs:1008` calls `sin_cos` and `viewer/src/assets/viewers/mdl/mod.rs:2390` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6–7 lines × 2) viewer/src/assets/viewers/layer/scene/sound.rs:253— viewer/src/assets/viewers/layer/scene/sound.rs:253-259 | viewer/src/assets/viewers/layer/sound.rs:190-195 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 5) viewer/src/character/mod.rs:1823— viewer/src/character/mod.rs:1823-1827 | viewer/src/character/mod.rs:3239-3243 | viewer/src/character/mod.rs:3388-3392 | viewer/src/quests/rewards.rs:144-148 | viewer/src/sheet/event_icon_type.rs:140-144 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (12 lines × 3) viewer/src/assets/viewers/avfx/mod.rs:824— viewer/src/assets/viewers/avfx/mod.rs:824-836 | viewer/src/assets/viewers/layer/mod.rs:998-1009 | viewer/src/assets/viewers/zone/envs.rs:219-230 — `viewer/src/assets/viewers/avfx/mod.rs` and `viewer/src/assets/viewers/layer/mod.rs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 5 separate duplicated blocks between them, totalling at least 66 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/assets/viewers/avfx/mod.rs:824` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–16 lines × 2) viewer/src/assets/mod.rs:1784— viewer/src/assets/mod.rs:1784-1799 | viewer/src/zones/mod.rs:479-491 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 3) viewer/src/character/menus.rs:452— viewer/src/character/menus.rs:452-457 | viewer/src/character/mounts.rs:52-58 | viewer/src/character/npcs.rs:331-337 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `viewer/src/character/menus.rs:452` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Low cohesion: WorkerFileProvider (LCOM4 5) viewer/src/data/worker.rs:12— WorkerFileProvider's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Hollow method — returns a constant without doing the work viewer/src/app.rs:1510— `on_auth_callback` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Wholesale file copy (114 identical lines × 2 files) smoke/look.ts:7— smoke/look.ts:7 · smoke/net.ts:7 — these 2 files are line-for-line copies of one another — 114 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
Duplicated block (57 lines × 2 locations) smoke/glow.ts:34— smoke/glow.ts:34 · smoke/quests.ts:36 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
Duplicated block (48 lines × 2 locations) smoke/drive.ts:25— smoke/drive.ts:25 · smoke/glow.ts:26 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
Duplicated block (44 lines × 2 locations) smoke/burst.ts:37— smoke/burst.ts:37 · smoke/drive.ts:36 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication· Duplicated block with local edits (41 matched lines × 2 locations) · ×1
Duplicated block with local edits (41 matched lines × 2 locations) smoke/net.ts:102— smoke/net.ts:102 · smoke/perf.ts:187 — the two spans are one implementation copied and then locally edited — 418 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (35 lines × 2 locations) smoke/drive.ts:111— smoke/drive.ts:111 · smoke/quests.ts:77 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (19 lines × 2 locations) smoke/frame.ts:85— smoke/frame.ts:85 · smoke/perf.ts:76 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (15 lines × 4 locations) smoke/burst.ts:90— smoke/burst.ts:90 · smoke/drive.ts:115 · smoke/glow.ts:79 · smoke/quests.ts:81 — the 4 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (9 lines × 2 locations) smoke/burst.ts:105— smoke/burst.ts:105 · smoke/frame.ts:177 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (5 lines × 9 locations) smoke/burst.ts:14— smoke/burst.ts:14 · smoke/drive.ts:13 · smoke/frame.ts:21 · smoke/glow.ts:14 · +5 more site(s) not listed — the 9 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 9 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 23, cognitive 49) · ×1
Complex function main (cyclomatic 23, cognitive 49) smoke/perf.ts:95— main has cyclomatic complexity 23 and cognitive complexity 49; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function decodePng (cyclomatic 23, cognitive 36) smoke/smoke.ts:301— decodePng has cyclomatic complexity 23 and cognitive complexity 36; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 22, cognitive 27) · ×1
Complex function main (cyclomatic 22, cognitive 27) smoke/smoke.ts:566— main has cyclomatic complexity 22 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 15, cognitive 27) · ×1
Complex function main (cyclomatic 15, cognitive 27) smoke/drive.ts:114— main has cyclomatic complexity 15 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 15, cognitive 17) · ×1
Complex function main (cyclomatic 15, cognitive 17) smoke/frame.ts:134— main has cyclomatic complexity 15 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 14, cognitive 27) · ×1
Complex function main (cyclomatic 14, cognitive 27) smoke/probe.ts:130— main has cyclomatic complexity 14 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 14, cognitive 22) · ×1
Complex function main (cyclomatic 14, cognitive 22) smoke/burst.ts:87— main has cyclomatic complexity 14 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function main (cyclomatic 12, cognitive 27) · ×1
Complex function main (cyclomatic 12, cognitive 27) smoke/look.ts:60— main has cyclomatic complexity 12 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity· Complex function record (cyclomatic 12, cognitive 11) · ×1
Complex function record (cyclomatic 12, cognitive 11) smoke/smoke.ts:177— record has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
smoke/smoke.ts: 981 lines of code smoke/smoke.ts:1— smoke/smoke.ts has 981 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
Duplicated predicate smoke/burst.ts:67— `!existsSync(portFile) && Date.now() < deadline` appears character-identically in 8 files — smoke/burst.ts, smoke/drive.ts, smoke/frame.ts, smoke/glow.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate smoke/probe.ts:124— `argument === undefined || argument === null` appears character-identically in 2 files — smoke/probe.ts, smoke/smoke.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate smoke/drive.ts:34— `asked.startsWith(dist) && !asked.endsWith("/")` appears character-identically in 5 files — smoke/drive.ts, smoke/glow.ts, smoke/probe.ts, smoke/quests.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate smoke/burst.ts:36— `asked.startsWith(dist) && !asked.endsWith("/") && existsSync(asked)` appears character-identically in 2 files — smoke/burst.ts, smoke/frame.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate viewer/src/assets/viewers/avfx/program.rs:219— `held.vertex() == shpk::NONE || held.pixel() == shpk::NONE` appears character-identically in 2 files — viewer/src/assets/viewers/avfx/program.rs, viewer/src/assets/viewers/mdl/program.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate viewer/src/assets/viewers/avfx/mod.rs:1002— `rect.width() < 1.0 || rect.height() < 1.0` appears character-identically in 5 files — viewer/src/assets/viewers/avfx/mod.rs, viewer/src/assets/viewers/layer/scene/mod.rs, viewer/src/assets/viewers/mdl/mod.rs, viewer/src/assets/viewers/pcb.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Silent fallback default on Err viewer/src/quests/index.rs:392— `cutscenes` turns every `Err` into `Vec::new()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err viewer/src/quests/rewards.rs:66— `class_job_reward` turns every `Err` into `Vec::new()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err viewer/src/assets/viewers/cutb/music.rs:128— `scripted` turns every `Err` into `Vec::new()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err viewer/src/assets/viewers/mdl/skin.rs:312— `companion` turns every `Err` into `Companion::default()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err viewer/src/icons/refs.rs:142— `icon_columns` turns every `Err` into `Vec::new()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err viewer/src/quests/rewards.rs:124— `read` turns every `Err` into `0` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
No ADRs found web/src/main.rs:1— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `web/src/main.rs` makes this repository a deployable product (line 1).
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion viewer/Cargo.toml:1— `viewer` (91780 LoC, 588 module-visible types across 28 directories) overshoots its size bounds. 1 of 9 build unit(s) (Cargo) overshoot their size bounds, lowering Project Cohesion to 7.8/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
Logging is not universal — Only 2/5 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `framediff`, `luadec`.
No dependency-update automation framediff/Cargo.toml:9— `framediff/Cargo.toml` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
No release approval gate REDACTED:52— The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
R7 · Dead Code· Unused module-local declaration 'click' · ×1
Unused module-local declaration 'click' smoke/frame.ts:104— This top-level declaration is not exported and its name occurs nowhere else in its module — not called, read, typed against, re-exported or named by a string. Nothing outside the module can reach a non-exported binding, so this is the whole search: remove it, or use it.
No app-layer HTTPS enforcement detected — This repository starts an HTTP server and nothing in its Rust source or committed `Rocket.toml` secures the transport: no TLS served (actix-web `bind_rustls`/`bind_openssl`, axum-server `bind_rustls` with a `RustlsConfig`, tonic `ServerTlsConfig`, a `TlsAcceptor`, Rocket's `[default.tls]`), no `Strict-Transport-Security` header, no `X-Forwarded-Proto` read from a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: `HttpServer::new(` (web/src/main.rs:100).
Security headers incomplete — Set: Content-Security-Policy, Referrer-Policy, X-Content-Type-Options, X-Frame-Options. Missing: Strict-Transport-Security — the four headers that carry the points of this card's security-headers term (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options), 0.5 each.(−0.5 on this card.) The server: `HttpServer::new(` (web/src/main.rs:100).
X2 · Cancellation propagation· Not all async functions that make a request accept an AbortSignal · ×1
Not all async functions that make a request accept an AbortSignal — Only 0/2 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
Outdated: actix-cors — `actix-cors` is locked at 0.7.1 but 0.7.2 is the current stable release on crates.io, and it already satisfies the `"0.7"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p actix-cors` and commit the updated REDACTED.
Outdated: actix-web — `actix-web` is locked at 4.14.0 but 4.19.0 is the current stable release on crates.io, and it already satisfies the `"4"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p actix-web` and commit the updated REDACTED.
Outdated: async-trait — `async-trait` is locked at 0.1.91 but 0.1.92 is the current stable release on crates.io, and it already satisfies the `"0.1"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p async-trait` and commit the updated REDACTED.
Outdated: base64 — `base64` is locked at 0.23.0 but 0.23.1 is the current stable release on crates.io, and it already satisfies the `"0.23"` requirement declared in framediff/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p base64` and commit the updated REDACTED.
Outdated: blocking — `blocking` is locked at 1.6.2 but 1.7.0 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p blocking` and commit the updated REDACTED.
Outdated: config — `config` is locked at 0.15.25 but 0.15.27 is the current stable release on crates.io, and it already satisfies the `"0.15"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p config` and commit the updated REDACTED.
Outdated: cridecoder — `cridecoder` is locked at 0.3.4 but 0.3.7 is the current stable release on crates.io, and it already satisfies the `"0.3"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p cridecoder` and commit the updated REDACTED.
Outdated: ehttp — `ehttp` is locked at 0.7.1 but 0.7.3 is the current stable release on crates.io, and it already satisfies the `"0.7"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p ehttp` and commit the updated REDACTED.
Outdated: either — `either` is locked at 1.17.0 but 1.19.0 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p either` and commit the updated REDACTED.
Outdated: flate2 — `flate2` is locked at 1.1.9 but 1.1.11 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p flate2` and commit the updated REDACTED.
Outdated: futures-util — `futures-util` is locked at 0.3.33 but 0.3.34 is the current stable release on crates.io, and it already satisfies the `"0.3"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p futures-util` and commit the updated REDACTED.
Outdated: js-sys — `js-sys` is locked at 0.3.103 but 0.3.107 is the current stable release on crates.io, and it already satisfies the `"0.3"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p js-sys` and commit the updated REDACTED.
Outdated: log — `log` is locked at 0.4.33 but 0.4.35 is the current stable release on crates.io, and it already satisfies the `"0.4"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p log` and commit the updated REDACTED.
Outdated: pest — `pest` is locked at 2.8.8 but 2.9.6 is the current stable release on crates.io, and it already satisfies the `"2"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p pest` and commit the updated REDACTED.
Outdated: pest_derive — `pest_derive` is locked at 2.8.8 but 2.9.6 is the current stable release on crates.io, and it already satisfies the `"2"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p pest_derive` and commit the updated REDACTED.
Outdated: reqwest — `reqwest` is locked at 0.13.1 but 0.13.5 is the current stable release on crates.io, and it already satisfies the `"0.13"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p reqwest` and commit the updated REDACTED.
Outdated: serde_json — `serde_json` is locked at 1.0.151 but 1.0.154 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in framediff/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p serde_json` and commit the updated REDACTED.
Outdated: sha2 — `sha2` is locked at 0.11.0 but 0.11.1 is the current stable release on crates.io, and it already satisfies the `"0.11"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p sha2` and commit the updated REDACTED.
Outdated: smallvec — `smallvec` is locked at 1.15.2 but 1.16.5 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p smallvec` and commit the updated REDACTED.
Outdated: thiserror — `thiserror` is locked at 2.0.19 but 2.0.21 is the current stable release on crates.io, and it already satisfies the `"2"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p thiserror` and commit the updated REDACTED.
Outdated: tokio — `tokio` is locked at 1.53.1 but 1.54.1 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p tokio` and commit the updated REDACTED.
Outdated: tokio-util — `tokio-util` is locked at 0.7.19 but 0.7.20 is the current stable release on crates.io, and it already satisfies the `"0.7"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p tokio-util` and commit the updated REDACTED.
Outdated: twox-hash — `twox-hash` is locked at 2.1.3 but 2.1.5 is the current stable release on crates.io, and it already satisfies the `"2"` requirement declared in web/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p twox-hash` and commit the updated REDACTED.
Outdated: ureq — `ureq` is locked at 3.3.0 but 3.5.2 is the current stable release on crates.io, and it already satisfies the `"3"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p ureq` and commit the updated REDACTED.
Outdated: uuid — `uuid` is locked at 1.24.0 but 1.29.3 is the current stable release on crates.io, and it already satisfies the `"*"` requirement declared in viewer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p uuid` and commit the updated REDACTED.
+ 5 more in this group — see findings.md.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1e790-2b3f-7850-886d-066d576472cc · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 17 · Warnings: 925 · Recommendations: 26 · Info: 30 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 17-11-2026 @ 03:32 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.