# Changelog

> **This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings — which rule fired, in which file, on which line, and how to fix it — are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.**

## Score

- CAI 62 → 69 (+6.7)
- Rubric changed (rubric-2026.10.5 → rubric-2026.11.2) — scores are not directly comparable.

## Lenses

- Code Health 90 → 90 (+0.3)
- Architecture 93 → 93 (-0.1)
- Maturity 46 → 54 (+8.1)
- Readiness 76 → 76 (+0.0)
- Security 72 → 88 (+16.0)

## Resolved (13)

- Duplicated block (10 lines × 3) (lib/shopify_api/auth/client_credentials.rb)
- High: security finding (details withheld)
- High: security finding (details withheld)
- High: security finding (details withheld)
- Inconsistent equality method naming. Most types use the standard Ruby `==` operator, but `ShopifyAPI.Auth` itself exposes `const_missing` which is a hook, not an equality check. However, within the Auth sub-namespace, the naming is consistent (`==`). The real inconsistency is between `ShopifyAPI.Auth.==(other)` (if it exists as a class method or instance method on the Auth module/class) and the specific sub-types. Looking closely, `ShopifyAPI.Auth` is a module/class, while `Session`, `JwtPayload` etc are classes. The signature `Auth.==(other)` suggests an instance method on the Auth class, whereas `AuthScopes.==(other)` is on AuthScopes. This is actually consistent Ruby style. 

Wait, looking closer at `ShopifyAPI.Auth.AssociatedUser` having `Method: AssociatedUser.==(other)` and `ShopifyAPI.Auth.Session` having `Method: Session.==(other)`. This is consistent.

Let's look for actual duplicates.

`ShopifyAPI.Clients.Graphql.Admin` and `ShopifyAPI.Clients.Rest.Admin` both have `initialize(session, api_version)`. This is consistent.

`ShopifyAPI.Clients.Graphql.Client` and `ShopifyAPI.Clients.Graphql.Storefront` both have `query(...)`. This is consistent.

`ShopifyAPI.Rest.Base` has `base_find(session, ids, params)`. Many resource classes like `ApplicationCharge` have `find(id, fields, session)`. This is a significant inconsistency. The base class exposes a low-level `base_find`, while the concrete resources expose a high-level `find` with different argument ordering and semantics (e.g., `id` vs `ids`, `fields` vs `params`).

`ShopifyAPI.Rest.Base` has `save!()` and `save(update_object)`. Concrete resources inherit this, so it's consistent.

`ShopifyAPI.Rest.Base` has `delete(params)`. Concrete resources like `ApplicationCharge` have `find(id, ...)` but do they have `delete`? `Article` has `delete(id, blog_id, session)`. `AndroidPayKey` has `delete(id, session)`. The base class `delete` takes `params`, while concrete classes take specific IDs and session. This is an inconsistency in the public API surface of the resources vs the base.

Actually, the most glaring issue is `ShopifyAPI.Auth.==(other)` vs `ShopifyAPI.Auth.Session.==(other)`. If `Auth` is a module, `Auth.==` is weird. If it's a class, it's fine. But `ShopifyAPI.Auth` is listed as a type. `ShopifyAPI.Auth.AssociatedUser` is a type. 

Let's look at `ShopifyAPI.Clients.HttpClient.request(request, response_as_struct)` vs `ShopifyAPI.Clients.Graphql.Client.query(...)`. These are different domains (HTTP vs GraphQL), so not inconsistent.

Let's look at `ShopifyAPI.Rest.Base.base_find` vs `ShopifyAPI.ApplicationCharge.find`. 
`Base.base_find(session, ids, params)` 
`ApplicationCharge.find(id, fields, session)`

The base class method is named `base_find` and takes `ids` (plural) and `params`. The resource method is named `find` and takes `id` (singular) and `fields`. This is a naming and signature inconsistency for the same logical operation (retrieving a resource).

Also, `ShopifyAPI.Rest.Base` has `delete(params)`. `Article` has `delete(id, blog_id, session)`. `AndroidPayKey` has `delete(id, session)`. The base class `delete` is likely a helper or internal, but it's exposed. The resource `delete` methods vary in arguments (some take `blog_id`, some don't). This is an inconsistency in the `delete` operation signature across resources.

However, the prompt asks for operations that appear to do the same thing under different names. `base_find` vs `find` is the strongest candidate. `base_find` is clearly the implementation of `find` for the base class, but it's exposed publicly with a different name and signature.

Another one: `ShopifyAPI.Auth.Session.temp` vs `ShopifyAPI.Auth.Session.from`. These are distinct.

`ShopifyAPI.Clients.Graphql.Admin` and `ShopifyAPI.Clients.Rest.Admin` are distinct clients.

Let's stick with `base_find` vs `find`.
- Inconsistent naming and signature for resource retrieval. The base class exposes `base_find` with `ids` (plural) and `params`, while concrete resource classes expose `find` with `id` (singular) and `fields`. This forces developers to use different method names and argument structures for the same logical operation depending on whether they are using the base class or a specific resource.
- No SBOM
- No artifact signing
- No build provenance
- Orphaned file (lib/shopify_api/auth/token_exchange.rb)
- Orphaned file (lib/shopify_api/clients/http_client.rb)
- Unpinned build actions
- Workflow token permissions not restricted (.github/workflows/close-waiting-for-response-issues.yml)

## New (1)

- Duplicated block (10 lines × 2) (lib/shopify_api/auth/refresh_token.rb)

## Changes since last survey

- 13 commits — 13 feature/other, 0 fixes

## By area

- (repo) — 6 commits
- (root) — 3 commits
- .github/workflows — 3 commits
- lib/shopify_api — 1 commit

## Notable commits

- change: Add JWT client assertion support to client credentials
- change: Merge branch 'main' into gardener/cleanup-dead-workflows
- change: Merge pull request #1473 from Shopify/v16.3.1
- change: Merge pull request #1474 from Shopify/gardener/cleanup-dead-workflows
- change: Merge pull request #1475 from Shopify/zl/client-assertions
- change: Merge pull request #1480 from Shopify/v16.4.0
- change: Merge pull request #1481 from jsaubry/js-11-05-token-exchange-invalid-identity-session
- change: Prepare release v16.3.1
- change: Release v16.4.0
- change: Remove gardener Slack notification and auto-labelling workflows
- change: Remove unused gardener investigate workflow
- change: Replace blocked issues-helper action with actions/stale in the waiting-for-response closer
- change: Treat invalid_identity_session token exchange errors as invalid JWT
