Public report of SapiensAnatis/Dawnshard, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 13:22 UTC · Survey ID cd_7b20aa26c1a94b99b0a30ecdeb9b7416

SapiensAnatis/Dawnshard

Measured 17 November 2026, 13:06 UTC, at code version 6abe4dc

First survey, so nothing to compare with yet Code coverage: not measuredBoundary Type-Coupling: not measured

Code coverage is not measured: JavaScript/TypeScript suite (CouldNotMeasureNoCollector).

Boundary Type-Coupling is not measured: Bounded contexts not declared.

CAI score 47.5out of 100 Provisional

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 91,103 lines of product code in 19 projects, tests not counted · Estimated rebuild effort: about 1.3 person-years · Weakest lens: Security and Compliance, 36.6

Findings by how serious they are

95 critical 420 serious 142 minor

3 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 13:06 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The code didn't build, so the score is provisional
We couldn't build the code: the build stopped with 82 errors. The dimensions that need a working build, such as complexity, duplication and dead code, were measured on an incomplete picture of the code, so their grades and the score are provisional. Fix the build errors and run the survey again for a final score. The first errors: MSB3073: The command ""DragaliaAPI/DragaliaAPI.MissionDesigner/bin/Debug/DragaliaAPI.MissionDesigner" "DragaliaAPI/DragaliaAPI.Shared/Resources/"" exited with code 131.; MSB4181: The "MSBuild" task returned false but did not log an error.; CS0246: The type or namespace name 'PluginBase' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'Photon' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'IPluginFactory' could not be found (are you missing a using directive or an assembly reference?)

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

78of 78 dimensions measured by tools.
585of 657 findings point to an exact file and line, so you can open each one in the code. The other 72 concern the repository as a whole, such as missing documentation.
78dimensions across 7 lenses, read from 91,103 lines of product code in 19 projects.
Chapters

Executive summary

SapiensAnatis/Dawnshard has a provisional result, because the code didn't build. Its score is held back in part because we found no encryption of stored data, no key vault and no enforced HTTPS. It scores 47.5 out of 100, and the ratings may change once the code builds. 81 of its 95 critical findings are security problems.

Security and Compliance, at 36.6, is the weakest lens and counts most in the score. The best first step for the work it takes is moving to stable dependency versions, worth about 5.2 points. Encrypting the sensitive stored data and keeping its keys in a vault would lift Security and Compliance itself, worth about 7.4 points. Raising Security and Compliance to 70 would lift the score to about 56.4.

Thirty-four pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Fifteen secrets can leak from the build pipeline, and twelve known security holes in the packages the code depends on can be used by attackers. Pinning each tool to an exact version, limiting each secret to its own step and updating the vulnerable packages would close these risks. Passing outside input through environment variables would fix the eight pipeline steps that put outside input straight into a shell command, and the seven passwords or keys in the code's history need replacing, with the old ones switched off. The seven data fields that are written but never read need removing.

The product code is 91,103 lines, about €190,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Security and Compliance 36.6 · counts for 46%Production Readiness 44.9 · counts for 25%Architecture 62.2 · counts for 14%Code Health 66.0 · counts for 8%Maturity 70.0 · counts for 4%Accessibility 72.1 · counts for 2%Performance 100.0 · counts for 1%

If Security and Compliance rose from 36.6 to 70, the lowest score rated Strong, the score would rise from 47.5 to about 56.4.

Code composition: what the lines of code are
Business logic 8%Supporting code 33%Tests 17%Generated by tools 43%Code analyzers 0%
Rebuild cost: about €190,000 · Estimate
Cost to rebuild€64,000 to €320,000, for 1,075 to 3,411 hours of work, about 1.3 person-years for 1 to 3 engineers
Difficulty of the problemHigh, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 47. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 91,103 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 4 Prerelease dependency finding(s) in Dependency Hygiene.
Raises the score by about 5.2 points · Low effort · Dependency Hygiene
2
Resolve the 7 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED.
Raises the score by about 3.9 points · Low effort · Secrets (history)
3
Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault.
Skip if delegated to infra (Postgres TDE, KMS, etc.).
Raises the score by about 7.4 points · Medium effort · Data Protection

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

If you do one thing first · First action
Fix the build. The code didn't build, so the dimensions that need a working build were measured on an incomplete picture of the code, and every grade in this report is provisional. Once the build works, the next survey gives a final score. The compiler's first errors: MSB3073: The command ""DragaliaAPI/DragaliaAPI.MissionDesigner/bin/Debug/DragaliaAPI.MissionDesigner" "DragaliaAPI/DragaliaAPI.Shared/Resources/"" exited with code 131.; MSB4181: The "MSBuild" task returned false but did not log an error.; CS0246: The type or namespace name 'PluginBase' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'Photon' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'IPluginFactory' could not be found (are you missing a using directive or an assembly reference?)
Based on: Solution Shape
Where the investment is most exposed · Value at risk
This code would cost about €190,000 to build again, about 1.3 person-years of work. Its weakest lens is Security and Compliance, at 36.6 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch Dawnshard.AppHost AppHost DragaliaAPI DragaliaAPI Dawnshard.AppHost->DragaliaAPI DragaliaAPI.Photon.StateManager StateManager Dawnshard.AppHost->DragaliaAPI.Photon.StateManager Dawnshard.ServiceDefaults ServiceDefaults DragaliaAPI->Dawnshard.ServiceDefaults DragaliaAPI.Database Database DragaliaAPI->DragaliaAPI.Database DragaliaAPI.MasterAssetConverter MasterAssetConverter DragaliaAPI->DragaliaAPI.MasterAssetConverter DragaliaAPI.MissionDesigner MissionDesigner DragaliaAPI->DragaliaAPI.MissionDesigner DragaliaAPI.Photon.Shared Shared DragaliaAPI->DragaliaAPI.Photon.Shared DragaliaAPI.Shared Shared DragaliaAPI->DragaliaAPI.Shared DragaliaAPI.Database->DragaliaAPI.Shared DragaliaAPI.MasterAssetConverter->DragaliaAPI.Shared DragaliaAPI.MissionDesigner->DragaliaAPI.Shared DragaliaAPI.Photon.Plugin Plugin DragaliaAPI.Photon.Plugin->DragaliaAPI.Photon.Shared DragaliaAPI.Photon.StateManager->Dawnshard.ServiceDefaults DragaliaAPI.Photon.StateManager->DragaliaAPI.Photon.Shared DragaliaAPI.Shared->DragaliaAPI.Photon.Shared

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

179 modules, with 652 dependencies between them. 2 loops run through 36 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 139 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 Infrastructure.Results2 Shared.Definitions.Enums3 Shared.PlayerDetails4 Database.Entities5 Features.Shared.Options6 Infrastructure7 Shared.MasterAsset.Models8 Database9 Models.Generated10 Database.Repositories11 Features.Present12 Features.CoOp13 Features.Friends14 Features.Player15 Features.Shared.Reward.Handlers16 Features.Shared.Reward17 Features.Quest18 Features.Shop19 Features.Chara20 Features.Trade21 Features.Dungeon.Record22 Features.Event23 Features.Dungeon24 Features.Wall25 Features.Tutorial26 Features.Story27 Features.Summoning28 Features.Login.Actions29 Features.Dmode30 Features.Shared31 Features.Dragons32 Features.Fort33 Features.Dungeon.Start34 Features.Parties35 Features.Missions.InitialProgress36 Features.Missions37 Features.AbilityCrests38 Features.Login39 Features.Login.SavefileUpdate40 Features.Login.Savefile
1 Infrastructure.Results
2 Shared.Definitions.Enums
3 Shared.PlayerDetails
4 Database.Entities36
5 Features.Shared.Options1
6 Infrastructure3
7 Shared.MasterAsset.Models57
8 Database264
9 Models.Generated11399
10 Database.Repositories1563327
11 Features.Present11161231
12 Features.CoOp1211411
13 Features.Friends11541422112
14 Features.Player11
15 Features.Shared.Reward.Handlers1856931211211
16 Features.Shared.Reward52113
17 Features.Quest122121221232121
18 Features.Shop19141123151111
19 Features.Chara1431113211112
20 Features.Trade351231131132
21 Features.Dungeon.Record111211111213119111
22 Features.Event62101612317462
23 Features.Dungeon15212124115111211111
24 Features.Wall321431241432
25 Features.Tutorial1121111
26 Features.Story242222211111211
27 Features.Summoning2811253231112
28 Features.Login.Actions111211112
29 Features.Dmode171102121211
30 Features.Shared11411112
31 Features.Dragons14311311111
32 Features.Fort183611113121111
33 Features.Dungeon.Start211121421121116111
34 Features.Parties16112152341111
35 Features.Missions.InitialProgress10223111121
36 Features.Missions12816111912112
37 Features.AbilityCrests39151312111
38 Features.Login3132112112411
39 Features.Login.SavefileUpdate21014631123275214
40 Features.Login.Savefile253121121211111112
Uses a module listed above itPart of a loopThe module itself
1 Infrastructure.Results2 Shared.Definitions.Enums3 Shared.PlayerDetails4 Database.Entities5 Features.Shared.Options6 Infrastructure7 Shared.MasterAsset.Models8 Database9 Models.Generated10 Database.Repositories11 Features.Present12 Features.CoOp13 Features.Friends14 Features.Player15 Features.Shared.Reward.Handlers16 Features.Shared.Reward17 Features.Quest18 Features.Shop19 Features.Chara20 Features.Trade21 Features.Dungeon.Record22 Features.Event23 Features.Dungeon24 Features.Wall25 Features.Tutorial26 Features.Story27 Features.Summoning28 Features.Login.Actions29 Features.Dmode30 Features.Shared31 Features.Dragons32 Features.Fort33 Features.Dungeon.Start34 Features.Parties35 Features.Missions.InitialProgress36 Features.Missions37 Features.AbilityCrests38 Features.Login39 Features.Login.SavefileUpdate40 Features.Login.SavefileInfrastructure.Results1Shared.Definitions.Enums2Shared.PlayerDetails3Database.Entities4Features.Shared.Options5Infrastructure6Shared.MasterAsset.Models7Database8Models.Generated9Database.Repositories10Features.Present11Features.CoOp12Features.Friends13Features.Player14Features.Shared.Reward.Handlers15Features.Shared.Reward16Features.Quest17Features.Shop18Features.Chara19Features.Trade20Features.Dungeon.Record21Features.Event22Features.Dungeon23Features.Wall24Features.Tutorial25Features.Story26Features.Summoning27Features.Login.Actions28Features.Dmode29Features.Shared30Features.Dragons31Features.Fort32Features.Dungeon.Start33Features.Parties34Features.Missions.InitialProgress35Features.Missions36Features.AbilityCrests37Features.Login38Features.Login.SavefileUpdate39Features.Login.Savefile403613572641139915633271116123112114111154142211211185693121121152113122121221232121191411231511111431113211112351231131132111211111213119111621016123174621521212411511121111132143124143211211112422222111112112811253231112111211112171102121211114111121431131111118361111312111121112142112111611116112152341111102231111211281611191211239151312111313211211241121014631123275214253121121211111112+139 more modules (most-connected shown)

At a glance — Code Health · 66.0 · Adequate · gated by D18 ·

At a glance — Architecture · 62.2 · Adequate · gated by AX7 ·

At a glance — Maturity · 70.0 · Adequate · gated by M2 ·

At a glance — Readiness · 44.9 · Weak · gated by P5, P7 ·

At a glance — Security · 36.6 · Weak · gated by D28, D29, D36, C1 ·

At a glance — Accessibility · 72.1 · Strong ·

At a glance — Performance · 100.0 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection73High / Critical
A03:2025 — Software Supply Chain Failures38High / Critical
A02:2025 — Security Misconfiguration9Medium
A07:2025 — Authentication Failures8High / Critical

Roadmap

Top priorities: Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.); Resolve the 4 Prerelease dependency finding(s) in Dependency Hygiene; Resolve the 1 finding(s) in DR & Backup.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 4 Prerelease dependency finding(s) in Dependency Hygiene.+5.2 ptsLowDependency Hygiene
Resolve the 7 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED.+3.9 ptsLowSecrets (history)
Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.).+7.4 ptsMediumData Protection
Resolve the 2 Deprecated finding(s) in Dependency Hygiene — start with REDACTED, REDACTED.+3.4 ptsLowDependency Hygiene
Resolve the 1 finding(s) in DR & Backup.+4.1 ptsMediumDR & Backup
Resolve the 5 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED.+1.9 ptsLowSupply-chain Provenance & Signing
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.+3.6 ptsMediumWeb-Security Posture
Resolve the 11 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (9), REDACTED, REDACTED.+3.3 ptsMediumDependency Vulnerabilities

File quality

Per-file score 0–10 — a quality signature. Of 196 files carrying findings, judged against the Production bar: 5% slop · 42% mixed · 53% near-clean.

FileScoreBandWorst signal
REDACTED1.3SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs4.2MixedExplicit Debt: WriteOnlyPrivateField
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.6MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 95

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 420

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 142

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 3

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 78 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 78 dimensions across the health lenses
D1D2D3D4D5D6D10D11D12D13D14D15D17D18D19D20D21D24D26D27D28D29D30D31D34D35D36D43D44AC1AC2AC3AC5AC6AX1AX10AX2AX3AX5AX6AX7AX8AX9C1C2C4ED5GD1IC1M1M2M3M4P1P2P3P4P5P6P7P8PF3S1X1X12X16X18X2X20X21X23X24X27X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 585 of 657 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic

Every finding is locatable in findings.md. Run 01a1e99d-bd6a-73e6-ace2-91d3b4350d8e.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D10 Test Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 927 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 11 test source file(s) (.ts) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
  • D12 Dependency Hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares npm dependencies as well as NuGet ones — manifests: REDACTED, Website/package.json — and the counts on this row cover the NuGet side ONLY. This dimension reads dependency currency from `<PackageReference>` elements via `dotnet list package`; it does not read them, so the npm packages declared there were not checked for newer, deprecated or unmaintained releases. Their absence from the counts above is a gap in this analyzer's ecosystem coverage — not a finding that those dependencies are current.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Cargo manifest, but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its Cargo dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares REDACTED, but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (14 contributor(s) across 1422 commit(s) sampled, automation and bot accounts excluded). One of them holds 90% of the history; the other 13 hold 0.8% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D21's naming rules read C# through Roslyn and every other language through its sidecar model; these languages are left out (PHP's reading is its own change, a Roslyn-loaded VB or F# project has no population builder yet). Their declarations carry no naming verdict this run — this says nothing about whether their names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
  • D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (87,274 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D24 compares a comment's words with the identifiers, literals and constructs of the code it annotates, using English function-word and rationale lexicons. Comments in another script or language were left unread rather than counted as clean.
  • D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/EventIdAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/MissionTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/WallTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Program.cs`, `DragaliaAPI/DragaliaAPI.Shared.SourceGenerator/EquatableReadOnlyList.cs`, … (+184 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX7 Slice cohesion — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 278 further occurrence(s) are not listed individually; the score already reflects all 318.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via AspireAppHost (REDACTED). the Aspire AppHost did not expose a crawlable HTTP endpoint in time (or only the dashboard) — no runtime evidence.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 513 further occurrence(s) are not listed individually; the score already reflects all 553.

Repo exclusion declarations: 7 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D11 Test Reliability: Flakiness is inferred from history/markers — we run the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
  • C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
  • ED5 Idempotency: Idempotency is read from the handler body and one hop below: a mutation is flagged only on structural double-apply evidence (a fresh-identity insert, an accumulation, a growing list, an unkeyed POST/send/charge), so a duplicate effect through a home-grown gateway two hops down, or an insert keyed on the message with no unique constraint, is not flagged but counted as not classified; a guard enforced by a database constraint or a broker's exactly-once delivery is invisible either way. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity7.7 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.7 / 10 · rule-coverage 100% · ceiling Prevented

13 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was UpdateDataService.MapUpdateDataList at 52. A further 6 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being QuestCompletionService.IsQuestMissionCompleted at 37 — they are counted neither in the figure above nor in this dimension's score. 4 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: DragaliaAPI/DragaliaAPI/Features/Dungeon/QuestCompletionService.cs (QuestCompletionService.IsQuestMissionCompleted at 37), DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/GenericRewardHandler.cs (GenericRewardHandler.Grant at 22), DragaliaAPI/DragaliaAPI/Features/Web/Savefile/SavefileEditService.cs (SavefileEditService.ValidatePresents at 22), DragaliaAPI/DragaliaAPI/Features/Summoning/SummonService.cs (SummonService.ProcessSummonPayment at 17). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

UpdateDataService.MapUpdateDataList (cyclomatic 52)DragaliaAPI/DragaliaAPI/Features/Shared/UpdateDataService.cs:56
MissionInitialProgressionService.GetInitialMissionProgress (cyclomatic 49)DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:56
CharaController.CharaManaNodeUnlock (cyclomatic 42)DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:508
PaymentService.ProcessPayment (cyclomatic 36)DragaliaAPI/DragaliaAPI/Features/Shop/PaymentService.cs:31
ClearPartyService.ProcessLostUnitList (cyclomatic 22)DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:138

+ 8 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 13 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with UpdateDataService.MapUpdateDataList (cyclomatic 52), MissionInitialProgressionService.GetInitialMissionProgress (cyclomatic 49), CharaController.CharaManaNodeUnlock (cyclomatic 42). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 13 together lifts Cyclomatic Complexity from 7.7 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.4 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Prevented

26 method(s) exceeded the cognitive complexity threshold of 15; the worst was CharaController.CharaManaNodeUnlock at 71.

CharaController.CharaManaNodeUnlock (cognitive 71)DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:508
ClearPartyService.ProcessLostUnitList (cognitive 37)DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:138
MissionProgressionService.ProcessMissionEvents (cognitive 37)DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:313
FortService.CollectIncome (cognitive 26)DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:95
DmodeDungeonService.GenerateSubsequentFloor (cognitive 24)DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:447

+ 21 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 3 bodies over 30 down to 30 or less in Cognitive Complexity — start with CharaController.CharaManaNodeUnlock (cognitive 71), ClearPartyService.ProcessLostUnitList (cognitive 37), MissionProgressionService.ProcessMissionEvents (cognitive 37). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 6.4 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.1 / 10Stronggated by 25 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Prevented

25 god class(es) detected.

MethodTooLong: QuestHelper.QuestHelper(…) · ×11PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/GameLogic/QuestHelper.Data.cs:49
ClassTooLong: StaticHelperDataService · ×8DragaliaAPI/DragaliaAPI/Features/Friends/StaticHelperDataService.cs
FileTooLong: Friends/StaticHelperDataService.cs · ×6DragaliaAPI/DragaliaAPI/Features/Friends/StaticHelperDataService.cs

What to do

  1. Resolve the 11 MethodTooLong finding(s) in God Classes — start with DungeonRepository.cs (2), QuestHelper.Data.cs, UpdateDataService.cs. — One of this dimension's main actionable groups (11 warning-level).
  2. Resolve the 8 ClassTooLong finding(s) in God Classes — start with StaticHelperDataService.cs, V1Missions.cs, DmodeDungeonService.cs. — One of this dimension's main actionable groups (8 warning-level).
  3. Resolve the 6 FileTooLong finding(s) in God Classes — start with StaticHelperDataService.cs, V1Missions.cs, DragonService.cs. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication8.9 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Verified

21 duplicated block group(s) detected. 2.7 % of the production lines (2,356 of 87,274) are in a reported copy. A further 44 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Edited copy of a member (21 corresponding lines) · ×6DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:381
Edited copy of a member (10 corresponding lines) · ×3DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:110
Duplicated block (7 lines × 2) · ×3DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:631
Edited copy of a member (19 corresponding lines) · ×2DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:541
Edited copies of one member (3 members, 21+ corresponding lines) · ×2DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:276

+ 39 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 6 Edited copy of a member (21 corresponding lines) finding(s) in Code Duplication — start with EventService.cs, MissionInitialProgressionService.cs, SummonOddsLogic.cs. — One of this dimension's main actionable groups (6 warning-level).
  2. Resolve the 3 Edited copy of a member (10 corresponding lines) finding(s) in Code Duplication — start with DmodeController.cs, RedisGame.cs, DiscordPlugin.cs. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 3 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with CharaController.cs, MissionInitialProgressionService.cs, StoryService.cs. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

19 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: DragaliaAPI.Photon.Shared · ×2Shared/DragaliaAPI.Photon.Shared/DragaliaAPI.Photon.Shared.csproj:1

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 155 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

3 skipped (3 with a documented reason), 0 zero-assertion, 6 mock references across 927 tests. Measured on the C# suite only — at least 11 test source file(s) (.ts) went unread, so its test quality is unmeasured and is not in these counts.

Mock framework: Moq · ×6
Skipped (documented): ExportSave_CounterIncreased · ×3DragaliaAPI/DragaliaAPI.Integration.Test/Other/MetricsTest.cs:19

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests pass reliably, with no flakiness.

Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 flaky across 3 measured tier(s). integration: measured (0 flaky); other: measured (0 flaky); JavaScript/TypeScript (vitest via `pnpm install --frozen-lockfile --ignore-scripts` in MaintenanceWorker/ (4 tests)): measured (0 flaky).

✓ On the Gold path — maintain.

Detailed fixes: d11_recommendation.md.

D12 · Dependency Hygiene6.0 / 10Adequate✓ Tool-verified

What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Verified

42 outdated, 2 vulnerable, 1 deprecated, 4 prerelease packages. NuGet only — this repository also declares npm dependencies, which are not read for currency here.

Prerelease dependency: OpenTelemetry.Exporter.Prometheus.AspNetCore · ×4
Deprecated: Aspire.Hosting.NodeJs · ×2REDACTED:8
Outdated: Aspire.Hosting.AppHost · ×42

What to do

  1. Resolve the 4 Prerelease dependency finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 2 Deprecated finding(s) in Dependency Hygiene — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 248 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 76 direct `PackageReference`(s), and 174 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares a Cargo manifest and REDACTED, and the licences of those dependency graphs were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window. Repeated repair below the complexity floor: DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs (3 of 3 changes were fixes)

Repeated repair: DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.csDragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:21

What to do

  1. Resolve the 1 Repeated repair finding(s) in Churn × Complexity Hotspots — start with EventDropService.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.2 / 10Adequategated by 7 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Prevented

107 deducted debt markers + 43 dead symbols across 87274 LoC in the .NET projects (0.4/KLoC) → score 9.2.

WriteOnlyPrivateField · ×7DragaliaAPI/DragaliaAPI.Integration.Test/Features/Maintenance/MaintenanceTest.cs:10
TodoComment · ×75DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerBannerData.cs:47
Dead code: ModuleInitializer · ×43DragaliaAPI/DragaliaAPI.Database.Test/ModuleInitializer.cs:7
CommentedOutCode · ×8Aspire/Dawnshard.ServiceDefaults/Extensions.cs:25
BareSuppressMessage · ×6DragaliaAPI/DragaliaAPI.Integration.Test/Features/Dungeon/DungeonRecordTest.cs:13

+ 8 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 7 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SessionService.cs (2), InputOutputFormatters.cs (2), MaintenanceTest.cs. — One of this dimension's main actionable groups (7 issue-level).
  2. Resolve the 75 TodoComment finding(s) in Explicit Debt — start with DragonService.cs (5), EventDropService.cs (4), PartyController.cs (4). — One of this dimension's main actionable groups (75 warning-level).
  3. Resolve the 43 Dead code finding(s) in Explicit Debt — start with ModuleInitializer.cs (4), DbPlayerBannerDataFactory.cs, IQuestRepository.cs. — One of this dimension's main actionable groups (43 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape3.0 / 10Weak✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 3.0 / 10 · rule-coverage 100% · ceiling Documented

19 projects, 1133 source files, 124054 hand-written lines of code (87274 production / 36780 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 95813 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 29 inter-project edges (build failed).

Build failed

What to do

  1. Resolve the 1 Build failed finding(s) in Solution Shape. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2 of 2 documentation facets pass in full. 8 document(s) read across 14 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundREDACTED:4

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency5.7 / 10Adequate✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Verified

1 naming inconsistencies among 23 declarations measured against a convention their peers follow.

`AttackBaseOnHPUpRate` spells `HP` where 22 names in the project spell it `Hp`DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:72

What to do

  1. Resolve the 1 `AttackBaseOnHPUpRate` spells `HP` where 22 names in the project spell… finding(s) in Naming Consistency — start with AbilityTypes.cs. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D24 · Comment Value9.8 7.2 / 10Strong✓ Tool-verified

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 7.2 / 10 · rule-coverage 73% · ceiling Documented

1 of 483 judged comments only repeat the code they sit on (0.2 %). 633 comment(s) in another language or script were not judged.

redundant commentDragaliaAPI/DragaliaAPI.Integration.Test/Features/Trade/TreasureTradeResetTest.cs:13
doc comments repeat the names · ×8DragaliaAPI/DragaliaAPI/Features/AbilityCrests/IAbilityCrestRepository.cs:19

What to do

  1. Resolve the 1 redundant comment finding(s) in Comment Value — start with TreasureTradeResetTest.cs. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion7.9 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.9 / 10 · rule-coverage 100% · ceiling Documented

2 of 19 projects flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion · ×2DragaliaAPI/DragaliaAPI/DragaliaAPI.csproj:1
Split DragaliaAPI.SharedDragaliaAPI/DragaliaAPI.Shared/DragaliaAPI.Shared.csproj:1

What to do

  1. Resolve the 2 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with DragaliaAPI.csproj, DragaliaAPI.Shared.csproj. — One of this dimension's main actionable groups (2 recommendation-level).
  2. Resolve the 1 Split DragaliaAPI.Shared finding(s) in Project Cohesion — start with DragaliaAPI.Shared.csproj. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability10.0 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

100 % of calls cross a namespace and 0 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)3.0 / 10Weak✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 3.0 / 10 · rule-coverage 100% · ceiling Documented

7 finding(s): 0 critical, 7 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 7 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (7 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.0 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

73 finding(s): 0 critical, 62 high, 11 medium, 0 low. 34 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 204 file(s) — `DragaliaAPI/DragaliaAPI.Integration.Test/Features/AbilityCrests/AbilityCrestTest.cs` (line 263, line 285), `DragaliaAPI/DragaliaAPI.Integration.Test/Features/Dungeon/AutoRepeatTest.cs` (line 402), `DragaliaAPI/DragaliaAPI.Integration.Test/Features/Dungeon/DungeonRecordTest.cs` (line 675, line 677, line 679, …), `DragaliaAPI/DragaliaAPI.Integration.Test/Features/Missions/MissionTest.cs` (lines 713–721, line 725), `DragaliaAPI/DragaliaAPI.Integration.Test/Features/Present/PresentTest.cs` (line 583, line 666), … (+199 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 181 of those file(s) — `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/EventIdAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/MissionTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/WallTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.Shared.SourceGenerator/EquatableReadOnlyList.cs`, `DragaliaAPI/DragaliaAPI.Shared/Features/StorySkip/StorySkipRewards.cs`, … (+176 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 11 of those file(s) — `DragaliaAPI/DragaliaAPI.Integration.Test/Features/Missions/MissionTest.cs`, `DragaliaAPI/DragaliaAPI.Shared.SourceGenerator/MasterAssetGenerator.cs`, `DragaliaAPI/DragaliaAPI.Test/Features/Summon/SummonOddsLogicTest.cs`, `DragaliaAPI/DragaliaAPI/Extensions/NumberExtensions.cs`, `DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs`, … (+6 more) — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 4 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 6 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 11 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (11 issue-level).
  2. Resolve the 8 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED (3), REDACTED. — One of this dimension's main actionable groups (8 issue-level).
  3. No action in Static Analysis (SAST) — all 34 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (34 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.5 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 0.5 / 10 · rule-coverage 100% · ceiling Documented

21 finding(s): 1 critical, 11 high, 7 medium, 2 low.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 11 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (9), REDACTED, REDACTED. — One of this dimension's main actionable groups (11 issue-level).
  2. Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 3 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security9.3 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

9 finding(s): 0 critical, 0 high, 6 medium, 3 low.

REDACTED
REDACTED

What to do

  1. Resolve the 6 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (6). — One of this dimension's main actionable groups (6 warning-level).
  2. Resolve the 3 Low IaC finding(s) in IaC & Container Security — start with REDACTED (3). — One of this dimension's main actionable groups (3 recommendation-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness9.1 / 10Adequategated by 2 critical findings✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Documented

19 of 227 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs. Counted over 227 of the 906 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledge · ×2DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:1
Orphaned file · ×17DragaliaAPI/DragaliaAPI/Features/Album/CharaHonorHelper.cs:1
Further orphaned files (smaller)

What to do

  1. Resolve the 2 Orphaned knowledge finding(s) in Knowledge Freshness — start with PartyPowerService.cs, Materials.cs. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 17 Orphaned file finding(s) in Knowledge Freshness — start with CharaHonorHelper.cs, UserService.cs, ShopService.cs. — One of this dimension's main actionable groups (17 recommendation-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: SessionService.cs↔SessionAuthenticationHandler.cs 60%; SessionService.cs↔Program.cs 54%; DragaliaControllerBase.cs↔Program.cs 50%

Change coupling: SessionService.cs ↔ SessionAuthenticationHandler.cs · ×3DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs:1

What to do

  1. Resolve the 3 Change coupling finding(s) in Change Coupling — start with SessionService.cs (2), DragaliaControllerBase.cs. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 5 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (5 warning-level).
  2. Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
  3. Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 3 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

AC2 · Forms & labels6.8 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. — Website/src/routes/(main)/admin/impersonation/+page.svelte:72
  • A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one). — Website/src/routes/(main)/header.svelte:61

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure6.4 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. — MaintenanceWorker/src/web/page.html:2

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety6.0 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • <loader2icon> moves — its `animate-spin` utility runs with no motion-safe:/motion-reduce: variant — and nothing reads prefers-reduced-motion for it, so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Gate it on @media (prefers-reduced-motion: no-preference) or motion-safe:. — Website/src/lib/shadcn/components/ui/sonner/sonner.svelte:20

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

AX10 · Code composition9.2 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons4.3 / 10Weak✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `Banner` is not registered, but `SystemBanners` creates it and keeps it in the static `RerollBanner`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (summonType, TradeDictionary, pickupCharaData, pickupDragonData; e.g. `summonType` at line 146). — DragaliaAPI/DragaliaAPI/Features/Summoning/SummonBannerOptions.cs:53

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces DragaliaAPI.Database.Entities ↔ DragaliaAPI.Database.Entities.Abstract depend on each other. The lightest dependency in the cycle is DragaliaAPI.Database.Entities.Abstract → DragaliaAPI.Database.Entities (DragaliaAPI.Database.Entities.Abstract.DbPlayerData → DragaliaAPI.Database.Entities.DbPlayer, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — DragaliaAPI/DragaliaAPI.Database/Entities/Abstract/DbPlayerData.cs:5
  • The namespaces DragaliaAPI.Features.AbilityCrests ↔ DragaliaAPI.Features.Chara ↔ DragaliaAPI.Features.ClearParty ↔ DragaliaAPI.Features.CoOp ↔ DragaliaAPI.Features.Dmode ↔ DragaliaAPI.Features.DmodeDungeon ↔ DragaliaAPI.Features.Dragons ↔ DragaliaAPI.Features.Dungeon ↔ DragaliaAPI.Features.Dungeon.AutoRepeat ↔ DragaliaAPI.Features.Dungeon.Record ↔ DragaliaAPI.Features.Emblem ↔ DragaliaAPI.Features.Event ↔ DragaliaAPI.Features.Fort ↔ DragaliaAPI.Features.Friends ↔ DragaliaAPI.Features.Item ↔ DragaliaAPI.Features.Login.Actions ↔ DragaliaAPI.Features.Missions ↔ DragaliaAPI.Features.Missions.InitialProgress ↔ DragaliaAPI.Features.Parties ↔ DragaliaAPI.Features.Player ↔ DragaliaAPI.Features.Present ↔ DragaliaAPI.Features.Quest ↔ DragaliaAPI.Features.Shared ↔ DragaliaAPI.Features.Shared.Reward ↔ DragaliaAPI.Features.Shared.Reward.Handlers ↔ DragaliaAPI.Features.Shop ↔ DragaliaAPI.Features.Story ↔ DragaliaAPI.Features.Summoning ↔ DragaliaAPI.Features.TimeAttack ↔ DragaliaAPI.Features.Trade ↔ DragaliaAPI.Features.Tutorial ↔ DragaliaAPI.Features.Wall ↔ DragaliaAPI.Infrastructure.Metrics ↔ DragaliaAPI.Models.Generated depend on each other. The lightest dependency in the cycle is DragaliaAPI.Features.AbilityCrests → DragaliaAPI.Features.Missions (DragaliaAPI.Features.AbilityCrests.AbilityCrestService → DragaliaAPI.Features.Missions.IMissionProgressionService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:4

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `IUnitRepository` declares 17 members: `Dragons`, `DragonReliabilities`, `WeaponBodies`, `AbilityCrests`, `Talismans`, `RemoveDragons`, `GetCharaSetData`, `AddCharaSetData`, `GetCharaSets`, `GetCharaSets`, `FindCharaAsync`, `FindDragonAsync`, `FindDragonReliabilityAsync`, `FindTalismanAsync`, `FindWeaponBodyAsync`, `AddTalisman`, `RemoveTalisman`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI.Database/Repositories/IUnitRepository.cs:6
  • `IShop` declares 37 members: `Id`, `Limit`, `PaymentType`, `NeedCost`, `DestinationEntityType1`, `DestinationEntityId1`, `DestinationEntityQuantity1`, `DestinationLimitBreakCount1`, `DestinationEntityType2`, `DestinationEntityId2`, `DestinationEntityQuantity2`, `DestinationLimitBreakCount2`, `DestinationEntityType3`, `DestinationEntityId3`, `DestinationEntityQuantity3`, `DestinationLimitBreakCount3`, `DestinationEntityType4`, `DestinationEntityId4`, `DestinationEntityQuantity4`, `DestinationLimitBreakCount4`, `DestinationEntityType5`, `DestinationEntityId5`, `DestinationEntityQuantity5`, `DestinationLimitBreakCount5`, `DestinationEntityType6`, `DestinationEntityId6`, `DestinationEntityQuantity6`, `DestinationLimitBreakCount6`, `DestinationEntityType7`, `DestinationEntityId7`, `DestinationEntityQuantity7`, `DestinationLimitBreakCount7`, `DestinationEntityType8`, `DestinationEntityId8`, `DestinationEntityQuantity8`, `DestinationLimitBreakCount8`, `DestinationEntities`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Shop/IShop.cs:5
  • `IEventRepository` declares 21 members: `EventData`, `Rewards`, `Items`, `Passives`, `GetEventDataAsync`, `GetEventRewardsAsync`, `GetEventRewardIdsAsync`, `GetEventItemAsync`, `GetEventItemAsync`, `GetEventItemsAsync`, `GetEventItemQuantityAsync`, `GetEventPassivesAsync`, `GetEventPassiveAsync`, `CreateEventData`, `CreateEventReward`, `CreateEventItems`, `CreateEventPassives`, `AddItemQuantityAsync`, `RemoveItemQuantityAsync`, `AddEventPassiveProgressAsync`, `HasEventDataAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 21 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI/Features/Event/IEventRepository.cs:5
  • `IEventService` declares 17 members: `GetCustomEventFlag`, `GetEventRewardList`, `GetEventPassiveList`, `ReceiveEventRewards`, `ReceiveEventLocationReward`, `CreateEventData`, `GetEventCharaFriendshipList`, `GetBuildEventUserData`, `GetRaidEventUserData`, `GetClb01EventUserData`, `GetCollectEventUserData`, `GetCombatEventUserData`, `GetEarnEventUserData`, `GetExHunterEventUserData`, `GetExRushEventUserData`, `GetMazeEventUserData`, `GetSimpleEventUserData`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI/Features/Event/IEventService.cs:5
  • `IFortService` declares 19 members: `GetBuildList`, `AddCarpenter`, `GetFortDetail`, `CollectIncome`, `BuildAtOnce`, `LevelupAtOnce`, `CancelBuild`, `CancelLevelup`, `EndBuild`, `EndLevelup`, `BuildStart`, `LevelupStart`, `Move`, `ClearPlantNewStatuses`, `ClearPlantNewStatuses`, `GetRupieProduction`, `GetDragonfruitProduction`, `GetStaminaProduction`, `GetCoreLevels`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI/Features/Fort/IFortService.cs:7
  • `IMissionProgressionService` declares 29 members: `OnQuestCleared`, `OnEventGroupCleared`, `OnQuestStoryCleared`, `OnWeaponEarned`, `OnWeaponRefined`, `OnAbilityCrestBuildupPlusCount`, `OnAbilityCrestTotalPlusCountUp`, `OnAbilityCrestLevelUp`, `OnCharacterBuildupPlusCount`, `OnCharacterLevelUp`, `OnCharacterManaNodeUnlock`, `OnDragonLevelUp`, `OnDragonGiftSent`, `OnDragonBondLevelUp`, `OnItemSummon`, `OnPartyOptimized`, `OnAbilityCrestTradeViewed`, `OnGuildCheckInRewardClaimed`, `OnPartyPowerReached`, `OnTreasureTrade`, `OnEventParticipation`, `OnEventRegularBattleCleared`, `OnEventQuestClearedWithCrest`, `OnEventPointCollected`, `OnEventChallengeBattleCleared`, `OnEventTrialCleared`, `OnEventRaidCleared`, `EnqueueEvent`, `ProcessMissionEvents`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — DragaliaAPI/DragaliaAPI/Features/Missions/IMissionProgressionService.cs:6

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX7 · Slice cohesion1.0 / 10Critical✓ Tool-verified

Other · Architecture — Whether feature slices stay independent (no direct cross-slice references) — the discipline that makes vertical-slice architecture pay off.

Method: Roslyn scan (vertical-slice gated): feature slices resolved from namespaces (.Features.*, .Slices.*) or project names; cross-slice type references detected. Deterministic, traceable.

  • `AbilityCrestService` (slice 'AbilityCrests') depends on `IMissionProgressionService` from slice 'Missions'. — DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:20
  • `AbilityCrestService` (slice 'AbilityCrests') depends on `ITutorialService` from slice 'Tutorial'. — DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:21
  • `AbilityCrestService` (slice 'AbilityCrests') depends on `TutorialService.TutorialStatusIds` from slice 'Tutorial'. — DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:68
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IAlbumService` from slice 'Album'. — DragaliaAPI/DragaliaAPI/Features/Album/FeatureExtensions.cs:10
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `AlbumService` from slice 'Album'. — DragaliaAPI/DragaliaAPI/Features/Album/FeatureExtensions.cs:10
  • `CharaController` (slice 'Chara') depends on `IStoryRepository` from slice 'Story'. — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:28
  • `CharaController` (slice 'Chara') depends on `IMissionProgressionService` from slice 'Missions'. — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:31
  • `CharaController` (slice 'Chara') depends on `IPaymentService` from slice 'Shop'. — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:32
  • `CharaService` (slice 'Chara') depends on `IMissionProgressionService` from slice 'Missions'. — DragaliaAPI/DragaliaAPI/Features/Chara/CharaService.cs:15
  • `ClearPartyService` (slice 'ClearParty') depends on `IDungeonRepository` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:17
  • `HeroParamService` (slice 'CoOp') depends on `IDungeonRepository` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:18
  • `HeroParamService` (slice 'CoOp') depends on `IBonusService` from slice 'Fort'. — DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:20
  • `HeroParamService` (slice 'CoOp') depends on `WeaponHelper` from slice 'Weapons'. — DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:115
  • `UpdateController` (slice 'Configuration') depends on `IFortService` from slice 'Fort'. — DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:23
  • `UpdateController` (slice 'Configuration') depends on `IEmblemRepository` from slice 'Emblem'. — DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:24
  • `UpdateController` (slice 'Configuration') depends on `FriendService` from slice 'Friends'. — DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:25
  • `DmodeController` (slice 'Dmode') depends on `IStoryRepository` from slice 'Story'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:15
  • `DmodeController` (slice 'Dmode') depends on `IStoryService` from slice 'Story'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:17
  • `DmodeService` (slice 'Dmode') depends on `IDmodeCacheService` from slice 'DmodeDungeon'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:18
  • `DmodeService` (slice 'Dmode') depends on `IPaymentService` from slice 'Shop'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:20
  • `DmodeService` (slice 'Dmode') depends on `DmodeHelper` from slice 'DmodeDungeon'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:199
  • `DmodeService` (slice 'Dmode') depends on `TalismanHelper` from slice 'DmodeDungeon'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:345
  • `DmodeSkipResetAction` (slice 'Dmode') depends on `IDailyResetAction` from slice 'Login'. — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeSkipResetAction.cs:8
  • `DmodeDungeonService` (slice 'DmodeDungeon') depends on `IDmodeRepository` from slice 'Dmode'. — DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:18
  • `DmodeDungeonService` (slice 'DmodeDungeon') depends on `IDmodeService` from slice 'Dmode'. — DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:20
  • `DragonService` (slice 'Dragons') depends on `IStoryRepository` from slice 'Story'. — DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:25
  • `DragonService` (slice 'Dragons') depends on `IPaymentService` from slice 'Shop'. — DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:27
  • `DragonService` (slice 'Dragons') depends on `IMissionProgressionService` from slice 'Missions'. — DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:29
  • `DungeonController` (slice 'Dungeon') depends on `IQuestService` from slice 'Quest'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonController.cs:16
  • `DungeonController` (slice 'Dungeon') depends on `IMatchingService` from slice 'CoOp'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonController.cs:19
  • `EventDropService` (slice 'Dungeon') depends on `IEventRepository` from slice 'Event'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:15
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IDungeonService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:14
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `DungeonService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:14
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IDungeonStartService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:15
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `DungeonStartService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:15
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IDungeonRepository` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:16
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `DungeonRepository` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:16
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IQuestEnemyService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:17
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `QuestEnemyService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:17
  • `FeatureExtensions` (slice 'AbilityCrests') depends on `IOddsInfoService` from slice 'Dungeon'. — DragaliaAPI/DragaliaAPI/Features/Dungeon/FeatureExtensions.cs:18

What to do

  • Keep slices independent: share cross-slice needs via an explicit contract/shared-kernel, not direct references between slices.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

AX9 · CQS / query purity10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.

Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.

Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.

C1 · Data Protection0.0 / 10Critical✓ Tool-verified

Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.

Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.

  • No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.

What to do

  • Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.).
  • Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
C2 · Access Controls8.0 / 10Strong✓ Tool-verified

Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.

Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.

  • Access here is not default-deny: `HeroParamController.GetHeroParam` is in a controller that declares no authorization (on itself, a base controller or any action) while 62 sibling controllers do, and no fallback policy, global AuthorizeFilter or gated MapControllers covers it. Where the endpoint returns stored data or changes state, D29 reports it as missing authorization. (×2) — REDACTED:17, REDACTED:23
  • Access here is not default-deny: `MaintenanceController.GetText` is in a controller that declares no authorization (on itself, a base controller or any action) while 62 sibling controllers do, and no fallback policy, global AuthorizeFilter or gated MapControllers covers it. Where the endpoint returns stored data or changes state, D29 reports it as missing authorization. — REDACTED:14

What to do

  • Put every endpoint behind the guard its siblings carry — [Authorize(Policy = …)] on the action or its controller, RequireAuthorization on the route or its group, or a fallback policy with explicit [AllowAnonymous] opt-outs — so the open surface is only what is public on purpose.
C4 · Data Retention6.5 / 10Adequate✓ Tool-verified

Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).

Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.

  • A retention mechanism is present, but the data-lifecycle is not yet complete — missing: a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob), a documented retention period / data-expiry.

What to do

  • Complete the data-lifecycle story: an expiry limit (a declared maximum age for the stored data — a retention-age setting, or a store-level TTL where your storage offers one), a scheduled purge/cleanup job that enforces it, and a documented retention period covering the personal data.
ED5 · Idempotency10.0 / 10Exemplary○ Nothing flagged

Other · Readiness — Whether retry-prone mutations (command handlers and message or event consumers) are idempotent, so an at-least-once redelivery or a client retry does not apply the effect twice.

Method: Roslyn (any mutation, ungated): each persistent write of a command handler or message/event consumer is idempotent when a guard is visible (an exists/dedup read that gates an exit, upsert, idempotency-key/inbox used in a condition or store call, versioned or fixed-value write, dedup envelope or pipeline), at risk only on positive double-apply evidence (a fresh-identity insert, an accumulation on a loaded and saved object, a growing member list, an unkeyed POST/SMTP send/Stripe charge), and otherwise not classified. Deterministic, no model; not scored when more than half are not classified. Advisory.

Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. Every mutation is classified exhaustively and deterministically: guarded, at risk on positive evidence, or not classified; the score is over the classified ones and is withheld when they are fewer than half.

GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×3) — DragaliaAPI/DragaliaAPI.Test.Utils/StubPlayerIdentityService.cs:12, DragaliaAPI/DragaliaAPI.Test.Utils/StubPlayerIdentityService.cs:15, DragaliaAPI/DragaliaAPI/Infrastructure/Linq2Db/Json.cs:55

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs7.2 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `Value` is a shipped member whose body only throws — and it is REACHED: DragaliaAPI/DragaliaAPI/Features/Web/TimeAttack/TimeAttackService.cs:115 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — DragaliaAPI/DragaliaAPI/Infrastructure/Linq2Db/Json.cs:55
  • The arm `EventKindType.Collect` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:141
  • The arm `EventKindType.ExHunter` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:143
  • The arm `EventKindType.Simple` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:144
  • The arm `EventKindType.BattleRoyal` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:145
  • The catch-all arm (reached by `None`, `LimitFall`, `DefeatAllEnemies`, `MaxTeamSize` and 27 more) throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Dungeon/QuestCompletionService.cs:359
  • The section `case SummonTickets.TenfoldSummonLimited:` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/SummonTicketHandler.cs:37
  • The branch `if (shopType is ShopType.Special)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Shop/ShopService.cs:98
  • The catch-all arm (reached by `DungeonMode`) throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:64
  • A test is skipped ("Test fails but functionality works") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it. (×3) — DragaliaAPI/DragaliaAPI.Integration.Test/Other/MetricsTest.cs:19, PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:22, PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:82
  • 9 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:588
  • 8 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:598
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×9) — DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:968, DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:969, DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:977, …
  • `PickDistinct`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — DragaliaAPI/DragaliaAPI/Features/Dungeon/SingleValuePicker.cs:18

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)8.8 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • `pnpm run lint:prettier` invokes prettier in the mode that REWRITES the files it reformats and exits 0 whatever it changed. The rewrite happens inside the runner's throwaway checkout and is then discarded, so the step passes on a badly-formatted change exactly as it passes on a clean one — it enforces nothing, and no other step in this file reads the result. `--check` is the flag that turns the same invocation into a gate: it leaves the files alone and exits non-zero when anything would have been reformatted. — REDACTED:50

What to do

  • Add `--check` to the prettier step in `REDACTED` so a change that is not formatted fails CI, instead of being silently reformatted into a checkout that is thrown away — or, if reformatting the branch is the intent, commit the result back so the fix reaches the repository.
P2 · Observability9.6 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 7/8 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 8, 3 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.

What to do

  • Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
P3 · Security & performance tooling6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • The .NET analyzers are running but not blocking — tighten them (set <AnalysisMode>All</AnalysisMode>, or treat analyzer warnings as errors on CI) so a security/quality regression fails the build rather than scrolling past as a warning.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P5 · DR & Backup0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

  • A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `services.AddHttpClient<IBaasApi, BaasApi>( (sp, client) => { IOptionsMonitor<...` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — DragaliaAPI/DragaliaAPI/ServiceConfiguration.cs:136
  • `services.AddHttpClient<IPhotonStateApi, PhotonStateApi>( (sp, client) => { IO...` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — DragaliaAPI/DragaliaAPI/ServiceConfiguration.cs:147

What to do

  • Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
P8 · Schema migrations10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether EF Core schema changes go through versioned migrations rather than the un-evolvable EnsureCreated().

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

S1 · Web-Security Posture4.5 / 10Weak✓ Tool-verified

Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
  • This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves. (×2) — DragaliaAPI/DragaliaAPI/Program.cs:22, PhotonStateManager/DragaliaAPI.Photon.StateManager/Program.cs:8
  • No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
  • This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it. (×2) — DragaliaAPI/DragaliaAPI/Program.cs:22, PhotonStateManager/DragaliaAPI.Photon.StateManager/Program.cs:8
  • No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.) — DragaliaAPI/DragaliaAPI/Features/Web/WebAuthenticationHelper.cs:17

What to do

  • Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
  • Enforce HTTPS at the app layer (UseHttpsRedirection / UseHsts) — only skip this if a reverse proxy demonstrably terminates TLS.
  • Set secure cookie flags — CookieSecurePolicy.Always, HttpOnly, and SameSite (Strict/Lax) on auth/session cookies. Skip only if the app sets no cookies.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness4.9 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `meter` is a `Meter`, which implements `IDisposable`, and it is created here (line 22). Every use of it in `DragaliaApiMetrics` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var meter = …;`), which releases it at the end of the scope on every path including a throw. — DragaliaAPI/DragaliaAPI/Infrastructure/Metrics/DragaliaApiMetrics.cs:22
  • `meter` is a `Meter`, which implements `IDisposable`, and it is created here (line 20). Every use of it in `PhotonStateManagerMetrics` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var meter = …;`), which releases it at the end of the scope on every path including a throw. — PhotonStateManager/DragaliaAPI.Photon.StateManager/PhotonStateManagerMetrics.cs:20

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X2 · Cancellation propagation5.7 / 10Adequate✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 211/762 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter, and the token `context.RequestAborted` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `context.RequestAborted` on, or take a CancellationToken. — Aspire/Dawnshard.ServiceDefaults/HealthCheckWriter.cs:11
  • No CancellationToken parameter — this work can't be stopped early once started. (×38) — DragaliaAPI/DragaliaAPI.Database/Repositories/BaseRepository.cs:12, DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:42, DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:62, …

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging4.1 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `REDACTED` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×3) — PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:39, PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:41, PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:50

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types9.9 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • ~0.1 `!` suppressions per 1k syntax nodes — 111 suppression(s) across the 934061 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

WCAG coverage — what static analysis assessed

Statically assessed 13 of 55 WCAG 2.2 Level A/AA success criteria (24%; ≈26% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 42 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 42 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.1, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health66.0Adequate — gated by D18Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture62.2Adequate — gated by AX7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity70.0Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness44.9Weak — gated by P5, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security36.6Weak — gated by D28, D29, D36, C1Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility72.1StrongSolid.
Performance100.0ExemplaryStrongest area.
Unscored — 1 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 6 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
  • C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 36 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
  • AX4 Dependency direction — not applicable to a vertical-slice architecture (the inward-dependency rule is for layered/clean styles)
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Aspire AppHost did not expose a crawlable HTTP endpoint in time (or only the dashboard) — no runtime evidence This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
  • D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
  • D25 ADR Conformance — no ADRs to check
  • D32 Data Compliance (PII/GDPR) — 189 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage NOT MEASURED: the .NET half measured 53.7%; the JavaScript/TypeScript half could not be measured — MaintenanceWorker/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan.
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (11 value object(s))
  • ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and a call made through an inferred or generic receiver has no resolvable owner in the source. Reported as guidance rather than measured
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found by the two searches this check runs — a BenchmarkDotNet package reference in any project file (loaded, or on disk), and a script whose name contains `benchmark` that this repository's CI runs. Neither can see a suite in another ecosystem's idiom, so this is not a verdict that the repository has none. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted, and nothing is asked of a repository that has none.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 95 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 9 more in this group — see findings.md.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×11
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · WriteOnlyPrivateField · ×7
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI.Integration.Test/Features/Maintenance/MaintenanceTest.cs:10 — private CustomWebApplicationFactory factory — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI.Shared/MasterAsset/MasterAssetGroup.cs:67 — private MessagePackSerializerOptions MsgpackOptions — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI/Features/Dungeon/OddsInfoService.cs:8 — private ILogger<OddsInfoService> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs:22 — private ILogger<SessionService> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs:23 — private TimeProvider dateTimeProvider — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI/Infrastructure/Serialization/MessagePack/InputOutputFormatters.cs:16 — private MessagePackSerializerOptions options — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField DragaliaAPI/DragaliaAPI/Infrastructure/Serialization/MessagePack/InputOutputFormatters.cs:37 — private MessagePackSerializerOptions options — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
D28 · Secrets (history) · High secret · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AX3 · Project dependency cycles · Namespace dependency cycle · ×2
  • Namespace dependency cycle DragaliaAPI/DragaliaAPI.Database/Entities/Abstract/DbPlayerData.cs:5 — The namespaces DragaliaAPI.Database.Entities ↔ DragaliaAPI.Database.Entities.Abstract depend on each other. The lightest dependency in the cycle is DragaliaAPI.Database.Entities.Abstract → DragaliaAPI.Database.Entities (DragaliaAPI.Database.Entities.Abstract.DbPlayerData → DragaliaAPI.Database.Entities.DbPlayer, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:4 — The namespaces DragaliaAPI.Features.AbilityCrests ↔ DragaliaAPI.Features.Chara ↔ DragaliaAPI.Features.ClearParty ↔ DragaliaAPI.Features.CoOp ↔ DragaliaAPI.Features.Dmode ↔ DragaliaAPI.Features.DmodeDungeon ↔ DragaliaAPI.Features.Dragons ↔ DragaliaAPI.Features.Dungeon ↔ DragaliaAPI.Features.Dungeon.AutoRepeat ↔ DragaliaAPI.Features.Dungeon.Record ↔ DragaliaAPI.Features.Emblem ↔ DragaliaAPI.Features.Event ↔ DragaliaAPI.Features.Fort ↔ DragaliaAPI.Features.Friends ↔ DragaliaAPI.Features.Item ↔ DragaliaAPI.Features.Login.Actions ↔ DragaliaAPI.Features.Missions ↔ DragaliaAPI.Features.Missions.InitialProgress ↔ DragaliaAPI.Features.Parties ↔ DragaliaAPI.Features.Player ↔ DragaliaAPI.Features.Present ↔ DragaliaAPI.Features.Quest ↔ DragaliaAPI.Features.Shared ↔ DragaliaAPI.Features.Shared.Reward ↔ DragaliaAPI.Features.Shared.Reward.Handlers ↔ DragaliaAPI.Features.Shop ↔ DragaliaAPI.Features.Story ↔ DragaliaAPI.Features.Summoning ↔ DragaliaAPI.Features.TimeAttack ↔ DragaliaAPI.Features.Trade ↔ DragaliaAPI.Features.Tutorial ↔ DragaliaAPI.Features.Wall ↔ DragaliaAPI.Infrastructure.Metrics ↔ DragaliaAPI.Models.Generated depend on each other. The lightest dependency in the cycle is DragaliaAPI.Features.AbilityCrests → DragaliaAPI.Features.Missions (DragaliaAPI.Features.AbilityCrests.AbilityCrestService → DragaliaAPI.Features.Missions.IMissionProgressionService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D34 · Knowledge Freshness · Orphaned knowledge · ×2
  • Orphaned knowledge DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
AC2 · Forms & labels · <input> without a programmatic label · ×1
  • <input> without a programmatic label Website/src/routes/(main)/admin/impersonation/+page.svelte:72 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC2 · Forms & labels · <button> with no accessible text · ×1
  • <button> with no accessible text Website/src/routes/(main)/header.svelte:61 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×1
  • REDACTED
IC1 · Incompleteness & stubs · Unfinished stub · ×1
  • Unfinished stub — throws NotImplementedException DragaliaAPI/DragaliaAPI/Infrastructure/Linq2Db/Json.cs:55 — `Value` is a shipped member whose body only throws — and it is REACHED: DragaliaAPI/DragaliaAPI/Features/Web/TimeAttack/TimeAttackService.cs:115 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Serious — 420 finding(s)
D17 · Explicit Debt · TodoComment · ×75
  • TodoComment DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerBannerData.cs:47 — //TODO Not sure if these two belong here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Database/Factories/DbPlayerBannerDataFactory.cs:12 — //TODO Probably get all this and more from bannerInfo — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:53 — // TODO: move DragaliaException into shared — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Database/Repositories/PartyRepository.cs:46 — // TODO: this method executes a query where it deletes the old units and adds the new ones — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Integration.Test/Features/Summoning/SummonTest.cs:557 — // TODO: Change when banners are implemented otherwise this test breaks — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/QuestDrops/QuestBonusReward.cs:7 — // TODO: Extend with random quantity variation — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI.Test/Features/Tool/SessionServiceTest.cs:13 — // TODO: Refactor this file to use the new methods — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:89 — //TODO Get and update missions relating to promoting characters — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:215 — //TODO: Party power calculation call — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:341 — //TODO: For now trust the client won't send the id of a chara who isn't allowed to share — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Chara/CharaService.cs:26 — //TODO: For now we'll trust the client to not allow leveling up/enhancing beyond allowed limits — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:636 — //TODO: For now we'll trust the client to not allow leveling up/enhancing beyond allowed limits — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/CoOp/Stamps/StampService.cs:24 — // TODO: implement database table for earned stickers. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/CoOp/Stamps/StampService.cs:40 — // TODO: validate which stamps are owned — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:14 — // TODO: Add the complete list of versions — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:70 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dungeon/QuestCompletionService.cs:275 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dungeon/QuestCompletionService.cs:280 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dungeon/Skip/DungeonSkipController.cs:238 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dungeon/Skip/DungeonSkipController.cs:240 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:188 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Present/PresentController.cs:95 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:132 — // TODO: Add random equipment — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:981 — // TODO: selectively include enemy groups / menaces — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:239 — //TODO: Add Notte's Nottes Bonus — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 50 more in this group — see findings.md.
D17 · Explicit Debt · Dead code · ×43
  • Dead code: ModuleInitializer DragaliaAPI/DragaliaAPI.Database.Test/ModuleInitializer.cs:7 — NamedType ModuleInitializer — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Database.Test, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: DbPlayerBannerDataFactory DragaliaAPI/DragaliaAPI.Database/Factories/DbPlayerBannerDataFactory.cs:5 — NamedType DbPlayerBannerDataFactory — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Database, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: DeleteQuests DragaliaAPI/DragaliaAPI.Database/Repositories/IQuestRepository.cs:9 — Method DeleteQuests — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Database, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: GetMultipleViewerData DragaliaAPI/DragaliaAPI.Database/Repositories/IUserDataRepository.cs:21 — Method GetMultipleViewerData — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Database, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ConvertIntToFlagList DragaliaAPI/DragaliaAPI.Database/Utils/TutorialFlagUtil.cs:41 — Method ConvertIntToFlagList — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Database, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ModuleInitializer DragaliaAPI/DragaliaAPI.Shared.SourceGenerator.Test/ModuleInitializer.cs:5 — NamedType ModuleInitializer — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Shared.SourceGenerator.Test, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ModuleInitializer DragaliaAPI/DragaliaAPI.Shared.Test/ModuleInitializer.cs:6 — NamedType ModuleInitializer — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Shared.Test, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ToPaymentType DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/EntityTypes.cs:58 — Method ToPaymentType — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: GetFormattedText DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityData.cs:17 — Method GetFormattedText — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ObsoleteReasons DragaliaAPI/DragaliaAPI.Shared/ObsoleteReasons.cs:3 — NamedType ObsoleteReasons — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ModuleInitializer DragaliaAPI/DragaliaAPI.Test/ModuleInitializer.cs:7 — NamedType ModuleInitializer — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Test, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: TestData DragaliaAPI/DragaliaAPI.Test/TestData.cs:6 — NamedType TestData — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI.Test, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: NextEnum DragaliaAPI/DragaliaAPI/Extensions/RandomExtensions.cs:7 — Method NextEnum — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: DmodeSkipResetAction DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeSkipResetAction.cs:7 — NamedType DmodeSkipResetAction — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: RemoveItemQuantityAsync DragaliaAPI/DragaliaAPI/Features/Event/IEventRepository.cs:37 — Method RemoveItemQuantityAsync — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: DailySummoningDealResetAction DragaliaAPI/DragaliaAPI/Features/Login/Actions/DailySummoningDealResetAction.cs:9 — NamedType DailySummoningDealResetAction — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: DragonGiftResetAction DragaliaAPI/DragaliaAPI/Features/Login/Actions/DragonGiftResetAction.cs:11 — NamedType DragonGiftResetAction — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ItemSummonResetAction DragaliaAPI/DragaliaAPI/Features/Login/Actions/ItemSummonResetAction.cs:6 — NamedType ItemSummonResetAction — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: LoginGiftResetAction DragaliaAPI/DragaliaAPI/Features/Login/Actions/LoginGiftResetAction.cs:9 — NamedType LoginGiftResetAction — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: LoadSessionIdToken DragaliaAPI/DragaliaAPI/Features/Login/Auth/ISessionService.cs:34 — Method LoadSessionIdToken — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: V10Update DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V10Update.cs:8 — NamedType V10Update — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: V11Update DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V11Update.cs:9 — NamedType V11Update — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: V12Update DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V12Update.cs:12 — NamedType V12Update — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: V15Update DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V15Update.cs:7 — NamedType V15Update — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: V26Update DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V26Update.cs:15 — NamedType V26Update — Roslyn's SymbolFinder walked every project the solution loads, including DragaliaAPI, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • + 18 more in this group — see findings.md.
AX7 · Slice cohesion · Cross-slice coupling · ×40
  • Cross-slice coupling: AbilityCrests → Missions DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:20 — `AbilityCrestService` (slice 'AbilityCrests') depends on `IMissionProgressionService` from slice 'Missions'.
  • Cross-slice coupling: AbilityCrests → Tutorial DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:21 — `AbilityCrestService` (slice 'AbilityCrests') depends on `ITutorialService` from slice 'Tutorial'.
  • Cross-slice coupling: AbilityCrests → Tutorial DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestService.cs:68 — `AbilityCrestService` (slice 'AbilityCrests') depends on `TutorialService.TutorialStatusIds` from slice 'Tutorial'.
  • Cross-slice coupling: AbilityCrests → Album DragaliaAPI/DragaliaAPI/Features/Album/FeatureExtensions.cs:10 — `FeatureExtensions` (slice 'AbilityCrests') depends on `IAlbumService` from slice 'Album'.
  • Cross-slice coupling: AbilityCrests → Album DragaliaAPI/DragaliaAPI/Features/Album/FeatureExtensions.cs:10 — `FeatureExtensions` (slice 'AbilityCrests') depends on `AlbumService` from slice 'Album'.
  • Cross-slice coupling: Chara → Story DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:28 — `CharaController` (slice 'Chara') depends on `IStoryRepository` from slice 'Story'.
  • Cross-slice coupling: Chara → Missions DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:31 — `CharaController` (slice 'Chara') depends on `IMissionProgressionService` from slice 'Missions'.
  • Cross-slice coupling: Chara → Shop DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:32 — `CharaController` (slice 'Chara') depends on `IPaymentService` from slice 'Shop'.
  • Cross-slice coupling: Chara → Missions DragaliaAPI/DragaliaAPI/Features/Chara/CharaService.cs:15 — `CharaService` (slice 'Chara') depends on `IMissionProgressionService` from slice 'Missions'.
  • Cross-slice coupling: ClearParty → Dungeon DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:17 — `ClearPartyService` (slice 'ClearParty') depends on `IDungeonRepository` from slice 'Dungeon'.
  • Cross-slice coupling: CoOp → Dungeon DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:18 — `HeroParamService` (slice 'CoOp') depends on `IDungeonRepository` from slice 'Dungeon'.
  • Cross-slice coupling: CoOp → Fort DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:20 — `HeroParamService` (slice 'CoOp') depends on `IBonusService` from slice 'Fort'.
  • Cross-slice coupling: CoOp → Weapons DragaliaAPI/DragaliaAPI/Features/CoOp/HeroParamService.cs:115 — `HeroParamService` (slice 'CoOp') depends on `WeaponHelper` from slice 'Weapons'.
  • Cross-slice coupling: Configuration → Fort DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:23 — `UpdateController` (slice 'Configuration') depends on `IFortService` from slice 'Fort'.
  • Cross-slice coupling: Configuration → Emblem DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:24 — `UpdateController` (slice 'Configuration') depends on `IEmblemRepository` from slice 'Emblem'.
  • Cross-slice coupling: Configuration → Friends DragaliaAPI/DragaliaAPI/Features/Configuration/UpdateController.cs:25 — `UpdateController` (slice 'Configuration') depends on `FriendService` from slice 'Friends'.
  • Cross-slice coupling: Dmode → Story DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:15 — `DmodeController` (slice 'Dmode') depends on `IStoryRepository` from slice 'Story'.
  • Cross-slice coupling: Dmode → Story DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:17 — `DmodeController` (slice 'Dmode') depends on `IStoryService` from slice 'Story'.
  • Cross-slice coupling: Dmode → DmodeDungeon DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:18 — `DmodeService` (slice 'Dmode') depends on `IDmodeCacheService` from slice 'DmodeDungeon'.
  • Cross-slice coupling: Dmode → Shop DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:20 — `DmodeService` (slice 'Dmode') depends on `IPaymentService` from slice 'Shop'.
  • Cross-slice coupling: Dmode → DmodeDungeon DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:199 — `DmodeService` (slice 'Dmode') depends on `DmodeHelper` from slice 'DmodeDungeon'.
  • Cross-slice coupling: Dmode → DmodeDungeon DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:345 — `DmodeService` (slice 'Dmode') depends on `TalismanHelper` from slice 'DmodeDungeon'.
  • Cross-slice coupling: Dmode → Login DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeSkipResetAction.cs:8 — `DmodeSkipResetAction` (slice 'Dmode') depends on `IDailyResetAction` from slice 'Login'.
  • Cross-slice coupling: DmodeDungeon → Dmode DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:18 — `DmodeDungeonService` (slice 'DmodeDungeon') depends on `IDmodeRepository` from slice 'Dmode'.
  • Cross-slice coupling: DmodeDungeon → Dmode DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:20 — `DmodeDungeonService` (slice 'DmodeDungeon') depends on `IDmodeService` from slice 'Dmode'.
  • + 15 more in this group — see findings.md.
X2 · Cancellation propagation · Async method without CancellationToken · ×39
  • Async method without CancellationToken: WriteResponse Aspire/Dawnshard.ServiceDefaults/HealthCheckWriter.cs:11 — No CancellationToken parameter, and the token `context.RequestAborted` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `context.RequestAborted` on, or take a CancellationToken.
  • Async method without CancellationToken: SaveChangesAsync DragaliaAPI/DragaliaAPI.Database/Repositories/BaseRepository.cs:12 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: UpdateQuantity DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:42 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindAsync DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:62 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: UpdateQuantity DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:80 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: UpdateQuantity DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:90 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetMaterial DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:100 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckQuantity DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:108 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckQuantity DragaliaAPI/DragaliaAPI.Database/Repositories/InventoryRepository.cs:111 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SetParty DragaliaAPI/DragaliaAPI.Database/Repositories/PartyRepository.cs:44 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: UpdatePartyName DragaliaAPI/DragaliaAPI.Database/Repositories/PartyRepository.cs:61 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindQuestAsync DragaliaAPI/DragaliaAPI.Database/Repositories/QuestRepository.cs:18 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetQuestDataAsync DragaliaAPI/DragaliaAPI.Database/Repositories/QuestRepository.cs:23 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindQuestEventAsync DragaliaAPI/DragaliaAPI.Database/Repositories/QuestRepository.cs:34 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetQuestEventAsync DragaliaAPI/DragaliaAPI.Database/Repositories/QuestRepository.cs:39 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DeleteQuests DragaliaAPI/DragaliaAPI.Database/Repositories/QuestRepository.cs:49 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindCharaAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:37 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindDragonAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:45 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindDragonReliabilityAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:50 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindTalismanAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:58 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: FindWeaponBodyAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:63 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetCharaSetData DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:68 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetCharaSets DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:99 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RemoveDragons DragaliaAPI/DragaliaAPI.Database/Repositories/UnitRepository.cs:137 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetUserDataAsync DragaliaAPI/DragaliaAPI.Database/Repositories/UserDataRepository.cs:32 — No CancellationToken parameter — this work can't be stopped early once started.
  • + 14 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×11
  • MethodTooLong: QuestHelper.QuestHelper(…) PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/GameLogic/QuestHelper.Data.cs:49 — MethodTooLong — QuestHelper(…) runs 464 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 364 over it, 4.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UpdateDataService.MapUpdateDataList DragaliaAPI/DragaliaAPI/Features/Shared/UpdateDataService.cs:56 — MethodTooLong — MapUpdateDataList runs 218 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 118 over it, 2.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SavefileService.Import DragaliaAPI/DragaliaAPI/Features/Login/Savefile/SavefileService.cs:97 — MethodTooLong — Import runs 211 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 111 over it, 2.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CharaController.CharaManaNodeUnlock DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:508 — MethodTooLong — CharaManaNodeUnlock runs 196 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 96 over it, 1.96× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MissionInitialProgressionService.GetInitialMissionProgress DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:56 — MethodTooLong — GetInitialMissionProgress runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MappingExtensions.ProjectToHelperProjection DragaliaAPI/DragaliaAPI/Features/Friends/MappingExtensions.cs:40 — MethodTooLong — ProjectToHelperProjection runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ClearPartyService.ProcessLostUnitList DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:138 — MethodTooLong — ProcessLostUnitList runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DungeonRepository.BuildDetailedPartyUnit DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:277 — MethodTooLong — BuildDetailedPartyUnit runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PaymentService.ProcessPayment DragaliaAPI/DragaliaAPI/Features/Shop/PaymentService.cs:31 — MethodTooLong — ProcessPayment runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DungeonRepository.BuildDetailedPartyUnit DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:149 — MethodTooLong — BuildDetailedPartyUnit runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PartyPowerService.CalculateCharacterPower DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:106 — MethodTooLong — CalculateCharacterPower runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D29 · Static Analysis (SAST) · REDACTED · ×10
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · CommentedOutCode · ×8
  • CommentedOutCode Aspire/Dawnshard.ServiceDefaults/Extensions.cs:25 — 4 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI/Features/Missions/MissionService.cs:351 — 4 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI/Infrastructure/CustomControllerFeatureProvider.cs:28 — 4 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI/Infrastructure/OutputCaching/RepeatedRequestPolicy.cs:66 — 4 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI.Integration.Test/Features/Login/LoginTest.cs:169 — 5 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:588 — 9 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:598 — 8 consecutive commented-code lines
  • CommentedOutCode DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:982 — 3 consecutive commented-code lines
D3 · God Classes · ClassTooLong · ×8
  • ClassTooLong: StaticHelperDataService DragaliaAPI/DragaliaAPI/Features/Friends/StaticHelperDataService.cs — ClassTooLong — 2435 significant lines (blank, comment-only and punctuation-only lines excluded), 4 methods. The bar is 400 significant lines; this is 2035 over it, 6.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: V1Missions DragaliaAPI/DragaliaAPI.MissionDesigner/Missions/Drill/V1Missions.cs — ClassTooLong — 1603 significant lines (blank, comment-only and punctuation-only lines excluded), 0 methods. The bar is 400 significant lines; this is 1203 over it, 4.01× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: DmodeDungeonService DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs — ClassTooLong — 668 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 268 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DragonService DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs — ClassTooLong — 634 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 234 over it, 1.59× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: CharaController DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs — ClassTooLong — 514 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 114 over it, 1.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: QuestHelper PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/GameLogic/QuestHelper.cs — ClassTooLong — 473 significant lines (blank, comment-only and punctuation-only lines excluded), 4 methods, declared across 2 files: GameLogic/QuestHelper.cs (3), GameLogic/QuestHelper.Data.cs (1). The bar is 400 significant lines; this is 73 over it, 1.18× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: PartyPowerService DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs — ClassTooLong — 406 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 6 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SummonService DragaliaAPI/DragaliaAPI/Features/Summoning/SummonService.cs — ClassTooLong — 405 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 5 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
IC1 · Incompleteness & stubs · Unfinished branch · ×8
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:141 — The arm `EventKindType.Collect` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:143 — The arm `EventKindType.ExHunter` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:144 — The arm `EventKindType.Simple` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:145 — The arm `EventKindType.BattleRoyal` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Dungeon/QuestCompletionService.cs:359 — The catch-all arm (reached by `None`, `LimitFall`, `DefeatAllEnemies`, `MaxTeamSize` and 27 more) throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/SummonTicketHandler.cs:37 — The section `case SummonTickets.TenfoldSummonLimited:` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Shop/ShopService.cs:98 — The branch `if (shopType is ShopType.Special)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:64 — The catch-all arm (reached by `DungeonMode`) throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
D17 · Explicit Debt · BareSuppressMessage · ×6
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Integration.Test/Features/Dungeon/DungeonRecordTest.cs:13 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Integration.Test/Features/Missions/MissionTest.cs:12 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Integration.Test/Features/Weapons/WeaponBodyTest.cs:9 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Test/GlobalSuppressions.cs:3 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Test/GlobalSuppressions.cs:4 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage DragaliaAPI/DragaliaAPI.Test/GlobalSuppressions.cs:8 — SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
D3 · God Classes · FileTooLong · ×6
  • FileTooLong: Friends/StaticHelperDataService.cs DragaliaAPI/DragaliaAPI/Features/Friends/StaticHelperDataService.cs — FileTooLong — 2439 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1939 over it, 4.88× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Drill/V1Missions.cs DragaliaAPI/DragaliaAPI.MissionDesigner/Missions/Drill/V1Missions.cs — FileTooLong — 1604 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1104 over it, 3.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Dragons/DragonService.cs DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs — FileTooLong — 700 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 200 over it, 1.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: DmodeDungeon/DmodeDungeonService.cs DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs — FileTooLong — 699 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 199 over it, 1.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Chara/CharaController.cs DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs — FileTooLong — 568 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 68 over it, 1.14× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Savefile/SavefileService.cs DragaliaAPI/DragaliaAPI/Features/Login/Savefile/SavefileService.cs — FileTooLong — 550 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 50 over it, 1.10× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D31 · IaC & Container Security · Medium IaC · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×6
  • Edited copy of a member (21 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:381 — DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:381-402 | DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:469-489 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:416 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:416-436 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:593-614 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:398 — DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:398-419 | DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:422-442 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) REDACTED:48 — REDACTED:48-69 | DragaliaAPI/DragaliaAPI/Features/Login/Auth/TransitionController.cs:23-43 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Event/BuildEventController.cs:21 — DragaliaAPI/DragaliaAPI/Features/Event/BuildEventController.cs:21-42 | DragaliaAPI/DragaliaAPI/Features/Event/EarnEventController.cs:23-43 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:83 — PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:83-103 | PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/StateManager/StateManagerPlugin.cs:335-355 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D12 · Dependency Hygiene · Prerelease dependency · ×4
  • Prerelease dependency: OpenTelemetry.Exporter.Prometheus.AspNetCore — OpenTelemetry.Exporter.Prometheus.AspNetCore resolves to 1.16.0-beta.1, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
  • Prerelease dependency: OpenTelemetry.Instrumentation.EntityFrameworkCore — OpenTelemetry.Instrumentation.EntityFrameworkCore resolves to 1.16.0-beta.1, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
  • Prerelease dependency: OpenTelemetry.Instrumentation.Process — OpenTelemetry.Instrumentation.Process resolves to 1.16.0-beta.1, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
  • Prerelease dependency: OpenTelemetry.Instrumentation.StackExchangeRedis — OpenTelemetry.Instrumentation.StackExchangeRedis resolves to 1.16.0-beta.1, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · BarePragmaDisable · ×3
  • BarePragmaDisable Aspire/Dawnshard.AppHost/Program.cs:7 — #pragma warning disable ASPIREPROXYENDPOINTS001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable Aspire/Dawnshard.AppHost/Program.cs:16 — #pragma warning disable ASPIRECERTIFICATES001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable DragaliaAPI/DragaliaAPI/Program.cs:154 — #pragma warning disable ASP0001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
D30 · Dependency Vulnerabilities · Medium CVE · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Medium advisory (unmaintained) · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D35 · Change Coupling · Change coupling · ×3
  • Change coupling: SessionService.cs ↔ SessionAuthenticationHandler.cs DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs:1 — `DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs` and `DragaliaAPI/DragaliaAPI/Infrastructure/Authentication/SessionAuthenticationHandler.cs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `bd774ee9` Handle user without Dawnshard identity in transition_by_n_account (#1… (at that commit the file was still `DragaliaAPI/DragaliaAPI/Features/Tool/SessionService.cs`); `738a9eda` Add user impersonation (#472) (at that commit the files were still `DragaliaAPI/Services/Game/SessionService.cs` and `DragaliaAPI/Middleware/SessionAuthenticationHandler.cs`); `0d93a221` Implement daily bonus (#282) (at that commit the files were still `DragaliaAPI/Services/Game/SessionService.cs` and `DragaliaAPI/Middleware/SessionAuthenticationHandler.cs`) — run `git show` on any of them.
  • Change coupling: SessionService.cs ↔ Program.cs DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs:1 — `DragaliaAPI/DragaliaAPI/Features/Login/Auth/SessionService.cs` and `DragaliaAPI/DragaliaAPI/Program.cs` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `55013870` Update config to work with nomad (#643) (at that commit the files were still `DragaliaAPI/Services/Game/SessionService.cs` and `DragaliaAPI/Program.cs`); `0d93a221` Implement daily bonus (#282) (at that commit the files were still `DragaliaAPI/Services/Game/SessionService.cs` and `DragaliaAPI/Program.cs`); `501a1205` Add viewer id to logs (#99) (at that commit the files were still `DragaliaAPI/Services/SessionService.cs` and `DragaliaAPI/Program.cs`) — run `git show` on any of them.
  • Change coupling: DragaliaControllerBase.cs ↔ Program.cs DragaliaAPI/DragaliaAPI/Infrastructure/DragaliaControllerBase.cs:1 — `DragaliaAPI/DragaliaAPI/Infrastructure/DragaliaControllerBase.cs` and `DragaliaAPI/DragaliaAPI/Program.cs` change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `a757332d` Refactor exception handler middleware (#1129) (at that commit the file was still `DragaliaAPI/DragaliaAPI/Controllers/DragaliaControllerBase.cs`); `a61dc614` Add Request-Token header to log context (#874) (at that commit the file was still `DragaliaAPI/DragaliaAPI/Controllers/DragaliaControllerBase.cs`); `aad9e473` Add maintenance controller (#642) (at that commit the files were still `DragaliaAPI/Controllers/DragaliaControllerBase.cs` and `DragaliaAPI/Program.cs`) — run `git show` on any of them.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×3
  • Edited copy of a member (10 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:110 — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeController.cs:110-119 | DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonController.cs:69-80 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) PhotonStateManager/DragaliaAPI.Photon.StateManager/Models/RedisGame.cs:21 — PhotonStateManager/DragaliaAPI.Photon.StateManager/Models/RedisGame.cs:21-30 | Shared/DragaliaAPI.Photon.Shared/Models/ApiGame.cs:48-57 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:71 — PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:71-80 | PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/StateManager/StateManagerPlugin.cs:192-201 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×3
  • Duplicated block (7 lines × 2) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:631 — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:631-637 | DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:643-649 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:356 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:356-362 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:400-406 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:356` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:398 — DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:398-404 | DragaliaAPI/DragaliaAPI/Features/Trade/TradeService.cs:283-289 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
GD1 · Unfinished & placeholder code · Unfinished stub · ×3
  • Unfinished stub — throws NotImplementedException DragaliaAPI/DragaliaAPI.Test.Utils/StubPlayerIdentityService.cs:12 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException DragaliaAPI/DragaliaAPI.Test.Utils/StubPlayerIdentityService.cs:15 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException DragaliaAPI/DragaliaAPI/Infrastructure/Linq2Db/Json.cs:55 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
D12 · Dependency Hygiene · Deprecated · ×2
  • Deprecated: Aspire.Hosting.NodeJs REDACTED:8 — Aspire.Hosting.NodeJs 9.5.2 — Legacy — the publisher's replacement is `Aspire.Hosting.JavaScript`; migrate the reference to it.
  • Deprecated: @cloudflare/vitest-pool-workers REDACTED:7 — @cloudflare/vitest-pool-workers 0.13.0, declared in REDACTED, is marked deprecated by its publisher: "@cloudflare/vitest-pool-workers has been renamed to @cloudflare/vitest-plugin. This package will not receive future updates.". Replace it with the package or version that message names, or record why this one must stay.
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×2
  • Edited copy of a member (19 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:541 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:541-559 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:567-586 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:61 — DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:61-79 | DragaliaAPI/DragaliaAPI/Features/Parties/PartyPowerService.cs:86-104 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 21+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:276 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:276-296 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:341-365 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:386-409 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 21+ corresponding lines) PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/CollectionExtensions.cs:117 — PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/CollectionExtensions.cs:117-137 | PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/CollectionExtensions.cs:140-160 | PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/CollectionExtensions.cs:167-189 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×2
  • Edited copy of a member (16 corresponding lines) DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/CharaListValidator.cs:12 — DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/CharaListValidator.cs:12-29 | DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/DragonListValidator.cs:12-27 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:432 — DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:432-448 | DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:451-466 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×2
  • Edited copy of a member (25 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:31 — DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:31-55 | DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:112-136 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Fort/FortController.cs:192 — DragaliaAPI/DragaliaAPI/Features/Fort/FortController.cs:192-216 | DragaliaAPI/DragaliaAPI/Features/Fort/FortController.cs:244-268 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×2
  • Edited copy of a member (15 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/HustleHammerHandler.cs:19 — DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/HustleHammerHandler.cs:19-33 | DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/WyrmiteHandler.cs:19-33 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs:173 — DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs:173-187 | DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs:190-204 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×2
  • Edited copy of a member (18 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/AbilityLogic.cs:135 — DragaliaAPI/DragaliaAPI/Features/Dungeon/AbilityLogic.cs:135-152 | DragaliaAPI/DragaliaAPI/Features/Dungeon/AbilityLogic.cs:158-177 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:42 — DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:42-63 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:72-89 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×2
  • Edited copy of a member (7 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:145 — DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:145-157 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:171-177 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/HustleHammerHandler.cs:36 — DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/HustleHammerHandler.cs:36-42 | DragaliaAPI/DragaliaAPI/Features/Shared/Reward/Handlers/WyrmiteHandler.cs:36-42 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×2
  • Duplicated block (18 lines × 2) DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/CharaData.cs:181 — DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/CharaData.cs:181-198 | DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/DragonData.cs:52-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (18 lines × 2) DragaliaAPI/DragaliaAPI/Features/Weapons/WeaponService.cs:182 — DragaliaAPI/DragaliaAPI/Features/Weapons/WeaponService.cs:182-199 | DragaliaAPI/DragaliaAPI/Features/Weapons/WeaponService.cs:301-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:314 — DragaliaAPI/DragaliaAPI/Features/Dmode/DmodeService.cs:314-328 | DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:223-237 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (15 lines × 2) DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:125 — DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:125-140 | DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:202-216 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:125` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:37 — DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:37-52 | DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:81-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:37` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `WallStartStartRequest` in one and `WallStartStartAssignUnitRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (16 lines × 2) DragaliaAPI/DragaliaAPI/Infrastructure/Middleware/PhotonAuthenticationHandler.cs:83 — DragaliaAPI/DragaliaAPI/Infrastructure/Middleware/PhotonAuthenticationHandler.cs:83-98 | PhotonStateManager/DragaliaAPI.Photon.StateManager/Authentication/PhotonAuthenticationHandler.cs:52-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Infrastructure/Middleware/PhotonAuthenticationHandler.cs:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×2
  • Duplicated block (8 lines × 2) DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:24 — DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:24-31 | DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs:17-24 — before extracting anything, compare `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs` and `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:34` calls `Column` and `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs:25` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) REDACTED:112 — REDACTED:112-119 | DragaliaAPI/DragaliaAPI/Features/Summoning/SummonService.cs:411-418 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:112` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×2
  • Duplicated block (9 lines × 2) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:428 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:428-436 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:606-614 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:428` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:104 — DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:104-112 | DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:231-239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:104` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×2
  • Outbound HTTP without resilience DragaliaAPI/DragaliaAPI/ServiceConfiguration.cs:136 — `services.AddHttpClient<IBaasApi, BaasApi>( (sp, client) => { IOptionsMonitor<...` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
  • Outbound HTTP without resilience DragaliaAPI/DragaliaAPI/ServiceConfiguration.cs:147 — `services.AddHttpClient<IPhotonStateApi, PhotonStateApi>( (sp, client) => { IO...` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×2
  • Disposable created and abandoned in the method that made it DragaliaAPI/DragaliaAPI/Infrastructure/Metrics/DragaliaApiMetrics.cs:22 — `meter` is a `Meter`, which implements `IDisposable`, and it is created here (line 22). Every use of it in `DragaliaApiMetrics` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var meter = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it PhotonStateManager/DragaliaAPI.Photon.StateManager/PhotonStateManagerMetrics.cs:20 — `meter` is a `Meter`, which implements `IDisposable`, and it is created here (line 20). Every use of it in `PhotonStateManagerMetrics` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var meter = …;`), which releases it at the end of the scope on every path including a throw.
AC3 · Page structure · Page without a main landmark · ×1
  • Page without a main landmark MaintenanceWorker/src/web/page.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC6 · Visual & motion safety · Animation without a prefers-reduced-motion guard · ×1
  • Animation without a prefers-reduced-motion guard Website/src/lib/shadcn/components/ui/sonner/sonner.svelte:20 — <loader2icon> moves — its `animate-spin` utility runs with no motion-safe:/motion-reduce: variant — and nothing reads prefers-reduced-motion for it, so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Gate it on @media (prefers-reduced-motion: no-preference) or motion-safe:.
AX2 · Stateful singletons · Stateful shared instance · ×1
  • Stateful shared instance: Banner DragaliaAPI/DragaliaAPI/Features/Summoning/SummonBannerOptions.cs:53 — `Banner` is not registered, but `SystemBanners` creates it and keeps it in the static `RerollBanner`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (summonType, TradeDictionary, pickupCharaData, pickupDragonData; e.g. `summonType` at line 146).
C1 · Data Protection · No data-protection/encryption · ×1
  • No data-protection/encryption — No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.
D1 · Cyclomatic Complexity · UpdateDataService.MapUpdateDataList (cyclomatic 52) · ×1
  • UpdateDataService.MapUpdateDataList (cyclomatic 52) DragaliaAPI/DragaliaAPI/Features/Shared/UpdateDataService.cs:56 — UpdateDataService.MapUpdateDataList has cyclomatic complexity 52 (threshold 15). Of this number, 50 points are the body's own statements and 2 belong to one function item inside it that branches. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MissionInitialProgressionService.GetInitialMissionProgress (cyclomatic 49) · ×1
  • MissionInitialProgressionService.GetInitialMissionProgress (cyclomatic 49) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:56 — MissionInitialProgressionService.GetInitialMissionProgress has cyclomatic complexity 49 (threshold 15). Of this number, 46 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · CharaController.CharaManaNodeUnlock (cyclomatic 42) · ×1
  • CharaController.CharaManaNodeUnlock (cyclomatic 42) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:508 — CharaController.CharaManaNodeUnlock has cyclomatic complexity 42 (threshold 15). Of this number, 40 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PaymentService.ProcessPayment (cyclomatic 36) · ×1
  • PaymentService.ProcessPayment (cyclomatic 36) DragaliaAPI/DragaliaAPI/Features/Shop/PaymentService.cs:31 — PaymentService.ProcessPayment has cyclomatic complexity 36 (threshold 15). Of this number, 34 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ClearPartyService.ProcessLostUnitList (cyclomatic 22) · ×1
  • ClearPartyService.ProcessLostUnitList (cyclomatic 22) DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:138 — ClearPartyService.ProcessLostUnitList has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DungeonRepository.BuildDetailedPartyUnit (cyclomatic 22) · ×1
  • DungeonRepository.BuildDetailedPartyUnit (cyclomatic 22) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:277 — DungeonRepository.BuildDetailedPartyUnit has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 5 of the 22 points are its own statements and the rest belongs to 15 function literals inside it that branch (lines 359, 366, 293, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · MissionProgressionService.ProcessMissionEvents (cyclomatic 20) · ×1
  • MissionProgressionService.ProcessMissionEvents (cyclomatic 20) DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:313 — MissionProgressionService.ProcessMissionEvents has cyclomatic complexity 20 (threshold 15). Of this number, 11 points are the body's own statements and 9 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WeaponService.TryBuildupGeneric (cyclomatic 19) · ×1
  • WeaponService.TryBuildupGeneric (cyclomatic 19) DragaliaAPI/DragaliaAPI/Features/Weapons/WeaponService.cs:151 — WeaponService.TryBuildupGeneric has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DragonService.DragonLevelUp (cyclomatic 18) · ×1
  • DragonService.DragonLevelUp (cyclomatic 18) DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:628 — DragonService.DragonLevelUp has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DmodeDungeonService.GenerateOddsInfo (cyclomatic 17) · ×1
  • DmodeDungeonService.GenerateOddsInfo (cyclomatic 17) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:643 — DmodeDungeonService.GenerateOddsInfo has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 7 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 670, 698). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · DmodeDungeonService.GenerateSubsequentFloor (cyclomatic 16) · ×1
  • DmodeDungeonService.GenerateSubsequentFloor (cyclomatic 16) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:447 — DmodeDungeonService.GenerateSubsequentFloor has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DmodeDungeonService.GenerateEnemies (cyclomatic 16) · ×1
  • DmodeDungeonService.GenerateEnemies (cyclomatic 16) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:969 — DmodeDungeonService.GenerateEnemies has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FortService.CollectIncome (cyclomatic 16) · ×1
  • FortService.CollectIncome (cyclomatic 16) DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:95 — FortService.CollectIncome has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D15 · Churn × Complexity Hotspots · Repeated repair · ×1
  • Repeated repair: DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:21 — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 15 (its worst body is EventDropService.ProcessEventPassiveDrops at line 21), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix raid boosts never dropping when one boost remains (#1550)”; “Fix raid clear ArgumentOutOfRangeException + adjust drops (#1548)”; “Persona event fixes (#1547)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-27..2026-10-25, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-27 10:53:50 +00:00' --until='2026-10-25 10:53:50 +00:00' --full-history --no-merges -- DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D17 · Explicit Debt · CoverageExclusion · ×1
  • CoverageExclusion DragaliaAPI/DragaliaAPI.Database/DatabaseConfiguration.cs:51 — method MigrateDatabase — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
D17 · Explicit Debt · XxxComment · ×1
  • XxxComment DragaliaAPI/DragaliaAPI/Features/Event/Summon/EventSummonService.cs:194 — // The checkbox in the GUI that sets is_enable_stop_by_target is labelled 'Summon Until XXX's Conviction — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D17 · Explicit Debt · DeadPreprocessorBranch · ×1
  • DeadPreprocessorBranch DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:2 — #if CHEATS && DEBUG — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
D17 · Explicit Debt · ObsoleteWithCallers · ×1
  • ObsoleteWithCallers DragaliaAPI/DragaliaAPI/Features/Fort/FortRepository.cs:19 — [Obsolete] Builds
D17 · Explicit Debt · HackComment · ×1
  • HackComment DragaliaAPI/DragaliaAPI/Features/Login/LoginController.cs:75 — // Hack to show diamantium on login. This is normally returned by a BaaS endpoint which we don't control, but — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D17 · Explicit Debt · FixmeComment · ×1
  • FixmeComment DragaliaAPI/DragaliaAPI/Features/Present/PresentController.cs:103 — // FIXME - if you claim duplicate wyrmprints and get rewarded eldwater, it works — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D18 · Solution Shape · Build failed · ×1
  • Build failed — The target solution did not build cleanly (errors: 82), which caps Solution Shape at 3/10 — the most basic shape signal is that it compiles. First errors: MSB3073: The command ""DragaliaAPI/DragaliaAPI.MissionDesigner/bin/Debug/DragaliaAPI.MissionDesigner" "DragaliaAPI/DragaliaAPI.Shared/Resources/"" exited with code 131.; MSB4181: The "MSBuild" task returned false but did not log an error.; CS0246: The type or namespace name 'PluginBase' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'Photon' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'IPluginFactory' could not be found (are you missing a using directive or an assembly reference?).
D2 · Cognitive Complexity · CharaController.CharaManaNodeUnlock (cognitive 71) · ×1
  • CharaController.CharaManaNodeUnlock (cognitive 71) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:508 — CharaController.CharaManaNodeUnlock has cognitive complexity 71 (threshold 15). Of this number, 70 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs holds 2 of the 26 methods over the threshold — including the worst — and 59 of the 209 points over it (28%), 2.7× the next-largest file (DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs at 22). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · ClearPartyService.ProcessLostUnitList (cognitive 37) · ×1
  • ClearPartyService.ProcessLostUnitList (cognitive 37) DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs:138 — ClearPartyService.ProcessLostUnitList has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MissionProgressionService.ProcessMissionEvents (cognitive 37) · ×1
  • MissionProgressionService.ProcessMissionEvents (cognitive 37) DragaliaAPI/DragaliaAPI/Features/Missions/MissionProgressionService.cs:313 — MissionProgressionService.ProcessMissionEvents has cognitive complexity 37 (threshold 15). Of this number, 30 points are the body's own statements and 7 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FortService.CollectIncome (cognitive 26) · ×1
  • FortService.CollectIncome (cognitive 26) DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:95 — FortService.CollectIncome has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DmodeDungeonService.GenerateSubsequentFloor (cognitive 24) · ×1
  • DmodeDungeonService.GenerateSubsequentFloor (cognitive 24) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:447 — DmodeDungeonService.GenerateSubsequentFloor has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DmodeDungeonService.GenerateEnemies (cognitive 24) · ×1
  • DmodeDungeonService.GenerateEnemies (cognitive 24) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:969 — DmodeDungeonService.GenerateEnemies has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SavefileService.Import (cognitive 24) · ×1
  • SavefileService.Import (cognitive 24) DragaliaAPI/DragaliaAPI/Features/Login/Savefile/SavefileService.cs:97 — SavefileService.Import has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UpdateDataService.MapUpdateDataList (cognitive 24) · ×1
  • UpdateDataService.MapUpdateDataList (cognitive 24) DragaliaAPI/DragaliaAPI/Features/Shared/UpdateDataService.cs:56 — UpdateDataService.MapUpdateDataList has cognitive complexity 24 (threshold 15). Of this number, 21 points are the body's own statements and 3 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DungeonRepository.BuildDetailedPartyUnit (cognitive 22) · ×1
  • DungeonRepository.BuildDetailedPartyUnit (cognitive 22) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:277 — DungeonRepository.BuildDetailedPartyUnit has cognitive complexity 22 (threshold 15). Most of this is not in the body itself: 7 of the 22 points are its own statements and the rest belongs to 15 function literals inside it that branch (lines 293, 299, 305, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · StoryService.ReadQuestStory (cognitive 21) · ×1
  • StoryService.ReadQuestStory (cognitive 21) DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:196 — StoryService.ReadQuestStory has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EventDropService.ProcessEventPassiveDrops (cognitive 20) · ×1
  • EventDropService.ProcessEventPassiveDrops (cognitive 20) DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:21 — EventDropService.ProcessEventPassiveDrops has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EventSummonService.ExecuteBoxSummon (cognitive 20) · ×1
  • EventSummonService.ExecuteBoxSummon (cognitive 20) DragaliaAPI/DragaliaAPI/Features/Event/Summon/EventSummonService.cs:79 — EventSummonService.ExecuteBoxSummon has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StorySkipService.ProcessQuestCompletions (cognitive 20) · ×1
  • StorySkipService.ProcessQuestCompletions (cognitive 20) DragaliaAPI/DragaliaAPI/Features/Story/Skip/StorySkipService.cs:119 — StorySkipService.ProcessQuestCompletions has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DragonService.IncreaseDragonReliability (cognitive 19) · ×1
  • DragonService.IncreaseDragonReliability (cognitive 19) DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:75 — DragonService.IncreaseDragonReliability has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DragonService.GrantRewardDataForLevel (cognitive 19) · ×1
  • DragonService.GrantRewardDataForLevel (cognitive 19) DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:190 — DragonService.GrantRewardDataForLevel has cognitive complexity 19 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · DragonService.DragonLevelUp (cognitive 19) · ×1
  • DragonService.DragonLevelUp (cognitive 19) DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:628 — DragonService.DragonLevelUp has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CharaController.LimitBreakChara (cognitive 18) · ×1
  • CharaController.LimitBreakChara (cognitive 18) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:444 — CharaController.LimitBreakChara has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs holds 2 of the 26 methods over the threshold — including the worst — and 59 of the 209 points over it (28%), 2.7× the next-largest file (DragaliaAPI/DragaliaAPI/Features/ClearParty/ClearPartyService.cs at 22). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · DungeonRepository.BuildDetailedPartyUnit (cognitive 18) · ×1
  • DungeonRepository.BuildDetailedPartyUnit (cognitive 18) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:149 — DungeonRepository.BuildDetailedPartyUnit has cognitive complexity 18 (threshold 15). Most of this is not in the body itself: 4 of the 18 points are its own statements and the rest belongs to 14 function literals inside it that branch (lines 159, 164, 169, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · V9Update.Apply (cognitive 18) · ×1
  • V9Update.Apply (cognitive 18) DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V9Update.cs:25 — V9Update.Apply has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PaymentService.ProcessPayment (cognitive 18) · ×1
  • PaymentService.ProcessPayment (cognitive 18) DragaliaAPI/DragaliaAPI/Features/Shop/PaymentService.cs:31 — PaymentService.ProcessPayment has cognitive complexity 18 (threshold 15). Of this number, 12 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ShopService.DoPurchase (cognitive 18) · ×1
  • ShopService.DoPurchase (cognitive 18) DragaliaAPI/DragaliaAPI/Features/Shop/ShopService.cs:23 — ShopService.DoPurchase has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EventService.CreateEventData (cognitive 17) · ×1
  • EventService.CreateEventData (cognitive 17) DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:169 — EventService.CreateEventData has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · WeaponService.TryBuildupGeneric (cognitive 17) · ×1
  • WeaponService.TryBuildupGeneric (cognitive 17) DragaliaAPI/DragaliaAPI/Features/Weapons/WeaponService.cs:151 — WeaponService.TryBuildupGeneric has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DungeonRepository.BuildDetailedPartyUnit (cognitive 16) · ×1
  • DungeonRepository.BuildDetailedPartyUnit (cognitive 16) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:25 — DungeonRepository.BuildDetailedPartyUnit has cognitive complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to 14 function literals inside it that branch (lines 32, 37, 42, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · LoginService.RewardLoginBonus (cognitive 16) · ×1
  • LoginService.RewardLoginBonus (cognitive 16) DragaliaAPI/DragaliaAPI/Features/Login/LoginService.cs:27 — LoginService.RewardLoginBonus has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummonService.CommitSummonResult (cognitive 16) · ×1
  • SummonService.CommitSummonResult (cognitive 16) DragaliaAPI/DragaliaAPI/Features/Summoning/SummonService.cs:396 — SummonService.CommitSummonResult has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Medium advisory (unsound) · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Edited copies of one member (3 members, 120+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 120+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:28 — DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:28-147 | DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:153-275 | DragaliaAPI/DragaliaAPI/Features/Dungeon/DungeonRepository.cs:280-426 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 120 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (44 corresponding lines) · ×1
  • Edited copy of a member (44 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:62 — DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:62-105 | DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:146-189 — These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 37+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 37+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:106 — DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:106-143 | DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:146-182 | DragaliaAPI/DragaliaAPI/Features/Fort/BonusService.cs:185-228 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 37 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/MissionService.cs:124 — DragaliaAPI/DragaliaAPI/Features/Missions/MissionService.cs:124-153 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionService.cs:156-190 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (38 corresponding lines) · ×1
  • Edited copy of a member (38 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:154 — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:154-193 | DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:761-798 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×1
  • Edited copy of a member (36 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/Skip/DungeonSkipController.cs:100 — DragaliaAPI/DragaliaAPI/Features/Dungeon/Skip/DungeonSkipController.cs:100-142 | DragaliaAPI/DragaliaAPI/Features/Dungeon/Skip/DungeonSkipController.cs:149-184 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×1
  • Edited copy of a member (26 corresponding lines) DragaliaAPI/DragaliaAPI.Database/Utils/CharaUtils.cs:15 — DragaliaAPI/DragaliaAPI.Database/Utils/CharaUtils.cs:15-40 | DragaliaAPI/DragaliaAPI.Database/Utils/CharaUtils.cs:43-68 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×1
  • Edited copy of a member (33 corresponding lines) DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestController.cs:58 — DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestController.cs:58-92 | DragaliaAPI/DragaliaAPI/Features/AbilityCrests/AbilityCrestController.cs:100-132 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (37 corresponding lines) · ×1
  • Edited copy of a member (37 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:25 — DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:25-63 | DragaliaAPI/DragaliaAPI/Features/Wall/WallStartController.cs:71-107 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 30+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 30+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:315 — DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:315-344 | DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:347-377 | DragaliaAPI/DragaliaAPI/Features/Dungeon/EventDropService.cs:380-409 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) DragaliaAPI/DragaliaAPI.Shared/MasterAsset/MasterAssetData.cs:116 — DragaliaAPI/DragaliaAPI.Shared/MasterAsset/MasterAssetData.cs:116-139 | DragaliaAPI/DragaliaAPI.Shared/MasterAsset/MasterAssetGroup.cs:80-103 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 17+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDeveloperController.cs:21 — DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDeveloperController.cs:21-39 | DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDeveloperController.cs:43-60 | DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDeveloperController.cs:64-80 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:824 — DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:824-845 | DragaliaAPI/DragaliaAPI/Features/DmodeDungeon/DmodeDungeonService.cs:848-870 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 18+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:200 — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:200-221 | DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:228-245 | DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:252-278 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 12+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 12+ corresponding lines) DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:160 — DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:160-174 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:181-192 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:199-210 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:217-228 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:235-249 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:256-270 | DragaliaAPI/DragaliaAPI/Features/Missions/MissionController.cs:277-288 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 15+ corresponding lines) PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:153 — PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:153-167 | PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:176-191 | PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:200-215 | PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:224-239 | PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/EventController.cs:243-258 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×1
  • Edited copy of a member (13 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:617 — DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:617-629 | DragaliaAPI/DragaliaAPI/Features/Fort/FortService.cs:632-644 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×1
  • Edited copy of a member (12 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Trade/AbilityCrestTradeController.cs:38 — DragaliaAPI/DragaliaAPI/Features/Trade/AbilityCrestTradeController.cs:38-49 | DragaliaAPI/DragaliaAPI/Features/Trade/EventTradeController.cs:35-47 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×1
  • Edited copy of a member (14 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:492 — DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:492-505 | DragaliaAPI/DragaliaAPI/Features/Event/EventService.cs:520-534 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×1
  • Edited copy of a member (6 corresponding lines) DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerFriendRequest.cs:25 — DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerFriendRequest.cs:25-30 | DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerHelperUseDate.cs:21-30 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:397 — DragaliaAPI/DragaliaAPI/Features/Story/StoryService.cs:397-404 | DragaliaAPI/DragaliaAPI/Features/Trade/TradeService.cs:282-289 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:71 — DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:71-105 | DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:155-189 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Dungeon/Start/DungeonStartController.cs:71` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `DungeonStartStartMultiRequest` in one and `DungeonStartStartMultiAssignUnitRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:34 — DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:34-60 | DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs:27-53 — before extracting anything, compare `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs` and `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresent.cs:31` calls `Column` and `DragaliaAPI/DragaliaAPI.Database/Entities/DbPlayerPresentHistory.cs:25` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupGroup.cs:13 — DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupGroup.cs:13-31 | DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupLevel.cs:11-29 — before extracting anything, compare `DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupGroup.cs` and `DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupLevel.cs` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/AbilityCrestBuildupGroup.cs:13` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:122 — DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:122-135 | DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:252-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Summoning/SummonOddsLogic.cs:122` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:544 — DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:544-556 | DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:570-583 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `DragaliaAPI/DragaliaAPI/Features/Missions/InitialProgress/MissionInitialProgressionService.cs:544` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×1
  • Duplicated block (10 lines × 2) DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:613 — DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:613-626 | DragaliaAPI/DragaliaAPI/Features/Chara/CharaController.cs:630-639 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×1
  • Duplicated block (5 lines × 2) DragaliaAPI/DragaliaAPI.Database/Utils/CharaConstants.cs:8 — DragaliaAPI/DragaliaAPI.Database/Utils/CharaConstants.cs:8-12 | DragaliaAPI/DragaliaAPI.Database/Utils/CharaUtils.cs:8-12 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:34 — PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/Discord/DiscordPlugin.cs:34-50 | PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/StateManager/StateManagerPlugin.cs:123-139 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D8 · Code Coverage · Coverage not measured · ×1
  • Coverage not measured — JavaScript/TypeScript suite — Coverage NOT MEASURED: the .NET half measured 53.7%; the JavaScript/TypeScript half could not be measured — MaintenanceWorker/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan.
P1 · CI/CD gates · CI formatting step cannot fail · ×1
  • CI formatting step cannot fail REDACTED:50 — `pnpm run lint:prettier` invokes prettier in the mode that REWRITES the files it reformats and exits 0 whatever it changed. The rewrite happens inside the runner's throwaway checkout and is then discarded, so the step passes on a badly-formatted change exactly as it passes on a clean one — it enforces nothing, and no other step in this file reads the result. `--check` is the flag that turns the same invocation into a gate: it leaves the files alone and exits non-zero when anything would have been reformatted.
P5 · DR & Backup · No DR/backup evidence · ×1
  • No DR/backup evidence — A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
Minor — 81 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×17
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Album/CharaHonorHelper.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Player/UserService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Shop/ShopService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Database/Utils/DragonConstants.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Chara/CharaService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Dragons/DragonController.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Shared/PlayerDetails/PlayerIdentityService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Missions/MissionCompleteType.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/ManaCircle/CharaLimitBreak.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Shop/ItemSummonService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Shop/IShop.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Album/AlbumService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Database/Utils/TutorialFlagUtil.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/QuestRewards/QuestRewardData.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V22Update.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Item/ItemService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file DragaliaAPI/DragaliaAPI/Features/Login/SavefileUpdate/V4Update.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
IC1 · Incompleteness & stubs · Commented-out code · ×11
  • Commented-out code DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:588 — 9 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/Materials.cs:598 — 8 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:968 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:969 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:977 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dragons/DragonService.cs:978 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dungeon/OddsInfoService.cs:24 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Dungeon/OddsInfoService.cs:37 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Features/Summoning/SummonService.cs:670 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Infrastructure/CustomControllerFeatureProvider.cs:30 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code DragaliaAPI/DragaliaAPI/Infrastructure/OutputCaching/RepeatedRequestPolicy.cs:68 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
AX6 · Interface segregation · Fat interface · ×6
  • Fat interface: IUnitRepository (17 members) DragaliaAPI/DragaliaAPI.Database/Repositories/IUnitRepository.cs:6 — `IUnitRepository` declares 17 members: `Dragons`, `DragonReliabilities`, `WeaponBodies`, `AbilityCrests`, `Talismans`, `RemoveDragons`, `GetCharaSetData`, `AddCharaSetData`, `GetCharaSets`, `GetCharaSets`, `FindCharaAsync`, `FindDragonAsync`, `FindDragonReliabilityAsync`, `FindTalismanAsync`, `FindWeaponBodyAsync`, `AddTalisman`, `RemoveTalisman`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IShop (37 members) DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Shop/IShop.cs:5 — `IShop` declares 37 members: `Id`, `Limit`, `PaymentType`, `NeedCost`, `DestinationEntityType1`, `DestinationEntityId1`, `DestinationEntityQuantity1`, `DestinationLimitBreakCount1`, `DestinationEntityType2`, `DestinationEntityId2`, `DestinationEntityQuantity2`, `DestinationLimitBreakCount2`, `DestinationEntityType3`, `DestinationEntityId3`, `DestinationEntityQuantity3`, `DestinationLimitBreakCount3`, `DestinationEntityType4`, `DestinationEntityId4`, `DestinationEntityQuantity4`, `DestinationLimitBreakCount4`, `DestinationEntityType5`, `DestinationEntityId5`, `DestinationEntityQuantity5`, `DestinationLimitBreakCount5`, `DestinationEntityType6`, `DestinationEntityId6`, `DestinationEntityQuantity6`, `DestinationLimitBreakCount6`, `DestinationEntityType7`, `DestinationEntityId7`, `DestinationEntityQuantity7`, `DestinationLimitBreakCount7`, `DestinationEntityType8`, `DestinationEntityId8`, `DestinationEntityQuantity8`, `DestinationLimitBreakCount8`, `DestinationEntities`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IEventRepository (21 members) DragaliaAPI/DragaliaAPI/Features/Event/IEventRepository.cs:5 — `IEventRepository` declares 21 members: `EventData`, `Rewards`, `Items`, `Passives`, `GetEventDataAsync`, `GetEventRewardsAsync`, `GetEventRewardIdsAsync`, `GetEventItemAsync`, `GetEventItemAsync`, `GetEventItemsAsync`, `GetEventItemQuantityAsync`, `GetEventPassivesAsync`, `GetEventPassiveAsync`, `CreateEventData`, `CreateEventReward`, `CreateEventItems`, `CreateEventPassives`, `AddItemQuantityAsync`, `RemoveItemQuantityAsync`, `AddEventPassiveProgressAsync`, `HasEventDataAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 21 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IEventService (17 members) DragaliaAPI/DragaliaAPI/Features/Event/IEventService.cs:5 — `IEventService` declares 17 members: `GetCustomEventFlag`, `GetEventRewardList`, `GetEventPassiveList`, `ReceiveEventRewards`, `ReceiveEventLocationReward`, `CreateEventData`, `GetEventCharaFriendshipList`, `GetBuildEventUserData`, `GetRaidEventUserData`, `GetClb01EventUserData`, `GetCollectEventUserData`, `GetCombatEventUserData`, `GetEarnEventUserData`, `GetExHunterEventUserData`, `GetExRushEventUserData`, `GetMazeEventUserData`, `GetSimpleEventUserData`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IFortService (19 members) DragaliaAPI/DragaliaAPI/Features/Fort/IFortService.cs:7 — `IFortService` declares 19 members: `GetBuildList`, `AddCarpenter`, `GetFortDetail`, `CollectIncome`, `BuildAtOnce`, `LevelupAtOnce`, `CancelBuild`, `CancelLevelup`, `EndBuild`, `EndLevelup`, `BuildStart`, `LevelupStart`, `Move`, `ClearPlantNewStatuses`, `ClearPlantNewStatuses`, `GetRupieProduction`, `GetDragonfruitProduction`, `GetStaminaProduction`, `GetCoreLevels`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IMissionProgressionService (29 members) DragaliaAPI/DragaliaAPI/Features/Missions/IMissionProgressionService.cs:6 — `IMissionProgressionService` declares 29 members: `OnQuestCleared`, `OnEventGroupCleared`, `OnQuestStoryCleared`, `OnWeaponEarned`, `OnWeaponRefined`, `OnAbilityCrestBuildupPlusCount`, `OnAbilityCrestTotalPlusCountUp`, `OnAbilityCrestLevelUp`, `OnCharacterBuildupPlusCount`, `OnCharacterLevelUp`, `OnCharacterManaNodeUnlock`, `OnDragonLevelUp`, `OnDragonGiftSent`, `OnDragonBondLevelUp`, `OnItemSummon`, `OnPartyOptimized`, `OnAbilityCrestTradeViewed`, `OnGuildCheckInRewardClaimed`, `OnPartyPowerReached`, `OnTreasureTrade`, `OnEventParticipation`, `OnEventRegularBattleCleared`, `OnEventQuestClearedWithCrest`, `OnEventPointCollected`, `OnEventChallengeBattleCleared`, `OnEventTrialCleared`, `OnEventRaidCleared`, `EnqueueEvent`, `ProcessMissionEvents`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
X10 · Duplicated predicate · Duplicated predicate · ×6
  • Duplicated predicate DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/QuestData.cs:62 — `!string.IsNullOrEmpty(x.ScenePath) && !string.IsNullOrEmpty(x.AreaName)` appears character-identically in 2 files — DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/QuestData.cs, DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Wall/QuestWallDetail.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/CharaListValidator.cs:21 — `MasterAsset.QuestData.TryGetValue(questId, out QuestData? questData) && questData.LimitedElementalType != UnitElement.None` appears character-identically in 2 files — DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/CharaListValidator.cs, DragaliaAPI/DragaliaAPI/Features/TimeAttack/Validation/DragonListValidator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Website/src/routes/(main)/account/+layout.ts:13 — `response.status >= 400 && response.status <= 499` appears character-identically in 2 files — Website/src/routes/(main)/account/+layout.ts, Website/src/routes/(main)/admin/+layout.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate DragaliaAPI/DragaliaAPI/Features/Friends/FriendNotificationService.cs:58 — `x.PlayerViewerId == playerIdentityService.ViewerId && x.IsNew` appears character-identically in 2 files — DragaliaAPI/DragaliaAPI/Features/Friends/FriendNotificationService.cs, DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate DragaliaAPI/DragaliaAPI/Features/Friends/FriendNotificationService.cs:28 — `x.ToPlayerViewerId == playerIdentityService.ViewerId && x.IsNew` appears character-identically in 2 files — DragaliaAPI/DragaliaAPI/Features/Friends/FriendNotificationService.cs, DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs:249 — `y.PlayerFriendshipPlayers.Any(z => z.PlayerViewerId == playerIdentityService.ViewerId ) && y.PlayerFriendshipPlayers.Any(z => z.PlayerViewer…` appears character-identically in 2 files — DragaliaAPI/DragaliaAPI/Features/Friends/FriendService.cs, DragaliaAPI/DragaliaAPI/Features/Friends/RealHelperDataService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
C2 · Access Controls · Endpoints outside the guard · ×3
  • Endpoints outside the guard REDACTED:17 — Access here is not default-deny: `HeroParamController.GetHeroParam` is in a controller that declares no authorization (on itself, a base controller or any action) while 62 sibling controllers do, and no fallback policy, global AuthorizeFilter or gated MapControllers covers it. Where the endpoint returns stored data or changes state, D29 reports it as missing authorization.
  • Endpoints outside the guard REDACTED:23 — Access here is not default-deny: `HeroParamController.GetHeroParam` is in a controller that declares no authorization (on itself, a base controller or any action) while 62 sibling controllers do, and no fallback policy, global AuthorizeFilter or gated MapControllers covers it. Where the endpoint returns stored data or changes state, D29 reports it as missing authorization.
  • Endpoints outside the guard REDACTED:14 — Access here is not default-deny: `MaintenanceController.GetText` is in a controller that declares no authorization (on itself, a base controller or any action) while 62 sibling controllers do, and no fallback policy, global AuthorizeFilter or gated MapControllers covers it. Where the endpoint returns stored data or changes state, D29 reports it as missing authorization.
D31 · IaC & Container Security · Low IaC · ×3
  • REDACTED
  • REDACTED
  • REDACTED
IC1 · Incompleteness & stubs · Disabled test · ×3
  • Disabled test DragaliaAPI/DragaliaAPI.Integration.Test/Other/MetricsTest.cs:19 — A test is skipped ("Test fails but functionality works") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
  • Disabled test PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:22 — A test is skipped ("Test fails but functionality works") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
  • Disabled test PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:82 — A test is skipped ("Test fails but functionality works") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
S1 · Web-Security Posture · No security response headers detected · ×3
  • No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
  • No security response headers detected DragaliaAPI/DragaliaAPI/Program.cs:22 — This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
  • No security response headers detected PhotonStateManager/DragaliaAPI.Photon.StateManager/Program.cs:8 — This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
S1 · Web-Security Posture · No app-layer HTTPS enforcement detected · ×3
  • No app-layer HTTPS enforcement detected — No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
  • No app-layer HTTPS enforcement detected DragaliaAPI/DragaliaAPI/Program.cs:22 — This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it.
  • No app-layer HTTPS enforcement detected PhotonStateManager/DragaliaAPI.Photon.StateManager/Program.cs:8 — This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it.
X4 · Structured logging · Interpolated log message defeats structured logging · ×3
  • Interpolated log message defeats structured logging PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:39 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:41 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging PhotonPlugin/DragaliaAPI.Photon.Plugin/Shared/Helpers/PluginHostExtensions.cs:50 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
D17 · Explicit Debt · ObsoleteWithoutCallers · ×2
  • ObsoleteWithoutCallers DragaliaAPI/DragaliaAPI/Features/Shared/IUpdateDataService.cs:7 — [Obsolete] SaveChangesAsync
  • ObsoleteWithoutCallers DragaliaAPI/DragaliaAPI/Features/Shared/UpdateDataService.cs:32 — [Obsolete] SaveChangesAsync
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×2
  • Projects may be oversized for their cohesion DragaliaAPI/DragaliaAPI/DragaliaAPI.csproj:1 — `DragaliaAPI` overshoots its size bounds (63203 LoC, 1354 public types across 68 namespaces). 2 of 19 project(s) overshoot their size bounds, lowering Project Cohesion to 7.9/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion DragaliaAPI/DragaliaAPI.Shared/DragaliaAPI.Shared.csproj:1 — `DragaliaAPI.Shared` overshoots its size bounds (9931 LoC, 229 public types across 29 namespaces). 2 of 19 project(s) overshoot their size bounds, lowering Project Cohesion to 7.9/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
D30 · Dependency Vulnerabilities · Low vulnerability · ×2
  • REDACTED
  • REDACTED
C4 · Data Retention · Partial data-retention evidence · ×1
  • Partial data-retention evidence — A retention mechanism is present, but the data-lifecycle is not yet complete — missing: a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob), a documented retention period / data-expiry.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found REDACTED:4 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `REDACTED` makes this repository a deployable product (line 4).
D21 · Naming Consistency · `AttackBaseOnHPUpRate` spells `HP` where 22 names in the project spell it `Hp` · ×1
  • `AttackBaseOnHPUpRate` spells `HP` where 22 names in the project spell it `Hp` DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:72 — 22 of 23 names in project DragaliaAPI.Shared spell the token `Hp` (22 of 23; unit: names in project DragaliaAPI.Shared containing `Hp`). Peers: AbilityTypes.RecoveryHpOnHitCount (DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:18); AbilityTypes.RebornHpRateUp (DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:71); AbilityTypes.ConsumeSpToRecoverHp (DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:79); AbilityTypes.ModifyBuffDebuffDurationTimeByRecoveryHp (DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:81); AbilityTypes.ConsumeUtpToRecoverHp (DragaliaAPI/DragaliaAPI.Shared/Definitions/Enums/AbilityTypes.cs:88). Rename to `AttackBaseOnHpUpRate`. [rule N6]
D24 · Comment Value · redundant comment · ×1
  • redundant comment DragaliaAPI/DragaliaAPI.Integration.Test/Features/Trade/TreasureTradeResetTest.cs:13 — "Trade with no reset" repeats the code it sits on: 3 of its 3 words (trade, no, reset) are already in `private const int NoResetTradeId = 10010101;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
D26 · Project Cohesion · Split DragaliaAPI.Shared · ×1
  • Split DragaliaAPI.Shared DragaliaAPI/DragaliaAPI.Shared/DragaliaAPI.Shared.csproj:1 — `DragaliaAPI.Shared` overshoots its size bounds (9931 LoC, 229 public types across 29 namespaces). These parts reach the rest of the project only through its shared core (`(root)`, `Features`), so they are the cleanest seams: `DragaliaAPI.Shared.PlayerDetails` (5 types in 3 files): 0 of 18 of its type references cross into a sibling namespace, and the rest of the project uses it 2 times and it uses the rest 0 times. Extract each into its own project.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 17 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: DragaliaAPI/DragaliaAPI/Features/Album/CharaHonorHelper.cs, DragaliaAPI/DragaliaAPI/Features/Player/UserService.cs, DragaliaAPI/DragaliaAPI/Features/Shop/ShopService.cs, DragaliaAPI/DragaliaAPI.Database/Utils/DragonConstants.cs, DragaliaAPI/DragaliaAPI/Features/Chara/CharaService.cs, DragaliaAPI/DragaliaAPI/Features/Dragons/DragonController.cs, DragaliaAPI/DragaliaAPI.Shared/PlayerDetails/PlayerIdentityService.cs, DragaliaAPI/DragaliaAPI.Shared/MasterAsset/Models/Missions/MissionCompleteType.cs (and 9 more) (19 orphaned of 227 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 227 of the 906 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
IC1 · Incompleteness & stubs · Member throws NotSupportedException · ×1
  • Member throws NotSupportedException DragaliaAPI/DragaliaAPI/Features/Dungeon/SingleValuePicker.cs:18 — `PickDistinct`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 7/8 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 8, 3 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
S1 · Web-Security Posture · Secure cookie flags not detected · ×1
  • Secure cookie flags not detected DragaliaAPI/DragaliaAPI/Features/Web/WebAuthenticationHelper.cs:17 — No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.)
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 211/762 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X5 · Nullable reference types · Null-forgiving operator (`!`) suppressions override nullable warnings · ×1
  • Null-forgiving operator (`!`) suppressions override nullable warnings — ~0.1 `!` suppressions per 1k syntax nodes — 111 suppression(s) across the 934061 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
Minor — 61 finding(s)
D12 · Dependency Hygiene · Outdated · ×42
  • Outdated: Aspire.Hosting.AppHost — REDACTED → 13.6.5 available (referenced by Dawnshard.AppHost).
  • Outdated: Aspire.Hosting.PostgreSQL — Aspire.Hosting.PostgreSQL 13.4.6 → 13.6.5 available (referenced by Dawnshard.AppHost).
  • Outdated: Aspire.Hosting.Redis — Aspire.Hosting.Redis 13.4.6 → 13.6.5 available (referenced by Dawnshard.AppHost).
  • Outdated: OpenTelemetry.Exporter.OpenTelemetryProtocol — OpenTelemetry.Exporter.OpenTelemetryProtocol 1.19.1 → 1.21.0 available (referenced by Dawnshard.ServiceDefaults).
  • Outdated: OpenTelemetry.Extensions.Hosting — OpenTelemetry.Extensions.Hosting 1.19.1 → 1.21.0 available (referenced by Dawnshard.ServiceDefaults).
  • Outdated: OpenTelemetry.Instrumentation.AspNetCore — OpenTelemetry.Instrumentation.AspNetCore 1.19.0 → 1.21.0 available (referenced by Dawnshard.ServiceDefaults).
  • Outdated: OpenTelemetry.Instrumentation.Http — OpenTelemetry.Instrumentation.Http 1.19.0 → 1.21.0 available (referenced by Dawnshard.ServiceDefaults).
  • Outdated: OpenTelemetry.Instrumentation.Runtime — OpenTelemetry.Instrumentation.Runtime 1.19.0 → 1.21.0 available (referenced by Dawnshard.ServiceDefaults).
  • Outdated: FluentAssertions — FluentAssertions 6.12.2 → 8.11.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Microsoft.EntityFrameworkCore.InMemory — Microsoft.EntityFrameworkCore.InMemory 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Microsoft.Extensions.DependencyInjection.Abstractions — Microsoft.Extensions.DependencyInjection.Abstractions 10.0.12 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Microsoft.Extensions.Logging.Abstractions — Microsoft.Extensions.Logging.Abstractions 10.0.12 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Microsoft.Extensions.TimeProvider.Testing — Microsoft.Extensions.TimeProvider.Testing 10.7.0 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: MockQueryable.EntityFrameworkCore — MockQueryable.EntityFrameworkCore 10.0.8 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: MockQueryable.Moq — MockQueryable.Moq 10.0.8 → 11.0.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Moq — Moq 4.20.72 → 4.21.0 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: xunit.v3.mtp-v2 — xunit.v3.mtp-v2 4.0.1 → 4.0.3 available (referenced by DragaliaAPI.Database.Test).
  • Outdated: Microsoft.CodeAnalysis.CSharp — Microsoft.CodeAnalysis.CSharp 5.0.0 → 5.12.0 available (referenced by DragaliaAPI.Database).
  • Outdated: Microsoft.EntityFrameworkCore — Microsoft.EntityFrameworkCore 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Database).
  • Outdated: Microsoft.EntityFrameworkCore.Design — Microsoft.EntityFrameworkCore.Design 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Database).
  • Outdated: Microsoft.EntityFrameworkCore.Tools — Microsoft.EntityFrameworkCore.Tools 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Database).
  • Outdated: Npgsql.EntityFrameworkCore.PostgreSQL — Npgsql.EntityFrameworkCore.PostgreSQL 10.0.2 → 10.0.3 available (referenced by DragaliaAPI.Database).
  • Outdated: Microsoft.AspNetCore.Mvc.Testing — Microsoft.AspNetCore.Mvc.Testing 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Integration.Test).
  • Outdated: Microsoft.AspNetCore.TestHost — Microsoft.AspNetCore.TestHost 10.0.9 → 11.0.0 available (referenced by DragaliaAPI.Integration.Test).
  • Outdated: Microsoft.Extensions.Diagnostics.Testing — Microsoft.Extensions.Diagnostics.Testing 10.7.0 → 11.0.0 available (referenced by DragaliaAPI.Integration.Test).
  • + 17 more in this group — see findings.md.
D24 · Comment Value · doc comments repeat the names · ×8
  • doc comments repeat the names DragaliaAPI/DragaliaAPI/Features/AbilityCrests/IAbilityCrestRepository.cs:19 — 18 of 73 documented parameters and 3 of 138 summaries in `DragaliaAPI` only repeat the member or parameter name (e.g. "The ability crest ID." for `abilityCrestId`). 5 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names DragaliaAPI/DragaliaAPI.Database/Entities/DbNewsItem.cs:54 — 0 of 2 documented parameters and 2 of 77 summaries in `DragaliaAPI.Database` only repeat the member or parameter name (e.g. "Gets or sets the alt text for the body image." for `BodyImageAltText`). Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names DragaliaAPI/DragaliaAPI.Integration.Test/Features/AbilityCrests/AbilityCrestTest.cs:9 — 1 of 9 documented parameters and 17 of 27 summaries in `DragaliaAPI.Integration.Test` only repeat the member or parameter name (e.g. "Tests" for `AbilityCrestTest`). Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names PhotonPlugin/DragaliaAPI.Photon.Plugin/Plugins/GameLogic/GameLogicPlugin.cs:439 — 6 of 23 documented parameters and 4 of 39 summaries in `DragaliaAPI.Photon.Plugin` only repeat the member or parameter name (e.g. "Info from ." for `info`). Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names Shared/DragaliaAPI.Photon.Shared/Models/ApiGame.cs:46 — 1 of 1 documented parameters and 0 of 32 summaries in `DragaliaAPI.Photon.Shared` only repeat the member or parameter name (e.g. "Base instance." for `gameBase`). Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names PhotonStateManager/DragaliaAPI.Photon.StateManager/Controllers/GetController.cs:67 — 3 of 13 documented parameters and 0 of 32 summaries in `DragaliaAPI.Photon.StateManager` only repeat the member or parameter name (e.g. "The room ID." for `roomId`). 3 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names DragaliaAPI/DragaliaAPI.Shared/MasterAsset/MasterAssetData.cs:36 — 1 of 84 documented parameters and 2 of 127 summaries in `DragaliaAPI.Shared` only repeat the member or parameter name (e.g. "Get a" for `Get`). 36 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names DragaliaAPI/DragaliaAPI.Test/UnitTestUtils.cs:22 — 0 of 4 documented parameters and 1 of 9 summaries in `DragaliaAPI.Test` only repeat the member or parameter name (e.g. "Same for ViewerId." for `ViewerId`). 3 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
D10 · Test Quality · Mock framework · ×6
  • Mock framework: Moq — DragaliaAPI.Database.Test references Moq.
  • Mock framework: Moq — DragaliaAPI.Integration.Test references Moq.
  • Mock framework: Moq — DragaliaAPI.Test.Utils references Moq.
  • Mock framework: NSubstitute — DragaliaAPI.Test.Utils references NSubstitute.
  • Mock framework: Moq — DragaliaAPI.Test references Moq.
  • Mock framework: NSubstitute — DragaliaAPI.Test references NSubstitute.
D10 · Test Quality · Skipped (documented) · ×3
  • Skipped (documented): ExportSave_CounterIncreased DragaliaAPI/DragaliaAPI.Integration.Test/Other/MetricsTest.cs:19 — Skipped with a documented reason — a deferral, not lazy debt: Test fails but functionality works
  • Skipped (documented): CreateRoom_CounterIncreases PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:22 — Skipped with a documented reason — a deferral, not lazy debt: Test fails but functionality works
  • Skipped (documented): CloseRoom_CounterDecreases PhotonStateManager/DragaliaAPI.Photon.StateManager.Test/Other/MetricsTest.cs:82 — Skipped with a documented reason — a deferral, not lazy debt: Test fails but functionality works
D5 · Coupling · Off the main sequence · ×2
  • Off the main sequence: DragaliaAPI.Photon.Shared Shared/DragaliaAPI.Photon.Shared/DragaliaAPI.Photon.Shared.csproj:1 — DragaliaAPI.Photon.Shared: abstractness 0.13, instability 0.00, distance 0.87 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
  • Off the main sequence: DragaliaAPI.Shared DragaliaAPI/DragaliaAPI.Shared/DragaliaAPI.Shared.csproj:1 — DragaliaAPI.Shared: abstractness 0.04, instability 0.17, distance 0.79 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-de8a4cef0d9b476eba0ec262d83c053c/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-de8a4cef0d9b476eba0ec262d83c053c/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=422" --report-format json --report-path /tmp/watchdog-gitleaks-de8a4cef0d9b476eba0ec262d83c053c/history-2.json --exit-code 0 --source .10artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-de8a4cef0d9b476eba0ec262d83c053c/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt --exclude DragaliaAPI/DragaliaAPI.Database/Migrations --exclude DragaliaAPI/DragaliaAPI.Shared/Generated --exclude Website/src/lib/shadcn .73artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesdotnet—dotnet list DragaliaAPI.slnx package --vulnerable --include-transitive --format json21artifacts/raw/dotnet-vulnerable.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .9artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 189 file(s) — `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/EventIdAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/MissionTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Models/Attributes/WallTypeAttribute.cs`, `DragaliaAPI/DragaliaAPI.MissionDesigner/Program.cs`, `DragaliaAPI/DragaliaAPI.Shared.SourceGenerator/EquatableReadOnlyList.cs`, … (+184 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json

Run 01a1e99d-bd6a-73e6-ace2-91d3b4350d8e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Appendix C — Personal-data map

Every field, property and record parameter whose name is conventional personal data — 1 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.

Email — 1 field(s)
  • AtgenNAccountInfo.Email DragaliaAPI/DragaliaAPI/Models/Generated/Components.cs:3512

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md