Executive summary
RikkaApps/Shizuku falls short of our standard for production because the project has no automated tests and we found no logging, tracing or health checks in the code. It scores 42 out of 100 and is rated Weak, and five of its seven critical findings are security problems in the build pipeline.
Production Readiness, at 22, is the weakest lens and counts most in the score. The best first step for the work it takes is recording design decisions, worth about 10 points. Adding automated tests would lift Production Readiness itself, worth about 20 points. Raising Production Readiness to 70 would lift the score to about 58.
Four pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. One secret can leak from the build pipeline, and the project has no automated tests, so a change can break it without warning. Adding automated tests, pinning each tool to an exact version and limiting the secret to its own step would close these risks. The set of files in separate parts that keep changing together needs that dependency made explicit.
The product code is 6,467 lines, about €5,500 to rebuild.
If Production Readiness rose from 22 to 70, the lowest score rated Strong, the score would rise from 42 to about 58.
Rebuild cost: about €5,500 · Estimate
| Cost to rebuild | €1,800 to €9,200, for 31 to 97 hours of work, under 0.1 person-years for one engineer |
|---|---|
| Difficulty of the problem | Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write. |
| Quality factor | ×0.7 at a score of 42. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it. |
| Size | Small: 6,467 lines of product code |
| What it is not | Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one. |
Top priorities
Diagnosis: what the measurements show together
Architecture — module dependency graph
Architecture: which parts of the code depend on which
| uses → | 1 common.util | 2 manager.ShizukuApplication | 3 manager.ShizukuManagerProvider | 4 manager.adb.AdbKey | 5 manager.adb.AdbMessage | 6 manager.adb.AdbPairingClient | 7 manager.adb.AdbPairingService | 8 manager.app | 9 manager.home.AdbPermissionLimitedViewHolder | 10 manager.home.HomeAdapter | 11 manager.home.LearnMoreViewHolder | 12 manager.home.ManageAppsViewHolder | 13 manager.home.ServerStatusViewHolder | 14 manager.home.StartAdbViewHolder | 15 manager.home.StartRootViewHolder | 16 manager.home.StartWirelessAdbViewHolder | 17 manager.home.TerminalViewHolder | 18 manager.legacy.LegacyIsNotSupportedActivity | 19 manager.management.AppViewHolder | 20 manager.management.EmptyViewHolder | 21 manager.model | 22 manager.receiver | 23 manager.utils | 24 manager.adb.AdbMdns | 25 manager.adb.AdbPairingClient.State | 26 manager.adb.PairingPacketHeader | 27 manager.authorization | 28 manager.legacy | 29 manager.management | 30 manager.settings | 31 manager.shell | 32 manager.starter | 33 manager.adb | 34 manager.adb.PairingPacketHeader.Type | 35 manager.adb.PairingContext | 36 manager.adb.PeerInfo | 37 manager.home | 38 manager | 39 manager.adb.PeerInfo.Type | 40 manager.ktx |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 common.util | ||||||||||||||||||||||||||||||||||||||||
| 2 manager.ShizukuApplication | ||||||||||||||||||||||||||||||||||||||||
| 3 manager.ShizukuManagerProvider | ||||||||||||||||||||||||||||||||||||||||
| 4 manager.adb.AdbKey | ||||||||||||||||||||||||||||||||||||||||
| 5 manager.adb.AdbMessage | ||||||||||||||||||||||||||||||||||||||||
| 6 manager.adb.AdbPairingClient | ||||||||||||||||||||||||||||||||||||||||
| 7 manager.adb.AdbPairingService | ||||||||||||||||||||||||||||||||||||||||
| 8 manager.app | ||||||||||||||||||||||||||||||||||||||||
| 9 manager.home.AdbPermissionLimitedViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 10 manager.home.HomeAdapter | ||||||||||||||||||||||||||||||||||||||||
| 11 manager.home.LearnMoreViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 12 manager.home.ManageAppsViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 13 manager.home.ServerStatusViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 14 manager.home.StartAdbViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 15 manager.home.StartRootViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 16 manager.home.StartWirelessAdbViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 17 manager.home.TerminalViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 18 manager.legacy.LegacyIsNotSupportedActivity | ||||||||||||||||||||||||||||||||||||||||
| 19 manager.management.AppViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 20 manager.management.EmptyViewHolder | ||||||||||||||||||||||||||||||||||||||||
| 21 manager.model | ||||||||||||||||||||||||||||||||||||||||
| 22 manager.receiver | ||||||||||||||||||||||||||||||||||||||||
| 23 manager.utils | ||||||||||||||||||||||||||||||||||||||||
| 24 manager.adb.AdbMdns | 2 | |||||||||||||||||||||||||||||||||||||||
| 25 manager.adb.AdbPairingClient.State | 4 | |||||||||||||||||||||||||||||||||||||||
| 26 manager.adb.PairingPacketHeader | 1 | |||||||||||||||||||||||||||||||||||||||
| 27 manager.authorization | 1 | |||||||||||||||||||||||||||||||||||||||
| 28 manager.legacy | 2 | |||||||||||||||||||||||||||||||||||||||
| 29 manager.management | 1 | |||||||||||||||||||||||||||||||||||||||
| 30 manager.settings | 1 | |||||||||||||||||||||||||||||||||||||||
| 31 manager.shell | 1 | |||||||||||||||||||||||||||||||||||||||
| 32 manager.starter | 1 | |||||||||||||||||||||||||||||||||||||||
| 33 manager.adb | 1 | 1 | 1 | 1 | ||||||||||||||||||||||||||||||||||||
| 34 manager.adb.PairingPacketHeader.Type | 2 | |||||||||||||||||||||||||||||||||||||||
| 35 manager.adb.PairingContext | 1 | |||||||||||||||||||||||||||||||||||||||
| 36 manager.adb.PeerInfo | 1 | |||||||||||||||||||||||||||||||||||||||
| 37 manager.home | 1 | 1 | 1 | 2 | ||||||||||||||||||||||||||||||||||||
| 38 manager | 1 | 1 | ||||||||||||||||||||||||||||||||||||||
| 39 manager.adb.PeerInfo.Type | 2 | |||||||||||||||||||||||||||||||||||||||
| 40 manager.ktx | 1 |
24→33 manager.adb.AdbMdns uses manager.adb part of a loop✕
- Connections
- 2 pairs of types, where a type in manager.adb.AdbMdns uses a type in manager.adb.
- The types involved
moe.shizuku.manager.adb.AdbMdns.DiscoveryListener→moe.shizuku.manager.adb.AdbMdnsmoe.shizuku.manager.adb.AdbMdns.ResolveListener→moe.shizuku.manager.adb.AdbMdns
- Direction
- manager.adb.AdbMdns uses manager.adb, so a change to manager.adb can break manager.adb.AdbMdns, while a change to manager.adb.AdbMdns can't break manager.adb.
- Position
- Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
25→6 manager.adb.AdbPairingClient.State uses manager.adb.AdbPairingClient✕
- Connections
- 4 pairs of types, where a type in manager.adb.AdbPairingClient.State uses a type in manager.adb.AdbPairingClient.
- The types involved
moe.shizuku.manager.adb.AdbPairingClient.State.ExchangingMsgs→moe.shizuku.manager.adb.AdbPairingClient.Statemoe.shizuku.manager.adb.AdbPairingClient.State.ExchangingPeerInfo→moe.shizuku.manager.adb.AdbPairingClient.Statemoe.shizuku.manager.adb.AdbPairingClient.State.Ready→moe.shizuku.manager.adb.AdbPairingClient.Statemoe.shizuku.manager.adb.AdbPairingClient.State.Stopped→moe.shizuku.manager.adb.AdbPairingClient.State
- Direction
- manager.adb.AdbPairingClient.State uses manager.adb.AdbPairingClient, so a change to manager.adb.AdbPairingClient can break manager.adb.AdbPairingClient.State, while a change to manager.adb.AdbPairingClient.State can't break manager.adb.AdbPairingClient.
- Position
- Below the diagonal: manager.adb.AdbPairingClient.State uses a module listed above it, which is the healthy direction.
26→33 manager.adb.PairingPacketHeader uses manager.adb part of a loop✕
- Connections
- 1 pair of types, where a type in manager.adb.PairingPacketHeader uses a type in manager.adb.
- The types involved
moe.shizuku.manager.adb.PairingPacketHeader.Companion→moe.shizuku.manager.adb.PairingPacketHeader
- Direction
- manager.adb.PairingPacketHeader uses manager.adb, so a change to manager.adb can break manager.adb.PairingPacketHeader, while a change to manager.adb.PairingPacketHeader can't break manager.adb.
- Position
- Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
27→8 manager.authorization uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.authorization uses a type in manager.app.
- The types involved
moe.shizuku.manager.authorization.RequestPermissionActivity→moe.shizuku.manager.app.AppActivity
- Direction
- manager.authorization uses manager.app, so a change to manager.app can break manager.authorization, while a change to manager.authorization can't break manager.app.
- Position
- Below the diagonal: manager.authorization uses a module listed above it, which is the healthy direction.
28→8 manager.legacy uses manager.app✕
- Connections
- 2 pairs of types, where a type in manager.legacy uses a type in manager.app.
- The types involved
moe.shizuku.manager.legacy.LegacyIsNotSupportedActivity→moe.shizuku.manager.app.AppActivitymoe.shizuku.manager.legacy.ShellRequestHandlerActivity→moe.shizuku.manager.app.AppActivity
- Direction
- manager.legacy uses manager.app, so a change to manager.app can break manager.legacy, while a change to manager.legacy can't break manager.app.
- Position
- Below the diagonal: manager.legacy uses a module listed above it, which is the healthy direction.
29→8 manager.management uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.management uses a type in manager.app.
- The types involved
moe.shizuku.manager.management.ApplicationManagementActivity→moe.shizuku.manager.app.AppBarActivity
- Direction
- manager.management uses manager.app, so a change to manager.app can break manager.management, while a change to manager.management can't break manager.app.
- Position
- Below the diagonal: manager.management uses a module listed above it, which is the healthy direction.
30→8 manager.settings uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.settings uses a type in manager.app.
- The types involved
moe.shizuku.manager.settings.SettingsActivity→moe.shizuku.manager.app.AppBarFragmentActivity
- Direction
- manager.settings uses manager.app, so a change to manager.app can break manager.settings, while a change to manager.settings can't break manager.app.
- Position
- Below the diagonal: manager.settings uses a module listed above it, which is the healthy direction.
31→8 manager.shell uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.shell uses a type in manager.app.
- The types involved
moe.shizuku.manager.shell.ShellTutorialActivity→moe.shizuku.manager.app.AppBarActivity
- Direction
- manager.shell uses manager.app, so a change to manager.app can break manager.shell, while a change to manager.shell can't break manager.app.
- Position
- Below the diagonal: manager.shell uses a module listed above it, which is the healthy direction.
32→8 manager.starter uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.starter uses a type in manager.app.
- The types involved
moe.shizuku.manager.starter.StarterActivity→moe.shizuku.manager.app.AppBarActivity
- Direction
- manager.starter uses manager.app, so a change to manager.app can break manager.starter, while a change to manager.starter can't break manager.app.
- Position
- Below the diagonal: manager.starter uses a module listed above it, which is the healthy direction.
33→6 manager.adb uses manager.adb.AdbPairingClient✕
- Connections
- 1 pair of types, where a type in manager.adb uses a type in manager.adb.AdbPairingClient.
- The types involved
moe.shizuku.manager.adb.AdbPairingClient→moe.shizuku.manager.adb.AdbPairingClient.State
- Direction
- manager.adb uses manager.adb.AdbPairingClient, so a change to manager.adb.AdbPairingClient can break manager.adb, while a change to manager.adb can't break manager.adb.AdbPairingClient.
- Position
- Below the diagonal: manager.adb uses a module listed above it, which is the healthy direction.
33→8 manager.adb uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.adb uses a type in manager.app.
- The types involved
moe.shizuku.manager.adb.AdbPairingTutorialActivity→moe.shizuku.manager.app.AppBarActivity
- Direction
- manager.adb uses manager.app, so a change to manager.app can break manager.adb, while a change to manager.adb can't break manager.app.
- Position
- Below the diagonal: manager.adb uses a module listed above it, which is the healthy direction.
33→24 manager.adb uses manager.adb.AdbMdns✕
- Connections
- 1 pair of types, where a type in manager.adb uses a type in manager.adb.AdbMdns.
- The types involved
moe.shizuku.manager.adb.AdbMdns→moe.shizuku.manager.adb.AdbMdns.DiscoveryListener
- Direction
- manager.adb uses manager.adb.AdbMdns, so a change to manager.adb.AdbMdns can break manager.adb, while a change to manager.adb can't break manager.adb.AdbMdns.
- Position
- Below the diagonal: manager.adb uses a module listed above it, which is the healthy direction.
33→26 manager.adb uses manager.adb.PairingPacketHeader✕
- Connections
- 1 pair of types, where a type in manager.adb uses a type in manager.adb.PairingPacketHeader.
- The types involved
moe.shizuku.manager.adb.AdbPairingClient→moe.shizuku.manager.adb.PairingPacketHeader.Type
- Direction
- manager.adb uses manager.adb.PairingPacketHeader, so a change to manager.adb.PairingPacketHeader can break manager.adb, while a change to manager.adb can't break manager.adb.PairingPacketHeader.
- Position
- Below the diagonal: manager.adb uses a module listed above it, which is the healthy direction.
34→26 manager.adb.PairingPacketHeader.Type uses manager.adb.PairingPacketHeader✕
- Connections
- 2 pairs of types, where a type in manager.adb.PairingPacketHeader.Type uses a type in manager.adb.PairingPacketHeader.
- The types involved
moe.shizuku.manager.adb.PairingPacketHeader.Type.PEER_INFO→moe.shizuku.manager.adb.PairingPacketHeader.Typemoe.shizuku.manager.adb.PairingPacketHeader.Type.SPAKE2_MSG→moe.shizuku.manager.adb.PairingPacketHeader.Type
- Direction
- manager.adb.PairingPacketHeader.Type uses manager.adb.PairingPacketHeader, so a change to manager.adb.PairingPacketHeader can break manager.adb.PairingPacketHeader.Type, while a change to manager.adb.PairingPacketHeader.Type can't break manager.adb.PairingPacketHeader.
- Position
- Below the diagonal: manager.adb.PairingPacketHeader.Type uses a module listed above it, which is the healthy direction.
35→33 manager.adb.PairingContext uses manager.adb✕
- Connections
- 1 pair of types, where a type in manager.adb.PairingContext uses a type in manager.adb.
- The types involved
moe.shizuku.manager.adb.PairingContext.Companion→moe.shizuku.manager.adb.PairingContext
- Direction
- manager.adb.PairingContext uses manager.adb, so a change to manager.adb can break manager.adb.PairingContext, while a change to manager.adb.PairingContext can't break manager.adb.
- Position
- Below the diagonal: manager.adb.PairingContext uses a module listed above it, which is the healthy direction.
36→33 manager.adb.PeerInfo uses manager.adb✕
- Connections
- 1 pair of types, where a type in manager.adb.PeerInfo uses a type in manager.adb.
- The types involved
moe.shizuku.manager.adb.PeerInfo.Companion→moe.shizuku.manager.adb.PeerInfo
- Direction
- manager.adb.PeerInfo uses manager.adb, so a change to manager.adb can break manager.adb.PeerInfo, while a change to manager.adb.PeerInfo can't break manager.adb.
- Position
- Below the diagonal: manager.adb.PeerInfo uses a module listed above it, which is the healthy direction.
37→8 manager.home uses manager.app✕
- Connections
- 1 pair of types, where a type in manager.home uses a type in manager.app.
- The types involved
moe.shizuku.manager.home.HomeActivity→moe.shizuku.manager.app.AppBarActivity
- Direction
- manager.home uses manager.app, so a change to manager.app can break manager.home, while a change to manager.home can't break manager.app.
- Position
- Below the diagonal: manager.home uses a module listed above it, which is the healthy direction.
37→21 manager.home uses manager.model✕
- Connections
- 1 pair of types, where a type in manager.home uses a type in manager.model.
- The types involved
moe.shizuku.manager.home.HomeViewModel→moe.shizuku.manager.model.ServiceStatus
- Direction
- manager.home uses manager.model, so a change to manager.model can break manager.home, while a change to manager.home can't break manager.model.
- Position
- Below the diagonal: manager.home uses a module listed above it, which is the healthy direction.
37→29 manager.home uses manager.management✕
- Connections
- 1 pair of types, where a type in manager.home uses a type in manager.management.
- The types involved
moe.shizuku.manager.home.HomeAdapter→moe.shizuku.manager.management.AppsViewModel
- Direction
- manager.home uses manager.management, so a change to manager.management can break manager.home, while a change to manager.home can't break manager.management.
- Position
- Below the diagonal: manager.home uses a module listed above it, which is the healthy direction.
37→33 manager.home uses manager.adb✕
- Connections
- 2 pairs of types, where a type in manager.home uses a type in manager.adb.
- The types involved
moe.shizuku.manager.home.AdbDialogFragment→moe.shizuku.manager.adb.AdbMdnsmoe.shizuku.manager.home.ViewModel→moe.shizuku.manager.adb.AdbMdns
- Direction
- manager.home uses manager.adb, so a change to manager.adb can break manager.home, while a change to manager.home can't break manager.adb.
- Position
- Below the diagonal: manager.home uses a module listed above it, which is the healthy direction.
38→23 manager uses manager.utils✕
- Connections
- 1 pair of types, where a type in manager uses a type in manager.utils.
- The types involved
moe.shizuku.manager.Helps→moe.shizuku.manager.utils.MultiLocaleEntity
- Direction
- manager uses manager.utils, so a change to manager.utils can break manager, while a change to manager can't break manager.utils.
- Position
- Below the diagonal: manager uses a module listed above it, which is the healthy direction.
38→37 manager uses manager.home✕
- Connections
- 1 pair of types, where a type in manager uses a type in manager.home.
- The types involved
moe.shizuku.manager.MainActivity→moe.shizuku.manager.home.HomeActivity
- Direction
- manager uses manager.home, so a change to manager.home can break manager, while a change to manager can't break manager.home.
- Position
- Below the diagonal: manager uses a module listed above it, which is the healthy direction.
39→36 manager.adb.PeerInfo.Type uses manager.adb.PeerInfo✕
- Connections
- 2 pairs of types, where a type in manager.adb.PeerInfo.Type uses a type in manager.adb.PeerInfo.
- The types involved
moe.shizuku.manager.adb.PeerInfo.Type.ADB_DEVICE_GUID→moe.shizuku.manager.adb.PeerInfo.Typemoe.shizuku.manager.adb.PeerInfo.Type.ADB_RSA_PUB_KEY→moe.shizuku.manager.adb.PeerInfo.Type
- Direction
- manager.adb.PeerInfo.Type uses manager.adb.PeerInfo, so a change to manager.adb.PeerInfo can break manager.adb.PeerInfo.Type, while a change to manager.adb.PeerInfo.Type can't break manager.adb.PeerInfo.
- Position
- Below the diagonal: manager.adb.PeerInfo.Type uses a module listed above it, which is the healthy direction.
40→38 manager.ktx uses manager✕
- Connections
- 1 pair of types, where a type in manager.ktx uses a type in manager.
- The types involved
moe.shizuku.manager.ktx.ContextKt→moe.shizuku.manager.ShizukuApplication
- Direction
- manager.ktx uses manager, so a change to manager can break manager.ktx, while a change to manager.ktx can't break manager.
- Position
- Below the diagonal: manager.ktx uses a module listed above it, which is the healthy direction.
At a glance — Code Health
At a glance — Architecture
At a glance — Maturity
At a glance — Readiness
At a glance — Security
Security & Compliance — OWASP Top-10 mapping
| OWASP category | Findings | Severity |
|---|---|---|
| A05:2025 — Injection | 9 | High / Critical |
| A03:2025 — Software Supply Chain Failures | 5 | Medium |
Roadmap
Top priorities: Resolve the 1 No automated tests finding(s) in Code Coverage; Resolve the 1 No ADRs found finding(s) in ADR Quality; Resolve the 42 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED, IntegerSimpleMenuPreference.java, AdbPairingService.kt.
| Do this | Helps | Effort | Dimension |
|---|---|---|---|
| Resolve the 1 No ADRs found finding(s) in ADR Quality. | +10.3 pts | Low | ADR Quality |
| Resolve the 42 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED, IntegerSimpleMenuPreference.java, AdbPairingService.kt. | +10.1 pts | Medium | Knowledge Freshness |
| Resolve the 1 No automated tests finding(s) in Code Coverage. | +19.6 pts | High | Code Coverage |
| Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them. | +7.5 pts | Medium | Architecture documentation |
| Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag. Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce. | +6.9 pts | Medium | Observability |
| Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing. | +6.9 pts | Medium | Security & performance tooling |
| Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release. | +2.8 pts | Medium | Release Hygiene |
| Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite. | +1.5 pts | Medium | Documentation (README) |
File quality
| File | Score | Band | Worst signal |
|---|---|---|---|
| REDACTED | 2.5 | Slop | Static Analysis (SAST): High: REDACTED |
| server/src/main/java/rikka/shizuku/server/ShizukuService.java | 2.5 | Slop | Change Coupling: Boundary-crossing change coupling: ShizukuService.java ↔ ServiceStarter.java |
| REDACTED | 6.3 | Mixed | Static Analysis (SAST): Medium: REDACTED |
| server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt | 7.8 | Mixed | Cyclomatic Complexity: ApkChangedObserversKt.eventToString (cyclomatic 16) |
| server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java | 7.8 | Mixed | Cyclomatic Complexity: ShizukuConfigManager.<init> (cyclomatic 16) |
| manager/src/main/java/moe/shizuku/manager/settings/SettingsFragment.kt | 7.8 | Mixed | Cognitive Complexity: SettingsFragment.onCreatePreferences (cognitive 22) |
| REDACTED | 7.9 | Mixed | Static Analysis (SAST): Medium: REDACTED |
| manager/src/main/java/moe/shizuku/manager/utils/MultiLocaleEntity.java | 8.5 | Near-clean | Cognitive Complexity: MultiLocaleEntity.get (cognitive 25) |
| manager/src/main/java/moe/shizuku/manager/authorization/AuthorizationManager.kt | 8.5 | Near-clean | Cognitive Complexity: AuthorizationManager.getPackages (cognitive 20) |
| server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java | 8.5 | Near-clean | Code Duplication: Duplicated block (8 lines × 2) |
| manager/src/main/java/moe/shizuku/manager/home/AdbDialogFragment.kt | 8.5 | Near-clean | Change Coupling: Change coupling: AdbDialogFragment.kt ↔ AdbPairDialogFragment.kt |
How the grades work
A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.
Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.
Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.
Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 41 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.
What we checked — 41 dimensions across the health lenses
- Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 95 of 108 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line.
- Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
- Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
Tools & methods
| Method | Backs | Version | Evaluator |
|---|---|---|---|
| Roslyn static analysis | Complexity, cohesion, coupling, dead code, API surface, layering | 5.3.0 | ✓ deterministic |
| Native secret scanner | Hardcoded secrets / credentials | 1.0.0 | ✓ deterministic |
| Canine Code Analyzer duplication detector (in-process) | Code duplication | 1.0.0 | ✓ deterministic |
| Coverage (coverlet / dotnet-coverage) | Line & branch coverage | 10.0.400 | ✓ deterministic |
| NuGet / dotnet | Outdated, vulnerable & deprecated dependencies | 10.0.400 | ✓ deterministic |
| git / LibGit2Sharp | Churn hotspots, knowledge concentration, history | 2.43.0 · 0.31.0 | ✓ deterministic |
| gitleaks · semgrep · trivy | Secrets in history, SAST, CVEs, IaC & container, PII / GDPR | 1.86.0 · 0.69.3 | ✓ deterministic |
Run transparency — what happened this run
- D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 6 Maven/Gradle manifest(s) were read, stating a version for 35 dependency(ies) and leaving 0 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
- D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. All 43 significant source file(s) were last meaningfully changed so long ago that no living knowledge remains — nothing since has been substantial enough to re-establish ownership (a broad, mechanical sweep that touches many files shallowly does not count, and neither does no activity at all). There is no concentration to measure, so the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness). Counted over 37 of the 92 production source files in this repository: 49 are under the ~2,400-byte size floor this dimension measures over, and the remaining 6 have no attributable history left to measure.
- D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
- D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
- D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (starter/build.gradle), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
- D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
- AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (manager). the Android app did not build — `./gradlew :manager:assembleDebug` exited 1: FAILURE: Build failed with an exception. * Where: Build file 'build.gradle' line: 27 * What went wrong: A problem occurred evaluating root projec…; runtime evidence skipped (launch chosen because manager/build.gradle applies the Android application plugin and gradlew builds it).
- C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
- GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Java, Kotlin, c, cpp is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
- IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Kotlin, c, cpp is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
- P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
- P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
- S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
- X2 Cancellation propagation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch, got, undici, node:http; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
- D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
- D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
- D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
- D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
- D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
- D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
- D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
- D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
- D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
- D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
- D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
- D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
- D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
- D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
- D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
- D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
- D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
- D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
- D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
- AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
- P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
Dimensions
D1 · Cyclomatic Complexity
2 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ApkChangedObserversKt.eventToString at 16.
What to do
- Bring the 2 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with ApkChangedObserversKt.eventToString (cyclomatic 16), ShizukuConfigManager.<init> (cyclomatic 16). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 9.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
D2 · Cognitive Complexity
9 method(s) exceeded the cognitive complexity threshold of 15; the worst was ShizukuConfigManager.<init> at 29.
What to do
- Bring the 9 bodies over 15 down to 15 or less in Cognitive Complexity — start with ShizukuConfigManager.<init> (cognitive 29), MultiLocaleEntity.get (cognitive 25), ShizukuService.dispatchPermissionConfirmationResult (cognitive 24). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 9 together lifts Cognitive Complexity from 8.6 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
D3 · God Classes
0 god class(es) detected.
D4 · Code Duplication
2 duplicated block group(s) detected.
What to do
- Resolve the 1 Duplicated block (4–15 lines × 3) finding(s) in Code Duplication — start with ShizukuService.java. — One of this dimension's main actionable groups (1 warning-level).
- Resolve the 1 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with IContentProviderUtils.java. — One of this dimension's main actionable groups (1 warning-level).
D5 · Coupling
8 production modules (Gradle+CMake), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 1 module(s) off the main sequence, with abstractness counted on 5 of the 8 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
D6 · Cohesion (LCOM4)
0 of 22 classes have LCOM4 above 3.
D8 · Code Coverage
No automated tests — no test code was found in this repository.
What to do
- Resolve the 1 No automated tests finding(s) in Code Coverage. — One of this dimension's main actionable groups (1 issue-level).
D13 · Secret Scanning
Secret scan ran and found no leaked secrets.
D14 · License Compliance
0 of 24 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 6 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. A further 10 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.
D15 · Churn × Complexity Hotspots
No churn × complexity hotspots in the window.
D17 · Explicit Debt
2 deducted task-comment markers across 6467 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
What to do
- Resolve the 2 TodoComment finding(s) in Explicit Debt — start with ShizukuService.java (2). — One of this dimension's main actionable groups (2 warning-level).
D19 · Documentation Quality
1 of 1 documentation facets pass in full. 1 document(s) read across 1 unit(s).
D20 · ADR Quality
No architecture decision records were found.
What to do
- Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).
D26 · Project Cohesion
0 of 5 build units (Gradle) flagged as possibly oversized/incoherent.
D28 · Secrets (history)
gitleaks scanned the full history AND the current working tree and found no secrets.
D29 · Static Analysis (SAST)
9 finding(s): 0 critical, 5 high, 4 medium, 0 low. 4 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 1 file(s) — `gradlew` (line 74, line 180) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
What to do
- Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
- Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 warning-level).
- No action in Static Analysis (SAST) — all 4 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (4 issue-level, 0 of them charged here).
D34 · Knowledge Freshness
43 of 43 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is server/src/main/java/rikka/shizuku/server/ShizukuService.java. Counted over 43 of the 92 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What to do
- Resolve the 42 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED, IntegerSimpleMenuPreference.java, AdbPairingService.kt. — One of this dimension's main actionable groups (42 recommendation-level).
- Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
- Resolve the 1 Most significant orphaned file finding(s) in Knowledge Freshness — start with ShizukuService.java. — One of this dimension's main actionable groups (1 recommendation-level).
D35 · Change Coupling
Strongest change-coupling: AdbDialogFragment.kt↔AdbPairDialogFragment.kt 80%; ShizukuService.java↔ServiceStarter.java 53%
What to do
- Resolve the 1 Boundary-crossing change coupling finding(s) in Change Coupling — start with ShizukuService.java. — One of this dimension's main actionable groups (1 issue-level).
- Resolve the 1 Change coupling finding(s) in Change Coupling — start with AdbDialogFragment.kt. — One of this dimension's main actionable groups (1 warning-level).
D36 · Supply-chain Provenance & Signing
1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).
What to do
- Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
- Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
- Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
D44 · Platform End-of-Life
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 2 platform declaration(s) and 35 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Frontend & cross-cutting dimensions
AX10 · Code composition
What to do
- The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX3 · Project dependency cycles
AX4 · Dependency direction
AX6 · Interface segregation
M1 · Documentation (README)
What to do
- Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
- Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
- Describe the projects a newcomer cannot place from the root README: 5 of 5 have no README of their own, in their folder or in their family's project (`common`, `manager`, `server`, `shell`, `starter`).
M2 · Architecture documentation
- No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
- No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
- Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
- Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure
What to do
- Start a test surface where your build system looks for one (tests/, test/, spec/, or your ecosystem's test source set) — the separation follows from putting the first tests in the right place.
P1 · CI/CD gates
What to do
- Run the test suite in CI via an explicit runner step (`./gradlew test` for the toolchain this pipeline already uses) and gate merges on it.
P2 · Observability
- No logging or diagnostics emission found. This repository ships a binary its users launch rather than a service you operate, so there is no operator to page — but when a run fails on a user's machine, neither they nor you have anything to read.
What to do
- Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag. Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce.
P3 · Security & performance tooling
- No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
What to do
- Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
- Enable Dependabot/Renovate or a dependency-review gate.
- Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene
- No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
- Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
X12 · Unreachable branch
X15 · Unvalidated length from an untrusted reader
- `dataLength` is read from the bytes being parsed at line 134 (`int`), then used to size a `ByteArray` at line 139 — and nowhere in its scope is `dataLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `dataLength` against the bytes actually remaining and a maximum the format allows before allocating. — manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:139
What to do
- Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop
X18 · Disposal-pattern correctness
X21 · Side-effecting pattern guard
X25 · Inert configuration knob
X26 · Unsynchronised callback handoff
X27 · Collection changed while being enumerated
X3 · Exception handling
- An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×6) — manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java:84, manager/src/main/java/moe/shizuku/manager/receiver/BootCompleteReceiver.kt:78, manager/src/main/java/moe/shizuku/manager/management/AppViewHolder.kt:76, …
- `catch (ignored: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — manager/src/main/java/moe/shizuku/manager/utils/AppIconCache.kt:45
- `catch (e: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — manager/src/main/java/moe/shizuku/manager/utils/AppIconCache.kt:107
- `catch (ex: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — manager/src/main/java/moe/shizuku/manager/management/AppViewHolder.kt:62
- `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt:48, manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:80, manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:110
- An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch. (×9) — manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:153, manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:157, manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:161, …
- `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — common/src/main/java/moe/shizuku/common/util/OsUtils.java:15
What to do
- Swallowed exception (empty catch)
X5 · Nullable reference types
Reference — by lens
| Lens | Score | Rating | Impact |
|---|---|---|---|
| Code Health | 77% | Strong | Solid. |
| Architecture | 100% | Exemplary | Strongest area. |
| Maturity | 40% | Weak — gated by D34, M2 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Readiness | 22% | Critical — gated by D8, P2, P3 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Security | 73% | Adequate — gated by D36 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
Unscored — 1 check(s) recorded observations but carry no score
- X10 Duplicated predicate — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for
- P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
- P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 75 check(s) not relevant to this codebase
- AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
- AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
- AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
- AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
- AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
- AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
- AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
- AX1 Captive dependencies — Not applicable: this repository's Java imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
- AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Java code is a Spring, JSR-330 or CDI singleton bean. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean.
- AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX7 Slice cohesion — not applicable — not a vertical-slice architecture
- AX8 Test isolation — no test/production split to check
- AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
- AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
- AXR1 Runtime accessibility — the Android app did not build — `./gradlew :manager:assembleDebug` exited 1: FAILURE: Build failed with an exception. * Where: Build file 'build.gradle' line: 27 * What went wrong: A problem occurred evaluating root projec…; runtime evidence skipped (launch chosen because manager/build.gradle applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
- C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
- C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
- C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
- C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
- D10 Test Quality — No tests were found in the analyzed repository to assess for quality.
- D11 Test Reliability — No test suite was found to re-run, so reliability couldn't be assessed. Two searches produced that zero and both came back empty: the classifier that reads the loaded workspace recognised no suite it could run, and a walk of the source on disk — which covers the JS/TS `*.test.*` and `*.spec.*` conventions and probes for a Pester suite — found no test source in any other ecosystem either. Neither search reaches a suite that is missing from the loaded workspace and carries no name either walk recognises, so this is 'no suite found by those two searches', not a verdict that the repository has none.
- D12 Dependency Hygiene — Not scored — 6 Maven/Gradle manifest(s) were read, stating a version for 35 dependency(ies) and leaving 0 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
- D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
- D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
- D21 Naming Consistency — Naming consistency is measured on C# and TypeScript only; Java, Kotlin not measured.
- D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
- D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
- D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
- D25 ADR Conformance — no ADRs to check
- D27 Navigability — symbol resolution incomplete — navigability not assessed
- D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
- D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
- D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
- D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
- D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
- D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
- D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
- D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
- D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
- D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
- D9 Test Distribution — No test suite could be collected, so there is no unit/integration/end-to-end mix to read. Not applicable: the absence of tests is D8's reading (Code Coverage), and is counted there once.
- DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (7 value object(s))
- ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
- ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
- ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
- GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
- IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
- P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
- P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
- P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
- P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
- PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
- PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
- PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
- S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- X1 Async correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X30 Support guard that admits what it rejects — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
- X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
- X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
- X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
- X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
- X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
Critical — 7 finding(s)
- REDACTED
- REDACTED
- REDACTED
- REDACTED
- REDACTED
- Boundary-crossing change coupling: ShizukuService.java ↔ ServiceStarter.java server/src/main/java/rikka/shizuku/server/ShizukuService.java:1
- No automated tests
Serious — 46 finding(s)
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java:84
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/receiver/BootCompleteReceiver.kt:78
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/management/AppViewHolder.kt:76
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/home/HomeActivity.kt:126
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:61
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:153
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:157
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:161
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:167
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:171
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:175
- Swallowed exception (empty catch) REDACTED:158
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:291
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:295
- Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:299
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/utils/AppIconCache.kt:45
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/utils/AppIconCache.kt:107
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/management/AppViewHolder.kt:62
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt:48
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:80
- Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:110
- Swallowed exception (caught, then discarded) common/src/main/java/moe/shizuku/common/util/OsUtils.java:15
- REDACTED
- REDACTED
- REDACTED
- TodoComment server/src/main/java/rikka/shizuku/server/ShizukuService.java:409
- TodoComment server/src/main/java/rikka/shizuku/server/ShizukuService.java:417
- ApkChangedObserversKt.eventToString (cyclomatic 16) server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt:88
- ShizukuConfigManager.<init> (cyclomatic 16) server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:103
- ShizukuConfigManager.<init> (cognitive 29) server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:103
- MultiLocaleEntity.get (cognitive 25) manager/src/main/java/moe/shizuku/manager/utils/MultiLocaleEntity.java:33
- ShizukuService.dispatchPermissionConfirmationResult (cognitive 24) server/src/main/java/rikka/shizuku/server/ShizukuService.java:284
- ShizukuService.getApplications (cognitive 24) server/src/main/java/rikka/shizuku/server/ShizukuService.java:421
- SettingsFragment.onCreatePreferences (cognitive 22) manager/src/main/java/moe/shizuku/manager/settings/SettingsFragment.kt:47
- AuthorizationManager.getPackages (cognitive 20) manager/src/main/java/moe/shizuku/manager/authorization/AuthorizationManager.kt:41
- SettingsFragment.setupLocalePreference (cognitive 18) manager/src/main/java/moe/shizuku/manager/settings/SettingsFragment.kt:161
- ShizukuService.updateFlagsForUid (cognitive 18) server/src/main/java/rikka/shizuku/server/ShizukuService.java:373
- ApkChangedObserversKt.eventToString (cognitive 16) server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt:88
- REDACTED
- Change coupling: AdbDialogFragment.kt ↔ AdbPairDialogFragment.kt manager/src/main/java/moe/shizuku/manager/home/AdbDialogFragment.kt:1
- REDACTED
- REDACTED
- Duplicated block (4–15 lines × 3) server/src/main/java/rikka/shizuku/server/ShizukuService.java:322
- Duplicated block (8 lines × 2) server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:22
- No structured logging
- Length read from the parsed input is spent without ever being bounded manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:139
Minor — 54 finding(s)
- Orphaned file REDACTED:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/settings/IntegerSimpleMenuPreference.java:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/settings/SettingsFragment.kt:1
- Orphaned file server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:1
- Orphaned file server/src/main/java/rikka/shizuku/server/BinderSender.java:1
- Orphaned file shell/src/main/java/rikka/shizuku/shell/ShizukuShellLoader.java:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/starter/StarterActivity.kt:1
- Orphaned file manager/build.gradle:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:1
- Orphaned file starter/src/main/java/moe/shizuku/starter/ServiceStarter.java:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/home/HomeActivity.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbPairingTutorialActivity.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/utils/AppIconCache.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/management/AppViewHolder.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/shell/ShellTutorialActivity.kt:1
- Orphaned file server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbMdns.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/home/StartWirelessAdbViewHolder.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbMessage.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/home/AdbDialogFragment.kt:1
- Orphaned file manager/src/main/java/moe/shizuku/manager/receiver/BootCompleteReceiver.kt:1
- Duplicated predicate server/src/main/java/rikka/shizuku/server/BinderSender.java:151
- Duplicated predicate manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt:112
- No ADRs found
- Dormant codebase
- Most significant orphaned file server/src/main/java/rikka/shizuku/server/ShizukuService.java:1
- REDACTED
- REDACTED
- REDACTED
- No ADRs
- No architecture diagram/doc
- No SAST
- No changelog
Minor — 1 finding(s)
- Off the main sequence: :common
Appendix B — Reproduction & audit trail
| Dimension | Tool | Version | Command | Findings | Raw output |
|---|---|---|---|---|---|
| D28 · Secrets (history) | gitleaks | — | gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-54c86b05016f46748d0ec8cd42962f1f/history.json --exit-code 0 --source . | 0 | artifacts/raw/gitleaks-history.json |
| D28 · Secrets (history) | gitleaks | — | gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-54c86b05016f46748d0ec8cd42962f1f/tree.json --exit-code 0 --source . | 0 | artifacts/raw/gitleaks-tree.json |
| D29 · Static Analysis (SAST) | semgrep | — | semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt . | 9 | artifacts/raw/semgrep.json |
| D30 · Dependency Vulnerabilities | none (dependency manifest found, not scanned for vulnerabilities here) | — | none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet). | 0 | — |
| D31 · IaC & Container Security | trivy | — | trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan. | 0 | — |
| D32 · Data Compliance (PII/GDPR) | semgrep | — | semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. | 0 | — |
| D37 · Vulnerability-disclosure Policy | disclosure | — | disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed. | 0 | — |
| D40 · Network Egress Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here. | 0 | — |
| D41 · Kernel & Syscall Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here. | 0 | — |
| D42 · Runtime Threat Enforcement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here. | 0 | — |
| D43 · Malicious Dependencies | none (dependency manifest found, not scanned for vulnerabilities here) | — | none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet). | 0 | — |