Public report of PocketMC/pocket-mc-windows, published 17 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 17 November 2026, 05:58 UTC · Survey ID cd_5bbc5ef3a3734920868043a147713088
PocketMC/pocket-mc-windows
Measured 17 November 2026, 05:57 UTC, at code version 1c800eb
Code coverage is not measured: Suite not runnable in-image.
Boundary Type-Coupling is not measured: Bounded contexts not declared.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 73,697 lines of product code in 10 projects, tests not counted · Estimated rebuild effort: about 2.7 person-years · Weakest lens: Security and Compliance, 38.7
Findings by how serious they are
224 critical792 serious181 minor
7 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 05:57 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
80of 80 dimensions measured by tools.
1155of 1197 findings point to an exact file and line, so you can open each one in the code. The other 42 concern the repository as a whole, such as missing documentation.
80dimensions across 7 lenses, read from 73,697 lines of product code in 10 projects.
PocketMC/pocket-mc-windows falls short of our standard for production, held back most by its Security and Compliance lens, the code's security and compliance. It scores 45.7 out of 100 and is rated Weak, and 30 of its 224 critical findings are security problems.
Security and Compliance, at 38.7, is the weakest lens and counts most in the score. The best first step is replacing the weak hashes, worth about 5.6 points. Keeping the encryption keys in a vault comes next, worth about 4.0 points. Raising Security and Compliance to 70 would lift the score to about 51.7.
Twelve pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Nine secrets can leak from the build pipeline, and 129 errors are caught and ignored, so failures can go unnoticed. Pinning each tool to an exact version, limiting each secret to its own step and handling or logging the ignored errors would close these risks. Fixing the weaknesses the scanner points to would fix the four security weaknesses in the code, and passing outside input through environment variables would deal with the three pipeline steps that put outside input straight into a shell command. The 29 data fields that are written but never read need removing.
The product code is 73,697 lines, about €400,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Security and Compliance rose from 38.7 to 70, the lowest score rated Strong, the score would rise from 45.7 to about 51.7.
Code composition: what the lines of code are
Business logic 48%Supporting code 29%Tests 23%
Rebuild cost: about €400,000 · Estimate
Cost to rebuild
€130,000 to €670,000, for 2,156 to 7,072 hours of work, about 2.7 person-years for 1 to 6 engineers
Difficulty of the problem
High, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 46. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 73,697 lines of product code
Comment lines
The estimate prices 70,767 lines. Comment lines count towards the size of 73,697 lines but aren't priced as work.
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name.
This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114` (SHA1), `PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437` (SHA1), `PocketMC.Infrastructure/Players/PlayerDataService.cs:81` (MD5), `PocketMC.Infrastructure/Storage/DownloaderService.cs:184` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Raises the score by about 4.0 points · Medium effort · Data Protection
3
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED.
Raises the score by about 1.8 points · Low effort · Secret Scanning
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €400,000 to build again, about 2.7 person-years of work. Its weakest lens is Security and Compliance, at 38.7 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. Of all the actions in this report, it raises the score most for the work it takes: about 5.6 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 6.3 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 4% to 10% on every change. The history of the code shows how much it changes: about 47,223 lines over the last 90 days, which is about 191,516 lines a year. At that pace, the extra work comes to an estimated 20.6 to 123.7 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
80 modules, with 319 dependencies between them. 4 loops run through 11 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 40 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
Application.Interfaces uses Domain.Models, so a change to Domain.Models can break Application.Interfaces, while a change to Application.Interfaces can't break Domain.Models.
Position
Below the diagonal: Application.Interfaces uses a module listed above it, which is the healthy direction.
Application.Interfaces.AI uses Domain.Models, so a change to Domain.Models can break Application.Interfaces.AI, while a change to Application.Interfaces.AI can't break Domain.Models.
Position
Below the diagonal: Application.Interfaces.AI uses a module listed above it, which is the healthy direction.
Application.Interfaces.Instances uses Domain.Models, so a change to Domain.Models can break Application.Interfaces.Instances, while a change to Application.Interfaces.Instances can't break Domain.Models.
Position
Below the diagonal: Application.Interfaces.Instances uses a module listed above it, which is the healthy direction.
Application.Services.Mods uses Domain.Models, so a change to Domain.Models can break Application.Services.Mods, while a change to Application.Services.Mods can't break Domain.Models.
Position
Below the diagonal: Application.Services.Mods uses a module listed above it, which is the healthy direction.
Application.Services.Networking uses Domain.Models, so a change to Domain.Models can break Application.Services.Networking, while a change to Application.Services.Networking can't break Domain.Models.
Position
Below the diagonal: Application.Services.Networking uses a module listed above it, which is the healthy direction.
Application.Services.Shell uses Domain.Models, so a change to Domain.Models can break Application.Services.Shell, while a change to Application.Services.Shell can't break Domain.Models.
Position
Below the diagonal: Application.Services.Shell uses a module listed above it, which is the healthy direction.
Desktop.Core.Interfaces uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Core.Interfaces, while a change to Desktop.Core.Interfaces can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Core.Interfaces uses a module listed above it, which is the healthy direction.
Infrastructure.Configuration uses Domain.Models, so a change to Domain.Models can break Infrastructure.Configuration, while a change to Infrastructure.Configuration can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Configuration uses a module listed above it, which is the healthy direction.
Application.Interfaces.Mods uses Domain.Models, so a change to Domain.Models can break Application.Interfaces.Mods, while a change to Application.Interfaces.Mods can't break Domain.Models.
Position
Below the diagonal: Application.Interfaces.Mods uses a module listed above it, which is the healthy direction.
Application.Interfaces.Mods uses Application.Services.Mods, so a change to Application.Services.Mods can break Application.Interfaces.Mods, while a change to Application.Interfaces.Mods can't break Application.Services.Mods.
Position
Below the diagonal: Application.Interfaces.Mods uses a module listed above it, which is the healthy direction.
Application.Services.Instances uses Domain.Models, so a change to Domain.Models can break Application.Services.Instances, while a change to Application.Services.Instances can't break Domain.Models.
Position
Below the diagonal: Application.Services.Instances uses a module listed above it, which is the healthy direction.
Application.Services.Instances uses Application.Interfaces, so a change to Application.Interfaces can break Application.Services.Instances, while a change to Application.Services.Instances can't break Application.Interfaces.
Position
Below the diagonal: Application.Services.Instances uses a module listed above it, which is the healthy direction.
Application.Services.Instances uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Application.Services.Instances, while a change to Application.Services.Instances can't break Application.Interfaces.Instances.
Position
Below the diagonal: Application.Services.Instances uses a module listed above it, which is the healthy direction.
Application.Services.Instances uses Application.Services.Shell, so a change to Application.Services.Shell can break Application.Services.Instances, while a change to Application.Services.Instances can't break Application.Services.Shell.
Position
Below the diagonal: Application.Services.Instances uses a module listed above it, which is the healthy direction.
Desktop.Features.Intelligence uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Intelligence, while a change to Desktop.Features.Intelligence can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Intelligence uses a module listed above it, which is the healthy direction.
Desktop.Features.Intelligence uses Application.Interfaces.AI, so a change to Application.Interfaces.AI can break Desktop.Features.Intelligence, while a change to Desktop.Features.Intelligence can't break Application.Interfaces.AI.
Position
Below the diagonal: Desktop.Features.Intelligence uses a module listed above it, which is the healthy direction.
14→37 Desktop.Features.Intelligence uses Desktop.Features.Consolepart of a loop✕
Connections
1 pair of types, where a type in Desktop.Features.Intelligence uses a type in Desktop.Features.Console.
Desktop.Features.Intelligence uses Desktop.Features.Console, so a change to Desktop.Features.Console can break Desktop.Features.Intelligence, while a change to Desktop.Features.Intelligence can't break Desktop.Features.Console.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Infrastructure.Instances.Providers uses Domain.Models, so a change to Domain.Models can break Infrastructure.Instances.Providers, while a change to Infrastructure.Instances.Providers can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Instances.Providers uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Providers uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Infrastructure.Instances.Providers, while a change to Infrastructure.Instances.Providers can't break Application.Interfaces.Instances.
Position
Below the diagonal: Infrastructure.Instances.Providers uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Providers uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Instances.Providers, while a change to Infrastructure.Instances.Providers can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Instances.Providers uses a module listed above it, which is the healthy direction.
15→19 Infrastructure.Instances.Providers uses Infrastructure.Instancespart of a loop✕
Connections
7 pairs of types, where a type in Infrastructure.Instances.Providers uses a type in Infrastructure.Instances.
Infrastructure.Instances.Providers uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Instances.Providers, while a change to Infrastructure.Instances.Providers can't break Infrastructure.Instances.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Infrastructure.Java uses Domain.Models, so a change to Domain.Models can break Infrastructure.Java, while a change to Infrastructure.Java can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Java uses a module listed above it, which is the healthy direction.
Infrastructure.Java uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Java, while a change to Infrastructure.Java can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Java uses a module listed above it, which is the healthy direction.
Infrastructure.Java uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Infrastructure.Java, while a change to Infrastructure.Java can't break Infrastructure.Configuration.
Position
Below the diagonal: Infrastructure.Java uses a module listed above it, which is the healthy direction.
16→19 Infrastructure.Java uses Infrastructure.Instancespart of a loop✕
Connections
1 pair of types, where a type in Infrastructure.Java uses a type in Infrastructure.Instances.
Infrastructure.Java uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Java, while a change to Infrastructure.Java can't break Infrastructure.Instances.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Infrastructure.Instances.Updates uses Domain.Models, so a change to Domain.Models can break Infrastructure.Instances.Updates, while a change to Infrastructure.Instances.Updates can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Instances.Updates uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Updates uses Application.Interfaces, so a change to Application.Interfaces can break Infrastructure.Instances.Updates, while a change to Infrastructure.Instances.Updates can't break Application.Interfaces.
Position
Below the diagonal: Infrastructure.Instances.Updates uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Updates uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Infrastructure.Instances.Updates, while a change to Infrastructure.Instances.Updates can't break Application.Interfaces.Instances.
Position
Below the diagonal: Infrastructure.Instances.Updates uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Updates uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Instances.Updates, while a change to Infrastructure.Instances.Updates can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Instances.Updates uses a module listed above it, which is the healthy direction.
Infrastructure.Instances.Updates uses Infrastructure.Instances.Providers, so a change to Infrastructure.Instances.Providers can break Infrastructure.Instances.Updates, while a change to Infrastructure.Instances.Updates can't break Infrastructure.Instances.Providers.
Position
Below the diagonal: Infrastructure.Instances.Updates uses a module listed above it, which is the healthy direction.
Infrastructure.Marketplace uses Domain.Models, so a change to Domain.Models can break Infrastructure.Marketplace, while a change to Infrastructure.Marketplace can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Marketplace uses a module listed above it, which is the healthy direction.
Infrastructure.Marketplace uses Application.Services.Mods, so a change to Application.Services.Mods can break Infrastructure.Marketplace, while a change to Infrastructure.Marketplace can't break Application.Services.Mods.
Position
Below the diagonal: Infrastructure.Marketplace uses a module listed above it, which is the healthy direction.
Infrastructure.Marketplace uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Marketplace, while a change to Infrastructure.Marketplace can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Marketplace uses a module listed above it, which is the healthy direction.
Infrastructure.Marketplace uses Application.Interfaces.Mods, so a change to Application.Interfaces.Mods can break Infrastructure.Marketplace, while a change to Infrastructure.Marketplace can't break Application.Interfaces.Mods.
Position
Below the diagonal: Infrastructure.Marketplace uses a module listed above it, which is the healthy direction.
18→19 Infrastructure.Marketplace uses Infrastructure.Instancespart of a loop✕
Connections
2 pairs of types, where a type in Infrastructure.Marketplace uses a type in Infrastructure.Instances.
Infrastructure.Marketplace uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Marketplace, while a change to Infrastructure.Marketplace can't break Infrastructure.Instances.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
37 pairs of types, where a type in Infrastructure.Instances uses a type in Domain.Models. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Infrastructure.Instances uses Domain.Models, so a change to Domain.Models can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Application.Interfaces, so a change to Application.Interfaces can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Application.Interfaces.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Application.Interfaces.Instances.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Infrastructure.Instances.Providers, so a change to Infrastructure.Instances.Providers can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Infrastructure.Instances.Providers.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Infrastructure.Java, so a change to Infrastructure.Java can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Infrastructure.Java.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Instances uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Infrastructure.Instances, while a change to Infrastructure.Instances can't break Infrastructure.Marketplace.
Position
Below the diagonal: Infrastructure.Instances uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Domain.Models, so a change to Domain.Models can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Application.Interfaces, so a change to Application.Interfaces can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Application.Interfaces.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Application.Services.Mods, so a change to Application.Services.Mods can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Application.Services.Mods.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Application.Interfaces.Mods, so a change to Application.Interfaces.Mods can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Application.Interfaces.Mods.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Infrastructure.Mods uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Infrastructure.Mods, while a change to Infrastructure.Mods can't break Infrastructure.Marketplace.
Position
Below the diagonal: Infrastructure.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Infrastructure.Instances.Providers, so a change to Infrastructure.Instances.Providers can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Infrastructure.Instances.Providers.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.InstanceCreation uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.InstanceCreation, while a change to Desktop.Features.InstanceCreation can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.InstanceCreation uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Application.Services.Mods, so a change to Application.Services.Mods can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Application.Services.Mods.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Application.Interfaces.Mods, so a change to Application.Interfaces.Mods can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Application.Interfaces.Mods.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Infrastructure.Instances.Providers, so a change to Infrastructure.Instances.Providers can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Infrastructure.Instances.Providers.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Infrastructure.Marketplace.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Mods uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Mods, while a change to Desktop.Features.Mods can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Mods uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Desktop.Features.Players uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Players, while a change to Desktop.Features.Players can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Players uses a module listed above it, which is the healthy direction.
Infrastructure.Backups uses Domain.Models, so a change to Domain.Models can break Infrastructure.Backups, while a change to Infrastructure.Backups can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Backups uses a module listed above it, which is the healthy direction.
Infrastructure.Backups uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Backups, while a change to Infrastructure.Backups can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Backups uses a module listed above it, which is the healthy direction.
Infrastructure.Backups uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Infrastructure.Backups, while a change to Infrastructure.Backups can't break Infrastructure.Configuration.
Position
Below the diagonal: Infrastructure.Backups uses a module listed above it, which is the healthy direction.
Infrastructure.Backups uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Backups, while a change to Infrastructure.Backups can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Backups uses a module listed above it, which is the healthy direction.
Infrastructure.Backups uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Backups, while a change to Infrastructure.Backups can't break Infrastructure.Instances.
Position
Below the diagonal: Infrastructure.Backups uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Domain.Models, so a change to Domain.Models can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Application.Interfaces.Instances.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Application.Services.Networking, so a change to Application.Services.Networking can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Application.Services.Networking.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Infrastructure.Marketplace.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Networking uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Networking, while a change to Infrastructure.Networking can't break Infrastructure.Instances.
Position
Below the diagonal: Infrastructure.Networking uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Domain.Models, so a change to Domain.Models can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Application.Interfaces, so a change to Application.Interfaces can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Application.Interfaces.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Application.Services.Networking, so a change to Application.Services.Networking can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Application.Services.Networking.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Infrastructure.Configuration.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Infrastructure.Tunnel uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Infrastructure.Tunnel, while a change to Infrastructure.Tunnel can't break Infrastructure.Instances.
Position
Below the diagonal: Infrastructure.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Application.Services.Networking, so a change to Application.Services.Networking can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Application.Services.Networking.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Infrastructure.Networking, so a change to Infrastructure.Networking can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Infrastructure.Networking.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
Desktop.Features.Dashboard uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Dashboard uses a module listed above it, which is the healthy direction.
27→35 Desktop.Features.Dashboard uses Desktop.Features.Tunnelpart of a loop✕
Connections
2 pairs of types, where a type in Desktop.Features.Dashboard uses a type in Desktop.Features.Tunnel.
Desktop.Features.Dashboard uses Desktop.Features.Tunnel, so a change to Desktop.Features.Tunnel can break Desktop.Features.Dashboard, while a change to Desktop.Features.Dashboard can't break Desktop.Features.Tunnel.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Desktop.Features.Instances.Services uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Application.Services.Networking, so a change to Application.Services.Networking can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Application.Services.Networking.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Instances.Services uses Infrastructure.Networking, so a change to Infrastructure.Networking can break Desktop.Features.Instances.Services, while a change to Desktop.Features.Instances.Services can't break Infrastructure.Networking.
Position
Below the diagonal: Desktop.Features.Instances.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Infrastructure.Configuration.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Application.Interfaces.Mods, so a change to Application.Interfaces.Mods can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Application.Interfaces.Mods.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Infrastructure.Marketplace.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Features.Marketplace uses Desktop.Features.Mods, so a change to Desktop.Features.Mods can break Desktop.Features.Marketplace, while a change to Desktop.Features.Marketplace can't break Desktop.Features.Mods.
Position
Below the diagonal: Desktop.Features.Marketplace uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Domain.Models, so a change to Domain.Models can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Domain.Models.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Application.Services.Mods, so a change to Application.Services.Mods can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Application.Services.Mods.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Desktop.Infrastructure uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Infrastructure, while a change to Desktop.Infrastructure can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Infrastructure uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Domain.Models, so a change to Domain.Models can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Domain.Models.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Application.Interfaces.Instances.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Application.Services.Networking, so a change to Application.Services.Networking can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Application.Services.Networking.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Application.Services.Shell, so a change to Application.Services.Shell can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Application.Services.Shell.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Application.Services.Instances, so a change to Application.Services.Instances can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Application.Services.Instances.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Infrastructure.Networking, so a change to Infrastructure.Networking can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Infrastructure.Networking.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
Infrastructure.Diagnostics uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Infrastructure.Diagnostics, while a change to Infrastructure.Diagnostics can't break Infrastructure.Tunnel.
Position
Below the diagonal: Infrastructure.Diagnostics uses a module listed above it, which is the healthy direction.
RemoteControl.Tunnels uses Application.Services.Shell, so a change to Application.Services.Shell can break RemoteControl.Tunnels, while a change to RemoteControl.Tunnels can't break Application.Services.Shell.
Position
Below the diagonal: RemoteControl.Tunnels uses a module listed above it, which is the healthy direction.
RemoteControl.Tunnels uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break RemoteControl.Tunnels, while a change to RemoteControl.Tunnels can't break Infrastructure.Configuration.
Position
Below the diagonal: RemoteControl.Tunnels uses a module listed above it, which is the healthy direction.
RemoteControl.Tunnels uses Infrastructure.Instances, so a change to Infrastructure.Instances can break RemoteControl.Tunnels, while a change to RemoteControl.Tunnels can't break Infrastructure.Instances.
Position
Below the diagonal: RemoteControl.Tunnels uses a module listed above it, which is the healthy direction.
RemoteControl.Tunnels uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break RemoteControl.Tunnels, while a change to RemoteControl.Tunnels can't break Infrastructure.Tunnel.
Position
Below the diagonal: RemoteControl.Tunnels uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Services.Mods, so a change to Application.Services.Mods can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Services.Mods.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Services.Networking, so a change to Application.Services.Networking can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Services.Networking.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Configuration.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Features.Intelligence, so a change to Desktop.Features.Intelligence can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Features.Intelligence.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Java, so a change to Infrastructure.Java can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Java.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Instances.Updates, so a change to Infrastructure.Instances.Updates can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Instances.Updates.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Marketplace, so a change to Infrastructure.Marketplace can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Marketplace.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Mods, so a change to Infrastructure.Mods can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Mods.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Features.Mods, so a change to Desktop.Features.Mods can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Features.Mods.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Backups, so a change to Infrastructure.Backups can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Backups.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Networking, so a change to Infrastructure.Networking can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Networking.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Settings uses Desktop.Infrastructure, so a change to Desktop.Infrastructure can break Desktop.Features.Settings, while a change to Desktop.Features.Settings can't break Desktop.Infrastructure.
Position
Below the diagonal: Desktop.Features.Settings uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Configuration.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Java, so a change to Infrastructure.Java can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Java.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Backups, so a change to Infrastructure.Backups can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Backups.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Desktop.Infrastructure, so a change to Desktop.Infrastructure can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Desktop.Infrastructure.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Shell uses Infrastructure.Diagnostics, so a change to Infrastructure.Diagnostics can break Desktop.Features.Shell, while a change to Desktop.Features.Shell can't break Infrastructure.Diagnostics.
Position
Below the diagonal: Desktop.Features.Shell uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Desktop.Core.Mvvm, so a change to Desktop.Core.Mvvm can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Desktop.Core.Mvvm.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Application.Interfaces.Instances.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Application.Services.Networking, so a change to Application.Services.Networking can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Application.Services.Networking.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Infrastructure.Networking, so a change to Infrastructure.Networking can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Infrastructure.Networking.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
Desktop.Features.Tunnel uses Desktop.Features.Dashboard, so a change to Desktop.Features.Dashboard can break Desktop.Features.Tunnel, while a change to Desktop.Features.Tunnel can't break Desktop.Features.Dashboard.
Position
Below the diagonal: Desktop.Features.Tunnel uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Domain.Models, so a change to Domain.Models can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Domain.Models.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Application.Interfaces, so a change to Application.Interfaces can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Application.Interfaces.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Application.Services.Shell, so a change to Application.Services.Shell can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Application.Services.Shell.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Infrastructure.Configuration.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Application.Services.Instances, so a change to Application.Services.Instances can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Application.Services.Instances.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses Infrastructure.Backups, so a change to Infrastructure.Backups can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break Infrastructure.Backups.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
RemoteControl.Hosting uses RemoteControl.Tunnels, so a change to RemoteControl.Tunnels can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break RemoteControl.Tunnels.
Position
Below the diagonal: RemoteControl.Hosting uses a module listed above it, which is the healthy direction.
36→39 RemoteControl.Hosting uses RemoteControl.Servicespart of a loop✕
Connections
9 pairs of types, where a type in RemoteControl.Hosting uses a type in RemoteControl.Services.
RemoteControl.Hosting uses RemoteControl.Services, so a change to RemoteControl.Services can break RemoteControl.Hosting, while a change to RemoteControl.Hosting can't break RemoteControl.Services.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Desktop.Features.Console uses Desktop.Features.Shell.Interfaces, so a change to Desktop.Features.Shell.Interfaces can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Desktop.Features.Shell.Interfaces.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Application.Interfaces.AI, so a change to Application.Interfaces.AI can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Application.Interfaces.AI.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Desktop.Features.Intelligence, so a change to Desktop.Features.Intelligence can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Desktop.Features.Intelligence.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Console uses Desktop.Features.Tunnel, so a change to Desktop.Features.Tunnel can break Desktop.Features.Console, while a change to Desktop.Features.Console can't break Desktop.Features.Tunnel.
Position
Below the diagonal: Desktop.Features.Console uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Application.Interfaces, so a change to Application.Interfaces can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Application.Interfaces.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Application.Interfaces.AI, so a change to Application.Interfaces.AI can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Application.Interfaces.AI.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Infrastructure.Configuration.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Infrastructure.Java, so a change to Infrastructure.Java can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Infrastructure.Java.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Infrastructure.Instances, so a change to Infrastructure.Instances can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Infrastructure.Instances.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Infrastructure.Tunnel, so a change to Infrastructure.Tunnel can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Infrastructure.Tunnel.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Desktop.Infrastructure, so a change to Desktop.Infrastructure can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Desktop.Infrastructure.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Infrastructure.Diagnostics, so a change to Infrastructure.Diagnostics can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Infrastructure.Diagnostics.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Desktop.Features.Settings, so a change to Desktop.Features.Settings can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Desktop.Features.Settings.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup uses Desktop.Features.Shell, so a change to Desktop.Features.Shell can break Desktop.Features.Setup, while a change to Desktop.Features.Setup can't break Desktop.Features.Shell.
Position
Below the diagonal: Desktop.Features.Setup uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses Application.Interfaces, so a change to Application.Interfaces can break RemoteControl.Services, while a change to RemoteControl.Services can't break Application.Interfaces.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses Application.Interfaces.Instances, so a change to Application.Interfaces.Instances can break RemoteControl.Services, while a change to RemoteControl.Services can't break Application.Interfaces.Instances.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses Application.Services.Shell, so a change to Application.Services.Shell can break RemoteControl.Services, while a change to RemoteControl.Services can't break Application.Services.Shell.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break RemoteControl.Services, while a change to RemoteControl.Services can't break Infrastructure.Configuration.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses Application.Services.Instances, so a change to Application.Services.Instances can break RemoteControl.Services, while a change to RemoteControl.Services can't break Application.Services.Instances.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses RemoteControl.Tunnels, so a change to RemoteControl.Tunnels can break RemoteControl.Services, while a change to RemoteControl.Services can't break RemoteControl.Tunnels.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
RemoteControl.Services uses RemoteControl.Hosting, so a change to RemoteControl.Hosting can break RemoteControl.Services, while a change to RemoteControl.Services can't break RemoteControl.Hosting.
Position
Below the diagonal: RemoteControl.Services uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses Domain.Models, so a change to Domain.Models can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break Domain.Models.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses Application.Services.Shell, so a change to Application.Services.Shell can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break Application.Services.Shell.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses Desktop.Core.Interfaces, so a change to Desktop.Core.Interfaces can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break Desktop.Core.Interfaces.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses Infrastructure.Configuration, so a change to Infrastructure.Configuration can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break Infrastructure.Configuration.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses Application.Services.Instances, so a change to Application.Services.Instances can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break Application.Services.Instances.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
Desktop.Features.Setup.ViewModels uses RemoteControl.Services, so a change to RemoteControl.Services can break Desktop.Features.Setup.ViewModels, while a change to Desktop.Features.Setup.ViewModels can't break RemoteControl.Services.
Position
Below the diagonal: Desktop.Features.Setup.ViewModels uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 58.7 · Adequate · gated by D2 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
42
High / Critical
A03:2025 — Software Supply Chain Failures
10
Medium
A07:2025 — Authentication Failures
1
High / Critical
Roadmap
Top priorities: Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114` (SHA1), `PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437` (SHA1), `PocketMC.Infrastructure/Players/PlayerDataService.cs:81` (MD5), `PocketMC.Infrastructure/Storage/DownloaderService.cs:184` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place; Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps; Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114` (SHA1), `PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437` (SHA1), `PocketMC.Infrastructure/Players/PlayerDataService.cs:81` (MD5), `PocketMC.Infrastructure/Storage/DownloaderService.cs:184` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 224
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 792
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 181
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 7
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 80 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 80 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1155 of 1197 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the test suite could not be built/run in-image (commonly external-service dependencies — a database, a broker — we won't provision). To have it measured, make the suite runnable without them. For context only, test code is ≈ 29% of production LoC (20,812 test / 71,991 production) — a rough proxy, NOT a coverage measurement, so it is excluded from the score. You can widen what we reach: optional: make the suite runnable without a database, broker or other service we do not provision, and real coverage is measured on the next scan.
D17 Explicit Debt — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Msbuild failed when processing the file 'PocketMC.Desktop/PocketMC.Desktop.csproj' with message: There was no runtime pack for Microsoft.WindowsDesktop.App available for the specified RuntimeIdentifier 'linux-x64'.
D18 Solution Shape — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. `dotnet build` reported 2 error(s), and the diagnostics it printed were: NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App available for the specified RuntimeIdentifier 'linux-x64'.; NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App.WPF available for the specified RuntimeIdentifier 'linux-x64'.. None of them is a .NET compiler diagnostic, which is the only signal this check reads as "the code does not compile", so the failure is recorded as a build-environment gap rather than a code defect. The usual causes are a project that targets a platform this run cannot build (a Windows-only target framework on a Linux worker) or a build step that shells out to a tool the image does not carry. Solution Shape is scored on structure and is NOT capped. Semantic analysis is independent of this build and covers every project that loaded — but a project whose restore did not complete has no resolved references, so treat its results as absent rather than clean. ★ The reach of that test, stated so this classification can be checked rather than taken on trust: it reads the C# (CS), Visual Basic (BC) and F# (FS) compiler series, and treats SDK, NuGet-restore and MSBuild codes (NETSDK, NU, MSB) as evidence that the build did not run rather than that the code is broken — read the diagnostics named above and judge for yourself. You can widen what we reach: if this build is meant to run off its own platform, without host tooling we do not carry, the diagnostics named above are what stopped it. If it is deliberately platform-bound — a Windows-only desktop product, say — there is nothing to do here: the note records our reach, not a defect in your build.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (71,991 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `PocketMC.Application/Services/Instances/InstanceOperationCoordinator.cs` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: 2 markup document(s) — HTML, Razor, JSX, Vue, Svelte or server templates. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
P10 Library API & versioning — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Library API & versioning could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
P11 BDD / executable specs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. BDD / executable specs could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
P7 Outbound HTTP resilience — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Outbound HTTP resilience could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
P8 Schema migrations — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Schema migrations could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 64 further occurrence(s) are not listed individually; the score already reflects all 104.
X10 Duplicated predicate — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 13 further occurrence(s) are not listed individually; the score already reflects all 53.
X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 231 further occurrence(s) are not listed individually; the score already reflects all 271.
X3 Exception handling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 105 further occurrence(s) are not listed individually; the score already reflects all 145.
X4 Structured logging — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Structured logging could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: Syntax node is not within syntax tree.
X7 Silent fallback defaults — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 29 further occurrence(s) are not listed individually; the score already reflects all 69.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D11 Test Reliability: Flakiness is inferred from history/markers — we run the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
C3 Audit Trail: This control is scored from in-repo evidence only — a working control configured outside the repository leaves no signal a static scan can credit.
C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
121 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was RemoteDashboardHost.MapEndpoints at 157. A further 5 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being AddonManifestService.RegisterInstallAsync at 25 — they are counted neither in the figure above nor in this dimension's score. 2 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs (PlayitAgentService.IsInvalidOrDeletedSecretLog at 17), PocketMC.Application/Services/Networking/PortFailureMessageService.cs (PortFailureMessageService.GetAction at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 111 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 120 down to 120 or less in Cyclomatic Complexity — start with RemoteDashboardHost.MapEndpoints (cyclomatic 157). — Refactoring it lifts Cyclomatic Complexity from 5.0 to about 5.4/10.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 172 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 120 down to 120 or less in Cognitive Complexity — start with AppConfig.ParseYamlContent (cognitive 196), RemoteDashboardHost.MapEndpoints (cognitive 176), JavaModMetadataService.ParseForgeMetadata (cognitive 125). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 3.1 to about 4.0/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.2 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 17 FileTooLong finding(s) in God Classes — start with SettingsAddonsVM.cs, app.js, AppSettingsPage.xaml.cs. — One of this dimension's main actionable groups (17 warning-level).
Resolve the 13 TooManyMethods finding(s) in God Classes — start with AppSettingsPage.xaml.cs, SettingsAddonsVM.cs, MainWindow.xaml.cs. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 12 MethodTooLong finding(s) in God Classes — start with REDACTED, NewsService.cs, ModpackService.cs. — One of this dimension's main actionable groups (12 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
111 duplicated block group(s) detected. 7.1 % of the production lines (5,097 of 71,991) are in a reported copy. A further 77 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
+ 87 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 10 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with NewInstancePage.xaml.cs (2), SettingsAddonsVM.cs, REDACTED. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 8 Duplicated block (14 lines × 2) finding(s) in Code Duplication — start with DropboxBackupProvider.cs, ServerConsolePage.xaml.cs, MapBrowserPage.xaml.cs. — One of this dimension's main actionable groups (8 warning-level).
Resolve the 7 Duplicated block (13 lines × 2) finding(s) in Code Duplication — start with MapBrowserPage.xaml.cs (2), BedrockPlayerDataService.cs, InstanceTunnelOrchestrator.cs. — One of this dimension's main actionable groups (7 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling9.2 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
Off the main sequence: PocketMC.DomainPocketMC.Domain/PocketMC.Domain.csproj:1
What to do
Resolve the 1 Off the main sequence finding(s) in Coupling — start with PocketMC.Domain.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 3 Low cohesion finding(s) in Cohesion (LCOM4) — start with AppSettingsPage.xaml.cs, OllamaModelManagerDialog.xaml.cs, PortConflictWindow.xaml.cs. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D10 · Test Quality9.9 / 10Stronggated by 16 serious findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
Resolve the 14 Test cannot fail finding(s) in Test Quality — start with MarkdownRenderingTests.cs (5), AdaptiveGridPanelTests.cs (4), HardwareRenderingOptimizerTests.cs (3). — One of this dimension's main actionable groups (14 warning-level).
Resolve the 1 No assertions finding(s) in Test Quality — start with RecoveryRegressionTests.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Fixed-sleep synchronisation finding(s) in Test Quality — start with PlayitAgentDeletionTests.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests pass reliably, with no flakiness.
Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
Resolve the 2 Deprecated finding(s) in Dependency Hygiene — start with Directory.Packages.props (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 Outdated finding(s) in Dependency Hygiene — start with Directory.Packages.props. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 204 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 22 direct `PackageReference`(s), and 182 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: REDACTED (14×157=2198); PocketMC.RemoteControl/Web/app.js (20×62=1240); PocketMC.Infrastructure/Configuration/AppConfig.cs (9×74=666) Repeated repair below the complexity floor: PocketMC.Infrastructure/Telemetry/TelemetryService.cs (3 of 5 changes were fixes); PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs (3 of 5 changes were fixes)
Resolve the 22 Hotspot finding(s) in Churn × Complexity Hotspots — start with REDACTED, app.js, AppConfig.cs. — One of this dimension's main actionable groups (22 warning-level).
Resolve the 2 Repeated repair finding(s) in Churn × Complexity Hotspots — start with TelemetryService.cs, ServerLifecycleService.cs. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor8.7 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
44 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is PocketMC.Infrastructure/News/NewsService.cs. Counted over 250 of the 412 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×2
What to do
Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
164 deducted debt markers + unmeasured dead symbols across 71991 LoC in the .NET projects (2.2/KLoC) → score 5.6. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.
Resolve the 129 EmptyCatchBlock finding(s) in Explicit Debt — start with SettingsAddonsVM.cs (9), MainWindow.xaml.cs (7), BedrockAddonInstaller.cs (7). — One of this dimension's main actionable groups (129 issue-level).
Resolve the 29 WriteOnlyPrivateField finding(s) in Explicit Debt — start with ModpackOverridePolicy.cs (6), ShellStartupCoordinator.cs (2), AddonUpdateService.cs (2). — One of this dimension's main actionable groups (29 issue-level).
Resolve the 3 NoWarnInCsproj finding(s) in Explicit Debt — start with PocketMC.Desktop.csproj, PocketMC.Desktop.Tests.csproj, Directory.Build.props. — One of this dimension's main actionable groups (3 issue-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
10 projects, 572 source files, 92803 hand-written lines of code (71991 production / 20812 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 25 inter-project edges (build NOT measured — `dotnet build` did not complete in the analyzer, so the build half of this dimension is unmeasured rather than failed: the score above rests on structure alone and is not capped. The diagnostics that stopped it are named under Limitations.)
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
2 of 2 documentation facets pass in full. 5 document(s) read across 6 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
No ADRs foundPocketMC.Desktop/PocketMC.Desktop.csproj:4
What to do
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with PocketMC.Desktop.csproj. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
doc comments repeat the names · ×2PocketMC.Application/Services/Networking/PortCheckRequest.cs:12
What to do
Resolve the 14 redundant comment finding(s) in Comment Value — start with AssemblyInfo.cs (4), JavaModMetadataServiceTests.cs (2), InstanceManager.cs. — One of this dimension's main actionable groups (14 recommendation-level).
Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 2 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with PocketMC.Desktop.csproj, PocketMC.Infrastructure.csproj. — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 1 Split PocketMC.Infrastructure finding(s) in Project Cohesion — start with PocketMC.Infrastructure.csproj. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
42 finding(s): 0 critical, 28 high, 14 medium, 0 low. 12 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 13 file(s) — `PocketMC.Application/Services/Instances/InstanceOperationCoordinator.cs` (lines 86–87, line 91, line 102), `PocketMC.Desktop.Tests/Features/Tunnel/InstanceTunnelOrchestratorTunnelFlowTests.cs` (line 162), `PocketMC.Desktop.Tests/Features/Tunnel/SimpleVoiceChatFirstRunTunnelTests.cs` (line 309), `PocketMC.Infrastructure.Tests/Marketplace/CurseForgeServiceSecurityTests.cs` (line 238), `PocketMC.Infrastructure.Tests/Marketplace/ModrinthServiceMetadataTests.cs` (line 70), … (+8 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 4 of those file(s) — `PocketMC.Application/Services/Instances/InstanceOperationCoordinator.cs`, `PocketMC.Infrastructure.Tests/Safety/ReviewRecoveryRegressionTests.cs`, `PocketMC.Infrastructure.Tests/Telemetry/TelemetryServiceTests.cs`, `PocketMC.Infrastructure.Tests/Tunnel/PlayitRuntimeManagementTests.cs` — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. Separately, one or more rules could not re-parse an embedded snippet in 5 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 7 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 issue-level).
No action in Static Analysis (SAST) — all 12 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (12 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 250 of the 412 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 4 Change coupling finding(s) in Change Coupling — start with MapBrowserPage.xaml.cs, CurseForgeService.cs, AppSettingsPage.xaml.cs. — One of this dimension's main actionable groups (4 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 7 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
Do you agree with this assessment?
AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Do you agree with this assessment?
AC3 · Page structure4.6 / 10Weak✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
With more than one navigation landmark, each needs an aria-label/aria-labelledby (e.g. "Primary", "Footer") so assistive tech can tell them apart. At least one nav here is unlabelled. — PocketMC.RemoteControl/Web/index.html:2
user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta. — PocketMC.RemoteControl/Web/index.html:5
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler. (×4) — PocketMC.RemoteControl/Web/app.js:392, PocketMC.RemoteControl/Web/app.js:1512, PocketMC.RemoteControl/Web/app.js:1529, …
The repo's own CSS styles .file-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. (×2) — PocketMC.RemoteControl/Web/app.js:1468, PocketMC.RemoteControl/Web/app.js:1725
The repo's own CSS styles .backup-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. (×4) — PocketMC.RemoteControl/Web/app.js:1834, PocketMC.RemoteControl/Web/app.js:1862, PocketMC.RemoteControl/Web/app.js:1892, …
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`.filter-label:has(#filterWarn:checked)` sets color: #ffffff on background-color: #d97706 — 3.2:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — PocketMC.RemoteControl/Web/styles.css:1210
`.code-editor` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — PocketMC.RemoteControl/Web/styles.css:2549
`.panel` moves (`animation: fade-in 0.25s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:274
`.btn-spinner` moves (`animation: btn-spin 0.8s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:485
`.metric-progress-bar` moves (`transition: width 0.4s cubic-bezier(0.16, 1, 0.3, 1)`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:594
`.snackbar` moves (`animation: snackbar-fade-in 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:712
`.snackbar.fade-out` moves (`animation: snackbar-fade-out 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:716
`.instance-status-pill.busy .status-dot` moves (`animation: pulse-dot 1.5s infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:1067
`.modal-content` moves (`animation: modal-slide-up 0.2s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:1322
`.offline-host-panel` moves (`animation: fade-in 0.25s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:1449
`.offline-pulse-ring` moves (`animation: offline-pulse 2.5s infinite ease-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:1496
`.welcome-btn-arrow` moves (`transition: transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:1726
`.skeleton-box` moves (`animation: skeleton-shimmer 1.5s infinite ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:2274
`.file-row.skeleton-upload-row::after` moves (`animation: skeleton-shimmer 1.4s infinite ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:2623
`.skeleton-spinner` moves (`animation: spin 0.8s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — PocketMC.RemoteControl/Web/styles.css:2669
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
`ForgeInstaller` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/ForgeInstaller.cs:16
`PocketMineLaunchConfigurator` is registered as a SINGLETON but its constructor takes `PhpProvisioningService phpProvisioning`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PhpProvisioningService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/PocketMineLaunchConfigurator.cs:25
`ServerLaunchConfigurator` is registered as a SINGLETON but its constructor takes `PhpProvisioningService phpProvisioning`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PhpProvisioningService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/ServerLaunchConfigurator.cs:47
`ServerLaunchConfigurator` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/ServerLaunchConfigurator.cs:48
`GeyserProvisioningService` is registered as a SINGLETON but its constructor takes `ModrinthService modrinth`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ModrinthService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — REDACTED:20
`ModpackService` is registered as a SINGLETON but its constructor takes `FabricProvider fabricProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `FabricProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Desktop/Features/Mods/ModpackService.cs:70
`ModpackService` is registered as a SINGLETON but its constructor takes `ForgeProvider forgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Desktop/Features/Mods/ModpackService.cs:71
`ModpackService` is registered as a SINGLETON but its constructor takes `NeoForgeProvider neoForgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `NeoForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Desktop/Features/Mods/ModpackService.cs:72
`AddonUpdateService` is registered as a SINGLETON but its constructor takes `ModrinthService modrinth`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ModrinthService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:52
`AddonUpdateService` is registered as a SINGLETON but its constructor takes `CurseForgeService curseForge`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `CurseForgeService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:53
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:23
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `FabricProvider fabricProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `FabricProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:24
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `ForgeProvider forgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:25
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `NeoForgeProvider neoForgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `NeoForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:26
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `PaperProvider paperProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PaperProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:27
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `PocketmineProvider pocketmineProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PocketmineProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:28
`InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `BedrockBdsProvider bedrockProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `BedrockBdsProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:29
`PlayitAgentService` is registered as a SINGLETON but its constructor takes `PlayitPartnerProvisioningClient partnerProvisioningClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PlayitPartnerProvisioningClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:104
What to do
Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`ResourceMonitorService` is a singleton (one shared instance) but mutates instance state outside any lock (_listCommandTick; e.g. `_listCommandTick` at line 87). — PocketMC.Infrastructure/Monitoring/ResourceMonitorService.cs:20
`InstanceExportService` is a singleton (one shared instance) but mutates instance state outside any lock (_activeCts; e.g. `_activeCts` at line 61). — PocketMC.Infrastructure/Instances/InstanceExportService.cs:16
`InstanceImportService` is a singleton (one shared instance) but mutates instance state outside any lock (_activeCts; e.g. `_activeCts` at line 198). — PocketMC.Infrastructure/Instances/InstanceImportService.cs:21
`OneDriveBackupProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_pca; e.g. `_pca` at line 44). — PocketMC.Infrastructure/Backups/Providers/OneDriveBackupProvider.cs:21
`DependencyHealthMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_cts; e.g. `_cts` at line 30). — PocketMC.Infrastructure/Diagnostics/DependencyHealthMonitor.cs:13
`AppNavigationService` is a singleton (one shared instance) but mutates instance state outside any lock (_shellHost, _shellBackStack, _shellForwardStack, _currentShellPageType, _detailPages, _forwardDetailPages; e.g. `_shellHost` at line 57). — PocketMC.Desktop/Infrastructure/AppNavigationService.cs:29
`TelemetryService` is a singleton (one shared instance) but mutates instance state outside any lock (_backgroundTask, _cachedCountry, _hasFetchedCountry; e.g. `_backgroundTask` at line 65). — PocketMC.Infrastructure/Telemetry/TelemetryService.cs:20
`ApplicationState` is a singleton (one shared instance) but mutates instance state outside any lock (Settings; e.g. `Settings` at line 107). — PocketMC.Application/Services/Shell/ApplicationState.cs:6
`UpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (CurrentStage, _disposed; e.g. `CurrentStage` at line 189). — PocketMC.Desktop/Infrastructure/UpdateService.cs:34
`NewsService` is a singleton (one shared instance) but mutates instance state outside any lock (_lifetime; e.g. `_lifetime` at line 151). — PocketMC.Infrastructure/News/NewsService.cs:27
`ShellUIStateService` is a singleton (one shared instance) but mutates instance state outside any lock (_breadcrumbCurrentText, _isBreadcrumbVisible, _titleBarTitle, _titleBarStatusText, _titleBarStatusBrush, _isTitleBarContextVisible; e.g. `_breadcrumbCurrentText` at line 14). — PocketMC.Desktop/Features/Shell/ShellUIStateService.cs:8
`AccentColorService` is a singleton (one shared instance) but mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 186). — PocketMC.Desktop/Features/Shell/AccentColorService.cs:14
`ShellVisualService` is a singleton (one shared instance) but mutates instance state outside any lock (_boundWindow, _isWindowActive; e.g. `_boundWindow` at line 44). — PocketMC.Desktop/Features/Shell/ShellVisualService.cs:14
`ShellStartupCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_host, _isDisposed, _startupServicesStarted, _playitStartupAttempted; e.g. `_host` at line 86). — PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:25
`ShellViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_updateStatusMessage, _isUpdateBannerVisible, _isUpdateDownloading, _updateDownloadPercent, _updateErrorMessage, _isSilentCheck; e.g. `_updateStatusMessage` at line 32). — PocketMC.Desktop/Features/Shell/ShellViewModel.cs:23
`TrayIconViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_tooltipText, _iconVisibility; e.g. `_tooltipText` at line 26). — PocketMC.Desktop/Features/Shell/TrayIconViewModel.cs:11
`PlayitAgentProcessManager` is a singleton (one shared instance) but mutates instance state outside any lock (_logWriter, _process; e.g. `_logWriter` at line 54). — PocketMC.Infrastructure/Tunnel/PlayitAgentProcessManager.cs:23
`PlayitAgentStateMachine` is a singleton (one shared instance) but mutates instance state outside any lock (_state; e.g. `_state` at line 36). — PocketMC.Domain/Models/PlayitAgentStateMachine.cs:25
`PlayitAgentService` is a singleton (one shared instance) but mutates instance state outside any lock (LastErrorMessage, _claimUrlAlreadyFired, _tunnelRunningAlreadyFired, _manualStopRequested, _restartDelayCancellation, _downloadCancellation; e.g. `LastErrorMessage` at line 133). — PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:31
`AgentProvisioningService` is a singleton (one shared instance) but mutates instance state outside any lock (State; e.g. `State` at line 68). — PocketMC.Infrastructure/Tunnel/AgentProvisioningService.cs:17
`RemoteControlCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_lastNotifiedTunnelUrl, _lastNotifiedUrl; e.g. `_lastNotifiedTunnelUrl` at line 76). — PocketMC.RemoteControl/Services/RemoteControlCoordinator.cs:11
`ControlledNavigationStack` is not registered, but the singleton `AppNavigationService` creates it and keeps it in `_detailStack`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_entries, _forwardEntries; e.g. `_entries` at line 65). — PocketMC.Desktop/Navigation/ControlledNavigationStack.cs:52
`WallpaperMicaService` is not registered, but the singleton `ShellVisualService` creates it and keeps it in `_wallpaperMicaService`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_blurredBitmap, _lastWallpaperPath, _lastBlurRadius; e.g. `_blurredBitmap` at line 49). — PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:19
`NewInstancePage` is registered per request (scoped/transient), so each caller expects its own instance — but it keeps mutable `static` state that every instance in the process shares, and mutates it outside any lock (InstanceCreatePageIsOpen, IsDownloadInProgress; e.g. `InstanceCreatePageIsOpen` at line 119). The per-request lifetime buys nothing here: the field outlives every request and concurrent requests race on it. — PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:37
`AddonIconService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_fabricFallback, _quiltFallback, _forgeFallback, _pluginFallback, _bedrockFallback, _bedrockBehaviorFallback; e.g. `_fabricFallback` at line 81). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Desktop/Features/Mods/AddonIconService.cs:15
`SplashWindow` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_instance; e.g. `_instance` at line 34). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Desktop/Features/Shell/SplashWindow.xaml.cs:6
`HardwareRenderingOptimizer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_cachedRefreshRate; e.g. `_cachedRefreshRate` at line 76). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Desktop/Infrastructure/HardwareRenderingOptimizer.cs:14
`SingleInstanceService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_mutex, _cancellationTokenSource; e.g. `_mutex` at line 35). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Desktop/Infrastructure/SingleInstanceService.cs:15
`WindowsToastNotificationService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_isRegistered; e.g. `_isRegistered` at line 48). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Infrastructure/Notifications/WindowsToastNotificationService.cs:9
`DownloaderService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_cloudflaredExpectedSha256IsOverridden, _cloudflaredExpectedSha256Override; e.g. `_cloudflaredExpectedSha256IsOverridden` at line 33). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — PocketMC.Infrastructure/Storage/DownloaderService.cs:16
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Mutable `static` state in a per-request component is shared by the whole process: inject it as a registered singleton (so its sharing is visible and testable) or make it thread-safe.
A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces PocketMC.Infrastructure.Instances ↔ PocketMC.Infrastructure.Instances.Providers ↔ PocketMC.Infrastructure.Java ↔ PocketMC.Infrastructure.Marketplace ↔ PocketMC.Infrastructure.Php depend on each other. The lightest dependency in the cycle is PocketMC.Infrastructure.Java → PocketMC.Infrastructure.Instances (PocketMC.Infrastructure.Java.JavaProvisioningService → PocketMC.Infrastructure.Instances.DownloaderService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — PocketMC.Infrastructure/Java/JavaProvisioningService.cs:15
The namespaces PocketMC.Desktop.Features.Dashboard ↔ PocketMC.Desktop.Features.Tunnel depend on each other. The lightest dependency in the cycle is PocketMC.Desktop.Features.Tunnel → PocketMC.Desktop.Features.Dashboard (PocketMC.Desktop.Features.Tunnel.InstanceTunnelOrchestrator → PocketMC.Desktop.Features.Dashboard.InstanceCardViewModel, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:17
The namespaces PocketMC.Desktop.Features.Console ↔ PocketMC.Desktop.Features.Intelligence depend on each other. The lightest dependency in the cycle is PocketMC.Desktop.Features.Intelligence → PocketMC.Desktop.Features.Console (PocketMC.Desktop.Features.Intelligence.SessionSummarizationService → PocketMC.Desktop.Features.Console.ConsoleLogHistoryService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — PocketMC.Desktop/Features/Intelligence/SessionSummarizationService.cs:9
The namespaces PocketMC.RemoteControl.Hosting ↔ PocketMC.RemoteControl.Services depend on each other. The lightest dependency in the cycle is PocketMC.RemoteControl.Services → PocketMC.RemoteControl.Hosting (PocketMC.RemoteControl.Services.RemoteControlCoordinator → PocketMC.RemoteControl.Hosting.RemoteDashboardHost, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — PocketMC.RemoteControl/Services/RemoteControlCoordinator.cs:3
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Do you agree with this assessment?
C3 · Audit Trail7.5 / 10Strong✓ Tool-verified
Other · Security — Whether changes to sensitive data are recorded (who, what, when) for compliance + incident response.
An audit mechanism is present, but the trail is not yet complete — missing: a write-side hook (the one code path every change to the sensitive data flows through, recording who changed what), [Audited] per-entity coverage.
What to do
Back the audit convention with a structural mechanism: route every sensitive change through one write path that records it to an immutable audit log with the acting user and time, and apply [Audited] to the entities that need a who-changed-what trail.
Do you agree with this assessment?
C4 · Data Retention5.0 / 10Adequate✓ Tool-verified
Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).
Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.
A retention mechanism is present, but the data-lifecycle is not yet complete — missing: an expiry limit — a declared maximum age / TTL after which the data is no longer kept, a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob).
What to do
Complete the data-lifecycle story: an expiry limit (a declared maximum age for the stored data — a retention-age setting, or a store-level TTL where your storage offers one), a scheduled purge/cleanup job that enforces it, and a documented retention period covering the personal data.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — PocketMC.Desktop/Core/Presentation/Converters.cs:54, PocketMC.Desktop/Core/Presentation/Converters.cs:75, PocketMC.Desktop/Features/Marketplace/DependencyConfirmationWindow.xaml.cs:49, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
1 guard above `return LogLevel.Info;` also returns `LogLevel.Info`, so no input can make it matter. Implement the distinction that was intended, or delete the guard. — PocketMC.Desktop/Features/Console/LogLineClassifier.cs:79
The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently. — PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:156
`TriggerServerAutoStarts` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:370
`BuildSimpleVoiceChatPromptMessage` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:490
`OnTimerTick` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:135
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 5 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:7
`Directory.Packages.props` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — Directory.Packages.props:6
What to do
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Do you agree with this assessment?
P5 · DR & Backup4.0 / 10Weak✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
What to do
Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
4 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×4) — PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:454, REDACTED:34, PocketMC.Infrastructure/Power/SleepPreventionService.cs:135, …
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. (×4) — PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114, PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437, PocketMC.Infrastructure/Players/PlayerDataService.cs:81, …
`EntropySalt` is the DPAPI additional entropy and is a compile-time constant, so the secret this operation depends on is published with the source. A key that ships with the source is not secret: every contributor, fork, mirror and released binary carries it, so anyone holding the repository can decrypt what any installation encrypted, and there is no way to invalidate what was already protected because every deployment built from this source shares the value. Where the constant is a password salt the consequence differs but is no smaller — one global salt means precomputation amortises across every installation, which is the property salting exists to destroy. Read the value from configuration, an environment variable or a secrets manager at startup and FAIL FAST when it is absent, so a missing key stops the process instead of silently falling back to a shared default; treat the committed value as disclosed and rotate it rather than only deleting the line. For a salt, generate a fresh random one per password and store it alongside the hash. — PocketMC.Infrastructure/Security/DataProtector.cs:13
`Iterations` fixes PBKDF2-SHA-256 at 100,000 iterations. A key-derivation function's only defence is the cost of ONE guess, and that cost is this number — the algorithm choice does not set it. Current OWASP guidance is 1,300,000 PBKDF2 iterations with HMAC-SHA1, 600,000 with SHA-256 and 210,000 with SHA-512; scrypt at N=2^17, r=8, p=1 (or an equivalent N·r·p product); Argon2id at 19 MiB of memory and 2 iterations (or an equivalent row); bcrypt at a work factor of at least 10. This figure divides the attacker's work by a factor of tens or hundreds against the same stolen hash, on hardware they already own. Where what is derived is short or low-entropy — a PIN, a numeric parental code, a four-character token — the whole keyspace falls in the time this parameter buys, and no salt or constant-time comparison changes that. Raise the count to the current published figure for the PRF you use, measure it on the slowest hardware that must run it (a target of roughly 100 ms per derivation is the usual budget), and read the value from configuration so a deployment can raise it again without a rebuild. Where the derived value must interoperate with a format someone else fixed, the count cannot move — derive a SEPARATE value for anything you own rather than inheriting the external format's price. — PocketMC.RemoteControl/Services/RemoteAuthenticationService.cs:10
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves. — REDACTED:101
No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it. — REDACTED:101
No ModelState/[ApiController]/FluentValidation signal — inbound payloads reach handlers unvalidated. (−2.0 on this card.)
`MapPost("/login")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:246
`MapPost("/logout")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:349
`MapGet("/status")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:357
`MapGet("/instances")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:359
`MapGet("/instances/{instanceId:guid}/status")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:371
`MapPost("/instances/{instanceId:guid}/start")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:382
`MapPost("/instances/{instanceId:guid}/stop")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:394
`MapPost("/instances/{instanceId:guid}/restart")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:406
`MapGet("/instances/{instanceId:guid}/console/history")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:418
`MapPost("/instances/{instanceId:guid}/console/command")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:431
`MapGet("/instances/{instanceId:guid}/players")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:462
`MapPost($"/instances/{{instanceId:guid}}/players/{{name}}/{action}")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:482
`MapGet("/instances/{instanceId:guid}/properties")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:495
`MapPut("/instances/{instanceId:guid}/properties")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:533
`MapGet("/instances/{instanceId:guid}/addons")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:573
`MapPost("/instances/{instanceId:guid}/addons/uninstall")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:590
`MapGet("/instances/{instanceId:guid}/files")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:637
`MapGet("/instances/{instanceId:guid}/files/content")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:703
`MapPut("/instances/{instanceId:guid}/files/content")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:757
`MapDelete("/instances/{instanceId:guid}/files")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:779
`MapPost("/instances/{instanceId:guid}/files/upload")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:813
`MapGet("/instances/{instanceId:guid}/backups")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:871
`MapPost("/instances/{instanceId:guid}/backups")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard. — REDACTED:951
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114` (SHA1), `PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437` (SHA1), `PocketMC.Infrastructure/Players/PlayerDataService.cs:81` (MD5), `PocketMC.Infrastructure/Storage/DownloaderService.cs:184` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Load cryptographic key and salt material from configuration, an environment variable or a secrets manager rather than fixing it in the source, and fail fast at startup when it is absent — a default that silently works is the one that reaches production. Rotate anything already committed: it must be treated as disclosed. Salts should be generated per password and stored with the hash, never shared across installations.
Raise the cost parameter to current guidance — PBKDF2 at 1,300,000 (HMAC-SHA1), 600,000 (SHA-256) or 210,000 (SHA-512) iterations; scrypt at N=2^17, r=8, p=1; bcrypt at a work factor of 10 or more — or move to a memory-hard KDF (Argon2id, scrypt) where the platform offers one. Read the parameter from configuration and tune it to roughly 100 ms per derivation on the slowest hardware that must run it, so the price can be raised again without shipping new code.
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
Enforce HTTPS at the app layer (UseHttpsRedirection / UseHsts) — only skip this if a reverse proxy demonstrably terminates TLS.
Validate inbound models (ModelState/[ApiController]/FluentValidation) to reduce injection and bad-data risk.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
`async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. (×40) — PocketMC.Desktop/App.xaml.cs:55, PocketMC.Desktop/App.xaml.cs:170, PocketMC.Desktop/Core/Mvvm/AsyncRelayCommand.cs:30, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`client` is a `HttpClient`, which implements `IDisposable`, and it is created here (line 136). Every use of it in `ConnectAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var client = …;`), which releases it at the end of the scope on every path including a throw. — PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:136
`ServerProcess` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_startupCts` itself (line 43), which makes that instance its own. But `_startupCts` is named in none of the methods the disposal search covered: `Dispose` (line 641), `Kill` (line 342), `CloseSessionLog` (line 608) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_startupCts?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — PocketMC.Infrastructure/Instances/ServerProcess.cs:43
`NewsService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_syncGate` itself (line 47), which makes that instance its own. But `_syncGate` is named in none of the methods the disposal search covered: `Dispose` (line 711), `Dispose` (line 720), `Stop` (line 155), `Dispose` (line 711), `Dispose` (line 720) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_syncGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — PocketMC.Infrastructure/News/NewsService.cs:47
`_client` is a `DiscordRpcClient` this type creates itself, and here (line 73) a new instance is written over it — but `Initialize` itself reads through `_client` before replacing it, so it expects an instance to be there, and nothing earlier in `Initialize` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_client?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back. — PocketMC.Infrastructure/Social/DiscordRpcService.cs:73
`PlayitAgentService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_restartDelayCancellation` itself (line 68), which makes that instance its own. But `_restartDelayCancellation` is named in none of the methods the disposal search covered: `Dispose` (line 1063), `UnsubscribeSystemEvents` (line 987) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_restartDelayCancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:68
`PlayitAgentService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_runtimeCheckGate` itself (line 72), which makes that instance its own. But `_runtimeCheckGate` is named in none of the methods the disposal search covered: `Dispose` (line 1063), `UnsubscribeSystemEvents` (line 987) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_runtimeCheckGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:72
`_downloadCancellation` is a `CancellationTokenSource` this type creates itself, and here (line 620) a new instance is written over it — but `DownloadAgentAsync` itself reads through `_downloadCancellation` before replacing it, so it expects an instance to be there, and nothing earlier in `DownloadAgentAsync` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_downloadCancellation?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back. — PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:620
`CloudflaredQuickTunnelProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_startLock` itself (line 31), which makes that instance its own. But `_startLock` is named in none of the methods the disposal search covered: `Dispose` (line 291), `StopAsync` (line 205) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_startLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — PocketMC.RemoteControl/Tunnels/CloudflaredQuickTunnelProvider.cs:31
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 210/480 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×39) — PocketMC.Desktop/Core/Mvvm/AsyncRelayCommand.cs:30, PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:836, PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1026, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped6.1 / 10Adequate✓ Tool-verified
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
`playerCount` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — PocketMC.RemoteControl/Web/app.js:425
What to do
Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×38) — PocketMC.Desktop/App.xaml.cs:82, PocketMC.Desktop/App.xaml.cs:185, PocketMC.Desktop/App.xaml.cs:201, …
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — PocketMC.Desktop/Features/Settings/CloudBackupSettingsViewModel.cs:76
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:372
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~0.3 `!` suppressions per 1k syntax nodes — 61 suppression(s) across the 208261 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
What to do
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 5 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 40 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X6 Hand-rolled structured-format parsing — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 40 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X9 Subsumed condition operand — 12 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 33 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D27 Navigability — symbol resolution incomplete — navigability not assessed
D30 Dependency Vulnerabilities — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 1 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage not measured
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 3 value object(s); a Domain/Aggregates/ValueObjects layer
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P10 Library API & versioning — Library API & versioning could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
P11 BDD / executable specs — BDD / executable specs could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
P7 Outbound HTTP resilience — Outbound HTTP resilience could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
P8 Schema migrations — Schema migrations could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X4 Structured logging — Structured logging could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:82— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:185— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:201— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:402— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:417— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/App.xaml.cs:437— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:580— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:581— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:790— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:800— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:953— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:215— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:229— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Instances/RuntimeDownloadDialog.xaml.cs:28— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Intelligence/NativeMarkdownViewer.xaml.cs:60— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:267— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:74— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:29— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:46— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:75— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:224— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:376— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:387— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:421— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock PocketMC.Desktop/Features/Mods/ModpackService.cs:288— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
WriteOnlyPrivateField PocketMC.Application/Services/Instances/InstanceManager.cs:24— private ApplicationState _applicationState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.RemoteControl/Services/RemotePlayerActionService.cs:15— private ApplicationState _applicationState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.RemoteControl/Tunnels/CloudflaredQuickTunnelProvider.cs:20— private ApplicationState _applicationState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:19— private HashSet<string> AllowedRootDirectories — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:31— private HashSet<string> BlockedRootDirectories — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:41— private HashSet<string> BlockedFileNames — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:58— private HashSet<string> BlockedExtensions — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:68— private HashSet<string> AllowedModsExtensions — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Application/Services/Mods/ModpackOverridePolicy.cs:73— private HashSet<string> AllowedScriptsExtensions — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:52— private ServerConfigurationService _configService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:47— private ServerRuntimeSettingApplier _runtimeApplier — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:47— private ModpackService _modpackService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:25— private IAppDispatcher _dispatcher — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Settings/SettingsWorldVM.cs:28— private IAppDispatcher _dispatcher — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Settings/SettingsVersionUpdatesVM.cs:21— private JavaProvisioningService _javaProvisioningService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:34— private IResourceMonitorService _resourceMonitorService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:41— private AppStartupOptions _startupOptions — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Features/Shell/ShellViewModel.cs:69— private ApplicationState _appState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Desktop/Infrastructure/UpdateService.cs:50— private ApplicationState _appState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Instances/Providers/VanillaProvider.cs:24— private ApplicationState _appState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Tunnel/AgentProvisioningService.cs:20— private ApplicationState _appState — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:29— private TimeSpan RegexTimeout — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Instances/Updates/InstanceUpdateApplier.cs:38— private ILogger<InstanceUpdateApplier> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Instances/Updates/InstanceUpdateService.cs:15— private ILogger<InstanceUpdateService> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:28— private IHttpClientFactory _httpClientFactory — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Captive dependency: singleton ForgeInstaller captures transient VanillaProvider PocketMC.Infrastructure/Instances/ForgeInstaller.cs:16— `ForgeInstaller` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton PocketMineLaunchConfigurator captures transient PhpProvisioningService PocketMC.Infrastructure/Instances/PocketMineLaunchConfigurator.cs:25— `PocketMineLaunchConfigurator` is registered as a SINGLETON but its constructor takes `PhpProvisioningService phpProvisioning`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PhpProvisioningService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ServerLaunchConfigurator captures transient PhpProvisioningService PocketMC.Infrastructure/Instances/ServerLaunchConfigurator.cs:47— `ServerLaunchConfigurator` is registered as a SINGLETON but its constructor takes `PhpProvisioningService phpProvisioning`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PhpProvisioningService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ServerLaunchConfigurator captures transient VanillaProvider PocketMC.Infrastructure/Instances/ServerLaunchConfigurator.cs:48— `ServerLaunchConfigurator` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton GeyserProvisioningService captures transient ModrinthService REDACTED:20— `GeyserProvisioningService` is registered as a SINGLETON but its constructor takes `ModrinthService modrinth`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ModrinthService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ModpackService captures transient FabricProvider PocketMC.Desktop/Features/Mods/ModpackService.cs:70— `ModpackService` is registered as a SINGLETON but its constructor takes `FabricProvider fabricProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `FabricProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ModpackService captures transient ForgeProvider PocketMC.Desktop/Features/Mods/ModpackService.cs:71— `ModpackService` is registered as a SINGLETON but its constructor takes `ForgeProvider forgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ModpackService captures transient NeoForgeProvider PocketMC.Desktop/Features/Mods/ModpackService.cs:72— `ModpackService` is registered as a SINGLETON but its constructor takes `NeoForgeProvider neoForgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `NeoForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton AddonUpdateService captures transient ModrinthService PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:52— `AddonUpdateService` is registered as a SINGLETON but its constructor takes `ModrinthService modrinth`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ModrinthService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton AddonUpdateService captures transient CurseForgeService PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:53— `AddonUpdateService` is registered as a SINGLETON but its constructor takes `CurseForgeService curseForge`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `CurseForgeService` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient VanillaProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:23— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `VanillaProvider vanillaProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `VanillaProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient FabricProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:24— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `FabricProvider fabricProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `FabricProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient ForgeProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:25— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `ForgeProvider forgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient NeoForgeProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:26— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `NeoForgeProvider neoForgeProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `NeoForgeProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient PaperProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:27— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `PaperProvider paperProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PaperProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient PocketmineProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:28— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `PocketmineProvider pocketmineProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PocketmineProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton InstanceArtifactStager captures transient BedrockBdsProvider PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:29— `InstanceArtifactStager` is registered as a SINGLETON but its constructor takes `BedrockBdsProvider bedrockProvider`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `BedrockBdsProvider` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton PlayitAgentService captures transient PlayitPartnerProvisioningClient PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:104— `PlayitAgentService` is registered as a SINGLETON but its constructor takes `PlayitPartnerProvisioningClient partnerProvisioningClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `PlayitPartnerProvisioningClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
AC4 · Keyboard semantics· Clickable element isn't keyboard-operable · ×6
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1468— The repo's own CSS styles .file-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1725— The repo's own CSS styles .file-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1834— The repo's own CSS styles .backup-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1862— The repo's own CSS styles .backup-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1892— The repo's own CSS styles .backup-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable PocketMC.RemoteControl/Web/app.js:1931— The repo's own CSS styles .backup-row with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Namespace dependency cycle PocketMC.Infrastructure/Java/JavaProvisioningService.cs:15— The namespaces PocketMC.Infrastructure.Instances ↔ PocketMC.Infrastructure.Instances.Providers ↔ PocketMC.Infrastructure.Java ↔ PocketMC.Infrastructure.Marketplace ↔ PocketMC.Infrastructure.Php depend on each other. The lightest dependency in the cycle is PocketMC.Infrastructure.Java → PocketMC.Infrastructure.Instances (PocketMC.Infrastructure.Java.JavaProvisioningService → PocketMC.Infrastructure.Instances.DownloaderService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:17— The namespaces PocketMC.Desktop.Features.Dashboard ↔ PocketMC.Desktop.Features.Tunnel depend on each other. The lightest dependency in the cycle is PocketMC.Desktop.Features.Tunnel → PocketMC.Desktop.Features.Dashboard (PocketMC.Desktop.Features.Tunnel.InstanceTunnelOrchestrator → PocketMC.Desktop.Features.Dashboard.InstanceCardViewModel, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle PocketMC.Desktop/Features/Intelligence/SessionSummarizationService.cs:9— The namespaces PocketMC.Desktop.Features.Console ↔ PocketMC.Desktop.Features.Intelligence depend on each other. The lightest dependency in the cycle is PocketMC.Desktop.Features.Intelligence → PocketMC.Desktop.Features.Console (PocketMC.Desktop.Features.Intelligence.SessionSummarizationService → PocketMC.Desktop.Features.Console.ConsoleLogHistoryService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle PocketMC.RemoteControl/Services/RemoteControlCoordinator.cs:3— The namespaces PocketMC.RemoteControl.Hosting ↔ PocketMC.RemoteControl.Services depend on each other. The lightest dependency in the cycle is PocketMC.RemoteControl.Services → PocketMC.RemoteControl.Hosting (PocketMC.RemoteControl.Services.RemoteControlCoordinator → PocketMC.RemoteControl.Hosting.RemoteDashboardHost, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
NoWarnInCsproj PocketMC.Desktop/PocketMC.Desktop.csproj:9— CS0105 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj PocketMC.Desktop.Tests/PocketMC.Desktop.Tests.csproj:6— CS0105 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:6— NU1701 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
AC4 · Keyboard semantics· Click handler on a non-interactive <div> · ×2
Click handler on a non-interactive <div> PocketMC.RemoteControl/Web/app.js:392— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> PocketMC.RemoteControl/Web/app.js:1565— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC4 · Keyboard semantics· Click handler on a non-interactive <span> · ×2
Click handler on a non-interactive <span> PocketMC.RemoteControl/Web/app.js:1512— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <span> PocketMC.RemoteControl/Web/app.js:1529— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Viewport restricts zoom PocketMC.RemoteControl/Web/index.html:5— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
S1 · Web-Security Posture· Cryptographic key material is a compile-time constant · ×1
Cryptographic key material is a compile-time constant PocketMC.Infrastructure/Security/DataProtector.cs:13— `EntropySalt` is the DPAPI additional entropy and is a compile-time constant, so the secret this operation depends on is published with the source. A key that ships with the source is not secret: every contributor, fork, mirror and released binary carries it, so anyone holding the repository can decrypt what any installation encrypted, and there is no way to invalidate what was already protected because every deployment built from this source shares the value. Where the constant is a password salt the consequence differs but is no smaller — one global salt means precomputation amortises across every installation, which is the property salting exists to destroy. Read the value from configuration, an environment variable or a secrets manager at startup and FAIL FAST when it is absent, so a missing key stops the process instead of silently falling back to a shared default; treat the committed value as disclosed and rotate it rather than only deleting the line. For a salt, generate a fresh random one per password and store it alongside the hash.
async void method: OnStartup PocketMC.Desktop/App.xaml.cs:55— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnExit PocketMC.Desktop/App.xaml.cs:170— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Execute PocketMC.Desktop/Core/Mvvm/AsyncRelayCommand.cs:30— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnSend_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:592— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: TxtCommand_KeyDown PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:665— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyLogs_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:744— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyCrash_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:755— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCrashAiAnalyze_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:763— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnStop_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:822— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnRestart_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:836— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnAiSummary_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1009— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnOptimize_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1162— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: CopyCrashReport PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:340— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:88— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyLanIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:97— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyNumericIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:106— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyBedrockNumericIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:115— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCopyBedrockIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:149— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnLoaded PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:123— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: CmbServerType_SelectionChanged PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:204— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ChkShowSnapshots_Changed PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:233— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: CmbVersion_SelectionChanged PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:243— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnImportModpack_Click PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:443— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnCreate_Click PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:484— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BtnAnalyzeWithAi_Click PocketMC.Desktop/Features/Instances/Dialogs/ServerCrashDialogWindow.xaml.cs:126— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
+ 15 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×39
Async method without CancellationToken: Execute PocketMC.Desktop/Core/Mvvm/AsyncRelayCommand.cs:30— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnRestart_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:836— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PerformAIAnalysisAsync PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1026— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnOptimize_Click PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1162— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: StartServer PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:85— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RestartServer PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:265— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteInstanceAsync PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:315— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: HandlePortReliabilityFailureAsync PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:447— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: LoadInstancesAsync PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs:51— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ShowCopiedFeedback PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:130— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnCopyBedrockIp_Click PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:149— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnCreate_Click PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:484— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CleanupFailedInstanceAsync PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:803— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnAnalyzeWithAi_Click PocketMC.Desktop/Features/Instances/Dialogs/ServerCrashDialogWindow.xaml.cs:126— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnCopyLogs_Click PocketMC.Desktop/Features/Instances/Dialogs/ServerCrashDialogWindow.xaml.cs:253— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExportAsync PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportViewModel.cs:146— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ImportAsync PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportViewModel.cs:253— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: StartAsync PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:83— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: HandleServerCrashAsync PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:361— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: LoadInstalledModelsAsync PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:84— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteModelButton_Click PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:140— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PullModelAsync PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:186— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FluentWindow_ContentRendered PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:48— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: TxtSearch_TextChanged PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:230— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BtnInstall_Click PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:279— No CancellationToken parameter — this work can't be stopped early once started.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:82— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:185— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:201— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:402— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:417— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/App.xaml.cs:437— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:580— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:581— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:790— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:800— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:953— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:215— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:229— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Instances/RuntimeDownloadDialog.xaml.cs:28— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Intelligence/NativeMarkdownViewer.xaml.cs:60— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:267— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:74— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:29— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:46— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:75— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:224— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:376— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:387— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:421— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) PocketMC.Desktop/Features/Mods/ModpackService.cs:288— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Hotspot: REDACTED REDACTED:222— REDACTED changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 157 in RemoteDashboardHost.MapEndpoints at line 222. 8 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.RemoteControl/Web/app.js PocketMC.RemoteControl/Web/app.js:461— PocketMC.RemoteControl/Web/app.js changed 20 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 62 in app.renderStatus at line 461. 12 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.RemoteControl/Web/app.js`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Configuration/AppConfig.cs PocketMC.Infrastructure/Configuration/AppConfig.cs:185— PocketMC.Infrastructure/Configuration/AppConfig.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 74 in AppConfig.ParseYamlContent at line 185. 1 of those changes was a fix/bug commit, and the other 8 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Configuration/AppConfig.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:797— PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 42 in MainWindow.OnKeyDown at line 797. 4 of those changes were fix/bug commits, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1989— PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs changed 17 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in AppSettingsPage.ChangeRootDirectory_Click at line 1989. 4 of those changes were fix/bug commits, and the other 13 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1295— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 45 in SettingsAddonsVM.AddModAsync at line 1295. 2 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Configuration/SettingsManager.cs PocketMC.Infrastructure/Configuration/SettingsManager.cs:351— PocketMC.Infrastructure/Configuration/SettingsManager.cs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in SettingsManager.Normalize at line 351. 3 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Configuration/SettingsManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:181— PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in TunnelPage.RefreshStatusAsync at line 181. 2 of those changes were fix/bug commits, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Instances/ServerProcess.cs PocketMC.Infrastructure/Instances/ServerProcess.cs:389— PocketMC.Infrastructure/Instances/ServerProcess.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in ServerProcess.AppendOutput at line 389. 4 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Instances/ServerProcess.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Php/PhpProvisioningService.cs PocketMC.Infrastructure/Php/PhpProvisioningService.cs:229— PocketMC.Infrastructure/Php/PhpProvisioningService.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in PhpProvisioningService.ProvisionInternalAsync at line 229. 3 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Php/PhpProvisioningService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/News/NewsService.cs PocketMC.Infrastructure/News/NewsService.cs:173— PocketMC.Infrastructure/News/NewsService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 47 in NewsService.SynchronizeCoreAsync at line 173. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/News/NewsService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:313— PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in ServerRebootSchedulerService.ExecuteScheduledRebootAsync at line 313. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Configuration/SettingsBackupService.cs PocketMC.Infrastructure/Configuration/SettingsBackupService.cs:236— PocketMC.Infrastructure/Configuration/SettingsBackupService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in SettingsBackupService.RestoreFromPackage at line 236. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Configuration/SettingsBackupService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:127— PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in DependencyResolverService.ResolveRecursiveAsync at line 127. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:435— PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in JavaSetupPage.ScanRuntimes at line 435. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Mods/AddonInventoryService.cs PocketMC.Infrastructure/Mods/AddonInventoryService.cs:112— PocketMC.Infrastructure/Mods/AddonInventoryService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in AddonInventoryService.BuildItem at line 112. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Mods/AddonInventoryService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Infrastructure/Mods/JavaModMetadataService.cs PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:73— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in JavaModMetadataService.ScanJarInternal at line 73. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Mods/JavaModMetadataService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:464— PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in PluginBrowserPage.BtnInstall_Click at line 464. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs:21— PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in RemoteConsoleWebSocketHandler.HandleAsync at line 21. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs:51— PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in DashboardInstanceListViewModel.LoadInstancesAsync at line 51. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.RemoteControl/Services/RemoteStatusService.cs PocketMC.RemoteControl/Services/RemoteStatusService.cs:65— PocketMC.RemoteControl/Services/RemoteStatusService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in RemoteStatusService.GetInstanceStatusAsync at line 65. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.RemoteControl/Services/RemoteStatusService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: PocketMC.Desktop/Features/Shell/ShellVisualService.cs PocketMC.Desktop/Features/Shell/ShellVisualService.cs:49— PocketMC.Desktop/Features/Shell/ShellVisualService.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in ShellVisualService.RequestMicaUpdate at line 49. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Shell/ShellVisualService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Stateful singleton: ResourceMonitorService PocketMC.Infrastructure/Monitoring/ResourceMonitorService.cs:20— `ResourceMonitorService` is a singleton (one shared instance) but mutates instance state outside any lock (_listCommandTick; e.g. `_listCommandTick` at line 87).
Stateful singleton: InstanceExportService PocketMC.Infrastructure/Instances/InstanceExportService.cs:16— `InstanceExportService` is a singleton (one shared instance) but mutates instance state outside any lock (_activeCts; e.g. `_activeCts` at line 61).
Stateful singleton: InstanceImportService PocketMC.Infrastructure/Instances/InstanceImportService.cs:21— `InstanceImportService` is a singleton (one shared instance) but mutates instance state outside any lock (_activeCts; e.g. `_activeCts` at line 198).
Stateful singleton: OneDriveBackupProvider PocketMC.Infrastructure/Backups/Providers/OneDriveBackupProvider.cs:21— `OneDriveBackupProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_pca; e.g. `_pca` at line 44).
Stateful singleton: DependencyHealthMonitor PocketMC.Infrastructure/Diagnostics/DependencyHealthMonitor.cs:13— `DependencyHealthMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_cts; e.g. `_cts` at line 30).
Stateful singleton: AppNavigationService PocketMC.Desktop/Infrastructure/AppNavigationService.cs:29— `AppNavigationService` is a singleton (one shared instance) but mutates instance state outside any lock (_shellHost, _shellBackStack, _shellForwardStack, _currentShellPageType, _detailPages, _forwardDetailPages; e.g. `_shellHost` at line 57).
Stateful singleton: TelemetryService PocketMC.Infrastructure/Telemetry/TelemetryService.cs:20— `TelemetryService` is a singleton (one shared instance) but mutates instance state outside any lock (_backgroundTask, _cachedCountry, _hasFetchedCountry; e.g. `_backgroundTask` at line 65).
Stateful singleton: ApplicationState PocketMC.Application/Services/Shell/ApplicationState.cs:6— `ApplicationState` is a singleton (one shared instance) but mutates instance state outside any lock (Settings; e.g. `Settings` at line 107).
Stateful singleton: UpdateService PocketMC.Desktop/Infrastructure/UpdateService.cs:34— `UpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (CurrentStage, _disposed; e.g. `CurrentStage` at line 189).
Stateful singleton: NewsService PocketMC.Infrastructure/News/NewsService.cs:27— `NewsService` is a singleton (one shared instance) but mutates instance state outside any lock (_lifetime; e.g. `_lifetime` at line 151).
Stateful singleton: ShellUIStateService PocketMC.Desktop/Features/Shell/ShellUIStateService.cs:8— `ShellUIStateService` is a singleton (one shared instance) but mutates instance state outside any lock (_breadcrumbCurrentText, _isBreadcrumbVisible, _titleBarTitle, _titleBarStatusText, _titleBarStatusBrush, _isTitleBarContextVisible; e.g. `_breadcrumbCurrentText` at line 14).
Stateful singleton: AccentColorService PocketMC.Desktop/Features/Shell/AccentColorService.cs:14— `AccentColorService` is a singleton (one shared instance) but mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 186).
Stateful singleton: ShellVisualService PocketMC.Desktop/Features/Shell/ShellVisualService.cs:14— `ShellVisualService` is a singleton (one shared instance) but mutates instance state outside any lock (_boundWindow, _isWindowActive; e.g. `_boundWindow` at line 44).
Stateful singleton: ShellStartupCoordinator PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:25— `ShellStartupCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_host, _isDisposed, _startupServicesStarted, _playitStartupAttempted; e.g. `_host` at line 86).
Stateful singleton: ShellViewModel PocketMC.Desktop/Features/Shell/ShellViewModel.cs:23— `ShellViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_updateStatusMessage, _isUpdateBannerVisible, _isUpdateDownloading, _updateDownloadPercent, _updateErrorMessage, _isSilentCheck; e.g. `_updateStatusMessage` at line 32).
Stateful singleton: TrayIconViewModel PocketMC.Desktop/Features/Shell/TrayIconViewModel.cs:11— `TrayIconViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_tooltipText, _iconVisibility; e.g. `_tooltipText` at line 26).
Stateful singleton: PlayitAgentProcessManager PocketMC.Infrastructure/Tunnel/PlayitAgentProcessManager.cs:23— `PlayitAgentProcessManager` is a singleton (one shared instance) but mutates instance state outside any lock (_logWriter, _process; e.g. `_logWriter` at line 54).
Stateful singleton: PlayitAgentStateMachine PocketMC.Domain/Models/PlayitAgentStateMachine.cs:25— `PlayitAgentStateMachine` is a singleton (one shared instance) but mutates instance state outside any lock (_state; e.g. `_state` at line 36).
Stateful singleton: PlayitAgentService PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:31— `PlayitAgentService` is a singleton (one shared instance) but mutates instance state outside any lock (LastErrorMessage, _claimUrlAlreadyFired, _tunnelRunningAlreadyFired, _manualStopRequested, _restartDelayCancellation, _downloadCancellation; e.g. `LastErrorMessage` at line 133).
Stateful singleton: AgentProvisioningService PocketMC.Infrastructure/Tunnel/AgentProvisioningService.cs:17— `AgentProvisioningService` is a singleton (one shared instance) but mutates instance state outside any lock (State; e.g. `State` at line 68).
Stateful singleton: RemoteControlCoordinator PocketMC.RemoteControl/Services/RemoteControlCoordinator.cs:11— `RemoteControlCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_lastNotifiedTunnelUrl, _lastNotifiedUrl; e.g. `_lastNotifiedTunnelUrl` at line 76).
FileTooLong: Settings/SettingsAddonsVM.cs PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs— FileTooLong — 1599 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1099 over it, 3.20× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Web/app.js PocketMC.RemoteControl/Web/app.js— FileTooLong — 1392 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 500 significant lines; this is 892 over it, 2.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Setup/AppSettingsPage.xaml.cs PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs— FileTooLong — 1391 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 891 over it, 2.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Instances/InstanceImportService.cs PocketMC.Infrastructure/Instances/InstanceImportService.cs— FileTooLong — 1018 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 518 over it, 2.04× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Players/PlayerManagementViewModel.cs PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs— FileTooLong — 844 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 344 over it, 1.69× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Console/ServerConsolePage.xaml.cs PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs— FileTooLong — 703 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 203 over it, 1.41× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 703 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 203 over it, 1.41× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Shell/MainWindow.xaml.cs PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs— FileTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 165 over it, 1.33× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Tunnel/PlayitApiClient.cs PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs— FileTooLong — 660 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 160 over it, 1.32× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Tunnel/TunnelPage.xaml.cs PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs— FileTooLong — 648 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 148 over it, 1.30× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Tunnel/PlayitAgentService.cs PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs— FileTooLong — 645 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 145 over it, 1.29× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Setup/JavaSetupPage.xaml.cs PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs— FileTooLong — 621 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 121 over it, 1.24× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 591 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 91 over it, 1.18× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Networking/PortPreflightService.cs PocketMC.Infrastructure/Networking/PortPreflightService.cs— FileTooLong — 574 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 74 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: InstanceCreation/NewInstancePage.xaml.cs PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs— FileTooLong — 559 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 59 over it, 1.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Mods/BedrockAddonInstaller.cs PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs— FileTooLong — 554 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 54 over it, 1.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Mods/JavaModMetadataService.cs PocketMC.Infrastructure/Mods/JavaModMetadataService.cs— FileTooLong — 540 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 40 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Test cannot fail: ScrollViewerHelper_EnableMouseWheelScrolling_AttachesAndDetachesCleanly PocketMC.Desktop.Tests/Infrastructure/HardwareRenderingOptimizerTests.cs:69— This test's act runs inside `RunInSta` at line 23 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. Adding an assertion inside that region does not fix it: the assertion throws, and the same catch swallows it exactly like the exception it replaced. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: ScrollViewerHelper_ScrollByWheelDelta_DirectControl_HandlesDeltaWithoutGlitch PocketMC.Desktop.Tests/Infrastructure/HardwareRenderingOptimizerTests.cs:84— This test's act runs inside `RunInSta` at line 23 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. Adding an assertion inside that region does not fix it: the assertion throws, and the same catch swallows it exactly like the exception it replaced. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: Measure_WithZeroWidth_ReturnsZeroSize PocketMC.Desktop.Tests/Core/Presentation/AdaptiveGridPanelTests.cs:12— This test's act runs inside `RunInSta` at line 126 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 3 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: Measure_WithMultipleChildren_CalculatesColumnsAndHeight PocketMC.Desktop.Tests/Core/Presentation/AdaptiveGridPanelTests.cs:31— This test's act runs inside `RunInSta` at line 126 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 3 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: Measure_WithNarrowWidth_CalculatesSingleColumn PocketMC.Desktop.Tests/Core/Presentation/AdaptiveGridPanelTests.cs:59— This test's act runs inside `RunInSta` at line 126 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 3 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: Arrange_PositionsItemsInGridColumns PocketMC.Desktop.Tests/Core/Presentation/AdaptiveGridPanelTests.cs:85— This test's act runs inside `RunInSta` at line 126 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 3 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: NativeMarkdownRenderer_RendersEmojiShortcodes PocketMC.Desktop.Tests/Features/Intelligence/MarkdownRenderingTests.cs:12— This test's act runs inside `RunOnSta` at line 293 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 7 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: NativeMarkdownRenderer_UsesEmojiWpfForUnicodeEmojiGlyphs PocketMC.Desktop.Tests/Features/Intelligence/MarkdownRenderingTests.cs:32— This test's act runs inside `RunOnSta` at line 293 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 4 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: NativeMarkdownRenderer_UsesEmojiWpfInsideBoldHeadings PocketMC.Desktop.Tests/Features/Intelligence/MarkdownRenderingTests.cs:49— This test's act runs inside `RunOnSta` at line 293 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 4 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: NativeMarkdownRenderer_UsesInlineTextBlocksForEmojiGlyphs PocketMC.Desktop.Tests/Features/Intelligence/MarkdownRenderingTests.cs:65— This test's act runs inside `RunOnSta` at line 293 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 6 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: NativeMarkdownRenderer_UsesEmojiWpfTextBlocksForEmojiGlyphs PocketMC.Desktop.Tests/Features/Intelligence/MarkdownRenderingTests.cs:83— This test's act runs inside `RunOnSta` at line 293 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 4 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: Build_ShowcaseRendersEverySupportedElementAsNativeWpfControls PocketMC.Desktop.Tests/Features/News/NewsContentRendererTests.cs:14— This test's act runs inside `RunInSta` at line 109 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 28 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: OptimizeWindow_ConfiguresHighPerformanceVisualSettings PocketMC.Desktop.Tests/Infrastructure/HardwareRenderingOptimizerTests.cs:52— This test's act runs inside `RunInSta` at line 23 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 7 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
Test cannot fail: ReturningToDashboard_FromAppSettings_ResumesActiveDetailPage PocketMC.Desktop.Tests/Navigation/AppNavigationServiceResumptionTests.cs:20— This test's act runs inside `RunInSta` at line 72 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 6 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×13
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:274— `.panel` moves (`animation: fade-in 0.25s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:485— `.btn-spinner` moves (`animation: btn-spin 0.8s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:594— `.metric-progress-bar` moves (`transition: width 0.4s cubic-bezier(0.16, 1, 0.3, 1)`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:712— `.snackbar` moves (`animation: snackbar-fade-in 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:716— `.snackbar.fade-out` moves (`animation: snackbar-fade-out 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:1067— `.instance-status-pill.busy .status-dot` moves (`animation: pulse-dot 1.5s infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:1322— `.modal-content` moves (`animation: modal-slide-up 0.2s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:1449— `.offline-host-panel` moves (`animation: fade-in 0.25s cubic-bezier(0.16, 1, 0.3, 1) forwards`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:1496— `.offline-pulse-ring` moves (`animation: offline-pulse 2.5s infinite ease-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:1726— `.welcome-btn-arrow` moves (`transition: transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:2274— `.skeleton-box` moves (`animation: skeleton-shimmer 1.5s infinite ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:2623— `.file-row.skeleton-upload-row::after` moves (`animation: skeleton-shimmer 1.4s infinite ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard PocketMC.RemoteControl/Web/styles.css:2669— `.skeleton-spinner` moves (`animation: spin 0.8s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
TooManyMethods: AppSettingsPage PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs— TooManyMethods — 1346 significant lines (blank, comment-only and punctuation-only lines excluded), 80 methods. The bar is 30 methods; this is 50 over it, 2.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SettingsAddonsVM PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs— TooManyMethods — 1407 significant lines (blank, comment-only and punctuation-only lines excluded), 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MainWindow PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs— TooManyMethods — 601 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: InstanceImportService PocketMC.Infrastructure/Instances/InstanceImportService.cs— TooManyMethods — 1002 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ServerConsolePage PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs— TooManyMethods — 659 significant lines (blank, comment-only and punctuation-only lines excluded), 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TunnelPage PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs— TooManyMethods — 621 significant lines (blank, comment-only and punctuation-only lines excluded), 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PlayitAgentService PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs— TooManyMethods — 625 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PlayerManagementViewModel PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs— TooManyMethods — 798 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PlayitApiClient PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs— TooManyMethods — 475 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PortPreflightService PocketMC.Infrastructure/Networking/PortPreflightService.cs— TooManyMethods — 540 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NewsService PocketMC.Infrastructure/News/NewsService.cs— TooManyMethods — 425 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NewInstancePage PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs— TooManyMethods — 526 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BedrockAddonInstaller PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs— TooManyMethods — 530 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
MethodTooLong: RemoteDashboardHost.MapEndpoints REDACTED:222— MethodTooLong — MapEndpoints runs 429 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 329 over it, 4.29× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: NewsService.SynchronizeCoreAsync PocketMC.Infrastructure/News/NewsService.cs:173— MethodTooLong — SynchronizeCoreAsync runs 166 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 66 over it, 1.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ModpackService.ExecuteImportAsync PocketMC.Desktop/Features/Mods/ModpackService.cs:98— MethodTooLong — ExecuteImportAsync runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AppConfig.ParseYamlContent PocketMC.Infrastructure/Configuration/AppConfig.cs:185— MethodTooLong — ParseYamlContent runs 147 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 47 over it, 1.47× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PortsMapPage.RefreshMapAsync PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:280— MethodTooLong — RefreshMapAsync runs 143 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 43 over it, 1.43× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: NewInstancePage.BtnCreate_Click PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:484— MethodTooLong — BtnCreate_Click runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: InstanceImportService.ImportLocalFolderAsync PocketMC.Infrastructure/Instances/InstanceImportService.cs:1359— MethodTooLong — ImportLocalFolderAsync runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: JavaModMetadataService.ParseForgeMetadata PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:483— MethodTooLong — ParseForgeMetadata runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DependencyResolverService.ResolveRecursiveAsync PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:127— MethodTooLong — ResolveRecursiveAsync runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PortRecoveryService.Recommend PocketMC.Infrastructure/Networking/PortRecoveryService.cs:73— MethodTooLong — Recommend runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TunnelPage.RefreshStatusAsync PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:181— MethodTooLong — RefreshStatusAsync runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ServerCrashDetector.AnalyzeLogSignatures PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:214— MethodTooLong — AnalyzeLogSignatures runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:391— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:391-400 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:404-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) REDACTED:575— REDACTED:575-584 | REDACTED:592-601 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/Mods/ModpackService.cs:161— PocketMC.Desktop/Features/Mods/ModpackService.cs:161-170 | PocketMC.Desktop/Features/Mods/ModpackService.cs:318-327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Mods/ModpackService.cs:161` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:61— PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:61-71 | PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:128-137 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:120— PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:120-129 | PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:130-139 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) PocketMC.Infrastructure/Marketplace/MarketplaceFileInstaller.cs:81— PocketMC.Infrastructure/Marketplace/MarketplaceFileInstaller.cs:81-90 | PocketMC.Infrastructure/Marketplace/MarketplaceFileInstaller.cs:105-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:650— PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:650-660 | PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:934-943 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:650` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:935— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:935-944 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:224-233 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:947— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:947-957 | PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:230-239 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) PocketMC.Infrastructure/Instances/InstanceImportService.cs:976— PocketMC.Infrastructure/Instances/InstanceImportService.cs:976-985 | PocketMC.Infrastructure/Marketplace/ModrinthService.cs:789-798 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:303— PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:303-316 | PocketMC.Infrastructure/Backups/Providers/OneDriveBackupProvider.cs:298-311 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:303` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1030— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1030-1043 | PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1101-1114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1030` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:250— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:250-263 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:449-462 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:718— PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:718-731 | PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:931-944 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:718` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) PocketMC.Application/Services/Players/BanSidecarService.cs:112— PocketMC.Application/Services/Players/BanSidecarService.cs:112-125 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:477-490 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:477` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) PocketMC.Infrastructure/News/NewsModels.cs:89— PocketMC.Infrastructure/News/NewsModels.cs:89-108 | PocketMC.Infrastructure/News/NewsModels.cs:126-139 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/News/NewsModels.cs:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:207— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:207-220 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:221-234 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1974— PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1974-1987 | REDACTED:197-210 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
AX2 · Stateful singletons· Process-global static state · ×7
Process-global static state: NewInstancePage PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:37— `NewInstancePage` is registered per request (scoped/transient), so each caller expects its own instance — but it keeps mutable `static` state that every instance in the process shares, and mutates it outside any lock (InstanceCreatePageIsOpen, IsDownloadInProgress; e.g. `InstanceCreatePageIsOpen` at line 119). The per-request lifetime buys nothing here: the field outlives every request and concurrent requests race on it.
Process-global static state: AddonIconService PocketMC.Desktop/Features/Mods/AddonIconService.cs:15— `AddonIconService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_fabricFallback, _quiltFallback, _forgeFallback, _pluginFallback, _bedrockFallback, _bedrockBehaviorFallback; e.g. `_fabricFallback` at line 81). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SplashWindow PocketMC.Desktop/Features/Shell/SplashWindow.xaml.cs:6— `SplashWindow` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_instance; e.g. `_instance` at line 34). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: HardwareRenderingOptimizer PocketMC.Desktop/Infrastructure/HardwareRenderingOptimizer.cs:14— `HardwareRenderingOptimizer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_cachedRefreshRate; e.g. `_cachedRefreshRate` at line 76). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SingleInstanceService PocketMC.Desktop/Infrastructure/SingleInstanceService.cs:15— `SingleInstanceService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_mutex, _cancellationTokenSource; e.g. `_mutex` at line 35). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: WindowsToastNotificationService PocketMC.Infrastructure/Notifications/WindowsToastNotificationService.cs:9— `WindowsToastNotificationService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_isRegistered; e.g. `_isRegistered` at line 48). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: DownloaderService PocketMC.Infrastructure/Storage/DownloaderService.cs:16— `DownloaderService` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_cloudflaredExpectedSha256IsOverridden, _cloudflaredExpectedSha256Override; e.g. `_cloudflaredExpectedSha256IsOverridden` at line 33). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Duplicated block (13 lines × 2) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:255— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:255-267 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:159-171 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:255` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:234— PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:234-246 | PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:308-320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:234` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1152— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1152-1164 | PocketMC.Infrastructure/Mods/PluginScanner.cs:102-114 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1152` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:387— PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:387-399 | PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:636-648 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:387` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:650` calls `DispatcherFrame`, `Run` and `PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:401` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:728— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:728-740 | PocketMC.Desktop/Features/Tunnel/PlayitConsoleWindow.xaml.cs:347-359 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:216— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:216-228 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:413-425 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:410— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:410-422 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:684-696 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:88— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:88-102 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:219-233 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:88` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) PocketMC.Desktop/Features/Mods/ModpackService.cs:206— PocketMC.Desktop/Features/Mods/ModpackService.cs:206-220 | PocketMC.Desktop/Features/Mods/ModpackService.cs:331-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15 lines × 2) PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:35— PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:35-49 | PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:77-91 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:902— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:902-916 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:927-941 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:902` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) PocketMC.Infrastructure/Players/ServerStateFileService.cs:200— PocketMC.Infrastructure/Players/ServerStateFileService.cs:200-214 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:231-245 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Players/ServerStateFileService.cs:200` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) PocketMC.Infrastructure/Tunnel/TunnelService.cs:438— PocketMC.Infrastructure/Tunnel/TunnelService.cs:438-449 | PocketMC.Infrastructure/Tunnel/TunnelService.cs:526-537 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:115— PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:115-126 | PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:213-224 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:115` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:830— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:830-841 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:976-987 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:830` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:192— PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:192-203 | PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:349-360 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:192` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:190` calls `OnPropertyChanged`, `nameof` and `PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:347` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:237— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:237-248 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:251-262 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2053— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2053-2061 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2072-2080 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:908— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:908-916 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1238-1246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) PocketMC.Domain/Storage/FileUtils.cs:156— PocketMC.Domain/Storage/FileUtils.cs:156-164 | PocketMC.Domain/Storage/FileUtils.cs:181-189 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Domain/Storage/FileUtils.cs:156` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) PocketMC.Infrastructure/Tunnel/TunnelService.cs:379— PocketMC.Infrastructure/Tunnel/TunnelService.cs:379-387 | PocketMC.Infrastructure/Tunnel/TunnelService.cs:434-442 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Tunnel/TunnelService.cs:379` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) REDACTED:639— REDACTED:639-647 | REDACTED:705-713 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) PocketMC.Domain/Models/PortDiagnosticsSnapshot.cs:62— PocketMC.Domain/Models/PortDiagnosticsSnapshot.cs:62-72 | PocketMC.Domain/Models/PortDiagnosticsSnapshot.cs:78-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) REDACTED:497— REDACTED:497-507 | REDACTED:535-545 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:396— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:396-406 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:670-680 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:32— PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:32-42 | PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:56-66 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:909— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:909-921 | PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:198-208 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:909` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) PocketMC.Domain/Models/InstanceMetadata.cs:34— PocketMC.Domain/Models/InstanceMetadata.cs:34-38 | PocketMC.Domain/Models/ServerConfiguration.cs:16-20 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:149— PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:149-153 | PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:176-180 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:154` calls `GetProperty`, `GetString` and `PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:182` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) PocketMC.Infrastructure/Storage/DownloaderService.cs:189— PocketMC.Infrastructure/Storage/DownloaderService.cs:189-195 | PocketMC.RemoteControl/Tunnels/CloudflaredInstaller.cs:73-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Storage/DownloaderService.cs:189` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (5 lines × 2) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1242— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1242-1246 | PocketMC.Desktop/Features/Dashboard/InstanceCardViewModel.cs:651-655 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:171— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:171-175 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:274-278 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs` and `PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Sync-over-async blocking — 4 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:454— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking REDACTED:34— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking PocketMC.Infrastructure/Power/SleepPreventionService.cs:135— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking PocketMC.RemoteControl/Tunnels/CloudflaredQuickTunnelProvider.cs:301— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
X18 · Disposal-pattern correctness· Owned disposable field is never released · ×5
Owned disposable field is never released PocketMC.Infrastructure/Instances/ServerProcess.cs:43— `ServerProcess` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_startupCts` itself (line 43), which makes that instance its own. But `_startupCts` is named in none of the methods the disposal search covered: `Dispose` (line 641), `Kill` (line 342), `CloseSessionLog` (line 608) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_startupCts?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released PocketMC.Infrastructure/News/NewsService.cs:47— `NewsService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_syncGate` itself (line 47), which makes that instance its own. But `_syncGate` is named in none of the methods the disposal search covered: `Dispose` (line 711), `Dispose` (line 720), `Stop` (line 155), `Dispose` (line 711), `Dispose` (line 720) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_syncGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:68— `PlayitAgentService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_restartDelayCancellation` itself (line 68), which makes that instance its own. But `_restartDelayCancellation` is named in none of the methods the disposal search covered: `Dispose` (line 1063), `UnsubscribeSystemEvents` (line 987) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_restartDelayCancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:72— `PlayitAgentService` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_runtimeCheckGate` itself (line 72), which makes that instance its own. But `_runtimeCheckGate` is named in none of the methods the disposal search covered: `Dispose` (line 1063), `UnsubscribeSystemEvents` (line 987) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_runtimeCheckGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released PocketMC.RemoteControl/Tunnels/CloudflaredQuickTunnelProvider.cs:31— `CloudflaredQuickTunnelProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_startLock` itself (line 31), which makes that instance its own. But `_startLock` is named in none of the methods the disposal search covered: `Dispose` (line 291), `StopAsync` (line 205) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_startLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
ClassTooLong: RemoteDashboardHost REDACTED— ClassTooLong — 679 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 279 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: JavaModMetadataService PocketMC.Infrastructure/Mods/JavaModMetadataService.cs— ClassTooLong — 529 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 129 over it, 1.32× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: InstanceTunnelOrchestrator PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs— ClassTooLong — 466 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 66 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RemoteControlSettingsViewModel REDACTED— ClassTooLong — 425 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 25 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Change coupling: MapBrowserPage.xaml.cs ↔ PluginBrowserPage.xaml.cs PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:1— `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `af66d313` feat: improve crash diagnostics, AI button contrast, and marketplace …; `8f49381f` change consol cursforge link to direct redirect to api key page; `79fe8f53` fix: improve CurseForge API key warning/error handling and add settin… — run `git show` on any of them.
Change coupling: CurseForgeService.cs ↔ DependencyResolverService.cs PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:1— `PocketMC.Infrastructure/Marketplace/CurseForgeService.cs` and `PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `af66d313` feat: improve crash diagnostics, AI button contrast, and marketplace …; `1f4fc21a` change the modpack rules , and fix some issue and add clarification b…; `5b98a524` fix cursforge marketplace , and plugin management (at that commit the files were still `PocketMC.Desktop/Features/Marketplace/CurseForgeService.cs` and `PocketMC.Desktop/Features/Marketplace/DependencyResolverService.cs`) — run `git show` on any of them.
Change coupling: AppSettingsPage.xaml.cs ↔ ShellVisualService.cs PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1— `PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs` and `PocketMC.Desktop/Features/Shell/ShellVisualService.cs` change together 62% of the time (13 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `290240f3` feat(ui): add custom blur and dimming settings for wallpaper theme & …; `a36d25ec` feat: change default accent color to green and add migration; `b7b26385` feat: add ReassertAccent method and accent apply feedback — run `git show` on any of them.
Change coupling: REDACTED ↔ app.js REDACTED:1— `REDACTED` and `PocketMC.RemoteControl/Web/app.js` change together 60% of the time (15 of the 25 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 15 shared commits counted here, the most recent 3 are `528da84e` fix(core): resolve concurrency, memory, and lifecycle stability remed…; `d3813fd2` fix(review-remediations): enforce status permissions, fix subuser pas…; `24dba5ee` file upload feture in remote web dashbooared , and fixed flickkering … — run `git show` on any of them.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×4
Edited copy of a member (22 corresponding lines) PocketMC.Application/Services/Players/BanSidecarService.cs:96— PocketMC.Application/Services/Players/BanSidecarService.cs:96-133 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:469-490 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:12— PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:12-33 | PocketMC.Desktop/Features/WhatsNew/WhatsNewWindow.xaml.cs:18-48 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) PocketMC.Infrastructure/Mods/AddonToggleService.cs:209— PocketMC.Infrastructure/Mods/AddonToggleService.cs:209-236 | PocketMC.Infrastructure/Mods/AddonToggleService.cs:242-263 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) PocketMC.Infrastructure/Tunnel/PlayitAgentProcessManager.cs:84— PocketMC.Infrastructure/Tunnel/PlayitAgentProcessManager.cs:84-105 | PocketMC.Infrastructure/Tunnel/PlayitAgentProcessManager.cs:108-131 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×4
Edited copy of a member (15 corresponding lines) PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:62— PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:62-76 | PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:83-97 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1506— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1506-1520 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1523-1537 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) PocketMC.Infrastructure/Networking/PortPreflightService.cs:554— PocketMC.Infrastructure/Networking/PortPreflightService.cs:554-568 | PocketMC.Infrastructure/Networking/PortPreflightService.cs:571-585 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsVersionUpdatesVM.cs:236— PocketMC.Desktop/Features/Settings/SettingsVersionUpdatesVM.cs:236-250 | PocketMC.Desktop/Features/Settings/SettingsVersionUpdatesVM.cs:253-267 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×4
Edited copy of a member (11 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1167— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1167-1177 | PocketMC.Infrastructure/Mods/PluginScanner.cs:117-127 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) PocketMC.Domain/Storage/FileUtils.cs:201— PocketMC.Domain/Storage/FileUtils.cs:201-222 | PocketMC.Infrastructure/Instances/InstanceExportService.cs:158-168 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:495— PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:495-509 | PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:512-522 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) PocketMC.Infrastructure/Instances/Export/AddonExportService.cs:388— PocketMC.Infrastructure/Instances/Export/AddonExportService.cs:388-398 | PocketMC.Infrastructure/Mods/AddonInventoryService.cs:382-392 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×4
Edited copy of a member (8 corresponding lines) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:528— PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:528-535 | PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:662-669 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:813— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:813-820 | PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:422-431 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:79— PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:79-86 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:393-400 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:63— PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:63-70 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:114-122 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×4
Edited copy of a member (6 corresponding lines) PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:123— PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:123-128 | PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:131-136 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) PocketMC.Desktop/Features/Marketplace/DependencyConfirmationWindow.xaml.cs:15— PocketMC.Desktop/Features/Marketplace/DependencyConfirmationWindow.xaml.cs:15-21 | PocketMC.Desktop/Features/Tunnel/CreateTunnelDialog.xaml.cs:31-36 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) PocketMC.Infrastructure/Networking/PortLeaseRegistry.cs:256— PocketMC.Infrastructure/Networking/PortLeaseRegistry.cs:256-261 | PocketMC.Infrastructure/Networking/PortPreflightService.cs:795-800 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) PocketMC.Infrastructure/Java/JavaAdoptiumClient.cs:106— PocketMC.Infrastructure/Java/JavaAdoptiumClient.cs:106-111 | PocketMC.Infrastructure/Storage/DownloaderService.cs:495-501 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (16 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:197— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:197-212 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:381-396 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) PocketMC.Infrastructure/Instances/JavaLaunchConfigurator.cs:224— PocketMC.Infrastructure/Instances/JavaLaunchConfigurator.cs:224-239 | PocketMC.Infrastructure/Instances/PocketMineLaunchConfigurator.cs:146-161 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:227— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:227-242 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:725-740 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:240— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:240-255 | PocketMC.Infrastructure/Players/PlayerDataService.cs:228-243 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:243— PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:243-250 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:481-488 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:243` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) REDACTED:873— REDACTED:873-880 | REDACTED:953-960 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) PocketMC.Application/Services/Players/BanSidecarService.cs:145— PocketMC.Application/Services/Players/BanSidecarService.cs:145-152 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:16-23 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1170— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1170-1177 | PocketMC.Infrastructure/Mods/PluginScanner.cs:120-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1170` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:310— PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:310-316 | PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:337-343 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:288— PocketMC.Infrastructure/Marketplace/ModrinthService.cs:288-294 | PocketMC.Infrastructure/Marketplace/ModrinthService.cs:314-320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Marketplace/ModrinthService.cs:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:30— PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:30-36 | PocketMC.Infrastructure/Mods/AddonAutoUpdateService.cs:183-189 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) PocketMC.Domain/Models/RemoteControlUser.cs:10— PocketMC.Domain/Models/RemoteControlUser.cs:10-18 | PocketMC.RemoteControl/Models/RemoteDashboardStatus.cs:14-20 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:174— PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:174-179 | REDACTED:901-906 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:528— PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:528-533 | PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:662-667 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:528` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:61— PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:61-66 | PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:61-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) PocketMC.Infrastructure/Java/JavaProvisioningService.cs:168— PocketMC.Infrastructure/Java/JavaProvisioningService.cs:168-173 | PocketMC.Infrastructure/Php/PhpProvisioningService.cs:236-241 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `version` to `int` in one and `string` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Unfinished stub — throws NotImplementedException PocketMC.Desktop/Core/Presentation/Converters.cs:54— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException PocketMC.Desktop/Core/Presentation/Converters.cs:75— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException PocketMC.Desktop/Features/Marketplace/DependencyConfirmationWindow.xaml.cs:49— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException PocketMC.Desktop/Features/Settings/MinecraftMotdConverter.cs:302— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Weak hash algorithm PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1114— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:437— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm PocketMC.Infrastructure/Players/PlayerDataService.cs:81— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm PocketMC.Infrastructure/Storage/DownloaderService.cs:184— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
Members sharing a duplicated core (4 members, 50+ identical tokens) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:891— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:891-931 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:167-203 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:181-217 | PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:189-216 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:70— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:70-122 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:125-145 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:98-150 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:153-173 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:519— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:519-546 | PocketMC.Infrastructure/Players/PlayerDataService.cs:440-467 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:342-369 | PocketMC.Infrastructure/Players/WhitelistService.cs:287-303 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×3
Edited copy of a member (14 corresponding lines) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:189— PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:189-203 | PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:347-360 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) PocketMC.Domain/Storage/FileUtils.cs:70— PocketMC.Domain/Storage/FileUtils.cs:70-87 | PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:892-905 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) PocketMC.Desktop/Features/Shell/ShellVisualService.cs:188— PocketMC.Desktop/Features/Shell/ShellVisualService.cs:188-201 | PocketMC.Desktop/Features/Shell/ShellVisualService.cs:204-217 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×3
Edited copy of a member (18 corresponding lines) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:899— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:899-916 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:924-941 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:75— PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:75-94 | PocketMC.Infrastructure/Instances/Providers/PaperProvider.cs:88-105 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) PocketMC.Desktop/Features/Settings/CloudBackupSettingsViewModel.cs:89— PocketMC.Desktop/Features/Settings/CloudBackupSettingsViewModel.cs:89-107 | PocketMC.Desktop/Features/Settings/CloudBackupSettingsViewModel.cs:110-127 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×3
Edited copy of a member (16 corresponding lines) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1211— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1211-1234 | PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:772-787 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:31— PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:31-52 | PocketMC.RemoteControl/Services/RemoteRequestLimiter.cs:55-70 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:428— PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:428-445 | PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:231-246 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×3
Edited copies of one member (3 members, 6+ corresponding lines) REDACTED:14— REDACTED:14-19 | REDACTED:54-59 | REDACTED:74-79 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:32— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:32-37 | PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:55-60 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:103-108 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1241— PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:1241-1246 | PocketMC.Desktop/Features/Dashboard/InstanceCardViewModel.cs:650-655 | PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:21-26 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (18 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:572— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:572-589 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:643-660 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:149— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:149-166 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:194-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:149` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:147` calls `ReadPlayerMapAsync` and `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:192` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18 lines × 2) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:91— PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:91-108 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:142-159 — before extracting anything, compare `PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs` and `PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:71— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:71-87 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:126-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:99— PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:99-115 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:154-170 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:99` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1092— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1092-1108 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1428-1444 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1092` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Low cohesion: AppSettingsPage (LCOM4 6) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:58— AppSettingsPage's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OllamaModelManagerDialog (LCOM4 5) PocketMC.Desktop/Features/Intelligence/OllamaModelManagerDialog.xaml.cs:16— OllamaModelManagerDialog's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: PortConflictWindow (LCOM4 4) PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:18— PortConflictWindow's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Stateful shared instance: ControlledNavigationStack PocketMC.Desktop/Navigation/ControlledNavigationStack.cs:52— `ControlledNavigationStack` is not registered, but the singleton `AppNavigationService` creates it and keeps it in `_detailStack`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_entries, _forwardEntries; e.g. `_entries` at line 65).
Stateful shared instance: WallpaperMicaService PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:19— `WallpaperMicaService` is not registered, but the singleton `ShellVisualService` creates it and keeps it in `_wallpaperMicaService`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_blurredBitmap, _lastWallpaperPath, _lastBlurRadius; e.g. `_blurredBitmap` at line 49).
Deprecated: xunit Directory.Packages.props:26— xunit 2.5.3 — Legacy — the publisher's replacement is `xunit.v3`; that is the next major line under a new package id, so the move is a breaking rename rather than a version bump — budget for API changes in the code that uses it, not only the reference swap.
Repeated repair: PocketMC.Infrastructure/Telemetry/TelemetryService.cs PocketMC.Infrastructure/Telemetry/TelemetryService.cs:109— PocketMC.Infrastructure/Telemetry/TelemetryService.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is TelemetryService.EnsureCountryFetchedAsync at line 109), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: require first-run install and country reporting”; “fix: enforce remote permissions and make server recovery transactional”; “fix unknown verion and country in telemetry”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Infrastructure/Telemetry/TelemetryService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:83— PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 15 (its worst body is ServerLifecycleService.StartAsync at line 83), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(settings): make scheduled restart cancellable and exclude addons search from enter-save”; “fix(core): resolve concurrency, memory, and lifecycle stability remediations”; “fix(review-remediations): enforce status permissions, fix subuser password check, prevent memory leaks, and use dynamic versioning”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 00:34:50 +05:30' --until='2026-10-24 00:34:50 +05:30' --full-history --no-merges -- PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
BarePragmaDisable PocketMC.RemoteControl.Tests/Services/RemoteInstanceControlServiceTests.cs:11— #pragma warning disable CS0067 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable PocketMC.RemoteControl.Tests/Services/RemoteStatusServiceTests.cs:14— #pragma warning disable CS0067 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
D4 · Code Duplication· Edited copy of a member (34 corresponding lines) · ×2
Edited copy of a member (34 corresponding lines) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:111— PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:111-149 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:162-195 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (34 corresponding lines) PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:100— PocketMC.Infrastructure/Instances/Updates/InstanceArtifactStager.cs:100-133 | PocketMC.Infrastructure/Instances/Updates/InstanceVersionTargetService.cs:59-94 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×2
Edited copy of a member (20 corresponding lines) PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:114— PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:114-133 | PocketMC.Desktop/Features/Settings/ImageCropPage.xaml.cs:212-238 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1145— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1145-1164 | PocketMC.Infrastructure/Mods/PluginScanner.cs:95-114 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×2
Edited copy of a member (19 corresponding lines) PocketMC.Domain/Storage/FileUtils.cs:155— PocketMC.Domain/Storage/FileUtils.cs:155-173 | PocketMC.Domain/Storage/FileUtils.cs:180-198 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (19 corresponding lines) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:353— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:353-371 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:374-394 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×2
Edited copy of a member (13 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1180— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1180-1199 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1447-1459 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:191— PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:191-206 | PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:532-544 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×2
Edited copy of a member (21 corresponding lines) PocketMC.Application/Services/Players/PlayerListParser.cs:187— PocketMC.Application/Services/Players/PlayerListParser.cs:187-211 | PocketMC.Application/Services/Players/PlayerListParser.cs:214-234 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) PocketMC.Infrastructure/Mods/PluginScanner.cs:42— PocketMC.Infrastructure/Mods/PluginScanner.cs:42-62 | PocketMC.Infrastructure/Mods/PluginScanner.cs:68-88 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×2
Edited copy of a member (7 corresponding lines) PocketMC.Infrastructure/Storage/DownloaderService.cs:181— PocketMC.Infrastructure/Storage/DownloaderService.cs:181-195 | PocketMC.RemoteControl/Tunnels/CloudflaredInstaller.cs:71-77 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) PocketMC.Infrastructure/News/NewsModels.cs:386— PocketMC.Infrastructure/News/NewsModels.cs:386-397 | PocketMC.Infrastructure/News/NewsService.cs:694-700 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×2
Edited copy of a member (9 corresponding lines) PocketMC.Domain/Models/InstanceExportManifest.cs:395— PocketMC.Domain/Models/InstanceExportManifest.cs:395-405 | PocketMC.Infrastructure/Instances/Export/AddonExportService.cs:401-409 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) PocketMC.Infrastructure/Backups/BackupSchedulerService.cs:32— PocketMC.Infrastructure/Backups/BackupSchedulerService.cs:32-40 | PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:47-60 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×2
Edited copy of a member (12 corresponding lines) PocketMC.Infrastructure/Php/PhpProvisioningService.cs:136— PocketMC.Infrastructure/Php/PhpProvisioningService.cs:136-148 | PocketMC.Infrastructure/Java/JavaProvisioningService.cs:75-86 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportViewModel.cs:225— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportViewModel.cs:225-236 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportViewModel.cs:358-370 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (5 corresponding lines) · ×2
Edited copy of a member (5 corresponding lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1288— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1288-1293 | PocketMC.Infrastructure/Mods/AddonUpdateCheckService.cs:131-135 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:163— PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:163-171 | PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:172-176 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 8+ corresponding lines) · ×2
Edited copies of one member (3 members, 8+ corresponding lines) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:155— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:155-162 | PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:197-204 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:258-265 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 8+ corresponding lines) PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:269— PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:269-276 | PocketMC.Desktop/Features/Tunnel/PreStartAgentWarningWindow.xaml.cs:64-71 | PocketMC.Desktop/Features/WhatsNew/WhatsNewWindow.xaml.cs:91-98 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (27 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96-122 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:124-150 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (27 lines × 2) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:97— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:97-123 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:199-225 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs` and `PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:97` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (5 lines × 3) REDACTED:87— REDACTED:87-91 | REDACTED:95-99 | REDACTED:103-107 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:33— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:33-37 | PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:56-60 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:104-108 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs` and `PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 3) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:156— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:156-162 | PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:198-204 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:259-265 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs` and `PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 3) PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:270— PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:270-276 | PocketMC.Desktop/Features/Tunnel/PreStartAgentWarningWindow.xaml.cs:65-71 | PocketMC.Desktop/Features/WhatsNew/WhatsNewWindow.xaml.cs:92-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Fake-async — async method never awaits PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:370— `TriggerServerAutoStarts` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:135— `OnTimerTick` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
X18 · Disposal-pattern correctness· Owned disposable field overwritten without releasing the previous instance · ×2
Owned disposable field overwritten without releasing the previous instance PocketMC.Infrastructure/Social/DiscordRpcService.cs:73— `_client` is a `DiscordRpcClient` this type creates itself, and here (line 73) a new instance is written over it — but `Initialize` itself reads through `_client` before replacing it, so it expects an instance to be there, and nothing earlier in `Initialize` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_client?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back.
Owned disposable field overwritten without releasing the previous instance PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:620— `_downloadCancellation` is a `CancellationTokenSource` this type creates itself, and here (line 620) a new instance is written over it — but `DownloadAgentAsync` itself reads through `_downloadCancellation` before replacing it, so it expects an instance to be there, and nothing earlier in `DownloadAgentAsync` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_downloadCancellation?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back.
Swallowed exception (caught, then discarded) PocketMC.Desktop/Features/Settings/CloudBackupSettingsViewModel.cs:76— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:372— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Multiple navigation landmarks without distinguishing labels PocketMC.RemoteControl/Web/index.html:2— With more than one navigation landmark, each needs an aria-label/aria-labelledby (e.g. "Primary", "Footer") so assistive tech can tell them apart. At least one nav here is unlabelled.
Low contrast colour pair in CSS (3.2:1) PocketMC.RemoteControl/Web/styles.css:1210— `.filter-label:has(#filterWarn:checked)` sets color: #ffffff on background-color: #d97706 — 3.2:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety· Focus outline removed in CSS without a · ×1
Focus outline removed in CSS without a :focus replacement PocketMC.RemoteControl/Web/styles.css:2549— `.code-editor` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
RemoteDashboardHost.MapEndpoints (cyclomatic 157) REDACTED:222— RemoteDashboardHost.MapEndpoints has cyclomatic complexity 157 (threshold 15). Most of this is not in the body itself: 2 of the 157 points are its own statements and the rest belongs to 27 function literals inside it that branch (lines 871, 813, 637, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AppConfig.ParseYamlContent (cyclomatic 74) PocketMC.Infrastructure/Configuration/AppConfig.cs:185— AppConfig.ParseYamlContent has cyclomatic complexity 74 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
app.renderStatus (cyclomatic 62) PocketMC.RemoteControl/Web/app.js:461— app.renderStatus has cyclomatic complexity 62 (threshold 15). Of this number, 52 points are the body's own statements and 10 belong to 3 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JavaModMetadataService.ParseForgeMetadata (cyclomatic 60) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:483— JavaModMetadataService.ParseForgeMetadata has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NewsService.SynchronizeCoreAsync (cyclomatic 47) PocketMC.Infrastructure/News/NewsService.cs:173— NewsService.SynchronizeCoreAsync has cyclomatic complexity 47 (threshold 15). Of this number, 44 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
JavaModMetadataService.ParseQuiltMetadata (cyclomatic 46) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:343— JavaModMetadataService.ParseQuiltMetadata has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsAddonsVM.AddModAsync (cyclomatic 45) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1295— SettingsAddonsVM.AddModAsync has cyclomatic complexity 45 (threshold 15). Most of this is not in the body itself: 3 of the 45 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 1303, 1394). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
PortsMapPage.RefreshMapAsync (cyclomatic 45) PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:280— PortsMapPage.RefreshMapAsync has cyclomatic complexity 45 (threshold 15). Of this number, 39 points are the body's own statements and 6 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerDetectionService.DetectServerTypeAndVersionAsync (cyclomatic 45) PocketMC.Infrastructure/Instances/ServerDetectionService.cs:21— ServerDetectionService.DetectServerTypeAndVersionAsync has cyclomatic complexity 45 (threshold 15). Most of this is not in the body itself: 3 of the 45 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 28, 72, 104). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
MainWindow.OnKeyDown (cyclomatic 42) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:797— MainWindow.OnKeyDown has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsAddonsVM.AddPluginAsync (cyclomatic 40) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:967— SettingsAddonsVM.AddPluginAsync has cyclomatic complexity 40 (threshold 15). Most of this is not in the body itself: 4 of the 40 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 976, 1056). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
JavaModMetadataService.ParseFabricMetadata (cyclomatic 39) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:216— JavaModMetadataService.ParseFabricMetadata has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsBackupService.RestoreFromPackage (cyclomatic 38) PocketMC.Infrastructure/Configuration/SettingsBackupService.cs:236— SettingsBackupService.RestoreFromPackage has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DependencyResolverService.ResolveRecursiveAsync (cyclomatic 38) PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:127— DependencyResolverService.ResolveRecursiveAsync has cyclomatic complexity 38 (threshold 15). Of this number, 36 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ModpackService.ExecuteImportAsync (cyclomatic 36) PocketMC.Desktop/Features/Mods/ModpackService.cs:98— ModpackService.ExecuteImportAsync has cyclomatic complexity 36 (threshold 15). Most of this is not in the body itself: 11 of the 36 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 190, 141, 197, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SettingsAddonsVM.ApplyFiltersAndSort (cyclomatic 35) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1994— SettingsAddonsVM.ApplyFiltersAndSort has cyclomatic complexity 35 (threshold 15). Most of this is not in the body itself: 1 of the 35 points is its own statement and the rest belongs to 7 function literals inside it that branch (lines 1996, 2025, 2003, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
NewInstancePage.BtnCreate_Click (cyclomatic 34) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:484— NewInstancePage.BtnCreate_Click has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SettingsAddonsVM.SettingsAddonsVM.ctor (cyclomatic 33) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:258— SettingsAddonsVM.SettingsAddonsVM.ctor has cyclomatic complexity 33 (threshold 15). Most of this is not in the body itself: 2 of the 33 points are its own statements and the rest belongs to 19 function literals inside it that branch (lines 311, 293, 309, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ServerConfigurationService.Load (cyclomatic 33) PocketMC.Application/Services/Instances/ServerConfigurationService.cs:64— ServerConfigurationService.Load has cyclomatic complexity 33 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
InstanceImportService.ImportLocalFolderAsync (cyclomatic 33) PocketMC.Infrastructure/Instances/InstanceImportService.cs:1359— InstanceImportService.ImportLocalFolderAsync has cyclomatic complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SemanticVersionHelper.SatisfiesCondition (cyclomatic 32) PocketMC.Domain/Models/SemanticVersionHelper.cs:85— SemanticVersionHelper.SatisfiesCondition has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PluginBrowserPage.RefreshResultsAsync (cyclomatic 30) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:217— PluginBrowserPage.RefreshResultsAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsBackupService.CreateBackupPackage (cyclomatic 30) PocketMC.Infrastructure/Configuration/SettingsBackupService.cs:18— SettingsBackupService.CreateBackupPackage has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PortsMapPage.ExecuteSavePort (cyclomatic 29) PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:197— PortsMapPage.ExecuteSavePort has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerCrashDetector.AnalyzeLogSignatures (cyclomatic 29) PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:214— ServerCrashDetector.AnalyzeLogSignatures has cyclomatic complexity 29 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ForgeInstaller.HandleInstallerBasedSetupAsync (cyclomatic 29) PocketMC.Infrastructure/Instances/ForgeInstaller.cs:21— ForgeInstaller.HandleInstallerBasedSetupAsync has cyclomatic complexity 29 (threshold 15). Of this number, 19 points are the body's own statements and 10 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AddonInventoryService.BuildItem (cyclomatic 29) PocketMC.Infrastructure/Mods/AddonInventoryService.cs:112— AddonInventoryService.BuildItem has cyclomatic complexity 29 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ServerConfigurationService.Save (cyclomatic 28) PocketMC.Application/Services/Instances/ServerConfigurationService.cs:132— ServerConfigurationService.Save has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BackupService.CreateLocalBackupAsync (cyclomatic 28) PocketMC.Infrastructure/Backups/BackupService.cs:252— BackupService.CreateLocalBackupAsync has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AddonExportService.BuildCanonicalJavaAddonsAsync (cyclomatic 28) PocketMC.Infrastructure/Instances/Export/AddonExportService.cs:52— AddonExportService.BuildCanonicalJavaAddonsAsync has cyclomatic complexity 28 (threshold 15). Of this number, 27 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it works in explicit hardware vector and instruction-set types. A kernel divided across a call boundary passes its vectors between the parts and depends on the runtime putting them back together, so the division can cost more than the complexity it removes. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
CurseForgeService.SearchAsync (cyclomatic 28) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:142— CurseForgeService.SearchAsync has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JavaModMetadataService.ScanJarInternal (cyclomatic 28) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:73— JavaModMetadataService.ScanJarInternal has cyclomatic complexity 28 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PortConflictWindow.ValidatePort (cyclomatic 26) PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:121— PortConflictWindow.ValidatePort has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AppSettingsPage.ChangeRootDirectory_Click (cyclomatic 26) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1989— AppSettingsPage.ChangeRootDirectory_Click has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ModrinthService.SelectCompatibleFile (cyclomatic 26) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:146— ModrinthService.SelectCompatibleFile has cyclomatic complexity 26 (threshold 15). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExportFileEnumerator.EnumerateExportFiles (cyclomatic 25) PocketMC.Infrastructure/Instances/Export/ExportFileEnumerator.cs:85— ExportFileEnumerator.EnumerateExportFiles has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AddonManifestService.SyncManifestAsync (cyclomatic 25) PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:286— AddonManifestService.SyncManifestAsync has cyclomatic complexity 25 (threshold 15). Of this number, 22 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DownloaderService.DownloadFileAsync (cyclomatic 25) PocketMC.Infrastructure/Storage/DownloaderService.cs:57— DownloaderService.DownloadFileAsync has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsAddonsVM.UpdateAllAddonsAsync (cyclomatic 24) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1782— SettingsAddonsVM.UpdateAllAddonsAsync has cyclomatic complexity 24 (threshold 15). Of this number, 12 points are the body's own statements and 12 belong to 4 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
AppSettingsPage.UpdateDiscordRpcPreview (cyclomatic 24) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1695— AppSettingsPage.UpdateDiscordRpcPreview has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InstanceImportService.TryRestorePackagedJavaAddonAsync (cyclomatic 24) PocketMC.Infrastructure/Instances/InstanceImportService.cs:651— InstanceImportService.TryRestorePackagedJavaAddonAsync has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LocalNetworkAddressService.GetRankedCandidateIps (cyclomatic 24) PocketMC.Infrastructure/Networking/LocalNetworkAddressService.cs:143— LocalNetworkAddressService.GetRankedCandidateIps has cyclomatic complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DashboardViewModel.ResolveAllTunnelsInBackgroundAsync (cyclomatic 23) PocketMC.Desktop/Features/Dashboard/DashboardViewModel.cs:205— DashboardViewModel.ResolveAllTunnelsInBackgroundAsync has cyclomatic complexity 23 (threshold 15). Of this number, 19 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PluginBrowserPage.BtnInstall_Click (cyclomatic 23) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:464— PluginBrowserPage.BtnInstall_Click has cyclomatic complexity 23 (threshold 15). Of this number, 17 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TunnelPage.RefreshStatusAsync (cyclomatic 23) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:181— TunnelPage.RefreshStatusAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JavaModMetadataService.ParseMcModInfoMetadata (cyclomatic 23) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:689— JavaModMetadataService.ParseMcModInfoMetadata has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SimpleVoiceChatDetector.Detect (cyclomatic 23) PocketMC.Infrastructure/Networking/SimpleVoiceChatDetector.cs:30— SimpleVoiceChatDetector.Detect has cyclomatic complexity 23 (threshold 15). Of this number, 21 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TunnelService.AutoCreateTunnelAsync (cyclomatic 23) PocketMC.Infrastructure/Tunnel/TunnelService.cs:246— TunnelService.AutoCreateTunnelAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PlayerManagementViewModel.ApplyOnlinePlayers (cyclomatic 22) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:336— PlayerManagementViewModel.ApplyOnlinePlayers has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerSettingsViewModel.SaveConfigurations (cyclomatic 22) PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:482— ServerSettingsViewModel.SaveConfigurations has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ModpackParser.ParseModrinthPackAsync (cyclomatic 22) PocketMC.Application/Services/Mods/ModpackParser.cs:72— ModpackParser.ParseModrinthPackAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BedrockAddonInstaller.ResolvePackStrings (cyclomatic 22) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:915— BedrockAddonInstaller.ResolvePackStrings has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ChangelogParser.Parse (cyclomatic 22) PocketMC.Infrastructure/WhatsNew/ChangelogParser.cs:48— ChangelogParser.Parse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RemoteConsoleWebSocketHandler.HandleAsync (cyclomatic 22) PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs:21— RemoteConsoleWebSocketHandler.HandleAsync has cyclomatic complexity 22 (threshold 15). Of this number, 11 points are the body's own statements and 11 belong to 2 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
MapBrowserPage.BtnInstall_Click (cyclomatic 21) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:279— MapBrowserPage.BtnInstall_Click has cyclomatic complexity 21 (threshold 15). Of this number, 16 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BackupService.RestoreBackupAsync (cyclomatic 21) PocketMC.Infrastructure/Backups/BackupService.cs:502— BackupService.RestoreBackupAsync has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BedrockAddonInstaller.TryParseManifest (cyclomatic 21) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:534— BedrockAddonInstaller.TryParseManifest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsAddonsVM.OpenAddonFolder (cyclomatic 20) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2094— SettingsAddonsVM.OpenAddonFolder has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AppSettingsPage.RefreshOllamaDaemonStatusAsync (cyclomatic 20) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1161— AppSettingsPage.RefreshOllamaDaemonStatusAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InstanceTunnelOrchestrator.EnsureTunnelFlowAsync (cyclomatic 20) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:75— InstanceTunnelOrchestrator.EnsureTunnelFlowAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MarkdownFlowDocumentConverter.ConvertTable (cyclomatic 20) PocketMC.Desktop/Infrastructure/MarkdownFlowDocumentConverter.cs:230— MarkdownFlowDocumentConverter.ConvertTable has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
OllamaProvider.ExtractContent (cyclomatic 20) REDACTED:103— OllamaProvider.ExtractContent has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsManager.Normalize (cyclomatic 20) PocketMC.Infrastructure/Configuration/SettingsManager.cs:351— SettingsManager.Normalize has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ForgeProvider.GetAvailableVersionsAsync (cyclomatic 20) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:31— ForgeProvider.GetAvailableVersionsAsync has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerRebootSchedulerService.IsDue (cyclomatic 20) PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:182— ServerRebootSchedulerService.IsDue has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerRebootSchedulerService.ExecuteScheduledRebootAsync (cyclomatic 20) PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:313— ServerRebootSchedulerService.ExecuteScheduledRebootAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
app.formatFriendlyError (cyclomatic 20) PocketMC.RemoteControl/Web/app.js:208— app.formatFriendlyError has cyclomatic complexity 20 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ServerConsolePage.LoadSessionLogHistoryAsync (cyclomatic 19) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:428— ServerConsolePage.LoadSessionLogHistoryAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerCrashDialogWindow.Populate (cyclomatic 19) PocketMC.Desktop/Features/Instances/Dialogs/ServerCrashDialogWindow.xaml.cs:36— ServerCrashDialogWindow.Populate has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
MapBrowserPage.RefreshResultsAsync (cyclomatic 19) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:86— MapBrowserPage.RefreshResultsAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ModpackService.ResolveModUrlsAsync (cyclomatic 19) PocketMC.Desktop/Features/Mods/ModpackService.cs:506— ModpackService.ResolveModUrlsAsync has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 5 of the 19 points are its own statements and the rest belongs to one function literal inside it that branches (line 521). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SettingsBackupsVM.RefreshHealthWarnings (cyclomatic 19) PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:224— SettingsBackupsVM.RefreshHealthWarnings has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AppSettingsPage.LoadOllamaModelsAsync (cyclomatic 19) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1247— AppSettingsPage.LoadOllamaModelsAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainWindow.ApplyDynamicWindowSize (cyclomatic 19) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:115— MainWindow.ApplyDynamicWindowSize has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
TunnelPage.UpdateActionButtons (cyclomatic 19) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:852— TunnelPage.UpdateActionButtons has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
PathSafety.IsUnsafeRelativePath (cyclomatic 19) PocketMC.Domain/Security/PathSafety.cs:84— PathSafety.IsUnsafeRelativePath has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ResourceMonitorService.OnTick (cyclomatic 19) PocketMC.Infrastructure/Monitoring/ResourceMonitorService.cs:58— ResourceMonitorService.OnTick has cyclomatic complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PortRecoveryService.IsPortUsedByOtherInstance (cyclomatic 19) PocketMC.Infrastructure/Networking/PortRecoveryService.cs:537— PortRecoveryService.IsPortUsedByOtherInstance has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhpProvisioningService.ProvisionInternalAsync (cyclomatic 19) PocketMC.Infrastructure/Php/PhpProvisioningService.cs:229— PhpProvisioningService.ProvisionInternalAsync has cyclomatic complexity 19 (threshold 15). Of this number, 15 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
app.renderFilesList (cyclomatic 19) PocketMC.RemoteControl/Web/app.js:1552— app.renderFilesList has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 7 of the 19 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 1564, 1591, 1611). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
(anonymous) (cyclomatic 19) PocketMC.RemoteControl/Web/app.js:1297— (anonymous) has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ModpackService.ExtractOverridesAsync (cyclomatic 18) PocketMC.Desktop/Features/Mods/ModpackService.cs:404— ModpackService.ExtractOverridesAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AppSettingsPage.UpdateLocalOllamaControlsVisibility (cyclomatic 18) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1104— AppSettingsPage.UpdateLocalOllamaControlsVisibility has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JavaSetupPage.ScanRuntimes (cyclomatic 18) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:435— JavaSetupPage.ScanRuntimes has cyclomatic complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MarkdownConfig.RenderToHtml (cyclomatic 18) PocketMC.Desktop/Infrastructure/MarkdownConfig.cs:12— MarkdownConfig.RenderToHtml has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ServerPropertiesParser.Read (cyclomatic 18) PocketMC.Application/Services/Instances/ServerPropertiesParser.cs:10— ServerPropertiesParser.Read has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
NeoForgeProvider.GetAvailableVersionsAsync (cyclomatic 18) PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:29— NeoForgeProvider.GetAvailableVersionsAsync has cyclomatic complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerProcess.AppendOutput (cyclomatic 18) PocketMC.Infrastructure/Instances/ServerProcess.cs:389— ServerProcess.AppendOutput has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CurseForgeService.GetLatestVersionWithProjectInfoAsync (cyclomatic 18) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:416— CurseForgeService.GetLatestVersionWithProjectInfoAsync has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NewsTextParser.ParseContent (cyclomatic 18) PocketMC.Infrastructure/News/NewsModels.cs:237— NewsTextParser.ParseContent has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
app.renderSelectionView (cyclomatic 18) PocketMC.RemoteControl/Web/app.js:361— app.renderSelectionView has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DashboardInstanceListViewModel.LoadInstancesAsync (cyclomatic 17) PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs:51— DashboardInstanceListViewModel.LoadInstancesAsync has cyclomatic complexity 17 (threshold 15). Of this number, 11 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PlayerManagementViewModel.LoadJavaGamemodeAsync (cyclomatic 17) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:545— PlayerManagementViewModel.LoadJavaGamemodeAsync has cyclomatic complexity 17 (threshold 15). Of this number, 13 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServerSettingsPage.ServerSettingsPage_Loaded (cyclomatic 17) PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:38— ServerSettingsPage.ServerSettingsPage_Loaded has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AppDialog.ShowResult (cyclomatic 17) PocketMC.Desktop/Infrastructure/AppDialog.cs:41— AppDialog.ShowResult has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MarkdownFlowDocumentConverter.AddInlines (cyclomatic 17) PocketMC.Desktop/Infrastructure/MarkdownFlowDocumentConverter.cs:318— MarkdownFlowDocumentConverter.AddInlines has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ModpackParser.ParseCurseForgePackAsync (cyclomatic 17) PocketMC.Application/Services/Mods/ModpackParser.cs:193— ModpackParser.ParseCurseForgePackAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CloudBackupService.UploadBackupToEnabledProvidersAsync (cyclomatic 17) PocketMC.Infrastructure/Backups/CloudBackupService.cs:14— CloudBackupService.UploadBackupToEnabledProvidersAsync has cyclomatic complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DependencyResolverService.IsFileCompatibleWithEngine (cyclomatic 17) PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:90— DependencyResolverService.IsFileCompatibleWithEngine has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JavaModMetadataService.ParsePluginMetadata (cyclomatic 17) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:766— JavaModMetadataService.ParsePluginMetadata has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NewsTextParser.BuildMetadata (cyclomatic 17) PocketMC.Infrastructure/News/NewsModels.cs:186— NewsTextParser.BuildMetadata has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
GeyserProvisioningService.EnsureGeyserSetupAsync (cyclomatic 17) REDACTED:40— GeyserProvisioningService.EnsureGeyserSetupAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiscordRpcService.BuildServerPresence (cyclomatic 17) PocketMC.Infrastructure/Social/DiscordRpcService.cs:251— DiscordRpcService.BuildServerPresence has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RemoteStatusService.GetInstanceStatusAsync (cyclomatic 17) PocketMC.RemoteControl/Services/RemoteStatusService.cs:65— RemoteStatusService.GetInstanceStatusAsync has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PluginBrowserPage.PluginBrowserPage.ctor (cyclomatic 16) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:60— PluginBrowserPage.PluginBrowserPage.ctor has cyclomatic complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AppSettingsPage.ValidateAiKey_Click (cyclomatic 16) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1493— AppSettingsPage.ValidateAiKey_Click has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainWindow.OnNavigating (cyclomatic 16) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:364— MainWindow.OnNavigating has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainWindow.MainWindow_Closing (cyclomatic 16) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:626— MainWindow.MainWindow_Closing has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellVisualService.RequestMicaUpdate (cyclomatic 16) PocketMC.Desktop/Features/Shell/ShellVisualService.cs:49— ShellVisualService.RequestMicaUpdate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SafeZipExtractor.ExtractAsync (cyclomatic 16) PocketMC.Domain/Storage/SafeZipExtractor.cs:10— SafeZipExtractor.ExtractAsync has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to one function literal inside it that branches (line 13). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SettingsManager.Save (cyclomatic 16) PocketMC.Infrastructure/Configuration/SettingsManager.cs:154— SettingsManager.Save has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiagnosticReportingService.GatherData (cyclomatic 16) PocketMC.Infrastructure/Diagnostics/DiagnosticReportingService.cs:69— DiagnosticReportingService.GatherData has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PlayitStatusService.GetNetworkStatusAsync (cyclomatic 16) PocketMC.Infrastructure/Tunnel/PlayitStatusService.cs:26— PlayitStatusService.GetNetworkStatusAsync has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
TunnelService.ResolveTunnelAsync (cyclomatic 16) PocketMC.Infrastructure/Tunnel/TunnelService.cs:127— TunnelService.ResolveTunnelAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RemoteDashboardHost.GetInstalledAddonsForInstance (cyclomatic 16) REDACTED:1131— RemoteDashboardHost.GetInstalledAddonsForInstance has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
app.api (cyclomatic 16) PocketMC.RemoteControl/Web/app.js:147— app.api has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
No assertions: WaitingForOneInstance_DoesNotBlockItsRuntimeOrAnotherInstance PocketMC.Application.Tests/Services/Safety/RecoveryRegressionTests.cs:64— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
D10 · Test Quality· Fixed-sleep synchronisation · ×1
Fixed-sleep synchronisation: DeleteAgentBinaryAsync_WhenOrphanProcessExists_KillsAndDeletesBinary PocketMC.Infrastructure.Tests/Tunnel/PlayitAgentDeletionTests.cs:43— This test starts a spawned process and then orders itself against it with `Task.Delay(150)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
AppConfig.ParseYamlContent (cognitive 196) PocketMC.Infrastructure/Configuration/AppConfig.cs:185— AppConfig.ParseYamlContent has cognitive complexity 196 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RemoteDashboardHost.MapEndpoints (cognitive 176) REDACTED:222— RemoteDashboardHost.MapEndpoints has cognitive complexity 176 (threshold 15). Most of this is not in the body itself: 1 of the 176 points is its own statement and the rest belongs to 27 function literals inside it that branch (lines 246, 871, 813, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
JavaModMetadataService.ParseForgeMetadata (cognitive 125) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:483— JavaModMetadataService.ParseForgeMetadata has cognitive complexity 125 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
JavaModMetadataService.ParseQuiltMetadata (cognitive 110) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:343— JavaModMetadataService.ParseQuiltMetadata has cognitive complexity 110 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SettingsAddonsVM.AddModAsync (cognitive 96) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1295— SettingsAddonsVM.AddModAsync has cognitive complexity 96 (threshold 15). Most of this is not in the body itself: 2 of the 96 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 1303, 1394). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SettingsAddonsVM.AddPluginAsync (cognitive 91) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:967— SettingsAddonsVM.AddPluginAsync has cognitive complexity 91 (threshold 15). Most of this is not in the body itself: 3 of the 91 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 976, 1056). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
renderStatus (cognitive 87) PocketMC.RemoteControl/Web/app.js:461— renderStatus has cognitive complexity 87 (threshold 15). Drivers by points: if/else 41 (58 pts), boolean chains 18, ternaries 4 (8 pts), loops 1 (3 pts) (nesting depth added 23). Of this number, 65 points are the body's own statements and 22 belong to 4 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortsMapPage.RefreshMapAsync (cognitive 83) PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:280— PortsMapPage.RefreshMapAsync has cognitive complexity 83 (threshold 15). Of this number, 77 points are the body's own statements and 6 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModpackService.ExecuteImportAsync (cognitive 73) PocketMC.Desktop/Features/Mods/ModpackService.cs:98— ModpackService.ExecuteImportAsync has cognitive complexity 73 (threshold 15). Most of this is not in the body itself: 10 of the 73 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 190, 141, 197, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AddonExportService.BuildCanonicalJavaAddonsAsync (cognitive 73) PocketMC.Infrastructure/Instances/Export/AddonExportService.cs:52— AddonExportService.BuildCanonicalJavaAddonsAsync has cognitive complexity 73 (threshold 15). Of this number, 72 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it works in explicit hardware vector and instruction-set types. A kernel divided across a call boundary passes its vectors between the parts and depends on the runtime putting them back together, so the division can cost more than the complexity it removes. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
NewsService.SynchronizeCoreAsync (cognitive 71) PocketMC.Infrastructure/News/NewsService.cs:173— NewsService.SynchronizeCoreAsync has cognitive complexity 71 (threshold 15). Of this number, 69 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ServerDetectionService.DetectServerTypeAndVersionAsync (cognitive 67) PocketMC.Infrastructure/Instances/ServerDetectionService.cs:21— ServerDetectionService.DetectServerTypeAndVersionAsync has cognitive complexity 67 (threshold 15). Most of this is not in the body itself: 2 of the 67 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 28, 104, 72). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ForgeInstaller.HandleInstallerBasedSetupAsync (cognitive 65) PocketMC.Infrastructure/Instances/ForgeInstaller.cs:21— ForgeInstaller.HandleInstallerBasedSetupAsync has cognitive complexity 65 (threshold 15). Of this number, 37 points are the body's own statements and 28 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PluginBrowserPage.RefreshResultsAsync (cognitive 59) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:217— PluginBrowserPage.RefreshResultsAsync has cognitive complexity 59 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
InstanceImportService.ImportLocalFolderAsync (cognitive 59) PocketMC.Infrastructure/Instances/InstanceImportService.cs:1359— InstanceImportService.ImportLocalFolderAsync has cognitive complexity 59 (threshold 15). Of this number, 58 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SettingsBackupService.RestoreFromPackage (cognitive 58) PocketMC.Infrastructure/Configuration/SettingsBackupService.cs:236— SettingsBackupService.RestoreFromPackage has cognitive complexity 58 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaModMetadataService.ParseFabricMetadata (cognitive 57) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:216— JavaModMetadataService.ParseFabricMetadata has cognitive complexity 57 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DependencyResolverService.ResolveRecursiveAsync (cognitive 56) PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:127— DependencyResolverService.ResolveRecursiveAsync has cognitive complexity 56 (threshold 15). Of this number, 54 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerConsolePage.LoadSessionLogHistoryAsync (cognitive 54) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:428— ServerConsolePage.LoadSessionLogHistoryAsync has cognitive complexity 54 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SettingsBackupService.CreateBackupPackage (cognitive 53) PocketMC.Infrastructure/Configuration/SettingsBackupService.cs:18— SettingsBackupService.CreateBackupPackage has cognitive complexity 53 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NewInstancePage.BtnCreate_Click (cognitive 46) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:484— NewInstancePage.BtnCreate_Click has cognitive complexity 46 (threshold 15). Of this number, 45 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MarkdownFlowDocumentConverter.ConvertTable (cognitive 46) PocketMC.Desktop/Infrastructure/MarkdownFlowDocumentConverter.cs:230— MarkdownFlowDocumentConverter.ConvertTable has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ForgeProvider.GetAvailableVersionsAsync (cognitive 46) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:31— ForgeProvider.GetAvailableVersionsAsync has cognitive complexity 46 (threshold 15). Of this number, 43 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MainWindow.OnKeyDown (cognitive 44) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:797— MainWindow.OnKeyDown has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerConfigurationService.Save (cognitive 44) PocketMC.Application/Services/Instances/ServerConfigurationService.cs:132— ServerConfigurationService.Save has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AddonManifestService.SyncManifestAsync (cognitive 44) PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:286— AddonManifestService.SyncManifestAsync has cognitive complexity 44 (threshold 15). Of this number, 36 points are the body's own statements and 8 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ModpackService.ResolveModUrlsAsync (cognitive 43) PocketMC.Desktop/Features/Mods/ModpackService.cs:506— ModpackService.ResolveModUrlsAsync has cognitive complexity 43 (threshold 15). Most of this is not in the body itself: 4 of the 43 points are its own statements and the rest belongs to one function literal inside it that branches (line 521). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
PlayerManagementViewModel.ApplyOnlinePlayers (cognitive 43) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:336— PlayerManagementViewModel.ApplyOnlinePlayers has cognitive complexity 43 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DiagnosticReportingService.GatherData (cognitive 43) PocketMC.Infrastructure/Diagnostics/DiagnosticReportingService.cs:69— DiagnosticReportingService.GatherData has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BedrockAddonInstaller.ResolvePackStrings (cognitive 43) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:915— BedrockAddonInstaller.ResolvePackStrings has cognitive complexity 43 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ModpackParser.ParseModrinthPackAsync (cognitive 41) PocketMC.Application/Services/Mods/ModpackParser.cs:72— ModpackParser.ParseModrinthPackAsync has cognitive complexity 41 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NeoForgeProvider.GetAvailableVersionsAsync (cognitive 41) PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:29— NeoForgeProvider.GetAvailableVersionsAsync has cognitive complexity 41 (threshold 15). Of this number, 38 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ModpackService.ExtractOverridesAsync (cognitive 39) PocketMC.Desktop/Features/Mods/ModpackService.cs:404— ModpackService.ExtractOverridesAsync has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.ChangeRootDirectory_Click (cognitive 39) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1989— AppSettingsPage.ChangeRootDirectory_Click has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortsMapPage.ExecuteSavePort (cognitive 39) PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:197— PortsMapPage.ExecuteSavePort has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
App.HandleUriActivation (cognitive 38) PocketMC.Desktop/App.xaml.cs:228— App.HandleUriActivation has cognitive complexity 38 (threshold 15). Of this number, 30 points are the body's own statements and 8 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
JavaModMetadataService.ParseMcModInfoMetadata (cognitive 38) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:689— JavaModMetadataService.ParseMcModInfoMetadata has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SemanticVersionHelper.SatisfiesCondition (cognitive 37) PocketMC.Domain/Models/SemanticVersionHelper.cs:85— SemanticVersionHelper.SatisfiesCondition has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DownloaderService.DownloadFileAsync (cognitive 37) PocketMC.Infrastructure/Storage/DownloaderService.cs:57— DownloaderService.DownloadFileAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DashboardViewModel.ResolveAllTunnelsInBackgroundAsync (cognitive 35) PocketMC.Desktop/Features/Dashboard/DashboardViewModel.cs:205— DashboardViewModel.ResolveAllTunnelsInBackgroundAsync has cognitive complexity 35 (threshold 15). Of this number, 32 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortConflictWindow.ValidatePort (cognitive 35) PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs:121— PortConflictWindow.ValidatePort has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceTunnelOrchestrator.EnsureTunnelFlowAsync (cognitive 35) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:75— InstanceTunnelOrchestrator.EnsureTunnelFlowAsync has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerSettingsPage.ServerSettingsPage_Loaded (cognitive 34) PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:38— ServerSettingsPage.ServerSettingsPage_Loaded has cognitive complexity 34 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BackupService.CreateLocalBackupAsync (cognitive 34) PocketMC.Infrastructure/Backups/BackupService.cs:252— BackupService.CreateLocalBackupAsync has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RemoteDashboardHost.GetInstalledAddonsForInstance (cognitive 34) REDACTED:1131— RemoteDashboardHost.GetInstalledAddonsForInstance has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerConfigurationService.Load (cognitive 33) PocketMC.Application/Services/Instances/ServerConfigurationService.cs:64— ServerConfigurationService.Load has cognitive complexity 33 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ModrinthService.SelectCompatibleFile (cognitive 33) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:146— ModrinthService.SelectCompatibleFile has cognitive complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalNetworkAddressService.GetRankedCandidateIps (cognitive 33) PocketMC.Infrastructure/Networking/LocalNetworkAddressService.cs:143— LocalNetworkAddressService.GetRankedCandidateIps has cognitive complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.UpdateDiscordRpcPreview (cognitive 32) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1695— AppSettingsPage.UpdateDiscordRpcPreview has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ForgeProvider.GetBuildsAsync (cognitive 32) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:106— ForgeProvider.GetBuildsAsync has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NeoForgeProvider.GetBuildsAsync (cognitive 32) PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:101— NeoForgeProvider.GetBuildsAsync has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MapBrowserPage.BtnInstall_Click (cognitive 31) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:279— MapBrowserPage.BtnInstall_Click has cognitive complexity 31 (threshold 15). Of this number, 21 points are the body's own statements and 10 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.RefreshOllamaDaemonStatusAsync (cognitive 31) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1161— AppSettingsPage.RefreshOllamaDaemonStatusAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BackupService.RestoreBackupAsync (cognitive 31) PocketMC.Infrastructure/Backups/BackupService.cs:502— BackupService.RestoreBackupAsync has cognitive complexity 31 (threshold 15). Of this number, 30 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceImportService.TryRestorePackagedJavaAddonAsync (cognitive 31) PocketMC.Infrastructure/Instances/InstanceImportService.cs:651— InstanceImportService.TryRestorePackagedJavaAddonAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModrinthService.GetLatestVersionAsync (cognitive 31) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:274— ModrinthService.GetLatestVersionAsync has cognitive complexity 31 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DashboardInstanceListViewModel.LoadInstancesAsync (cognitive 30) PocketMC.Desktop/Features/Dashboard/DashboardInstanceListViewModel.cs:51— DashboardInstanceListViewModel.LoadInstancesAsync has cognitive complexity 30 (threshold 15). Most of this is not in the body itself: 14 of the 30 points are its own statements and the rest belongs to one function literal inside it that branches (line 64). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SettingsBackupsVM.RefreshHealthWarnings (cognitive 30) PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:224— SettingsBackupsVM.RefreshHealthWarnings has cognitive complexity 30 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MarkdownFlowDocumentConverter.AddInlines (cognitive 30) PocketMC.Desktop/Infrastructure/MarkdownFlowDocumentConverter.cs:318— MarkdownFlowDocumentConverter.AddInlines has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OllamaService.ParseModelsFromTagsResponse (cognitive 30) REDACTED:256— OllamaService.ParseModelsFromTagsResponse has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerRebootSchedulerService.IsDue (cognitive 30) PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:182— ServerRebootSchedulerService.IsDue has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CurseForgeService.SearchAsync (cognitive 30) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:142— CurseForgeService.SearchAsync has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TunnelService.AutoCreateTunnelAsync (cognitive 30) PocketMC.Infrastructure/Tunnel/TunnelService.cs:246— TunnelService.AutoCreateTunnelAsync has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaSetupPage.BtnDelete_Click (cognitive 29) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:634— JavaSetupPage.BtnDelete_Click has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExportFileEnumerator.EnumerateExportFiles (cognitive 29) PocketMC.Infrastructure/Instances/Export/ExportFileEnumerator.cs:85— ExportFileEnumerator.EnumerateExportFiles has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaModMetadataService.ParsePluginMetadata (cognitive 29) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:766— JavaModMetadataService.ParsePluginMetadata has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerStateFileService.GetBannedPlayersAsync (cognitive 29) PocketMC.Infrastructure/Players/ServerStateFileService.cs:58— ServerStateFileService.GetBannedPlayersAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.LoadOllamaModelsAsync (cognitive 28) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1247— AppSettingsPage.LoadOllamaModelsAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.ValidateAiKey_Click (cognitive 28) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1493— AppSettingsPage.ValidateAiKey_Click has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLlmProvider.ParseApiErrorMessage (cognitive 28) PocketMC.Infrastructure/AI/Providers/BaseLlmProvider.cs:82— BaseLlmProvider.ParseApiErrorMessage has cognitive complexity 28 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ServerCrashDetector.AnalyzeLogSignatures (cognitive 28) PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:214— ServerCrashDetector.AnalyzeLogSignatures has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AddonInventoryService.BuildItem (cognitive 28) PocketMC.Infrastructure/Mods/AddonInventoryService.cs:112— AddonInventoryService.BuildItem has cognitive complexity 28 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ResourceMonitorService.OnTick (cognitive 28) PocketMC.Infrastructure/Monitoring/ResourceMonitorService.cs:58— ResourceMonitorService.OnTick has cognitive complexity 28 (threshold 15). Of this number, 24 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GeyserProvisioningService.PatchGeyserConfigPort (cognitive 28) REDACTED:263— GeyserProvisioningService.PatchGeyserConfigPort has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MapBrowserPage.RefreshResultsAsync (cognitive 27) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:86— MapBrowserPage.RefreshResultsAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerPropertiesParser.Read (cognitive 27) PocketMC.Application/Services/Instances/ServerPropertiesParser.cs:10— ServerPropertiesParser.Read has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ModrinthService.GetFromJsonWithRetryAsync (cognitive 27) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:574— ModrinthService.GetFromJsonWithRetryAsync has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ModrinthService.PostJsonForJsonWithRetryAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ModrinthService.PostJsonForJsonWithRetryAsync (cognitive 27) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:634— ModrinthService.PostJsonForJsonWithRetryAsync has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ModrinthService.GetFromJsonWithRetryAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ChangelogParser.Parse (cognitive 27) PocketMC.Infrastructure/WhatsNew/ChangelogParser.cs:48— ChangelogParser.Parse has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RemoteConsoleWebSocketHandler.HandleAsync (cognitive 27) PocketMC.RemoteControl/Hosting/RemoteConsoleWebSocketHandler.cs:21— RemoteConsoleWebSocketHandler.HandleAsync has cognitive complexity 27 (threshold 15). Most of this is not in the body itself: 12 of the 27 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 72, 40). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SettingsManager.Save (cognitive 26) PocketMC.Infrastructure/Configuration/SettingsManager.cs:154— SettingsManager.Save has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BedrockAddonInstaller.TryParseManifest (cognitive 26) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:534— BedrockAddonInstaller.TryParseManifest has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GeyserProvisioningService.EnsureGeyserSetupAsync (cognitive 26) REDACTED:40— GeyserProvisioningService.EnsureGeyserSetupAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
app.renderSelectionView (cognitive 26) PocketMC.RemoteControl/Web/app.js:361— app.renderSelectionView has cognitive complexity 26 (threshold 15). Drivers by points: ternaries 7 (16 pts), boolean chains 6, if/else 3, loops 1 (nesting depth added 9). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerConsolePage.TxtCommand_KeyDown (cognitive 25) PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:665— ServerConsolePage.TxtCommand_KeyDown has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PluginBrowserPage.BtnInstall_Click (cognitive 25) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:464— PluginBrowserPage.BtnInstall_Click has cognitive complexity 25 (threshold 15). Of this number, 18 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ServerSettingsViewModel.SaveConfigurations (cognitive 25) PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:482— ServerSettingsViewModel.SaveConfigurations has cognitive complexity 25 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SettingsAddonsVM.SettingsAddonsVM.ctor (cognitive 25) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:258— SettingsAddonsVM.SettingsAddonsVM.ctor has cognitive complexity 25 (threshold 15). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to 19 function literals inside it that branch (lines 302, 308, 309, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
PaperProvider.GetAvailableVersionsAsync (cognitive 25) PocketMC.Infrastructure/Instances/Providers/PaperProvider.cs:34— PaperProvider.GetAvailableVersionsAsync has cognitive complexity 25 (threshold 15). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaModMetadataService.ScanJarInternal (cognitive 25) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:73— JavaModMetadataService.ScanJarInternal has cognitive complexity 25 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
DashboardActionsViewModel.HandlePortReliabilityFailureAsync (cognitive 24) PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:447— DashboardActionsViewModel.HandlePortReliabilityFailureAsync has cognitive complexity 24 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SettingsAddonsVM.OpenAddonFolder (cognitive 24) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2094— SettingsAddonsVM.OpenAddonFolder has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsBackupsVM.LoadBackups (cognitive 24) PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:145— SettingsBackupsVM.LoadBackups has cognitive complexity 24 (threshold 15). Of this number, 23 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MainWindow.OnNavigating (cognitive 24) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:364— MainWindow.OnNavigating has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SafeZipExtractor.ExtractAsync (cognitive 24) PocketMC.Domain/Storage/SafeZipExtractor.cs:10— SafeZipExtractor.ExtractAsync has cognitive complexity 24 (threshold 15). None of this is in the body itself: all 24 points belong to one function literal inside it that branches (line 13). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ServerRebootSchedulerService.ExecuteScheduledRebootAsync (cognitive 24) PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs:313— ServerRebootSchedulerService.ExecuteScheduledRebootAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SimpleVoiceChatDetector.Detect (cognitive 24) PocketMC.Infrastructure/Networking/SimpleVoiceChatDetector.cs:30— SimpleVoiceChatDetector.Detect has cognitive complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.UpdateAiApiKeyUI (cognitive 23) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1053— AppSettingsPage.UpdateAiApiKeyUI has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WorldInventory.Resolve (cognitive 23) PocketMC.Application/Services/Instances/WorldInventory.cs:10— WorldInventory.Resolve has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceImportService.ResolveSoftwareProvider (cognitive 23) PocketMC.Infrastructure/Instances/InstanceImportService.cs:881— InstanceImportService.ResolveSoftwareProvider has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ServerProcess.AppendOutput (cognitive 23) PocketMC.Infrastructure/Instances/ServerProcess.cs:389— ServerProcess.AppendOutput has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceUpdateApplier.ApplyAsync (cognitive 23) PocketMC.Infrastructure/Instances/Updates/InstanceUpdateApplier.cs:51— InstanceUpdateApplier.ApplyAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiscordRpcService.BuildServerPresence (cognitive 23) PocketMC.Infrastructure/Social/DiscordRpcService.cs:251— DiscordRpcService.BuildServerPresence has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerLifecycleService.StartAsync (cognitive 22) PocketMC.Desktop/Features/Instances/Services/ServerLifecycleService.cs:83— ServerLifecycleService.StartAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayerManagementViewModel.LoadJavaGamemodeAsync (cognitive 22) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:545— PlayerManagementViewModel.LoadJavaGamemodeAsync has cognitive complexity 22 (threshold 15). Of this number, 12 points are the body's own statements and 10 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsAddonsVM.BuildPocketminePluginList (cognitive 22) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:878— SettingsAddonsVM.BuildPocketminePluginList has cognitive complexity 22 (threshold 15). Of this number, 19 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MainWindow.MainWindow_Closing (cognitive 22) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:626— MainWindow.MainWindow_Closing has cognitive complexity 22 (threshold 15). Of this number, 17 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CurseForgeService.GetLatestVersionAsync (cognitive 22) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:235— CurseForgeService.GetLatestVersionAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaModMetadataService.EnumerateActiveTomlLines (cognitive 22) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:951— JavaModMetadataService.EnumerateActiveTomlLines has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayerManagementViewModel.OnOutputLine (cognitive 21) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:1108— PlayerManagementViewModel.OnOutputLine has cognitive complexity 21 (threshold 15). Of this number, 14 points are the body's own statements and 7 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RemoteControlSettingsViewModel.SaveUser (cognitive 21) REDACTED:171— RemoteControlSettingsViewModel.SaveUser has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TunnelPage.RefreshStatusAsync (cognitive 21) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:181— TunnelPage.RefreshStatusAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppNavigationService.NavigateBack (cognitive 21) PocketMC.Desktop/Infrastructure/AppNavigationService.cs:176— AppNavigationService.NavigateBack has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SimpleVoiceChatConfigService.PatchProperty (cognitive 21) PocketMC.Application/Services/Networking/SimpleVoiceChatProperties.cs:166— SimpleVoiceChatConfigService.PatchProperty has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OllamaProvider.ExtractContent (cognitive 21) REDACTED:103— OllamaProvider.ExtractContent has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OneDriveBackupProvider.ListBackupsAsync (cognitive 21) PocketMC.Infrastructure/Backups/Providers/OneDriveBackupProvider.cs:233— OneDriveBackupProvider.ListBackupsAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiscordRpcService.BuildOnlineStateText (cognitive 21) PocketMC.Infrastructure/Social/DiscordRpcService.cs:345— DiscordRpcService.BuildOnlineStateText has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity· api (cognitive 21) · ×1
api (cognitive 21) PocketMC.RemoteControl/Web/app.js:147— api has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (10 pts), boolean chains 8, error handling 1 (2 pts), ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayerManagementPage.MainTabControl_SelectionChanged (cognitive 20) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:110— PlayerManagementPage.MainTabControl_SelectionChanged has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MinecraftMotdConverter.AddTextRuns (cognitive 20) PocketMC.Desktop/Features/Settings/MinecraftMotdConverter.cs:164— MinecraftMotdConverter.AddTextRuns has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaSetupPage.ScanRuntimes (cognitive 20) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:435— JavaSetupPage.ScanRuntimes has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayitSetupWizardDialog.UpdateStepVisuals (cognitive 20) PocketMC.Desktop/Features/Tunnel/PlayitSetupWizardDialog.xaml.cs:78— PlayitSetupWizardDialog.UpdateStepVisuals has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppDialog.ShowResult (cognitive 20) PocketMC.Desktop/Infrastructure/AppDialog.cs:41— AppDialog.ShowResult has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModpackParser.ParseCurseForgePackAsync (cognitive 20) PocketMC.Application/Services/Mods/ModpackParser.cs:193— ModpackParser.ParseCurseForgePackAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsManager.Normalize (cognitive 20) PocketMC.Infrastructure/Configuration/SettingsManager.cs:351— SettingsManager.Normalize has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ServerProcess.UpdatePlayerCount (cognitive 20) PocketMC.Infrastructure/Instances/ServerProcess.cs:497— ServerProcess.UpdatePlayerCount has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PluginBrowserPage.PluginBrowserPage.ctor (cognitive 19) PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:60— PluginBrowserPage.PluginBrowserPage.ctor has cognitive complexity 19 (threshold 15). Of this number, 16 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MinecraftMotdConverter.ParseJsonMotd (cognitive 19) PocketMC.Desktop/Features/Settings/MinecraftMotdConverter.cs:197— MinecraftMotdConverter.ParseJsonMotd has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerSettingsPage.MainTabControl_SelectionChanged (cognitive 19) PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:161— ServerSettingsPage.MainTabControl_SelectionChanged has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellVisualService.RequestMicaUpdate (cognitive 19) PocketMC.Desktop/Features/Shell/ShellVisualService.cs:49— ShellVisualService.RequestMicaUpdate has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsManager.Load (cognitive 19) PocketMC.Infrastructure/Configuration/SettingsManager.cs:55— SettingsManager.Load has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceImportService.RegisterRestoredAddonAsync (cognitive 19) PocketMC.Infrastructure/Instances/InstanceImportService.cs:772— InstanceImportService.RegisterRestoredAddonAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FabricProvider.GetAvailableVersionsAsync (cognitive 19) PocketMC.Infrastructure/Instances/Providers/FabricProvider.cs:31— FabricProvider.GetAvailableVersionsAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CurseForgeService.GetLatestVersionWithProjectInfoAsync (cognitive 19) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:416— CurseForgeService.GetLatestVersionWithProjectInfoAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
(anonymous) (cognitive 19) PocketMC.RemoteControl/Web/app.js:1297— (anonymous) has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (7 pts), boolean chains 6, other 5, error handling 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
renderFilesList (cognitive 19) PocketMC.RemoteControl/Web/app.js:1552— renderFilesList has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9, boolean chains 5, ternaries 4, error handling 1. Most of this is not in the body itself: 6 of the 19 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 1564, 1591, 1611, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ConsoleLogHistoryService.ReadTailLinesAsync (cognitive 18) PocketMC.Desktop/Features/Console/ConsoleLogHistoryService.cs:162— ConsoleLogHistoryService.ReadTailLinesAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MainWindow.WmGetMinMaxInfo (cognitive 18) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:1030— MainWindow.WmGetMinMaxInfo has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
InstanceTunnelOrchestrator.SetTunnelAddress (cognitive 18) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:342— InstanceTunnelOrchestrator.SetTunnelAddress has cognitive complexity 18 (threshold 15). None of this is in the body itself: all 18 points belong to one function literal inside it that branches (line 344). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
VersionStringComparer.Compare (cognitive 18) PocketMC.Domain/Models/VersionStringComparer.cs:8— VersionStringComparer.Compare has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PocketmineProvider.GetAvailableVersionsAsync (cognitive 18) PocketMC.Infrastructure/Instances/Providers/PocketmineProvider.cs:39— PocketmineProvider.GetAvailableVersionsAsync has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
CurseForgeService.FileSupportsLoader (cognitive 18) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:76— CurseForgeService.FileSupportsLoader has cognitive complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DependencyResolverService.IsFileCompatibleWithEngine (cognitive 18) PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:90— DependencyResolverService.IsFileCompatibleWithEngine has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortPreflightService.TryReadGeyserNetworkSettings (cognitive 18) PocketMC.Infrastructure/Networking/PortPreflightService.cs:681— PortPreflightService.TryReadGeyserNetworkSettings has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortRecoveryService.IsPortUsedByOtherInstance (cognitive 18) PocketMC.Infrastructure/Networking/PortRecoveryService.cs:537— PortRecoveryService.IsPortUsedByOtherInstance has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhpProvisioningService.ProvisionInternalAsync (cognitive 18) PocketMC.Infrastructure/Php/PhpProvisioningService.cs:229— PhpProvisioningService.ProvisionInternalAsync has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DownloaderService.EnsurePlayitDownloadedAsync (cognitive 18) PocketMC.Infrastructure/Storage/DownloaderService.cs:201— DownloaderService.EnsurePlayitDownloadedAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RemoteStatusService.GetInstanceStatusAsync (cognitive 18) PocketMC.RemoteControl/Services/RemoteStatusService.cs:65— RemoteStatusService.GetInstanceStatusAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
PlayitHttpsTunnelProvider.WaitForPublicUrlAsync (cognitive 18) PocketMC.RemoteControl/Tunnels/PlayitHttpsTunnelProvider.cs:189— PlayitHttpsTunnelProvider.WaitForPublicUrlAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstanceCardViewModel.FormatRelativeTime (cognitive 17) PocketMC.Desktop/Features/Dashboard/InstanceCardViewModel.cs:611— InstanceCardViewModel.FormatRelativeTime has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SessionSummarizationService.ExecuteSummarizeAsync (cognitive 17) PocketMC.Desktop/Features/Intelligence/SessionSummarizationService.cs:109— SessionSummarizationService.ExecuteSummarizeAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServerSettingsPage.ServerSettingsPage_PreviewKeyDown (cognitive 17) PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:339— ServerSettingsPage.ServerSettingsPage_PreviewKeyDown has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsAddonsVM.UpdateAllAddonsAsync (cognitive 17) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1782— SettingsAddonsVM.UpdateAllAddonsAsync has cognitive complexity 17 (threshold 15). Of this number, 13 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
AppSettingsPage.LoadSettingsIntoUI (cognitive 17) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:169— AppSettingsPage.LoadSettingsIntoUI has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppSettingsPage.UpdateLocalOllamaControlsVisibility (cognitive 17) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:1104— AppSettingsPage.UpdateLocalOllamaControlsVisibility has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortsMapPage.ExecuteEditPort (cognitive 17) PocketMC.Desktop/Features/Tunnel/PortsMapPage.xaml.cs:161— PortsMapPage.ExecuteEditPort has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TunnelPage.BtnDeleteAgent_Click (cognitive 17) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:983— TunnelPage.BtnDeleteAgent_Click has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MarkdownConfig.RenderToHtml (cognitive 17) PocketMC.Desktop/Infrastructure/MarkdownConfig.cs:12— MarkdownConfig.RenderToHtml has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SemanticVersionHelper.ConvertMavenRangeToNpm (cognitive 17) PocketMC.Domain/Models/SemanticVersionHelper.cs:33— SemanticVersionHelper.ConvertMavenRangeToNpm has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CloudBackupService.UploadBackupToEnabledProvidersAsync (cognitive 17) PocketMC.Infrastructure/Backups/CloudBackupService.cs:14— CloudBackupService.UploadBackupToEnabledProvidersAsync has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BedrockAddonInstaller.DeletePackAsync (cognitive 17) PocketMC.Infrastructure/Mods/BedrockAddonInstaller.cs:267— BedrockAddonInstaller.DeletePackAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortProbeService.Probe (cognitive 17) PocketMC.Infrastructure/Networking/PortProbeService.cs:33— PortProbeService.Probe has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayitAgentService.TryImportLegacyTomlConnection (cognitive 17) PocketMC.Infrastructure/Tunnel/PlayitAgentService.cs:532— PlayitAgentService.TryImportLegacyTomlConnection has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlayitApiClient.GetAgentRundataAsync (cognitive 17) PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs:346— PlayitApiClient.GetAgentRundataAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TunnelService.ResolveTunnelAsync (cognitive 17) PocketMC.Infrastructure/Tunnel/TunnelService.cs:127— TunnelService.ResolveTunnelAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
app.refreshEverything (cognitive 17) PocketMC.RemoteControl/Web/app.js:303— app.refreshEverything has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 3, error handling 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 17) PocketMC.RemoteControl/Web/app.js:1098— (anonymous) has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (11 pts), error handling 2 (3 pts), boolean chains 2, ternaries 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DashboardActionsViewModel.StartServer (cognitive 16) PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:85— DashboardActionsViewModel.StartServer has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsAddonsVM.UpdateServerPropertiesTexturepackRequired (cognitive 16) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:586— SettingsAddonsVM.UpdateServerPropertiesTexturepackRequired has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsAddonsVM.ApplyFiltersAndSort (cognitive 16) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1994— SettingsAddonsVM.ApplyFiltersAndSort has cognitive complexity 16 (threshold 15). None of this is in the body itself: all 16 points belong to 7 function literals inside it that branch (lines 1996, 2003, 2025, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
MainWindow.ApplyDynamicWindowSize (cognitive 16) PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:115— MainWindow.ApplyDynamicWindowSize has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PlayitConsoleWindow.OnFlushTimerTick (cognitive 16) PocketMC.Desktop/Features/Tunnel/PlayitConsoleWindow.xaml.cs:157— PlayitConsoleWindow.OnFlushTimerTick has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AddonUpdateCheckDialogWindow.Window_Loaded (cognitive 16) PocketMC.Desktop/Infrastructure/AddonUpdateCheckDialogWindow.xaml.cs:72— AddonUpdateCheckDialogWindow.Window_Loaded has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AddonUpdateDialogWindow.BtnUpdate_Click (cognitive 16) PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:135— AddonUpdateDialogWindow.BtnUpdate_Click has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
PocketmineProvider.DownloadSoftwareAsync (cognitive 16) PocketMC.Infrastructure/Instances/Providers/PocketmineProvider.cs:77— PocketmineProvider.DownloadSoftwareAsync has cognitive complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AddonUpdateService.CheckForUpdateFromEntryAsync (cognitive 16) PocketMC.Infrastructure/Marketplace/AddonUpdateService.cs:97— AddonUpdateService.CheckForUpdateFromEntryAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataProtector.Unprotect (cognitive 16) PocketMC.Infrastructure/Security/DataProtector.cs:42— DataProtector.Unprotect has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
FunctionTooLong: app.renderStatus PocketMC.RemoteControl/Web/app.js:461— FunctionTooLong — renderStatus runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Near-duplicate member pair (56 shared lines) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:968— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:968-1108 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1296-1444 — These two members are variants of one another: 56 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (125 corresponding lines) · ×1
Edited copy of a member (125 corresponding lines) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:217— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:217-341 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:344-481 — These two members are one piece of code written twice and then edited apart: 125 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (92 corresponding lines) · ×1
Edited copy of a member (92 corresponding lines) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:49— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:49-140 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:136-243 — These two members are one piece of code written twice and then edited apart: 92 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (70 corresponding lines) · ×1
Edited copy of a member (70 corresponding lines) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:32— PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:32-104 | PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:30-99 — These two members are one piece of code written twice and then edited apart: 70 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (73 corresponding lines) · ×1
Edited copy of a member (73 corresponding lines) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:193— PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:193-265 | PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:268-340 — These two members are one piece of code written twice and then edited apart: 73 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (83 corresponding lines) · ×1
Edited copy of a member (83 corresponding lines) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:2202— PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:2202-2288 | PocketMC.Desktop/Features/Setup/RootDirectorySetupPage.xaml.cs:135-217 — These two members are one piece of code written twice and then edited apart: 83 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (46 corresponding lines) · ×1
Edited copy of a member (46 corresponding lines) PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:121— PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:121-166 | PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:145-191 — These two members are one piece of code written twice and then edited apart: 46 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×1
Edited copy of a member (36 corresponding lines) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:547— PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:547-593 | PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:600-635 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (51 corresponding lines) · ×1
Edited copy of a member (51 corresponding lines) PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs:688— PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs:688-758 | PocketMC.Infrastructure/Tunnel/PlayitApiClient.cs:1104-1154 — These two members are one piece of code written twice and then edited apart: 51 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×1
Edited copy of a member (31 corresponding lines) PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:904— PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:904-934 | PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:937-969 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (35 corresponding lines) · ×1
Edited copy of a member (35 corresponding lines) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:554— PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:554-588 | PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:687-724 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (39 corresponding lines) · ×1
Edited copy of a member (39 corresponding lines) PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:34— PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:34-77 | PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:106-144 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (37 corresponding lines) · ×1
Edited copy of a member (37 corresponding lines) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:145— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:145-188 | PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:191-227 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (25 corresponding lines) · ×1
Edited copy of a member (25 corresponding lines) PocketMC.Infrastructure/Marketplace/MarketplaceArchiveInspector.cs:12— PocketMC.Infrastructure/Marketplace/MarketplaceArchiveInspector.cs:12-44 | PocketMC.Infrastructure/Marketplace/MarketplaceArchiveInspector.cs:47-71 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 29+ corresponding lines) · ×1
Edited copies of one member (3 members, 29+ corresponding lines) PocketMC.Infrastructure/Players/ServerStateFileService.cs:199— PocketMC.Infrastructure/Players/ServerStateFileService.cs:199-227 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:230-260 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:263-297 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 29 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 27+ corresponding lines) · ×1
Edited copies of one member (3 members, 27+ corresponding lines) PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:412— PocketMC.Infrastructure/Backups/Providers/GoogleDriveBackupProvider.cs:412-442 | PocketMC.Infrastructure/Telemetry/TelemetryService.cs:369-395 | PocketMC.Infrastructure/Tunnel/PlayitPartnerProvisioningClient.cs:170-201 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 27 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:160— PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:160-183 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:204-227 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 17+ corresponding lines) · ×1
Edited copies of one member (3 members, 17+ corresponding lines) PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:200— PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:200-217 | PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:220-236 | PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:239-255 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 16+ corresponding lines) · ×1
Edited copies of one member (3 members, 16+ corresponding lines) PocketMC.RemoteControl/Services/RemoteInstanceControlService.cs:23— PocketMC.RemoteControl/Services/RemoteInstanceControlService.cs:23-39 | PocketMC.RemoteControl/Services/RemoteInstanceControlService.cs:42-57 | PocketMC.RemoteControl/Services/RemoteInstanceControlService.cs:60-75 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 13+ corresponding lines) · ×1
Edited copies of one member (3 members, 13+ corresponding lines) PocketMC.Infrastructure/Backups/BackupService.cs:645— PocketMC.Infrastructure/Backups/BackupService.cs:645-657 | PocketMC.Infrastructure/Java/JavaProvisioningService.cs:276-288 | PocketMC.Infrastructure/Marketplace/MarketplaceFileInstaller.cs:118-130 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 8+ corresponding lines) · ×1
Edited copies of one member (4 members, 8+ corresponding lines) PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:134— PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:134-142 | PocketMC.Domain/Models/BackupMetadata.cs:147-154 | PocketMC.Infrastructure/Backups/BackupService.cs:242-250 | PocketMC.Infrastructure/Marketplace/AddonManifestService.cs:446-454 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×1
Edited copy of a member (4 corresponding lines) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:154— PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:154-157 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:198-201 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (53–57 lines × 2) PocketMC.Infrastructure/Marketplace/ModrinthService.cs:580— PocketMC.Infrastructure/Marketplace/ModrinthService.cs:580-632 | PocketMC.Infrastructure/Marketplace/ModrinthService.cs:640-696 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Marketplace/ModrinthService.cs:580` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (41 lines × 2) PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:130— PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:130-170 | PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:299-339 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs` and `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:130` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs:340` calls `Contains` and `PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs:171` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (42 lines × 2) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:109— PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:109-150 | PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:104-145 — before extracting anything, compare `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs` and `PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 109 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:109` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (39 lines × 2) PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:2218— PocketMC.Desktop/Features/Setup/AppSettingsPage.xaml.cs:2218-2256 | PocketMC.Desktop/Features/Setup/RootDirectorySetupPage.xaml.cs:151-189 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (38 lines × 2) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:67— PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:67-104 | PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:62-99 — before extracting anything, compare `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs` and `PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 109 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:67` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:64` calls `TryParseVersion` and `PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:60` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (36 lines × 2) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:168— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:168-203 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:182-217 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (30 lines × 2) PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:633— PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:633-662 | PocketMC.Desktop/Features/Players/PlayerManagementViewModel.cs:1127-1156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (31–32 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:304— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:304-335 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:443-473 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:304` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29 lines × 2) PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:112— PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:112-140 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:163-191 — before extracting anything, compare `PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs` and `PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (28 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1047— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1047-1074 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1385-1412 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1047` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (28–29 lines × 2) PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:37— PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:37-64 | PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs:34-62 — before extracting anything, compare `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs` and `PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 109 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (27 lines × 3) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:520— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:520-546 | PocketMC.Infrastructure/Players/PlayerDataService.cs:441-467 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:343-369 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (25 lines × 2) PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:381— PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:381-405 | PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:410-434 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs:381` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:243— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:243-264 | PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:364-385 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (23–24 lines × 2) PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:1021— PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:1021-1044 | PocketMC.Infrastructure/Networking/PortPreflightService.cs:757-779 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (23 lines × 2) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:494— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:494-516 | PocketMC.Infrastructure/Players/PlayerDataService.cs:407-429 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (21 lines × 2) PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:548— PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:548-568 | PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:601-621 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:14— PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:14-33 | REDACTED:20-39 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:14` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18–20 lines × 3) PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:13— PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogWindow.xaml.cs:13-32 | PocketMC.Desktop/Features/WhatsNew/WhatsNewWindow.xaml.cs:21-38 | REDACTED:19-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (18–19 lines × 2) PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:72— PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs:72-89 | PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs:173-191 — before extracting anything, compare `PocketMC.Desktop/Features/Marketplace/AddonInstallDialogWindow.xaml.cs` and `PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (17–18 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1999— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1999-2015 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2021-2038 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1999` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2040` calls `OrderBy`, `ThenBy` and `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:2017` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 3) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96-108 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:124-136 | PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs:657-669 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:96` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (16–17 lines × 2) PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:89— PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:89-105 | PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:269-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Dashboard/DashboardActionsViewModel.cs:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 4) PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:73— PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:73-83 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:128-138 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:101-111 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:156-166 — before extracting anything, compare `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs` and `PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 123 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:73` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 2) PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:538— PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:538-551 | PocketMC.Desktop/Features/Tunnel/TunnelPage.xaml.cs:672-684 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 4) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:525— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:525-536 | PocketMC.Infrastructure/Players/PlayerDataService.cs:446-457 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:348-359 | PocketMC.Infrastructure/Players/WhitelistService.cs:288-299 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:525` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 2) PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1034— PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1034-1045 | PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1373-1383 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1034` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 5) REDACTED:639— REDACTED:639-645 | REDACTED:705-711 | REDACTED:759-765 | REDACTED:781-787 | REDACTED:815-821 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 4) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:912— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:912-921 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:181-189 | PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs:195-203 | PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:200-208 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:912` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:309— PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:309-316 | PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:336-343 | PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:430-438 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 4) REDACTED:87— REDACTED:87-91 | REDACTED:95-99 | REDACTED:103-107 | REDACTED:112-116 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 3) PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:961— PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:961-971 | PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:243-253 | PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs:116-126 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 4) PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:549— PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:549-554 | PocketMC.Infrastructure/Players/PlayerDataService.cs:432-437 | PocketMC.Infrastructure/Players/ServerStateFileService.cs:334-339 | PocketMC.Infrastructure/Players/WhitelistService.cs:279-284 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Off the main sequence: PocketMC.Domain PocketMC.Domain/PocketMC.Domain.csproj:1— PocketMC.Domain: abstractness 0.03, instability 0.00, distance 0.97 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
IC1 · Incompleteness & stubs· Guard cannot change the result · ×1
Guard cannot change the result — returns what the code already falls through to PocketMC.Desktop/Features/Console/LogLineClassifier.cs:79— 1 guard above `return LogLevel.Info;` also returns `LogLevel.Info`, so no input can make it matter. Implement the distinction that was intended, or delete the guard.
IC1 · Incompleteness & stubs· Both branches open with the same statements · ×1
Both branches open with the same statements — the condition does not decide them PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:156— The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently.
Hollow method — returns a constant without doing the work PocketMC.Desktop/Features/Tunnel/InstanceTunnelOrchestrator.cs:490— `BuildSimpleVoiceChatPromptMessage` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
S1 · Web-Security Posture· Password key derivation is priced too cheaply · ×1
Password key derivation is priced too cheaply PocketMC.RemoteControl/Services/RemoteAuthenticationService.cs:10— `Iterations` fixes PBKDF2-SHA-256 at 100,000 iterations. A key-derivation function's only defence is the cost of ONE guess, and that cost is this number — the algorithm choice does not set it. Current OWASP guidance is 1,300,000 PBKDF2 iterations with HMAC-SHA1, 600,000 with SHA-256 and 210,000 with SHA-512; scrypt at N=2^17, r=8, p=1 (or an equivalent N·r·p product); Argon2id at 19 MiB of memory and 2 iterations (or an equivalent row); bcrypt at a work factor of at least 10. This figure divides the attacker's work by a factor of tens or hundreds against the same stolen hash, on hardware they already own. Where what is derived is short or low-entropy — a PIN, a numeric parental code, a four-character token — the whole keyspace falls in the time this parameter buys, and no salt or constant-time comparison changes that. Raise the count to the current published figure for the PRF you use, measure it on the slowest hardware that must run it (a target of roughly 100 ms per derivation is the usual budget), and read the value from configuration so a deployment can raise it again without a rebuild. Where the derived value must interoperate with a format someone else fixed, the count cannot move — derive a SEPARATE value for anything you own rather than inheriting the external format's price.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×1
Disposable created and abandoned in the method that made it PocketMC.Infrastructure/Backups/Providers/DropboxBackupProvider.cs:136— `client` is a `HttpClient`, which implements `IDisposable`, and it is created here (line 136). Every use of it in `ConnectAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var client = …;`), which releases it at the end of the scope on every path including a throw.
X24 · Document value interpolated into markup unescaped· Untrusted text written into markup unescaped · ×1
Untrusted text written into markup unescaped PocketMC.RemoteControl/Web/app.js:425— `playerCount` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Duplicated predicate PocketMC.Desktop/Features/Marketplace/AddonInstallRowViewModel.cs:43— `!string.IsNullOrEmpty(StatusText) || IsDownloading` appears character-identically in 2 files — PocketMC.Desktop/Features/Marketplace/AddonInstallRowViewModel.cs, PocketMC.Desktop/Infrastructure/AddonUpdateDialogWindow.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/CurseForgeService.cs:171— `!string.IsNullOrEmpty(mcVersion) && mcVersion != "*"` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/CurseForgeService.cs, PocketMC.Infrastructure/Marketplace/ModrinthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:153— `!string.IsNullOrWhiteSpace(customDir) && customDir != defaultDir && Directory.Exists(customDir)` appears character-identically in 2 files — PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs:177— `!string.IsNullOrWhiteSpace(customDir) && fi.FullName.StartsWith(customDir, StringComparison.OrdinalIgnoreCase)` appears character-identically in 2 files — PocketMC.Desktop/Features/Settings/SettingsBackupsVM.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:813— `!string.IsNullOrWhiteSpace(instancePath) && Directory.Exists(instancePath)` appears character-identically in 2 files — PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs, PocketMC.Infrastructure/Diagnostics/PortDiagnosticsSnapshotBuilder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs:173— `FindAncestor<ScrollBar>(source) != null || FindAncestor<ComboBox>(source)?.IsDropDownOpen == true || FindAncestor<Popup>(source) != null || …` appears character-identically in 2 files — PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs, PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:126— `MainTabControl.SelectedIndex >= 0 && MainTabControl.SelectedIndex < SidebarList.MenuItems.Count` appears character-identically in 2 files — PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs, PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:47— `SidebarList.MenuItems.Count > 0 && SidebarList.MenuItems[0] is Wpf.Ui.Controls.NavigationViewItem firstItem` appears character-identically in 2 files — PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs, PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:117— `SidebarList.MenuItems[i] is Wpf.Ui.Controls.NavigationViewItem item && item.IsActive` appears character-identically in 2 files — PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs, PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:892— `_isForwardingMouseWheel || e.OriginalSource is not DependencyObject source` appears character-identically in 5 files — PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs, PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs, PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs, PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:198— `activeScrollViewer == null || activeScrollViewer.ScrollableHeight <= 0` appears character-identically in 2 files — PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs, PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/MarketplaceArchiveInspector.cs:127— `archive.GetEntry("plugin.yml") != null || archive.GetEntry("paper-plugin.yml") != null` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/MarketplaceArchiveInspector.cs, PocketMC.Infrastructure/Mods/JavaModMetadataService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogService.cs:30— `dialog.ShowDialog() == true && !string.IsNullOrWhiteSpace(dialog.ApiKey)` appears character-identically in 3 files — PocketMC.Desktop/Features/Marketplace/CurseForgeApiKeyDialogService.cs, PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs, PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:634— `e.Key == Key.F && Keyboard.Modifiers == ModifierKeys.Control` appears character-identically in 3 files — PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs, PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs, PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs:185— `e.Key == Key.F5 || (e.Key == Key.R && Keyboard.Modifiers == ModifierKeys.Control)` appears character-identically in 5 files — PocketMC.Desktop/Features/Dashboard/DashboardPage.xaml.cs, PocketMC.Desktop/Features/Marketplace/MapBrowserPage.xaml.cs, PocketMC.Desktop/Features/Marketplace/PluginBrowserPage.xaml.cs, PocketMC.Desktop/Features/Shell/MainWindow.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs:550— `element.TryGetProperty(propertyName, out JsonElement property) && property.ValueKind == JsonValueKind.String` appears character-identically in 3 files — PocketMC.Infrastructure/Players/BedrockPlayerDataService.cs, PocketMC.Infrastructure/Players/PlayerDataService.cs, PocketMC.Infrastructure/Players/ServerStateFileService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1291— `entry.FileName.Equals(item.FileName, StringComparison.OrdinalIgnoreCase) || entry.FileName.Equals(Path.GetFileName(item.RelativePath), Strin…` appears character-identically in 2 files — PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs, PocketMC.Infrastructure/Mods/AddonUpdateCheckService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:118— `fn.Contains("fabric") || (fn.Contains("forge") && !fn.Contains("neoforge"))` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs, PocketMC.Infrastructure/Marketplace/ModrinthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:97— `fn.Contains("fabric") || fn.Contains("forge") || fn.Contains("neoforge") || fn.Contains("quilt")` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs, PocketMC.Infrastructure/Marketplace/ModrinthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:111— `fn.Contains("fabric") || fn.Contains("neoforge")` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs, PocketMC.Infrastructure/Marketplace/ModrinthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:104— `fn.Contains("forge") || fn.Contains("neoforge")` appears character-identically in 2 files — PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs, PocketMC.Infrastructure/Marketplace/ModrinthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs:936— `focused is System.Windows.Controls.Primitives.TextBoxBase || focused is System.Windows.Controls.PasswordBox` appears character-identically in 3 files — PocketMC.Desktop/Features/InstanceCreation/NewInstancePage.xaml.cs, PocketMC.Desktop/Features/Instances/ImportExport/InstanceExportPage.xaml.cs, PocketMC.Desktop/Features/Instances/ImportExport/InstanceImportPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs:96— `idx != -1 && MainTabControl.SelectedIndex != idx` appears character-identically in 2 files — PocketMC.Desktop/Features/Players/PlayerManagementPage.xaml.cs, PocketMC.Desktop/Features/Settings/ServerSettingsPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1173— `int.TryParse(parts[0], out int major) && int.TryParse(parts[1], out int minor)` appears character-identically in 2 files — PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs, PocketMC.Infrastructure/Mods/PluginScanner.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs:73— `isRecommended || !version.Contains("-beta")` appears character-identically in 2 files — PocketMC.Infrastructure/Instances/Providers/ForgeProvider.cs, PocketMC.Infrastructure/Instances/Providers/NeoForgeProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Silent fallback default in catch PocketMC.Desktop/Features/Console/ConsoleLogFilter.cs:27— `MatchesSearch` swallows `ArgumentException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Console/LogLineClassifier.cs:94— `IsChatOrPlayerEvent` swallows `RegexMatchTimeoutException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Dashboard/InstanceCardViewModel.cs:189— `ShowVoiceChatBadge` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Dashboard/InstanceCardViewModel.cs:264— `HasGeyser` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Intelligence/SessionSummarizationService.cs:66— `GetLatestSummary` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:97— `Read` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Intelligence/SummaryStorageService.cs:117— `Delete` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Mods/AddonIconService.cs:65— `GetCachedRemoteIconAsync` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Mods/AddonIconService.cs:98— `GetLocalIconAsync` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Mods/AddonIconService.cs:119— `GetIconFromBytes` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/MinecraftMotdConverter.cs:280— `ResolveColor` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/ServerCloudBackupViewModel.cs:234— `IsProviderConnectedAsync` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:408— `BuildPortRequestsForSettings` swallows every exception into `return Array.Empty<PortCheckRequest>();` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1160— `IsApiVersionIncompatible` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/SettingsAdvancedVM.cs:177— `LoadRawProperties` swallows every exception and sets `RawServerProperties = string.Empty;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Settings/SettingsGeneralVM.cs:97— `LoadIcon` swallows every exception and sets `ServerIcon = null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:1018— `GetDirectorySizeMb` swallows every exception into `return 0;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:751— `GenerateQrCode` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:933— `Edit` swallows every exception and sets `Password = "";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/AccentColorService.cs:141— `GetSystemAccentColor` swallows every exception into `return FallbackSystemAccent;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:157— `IsTemporaryPath` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/ShellStartupCoordinator.cs:356— `WriteStartupFailureLog` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/ShellVisualService.cs:213— `ApplyFakeMicaLayerWithCustomImage` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:140— `ApplyCustomImage` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch PocketMC.Desktop/Features/Shell/WallpaperMicaService.cs:203— `CreatePreBlurredBitmap` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
+ 6 more in this group — see findings.md.
S1 · Web-Security Posture· No inbound model validation detected · ×24
No inbound model validation detected — No ModelState/[ApiController]/FluentValidation signal — inbound payloads reach handlers unvalidated. (−2.0 on this card.)
No inbound model validation detected REDACTED:246— `MapPost("/login")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:349— `MapPost("/logout")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:357— `MapGet("/status")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:359— `MapGet("/instances")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:371— `MapGet("/instances/{instanceId:guid}/status")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:382— `MapPost("/instances/{instanceId:guid}/start")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:394— `MapPost("/instances/{instanceId:guid}/stop")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:406— `MapPost("/instances/{instanceId:guid}/restart")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:418— `MapGet("/instances/{instanceId:guid}/console/history")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:431— `MapPost("/instances/{instanceId:guid}/console/command")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:462— `MapGet("/instances/{instanceId:guid}/players")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:482— `MapPost($"/instances/{{instanceId:guid}}/players/{{name}}/{action}")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:495— `MapGet("/instances/{instanceId:guid}/properties")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:533— `MapPut("/instances/{instanceId:guid}/properties")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:573— `MapGet("/instances/{instanceId:guid}/addons")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:590— `MapPost("/instances/{instanceId:guid}/addons/uninstall")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:637— `MapGet("/instances/{instanceId:guid}/files")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:703— `MapGet("/instances/{instanceId:guid}/files/content")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:757— `MapPut("/instances/{instanceId:guid}/files/content")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:779— `MapDelete("/instances/{instanceId:guid}/files")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:813— `MapPost("/instances/{instanceId:guid}/files/upload")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:871— `MapGet("/instances/{instanceId:guid}/backups")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
No inbound model validation detected REDACTED:951— `MapPost("/instances/{instanceId:guid}/backups")` binds request input and nothing in this codebase validates it — no [ApiController]/ModelState check, validator or guard.
redundant comment PocketMC.Application/Services/Instances/InstanceManager.cs:64— "Apply default server icon" repeats the code it sits on: 4 of its 4 words (apply, default, server, icon) are already in `ApplyDefaultServerIcon(newInstancePath);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop.Tests/Features/Mods/ModpackServiceTests.cs:345— "No key set in app settings" repeats the code it sits on: 4 of its 5 words (key, set, app, settings) are already in `_appState.ApplySettings(new AppSettings { AppRootPath = _tempDir, CurseForgeApiKey = null });`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/AssemblyInfo.cs:5— "where theme specific resource dictionaries are located" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/AssemblyInfo.cs:6— "(used if a resource is not found in the page, or application resource dictionaries)" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/AssemblyInfo.cs:8— "where the generic resource dictionary is located" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/AssemblyInfo.cs:9— "(used if a resource is not found in the page, app, or any theme specific resource dictionaries)" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/Features/Console/ServerConsolePage.xaml.cs:373— "Auto-scroll to bottom of the RichTextBox" repeats the code it sits on: 5 of its 6 words (auto, scroll, rich, text, box) are already in `if (addedToFiltered && LogRichTextBox != null && (BtnAutoScroll?.IsChecked ?? true))`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/Features/Settings/SettingsAddonsVM.cs:1024— "API version check" repeats the code it sits on: 3 of its 3 words (api, version, check) are already in `if (!string.IsNullOrEmpty(metadata.ApiVersion) && !string.IsNullOrEmpty(_metadata.MinecraftVersion))`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Desktop/Features/Setup/JavaSetupPage.xaml.cs:549— 6 comments in this file only repeat the code they sit on (lines 549, 578, 630, 705, 758, 784), for example "────────────────────────────────────────────── Download Missing (Java + PHP) ──────────────────────────────────────────────". Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment REDACTED:631— "Generate QR Codes" repeats the code it sits on: 3 of its 3 words (generate, qr, codes) are already in `LocalQrImage = GenerateQrCode(LocalUrl);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Domain/Storage/FileUtils.cs:122— "Awaiting recursive call" repeats the code it sits on: 3 of its 3 words (awaiting, recursive, call) are already in `await CopyDirectoryRecursiveAsync(dir, destSubDir, totalBytes, copiedBytes, progress);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Infrastructure.Tests/Mods/JavaModMetadataServiceTests.cs:472— "Quilt client environment" repeats the code it sits on: 3 of its 3 words (quilt, client, environment) are already in `string jsonClient = @"{ ""quilt_loader"": { ""id"": ""qc"", ""environment"": ""client"", ""metadata"": { ""name"": ""QCl …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.Infrastructure.Tests/Mods/JavaModMetadataServiceTests.cs:483— "Quilt server environment" repeats the code it sits on: 3 of its 3 words (quilt, server, environment) are already in `string jsonServer = @"{ ""quilt_loader"": { ""id"": ""qs"", ""environment"": ""server"", ""metadata"": { ""name"": ""QSe …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment PocketMC.RemoteControl/Web/app.js:1211— "Mobile menu toggle" repeats the code it sits on: 3 of its 3 words (mobile, menu, toggle) are already in `const mobileMenuToggle = document.getElementById('mobileMenuToggle');`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
Subsumed condition operand PocketMC.Application/Services/Networking/SimpleVoiceChatProperties.cs:381— `text.EndsWith("\r\n", StringComparison.Ordinal)` can never decide this `||` — every value satisfying `text.EndsWith("\r\n", StringComparison.Ordinal)` also satisfies `text.EndsWith("\n", StringComparison.Ordinal)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:115— `line.Contains("gamemode", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `line.Contains("gamemode", StringComparison.OrdinalIgnoreCase)` also satisfies `line.Contains("mode", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:118— `line.Contains("/gma", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `line.Contains("/gma", StringComparison.OrdinalIgnoreCase)` also satisfies `line.Contains("/gm", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:119— `line.Contains("/gmc", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `line.Contains("/gmc", StringComparison.OrdinalIgnoreCase)` also satisfies `line.Contains("/gm", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:120— `line.Contains("/gms", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `line.Contains("/gms", StringComparison.OrdinalIgnoreCase)` also satisfies `line.Contains("/gm", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:121— `line.Contains("/gmsp", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `line.Contains("/gmsp", StringComparison.OrdinalIgnoreCase)` also satisfies `line.Contains("/gm", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Application/Services/Players/PlayerListParser.cs:167— `prefix.EndsWith("]:", StringComparison.Ordinal)` can never decide this `||` — every value satisfying `prefix.EndsWith("]:", StringComparison.Ordinal)` also satisfies `prefix.EndsWith(":", StringComparison.Ordinal)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:97— `fn.Contains("neoforge")` can never decide this `||` — every value satisfying `fn.Contains("neoforge")` also satisfies `fn.Contains("forge")`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Infrastructure/Marketplace/DependencyResolverService.cs:104— `fn.Contains("neoforge")` can never decide this `||` — every value satisfying `fn.Contains("neoforge")` also satisfies `fn.Contains("forge")`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Infrastructure/Marketplace/ModrinthService.cs:167— `fn.Contains("neoforge")` can never decide this `||` — every value satisfying `fn.Contains("neoforge")` also satisfies `fn.Contains("forge")`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Infrastructure/Marketplace/ModrinthService.cs:174— `fn.Contains("neoforge")` can never decide this `||` — every value satisfying `fn.Contains("neoforge")` also satisfies `fn.Contains("forge")`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Subsumed condition operand PocketMC.Infrastructure/Mods/JavaModMetadataService.cs:622— `cleanSection.StartsWith("mods.", StringComparison.OrdinalIgnoreCase)` can never decide this `||` — every value satisfying `cleanSection.StartsWith("mods.", StringComparison.OrdinalIgnoreCase)` also satisfies `cleanSection.StartsWith("mods", StringComparison.OrdinalIgnoreCase)`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Silent fallback default on parse failure PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:255— `LoadAll` falls back to `10` when `int.TryParse(cfg.ViewDistance, out var vd)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Desktop/Features/Settings/ServerSettingsViewModel.cs:527— `SaveConfigurations` falls back to `24` when `int.TryParse(Advanced.ScheduledRebootIntervalHours, out int srh) && srh > 0` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Desktop/Infrastructure/AppNavigationService.cs:184— `NavigateBack` returns `false` when `result.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Desktop/Infrastructure/AppNavigationService.cs:246— `NavigateForward` returns `false` when `result.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Domain/Models/SemanticVersionHelper.cs:20— `IsCompatible` returns `false` when `TryParseVersion(version, out var vParts)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Domain/Models/SemanticVersionHelper.cs:93— `SatisfiesCondition` returns `false` when `TryParseVersion(caretTargetStr, out var caretTarget)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Application/Services/Instances/ServerConfigurationService.cs:326— `TryGetPortPlusOne` falls back to `"19133"` when `int.TryParse(rawPort, out int parsedPort) && parsedPort < 65535` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Application/Services/Players/PlayerGamemodeLogParser.cs:279— `CreateCommandEvent` falls back to `string.Empty` when `match.Groups["target"].Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure PocketMC.Infrastructure/Instances/Providers/BedrockBdsProvider.cs:207— `Compare` falls back to `0` when `int.TryParse(p, out int n)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 27 significant file(s) lose their only recent owner: PocketMC.Infrastructure/Networking/PortRecoveryService.cs, PocketMC.Desktop/Infrastructure/MarkdownFlowDocumentConverter.cs, REDACTED, PocketMC.Application/Services/Networking/PortFailureMessageService.cs, PocketMC.Desktop/Features/Networking/PortConflictWindow.xaml.cs, PocketMC.Infrastructure/Instances/ServerDetectionService.cs, PocketMC.Infrastructure/Instances/Export/ExportZipWriter.cs, PocketMC.Desktop/Features/Console/ConsoleLogHistoryService.cs (+19 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 17 significant file(s) lose their only recent owner: PocketMC.Infrastructure/News/NewsService.cs, PocketMC.Infrastructure/Instances/Diagnostics/ServerCrashDetector.cs, PocketMC.Infrastructure/Configuration/SettingsBackupService.cs, PocketMC.Infrastructure/News/NewsModels.cs, PocketMC.Desktop/Features/Tunnel/PlayitConsoleWindow.xaml.cs, PocketMC.Infrastructure/Instances/ServerRebootSchedulerService.cs, PocketMC.Desktop/Features/Settings/MinecraftMotdConverter.cs, PocketMC.Desktop/Features/Tunnel/PlayitLogFormatter.cs (+9 more). Pair on, review, or document these before any departure.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×2
Projects may be oversized for their cohesion PocketMC.Desktop/PocketMC.Desktop.csproj:1— `PocketMC.Desktop` overshoots its size bounds (32543 LoC, 191 public types across 29 namespaces). 2 of 10 project(s) overshoot their size bounds, lowering Project Cohesion to 6.0/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
Projects may be oversized for their cohesion PocketMC.Infrastructure/PocketMC.Infrastructure.csproj:1— `PocketMC.Infrastructure` overshoots its size bounds (29087 LoC, 173 public types across 27 namespaces). 2 of 10 project(s) overshoot their size bounds, lowering Project Cohesion to 6.0/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No security response headers detected REDACTED:101— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
No app-layer HTTPS enforcement detected — No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
No app-layer HTTPS enforcement detected REDACTED:101— This web host's pipeline is composed here with no UseHttpsRedirection/UseHsts, and nothing says a reverse proxy terminates TLS in front of it.
Partial audit-trail evidence — An audit mechanism is present, but the trail is not yet complete — missing: a write-side hook (the one code path every change to the sensitive data flows through, recording who changed what), [Audited] per-entity coverage.
C4 · Data Retention· Partial data-retention evidence · ×1
Partial data-retention evidence — A retention mechanism is present, but the data-lifecycle is not yet complete — missing: an expiry limit — a declared maximum age / TTL after which the data is no longer kept, a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob).
No ADRs found PocketMC.Desktop/PocketMC.Desktop.csproj:4— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `PocketMC.Desktop/PocketMC.Desktop.csproj` makes this repository a deployable product (line 4).
Split PocketMC.Infrastructure PocketMC.Infrastructure/PocketMC.Infrastructure.csproj:1— `PocketMC.Infrastructure` overshoots its size bounds (29087 LoC, 173 public types across 27 namespaces). These parts reach the rest of the project only through its shared core (`(root)`, `Configuration`, `Http`, `Marketplace`, `OS`, `Security`), so they are the cleanest seams: `PocketMC.Infrastructure.Mods` (17 types in 11 files): 0 of 250 of its type references cross into a sibling namespace, and the rest of the project uses it 0 times and it uses the rest 79 times; `PocketMC.Infrastructure.Backups` (14 types in 11 files): 14 of 120 of its type references cross into a sibling namespace, and the rest of the project uses it 0 times and it uses the rest 48 times; `PocketMC.Infrastructure.Players` (13 types in 4 files): 0 of 91 of its type references cross into a sibling namespace, and the rest of the project uses it 0 times and it uses the rest 1 times. Extract each into its own project.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 7 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
No SAST REDACTED:7— No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 5 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation Directory.Packages.props:6— `Directory.Packages.props` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 210/480 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Nullable reference types not enabled everywhere — 4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions override nullable warnings — ~0.3 `!` suppressions per 1k syntax nodes — 61 suppression(s) across the 208261 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
Hand-rolled JSON/XML parsing via regex PocketMC.Infrastructure/Instances/ServerDetectionService.cs:145— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
doc comments repeat the names PocketMC.Application/Services/Networking/PortCheckRequest.cs:12— 0 of 64 documented parameters and 6 of 140 summaries in `PocketMC.Application` only repeat the member or parameter name (e.g. "Initializes a new port check request." for `PortCheckRequest`). Delete the restating tags, or add what the name does not say.
doc comments repeat the names PocketMC.Infrastructure/Networking/PortPreflightService.cs:35— 0 of 42 documented parameters and 3 of 141 summaries in `PocketMC.Infrastructure` only repeat the member or parameter name (e.g. "Initializes a new port preflight service." for `PortPreflightService`). Delete the restating tags, or add what the name does not say.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 1 file(s) — `PocketMC.Application/Services/Instances/InstanceOperationCoordinator.cs` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1e815-0501-775d-a74b-b9102cc5325f · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 3 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 224 · Warnings: 792 · Recommendations: 157 · Info: 24 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 17-11-2026 @ 05:57 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.