{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D14","name":"License Compliance","shortDescription":{"text":"License Compliance"},"helpUri":"https://codehealth.canine.dev/dimensions/D14"},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D30","name":"Dependency Vulnerabilities","shortDescription":{"text":"Dependency Vulnerabilities"},"helpUri":"https://codehealth.canine.dev/dimensions/D30","relationships":[{"target":{"id":"CWE-1395","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-937","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1395","CWE-937"],"owasp":"A03:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D36","name":"Supply-chain Provenance \u0026 Signing","shortDescription":{"text":"Supply-chain Provenance \u0026 Signing"},"helpUri":"https://codehealth.canine.dev/dimensions/D36","relationships":[{"target":{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1357","CWE-494"],"owasp":"A03:2025"}},{"id":"D43","name":"Malicious Dependencies","shortDescription":{"text":"Malicious Dependencies"},"helpUri":"https://codehealth.canine.dev/dimensions/D43","relationships":[{"target":{"id":"CWE-506","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A08:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-506"],"owasp":"A08:2025"}},{"id":"D44","name":"Platform End-of-Life","shortDescription":{"text":"Platform End-of-Life"},"helpUri":"https://codehealth.canine.dev/dimensions/D44"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX9","name":"CQS / query purity","shortDescription":{"text":"CQS / query purity"},"helpUri":"https://codehealth.canine.dev/dimensions/AX9"},{"id":"AXB2","name":"Runtime readiness","shortDescription":{"text":"Runtime readiness"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB2"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"ES1","name":"Fold determinism","shortDescription":{"text":"Fold determinism"},"helpUri":"https://codehealth.canine.dev/dimensions/ES1"},{"id":"ES2","name":"Immutable events","shortDescription":{"text":"Immutable events"},"helpUri":"https://codehealth.canine.dev/dimensions/ES2"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P10","name":"Library API \u0026 versioning","shortDescription":{"text":"Library API \u0026 versioning"},"helpUri":"https://codehealth.canine.dev/dimensions/P10"},{"id":"P12","name":"CI test-gate honesty","shortDescription":{"text":"CI test-gate honesty"},"helpUri":"https://codehealth.canine.dev/dimensions/P12"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"X1","name":"Async correctness","shortDescription":{"text":"Async correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X1"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X12","name":"Unreachable branch","shortDescription":{"text":"Unreachable branch"},"helpUri":"https://codehealth.canine.dev/dimensions/X12"},{"id":"X13","name":"Undrained process stream","shortDescription":{"text":"Undrained process stream"},"helpUri":"https://codehealth.canine.dev/dimensions/X13"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X15","name":"Unvalidated length from an untrusted reader","shortDescription":{"text":"Unvalidated length from an untrusted reader"},"helpUri":"https://codehealth.canine.dev/dimensions/X15"},{"id":"X16","name":"Unfloored truncation loop","shortDescription":{"text":"Unfloored truncation loop"},"helpUri":"https://codehealth.canine.dev/dimensions/X16"},{"id":"X17","name":"Uncapped recursion over a caller-supplied document","shortDescription":{"text":"Uncapped recursion over a caller-supplied document"},"helpUri":"https://codehealth.canine.dev/dimensions/X17"},{"id":"X18","name":"Disposal-pattern correctness","shortDescription":{"text":"Disposal-pattern correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X18"},{"id":"X19","name":"Unrestored process-global state","shortDescription":{"text":"Unrestored process-global state"},"helpUri":"https://codehealth.canine.dev/dimensions/X19"},{"id":"X2","name":"Cancellation propagation","shortDescription":{"text":"Cancellation propagation"},"helpUri":"https://codehealth.canine.dev/dimensions/X2"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X22","name":"Contradicted release guard","shortDescription":{"text":"Contradicted release guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X22"},{"id":"X23","name":"Unguarded diagnostic materialisation","shortDescription":{"text":"Unguarded diagnostic materialisation"},"helpUri":"https://codehealth.canine.dev/dimensions/X23"},{"id":"X24","name":"Document value interpolated into markup unescaped","shortDescription":{"text":"Document value interpolated into markup unescaped"},"helpUri":"https://codehealth.canine.dev/dimensions/X24"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X27","name":"Collection changed while being enumerated","shortDescription":{"text":"Collection changed while being enumerated"},"helpUri":"https://codehealth.canine.dev/dimensions/X27"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X29","name":"Per-element action decided by a fixed element","shortDescription":{"text":"Per-element action decided by a fixed element"},"helpUri":"https://codehealth.canine.dev/dimensions/X29"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X30","name":"Support guard that admits what it rejects","shortDescription":{"text":"Support guard that admits what it rejects"},"helpUri":"https://codehealth.canine.dev/dimensions/X30"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X4","name":"Structured logging","shortDescription":{"text":"Structured logging"},"helpUri":"https://codehealth.canine.dev/dimensions/X4"},{"id":"X5","name":"Nullable reference types","shortDescription":{"text":"Nullable reference types"},"helpUri":"https://codehealth.canine.dev/dimensions/X5"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"ApConfigurationScreenKt.ApConfigurationScreen (cyclomatic 56): ApConfigurationScreenKt.ApConfigurationScreen has cyclomatic complexity 56 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"7461f3c3ed805ee182374d45ca7d5ee9e569b304b59636c918c416d2f0167441"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::nat66::ra::spawn_loop (cyclomatic 52): vpnhotspotd::nat66::ra::spawn_loop has cyclomatic complexity 52 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2016cc9441a520ef777442b0b2740282b66b5778a5bd34e54b86a7af37f0345"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::nat66::udp::spawn_loop (cyclomatic 51): vpnhotspotd::nat66::udp::spawn_loop has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"3406d53544d8b11d956031fe6d90cae7f89f2871f90f919eef43310da54fbba7"}},{"ruleId":"D1","level":"warning","message":{"text":"TetheringScreenKt.TetheringScreen (cyclomatic 48): TetheringScreenKt.TetheringScreen has cyclomatic complexity 48 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"e584621b0ac7ec67fc9088ac27ffc5a1b5debb5c9847514f2afe1a2fb9fc2e11"}},{"ruleId":"D1","level":"warning","message":{"text":"Routing.start (cyclomatic 39): Routing.start has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"af146f7873ba3d731b51e46379b3c8023eaddf6644e6f69e43d5513aea39e02c"}},{"ruleId":"D1","level":"warning","message":{"text":"RepeaterService.createGroup (cyclomatic 35): RepeaterService.createGroup has cyclomatic complexity 35 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":489}}}],"partialFingerprints":{"codehealthFindingId/v1":"740339ee3690110fc1ca29fb41571c280e90eb5e54cea4331e516f13c1f146d3"}},{"ruleId":"D1","level":"warning","message":{"text":"SettingsScreenKt.SettingsScreen (cyclomatic 34): SettingsScreenKt.SettingsScreen has cyclomatic complexity 34 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e2033752f0aec336a07003f3649cd156e460fa032212007a974f2768c9afd3e"}},{"ruleId":"D1","level":"warning","message":{"text":"Runtime::desired_mutations (cyclomatic 29): Runtime::desired_mutations has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"f92f5346b03295b2fb35bd71548c9016436faa4faea2303fcdd19c96b815202a"}},{"ruleId":"D1","level":"warning","message":{"text":"VpnHotspotAppKt.VpnHotspotApp (cyclomatic 25): VpnHotspotAppKt.VpnHotspotApp has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"a06767104401f0a2e244be3bbd39c1b9c09310a75eb7fdc078e12ba106ff2a45"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo (cyclomatic 25): vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e334811637cb87928021f53cc084b51743a0df71c5fb8d1469e87028f88e56d"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::upstream::spawn_loop (cyclomatic 24): vpnhotspotd::nat66::icmp::upstream::spawn_loop has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"c196e9336b2dee910839241ebfd8fada5585817149567cfc33777e5d22a31758"}},{"ruleId":"D1","level":"warning","message":{"text":"ApConfigurationState.generateConfigError (cyclomatic 23): ApConfigurationState.generateConfigError has cyclomatic complexity 23 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"8078bf38aa908969082052151fbda26322cc500a1aa27380b372354d8c28ea52"}},{"ruleId":"D1","level":"warning","message":{"text":"SoftApConfigurationCompat.toPlatform (cyclomatic 22): SoftApConfigurationCompat.toPlatform has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt"},"region":{"startLine":539}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ef7a5e24ddc80cc397bb669ee01167d935c52c0354beb6c998eef5ff9d0723e"}},{"ruleId":"D1","level":"warning","message":{"text":"DaemonController.startReaderLocked (cyclomatic 22): DaemonController.startReaderLocked has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"b713b7c9eb6595d8bb84b983dd518c663ded335a213f609f4215d699f0646bc8"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::downstream::run_queue (cyclomatic 22): vpnhotspotd::nat66::icmp::downstream::run_queue has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"de4139ae9ca1fc147bcfb93a6e26a5a7ceaf0552cadbb4a6065934360988e9b8"}},{"ruleId":"D1","level":"warning","message":{"text":"LocalOnlyHotspotService.collectLocalOnlyHotspotEvents (cyclomatic 21): LocalOnlyHotspotService.collectLocalOnlyHotspotEvents has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcfed17fe5dea7d31fbb1a471f0d492dfe994107d6c52e05cd81ad619ae00e78"}},{"ruleId":"D1","level":"warning","message":{"text":"ClientViewModel.populateClients (cyclomatic 21): ClientViewModel.populateClients has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a779f2113b03e4b12c49c237d1214f7723161b09f40e51bc53e1e098bbb03e8"}},{"ruleId":"D1","level":"warning","message":{"text":"SoftApTextKt.wifiP2pConnectionInfoLabel (cyclomatic 21): SoftApTextKt.wifiP2pConnectionInfoLabel has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file\u0027s highest cyclomatic complexity: SoftApTextKt.softApClientDisconnectReasonLabel (cyclomatic 63) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SoftApText.kt"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"d10ef695237cb6fb8cf2d638add158baf287cc151747c11318532ad7374ef6c2"}},{"ruleId":"D1","level":"warning","message":{"text":"ClientsScreenKt.ClientRow (cyclomatic 20): ClientsScreenKt.ClientRow has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"d99778150d565bc8d0ae1c83167ce24c54c7b1fa819f49c326714a6f73b0451a"}},{"ruleId":"D1","level":"warning","message":{"text":"LocalOnlyHotspotService.doStart (cyclomatic 19): LocalOnlyHotspotService.doStart has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt"},"region":{"startLine":264}}}],"partialFingerprints":{"codehealthFindingId/v1":"db615ef579672d5f1665fb92e8df66eeacd5dddfa7b79ad1339929d389bf9e44"}},{"ruleId":"D1","level":"warning","message":{"text":"TrafficRecorder.updateLocked (cyclomatic 18): TrafficRecorder.updateLocked has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"870ea1641a7c783db2154d72e05d357ec05dc6b28801eeaf48196389c914e8b0"}},{"ruleId":"D1","level":"warning","message":{"text":"Session::replace_config (cyclomatic 18): Session::replace_config has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/session.rs"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2c119a295dc7fabb4e9561ba428b647f1d48e2ae7789f2548e02b8d2785137e"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::control::run (cyclomatic 18): vpnhotspotd::control::run has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control.rs"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb57e709c10a2a54bc5064eba2204d2f1b70a4a8fa2b55d5bbd86695c1b4f64c"}},{"ruleId":"D1","level":"warning","message":{"text":"App.attachBaseContext (cyclomatic 17): App.attachBaseContext has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/App.kt"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"1505ccd35158c4ceba9bf82e760b7f117b75a35776eaaebc3ef8113aa2855f92"}},{"ruleId":"D1","level":"warning","message":{"text":"MacAddressApRowKt.MacAddressApDialog (cyclomatic 17): MacAddressApRowKt.MacAddressApDialog has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"d015480860586b7ada4f512e839696a4554c9a1bf74bb6c931d594c0a694834a"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::control::handle_command (cyclomatic 17): vpnhotspotd::control::handle_command has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control.rs"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ce4e7d0d2de2155fb1c05322a58ecc852309fc4dcecbcc984ff9982634fa7d3"}},{"ruleId":"D1","level":"warning","message":{"text":"vpnhotspotd::neighbour::neighbour_from_message (cyclomatic 16): vpnhotspotd::neighbour::neighbour_from_message has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/neighbour.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b69a2081b36f9c75538ddb37129cb602959450680ba60f088ded10d9070e746"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::udp::spawn_loop (cognitive 167): vpnhotspotd::nat66::udp::spawn_loop has cognitive complexity 167 (threshold 15). Drivers by points: if/else 17 (81 pts), match/switch 17 (78 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 128). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfcd0d45629b605e57bb9dd2f8bab7642aec971d6c4bd856e625d6adb3295701"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::ra::spawn_loop (cognitive 107): vpnhotspotd::nat66::ra::spawn_loop has cognitive complexity 107 (threshold 15). Drivers by points: if/else 20 (58 pts), match/switch 11 (37 pts), loops 3 (8 pts), boolean chains 4 (nesting depth added 69). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"86248cc36bd99e4fa18facd696c848faa3d4ae8764cb779cb101e035c0336974"}},{"ruleId":"D2","level":"warning","message":{"text":"Routing.start (cognitive 85): Routing.start has cognitive complexity 85 (threshold 15). Drivers by points: if/else 21 (53 pts), error handling 8 (18 pts), boolean chains 6, loops 3 (6 pts), match/switch 1 (2 pts) (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"78fc989d4e318bfa99ab60da09ff7a0a5725611eb07c2dcae23ab09114b84d0f"}},{"ruleId":"D2","level":"warning","message":{"text":"TetheringScreenKt.TetheringScreen (cognitive 84): TetheringScreenKt.TetheringScreen has cognitive complexity 84 (threshold 15). Drivers by points: if/else 54 (71 pts), boolean chains 9, error handling 1 (2 pts), loops 2 (nesting depth added 18). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"3633d32315a4b645165307afc5f6b9ca515745592629c0d7e1eafb56c1630186"}},{"ruleId":"D2","level":"warning","message":{"text":"ApConfigurationScreenKt.ApConfigurationScreen (cognitive 80): ApConfigurationScreenKt.ApConfigurationScreen has cognitive complexity 80 (threshold 15). Drivers by points: if/else 39 (48 pts), boolean chains 18, error handling 7 (14 pts) (nesting depth added 16). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d640a45d74c71cc2dab54e0a2bcc99a8fd7a8c72015bd2f98fdbf2869ee1858"}},{"ruleId":"D2","level":"warning","message":{"text":"RepeaterService.createGroup (cognitive 65): RepeaterService.createGroup has cognitive complexity 65 (threshold 15). Drivers by points: if/else 17 (29 pts), match/switch 6 (16 pts), error handling 6 (15 pts), boolean chains 5 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":489}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7b565480ad1b179d0f1390c3c7b6b01382cbe7d25282706a1ed4cd829181078"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::downstream::run_queue (cognitive 58): vpnhotspotd::nat66::icmp::downstream::run_queue has cognitive complexity 58 (threshold 15). Drivers by points: if/else 11 (40 pts), match/switch 5 (15 pts), loops 2 (3 pts) (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"873620730a0ef3f56a5fe01e19ae928801ca727773dbdef2839698adaf019277"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsScreenKt.SettingsScreen (cognitive 48): SettingsScreenKt.SettingsScreen has cognitive complexity 48 (threshold 15). Drivers by points: if/else 38 (41 pts), error handling 4 (6 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ae8930cf24d23d388f62ba25fa3ae24631bc12891d1968ae251d8234d6f23f5"}},{"ruleId":"D2","level":"warning","message":{"text":"Runtime::desired_mutations (cognitive 48): Runtime::desired_mutations has cognitive complexity 48 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 10 (17 pts), match/switch 4 (11 pts), boolean chains 3 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0dabc1fe5b60f37478ca09d84ae80b1e023876936eabc0adf70d88dd4d0eecd"}},{"ruleId":"D2","level":"warning","message":{"text":"SoftApConfigurationCompat.toPlatform (cognitive 47): SoftApConfigurationCompat.toPlatform has cognitive complexity 47 (threshold 15). Drivers by points: if/else 16 (29 pts), error handling 4 (12 pts), loops 1 (3 pts), boolean chains 2, match/switch 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt"},"region":{"startLine":539}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a8f48c6c4f336611b4abb1cd502499f66ee99d81de12cc9048cd2ae9d431f73"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo (cognitive 45): vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo has cognitive complexity 45 (threshold 15). Drivers by points: if/else 14 (27 pts), match/switch 8 (16 pts), boolean chains 1, loops 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"cff2f2af79c4fbf088750795f68cc436f7ad7a7e91d8a3276cdccd8ca19805ba"}},{"ruleId":"D2","level":"warning","message":{"text":"LocalOnlyHotspotService.doStart (cognitive 39): LocalOnlyHotspotService.doStart has cognitive complexity 39 (threshold 15). Drivers by points: if/else 10 (22 pts), error handling 8 (16 pts), boolean chains 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt"},"region":{"startLine":264}}}],"partialFingerprints":{"codehealthFindingId/v1":"205660ed0b05f4c4caef0fe404ea3ead1b1536f401521cf3a23ea88cab319ed4"}},{"ruleId":"D2","level":"warning","message":{"text":"DaemonController.startReaderLocked (cognitive 37): DaemonController.startReaderLocked has cognitive complexity 37 (threshold 15). Drivers by points: if/else 9 (23 pts), match/switch 4 (11 pts), error handling 2, loops 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"50790800b39519f7fd0ff4f459822ca19ac9134fabdedee481e43b9e772ea75d"}},{"ruleId":"D2","level":"warning","message":{"text":"TetheringService.onStartCommand (cognitive 36): TetheringService.onStartCommand has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (30 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/TetheringService.kt"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"5789e04e94c4bb20141da062842b5b6cb27846d8fa023c5a74dbc82c17018fdf"}},{"ruleId":"D2","level":"warning","message":{"text":"ClientViewModel.populateClients (cognitive 35): ClientViewModel.populateClients has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (25 pts), boolean chains 4, error handling 1 (3 pts), loops 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d8b430b6b1f45c8e3aa431349baf5100faeb5db12786514442fffc106437008"}},{"ruleId":"D2","level":"warning","message":{"text":"TetheringManagerCompat.startTethering (cognitive 35): TetheringManagerCompat.startTethering has cognitive complexity 35 (threshold 15). Drivers by points: if/else 10 (21 pts), error handling 6 (14 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/TetheringManagerCompat.kt"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"bef2cd60a011b3e2b973164e6a85ebdfca1fa9a2eaa8fa3013ad38295ca02b42"}},{"ruleId":"D2","level":"warning","message":{"text":"ApConfigurationSessionKt.applySystemApConfiguration (cognitive 35): ApConfigurationSessionKt.applySystemApConfiguration has cognitive complexity 35 (threshold 15). Drivers by points: error handling 8 (21 pts), if/else 7 (14 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationSession.kt"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"62ce8ea54a8141871150bdc53a9735f50269a5bf29512002e3f4df232d41dcec"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::dns::spawn_tcp_loop (cognitive 35): vpnhotspotd::dns::spawn_tcp_loop has cognitive complexity 35 (threshold 15). Drivers by points: if/else 7 (25 pts), match/switch 3 (9 pts), loops 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":323}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed95c31696d682f639296bdefc7523ade2a0b245402a1177621ddf966bc3f84b"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::dns::spawn_udp_loop (cognitive 35): vpnhotspotd::dns::spawn_udp_loop has cognitive complexity 35 (threshold 15). Drivers by points: if/else 5 (25 pts), match/switch 3 (9 pts), loops 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3adedf7f2e11bee1adf5b679628a1d50473d04aec9af6f409b6279ebb9b49aa"}},{"ruleId":"D2","level":"warning","message":{"text":"VpnHotspotAppKt.VpnHotspotApp (cognitive 33): VpnHotspotAppKt.VpnHotspotApp has cognitive complexity 33 (threshold 15). Drivers by points: if/else 23 (25 pts), boolean chains 4, match/switch 2 (3 pts), loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"37525c37c5f44da5becb02dcbb104ed03a8f8021ca5b567e4a3dad2219697d0b"}},{"ruleId":"D2","level":"warning","message":{"text":"LocalOnlyHotspotService.collectLocalOnlyHotspotEvents (cognitive 32): LocalOnlyHotspotService.collectLocalOnlyHotspotEvents has cognitive complexity 32 (threshold 15). Drivers by points: if/else 13 (28 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 16). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6c97d436bbc6866abe845c29ab64fa45827ab50ad1917ea18399f0d4bddef30"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::control::run (cognitive 32): vpnhotspotd::control::run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (20 pts), match/switch 4 (9 pts), loops 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control.rs"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc186f673dfdb3d2947bbef548e1dd2ec2b3b3c9bab420119fca293ce0711137"}},{"ruleId":"D2","level":"warning","message":{"text":"ApConfigurationState.generateConfigError (cognitive 31): ApConfigurationState.generateConfigError has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (13 pts), error handling 6 (12 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"17afe8a2cc1a340e4aa973467b321ad6ea50fc432abbfb9946c05ea22ed7e97a"}},{"ruleId":"D2","level":"warning","message":{"text":"App.attachBaseContext (cognitive 30): App.attachBaseContext has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (25 pts), boolean chains 3, error handling 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/App.kt"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"22c6cdb9b4cf4ae21cb90d4166f1d7c7b1b30e77c817938881aca2d0eeb2c051"}},{"ruleId":"D2","level":"warning","message":{"text":"SoftApWifiSummaryKt.softApInfoSummary (cognitive 29): SoftApWifiSummaryKt.softApInfoSummary has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (26 pts), error handling 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SoftApWifiSummary.kt"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cc934a3430b25692c9bdcb9e77ef76a8164dab9a8907fb95a355bc87d1d413b"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::icmp::upstream::spawn_loop (cognitive 28): vpnhotspotd::nat66::icmp::upstream::spawn_loop has cognitive complexity 28 (threshold 15). Drivers by points: match/switch 7 (18 pts), if/else 3 (7 pts), loops 2 (3 pts) (nesting depth added 16). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b57f04d5ef0a3c687bee4007dd64d434614f1786b34485c001c526f1e3dd067"}},{"ruleId":"D2","level":"warning","message":{"text":"TrafficRecorder.updateLocked (cognitive 27): TrafficRecorder.updateLocked has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 4, error handling 3 (4 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"c771623407241b751ffad48df61e0e3c81eeafdce522bd9635778d474d995df9"}},{"ruleId":"D2","level":"warning","message":{"text":"MacAddressApRowKt.MacAddressApDialog (cognitive 25): MacAddressApRowKt.MacAddressApDialog has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 7 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"85f514406c425f82f7d2d84fbf6b86c8d44224d1c30e3972dc6f3bcd4e7a08cd"}},{"ruleId":"D2","level":"warning","message":{"text":"TextSwitchApRowKt.TextSwitchApRow (cognitive 24): TextSwitchApRowKt.TextSwitchApRow has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (19 pts), boolean chains 5 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextSwitchApRow.kt"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c6857b5628ef27bf4ca9ccd49802fbc7242c7df47d765eb17717f5e1f5098cd"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::control::session_control::run_session (cognitive 24): vpnhotspotd::control::session_control::run_session has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control/session_control.rs"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"1df20e6b800b8339c8432b7761e47b51669b3fede29e3ff1cde7bf9aa78f67c1"}},{"ruleId":"D2","level":"warning","message":{"text":"TetheringScreenKt.repeaterSummary (cognitive 22): TetheringScreenKt.repeaterSummary has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (20 pts), error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":884}}}],"partialFingerprints":{"codehealthFindingId/v1":"de095771580662d206c76471c363ed3be7c920fca17e9afa0d4a492bf97a917c"}},{"ruleId":"D2","level":"warning","message":{"text":"PasswordApRowKt.PasswordApRow (cognitive 22): PasswordApRowKt.PasswordApRow has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (21 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/PasswordApRow.kt"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fc06cd0fed2f7fdd97cac3c38fe4495ad0d01c1e0f94ab518edbf406e291663"}},{"ruleId":"D2","level":"warning","message":{"text":"Runtime::replace_clients (cognitive 22): Runtime::replace_clients has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"858269bdb19ecbd1bd42c30a36fed55cd370072491b29ef78f363dcd3cb3211f"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::tcp::spawn_loop (cognitive 22): vpnhotspotd::nat66::tcp::spawn_loop has cognitive complexity 22 (threshold 15). Drivers by points: if/else 3 (12 pts), match/switch 3 (9 pts), loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/tcp.rs"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"78817d7db50d1aed2ff0fdc7b1efdf6a7949bfce19f4105621a2313e76a7a54e"}},{"ruleId":"D2","level":"warning","message":{"text":"StaticIpSetter.enable (cognitive 21): StaticIpSetter.enable has cognitive complexity 21 (threshold 15). Drivers by points: error handling 4 (8 pts), if/else 4 (7 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/StaticIpSetter.kt"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"eca7e2646db0d36be31baff1e961c2b597f07c2b09d3cf48753056c488e2329f"}},{"ruleId":"D2","level":"warning","message":{"text":"TetheringScreenKt.networkInterfaceAddressesText (cognitive 21): TetheringScreenKt.networkInterfaceAddressesText has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (9 pts), error handling 3 (7 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcaa320d4e790cd39899b92b5d09df497ecc36e705312d41d9263ec4f6a1c977"}},{"ruleId":"D2","level":"warning","message":{"text":"Runtime::reconcile (cognitive 21): Runtime::reconcile has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (11 pts), match/switch 3 (8 pts), loops 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing.rs"},"region":{"startLine":202}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b7cf4f2584ee69aa8e5456e1a3af946b94a11f3c85cbdd24a1ff37e28a40afa"}},{"ruleId":"D2","level":"warning","message":{"text":"Session::replace_config (cognitive 21): Session::replace_config has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 4, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/session.rs"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"57c5de63d760af1e40f0b90a0e2628c585f837a0a72ed25a6b237fc37d0256af"}},{"ruleId":"D2","level":"warning","message":{"text":"ClientsScreenKt.ClientsScreen (cognitive 20): ClientsScreenKt.ClientsScreen has cognitive complexity 20 (threshold 15). Drivers by points: error handling 4 (12 pts), if/else 4 (6 pts), loops 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce47b7b53c951a0288ac565e89c945d84716f9b2da60fa0d38c51ebc8a843821"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::control::handle_command (cognitive 20): vpnhotspotd::control::handle_command has cognitive complexity 20 (threshold 15). Drivers by points: loops 4 (8 pts), if/else 2 (6 pts), match/switch 3 (5 pts), boolean chains 1 (nesting depth added 10). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control.rs"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"d807371a239f4a479d0b82eaabd5fb34105992e45b32842ac8c269d6d8c02167"}},{"ruleId":"D2","level":"warning","message":{"text":"RepeaterService.runLifespan (cognitive 19): RepeaterService.runLifespan has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 2, loops 1 (2 pts), error handling 1, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":395}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ab23aa1195dd396bafad8c900e8086e1a0b64f7c07c3ed50ae6d20b48de2ebc"}},{"ruleId":"D2","level":"warning","message":{"text":"ClientsScreenKt.ClientRow (cognitive 19): ClientsScreenKt.ClientRow has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15, error handling 2, boolean chains 1, match/switch 1. To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2eb29ce8a6391e6940190d6fe3af5d0a38f84a04f02979425fa3ce48875783b"}},{"ruleId":"D2","level":"warning","message":{"text":"ChannelApRowKt.ChannelApSheet (cognitive 19): ChannelApRowKt.ChannelApSheet has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ChannelApRow.kt"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5b94d794c55ba9e3f5ce869c490095d86e6e21ea87289e896a38a5ac5d994a3"}},{"ruleId":"D2","level":"warning","message":{"text":"DaemonController.ensureDaemonLocked (cognitive 18): DaemonController.ensureDaemonLocked has cognitive complexity 18 (threshold 15). Drivers by points: error handling 6 (10 pts), if/else 5 (7 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"66bee50156322ee30de5692b9f010081d485b712f5a3204bb0a7fbb001d91616"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::nat66::tcp::handle_connection (cognitive 18): vpnhotspotd::nat66::tcp::handle_connection has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, match/switch 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/tcp.rs"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"c05f7706ec984d5a4ca783628df9f9f7666ca20060caaa59b630a54d7ccbb9bd"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::neighbour::neighbour_from_message (cognitive 18): vpnhotspotd::neighbour::neighbour_from_message has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/neighbour.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ffa17c6397c55ca2578bf49cbd1dbef3d628a89c3b2f072ca895a24c002e3a6"}},{"ruleId":"D2","level":"warning","message":{"text":"ApConfigurationSessionKt.loadSystemApConfiguration (cognitive 17): ApConfigurationSessionKt.loadSystemApConfiguration has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), error handling 4 (6 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationSession.kt"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"014b7b161d8a9ea26f1ea64e28892ac826da194bec3c8f660b75e53b887c3f9c"}},{"ruleId":"D2","level":"warning","message":{"text":"SoftApRuntimeInfoKt.softApSupportedFeatures (cognitive 17): SoftApRuntimeInfoKt.softApSupportedFeatures has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 3 (4 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/SoftApRuntimeInfo.kt"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"37f0b6e227f396fbf930be90c17d552d0b4ef434b86c9400797d845e6e98b6d5"}},{"ruleId":"D2","level":"warning","message":{"text":"AssociationTask::run (cognitive 17): AssociationTask::run has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (9 pts), match/switch 2 (5 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":498}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab3084396b514b84a9ace7e141eaa52de411d46f2a9e77660bab04ee725b3acd"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::shared::ipv4_forward_counter::parse_ipv4_forward_counter_line (cognitive 17): vpnhotspotd::shared::ipv4_forward_counter::parse_ipv4_forward_counter_line has cognitive complexity 17 (threshold 15). Drivers by points: if/else 17. To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"39a44700c2cf4358c21ca876c2b8c7d4fb971dbae0b634edfbf4774ecbcaad39"}},{"ruleId":"D2","level":"warning","message":{"text":"LeakCanaryInstaller.onCreate (cognitive 16): LeakCanaryInstaller.onCreate has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), match/switch 2 (6 pts), if/else 1 (nesting depth added 10). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/debug/java/be/mygod/vpnhotspot/LeakCanaryInstaller.kt"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"f389b7dc130cebb097c0dbdeb6b104529db6a5e25b35004e20d2eb9914b1392f"}},{"ruleId":"D2","level":"warning","message":{"text":"Runtime::replace_clients (cognitive 16): Runtime::replace_clients has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4fa28a21b97ab22c9b76057e51379e6428c84d6b1602b2e5ef21f60dd09e6be"}},{"ruleId":"D2","level":"warning","message":{"text":"Runtime::record_config_replacement (cognitive 16): Runtime::record_config_replacement has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs"},"region":{"startLine":334}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad89e2784c324e79ca71bed54c71eae4f5cd8104cd131b4008e62d571df8d7ff"}},{"ruleId":"D2","level":"warning","message":{"text":"vpnhotspotd::routing::static_addresses::replace_static_addresses (cognitive 16): vpnhotspotd::routing::static_addresses::replace_static_addresses has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 3 (7 pts), if/else 2 (4 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/static_addresses.rs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"a305e2a1b5f1fb959623d123c3987a3846c45f81aaccbe62ba8a7b6039848675"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ApConfigurationScreenKt.ApConfigurationScreen: MethodTooLong \u2014 ApConfigurationScreen runs 343 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 243 over it, 3.43\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"2772dd8388648f7413f8a5d0b843498116aaf613284387cf1e6a4d294ee7c373"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: vpnhotspotd::nat66::udp::spawn_loop: FunctionTooLong \u2014 vpnhotspotd::nat66::udp::spawn_loop runs 308 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 208 over it, 3.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"82fa90cf0d9879db66268637d74516aa1a400b45a152779b83e5f41cb7f37409"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: SettingsScreenKt.SettingsScreen: MethodTooLong \u2014 SettingsScreen runs 231 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 131 over it, 2.31\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ce86d5896fec1a1f06b0ebf000a2e72fbb6c822b24ecc514fef58694a967d9e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: VpnHotspotAppKt.VpnHotspotApp: MethodTooLong \u2014 VpnHotspotApp runs 224 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 124 over it, 2.24\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3ac91f8d5bfeb91420b1a1cf15ff889bb0245c783bd278329b451f100d6f17d"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: vpnhotspotd::nat66::ra::spawn_loop: FunctionTooLong \u2014 vpnhotspotd::nat66::ra::spawn_loop runs 217 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 117 over it, 2.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"74121cd5299a83fd0ee1f6759893e30dee8d7079e2975e9d8e0d37fa7a8ff4fb"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Runtime.desired_mutations: MethodTooLong \u2014 desired_mutations runs 200 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 100 over it, 2.00\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"165d83799141512ac28b9231b3a6948b56cb3078c5558c2c326cb0dfabb57741"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ClientsScreenKt.ClientRow: MethodTooLong \u2014 ClientRow runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4d480b1e19d5613c320080b8dcf8bd91787d0310e7d3de1b1c462aceb61e275"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: ui/TetheringScreen.kt: FileTooLong \u2014 730 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 230 over it, 1.46\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c365e2f6736e127f6e5a7cabadc6a0b5092c91a2e49da23565dd881f461ae58"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo: FunctionTooLong \u2014 vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo runs 138 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 38 over it, 1.38\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"34b7aeb08bd0c0d88f12b043ce9dd6fa4712d9931dbaadb8b5ccc1149cec83cf"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: MacAddressApRowKt.MacAddressApDialog: MethodTooLong \u2014 MacAddressApDialog runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"38b9c41b1c1abbcb4d56887a27d1d3e1dc30dec97906ed74fed648b99fc1391c"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: routing/desired.rs: FileTooLong \u2014 610 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 96% of them inside a single declaration: Runtime (29-790). The bar is 500 significant lines; this is 110 over it, 1.22\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b5f827b9cfb96968df57cd63f3350901eee076ab75c12eee3237a1401b85ab1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: ui/SettingsScreen.kt: FileTooLong \u2014 561 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 61 over it, 1.12\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"90a608ce47e54cac9f18e8acaea194ba5ee3b37b7200e46fe5748653658533bb"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: ui/VpnHotspotApp.kt: FileTooLong \u2014 553 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 53 over it, 1.11\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd2a39120711f846702fd892cc414b15c0b3dbcb319c7b957c456fa53d6ace3d"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: vpnhotspotd::nat66::icmp::downstream::run_queue: FunctionTooLong \u2014 vpnhotspotd::nat66::icmp::downstream::run_queue runs 108 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 8 over it, 1.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a19d23ae840fef5ab1024ad726bebec986f805e8095c3caa074a29929444a2e"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: RepeaterService: ClassTooLong \u2014 423 significant lines (blank, comment-only and punctuation-only lines excluded), 12 methods. The bar is 400 significant lines; this is 23 over it, 1.06\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"0bf25c1aca0021724e4bf6c36f521ba4860ba4c78d5ed9622332bbde9962dec6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: TextSwitchApRowKt.TextSwitchApRow: MethodTooLong \u2014 TextSwitchApRow runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextSwitchApRow.kt"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bf49ef3a7229690931d28815643c5c6d318feca7ff311d78856c18209993d9a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ApConfigurationState: ClassTooLong \u2014 404 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 4 over it, 1.01\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"c789a3a5df5007a4d2fc97db60a3f9fc4311e08de11b46d28b9cab57c64643a0"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: vpnhotspot/RepeaterService.kt: FileTooLong \u2014 505 significant lines (blank, comment-only and punctuation-only lines excluded), about 84% of them inside a single declaration: RepeaterService (88-664). The bar is 500 significant lines; this is 5 over it, 1.01\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"95354b448e9cb25bbb17699db2de387e2a0518ce3b0ef0640b6fe73fbb890914"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (70 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs:275-344 | mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs:382-473 \u2014 These two members are one piece of code written twice and then edited apart: 70 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"48c82844a135dfa6f00b30e264087f932995a00e885e859011946162a55b2cf1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (55 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:582-636 | mobile/src/main/rust/vpnhotspotd/src/routing/ipv6_nat_firewall.rs:96-157 \u2014 These two members are one piece of code written twice and then edited apart: 55 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":582}}}],"partialFingerprints":{"codehealthFindingId/v1":"c28e9b8ce49cc47d4ec6f87106aa6ba74b36d93b830b466521c8db0c5609168c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/dns.rs:135-155 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:244-273 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"538428e36b466db477ad7b049aa0f19332f3a4acc78ded5ca03fa25092f59706"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 21\u002B corresponding lines): mobile/src/main/rust/vpnhotspotd/src/dns.rs:174-194 | mobile/src/main/rust/vpnhotspotd/src/dns.rs:196-216 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:275-302 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:304-332 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f84d5e280966217baab66763125958cf391c474729b88f1985f2cb7b1e267a9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs:46-58 | mobile/src/main/rust/vpnhotspotd/src/shared/nat66_counter.rs:88-100 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae8c2e6457f3ea531cc58224333f968f9cc305632e1513d572408fe9c88bc242"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/nat66/tproxy.rs:8-23 | mobile/src/main/rust/vpnhotspotd/src/nat66/tproxy.rs:25-41 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/tproxy.rs"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"58ac46934866d5f88ea569103dfd70c467e0be14ae458d5a952859f18a6b04cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/shared/protocol.rs:41-54 | mobile/src/main/rust/vpnhotspotd/src/shared/protocol.rs:71-87 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/protocol.rs"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3372dcc53b41e7da046aa48d98f547f74f8c9780f172cbdad3f9f273f3f3b23"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/raw_socket.rs:138-146 | mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs:450-469 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/raw_socket.rs"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b514dbacb6071a3a2370e002edb5a3efe38a9bf8fd3227e39700b9174c1b6fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/socket.rs:24-41 | mobile/src/main/rust/vpnhotspotd/src/socket.rs:47-65 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/socket.rs"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"97c82a47e3aad104ea56382252ab3acae8259d82e3116739e98faea66bdf27cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): mobile/src/main/java/be/mygod/vpnhotspot/manage/LocalOnlyHotspotTileService.kt:20-37 | mobile/src/main/java/be/mygod/vpnhotspot/manage/RepeaterTileService.kt:27-47 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/manage/LocalOnlyHotspotTileService.kt"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"2dc12915e77d6b8713e14da0683599310dcdcd034d37004e57d0f8ebae68f178"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/netlink.rs:190-207 | mobile/src/main/rust/vpnhotspotd/src/netlink.rs:242-258 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/netlink.rs"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"26ee9d7ae8d20c3fc9bd71f91bd9f35a24b941ac1d57a7d1d16c7ba5d67f1bb8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs:54-62 | mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs:71-84 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"078996f34e8d614be974fa9221404b8736c932c9e0b8aadbe32a4db3d3e5e973"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs:79-93 | mobile/src/main/rust/vpnhotspotd/src/shared/nat66_counter.rs:128-142 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"823fd34875fb764ef6cfdcfa31d9b26641c540984729c881e31670355c39b36f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/dns.rs:220-228 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:455-463 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"490378b4d0be1108dc83dcf35c67da73e36925d98b4e8e1eab13ea3d386a0565"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 13\u002B corresponding lines): mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/state.rs:146-159 | mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/state.rs:241-253 | mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/state.rs:259-272 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/state.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9e8b7cb10aa769f7ab87224275c4034ddb5dafc862065b5564893310c763402"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt:633-642 | mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt:645-654 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":633}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f04a1af6f7d7307e82ec7a0387884a3fd39823c213280ae5f5af42bf1640f4a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs:514-528 | mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs:557-571 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":514}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b0afccdc23dc2b755e6980995c2a7ea167c810ef77209a8bcd1a52f3f87180e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): mobile/src/main/rust/vpnhotspotd/src/neighbour.rs:100-109 | mobile/src/main/rust/vpnhotspotd/src/socket.rs:67-76 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/neighbour.rs"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"2789b857213594f6157445902e80f430325337988eb9e21ddbc80726edc01689"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 2): mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextApRow.kt:70-86 | mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextSwitchApRow.kt:118-133 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextApRow.kt:70\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/TextApRow.kt"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"d346234065d0dd6d46a3070046c188ef447b49d07a612b4d83e61574d7dead17"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): mobile/src/main/java/be/mygod/vpnhotspot/ui/SoftApWifiSummary.kt:63-77 | mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt:772-786 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/SoftApWifiSummary.kt:63\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SoftApWifiSummary.kt"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"0149e1bb38d13425b13deebe5382d47e04331cfdc395da96c31598322fed856f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:487-500 | mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ChannelApRow.kt:94-107 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:487\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"b52c79b86cdb5ee89826d48318d6ad42a18620fee653278c3c39611178fde1e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 2): mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:251-260 | mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:264-274 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:251\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8a816cb183c5853dfa1efe5c9af60b5b45f1eb8abf2de20d503c55201322a55"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt:348-357 | mobile/src/main/java/be/mygod/vpnhotspot/ui/PreferenceComponents.kt:491-500 | mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ChannelApRow.kt:98-107 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt:348\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ChannelApRow.kt:108\u0060 calls \u0060spacedBy\u0060 and \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt:358\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":348}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1a5983bdf6a54a6c6210b34ba056bec21e7ea65a0ecc5c800f3652ecc9f086a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/PasswordApRow.kt:57-65 | mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/SsidApRow.kt:97-105 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/PasswordApRow.kt:57\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/PasswordApRow.kt"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3e63c92c6bb4a2534c0933966288a76e79e93e6bd4ee01ab76753205b66c0ae"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/dns.rs:96-112 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:187-204 \u2014 before extracting anything, compare \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs:96\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"95875096fb7a9f8f4f3f198810d445124cbc01967ac68a098d2494bb7d72bc36"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/dns.rs:138-154 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:252-268 \u2014 before extracting anything, compare \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs:138\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind \u0060committed\u0060 to \u0060\u0026[ClientDnsPorts]\u0060 in one and \u0060Option\u003C\u0026Ipv6NatPorts\u003E\u0060 in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH \u2014 their common supertype where they have one, or a new abstraction over them where they do not \u2014 and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"c54f95a7d331531fa1094cf991028df027b0c5c7a6eeb18794c744f6698a5110"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs:281-296 | mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs:418-433 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs:281\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"8899d9af6e026dbd496508320b63c2a00bdf80ed4cf586cadc2d4ae89755abf5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:603-616 | mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:618-631 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:603\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:600\u0060 calls \u0060clone\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs:615\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":603}}}],"partialFingerprints":{"codehealthFindingId/v1":"01434335cf8916f8247dff3a4a0126469a2feaca2e082c755b6a8949e8add334"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/dns.rs:179-189 | mobile/src/main/rust/vpnhotspotd/src/dns.rs:201-211 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs:179\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"d69387a9c038a9e43bc59e956707c3a62a4a36f67b8c20b4c98913d8d2a846ee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:283-293 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:313-323 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:283\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:312\u0060 calls \u0060clone\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:282\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs"},"region":{"startLine":283}}}],"partialFingerprints":{"codehealthFindingId/v1":"31bab496d725d15432c85f2d913402edb75f8b89f834630bae19922f936c7695"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/netlink.rs:191-199 | mobile/src/main/rust/vpnhotspotd/src/netlink.rs:210-218 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/netlink.rs:191\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/netlink.rs"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ec821ee4ae88238f6e8cf381730a6ed85cfcf4b1fb6f7f0ea09ffe206bf7a21"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs:69-77 | mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs:87-95 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs:79\u0060 calls \u0060Ok\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs:96\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/ipv4_forward_counter.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"4029af320a41ed69d897ae6539c54c111d72b2d930dcf410d24842e8764cfcd7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs:56-62 | mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs:78-84 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs:56\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/icmp_wire.rs"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fb6a5c7993bddcb6fe5c9aa2b02dd28a30fe5ee63f0b3a23b086516b99f7bac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/dns.rs:230-237 | mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs:465-472 \u2014 before extracting anything, compare \u0060mobile/src/main/rust/vpnhotspotd/src/dns.rs\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"502129e09933ae641ac7b07d26ec06b20a41eeb256d71ea8b235dc9dc39e8a43"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs:244-251 | mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs:277-284 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs:244\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/upstream.rs"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"92bfb729c6c6d151bab3dc9c8064bc01c746fbac12e22b8c7a5e2bb32ad78489"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs:49-55 | mobile/src/main/rust/vpnhotspotd/src/shared/nat66_counter.rs:91-97 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs:49\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/shared/dns_counter.rs"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"79eab82144c6cbdc0e09ab0cc177fd2cb3a771f5a515b930dc6356a3f2cf404c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs:441-445 | mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs:451-455 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":441}}}],"partialFingerprints":{"codehealthFindingId/v1":"fae1547e53d921526df3defc73469d1af53df29495e515b8fa339bdec3702680"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: App (LCOM4 5): App\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/App.kt"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"affa402cb422946fa6ceb1f12d7e2625d3f454a5f2590a87b935201b9e49f457"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: KillableTileService (LCOM4 5): KillableTileService\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/util/KillableTileService.kt"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6cef900efad74bd01daecb411e3433deb92154f88dd15bb2e4c73ad76faac1f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt changed 22 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 56 in ApConfigurationScreenKt.ApConfigurationScreen at line 53. 3 of those changes were fix/bug commits, and the other 19 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8d7098dc16e64034057f5ec90244f621a67b1a784a7818e3b68297d9755c157"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt changed 24 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 48 in TetheringScreenKt.TetheringScreen at line 111. 8 of those changes were fix/bug commits, and the other 16 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9ba2fe9c5edab68affe94d7728a4325db8dfa21129b648c2751442e62408e95"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt: mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 39 in Routing.start at line 109. 4 of those changes were fix/bug commits, and the other 19 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/Routing.kt"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"4293a380365fe556d1177062ef05f786517635fd219ec895c75edbf3665411ad"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs: mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 52 in vpnhotspotd::nat66::ra::spawn_loop at line 53. 2 of those changes were fix/bug commits, and the other 13 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/ra.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"634577daf2b4e51b46f214f58ad6b8a245963f491a23b8bb0fcc5b576086b255"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt: mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt changed 32 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in DaemonController.startReaderLocked at line 275. 2 of those changes were fix/bug commits, and the other 30 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e0050eec0125badee08a7dc31eb1f094e3591e0954e000f899cd3a5215dfb74"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt: mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt changed 18 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in RepeaterService.createGroup at line 489. 5 of those changes were fix/bug commits, and the other 13 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":489}}}],"partialFingerprints":{"codehealthFindingId/v1":"dac2a3d701cbc45a089281b1e8744f9c979decb2688612294faec2282de6bed5"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs: mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 51 in vpnhotspotd::nat66::udp::spawn_loop at line 68. 1 of those changes was a fix/bug commit, and the other 10 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0206e14050a2b85d511c4eaf88890a77b26bfb0750eb56070207e581047c967"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt: mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt changed 25 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in ClientViewModel.populateClients at line 235. 4 of those changes were fix/bug commits, and the other 21 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea473c472aa990a427b5195ea4b60451c09cb046a95f411086ad720589ae415f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/control.rs: mobile/src/main/rust/vpnhotspotd/src/control.rs changed 28 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in vpnhotspotd::control::run at line 32. 4 of those changes were fix/bug commits, and the other 24 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/control.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/control.rs"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"616c07d714a94d84a4f08faca7fdc8e7d31936db94963214f13b388e638d1446"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt changed 18 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in VpnHotspotAppKt.VpnHotspotApp at line 138. 5 of those changes were fix/bug commits, and the other 13 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"7484f297b88515ef2274c02acc7c7335e044c5ad0bc4a3d98af80d9eb329d888"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 34 in SettingsScreenKt.SettingsScreen at line 100. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"7adc9e76573c24b736934057d97e45d3336aa3236e96edc5c1157b2a472c9586"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt: mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt changed 20 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in LocalOnlyHotspotService.collectLocalOnlyHotspotEvents at line 127. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"02dedb56d9d8a292fa8ce04f207fcdb2f05a0f3a942bfa36631a0c1dfcf43be5"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/session.rs: mobile/src/main/rust/vpnhotspotd/src/session.rs changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in Session::replace_config at line 114. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/session.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/session.rs"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ad2d0d29763759fe360eef7ce6d28fae0324d3751a49fd949997c355a4b167f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/neighbour.rs: mobile/src/main/rust/vpnhotspotd/src/neighbour.rs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in vpnhotspotd::neighbour::neighbour_from_message at line 146. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/neighbour.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/neighbour.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c73e1e3fe0c9c2b063a6f0048c9e8c45bff650f2c843a88eb9d8d865f8cc780"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs: mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in Runtime::desired_mutations at line 30. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2f03b3d0a2eb68139d70fe8bd164600670d4e6be36b694e4e1fd4afb6a38e8f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in ApConfigurationState.generateConfigError at line 234. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3932debfeb96c52b2891a0515a00b2f66cc019e660a09041a54027b0ef50e68"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in ClientsScreenKt.ClientRow at line 157. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/ClientsScreen.kt"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec7bdaecc1d34e02ac25afe808db118f91fe77060fd1ee72f65ebbed9a6e8293"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/App.kt: mobile/src/main/java/be/mygod/vpnhotspot/App.kt changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in App.attachBaseContext at line 63. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/App.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/App.kt"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"5840ff5aa79142d1c712fba6079d007ed10f25269dbf6d9dcdf2bea187eefd79"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt: mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in TrafficRecorder.updateLocked at line 119. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"a159fbbb12e6b73a6c56fc63b7509271c2a033640f91db623ae3fcd94666e39b"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt: mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in MacAddressApRowKt.MacAddressApDialog at line 57. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a83ca9a5f000c0c27c9cc0a7d1e800b550a9d2d5a809a6f7861ffa7ecb44004"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt: mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in SoftApConfigurationCompat.toPlatform at line 539. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt"},"region":{"startLine":539}}}],"partialFingerprints":{"codehealthFindingId/v1":"6cacd9a11422102e2a7743da862ac7119c4f618da90a7c83f7a000d94dfc25ba"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs: mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in vpnhotspotd::nat66::icmp::downstream::handle_downstream_echo at line 326. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/nat66/icmp/downstream.rs"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae1f6a9204efee3c467055660b29785d30d3f56feb9d90d94507733ef600901b"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: mobile/src/main/java/be/mygod/vpnhotspot/manage/BluetoothTethering.kt: mobile/src/main/java/be/mygod/vpnhotspot/manage/BluetoothTethering.kt changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 7 (its worst body is BluetoothTethering.awaitBluetoothOn at line 109), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201CFix weak usage for start/stopTethering\u201D; \u201CFix BluetoothPan leaks\u201D; \u201CFix cleanup in BluetoothTethering\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-05-05..2026-08-03, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-05-05 15:22:23 -04:00\u0027 --until=\u00272026-08-03 15:22:23 -04:00\u0027 --full-history --no-merges -- mobile/src/main/java/be/mygod/vpnhotspot/manage/BluetoothTethering.kt\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/manage/BluetoothTethering.kt"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ded5eb90d86e5353cf218e6b460724525681f880fb5df2d70c1d0f1730dcdc1"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #1: If anonymized user #1 becomes unavailable, 94 significant file(s) lose their only recent owner: mobile/src/main/java/be/mygod/vpnhotspot/ui/TetheringScreen.kt, mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt, mobile/src/main/java/be/mygod/vpnhotspot/ui/SettingsScreen.kt, mobile/src/main/java/be/mygod/vpnhotspot/ui/VpnHotspotApp.kt, mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/SoftApConfigurationCompat.kt, mobile/src/main/rust/vpnhotspotd/src/nat66/udp.rs, mobile/src/main/rust/vpnhotspotd/src/routing/desired.rs, mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt (\u002B86 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"42d6700b36297cdbdb1544acbefc0f46aca3189135d91b94dbfd12dc6fd5f12e"}},{"ruleId":"D19","level":"note","message":{"text":"Documentation: no build, run or usage example: the repository holds project manifests and neither \u0060README.md\u0060 nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"README.md"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c33a5992d4bd6ac1ea4b853ae69753fcd7e0410099c58731c86be53325ba8c96"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060. ADRs are expected here because \u0060mobile/build.gradle.kts\u0060 makes this repository a deployable product (line 19)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/build.gradle.kts"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe8b5096be1244bef7b25afbd24f7a9588cceaaca7983138f3077f4fee9db099"}},{"ruleId":"D26","level":"note","message":{"text":"Projects may be oversized for their cohesion: 1 of 2 project(s) overshoot their size bounds, lowering Project Cohesion to 0.0/10. The most over is \u0060mobile\u0060 (16277 LoC, 273 module-visible types across 16 directories). Review these for cohesion \u2014 draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d5a94650dc74886a0f1f08eb9fb6775f1fc395279ef7e901c970c9d26f767a72"}},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d5b8f11381d61a58459ffc7c595fd52d09c03c711894a63a9578043d2338412b"},"taxa":[{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A08:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"76cc5c42a7ec41776acb0e00279192e12f76f91c8b32c2ce5e815465deef685e"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b7e67286c3ac9bf8ce0e14b33e97832e7e17f704c68a703429f6a346d2c6115f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"12613682b05457ee572fceccd28d9ca29a09a053fdc23fb03f795425e48ad214"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"53e4f261611e1d381028aadd6f0565226259704f970b8365c5ddf1ce19ad2c35"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"64093150bf36097c6dd6157723bb6e2681888ade8d6f39db9afb41932568a4a5"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"38cc5eac9182bedfee2216db49c771eda57424f34ebc47c533526acd62abb982"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"524094e0c8c8d05f465342e686dd3db382059d6729576dcf402dc0f870cbfef8"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"bbaab9089b019a51eab890348b9d25fc8f9c7a9c492736515fdb514aa864ce32"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"986606773db22de6d7cc75a541e0b73160bc4a896754e57b9ab3578a4ea52d02"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2f8abd8d586c5535063ec05c93d96f9da2e7876b6c371025ad10dbb55846ac0f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3da0ac29c51eb4c97825431fba929cb163f1b2ca71dc0bdcca574df447813966"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b8b7c21505d0dfce59e03bfde35252da1f893ba2d1214245a8e80fbdb6addee1"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"51deb5f11d29da72484d112de68af7e38e0a51818f441a6e0dd487a6031a58d2"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"830cdf7a06342b2427d9d5e48294f8259fa57303c0582fbc3da885f01da75c46"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"93e9bcc358ac2b3f36ce798d943c83e64826584fb473ff47dffc3e0306e3be70"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8021fe7fdc6d35b8c2dd27c98d90c6755ab8fd96a1e24a3fbb507cc971e985a1"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6c577fe62723fa4c687bd3dfc1f5fe1ee7f83240bd9383a66c73a60dd90d489f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4a0928ee80df4c6855a18bad05bf11e57d5989b65f9542103d04d629516afff6"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b28dc6b73a0d0924ccbdb08cc545199979680559697b0ca7cdb60647100bd2fe"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"377d1ef34a200236ae2b695b21a7040932abc16a3cb2597b618e145af5169315"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c76605420b4ba9e3829541dc626b617a1a73cc9e9fa70a10ac66b0a3cf044ae9"},"properties":{"dependency":{"package":"paste","version":"1.0.15","advisory":"RUSTSEC-2024-0436","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"20d4c7b97ca3c748d0d9617b55dafca1301717dd8ef702f04f893d70cc3a14c9"},"properties":{"dependency":{"package":"rustix","version":"1.1.4","advisory":"RUSTSEC-2026-0486","aliases":["[GHSA redacted]"],"reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"cffeb438a35296587bf5854132349f9d26eb70c572d2cd0974d8f023ab4739c5"},"properties":{"dependency":{"package":"tokio","version":"1.53.1","advisory":"RUSTSEC-2026-0386","reachability":{"kind":"unknown"}}}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 1 of 109 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 109 of the 180 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/WifiDoubleLock.kt. Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/WifiDoubleLock.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb559dc4bb87bba1dcb42dc3fa6b7654ca28c55bc93307bbcb951f02a839d534"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: NetlinkNeighbourMonitoringService.kt \u2194 NetlinkNeighbourMonitoringTileService.kt: \u0060mobile/src/main/java/be/mygod/vpnhotspot/NetlinkNeighbourMonitoringService.kt\u0060 and \u0060mobile/src/main/java/be/mygod/vpnhotspot/manage/NetlinkNeighbourMonitoringTileService.kt\u0060 change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency \u2014 the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE \u2014 the registration is the link, and it is meant not to be an import \u2014 and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are \u006018d3573a\u0060 Revert \u0022Special case stale state\u0022; \u0060088c4a2f\u0060 Special case stale state; \u006059ee36a0\u0060 Simplify flow design \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/NetlinkNeighbourMonitoringService.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"11e80f95a7492efd929a6594363b71e4494f0119727daece36036a59531c39db"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: RepeaterService.kt \u2194 WifiP2pManagerHelper.kt: \u0060mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt\u0060 and \u0060mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/WifiP2pManagerHelper.kt\u0060 change together 60% of the time (21 of the 35 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency \u2014 the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE \u2014 the registration is the link, and it is meant not to be an import \u2014 and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 21 shared commits counted here, the most recent 3 are \u00606207e45a\u0060 Fix getGroupList on Android 10; \u0060976f3c0a\u0060 Support Android 17; \u00603ef1e59e\u0060 Migrate p2p ActionListener to coroutine \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/RepeaterService.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0ed541e3eeb7d6b009c09bd2fb620bcea3bf004e453b10b7c2970d0677a79fc"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: DaemonController.kt \u2194 neighbour.rs: \u0060mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt\u0060 and \u0060mobile/src/main/rust/vpnhotspotd/src/neighbour.rs\u0060 change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit \u2014 they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary \u2014 an event or message name, a route, a serialised shape \u2014 that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other\u0027s build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are \u0060bd08af0c\u0060 Better support client display for bridged AP; \u0060e367272c\u0060 Cleanup; \u0060c2550cad\u0060 Refine error reporting \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/root/daemon/DaemonController.kt"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"04cc88e4efb80d41d35bf143b6614023a0bc355d3fec8829836555a3e3243d9a"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6b1273c81a1ca9b5eb097489b2567416912a145951451afeec807249ffa5e5b8"},"taxa":[{"id":"CICD-SEC-4","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c593d4dbd23724f337bfb8d2c1653812f143ae255bd9b59d4b3e9c37779fa6f4"},"taxa":[{"id":"CICD-SEC-3","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"P2","level":"note","message":{"text":"Logging is not universal: Only 1/2 runnable modules use logging (modules with no entry point or server are excluded \u2014 they are libraries a runnable module hosts). Silent: \u0060mobile/src/main/rust/vpnhotspotd\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"91a94e21d6d4d0e6a2003f94505b0b02b157176f0b24c4820f3f82b4447a97fe"}},{"ruleId":"P3","level":"note","message":{"text":"Dependabot does not watch gitsubmodule: \u0060.github/dependabot.yml\u0060 schedules updates, but no \u0060package-ecosystem\u0060 entry covers \u0060gitsubmodule\u0060, which this tree depends on \u2014 so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the \u0060updates:\u0060 list."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":".github/dependabot.yml"},"region":{"startLine":2}}}],"partialFingerprints":{"codehealthFindingId/v1":"189dbbebbc083d2f437329c82dc1cae8adbf1b7293a5bc9e2de708f747e84eda"}},{"ruleId":"P6","level":"note","message":{"text":"No changelog: No CHANGELOG/HISTORY/RELEASES file \u2014 what shipped when isn\u0027t easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"dda5aa5aed8cbb292c3ef2b733bc138f614293ae6426c85e98bf31ef330d9415"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!state.p2pMode \u0026\u0026 Build.VERSION.SDK_INT \u003E= 31\u0060 appears character-identically in 2 files \u2014 mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt, mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbb5449050b894c6f85c3f37d982a1e1b671c0ff77d9b82ca40d3dca75d2b694"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!state.p2pMode \u0026\u0026 Build.VERSION.SDK_INT \u003E= 33\u0060 appears character-identically in 2 files \u2014 mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt, mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/MacAddressApRow.kt. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationScreen.kt"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d54c48bf655501e881d0d6c30a4dd91e2544f73c8c55b5e254f9d5d1812d3a9"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060client.tcp.is_some() || client.udp.is_some()\u0060 appears character-identically in 2 files \u2014 mobile/src/main/rust/vpnhotspotd/src/dns.rs, mobile/src/main/rust/vpnhotspotd/src/nat66/mod.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/rust/vpnhotspotd/src/dns.rs"},"region":{"startLine":148}}}],"partialFingerprints":{"codehealthFindingId/v1":"0361e3a08f59ee3ab7741f8a5732d33dde205ae5ccb00b6b1a2fced949b37d3b"}},{"ruleId":"X2","level":"note","message":{"text":"Not all suspend functions that make a request accept the coroutine\u0027s cancellation: Only 0/1 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine\u0027s cancellation or pass one on, so a request keeps running after whatever wanted it has given up \u2014 a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends \u2014 Ktor, OkHttp\u0027s \u0060executeAsync()\u0060, or a \u0060suspendCancellableCoroutine\u0060 that cancels the \u0060Call\u0060 \u2014 not a blocking \u0060execute()\u0060: \u0060withContext(Dispatchers.IO)\u0060 moves the call off the caller\u0027s thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice \u2014 judge against how the function is used."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"97a0137a13dc63b0e07ec4e232770b687c26a8a2030f49787e45a4506416c527"}},{"ruleId":"X2","level":"warning","message":{"text":"Suspend function with a blocking request: connectCancellable: \u0060connectCancellable\u0060 suspends, but makes its request with \u0060URL(\u2026).openConnection()\u0060, which blocks: its caller\u0027s cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up \u2014 \u0060withContext(Dispatchers.IO)\u0060 moves it off the caller\u0027s thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp\u0027s \u0060executeAsync()\u0060, or a \u0060suspendCancellableCoroutine\u0060 over \u0060enqueue\u0060 that cancels the \u0060Call\u0060 in \u0060invokeOnCancellation\u0060."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/util/Utils.kt"},"region":{"startLine":294}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e0497f1a3ec424a7f919cebf65d4190261073365ccab4f26cbee51ef5c9ff5a"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/util/Utils.kt"},"region":{"startLine":193}}}],"partialFingerprints":{"codehealthFindingId/v1":"a07f6900234e076e1f95b8d77c305e3785ac1521ebeea6d933a1f31868330887"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (_: RuntimeException)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f6952d8b9c08f313626bceb5dbe7cf95d8cd46d30270d1b5190955265e4ca8d"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on parse failure: \u0060ssidByteCount\u0060 answers \u00600\u0060 when \u0060IllegalArgumentException\u0060 is thrown, with no log or throw \u2014 a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"mobile/src/main/java/be/mygod/vpnhotspot/ui/apconfiguration/ApConfigurationState.kt"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"423f15175766df99f5403ccd5a95afe63102a84894f64f33925d55c8a0062556"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1357","guid":"e4d2e772-757e-0a5c-bd7d-77052949d866","name":"Reliance on Insufficiently Trustworthy Component","shortDescription":{"text":"Reliance on Insufficiently Trustworthy Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1357.html"},{"id":"CWE-1395","guid":"800e09e7-c11a-8654-9fa6-86f398995fed","name":"Dependency on Vulnerable Third-Party Component","shortDescription":{"text":"Dependency on Vulnerable Third-Party Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1395.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-353","guid":"09d7e902-d4ee-f05d-ae6c-0a1554d0c18f","name":"Missing Support for Integrity Check","shortDescription":{"text":"Missing Support for Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/353.html"},{"id":"CWE-494","guid":"b8a65e0d-e459-4a55-a931-fc1136482375","name":"Download of Code Without Integrity Check","shortDescription":{"text":"Download of Code Without Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/494.html"},{"id":"CWE-506","guid":"401d6455-56e3-0552-9a39-f77461673e3f","name":"Embedded Malicious Code","shortDescription":{"text":"Embedded Malicious Code"},"helpUri":"https://cwe.mitre.org/data/definitions/506.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-829","guid":"13c33925-97fb-5a5e-b40c-56d328b8a4d7","name":"Inclusion of Functionality from Untrusted Control Sphere","shortDescription":{"text":"Inclusion of Functionality from Untrusted Control Sphere"},"helpUri":"https://cwe.mitre.org/data/definitions/829.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-937","guid":"16f316ae-415c-b354-a59b-1f7905f756e9","name":"Using Components with Known Vulnerabilities","shortDescription":{"text":"Using Components with Known Vulnerabilities"},"helpUri":"https://cwe.mitre.org/data/definitions/937.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A03:2025","guid":"168e227c-7735-2e57-bc6e-997affe644c5","name":"Software Supply Chain Failures","shortDescription":{"text":"Software Supply Chain Failures"},"helpUri":"https://top10.owasp.org/2025/A03_2025-Software_Supply_Chain_Failures/"},{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"},{"id":"A08:2025","guid":"84b0c297-710e-9a5f-9335-936ecb260c36","name":"Software or Data Integrity Failures","shortDescription":{"text":"Software or Data Integrity Failures"},"helpUri":"https://top10.owasp.org/2025/A08_2025-Software_or_Data_Integrity_Failures/"}]},{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35","organization":"OWASP Foundation","informationUri":"https://owasp.org/www-project-top-10-ci-cd-security-risks/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10 CI/CD Security Risks."},"taxa":[{"id":"CICD-SEC-3","guid":"458c83a6-ebf7-cf55-8cc3-b4d949bbf271","name":"Dependency Chain Abuse","shortDescription":{"text":"Dependency Chain Abuse"},"helpUri":"https://owasp.github.io/www-project-top-10-ci-cd-security-risks/CICD-SEC-03-Dependency-Chain-Abuse"},{"id":"CICD-SEC-4","guid":"c859d8ea-8b24-a157-9406-94929c10397a","name":"Poisoned Pipeline Execution (PPE)","shortDescription":{"text":"Poisoned Pipeline Execution (PPE)"},"helpUri":"https://owasp.github.io/www-project-top-10-ci-cd-security-risks/CICD-SEC-04-Poisoned-Pipeline-Execution"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":26,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}