{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D14","name":"License Compliance","shortDescription":{"text":"License Compliance"},"helpUri":"https://codehealth.canine.dev/dimensions/D14"},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D30","name":"Dependency Vulnerabilities","shortDescription":{"text":"Dependency Vulnerabilities"},"helpUri":"https://codehealth.canine.dev/dimensions/D30","relationships":[{"target":{"id":"CWE-1395","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-937","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1395","CWE-937"],"owasp":"A03:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D36","name":"Supply-chain Provenance \u0026 Signing","shortDescription":{"text":"Supply-chain Provenance \u0026 Signing"},"helpUri":"https://codehealth.canine.dev/dimensions/D36","relationships":[{"target":{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1357","CWE-494"],"owasp":"A03:2025"}},{"id":"D43","name":"Malicious Dependencies","shortDescription":{"text":"Malicious Dependencies"},"helpUri":"https://codehealth.canine.dev/dimensions/D43","relationships":[{"target":{"id":"CWE-506","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A08:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-506"],"owasp":"A08:2025"}},{"id":"D44","name":"Platform End-of-Life","shortDescription":{"text":"Platform End-of-Life"},"helpUri":"https://codehealth.canine.dev/dimensions/D44"},{"id":"AC1","name":"Text alternatives","shortDescription":{"text":"Text alternatives"},"helpUri":"https://codehealth.canine.dev/dimensions/AC1"},{"id":"AC2","name":"Forms \u0026 labels","shortDescription":{"text":"Forms \u0026 labels"},"helpUri":"https://codehealth.canine.dev/dimensions/AC2"},{"id":"AC3","name":"Page structure","shortDescription":{"text":"Page structure"},"helpUri":"https://codehealth.canine.dev/dimensions/AC3"},{"id":"AC5","name":"ARIA correctness","shortDescription":{"text":"ARIA correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/AC5"},{"id":"AC6","name":"Visual \u0026 motion safety","shortDescription":{"text":"Visual \u0026 motion safety"},"helpUri":"https://codehealth.canine.dev/dimensions/AC6"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX9","name":"CQS / query purity","shortDescription":{"text":"CQS / query purity"},"helpUri":"https://codehealth.canine.dev/dimensions/AX9"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"ES2","name":"Immutable events","shortDescription":{"text":"Immutable events"},"helpUri":"https://codehealth.canine.dev/dimensions/ES2"},{"id":"GD1","name":"Unfinished \u0026 placeholder code","shortDescription":{"text":"Unfinished \u0026 placeholder code"},"helpUri":"https://codehealth.canine.dev/dimensions/GD1"},{"id":"IC1","name":"Incompleteness \u0026 stubs","shortDescription":{"text":"Incompleteness \u0026 stubs"},"helpUri":"https://codehealth.canine.dev/dimensions/IC1"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P10","name":"Library API \u0026 versioning","shortDescription":{"text":"Library API \u0026 versioning"},"helpUri":"https://codehealth.canine.dev/dimensions/P10"},{"id":"P12","name":"CI test-gate honesty","shortDescription":{"text":"CI test-gate honesty"},"helpUri":"https://codehealth.canine.dev/dimensions/P12"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P4","name":"Deployment \u0026 Rollback","shortDescription":{"text":"Deployment \u0026 Rollback"},"helpUri":"https://codehealth.canine.dev/dimensions/P4"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"X1","name":"Async correctness","shortDescription":{"text":"Async correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X1"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X12","name":"Unreachable branch","shortDescription":{"text":"Unreachable branch"},"helpUri":"https://codehealth.canine.dev/dimensions/X12"},{"id":"X13","name":"Undrained process stream","shortDescription":{"text":"Undrained process stream"},"helpUri":"https://codehealth.canine.dev/dimensions/X13"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X15","name":"Unvalidated length from an untrusted reader","shortDescription":{"text":"Unvalidated length from an untrusted reader"},"helpUri":"https://codehealth.canine.dev/dimensions/X15"},{"id":"X16","name":"Unfloored truncation loop","shortDescription":{"text":"Unfloored truncation loop"},"helpUri":"https://codehealth.canine.dev/dimensions/X16"},{"id":"X17","name":"Uncapped recursion over a caller-supplied document","shortDescription":{"text":"Uncapped recursion over a caller-supplied document"},"helpUri":"https://codehealth.canine.dev/dimensions/X17"},{"id":"X18","name":"Disposal-pattern correctness","shortDescription":{"text":"Disposal-pattern correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X18"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X23","name":"Unguarded diagnostic materialisation","shortDescription":{"text":"Unguarded diagnostic materialisation"},"helpUri":"https://codehealth.canine.dev/dimensions/X23"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X27","name":"Collection changed while being enumerated","shortDescription":{"text":"Collection changed while being enumerated"},"helpUri":"https://codehealth.canine.dev/dimensions/X27"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X29","name":"Per-element action decided by a fixed element","shortDescription":{"text":"Per-element action decided by a fixed element"},"helpUri":"https://codehealth.canine.dev/dimensions/X29"},{"id":"X30","name":"Support guard that admits what it rejects","shortDescription":{"text":"Support guard that admits what it rejects"},"helpUri":"https://codehealth.canine.dev/dimensions/X30"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X4","name":"Structured logging","shortDescription":{"text":"Structured logging"},"helpUri":"https://codehealth.canine.dev/dimensions/X4"},{"id":"X5","name":"Nullable reference types","shortDescription":{"text":"Nullable reference types"},"helpUri":"https://codehealth.canine.dev/dimensions/X5"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::app::run (cyclomatic 67): fw::tasks::app::run has cyclomatic complexity 67 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5f1111d61204f447f84ab729a631c38752db9eeb916e2c1f6cc42d637f859a4"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::display::run (cyclomatic 60): fw::tasks::display::run has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"73a3920e15d3afc1379970c434d7954e2b65eeea127dda9f01d58434e6fbf2e0"}},{"ruleId":"D1","level":"warning","message":{"text":"ReaderState::apply_library_event (cyclomatic 52): ReaderState::apply_library_event has cyclomatic complexity 52 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1171}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9b057000a277ca65078b622bf82a2aebb631df09120670e8517d2c63f5251b3"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::display::handle_storage_command (cyclomatic 52): fw::tasks::display::handle_storage_command has cyclomatic complexity 52 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1019}}}],"partialFingerprints":{"codehealthFindingId/v1":"41584c8aa48b497b8f7d5c1aa11a3349a52ad97932440cfb6d41b284fb48d607"}},{"ruleId":"D1","level":"warning","message":{"text":"ReaderState::apply_input (cyclomatic 46): ReaderState::apply_input has cyclomatic complexity 46 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":936}}}],"partialFingerprints":{"codehealthFindingId/v1":"378164151422a2fd21d0b5ac15ef59e8f03b24311373b96118119dc0d523ee7b"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache::build_or_load_epub_cache_from_zip (cyclomatic 40): fw::reader_cache::build_or_load_epub_cache_from_zip has cyclomatic complexity 40 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1523}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbce15cc79d4202de78ee0b528a3ad511e635c529f71cfa1194248c2bb53ef10"}},{"ruleId":"D1","level":"warning","message":{"text":"XhtmlBlockStreamParser::handle_start_tag (cyclomatic 35): XhtmlBlockStreamParser::handle_start_tag has cyclomatic complexity 35 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3062}}}],"partialFingerprints":{"codehealthFindingId/v1":"41907bbda03fd3a4a62afef9bfbad95d6a941f9b8070bc5353c729cc0e360db6"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache_files::load_v2_book_index (cyclomatic 33): fw::reader_cache_files::load_v2_book_index has cyclomatic complexity 33 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":795}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba05ce3f2d3dbfa3cd8cea099c88ba6bba35cb8a66b80bd855d0af7b72d9d780"}},{"ruleId":"D1","level":"warning","message":{"text":"OpfCollector::handle (cyclomatic 30): OpfCollector::handle has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":2697}}}],"partialFingerprints":{"codehealthFindingId/v1":"de3d779ed7981f60367d23b5d2b423a941d7ab15a3012ac82b35153d3a42598d"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::epub::parse_epub3_nav_to_sink (cyclomatic 29): proto::epub::parse_epub3_nav_to_sink has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3342}}}],"partialFingerprints":{"codehealthFindingId/v1":"f09bc04b4be79c4c667375a6a89f879bc14162d6ce81deb78ca37c9a9db3ead8"}},{"ruleId":"D1","level":"warning","message":{"text":"LineWindow::relax_from (cyclomatic 27): LineWindow::relax_from has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":991}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a9602656f0956dd28e1f6b5b339e227a69ef12d09ccbb746a8b7b5869895195"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::block_sink::push_styled_preview_fragment (cyclomatic 26): fw::block_sink::push_styled_preview_fragment has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1306}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a84f3f49ab1b915b39d6fc43b8026965c56f3e47a1c94511a56bac9ebcf1405"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache_files::read_section_page_images (cyclomatic 26): fw::reader_cache_files::read_section_page_images has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1473}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b4038767710372053cf1daeb8adc71387ef31c475b24f5dbc46a1630960f801"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache_files::reflow_book_spacing (cyclomatic 26): fw::reader_cache_files::reflow_book_spacing has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":2581}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f5c948b62e179af97a95084ad53c6a53eebf67f3cbc4a9454f6dca848484aee"}},{"ruleId":"D1","level":"warning","message":{"text":"StreamingXmlTokenizer::consume (cyclomatic 26): StreamingXmlTokenizer::consume has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3659}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ab8f1f9a70e88d8d747e001f58c96705ff75a51465942cd9e4e1c5ddbb84edb"}},{"ruleId":"D1","level":"warning","message":{"text":"OpfCollector::handle_item (cyclomatic 24): OpfCollector::handle_item has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":2762}}}],"partialFingerprints":{"codehealthFindingId/v1":"da0170d285982111fd0ff41c0fb93ce96d2592434aba5561dbba274fb8d89509"}},{"ruleId":"D1","level":"warning","message":{"text":"Epub3NavStreamParser::handle (cyclomatic 22): Epub3NavStreamParser::handle has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3982}}}],"partialFingerprints":{"codehealthFindingId/v1":"c07c14e2fcd8d9727a75007837e1e29bfeb8454be6f1a38a54cd4c8ea3e18fa2"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::epub::tag_has_attr (cyclomatic 22): proto::epub::tag_has_attr has cyclomatic complexity 22 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4321}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddb367918612593a542e2952b6ef486f51245a5228f6c09990021319b6aa451f"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache_files::write_v2_book_index (cyclomatic 21): fw::reader_cache_files::write_v2_book_index has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1293}}}],"partialFingerprints":{"codehealthFindingId/v1":"acf766585256a22b5c7e1240837c7569ccfba88d95a02eb7644290fba25c94e3"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::wifi::upload_server (cyclomatic 21): fw::tasks::wifi::upload_server has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":272}}}],"partialFingerprints":{"codehealthFindingId/v1":"927d7f951f348133bac6eba8cdc4191981faf5b7a0654835f1c94513f494a828"}},{"ruleId":"D1","level":"warning","message":{"text":"app_core::apply_setting (cyclomatic 20): app_core::apply_setting has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1733}}}],"partialFingerprints":{"codehealthFindingId/v1":"72fb56501b7e2ccbbf08e562ed90a2b2e748c7df222819484ac795332a20228d"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::display::prepare_while_idle (cyclomatic 20): fw::tasks::display::prepare_while_idle has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":752}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a00390f7d3b878d3e2fbe3f650721ef06af0f7b62928b90e34e60c90201bce3"}},{"ruleId":"D1","level":"warning","message":{"text":"Head::take (cyclomatic 20): Head::take has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":460}}}],"partialFingerprints":{"codehealthFindingId/v1":"d378e91a3372182cff89c7cc4bb7dbc8b6a6d2c4e1bcb3c6b7b99a77e6a2498a"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::block_sink::place_inline_image (cyclomatic 19): fw::block_sink::place_inline_image has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1734}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7f685356630dfbc76e0db96663c138d76b0452182026cacfd4237d6baa81d12"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::image_decode::decode_jpeg (cyclomatic 19): fw::image_decode::decode_jpeg has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":1064}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1f77cf7e13eac2e48a68de0cb9a56c33615ec4f398a7f8f666d6b199283d402"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::reader_cache::lay_out_spine (cyclomatic 19): fw::reader_cache::lay_out_spine has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file\u0027s highest cyclomatic complexity: fw::reader_cache::set_preview_error_from_error (cyclomatic 22) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded function is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2184}}}],"partialFingerprints":{"codehealthFindingId/v1":"9176ba97fd19149b0d92cd66f5696926a5191dd23ff2e59457a612bd8c14fc6f"}},{"ruleId":"D1","level":"warning","message":{"text":"XhtmlBlockStreamParser::handle_end (cyclomatic 18): XhtmlBlockStreamParser::handle_end has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3177}}}],"partialFingerprints":{"codehealthFindingId/v1":"6077fecfeedc2049714197f50da7fd8fc3999e4c687ba46fdc3c5b7437f97c08"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::image::png::accumulate (cyclomatic 18): proto::image::png::accumulate has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":1153}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a860b1b3df4f39071259c5d8b430c2107f5ae3a856ec1326c516b91de39bb8a"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::ota::validate_image (cyclomatic 18): proto::ota::validate_image has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/ota.rs"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"0510f6a42f2b3ebc7a8fd4e07e58a7be25f3f29aed33ee7962cddf5ec728afb8"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::input::run (cyclomatic 17): fw::tasks::input::run has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f27cedd0f29b36033db51f0a386eb7f16ec5aaf3d97e806ff83dbbb3e5d8787"}},{"ruleId":"D1","level":"warning","message":{"text":"Head::begin_segment (cyclomatic 17): Head::begin_segment has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fa45b71f4759ef764314b26b767fc439ea5eb86db63a2f5e62d251f2bbdf94a"}},{"ruleId":"D1","level":"warning","message":{"text":"PngDecoder::start (cyclomatic 17): PngDecoder::start has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":793}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b3e179ac2e829daeaef676ccb7ee9d33258d62651f7562224d472083caae7cb"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::upload::wireless_epub_filename (cyclomatic 17): proto::upload::wireless_epub_filename has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/upload.rs"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"3bfb81c1c7e16a62de9565aede9131aac5455646e8a1133cb158e41ee573a8b8"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::app::storage_command_for_transition (cyclomatic 16): fw::tasks::app::storage_command_for_transition has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":729}}}],"partialFingerprints":{"codehealthFindingId/v1":"99f72a69863bb842fa3fd25341417e12b15958833bf334d0140663f6eb3380eb"}},{"ruleId":"D1","level":"warning","message":{"text":"fw::tasks::bench_serial::run (cyclomatic 16): fw::tasks::bench_serial::run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/bench_serial.rs"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9e36b3c31f4306b9ae699e1ce18fcfd30b4df241036c46ffb6463c026a1d9ff"}},{"ruleId":"D1","level":"warning","message":{"text":"StreamingXmlTokenizer::flush_text (cyclomatic 16): StreamingXmlTokenizer::flush_text has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3783}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0b22d0b2a7c1df188e287714d3c2df6247696b7daffa824ec443c5f3a2ce15d"}},{"ruleId":"D1","level":"warning","message":{"text":"PngDecoder::begin_chunk (cyclomatic 16): PngDecoder::begin_chunk has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":600}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cac2a899d6f2b3bad2308b5c22f98eeaad2f16faf00d9d69e2d367a394e835e"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::epub::parse_epub2_ncx_to_sink (cyclomatic 16): proto::epub::parse_epub2_ncx_to_sink has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3426}}}],"partialFingerprints":{"codehealthFindingId/v1":"8463eba1091e76e3b815e1b64e4e1b2b3544417a5f3f68594c8c22da2247e5fd"}},{"ruleId":"D1","level":"warning","message":{"text":"proto::image::index::open_image_index (cyclomatic 16): proto::image::index::open_image_index has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/index.rs"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"595a7fe77d33bce197cdc5441195a5025d70487954114ff8e8288efe9c4a7284"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::app::run (cognitive 175): fw::tasks::app::run has cognitive complexity 175 (threshold 15). Drivers by points: if/else 51 (155 pts), boolean chains 12, match/switch 3 (7 pts), loops 1 (nesting depth added 108). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"856d9a0f769fef5ed76ec3d7c0e95507d686cce3bd01ccc36fbda625e89cc943"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::display::run (cognitive 148): fw::tasks::display::run has cognitive complexity 148 (threshold 15). Drivers by points: if/else 42 (120 pts), match/switch 7 (16 pts), boolean chains 10, loops 2 (nesting depth added 87). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"05e12961a98033c7e696649a40c3cfaf1c32532a0a99d312dc6921842d51182b"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::display::handle_storage_command (cognitive 83): fw::tasks::display::handle_storage_command has cognitive complexity 83 (threshold 15). Drivers by points: if/else 33 (70 pts), boolean chains 9, match/switch 2 (4 pts) (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1019}}}],"partialFingerprints":{"codehealthFindingId/v1":"00a3fee1997c60407c4149627a7a78c9e9bbaf580ebc49c69c5df32b45940a0b"}},{"ruleId":"D2","level":"warning","message":{"text":"ReaderState::apply_library_event (cognitive 81): ReaderState::apply_library_event has cognitive complexity 81 (threshold 15). Drivers by points: if/else 37 (74 pts), boolean chains 6, match/switch 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1171}}}],"partialFingerprints":{"codehealthFindingId/v1":"920eea94e8c96fccca788fae5394f4b9136240d0052fbd96369627ad2409280e"}},{"ruleId":"D2","level":"warning","message":{"text":"LineWindow::relax_from (cognitive 71): LineWindow::relax_from has cognitive complexity 71 (threshold 15). Drivers by points: if/else 24 (58 pts), boolean chains 6, loops 2 (5 pts), match/switch 1 (2 pts) (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":991}}}],"partialFingerprints":{"codehealthFindingId/v1":"51c5c68c61ed3dee601d19ddfee46e2f6161787afe552017d546620d4ce4fdea"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::build_or_load_epub_cache_from_zip (cognitive 54): fw::reader_cache::build_or_load_epub_cache_from_zip has cognitive complexity 54 (threshold 15). Drivers by points: if/else 28 (32 pts), match/switch 5 (10 pts), boolean chains 9, loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1523}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc03943fff2790d2e0dd3c7790d45b271e1df2628e3c3bb076c6bddd9672bc0a"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::wifi::upload_server (cognitive 52): fw::tasks::wifi::upload_server has cognitive complexity 52 (threshold 15). Drivers by points: if/else 20 (44 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":272}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e4df7da0b644e79e4578570169642bc8937fe45d07dc1c29537e7df86c25aab"}},{"ruleId":"D2","level":"warning","message":{"text":"StreamingXmlTokenizer::consume (cognitive 48): StreamingXmlTokenizer::consume has cognitive complexity 48 (threshold 15). Drivers by points: if/else 14 (28 pts), loops 3 (10 pts), match/switch 4 (8 pts), boolean chains 2 (nesting depth added 25). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3659}}}],"partialFingerprints":{"codehealthFindingId/v1":"13cbd382543709b4501ef75ab91a1e94660f6a0f09abd60d98e35731cadea1b4"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache_files::reflow_book_spacing (cognitive 44): fw::reader_cache_files::reflow_book_spacing has cognitive complexity 44 (threshold 15). Drivers by points: if/else 15 (33 pts), boolean chains 8, loops 2 (3 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":2581}}}],"partialFingerprints":{"codehealthFindingId/v1":"162a3879edd9b4c080adebdf1373c2d24d1c58fd2adfdc1ab6986a96d539bf05"}},{"ruleId":"D2","level":"warning","message":{"text":"XhtmlBlockStreamParser::handle_start_tag (cognitive 44): XhtmlBlockStreamParser::handle_start_tag has cognitive complexity 44 (threshold 15). Drivers by points: if/else 25 (33 pts), boolean chains 11 (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3062}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8f555801a9853dab4289094812745ef6602327944e4636d5dab88bfb3f25748"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache_files::read_section_page_images (cognitive 42): fw::reader_cache_files::read_section_page_images has cognitive complexity 42 (threshold 15). Drivers by points: if/else 16 (30 pts), boolean chains 5, match/switch 1 (4 pts), loops 2 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1473}}}],"partialFingerprints":{"codehealthFindingId/v1":"2afb5afec39b00eaf3e8b3d40ca2fd6a73b58962515582e41cf81bbdcce37633"}},{"ruleId":"D2","level":"warning","message":{"text":"StreamingXmlTokenizer::flush_text (cognitive 41): StreamingXmlTokenizer::flush_text has cognitive complexity 41 (threshold 15). Drivers by points: if/else 13 (37 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3783}}}],"partialFingerprints":{"codehealthFindingId/v1":"2652ff265da2b6e6bff2c2453c80a255f8840b39558ffda8094c7375770f828c"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache_files::load_v2_book_index (cognitive 40): fw::reader_cache_files::load_v2_book_index has cognitive complexity 40 (threshold 15). Drivers by points: if/else 23 (29 pts), boolean chains 8, loops 1 (2 pts), match/switch 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":795}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cf446fcef9e36b6b49ed07c31ccf7956f725c95f359ad76f6971df737843b7d"}},{"ruleId":"D2","level":"warning","message":{"text":"Head::take (cognitive 40): Head::take has cognitive complexity 40 (threshold 15). Drivers by points: if/else 14 (37 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":460}}}],"partialFingerprints":{"codehealthFindingId/v1":"e801e2ffeb3d486dc4f9f37ff61b136516ecd606d510d05f6d7985c52f84956c"}},{"ruleId":"D2","level":"warning","message":{"text":"OpfCollector::handle (cognitive 38): OpfCollector::handle has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (26 pts), boolean chains 8, match/switch 2 (4 pts) (nesting depth added 11). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":2697}}}],"partialFingerprints":{"codehealthFindingId/v1":"33f7dc4c1fed27b11103fcd4d619fc509570cc6b2ab615c5ee64551294df730f"}},{"ruleId":"D2","level":"warning","message":{"text":"ReaderState::apply_input (cognitive 37): ReaderState::apply_input has cognitive complexity 37 (threshold 15). Drivers by points: if/else 18 (32 pts), match/switch 3 (5 pts) (nesting depth added 16). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":936}}}],"partialFingerprints":{"codehealthFindingId/v1":"67849ff81b83f28c52be51cac092db24d82684c0aa7af35b0ad89e5196a07800"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::tag_has_attr (cognitive 36): proto::epub::tag_has_attr has cognitive complexity 36 (threshold 15). Drivers by points: loops 7 (18 pts), boolean chains 10, if/else 3 (5 pts), match/switch 1 (3 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4321}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3e324525ca565ff47b702f65c35d5d446ee072bad2cc65d1e6009857fafbf75"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::image::jpeg::decode_block (cognitive 35): proto::image::jpeg::decode_block has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (29 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":984}}}],"partialFingerprints":{"codehealthFindingId/v1":"01c59d4c1a6db56b2054e75f0a230fcf5b9ffc9a26be54ad60c17777dab058fd"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::block_sink::push_styled_preview_fragment (cognitive 33): fw::block_sink::push_styled_preview_fragment has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14 (19 pts), boolean chains 11, loops 2 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1306}}}],"partialFingerprints":{"codehealthFindingId/v1":"12e06bb6869ea4720b56700195861b93297524ed6d31570470b06be90a1cc503"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::bench_serial::run (cognitive 33): fw::tasks::bench_serial::run has cognitive complexity 33 (threshold 15). Drivers by points: if/else 10 (23 pts), loops 3 (5 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/bench_serial.rs"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6840f4c4a312cb8773cd1051cc7f3476a8ef54bf383e5fb538a4378b42ee271"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::input::run (cognitive 32): fw::tasks::input::run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 16 (28 pts), boolean chains 3, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"87718a37b8c92819032a751fb335282423880959e1d373d1e8033e0797fd37c6"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::inflate_chunks_to_sink (cognitive 31): proto::epub::inflate_chunks_to_sink has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (23 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1212}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe50e2c2116de53951b2b0002632cd05b42415757a31ba830a803fb1a6003e50"}},{"ruleId":"D2","level":"warning","message":{"text":"OpfCollector::handle_item (cognitive 29): OpfCollector::handle_item has cognitive complexity 29 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 9, match/switch 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":2762}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7c5dde50fd162ffede87e54663da8e42823b1be86cfe1dcd0973f21d72838e1"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::block_sink::place_inline_image (cognitive 28): fw::block_sink::place_inline_image has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 8, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1734}}}],"partialFingerprints":{"codehealthFindingId/v1":"97d730a8a27c4eec99eef381929d5f916c30ccc65c4dc2fb70b6729ff4858a44"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::display::prepare_while_idle (cognitive 28): fw::tasks::display::prepare_while_idle has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (23 pts), boolean chains 5 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":752}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb29d753cbac84679a8a442ae4f1a257e2cfdc58933b6d127cd1ec96aee440e6"}},{"ruleId":"D2","level":"warning","message":{"text":"JpegDecoder::decode_mcus (cognitive 28): JpegDecoder::decode_mcus has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (24 pts), boolean chains 3, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1570}}}],"partialFingerprints":{"codehealthFindingId/v1":"60f2c0475c012231eb6d55fd72f8533e7401e3d4bbfb8fe56f8a7f5b9a9abf1d"}},{"ruleId":"D2","level":"warning","message":{"text":"LineWindow::relax (cognitive 27): LineWindow::relax has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16 (27 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":1166}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c51308d886c4a71b88152d9e08806e0841188ad7db3f07a7c08abfc0dc5a248"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::image_decode::decode_jpeg (cognitive 27): fw::image_decode::decode_jpeg has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (18 pts), match/switch 3 (5 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":1064}}}],"partialFingerprints":{"codehealthFindingId/v1":"3689973f5bee9803ab62085ac406570463397e1f039bb1fbf9bf75a41a00ee58"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::lay_out_spine (cognitive 27): fw::reader_cache::lay_out_spine has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (24 pts), match/switch 2, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2184}}}],"partialFingerprints":{"codehealthFindingId/v1":"a72a7d0fad42c2e6af73b9e1c410b89c4886eaf15e6747b8c6d40a03c93b3834"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::inflate_chunks_prefix (cognitive 27): proto::epub::inflate_chunks_prefix has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1292}}}],"partialFingerprints":{"codehealthFindingId/v1":"c21ab794b0ea84003156c3d82b4b9ba69cb6165e72ddd881ea73be267a7c9980"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::library_sd::sweep_orphan_caches (cognitive 26): fw::library_sd::sweep_orphan_caches has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":717}}}],"partialFingerprints":{"codehealthFindingId/v1":"13ea47b2aec13d1208a2009abb2ce7573268d67227c5878b4d6cf9a6293f4bcd"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::parse_epub3_nav_to_sink (cognitive 26): proto::epub::parse_epub3_nav_to_sink has cognitive complexity 26 (threshold 15). Drivers by points: if/else 4 (13 pts), boolean chains 10, match/switch 1 (2 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3342}}}],"partialFingerprints":{"codehealthFindingId/v1":"f978b36f5df5859a28ae94c77028e58d31714df158ddde0c136158df5550ce8d"}},{"ruleId":"D2","level":"warning","message":{"text":"JpegDecoder::start_scan (cognitive 25): JpegDecoder::start_scan has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 4 (10 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1431}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce7d64191c9f5ddb8d99d144761b5228410ab81bdabfb26ec2f562213d5a4cd1"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::ota::validate_image (cognitive 25): proto::ota::validate_image has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/ota.rs"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"3405c85fc3dbfaf138f130aa4ab253e9b0ce4cf591ae9b0dbff798ffad8ecea3"}},{"ruleId":"D2","level":"warning","message":{"text":"ReaderStore::requested_page (cognitive 24): ReaderStore::requested_page has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (19 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":1529}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4289b0dc3720cc2a4f9055ca2a18597cede5855d653a1943852733a48f8d668"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::upload::wireless_epub_filename (cognitive 24): proto::upload::wireless_epub_filename has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 5, match/switch 2 (4 pts), loops 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/upload.rs"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cd8d9c41920356d23672820b8e87c132c5d6e738eaffb5915461349461f039e"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::sd_session::write_one_book (cognitive 23): fw::sd_session::write_one_book has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 3 (5 pts), boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":743}}}],"partialFingerprints":{"codehealthFindingId/v1":"95f54ccecd06db4fd22751b375aa0349c0e2da76a4a1ba5c81d773b0962d0ae6"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::hyphen::word_breaks (cognitive 23): proto::hyphen::word_breaks has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 4 (6 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/hyphen.rs"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cb2bdd2bc200140bbb646f7277d9d8fd434eb5dfc8e27488588d159dd4386d4"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache_files::write_v2_book_index (cognitive 22): fw::reader_cache_files::write_v2_book_index has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 8, loops 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1293}}}],"partialFingerprints":{"codehealthFindingId/v1":"f67200ae65c7139229efb740efe5b9e35beae8e73b80532f28b816b7fbf059df"}},{"ruleId":"D2","level":"warning","message":{"text":"ZipStream::for_each_entry (cognitive 22): ZipStream::for_each_entry has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":497}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbcfabca4214c51d32bf5ceb3620c929580b951f8e5c36cbe949634559565e4d"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::append_text_to_sink_block (cognitive 22): proto::epub::append_text_to_sink_block has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (20 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4593}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cdeba9ae460a43e8a2b581760610accad3d321e35df8d45ef7f854f4f35075a"}},{"ruleId":"D2","level":"warning","message":{"text":"Framebuffer::blit (cognitive 21): Framebuffer::blit has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 4 (9 pts), boolean chains 1, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/fb/blit.rs"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1af36408189d33b32f21824949e022421bd78582e95e2ce039e67049eba63f2"}},{"ruleId":"D2","level":"warning","message":{"text":"ImageSession::decode_nearest (cognitive 21): ImageSession::decode_nearest has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":677}}}],"partialFingerprints":{"codehealthFindingId/v1":"8af22940f71ac3aef176c0092e4a175acbb5422f16b275819726efa1ec15d1ac"}},{"ruleId":"D2","level":"warning","message":{"text":"Head::begin_segment (cognitive 21): Head::begin_segment has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (15 pts), boolean chains 6 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cc277212199ba42b5dc8b8d4488788b8a9237fcdc8d079adadca87c1bbb494a"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::decode_images_while_idle (cognitive 20): fw::reader_cache::decode_images_while_idle has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 3, match/switch 3, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":757}}}],"partialFingerprints":{"codehealthFindingId/v1":"a88c2b07c4dacb9d7414ded9a075c070b769de87fab8063ce6eddfdfec8d18d4"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::bench_unplug::measure (cognitive 20): fw::tasks::bench_unplug::measure has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 4 (8 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/bench_unplug.rs"},"region":{"startLine":196}}}],"partialFingerprints":{"codehealthFindingId/v1":"c58195795707345a9e466412b0977a21cc44c32224f2a74b7b071d01a31d8e9b"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::wifi::credential_portal (cognitive 20): fw::tasks::wifi::credential_portal has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":648}}}],"partialFingerprints":{"codehealthFindingId/v1":"676af13d097daaa757417964a1ac9c2d916c84f843728dd247924160b440499e"}},{"ruleId":"D2","level":"warning","message":{"text":"Bits::refill (cognitive 20): Bits::refill has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":778}}}],"partialFingerprints":{"codehealthFindingId/v1":"011a569d663f6fe9957e1f5f50562c02bda4f0784d31b666bd9d20d8223f62ff"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::build_or_load_book_cache_from_root (cognitive 19): fw::reader_cache::build_or_load_book_cache_from_root has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (11 pts), match/switch 3 (7 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":280}}}],"partialFingerprints":{"codehealthFindingId/v1":"85a69a425ae15e188bd3633c023887a2d6e0806315b0af10721b0d46ada3192b"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::app::storage_command_for_transition (cognitive 19): fw::tasks::app::storage_command_for_transition has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":729}}}],"partialFingerprints":{"codehealthFindingId/v1":"115e3bcc50d9397f8b4d800667ea01f78c414e78d56de11c40a534c2e51b8b0d"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::tasks::wifi::stream_book (cognitive 19): fw::tasks::wifi::stream_book has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 3 (7 pts), boolean chains 4, if/else 3 (4 pts), loops 3 (4 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":421}}}],"partialFingerprints":{"codehealthFindingId/v1":"86d4dcbd50bd9fb872b4fa9af7dbd265be698c956c27832abca507e87569119b"}},{"ruleId":"D2","level":"warning","message":{"text":"XmlCursor::next_token (cognitive 19): XmlCursor::next_token has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (17 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"5066aa2e9f6f1295e8e5eead32bf4fa7264cc9f5eabd5b317725c62eba4a821c"}},{"ruleId":"D2","level":"warning","message":{"text":"JpegDecoder::filter_across (cognitive 19): JpegDecoder::filter_across has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 3 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1685}}}],"partialFingerprints":{"codehealthFindingId/v1":"96da3e43d6c52e5c09f4b4dd1df9437d1586e0c845d303da9314f0f901dbb8d9"}},{"ruleId":"D2","level":"warning","message":{"text":"display::epd::fill_transformed_band_impl (cognitive 18): display::epd::fill_transformed_band_impl has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (9 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 6). Of this number, 15 points are the body\u0027s own statements and 3 belong to one function item inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/epd/mod.rs"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"f075e5c0e644d2a606c278a0276efbd8808d67fca1fbe26dea4895114c38fa4c"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::block_sink::place_word_piece (cognitive 18): fw::block_sink::place_word_piece has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (15 pts), boolean chains 2, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1552}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7dfd8319708986176d9ca4718f8b60de34530f4b02ddc4edbf9ca196b1c26a6"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::decode_page_images (cognitive 18): fw::reader_cache::decode_page_images has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 5, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":868}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b1453dca3b66c4652ad72fd914e2c27a0218da1c78056dc5bd131ed3b839cf9"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::reader_cache::try_load_v2_book_cache (cognitive 18): fw::reader_cache::try_load_v2_book_cache has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 3, match/switch 2 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1056}}}],"partialFingerprints":{"codehealthFindingId/v1":"512c9ef6eb8d5bc193cf41eca228378aeb340400ed37bba1d776d308c5369c8d"}},{"ruleId":"D2","level":"warning","message":{"text":"AppStateRecord::decode (cognitive 18): AppStateRecord::decode has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 1, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"hal-ext/src/nvm.rs"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a814666e7132a87d6644d9ba18a1bc8f30fc32e6370cd8d35899c0ae52b229c"}},{"ruleId":"D2","level":"warning","message":{"text":"XhtmlBlockStreamParser::handle_end (cognitive 18): XhtmlBlockStreamParser::handle_end has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (12 pts), boolean chains 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3177}}}],"partialFingerprints":{"codehealthFindingId/v1":"a367035b5473f9fe3aa541db0dd942904c7c87ca4feb260964a2994f365495a2"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::image::index::open_image_index (cognitive 18): proto::image::index::open_image_index has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/index.rs"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"c987e4997c2c50bb971b30a868270785c4af11cdd925f4ce09e7e72df30d5d36"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::ota::parse_ota_layout (cognitive 18): proto::ota::parse_ota_layout has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/ota.rs"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"8db05dcf4c3c06ede10a5aad336f87990b63daeee59374ed346357b581026cac"}},{"ruleId":"D2","level":"warning","message":{"text":"CustomFontFile::draw_inline_styled_line (cognitive 17): CustomFontFile::draw_inline_styled_line has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":581}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbd87fa75b7755ed521adc9396fb7ef34fff9f5bfaa58dc5ff894916d5e29f99"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::custom_font::bench::exercise (cognitive 17): fw::custom_font::bench::exercise has cognitive complexity 17 (threshold 15). Drivers by points: loops 6 (9 pts), if/else 6, boolean chains 2 (nesting depth added 3). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font/bench.rs"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"59501ca127845a7fa7fdbf887b1212090ccb4caf82cc6658edc85490726cdb90"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::library_sd::find_in_catalog (cognitive 17): fw::library_sd::find_in_catalog has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 3, loops 1 (nesting depth added 7). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":492}}}],"partialFingerprints":{"codehealthFindingId/v1":"cea64fb5571317002c66d3a37f4559e5155245da62680a42850fb80e80c85276"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::views::fill_chapters (cognitive 17): fw::views::fill_chapters has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 4 (7 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/views.rs"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0b79d72fb96ad27f28f264bb8fdca8a2039e8aa9c1a9438a26944fe27f661f0"}},{"ruleId":"D2","level":"warning","message":{"text":"PngDecoder::take (cognitive 17): PngDecoder::take has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (14 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":525}}}],"partialFingerprints":{"codehealthFindingId/v1":"894143fda4c5ae6e3a92d710f2346e702b8e51fa63455a95a6b9f6bdcf0faec6"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::parse_opf_streamed (cognitive 17): proto::epub::parse_opf_streamed has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 3, loops 1, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":2285}}}],"partialFingerprints":{"codehealthFindingId/v1":"057af23e78d2d54fb56d0964c6c61290178a71cba8bfb7b2e3b932664b0b9b05"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::parse_epub2_ncx_to_sink (cognitive 17): proto::epub::parse_epub2_ncx_to_sink has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (9 pts), boolean chains 5, match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3426}}}],"partialFingerprints":{"codehealthFindingId/v1":"60c08a2c68d8ded75f582c6283282ad7334e6f15e73464adb111ea71426154cf"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::epub::append_owned_text (cognitive 17): proto::epub::append_owned_text has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4553}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8724a6bdf067b3d45441fb0db5ddd7a50eb71dbef38dac27974dcebb5c44607"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::image::png::accumulate (cognitive 17): proto::image::png::accumulate has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2, match/switch 1 (nesting depth added 5). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":1153}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4d666484e4f3e169dfbd93b534eb394f4c69e361cccca5b15569c1d65f2e0f7"}},{"ruleId":"D2","level":"warning","message":{"text":"ui::reading::draw_reading_page_body_while (cognitive 17): ui::reading::draw_reading_page_body_while has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (16 pts), match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":626}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0c5d9709f2ec74b93650c65e7994ce931f7b31c1ed8f9a6c4108ac53dd8fb12"}},{"ruleId":"D2","level":"warning","message":{"text":"ui::reading::draw_inline_styled_line (cognitive 17): ui::reading::draw_inline_styled_line has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":791}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4aa787c3eb4f247c956263b79d0634fff63d0734d8faf67f233d8d91043791e"}},{"ruleId":"D2","level":"warning","message":{"text":"ui::reading::next_wrapped_line (cognitive 17): ui::reading::next_wrapped_line has cognitive complexity 17 (threshold 15). Drivers by points: loops 5 (8 pts), if/else 3 (6 pts), boolean chains 3 (nesting depth added 6). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1587}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ee4d55c39ad27453306bc9ed7c29a4d03a0a612173544ec21bff175df09ec7b"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::block_sink::set_window_line (cognitive 16): fw::block_sink::set_window_line has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2257}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dafe6242fd7aeffb45e7af0b6e50f2cff8f67f1897d6a0c1372a61e40b04baa"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::block_sink::push_normalized (cognitive 16): fw::block_sink::push_normalized has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 3, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2801}}}],"partialFingerprints":{"codehealthFindingId/v1":"3cb0fe038cf1266b8474008cd906cf0fed5f6c8356afcdabe8c97d15636c076c"}},{"ruleId":"D2","level":"warning","message":{"text":"fw::sd_session::serve_uploads (cognitive 16): fw::sd_session::serve_uploads has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (10 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":629}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e73e6e3e3fe623eca715b9a1770d3fe79f048143bbc96f5e0a7f8f7be951f9b"}},{"ruleId":"D2","level":"warning","message":{"text":"ZipStream::visit_entry_start (cognitive 16): ZipStream::visit_entry_start has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 1 (2 pts), boolean chains 1, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":582}}}],"partialFingerprints":{"codehealthFindingId/v1":"1294979c6706ce196a93754bc2848c477cb840ab0ef790ad3cc4d4eb08afd8d5"}},{"ruleId":"D2","level":"warning","message":{"text":"ImageIndexBuilder::end_pass (cognitive 16): ImageIndexBuilder::end_pass has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (7 pts), loops 5 (7 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/index.rs"},"region":{"startLine":850}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce9959a5ba0f47e9810474a73d2d4080b40742bf3d24967baf07773dde477c11"}},{"ruleId":"D2","level":"warning","message":{"text":"proto::image::index::scan_images (cognitive 16): proto::image::index::scan_images has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/index.rs"},"region":{"startLine":676}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb8d8073b26b38cd49cabe5100ba4af34bc5584d60b597d1e94ac8369682d45e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ReaderStore: TooManyMethods \u2014 134 methods. The bar is 30 methods; this is 104 over it, 4.47\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b39bdf2006eac891a1dbed4700a162eac3d2db9834cd9fd3adc7345eb83be1e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/reader_cache_files.rs: FileTooLong \u2014 2064 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 64 free functions. The bar is 500 significant lines; this is 1564 over it, 4.13\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f81d90301ef0009621dc9d1f2201477b2fceccb6ceef0bdfd9d22da78696daf"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::tasks::display::run: FunctionTooLong \u2014 fw::tasks::display::run runs 400 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 300 over it, 4.00\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"f335f79f7195d51d825dc48797ea8bcaeffca0ea9fc0a239148707c231af487c"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/reader_cache.rs: FileTooLong \u2014 1981 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 50 free functions. The bar is 500 significant lines; this is 1481 over it, 3.96\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cab4b570a1f45822b0c85a4e6427f4f00ebccbb05171a9fd25c57fd4854ddaef"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/block_sink.rs: FileTooLong \u2014 1962 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 40 free functions. The bar is 500 significant lines; this is 1462 over it, 3.92\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b350273bad6cca2bf2666fcbfcba609369ed9666bd9f721b0695285ccfe72cc"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::tasks::display::handle_storage_command: FunctionTooLong \u2014 fw::tasks::display::handle_storage_command runs 385 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 285 over it, 3.85\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1019}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a6888e1271df79963e33cb5bb8880fbdc7f6bface084d3d49b5cc99e3984963"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::reader_cache::build_or_load_epub_cache_from_zip: FunctionTooLong \u2014 fw::reader_cache::build_or_load_epub_cache_from_zip runs 338 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 238 over it, 3.38\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1523}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b08e5d4dbc95b660ebbe58069e474616fb631bedb35246c8731613564eb6039"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/reader_store.rs: FileTooLong \u2014 1429 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 73% of them inside a single declaration: ReaderStore (3 blocks, 531-2338). The bar is 500 significant lines; this is 929 over it, 2.86\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2aa8ac3db8892acf9a7036858815b75aac08edb018505b8d051d0e3193ab8b2b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: tasks/display.rs: FileTooLong \u2014 1373 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 873 over it, 2.75\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"51f52f8b8c0594410b51aa54b08d42fe15bd14f90f6453cb3c7c485b96cb57cb"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ReaderStore: ClassTooLong \u2014 1049 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 134 methods, 3 blocks, lines 531-2338. The bar is 400 significant lines; this is 649 over it, 2.62\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"cda65bd2eb76988d99e235bd1851de09bffbb297bbe1473dc3ef81e27f954c13"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/reading.rs: FileTooLong \u2014 1204 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 56 free functions. The bar is 500 significant lines; this is 704 over it, 2.41\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3d7ab389a0cb756bed5398094c7d65e761d4186fb50e53917259140d3aab9a0"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::tasks::app::run: FunctionTooLong \u2014 fw::tasks::app::run runs 237 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 137 over it, 2.37\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ee04659643af2bf6bd78b80d4594316ab75d28b19e5fc0f70b10b0c48e17f2c"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: ReaderStore: TooManyFields \u2014 71 stored fields beside 134 methods. The bar is 30 stored fields; this is 41 over it, 2.37\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b1facda3d8ba23fcdec190580d596b4b296b6cfacc5f40406cbcee9739590b7"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/lib.rs: FileTooLong \u2014 1157 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 657 over it, 2.31\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5dba4d7a4598f1820d15c42d2cd3bdca631a441a44ad5759290f8dabeec52fc"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: image/jpeg.rs: FileTooLong \u2014 1122 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 622 over it, 2.24\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"10cc2c1459f3ae5a474b24be0d88cc5e1d7292377aaf99d3017a0040cec9c2da"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/render.rs: FileTooLong \u2014 949 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 54 free functions. The bar is 500 significant lines; this is 449 over it, 1.90\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d75f08eae0d1ff043b04403144b1bbce0447ceb5e521f0af032b1880dce28fba"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: LineWindow: ClassTooLong \u2014 731 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 51 methods, 2 blocks, lines 241-1294. The bar is 400 significant lines; this is 331 over it, 1.83\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":241}}}],"partialFingerprints":{"codehealthFindingId/v1":"730f56b5b1e8eae7b733bae8153be5dca5e67c418012dbdbefbd72c1fc50d9ed"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ReaderState.apply_library_event: MethodTooLong \u2014 apply_library_event runs 180 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 80 over it, 1.80\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1171}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bf5c8982578f0c7a9985275560dcfceff0468fa00708b98125557e05d389005"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/line_window.rs: FileTooLong \u2014 868 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 84% of them inside a single declaration: LineWindow (2 blocks, 241-1294). The bar is 500 significant lines; this is 368 over it, 1.74\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"923047a96222b0fe0b36a728b8ccff764d06b3985b9231a1727281929e027bf6"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: image/png.rs: FileTooLong \u2014 851 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 351 over it, 1.70\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bd0b463841ef4b951e1381c495203dfbd5f9085cb0d0ece79153bbfc1460ade"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: LineWindow: TooManyMethods \u2014 51 methods. The bar is 30 methods; this is 21 over it, 1.70\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":241}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9cf33bd5f21cb072c0d0f750b6e998efcd883022492ddcc624b555d24be54dd"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::reader_cache::lay_out_spine: FunctionTooLong \u2014 fw::reader_cache::lay_out_spine runs 159 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 59 over it, 1.59\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2184}}}],"partialFingerprints":{"codehealthFindingId/v1":"67ca63700a083b5bf48f1e0d4e6372cbf75ab243b3f15347d101fe4415e5bc83"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/image_decode.rs: FileTooLong \u2014 789 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 289 over it, 1.58\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"168da3975989869dacd321c63d821247b655bcecda2368bc2ea0bd29621a7876"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ReaderState.apply_input: MethodTooLong \u2014 apply_input runs 152 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 52 over it, 1.52\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":936}}}],"partialFingerprints":{"codehealthFindingId/v1":"17aea10c15f3fa1afbd992b4de08d071c97737126f0d7ec4557231dcf66a6873"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/custom_font.rs: FileTooLong \u2014 750 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 250 over it, 1.50\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5751348fc3066f318676aa486720778d9da378cf3d20f18efe6631fdc38e6a03"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/cache.rs: FileTooLong \u2014 746 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), declaring 59 free functions. The bar is 500 significant lines; this is 246 over it, 1.49\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/cache.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c45ac4de842117c5ca8f69c7e620a87e792c8000671663dcf20c4aae2ddaac63"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/library_sd.rs: FileTooLong \u2014 720 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 220 over it, 1.44\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cde73f0bfb50003a1a5552870849a47c8c36911daf6a82f8248b52d85fd3f10c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: LineWindow.relax_from: MethodTooLong \u2014 relax_from runs 140 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/line_window.rs"},"region":{"startLine":991}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4c2e8a2a1fbe09b67e528253c2a070cba3f24e26e69b3e862546378544a5fbe"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::reader_cache_files::load_v2_book_index: FunctionTooLong \u2014 fw::reader_cache_files::load_v2_book_index runs 134 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 34 over it, 1.34\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":795}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9013f0f9fdc714035e520aea40c6b4460fbbfc46741781ce094dff12132ff77"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: LibraryBlockSink: TooManyFields \u2014 40 stored fields beside 21 methods. The bar is 30 stored fields; this is 10 over it, 1.33\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"750b038de272cb945791ff651db7689c1625fb33992d8b3cb702213d7e62de17"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: LibraryBlockSink: ClassTooLong \u2014 533 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 21 methods, 4 blocks, lines 65-1259. The bar is 400 significant lines; this is 133 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b5fc7db679777062d4041964fe25186389f58eab0e1fab4bb12fa5164b13982"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ReaderState: ClassTooLong \u2014 527 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 15 methods, 2 blocks, lines 848-1593. The bar is 400 significant lines; this is 127 over it, 1.32\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":848}}}],"partialFingerprints":{"codehealthFindingId/v1":"f38e0b15a3a36f85f38eb2e54db61306669e5061b07b0a08bb5c333e233e576e"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::reader_cache::build_or_load_book_cache_from_root: FunctionTooLong \u2014 fw::reader_cache::build_or_load_book_cache_from_root runs 129 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 29 over it, 1.29\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":280}}}],"partialFingerprints":{"codehealthFindingId/v1":"59b9495b7883bd3b774aeaaed8a52941e11144f5de74f6f6460761a242e26efd"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: JpegDecoder: ClassTooLong \u2014 513 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 22 methods. The bar is 400 significant lines; this is 113 over it, 1.28\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1081}}}],"partialFingerprints":{"codehealthFindingId/v1":"d854e766514f5b31ee16c04a27392895f60ac0107db077f327d4303df312cfe1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: image/index.rs: FileTooLong \u2014 635 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 135 over it, 1.27\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/index.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f191aae5bf0a0eab37939f3fb6f9f06f4d9a1d97a1af58c6565745bc4df5dfc"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: tasks/wifi.rs: FileTooLong \u2014 627 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 127 over it, 1.25\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cec4561290c9b7ddcd089871e3fa49d9f6f589df26fefa3dc84a8ba9bb871f7e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/sd_session.rs: FileTooLong \u2014 606 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 106 over it, 1.21\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"313d25ffb791ca18be4478cd56cb4106e41ec26c5b70435dc575ae23e0f9677e"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::tasks::wifi::upload_server: FunctionTooLong \u2014 fw::tasks::wifi::upload_server runs 118 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 18 over it, 1.18\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":272}}}],"partialFingerprints":{"codehealthFindingId/v1":"41457eba588d773ed5ae57ef11bae4cf717f48cdf20c73ad31eb7920c45bbd0f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: PngDecoder: TooManyFields \u2014 35 stored fields beside 25 methods. The bar is 30 stored fields; this is 5 over it, 1.17\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":350}}}],"partialFingerprints":{"codehealthFindingId/v1":"02428a9089ba8296489422f2d17e7e36ce23893207283517efdf50f8e80799f1"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::main: FunctionTooLong \u2014 fw::main runs 112 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":277}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8503d530e3fc6671916eaf087c3eefa3d984368c5e33fd2c46244821e5e3516"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: ReaderState: TooManyFields \u2014 33 stored fields beside 15 methods. The bar is 30 stored fields; this is 3 over it, 1.10\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":848}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bd79886ffcea1f42d90a05bfa9139643db7759399e84e2a43b75c23098edb90"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: tasks/app.rs: FileTooLong \u2014 543 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 43 over it, 1.09\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"21c1410a2c98b40c19165555ff8114f288f4cbce530c9f110f54a53765aeebac"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PngDecoder: ClassTooLong \u2014 428 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 25 methods. The bar is 400 significant lines; this is 28 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":350}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d7f1310f0abef64750f0969bc57e615f080643541626ff0a39561df8ed0bd04"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::reader_cache::try_load_v2_book_cache: FunctionTooLong \u2014 fw::reader_cache::try_load_v2_book_cache runs 106 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1056}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d857d80897c8515dc649bfd75d53dd61bc28aaa033cc55a4a2f7e5301fde0cf"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: ui::render::render_wireless: FunctionTooLong \u2014 ui::render::render_wireless runs 106 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":693}}}],"partialFingerprints":{"codehealthFindingId/v1":"667c12e04f6eb97266976fd4bc9ce7878ec1eb5ea212f2aed2829084a6c58183"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::tasks::display::prepare_while_idle: FunctionTooLong \u2014 fw::tasks::display::prepare_while_idle runs 105 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 5 over it, 1.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":752}}}],"partialFingerprints":{"codehealthFindingId/v1":"6327f302d3372a3df02db40a3d4b7e3eff704a4f56255b767ce4c37130743979"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: JpegDecoder: TooManyFields \u2014 31 stored fields beside 22 methods. The bar is 30 stored fields; this is 1 over it, 1.03\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1081}}}],"partialFingerprints":{"codehealthFindingId/v1":"19ff2cfad290486c66ecef1de1153da95ead490937769a93586d08dc1214eac1"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::block_sink::push_styled_preview_fragment: FunctionTooLong \u2014 fw::block_sink::push_styled_preview_fragment runs 103 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1306}}}],"partialFingerprints":{"codehealthFindingId/v1":"8534ffcf3729d529f4eb10c9b4ab43c353b3d463964bbed42b4752e6b44c6692"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: fw::image_decode::decode_jpeg: FunctionTooLong \u2014 fw::image_decode::decode_jpeg runs 102 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":1064}}}],"partialFingerprints":{"codehealthFindingId/v1":"836138f74b7533843bb614b9cf0a3e7d808618e48d3a5f9aa65ff8a1ec757b02"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): proto/src/epub.rs:1941-1973 | proto/src/epub.rs:4553-4584 | proto/src/epub.rs:4600-4640 | tools/preview/src/main.rs:1932-1958 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1941}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a43920e9844a8e6d3bb966a919ca210a6f4b2efce7f93880caa210fc59e8f3c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (30 corresponding lines): display/src/fb/blit.rs:151-180 | display/src/fb/blit.rs:189-221 \u2014 These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/fb/blit.rs"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c141219eb851eba34f336e21f17b33d9d4739fdfbdb48cae474c00d57223f9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (57 corresponding lines): ui/src/render.rs:361-433 | ui/src/render.rs:473-529 \u2014 These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"fde485b214949cc1f529d8b6a9c6b44ec9c2546fcfbcd237cbc439a3cc1c9d61"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (52 corresponding lines): proto/src/epub.rs:1223-1287 | proto/src/epub.rs:1301-1352 \u2014 These two members are one piece of code written twice and then edited apart: 52 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1223}}}],"partialFingerprints":{"codehealthFindingId/v1":"03aef167a3d8d13648f6c52d370ca23da24b5957e9798e8d4b598b02e2c1373c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (36 corresponding lines): fw/src/custom_font.rs:494-531 | fw/src/custom_font.rs:653-688 \u2014 These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":494}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b6303d6e20688a06992a327bcada657b7b2534c6e87a43220014354aac2d6aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (38 corresponding lines): proto/src/image/dither.rs:131-171 | proto/src/image/dither.rs:176-213 \u2014 These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/dither.rs"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c9ec1c320731a9bd3ed65c03797a471c35770e371cc6a305ba56f083fa7bab6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (49 corresponding lines): fw/src/custom_font.rs:589-639 | ui/src/reading.rs:800-848 \u2014 These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":589}}}],"partialFingerprints":{"codehealthFindingId/v1":"a95890012fed98d57e281ee3b4d6312a0f407074423faf85e4aa42421354bac8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): fw/src/sd_session.rs:129-159 | fw/src/sd_session.rs:161-194 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba7924965e534d6f36db139d3c5e5e2a69a86bedffdf7bd559c92c148183c92d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): ui/src/reading.rs:1206-1232 | ui/src/reading.rs:1271-1305 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1206}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8855bc5c8bb4954aa92b60129bee0fcd9998a60d6aad38ea20f5da5db0afaec"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): fw/src/tasks/wifi.rs:601-624 | fw/src/tasks/wifi.rs:626-646 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":601}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3f4741bca5cfeaf2517a3b441941ece83053634247eea8ce19c24320a054138"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): proto/src/image/jpeg/idct.rs:191-216 | proto/src/image/jpeg/idct.rs:218-238 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg/idct.rs"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d1f352aa04c8463a1c60ddb6cd355d3d999a799ed52585d59ceafaaee5db46b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): ui/src/reading.rs:864-900 | ui/src/reading.rs:1854-1880 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":864}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a7833de19c69296d194a1372ce48c92a5a707957ed4293f5ac34a9e3ea65779"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): proto/src/captive.rs:242-265 | proto/src/captive.rs:269-288 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/captive.rs"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ef7fdaee5ee4e3f8710431c6a5d297c9b2ba03721c387061612b37c450b0fb7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): proto/src/cache.rs:495-514 | proto/src/cache.rs:542-564 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/cache.rs"},"region":{"startLine":495}}}],"partialFingerprints":{"codehealthFindingId/v1":"d573d361b7924309c7d1d45e3f0badf7dd74497a46512f637804a9cd2575a9b1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): proto/src/image/png.rs:1412-1427 | proto/src/image/png.rs:1429-1445 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":1412}}}],"partialFingerprints":{"codehealthFindingId/v1":"7517a3b4a712572354324ec5c48674f0eeed05ed817d72689bed8e4be333e96f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 19\u002B corresponding lines): proto/src/cache.rs:516-537 | proto/src/cache.rs:566-589 | proto/src/cache.rs:714-732 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/cache.rs"},"region":{"startLine":516}}}],"partialFingerprints":{"codehealthFindingId/v1":"bae4f1cf1bd81ff48384970664fcdda1f508ed9427d1fcb531ad98edaaf2ba07"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): ui/src/render.rs:270-290 | ui/src/render.rs:314-327 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fe9374c2ac8e296feee8675ccaf5679307cf750865940c13b1b86acf1013afa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): fw/src/custom_font.rs:698-724 | fw/src/custom_font.rs:732-749 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":698}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf0b822c22bc2980a65c6bfb3fd0495f1cf5252a4604a639d725a6cd45096392"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): fw/src/block_sink.rs:521-547 | fw/src/block_sink.rs:2403-2429 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":521}}}],"partialFingerprints":{"codehealthFindingId/v1":"5501eb4a88bc800251e6d9132bcf3b47266a736dd10b9df06f3ff7f7e814154f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): fw/src/reader_cache.rs:2469-2482 | tools/preview/src/main.rs:2122-2137 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2469}}}],"partialFingerprints":{"codehealthFindingId/v1":"b51161d23ee8c0960c3a3e0789e9d7c45840167424ea5122760ee09d7a54664a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): proto/src/epub.rs:4068-4084 | proto/src/epub.rs:4093-4109 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4068}}}],"partialFingerprints":{"codehealthFindingId/v1":"a44f0182281e2cf6687de9db614dacab48f5f9bb0043bcb38df5f21ed637dc83"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): fw/src/reader_cache.rs:662-685 | fw/src/reader_cache.rs:696-713 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":662}}}],"partialFingerprints":{"codehealthFindingId/v1":"d541101fc97fa9e6cada3c4d1948ac0aacc8eefb341ecd6325e9c6dae758d590"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): proto/src/ota.rs:402-414 | proto/src/ota.rs:421-433 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/ota.rs"},"region":{"startLine":402}}}],"partialFingerprints":{"codehealthFindingId/v1":"d35615c8c3b902e5d6b3d250508c4417f934e08b0a548a46b2c36abcfe1b3032"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): fw/src/reader_cache_files.rs:389-402 | fw/src/reader_cache_files.rs:527-536 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":389}}}],"partialFingerprints":{"codehealthFindingId/v1":"91cd833efc2477e8d28da521d874d4631091511e32e9e28fa9ec3b5f02b2eb52"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): proto/src/epub.rs:305-321 | proto/src/epub.rs:339-365 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":305}}}],"partialFingerprints":{"codehealthFindingId/v1":"0da9c6151594e9f831c4438327613e83a03852972b7a47cda1d177f6a4837bf0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): fw/src/reader_cache_files.rs:1881-1890 | fw/src/reader_cache_files.rs:2467-2477 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1881}}}],"partialFingerprints":{"codehealthFindingId/v1":"45527868caeab5cf210b166d921df39482323aff61a3474ec01aa0c83cdbb03b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): ui/src/reading.rs:1919-1943 | ui/src/reading.rs:1955-1981 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1919}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e20b5919edd527eff7d2eea6fe8f9fa478065aca41364188a6848836fa26c57"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): fw/src/block_sink.rs:2933-2946 | proto/src/epub.rs:5098-5114 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2933}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdb9ed59d5e02915a7d1c54cfb80ab314217bea67d4242a198127c23366ea0d7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): fw/src/block_sink.rs:2843-2862 | tools/preview/src/main.rs:1992-2011 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2843}}}],"partialFingerprints":{"codehealthFindingId/v1":"377237e180e0eea0af78c51ea0cbd8fcf4ab0b036e9c810dceb7d17b2b8f1323"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): fw/src/block_sink.rs:2867-2890 | tools/preview/src/main.rs:1968-1990 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2867}}}],"partialFingerprints":{"codehealthFindingId/v1":"f63e33d529f0a68d97edd719d33e71298e18aa85b25b680a824d6e54edfae41a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): fw/src/custom_font.rs:925-935 | proto/src/ota.rs:367-373 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":925}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fbe99609572776c3f3e2fab6c04a1db264bbe084ace61db86dddf8651e4f2ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): fw/src/reader_cache_files.rs:1908-1914 | fw/src/reader_cache_files.rs:2140-2146 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1908}}}],"partialFingerprints":{"codehealthFindingId/v1":"075b4a494960dea5a2f35017fa12ed3a9e1b99d1ea74b2c22ca21504147912b5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): fw/src/reader_store.rs:1760-1767 | fw/src/reader_store.rs:1787-1794 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":1760}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef263dfbbe5e1a86db8cfd34de8d2d414ff8526970df7aa052c085cdd17b7930"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): fw/src/block_sink.rs:2914-2925 | tools/preview/src/main.rs:2013-2024 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2914}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe7556fba8cee4f8deac9912fc89dea1a6737881f048b60f90729b2fd2e469eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): fw/src/tasks/app.rs:793-804 | fw/src/tasks/app.rs:806-820 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":793}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee1dedf8b6f00dabb9a0c7abead4d0811136481a1aca50b4efde401244ee9278"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): proto/src/epub.rs:3481-3488 | proto/src/epub.rs:3936-3944 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":3481}}}],"partialFingerprints":{"codehealthFindingId/v1":"5759217fb097da78098dc50fe82dc281076d448037306ed0fee77201b232fb32"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): proto/src/epub.rs:5204-5214 | fw/src/reader_cache_files/book_generation.rs:34-43 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":5204}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1e0a150b29503ece3fe94feb222758c25d1deffb5944bde0e635cf9607ca595"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): proto/src/epub.rs:5177-5182 | proto/src/font_pack.rs:178-183 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":5177}}}],"partialFingerprints":{"codehealthFindingId/v1":"114f593182d9bea025f4e683deb94b80aa621919187f52b17aa091d07d903c62"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): proto/src/image/jpeg.rs:1187-1194 | proto/src/image/png.rs:474-481 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1187}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9cf920a2a8564da2a55fd70363380303c463428adf249742e86d00b7afa6486"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): proto/src/epub.rs:5170-5175 | proto/src/font_pack.rs:171-176 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":5170}}}],"partialFingerprints":{"codehealthFindingId/v1":"63c6a03a113d8b7182cd8c4fd2a85dc1ae15962353481d09d49380e2a28ea12f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): tools/preview/src/main.rs:1692-1695 | ui/src/render.rs:1174-1177 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1692}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f424191d46dba8b9a15f2cd50453e909a8c37230e5b61d3a36ebf63b31b4e5e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): fw/src/reader_store.rs:2278-2285 | proto/src/epub.rs:3332-3340 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":2278}}}],"partialFingerprints":{"codehealthFindingId/v1":"7faa040fde681a63a4d9e9cffd4ebed158773422097bf143bd1c2dc6dac886da"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): ui/src/reading.rs:815-845 | ui/src/reading.rs:1687-1717 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":815}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bd5f3e4514baaeeff742628f8fad04b65cf775e24acfb7b6df15053d8e3f1e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): proto/src/epub.rs:1230-1250 | proto/src/epub.rs:1308-1328 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/epub.rs:1230\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1230}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a601e7d9682dd606a3508352c7ef58c666cf7ffe5cf02fc186338d2412bc652"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): fw/src/block_sink.rs:2893-2912 | tools/preview/src/main.rs:2027-2046 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2893}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbf852c3a9f1570bb394a2b160555e444f42d9c56613cc931d724d9adcbf0f5c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201320 lines \u00D7 2): fw/src/display_flush/ssd1677.rs:258-277 | fw/src/display_flush/uc8253.rs:328-345 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/display_flush/ssd1677.rs:258\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/display_flush/ssd1677.rs"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ebff56db79f47ccaf0be56df60b5a5e0ef21dd9a2c9b9ec2da2a556bf0fe531"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): fw/src/block_sink.rs:529-547 | fw/src/block_sink.rs:2411-2429 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/block_sink.rs:529\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":529}}}],"partialFingerprints":{"codehealthFindingId/v1":"c405f657017340b102e52209066940387550efc19bb3829e3aa3cb71c1bf7bef"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): fw/src/custom_font.rs:513-531 | fw/src/custom_font.rs:670-688 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:513\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":513}}}],"partialFingerprints":{"codehealthFindingId/v1":"852765fdde8c904e575d74df5df411834aa93d5d85996040acc6faa6913b0d33"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201319 lines \u00D7 2): fw/src/reader_cache.rs:367-383 | fw/src/reader_cache.rs:392-410 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":367}}}],"partialFingerprints":{"codehealthFindingId/v1":"3114a17a675824c0d34950d2ce441816f44d1b684e0cd009567b1e24d38a2f60"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): fw/src/tasks/display.rs:1285-1301 | fw/src/tasks/display.rs:1441-1457 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/tasks/display.rs:1285\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1285}}}],"partialFingerprints":{"codehealthFindingId/v1":"06853d0bcb5945fdad0ff92ba887d9a02c619b8f999fc66f062607717c9631db"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): fw/src/block_sink.rs:1277-1292 | tools/preview/src/main.rs:1893-1908 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1277}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d6f9bf144a964a1a74bcca1e8eed3c3372db3ad3b02420f363f0c8af4b9daa9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): proto/src/epub.rs:1266-1287 | proto/src/epub.rs:1337-1352 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/epub.rs:1266\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1266}}}],"partialFingerprints":{"codehealthFindingId/v1":"7145891f4ce4d5b5de8b76d683a4518b94b6c017912145cf44d9c396077d8475"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): fw/src/block_sink.rs:2780-2794 | tools/preview/src/main.rs:2049-2063 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2780}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd8f42ad26618b625e679bfdf65191d9276420a7bb9cb796416ceba1f4c32436"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): fw/src/sd_session.rs:458-471 | fw/src/sd_session.rs:540-553 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/sd_session.rs:458\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":458}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ecefd7da964d9b96e5b09bd13d46ec2718e060634b8454a054cd3c81ecf1e6e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): fw/src/views.rs:28-41 | fw/src/views.rs:147-160 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/views.rs"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a4fd53dd806a407de386b8eb6ed153e469a646e2412affa3f7f48fdbe7b6e8e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): proto/src/captive.rs:243-258 | proto/src/captive.rs:270-285 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/captive.rs"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"094a31535368dfd9d670ca3bf0f8b7d70fbf23d42f399b96af469db1cd4fd386"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): proto/src/epub.rs:4071-4084 | proto/src/epub.rs:4096-4109 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/epub.rs:4071\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4071}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cb3981e670b61f8f3cfce58877911022d5f6476d2f03264108f4f992c45c25f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): fw/src/custom_font.rs:457-469 | fw/src/custom_font.rs:617-629 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:457\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":457}}}],"partialFingerprints":{"codehealthFindingId/v1":"64d677f79bd918aa673d25c3542b55371a36ea5d50e87ba3e060c9cb5096d3ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): fw/src/custom_font.rs:596-608 | ui/src/reading.rs:807-819 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:596\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":596}}}],"partialFingerprints":{"codehealthFindingId/v1":"878235e12e9fb97fd9973be1a91ba7db63d7f640cac789bc9fe3f27ec6bf5e0e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): fw/src/custom_font.rs:709-721 | fw/src/custom_font.rs:735-747 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":709}}}],"partialFingerprints":{"codehealthFindingId/v1":"393fe8f3375f25ff7f765cfa59493a661d7b7a7e4ac8ab134e3705a002cf08b3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): fw/src/views.rs:358-370 | fw/src/views.rs:396-408 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/views.rs:358\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/views.rs"},"region":{"startLine":358}}}],"partialFingerprints":{"codehealthFindingId/v1":"e92dbd91be9f358ef097d1d58c0d41564a57d5c922ca0f2d8e1fa90b319a01f8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): ui/src/reading.rs:1207-1218 | ui/src/reading.rs:1272-1283 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060ui/src/reading.rs:1207\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060ui/src/reading.rs:1284\u0060 calls \u0060push_fallback\u0060 and \u0060ui/src/reading.rs:1219\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1207}}}],"partialFingerprints":{"codehealthFindingId/v1":"464f91dacc958da42fd705a4489ac983cd0ad4c4adf8dbe1605fdb738ac29bcb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): fw/src/tasks/app.rs:733-743 | tools/emulator/src/main.rs:426-436 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind \u0060next\u0060 to \u0060\u0026ReaderState\u0060 in one and \u0060app_core::ReaderState\u0060 in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH \u2014 their common supertype where they have one, or a new abstraction over them where they do not \u2014 and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":733}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2df4b7ca337db175cdc29b5de9415ed0bc72fad3e71b73cde3ff70f60859a22"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): fw/src/tasks/wifi.rs:286-296 | fw/src/tasks/wifi.rs:656-666 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/tasks/wifi.rs:286\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c3df2927878911cacfddd219ba45f2fad56519fb350bc99cdb022c9121d39c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): hal-ext/src/nvm.rs:106-116 | hal-ext/src/nvm.rs:158-168 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060hal-ext/src/nvm.rs:106\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"hal-ext/src/nvm.rs"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d516f87c88610f64f7c2c2f2ca225f2583d1379da1bc5ee868b584619325a22"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): proto/src/epub.rs:287-297 | proto/src/epub.rs:800-810 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7175725d28c025280f21afc8a43247cce4413182d6b04ee7a0a864600aee3c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): fw/src/tasks/display.rs:1261-1270 | fw/src/tasks/display.rs:1343-1352 | fw/src/tasks/display.rs:1486-1495 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/tasks/display.rs:1261\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1261}}}],"partialFingerprints":{"codehealthFindingId/v1":"04666a6d910be4ffe65de6c2f51a77ffe4ba79e5d77def7097c5e03114445bbe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): fw/src/block_sink.rs:2916-2925 | tools/preview/src/main.rs:2015-2024 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/block_sink.rs:2916\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2916}}}],"partialFingerprints":{"codehealthFindingId/v1":"693bbe681ebe2189bc4340aa772a12094bb3b047cd18420b78c60ed28a2d268d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): fw/src/library_sd.rs:903-912 | fw/src/reader_cache_files.rs:2439-2448 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":903}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebd1a23e35b452bc4f42063b46dc5d5fab63a754bcf05c625a43b4a03e463af4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u201310 lines \u00D7 2): fw/src/reader_cache_files.rs:1992-1999 | fw/src/reader_cache_files.rs:2052-2061 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/reader_cache_files.rs:1992\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":1992}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba181bd94149e2eaaec46f82a58251fc1de5d3debeedc02a58db22f135797655"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): fw/src/tasks/input.rs:251-260 | fw/src/tasks/input.rs:266-275 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/tasks/input.rs:251\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab858431899588f26a5331f59b7f1245fdda512d697634c051cc78a1c01ff86d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u201310 lines \u00D7 2): proto/src/epub.rs:774-783 | proto/src/epub.rs:1764-1771 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/epub.rs:774\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":774}}}],"partialFingerprints":{"codehealthFindingId/v1":"609dd8a20fc68cfee3b5659331b8a16042a4267943e1f91af1ce84a0fe99a85a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): proto/src/epub.rs:4519-4528 | proto/src/epub.rs:4531-4540 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":4519}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a44fde46833bed38b36ca5c1baaad2744d13cf941866d737b1e674ddbb14673"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201317 lines \u00D7 4): proto/src/epub.rs:1945-1955 | proto/src/epub.rs:4554-4570 | proto/src/epub.rs:4601-4617 | tools/preview/src/main.rs:1935-1945 \u2014 there are 4 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/epub.rs:1945\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1945}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a617bbba6cc15e03c1bdf9de0c0b2f91b7838cbf1eb050b64cc597d74fd8493"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): ui/src/app_render.rs:182-192 | ui/src/render.rs:234-243 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060ui/src/app_render.rs:182\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/app_render.rs"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"910706e4147663d878b65400c2d646b1ec730d44b00d3b9dc1676caba78bd044"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): fw/src/custom_font.rs:440-448 | ui/src/reading.rs:1683-1691 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:440\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":440}}}],"partialFingerprints":{"codehealthFindingId/v1":"78fb70d11d53beddd9b242b75ff97032257e39e5482f9a1f148ba3b842589e07"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): fw/src/ota_update.rs:301-309 | fw/src/ota_update.rs:385-393 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/ota_update.rs"},"region":{"startLine":301}}}],"partialFingerprints":{"codehealthFindingId/v1":"3af56a7100db29cb4d6d92b574f399a50deac0ecf8ac26f99ab76d432ab03067"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5\u20139 lines \u00D7 2): ui/src/render.rs:1029-1037 | ui/src/render.rs:1082-1086 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060ui/src/render.rs:1029\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":1029}}}],"partialFingerprints":{"codehealthFindingId/v1":"076fff98309e56b99a38e3eda5272fac40d1ad08607b2177610a330404fb6dba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): display/src/fb/blit.rs:157-164 | display/src/fb/blit.rs:196-203 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/fb/blit.rs"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb758986365b0f39da33d0af3539a257cd039f7b907d26ab511f827bc730c74f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): fw/src/block_sink.rs:1390-1397 | fw/src/block_sink.rs:1750-1757 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1390}}}],"partialFingerprints":{"codehealthFindingId/v1":"c89ab09f2f4cb95c95520e750959f5ec4396807308ef93262f49c76da96a6e14"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): fw/src/image_decode.rs:1006-1013 | fw/src/image_decode.rs:1088-1095 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/image_decode.rs"},"region":{"startLine":1006}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c8f2c2af3e4604659a3a2028c9a0d864432b2402a67caa081cdef220d3baef3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): fw/src/library_sd.rs:992-999 | fw/src/library_sd.rs:1003-1010 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/library_sd.rs:992\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060fw/src/library_sd.rs:1002\u0060 calls \u0060eq_ignore_ascii_case\u0060 and \u0060fw/src/library_sd.rs:991\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":992}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c9688b5bd0f3c52f3660b9a9251d2828d222fa22d8060079f83e79fde901525"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): fw/src/reader_cache_files.rs:933-940 | fw/src/reader_cache_files.rs:943-950 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/reader_cache_files.rs:933\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":933}}}],"partialFingerprints":{"codehealthFindingId/v1":"69ddb22047a298668ec52f9ec3f0f98eb9b989fef3b0867126c87a054d1e6b98"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): fw/src/custom_font.rs:365-371 | fw/src/custom_font.rs:385-391 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:365\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":365}}}],"partialFingerprints":{"codehealthFindingId/v1":"d640e7a154a8d63a1e59084186d1e0dd93454e71e02a6ddc54f1874322ae4bcf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): fw/src/custom_font.rs:502-508 | fw/src/custom_font.rs:659-665 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/custom_font.rs:502\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/custom_font.rs"},"region":{"startLine":502}}}],"partialFingerprints":{"codehealthFindingId/v1":"1fc87b28a523c04c07629291363b541ab437c573ddbf676cef9b3eff22fe537b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): fw/src/sd_session.rs:495-501 | fw/src/sd_session.rs:560-566 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":495}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5d2b6294a41dd6f886802b0b822af7f729a3f335ce19bc74c5a78e412bc43c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): proto/src/cache.rs:484-490 | proto/src/cache.rs:503-509 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind \u0060header\u0060 to \u0060PageCacheHeader\u0060 in one and \u0060SectionHeader\u0060 in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH \u2014 their common supertype where they have one, or a new abstraction over them where they do not \u2014 and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060proto/src/cache.rs:511\u0060 calls \u0060write_u32\u0060 and \u0060proto/src/cache.rs:492\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/cache.rs"},"region":{"startLine":484}}}],"partialFingerprints":{"codehealthFindingId/v1":"62c076877b591cbe613423105e6040eda3fafefafc945e4c324d1a6745626f56"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): proto/src/cache.rs:486-491 | proto/src/cache.rs:505-510 | proto/src/cache.rs:552-557 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind \u0060header\u0060 to \u0060PageCacheHeader\u0060 in one and \u0060SectionHeader\u0060 in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH \u2014 their common supertype where they have one, or a new abstraction over them where they do not \u2014 and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060proto/src/cache.rs:511\u0060 calls \u0060write_u32\u0060 and \u0060proto/src/cache.rs:492\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/cache.rs"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"76e12173c385be6b5e8fe73f67b591c3e3901a3fd966aceaba921fae160752b1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): fw/src/sd_session.rs:651-656 | fw/src/sd_session.rs:921-926 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/sd_session.rs:651\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":651}}}],"partialFingerprints":{"codehealthFindingId/v1":"073a06be74b7e6474a3eef08b688ff4c9781aeec3f65f95a68f1d2cb5eec4a09"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): proto/src/epub.rs:1682-1687 | proto/src/epub.rs:5117-5122 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/epub.rs"},"region":{"startLine":1682}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8bcce0eefed33e84d5c8a0be58a17b3ea8da14a8b63180390367bb2adc5191a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): proto/src/image/jpeg.rs:1824-1829 | proto/src/image/png.rs:1043-1048 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/image/jpeg.rs:1824\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1824}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ae715ab68f0ba0f2fec9b9d67dec16b89f84b8e53b6d092d829c8dfc0d8cd33"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): display/src/fb/blit.rs:168-173 | display/src/fb/blit.rs:207-212 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060display/src/fb/blit.rs:168\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/fb/blit.rs"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae2245f19741224a8e497f75d16f8715e4884c2996b0fe04ba631140bbde1eba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): fw/src/bin/test_dma.rs:19-24 | fw/src/main.rs:382-386 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/bin/test_dma.rs:19\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/bin/test_dma.rs"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"a048c1e624e6733b32bcbc1c898cd535c161806ff86c53750d3611074b624e96"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): fw/src/reader_cache_files.rs:2468-2474 | fw/src/reader_cache_files.rs:2506-2512 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060fw/src/reader_cache_files.rs:2505\u0060 calls \u0060ensure_v2_cache_dirs\u0060, \u0060ok\u0060 and \u0060fw/src/reader_cache_files.rs:2467\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":2468}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a5bb49c9129ad88a1bbe321a5b2ba1be50bb645c27fe63710fb90fbd7b9e23d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): proto/src/image/jpeg/idct.rs:204-208 | proto/src/image/jpeg/idct.rs:226-230 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/image/jpeg/idct.rs:204\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg/idct.rs"},"region":{"startLine":204}}}],"partialFingerprints":{"codehealthFindingId/v1":"54096c2d7e8c36ba046b69dded58ab964edf5d7d3dc2691f05a646403efe310c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): proto/src/image/png.rs:1413-1421 | proto/src/image/png.rs:1431-1439 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060proto/src/image/png.rs:1413\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/png.rs"},"region":{"startLine":1413}}}],"partialFingerprints":{"codehealthFindingId/v1":"10b2caa176ff68b7cbb4df8b19ee869bb6f6cefe74c74d5573f1f83e3f4137ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): ui/src/reading.rs:1227-1231 | ui/src/reading.rs:1297-1301 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/reading.rs"},"region":{"startLine":1227}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4859c43e2432647edf2dde8f69abd1d7af3c04a9eac99e8182ad8e6c209d5fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): ui/src/render.rs:271-276 | ui/src/render.rs:315-320 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060ui/src/render.rs:271\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"ui/src/render.rs"},"region":{"startLine":271}}}],"partialFingerprints":{"codehealthFindingId/v1":"95ea96741aa90d8b625cc2e8717bba5b770782dd98ed7957d6d7c141f48ca26d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): fw/src/block_sink.rs:385-393 | proto/src/cache.rs:1014-1022 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"3667888b3f968169e8a1edb3b91134ca6b3398b088db1ccecf0cdcfa0e3d256b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): fw/src/block_sink.rs:493-497 | fw/src/custom_font.rs:993-997 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":493}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a7bd2a7e56d86400a90b1f8098cd6adafd35b37d61f05a3b00afda8933c3992"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): fw/src/block_sink.rs:2745-2755 | tools/preview/src/main.rs:2072-2082 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2745}}}],"partialFingerprints":{"codehealthFindingId/v1":"86aaeb1c51d2e8391e8bf4a655654499439b04639b3dab7c7e79eee95b604b6c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): fw/src/block_sink.rs:2757-2769 | tools/preview/src/main.rs:1918-1930 \u2014 before extracting anything, compare \u0060fw/src/block_sink.rs\u0060 and \u0060tools/preview/src/main.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 85 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2757}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cb6b4bff614f0bb6535755e990c21fb95541323643871be62c2c9b21e1c99df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): fw/src/library_sd.rs:885-893 | fw/src/reader_cache_files.rs:1656-1664 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/library_sd.rs"},"region":{"startLine":885}}}],"partialFingerprints":{"codehealthFindingId/v1":"caeb273372399fd807b87fae28c9e00915e7388dee12c5e99bcd38d6e284ab8e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): fw/src/ota_update.rs:286-290 | fw/src/reader_cache_files.rs:33-37 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/ota_update.rs"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac6f463d1c4d0c92974541a82c09e35bcfbc7a4c3bb674757721bb4c99dcd4d7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): proto/src/captive.rs:324-331 | proto/src/upload.rs:104-111 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/captive.rs"},"region":{"startLine":324}}}],"partialFingerprints":{"codehealthFindingId/v1":"de9a074ad4592a178fa285db36e02ec4c09933635f72e915beb869a314ee453c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): fw/src/ota_update.rs:346-357 | fw/src/ota_update.rs:405-416 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/ota_update.rs"},"region":{"startLine":346}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4b0f89e9e3154155d85af8b0f9b7dba10da245defa19a69c17f124c0331e234"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): fw/src/tasks/wifi.rs:602-610 | fw/src/tasks/wifi.rs:627-635 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":602}}}],"partialFingerprints":{"codehealthFindingId/v1":"6cebb1c07a7ae67705c99a082cd37c38dd47efc522f65dea913eb2ed0d8ba5a5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): fw/src/reader_cache.rs:665-669 | fw/src/reader_cache.rs:699-703 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060fw/src/reader_cache.rs:665\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":665}}}],"partialFingerprints":{"codehealthFindingId/v1":"8abe558bf6f827a65c95f16f0eb870f23505dd938ac07a29d4799dbd651ef125"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (9 members, 50\u002B identical tokens): tools/preview/src/main.rs:882-892 | tools/preview/src/main.rs:894-905 | tools/preview/src/main.rs:907-917 | tools/preview/src/main.rs:919-929 | tools/preview/src/main.rs:931-942 | tools/preview/src/main.rs:944-954 | tools/preview/src/main.rs:956-966 | tools/preview/src/main.rs:968-978 | tools/preview/src/main.rs:980-990 \u2014 These 9 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 9 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 9 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":882}}}],"partialFingerprints":{"codehealthFindingId/v1":"806a0528388b66300380c886c1bbb937a68afe7e5e7bc9342e7a810432cd3f01"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (9 members, 50\u002B identical tokens): tools/preview/src/main.rs:1086-1105 | tools/preview/src/main.rs:1114-1135 | tools/preview/src/main.rs:1137-1154 | tools/preview/src/main.rs:1168-1191 | tools/preview/src/main.rs:1193-1209 | tools/preview/src/main.rs:1259-1276 | tools/preview/src/main.rs:1324-1337 | tools/preview/src/main.rs:1575-1610 | tools/preview/src/main.rs:1612-1626 \u2014 These 9 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 9 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 9 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1086}}}],"partialFingerprints":{"codehealthFindingId/v1":"f30db55e9120713145471357f58263c9c08d7a44e679eb34c6c647369c5ff3da"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (8 members, 50\u002B identical tokens): tools/preview/src/main.rs:790-802 | tools/preview/src/main.rs:804-815 | tools/preview/src/main.rs:817-828 | tools/preview/src/main.rs:830-841 | tools/preview/src/main.rs:843-854 | tools/preview/src/main.rs:856-867 | tools/preview/src/main.rs:869-880 | tools/preview/src/main.rs:1556-1566 \u2014 These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":790}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c67ecb6e735b9012ec4b3dcd00f768d13e3340da86fff43d3d4ca6a432806dd"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (6 members, 50\u002B identical tokens): tools/preview/src/main.rs:992-1002 | tools/preview/src/main.rs:1004-1014 | tools/preview/src/main.rs:1016-1026 | tools/preview/src/main.rs:1028-1038 | tools/preview/src/main.rs:1040-1050 | tools/preview/src/main.rs:1052-1062 \u2014 These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":992}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e158accd4d5fd180ebfdb5e0a6230e4244097bf829e9aa7e2dabc2eaa66a1e7"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): tools/preview/src/main.rs:1211-1233 | tools/preview/src/main.rs:1235-1257 | tools/preview/src/main.rs:1278-1299 | tools/preview/src/main.rs:1301-1322 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1211}}}],"partialFingerprints":{"codehealthFindingId/v1":"b04815ca9c91736e39f749ced68a9b7c95399e2a7fb824056ba5df57a007774b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (75 corresponding lines): tools/build_font_pack.py:314-395 | tools/font_pack_to_rust.py:61-135 \u2014 These two members are one piece of code written twice and then edited apart: 75 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/build_font_pack.py"},"region":{"startLine":314}}}],"partialFingerprints":{"codehealthFindingId/v1":"616b16450670f2941c43ae1e75c43b9d8daec46e13bb279e850519e4fe44a04a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 30\u002B corresponding lines): tools/preview/src/design_mockups.rs:864-895 | tools/preview/src/design_mockups.rs:1145-1174 | tools/preview/src/design_mockups.rs:1273-1304 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":864}}}],"partialFingerprints":{"codehealthFindingId/v1":"b200a6c1672d7cf0af2797daa0d1e7ff7171280e2211cb908a01ed249b46aec3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (28 corresponding lines): tools/fontgen_common.py:230-259 | tools/generate_mockup_fonts.py:65-92 \u2014 These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/fontgen_common.py"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"537c70d412d684d28aaf5e34626cce5fb5b87004dd3ab0b63d8f0c108009c67e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (41 corresponding lines): tools/emulator/src/main.rs:425-474 | tools/web-emulator/src/lib.rs:464-504 \u2014 These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/main.rs"},"region":{"startLine":425}}}],"partialFingerprints":{"codehealthFindingId/v1":"cadce8d5ba4f3ab5e731aa7d79a7b23770a0471eaac37a4dd159132cebad5331"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (44 corresponding lines): tools/emulator/src/main.rs:46-89 | tools/preview/src/main.rs:72-119 \u2014 These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/main.rs"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4694f34347418c1b804ca3c942d3fca9052070f0cf499a751976df1754a08f7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): tools/preview/src/main.rs:1628-1647 | tools/preview/src/main.rs:1649-1671 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1628}}}],"partialFingerprints":{"codehealthFindingId/v1":"72b83b3bc69fcdbd7ef31c1bbeb0d6eac136d3c325046f1f71366cfdbd016e59"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): tools/preview/src/main.rs:1467-1478 | tools/preview/src/main.rs:1480-1510 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1467}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d3e9bc1f684fa4b3c1fa4415ce2edaa85a8b14fa21a0c851f70e6458e43e2fc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): fixtures/images/make_inline_images.py:23-33 | fixtures/images/shrink_orientation_marker.py:60-69 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fixtures/images/make_inline_images.py"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5f9a38842f1834b320cb27c7a75e55ece6dc48e06a0d5422b0f9aa7058f8172"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 15\u002B corresponding lines): tools/preview/src/main.rs:1841-1855 | tools/preview/src/main.rs:1857-1872 | tools/preview/src/main.rs:1874-1890 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1841}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ba705e944294e393eba32c83c8858bc5f9fed021c2033b603cdc9d24bb52f64"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 20\u002B corresponding lines): tools/preview/src/design_mockups.rs:617-636 | tools/preview/src/design_mockups.rs:679-698 | tools/preview/src/design_mockups.rs:1116-1143 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":617}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cb558106bbf9e6d312f547d9eff2cadc22f9cbdf79ee786dbb925a32e098135"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): tools/generate_literata_semibold.py:78-91 | tools/generate_literata_sizes.py:74-87 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_literata_semibold.py"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb3c1b71efa675f4170266e3f3488c0f70ec596cc933e0f9f07701e18ba31457"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): tools/generate_literata_extra.py:61-74 | tools/generate_mockup_fonts.py:96-110 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_literata_extra.py"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ab57697791f226d474a61eb911102c126637b852cf19e6ecfa8967968e7da32"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): tools/bench/fb_dump.py:31-39 | tools/bench/send.py:28-40 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/bench/fb_dump.py"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"628702d0760b20cf77236bce66f0a7bd8e65cf57a2c21797e9e88d6f10daa8f8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): tools/fontgen_common.py:358-371 | tools/fontgen_common.py:375-392 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/fontgen_common.py"},"region":{"startLine":358}}}],"partialFingerprints":{"codehealthFindingId/v1":"7efb67ad23870e547fb4f2b5596e1dca11ddb6fb92dc2d25a845ab9e5631dd06"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): tools/preview/src/main.rs:1529-1536 | tools/preview/src/main.rs:1543-1548 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1529}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b19cfbea4d7dddc87c0a4156e334e8810c783b7957eb9e4f4db99e1bbdfcfef"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): tools/preview/src/design_mockups.rs:1503-1516 | tools/preview/src/design_mockups.rs:1538-1552 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1503}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d9a75e635231d7fe1fb9162515de2888eb3a564720b3a2b38d1cc0830dda09b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): tools/preview/src/main.rs:1454-1459 | tools/preview/src/main.rs:1697-1702 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1454}}}],"partialFingerprints":{"codehealthFindingId/v1":"86920fd211fb6ab2d7200564af3a55c657b70a9a2876836f76bc02f427985725"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 9\u002B corresponding lines): tools/preview/src/design_mockups.rs:1712-1720 | tools/preview/src/design_mockups.rs:1723-1732 | tools/preview/src/design_mockups.rs:1745-1753 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1712}}}],"partialFingerprints":{"codehealthFindingId/v1":"35736dbfed6bb0bd9f0a43ade4b0bd83721e466d93f036c55015bc6e3b052b9e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): tools/preview/src/main.rs:1512-1517 | tools/preview/src/main.rs:1673-1680 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1512}}}],"partialFingerprints":{"codehealthFindingId/v1":"de35e182fd2bb175064bd1d62cbf89f2cac0a69e351eb0d61d323c6642555444"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): tools/preview/src/design_mockups.rs:1645-1658 | tools/preview/src/design_mockups.rs:1667-1676 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1645}}}],"partialFingerprints":{"codehealthFindingId/v1":"898ffbdfb92627196d4250eb3bc7f1aac1dbcfeded353dd5651b1587ef7eafbf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): tools/emulator/src/render.rs:46-51 | tools/emulator/src/render.rs:58-63 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/render.rs"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bfe36f43347362525ae46b56d58e8c6ec60e032e5f3af8e653b8e0432945827"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 13\u002B corresponding lines): tools/preview/src/design_mockups.rs:1520-1534 | tools/preview/src/design_mockups.rs:1556-1568 | tools/preview/src/design_mockups.rs:1597-1609 | tools/preview/src/design_mockups.rs:1613-1625 | tools/preview/src/design_mockups.rs:1629-1641 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1520}}}],"partialFingerprints":{"codehealthFindingId/v1":"daf20e6f7bbcf5bb34051e67cde57f4112a89157d220718b9593d6cf3d2108db"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): tools/preview/src/main.rs:1519-1527 | tools/preview/src/main.rs:1682-1690 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1519}}}],"partialFingerprints":{"codehealthFindingId/v1":"65ac50dd9d8281d48e842283ff5adfa448fb8b02c8672635cf6eb62f8183369b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 8\u002B corresponding lines): tools/preview/src/design_mockups.rs:1735-1742 | tools/preview/src/design_mockups.rs:1756-1764 | tools/preview/src/design_mockups.rs:1796-1804 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1735}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdcd2d67062b8dc4b680738e450a2391c4353982717902149f2361ba3ee188d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 8\u002B corresponding lines): tools/preview/src/design_mockups.rs:670-677 | tools/preview/src/design_mockups.rs:1176-1186 | tools/preview/src/design_mockups.rs:1310-1319 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":670}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb876ed10a200081e199d78a49308ce112cb337973ab3f0589d8d5cf6a730073"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): tools/emulator/src/render.rs:83-91 | tools/emulator/src/render.rs:96-104 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/render.rs"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"25fa6571fe97b746b1a556a6cf1aa5eb565a05fc209c6f8135da1b38484ecc72"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 5\u002B corresponding lines): tools/preview/src/main.rs:1442-1446 | tools/preview/src/main.rs:1448-1452 | tools/preview/src/main.rs:1550-1554 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1442}}}],"partialFingerprints":{"codehealthFindingId/v1":"7133ecde8a143a73c9dd7731b706d3becef6001019d7b44bb6ddde880ac46390"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): tools/preview/src/design_mockups.rs:429-433 | tools/preview/src/design_mockups.rs:435-440 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":429}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d427ff11bc3c4d6372c6ae4b896795289c47003d76ed1a9e390a2f08ed52715"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 4\u002B corresponding lines): tools/build_font_pack.py:171-174 | tools/fontgen_common.py:263-266 | tools/generate_mockup_fonts.py:58-61 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/build_font_pack.py"},"region":{"startLine":171}}}],"partialFingerprints":{"codehealthFindingId/v1":"c299ec22bc4243b972d7d292d222d878f4586a1d2730a15475d6b999f9edafcf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (37 lines \u00D7 2): tools/emulator/src/main.rs:438-474 | tools/web-emulator/src/lib.rs:468-504 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/emulator/src/main.rs:438\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/main.rs"},"region":{"startLine":438}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4ef8baf2a701aed0e9c30694835aef16d0ce8bc6de271f65a9f8d41ee6895e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23\u201324 lines \u00D7 3): tools/preview/src/design_mockups.rs:869-892 | tools/preview/src/design_mockups.rs:1149-1171 | tools/preview/src/design_mockups.rs:1278-1300 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/design_mockups.rs:867\u0060 calls \u0060rfill\u0060 and \u0060tools/preview/src/design_mockups.rs:1147\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":869}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f997e7a8d27a779a5f8a6afb688c11c01daa6c0dc22f796ebb14290dd61989d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): tools/preview/src/design_mockups.rs:838-862 | tools/preview/src/design_mockups.rs:1119-1143 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/design_mockups.rs:838\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":838}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e433ad4e50e7328ffebee6e50fbd1404d86a7d3e4af870774ae7370fd142745"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): tools/preview/src/design_mockups.rs:923-936 | tools/preview/src/design_mockups.rs:1196-1209 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":923}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdd26d69844f2d1efb310e06606378065a9b0b642fe3d6d4e52aa5e173b0d548"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): tools/preview/src/main.rs:1212-1230 | tools/preview/src/main.rs:1236-1254 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1212\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1212}}}],"partialFingerprints":{"codehealthFindingId/v1":"598da1713fbbe1f688055dc915ac65957fc3bb5766021a41b3a03f414fc4758b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): tools/preview/src/main.rs:1223-1233 | tools/preview/src/main.rs:1312-1322 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1223\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/main.rs:1311\u0060 calls \u0060draw_edge_button_mark\u0060 and \u0060tools/preview/src/main.rs:1222\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1223}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e47be45c8cc211d7ec9e447d7b6460f2f7c75846ac7eb65fe05746076b96787"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): tools/emulator/src/main.rs:49-55 | tools/preview/src/main.rs:76-82 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/emulator/src/main.rs:49\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/main.rs:74\u0060 calls \u0060from\u0060 and \u0060tools/emulator/src/main.rs:47\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/main.rs"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d1d4df12d6f94ed68f2a979c5336c3fac03a10dbb22f863eaf8792590709f39"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/preview/src/design_mockups.rs:629-636 | tools/preview/src/design_mockups.rs:691-698 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/design_mockups.rs:629\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":629}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfc9ff9f9d220b03b52fdf85e1249ab72241c4492ab9285f53822b1d7ad2f5ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/preview/src/design_mockups.rs:1066-1073 | tools/preview/src/design_mockups.rs:1311-1318 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1066}}}],"partialFingerprints":{"codehealthFindingId/v1":"3306fd072ca823f95c2b62c07663b3ba850cd296f95b03498085f1292149ccac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/preview/src/main.rs:1520-1527 | tools/preview/src/main.rs:1683-1690 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1520}}}],"partialFingerprints":{"codehealthFindingId/v1":"a809f42e4de3cd2ba35912fd10f4ec1665e638f0554b76101581b59b75a05a6a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): tools/preview/src/design_mockups.rs:671-676 | tools/preview/src/design_mockups.rs:770-775 | tools/preview/src/design_mockups.rs:1178-1183 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":671}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad110d558b12a4a4fbdb5133465562c4453c9aa0f0f61e27398c43d826391a1c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/preview/src/main.rs:1842-1849 | tools/preview/src/main.rs:1858-1865 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1842\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1842}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c1cded774051d0dc0c45db03eb8c53ba9ea20286a1957801b7a99af6e7da815"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 9): tools/preview/src/main.rs:887-892 | tools/preview/src/main.rs:900-905 | tools/preview/src/main.rs:912-917 | tools/preview/src/main.rs:924-929 | tools/preview/src/main.rs:937-942 | tools/preview/src/main.rs:949-954 | tools/preview/src/main.rs:961-966 | tools/preview/src/main.rs:973-978 | tools/preview/src/main.rs:985-990 \u2014 all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:887\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":887}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d85fe80c3e3399505ccc3c15d5fe78a3315de912deb3863aef7ee6a1687409b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 8): tools/preview/src/main.rs:798-802 | tools/preview/src/main.rs:811-815 | tools/preview/src/main.rs:824-828 | tools/preview/src/main.rs:837-841 | tools/preview/src/main.rs:850-854 | tools/preview/src/main.rs:863-867 | tools/preview/src/main.rs:876-880 | tools/preview/src/main.rs:1562-1566 \u2014 all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:798\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/main.rs:795\u0060 calls \u0060fill_rect\u0060 and \u0060tools/preview/src/main.rs:1559\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":798}}}],"partialFingerprints":{"codehealthFindingId/v1":"717d695f942a6fd6a248e1ec82d9c2c2f8b5374f62100c441a65ff8fa5231ff4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 6): tools/preview/src/main.rs:997-1002 | tools/preview/src/main.rs:1009-1014 | tools/preview/src/main.rs:1021-1026 | tools/preview/src/main.rs:1033-1038 | tools/preview/src/main.rs:1045-1050 | tools/preview/src/main.rs:1057-1062 \u2014 all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:997\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":997}}}],"partialFingerprints":{"codehealthFindingId/v1":"3199b116d96e1938b77ea38cca764b59b5aa244cf1d8de51352e299bdf0ec0ad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (4\u20135 lines \u00D7 9): tools/preview/src/main.rs:1088-1092 | tools/preview/src/main.rs:1115-1118 | tools/preview/src/main.rs:1138-1141 | tools/preview/src/main.rs:1169-1172 | tools/preview/src/main.rs:1194-1197 | tools/preview/src/main.rs:1260-1263 | tools/preview/src/main.rs:1325-1328 | tools/preview/src/main.rs:1577-1581 | tools/preview/src/main.rs:1614-1618 \u2014 all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1088\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/main.rs:1088\u0060 calls \u0060literata\u0060 and \u0060tools/preview/src/main.rs:1115\u0060 does not \u2014 after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1088}}}],"partialFingerprints":{"codehealthFindingId/v1":"ced6cae0d282e22f59d161799d37100e8fec63a770a600cd63a96be82d2daa56"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): tools/preview/src/main.rs:1217-1222 | tools/preview/src/main.rs:1241-1246 | tools/preview/src/main.rs:1305-1310 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1217\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1217}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab84a375ed620670f94ced98d4240232bc926739c83b66ff5aaca1c1a9858579"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): tools/preview/src/main.rs:1472-1476 | tools/preview/src/main.rs:1634-1638 | tools/preview/src/main.rs:1657-1661 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/preview/src/main.rs:1633\u0060 calls \u0060fill_rect\u0060 and \u0060tools/preview/src/main.rs:1471\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1472}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bccdc20468203f1bed5dd151df4ade5a0b0e25d0ffbd66fbb6603d3143a0f6b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): tools/preview/src/design_mockups.rs:1006-1011 | tools/preview/src/design_mockups.rs:1054-1059 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/design_mockups.rs:1006\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1006}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd1404dc4f80506d184ef3ee97305198fd287f31c8932bdd8820383fab4de7cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/preview/src/main.rs:993-1000 | tools/preview/src/main.rs:1017-1024 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":993}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb589b05ba6eba2254b126cceb1236c453e6060d8e9b03f39a2ca3a8396d3b76"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): tools/preview/src/main.rs:1279-1285 | tools/preview/src/main.rs:1302-1308 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/main.rs:1279\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1279}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ee62bfa99d9f05ff171864400ea1e67c32a627686e0f3d56680bbdff1284cf9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): tools/preview/src/design_mockups.rs:1769-1775 | tools/preview/src/design_mockups.rs:1808-1813 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060tools/preview/src/design_mockups.rs:1814\u0060 calls \u0060text\u0060, \u0060small\u0060 and \u0060tools/preview/src/design_mockups.rs:1776\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":1769}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed20696335811b6132d322c845efd35cabc6dddf04349e7adc3de34e127887fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): tools/preview/src/design_mockups.rs:832-836 | tools/preview/src/design_mockups.rs:1439-1443 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/preview/src/design_mockups.rs:1439\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/design_mockups.rs"},"region":{"startLine":832}}}],"partialFingerprints":{"codehealthFindingId/v1":"794972c089e541763ec04071e1c22734402492040f2656d53025378e571143c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): tools/preview/src/main.rs:805-810 | tools/preview/src/main.rs:818-823 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":805}}}],"partialFingerprints":{"codehealthFindingId/v1":"2902571150b816f5a96e0fc04890914fae7d5c3097cf7813d76c334475a02924"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): tools/preview/src/main.rs:1377-1381 | tools/preview/src/main.rs:1455-1459 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/preview/src/main.rs"},"region":{"startLine":1377}}}],"partialFingerprints":{"codehealthFindingId/v1":"126ea36f1ec1b8e0152cea71b4419368a453a7e4623b4b8e67d57432a28f3ed3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25\u201326 lines \u00D7 2): tools/build_font_pack.py:315-340 | tools/font_pack_to_rust.py:61-85 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/build_font_pack.py"},"region":{"startLine":315}}}],"partialFingerprints":{"codehealthFindingId/v1":"32c266bd6469df703d0f4911631d7dc311843007e98d22d6258e0417fb99685a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): tools/generate_literata_semibold.py:78-88 | tools/generate_literata_sizes.py:74-84 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/generate_literata_semibold.py:78\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_literata_semibold.py"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ce500e041de26008ef0bbd569aeb72a670943005d4a0e78b3a5d2c2080a11e0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): tools/generate_literata_extra.py:67-74 | tools/generate_literata_semibold.py:84-91 | tools/generate_literata_sizes.py:80-87 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_literata_extra.py"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"927212adcd9950bce0bbe4348d23b2178119d5318f63c416adaf0232a3cfc412"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): tools/bench/bench.py:278-284 | tools/serial_capture.py:16-22 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/bench/bench.py"},"region":{"startLine":278}}}],"partialFingerprints":{"codehealthFindingId/v1":"6802c831cda16acb0f11bb481e576a131f69207811053cc4021bd2dc2c817210"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): tools/fontgen_common.py:242-249 | tools/generate_mockup_fonts.py:75-82 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/fontgen_common.py"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"ffbc4f0065f3adc7eaa8dcc1b411beb70d7f6a854b1e669258023198c569c2ae"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): tools/web-emulator/books/convert.py:285-291 | tools/web-emulator/books/convert.py:333-339 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060tools/web-emulator/books/convert.py:285\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/web-emulator/books/convert.py"},"region":{"startLine":285}}}],"partialFingerprints":{"codehealthFindingId/v1":"537b20a9f0f74ae44677f508cf60e250dd0e8ad04fb541a3b371223e196695ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): tools/generate_hyphenation.py:162-168 | tools/generate_hyphenation.py:169-175 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_hyphenation.py"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"d379d457127c5ee702f63f1b8b523680702bb487ad8979c21974ae9e112490bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): tools/generate_hyphenation.py:153-157 | tools/generate_hyphenation.py:162-166 | tools/generate_hyphenation.py:169-173 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060tools/generate_hyphenation.py:152\u0060 calls \u0060ord\u0060 and \u0060tools/generate_hyphenation.py:168\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/generate_hyphenation.py"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"53f86b2eea6f165777dba75b97aefb4790beca12b417f9c2b8892d2497e00e38"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): fixtures/images/make_inline_images.py:28-33 | fixtures/images/shrink_orientation_marker.py:64-69 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fixtures/images/make_inline_images.py"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec5676830a8c44d55456077f7e6e46fde83948b435e6352b70638a07dcb2c578"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: display: display: abstractness 0.00, instability 0.00, distance 1.00 \u2014 zone of pain \u2014 concrete and depended on by 6 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"b62581f3a8ad71d402a8432ffbfa79cc51154f3afd4baa18a01794a52a97054b"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: proto: proto: abstractness 0.12, instability 0.00, distance 0.88 \u2014 zone of pain \u2014 concrete and depended on by 5 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"1d27de0319ab5497e8e0e39b6903ea30cc0ec5d87c0872a27578ae0f34d2ff19"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: app-core: app-core: abstractness 0.00, instability 0.20, distance 0.80 \u2014 zone of pain \u2014 concrete and depended on by 4 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"029fc269cb358c18b128fb337cc5e645e099ef6e1e0705f817aeaae9c938e117"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: hal-ext: hal-ext: abstractness 0.29, instability 0.00, distance 0.71 \u2014 zone of pain \u2014 concrete and depended on by 1 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"cc4cf79ef01c54ff4d2251c9d2626925a3eca691acc7d15cce18732bb2717be7"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: ReaderStore (LCOM4 5): ReaderStore\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_store.rs"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa31005818e7dfca97071583934591aa64e5d4dde63384fefaae6a27c8ade7fa"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/tasks/display.rs: fw/src/tasks/display.rs changed 27 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 60 in fw::tasks::display::run at line 60. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/tasks/display.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"d93de8ef66fa1e2a2e512a91dfd9ef3f9269027a089cca4e35cf7bd6e5032b62"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/reader_cache.rs: fw/src/reader_cache.rs changed 22 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 40 in fw::reader_cache::build_or_load_epub_cache_from_zip at line 1523. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/reader_cache.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":1523}}}],"partialFingerprints":{"codehealthFindingId/v1":"18c78f6a4b55373760df99c59f5978d8f8c26a159c5f4fb0c0223696307ec00f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/tasks/app.rs: fw/src/tasks/app.rs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 67 in fw::tasks::app::run at line 15. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/tasks/app.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"563e91db59150bff1480ae1e92101049f20eed67a8d15c4182f1b06931578dea"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: app-core/src/lib.rs: app-core/src/lib.rs changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 52 in ReaderState::apply_library_event at line 1171. 1 of those changes was a fix/bug commit, and the other 13 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- app-core/src/lib.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":1171}}}],"partialFingerprints":{"codehealthFindingId/v1":"dba22534660b55c4494e6e6d29b2ae2513a4d477d9018350de35d0f6f22a39db"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/reader_cache_files.rs: fw/src/reader_cache_files.rs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in fw::reader_cache_files::load_v2_book_index at line 795. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/reader_cache_files.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":795}}}],"partialFingerprints":{"codehealthFindingId/v1":"2635cf0e0bc19857eeea5b32a7ea82af04835e657b9ba794e24f16603c17f63d"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: tools/bench/bench.py: tools/bench/bench.py changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 40 in bench.summarize_paths at line 427. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- tools/bench/bench.py\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/bench/bench.py"},"region":{"startLine":427}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1a37b2dd85a609912d6210e20c82ec0339b3e13cd1d687a1a0a444d253bc6a9"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: tools/emulator/src/scenario.rs: tools/emulator/src/scenario.rs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 41 in Scenario::assert at line 83. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- tools/emulator/src/scenario.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/scenario.rs"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"be75227a5c2f16f7e7e7a85e89d47808d5127310e9297ebd2676cd75e603be2d"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/tasks/input.rs: fw/src/tasks/input.rs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in fw::tasks::input::run at line 157. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/tasks/input.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"62e5ac5ec192559d4186d2debb36322e5e2bd4382a63c860b9420b2e9ccca606"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: fw/src/tasks/bench_serial.rs: fw/src/tasks/bench_serial.rs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in fw::tasks::bench_serial::run at line 55. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-12..2026-11-10, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-12 04:14:27 \u002B01:00\u0027 --until=\u00272026-11-10 04:14:27 \u002B01:00\u0027 --full-history --no-merges -- fw/src/tasks/bench_serial.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/bench_serial.rs"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"268d7f613072d1c32882637898bb468ad3a197cb6494a47ef690ab7987cecb5e"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060. ADRs are expected here because \u0060fw/src/main.rs\u0060 makes this repository a deployable product (line 1)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b947baf0f8585139755798e5af99253583c7dbbd5f840cef8a268a5f2ffacc66"}},{"ruleId":"D26","level":"note","message":{"text":"Projects may be oversized for their cohesion: \u0060proto\u0060 (21413 LoC, 128 module-visible types across 3 directories) overshoots its size bounds. 1 of 10 build unit(s) (Cargo) overshoot their size bounds, lowering Project Cohesion to 8.0/10. Review these for cohesion \u2014 draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/Cargo.toml"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"418fd918fddd397e3d464d55dcb1181956d86a058161a0f98380ed95755134c0"}},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a1f31e3fc38e806c632551480508ae27b2701acddad0a9d80c648ba1fc9463b3"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"54015389eb5f9a0beb6433e209224f32665bbffd45f48b4ac71eacdc7584cddd"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c1bb7814097052b3b9e49cf20adb5ffa3c94da3abc00863955683dc4725b2e91"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"58416306c1a27a37c4768b939e55dd2865e8672774adab59964be2ffeffdd74f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"bc17439367157c6f6ff8590f4dfe29bc3a0ce4e328d99df310f8a49a2877af10"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ae4b19a624088a80ae967fa19fc6e2d3b4d86bf95f6afb9918729adad8224e32"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"99c8716916ca0dd9ddee8302208a5745bab6513f34ca12c2672d93f07c07be5f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"46ed5088e372a1645841089d14aca0a25845741310820ce62e7cb1a6cd16763b"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e4cb465e1f0d2eae4c574d9bbda594dca37b461c20ca4391a9a1ab1fb76b76e5"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"34f998d59eaff18b05f62f3ffd53eb1d86ddd758e021a3b06f3dd141181d69a1"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c6ef2f316ca631b692d03c475bed7e473e93f3db6fa35d9ef86248c50808e234"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5c802ec97e672feaa32f710e6686a62b890e325cf5a04a8fb4136422a8a2ef74"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A03:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5922a5beeab5ac077ffb485a783ad545036e79b56239f83da38f3fb84336b113"},"properties":{"dependency":{"package":"paste","version":"1.0.15","advisory":"RUSTSEC-2024-0436","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2b5cc6a78fe02a95b2f6755616011982ae866dcba8c2aeaae7b037f36ce19be5"},"properties":{"dependency":{"package":"unsafe-libyaml","version":"0.2.11","advisory":"RUSTSEC-2024-0449","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"22a976352cff54276b5f0c3add5911c10766cd9eb2beb87bb174cb36561ba001"},"properties":{"dependency":{"package":"memmap2","version":"0.9.10","advisory":"RUSTSEC-2026-0186","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7d4765addab556f3d8f7176315a2c6fe6656bd210d848378569dd1278d0931f9"},"properties":{"dependency":{"package":"quick-xml","version":"0.39.4","advisory":"RUSTSEC-2026-0194","aliases":["RUSTSEC-2026-0195"],"reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5c27567885e09c9c74216d125f2fe79f8ac40563e321b64541e2975cf8e4056e"},"properties":{"dependency":{"package":"rustix","version":"1.1.4","advisory":"RUSTSEC-2026-0486","aliases":["[GHSA redacted]"],"reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1168b6c546df13b5a5bd9b17c82dff3c8580a065cc344f40e1570a9934b74e96"},"properties":{"dependency":{"package":"ttf-parser","version":"0.25.1","advisory":"RUSTSEC-2026-0192","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"43ebedaceb1440f59835bc80b22c5a6b50f672fa820dbcf42c90d1d671bc556a"},"properties":{"dependency":{"package":"webbrowser","version":"1.2.1","advisory":"RUSTSEC-2026-0257","aliases":["[GHSA redacted]"],"reachability":{"kind":"unknown"}}}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1b213f6eedd4b140d0bc37bdf1496f72811a643f34064f12518b32e9e83bcfc7"},"taxa":[{"id":"CICD-SEC-9","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0e17f71490e4d120a48b2b2881ab866c93b272bef2febb673a3e8e42b2c288ab"},"taxa":[{"id":"CICD-SEC-9","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eb00976a698a5d68999b7ee6d27206fd374e916853e7ff1ead5eed42386f043f"},"taxa":[{"id":"CICD-SEC-9","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"90f83b4fa27db32740afe9540c905f3c0499caed87f61049a8a903ecc95b41c3"},"taxa":[{"id":"CICD-SEC-8","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ace515990e7ee0f17b5c17e44dd168a5bdecf90804a3a3dd845cf05540978013"},"taxa":[{"id":"CICD-SEC-3","toolComponent":{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35"}}]},{"ruleId":"D44","level":"warning","message":{"text":"End-of-life runtime: Rust 1.95: rust-toolchain.toml declares Rust 1.95 as this project\u0027s toolchain file, and Rust 1.95, superseded by 1.96 on 2026-05-28 (the Rust project patches only the current stable). An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2026-05-28 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"rust-toolchain.toml"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dde701f9c40b0b8cb202babf3f8d8da48dda44162595030f1b0a8f7d57710684"}},{"ruleId":"AC6","level":"warning","message":{"text":"Low contrast colour pair in CSS (1.0:1): \u0060.ghost\u0060 sets color: #161614 on background-color: #191510 \u2014 1.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"web/index.html"},"region":{"startLine":374}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2082267b54d3d45fb7a6fd97ea54902344580174b5aa9745e86c7e12ff0b637"}},{"ruleId":"AC6","level":"warning","message":{"text":"Low contrast colour pair in CSS (3.2:1): \u0060.sdsteps .n\u0060 sets color: #cf5f0c on background-color: #ece6d7 \u2014 3.2:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"web/index.html"},"region":{"startLine":392}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5c7b9eee25e502f2bb9e875371323af3fcecc80c38ba8b7f6484dc351160678"}},{"ruleId":"AC6","level":"warning","message":{"text":"Low contrast colour pair in CSS (1.0:1): \u0060.dl2\u0060 sets color: #161614 on background-color: #191510 \u2014 1.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"web/index.html"},"region":{"startLine":393}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc06c1777915f3a2690a34613adc9374069393a6c53dcf7ba2098ac6e374a5d3"}},{"ruleId":"IC1","level":"warning","message":{"text":"Empty method body \u2014 does nothing with its inputs: \u0060log_image_session\u0060 takes parameters but its body is empty \u2014 it accepts inputs and does nothing. Either implement it or remove it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":991}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b0ac4093d62c5fb9da915cccf3c4098df0775a00b946321cb34afbc15310a49"}},{"ruleId":"IC1","level":"warning","message":{"text":"Empty method body \u2014 does nothing with its inputs: \u0060log_input\u0060 takes parameters but its body is empty \u2014 it accepts inputs and does nothing. Either implement it or remove it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":377}}}],"partialFingerprints":{"codehealthFindingId/v1":"2122986218c324866fdc11258cf49943201a83cf9e1db6e5f251dfa38a7b956e"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"Architecture diagram out of date: \u0060docs/ARCHITECTURE.md\u0060 draws the system\u0027s parts, and the drawing no longer matches the code: it leaves out \u0060x4-web-emulator\u0060, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"docs/ARCHITECTURE.md"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6e246bc726fd8f7630df79f514c9d639242bcfcddfaa0995a6f26309dd6cbf3"}},{"ruleId":"P2","level":"warning","message":{"text":"No structured logging: No logging or diagnostics emission found. This repository ships a binary its users launch rather than a service you operate, so there is no operator to page \u2014 but when a run fails on a user\u0027s machine, neither they nor you have anything to read."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"9f10d71351c6778ebe84e761f82a90d4f9ed6c64f5e01975ede8fda7e4e2ebc5"}},{"ruleId":"P3","level":"note","message":{"text":"No dependency-update automation: \u0060display/Cargo.toml\u0060 declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices \u2014 including after an advisory is published against it. Add a \u0060.github/dependabot.yml\u0060 with one \u0060package-ecosystem\u0060 entry per ecosystem the tree uses (or an enabled \u0060renovate.json\u0060), and gate pull requests with \u0060actions/dependency-review-action\u0060."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/Cargo.toml"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9f5c57b9c40fc7afd94e7a15c5961c67658f471a10e7e0af266ee2ece29476f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!previous_space \u0026\u0026 out.push(\u0027 \u0027).is_err()\u0060 appears character-identically in 2 files \u2014 fw/src/block_sink.rs, proto/src/epub.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2805}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4b26019788706f7d7aa9da70cc3115b3735964b47659d8c920f575639e53a6a"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!sink.line.is_empty() \u0026\u0026 (sink.line_role != role || sink.line_align != align)\u0060 appears character-identically in 2 files \u2014 fw/src/block_sink.rs, tools/preview/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1390}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ac622cfd177910608b55566492befb6d2e0f65212afa1cece175969ce171f94"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060is_epub_titlepage_label(rest) || contains_gutenberg_metadata(rest)\u0060 appears character-identically in 2 files \u2014 fw/src/block_sink.rs, tools/preview/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2885}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c19c1c6164e1da15346192c892cc83a881e2fbb48fc9597ad8ede0e3ca02b68"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060is_leading_punctuation_word(word) \u0026\u0026 !sink.line.is_empty()\u0060 appears character-identically in 2 files \u2014 fw/src/block_sink.rs, tools/preview/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":1423}}}],"partialFingerprints":{"codehealthFindingId/v1":"c16efe78f295385ef9e0aa979b1dc3b655ebd1d170eb77fb60b3fa24c6b64c03"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060lower.contains(\u0022most recently updated\u0022) || lower.contains(\u0022project gutenberg ebook\u0022) || lower.contains(\u0022start of the project gutenberg\u0022) || \u2026\u0060 appears character-identically in 2 files \u2014 fw/src/block_sink.rs, tools/preview/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/block_sink.rs"},"region":{"startLine":2916}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba290cdbfe27dac2c50081dbad9c302e16db4d487c4eb2c72588a74f7e10c26d"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060next.view == AppView::FirmwareUpdate \u0026\u0026 previous.firmware_status != app_core::FirmwareUpdateStatus::Staging \u0026\u0026 next.firmware_status == app_c\u2026\u0060 appears character-identically in 2 files \u2014 fw/src/tasks/app.rs, tools/emulator/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":736}}}],"partialFingerprints":{"codehealthFindingId/v1":"78e3965e540ed38cd436ca1f4244dc6cd8f297cb04deabff08a7435d4d6a5a69"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060next.view == AppView::FirmwareUpdate \u0026\u0026 previous.view != AppView::FirmwareUpdate\u0060 appears character-identically in 2 files \u2014 fw/src/tasks/app.rs, tools/emulator/src/main.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/app.rs"},"region":{"startLine":733}}}],"partialFingerprints":{"codehealthFindingId/v1":"910b76d0f600d90067f18c126fc74925429e0733a7669afbaf4b5b0d14e52bad"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060previous.book_id != next.book_id || previous.chapter != next.chapter || previous.view != AppView::Reading\u0060 appears character-identically in 2 files \u2014 tools/emulator/src/main.rs, tools/web-emulator/src/lib.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/emulator/src/main.rs"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6e2a1c2a0b75bb9e3f2fe0ae398e9e84e8dde5eac3f04c12423aa04326fef04"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060request.view == AppView::Reading \u0026\u0026 ReaderSource::from_book_id(request.book_id).is_sd()\u0060 appears character-identically in 2 files \u2014 fw/src/views.rs, tools/web-emulator/src/lib.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/views.rs"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa03bc1884f7ebadebe2e96b05ca7614dfe49bdf998d1bdd2e64d2d5eee5eca8"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060self.band_left == 0 \u0026\u0026 self.out_y \u003C self.out_h\u0060 appears character-identically in 2 files \u2014 proto/src/image/jpeg.rs, proto/src/image/png.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1782}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b947b7c5d1a690e50fa64cdda1c0d3d9f92357316f1cd6d0f6f5bb571fef877"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060self.out_w \u003E info.width || self.out_h \u003E info.height\u0060 appears character-identically in 2 files \u2014 proto/src/image/jpeg.rs, proto/src/image/png.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":1399}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8b0337defc2d23738f596b7d341c73533fd81ba75ab3dd6d8e53e42285e1239"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060self.width \u003E MAX_DIMENSION || self.height \u003E MAX_DIMENSION || pixels \u003E MAX_PIXELS\u0060 appears character-identically in 2 files \u2014 proto/src/image/jpeg.rs, proto/src/image/png.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/image/jpeg.rs"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9ad4f2afe69c8d221412da1ac7c1240f55ec8e7c89eb6ea841d4a76af91c9db"}},{"ruleId":"X25","level":"warning","message":{"text":"Configuration option is read nowhere: \u0060ReaderState.dirty\u0060 is offered as a builder setter option, so whoever configures the program can set it \u2014 but no production code reads it. A test asserts that it parses, which proves the key is read from the input, not that it does anything. Every value supplied for it is silently ignored. Consult it where it was meant to take effect \u2014 or, if it genuinely does nothing, remove it (or mark it deprecated and say so in its documentation) so the configuration stops advertising a setting that changes nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"app-core/src/lib.rs"},"region":{"startLine":885}}}],"partialFingerprints":{"codehealthFindingId/v1":"74ba4c5465bb597d7b5c8b1d7153d6270647ab010da4420ae4e1d031e4ace706"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060write!(out,\u0022{hash:08X}.EPU\u0022)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060upload_short_alias\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"proto/src/upload.rs"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"c322ae849531cb3dec5a7baab80f636a4f5377dbb4c6f51fbbad799f87ad88d7"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060env::var(\u0022OUT_DIR\u0022)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/build.rs"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"9736cac6d9f65b1519ba2700ebd3303ceae13bcc56f9080bcfa191a18d2a5500"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060fs::write(out_dir.join(\u0022ram-layout.x\u0022),script)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/build.rs"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac61e2462585b0ae2a016856ac2ab56ca536bdb72bfc0990787da76e1897a207"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060esp_hal::i2c::master::I2c::new(peripherals.I2C0,esp_hal::i2c::master::Config::default().with_frequency(Rate::from_khz(400)).with_timeout(esp_hal::i2c::master::BusTimeout::BusCycles(2000)),)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":349}}}],"partialFingerprints":{"codehealthFindingId/v1":"3768ae59962640af18d374a0fb30fe17ae2e1acd61fa84c53bf4d9de9d1c45ce"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060esp_hal::dma::DmaRxBuf::new(rx_descriptors,rx_buffer)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":382}}}],"partialFingerprints":{"codehealthFindingId/v1":"4364f2e4c68d127ecd5e13f9f6e493ad3876c9042890458a2f4c2148ce61ec02"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060esp_hal::dma::DmaTxBuf::new(tx_descriptors,tx_buffer)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fbb0a598b96b1c87747d6e9042b50cd1423840dbc44f31ae71d35825af00bf5"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060Spi::new(peripherals.SPI2,SpiConfig::default().with_frequency(Rate::from_hz(display::epd::SPI_HZ)).with_mode(esp_hal::spi::Mode::_0),)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":390}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e4ae475244dc96ca0386e94a30ea13f5da05a4054b45a813c36bc17012dbb98"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::bench_serial::run(peripherals.USB_DEVICE)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":408}}}],"partialFingerprints":{"codehealthFindingId/v1":"8eb22a0a367a0788681c505a8918f9cc9c4e253dcb60913dbc7c373fcabda8da"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::input::run(adc1,InputPins{power:power_button,#[cfg(not(feature=\u0022device-x3\u0022))]aux_pin:aux_adc,nav_pin:nav_adc,page_pin:page_adc,},)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":421}}}],"partialFingerprints":{"codehealthFindingId/v1":"c45af8240fb651db7899f21f40d57e181ee2de5823a5a9000e8850dec7736957"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::input::battery_run(battery_gauge)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":431}}}],"partialFingerprints":{"codehealthFindingId/v1":"75abe18f234a68990c3a5bed21c942f12384931ac915833d5e868483f22aec41"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::display::run(epd_bus,sd_cs,epub_scratch)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":433}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ee695f1814fdc35fc390b55a604170edcf42d0352f1dcb65d6f474bd5ae5b04"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::power::run(peripherals.LPWR)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ab06639c3fc1dab84140ea82952515e921f64b661bb51dc2e49100fae09b7bc"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::power::report_light_sleep()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":437}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ddf1be97656140f3a450bbd912d3f4d50f296b593b61fe29e95178afe57b2fc"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060crumbs::heartbeat()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":439}}}],"partialFingerprints":{"codehealthFindingId/v1":"56df55b145c0d2712196508d0783931ae47f84efc78a9d211ee19bb91f4452e2"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::bench_unplug::run()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":441}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0a89cc9d9d8ed5a601279c1244ab6d8b99ee86d18c2669173acab39766df5fd"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::app::run()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":443}}}],"partialFingerprints":{"codehealthFindingId/v1":"b97dc3c7fa129c42ee31a463eecacd1fce2e8cfa9034adb582cb5b18e0270f6b"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060tasks::wifi::run(spawner,peripherals.WIFI)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060main\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/main.rs"},"region":{"startLine":445}}}],"partialFingerprints":{"codehealthFindingId/v1":"f037e0f79a1f9cffb5b1d4d67a8bc96f7ad5dd8744c961c8e7b2f9e14f4c97b7"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060parse_error.take()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060lay_out_spine\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2339}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e9b5e06b6b31ef9896724ae600d0298e848ddae96c9ceb61a423ea73a7bf051"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060last_err\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060read_at\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache.rs"},"region":{"startLine":2695}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fdc6297606f0561ab9d58415af7d14a4446fd3756a43bb777be2a6953949072"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060f.take()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060run_sd_session\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/sd_session.rs"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"68962fc0cfd9e03288999443f5d8dd03b9b1d0ce6617a4bc0e25c79297d870d5"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060crate::sync_mem::take_prev_fb()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060run\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d4883eac1913ed97e82ba2882b214ed89736083f79fab6547e8a208540c5cd5"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060epub_scratch.as_deref_mut()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.expect()\u0060 in \u0060ensure_epub_scratch\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/display.rs"},"region":{"startLine":1622}}}],"partialFingerprints":{"codehealthFindingId/v1":"0256f040b739c9e5662ff6ae11a315d54a8eaf274ab69b4f0180bc7bd21a37de"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060net_task(runner)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060run\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"cadc0703ceef43f7357c57efa477f5199b4aa7ce318e9d0770a25cdb458030e0"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060ap_net_task(runner)\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060run_portal\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/wifi.rs"},"region":{"startLine":582}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e6e40ec27eeb4acb73b369f2422c9f5322ca28d4faf7d9835f4c302519e5d2a"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060footer[8..12].try_into()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060candidate\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files/book_generation.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"99a895c1c9a20527652c5525e14877e5e203d63e55fc5b64bf1385646302477d"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060footer[4..8].try_into()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060candidate\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files/book_generation.rs"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5f59362d99c9f74fc4cde83f59359a9cbf802c99c240a69a94e37ce6fea2ce8"}},{"ruleId":"X5","level":"warning","message":{"text":"Symbol treated as nullable, then dereferenced unguarded: \u0060footer[12..16].try_into()\u0060 can be absent \u2014 it is an \u0060Option\u0060 or \u0060Result\u0060, which is why it is forced \u2014 and \u0060.unwrap()\u0060 in \u0060candidate\u0060 forces it with nothing on this path excluding \u0060None\u0060/\u0060Err\u0060: no \u0060if let\u0060 or \u0060match\u0060 arm that matched it present, no \u0060let \u2026 else\u0060, no \u0060is_some()\u0060/\u0060is_ok()\u0060 test (or \u0060is_none()\u0060/\u0060is_err()\u0060 test that leaves), no \u0060assert!\u0060 of it, and for a lookup no proof the key or index exists. This line panics the first time the value is not there. Handle the absent case where it arises: propagate it with \u0060?\u0060, branch on it with \u0060if let\u0060 / \u0060match\u0060 / \u0060let \u2026 else\u0060, or give it a default (\u0060unwrap_or\u0060, \u0060unwrap_or_default\u0060, \u0060unwrap_or_else\u0060)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files/book_generation.rs"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"b29f5c6c422906a859769ce50c641d8fe088253b1f14ffea590a8c154f1856fe"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on Err: \u0060kerning_adjust_fp\u0060 turns every \u0060Err\u0060 into \u00600\u0060 \u2014 a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with \u0060?\u0060. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"display/src/font.rs"},"region":{"startLine":223}}}],"partialFingerprints":{"codehealthFindingId/v1":"36e7e1312ca5a74bb62447e029d62f81995ef04ab19f637963618a23e7cb87b6"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on Err: \u0060read_v2_book_total_pages\u0060 turns every \u0060Err\u0060 into \u00600\u0060 \u2014 a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with \u0060?\u0060. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":598}}}],"partialFingerprints":{"codehealthFindingId/v1":"f77e58ac58b6ff87238ef485c8561cef3c0e4a71347486b554fedd632b392bd3"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on Err: \u0060load_v2_book_index\u0060 turns every \u0060Err\u0060 into \u0060false\u0060 \u2014 a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with \u0060?\u0060. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/reader_cache_files.rs"},"region":{"startLine":852}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5b46755a88658fde3435944336fe571785ecad0926e9b3efda41a03b2e930e4"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on Err: \u0060read_adc\u0060 turns every \u0060Err\u0060 into \u00600\u0060 \u2014 a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with \u0060?\u0060. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fw/src/tasks/input.rs"},"region":{"startLine":519}}}],"partialFingerprints":{"codehealthFindingId/v1":"98759fb9babde824e8604386a0d831a3c1eacb3f3650f5c2949a5aa3a27246cc"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1357","guid":"e4d2e772-757e-0a5c-bd7d-77052949d866","name":"Reliance on Insufficiently Trustworthy Component","shortDescription":{"text":"Reliance on Insufficiently Trustworthy Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1357.html"},{"id":"CWE-1395","guid":"800e09e7-c11a-8654-9fa6-86f398995fed","name":"Dependency on Vulnerable Third-Party Component","shortDescription":{"text":"Dependency on Vulnerable Third-Party Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1395.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-353","guid":"09d7e902-d4ee-f05d-ae6c-0a1554d0c18f","name":"Missing Support for Integrity Check","shortDescription":{"text":"Missing Support for Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/353.html"},{"id":"CWE-494","guid":"b8a65e0d-e459-4a55-a931-fc1136482375","name":"Download of Code Without Integrity Check","shortDescription":{"text":"Download of Code Without Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/494.html"},{"id":"CWE-506","guid":"401d6455-56e3-0552-9a39-f77461673e3f","name":"Embedded Malicious Code","shortDescription":{"text":"Embedded Malicious Code"},"helpUri":"https://cwe.mitre.org/data/definitions/506.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-937","guid":"16f316ae-415c-b354-a59b-1f7905f756e9","name":"Using Components with Known Vulnerabilities","shortDescription":{"text":"Using Components with Known Vulnerabilities"},"helpUri":"https://cwe.mitre.org/data/definitions/937.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A03:2025","guid":"168e227c-7735-2e57-bc6e-997affe644c5","name":"Software Supply Chain Failures","shortDescription":{"text":"Software Supply Chain Failures"},"helpUri":"https://top10.owasp.org/2025/A03_2025-Software_Supply_Chain_Failures/"},{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"},{"id":"A08:2025","guid":"84b0c297-710e-9a5f-9335-936ecb260c36","name":"Software or Data Integrity Failures","shortDescription":{"text":"Software or Data Integrity Failures"},"helpUri":"https://top10.owasp.org/2025/A08_2025-Software_or_Data_Integrity_Failures/"}]},{"name":"OWASP Top 10 CI/CD Security Risks","guid":"3c9b2a6e-5d14-4f7b-8e02-6a1d9c4b7f35","organization":"OWASP Foundation","informationUri":"https://owasp.org/www-project-top-10-ci-cd-security-risks/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10 CI/CD Security Risks."},"taxa":[{"id":"CICD-SEC-3","guid":"458c83a6-ebf7-cf55-8cc3-b4d949bbf271","name":"Dependency Chain Abuse","shortDescription":{"text":"Dependency Chain Abuse"},"helpUri":"https://owasp.github.io/www-project-top-10-ci-cd-security-risks/CICD-SEC-03-Dependency-Chain-Abuse"},{"id":"CICD-SEC-8","guid":"b6b2dacf-a168-4957-876e-a8c73ee00eb0","name":"Ungoverned Usage of 3rd Party Services","shortDescription":{"text":"Ungoverned Usage of 3rd Party Services"},"helpUri":"https://owasp.github.io/www-project-top-10-ci-cd-security-risks/CICD-SEC-08-Ungoverned-Usage-of-3rd-Party-Services"},{"id":"CICD-SEC-9","guid":"b3d36727-0395-5b51-94c4-5e173d62eab3","name":"Improper Artifact Integrity Validation","shortDescription":{"text":"Improper Artifact Integrity Validation"},"helpUri":"https://owasp.github.io/www-project-top-10-ci-cd-security-risks/CICD-SEC-09-Improper-Artifact-Integrity-Validation"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":24,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}