{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D8","name":"Code Coverage","shortDescription":{"text":"Code Coverage"},"helpUri":"https://codehealth.canine.dev/dimensions/D8"},{"id":"D11","name":"Test Reliability","shortDescription":{"text":"Test Reliability"},"helpUri":"https://codehealth.canine.dev/dimensions/D11"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX8","name":"Test isolation","shortDescription":{"text":"Test isolation"},"helpUri":"https://codehealth.canine.dev/dimensions/AX8"},{"id":"AX9","name":"CQS / query purity","shortDescription":{"text":"CQS / query purity"},"helpUri":"https://codehealth.canine.dev/dimensions/AX9"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P12","name":"CI test-gate honesty","shortDescription":{"text":"CI test-gate honesty"},"helpUri":"https://codehealth.canine.dev/dimensions/P12"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"AerialView.setup (cyclomatic 31): AerialView.setup has cyclomatic complexity 31 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This file is where this pass\u0027s cyclomatic complexity CONCENTRATES: Aerial/Source/Views/AerialView.swift holds 2 of the 8 methods over the threshold \u2014 including the worst \u2014 and 19 of the 30 points over it (63%), 3.8\u00D7 the next-largest file (Aerial/Source/Models/Cache/Cache.swift at 5). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee191bc602b8a7b1dc6e21c9a90120478a0aa7c1303d84e7acbb79ab560d8896"}},{"ruleId":"D1","level":"warning","message":{"text":"Cache.freeCache (cyclomatic 18): Cache.freeCache has cyclomatic complexity 18 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":704}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdfa238846103c221db12c62e1f3d1c3577b55b17f5a923ccbc6715e054e2a3f"}},{"ruleId":"D1","level":"warning","message":{"text":"AerialView.playNextVideo (cyclomatic 18): AerialView.playNextVideo has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass\u0027s cyclomatic complexity CONCENTRATES: Aerial/Source/Views/AerialView.swift holds 2 of the 8 methods over the threshold \u2014 including the worst \u2014 and 19 of the 30 points over it (63%), 3.8\u00D7 the next-largest file (Aerial/Source/Models/Cache/Cache.swift at 5). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":778}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6e269b6f99c143c2c20ba5e240f0837420269d36b4135d6c388dc6a5c5fc6b4"}},{"ruleId":"D1","level":"warning","message":{"text":"Cache.supportPath (cyclomatic 17): Cache.supportPath has cyclomatic complexity 17 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"f58dd10e32c3e64d61f9851f6d93656438e05e18e0af46c0b7bbf4d0756d7aac"}},{"ruleId":"D1","level":"warning","message":{"text":"Thumbnails.generate (cyclomatic 17): Thumbnails.generate has cyclomatic complexity 17 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Thumbnails.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"07c70fd1d59af23ca25e46aaea0c357dee9bce86e82ace179bec872b3b21765e"}},{"ruleId":"D1","level":"warning","message":{"text":"TimeManagement.shouldRestrictPlaybackToDayNightVideo (cyclomatic 17): TimeManagement.shouldRestrictPlaybackToDayNightVideo has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Time/TimeManagement.swift"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7fed92bce6e821394cf1c0beffaf836923d64f52ad2e64190cef3b3b20afbc8"}},{"ruleId":"D1","level":"warning","message":{"text":"DisplayView.draw (cyclomatic 16): DisplayView.draw has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/DisplayView.swift"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"65abd36cbedffbf7aee9efd1d24b6c4d8a2ac7907599444a6ec3620a527b679a"}},{"ruleId":"D1","level":"warning","message":{"text":"InfoWeatherView.testLocationButtonClick (cyclomatic 16): InfoWeatherView.testLocationButtonClick has cyclomatic complexity 16 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoWeatherView.swift"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"178e743ef235722bd907a35ab1f04c837d5eba341a8f3b6d33a51896288f803e"}},{"ruleId":"D2","level":"warning","message":{"text":"Cache.supportPath (cognitive 47): Cache.supportPath has cognitive complexity 47 (threshold 15). Drivers by points: if/else 19 (35 pts), error handling 3 (11 pts), boolean chains 1 (nesting depth added 24). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"50b07fa2491d64d2accbbfb6a2a064d90a2e86b1a3f958768b78d5d0703bfd8e"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.setup (cognitive 46): AerialView.setup has cognitive complexity 46 (threshold 15). Drivers by points: if/else 29 (38 pts), boolean chains 7, loops 1 (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a25b669e1c86dd65cad30b27ba8ab76b4c3657b7fd585199000542e1a93adef"}},{"ruleId":"D2","level":"warning","message":{"text":"DisplayView.draw (cognitive 46): DisplayView.draw has cognitive complexity 46 (threshold 15). Drivers by points: if/else 20 (44 pts), boolean chains 1, loops 1 (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/DisplayView.swift"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"8cb3dd3fa81f241da03fc6c45a0b093323f9adb00bca9344320e9e889ca8da03"}},{"ruleId":"D2","level":"warning","message":{"text":"Thumbnails.generate (cognitive 32): Thumbnails.generate has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (23 pts), boolean chains 8, error handling 1 (nesting depth added 11). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Thumbnails.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1efa769df004d80329cc9f180287aa3034d3a7d96cd2e7dc55ca368b2f3d9b4"}},{"ruleId":"D2","level":"warning","message":{"text":"Cache.freeCache (cognitive 31): Cache.freeCache has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (18 pts), error handling 3 (8 pts), loops 4, boolean chains 1 (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":704}}}],"partialFingerprints":{"codehealthFindingId/v1":"59c5476ed3a3ffac8295174525be52bc24b9495eb10775da188d26ef518e9338"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.playNextVideo (cognitive 28): AerialView.playNextVideo has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (25 pts), boolean chains 1, loops 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":778}}}],"partialFingerprints":{"codehealthFindingId/v1":"26de36edb76bc2d9251860f82f357240e04db2c2de2132052da8cc7bd642ce28"}},{"ruleId":"D2","level":"warning","message":{"text":"InfoWeatherView.testLocationButtonClick (cognitive 28): InfoWeatherView.testLocationButtonClick has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (18 pts), error handling 2 (4 pts), match/switch 2 (4 pts), boolean chains 2 (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoWeatherView.swift"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"409b263f3743f6d2254168e9b7c8494120c89aa34502e05069fdd8538cb7920c"}},{"ruleId":"D2","level":"warning","message":{"text":"VideoCache.isAvailableOffline (cognitive 27): VideoCache.isAvailableOffline has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (20 pts), error handling 2 (7 pts) (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoCache.swift"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb3a07ceeaa2508150ba1c097b488f9c79183af5b9918f93cd6f2ddfdd166fd6"}},{"ruleId":"D2","level":"warning","message":{"text":"TimeManagement.shouldRestrictPlaybackToDayNightVideo (cognitive 27): TimeManagement.shouldRestrictPlaybackToDayNightVideo has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (21 pts), ternaries 2 (4 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Time/TimeManagement.swift"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"86866ae51705d09b1763237cd273521bd386d009a8ad469c2d9e3dac62dff548"}},{"ruleId":"D2","level":"warning","message":{"text":"Music.mediaRemoteCallback (cognitive 25): Music.mediaRemoteCallback has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (21 pts), ternaries 1 (3 pts), loops 1 (nesting depth added 14). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Music/Music.swift"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3a155f999a9741a94ad5d2dcddd6df137b8cd1ed8ebbfa33090c13b913ff3c0"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.keyDown (cognitive 25): AerialView.keyDown has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 2 (10 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":911}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d299261f8842587df3d5d28d47870707ea61b5a1615cd4e83e2c87769be79c1"}},{"ruleId":"D2","level":"warning","message":{"text":"NSImage.getTrimmedRect (cognitive 24): NSImage.getTrimmedRect has cognitive complexity 24 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 8 (12 pts) (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Extensions/NSImage\u002Btrim.swift"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"a18094c08ed7fcdfc2f5d46bc89ae0f78505a0868fcaaa4f5aabc9b4de990d19"}},{"ruleId":"D2","level":"warning","message":{"text":"Aerial.migratePreferences (cognitive 23): Aerial.migratePreferences has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (12 pts), error handling 2 (7 pts), loops 1 (4 pts) (nesting depth added 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":374}}}],"partialFingerprints":{"codehealthFindingId/v1":"195709a948f4c343b5e4ebb625398f00e5456fa6eaff44829cff24dee3aaab64"}},{"ruleId":"D2","level":"warning","message":{"text":"NightShift.getInformation (cognitive 23): NightShift.getInformation has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 1, loops 1 (nesting depth added 8). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/NightShift.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"33f584fe08d9ed0635b7297393e87389ef7a6ffd8c499c2507b4189de6b614dd"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.observeValue (cognitive 23): AerialView.observeValue has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":561}}}],"partialFingerprints":{"codehealthFindingId/v1":"08fbdf63898a55b07aa821ca3e8a032d8a9cc9f1cf0b96cd9daa1cc1280a1899"}},{"ruleId":"D2","level":"warning","message":{"text":"Cache.removeCruft (cognitive 22): Cache.removeCruft has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 2 (7 pts), error handling 1 (2 pts) (nesting depth added 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"54a7807ee0ecaece5369d40373f0e66aeebec33ce1de360ef7d65f24b7bc9587"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.setupPlayerLayer (cognitive 22): AerialView.setupPlayerLayer has cognitive complexity 22 (threshold 15). Drivers by points: if/else 15 (20 pts), boolean chains 2 (nesting depth added 5). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView\u002BPlayer.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"770490c64c791b1ec256827831d369415c552d8ec240d9629212f9e14c82762a"}},{"ruleId":"D2","level":"warning","message":{"text":"ManifestLoader.getOldFilesEstimation (cognitive 21): ManifestLoader.getOldFilesEstimation has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (9 pts), error handling 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":929}}}],"partialFingerprints":{"codehealthFindingId/v1":"c483eb1117a28649bcf691673d88d150e9448c4e2756b93527ef7a141b813c8b"}},{"ruleId":"D2","level":"warning","message":{"text":"Cache.removeUncachedCruft (cognitive 19): Cache.removeUncachedCruft has cognitive complexity 19 (threshold 15). Drivers by points: if/else 2 (9 pts), loops 3 (8 pts), error handling 1 (2 pts) (nesting depth added 13). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5194ae40979284a2f8e6d727d0e3467f8af3d61539f093179f8c8ea4ee75742"}},{"ruleId":"D2","level":"warning","message":{"text":"PoiStringProvider.getCommunityPathForLocale (cognitive 18): PoiStringProvider.getCommunityPathForLocale has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (18 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/PoiStringProvider.swift"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe8f7c85230628c50e546250d8099d957ed7cbea271c6556125f28df2386ddbe"}},{"ruleId":"D2","level":"warning","message":{"text":"DisplayDetection.getGlobalScreenRect (cognitive 18): DisplayDetection.getGlobalScreenRect has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (DisplayDetection.getZeroedActiveSpannedRect) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":279}}}],"partialFingerprints":{"codehealthFindingId/v1":"c61eecf51c73746eb96934f9b2adf53bac4e2403d80cc7ac561db5d634962e6a"}},{"ruleId":"D2","level":"warning","message":{"text":"DisplayDetection.getZeroedActiveSpannedRect (cognitive 18): DisplayDetection.getZeroedActiveSpannedRect has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (DisplayDetection.getGlobalScreenRect) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":325}}}],"partialFingerprints":{"codehealthFindingId/v1":"52a36784d243888fa833b79ee619a28aae9bd5f948ae3556a81103f201d7b095"}},{"ruleId":"D2","level":"warning","message":{"text":"ManifestLoader.generatePlaylist (cognitive 17): ManifestLoader.generatePlaylist has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), boolean chains 4, loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab16343aab8e232fb219ac842811d3b0c8b36eadda9819d08404c188666b9f86"}},{"ruleId":"D2","level":"warning","message":{"text":"DisplayDetection.isScreenActive (cognitive 17): DisplayDetection.isScreenActive has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (16 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":366}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7a4a591002f8af9571b2af5f4021e49c5076802f27bf5f719918f81ded42879"}},{"ruleId":"D2","level":"warning","message":{"text":"HardwareDetection.getSuggestedFormat (cognitive 17): HardwareDetection.getSuggestedFormat has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (16 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/HardwareDetection.swift"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"54e5397e0dfcaa460a00b8a9bebb80f4ec854975b4e06903cc9405788dc4eb3c"}},{"ruleId":"D2","level":"warning","message":{"text":"CustomVideoController.outlineView (cognitive 16): CustomVideoController.outlineView has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":491}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d9658ba70dc92ad393ae78d98433fe4922b39e339de5fea4fee467b45198298"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialVideo.init (cognitive 16): AerialVideo.init has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12 (15 pts), match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/AerialVideo.swift"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"8daab0cafa78cc04c159580c5b39cec22e254a2a8c004ef3eaf74c86e8ab9cce"}},{"ruleId":"D2","level":"warning","message":{"text":"Solar.getTimeSlice (cognitive 16): Solar.getTimeSlice has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9, boolean chains 7. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Time/Solar.swift"},"region":{"startLine":283}}}],"partialFingerprints":{"codehealthFindingId/v1":"27f7a886c4ae4b3d160828b33d8b6a939510e42ef11174f2ad7a4bed2e53aa0d"}},{"ruleId":"D2","level":"warning","message":{"text":"AerialView.setDimTimers (cognitive 16): AerialView.setDimTimers has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 8). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView\u002BBrightness.swift"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"13f41a8212fec3f9fdd63bb7112792284446855e9e9b28f4e7384a8988ae28c8"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: AerialView: ClassTooLong \u2014 566 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 166 over it, 1.42\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"675b629eea974d38bec30c21dda3422b5a169760e97f36146666f4b6dc5af8ae"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AerialView: TooManyMethods \u2014 42 methods, declared across 3 files: Views/AerialView.swift (32), Views/AerialView\u002BPlayer.swift (8), Views/AerialView\u002BBrightness.swift (2). The bar is 30 methods; this is 12 over it, 1.40\u00D7 the bar. That list is where to read them, not a suggestion to split the file: the members belong to the type wherever they are declared, so moving them between files leaves the count unchanged. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"aae7aa1687df133401681631f1392c289bc42aa72d109e1ee8a456af07511ffd"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: Views/AerialView.swift: FileTooLong \u2014 571 significant lines (blank, comment-only and punctuation-only lines excluded), about 99% of them inside a single declaration: AerialView (16-1017). The bar is 500 significant lines; this is 71 over it, 1.14\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"40ce366cd9cc08b3e4979fe4b136b5fe17b9d88514dde05d85897f16933f4c0d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: CustomVideoController: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"a51a03be27b08601efbbbc91c1e8402e9f6ff50455119a810c2b9f4703a61c97"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DisplayView.draw: MethodTooLong \u2014 draw runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/DisplayView.swift"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec6320776f4eb505f2eaf2aa7adbff5121e9256d86ef9f9018ed3b8c25a76375"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManifestLoader: ClassTooLong \u2014 401 significant lines (blank, comment-only and punctuation-only lines excluded), 21 methods. The bar is 400 significant lines; this is 1 over it, 1.00\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe217942a8b0c4dd7db3a35216f0373a476c0bd74805d0dd460dba784a427911"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member pair (47 shared lines): Aerial/Source/Controllers/CustomVideoController.swift:173-252 | Aerial/Source/Models/Sources/SourceList.swift:327-393 \u2014 These two members are variants of one another: 47 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members\u0027 grain \u2014 factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"db871d2ad41f8c2ecbe25a2568576490dfb806b457bdd0b195abc246cdd94bc4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): Aerial/Source/Models/Hardware/DisplayDetection.swift:279-302 | Aerial/Source/Models/Hardware/DisplayDetection.swift:325-354 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":279}}}],"partialFingerprints":{"codehealthFindingId/v1":"75400b5b312511f7c834e8ac220143b981fca471a1932d1f527bfccebb37bec0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (28 corresponding lines): Aerial/Source/Models/ManifestLoader.swift:898-925 | Aerial/Source/Models/Sources/SourceInfo.swift:301-328 \u2014 These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":898}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd3e6a395a4ba2b93cd69a300f9cb380f377a9f6de1467abdb16effada983da7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): Aerial/Source/Models/Cache/Cache.swift:329-348 | Aerial/Source/Models/Cache/Cache.swift:353-375 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"455f5b099042214cc31e49d680eebdee0e8b2f3c8e431ee1cae7864253d11b71"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): Aerial/Source/Models/Aerial.swift:227-253 | Aerial/Source/Models/Aerial.swift:286-312 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":227}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c4b15afaaf9dd450dc983a110b41a1222f08fee07b765b21aef80d6da86c1f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): Aerial/Source/Models/Aerial.swift:144-163 | Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:168-188 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"d85fc2fc0702a6a16910ab52e95197fafdfb77deee0dbd5902faae08ff4f6e54"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): Aerial/Source/Models/Cache/Cache.swift:554-568 | Aerial/Source/Models/Cache/Cache.swift:570-588 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":554}}}],"partialFingerprints":{"codehealthFindingId/v1":"76dd3e40f814f62e0a88a0105fb847a442521bc011cb4560b51808e1dcfc2157"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): Aerial/Source/Views/AerialView\u002BPlayer.swift:116-130 | Resources/MainUI/VideosViewController.swift:87-96 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView\u002BPlayer.swift"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bdb2061dfd41e39e32fab970c4ea558a2b41f3f592594ae9f67259368a8ddbf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): Aerial/Source/Controllers/CustomVideoController.swift:365-374 | Aerial/Source/Controllers/CustomVideoController.swift:389-399 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":365}}}],"partialFingerprints":{"codehealthFindingId/v1":"75ef0a49130ad56a14d7659c55d05180c52596d42738d2148d870be91148f6d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 9\u002B corresponding lines): Aerial/Source/Models/Aerial.swift:97-105 | Aerial/Source/Models/Aerial.swift:107-116 | Aerial/Source/Models/Aerial.swift:118-130 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bd415cb99f1fe4baf895a0c22f3a52bffb96ed132de2e744d2f463d836c4576"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 7\u002B corresponding lines): Aerial/Source/Controllers/CustomVideoController.swift:277-283 | Aerial/Source/Controllers/CustomVideoController.swift:314-321 | Aerial/Source/Controllers/CustomVideoController.swift:323-330 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":277}}}],"partialFingerprints":{"codehealthFindingId/v1":"04485efa4c62ecb05d66207496e09703c3ac4759b06b8795b1a1f8989b2c1c01"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): Aerial/Source/Views/PrefPanel/InfoSettingsTableSource.swift:49-55 | Aerial/Source/Views/PrefPanel/InfoTableSource.swift:65-74 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoSettingsTableSource.swift"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b5cf69bfe520a2249800a5671f8a44e1f6828e4c827b8b262d8d9a379d5a6b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): Aerial/Source/Models/Cache/Cache.swift:546-549 | Aerial/Source/Models/Cache/VideoCache.swift:134-141 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":546}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d03b3c5bc5da2f1cd4523fd8f55d5b0c571738180d50ad3f5897d3eb9a922b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): Aerial/Source/Models/Extensions/NSButton\u002Bicons.swift:14-17 | Aerial/Source/Models/Extensions/NSMenuItem\u002Bicons.swift:12-15 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Extensions/NSButton\u002Bicons.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8f680097dd289193de74df429b84bc7ab85816d70947bf27595c96898990856"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (32\u201335 lines \u00D7 2): Aerial/Source/Models/Cache/VideoDownload.swift:289-320 | Aerial/Source/Models/Cache/VideoLoader.swift:205-239 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoDownload.swift"},"region":{"startLine":289}}}],"partialFingerprints":{"codehealthFindingId/v1":"721bc772d3c76fabc9e18d2faf8b30869bb87ff7fde9eda8e22535f8a748f65d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): Aerial/Source/Models/Aerial.swift:230-253 | Aerial/Source/Models/Aerial.swift:289-312 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Aerial.swift:230\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"a27fa7156b132886ea7e2e69e3edb57468757e0060065094d75d584009f19fe5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201323 lines \u00D7 2): Aerial/Source/Views/AerialView.swift:840-861 | Aerial/Source/Views/AerialView.swift:880-902 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Views/AerialView.swift:880\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060Aerial/Source/Views/AerialView.swift:877\u0060 calls \u0060global\u0060 and \u0060Aerial/Source/Views/AerialView.swift:835\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":840}}}],"partialFingerprints":{"codehealthFindingId/v1":"fefc1d7ad26018bfab1ec269be34e68b1eed8dd8ebaf57a7d03ffe46dd9a0c62"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): Aerial/Source/Controllers/CustomVideoController.swift:203-224 | Aerial/Source/Models/Sources/SourceList.swift:364-385 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Controllers/CustomVideoController.swift:203\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"397a6eeeaf3bc60b6ea033c01a61ccd0409cb2ab2e5d70afdce9baa94cd0a67d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 3): Aerial/Source/Controllers/CustomVideoController.swift:184-200 | Aerial/Source/Models/Sources/SourceList.swift:288-305 | Aerial/Source/Models/Sources/SourceList.swift:344-360 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Controllers/CustomVideoController.swift:184\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4e300ea85ec700cc5c0e5b74872ea6338accc4b99f70c8a091072e3ebd005c8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): Aerial/Source/Models/Cache/TimeMachine.swift:41-58 | Aerial/Source/Models/Cache/TimeMachine.swift:61-78 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any \u0060return\u0060 inside it is the body\u0027s own exit and keeps its meaning in the moved unit."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/TimeMachine.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"992988d992187281593c2bb69cdd0979e69da8930b827dfc291f98ff94273d4e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 3): Aerial/Source/Models/Cache/TimeMachine.swift:14-29 | Aerial/Source/Models/Cache/TimeMachine.swift:41-57 | Aerial/Source/Models/Cache/TimeMachine.swift:61-77 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/TimeMachine.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6a88146b9037e742584694e57ef65b70557277a0019e33b58fb38f998cc1d5e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): Aerial/Source/Models/Cache/Cache.swift:332-348 | Aerial/Source/Models/Cache/Cache.swift:358-374 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Cache/Cache.swift:332\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":332}}}],"partialFingerprints":{"codehealthFindingId/v1":"f330aff726dc14be3918ac3772991e61e9e34000d6fcadca733a8c60d4ecbc84"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): Aerial/Source/Models/Hardware/DisplayDetection.swift:286-298 | Aerial/Source/Models/Hardware/DisplayDetection.swift:332-344 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Hardware/DisplayDetection.swift:286\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b7b0b3283d86bee291f1c4121762ca9d074110962ea7887b07ab74db96c2958"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): Aerial/Source/Models/Cache/Thumbnails.swift:47-59 | Aerial/Source/Models/Cache/Thumbnails.swift:65-77 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Cache/Thumbnails.swift:47\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Thumbnails.swift"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"39227d533773a0f9ea281ee60fef295be8b3af5975fdf233c0898d1939f1d30f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u201310 lines \u00D7 2): Aerial/Source/Controllers/CustomVideoController.swift:173-182 | Aerial/Source/Models/Sources/SourceList.swift:328-335 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Controllers/CustomVideoController.swift:173\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f4ae29d939e59e2c61af2d28ebe4795b04d5fd1422c1c7a30be39ef8231cb05"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u201310 lines \u00D7 2): Aerial/Source/Models/ManifestLoader.swift:898-907 | Aerial/Source/Models/Sources/SourceInfo.swift:303-310 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/ManifestLoader.swift:898\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":898}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7a8c588263045c9992e7e2f8abd7e892f2cba9a69e109f21d21595b0be73e87"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (3\u20139 lines \u00D7 3): Aerial/Source/Models/Cache/Cache.swift:524-526 | Aerial/Source/Models/Cache/Cache.swift:560-568 | Aerial/Source/Models/Cache/Cache.swift:577-584 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Cache/Cache.swift:524\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":524}}}],"partialFingerprints":{"codehealthFindingId/v1":"56d612774cd4fae79d3ce3616407c8dca265e4adc806d013a51246f73ec624db"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): Aerial/Source/Models/Cache/Cache.swift:741-749 | Aerial/Source/Models/Cache/Cache.swift:774-782 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/Cache/Cache.swift:741\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":741}}}],"partialFingerprints":{"codehealthFindingId/v1":"4aa87b6d74676315c7b3bf99cc2201c3a5baa3699e48af716df4447b8b3d2d6d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): Aerial/Source/Models/ManifestLoader.swift:915-925 | Aerial/Source/Models/Sources/SourceInfo.swift:318-328 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060Aerial/Source/Models/ManifestLoader.swift:915\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":915}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fcc1928b08fb82e9888a6c21f5f9c4dc65a3c8dfe02eb549ea1897cde1f3d28"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): Aerial/Source/Controllers/CustomVideoController.swift:481-485 | Aerial/Source/Models/ManifestLoader.swift:492-496 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":481}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9abae7af171b17bff6ae1e0887202889e31b84998a242f4af7d67b2293a24d0"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: Aerial (LCOM4 12): Aerial\u0027s methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5bcd77109c164dc1133b7918eee135df329746c016aa8d0bfd59c9b7eb3cf6f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoSettingsView (LCOM4 9): InfoSettingsView\u0027s methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoSettingsView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"faee7f666f43c0e8c54f68e5263e69991bb1910b3cc85a18b8a0d2679678d558"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoWeatherView (LCOM4 9): InfoWeatherView\u0027s methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoWeatherView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"bec259608025d28745ff4ee6c748f40b1f79125bf162a1c4532965822219ff67"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: CustomVideoController (LCOM4 7): CustomVideoController\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"b12ee270852725dcea55e0f02a1161732d3b219d3006a21978f526426876fa58"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoTableSource (LCOM4 7): InfoTableSource\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoTableSource.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f438405e382901f7329a3a2e1a0fff40bba2c28be57cd814878cae6a6d7f588"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AerialView (LCOM4 5): AerialView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/AerialView.swift"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"76e19877f235a7c04dbd7779247defc68dafdbc65b0399eb5468781e5f1293d0"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoCountdownView (LCOM4 5): InfoCountdownView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoCountdownView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"c12814aaae7e817418ff1744f33973f0998260f7601a67e3077e68317053731c"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoMessageView (LCOM4 5): InfoMessageView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoMessageView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b2632ce345ea8fcf6ac5a6873757bf2184623f8166bc8d8698627704dad1221"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoSettingsTableSource (LCOM4 5): InfoSettingsTableSource\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoSettingsTableSource.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"4acb06820c25eaa48e9c5d44b74469c549cafb519029768fec1ac4e3cefc0d87"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoTimerView (LCOM4 5): InfoTimerView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoTimerView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"9368bb264d15d17a08ffafbf6bc53c7a4d39149f527ba13657e038ec24e9805b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PoiStringProvider (LCOM4 4): PoiStringProvider\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/PoiStringProvider.swift"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a8b9a7e029086665328cbe5942815c0845becb0907088d09d0f5f931cf9cb13"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DisplayDetection (LCOM4 4): DisplayDetection\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/DisplayDetection.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ce42609511e0ebe751830b00c85a39a13bc612d71fdb1b1dd4bd87672654472"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: InfoClockView (LCOM4 4): InfoClockView\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoClockView.swift"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"efb9014639f3ce16b9954476f419c246f2728f516b66419fc243f4ca4a61f674"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #1: If anonymized user #1 becomes unavailable, 1 significant file(s) lose their only recent owner: Aerial/Source/Views/AerialView.swift. Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"f7198d06f5cf1bbc25e61fda88905ead956394712bb6829991ad4bdbe59c6cd9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO hide day \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoCountdownView.swift"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb338095447eca6413e36d2123ef9e4a3cd67e6f40371700be056ef2e3d22eb1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: move to extension of NSImage... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Aerial.swift"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"363f8b8943ea57b4aa7d98e26cf3b9f79d2e9fd7b2c18fe1757541e087d35aee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u0026\u0026 lhs.url1080pHEVC == rhs.url1080pHEVC \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/AerialVideo.swift"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"c66ed2449b35ca9ba91198e25eccfee5dc111b561f7b8b9a23e084eb08b78d6e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO, this is hardcoded as it\u0027s no longer available in the modern JSONs \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":766}}}],"partialFingerprints":{"codehealthFindingId/v1":"839c3e94ff7571bdfeb80196a88ad881dea9707b13fa3148a36123a3d5cb0da7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: kind of a temporary safety \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/Cache.swift"},"region":{"startLine":379}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bd27ca37f33fecfc4cfaef83c56e2a18e5e554b8f07c03d7e6d8a46564f7be2"}},{"ruleId":"D17","level":"warning","message":{"text":"FixmeComment: // FIXME: crash if key doesn\u0027t have \u0022_\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/PoiStringProvider.swift"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"dca9484f8e0a030c4bb392623872380b29eac6e63db8c2231d80cc5be3bd0801"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO : temporary for the migration \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoCache.swift"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"e491d88f717b52a3cb354769a11e3075107f73797f7ead6ff581ecb70c0b5ebd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO : Until refactor is done \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoCache.swift"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"417b3aa2877871f340a93a6853d84339e7c4385c1bc85064292a4c80babfa5fd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoDownload.swift"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5b70e2ed7a1fa2771dfbca86f4348ac21bd080a4fd68c15f785de684e3f41fd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO 2.0 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1afe02734b0667c1fb41081766b77ee3045712dea9c70de165a0631f0f554ff"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060. ADRs are expected here because \u0060Aerial.xcodeproj/project.pbxproj\u0060 makes this repository a deployable product (line 1)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial.xcodeproj/project.pbxproj"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b546ef5f59fc43ba2312f7cd224d0462353a6752975cc8d974de3eec408837b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 2 of 21 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 21 of the 31 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: Aerial/Source/Models/Cache/VideoDownload.swift, Aerial/Source/Models/Cache/VideoLoader.swift. Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoDownload.swift"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d1b7268aacf0e7af7b00a3f2482e011338fec2a3e06e8d0494d93bdccf1ec93"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Cache/VideoLoader.swift"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c3392b32decafa146d8c8fc58c26b5e8361c84fb7479342d896a3d8e31d95cf"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: Source.swift \u2194 AerialView.swift: \u0060Aerial/Source/Models/Sources/Source.swift\u0060 and \u0060Aerial/Source/Views/AerialView.swift\u0060 change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder \u2014 so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are \u0060f9c8fdbb\u0060 Fix overlays showing on wrong screens; \u00605be955e6\u0060 Fix Sonoma unable to detect monitors; \u0060037c6142\u0060 Fix local sources custom data being erased at startup \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Sources/Source.swift"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"550bfcf01120e0576fa9f70baac80cd9c8f644256eafe0b00545a63092c10e79"}},{"ruleId":"M1","level":"note","message":{"text":"Thin README: The root README is 67 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise \u2014 or with no heading at all \u2014 is not seen and this row may understate what the document covers."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Readme.md"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c80a0409a9aef4a6492d8ea5ee938b6232f53b4f9a1cf362e0772e706f6edce"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"No architecture diagram/doc: No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named \u0060architecture\u0060 or \u0060design\u0060 in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape \u2014 no \u0060## Architecture\u0060 heading, no \u0022architecture overview\u0022/\u0022high-level design\u0022 phrasing, no \u0022the architecture is \u2026\u0022 introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document \u2014 not evidence that nobody wrote the shape down."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0c190e7c159d1850ee706c3ac4486e151e8a4fe169de4bf61436b9f399654f06"}},{"ruleId":"P12","level":"warning","message":{"text":"Coverage collected but not gated: CI collects a coverage report but no step enforces a minimum \u2014 coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool\u0027s minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository\u0027s CI files AND its coverage configuration \u2014 the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited \u2014 matched against the threshold settings this check knows by name. A floor set in your coverage service\u0027s web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"7f63c06044cf998d9a0698692df30d8873e29bc9b0c98ee829255017c1193d33"}},{"ruleId":"P3","level":"note","message":{"text":"No SAST: No static application security testing detected. For this repository\u0027s stack, add CodeQL\u0027s Swift pack (Swift/Xcode) (or \u0060semgrep --config=auto\u0060, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge\u0027s web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen \u2014 if that is your case the row is wrong, and saying so is more useful than adding a second scanner."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6e54424179c892f03ef2fd003130ac4bd43f39bbf3b1ca0a0143e25acb80ec87"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060lurl.path.lowercased().hasSuffix(\u0022.mp4\u0022) || lurl.path.lowercased().hasSuffix(\u0022.mov\u0022)\u0060 appears character-identically in 2 files \u2014 Aerial/Source/Controllers/CustomVideoController.swift, Aerial/Source/Models/Sources/SourceList.swift. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Controllers/CustomVideoController.swift"},"region":{"startLine":183}}}],"partialFingerprints":{"codehealthFindingId/v1":"05fd4b690f8c76b14131732b89964510d3adee00e6998c64277ad712cc5bc88a"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060playlist.count \u003E 1 \u0026\u0026 lastPluckedFromPlaylist == playlist.first\u0060 appears character-identically in 2 files \u2014 Aerial/Source/Models/ManifestLoader.swift, Aerial/Source/Models/Sources/VideoList.swift. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":213}}}],"partialFingerprints":{"codehealthFindingId/v1":"b96940cb93258e1335cc108b25720d4b660991a2925d06784607453f97093098"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060url1080pH264 != \u0022\u0022 \u0026\u0026 video.urls[.v1080pH264] != \u0022\u0022\u0060 appears character-identically in 2 files \u2014 Aerial/Source/Models/ManifestLoader.swift, Aerial/Source/Models/Sources/SourceInfo.swift. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/ManifestLoader.swift"},"region":{"startLine":917}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9c4d2f2289d6e99a3c167e802e3bc951d883f5b7535a2cfb8e9e6ed7457dfae"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoWeatherView.swift"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"c30e4d36d01f633215cc9ab6a54ea2cb0078ee12394d391b13b4dbfef2ac05d1"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Views/PrefPanel/InfoWeatherView.swift"},"region":{"startLine":143}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4cfbe2d49a9eb42d520ca883d253404a3d60253293544a4e391b0367db7e7b0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager\u002BProperties.swift"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ce0df1bde21b73f3fe9e5986426869b950bc1ab722c50eda891c37fd59d3a58"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager\u002BProperties.swift"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"39c2176f5100598d10c201f4c410851c79f6150338a85944c7fbbcfa309b451a"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060volume\u0060 turns every thrown error into \u00600\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the error or let it propagate (\u0060throws\u0060). If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment at the \u0060catch\u0060, \u0060guard\u0060 or \u0060??\u0060, or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager\u002BProperties.swift"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"33bbc4b3b6ca3022e288c1cf3ea37b63042117a616ffb4a3bdec10e10a7691f9"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":0,"secretScannerRunsExcluded":0}}}]}