Public report of GeneralLibrary/GeneralUpdate, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 07:24 UTC · Survey ID cd_9558b696abc84ecba9d62cdea46bf941

GeneralLibrary/GeneralUpdate

Measured 17 November 2026, 07:23 UTC, at code version 126e5d8

First survey, so nothing to compare with yet Boundary Type-Coupling: not measured

Boundary Type-Coupling is not measured: Bounded contexts not declared.

CAI score 59.9out of 100 Adequate
CriticalWeakAdequateStrongExemplary

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 30,261 lines of product code in 16 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Production Readiness, 47.2

Findings by how serious they are

37 critical 309 serious 71 minor

3 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 07:23 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

64of 64 dimensions measured by tools.
399of 417 findings point to an exact file and line, so you can open each one in the code. The other 18 concern the repository as a whole, such as missing documentation.
64dimensions across 6 lenses, read from 30,261 lines of product code in 16 projects.
Chapters

Executive summary

GeneralLibrary/GeneralUpdate falls short of our standard for production, in part because we found no automated security scanning of the code, its secrets or its dependencies. It scores 59.9 out of 100 and is rated Adequate, and 18 of its 37 critical findings are security problems.

Production Readiness, at 47.2, is the weakest lens and counts most in the score. The best first step is adding automated security scanning, worth about 9.5 points. Protecting outgoing calls with timeouts comes next, worth about 5.7 points. Raising Production Readiness to 70 would lift the score to about 69.8.

Eight pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Five weaknesses in the code could be used by an attacker, and fourteen errors are caught and ignored, so failures can go unnoticed. Pinning each tool to an exact version, fixing the weaknesses the scanner points to and handling or logging the ignored errors would close these risks. Updating the vulnerable packages would fix the two packages with a known security hole, and limiting each secret to its own step would deal with the two secrets exposed to more of the pipeline than needed. The four data fields that are written but never read need removing.

The product code is 30,261 lines, about €96,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 47.2 · counts for 46%Maturity 67.1 · counts for 25%Security and Compliance 70.7 · counts for 14%Code Health 72.6 · counts for 8%Architecture 81.5 · counts for 4%Performance 85.0 · counts for 2%

If Production Readiness rose from 47.2 to 70, the lowest score rated Strong, the score would rise from 59.9 to about 69.8.

Code composition: what the lines of code are
Business logic 26%Supporting code 17%Tests 56%
Rebuild cost: about €96,000 · Estimate
Cost to rebuild€31,000 to €160,000, for 520 to 1,688 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 60. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 30,261 lines of product code, of which 26% is declarations and boilerplate, 13% straight logic and 61% logic with branches
Comment linesThe estimate prices 19,381 lines. Comment lines count towards the size of 30,261 lines but aren't priced as work.
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 9.5 points · Medium effort · Security & performance tooling
2
Give every outbound call a bound the caller can rely on: set an explicit `HttpClient.Timeout` (or pass a `CancellationToken` from a `CancellationTokenSource` with a deadline) and flow the caller's own `CancellationToken` through, so a slow endpoint fails fast instead of hanging.
Raises the score by about 5.7 points · Medium effort · Outbound HTTP resilience
3
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.
Raises the score by about 2.0 points · Low effort · Documentation Quality

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €96,000 to build again, about 0.7 person-years of work. Its weakest lens is Production Readiness, at 47.2 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing. Of all the actions in this report, it raises the score most for the work it takes: about 9.5 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.1 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 553 lines over the last 90 days, which is about 2,243 lines a year. At that pace, the extra work comes to an estimated 0.1 to 0.7 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch GeneralUpdate.Bowl Bowl GeneralUpdate.Core Core GeneralUpdate.Differential Differential GeneralUpdate.Core->GeneralUpdate.Differential GeneralUpdate.Drivelution Drivelution GeneralUpdate.Extension Extension

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

63 modules, with 103 dependencies between them. One loop runs through 3 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 23 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 Core.Download.Reporting2 Core.Models3 Core.Security4 Drivelution.Abstractions.Configuration5 Drivelution.Abstractions.Models6 Drivelution.Core.Execution7 Extension.Common.Enums8 Bowl.Internal9 Bowl.Strategies10 Core.Configuration11 Drivelution.Abstractions12 Extension.Common.DTOs13 Extension.Common.Models14 Bowl15 Core.Download.Models16 Core.FileSystem17 Core.Hooks18 Core.Network19 Drivelution20 Drivelution.Core.Pipeline21 Extension.Catalog22 Extension.Communication23 Extension.Compatibility24 Core.Differential25 Core.Download26 Core.Download.Abstractions27 Core.JsonContext28 Drivelution.Linux.Implementation29 Drivelution.MacOS.Implementation30 Drivelution.Windows.Implementation31 Extension.Dependencies32 Core.Download.Executors33 Core.Download.Orchestrators34 Core.Download.Sources35 Core.Event36 Core.Pipeline37 Extension.Core38 Core.Strategy39 Core.Silent40 Core
1 Core.Download.Reporting
2 Core.Models
3 Core.Security
4 Drivelution.Abstractions.Configuration
5 Drivelution.Abstractions.Models
6 Drivelution.Core.Execution
7 Extension.Common.Enums
8 Bowl.Internal2
9 Bowl.Strategies3
10 Core.Configuration4
11 Drivelution.Abstractions7
12 Extension.Common.DTOs2
13 Extension.Common.Models2
14 Bowl22
15 Core.Download.Models3
16 Core.FileSystem4
17 Core.Hooks1
18 Core.Network53
19 Drivelution161
20 Drivelution.Core.Pipeline2125
21 Extension.Catalog22
22 Extension.Communication82
23 Extension.Compatibility44
24 Core.Differential5
25 Core.Download22
26 Core.Download.Abstractions7
27 Core.JsonContext13131
28 Drivelution.Linux.Implementation13142
29 Drivelution.MacOS.Implementation13242
30 Drivelution.Windows.Implementation13142
31 Extension.Dependencies21
32 Core.Download.Executors62
33 Core.Download.Orchestrators55
34 Core.Download.Sources1232
35 Core.Event1110
36 Core.Pipeline314
37 Extension.Core11084363
38 Core.Strategy513181711
39 Core.Silent11
40 Core1452211
Uses a module listed above itPart of a loopThe module itself
1 Core.Download.Reporting2 Core.Models3 Core.Security4 Drivelution.Abstractions.Configuration5 Drivelution.Abstractions.Models6 Drivelution.Core.Execution7 Extension.Common.Enums8 Bowl.Internal9 Bowl.Strategies10 Core.Configuration11 Drivelution.Abstractions12 Extension.Common.DTOs13 Extension.Common.Models14 Bowl15 Core.Download.Models16 Core.FileSystem17 Core.Hooks18 Core.Network19 Drivelution20 Drivelution.Core.Pipeline21 Extension.Catalog22 Extension.Communication23 Extension.Compatibility24 Core.Differential25 Core.Download26 Core.Download.Abstractions27 Core.JsonContext28 Drivelution.Linux.Implementation29 Drivelution.MacOS.Implementation30 Drivelution.Windows.Implementation31 Extension.Dependencies32 Core.Download.Executors33 Core.Download.Orchestrators34 Core.Download.Sources35 Core.Event36 Core.Pipeline37 Extension.Core38 Core.Strategy39 Core.Silent40 CoreCore.Download.Reporting1Core.Models2Core.Security3Drivelution.Abstractions.Configuration4Drivelution.Abstractions.Models5Drivelution.Core.Execution6Extension.Common.Enums7Bowl.Internal8Bowl.Strategies9Core.Configuration10Drivelution.Abstractions11Extension.Common.DTOs12Extension.Common.Models13Bowl14Core.Download.Models15Core.FileSystem16Core.Hooks17Core.Network18Drivelution19Drivelution.Core.Pipeline20Extension.Catalog21Extension.Communication22Extension.Compatibility23Core.Differential24Core.Download25Core.Download.Abstractions26Core.JsonContext27Drivelution.Linux.Implementation28Drivelution.MacOS.Implementation29Drivelution.Windows.Implementation30Extension.Dependencies31Core.Download.Executors32Core.Download.Orchestrators33Core.Download.Sources34Core.Event35Core.Pipeline36Extension.Core37Core.Strategy38Core.Silent39Core40234722223415316121252282445227131311314213242131422162551232111031411084363513181711111452211+23 more modules (most-connected shown)

At a glance — Code Health · 72.6 · Strong ·

At a glance — Architecture · 81.5 · Strong ·

At a glance — Maturity · 67.1 · Adequate · gated by M2 ·

At a glance — Readiness · 47.2 · Weak · gated by P3, P7 ·

At a glance — Security · 70.7 · Adequate · gated by D29, D36 ·

At a glance — Performance · 85.0 · Strong ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection18High / Critical
A03:2025 — Software Supply Chain Failures11High / Critical

Roadmap

Top priorities: Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing; Give every outbound call a bound the caller can rely on: set an explicit `HttpClient.Timeout` (or pass a `CancellationToken` from a `CancellationTokenSource` with a deadline) and flow the caller's own `CancellationToken` through, so a slow endpoint fails fast instead of hanging; Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+9.5 ptsMediumSecurity & performance tooling
Give every outbound call a bound the caller can rely on: set an explicit `HttpClient.Timeout` (or pass a `CancellationToken` from a `CancellationTokenSource` with a deadline) and flow the caller's own `CancellationToken` through, so a slow endpoint fails fast instead of hanging.+5.7 ptsMediumOutbound HTTP resilience
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.+2.0 ptsLowDocumentation Quality
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.+3.7 ptsMediumRelease Hygiene
Resolve the 19 redundant comment finding(s) in Comment Value — start with StreamingHdiffDiffer.cs (3), UpdateRequestBuilderTests.cs (3), ClientStrategy.cs (2).+1.5 ptsMediumComment Value
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+2.1 ptsMediumArchitecture documentation
Resolve the 4 WriteOnlyPrivateField finding(s) in Explicit Debt — start with DownloadQueueManager.cs (2), BowlCrashPipelineTests.cs, DifferentialUpgradeIntegrationTests.cs.+1.0 ptsLowExplicit Debt
Resolve the 45 Low coverage finding(s) in Code Coverage — start with WindowsOutputDebugListener.cs (2), WindowsDriverBackup.cs, WindowsDriverValidator.cs.+1.7 ptsMediumCode Coverage

File quality

Per-file score 0–10 — a quality signature. Of 100 files carrying findings, judged against the Production bar: 3% slop · 56% mixed · 41% near-clean.

FileScoreBandWorst signal
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs3.5SlopExplicit Debt: EmptyCatchBlock
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs4.1MixedExplicit Debt: EmptyCatchBlock
REDACTED4.3MixedStatic Analysis (SAST): High: REDACTED
src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs4.6MixedExplicit Debt: EmptyCatchBlock
src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs4.6MixedCyclomatic Complexity: GeneralExtensionHost.InstallExtensionAsync (cyclomatic 21)
src/GeneralUpdate.Core/Strategy/OssStrategy.cs5.1MixedCyclomatic Complexity: OssStrategy.ExecuteClientAsync (cyclomatic 16)
REDACTED5.3MixedDependency Vulnerabilities: High CVE: REDACTED
src/GeneralUpdate.Extension/Examples/ExtensionExample.cs5.5MixedCyclomatic Complexity: ExtensionExample.RunExample (cyclomatic 19)
src/GeneralUpdate.Extension/Examples/ExtensionCatalogExample.cs5.5MixedCyclomatic Complexity: ExtensionCatalogExample.RunExample (cyclomatic 17)
src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs5.5MixedCognitive Complexity: WindowsGeneralDrivelution.ParseInfFileAsync (cognitive 26)
src/GeneralUpdate.Core/Utilities/Semver.cs5.5MixedCognitive Complexity: Semver.Normalize (cognitive 17)
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs5.9MixedCode Duplication: Members sharing a duplicated core (4 members, 50+ identical tokens)
src/GeneralUpdate.Core/FileSystem/StorageManager.cs6.1MixedExplicit Debt: EmptyCatchBlock
src/GeneralUpdate.Extension/Examples/DependencyResolverExample.cs6.1MixedExplicit Debt: EmptyCatchBlock
src/GeneralUpdate.Core/Strategy/ClientStrategy.cs6.3MixedCyclomatic Complexity: ClientStrategy.ExecuteStandardWorkflowAsync (cyclomatic 24)
src/GeneralUpdate.Core/Security/IHttpAuthProvider.cs6.3MixedCyclomatic Complexity: HttpAuthProviderFactory.Create (cyclomatic 21)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 37

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 309

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 71

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 3

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 64 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 64 dimensions across the health lenses
D1D2D3D4D5D6D8D10D13D14D15D17D18D19D21D24D26D27D28D29D30D34D35D36D37D43D44AX1AX10AX2AX3AX4AX5AX6AX8GD1IC1M1M2M3M4P1P3P4P6P7PF3S1X1X12X13X16X18X2X20X22X25X26X27X28X29X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 399 of 417 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1e864-01cc-7dcc-9dc1-faaaf5a7c83e.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 27 test(s) failed in this run, so they did not run to their end (commonly a database, container or service they need was not available here). The 22 production file(s) those tests reach are unmeasured in this run, not untested, so their figures are left out of the per-file rows and the 57.3% whatever they read, rather than published as low coverage or counted toward the figure. You can widen what we reach: optional: commit the Cobertura/OpenCover/lcov report of a run where those tests pass, and their files are read from it.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability not included — no test tier produced comparable repeat runs within its budget (other: not included — too large to re-run within its budget).
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: `dotnet list package` exited 1 with no output.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (18 contributor(s) across 1350 commit(s) sampled, automation and bot accounts excluded). One of them holds 96% of the history; the other 17 hold 0.2% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D17 Explicit Debt — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Msbuild failed when processing the file 'src/GeneralUpdate.Bowl/GeneralUpdate.Bowl.csproj' with message: Project does not contain 'Compile' target.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
  • D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (30,261 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/GeneralUpdate.Bowl/Internal/CrashJsonContext.cs`, `src/GeneralUpdate.Core/Configuration/VersionRespDTO.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadCompletedEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadStatisticsEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/UpdateInfoEventArgs.cs`, … (+12 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 31 further occurrence(s) are not listed individually; the score already reflects all 71.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.4 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Prevented

25 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was BZip2OutputStream.SendMTFValues at 67. A further 1 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being BaseDriverUpdater.MapExceptionToErrorInfo at 16 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/GeneralUpdate.Drivelution/Core/Pipeline/BaseDriverUpdater.cs (BaseDriverUpdater.MapExceptionToErrorInfo at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

BZip2OutputStream.SendMTFValues (cyclomatic 67)src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:472
BZip2OutputStream.MainSort (cyclomatic 32)src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1040
BsdiffDiffer.Clean (cyclomatic 29)src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:83
UpdateRequestBuilder.LoadFromConfigFile (cyclomatic 27)src/GeneralUpdate.Core/Configuration/UpdateRequestBuilder.cs:130
BZip2InputStream.GetAndMoveToFrontDecode (cyclomatic 26)src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:467

+ 20 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with BZip2OutputStream.SendMTFValues (cyclomatic 67), BZip2OutputStream.MainSort (cyclomatic 32). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 6.4 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.0 / 10Weak✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Prevented

37 method(s) exceeded the cognitive complexity threshold of 15; the worst was BZip2OutputStream.SendMTFValues at 135.

Semver.Normalize (cognitive 17) · ×3src/GeneralUpdate.Core/Utilities/Semver.cs:104
BZip2OutputStream.SendMTFValues (cognitive 135)src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:472
BsdiffDiffer.Clean (cognitive 81)src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:83
BZip2OutputStream.MainSort (cognitive 64)src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1040
BZip2OutputStream.HbMakeCodeLengths (cognitive 60)src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1544

+ 30 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 3 bodies over 60 down to 60 or less in Cognitive Complexity — start with BZip2OutputStream.SendMTFValues (cognitive 135), BsdiffDiffer.Clean (cognitive 81), BZip2OutputStream.MainSort (cognitive 64). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 5.0 to about 6.1/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.2 / 10Stronggated by 9 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Prevented

9 god class(es) detected.

MethodTooLong: ClientStrategy.ExecuteStandardWorkflowAsync · ×4src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396
TooManyMethods: BZip2OutputStream · ×3src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs
FileTooLong: Binary/BZip2OutputStream.cssrc/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs
ClassTooLong: BsdiffDiffersrc/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs

What to do

  1. Resolve the 4 MethodTooLong finding(s) in God Classes — start with ClientStrategy.cs, BZip2OutputStream.cs, BsdiffDiffer.cs. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 3 TooManyMethods finding(s) in God Classes — start with BZip2OutputStream.cs, ClientStrategy.cs, BZip2InputStream.cs. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 1 FileTooLong finding(s) in God Classes — start with BZip2OutputStream.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication7.2 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.2 / 10 · rule-coverage 100% · ceiling Verified

42 duplicated block group(s) detected. 7.1 % of the production lines (2,150 of 30,261) are in a reported copy. A further 43 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 1 of the 85 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Duplicated block (17 lines × 3) · ×4src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:17
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:36
Members sharing a duplicated core (6 members, 50+ identical tokens) · ×2src/GeneralUpdate.Core/Utilities/Semver.cs:190
Edited copy of a member (10 corresponding lines) · ×2src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1100
Edited copy of a member (18 corresponding lines) · ×2src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs:68

+ 50 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 4 Duplicated block (17 lines × 3) finding(s) in Code Duplication — start with Semver.cs (3), GeneralTracer.cs. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 3 Members sharing a duplicated core (4 members, 50+ identical tokens) finding(s) in Code Duplication — start with GeneralTracer.cs (2), LinuxDriverBackup.cs. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 2 Members sharing a duplicated core (6 members, 50+ identical tokens) finding(s) in Code Duplication — start with Semver.cs (2). — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

16 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 55 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D8 · Code Coverage9.1 / 10Stronggated by 53 serious findings✓ Tool-verified

What it measures: How much of the code is actually exercised by tests.

Method: Coverage from the analyzer's own run of the suite, computed per-file with structured exclusions for generated, trivial, and glue code. A coverage report found in the repository is never read. When the suite can't be built/run in-image, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Verified

Line coverage 57.3% — 45 file(s) below 50% · 44 method(s) over the CRAP-30 risk line.

Low coverage: src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs · ×45src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:1
CRAP 380: ExtensionExample.RunExamplesrc/GeneralUpdate.Extension/Examples/ExtensionExample.cs:19
CRAP 306: ExtensionCatalogExample.RunExamplesrc/GeneralUpdate.Extension/Examples/ExtensionCatalogExample.cs:19
CRAP 199: WindowsGeneralDrivelution.ParseInfFileAsyncsrc/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:326
CRAP 168: OssStrategy.ExecuteClientAsyncsrc/GeneralUpdate.Core/Strategy/OssStrategy.cs:190

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 45 Low coverage finding(s) in Code Coverage — start with WindowsOutputDebugListener.cs (2), WindowsDriverBackup.cs, WindowsDriverValidator.cs. — One of this dimension's main actionable groups (45 warning-level).
  2. Resolve the 1 CRAP 380 finding(s) in Code Coverage — start with ExtensionExample.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 CRAP 306 finding(s) in Code Coverage — start with ExtensionCatalogExample.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.

D10 · Test Quality9.8 / 10Stronggated by 21 serious findings✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

1 skipped (1 with a documented reason), 20 zero-assertion, 1 whose failure is swallowed by a catch-all, 5 mock references across 1696 tests.

No assertions: Configinfo_Validate_WithAllFields_Passes · ×20tests/CoreTest/Bootstrap/ParameterMatrixAndEventTests.cs:164
Test cannot fail: DecryptFromFile_FileDeleteFails_DoesNotThrowtests/CoreTest/Ipc/IpcEncryptionTests.cs:59
Mock-dominated test: Constructor_ShouldLoadInstalledExtensions · ×2tests/ExtensionTest/GeneralExtensionHostTests.cs:169
Mock framework: Moq · ×5
Skipped (documented): UpdateAsync_WithTimeout_ReportsTimeouttests/DrivelutionTest/Pipeline/BaseDriverUpdaterTests.cs:89

What to do

  1. Resolve the 20 No assertions finding(s) in Test Quality — start with UpgradeHubServiceTests.cs (7), DefaultExtensionLifecycleHooksTests.cs (6), ParameterMatrixAndEventTests.cs (2). — One of this dimension's main actionable groups (20 warning-level).
  2. Resolve the 2 Mock-dominated test finding(s) in Test Quality — start with GeneralExtensionHostTests.cs (2). — One of this dimension's main actionable groups (2 recommendation-level).
  3. Resolve the 1 Test cannot fail finding(s) in Test Quality — start with IpcEncryptionTests.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 116 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 17 direct `PackageReference`(s), and 101 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/GeneralUpdate.Core/Strategy/ClientStrategy.cs (2×24=48)

Hotspot: src/GeneralUpdate.Core/Strategy/ClientStrategy.cssrc/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396

What to do

  1. Resolve the 1 Hotspot finding(s) in Churn × Complexity Hotspots — start with ClientStrategy.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt8.8 / 10Adequategated by 18 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

20 deducted debt markers + unmeasured dead symbols across 30261 LoC in the .NET projects (0.6/KLoC) → score 8.8. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.

EmptyCatchBlock · ×14src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:158
WriteOnlyPrivateField · ×4src/GeneralUpdate.Extension/Download/DownloadQueueManager.cs:28
BarePragmaDisablesrc/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs:90
ObsoleteWithCallerssrc/GeneralUpdate.Drivelution/Core/Utilities/VersionComparer.cs:9

What to do

  1. Resolve the 14 EmptyCatchBlock finding(s) in Explicit Debt — start with GeneralTracer.cs (4), ExtensionCatalog.cs (2), DefaultDownloadOrchestrator.cs. — One of this dimension's main actionable groups (14 issue-level).
  2. Resolve the 4 WriteOnlyPrivateField finding(s) in Explicit Debt — start with DownloadQueueManager.cs (2), BowlCrashPipelineTests.cs, DifferentialUpgradeIntegrationTests.cs. — One of this dimension's main actionable groups (4 issue-level).
  3. Resolve the 1 BarePragmaDisable finding(s) in Explicit Debt — start with HashValidator.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

16 projects, 674 source files, 55383 hand-written lines of code (30261 production / 25122 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 11 inter-project edges.

✓ On the Gold path — maintain.

Detailed fixes: d18_recommendation.md.

D19 · Documentation Quality5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 2 documentation facets pass in full; short on: F4 map. 5 document(s) read across 6 unit(s).

Documentation: no map of the repository's partsREADME.md:1

What to do

  1. Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies among 56 declarations measured against a convention their peers follow.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D24 · Comment Value6.8 6.4 / 10Adequate✓ Tool-verified

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 94% · ceiling Documented

25 of 782 judged comments only repeat the code they sit on (3.2 %). 66 comment(s) in another language or script were not judged.

redundant comment · ×19src/GeneralUpdate.Core/Download/DownloadPlanBuilder.cs:84
doc comments repeat the names · ×4src/GeneralUpdate.Bowl/Internal/Crash.cs:23

What to do

  1. Resolve the 19 redundant comment finding(s) in Comment Value — start with StreamingHdiffDiffer.cs (3), UpdateRequestBuilderTests.cs (3), ClientStrategy.cs (2). — One of this dimension's main actionable groups (19 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion8.3 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 8.3 / 10 · rule-coverage 100% · ceiling Documented

1 of 12 projects flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesionREDACTED:1

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.7 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

79 % of calls cross a namespace and 2 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: medium — clean/modular boundaries expected.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)1.9 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 1.9 / 10 · rule-coverage 100% · ceiling Documented

19 finding(s): 0 critical, 17 high, 2 medium, 0 low. 8 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 17 file(s) — `src/GeneralUpdate.Bowl/Internal/CrashJsonContext.cs` (lines 5–6), `src/GeneralUpdate.Core/Configuration/VersionRespDTO.cs` (line 4), `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadCompletedEventArgs.cs` (line 5, line 7, line 11), `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadStatisticsEventArgs.cs` (lines 5–10), `src/GeneralUpdate.Core/Download/MultiEventArgs/UpdateInfoEventArgs.cs` (line 6), … (+12 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 5 of those file(s) — `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadCompletedEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadStatisticsEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/UpdateInfoEventArgs.cs`, `src/GeneralUpdate.Core/Event/ExceptionEventArgs.cs`, `src/GeneralUpdate.Core/Pipeline/PipelineBuilder.cs` — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 5 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (5 issue-level).
  2. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. No action in Static Analysis (SAST) — all 8 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (8 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities8.6 / 10Adequategated by 2 critical findings✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Documented

3 finding(s): 0 critical, 2 high, 1 medium, 0 low.

REDACTED
REDACTED

What to do

  1. Resolve the 2 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Every significant source file has living knowledge — recently and meaningfully worked. Counted over 124 of the 235 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md.

D35 · Change Coupling10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: REDACTED↔DefaultDownloadOrchestrator.cs 55%

Change coupling: REDACTED ↔ DefaultDownloadOrchestrator.csREDACTED:1

What to do

  1. Resolve the 1 Change coupling finding(s) in Change Coupling — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 3 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 12 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

AX10 · Code composition8.6 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons4.6 / 10Weak✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `DownloadQueueManager` is a singleton (one shared instance) but mutates instance state outside any lock (_isProcessing; e.g. `_isProcessing` at line 99). — src/GeneralUpdate.Extension/Download/DownloadQueueManager.cs:24
  • `GeneralExtensionHost` is a singleton (one shared instance) but mutates instance state outside any lock (_autoUpdateSettings, _globalAutoUpdate; e.g. `_autoUpdateSettings` at line 526). — src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:27
  • `ExtensionMetadata` is not registered, but `DependencyResolverExample` creates it and hands it to the singleton `ExtensionCatalog`, which keeps it in `_installedExtensions`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_dependencyList; e.g. `_dependencyList` at line 113). — src/GeneralUpdate.Extension/Common/Models/ExtensionMetadata.cs:15
  • `GeneralTracer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_fileListener, _currentLogDate; e.g. `_fileListener` at line 54). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:8
  • `HttpClientProvider` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_sslPolicy, _defaultAuthProvider; e.g. `_sslPolicy` at line 80). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/GeneralUpdate.Core/Network/HttpClientProvider.cs:31

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
  • A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces GeneralUpdate.Bowl ↔ GeneralUpdate.Bowl.Internal ↔ GeneralUpdate.Bowl.Strategies depend on each other. The lightest dependency in the cycle is GeneralUpdate.Bowl → GeneralUpdate.Bowl.Internal (GeneralUpdate.Bowl.BowlBootstrap → GeneralUpdate.Bowl.Internal.ICrashReporter, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/GeneralUpdate.Bowl/BowlBootstrap.cs:5

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. — src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:114

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs7.9 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • The `if` and its `else` contain the same 1 statement, so no input can make the condition matter. Implement the distinction that was intended, or drop the branch and keep the body. — src/GeneralUpdate.Core/GracefulExit.cs:29
  • `TryRollbackAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/GeneralUpdate.Drivelution/Core/Pipeline/BaseDriverUpdater.cs:498
  • A test is skipped with reason "Flaky on CI — unrelated to current changes. Runs correctly in local dev." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten. — tests/DrivelutionTest/Pipeline/BaseDriverUpdaterTests.cs:89

What to do

  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation3.0 / 10Weak✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:6
  • `tests/Directory.Packages.props` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — tests/Directory.Packages.props:6

What to do

  • Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. This codebase ships libraries/tools rather than a service it operates, so the failure lands as a hung caller — a build step, a CLI run, a UI thread — with no way out. — src/GeneralUpdate.Extension/Communication/ExtensionHttpClient.cs:39

What to do

  • Give every outbound call a bound the caller can rely on: set an explicit `HttpClient.Timeout` (or pass a `CancellationToken` from a `CancellationTokenSource` with a deadline) and flow the caller's own `CancellationToken` through, so a slow endpoint fails fast instead of hanging.
PF3 · Async & latency hygiene8.5 / 10Strong✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • 1 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:817

What to do

  • Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
S1 · Cryptographic Hygiene8.0 / 10Strong✓ Tool-verified

Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything. — src/GeneralUpdate.Core/Ipc/IpcEncryption.cs:24

What to do

  • Authenticate ciphertext, do not just encrypt it: move to an AEAD cipher (`AesGcm`, `ChaCha20Poly1305`), or where the wire format is fixed, add encrypt-then-MAC with HMAC-SHA256 over IV+ciphertext under a separately derived key and verify the tag with `CryptographicOperations.FixedTimeEquals` before decrypting. Unauthenticated CBC is malleable, and a decrypt path that distinguishes padding failures from other failures is a padding oracle.
X1 · Async correctness7.6 / 10Strong✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. — REDACTED:241
  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:817

What to do

  • Sync-over-async (deadlock risk) through `.Result`
X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness5.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `_cts` is a `CancellationTokenSource` this type creates itself, and here (line 149) a new instance is written over it — but `LaunchAsync` (line 139) calls `LaunchWithStrategy` with nothing releasing `_cts` first, while `LaunchAsync` (line 140) releases it before its own call — so the type's own code expects an instance to be there, and nothing earlier in `LaunchWithStrategy` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_cts?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back. — REDACTED:149
  • `BZip2OutputStream` declares a finalizer (line 164), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:164
  • `downloadQueue` is a `DownloadQueueManager`, which implements `IDisposable`, and it is created here (line 23). Every use of it in `RunExample` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var downloadQueue = …;`), which releases it at the end of the scope on every path including a throw. — src/GeneralUpdate.Extension/Examples/DownloadQueueExample.cs:23

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X2 · Cancellation propagation7.3 / 10Strong✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 86/154 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×36) — REDACTED:125, REDACTED:147, REDACTED:457, …
  • No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. — src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs:71
  • Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one. (×2) — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:574, src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:592

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard4.6 / 10Weak✓ Tool-verified

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.

  • The guard on line 248 rejects `filePath` and line 249 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(filePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `filePath`, and on that path `filePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — REDACTED:249
  • The guard on line 613 rejects `sourcePath` and line 613 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(sourcePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `sourcePath`, and on that path `sourcePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:613
  • The guard on line 614 rejects `targetPath` and line 614 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(targetPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `targetPath`, and on that path `targetPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:614
  • The guard on line 615 rejects `patchPath` and line 615 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:615
  • The guard on line 465 rejects `oldfilePath` and line 466 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(oldfilePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `oldfilePath`, and on that path `oldfilePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:466
  • The guard on line 467 rejects `newfilePath` and line 468 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(newfilePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `newfilePath`, and on that path `newfilePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:468
  • The guard on line 469 rejects `patchPath` and line 470 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:470
  • The guard on line 431 rejects `oldPath` and line 431 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(oldPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `oldPath`, and on that path `oldPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:431
  • The guard on line 432 rejects `newPath` and line 432 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(newPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `newPath`, and on that path `newPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:432
  • The guard on line 433 rejects `patchPath` and line 433 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition. — src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:433

What to do

  • Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.9 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×4) — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:123, src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:142, src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:126, …
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else). (×4) — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:158, src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:181, src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:161, …
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×10) — src/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs:329, src/GeneralUpdate.Core/FileSystem/StorageManager.cs:266, src/GeneralUpdate.Core/Ipc/IpcEncryption.cs:74, …

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X5 · Nullable reference types9.7 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • ~0.4 `!` suppressions per 1k syntax nodes — 39 suppression(s) across the 106234 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health72.6StrongSolid.
Architecture81.5StrongSolid.
Maturity67.1Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness47.2Weak — gated by P3, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security70.7Adequate — gated by D29, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance85.0StrongStrongest area.
Unscored — 5 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • P12 CI test-gate honesty — 2 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • X10 Duplicated predicate — 10 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X6 Hand-rolled structured-format parsing — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 13 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X9 Subsumed condition operand — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 47 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
  • C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • D11 Test Reliability — Test reliability not included
  • D12 Dependency Hygiene — Dependency hygiene not measured
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
  • D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
  • D25 ADR Conformance — no ADRs to check
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 17 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 value object(s))
  • ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (a message-bus package)
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P2 Observability — This repo is a library, not a deployed service — it has no process to operate, so production observability (structured logging, tracing/metrics, health checks) is N/A. A library may log via an injected ILogger, but the absence of operational telemetry is not a defect here. If it grows a host (web API, worker), the dimension reactivates.
  • P8 Schema migrations — no EF Core usage detected
  • P9 Domain vs controller coverage — coverage data present for 303 file(s), but no domain-layer files were identified: no covered file's path contains any of the markers this check keys on (/domain/, /aggregates/, /valueobjects/, /domainmodel/, .domain/, /entities/), which are matched case-insensitively anywhere in the path. With no domain partition there is nothing to compare the web/controller layer against — if this repository keeps its business rules under a folder named none of those, that naming is what the check cannot see, not the domain logic.
  • PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X4 Structured logging — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 37 finding(s)
D17 · Explicit Debt · EmptyCatchBlock · ×14
  • EmptyCatchBlock src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:158 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs:329 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Core/FileSystem/StorageManager.cs:266 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Core/Ipc/IpcEncryption.cs:74 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:181 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Drivelution/Core/Execution/CommandRunner.cs:60 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Drivelution/Core/Pipeline/RetryPolicy.cs:116 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:119 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:283 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:161 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Extension/Catalog/ExtensionCatalog.cs:143 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Extension/Catalog/ExtensionCatalog.cs:214 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Extension/Examples/DependencyResolverExample.cs:202 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:161 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · WriteOnlyPrivateField · ×4
  • WriteOnlyPrivateField src/GeneralUpdate.Extension/Download/DownloadQueueManager.cs:28 — private object _lock — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/GeneralUpdate.Extension/Download/DownloadQueueManager.cs:30 — private int _maxConcurrentDownloads — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField tests/BowlTest/Integration/BowlCrashPipelineTests.cs:266 — private IReadOnlyList<string> _outputLines — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField tests/DifferentialTest/DifferentialUpgradeIntegrationTests.cs:33 — private ITestOutputHelper _output — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×2
  • REDACTED
  • REDACTED
AX3 · Project dependency cycles · Namespace dependency cycle · ×1
  • Namespace dependency cycle src/GeneralUpdate.Bowl/BowlBootstrap.cs:5 — The namespaces GeneralUpdate.Bowl ↔ GeneralUpdate.Bowl.Internal ↔ GeneralUpdate.Bowl.Strategies depend on each other. The lightest dependency in the cycle is GeneralUpdate.Bowl → GeneralUpdate.Bowl.Internal (GeneralUpdate.Bowl.BowlBootstrap → GeneralUpdate.Bowl.Internal.ICrashReporter, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 309 finding(s)
D8 · Code Coverage · Low coverage · ×45
  • Low coverage: src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:1 — 0.0% line coverage (0/85).
  • Low coverage: src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverValidator.cs src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverValidator.cs:1 — 40.9% line coverage (27/66).
  • Low coverage: src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:1 — 1.9% line coverage (4/213).
  • Low coverage: src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsPermissionHelper.cs src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsPermissionHelper.cs:1 — 0.0% line coverage (0/69).
  • Low coverage: src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsSignatureHelper.cs src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsSignatureHelper.cs:1 — 10.5% line coverage (6/57).
  • Low coverage: src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:1 — 13.3% line coverage (42/315).
  • Low coverage: src/GeneralUpdate.Drivelution/MacOS/Helpers/MacOSPermissionHelper.cs src/GeneralUpdate.Drivelution/MacOS/Helpers/MacOSPermissionHelper.cs:1 — 0.0% line coverage (0/14).
  • Low coverage: src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:1 — 28.9% line coverage (22/76).
  • Low coverage: src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:1 — 38.2% line coverage (97/254).
  • Low coverage: src/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs src/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs:1 — 27.9% line coverage (24/86).
  • Low coverage: REDACTED REDACTED:1 — 0.0% line coverage (0/78).
  • Low coverage: src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs:1 — 46.4% line coverage (32/69).
  • Low coverage: src/GeneralUpdate.Drivelution/Core/Utilities/RestartHelper.cs src/GeneralUpdate.Drivelution/Core/Utilities/RestartHelper.cs:1 — 16.3% line coverage (15/92).
  • Low coverage: REDACTED REDACTED:1 — 17.6% line coverage (52/295).
  • Low coverage: src/GeneralUpdate.Core/GracefulExit.cs src/GeneralUpdate.Core/GracefulExit.cs:1 — 11.5% line coverage (3/26).
  • Low coverage: src/GeneralUpdate.Core/Tracer/WindowsOutputDebugListener.cs src/GeneralUpdate.Core/Tracer/WindowsOutputDebugListener.cs:1 — 0.0% line coverage (0/9).
  • Low coverage: src/GeneralUpdate.Core/Utilities/Semver.cs src/GeneralUpdate.Core/Utilities/Semver.cs:1 — 35.3% line coverage (72/204).
  • Low coverage: src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:1 — 41.4% line coverage (94/227).
  • Low coverage: src/GeneralUpdate.Core/Strategy/LinuxStrategy.cs src/GeneralUpdate.Core/Strategy/LinuxStrategy.cs:1 — 0.0% line coverage (0/43).
  • Low coverage: src/GeneralUpdate.Core/Strategy/MacStrategy.cs src/GeneralUpdate.Core/Strategy/MacStrategy.cs:1 — 0.0% line coverage (0/43).
  • Low coverage: src/GeneralUpdate.Core/Strategy/OssStrategy.cs src/GeneralUpdate.Core/Strategy/OssStrategy.cs:1 — 16.0% line coverage (47/293).
  • Low coverage: src/GeneralUpdate.Core/Strategy/OsStrategyResolver.cs src/GeneralUpdate.Core/Strategy/OsStrategyResolver.cs:1 — 35.0% line coverage (7/20).
  • Low coverage: src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:1 — 10.0% line coverage (15/150).
  • Low coverage: src/GeneralUpdate.Core/Strategy/WindowsStrategy.cs src/GeneralUpdate.Core/Strategy/WindowsStrategy.cs:1 — 0.0% line coverage (0/52).
  • Low coverage: src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs:1 — 17.0% line coverage (16/94).
  • + 20 more in this group — see findings.md.
X2 · Cancellation propagation · Async method without CancellationToken · ×36
  • Async method without CancellationToken: LaunchAsync REDACTED:125 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: LaunchWithStrategy REDACTED:147 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: LaunchSilentAsync REDACTED:457 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: BackupAsync src/GeneralUpdate.Core/FileSystem/StorageManager.cs:602 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RestoreAsync src/GeneralUpdate.Core/FileSystem/StorageManager.cs:616 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CleanBackupAsync src/GeneralUpdate.Core/FileSystem/StorageManager.cs:630 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ShutdownAsync src/GeneralUpdate.Core/GracefulExit.cs:26 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: OnBeforeStartAppAsync src/GeneralUpdate.Core/Hooks/IUpdateHooks.cs:48 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: OnBeforeStartAppAsync src/GeneralUpdate.Core/Hooks/IUpdateHooks.cs:96 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartAsync src/GeneralUpdate.Core/Hubs/UpgradeHubService.cs:62 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StopAsync src/GeneralUpdate.Core/Hubs/UpgradeHubService.cs:74 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: InvokeAsync src/GeneralUpdate.Core/Pipeline/CompressMiddleware.cs:57 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CopyUnknownFiles src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:513 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: InvokeAsync src/GeneralUpdate.Core/Pipeline/HashMiddleware.cs:56 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: VerifyFileHash src/GeneralUpdate.Core/Pipeline/HashMiddleware.cs:97 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: InvokeAsync src/GeneralUpdate.Core/Pipeline/PatchMiddleware.cs:61 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Build src/GeneralUpdate.Core/Pipeline/PipelineBuilder.cs:117 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteAsync src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:149 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:257 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteWorkflowAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:342 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteStandardWorkflowAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ApplyUpgradePackagesAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:726 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CallSmallBowlHomeAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:988 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SafeOnBeforeStartAppAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1050 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SafeReportUpdateStartedAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1119 — No CancellationToken parameter — this work can't be stopped early once started.
  • + 11 more in this group — see findings.md.
D10 · Test Quality · No assertions · ×20
  • No assertions: Configinfo_Validate_WithAllFields_Passes tests/CoreTest/Bootstrap/ParameterMatrixAndEventTests.cs:164 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: Configinfo_Validate_VariousAuthSchemes_Passes tests/CoreTest/Bootstrap/ParameterMatrixAndEventTests.cs:226 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: SetFiles_ValidList_Stored tests/CoreTest/Configuration/UpdateRequestBuilderTests.cs:155 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerReceive_WithValidCallback_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:61 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerReceive_MultipleCallbacks_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:70 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerOnline_WithValidCallback_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:82 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerOnline_MultipleCallbacks_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:90 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerReconnected_WithValidCallback_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:102 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerReconnected_WithNullCallback_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:109 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: AddListenerClosed_WithValidCallback_DoesNotThrow tests/CoreTest/Hubs/UpgradeHubServiceTests.cs:120 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: Build_EmptyStack_DoesNothing tests/CoreTest/Pipeline/PipelineBuilderTests.cs:23 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: Build_SingleMiddleware_Invoked tests/CoreTest/Pipeline/PipelineBuilderTests.cs:30 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: RemoveInstalledExtension_不存在扩展_不抛异常 tests/ExtensionTest/Catalog/ExtensionCatalogTests.cs:315 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: RemoveInstalledExtension_重复移除不抛异常 tests/ExtensionTest/Catalog/ExtensionCatalogTests.cs:323 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: OnBeforeActivateAsync_默认不抛异常 tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:38 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: OnAfterActivateAsync_默认不抛异常 tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:44 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: OnBeforeDeactivateAsync_默认不抛异常 tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:50 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: OnAfterDeactivateAsync_默认不抛异常 tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:56 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: OnAfterUninstallAsync_默认不抛异常 tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:69 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: 所有方法均可接收CancellationToken tests/ExtensionTest/Core/DefaultExtensionLifecycleHooksTests.cs:75 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
X3 · Exception handling · Swallowed exception (empty catch) · ×14
  • Swallowed exception (empty catch) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:158 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs:329 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Core/FileSystem/StorageManager.cs:266 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Core/Ipc/IpcEncryption.cs:74 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:181 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/GeneralUpdate.Drivelution/Core/Execution/CommandRunner.cs:60 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Drivelution/Core/Pipeline/RetryPolicy.cs:116 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:119 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:283 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:161 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/GeneralUpdate.Extension/Catalog/ExtensionCatalog.cs:143 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Extension/Catalog/ExtensionCatalog.cs:214 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Extension/Examples/DependencyResolverExample.cs:202 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:161 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
X20 · Mistyped argument guard · Argument guard throws the exception its own condition disproves · ×10
  • Argument guard throws the exception its own condition disproves REDACTED:249 — The guard on line 248 rejects `filePath` and line 249 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(filePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `filePath`, and on that path `filePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:613 — The guard on line 613 rejects `sourcePath` and line 613 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(sourcePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `sourcePath`, and on that path `sourcePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:614 — The guard on line 614 rejects `targetPath` and line 614 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(targetPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `targetPath`, and on that path `targetPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:615 — The guard on line 615 rejects `patchPath` and line 615 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:466 — The guard on line 465 rejects `oldfilePath` and line 466 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(oldfilePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `oldfilePath`, and on that path `oldfilePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:468 — The guard on line 467 rejects `newfilePath` and line 468 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(newfilePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `newfilePath`, and on that path `newfilePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:470 — The guard on line 469 rejects `patchPath` and line 470 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:431 — The guard on line 431 rejects `oldPath` and line 431 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(oldPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `oldPath`, and on that path `oldPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:432 — The guard on line 432 rejects `newPath` and line 432 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(newPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `newPath`, and on that path `newPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:433 — The guard on line 433 rejects `patchPath` and line 433 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(patchPath)` is true of a value that is NOT null: it is satisfied by an EMPTY `patchPath`, and on that path `patchPath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows this case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` (or `ArgumentOutOfRangeException` for a bound) for what the condition actually tests, or split the guard and throw each on its own condition.
D3 · God Classes · MethodTooLong · ×4
  • MethodTooLong: ClientStrategy.ExecuteStandardWorkflowAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396 — MethodTooLong — ExecuteStandardWorkflowAsync runs 188 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 88 over it, 1.88× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BZip2OutputStream.SendMTFValues src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:472 — MethodTooLong — SendMTFValues runs 179 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 79 over it, 1.79× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BsdiffDiffer.Clean src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:83 — MethodTooLong — Clean runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BaseDriverUpdater.UpdateAsync src/GeneralUpdate.Drivelution/Core/Pipeline/BaseDriverUpdater.cs:49 — MethodTooLong — UpdateAsync runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×4
  • Duplicated block (17 lines × 3) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:17 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:17-33 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:17-33 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:17-33 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 115 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (17 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:45 — src/GeneralUpdate.Core/Utilities/Semver.cs:45-61 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:45-61 | src/GeneralUpdate.Extension/Utilities/Semver.cs:45-61 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (17 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:70 — src/GeneralUpdate.Core/Utilities/Semver.cs:70-86 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:70-86 | src/GeneralUpdate.Extension/Utilities/Semver.cs:70-86 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (17 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:152 — src/GeneralUpdate.Core/Utilities/Semver.cs:152-168 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:152-168 | src/GeneralUpdate.Extension/Utilities/Semver.cs:152-168 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×4
  • Swallowed exception (caught, then discarded) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:123 — `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
  • Swallowed exception (caught, then discarded) src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:142 — `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
  • Swallowed exception (caught, then discarded) src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:126 — `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
  • Swallowed exception (caught, then discarded) src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:126 — `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
D2 · Cognitive Complexity · Semver.Normalize (cognitive 17) · ×3
  • Semver.Normalize (cognitive 17) src/GeneralUpdate.Core/Utilities/Semver.cs:104 — Semver.Normalize has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
  • Semver.Normalize (cognitive 17) src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:104 — Semver.Normalize has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
  • Semver.Normalize (cognitive 17) src/GeneralUpdate.Extension/Utilities/Semver.cs:104 — Semver.Normalize has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D3 · God Classes · TooManyMethods · ×3
  • TooManyMethods: BZip2OutputStream src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs — TooManyMethods — 967 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ClientStrategy src/GeneralUpdate.Core/Strategy/ClientStrategy.cs — TooManyMethods — 418 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BZip2InputStream src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs — TooManyMethods — 480 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:36 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:36-58 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:50-77 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:36-61 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:36-61 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:104 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:104-129 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:123-148 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:107-132 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:107-132 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:24 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:24-59 | src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:66-99 | src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:24-65 | src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:72-113 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
AX2 · Stateful singletons · Stateful singleton · ×2
  • Stateful singleton: DownloadQueueManager src/GeneralUpdate.Extension/Download/DownloadQueueManager.cs:24 — `DownloadQueueManager` is a singleton (one shared instance) but mutates instance state outside any lock (_isProcessing; e.g. `_isProcessing` at line 99).
  • Stateful singleton: GeneralExtensionHost src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:27 — `GeneralExtensionHost` is a singleton (one shared instance) but mutates instance state outside any lock (_autoUpdateSettings, _globalAutoUpdate; e.g. `_autoUpdateSettings` at line 526).
AX2 · Stateful singletons · Process-global static state · ×2
  • Process-global static state: GeneralTracer src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:8 — `GeneralTracer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_fileListener, _currentLogDate; e.g. `_fileListener` at line 54). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: HttpClientProvider src/GeneralUpdate.Core/Network/HttpClientProvider.cs:31 — `HttpClientProvider` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_sslPolicy, _defaultAuthProvider; e.g. `_sslPolicy` at line 80). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
D4 · Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/GeneralUpdate.Core/Utilities/Semver.cs:190 — src/GeneralUpdate.Core/Utilities/Semver.cs:190-202 | src/GeneralUpdate.Core/Utilities/Semver.cs:324-336 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:190-202 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:320-332 | src/GeneralUpdate.Extension/Utilities/Semver.cs:190-202 | src/GeneralUpdate.Extension/Utilities/Semver.cs:321-333 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/GeneralUpdate.Core/Utilities/Semver.cs:205 — src/GeneralUpdate.Core/Utilities/Semver.cs:205-213 | src/GeneralUpdate.Core/Utilities/Semver.cs:339-347 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:205-213 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:335-343 | src/GeneralUpdate.Extension/Utilities/Semver.cs:205-213 | src/GeneralUpdate.Extension/Utilities/Semver.cs:336-344 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×2
  • Edited copy of a member (10 corresponding lines) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1100 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1100-1113 | src/GeneralUpdate.Core/Strategy/OssStrategy.cs:622-631 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/GeneralUpdate.Bowl/FileSystem/StorageHelper.cs:52 — src/GeneralUpdate.Bowl/FileSystem/StorageHelper.cs:52-61 | src/GeneralUpdate.Core/FileSystem/StorageManager.cs:157-171 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×2
  • Edited copy of a member (18 corresponding lines) src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs:68 — src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs:68-85 | src/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs:93-110 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/GeneralUpdate.Drivelution/Core/Utilities/RestartHelper.cs:99 — src/GeneralUpdate.Drivelution/Core/Utilities/RestartHelper.cs:99-116 | src/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs:62-89 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×2
  • Edited copy of a member (12 corresponding lines) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1120 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1120-1131 | src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1138-1149 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:233 — src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:233-244 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:253-264 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×2
  • Edited copy of a member (9 corresponding lines) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:234 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:234-242 | src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:80-88 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1016 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1016-1024 | src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:218-226 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×2
  • Duplicated block (13 lines × 3) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:496 — src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:496-513 | src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:550-562 | src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:609-621 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (13 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:136 — src/GeneralUpdate.Core/Utilities/Semver.cs:136-148 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:136-148 | src/GeneralUpdate.Extension/Utilities/Semver.cs:136-148 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×2
  • Duplicated block (12–13 lines × 2) src/GeneralUpdate.Core/Utilities/Semver.cs:263 — src/GeneralUpdate.Core/Utilities/Semver.cs:263-275 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:263-274 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12–13 lines × 2) src/GeneralUpdate.Core/Utilities/Semver.cs:263 — src/GeneralUpdate.Core/Utilities/Semver.cs:263-275 | src/GeneralUpdate.Extension/Utilities/Semver.cs:263-274 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Extension/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×2
  • Duplicated block (7 lines × 2) src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:528 — src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:528-534 | src/GeneralUpdate.Core/Pipeline/DiffPipeline.cs:585-591 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) src/GeneralUpdate.Extension/Examples/VersionCompatibilityExample.cs:85 — src/GeneralUpdate.Extension/Examples/VersionCompatibilityExample.cs:85-91 | src/GeneralUpdate.Extension/Examples/VersionCompatibilityExample.cs:123-129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Extension/Examples/VersionCompatibilityExample.cs:85` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×2
  • Duplicated block (6 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:265 — src/GeneralUpdate.Core/Utilities/Semver.cs:265-270 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:264-269 | src/GeneralUpdate.Extension/Utilities/Semver.cs:264-269 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:243 — src/GeneralUpdate.Core/Utilities/Semver.cs:243-248 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:243-248 | src/GeneralUpdate.Extension/Utilities/Semver.cs:243-248 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
PF3 · Async & latency hygiene · Sync-over-async blocking · ×2
  • Sync-over-async blocking — 1 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:817 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
X2 · Cancellation propagation · Async local function without CancellationToken · ×2
  • Async local function without CancellationToken: ExecuteDownloadAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:574 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
  • Async local function without CancellationToken: DownloadAndApplyAsync src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:592 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
AX2 · Stateful singletons · Stateful shared instance · ×1
  • Stateful shared instance: ExtensionMetadata src/GeneralUpdate.Extension/Common/Models/ExtensionMetadata.cs:15 — `ExtensionMetadata` is not registered, but `DependencyResolverExample` creates it and hands it to the singleton `ExtensionCatalog`, which keeps it in `_installedExtensions`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_dependencyList; e.g. `_dependencyList` at line 113).
D1 · Cyclomatic Complexity · BZip2OutputStream.SendMTFValues (cyclomatic 67) · ×1
  • BZip2OutputStream.SendMTFValues (cyclomatic 67) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:472 — BZip2OutputStream.SendMTFValues has cyclomatic complexity 67 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · BZip2OutputStream.MainSort (cyclomatic 32) · ×1
  • BZip2OutputStream.MainSort (cyclomatic 32) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1040 — BZip2OutputStream.MainSort has cyclomatic complexity 32 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · BsdiffDiffer.Clean (cyclomatic 29) · ×1
  • BsdiffDiffer.Clean (cyclomatic 29) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:83 — BsdiffDiffer.Clean has cyclomatic complexity 29 (threshold 15). Most of this is not in the body itself: 1 of the 29 points is its own statement and the rest belongs to one function literal inside it that branches (line 85). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · UpdateRequestBuilder.LoadFromConfigFile (cyclomatic 27) · ×1
  • UpdateRequestBuilder.LoadFromConfigFile (cyclomatic 27) src/GeneralUpdate.Core/Configuration/UpdateRequestBuilder.cs:130 — UpdateRequestBuilder.LoadFromConfigFile has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BZip2InputStream.GetAndMoveToFrontDecode (cyclomatic 26) · ×1
  • BZip2InputStream.GetAndMoveToFrontDecode (cyclomatic 26) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:467 — BZip2InputStream.GetAndMoveToFrontDecode has cyclomatic complexity 26 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · BZip2OutputStream.HbMakeCodeLengths (cyclomatic 26) · ×1
  • BZip2OutputStream.HbMakeCodeLengths (cyclomatic 26) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1544 — BZip2OutputStream.HbMakeCodeLengths has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · BsdiffDiffer.Dirty (cyclomatic 26) · ×1
  • BsdiffDiffer.Dirty (cyclomatic 26) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:266 — BsdiffDiffer.Dirty has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 1 of the 26 points is its own statement and the rest belongs to one function literal inside it that branches (line 268). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · ClientStrategy.ExecuteStandardWorkflowAsync (cyclomatic 24) · ×1
  • ClientStrategy.ExecuteStandardWorkflowAsync (cyclomatic 24) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396 — ClientStrategy.ExecuteStandardWorkflowAsync has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ZipCompressionStrategy.Compress (cyclomatic 21) · ×1
  • ZipCompressionStrategy.Compress (cyclomatic 21) src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:20 — ZipCompressionStrategy.Compress has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DownloadPlanBuilder.Build (cyclomatic 21) · ×1
  • DownloadPlanBuilder.Build (cyclomatic 21) src/GeneralUpdate.Core/Download/DownloadPlanBuilder.cs:119 — DownloadPlanBuilder.Build has cyclomatic complexity 21 (threshold 15). Of this number, 11 points are the body's own statements and 10 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HttpAuthProviderFactory.Create (cyclomatic 21) · ×1
  • HttpAuthProviderFactory.Create (cyclomatic 21) src/GeneralUpdate.Core/Security/IHttpAuthProvider.cs:345 — HttpAuthProviderFactory.Create has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GeneralExtensionHost.InstallExtensionAsync (cyclomatic 21) · ×1
  • GeneralExtensionHost.InstallExtensionAsync (cyclomatic 21) src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:326 — GeneralExtensionHost.InstallExtensionAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AbstractStrategy.ExecuteAsync (cyclomatic 20) · ×1
  • AbstractStrategy.ExecuteAsync (cyclomatic 20) src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:149 — AbstractStrategy.ExecuteAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · BsdiffDiffer.Split (cyclomatic 20) · ×1
  • BsdiffDiffer.Split (cyclomatic 20) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:525 — BsdiffDiffer.Split has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExtensionExample.RunExample (cyclomatic 19) · ×1
  • ExtensionExample.RunExample (cyclomatic 19) src/GeneralUpdate.Extension/Examples/ExtensionExample.cs:19 — ExtensionExample.RunExample has cyclomatic complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BZip2InputStream.RecvDecodingTables (cyclomatic 18) · ×1
  • BZip2InputStream.RecvDecodingTables (cyclomatic 18) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:371 — BZip2InputStream.RecvDecodingTables has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · BZip2OutputStream.QSort3 (cyclomatic 18) · ×1
  • BZip2OutputStream.QSort3 (cyclomatic 18) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:918 — BZip2OutputStream.QSort3 has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · BZip2OutputStream.FullGtU (cyclomatic 18) · ×1
  • BZip2OutputStream.FullGtU (cyclomatic 18) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1274 — BZip2OutputStream.FullGtU has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · ExtensionHostBuilder.Build (cyclomatic 17) · ×1
  • ExtensionHostBuilder.Build (cyclomatic 17) src/GeneralUpdate.Extension/Core/ExtensionHostBuilder.cs:84 — ExtensionHostBuilder.Build has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ExtensionCatalogExample.RunExample (cyclomatic 17) · ×1
  • ExtensionCatalogExample.RunExample (cyclomatic 17) src/GeneralUpdate.Extension/Examples/ExtensionCatalogExample.cs:19 — ExtensionCatalogExample.RunExample has cyclomatic complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FileTree.DelNode (cyclomatic 16) · ×1
  • FileTree.DelNode (cyclomatic 16) src/GeneralUpdate.Core/FileSystem/FileTree.cs:123 — FileTree.DelNode has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OssStrategy.ExecuteClientAsync (cyclomatic 16) · ×1
  • OssStrategy.ExecuteClientAsync (cyclomatic 16) src/GeneralUpdate.Core/Strategy/OssStrategy.cs:190 — OssStrategy.ExecuteClientAsync has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BZip2OutputStream.GenerateMTFValues (cyclomatic 16) · ×1
  • BZip2OutputStream.GenerateMTFValues (cyclomatic 16) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1431 — BZip2OutputStream.GenerateMTFValues has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table. This file is where this pass's cyclomatic complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 6 of the 25 methods over the threshold — including the worst — and 87 of the 193 points over it (45%), 2.8× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 31). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D1 · Cyclomatic Complexity · BsdiffDiffer.SuffixSort (cyclomatic 16) · ×1
  • BsdiffDiffer.SuffixSort (cyclomatic 16) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:620 — BsdiffDiffer.SuffixSort has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StreamingHdiffDiffer.ComputeDiff (cyclomatic 16) · ×1
  • StreamingHdiffDiffer.ComputeDiff (cyclomatic 16) src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:221 — StreamingHdiffDiffer.ComputeDiff has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D10 · Test Quality · Test cannot fail · ×1
  • Test cannot fail: DecryptFromFile_FileDeleteFails_DoesNotThrow tests/CoreTest/Ipc/IpcEncryptionTests.cs:59 — This test's act runs inside `catch` at line 70 of this file, which catches every exception and neither rethrows nor verifies — so the method passes whether or not the behaviour it names actually happens. The 2 assertion(s) this test does make are inside that region, and an xUnit/NUnit assertion reports by THROWING — so they are caught and discarded too, which is why nothing else here flags this test. Assert the outcome instead of catching it: `Assert.Throws<T>(() => …)` (or the framework equivalent) when a throw is the expected result, or narrow the catch to the one exception type and assert on it. A catch-all that only logs belongs in production code, not between a test and its verdict.
D15 · Churn × Complexity Hotspots · Hotspot · ×1
  • Hotspot: src/GeneralUpdate.Core/Strategy/ClientStrategy.cs src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in ClientStrategy.ExecuteStandardWorkflowAsync at line 396. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-21..2026-09-19, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-21 23:40:00 +08:00' --until='2026-09-19 23:40:00 +08:00' --full-history --no-merges -- src/GeneralUpdate.Core/Strategy/ClientStrategy.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D17 · Explicit Debt · BarePragmaDisable · ×1
  • BarePragmaDisable src/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs:90 — #pragma warning disable CA5351 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
D17 · Explicit Debt · ObsoleteWithCallers · ×1
  • ObsoleteWithCallers src/GeneralUpdate.Drivelution/Core/Utilities/VersionComparer.cs:9 — [Obsolete] VersionComparer
D2 · Cognitive Complexity · BZip2OutputStream.SendMTFValues (cognitive 135) · ×1
  • BZip2OutputStream.SendMTFValues (cognitive 135) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:472 — BZip2OutputStream.SendMTFValues has cognitive complexity 135 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · BsdiffDiffer.Clean (cognitive 81) · ×1
  • BsdiffDiffer.Clean (cognitive 81) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:83 — BsdiffDiffer.Clean has cognitive complexity 81 (threshold 15). None of this is in the body itself: all 81 points belong to one function literal inside it that branches (line 85). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · BZip2OutputStream.MainSort (cognitive 64) · ×1
  • BZip2OutputStream.MainSort (cognitive 64) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1040 — BZip2OutputStream.MainSort has cognitive complexity 64 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · BZip2OutputStream.HbMakeCodeLengths (cognitive 60) · ×1
  • BZip2OutputStream.HbMakeCodeLengths (cognitive 60) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1544 — BZip2OutputStream.HbMakeCodeLengths has cognitive complexity 60 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · BZip2InputStream.GetAndMoveToFrontDecode (cognitive 52) · ×1
  • BZip2InputStream.GetAndMoveToFrontDecode (cognitive 52) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:467 — BZip2InputStream.GetAndMoveToFrontDecode has cognitive complexity 52 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ZipCompressionStrategy.Compress (cognitive 49) · ×1
  • ZipCompressionStrategy.Compress (cognitive 49) src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:20 — ZipCompressionStrategy.Compress has cognitive complexity 49 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · BZip2OutputStream.QSort3 (cognitive 45) · ×1
  • BZip2OutputStream.QSort3 (cognitive 45) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:918 — BZip2OutputStream.QSort3 has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · StreamingHdiffDiffer.ComputeDiff (cognitive 44) · ×1
  • StreamingHdiffDiffer.ComputeDiff (cognitive 44) src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:221 — StreamingHdiffDiffer.ComputeDiff has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BsdiffDiffer.Split (cognitive 38) · ×1
  • BsdiffDiffer.Split (cognitive 38) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:525 — BsdiffDiffer.Split has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BZip2OutputStream.SimpleSort (cognitive 36) · ×1
  • BZip2OutputStream.SimpleSort (cognitive 36) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:825 — BZip2OutputStream.SimpleSort has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · BsdiffDiffer.Dirty (cognitive 35) · ×1
  • BsdiffDiffer.Dirty (cognitive 35) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:266 — BsdiffDiffer.Dirty has cognitive complexity 35 (threshold 15). None of this is in the body itself: all 35 points belong to one function literal inside it that branches (line 268). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · FileTree.DelNode (cognitive 33) · ×1
  • FileTree.DelNode (cognitive 33) src/GeneralUpdate.Core/FileSystem/FileTree.cs:123 — FileTree.DelNode has cognitive complexity 33 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · BZip2InputStream.RecvDecodingTables (cognitive 32) · ×1
  • BZip2InputStream.RecvDecodingTables (cognitive 32) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:371 — BZip2InputStream.RecvDecodingTables has cognitive complexity 32 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · BZip2OutputStream.GenerateMTFValues (cognitive 29) · ×1
  • BZip2OutputStream.GenerateMTFValues (cognitive 29) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1431 — BZip2OutputStream.GenerateMTFValues has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · GeneralExtensionHost.InstallExtensionAsync (cognitive 28) · ×1
  • GeneralExtensionHost.InstallExtensionAsync (cognitive 28) src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:326 — GeneralExtensionHost.InstallExtensionAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExtensionExample.RunExample (cognitive 28) · ×1
  • ExtensionExample.RunExample (cognitive 28) src/GeneralUpdate.Extension/Examples/ExtensionExample.cs:19 — ExtensionExample.RunExample has cognitive complexity 28 (threshold 15). Of this number, 26 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BZip2OutputStream.FullGtU (cognitive 27) · ×1
  • BZip2OutputStream.FullGtU (cognitive 27) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1274 — BZip2OutputStream.FullGtU has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs holds 7 of the 37 methods over the threshold — including the worst — and 291 of the 660 points over it (44%), 2.4× the next-largest file (src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · UpdateRequestBuilder.LoadFromConfigFile (cognitive 26) · ×1
  • UpdateRequestBuilder.LoadFromConfigFile (cognitive 26) src/GeneralUpdate.Core/Configuration/UpdateRequestBuilder.cs:130 — UpdateRequestBuilder.LoadFromConfigFile has cognitive complexity 26 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · AbstractStrategy.ExecuteAsync (cognitive 26) · ×1
  • AbstractStrategy.ExecuteAsync (cognitive 26) src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:149 — AbstractStrategy.ExecuteAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WindowsGeneralDrivelution.ParseInfFileAsync (cognitive 26) · ×1
  • WindowsGeneralDrivelution.ParseInfFileAsync (cognitive 26) src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:326 — WindowsGeneralDrivelution.ParseInfFileAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BsdiffDiffer.SuffixSort (cognitive 24) · ×1
  • BsdiffDiffer.SuffixSort (cognitive 24) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:620 — BsdiffDiffer.SuffixSort has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExtensionHostBuilder.Build (cognitive 24) · ×1
  • ExtensionHostBuilder.Build (cognitive 24) src/GeneralUpdate.Extension/Core/ExtensionHostBuilder.cs:84 — ExtensionHostBuilder.Build has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · DownloadPlanBuilder.Build (cognitive 23) · ×1
  • DownloadPlanBuilder.Build (cognitive 23) src/GeneralUpdate.Core/Download/DownloadPlanBuilder.cs:119 — DownloadPlanBuilder.Build has cognitive complexity 23 (threshold 15). Of this number, 12 points are the body's own statements and 11 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientStrategy.ExecuteStandardWorkflowAsync (cognitive 23) · ×1
  • ClientStrategy.ExecuteStandardWorkflowAsync (cognitive 23) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:396 — ClientStrategy.ExecuteStandardWorkflowAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · HttpAuthProviderFactory.Create (cognitive 20) · ×1
  • HttpAuthProviderFactory.Create (cognitive 20) src/GeneralUpdate.Core/Security/IHttpAuthProvider.cs:345 — HttpAuthProviderFactory.Create has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExtensionCatalogExample.RunExample (cognitive 20) · ×1
  • ExtensionCatalogExample.RunExample (cognitive 20) src/GeneralUpdate.Extension/Examples/ExtensionCatalogExample.cs:19 — ExtensionCatalogExample.RunExample has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · StorageManager.DeleteDirectory (cognitive 18) · ×1
  • StorageManager.DeleteDirectory (cognitive 18) src/GeneralUpdate.Core/FileSystem/StorageManager.cs:345 — StorageManager.DeleteDirectory has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · BaseDriverUpdater.UpdateAsync (cognitive 18) · ×1
  • BaseDriverUpdater.UpdateAsync (cognitive 18) src/GeneralUpdate.Drivelution/Core/Pipeline/BaseDriverUpdater.cs:49 — BaseDriverUpdater.UpdateAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GeneralExtensionHost.UpdateExtensionAsync (cognitive 18) · ×1
  • GeneralExtensionHost.UpdateExtensionAsync (cognitive 18) src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:181 — GeneralExtensionHost.UpdateExtensionAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BowlBootstrap.HandleCrashAsync (cognitive 17) · ×1
  • BowlBootstrap.HandleCrashAsync (cognitive 17) src/GeneralUpdate.Bowl/BowlBootstrap.cs:113 — BowlBootstrap.HandleCrashAsync has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · OssStrategy.ExecuteClientAsync (cognitive 17) · ×1
  • OssStrategy.ExecuteClientAsync (cognitive 17) src/GeneralUpdate.Core/Strategy/OssStrategy.cs:190 — OssStrategy.ExecuteClientAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · GeneralUpdateBootstrap.ConfigureStrategy (cognitive 16) · ×1
  • GeneralUpdateBootstrap.ConfigureStrategy (cognitive 16) REDACTED:498 — GeneralUpdateBootstrap.ConfigureStrategy has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ZipCompressionStrategy.Decompress (cognitive 16) · ×1
  • ZipCompressionStrategy.Decompress (cognitive 16) src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:121 — ZipCompressionStrategy.Decompress has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BsdiffDiffer.Search (cognitive 16) · ×1
  • BsdiffDiffer.Search (cognitive 16) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:493 — BsdiffDiffer.Search has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · FileTooLong · ×1
  • FileTooLong: Binary/BZip2OutputStream.cs src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs — FileTooLong — 974 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 474 over it, 1.95× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D3 · God Classes · ClassTooLong · ×1
  • ClassTooLong: BsdiffDiffer src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs — ClassTooLong — 402 significant lines (blank, comment-only and punctuation-only lines excluded), 17 methods. The bar is 400 significant lines; this is 2 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D30 · Dependency Vulnerabilities · Medium CVE · ×1
  • REDACTED
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: REDACTED ↔ DefaultDownloadOrchestrator.cs REDACTED:1 — `REDACTED` and `src/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `9f20c5dc` fix: address Copilot review comments on PR #456/#458 (at that commit the files were still `src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs` and `src/c#/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs`); `164527f5` feat: wire up unused AbstractBootstrap extension points and remove re… (at that commit the files were still `src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs` and `src/c#/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs`); `15012007` fix: address Copilot review — semaphore over-release, SetDiffer order… (at that commit the files were still `src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs` and `src/c#/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs`) — run `git show` on any of them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Edited copy of a member (54 corresponding lines) · ×1
  • Edited copy of a member (54 corresponding lines) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:153 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:153-206 | src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:146-199 — These two members are one piece of code written twice and then edited apart: 54 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 26+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 26+ corresponding lines) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:333 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:333-363 | src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:369-394 | src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:400-433 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 19+ corresponding lines) src/GeneralUpdate.Core/Utilities/Semver.cs:44 — src/GeneralUpdate.Core/Utilities/Semver.cs:44-62 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:44-62 | src/GeneralUpdate.Extension/Utilities/Semver.cs:44-62 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs:157 — src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs:157-178 | src/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs:188-210 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×1
  • Edited copy of a member (13 corresponding lines) src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:253 — src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:253-265 | src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:268-280 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 9+ corresponding lines) src/GeneralUpdate.Core/Utilities/Semver.cs:29 — src/GeneralUpdate.Core/Utilities/Semver.cs:29-37 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:29-37 | src/GeneralUpdate.Extension/Utilities/Semver.cs:29-37 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×1
  • Edited copy of a member (16 corresponding lines) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:214 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs:214-231 | src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:204-219 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×1
  • Edited copy of a member (25 corresponding lines) src/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs:21 — src/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs:21-45 | src/GeneralUpdate.Drivelution/Core/Utilities/HashValidator.cs:75-99 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×1
  • Edited copy of a member (4 corresponding lines) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1034 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:1034-1044 | src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:229-232 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 4+ corresponding lines) src/GeneralUpdate.Core/Utilities/Semver.cs:255 — src/GeneralUpdate.Core/Utilities/Semver.cs:255-258 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:255-258 | src/GeneralUpdate.Extension/Utilities/Semver.cs:255-258 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 7+ corresponding lines) src/GeneralUpdate.Bowl/Tracer/TextTraceListener.cs:17 — src/GeneralUpdate.Bowl/Tracer/TextTraceListener.cs:17-23 | src/GeneralUpdate.Core/Tracer/TextTraceListener.cs:15-21 | src/GeneralUpdate.Drivelution/Tracer/TextTraceListener.cs:17-23 | src/GeneralUpdate.Extension/Tracer/TextTraceListener.cs:17-23 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 6+ corresponding lines) src/GeneralUpdate.Core/Utilities/Semver.cs:282 — src/GeneralUpdate.Core/Utilities/Semver.cs:282-288 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:281-286 | src/GeneralUpdate.Extension/Utilities/Semver.cs:281-286 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 7+ corresponding lines) src/GeneralUpdate.Core/Utilities/Semver.cs:242 — src/GeneralUpdate.Core/Utilities/Semver.cs:242-248 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:242-248 | src/GeneralUpdate.Extension/Utilities/Semver.cs:242-248 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×1
  • Edited copy of a member (5 corresponding lines) src/GeneralUpdate.Core/Configuration/Environments.cs:30 — src/GeneralUpdate.Core/Configuration/Environments.cs:30-34 | src/GeneralUpdate.Core/Ipc/IProcessInfoProvider.cs:45-49 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (63 lines × 2) · ×1
  • Duplicated block (63 lines × 2) src/GeneralUpdate.Extension/Common/DTOs/ExtensionDTO.cs:17 — src/GeneralUpdate.Extension/Common/DTOs/ExtensionDTO.cs:17-79 | src/GeneralUpdate.Extension/Common/Models/ExtensionMetadata.cs:17-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (32 lines × 2) · ×1
  • Duplicated block (32 lines × 2) src/GeneralUpdate.Core/Configuration/UpdateContext.cs:145 — src/GeneralUpdate.Core/Configuration/UpdateContext.cs:145-176 | src/GeneralUpdate.Core/Download/Models/DownloadOrchestratorOptions.cs:17-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1468 — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1468-1494 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1504-1530 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1468` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (27 lines × 3) · ×1
  • Duplicated block (27 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:106 — src/GeneralUpdate.Core/Utilities/Semver.cs:106-132 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:106-132 | src/GeneralUpdate.Extension/Utilities/Semver.cs:106-132 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (25 lines × 4) · ×1
  • Duplicated block (25 lines × 4) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:105 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:105-129 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:124-148 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:108-132 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:108-132 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Core/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:541 — src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:541-565 | src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:600-624 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Differential/Binary/BZip2InputStream.cs:541` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1590 — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1590-1612 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1619-1641 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (22 lines × 3) · ×1
  • Duplicated block (22 lines × 3) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:37 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:37-58 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:39-60 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:39-60 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 115 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (19–21 lines × 2) · ×1
  • Duplicated block (19–21 lines × 2) src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:46 — src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:46-66 | src/GeneralUpdate.Core/Compress/ZipCompressionStrategy.cs:85-103 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (17–19 lines × 2) · ×1
  • Duplicated block (17–19 lines × 2) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:35 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:35-51 | src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:39-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:35` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:39` calls `Info` and `src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:35` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14–18 lines × 3) · ×1
  • Duplicated block (14–18 lines × 3) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:846 — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:846-863 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:865-882 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:883-896 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:865` calls `FullGtU` and `src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:883` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:172 — src/GeneralUpdate.Core/Utilities/Semver.cs:172-187 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:172-187 | src/GeneralUpdate.Extension/Utilities/Semver.cs:172-187 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1342 — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1342-1357 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1374-1389 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:397 — src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:397-411 | src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:581-595 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×1
  • Duplicated block (13 lines × 2) src/GeneralUpdate.Bowl/FileSystem/StorageHelper.cs:21 — src/GeneralUpdate.Bowl/FileSystem/StorageHelper.cs:21-33 | src/GeneralUpdate.Core/FileSystem/StorageManager.cs:577-589 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1567 — src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1567-1580 | src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1649-1662 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:1567` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (12 lines × 6) · ×1
  • Duplicated block (12 lines × 6) src/GeneralUpdate.Core/Utilities/Semver.cs:191 — src/GeneralUpdate.Core/Utilities/Semver.cs:191-202 | src/GeneralUpdate.Core/Utilities/Semver.cs:325-336 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:191-202 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:321-332 | src/GeneralUpdate.Extension/Utilities/Semver.cs:191-202 | src/GeneralUpdate.Extension/Utilities/Semver.cs:322-333 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×1
  • Duplicated block (12 lines × 4) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:45 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:45-56 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:62-73 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:47-58 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:47-58 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Core/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:45` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11–13 lines × 3) · ×1
  • Duplicated block (11–13 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:296 — src/GeneralUpdate.Core/Utilities/Semver.cs:296-308 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:294-304 | src/GeneralUpdate.Extension/Utilities/Semver.cs:294-305 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×1
  • Duplicated block (11 lines × 2) REDACTED:153 — REDACTED:153-163 | REDACTED:459-470 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×1
  • Duplicated block (16–17 lines × 2) src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:704 — src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:704-719 | src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:467-483 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (8 lines × 6) · ×1
  • Duplicated block (8 lines × 6) src/GeneralUpdate.Core/Utilities/Semver.cs:206 — src/GeneralUpdate.Core/Utilities/Semver.cs:206-213 | src/GeneralUpdate.Core/Utilities/Semver.cs:340-347 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:206-213 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:336-343 | src/GeneralUpdate.Extension/Utilities/Semver.cs:206-213 | src/GeneralUpdate.Extension/Utilities/Semver.cs:337-344 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) src/GeneralUpdate.Core/Utilities/Semver.cs:30 — src/GeneralUpdate.Core/Utilities/Semver.cs:30-37 | src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:30-37 | src/GeneralUpdate.Extension/Utilities/Semver.cs:30-37 — before extracting anything, compare `src/GeneralUpdate.Core/Utilities/Semver.cs` and `src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×1
  • Duplicated block (7 lines × 4) src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:45 — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:45-51 | src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:85-91 | src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:51-57 | src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:99-105 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (40 lines × 4) · ×1
  • Duplicated block (40 lines × 4) src/GeneralUpdate.Bowl/Tracer/TextTraceListener.cs:25 — src/GeneralUpdate.Bowl/Tracer/TextTraceListener.cs:25-64 | src/GeneralUpdate.Core/Tracer/TextTraceListener.cs:23-62 | src/GeneralUpdate.Drivelution/Tracer/TextTraceListener.cs:25-64 | src/GeneralUpdate.Extension/Tracer/TextTraceListener.cs:25-64 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/TextTraceListener.cs` and `src/GeneralUpdate.Core/Tracer/TextTraceListener.cs` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×1
  • Duplicated block (11 lines × 4) src/GeneralUpdate.Bowl/Tracer/WindowsOutputDebugListener.cs:20 — src/GeneralUpdate.Bowl/Tracer/WindowsOutputDebugListener.cs:20-30 | src/GeneralUpdate.Core/Tracer/WindowsOutputDebugListener.cs:20-30 | src/GeneralUpdate.Drivelution/Tracer/WindowsOutputDebugListener.cs:20-30 | src/GeneralUpdate.Extension/Tracer/WindowsOutputDebugListener.cs:20-30 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/WindowsOutputDebugListener.cs` and `src/GeneralUpdate.Core/Tracer/WindowsOutputDebugListener.cs` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:84 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:84-93 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:103-112 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:87-96 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:87-96 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Core/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:131 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:131-139 | src/GeneralUpdate.Core/Tracer/GeneralTracer.cs:150-158 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:134-142 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:134-142 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Core/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (20 lines × 3) · ×1
  • Duplicated block (20 lines × 3) src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:143 — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:143-162 | src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs:146-165 | src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs:146-165 — before extracting anything, compare `src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs` and `src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 115 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×1
  • Duplicated block (8 lines × 2) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:235 — src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:235-242 | src/GeneralUpdate.Core/Strategy/UpdateStrategy.cs:81-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D8 · Code Coverage · CRAP 380 · ×1
  • CRAP 380: ExtensionExample.RunExample src/GeneralUpdate.Extension/Examples/ExtensionExample.cs:19 — Cyclomatic 19 with 0.0% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 306 · ×1
  • CRAP 306: ExtensionCatalogExample.RunExample src/GeneralUpdate.Extension/Examples/ExtensionCatalogExample.cs:19 — Cyclomatic 17 with 0.0% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 199 · ×1
  • CRAP 199: WindowsGeneralDrivelution.ParseInfFileAsync src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:326 — Cyclomatic 14 with 1.9% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 168 · ×1
  • CRAP 168: OssStrategy.ExecuteClientAsync src/GeneralUpdate.Core/Strategy/OssStrategy.cs:190 — Cyclomatic 16 with 16.0% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 162 · ×1
  • CRAP 162: GeneralExtensionHost.InstallExtensionAsync src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:326 — Cyclomatic 21 with 31.6% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 132 · ×1
  • CRAP 132: PlatformMatcherExample.RunExample src/GeneralUpdate.Extension/Examples/PlatformMatcherExample.cs:17 — Cyclomatic 11 with 0.0% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 130 · ×1
  • CRAP 130: OssStrategy.ExecuteUpgradeAsync src/GeneralUpdate.Core/Strategy/OssStrategy.cs:325 — Cyclomatic 14 with 16.0% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
D8 · Code Coverage · CRAP 125 · ×1
  • CRAP 125: ExtensionHttpClient.DownloadExtensionWithResultAsync src/GeneralUpdate.Extension/Communication/ExtensionHttpClient.cs:123 — Cyclomatic 13 with 12.9% file coverage — too complex for how untested it is (CRAP = CC²·(1−cov)³ + CC; ≥30 needs tests or simplification).
GD1 · Unfinished & placeholder code · Unfinished stub · ×1
  • Unfinished stub — throws NotImplementedException src/GeneralUpdate.Core/Strategy/AbstractStrategy.cs:114 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
IC1 · Incompleteness & stubs · Both branches are identical · ×1
  • Both branches are identical — the condition decides nothing src/GeneralUpdate.Core/GracefulExit.cs:29 — The `if` and its `else` contain the same 1 statement, so no input can make the condition matter. Implement the distinction that was intended, or drop the branch and keep the body.
IC1 · Incompleteness & stubs · Fake-async · ×1
  • Fake-async — async method never awaits src/GeneralUpdate.Drivelution/Core/Pipeline/BaseDriverUpdater.cs:498 — `TryRollbackAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
IC1 · Incompleteness & stubs · Skipped test marks a known-real bug · ×1
  • Skipped test marks a known-real bug tests/DrivelutionTest/Pipeline/BaseDriverUpdaterTests.cs:89 — A test is skipped with reason "Flaky on CI — unrelated to current changes. Runs correctly in local dev." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten.
P12 · CI test-gate honesty · CI test gate excludes suites by filter · ×1
  • CI test gate excludes suites by filter REDACTED:32 — `dotnet test ./src/GeneralUpdate.slnx -c Release --no-build --filter "FullyQualifiedName!~ConfiginfoBuilderTests&FullyQualifiedName!~Clean…` filters with `FullyQualifiedName!~ConfiginfoBuilderTests&FullyQualifiedName!~CleanBackup_KeepsOnlyRecentVersions&FullyQualifiedName!~SharedMemoryProvider_RoundTrip&FullyQualifiedName!~AutoProvider_ThrowsWhenAllFail&FullyQualifiedName!~DefaultRetryPolicy_ExponentialBackoff&FullyQualifiedName!~SimulatedCrash_ProducesDumpAndReportFiles` — 1 test(s) it drops — run by no other gate before merge (e.g. BowlCrashPipelineTests.SimulatedCrash_ProducesDumpAndReportFiles). Run what it drops in another job before merge (a complementary filter), or remove the filter.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×1
  • Outbound HTTP without resilience src/GeneralUpdate.Extension/Communication/ExtensionHttpClient.cs:39 — `new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. This codebase ships libraries/tools rather than a service it operates, so the failure lands as a hung caller — a build step, a CLI run, a UI thread — with no way out.
S1 · Cryptographic Hygiene · Ciphertext is encrypted but not authenticated · ×1
  • Ciphertext is encrypted but not authenticated src/GeneralUpdate.Core/Ipc/IpcEncryption.cs:24 — This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
X1 · Async correctness · Sync-over-async (deadlock risk) through `.Result` · ×1
  • Sync-over-async (deadlock risk) through `.Result` REDACTED:241 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
X1 · Async correctness · Sync-over-async (deadlock risk) · ×1
  • Sync-over-async (deadlock risk) src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:817 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
X18 · Disposal-pattern correctness · Owned disposable field overwritten without releasing the previous instance · ×1
  • Owned disposable field overwritten without releasing the previous instance REDACTED:149 — `_cts` is a `CancellationTokenSource` this type creates itself, and here (line 149) a new instance is written over it — but `LaunchAsync` (line 139) calls `LaunchWithStrategy` with nothing releasing `_cts` first, while `LaunchAsync` (line 140) releases it before its own call — so the type's own code expects an instance to be there, and nothing earlier in `LaunchWithStrategy` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`_cts?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back.
X18 · Disposal-pattern correctness · Finalizer on a type that owns no unmanaged resource · ×1
  • Finalizer on a type that owns no unmanaged resource src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:164 — `BZip2OutputStream` declares a finalizer (line 164), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×1
  • Disposable created and abandoned in the method that made it src/GeneralUpdate.Extension/Examples/DownloadQueueExample.cs:23 — `downloadQueue` is a `DownloadQueueManager`, which implements `IDisposable`, and it is created here (line 23). Every use of it in `RunExample` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var downloadQueue = …;`), which releases it at the end of the scope on every path including a throw.
Minor — 61 finding(s)
D24 · Comment Value · redundant comment · ×19
  • redundant comment src/GeneralUpdate.Core/Download/DownloadPlanBuilder.cs:84 — "Compare: max server version > local version?" repeats the code it sits on: 4 of its 5 words (max, server, version, local) are already in `return serverVersions.Max() > local;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:539 — "Report: update started" repeats the code it sits on: 3 of its 3 words (report, update, started) are already in `await SafeReportUpdateStartedAsync(hooksCtx).ConfigureAwait(false);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Core/Strategy/ClientStrategy.cs:547 — "Check failed version" repeats the code it sits on: 3 of its 3 words (check, failed, version) are already in `if (!string.IsNullOrEmpty(_configInfo.LastVersion) && CheckFail(_configInfo.LastVersion))`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Differential/Differ/BsdiffDiffer.cs:295 — "Read lengths from header" repeats the code it sits on: 3 of its 3 words (read, lengths, header) are already in `controlLength = ReadInt64(header, 8);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:272 — "The region [newPos - backwardLen, newPos) is the diff region" repeats the code it sits on: 5 of its 6 words (new, pos, backward, len, diff) are already in `int diffStart = newPos - backwardLen;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:302 — "Write diff bytes (lenf bytes)" repeats the code it sits on: 4 of its 4 words (write, diff, bytes, lenf) are already in `WriteBuffered(newBytes, diffStart, lenf, oldBytes, diffOldRef, diffStream, writeBuf);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Differential/Differ/StreamingHdiffDiffer.cs:309 — "Write extra bytes" repeats the code it sits on: 3 of its 3 words (write, extra, bytes) are already in `WriteBufferedRaw(newBytes, extraStart, extraLen, extraStream, writeBuf);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:336 — "Compute file hash" repeats the code it sits on: 3 of its 3 words (compute, file, hash) are already in `driverInfo.Hash = await HashValidator.ComputeHashAsync(filePath, "SHA256", cancellationToken);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs:90 — "Backup existing target file if it exists" repeats the code it sits on: 4 of its 5 words (existing, target, file, exists) are already in `if (File.Exists(targetPath))`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:274 — "Compute file hash" repeats the code it sits on: 3 of its 3 words (compute, file, hash) are already in `driverInfo.Hash = await HashValidator.ComputeHashAsync(filePath, "SHA256", cancellationToken);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs:278 — "Extract signature info" repeats the code it sits on: 3 of its 3 words (extract, signature, info) are already in `ExtractSignatureInfo(filePath, driverInfo);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/GeneralUpdate.Extension/Core/GeneralExtensionHost.cs:97 — 7 comments in this file only repeat the code they sit on (lines 97, 130, 227, 389, 395, 402, 470), for example "Load installed extensions". Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/CoreTest/FileSystem/FileNodeTests.cs:209 — "── GetHashCode ──" repeats the code it sits on: 3 of its 3 words (get, hash, code) are already in `[Fact]`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/CoreTest/Shared/UpdateRequestBuilderTests.cs:822 — "Write test config file" repeats the code it sits on: 4 of its 4 words (write, test, config, file) are already in `File.WriteAllText(configFilePath, System.Text.Json.JsonSerializer.Serialize(testConfig));`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/CoreTest/Shared/UpdateRequestBuilderTests.cs:883 — "Arrange - Create an invalid config file" repeats the code it sits on: 4 of its 5 words (create, invalid, config, file) are already in `var configFilePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "update_config.json");`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/CoreTest/Shared/UpdateRequestBuilderTests.cs:888 — "Write invalid JSON" repeats the code it sits on: 3 of its 3 words (write, invalid, json) are already in `File.WriteAllText(configFilePath, "{ invalid json content !!!");`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/DifferentialTest/ComprehensiveDifferentialTests.cs:859 — "Assert: plug.dll is at app / plugins / plug.dll" repeats the code it sits on: 5 of its 5 words (assert, plug, dll, app, plugins) are already in `Assert.True(File.Exists(Path.Combine(app, "plugins", "plug.dll")));`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/ExtensionTest/RefactorSecurityAndArchitectureTests.cs:281 — "Arrange: valid and invalid versions mixed" repeats the code it sits on: 4 of its 5 words (valid, invalid, versions, mixed) are already in `var checker = new VersionCompatibilityChecker();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment tests/ExtensionTest/RefactorSecurityAndArchitectureTests.cs:489 — "PlatformMatcher with custom IPlatformServices for testing" repeats the code it sits on: 4 of its 5 words (platform, matcher, custom, services) are already in `var customServices = new CustomPlatformServices();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
X10 · Duplicated predicate · Duplicated predicate · ×10
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:74 — `!TryParse(a, out var parsedA) || !TryParse(b, out var parsedB)` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:33 — `!string.IsNullOrEmpty(backupDir) && !Directory.Exists(backupDir)` appears character-identically in 3 files — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs, src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs, src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs:75 — `!string.IsNullOrEmpty(targetDir) && !Directory.Exists(targetDir)` appears character-identically in 2 files — src/GeneralUpdate.Drivelution/Linux/Implementation/LinuxDriverBackup.cs, src/GeneralUpdate.Drivelution/Windows/Implementation/WindowsDriverBackup.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:283 — `Major == other.Major && Minor == other.Minor && Patch == other.Patch && string.Equals(PreRelease, other.PreRelease, StringComparison.Ordinal…` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Strategy/LinuxStrategy.cs:72 — `_configinfo.PatchEnabled == true && packageType != (int)PackageType.Full` appears character-identically in 3 files — src/GeneralUpdate.Core/Strategy/LinuxStrategy.cs, src/GeneralUpdate.Core/Strategy/MacStrategy.cs, src/GeneralUpdate.Core/Strategy/WindowsStrategy.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:292 — `obj is SemVersion other && Equals(other)` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:164 — `part.Length > 1 && part[0] == '0' && part.All(c => c >= '0' && c <= '9')` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:70 — `string.IsNullOrWhiteSpace(a) && string.IsNullOrWhiteSpace(b)` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs:39 — `today == _currentLogDate && _fileListener != null` appears character-identically in 4 files — src/GeneralUpdate.Bowl/Tracer/GeneralTracer.cs, src/GeneralUpdate.Core/Tracer/GeneralTracer.cs, src/GeneralUpdate.Drivelution/Tracer/GeneralTracer.cs, src/GeneralUpdate.Extension/Tracer/GeneralTracer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/GeneralUpdate.Core/Utilities/Semver.cs:183 — `token.Length == 10 && token.CompareTo("2147483647") > 0` appears character-identically in 3 files — src/GeneralUpdate.Core/Utilities/Semver.cs, src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs, src/GeneralUpdate.Extension/Utilities/Semver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
X7 · Silent fallback defaults · Silent fallback default in catch · ×8
  • Silent fallback default in catch REDACTED:173 — `IsProcdumpInPath` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Core/Configuration/UpdateRequestBuilder.cs:210 — `LoadFromConfigFile` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs:49 — `IsRoot` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/Linux/Helpers/LinuxPermissionHelper.cs:84 — `CanUseSudoAsync` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/MacOS/Helpers/MacOSPermissionHelper.cs:28 — `IsRoot` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:378 — `ParseKextVersionAsync` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsPermissionHelper.cs:34 — `IsAdministrator` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/GeneralUpdate.Drivelution/Windows/Helpers/WindowsSignatureHelper.cs:132 — `IsFileSigned` swallows `System.Security.Cryptography.CryptographicException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×4
  • Silent fallback default on parse failure src/GeneralUpdate.Core/Utilities/Semver.cs:129 — `Normalize` falls back to `string.Empty` when `match.Groups[4].Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/GeneralUpdate.Drivelution/Core/Utilities/Semver.cs:129 — `Normalize` falls back to `string.Empty` when `match.Groups[4].Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/GeneralUpdate.Extension/Compatibility/VersionCompatibilityChecker.cs:32 — `IsCompatible` returns `false` when `Semver.TryParse(hostVersion, out var host)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/GeneralUpdate.Extension/Utilities/Semver.cs:129 — `Normalize` falls back to `string.Empty` when `match.Groups[4].Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
D10 · Test Quality · Mock-dominated test · ×2
  • Mock-dominated test: Constructor_ShouldLoadInstalledExtensions tests/ExtensionTest/GeneralExtensionHostTests.cs:169 — This test sets up 6 test doubles (for example `new Mock<IExtensionHttpClient>()`) against 1 real object(s) of its own, and its only verification is 1 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
  • Mock-dominated test: IsExtensionCompatible_ShouldCallCompatibilityChecker tests/ExtensionTest/GeneralExtensionHostTests.cs:233 — This test sets up 6 test doubles (for example `new Mock<IExtensionHttpClient>()`) against 2 real object(s) of its own, and its only verification is 1 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
X6 · Hand-rolled structured-format parsing · Hand-rolled JSON/XML parsing via string slicing · ×2
  • Hand-rolled JSON/XML parsing via string slicing src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:370 — A JSON key or XML tag is located in the text with IndexOf/Split and the value cut out around it — a reordered, re-spaced or differently-typed document (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
  • Hand-rolled JSON/XML parsing via string slicing src/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs:373 — A JSON key or XML tag is located in the text with IndexOf/Split and the value cut out around it — a reordered, re-spaced or differently-typed document (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. .NET ships a real parser for it (System.Text.Json, System.Xml.Linq); use it here.
D19 · Documentation Quality · Documentation · ×1
  • Documentation: no map of the repository's parts README.md:1 — The repository has 5 units (`GeneralUpdate.Bowl`, `GeneralUpdate.Core`, `GeneralUpdate.Differential`, `GeneralUpdate.Drivelution`, `GeneralUpdate.Extension`); `README.md` and the documents it links name none of them. Add a short list of the parts and what each does.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion REDACTED:1 — `GeneralUpdate.Core(netstandard2.0)` overshoots its size bounds (15185 LoC, 153 public types across 29 namespaces). 1 of 12 project(s) overshoot their size bounds, lowering Project Cohesion to 8.3/10. Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P12 · CI test-gate honesty · Sleep-based test synchronization · ×1
  • Sleep-based test synchronization — 7 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST REDACTED:6 — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation tests/Directory.Packages.props:6 — `tests/Directory.Packages.props` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 86/154 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X5 · Nullable reference types · Null-forgiving operator (`!`) suppressions override nullable warnings · ×1
  • Null-forgiving operator (`!`) suppressions override nullable warnings — ~0.4 `!` suppressions per 1k syntax nodes — 39 suppression(s) across the 106234 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
X7 · Silent fallback defaults · Silent fallback default on unknown code · ×1
  • Silent fallback default on unknown code REDACTED:571 — `ParseFormat` maps every unrecognised code to `Format.Zip`, one of the real values, with no log or throw — a malformed or new code silently reads as a known one. Throw on the unknown code, or log it. If that member is the correct answer for any other code, say so in a comment on the member and the row stops firing.
X9 · Subsumed condition operand · Subsumed condition operand · ×1
  • Subsumed condition operand src/GeneralUpdate.Differential/Binary/BZip2OutputStream.cs:651 — `num >= 32768` can never decide this `||` — every value satisfying `num >= 32768` also satisfies `num > 18002`, so the `||` chain is already decided by the latter. The expression is equivalent to the chain without it, which means it is wider than it reads. Delete the dead operand, or narrow the surviving one if IT is the accident.
Minor — 10 finding(s)
D10 · Test Quality · Mock framework · ×5
  • Mock framework: Moq — BowlTest references Moq.
  • Mock framework: Moq — CoreTest references Moq.
  • Mock framework: Moq — DifferentialTest references Moq.
  • Mock framework: Moq — DrivelutionTest references Moq.
  • Mock framework: Moq — ExtensionTest references Moq.
D24 · Comment Value · doc comments repeat the names · ×4
  • doc comments repeat the names src/GeneralUpdate.Bowl/Internal/Crash.cs:23 — 0 of 15 documented parameters and 1 of 65 summaries in `GeneralUpdate.Bowl(netstandard2.0)` only repeat the member or parameter name (e.g. "Dump file name." for `DumpFileName`). 1 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names src/GeneralUpdate.Core/FileSystem/BlackMatcher.cs:92 — 2 of 523 documented parameters and 0 of 739 summaries in `GeneralUpdate.Core(netstandard2.0)` only repeat the member or parameter name (e.g. "The directory name." for `directoryName`). 7 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names src/GeneralUpdate.Drivelution/Abstractions/IGeneralDrivelution.cs:16 — 19 of 70 documented parameters and 6 of 137 summaries in `GeneralUpdate.Drivelution` only repeat the member or parameter name (e.g. "Cancellation token" for `cancellationToken`). 1 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names src/GeneralUpdate.Extension/Catalog/IExtensionCatalog.cs:23 — 25 of 93 documented parameters and 21 of 227 summaries in `GeneralUpdate.Extension` only repeat the member or parameter name (e.g. "Get all installed extensions" for `GetInstalledExtensions`). 1 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
D10 · Test Quality · Skipped (documented) · ×1
  • Skipped (documented): UpdateAsync_WithTimeout_ReportsTimeout tests/DrivelutionTest/Pipeline/BaseDriverUpdaterTests.cs:89 — Skipped with a documented reason — a deferral, not lazy debt: Flaky on CI — unrelated to current changes. Runs correctly in local dev.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-dda31e3de58349fe8031a93ed6ecb62b/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-dda31e3de58349fe8031a93ed6ecb62b/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=350" --report-format json --report-path /tmp/watchdog-gitleaks-dda31e3de58349fe8031a93ed6ecb62b/history-2.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-dda31e3de58349fe8031a93ed6ecb62b/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .19artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesdotnet—dotnet list src/GeneralUpdate.slnx package --vulnerable --include-transitive --format json3artifacts/raw/dotnet-vulnerable.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 17 file(s) — `src/GeneralUpdate.Bowl/Internal/CrashJsonContext.cs`, `src/GeneralUpdate.Core/Configuration/VersionRespDTO.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadCompletedEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/MultiDownloadStatisticsEventArgs.cs`, `src/GeneralUpdate.Core/Download/MultiEventArgs/UpdateInfoEventArgs.cs`, … (+12 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-2328d6d6d96f4eceaad6b913b3b4f95a0artifacts/raw/osv-scanner.json

Run 01a1e864-01cc-7dcc-9dc1-faaaf5a7c83e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Appendix C — Personal-data map

Every field, property and record parameter whose name is conventional personal data — 3 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.

Name — 3 field(s)
  • VersionEntry.FallbackFullName src/GeneralUpdate.Core/Configuration/VersionEntry.cs:195
  • DownloadAsset.FallbackFullName src/GeneralUpdate.Core/Download/Models/DownloadAsset.cs:15
  • FileNode.FullName src/GeneralUpdate.Core/FileSystem/FileNode.cs:43

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md